Page MenuHomePhabricator
Feed Advanced Search

Today

Legoktm renamed T259402: parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint from vendor/wikimedia/parsoid/src/Utils/Diff.php doesn't pass PHP lint to parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint.
Mon, Aug 3, 7:32 AM · MediaWiki-Debian, MW-1.35-release, Parsoid
Legoktm merged T259449: upgrade 1.34.2 to 1.35.0-rc.0 fails into T259402: parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint.
Mon, Aug 3, 7:31 AM · MediaWiki-Debian, MW-1.35-release, Parsoid
Legoktm merged task T259449: upgrade 1.34.2 to 1.35.0-rc.0 fails into T259402: parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint.
Mon, Aug 3, 7:31 AM · MW-1.35-release
Legoktm added a comment to T259449: upgrade 1.34.2 to 1.35.0-rc.0 fails.

Indeed, this was a bug in rc.0, has been fixed in git and will be part of rc.1.

Mon, Aug 3, 7:31 AM · MW-1.35-release
Legoktm closed T259402: parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint as Resolved.

Somewhat related: for the next 1.35 RC I'd like to bump parsoid from 0.12.0-a23 to 0.12.0 and make it a proper 'non-alpha' release. We didn't quite manage that before the branch.

Mon, Aug 3, 7:30 AM · MediaWiki-Debian, MW-1.35-release, Parsoid
Legoktm created T259452: Release parsoid 0.12.0 and bump it in REL1_35.
Mon, Aug 3, 7:30 AM · MediaWiki-Vendor, Parsoid, MW-1.35-release

Yesterday

Legoktm added a comment to T220703: Increase the max length of URL to be shortened.

Given the community requests here, I took the liberty to reopen it. Talking to DBAs a while back, there's not much storage issues with url shortener and also as long as the blob is below 4GB (IIRC talking to Jaime) it should be fine. So I suggest increasing it to 5K for now (similar to ResourceLoader).

Sun, Aug 2, 6:15 AM · Patch-For-Review, Security, Wikimedia-Site-requests, MediaWiki-extensions-UrlShortener

Sat, Aug 1

Legoktm closed T259364: Codesearch beta: execute search when navigating through repository links as Resolved.

Should be fixed now - let me know if that doesn't work for you or if you wanted something else.

Sat, Aug 1, 7:38 AM · VPS-project-codesearch
Legoktm closed T259359: Codesearch beta: Avoid sidebar on narrow viewport as Resolved.

Should be fixed now.

Sat, Aug 1, 7:35 AM · VPS-project-codesearch
Legoktm committed rLCSH5d676ffacfaf: frontend: Switch to one column display on smaller devices (authored by Legoktm).
frontend: Switch to one column display on smaller devices
Sat, Aug 1, 7:24 AM
Legoktm committed rLCSH90107c115bbb: frontend: Re-trigger search when switching profiles (authored by Legoktm).
frontend: Re-trigger search when switching profiles
Sat, Aug 1, 7:07 AM
Legoktm triaged T259402: parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint as High priority.

Looks like this was fixed in master but missed a REL1_35 backport.

Sat, Aug 1, 6:24 AM · MediaWiki-Debian, MW-1.35-release, Parsoid
Legoktm added a comment to T257102: Mediawiki 1.34.2 tarball incompatible with 7zip on windows due to Pax format.

Most obvious answer I can see is due to an upgrade to Ubuntu 20.04, and the subsequent upgrade of python... or other libraries?

I know I did it with python3, which I have done for previous releases

$ python3 --version
Python 3.8.2
$ pip3 install git_archive_all
Requirement already satisfied: git_archive_all in ./.local/lib/python3.8/site-packages (1.21.0)
Sat, Aug 1, 5:22 AM · MediaWiki-Releasing
Legoktm created T259402: parsoid in 1.35.0-rc.0 not updated, it includes vendor/wikimedia/parsoid/src/Utils/Diff.php which doesn't pass PHP lint.
Sat, Aug 1, 4:59 AM · MediaWiki-Debian, MW-1.35-release, Parsoid
Legoktm committed rEAMEcb0381e81266: Remove "load_composer_autoloader" from extension.json (authored by Legoktm).
Remove "load_composer_autoloader" from extension.json
Sat, Aug 1, 1:35 AM
Legoktm closed T259398: resources/lib/promise-polyfill/ is missing licensing information as Resolved.

I forgot to tag https://gerrit.wikimedia.org/r/c/mediawiki/core/+/617795 with this bug.

Sat, Aug 1, 1:05 AM · MW-1.35-notes, MediaWiki-Debian, Software-Licensing, MW-1.35-release, MediaWiki-Interface
Legoktm claimed T259398: resources/lib/promise-polyfill/ is missing licensing information.
Sat, Aug 1, 12:06 AM · MW-1.35-notes, MediaWiki-Debian, Software-Licensing, MW-1.35-release, MediaWiki-Interface

Fri, Jul 31

Legoktm created T259398: resources/lib/promise-polyfill/ is missing licensing information.
Fri, Jul 31, 10:39 PM · MW-1.35-notes, MediaWiki-Debian, Software-Licensing, MW-1.35-release, MediaWiki-Interface
Legoktm claimed T259364: Codesearch beta: execute search when navigating through repository links.
Fri, Jul 31, 9:24 PM · VPS-project-codesearch
Legoktm updated subscribers of T259359: Codesearch beta: Avoid sidebar on narrow viewport.

@cscott noticed this too.

Fri, Jul 31, 9:22 PM · VPS-project-codesearch
Legoktm added a comment to T188731: preserve search query when navigating to different silos.

This is fixed in the new beta codesearch UI.

Fri, Jul 31, 8:32 AM · VPS-project-codesearch
Legoktm added a comment to T196902: Recommendation for browser search engine pattern.

This was fixed upstream (https://github.com/hound-search/hound/pull/321) but we're not currently pulling upstream updates because their docker build is broken..

Fri, Jul 31, 8:31 AM · Upstream, VPS-project-codesearch
Legoktm added a comment to T197801: Make codesearch results collapsible.

I implemented something similar to this in the new beta frontend, does that address what you're looking for?

Fri, Jul 31, 6:18 AM · Upstream, VPS-project-codesearch
Legoktm added a comment to T259311: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMDataUtils::getDataMw() must be an instance of DOMElement.

To do (help appreciated): isolate a minimal test case from the above crash, land the patch, branch v0.13.0-a2 and cherry-pick the patch, rt-test the branch, release v0.13.0-a3 on the branch, write a mediawiki-vendor patch for wmf.2 which bumps to v0.13.0-a3.

Fri, Jul 31, 12:31 AM · Parsing-Active-Work, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Patch-For-Review, User-brennen, Parsoid, Wikimedia-production-error

Thu, Jul 30

Legoktm committed rLCSHd40f0fefc793: frontend: Don't copy in Cargo.lock (authored by Legoktm).
frontend: Don't copy in Cargo.lock
Thu, Jul 30, 1:34 PM
Legoktm added a comment to T259109: mwext-codehealth-master-non-voting erase doc.wikimedia.org coverage report.

Why is a "non-voting" job running in postmerge? Seems like it makes more sense to have the normal phpunit-coverage job take care of publishing since it's already working and let codehealth just do whatever it needs and not publish.

Thu, Jul 30, 11:43 AM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), Continuous-Integration-Config, User-DannyS712

Wed, Jul 29

Legoktm added a comment to T259126: Warning: Locally stored wiki page has unsupported content model (from JsonConfig).

@Mholloway how does ^ look? I didn't test it. I think it's smaller and fits the expectations by ContentHandlerFactory (though I do think the core change might need to be re-evaluated).

Wed, Jul 29, 10:21 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, JsonConfig, MediaWiki-extensions-Scribunto, Wikimedia-production-error
Legoktm added a comment to T259126: Warning: Locally stored wiki page has unsupported content model (from JsonConfig).

Maybe JsonConfig should implement the GetContentModels hook? That would ensure ContentHandlerFactory::isDefinedModel() returns true.

Wed, Jul 29, 10:11 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, JsonConfig, MediaWiki-extensions-Scribunto, Wikimedia-production-error
Legoktm added a comment to T259126: Warning: Locally stored wiki page has unsupported content model (from JsonConfig).

I believe this was triggered by this change: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/a67cad6d0fc5b6a2aab08e5dd9b0391202ea3e9b

JsonConfig doesn't (yet) register its content handlers in extension.json, but rather handles them in a hook handler for ContentHandlerForModelID. As such, its content models aren't known to the ContentHandlerFactory. Previously, RevisionStore::loadSlotContent() would call ContentHandlerFactory::getContentHandler() without first checking if the content model was known, ContentHandlerFactory would first attempt to look up the handler from the known specs and fail, and it would then run the ContentHandlerForModelID hook, where JsonConfig would return the correct handler. Now, the new check short-circuits the hook used by ContentHandlerFactory as a fallback and instead returns a FallbackContent object for unregistered content models; and the error here is triggered when JsonConfig encounters a FallbackContent object, which isn't an instance of JCContent.

I think there's probably some work to be done to harmonize the new check with the behavior of ContentHandlerFactory (and maybe this wasn't the only extension relying on the fallback behavior?) but I think the easiest path forward to unbreak this is to update JsonConfig to register its content handlers in extension.json.

Wed, Jul 29, 9:36 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Product-Infrastructure-Team-Backlog (Kanban), Patch-For-Review, JsonConfig, MediaWiki-extensions-Scribunto, Wikimedia-production-error
Legoktm added a comment to T258845: RFC: Stop supporting legacy PHP entry point extensions.

If I understand correctly the main "problem" we want to solve is:
<snip>

Wed, Jul 29, 9:13 PM · MediaWiki-Configuration, TechCom-RFC
Legoktm added a comment to T259109: mwext-codehealth-master-non-voting erase doc.wikimedia.org coverage report.

The HTML coverage was there sometimes I loaded the page, but often the CSS would fail to load. And then everything would vanish as well.

Wed, Jul 29, 7:56 PM · Patch-For-Review, Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1))), Continuous-Integration-Config, User-DannyS712
Legoktm created T259191: Update VisualEditor documentation for Parsoid-PHP loopback configuration.
Wed, Jul 29, 7:53 PM · Parsoid, VisualEditor, Documentation, MW-1.35-release
Legoktm updated the task description for T259129: Write release announcement for 1.35.0-rc.0.
Wed, Jul 29, 7:49 PM · MW-1.35-release, MediaWiki-Releasing, Release
Legoktm added a project to T259098: Wikibase labels: localize parenthesis: I18n.
Wed, Jul 29, 7:10 AM · I18n, User-DannyS712, MediaWiki-extensions-GlobalWatchlist
Legoktm closed T257278: Command::restrict( Shell::RESTRICT_NONE ) doesn't actually work as Resolved.

Sorry, I forgot to reply earlier.

Wed, Jul 29, 5:24 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Platform Engineering, MediaWiki-Shell
Legoktm added a project to T138727: Global modules are not loaded on mobile: User-notice.

For Tech News: Users' global.js and global.css pages will now also be loaded on the mobile site. Refer to the documentation for how to avoid applying styles to the mobile skin.

Wed, Jul 29, 1:14 AM · User-notice, GlobalCssJs
Legoktm claimed T259047: ext.globalCssJs.user and ext.globalCssJs.user.styles are silently being removed from page via targets system.
Wed, Jul 29, 1:05 AM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MobileFrontend (Tracking), GlobalCssJs
Legoktm removed a project from T230256: Some abuse filters stopped matching after empty data introduction: MW-1.35-release.
Wed, Jul 29, 12:32 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, User-notice, AbuseFilter
Legoktm removed a project from T247196: Wikibase property names are missing when renders: MW-1.35-release.

It looks like all of this is in Wikibase, so I'm removing as a 1.35 blocker.

Wed, Jul 29, 12:32 AM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, User-Ladsgroup, Regression, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
Legoktm edited projects for T218207: Use disk-based LCStore by default in MediaWiki 1.36, added: MW-1.36-release; removed MW-1.35-release.

Bumping again, doesn't seem like enough progress has been made yet.

Wed, Jul 29, 12:26 AM · MW-1.36-release, Platform Engineering, Performance-Team (Radar), MediaWiki-Internationalization

Tue, Jul 28

Legoktm added a comment to T257218: Use WMF Gerrit's logo as favicon.

...I'll be bold and switch our Gerrit favicon to a picture of my grinning face :-) ... or something similar).

Tue, Jul 28, 8:29 PM · Patch-For-Review, Gerrit
Legoktm added a comment to T259047: ext.globalCssJs.user and ext.globalCssJs.user.styles are silently being removed from page via targets system.

Is the user module loaded on mobile? This is basically the global equivalent of that and should be treated the same.

Tue, Jul 28, 7:32 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MobileFrontend (Tracking), GlobalCssJs
Legoktm updated subscribers of T226857: Provide capability for a DB to be added in an extension.

@Krinkle and I discussed this on IRC today (and a bit in Gerrit). I think both of us are concerned with trying to backport such a large feature into REL1_35 this late. Back in 2015 I thought this project had a large enough scope that it was RfC-worthy. From my perspecitve I think there are some unresolved questions/issues, like what extensions should do if they encounter a non-supported db type (some throw an exception, others will assume it's MySQL-compatible, probably causing other failures). How do database extension developers support extensions that don't want to be compatible and carry their schemas (see $wgResourceModuleSkinStyles which allowed non-core skins to support extensions without requiring extension changes). I also think we need more insight on how this will integrate with the abstract schema project, when a lot of these concerns will go away (though this may be needed before that project is completed).

Tue, Jul 28, 6:57 AM · Story, Platform Team Workboards (S&F Workboard), Patch-For-Review, MediaWiki-Installer
Legoktm added a comment to T244864: web installer / upgrade doesn't seem to recognize extension.json configuration or overrides to that configuration.

This is on purpose. The only thing loaded during the web installer are classes for autoloading and the schema update hook itself (and then any maintenance that needs to run). Configuration is explicitly not loaded. The expectation is that the schema is universal regardless of configuration.

Tue, Jul 28, 5:04 AM · Platform Engineering (Icebox), MediaWiki-Stakeholders-Group, Release-Engineering-Team, MediaWiki-Installer

Mon, Jul 27

Legoktm added a comment to T252244: CentralAuth extension: Code stewardship review.

5 years and two days ago I outlined my incredibly simple plan to get rid of CentralAuth: https://www.mediawiki.org/wiki/User:Legoktm/evil-plans2.txt (loosely inspired by I believe brion's original evil-plans.txt).

Mon, Jul 27, 10:37 PM · MediaWiki-extensions-CentralAuth, Code-Stewardship-Reviews
Legoktm added a comment to T258493: [Bug] "Use Legacy Vector" is not working as a global preference.

I think T246491: Special:GlobalPreferences does not deal well with "conditional preferences" (using hide-if) is the root cause for this.

Mon, Jul 27, 10:10 PM · User-notice, Community-Tech, MediaWiki-extensions-GlobalPreferences, Readers-Web-Backlog (Kanbanana-2020-21-Q1), Desktop Improvements
Legoktm added a comment to T90475: If a global user page is marked with __NOINDEX__ the same should be applied to the local copies.

Please provide an example. GlobalUserPage should have no impact on the indexing status of pages from Meta.

My fr.wikisource user page, included from Meta, was in Google's first page before I requested deletion.

Mon, Jul 27, 9:59 PM · Privacy, GlobalUserPage
Legoktm added a comment to T90475: If a global user page is marked with __NOINDEX__ the same should be applied to the local copies.

Has this bug with "High" priority been really opened for more than 5 years and still nothing changed?

Mon, Jul 27, 8:36 PM · Privacy, GlobalUserPage
Legoktm added a comment to T177159: Avoid indexing of local "copies" of the central user page.

https://www.google.com/search?q=%22you+see+on+this+page+was+copied+from%22&hl=en&filter=0&biw=2560&bih=1311 still has some results, but the few I checked out all have <meta name="robots" content="noindex,nofollow"/> set.

Mon, Jul 27, 8:32 PM · MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), GlobalUserPage
Legoktm added a comment to T91154: {{=}} should be a parser function.

Can you and/or @cscott consider the upgrade script for non-WMF wikis?

Mon, Jul 27, 11:12 AM · Patch-For-Review, MediaWiki-Installer, MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), MediaWiki-Page-editing, User-notice, MediaWiki-Parser
Jdforrester-WMF awarded T258845: RFC: Stop supporting legacy PHP entry point extensions a Like token.
Mon, Jul 27, 10:01 AM · MediaWiki-Configuration, TechCom-RFC

Sun, Jul 26

Legoktm committed rLCSHf907bcfce910: Set CORS header on config.json endpoint (authored by Legoktm).
Set CORS header on config.json endpoint
Sun, Jul 26, 6:01 AM
Legoktm committed rLCSH9e1a2d745b50: Expose hound config.json (authored by Legoktm).
Expose hound config.json
Sun, Jul 26, 5:03 AM
Legoktm added a project to T226857: Provide capability for a DB to be added in an extension: MW-1.35-release.
Sun, Jul 26, 4:43 AM · Story, Platform Team Workboards (S&F Workboard), Patch-For-Review, MediaWiki-Installer
Legoktm added a comment to T258844: Make the web installer work without running any extension PHP code.

I posted a more detailed proposal on that task which would allow us to move in that direction.

Sun, Jul 26, 4:33 AM · MediaWiki-Installer
Legoktm updated subscribers of T258852: Replace LoadExtensionSchemaUpdates hook with static data in extension.json.

Probably a good time to disentangle installation from upgrade a bit? Installation only requires a predefined SQL schema 99% of the time; it would be easy to require extensions which want to be part of a tarball bundle, so they can be enabled at install time, to provide a static schema. The very few extensions that can't would still be possible to enable via the updater.

Sun, Jul 26, 4:31 AM · MediaWiki-Installer, MediaWiki-Core-Hooks, MediaWiki-Configuration
Legoktm added a comment to T258852: Replace LoadExtensionSchemaUpdates hook with static data in extension.json.

Quick survey of the most popular extensions (I might need to look broader as this didn't contain as many extensions with database tables as I thought it would):

Sun, Jul 26, 4:23 AM · MediaWiki-Installer, MediaWiki-Core-Hooks, MediaWiki-Configuration
Legoktm added a comment to T258844: Make the web installer work without running any extension PHP code.

In terms of database schema, there isn't actually any concept of "installation", it's always treated as updates. I do think as part of T258852: Replace LoadExtensionSchemaUpdates hook with static data in extension.json we could implement that split - we have one declared schema definition, on install we run that, and then on updates we iterate through all the updates.

Sun, Jul 26, 2:17 AM · MediaWiki-Installer
Legoktm added a project to T258877: MediaWiki sets invalid Content-Encoding: none: MediaWiki-General.
Sun, Jul 26, 1:59 AM · Patch-For-Review, MediaWiki-General

Sat, Jul 25

Legoktm removed a parent task for T234732: Add an on/off switch for project administrators to temporally disable MediaWiki extensions: T388: Graphical configuration interface.
Sat, Jul 25, 4:36 AM · Wikimedia-Site-requests
Legoktm removed a subtask for T388: Graphical configuration interface: T234732: Add an on/off switch for project administrators to temporally disable MediaWiki extensions.
Sat, Jul 25, 4:36 AM · Platform Engineering (Icebox), MediaWiki-Configuration
Legoktm edited projects for T234732: Add an on/off switch for project administrators to temporally disable MediaWiki extensions, added: Wikimedia-Site-requests; removed MediaWiki-Configuration.
Sat, Jul 25, 4:36 AM · Wikimedia-Site-requests
Legoktm closed T234732: Add an on/off switch for project administrators to temporally disable MediaWiki extensions, a subtask of T388: Graphical configuration interface, as Declined.
Sat, Jul 25, 4:36 AM · Platform Engineering (Icebox), MediaWiki-Configuration
Legoktm closed T234732: Add an on/off switch for project administrators to temporally disable MediaWiki extensions as Declined.

Gotcha. Unfortunately allowing administrators to toggle extensions on/off is a security risk (imagine if a rogue admin disabled CheckUser) and won't ever be enabled on Wikimedia sites. I would recommend using test.wikipedia.org to test modifications to the configuration of those extensions or asking for help on a forum like m:Tech.

Sat, Jul 25, 4:36 AM · Wikimedia-Site-requests
Legoktm updated the task description for T258851: New hook system not compatible with how the web installer expects LoadExtensionSchemaUpdates to work.
Sat, Jul 25, 1:28 AM · MediaWiki-Installer, MediaWiki-Core-Hooks
Legoktm added a parent task for T258852: Replace LoadExtensionSchemaUpdates hook with static data in extension.json: T258844: Make the web installer work without running any extension PHP code.
Sat, Jul 25, 1:28 AM · MediaWiki-Installer, MediaWiki-Core-Hooks, MediaWiki-Configuration
Legoktm added a subtask for T258844: Make the web installer work without running any extension PHP code: T258852: Replace LoadExtensionSchemaUpdates hook with static data in extension.json.
Sat, Jul 25, 1:28 AM · MediaWiki-Installer
Legoktm created T258852: Replace LoadExtensionSchemaUpdates hook with static data in extension.json.
Sat, Jul 25, 1:27 AM · MediaWiki-Installer, MediaWiki-Core-Hooks, MediaWiki-Configuration
Legoktm created T258851: New hook system not compatible with how the web installer expects LoadExtensionSchemaUpdates to work.
Sat, Jul 25, 1:06 AM · MediaWiki-Installer, MediaWiki-Core-Hooks
Legoktm added a comment to T258658: Migrate Wikibase Settings to mediawiki config handler.

class WikibaseGlobalArrayConfig {
public static function factory() {

global $wgWBRepoSettings;
return new self ( $wgWBRepoSettings );

}

Sat, Jul 25, 12:50 AM · MediaWiki-Configuration, Wikidata

Fri, Jul 24

Legoktm closed T212489: Update extensions to specify platform requirements as Resolved.

Based on https://codesearch.wmcloud.org/things/?q=extension_loaded&i=nope&files=&repos= I don't think there's anything left to do here

Fri, Jul 24, 11:29 PM · MediaWiki-extensions-General, MediaWiki-Configuration
Legoktm moved T212489: Update extensions to specify platform requirements from Backlog to In Progress on the MediaWiki-Configuration board.
Fri, Jul 24, 11:25 PM · MediaWiki-extensions-General, MediaWiki-Configuration
Legoktm removed a project from T35488: Defining namespaces in SearchableNamespaces is double work: MediaWiki-Configuration.
Fri, Jul 24, 11:24 PM · good first task, Discovery-Search, MediaWiki-Search
Legoktm added a comment to T234732: Add an on/off switch for project administrators to temporally disable MediaWiki extensions.

@Klein are you asking for this functionality on Wikimedia sites or on a MediaWiki instance you operate?

Fri, Jul 24, 11:22 PM · Wikimedia-Site-requests
Legoktm moved T240535: Clean up ExtensionRegistry autoloading mess from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 11:18 PM · Technical-Debt, MediaWiki-Core-Testing, MediaWiki-Configuration
Legoktm closed T243213: Allow extensions to register handlers with factories without the use of global variables as Declined.

@daniel, have you already reviewed the "attributes" functionality of extension.json and found it to be insufficient? Either I'm not understanding what you're looking for, or you're describing functionality that is already implemented.

Fri, Jul 24, 11:18 PM · User-Daniel, TechCom, Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-ServiceContainer, MediaWiki-Configuration
Legoktm moved T243276: Add 'actor' to default $wgSharedTables from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 11:13 PM · MW-1.35-release, MediaWiki-User-management, MediaWiki-Configuration
Legoktm added a project to T243276: Add 'actor' to default $wgSharedTables: MW-1.35-release.

At this point I think we should do this now so we don't continue to keep creating misconfigured wikis with a warning that people upgrading will need to remove it until we have the maintenance script.

Fri, Jul 24, 11:13 PM · MW-1.35-release, MediaWiki-User-management, MediaWiki-Configuration
Legoktm removed a project from T243722: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions: MediaWiki-Configuration.
Fri, Jul 24, 11:12 PM · MediaWiki-Special-pages, JavaScript
Legoktm moved T245293: Remove $wgAllowImageMoving from Backlog to In Progress on the MediaWiki-Configuration board.
Fri, Jul 24, 11:11 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), MediaWiki-Configuration, Technical-Debt (Deprecation process), User-DannyS712
Legoktm changed the status of T245293: Remove $wgAllowImageMoving from Stalled to Open.

IIRC this was a feature flag from back when image moving was unstable but that's no longer the case.

Fri, Jul 24, 11:10 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), MediaWiki-Configuration, Technical-Debt (Deprecation process), User-DannyS712
Legoktm moved T248866: Consider having a linter that could catch config file entries that set unused variables from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 11:08 PM · Patch-For-Review, MediaWiki-Stakeholders-Group, Wikidata, Sustainability (Incident Followup), Continuous-Integration-Config, MediaWiki-Configuration
Legoktm added a comment to T248866: Consider having a linter that could catch config file entries that set unused variables.

In theory you can get every possible config option by reading through extension.json and DefaultSettings.php. But we often stage new config settings before deployment, so the proposed linter would need to be able to work around that.

Fri, Jul 24, 11:08 PM · Patch-For-Review, MediaWiki-Stakeholders-Group, Wikidata, Sustainability (Incident Followup), Continuous-Integration-Config, MediaWiki-Configuration
Legoktm closed T247629: NS_MODULE not defined in LocalSettings.php as Declined.

This is intentional as a side-effect of the extension.json migration. There is some loss of functionality, I admit that NS_MODULE can't be used in LocalSettings.php which was nice for readability. There is a plus side though, that extension namespace numbers are no longer hardcoded (e.g. doing define( 'NS_MODULE', 123 ); changes the internal NS number for Scribunto).

Fri, Jul 24, 11:02 PM · MediaWiki-Configuration, MediaWiki-extensions-Scribunto
Legoktm moved T249380: RfC: Per namespace view restrictions from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:57 PM · MediaWiki-Stakeholders-Group, MediaWiki-User-management, MediaWiki-Configuration, TechCom-RFC, Developer-Wishlist (2017), User-DannyS712, MediaWiki-Page-protection, Proposal, MediaWiki-General
Legoktm moved T249401: New configuration setting for user rights to create pages in a specific namespace from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:57 PM · MediaWiki-Configuration, MediaWiki-Page-protection
Legoktm added a comment to T249401: New configuration setting for user rights to create pages in a specific namespace.

In general +1 to the concept, I think there's enough demonstrated usage that it makes sense to implement this properly in core.

Fri, Jul 24, 10:56 PM · MediaWiki-Configuration, MediaWiki-Page-protection
Legoktm moved T249564: Determine purpose of GlobalVarConfig-backend entries in ConfigFactory (via wgConfigRegistry) from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:54 PM · Platform Engineering, MediaWiki-Configuration, Wikimedia-General-or-Unknown
Legoktm added a comment to T249564: Determine purpose of GlobalVarConfig-backend entries in ConfigFactory (via wgConfigRegistry).

The intention was that each extension would only its own config instance and eventually once the extension was switched to using Config we'd switch it away from GlobalVarConfig to....something else that was never built.

Fri, Jul 24, 10:54 PM · Platform Engineering, MediaWiki-Configuration, Wikimedia-General-or-Unknown
Legoktm merged T249586: Configurator omits $wgSessionCacheType into T147161: Installer suggests $wgMainCacheType = CACHE_ACCEL, potentially breaking sessions.
Fri, Jul 24, 10:50 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization, MediaWiki-Cache, MediaWiki-Installer
Legoktm merged task T249586: Configurator omits $wgSessionCacheType into T147161: Installer suggests $wgMainCacheType = CACHE_ACCEL, potentially breaking sessions.
Fri, Jul 24, 10:50 PM · MediaWiki-Configuration, MediaWiki-Installer
Legoktm moved T252567: Create and maintain/encourage/enforce a sort order for extension/skin.json from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:50 PM · LibUp, MediaWiki-Configuration
Legoktm moved T256898: Reconsider usage of ServiceOptions from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:50 PM · Patch-For-Review, MediaWiki-Configuration, MediaWiki-ServiceContainer
Legoktm moved T258664: 25% latency regression July 2nd due to InstallerExtensionSelector service running in production from Backlog to In Progress on the MediaWiki-Configuration board.
Fri, Jul 24, 10:50 PM · Performance-Team (Radar), MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), MediaWiki-Configuration, MediaWiki-Installer, Platform Engineering, Wikimedia-Rdbms, Wikimedia-Incident
Legoktm moved T258845: RFC: Stop supporting legacy PHP entry point extensions from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:50 PM · MediaWiki-Configuration, TechCom-RFC
Legoktm moved T258668: Deprecate extension.json's manifest_version 1 format in MediaWiki 1.38 from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:50 PM · MediaWiki-Configuration
Legoktm moved T258658: Migrate Wikibase Settings to mediawiki config handler from Backlog to Planning on the MediaWiki-Configuration board.
Fri, Jul 24, 10:50 PM · MediaWiki-Configuration, Wikidata
Legoktm added a comment to T258658: Migrate Wikibase Settings to mediawiki config handler.

I think in general your plan sounds good, but you can just do it all in Wikibase. Just define the GlobalArrayConfig class in Wikibase, and have the factory function pass $wgWBRepoSettings to the new instance.

Fri, Jul 24, 10:45 PM · MediaWiki-Configuration, Wikidata
Legoktm added a subtask for T258844: Make the web installer work without running any extension PHP code: T258845: RFC: Stop supporting legacy PHP entry point extensions.
Fri, Jul 24, 10:41 PM · MediaWiki-Installer
Legoktm added a parent task for T258845: RFC: Stop supporting legacy PHP entry point extensions: T258844: Make the web installer work without running any extension PHP code.
Fri, Jul 24, 10:41 PM · MediaWiki-Configuration, TechCom-RFC