Hi Strobilomyces, the contents of the document have been ported to metawiki: https://meta.wikimedia.org/wiki/Abstract_Wikipedia/Semantics_of_validation_in_Wikifunctions. I'll update the OP.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Oct 13 2022
Oct 13 2022
Oct 7 2022
Oct 7 2022
Thank you!
Sep 22 2022
Sep 22 2022
Sep 21 2022
Sep 21 2022
• AAssaf added a comment to T317230: Resolve Z18s, Z9s, and Z7s Which Are Not at the Top Level of an Argument.
Note that I think this issue is not depending on the validation strategy (on the contrary, this issue would even be a blocker for a working validation strategy). We can fix and should fix it independently.
Sep 8 2022
Sep 8 2022
Thank you Ori and Cory for looking into this!
Sep 1 2022
Sep 1 2022
Aug 18 2022
Aug 18 2022
• AAssaf added a comment to T315009: Revisit best practices and code support for local & global keys.
As mentioned in today's eng meeting, "Z882K1" should probably not be accepted because the type is a transient type generated by a function. This is also touched up in the doc,
Aug 17 2022
Aug 17 2022
• AAssaf added a comment to T305981: Distinguish Formally between Variable Binding and Value Assignment.
Cory is right, it is very common for dynamically-checked languages to not enforce this.
• AAssaf added a comment to T306447: Refactor Function Signatures in Orchestrator by Encapsulating Invariants.
Cory, do we consider this done with https://gerrit.wikimedia.org/r/c/mediawiki/services/function-orchestrator/+/787836?
Aug 16 2022
Aug 16 2022
• AAssaf added a comment to T315009: Revisit best practices and code support for local & global keys.
This topic also came up while working on scoping in the orchestrator. It turns out there are several different usages of local keys and subtle differences between them. I went ahead and summarized my current understanding in this doc, I hope it will help the team when tackling this subject: https://docs.google.com/document/d/1yGnvukO8hjOP3r7zdCjWNG1mQBQdICHyEQscGjC_rXQ/edit
Aug 15 2022
Aug 15 2022
Noting that by removing the clone, at head there would be only 3 tests failing, because they are expecting the result to be slightly less resolved:
Aug 10 2022
Aug 10 2022
• AAssaf renamed T314926: Generic types are not fully evaluated, wrongly returning errors from Generic function types are not fully evaluated, wrongly returning errors to Generic types are not fully evaluated, wrongly returning errors.
• AAssaf updated the task description for T314926: Generic types are not fully evaluated, wrongly returning errors.
• AAssaf updated the task description for T314926: Generic types are not fully evaluated, wrongly returning errors.
• AAssaf updated the task description for T314926: Generic types are not fully evaluated, wrongly returning errors.
• AAssaf updated subscribers of T314926: Generic types are not fully evaluated, wrongly returning errors.
Aug 8 2022
Aug 8 2022
• AAssaf added a comment to T309038: Getting wrong result for if(empty string("x"), "a", if(empty string(""), "b", "c")).
I confirm that this works now, maybe due to fixing https://phabricator.wikimedia.org/T309195.
Aug 5 2022
Aug 5 2022
• AAssaf edited subtasks for T309038: Getting wrong result for if(empty string("x"), "a", if(empty string(""), "b", "c")), added: T306376: In the implementation editor, choosing "arg" in the mode selector empties the field completely and one must choose Argument reference as a type; removed: T312953: Cannot define a function by composition on Booleans in Wikifunctions UX.
• AAssaf added a comment to T312953: Cannot define a function by composition on Booleans in Wikifunctions UX.
Noting that this is not just for booleans, trying to define the empty string function from https://phabricator.wikimedia.org/T309038 also does not work.
I think we can consider this done.
Aug 4 2022
Aug 4 2022
Fix formatting of complex objects.
Aug 3 2022
Aug 3 2022
• AAssaf committed rMTWC64f83500e3c7: Fix formatting of function types by dropping first element of the Benjamin….
Fix formatting of function types by dropping first element of the Benjamin…
Fix indentation in formatting of lambda CLI output.
Add functions for debugging ZWrapper objects.
Aug 2 2022
Aug 2 2022
Actually might not be related to lists migration, but here is an example:
$ lambda --noeval --normal 'if(true, [String, "a", "b"] , [String, "c", "d"])' { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z802" }, "Z802K1": { "Z1K1": "Z9", "Z9K1": "Z41" }, "Z802K2": { "Z1K1": { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z881" }, "Z881K1": { "Z1K1": "Z9", "Z9K1": "Z6" } }, "K1": { "Z1K1": "Z6", "Z6K1": "a" }, "K2": { "Z1K1": { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z881" }, "Z881K1": { "Z1K1": "Z9", "Z9K1": "Z6" } }, "K1": { "Z1K1": "Z6", "Z6K1": "b" }, "K2": { "Z1K1": { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z881" }, "Z881K1": { "Z1K1": "Z9", "Z9K1": "Z6" } } } } }, "Z802K3": { "Z1K1": { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z881" }, "Z881K1": { "Z1K1": "Z9", "Z9K1": "Z6" } }, "K1": { "Z1K1": "Z6", "Z6K1": "c" }, "K2": { "Z1K1": { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z881" }, "Z881K1": { "Z1K1": "Z9", "Z9K1": "Z6" } }, "K1": { "Z1K1": "Z6", "Z6K1": "d" }, "K2": { "Z1K1": { "Z1K1": { "Z1K1": "Z9", "Z9K1": "Z7" }, "Z7K1": { "Z1K1": "Z9", "Z9K1": "Z881" }, "Z881K1": { "Z1K1": "Z9", "Z9K1": "Z6" } } } } } } undefined function: If condition: true then: undefined K1: "a" K2: undefined K1: "b" K2: undefined else: undefined K1: "c" K2: undefined K1: "d" K2: undefined
There are still some undefined that show up due to the typed lists migration that we need to fix.
Jul 19 2022
Jul 19 2022
Jul 18 2022
Jul 18 2022
• AAssaf closed T312211: Test 'map "echo" function to a list of items' is incorrect, a subtask of T309195: Wrong result due to dynamic scoping in function calls, as Resolved.
• AAssaf closed T312227: ZWrapper caching is broken, a subtask of T309195: Wrong result due to dynamic scoping in function calls, as Resolved.
Jul 15 2022
Jul 15 2022
• AAssaf committed rMSFO582f8b579d55: Use scope attached to ZWrapper instead of passing it around everywhere..
Use scope attached to ZWrapper instead of passing it around everywhere.
Jul 14 2022
Jul 14 2022
• AAssaf committed rMSFO447b9bb131b3: Fix ZWrapper caching by storing the result of argument reference resolution..
Fix ZWrapper caching by storing the result of argument reference resolution.
• AAssaf committed rMSFOc089bb11f037: Fix the 'map "echo" function to a list of items' test to not use dynamic….
Fix the 'map "echo" function to a list of items' test to not use dynamic…
Fix scoping in orchestrator.
Repo was moved to https://github.com/wikimedia/mediawiki-tools-wikilambda-cli
Jul 13 2022
Jul 13 2022
Jul 6 2022
Jul 6 2022
• AAssaf committed rMSFO325d569d9214: Do not rely on function call execution when building builtin generic map types..
Do not rely on function call execution when building builtin generic map types.
Log the error in test failures.
Also mentioned with Denny and Ori the idea of bringing it over from Github into the WMF repositories and setting up CI for it to avoid future breakages.
Maybe related: https://phabricator.wikimedia.org/T310995
Some fixes were submitted in https://github.com/vrandezo/lambda-cli/pull/2.
Jul 5 2022
Jul 5 2022
• AAssaf closed T310995: Composition implementations are being evaluated before being selected, a subtask of T309195: Wrong result due to dynamic scoping in function calls, as Resolved.
Jul 1 2022
Jul 1 2022
Do not resolve implementations before selecting them
Jun 29 2022
Jun 29 2022
• AAssaf updated subscribers of T309038: Getting wrong result for if(empty string("x"), "a", if(empty string(""), "b", "c")).
• AAssaf updated subscribers of T310995: Composition implementations are being evaluated before being selected.
Jun 20 2022
Jun 20 2022
Jun 13 2022
Jun 13 2022
Start annotating resolve and execute methods.
Jun 9 2022
Jun 9 2022
Jun 8 2022
Jun 8 2022
May 25 2022
May 25 2022
May 24 2022
May 24 2022
• AAssaf updated subscribers of T309038: Getting wrong result for if(empty string("x"), "a", if(empty string(""), "b", "c")).
May 23 2022
May 23 2022
That one was resolved by pointing the "wiki" in the config to the correct address ("http://localhost:8080"). By default the first one in the config is used (which by default is "https://wikifunctions.beta.wmflabs.org").
Now getting "could not delabel reference" when trying to evaluate:
It turns out the error UnhandledPromiseRejectionWarning: TypeError: s.toLowerCase(...).replaceAll is not a function was caused by my Node version being too old: https://stackoverflow.com/questions/13340131/string-prototype-replaceall-not-working. I switched to a newer version and the error went away.
May 19 2022
May 19 2022
May 5 2022
May 5 2022
Very early draft with more details on the goals and assumptions: https://docs.google.com/document/d/1olASGiCWKbT-XjAHO528HgZsx_pmVHO5tbPlZFGiex4/edit?pli=1#
Apr 20 2022
Apr 20 2022
Thanks!
Apr 19 2022
Apr 19 2022
Apr 14 2022
Apr 14 2022
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL