Page MenuHomePhabricator
Feed Advanced Search

Dec 4 2023

Justin_C_Lloyd added a comment to T282499: Consider whether Parsoid will support forced linear parsing..

I'll add my voice to MGChecker's comments, as we use Variables (and Loops to a lesser extent) in multiple wikis totalling around 300k content pages (and growing) that use 100s of templates that use Variables. Further, all of our wikis' contents are managed not by me or my company but by the wikis' respective communities and a small-ish set of editors who would be forced to completely rework all their use of the affected extensions somehow. (It's my understanding that the generally expected alternative would be Scribunto/Lua, meaning the editors would need to learn Lua if they don't already know it.)

Dec 4 2023, 6:48 PM · MediaWiki-extensions-ExternalData, Parsoid-Read-Views (Phase 3 - Main namespace of officewiki / mediawiki.org renders with Parsoid), MediaWiki-extensions-Variables, Parsoid, MediaWiki-Parser

Apr 6 2023

Justin_C_Lloyd added a comment to T291768: CdnCacheUpdate defaults to port 1080 on MediaWiki >= 1.35.

The comments in MainConfigSchema.php still also say that port 80 is the default for CdnServers:
https://github.com/wikimedia/mediawiki/blob/master/includes/MainConfigSchema.php#L4434

Apr 6 2023, 10:07 PM · MediaWiki-libs-HTTP

Jan 11 2023

Justin_C_Lloyd added a comment to T323959: Semantic MediaWiki unparsed queries and empty or incomplete query results possibly being caused by CirrusSearch.

I've opened a SMW GitHub issue in case that is a more appropriate avenue, given that these issues appear to be at the intersection of extensions managed here and there.

Jan 11 2023, 3:46 PM · Discovery-Search, CirrusSearch

Dec 16 2022

Justin_C_Lloyd added a comment to T323959: Semantic MediaWiki unparsed queries and empty or incomplete query results possibly being caused by CirrusSearch.

I would like to add that, while we have been able to work around the unparsed queries issue, the empty and incomplete query results are a significant problem for us. It would be nice to at least have an idea if this is more likely either a software bug (regardless of which component) or some kind of configuration or content-related issue that we would somehow need to address ourselves. Right now we have no idea and are completely stuck.

Dec 16 2022, 1:55 PM · Discovery-Search, CirrusSearch

Nov 28 2022

Justin_C_Lloyd created T323959: Semantic MediaWiki unparsed queries and empty or incomplete query results possibly being caused by CirrusSearch.
Nov 28 2022, 11:13 PM · Discovery-Search, CirrusSearch

Jun 20 2022

Justin_C_Lloyd added a comment to T298611: Some widgets are being frequently recompiled.

I'm working on redesigning our wikis to use a family design so I'm testing this again. I have each wiki's compiled widgets in $IP/compiled_templates/$wikiId/. I can see some widgets getting recompiled every time I hit a new page (e.g. via the Random page link) by watching the files' timestamps on the command-line via ls -l --full-time. Is there any further information I can provide to help diagnose this? Is this possibly just normal behavior, or could it be due to how the widgets are written? It would certainly be nice to resolve this before I'm ready to go live with the family redesign.

Jun 20 2022, 9:50 PM · MediaWiki-extensions-Widgets

Jun 15 2022

Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

Is there any work being done on this issue? Any idea of how significant of a risk it is?

Jun 15 2022, 9:05 PM · MediaWiki-extensions-Page_Forms

Apr 6 2022

Justin_C_Lloyd added a comment to T180885: Create maintenance script to renumber namespaces.

Is this task being worked? I have several custom namespaces that I need to renumber on several large wikis so that I can convert them into a wiki family design, and not having the ability to renumber a namespace is a showstopper for that larger project.

Apr 6 2022, 11:42 AM · MediaWiki-Core-Revision-backend

Apr 5 2022

Justin_C_Lloyd added a comment to T298611: Some widgets are being frequently recompiled.

Any ideas about this issue?

Apr 5 2022, 5:44 PM · MediaWiki-extensions-Widgets
Justin_C_Lloyd created T305492: Change the ID of an existing custom namespace.
Apr 5 2022, 4:41 PM

Feb 23 2022

Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

@Revansx I don't know for sure that they're related, but IIRC the conversation in the MW Stakeholders channel suggested that they are, and I'm not really knowledgeable on the details of how the extension works and what it all does, as it's our editors that manage all of our wikis' contents.

Feb 23 2022, 3:20 PM · MediaWiki-extensions-Page_Forms

Feb 11 2022

Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

FWIW I've also been told that SQL injections may be possible with this issue, though I don't have an example query/URL yet to demonstrate that.

Feb 11 2022, 10:32 PM · MediaWiki-extensions-Page_Forms
Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

Ok, thanks for the confirmation. I'll keep a close eye on this issue and I have a dev environment in which I can do further testing if needed.

Feb 11 2022, 9:47 PM · MediaWiki-extensions-Page_Forms
Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

HTML injection. The link I provided in our wiki shows an example of that, but the sec team (and me) weren't sure if this was in some way maliciously exploitable or if MW/SMW is more restrictive in e.g. the HTML tags it allows.

Feb 11 2022, 8:32 PM · MediaWiki-extensions-Page_Forms
Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

I don't know if there actually is one. Our security team reported this was discovered during some testing and wanted to know if this was normal behavior for the wikis or if it was some kind of exploitable bug.

Feb 11 2022, 5:58 PM · MediaWiki-extensions-Page_Forms

Feb 10 2022

Justin_C_Lloyd added a comment to T301202: RunQuery form makes Error 400 for sites with strict compliance to RFC7231.

I was told that an issue we discovered during some security testing may be related to this, so I figured I should post it here.

Feb 10 2022, 5:29 PM · MediaWiki-extensions-Page_Forms

Jan 5 2022

Justin_C_Lloyd created T298611: Some widgets are being frequently recompiled.
Jan 5 2022, 1:57 PM · MediaWiki-extensions-Widgets

Dec 1 2021

Justin_C_Lloyd added a comment to T132538: isConfiguredProxy not recognizing $wgSquidServers with port.

This bug is referenced by the docs for $wgCdnServers, and I'd just commented on T291768 about needed to add port 80 to my list of Varnish servers. However, the purges seem to be working whether or not I also add the IPs to $wgCdnServersNopurge. I am on MW 1.36.2, so maybe this issue was resolved with 1.36 (or even 1.35)?

Dec 1 2021, 12:14 PM · Patch-Needs-Improvement, MediaWiki-General
Justin_C_Lloyd added a comment to T291768: CdnCacheUpdate defaults to port 1080 on MediaWiki >= 1.35.

I just found this bug report. I'd always been confused why I'd never see any PURGE requests coming into my wiki web servers' Varnish processes (via varnishlog -q 'ReqMethod eq PURGE'), and why I was seeing port 1080 instead of the expected 80 when viewing page purges through tcpdump. I can confirm that adding :80 to each of the IP addresses in my $wgCdnServers setting does indeed resolve the problem for me.

Dec 1 2021, 11:50 AM · MediaWiki-libs-HTTP

Oct 22 2021

Justin_C_Lloyd added a comment to T267106: PHP fatal error while searching index: Declaration of Elasticsearch\Endpoints\Indices\Exists::getParamWhitelist() must be compatible with Elasticsearch\Endpoints\AbstractEndpoint::getParamWhitelist(): .

I had it working with REL1_35 using elasticsearch/elasticsaerch 6.7.*. Semantic MediaWiki wanted 6.8 but seemed to work fine when I specified the 6.7 limit in my composer.local.json. I didn't restrict elastica but it installed 6.1 (currently on 6.1.3 with REL1_36).

Oct 22 2021, 4:57 PM · Discovery-Search, CirrusSearch, Elasticsearch

Oct 4 2021

Justin_C_Lloyd added a comment to T250963: Replace use of removed hook InternalParseBeforeSanitize.

I'm following up on @Revansx, who may have been replying here due to me bringing this up on a live channel the same day he posted based on reviewing the documentation for all of the extensions we use as I prepare for a major version upgrade to 1.36. We use Variables extensively on our five Guild Wars 1 and 2 wikis.

Oct 4 2021, 2:07 PM · ci-test-error, MediaWiki-extensions-Variables

Sep 21 2021

Justin_C_Lloyd created T291493: Remove $sdgNamespaceIndex reference from INSTALL file.
Sep 21 2021, 2:31 PM · MediaWiki-extensions-SemanticDrilldown
Justin_C_Lloyd added a comment to T284148: Embedding of query forms breaks in MW 1.35.

I'm hitting this as well in testing rebuildData.php on MW 1.36 with SMW 3.2.3 and Page Forms 5.2.1. It appears to duplicate https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4330. Also, --ignore-exceptions does not skip over it.

Sep 21 2021, 9:59 AM · MediaWiki-extensions-Page_Forms

Sep 8 2021

Justin_C_Lloyd created T290577: Hitting a Loops limit despite $egLoopsCounterLimit being set high enough..
Sep 8 2021, 2:48 PM · MediaWiki-extensions-Loops

Aug 3 2021

Justin_C_Lloyd created T287950: Remove $wgJobQueueAggregator from CirrusSearch README.
Aug 3 2021, 11:59 AM · MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), good first task, Discovery-Search, Documentation, CirrusSearch

Jul 26 2021

Justin_C_Lloyd added a comment to T287367: PHP Warning: Empty regular expression in Linker.php in MW 1.35.

PHP Warning: preg_match(): Empty regular expression in $IP/includes/Linker.php on line 1826

Jul 26 2021, 2:05 PM · MW-1.35-release, MediaWiki-Parser
Justin_C_Lloyd added a comment to T287367: PHP Warning: Empty regular expression in Linker.php in MW 1.35.

@Aklapper My bad, thanks. I'm still new to using Phabricator. Should I do anything to change this? And is further information needed regarding this issue?

Jul 26 2021, 12:43 PM · MW-1.35-release, MediaWiki-Parser
Justin_C_Lloyd created T287367: PHP Warning: Empty regular expression in Linker.php in MW 1.35.
Jul 26 2021, 11:06 AM · MW-1.35-release, MediaWiki-Parser

Jul 21 2021

Justin_C_Lloyd added a comment to T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.

If you're letting it install based on the SMW version constraints alone, probably.

If you're combining (using composer-merge-plugin) your composer.json files, it should try and make sure it validates and meets all constraints

Jul 21 2021, 8:11 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-release, Upstream, CirrusSearch, Discovery-Search
Justin_C_Lloyd added a comment to T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.

I'm seeing the same problem in the original post where Elastica requires ruflin/elastica 6.1.5, which requires elasticsearch/elasticsearch: ^6.0 and conflicts with 6.8.1. However, I also just noticed that Semantic MediaWiki requires elasticsearch/elasticsearch ^5.3|^6.0, so I think that's why I'm getting 6.8.1.

Jul 21 2021, 3:44 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-release, Upstream, CirrusSearch, Discovery-Search
Justin_C_Lloyd added a comment to T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.

This still doesn't seem to work. I'm on MediaWiki 1.35.3, trying to get AWS Elasticsearch v6.5.4 working with CirrusSearch. I've got Elastica 6.1.3 (de9fe84) and elasticsearch/elasticsearch 6.8.1 but when I run the maintenance script I get the error in T267106:

# php ./extensions/CirrusSearch/maintenance/UpdateSearchIndexConfig.php 
indexing namespaces...
PHP Fatal error:  Declaration of Elasticsearch\Endpoints\Indices\Exists::getParamWhitelist() must be compatible with Elasticsearch\Endpoints\AbstractEndpoint::getPar
amWhitelist(): array in $IP/extensions/Elastica/vendor/elasticsearch/elasticsearch/src/Elasticsearch/Endpoints/Indices/Exists.php on line 45

But that error is completely different (it's not from missing classes), and is detailed in T267106: PHP fatal error while searching index: Declaration of Elasticsearch\Endpoints\Indices\Exists::getParamWhitelist() must be compatible with Elasticsearch\Endpoints\AbstractEndpoint::getParamWhitelist():

Jul 21 2021, 2:55 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-release, Upstream, CirrusSearch, Discovery-Search
Justin_C_Lloyd added a comment to T276854: composer update command installs PHP client for Elasticsearch v6.8.0 where some classes were removed.

This still doesn't seem to work. I'm on MediaWiki 1.35.3, trying to get AWS Elasticsearch v6.5.4 working with CirrusSearch. I've got Elastica 6.1.3 (de9fe84) and elasticsearch/elasticsearch 6.8.1 but when I run the maintenance script I get the error in T267106:

Jul 21 2021, 2:49 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), MW-1.35-release, Upstream, CirrusSearch, Discovery-Search

Mar 1 2021

Justin_C_Lloyd added a comment to T246594: Prevent use of known buggy versions of PHP (that are greater than the minimum supported PHP version) (7.4.0 – 7.4.8, and 7.3.0 - 7.3.18).

This PHP restriction is completely breaking MediaWiki installation on Ubuntu 20.04 (focal) since that currently has PHP 7.4.3 in its repo. Fortunately, I have a version of MW downloaded from Feb 8, so I can use that, but this patch prevents upgrading MediaWiki as long as Ubuntu doesn't have a new enough version of PHP.

Mar 1 2021, 1:23 PM · MW-1.35-notes, MW-1.36-notes, MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), Patch-For-Review, MediaWiki-General

Feb 17 2021

Justin_C_Lloyd created T275064: CURLPIPE_HTTP1 is no longer supported in MultiHttpClient.php.
Feb 17 2021, 7:03 PM