The error showed again in Logstash. I will check what's the reason for filtering again. It is suspicious we're only got results filtered in arwiki so far.
Thu, Jan 20
Wed, Jan 19
Mon, Jan 17
I added swipe gestures to the modal. Having a consolidated dialog experience can remain as a nice to have since it's prune to change in the future when we use Vue components.
Fri, Jan 14
After looking deeper into the different JS I think the complete migration of all our existing JS to Vue.js code is complex because many of the current code abstractions and entities do not fit well in a component approach framework like Vue. IMO this task should be marked as an EPIC and sliced into several.
Wed, Jan 12
I pushed a tentative fix. @RHo could you confirm that the help panel CTA needs to appear in User page and Discussion namespaces. Ty.
In T291603#7617146, @alexhollender wrote:
Interesting...I'm wondering if there was a separate bug that was causing the editor help button to show even when not in editing mode? I do remember seeing it a few days ago when not in editing mode (and imagine that was happening at the time when I reported this issue to @RHo), but that no longer seems to be the case.
I have gone through the happy path and some edges adding an image to an article. There were impressions for all relevant actions. Unless specific data needs to be gathered for the desktop experience I think we can move this forward.
Great. Thanks for checking @Etonkovidova
The designs were made for a screen with 640px height. iPhone 6s/SE and similar have a height of 667px but iOS Safari URL top bar and actions bottom bar take some extra space so we end up with less than 600px vertical viewport. This is quite common problem with short height devices that might affect other screens in our UI.
@Etonkovidova I could not reproduce the issue. On mobile the main header containing the notifications button is hidden while editing a article.
Tue, Jan 11
@Etonkovidova I created a tentative patch to solve the vertical scroll issue. I couldn't test with the particular images that you posted, could you point me to an article that has this problem in beta?
Fri, Jan 7
This is also reproducible on Vector skin. I think the issue is not related with the skin but with the fact the the last rendered window by the WindowManager is the RecommendedImageToolbarDialog and this dialog is "stealing" the focus from the StructuredTaskOnboardingDialog. If we click inside the on-boarding dialog to regain focus and then press Esc key it works as expected.
Wed, Jan 5
I'm understanding what we want to consolidate is non HTML render logic, right? @Tgr
Tue, Jan 4
Mon, Jan 3
Thu, Dec 23
@RHo A minor comment on the design, isn't a bit weird that the loading state text "Submitting..." appears under the gray overlay? It's definitely a minor issue but maybe we can improve it in the future.
@Tgr I tested the patch locally creating several accounts and it works fine. I could not find where is the geEnabled=1 set, I always found it to be -1 but all the accounts started with GE features enabled on their homepage. From 10 created accounts 1 showed up the welcome survey.
Dec 21 2021
Most of the errors coming from the frwiki guided tours are caused by calls to the next() callback without a return value on some step definitions. Maintainers are navigating to a different page by doing things like window.location.href = mw.util.getUrl( 'Somepage' ); inside the callbacks. For instance in tuto1:
Closing as duplicate of T262839: TypeError: rawStep is undefined. I added it to the existing filter NOT guidedtour:T262839 in logstash. Trying to contact the maintainers on frwiki although not sure what to suggest as a fix yet. Returning the next step name in the next() callback would avoid the error but render the step without waiting for the navigated page to load which may lead to a inappropriate experience on slow connections.
Dec 20 2021
The root of the issue comes from a frwiki guided tour. As per @Trizek-WMF comments the tour is actively used by the community. It's not a critical issue since the tour workflow is not affected and users can navigate through all the steps back and forward. However it would be nice to fix it so we don't pollute our JS production logs.
Dec 17 2021
@RHo In the current implementation of the Special:Homepage there's a left margin set to 8px in the main group modules whereas the right margin is set to 0 in the sidebar ones. I think we might not need the left margin at all as per designs in figma. Could you confirm we can remove this margin?
Dec 16 2021
Dec 15 2021
Good catch @mewoph - can we should use the same button style that exists on Minerva (with max-width:28.75em)?
Dec 14 2021
genewcomertasktoken is generated in SuggestedEditsModule.logCardData. It's just a random number to tie different EventLogging schemas together; could be generated anywhere else if that's more convenient.
Dec 13 2021
I think the easiest is to just move the link wrapping logic to DashboardModule::renderMobileSummary, and inject a base URL, as Sergio says. That would also get rid of the JS data generation hack.