Page MenuHomePhabricator
Feed Advanced Search

Jan 17 2019

phuedx moved T212961: Add X-Analytics tag for AMC webrequests from Blocked on Others to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Jan 17 2019, 9:17 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Product-QA (RW-Test-Cases), Patch-For-Review, XAnalytics, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 16 2019

phuedx added a comment to T212465: [EPIC] None of our View's should exhibit 2 levels of inheritance.

Can I ask that an outcome of this epic be well-written documentation about how to author new overlays both within and without the MobileFrontend/MinervaNeue codebases?

Jan 16 2019, 2:39 PM · Readers-Web-Backlog (Tracking), MobileFrontend (MobileFrontend and MinervaNeue architecture), Epic, MinervaNeue
phuedx added a comment to T212961: Add X-Analytics tag for AMC webrequests.

This is currently blocked on a privacy review.

Jan 16 2019, 12:36 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Product-QA (RW-Test-Cases), Patch-For-Review, XAnalytics, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 15 2019

phuedx claimed T212516: WikimediaEvents do not track logged in beta users on Special:MobileOptions.
Jan 15 2019, 6:03 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Advanced Mobile Contributions, MobileFrontend, MediaWiki-extensions-WikimediaEvents
phuedx updated subscribers of T213362: Limit what URLs Proton can access.

☝️ /cc @Pchelolo @mobrovac

Jan 15 2019, 11:40 AM · Patch-For-Review, Product-Infrastructure-Team-Backlog (Kanban), Security, Core Platform Team Legacy (Watching / External), Services (watching), Proton

Jan 11 2019

phuedx updated the task description for T213459: Minimise the code QuickSurveys loads when there are no surveys running.
Jan 11 2019, 4:43 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), QuickSurveys
phuedx added a comment to T213459: Minimise the code QuickSurveys loads when there are no surveys running.

Very neat, @Krinkle! That approach'll require a fair bit of explanation in the QuickSurveys documentation for future developers (covered by AC 3)

Jan 11 2019, 4:42 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), QuickSurveys

Jan 10 2019

phuedx added a comment to T213459: Minimise the code QuickSurveys loads when there are no surveys running.

I removed the duplicate information from the description but should clarify the following:

Jan 10 2019, 5:56 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), QuickSurveys
phuedx updated the task description for T213459: Minimise the code QuickSurveys loads when there are no surveys running.
Jan 10 2019, 5:54 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), QuickSurveys
bmansurov awarded T213459: Minimise the code QuickSurveys loads when there are no surveys running a Hungry Hippo token.
Jan 10 2019, 5:52 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), QuickSurveys
phuedx created T213459: Minimise the code QuickSurveys loads when there are no surveys running.
Jan 10 2019, 5:28 PM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Performance-Team (Radar), QuickSurveys
phuedx added a comment to T209882: Deploy/Undeploy Quicksurvey for reader trust.

The client-side error rate has since fallen to its previous level: https://grafana.wikimedia.org/d/000000566/reading-web-dashboard?orgId=1&panelId=15&fullscreen&from=1547035200000&to=now&refresh=5m

Jan 10 2019, 2:40 PM · Readers-Web-Backlog (Tracking), User-Jdlrobson, Patch-For-Review, Research
phuedx added a comment to T209882: Deploy/Undeploy Quicksurvey for reader trust.

@Jdlrobson thanks for spotting this. I wonder what a proper fix would be. There's got to be a way of removing that config. Hopefully the fix reduces the errors.

Jan 10 2019, 12:36 PM · Readers-Web-Backlog (Tracking), User-Jdlrobson, Patch-For-Review, Research
phuedx updated subscribers of T213363: Fix or clarify Proton Puppeteer sandboxing and SSL settings.

AIUI the service runner running Proton is firejailed. Is that correct @pmiazga, @Pchelolo?

Jan 10 2019, 12:04 PM · Product-Infrastructure-Team-Backlog (Kanban), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Proton
phuedx added a comment to T212959: Create AMC edit tag.

☝️ Formalizing T212959#4867678.

Jan 10 2019, 10:59 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a subtask for T212959: Create AMC edit tag: T211197: Build AMC opt-in toggle.
Jan 10 2019, 10:58 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a parent task for T211197: Build AMC opt-in toggle: T212959: Create AMC edit tag.
Jan 10 2019, 10:58 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 8 2019

phuedx set the point value for T212959: Create AMC edit tag to 5.
Jan 8 2019, 5:40 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212959: Create AMC edit tag.
Jan 8 2019, 5:40 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T212959: Create AMC edit tag.

Here's the GettingStarted extension's implementation of edit tags: https://github.com/wikimedia/mediawiki-extensions-GettingStarted/blob/ae9542e45f722c5f700ed4434dca47d561394794/Hooks.php#L328-L363

Jan 8 2019, 5:30 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx closed T177210: Security review of Marvin as Declined.

Thanks for the ping, @charlotteportero. This can safely be declined for now as the Marvin project is being archived.

Jan 8 2019, 2:20 PM · Security-Team-Reviews, Marvin
phuedx closed T177210: Security review of Marvin, a subtask of T177057: Clarify production deployment requirements, outline and blockers, as Declined.
Jan 8 2019, 2:20 PM · Epic, Marvin
phuedx added a comment to T212961: Add X-Analytics tag for AMC webrequests.

Do note that this task focusses on making the change in our application code, which is made possible by restricting AMC to logged-in users (who are always served by the application servers). It may be prudent to home all of our X-Analytics-related logic in the Varnish VCL's themselves.

Jan 8 2019, 11:56 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Product-QA (RW-Test-Cases), Patch-For-Review, XAnalytics, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212961: Add X-Analytics tag for AMC webrequests.
Jan 8 2019, 11:45 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Product-QA (RW-Test-Cases), Patch-For-Review, XAnalytics, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212961: Add X-Analytics tag for AMC webrequests.
Jan 8 2019, 11:44 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Product-QA (RW-Test-Cases), Patch-For-Review, XAnalytics, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212961: Add X-Analytics tag for AMC webrequests.
Jan 8 2019, 11:41 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Product-QA (RW-Test-Cases), Patch-For-Review, XAnalytics, Product-Analytics, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.
Jan 8 2019, 11:10 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T212216: AMC page/talk toggle v1: Talk tab at the top of page for AMC users.
Jan 8 2019, 11:09 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), UI-Standardization, UI-Standardization-Kanban, Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions

Jan 4 2019

phuedx updated the task description for T212802: [Spike, 12hrs] How do we extract beta / stable mode code from MobileContext to new file?.
Jan 4 2019, 9:30 AM · MobileFrontend (MobileFrontend and MinervaNeue architecture), Spike, Technical-Debt, Advanced Mobile Contributions

Jan 2 2019

phuedx added a comment to T211197: Build AMC opt-in toggle.

There was a lot of back and forth between an 8 and a 13 with good discussion about:

Jan 2 2019, 6:16 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx updated the task description for T211197: Build AMC opt-in toggle.
Jan 2 2019, 5:29 PM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Advanced Mobile Contributions
phuedx added a comment to T212330: [Bug] Many JSON decode ReadingDepth schema errors from wikiyy.

We don't want to collect this data at all, right?

Jan 2 2019, 4:48 PM · Reading Depth, Readers-Web-Backlog (Tracking), Analytics
phuedx added a comment to T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".

I think the original change was a good one – constraining a very loose API is a Good Thing™. However, while the ContribsPager API was very loose (a number of member variables were created in the constructor that happily defaulted to public!), I have to ask: should the public member variables have been formally deprecated?

Jan 2 2019, 4:30 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General
phuedx added a comment to T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".

Alright, shall we just make it a public property for now?

Jan 2 2019, 4:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General
phuedx updated subscribers of T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".
Jan 2 2019, 12:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General
phuedx renamed T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter" from [Bug] Special:Contributions broken for users that exist to [Bug] Special:Contributions broken when the Flow extension is loaded.
Jan 2 2019, 11:06 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General
phuedx added a comment to T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".

@thiemowmde @Umherirrender: I've subscribed you both as you authored and merged the change I mentioned, respectively.

Jan 2 2019, 11:03 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General
phuedx created T212771: [Bug] Special:Contributions broken when the Flow extension is loaded: "Cannot access private property ContribsPager::$tagFilter".
Jan 2 2019, 11:02 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Growth-Team (Current Sprint), Patch-For-Review, StructuredDiscussions, MediaWiki-General
phuedx moved T200927: Enable smooth/animated scrolling between links on pages from Needs More Work to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

I take it back. Correlation doesn't imply causation and all that…

Jan 2 2019, 10:09 AM · Readers-Web-Backlog, Product-QA, MobileFrontend, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08)

Dec 28 2018

phuedx added a comment to T212408: Refactor the /content-providers/MwApiContentProvider.php class for ease of writing PHPUnit tests.

👍

Dec 28 2018, 1:30 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MobileFrontend, User-D3r1ck01, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review

Dec 27 2018

phuedx moved T200927: Enable smooth/animated scrolling between links on pages from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

It looks like this introduced a regression in the automated browser tests (N.B. the failures started on 22nd December as they were run 2 hours prior to T200927#4840811): https://integration.wikimedia.org/ci/job/selenium-MobileFrontend/

Dec 27 2018, 8:19 AM · Readers-Web-Backlog, Product-QA, MobileFrontend, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08)

Dec 21 2018

phuedx closed T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings as Resolved.

Being bold.

Dec 21 2018, 5:50 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

className is always passed to the parent constructor rather than set as a property

Dec 21 2018, 5:50 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 5:49 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T212484: Page Preview beacons being sent too fast?.

To be clear, that's 1 second after the page preview is shown, which occurs no less than 700 ms after the user hovers over the link, i.e. the user has to dwell on the link for >= 1.7 seconds prior to the beacon being sent. I grant that some of these beacons could be the result of accidental hovers but, from experience, it's unlikely.

Dec 21 2018, 4:09 PM · Analytics, Product-Analytics
phuedx closed T212408: Refactor the /content-providers/MwApiContentProvider.php class for ease of writing PHPUnit tests as Resolved.

Points 1 and 2 were addressed in https://gerrit.wikimedia.org/r/478488. It'd be good to see a follow-on change to add tests for the class.

Dec 21 2018, 3:41 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MobileFrontend, User-D3r1ck01, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review
phuedx moved T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings from Ready for Signoff to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2) board.

@Jdlrobson: I believe that https://gerrit.wikimedia.org/r/481181 should allow us to mark the first AC as done so that we can resolve this task.

Dec 21 2018, 3:36 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

If a class extends View and defines className and isBorderBox these have no impact
No deprecation notices can be shown in the console under any circumstances

Dec 21 2018, 3:18 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:17 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

isBorderBox is always passed to the parent constructor rather than set as a property

Dec 21 2018, 3:15 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:12 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.

className is always passed to the parent constructor rather than set as a property

Dec 21 2018, 3:11 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:10 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:07 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx claimed T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:06 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T211828: MFA: Drop all usages of isBorderBox and className props on View and remove log warnings.
Dec 21 2018, 3:06 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T212484: Page Preview beacons being sent too fast?.

(Emphasis on should)

Dec 21 2018, 11:44 AM · Analytics, Product-Analytics
phuedx added a comment to T212484: Page Preview beacons being sent too fast?.

The beacon should be being sent 1 second after the page preview is shown. This is also reflected in the AC for T184793: [EPIC] Instrument page interactions and in the description of the VirtualPageview schema itself.

Dec 21 2018, 11:43 AM · Analytics, Product-Analytics
phuedx triaged T200235: Word spacing issue in disclaimer of generated PDFs as Normal priority.

My guess is that this is Normal to High. We should try to reproduce it with Proton and if we can, then it should be escalated.

Dec 21 2018, 11:21 AM · Proton, Readers-Web-Backlog

Dec 19 2018

phuedx added a comment to T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.

What reading web products using statsv that might be impacted?

Dec 19 2018, 10:27 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents

Dec 18 2018

phuedx added a comment to T212137: Check impacts of mobile VE load screen improvements.

How long does it take on average for pages to load?

Dec 18 2018, 11:27 AM · Product-Analytics, VisualEditor
phuedx added a comment to T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests.

Thank you, @D3r1ck01!

Dec 18 2018, 11:03 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests as Resolved.

Being bold.

Dec 18 2018, 11:01 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx closed T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Dec 18 2018, 11:01 AM · Readers-Web-Backlog, Epic, MobileFrontend
phuedx updated the task description for T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.
Dec 18 2018, 11:01 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx added a comment to T210390: PHPUnit: Cover methods in content-providers/McsContentProvider.php with unit tests.

Code Coverage has gone up to 100%

Dec 18 2018, 11:00 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Patch-For-Review, User-D3r1ck01, MobileFrontend
phuedx closed T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests as Resolved.

Being bold.

Dec 18 2018, 10:44 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx closed T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests, a subtask of T208761: [Epic] Improve PHPUnit coverage in MobileFrontend to medium, as Resolved.
Dec 18 2018, 10:44 AM · Readers-Web-Backlog, Epic, MobileFrontend
phuedx updated the task description for T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests.
Dec 18 2018, 10:44 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx added a comment to T210400: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests.

Code Coverage has gone up to 100%

Dec 18 2018, 10:43 AM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend
phuedx added a comment to T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.

Can you expand the problem statement here? Does this relate to ReadingDepth or something else? It would be great to tie this back to our products and any bugs we're seeing.

Dec 18 2018, 10:20 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx updated the task description for T208980: [Bug] The statsv client should send a request when the page unloads so we are not losing events.
Dec 18 2018, 10:07 AM · Product-QA (RW-Test-Cases), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), Performance-Team, MediaWiki-extensions-WikimediaEvents
phuedx added a comment to T209647: MFA: Allow our View's to support easy adding of children.

Using a tried and tested alternative e.g. Preact was quite popular and we're going to explore that a little more.

Dec 18 2018, 9:53 AM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Readers-Web-Backlog

Dec 17 2018

phuedx awarded T210553: Deploy page issues to all wikipedias (except enwiki) a Mountain of Wealth token.
Dec 17 2018, 6:21 PM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
phuedx added a comment to T209708: Catalogue where the MobileFrontend loading overlay is used.

@JTannerWMF: I'm the Sam you're looking for 🙂

Dec 17 2018, 5:33 PM · VisualEditor (Current work), Readers-Web-Backlog (Design), Design
phuedx updated the task description for T210553: Deploy page issues to all wikipedias (except enwiki).
Dec 17 2018, 11:33 AM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
phuedx updated the task description for T210553: Deploy page issues to all wikipedias (except enwiki).
Dec 17 2018, 11:32 AM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
phuedx added a comment to T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..

☝️ From at the current AC for T210553: Deploy page issues to all wikipedias (except enwiki):

Dec 17 2018, 11:31 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
phuedx removed a parent task for T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes.: T210553: Deploy page issues to all wikipedias (except enwiki).
Dec 17 2018, 11:29 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings
phuedx removed a subtask for T210553: Deploy page issues to all wikipedias (except enwiki): T202349: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes..
Dec 17 2018, 11:29 AM · Wikimedia-Site-requests, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Page-Issue-Warnings

Dec 14 2018

phuedx added a comment to T209708: Catalogue where the MobileFrontend loading overlay is used.

I suspect there may be a distinction between processes we expect to complete quickly (e.g. <500ms) and long processes like loading VE, which can take a few seconds. A design which works for one may not be optimal for the other.

Dec 14 2018, 3:45 PM · VisualEditor (Current work), Readers-Web-Backlog (Design), Design

Dec 12 2018

phuedx added a comment to T197883: Popups: Update babel-preset-env and friends.

Unfortunately, both the staging server and the Beta Cluster no longer have the Page Previews testing pages present. I'll try and dig out the corpus and re-import it to both of those servers.

Dec 12 2018, 6:45 PM · Google-Code-in-2018, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Technical-Debt, Page-Previews
phuedx added a comment to T197883: Popups: Update babel-preset-env and friends.

@nray: As discussed, here's the list of all Page Previews test cases that @ovasileva and @ABorbaWMF created. As you can see, it's long. I would suggest that you use your discretion about how many cases you run through (e.g. we have browser tests covering previews appearing/disappearing when you interact with a link).

Dec 12 2018, 6:41 PM · Google-Code-in-2018, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Technical-Debt, Page-Previews
phuedx added a comment to T209708: Catalogue where the MobileFrontend loading overlay is used.

This first step will be determining where the overlay is used, followed by design review and discussion.

Dec 12 2018, 11:04 AM · VisualEditor (Current work), Readers-Web-Backlog (Design), Design

Dec 11 2018

phuedx added a comment to T210870: MFA: Remove CtaDrawer events and pass events for red link CtaDrawer via options.

I can conceive of a situation where you'd define a view with some default click event handler but an extending class wants to define its own click handler. In this instance, I'd expect both event handlers to be bound rather than one. Is this the intended behaviour?

Dec 11 2018, 5:16 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2)
phuedx closed T208920: MFA: add tests for Drawer and CtaDrawer as Resolved.

Being bold.

Dec 11 2018, 3:18 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx closed T208920: MFA: add tests for Drawer and CtaDrawer, a subtask of T195478: [EPIC] Speed up unit test execution and increase code coverage, as Resolved.
Dec 11 2018, 3:18 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), MobileFrontend (MobileFrontend and MinervaNeue architecture), Readers-Web-Kanbanana-Board-Old, User-Jdlrobson, Epic, MinervaNeue
phuedx added a comment to T208920: MFA: add tests for Drawer and CtaDrawer.

This change affects the call to action shown to an anonymous user when they click the watchstar and affects the reference drawer so both of those should be tested.

Dec 11 2018, 3:18 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx claimed T208920: MFA: add tests for Drawer and CtaDrawer.
Dec 11 2018, 1:31 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T208920: MFA: add tests for Drawer and CtaDrawer.

This change affects the call to action shown to an anonymous user when they click the watchstar and affects the reference drawer so both of those should be tested.

Dec 11 2018, 1:31 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T208920: MFA: add tests for Drawer and CtaDrawer.
  • Record progress
Dec 11 2018, 1:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T208920: MFA: add tests for Drawer and CtaDrawer.
Dec 11 2018, 1:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx updated the task description for T208920: MFA: add tests for Drawer and CtaDrawer.
Dec 11 2018, 1:13 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx added a comment to T208920: MFA: add tests for Drawer and CtaDrawer.

Coverage should be 100%. If not, and there is a reason, please make a note on the table. If coverage is not 100% push this back to needs more work to find out why.

Dec 11 2018, 1:06 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), MobileFrontend (MobileFrontend and MinervaNeue architecture)
phuedx placed T195880: % of "none" referers seems too high up for grabs.

Not sure why I assigned this to myself…

Dec 11 2018, 11:58 AM · Readers-Web-Backlog (Needs Product Owner Decisions), Analytics

Dec 7 2018

phuedx added a comment to T211382: Requesting access to Proton for pmiazga, bearND, Mholloway, MSantos, Tgr.

Approved.

Dec 7 2018, 3:49 PM · Patch-For-Review, Proton, Operations, SRE-Access-Requests
phuedx updated the task description for T210652: Handoff Proton service to Reading Infrastructure.
Dec 7 2018, 9:51 AM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Product-Infrastructure-Team-Backlog, Proton

Dec 6 2018

phuedx added a comment to T207862: Use Server-Timing to collect Varnish hit/miss information in NavigationTiming.

Doesn't work, I see nothing in hive and this happens a bunch:

Dec 6 2018, 11:58 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Performance-Team

Dec 5 2018

phuedx added a comment to T210658: [EPIC] AMC Navigation - page/talk toggle.
  • Making the toggle a link maximises the number of users that we support (all browsers can follow a hyperlink).
  • When investigating whether we can fetch the content of the talk page via an API (making it more a tab switch than a link follow), please consider that the mobileview API is intended to be deprecated (see T186627: [EPIC] Deprecate the MobileView API)
  • What happens to the talk overlay in this treatment?
Dec 5 2018, 5:43 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), Epic, Advanced Mobile Contributions
phuedx updated subscribers of T211195: [Spike 16hrs] Investigate opt-in audience and instrumentation.

/cc @Tbayer

Dec 5 2018, 5:12 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), Spike, Advanced Mobile Contributions