In T225768#5402985, @nray wrote:Padding is restored
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Aug 19 2019
Aug 19 2019
phuedx closed T225768: [Bug] Minerva's History Action "Compare selected revisions" button is missing padding [desktop] as Resolved.
Aug 15 2019
Aug 15 2019
When saving, I was not given the option to see or edit the section in the summary.
phuedx moved T229802: Homepage: add context to mentorship module from Needs triage to Growth on the Mobile board.
phuedx moved T229805: Homepage: Allow mentors to provide more information about themselves to newcomers from Needs triage to Growth on the Mobile board.
phuedx moved T229808: Homepage: Surface mentor answers more prominently in the mentor module from Needs triage to Growth on the Mobile board.
phuedx moved T230014: Homepage: layout and UI fixes from Needs triage to Growth on the Mobile board.
phuedx moved T230333: Impact Module: number of pageviews in mobile impact preview should be abbreviated from Needs triage to Growth on the Mobile board.
phuedx moved T230349: Homepage: module headers in mobile Start module dialog should have no padding from Needs triage to Growth on the Mobile board.
phuedx moved T230350: Homepage: user info text vertical stacking issues in mobile account creation module from Needs triage to Growth on the Mobile board.
phuedx moved T230352: Homepage: account age text styling issues in mobile account creation module from Needs triage to Growth on the Mobile board.
phuedx moved T230355: Homepage: icons alignment issue in mobile Start module dialog from Needs triage to Growth on the Mobile board.
phuedx moved T230360: Homepage: modules padding issues in mobile Start module dialog from Needs triage to Growth on the Mobile board.
phuedx moved T230364: Homepage: light text style tracking issue in mobile homepage module previews from Needs triage to Growth on the Mobile board.
phuedx moved T230365: Homepage: incorrect text style in mobile help module preview from Needs triage to Growth on the Mobile board.
phuedx moved T230368: Homepage: margin issues with light text in mobile Impact module dialog from Needs triage to Growth on the Mobile board.
phuedx moved T230370: Homepage: size issue with mentor's username in mobile mentor module preview and dialog from Needs triage to Growth on the Mobile board.
phuedx moved T230373: Homepage: mentor text style issues in mobile Mentorship module dialog from Needs triage to Growth on the Mobile board.
phuedx moved T230374: Homepage: mentor message text style issue in mobile mentorship module dialog from Needs triage to Growth on the Mobile board.
phuedx moved T230376: Homepage: vertical alignment issues in mobile Impact module preview from Needs triage to Growth on the Mobile board.
phuedx moved T230377: Homepage: text size issue of pageviews number in Impact module from Needs triage to Growth on the Mobile board.
Aug 14 2019
Aug 14 2019
phuedx added a comment to T228794: Investigate technical needs for native mobile diffs, including supporting APIs.
In T228794#5413723, @phuedx wrote:Unfortunately, I can find no such API.
phuedx added a comment to T228794: Investigate technical needs for native mobile diffs, including supporting APIs.
In T228794#5412294, @Jhernandez wrote:
- There is no structured diff data API because of performance reasons. The diffing modules used in production are C++ code that generates HTML directly. Fun times.
Aug 12 2019
Aug 12 2019
phuedx added a comment to T229875: [Bug] iPadOS 13 shows the desktop version of Safari with a broken layout.
In T229875#5396278, @Jdlrobson wrote:We shouldn't add <meta name="viewport" content="width=device-width, user-scalable=no, initial-scale=1, shrink-to-fit=no"> to Vector. When Monobook did that it annoyed a lot of people and I wouldn't advise it as it seems many users use Vector on their mobile devices exactly because they don't want a responsive layout.
phuedx added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.
In T225213#5394727, @Jdlrobson wrote:for non-JS users requires an extra page load.
Remember menu usage is very low (https://grafana.wikimedia.org/d/000000566/overview?panelId=22&fullscreen&orgId=1 logs events for 50% of all page views). Most people don't interact with the main menu. They want to read the article.
phuedx added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.
Firstly, forgive the lateness of my reply and also if I've missed any discussion of this task (or the more general topic) while I've been away.
I'm not against disabling the instrumentation for now (but keeping the dataset per T229042#5370440), given the… alarmingly high event rate. To be clear, disabling the instrumentation must include not sending it to the client.
Aug 7 2019
Aug 7 2019
• Jhernandez awarded T217142: [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors a Mountain of Wealth token.
Aug 5 2019
Aug 5 2019
Per T220016#5385166 and T228681#5388069.
phuedx moved T228681: Decommision MobileWebMainMenuClickTracking from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
@Jdlrobson's change above will need to be merged, deployed to the Beta Cluster, and deployed to the production servers. Since we're confident that this is effectively a NOOP change (the new instrumentation is working as expected – see T228681#5388069 above), the change can be deployed at any time provided that this is communicated in #wikimedia-operations.
Aug 2 2019
Aug 2 2019
phuedx added a comment to T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage).
In T229399#5385954, @alexhollender wrote:@Jdlrobson @phuedx I just checked production in Safari/MacOS and I can't reproduce this issue. Would it make sense to spend our time elsewhere? I feel like we're over investing in a very minor bug.
Aug 1 2019
Aug 1 2019
Correct. Those prefixes must be added by whatever application is proxying the site.
In T216063#5328423, @Milimetric wrote:These failures are expected, though, the spec does not account for such prefixes, it just expects an encoded JSON blob. Is this something the client has no control over somehow? Actually, yeah, how are these URLs even generated?
Jul 31 2019
Jul 31 2019
phuedx added a comment to T225959: [Bug] Overflow menu has blank entry on community portal when no Wikidata item exists.
Note also that the above might fix T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) too.
phuedx raised the priority of T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) from Medium to Needs Triage.
phuedx closed T214540: [EPIC] AMC Navigation - user menu, a subtask of T210655: [EPIC] AMC Navigation, as Resolved.
phuedx closed T214540: [EPIC] AMC Navigation - user menu, a subtask of T228916: Deploy AMC to all Wikipedias, as Resolved.
This looks great to me 💪 Excellent work everyone!
phuedx triaged T229399: [Bug] [AMC] 1px gap at bottom of page actions without download icon (due to font size usage) as Medium priority.
In T214540#5354758, @alexhollender wrote:As you suggest, I agree it'd be a great idea to persist that styling while the menu is open, cc @Jdrewniak. I will create a task for that.
phuedx closed T228278: Edits lost when writing replies on talk page before leaving the page as Resolved.
LGTM 💪 I tested this on the BC as did @Edtadros in T228278#5378507. The patch will be deployed to group0 wikis tomorrow.
LGTM 💪
Jul 30 2019
Jul 30 2019
phuedx moved T201131: Bug: Order of some paragraphs is flipped on mobile from Ready for Signoff to Blocked on Others on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
The changes and the QA LGTM and I'd be happy to sign this off. However, the changes will be deployed to enwiki this Thursday so I'm inclined to wait and double-check the page in production.
phuedx moved T220016: Create, and deploy working MobileWebUIActionsTracking schema from Ready for Signoff to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-2019-20-Q1) board.
Per T220016#5377322. Alternatively, I'm happy to sign this off and create an "enable the instrumentation" task.
I clarified with @pmiazga that it's expected that we're not sending seen events for UI elements yet. That is, we're tracking UI element interactions as we were before.
Jul 4 2019
Jul 4 2019
phuedx added a comment to T209410: sameAs schema doesn't report dateModified if article has only one edit.
I did some digging on this task during today's chores. Here's what I think I know:
In the last 24 hour period, 11 more ReadingDepth events with odd URLs have caused processing errors. See https://logstash.wikimedia.org/goto/dbe9713837e22a6d5a0d64f09fae1ec2. For these events, the QSON is terminated as we expect but it's prefixed with either iorg_domain_internal=... or operator_user=....
Jul 2 2019
Jul 2 2019
In T226164#5300813, @Jdlrobson wrote:Noise in EventLogging should be considered a high priority to fix as it creates problems for all people working with our infrastructure, so I suggest we fix this sooner rather than later.
In today's grooming ritual, we wondered aloud whether the MinervaPageActions config is actually needed – it was but is it still?
phuedx added a comment to T221695: [Bug] Infobox in "Iraq war" article on enwiki not full width on mobile-html.
In T221695#5298411, @Jdlrobson wrote:
Jul 1 2019
Jul 1 2019
phuedx added a comment to T217142: [Proposal] Use the Kafka-Logstash logging infrastructure to log client-side errors.
In T217142#5295424, @Tgr wrote:
- tags (which contain lots of useful information such as MediaWiki version, language, skin...) are handled extremely poorly by kibana in their current format. They should be converted into top-level properties (preferably with field names matching those in PHP errors so that Kibana visualisations / saved searches can be reused). Not sure what's the right place for that: client, EventGate, logstash filter? (The last one has its own domain language so it would be the most painful to maintain.)
Jun 27 2019
Jun 27 2019
phuedx added a comment to T225877: Two link rel="canonical" if $wgEnableCanonicalServerLink and $mfNoIndexPages is true.
Following on from @DIKW_Pyramid's comment above:
Jun 25 2019
Jun 25 2019
Jun 20 2019
Jun 20 2019
phuedx moved T224379: mobile app is killing tabs to force article of the day from Needs triage to Apps on the Mobile board.
phuedx moved T226106: Three clicks required to exit talk overlay from Needs triage to MinervaNeue on the Mobile board.
phuedx moved T225180: Sharing a text from Wikipedia App into Twitter gives @Wikipedia handle, which shouldn't from Needs triage to Apps on the Mobile board.
phuedx moved T226009: add link to Wikidata on Wikipedia mobile view from Needs triage to Triaged on the Mobile board.
phuedx moved T226146: Homepage: minor mobile instrumentation issues from Needs triage to Triaged on the Mobile board.
phuedx moved T226147: Homepage: impact clock icon issues on mobile from Needs triage to Triaged on the Mobile board.
phuedx moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Triaged to MinervaNeue on the Mobile board.
phuedx moved T225499: Fix Special:RecentChanges dropdown widget on mobile from Needs triage to Triaged on the Mobile board.
phuedx moved T226041: Homepage and help panel: ask question dialog should be aware of back button from Needs triage to Triaged on the Mobile board.
phuedx edited projects for T226164: Invalid MobileWebSearch events being logged, added: Mobile; removed MediaWiki-extensions-EventLogging, Analytics.
Restricted Application added a project to T226164: Invalid MobileWebSearch events being logged: Analytics.
Jun 19 2019
Jun 19 2019
phuedx added a comment to T220558: ImageGateway should utilize browser cache when calling MediaWIki API.
In T220558#5217741, @Niedzielski wrote:Can we use MediaWiki API caching instead and drop the cache?
phuedx updated the task description for T220558: ImageGateway should utilize browser cache when calling MediaWIki API.
Jun 18 2019
Jun 18 2019
phuedx added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.
Could we also consider moving the Wikimedia-specific instrumentation for the main menu into the WikimediaEvents extension?
phuedx added a comment to T225213: Main Menu should work without JavaScript to be more accessible and a better user experience.
As I mentioned in today's grooming, there's a whole bunch of (now overly-complicated) machinery that we created in order to defer the parsing/DOM construction for the main menu as it's the very top element in #mw-mf-viewport. I think that reevaluating this machinery is well worth it!
phuedx awarded T225946: [SPIKE 8hrs] Determine remedy for MobileFrontend lazy-loading images performance issues a Mountain of Wealth token.
Jun 11 2019
Jun 11 2019
I think this could be as simple as adding the following rules:
phuedx added a comment to T223363: Cleanup Special:RecentChanges filters appearance on Minerva (mobile).
Is the level of specificity of some of the example CSS rules required, e.g. .mw-rcfilters-ui-filterTagMultiselectWidget-views-select-widget.oo-ui-widget.oo-ui-widget-enabled.oo-ui-selectWidget.oo-ui-selectWidget-unpressed.oo-ui-selectWidget-depressed.oo-ui-buttonSelectWidget ?
Jun 7 2019
Jun 7 2019
phuedx updated the task description for T225260: BUG: Notifications tray (mobile) - margins and borders.
… gIven that the bugs are minor.
phuedx moved T225260: BUG: Notifications tray (mobile) - margins and borders from Triaged to MobileFrontend specific on the Mobile board.
phuedx moved T225260: BUG: Notifications tray (mobile) - margins and borders from Needs triage to Triaged on the Mobile board.
phuedx updated the task description for T225260: BUG: Notifications tray (mobile) - margins and borders.
phuedx edited projects for T224997: Update MobileFrontend-npm-run-lint-modules-docker to run node10, added: Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
phuedx edited projects for T225042: Internal quick survey: allow entering free text, added: Web-Team-Backlog (Tracking); removed Web-Team-Backlog.
phuedx added a project to T225042: Internal quick survey: allow entering free text: Web-Team-Backlog.
phuedx added a parent task for T225042: Internal quick survey: allow entering free text: T216495: [EPIC] Diversity quicksurveys.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL