@bmansurov I dont think applying the css to the span and the img tags would work as i've checked doing that in the chrome editing the markup by "inspect element".
It worked when I applied the css on the wrapping <dd> element.
^ this worked
@bmansurov I dont think applying the css to the span and the img tags would work as i've checked doing that in the chrome editing the markup by "inspect element".
It worked when I applied the css on the wrapping <dd> element.
Okay cool, i'll upload it! @bmansurov
@Physikerwelt Yes, i'm able to access the url form my browser.
@bmansurov Yes, I had written the patch but i wasn't able to test it.
@bmansurov I tried later on Windows, it worked.
@Jdlrobson @Physikerwelt What parsing options should I choose in
@Jdlrobson I ran update.php, installed php-mysql module It showed the same error.
I deleted the extension and the downloaded a fresh stable version and run update.php and its still showing the same error.
@Jdlrobson, I've written the patch but am not sure as I'm not able to test it as every time I try to save a math page, I receive a database error
In T134281#2843862, @Physikerwelt wrote:I'm not sure if wrapping inline math elements in a div would be a good idea. And texvc_cgi is not used in production. The code is actually here
https://github.com/wikimedia/mediawiki-extensions-Math/blob/master/MathMathML.php#L453
@Jdlrobson @Physikerwelt
I've been trying to wrap the "mwe-math-fallback-image-inline" inside a div(i've tried it in chrome developer console and it works).
But to wrap it up, I tred searching for the <img...> markup using grep and there was no proper HTML markup in any php file, all of them were filled up with definitions of classes, except for this one file "texvc_cgi.ml"
line 31 on extensions/Math/texvc_cgi.ml
out ("<h3>Image:</h3><img src=\""^finalurl^md5^".png\">") with Util.FileAlreadyExists -> out ("<h3>Image:</h3><img src=\""^finalurl^md5^".png\">")
Will wrapping this img element work? Or is there some other php responsible for the output.
The only other relevant php i could find was in
line 147 /extensions/Math/MathTexvc.php (searching for class name in grep)
In T134281#2811490, @Jdlrobson wrote:@TameeshB did you have any luck locating the code outputting the dd element?
I'll resume working on it this Friday as I have exams until then.
The bug seems to have been fixed and the page is now fine.
The bug seems to have been fixed and the page is now fine.
May I please take up this task to work on?
I found that all the math equations are enclosed in a "<dd>" which itself is wrapped by a "<dl>" tag.
Is it okay to add the css properties to the selector
dl>dd{
As in your previous comment,
Which solution must I go with?
- Set max-width to 100% and avoid horizontal scrolling altogether - a user can switch to landscape mode to get a better look.
The above one might cause problem in a case that the equation is a long one, it would become near invisible.
- The image could be wrapped in a container and use overflow on that container,
So should I go with this^ ?
May I please take up this bug for my first bug fix?