I figured out how to reproduce this. The problem only occurs if you load the 'ext.discussionTools.init' module while viewing Special:Watchlist (or another special page), as DiscussionTools fetches some metadata about the page using VisualEditor's API.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Thu, Apr 8
Thu, Apr 8
matmarex added a comment to T279711: WikiPage constructed on a Title that cannot exist as a page: Special:Watchlist [Called from Article::newPage].
matmarex added a comment to T279141: Discussion tools source mode should display navigation popups when enabled.
For case A, I don't think we can do much, Popups only handles that in the old wikitext editor.
matmarex moved T279707: VisualEditor client-side errors review (April 2021) from To Triage to Triaged on the VisualEditor board.
(added the subtasks that we looked at in today's triage meeting, plus two from the same "batch" that were already on our workboard)
matmarex moved T279215: TypeError: content.parts is undefined from To Triage to Triaged on the VisualEditor board.
matmarex moved T279297: Error: Unable to parse title at ve.ce.MWImageNode.static.getDescription from To Triage to Triaged on the VisualEditor board.
matmarex moved T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange from To Triage to Triaged on the VisualEditor board.
matmarex moved T279441: TypeError: Cannot read property 'getModel' of null from To Triage to Triaged on the VisualEditor board.
matmarex added subtasks for T279707: VisualEditor client-side errors review (April 2021): T279217: TypeError: undefined is not an object (evaluating 'this.mediaUploadBooklet.setFile'), T279313: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackCommand.execute, T279441: TypeError: Cannot read property 'getModel' of null, T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange, T279299: TypeError: Cannot read property 'canHaveChildrenNotContent' of null at VeCeSurface.ve.ce.Surface.findBlockSlug, T279297: Error: Unable to parse title at ve.ce.MWImageNode.static.getDescription, T279169: TypeError: Cannot read property 'node' of undefined / Error: domNode has no ancestor with a .data( 'view' ) , T279215: TypeError: content.parts is undefined.
matmarex added a comment to T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work.
And thank you for noticing this @Etonkovidova!
matmarex moved T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.
Backported
I'm glad you got it working. I think we can close this task now.
matmarex added a comment to T278725: how to create lists without marking (bullet or numeric) within visual editor?.
It can't be done at the moment.
It looks to me like the original problem in this task was already fixed.
matmarex added a comment to T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work.
Yes, scheduled for the next backport window today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210408T1800
matmarex renamed T247661: "Special:Badtitle/ApiErrorFormatter::getDummyTitle" displayed instead of page title in abusefilter warning with VE from {{FULLPAGENAME}} returns "Special:Badtitle/ApiErrorFormatter::getDummyTitle" in abusefilter warning with VE to "Special:Badtitle/ApiErrorFormatter::getDummyTitle" displayed instead of page title in abusefilter warning with VE.
matmarex edited projects for T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team.
Caused by 4984c5ffbbf26d6c274d19924d9bda70442eb1b5
Wed, Apr 7
Wed, Apr 7
matmarex added a comment to T279604: [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster.
Yes, a silly mistake, thanks for debugging @Krinkle.
matmarex moved T262842: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (FY2020-21 Kanban Board) board.
(check logs after it's deployed)
matmarex updated the task description for T270803: Prevent blocked users from opening the DiscussionTools.
No, I don't think the difference matters in the end. As I understand, we were considering different treatments for different block types, but in end end we decided to just do whatever visual editor does (which in turn just does whatever the wikitext editor does), so all special cases are handled elsewhere and we just display the message.
matmarex moved T263472: [TRACKING] VE navigation issues when cancelling a close from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
All subtasks resolved
matmarex edited projects for T263472: [TRACKING] VE navigation issues when cancelling a close, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team.
@A.Amritesh Sorry I didn't reply to your messages earlier, I get lots of notifications. I'm glad you worked it out!
matmarex moved T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null from Needs Discussion / Investigation to Blocked / Needs More Work on the Editing-team (FY2020-21 Kanban Board) board.
(check logs after it's deployed)
matmarex updated the task description for T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface.
matmarex renamed T53045: VisualEditor: Ctrl+Shift+Space/Opt+Space to insert a non-breaking space (NBSP) from VisualEditor: Ctrl+Space/Opt+Space to insert a non-breaking space (NBSP) to VisualEditor: Ctrl+Shift+Space/Opt+Space to insert a non-breaking space (NBSP).
Yes, it's easier to keep track of as a separate task. I filed one for this: T279600. I think we didn't test this change with the wikitext editor :(
matmarex updated the task description for T270803: Prevent blocked users from opening the DiscussionTools.
matmarex updated the task description for T276393: Reply links appear for users who can't edit the page.
matmarex updated the task description for T276393: Reply links appear for users who can't edit the page.
matmarex updated the task description for T270803: Prevent blocked users from opening the DiscussionTools.
Testing instructions were written on T276393, it seems. Have you seen that, or are those unclear?
matmarex moved T275821: Reply tool does not work for most comments on community wishlist index pages from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T275821
matmarex moved T273413: Cannot reply to a comment with an external link in section title from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T273413
matmarex added a comment to T273413: Cannot reply to a comment with an external link in section title.
I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!
matmarex added a comment to T275821: Reply tool does not work for most comments on community wishlist index pages.
I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!
matmarex added a comment to T279585: Error on wmf.38 when parsing edit summary via API: Content serialization failed: Failed to decode as application/json.
I think the error message means that action=parse is trying to use the text parameter (which would normally contain the wikitext to parse), except that you did not provide it, and also it's using the content model application/json instead of text/x-wiki because that's the default content model of the main namespace on Wikidata (and the default title when not provided is "API", which is in main namespace).
matmarex moved T264904: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (FY2020-21 Kanban Board) board.
That is indeed the same error.
matmarex added subtasks for T278442: Enable more signature flexibility in discussion tools: T267663: Adding <small> tag in a reply using DiscussionTools provides no way to auto-close the tag if one wants their signature to be made the same size, T268558: Allow minor (<small>-wrapped) comments to be saved via the reply link, T278357: Discussion tools should recognise three and five tilde signatures and add only the missing part, T278355: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters, T279578: Consider a way to suppress the user's signature.
matmarex renamed T278355: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters from Discussion tools doesn't detect a manually-added siganture when followed by any non-whitespace characters to Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters.
matmarex updated the task description for T278442: Enable more signature flexibility in discussion tools.
Related: T278442: Enable more signature flexibility in discussion tools and the tasks linked there.
matmarex moved T279121: Undo functionality not "sticking" from Ready to Be Worked On to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
I could reproduce this in the demo you linked, but not in the latest version of the code when testing locally (or this new demo I just made today: https://patchdemo.wmflabs.org/wikis/506b59600d/wiki/Talk:Main_Page).
This has been implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/663894 (it should have been tagged with this task).
matmarex moved T276990: Ensure duplicate notifications are *not* sent for the same talk page event from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
This has been implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/663894 (it should have been tagged with this task).
Tue, Apr 6
Tue, Apr 6
matmarex committed rEDTO18cbae137ff3: Make sourcemodetoolbar preference available (authored by matmarex).
Make sourcemodetoolbar preference available
Backported
matmarex committed rEDTO86be6f83daf8: Service to interact with topic subscriptions (authored by DLynch).
Service to interact with topic subscriptions
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL