Page MenuHomePhabricator
Feed Advanced Search

Thu, Apr 8

matmarex added a comment to T279711: WikiPage constructed on a Title that cannot exist as a page: Special:Watchlist [Called from Article::newPage].

I figured out how to reproduce this. The problem only occurs if you load the 'ext.discussionTools.init' module while viewing Special:Watchlist (or another special page), as DiscussionTools fetches some metadata about the page using VisualEditor's API.

Thu, Apr 8, 8:07 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor, MediaWiki-API, VisualEditor-MediaWiki, Wikimedia-production-error
matmarex added a project to T279711: WikiPage constructed on a Title that cannot exist as a page: Special:Watchlist [Called from Article::newPage]: Editing-team (FY2020-21 Kanban Board).
Thu, Apr 8, 8:07 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor, MediaWiki-API, VisualEditor-MediaWiki, Wikimedia-production-error
matmarex added a comment to T279141: Discussion tools source mode should display navigation popups when enabled.

For case A, I don't think we can do much, Popups only handles that in the old wikitext editor.

Thu, Apr 8, 7:44 PM · Patch-For-Review, Editing-team, DiscussionTools
matmarex assigned T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null to Esanders.
Thu, Apr 8, 7:06 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, Release-Engineering-Team (Logspam), JavaScript, ContentTranslation, Wikimedia-production-error
matmarex assigned T262842: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) to Esanders.
Thu, Apr 8, 7:06 PM · Editing-team (FY2020-21 Kanban Board), Release-Engineering-Team (Logspam), JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T279707: VisualEditor client-side errors review (April 2021) from To Triage to Triaged on the VisualEditor board.

(added the subtasks that we looked at in today's triage meeting, plus two from the same "batch" that were already on our workboard)

Thu, Apr 8, 7:05 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex added a parent task for T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 7:03 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, Release-Engineering-Team (Logspam), JavaScript, ContentTranslation, Wikimedia-production-error
matmarex added a parent task for T262842: Uncaught TypeError: Cannot read property 'node' of null (in importTable ): T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 7:03 PM · Editing-team (FY2020-21 Kanban Board), Release-Engineering-Team (Logspam), JavaScript, Wikimedia-production-error, VisualEditor
matmarex added subtasks for T279707: VisualEditor client-side errors review (April 2021): T262842: Uncaught TypeError: Cannot read property 'node' of null (in importTable ), T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null.
Thu, Apr 8, 7:03 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex moved T279215: TypeError: content.parts is undefined from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 7:02 PM · JavaScript, Release-Engineering-Team (Logspam), VisualEditor, Wikimedia-production-error
matmarex moved T279169: TypeError: Cannot read property 'node' of undefined / Error: domNode has no ancestor with a .data( 'view' ) from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 7:02 PM · JavaScript, Release-Engineering-Team (Logspam), VisualEditor, Wikimedia-production-error
matmarex moved T279297: Error: Unable to parse title at ve.ce.MWImageNode.static.getDescription from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 7:02 PM · Release-Engineering-Team (Logspam), VisualEditor, ContentTranslation, Wikimedia-production-error
matmarex moved T279299: TypeError: Cannot read property 'canHaveChildrenNotContent' of null at VeCeSurface.ve.ce.Surface.findBlockSlug from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 6:56 PM · Release-Engineering-Team (Logspam), VisualEditor, Wikimedia-production-error
matmarex moved T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 6:56 PM · VisualEditor, Release-Engineering-Team (Logspam), Wikimedia-production-error
matmarex moved T279441: TypeError: Cannot read property 'getModel' of null from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 6:56 PM · VisualEditor, Release-Engineering-Team (Logspam), Wikimedia-production-error
matmarex moved T279313: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackCommand.execute from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 6:56 PM · VisualEditor, Release-Engineering-Team (Logspam), Mobile, Wikimedia-production-error
matmarex moved T279217: TypeError: undefined is not an object (evaluating 'this.mediaUploadBooklet.setFile') from To Triage to Triaged on the VisualEditor board.
Thu, Apr 8, 6:56 PM · JavaScript, Release-Engineering-Team (Logspam), MinervaNeue (Tracking), Mobile, Wikimedia-production-error, VisualEditor
matmarex added a parent task for T279169: TypeError: Cannot read property 'node' of undefined / Error: domNode has no ancestor with a .data( 'view' ) : T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · JavaScript, Release-Engineering-Team (Logspam), VisualEditor, Wikimedia-production-error
matmarex added a parent task for T279215: TypeError: content.parts is undefined: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · JavaScript, Release-Engineering-Team (Logspam), VisualEditor, Wikimedia-production-error
matmarex added a parent task for T279297: Error: Unable to parse title at ve.ce.MWImageNode.static.getDescription: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · Release-Engineering-Team (Logspam), VisualEditor, ContentTranslation, Wikimedia-production-error
matmarex added a parent task for T279217: TypeError: undefined is not an object (evaluating 'this.mediaUploadBooklet.setFile'): T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · JavaScript, Release-Engineering-Team (Logspam), MinervaNeue (Tracking), Mobile, Wikimedia-production-error, VisualEditor
matmarex added a parent task for T279299: TypeError: Cannot read property 'canHaveChildrenNotContent' of null at VeCeSurface.ve.ce.Surface.findBlockSlug: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · Release-Engineering-Team (Logspam), VisualEditor, Wikimedia-production-error
matmarex added a parent task for T279313: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackCommand.execute: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · VisualEditor, Release-Engineering-Team (Logspam), Mobile, Wikimedia-production-error
matmarex added a parent task for T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · VisualEditor, Release-Engineering-Team (Logspam), Wikimedia-production-error
matmarex added a parent task for T279441: TypeError: Cannot read property 'getModel' of null: T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:54 PM · VisualEditor, Release-Engineering-Team (Logspam), Wikimedia-production-error
matmarex added subtasks for T279707: VisualEditor client-side errors review (April 2021): T279217: TypeError: undefined is not an object (evaluating 'this.mediaUploadBooklet.setFile'), T279313: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackCommand.execute, T279441: TypeError: Cannot read property 'getModel' of null, T279321: TypeError: Cannot read property 'isWrapped' of null in shallowCloneFromRange, T279299: TypeError: Cannot read property 'canHaveChildrenNotContent' of null at VeCeSurface.ve.ce.Surface.findBlockSlug, T279297: Error: Unable to parse title at ve.ce.MWImageNode.static.getDescription, T279169: TypeError: Cannot read property 'node' of undefined / Error: domNode has no ancestor with a .data( 'view' ) , T279215: TypeError: content.parts is undefined.
Thu, Apr 8, 6:54 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex created T279707: VisualEditor client-side errors review (April 2021).
Thu, Apr 8, 6:52 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor
matmarex added a comment to T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work.

And thank you for noticing this @Etonkovidova!

Thu, Apr 8, 6:45 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing QA, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), VisualEditor, Editing-team (FY2020-21 Kanban Board), Regression, Mobile
matmarex moved T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work from Code Review to QA on the Editing-team (FY2020-21 Kanban Board) board.

Backported

Thu, Apr 8, 6:34 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing QA, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), VisualEditor, Editing-team (FY2020-21 Kanban Board), Regression, Mobile
matmarex closed T279039: Error contacting the Parsoid/RESTBase server (HTTP 400), a subtask of T266971: "Error contacting the Parsoid/RESTBase server" (HTTP 404/403) and similar errors (catalog), as Resolved.
Thu, Apr 8, 6:14 PM · Parsoid (Third-party), RESTBase, VisualEditor
matmarex closed T279039: Error contacting the Parsoid/RESTBase server (HTTP 400) as Resolved.

I'm glad you got it working. I think we can close this task now.

Thu, Apr 8, 6:14 PM · Editing-team (Third-party), Parsoid (Third-party), VisualEditor
matmarex merged task T278725: how to create lists without marking (bullet or numeric) within visual editor? into T39938: Support for creating and editing definition-lists in VisualEditor.
Thu, Apr 8, 6:11 PM · VisualEditor
matmarex merged T278725: how to create lists without marking (bullet or numeric) within visual editor? into T39938: Support for creating and editing definition-lists in VisualEditor.
Thu, Apr 8, 6:11 PM · Design, Epic, VisualEditor, VisualEditor-EditingTools
matmarex added a comment to T278725: how to create lists without marking (bullet or numeric) within visual editor?.

It can't be done at the moment.

Thu, Apr 8, 6:10 PM · VisualEditor
matmarex added a comment to T267161: Improvements to wide tables in new Vector.

It looks to me like the original problem in this task was already fixed.

Thu, Apr 8, 5:45 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector
matmarex added a comment to T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work.

Yes, scheduled for the next backport window today: https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20210408T1800

Thu, Apr 8, 4:02 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing QA, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), VisualEditor, Editing-team (FY2020-21 Kanban Board), Regression, Mobile
matmarex renamed T247661: "Special:Badtitle/ApiErrorFormatter::getDummyTitle" displayed instead of page title in abusefilter warning with VE from {{FULLPAGENAME}} returns "Special:Badtitle/ApiErrorFormatter::getDummyTitle" in abusefilter warning with VE to "Special:Badtitle/ApiErrorFormatter::getDummyTitle" displayed instead of page title in abusefilter warning with VE.
Thu, Apr 8, 3:42 PM · Editing-team (Tracking), Anti-Harassment, Platform Engineering (Icebox), MediaWiki-API, AbuseFilter, VisualEditor
matmarex moved T279671: Ensure that all of topic subscriptions code is behind the feature flag from Needs Discussion / Investigation to Doing on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Apr 8, 2:47 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a subtask for T274216: Build topic subscriptions v1.0 : T279671: Ensure that all of topic subscriptions code is behind the feature flag.
Thu, Apr 8, 2:47 PM · DiscussionTools
matmarex added a parent task for T279671: Ensure that all of topic subscriptions code is behind the feature flag: T274216: Build topic subscriptions v1.0 .
Thu, Apr 8, 2:47 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a project to T279671: Ensure that all of topic subscriptions code is behind the feature flag: Editing-team (FY2020-21 Kanban Board).
Thu, Apr 8, 2:47 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex created T279671: Ensure that all of topic subscriptions code is behind the feature flag.
Thu, Apr 8, 2:47 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Thu, Apr 8, 1:39 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing QA, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), VisualEditor, Editing-team (FY2020-21 Kanban Board), Regression, Mobile
matmarex edited projects for T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team.
Thu, Apr 8, 1:33 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing QA, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), VisualEditor, Editing-team (FY2020-21 Kanban Board), Regression, Mobile
matmarex claimed T279613: [wmf.38-regression] mobile VE - "oo-ui-icon-close" button does not work.

Caused by 4984c5ffbbf26d6c274d19924d9bda70442eb1b5

Thu, Apr 8, 1:29 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing QA, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), VisualEditor, Editing-team (FY2020-21 Kanban Board), Regression, Mobile

Wed, Apr 7

matmarex added a comment to T279604: [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster.

Yes, a silly mistake, thanks for debugging @Krinkle.

Wed, Apr 7, 11:23 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, Wikimedia-production-error
matmarex moved T279604: [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Apr 7, 11:23 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, Wikimedia-production-error
matmarex claimed T279604: [Regression pre-wmf.38] Getting "error: Call to a member function equals() on boolean" while loading a discussion page on Beta cluster.
Wed, Apr 7, 11:23 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, DiscussionTools, Wikimedia-production-error
matmarex moved T262842: Uncaught TypeError: Cannot read property 'node' of null (in importTable ) from Ready for Sign Off to Blocked / Needs More Work on the Editing-team (FY2020-21 Kanban Board) board.

(check logs after it's deployed)

Wed, Apr 7, 11:14 PM · Editing-team (FY2020-21 Kanban Board), Release-Engineering-Team (Logspam), JavaScript, Wikimedia-production-error, VisualEditor
matmarex updated the task description for T270803: Prevent blocked users from opening the DiscussionTools.
Wed, Apr 7, 11:13 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T270803: Prevent blocked users from opening the DiscussionTools.

No, I don't think the difference matters in the end. As I understand, we were considering different treatments for different block types, but in end end we decided to just do whatever visual editor does (which in turn just does whatever the wikitext editor does), so all special cases are handled elsewhere and we just display the message.

Wed, Apr 7, 11:12 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T263472: [TRACKING] VE navigation issues when cancelling a close from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

All subtasks resolved

Wed, Apr 7, 10:38 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki, VisualEditor
matmarex edited projects for T263472: [TRACKING] VE navigation issues when cancelling a close, added: Editing-team (FY2020-21 Kanban Board); removed Editing-team.
Wed, Apr 7, 10:38 PM · Editing-team (FY2020-21 Kanban Board), VisualEditor-MediaWiki, VisualEditor
matmarex added a comment to T277211: Visual diff change colors hidden by <code> tag.

@A.Amritesh Sorry I didn't reply to your messages earlier, I get lots of notifications. I'm glad you worked it out!

Wed, Apr 7, 10:25 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Skipped QA, Editing-team (FY2020-21 Kanban Board), good first task, VisualEditor, VisualEditor-VisualDiffs
matmarex moved T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null from Needs Discussion / Investigation to Blocked / Needs More Work on the Editing-team (FY2020-21 Kanban Board) board.

(check logs after it's deployed)

Wed, Apr 7, 10:24 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, Release-Engineering-Team (Logspam), JavaScript, ContentTranslation, Wikimedia-production-error
matmarex moved T277211: Visual diff change colors hidden by <code> tag from Needs Discussion / Investigation to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Apr 7, 10:24 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Skipped QA, Editing-team (FY2020-21 Kanban Board), good first task, VisualEditor, VisualEditor-VisualDiffs
Pols12 awarded T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface a Like token.
Wed, Apr 7, 10:23 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a project to T277211: Visual diff change colors hidden by <code> tag: Editing-team (FY2020-21 Kanban Board).
Wed, Apr 7, 10:23 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Skipped QA, Editing-team (FY2020-21 Kanban Board), good first task, VisualEditor, VisualEditor-VisualDiffs
matmarex added a project to T261992: Uncaught TypeError: Cannot read property 'offsetHeight' of null: Editing-team (FY2020-21 Kanban Board).
Wed, Apr 7, 10:21 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, Release-Engineering-Team (Logspam), JavaScript, ContentTranslation, Wikimedia-production-error
matmarex updated the task description for T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface.
Wed, Apr 7, 10:17 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex renamed T53045: VisualEditor: Ctrl+Shift+Space/Opt+Space to insert a non-breaking space (NBSP) from VisualEditor: Ctrl+Space/Opt+Space to insert a non-breaking space (NBSP) to VisualEditor: Ctrl+Shift+Space/Opt+Space to insert a non-breaking space (NBSP).
Wed, Apr 7, 10:13 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), VisualEditor, VisualEditor-ContentEditable
matmarex moved T264904: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak from To Triage to Triaged on the VisualEditor board.
Wed, Apr 7, 10:12 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), Utilities-UnicodeJS, JavaScript, Wikimedia-production-error, VisualEditor
matmarex moved T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface from To Triage to Triaged on the VisualEditor board.
Wed, Apr 7, 10:12 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a project to T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface: VisualEditor.
Wed, Apr 7, 10:11 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface from Needs Discussion / Investigation to Code Review on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Apr 7, 10:05 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex claimed T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface.
Wed, Apr 7, 10:04 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex added a comment to T96701: VE silently alters non-breaking spaces into normal spaces.

Yes, it's easier to keep track of as a separate task. I filed one for this: T279600. I think we didn't test this change with the wikitext editor :(

Wed, Apr 7, 9:48 PM · VisualEditor-MediaWiki-2017WikitextEditor, User-Ryasmeen, Verified, MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Editing-team (FY2020-21 Kanban Board), Parsoid, VisualEditor-MediaWiki, VisualEditor
matmarex created T279600: Inserting a non-breaking space in 2017 Wikitext Editor makes the cursor leave the surface.
Wed, Apr 7, 9:48 PM · VisualEditor, Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
matmarex moved T270803: Prevent blocked users from opening the DiscussionTools from Blocked / Needs More Work to QA on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Apr 7, 9:28 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex updated the task description for T270803: Prevent blocked users from opening the DiscussionTools.
Wed, Apr 7, 9:27 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex updated the task description for T276393: Reply links appear for users who can't edit the page.
Wed, Apr 7, 9:27 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex updated the task description for T276393: Reply links appear for users who can't edit the page.
Wed, Apr 7, 9:25 PM · Editing QA, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex updated the task description for T270803: Prevent blocked users from opening the DiscussionTools.
Wed, Apr 7, 9:25 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T270803: Prevent blocked users from opening the DiscussionTools.

Testing instructions were written on T276393, it seems. Have you seen that, or are those unclear?

Wed, Apr 7, 9:24 PM · Editing QA, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T275821: Reply tool does not work for most comments on community wishlist index pages from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.

This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T275821

Wed, Apr 7, 9:16 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T273413: Cannot reply to a comment with an external link in section title from Blocked / Needs More Work to Code Review on the Editing-team (FY2020-21 Kanban Board) board.

This patch will actually fix the issue. I made a reduced test case and tested it locally, here's a demo as well: https://patchdemo.wmflabs.org/wikis/179220305e/wiki/Talk:T273413

Wed, Apr 7, 9:16 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T273413: Cannot reply to a comment with an external link in section title.

I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!

Wed, Apr 7, 9:10 PM · Patch-For-Review, Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T275821: Reply tool does not work for most comments on community wishlist index pages.

I'm sorry, you're right, this is not fixed. I assumed it would be, but I didn't test it. I'm really sorry for wasting your time!

Wed, Apr 7, 9:09 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T279585: Error on wmf.38 when parsing edit summary via API: Content serialization failed: Failed to decode as application/json.

I think the error message means that action=parse is trying to use the text parameter (which would normally contain the wikitext to parse), except that you did not provide it, and also it's using the content model application/json instead of text/x-wiki because that's the default content model of the main namespace on Wikidata (and the default title when not provided is "API", which is in main namespace).

Wed, Apr 7, 9:01 PM · Wikimedia-production-error, wdwb-tech, Wikidata, Wikidata-Campsite, Platform Engineering, Regression, MediaWiki-API
matmarex moved T264904: Uncaught TypeError: Cannot read property 'length' of null at Object.wordbreak.isBreak from Blocked / Needs More Work to Ready to Be Worked On on the Editing-team (FY2020-21 Kanban Board) board.

That is indeed the same error.

Wed, Apr 7, 7:53 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), Editing-team (FY2020-21 Kanban Board), Utilities-UnicodeJS, JavaScript, Wikimedia-production-error, VisualEditor
matmarex added a parent task for T267663: Adding <small> tag in a reply using DiscussionTools provides no way to auto-close the tag if one wants their signature to be made the same size: T278442: Enable more signature flexibility in discussion tools.
Wed, Apr 7, 7:34 PM · User-RhinosF1, DiscussionTools
matmarex added a parent task for T268558: Allow minor (<small>-wrapped) comments to be saved via the reply link: T278442: Enable more signature flexibility in discussion tools.
Wed, Apr 7, 7:34 PM · DiscussionTools, Editing-team
matmarex added a parent task for T278355: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters: T278442: Enable more signature flexibility in discussion tools.
Wed, Apr 7, 7:34 PM · Editing-team, DiscussionTools
matmarex added a parent task for T279578: Consider a way to suppress the user's signature: T278442: Enable more signature flexibility in discussion tools.
Wed, Apr 7, 7:34 PM · DiscussionTools
matmarex added a parent task for T278357: Discussion tools should recognise three and five tilde signatures and add only the missing part: T278442: Enable more signature flexibility in discussion tools.
Wed, Apr 7, 7:34 PM · Editing-team, DiscussionTools
matmarex added subtasks for T278442: Enable more signature flexibility in discussion tools: T267663: Adding <small> tag in a reply using DiscussionTools provides no way to auto-close the tag if one wants their signature to be made the same size, T268558: Allow minor (<small>-wrapped) comments to be saved via the reply link, T278357: Discussion tools should recognise three and five tilde signatures and add only the missing part, T278355: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters, T279578: Consider a way to suppress the user's signature.
Wed, Apr 7, 7:34 PM · Editing-team, DiscussionTools
matmarex renamed T278355: Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters from Discussion tools doesn't detect a manually-added siganture when followed by any non-whitespace characters to Discussion tools doesn't detect a manually-added signature when followed by any non-whitespace characters.
Wed, Apr 7, 7:33 PM · Editing-team, DiscussionTools
matmarex updated the task description for T278442: Enable more signature flexibility in discussion tools.
Wed, Apr 7, 7:32 PM · Editing-team, DiscussionTools
matmarex added a comment to T279578: Consider a way to suppress the user's signature.

Related: T278442: Enable more signature flexibility in discussion tools and the tasks linked there.

Wed, Apr 7, 7:32 PM · DiscussionTools
matmarex moved T279121: Undo functionality not "sticking" from Ready to Be Worked On to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

I could reproduce this in the demo you linked, but not in the latest version of the code when testing locally (or this new demo I just made today: https://patchdemo.wmflabs.org/wikis/506b59600d/wiki/Talk:Main_Page).

Wed, Apr 7, 7:28 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex updated subscribers of T275949: Implement topic subscription notification bundling.

This has been implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/663894 (it should have been tagged with this task).

Wed, Apr 7, 2:47 PM · Editing-team (Design Backlog), DiscussionTools
matmarex moved T276990: Ensure duplicate notifications are *not* sent for the same talk page event from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.

This has been implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/663894 (it should have been tagged with this task).

Wed, Apr 7, 2:39 PM · Skipped QA, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T264885: Investigate table schema / DB abstraction layer for section/comment watching/unwatching from Doing to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Apr 7, 2:32 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex moved T276996: Hide topic subscription affordance on peoples' own user talk page from Code Review to Ready for Sign Off on the Editing-team (FY2020-21 Kanban Board) board.
Wed, Apr 7, 2:31 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Editing-team (FY2020-21 Kanban Board), DiscussionTools
matmarex added a comment to T264028: Whitespace in <nowiki>…</nowiki> normalized or something.

https://bn.wikipedia.org/w/index.php?title=ব্যবহারকারী_আলাপ:কুউ_পুলক&diff=5000993

Wed, Apr 7, 2:24 PM · DiscussionTools, Parsoid
matmarex merged T279535: Line breaks removed from nowiki by DiscussionTools edit into T264028: Whitespace in <nowiki>…</nowiki> normalized or something.
Wed, Apr 7, 2:23 PM · DiscussionTools, Parsoid
matmarex merged task T279535: Line breaks removed from nowiki by DiscussionTools edit into T264028: Whitespace in <nowiki>…</nowiki> normalized or something.
Wed, Apr 7, 2:23 PM · DiscussionTools

Tue, Apr 6

matmarex committed rEDTO18cbae137ff3: Make sourcemodetoolbar preference available (authored by matmarex).
Make sourcemodetoolbar preference available
Tue, Apr 6, 11:46 PM
matmarex added a comment to T279099: Minor edit marker no longer bolded on diffs.

Backported

Tue, Apr 6, 11:38 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Readers-Web-Backlog (Kanbanana-FY-2020-21), Regression, MediaWiki-Core-Skin-Architecture, MediaWiki-Interface
matmarex committed rEDTO86be6f83daf8: Service to interact with topic subscriptions (authored by DLynch).
Service to interact with topic subscriptions
Tue, Apr 6, 11:29 PM