Page MenuHomePhabricator
Feed Advanced Search

Tue, Apr 9

Dogu added a comment to T355370: [REQUEST] Product review for Adiutor MediaWiki extension.

Hey @Samwalton9-WMF, Firstly, thank you very much for taking the time to review the Adiutor extension and for providing such detailed and constructive feedback. I deeply appreciate your insights, After these reviews, I will release another update for Adiutor and do my best to fix the issues you mentioned.

Tue, Apr 9, 4:18 PM · Adiutor, Moderator-Tools-Team

Feb 24 2024

Dogu added a parent task for T358356: [REQUEST] Code review for PHP in Adiutor extension: T356378: Install Adiutor extension on azwiki.
Feb 24 2024, 1:24 AM · Adiutor
Dogu added a subtask for T356378: Install Adiutor extension on azwiki: T358356: [REQUEST] Code review for PHP in Adiutor extension.
Feb 24 2024, 1:24 AM · Wikimedia-Extension-setup, Adiutor
Dogu added a subtask for T354493: Install Adiutor extension on trwiki: T358356: [REQUEST] Code review for PHP in Adiutor extension.
Feb 24 2024, 1:23 AM · Wikimedia-extension-review-queue, Wikimedia-Extension-setup, User-Tgr, Adiutor, Turkish-Sites
Dogu added a parent task for T358356: [REQUEST] Code review for PHP in Adiutor extension: T354493: Install Adiutor extension on trwiki.
Feb 24 2024, 1:23 AM · Adiutor

Feb 23 2024

Dogu created T358356: [REQUEST] Code review for PHP in Adiutor extension.
Feb 23 2024, 4:02 PM · Adiutor

Feb 11 2024

Dogu moved T357243: The main user-dashboard is using a only-Webkit supported CSS rule value from Backlog to In progress on the Adiutor board.
Feb 11 2024, 11:04 PM · Adiutor
Dogu added a comment to T357243: The main user-dashboard is using a only-Webkit supported CSS rule value.

Hello @Lofhi, thanks for the feedback, I've updated Adiutor gadget's css file and requested necessary changes from your wiki.

Feb 11 2024, 11:04 PM · Adiutor
Dogu claimed T357243: The main user-dashboard is using a only-Webkit supported CSS rule value.
Feb 11 2024, 10:55 PM · Adiutor

Feb 10 2024

Dogu committed rEADI8770208de251: maintenance: Add UpdateConfiguration maintenance script.
maintenance: Add UpdateConfiguration maintenance script
Feb 10 2024, 1:51 AM

Feb 9 2024

Dogu committed rEADI897b9a3642df: Add mobile support for minerva skin.
Add mobile support for minerva skin
Feb 9 2024, 10:48 AM

Feb 7 2024

Dogu updated the task description for T356879: Enable Extension:ContentTranslation for 'translator' user group only on trwiki.
Feb 7 2024, 3:08 PM · Language-Team (Language-2024-April-June), ContentTranslation, Wikimedia-Site-requests, Turkish-Sites
Dogu created T356879: Enable Extension:ContentTranslation for 'translator' user group only on trwiki.
Feb 7 2024, 3:06 PM · Language-Team (Language-2024-April-June), ContentTranslation, Wikimedia-Site-requests, Turkish-Sites

Feb 6 2024

Dogu committed rEADI8fda2762a492: Add revision-icon-ltr.svg icon and update protection-icon-ltr.svg.
Add revision-icon-ltr.svg icon and update protection-icon-ltr.svg
Feb 6 2024, 12:17 AM

Feb 5 2024

Dogu committed rEADIcc6929e022bf: Fix deletion log message display.
Fix deletion log message display
Feb 5 2024, 6:53 PM
Dogu committed rEADI1d7328ee202a: Update dialog components icons and styles.
Update dialog components icons and styles
Feb 5 2024, 6:40 PM
Dogu committed rEADI9cc34640beb4: Update dialog styles VUE components.
Update dialog styles VUE components
Feb 5 2024, 5:16 PM
Dogu committed rEADI040bf16939c0: Refactor requestPageProtection component styles.
Refactor requestPageProtection component styles
Feb 5 2024, 5:16 PM

Feb 4 2024

Dogu committed rEADI783d994bc5c0: Update extension.json with new codexComponents.
Update extension.json with new codexComponents
Feb 4 2024, 9:18 AM
Dogu committed rEADI97a30505a48c: Update author and MediaWiki version in extension.json.
Update author and MediaWiki version in extension.json
Feb 4 2024, 9:05 AM
Dogu committed rEADI07b16689dc29: Refine Codex usages and Vue components.
Refine Codex usages and Vue components
Feb 4 2024, 12:41 AM

Feb 3 2024

Dogu closed T356563: Class 'ResourceLoaderSkinModule' Not Found Error as Invalid.
Feb 3 2024, 10:32 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Dogu created T356578: MediaWiki failing with "RuntimeException: Output already sent!" after entry point refactor.
Feb 3 2024, 10:31 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-ResourceLoader, MediaWiki-Platform-Team
Dogu committed rEADI62e5a12b7d48: Update import path @wikimedia/codex with codex.js.
Update import path @wikimedia/codex with codex.js
Feb 3 2024, 10:06 PM
Dogu placed T356563: Class 'ResourceLoaderSkinModule' Not Found Error up for grabs.
Feb 3 2024, 9:02 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Dogu reopened T356563: Class 'ResourceLoaderSkinModule' Not Found Error as "Open".

When I've updated Vector skin with master branch it fixed, bu now I'm getting following backtraces:

Feb 3 2024, 9:00 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Dogu committed rEADI49a9c9c7369b: Fix formatting in deletionPropose.vue.
Fix formatting in deletionPropose.vue
Feb 3 2024, 8:43 PM
Dogu committed rEADI464bc0589cda: Refactor deletionPropose.vue component.
Refactor deletionPropose.vue component
Feb 3 2024, 8:39 PM
Dogu committed rEADI1d8199c9af0e: Refine Codex usages and Vue components.
Refine Codex usages and Vue components
Feb 3 2024, 8:32 PM
Dogu closed T356563: Class 'ResourceLoaderSkinModule' Not Found Error as Resolved.
Feb 3 2024, 3:34 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)
Dogu created T356563: Class 'ResourceLoaderSkinModule' Not Found Error.
Feb 3 2024, 12:12 PM · Patch-For-Review, MediaWiki-Core-Skin-Architecture (Menus 2.0)

Feb 2 2024

Dogu added a comment to T355358: [REQUEST] Design Systems review for Codex in Adiutor extension.

@AnneT I'm glad to have heard this, thank you for taking the time and showing interest.

Feb 2 2024, 7:50 PM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor

Feb 1 2024

Dogu updated Dogu.
Feb 1 2024, 10:44 PM
Dogu updated Dogu.
Feb 1 2024, 10:44 PM
Dogu added a comment to T355358: [REQUEST] Design Systems review for Codex in Adiutor extension.

Hello @AnneT, first of all, thank you very much for your valuable comments and insights. I really appreciate your acknowledgment of my efforts. Based on your feedbacks, I have prepared a patch that I will push to Gerrit, and I'll add you as a reviewer. I just wanted to ask if there are any obstacles to the deployment of the extension by WMF at the moment. Can I address other minor things in subsequent updates?

Feb 1 2024, 9:55 PM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor
Dogu added a comment to T349598: Create Automoderator extension.

Here, you can see the beta:

https://adiutor.wmcloud.org/wiki/Special:AutoModeratorConfiguration

You can get the config values with mw.config.get("wgAutoModeratorConfiguration")

The labels and the other things can be done with a patch, this is just a beta to show how it works.

Thanks for your interest in Automoderator! As we discussed elsewhere this ticket is an Epic and the current work on setting up Automoderator is only happening internally to the Wikimedia Foundation right now - we're not set up to receive volunteer contributions right now, while we work on the fundamental technology and architecture for this project. We'll make it clearer when we'll be better positioned for volunteer contributions :)

Feb 1 2024, 2:02 PM · Automoderator, Epic, Moderator-Tools-Team
Dogu placed T349598: Create Automoderator extension up for grabs.
Feb 1 2024, 2:02 PM · Automoderator, Epic, Moderator-Tools-Team
Dogu closed T346350: Add revision ID to X-Analytics header as Resolved.
Feb 1 2024, 1:55 PM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Moderator-Tools-Team (Kanban), Traffic, good first task, Data Products, Product-Analytics, Automoderator
Dogu closed T346350: Add revision ID to X-Analytics header, a subtask of T348861: Baseline: What is the average pageview count for vandalism revisions?, as Resolved.
Feb 1 2024, 1:55 PM · Moderator-Tools-Team (Kanban), Product-Analytics (Kanban), Automoderator
Dogu added a subtask for T355150: Application Security Review Request : Adiutor MediaWiki extension: T356378: Install Adiutor extension on azwiki.
Feb 1 2024, 9:40 AM · Adiutor, secscrum, Security, Application Security Reviews
Dogu added a subtask for T355358: [REQUEST] Design Systems review for Codex in Adiutor extension: T356378: Install Adiutor extension on azwiki.
Feb 1 2024, 9:39 AM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor
Dogu added a subtask for T355153: Performance review of Adiutor MediaWiki extension: T356378: Install Adiutor extension on azwiki.
Feb 1 2024, 9:39 AM · Adiutor
Dogu added a subtask for T355370: [REQUEST] Product review for Adiutor MediaWiki extension: T356378: Install Adiutor extension on azwiki.
Feb 1 2024, 9:39 AM · Adiutor, Moderator-Tools-Team
Dogu added parent tasks for T356378: Install Adiutor extension on azwiki: T355358: [REQUEST] Design Systems review for Codex in Adiutor extension, T355153: Performance review of Adiutor MediaWiki extension, T355370: [REQUEST] Product review for Adiutor MediaWiki extension, T355150: Application Security Review Request : Adiutor MediaWiki extension.
Feb 1 2024, 9:39 AM · Wikimedia-Extension-setup, Adiutor
Dogu updated subscribers of T356378: Install Adiutor extension on azwiki.
Feb 1 2024, 9:35 AM · Wikimedia-Extension-setup, Adiutor
Dogu moved T355358: [REQUEST] Design Systems review for Codex in Adiutor extension from Backlog to In progress on the Adiutor board.
Feb 1 2024, 9:11 AM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor

Jan 31 2024

Dogu claimed T356154: Minor typo in urlShortener JavaScript.
Jan 31 2024, 12:13 PM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Patch-For-Review, good first task, MediaWiki-extensions-UrlShortener

Jan 28 2024

Dogu committed rEADI4694d9d0713c: Add PHPUnit test for ChangeTagsHandler.php.
Add PHPUnit test for ChangeTagsHandler.php
Jan 28 2024, 4:48 PM
Dogu committed rEADI8883e2ad6a6b: Make TAG_NAME public in ChangeTagsHandler.php.
Make TAG_NAME public in ChangeTagsHandler.php
Jan 28 2024, 4:45 PM
Dogu committed rEADI05ea9b90d87f: Refactor onSaveUserOptions in PreferencesHandler.
Refactor onSaveUserOptions in PreferencesHandler
Jan 28 2024, 12:11 PM
Dogu committed rEADIe56023055337: Fix method call in PreferencesHandlerTest.
Fix method call in PreferencesHandlerTest
Jan 28 2024, 11:36 AM

Jan 27 2024

Dogu committed rEADI539213d93417: Change AdiutorUtility.extractTemplatesFromParsedContent to synchronous.
Change AdiutorUtility.extractTemplatesFromParsedContent to synchronous
Jan 27 2024, 1:06 PM
Dogu committed rEADI39e922198cd2: Refactor tearDown method in AdiutorTest.php.
Refactor tearDown method in AdiutorTest.php
Jan 27 2024, 12:22 PM
Dogu committed rEADIf89cb290afbf: Refactor user creation in AdiutorMaintenance.php.
Refactor user creation in AdiutorMaintenance.php
Jan 27 2024, 12:17 PM
Dogu added a comment to T349598: Create Automoderator extension.

Here, you can see the beta:

Jan 27 2024, 3:29 AM · Automoderator, Epic, Moderator-Tools-Team
Dogu claimed T349598: Create Automoderator extension.
Jan 27 2024, 12:18 AM · Automoderator, Epic, Moderator-Tools-Team

Jan 26 2024

Dogu committed rEADI5dd8b14dbf63: Move hook handlers from the Hooks to the HookHandlers directory..
Move hook handlers from the Hooks to the HookHandlers directory.
Jan 26 2024, 1:42 PM
Dogu committed rEADI2dfa024f4817: Refactor Adiutor clas, add PHPUnit test and move Hooks.
Refactor Adiutor clas, add PHPUnit test and move Hooks
Jan 26 2024, 1:25 PM
Dogu committed rEADI3577b6dfad5c: Add PermissionManager mock and set it as a service.
Add PermissionManager mock and set it as a service
Jan 26 2024, 9:53 AM
Dogu committed rEADI5eb245081334: Add PHPUnit test for PageDisplayHandler.
Add PHPUnit test for PageDisplayHandler
Jan 26 2024, 2:29 AM
Dogu committed rEADI90b71f12735e: Cleanup PageDisplayHandler for better readability.
Cleanup PageDisplayHandler for better readability
Jan 26 2024, 1:31 AM
Dogu committed rEADI9cfe29699556: Add PHPUnit test for PageSaveCompleteHandler.
Add PHPUnit test for PageSaveCompleteHandler
Jan 26 2024, 1:20 AM

Jan 25 2024

Dogu committed rEADIaeea17a66b26: Rename LocalizationConfiguration to AdiutorLocalConfig and update uses.
Rename LocalizationConfiguration to AdiutorLocalConfig and update uses
Jan 25 2024, 11:21 PM
Dogu added a comment to T346211: Deprecate WebRequest::getRequestId().

It seems that WebRequest::getRequestId() has been deprecated in the latest version of the MediaWiki core repository, based on what I observed in the code.

Jan 25 2024, 1:25 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-libs-HTTP
Dogu closed T353685: PageTriage is not considering "<Ref" as a reference, while checking for unreferenced articles as Resolved.
Jan 25 2024, 1:10 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), good first task, PageTriage
Dogu claimed T353685: PageTriage is not considering "<Ref" as a reference, while checking for unreferenced articles.
Jan 25 2024, 1:34 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), good first task, PageTriage

Jan 24 2024

Dogu updated Dogu.
Jan 24 2024, 8:38 PM
Dogu claimed T346350: Add revision ID to X-Analytics header.
Jan 24 2024, 8:20 PM · MW-1.42-notes (1.42.0-wmf.17; 2024-02-06), Moderator-Tools-Team (Kanban), Traffic, good first task, Data Products, Product-Analytics, Automoderator
Dogu removed a watcher for good first task: Dogu.
Jan 24 2024, 12:07 AM

Jan 23 2024

Dogu added a watcher for good first task: Dogu.
Jan 23 2024, 11:12 PM
Dogu moved T355358: [REQUEST] Design Systems review for Codex in Adiutor extension from In progress to Backlog on the Adiutor board.
Jan 23 2024, 12:56 AM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor
Dogu moved T355358: [REQUEST] Design Systems review for Codex in Adiutor extension from Backlog to In progress on the Adiutor board.
Jan 23 2024, 12:54 AM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor

Jan 21 2024

Dogu committed rEADI706a5efc2384: Add function to extract templates using parse tree.
Add function to extract templates using parse tree
Jan 21 2024, 11:31 PM

Jan 19 2024

Dogu committed rEADI867be6365a37: Add functions to retrieve and update page content with article tags.
Add functions to retrieve and update page content with article tags
Jan 19 2024, 11:27 PM
Dogu committed rEADI29834c4dd805: Fix getModulePolicy function.
Fix getModulePolicy function
Jan 19 2024, 4:54 PM
Dogu added a project to T355370: [REQUEST] Product review for Adiutor MediaWiki extension: Adiutor.
Jan 19 2024, 10:35 AM · Adiutor, Moderator-Tools-Team

Jan 18 2024

Dogu created T355370: [REQUEST] Product review for Adiutor MediaWiki extension.
Jan 18 2024, 11:10 PM · Adiutor, Moderator-Tools-Team
Dogu closed T355249: Change my username on Wikitech as Resolved.
Jan 18 2024, 10:35 PM · wikitech.wikimedia.org, LDAP
Dogu added a comment to T355358: [REQUEST] Design Systems review for Codex in Adiutor extension.

Hi @CCiufo-WMF, thank you for your prompt response! I truly appreciate both design and code reviews. Your feedback and suggestions on how I utilize Codex would be extremely helpful. I am eagerly anticipating your review.

Jan 18 2024, 10:32 PM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor
Dogu updated the task description for T355358: [REQUEST] Design Systems review for Codex in Adiutor extension.
Jan 18 2024, 8:08 PM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor
Dogu created T355358: [REQUEST] Design Systems review for Codex in Adiutor extension.
Jan 18 2024, 7:47 PM · Patch-For-Review, Design, Design-System-Team (DST-Sprint-15 (2024-01-22 to 2024-02-02)), Adiutor
Dogu committed rEADI63cc4b34b7cd: Remove invalid argument from getModulePolicy function call.
Remove invalid argument from getModulePolicy function call
Jan 18 2024, 6:43 PM
Dogu committed rEADI062b92cecce6: Fix PREF_ADIUTOR_ENABLE assignment in PreferencesHandler.
Fix PREF_ADIUTOR_ENABLE assignment in PreferencesHandler
Jan 18 2024, 12:33 AM

Jan 17 2024

Dogu updated Dogu.
Jan 17 2024, 5:18 PM
Dogu created T355249: Change my username on Wikitech.
Jan 17 2024, 5:16 PM · wikitech.wikimedia.org, LDAP
taavi renamed Dogu from Vikipolimer to Dogu.
Jan 17 2024, 4:40 PM
Dogu created T355245: Change my username.
Jan 17 2024, 4:39 PM · Phabricator
Dogu committed rEADI00fcfad217cb: Centralize saveConfiguration in adiutorUtility.js.
Centralize saveConfiguration in adiutorUtility.js
Jan 17 2024, 12:29 PM
Dogu added a project to T355153: Performance review of Adiutor MediaWiki extension: Adiutor.
Jan 17 2024, 11:18 AM · Adiutor
Dogu added a project to T355150: Application Security Review Request : Adiutor MediaWiki extension: Adiutor.
Jan 17 2024, 11:17 AM · Adiutor, secscrum, Security, Application Security Reviews

Jan 16 2024

Dogu added a comment to T355150: Application Security Review Request : Adiutor MediaWiki extension.

@sbassett - We aim to deploy this extension to Wikimedia production as soon as it is ready. I commit to assume maintenance responsibilities once deployment is complete. I will co-operate with the relevant teams at the Wikimedia Foundation to provide oversight to make sure that maintenance, security, and other issues related to sponsorship and support are managed properly. The Turkish Wikipedia community has requested this deployment, so it will be initiated as soon as the necessary permissions are obtained. It is considered a productivity improvement, and there is no strict deadline for deployment. Its non-deployment does not obstruct anyone from performing their tasks. There is currently no sponsoring team, unless Moderator Tools has the capacity to support it. Gergő Tisza is currently reviewing the code, and I am awaiting the VUE code review.

Jan 16 2024, 10:55 PM · Adiutor, secscrum, Security, Application Security Reviews
Dogu committed rEADId906ccddcc37: Implement PageSaveCompleteHook in PageSaveCompleteHandler.
Implement PageSaveCompleteHook in PageSaveCompleteHandler
Jan 16 2024, 3:58 PM
Dogu created T355153: Performance review of Adiutor MediaWiki extension.
Jan 16 2024, 2:52 PM · Adiutor
Dogu created T355150: Application Security Review Request : Adiutor MediaWiki extension.
Jan 16 2024, 2:35 PM · Adiutor, secscrum, Security, Application Security Reviews
Dogu committed rEADI8e0489e7a098: Update onPageSaveComplete method signature.
Update onPageSaveComplete method signature
Jan 16 2024, 1:55 PM
Dogu added a comment to T355063: Add a parameter like "lecurrent" to list=logevents.

I've made this changes, but I'm not sure about the result, however this can be done also using logs index anyway, and filterin on client side.

Index: includes/api/ApiQueryLogEvents.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/includes/api/ApiQueryLogEvents.php b/includes/api/ApiQueryLogEvents.php
--- a/includes/api/ApiQueryLogEvents.php	(revision 5dca00526add34d5c566e882e6763baed9d80a38)
+++ b/includes/api/ApiQueryLogEvents.php	(date 1705362906083)
@@ -272,6 +272,15 @@
 			$this->addOption( 'STRAIGHT_JOIN' );
 		}
Jan 16 2024, 12:12 AM · MediaWiki-Action-API

Jan 15 2024

Dogu added a comment to T355063: Add a parameter like "lecurrent" to list=logevents.

@Vikipolimer Thank you, and yes, something like that. If I were an anonymous user and the log #65 had been action-deleted, then the response array in the 2nd example should be empty because the object in it is the only log that matches the current protection settings of the page Hello.

Jan 15 2024, 7:25 PM · MediaWiki-Action-API
Dogu added a comment to T355063: Add a parameter like "lecurrent" to list=logevents.

Oh, sorry. I posted the wrong test result; that’s why I deleted it. I’ll post it again as soon as I finish.

Jan 15 2024, 4:25 PM · MediaWiki-Action-API
Dogu added a comment to T355063: Add a parameter like "lecurrent" to list=logevents.
Jan 15 2024, 3:51 PM · MediaWiki-Action-API
Dogu committed rEADI2ba4c6160637: Refactor portlet link handling and update links access keys.
Refactor portlet link handling and update links access keys
Jan 15 2024, 1:42 PM