Page MenuHomePhabricator
Feed Advanced Search

Jun 29 2017

Zazpot added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

This proposal is to get rid of that and come up with something better. Solution 1 is to remove the logic that makes the server respond with the content of the target of the redirect and instead respond with a native browser redirect. This means the browser will be told, "nothing here, go to https://en.wikipedia.org/wiki/Foo_events#Foo_2017 instead.". The browser then essentially aborts the load, updates the browser bar, and goes to make another request to the server (transparent to the user). This solves the problem, but does come at the cost of performance. (As user's devices will now sending a request, getting a respond, and then doing the ceremony a second time.)

Jun 29 2017, 9:44 AM · Platform Engineering Roadmap Decision Making, Product-Infrastructure-Team-Backlog-Deprecated, TechCom-RFC (TechCom-RFC-Closed), User-notice, MediaWiki-Redirects
Zazpot added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

In the past, we discussed adding the "redirected from" thing in client-side javascript.

It's unclear (to me) from this remark whether you spotted that the purpose of this issue is, at least in part, to handle cases where client-side JavaScript is not present (e.g. a browser that does not support JavaScript, or that has JavaScript disabled). Probably you already understood that, but I'm adding this clarificatory remark just in case not ;)

To clarify: I was talking about the "redirected from" notice, which at least the current description does not call out as needs-to-work-without-JS. While fundamental functionality like linking clearly shouldn't rely on JS, it might make sense to rely on JS for less critical features like small notices aimed primarily at editors, especially when that enables better cache performance.

Jun 29 2017, 9:29 AM · Platform Engineering Roadmap Decision Making, Product-Infrastructure-Team-Backlog-Deprecated, TechCom-RFC (TechCom-RFC-Closed), User-notice, MediaWiki-Redirects

Jun 28 2017

Zazpot added a comment to T169130: Prevent the addition of Property Constraints to Items.

s/implantated/implemented/ ?

Jun 28 2017, 10:28 PM · Wikibase-Quality-Constraints, Wikidata
Zazpot updated the task description for T169130: Prevent the addition of Property Constraints to Items.
Jun 28 2017, 7:34 PM · Wikibase-Quality-Constraints, Wikidata
Zazpot created T169130: Prevent the addition of Property Constraints to Items.
Jun 28 2017, 7:33 PM · Wikibase-Quality-Constraints, Wikidata
Zazpot added a comment to T168968: [Story] Make Wikidata Query Service accessible without JavaScript.

TLDR: Currently it makes browser to download a result file in application/sparql-results+xml format, which is hard to understand and not what user would expect, IMO.

Jun 28 2017, 5:39 PM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata
Lucas_Werkmeister_WMDE awarded T168968: [Story] Make Wikidata Query Service accessible without JavaScript a Like token.
Jun 28 2017, 10:02 AM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata

Jun 27 2017

Zazpot added a comment to T168968: [Story] Make Wikidata Query Service accessible without JavaScript.

Could you please explain what the motivation behind this is and also what you expect to work without JS?

Jun 27 2017, 7:59 PM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata
Zazpot updated the task description for T168968: [Story] Make Wikidata Query Service accessible without JavaScript.
Jun 27 2017, 7:58 PM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata
Zazpot awarded T168968: [Story] Make Wikidata Query Service accessible without JavaScript a 100 token.
Jun 27 2017, 6:16 PM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata
Zazpot awarded T53814: [Story] Allow editing of statements without JavaScript a 100 token.
Jun 27 2017, 6:15 PM · Story, Wikidata, patch-welcome, MediaWiki-extensions-WikibaseRepository
Zazpot updated the task description for T168968: [Story] Make Wikidata Query Service accessible without JavaScript.
Jun 27 2017, 4:04 PM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata
Zazpot created T168968: [Story] Make Wikidata Query Service accessible without JavaScript.
Jun 27 2017, 3:47 PM · Wikidata-Former-Sprint-Board, Patch-For-Review, Wikidata-Query-Service, Discovery-ARCHIVED, Wikidata

Jun 20 2017

Zazpot added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.
In T53736#3362847, @Tgr wrote:

Related use cases we don't want to break:

Also performance? A HTTP redirect would introduce delay for no good reason (unless we cache it in Varnish and then deal with cache invalidation).

[...] IMO the low-hanging fruit is to just change the text of the redirect warning as suggested in T53736#556866.

Jun 20 2017, 7:36 PM · Platform Engineering Roadmap Decision Making, Product-Infrastructure-Team-Backlog-Deprecated, TechCom-RFC (TechCom-RFC-Closed), User-notice, MediaWiki-Redirects
Zazpot added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

In the past, we discussed adding the "redirected from" thing in client-side javascript.

Jun 20 2017, 7:31 PM · Platform Engineering Roadmap Decision Making, Product-Infrastructure-Team-Backlog-Deprecated, TechCom-RFC (TechCom-RFC-Closed), User-notice, MediaWiki-Redirects

May 30 2017

Zazpot added a comment to T66237: Warns about nonexistent edit conflicts.

https://en.wikipedia.org/w/index.php?title=Feh_%28image_viewer%29&action=edit&undoafter=767731611&undo=782915510 produces an error message claiming that an edit conflict exists.

May 30 2017, 4:17 AM · MediaWiki-Page-editing

May 29 2017

Zazpot awarded T7072: Paragraph splits and moves not identified in diffs a Manufacturing Defect? token.
May 29 2017, 6:24 AM · Better-Diffs-2023, Community-Tech, MediaWiki-Page-diffs
Zazpot added a comment to T7072: Paragraph splits and moves not identified in diffs.

Several people above have suggested that a client-side solution would be acceptable. I disagree.

May 29 2017, 6:23 AM · Better-Diffs-2023, Community-Tech, MediaWiki-Page-diffs
Zazpot added a comment to T7072: Paragraph splits and moves not identified in diffs.

As discussed here, another example of this bug is at https://en.wikipedia.org/w/index.php?title=MalwareTech&diff=782456060&oldid=782449642 . In that diff, both the left and right columns have hunks that begin "Following his work on the WannaCry ransomware attack in 2017" and that are almost identical (edit distance: 3) but that have been aligned with other hunks instead of with each other, making it very hard to spot what has changed between them. (To spare you searching, it is "he's" to "he has".)

May 29 2017, 6:20 AM · Better-Diffs-2023, Community-Tech, MediaWiki-Page-diffs

Nov 22 2016

Zazpot added a comment to T144781: Shortcuts that are redirects to anchors are broken without JavaScript enabled.

everyone has Javascript these days

Nov 22 2016, 2:33 AM · MediaWiki-Redirects

Sep 8 2016

Zazpot added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

User 24.151.10.165 has added a note about this issue on my talk page.

Sep 8 2016, 10:17 PM · Platform Engineering Roadmap Decision Making, Product-Infrastructure-Team-Backlog-Deprecated, TechCom-RFC (TechCom-RFC-Closed), User-notice, MediaWiki-Redirects

Sep 6 2016

Zazpot added a comment to T144781: Shortcuts that are redirects to anchors are broken without JavaScript enabled.

Related to T2218, according to 24.151.10.165.

Sep 6 2016, 4:33 PM · MediaWiki-Redirects
Zazpot added a comment to T144781: Shortcuts that are redirects to anchors are broken without JavaScript enabled.

here's an edit from 2011 that documents this behavior on the English Wikipedia

Sep 6 2016, 2:12 PM · MediaWiki-Redirects
Zazpot added a comment to T53736: Consider changing wikipage redirects to be proper HTTP redirects.

Lahwaacz wrote:
Is the "Redirected from" message really more important than breaking links for browsers with JavaScript disabled? JavaScript should be used to enhance functionality and not to break stuff. Isn't it possible to do it the opposite way and add the "Redirected from" message using a JavaScript when the page was loaded through a HTTP redirect?

Sep 6 2016, 2:11 PM · Platform Engineering Roadmap Decision Making, Product-Infrastructure-Team-Backlog-Deprecated, TechCom-RFC (TechCom-RFC-Closed), User-notice, MediaWiki-Redirects
Zazpot added a comment to T144781: Shortcuts that are redirects to anchors are broken without JavaScript enabled.

matmarkex wrote:
That's not true. Redirects to section always relied on JavaScript, even before that change.

Sep 6 2016, 12:24 PM · MediaWiki-Redirects
Zazpot added a comment to T144781: Shortcuts that are redirects to anchors are broken without JavaScript enabled.

Aklapper wrote:
If they "are currently broken" and do not work, what does that mean? That you still end up on the correct page, just not scrolling to the correct position?

Sep 6 2016, 11:47 AM · MediaWiki-Redirects
Zazpot added a comment to T37045: Use history.replaceState to rewrite redirect urls.

From the user perspective this would have a similar effect to using 301s. It would make end users end up copying the canonical url instead of the redirect's url.

Sep 6 2016, 11:47 AM · MediaWiki-Redirects, MW-1.24-release

Sep 5 2016

Zazpot created T144781: Shortcuts that are redirects to anchors are broken without JavaScript enabled.
Sep 5 2016, 11:35 PM · MediaWiki-Redirects

Jul 24 2016

Zazpot added a comment to T44085: Wikimedia needs a URL shortener (tracking).

Can I ask that the fix [...] prevent the shortened URLs containing characters that are ambiguous in common fonts [...]

Yes, that's already implemented. See T139511: Remove 0 and O from the list of characters as they are visually confusing for some more details.

Jul 24 2016, 12:28 PM · User-Ladsgroup, Proposal, TechCom-RFC (TechCom-RFC-Closed), Tracking-Neverending, OKR-Work, WMF-General-or-Unknown

Jul 22 2016

Zazpot added a comment to T44085: Wikimedia needs a URL shortener (tracking).

Can I ask that the fix for this feature request implement something like newbase42 (which is abandonware, but the principle is clear) in order to prevent the shortened URLs containing characters that are ambiguous in common fonts, such as these characters:

Il10O
Jul 22 2016, 2:21 PM · User-Ladsgroup, Proposal, TechCom-RFC (TechCom-RFC-Closed), Tracking-Neverending, OKR-Work, WMF-General-or-Unknown