Page MenuHomePhabricator
Feed Advanced Search

Jul 8 2019

Alexia renamed T227461: PHPRedis module >= 5.0.0 throws deprecation warnings for delete(). from PHPRedis >= 5.0.0 throws deprecation warnings for delete(). to PHPRedis module >= 5.0.0 throws deprecation warnings for delete()..
Jul 8 2019, 11:55 AM · MW-1.33-notes, Patch-For-Review, MediaWiki-Cache
Alexia created T227461: PHPRedis module >= 5.0.0 throws deprecation warnings for delete()..
Jul 8 2019, 11:41 AM · MW-1.33-notes, Patch-For-Review, MediaWiki-Cache

Jun 14 2019

Krinkle awarded T225843: Performance: Prevent double query for the same User::idFromName() call. a Orange Medal token.
Jun 14 2019, 6:05 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Performance-Team (Radar), MediaWiki-General
Alexia created T225843: Performance: Prevent double query for the same User::idFromName() call..
Jun 14 2019, 5:46 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Performance-Team (Radar), MediaWiki-General

Jun 11 2019

Alexia added a comment to T208881: CSS using var() to create exponential sized calc() on wiki page will crash visitor's browser.

Locally on Gamepedia we are removing this patch due to it negativity affecting many of our wikis breaking styling and layout. This issue only affects Chrome the worst, does not crash Safari(though never finishes loading), and loads fine in Firefox. It should be fixed by the browser vendors as needed.

Jun 11 2019, 6:20 PM · MW-1.33-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MW-1.30-release-notes, MW-1.27-release-notes, Patch-For-Review, MediaWiki-Parser, Vuln-DoS, Security
Alexia added a comment to T211233: Setting the EditPage::POST_EDIT_COOKIE_KEY_PREFIX cookie on every edit causes the Cookie header to be truncated for bots and browsers..

Sounds like this is a known bug in the bots, then?

Jun 11 2019, 3:34 PM · Patch-For-Review, MediaWiki-Page-editing
Alexia added a comment to T211233: Setting the EditPage::POST_EDIT_COOKIE_KEY_PREFIX cookie on every edit causes the Cookie header to be truncated for bots and browsers..

The cookie expires after 20 minutes, and should be removed immediately on successful edit by the JS anyway. Is this not happening in the client?

Jun 11 2019, 3:26 PM · Patch-For-Review, MediaWiki-Page-editing

Jun 9 2019

Alexia closed T211442: Database errors during MovePage operations for file moves causes data loss. as Resolved.
Jun 9 2019, 12:38 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikimedia-Rdbms, Multimedia, MediaWiki-File-management, Commons
Alexia added a comment to T211442: Database errors during MovePage operations for file moves causes data loss..

Looks good to me!

Jun 9 2019, 12:38 AM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikimedia-Rdbms, Multimedia, MediaWiki-File-management, Commons

Jun 2 2019

Danmichaelo awarded T211233: Setting the EditPage::POST_EDIT_COOKIE_KEY_PREFIX cookie on every edit causes the Cookie header to be truncated for bots and browsers. a Stroopwafel token.
Jun 2 2019, 10:34 AM · Patch-For-Review, MediaWiki-Page-editing

Jan 9 2019

Alexia added a comment to T212013: A non-numeric value encountered in includes/LinksUpdateHookHandler.php:142..

The $wgThumbLimits setting is default/stock in the Gamepedia stack.

Jan 9 2019, 12:03 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Readers-Web-Backlog, Patch-For-Review, PageImages
Alexia added a comment to T212013: A non-numeric value encountered in includes/LinksUpdateHookHandler.php:142..

@Alexia, please check the local $wgPageImagesScores setting you are using in your wiki (farm). It seems it contains strings, but should only contain integers.

Jan 9 2019, 11:20 AM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Readers-Web-Backlog, Patch-For-Review, PageImages

Dec 14 2018

Alexia created T212013: A non-numeric value encountered in includes/LinksUpdateHookHandler.php:142..
Dec 14 2018, 9:06 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Readers-Web-Backlog, Patch-For-Review, PageImages

Dec 10 2018

Alexia added a comment to T211442: Database errors during MovePage operations for file moves causes data loss..

I goofed and submitted a buggy patch. See the new patch set.

Dec 10 2018, 7:34 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikimedia-Rdbms, Multimedia, MediaWiki-File-management, Commons
Alexia added a comment to T210891: @import are broken due to be concatenated in the middle of output..

Understood. I changed our local CSS to embed the output of the Google Font URL call directly.(Which is not recommended, but not the worst thing.) We only use it in two places.

Dec 10 2018, 5:50 PM · Performance-Team, MediaWiki-ResourceLoader
Alexia closed T210891: @import are broken due to be concatenated in the middle of output. as Declined.
Dec 10 2018, 5:49 PM · Performance-Team, MediaWiki-ResourceLoader

Dec 7 2018

Alexia created T211442: Database errors during MovePage operations for file moves causes data loss..
Dec 7 2018, 6:32 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Wikimedia-Rdbms, Multimedia, MediaWiki-File-management, Commons

Dec 5 2018

Alexia updated the task description for T211233: Setting the EditPage::POST_EDIT_COOKIE_KEY_PREFIX cookie on every edit causes the Cookie header to be truncated for bots and browsers..
Dec 5 2018, 8:12 PM · Patch-For-Review, MediaWiki-Page-editing
Alexia added a comment to T211233: Setting the EditPage::POST_EDIT_COOKIE_KEY_PREFIX cookie on every edit causes the Cookie header to be truncated for bots and browsers..

This is MediaWiki making many cookies. See EditPage::setPostEditCookie() where it creates the cookie key: $postEditKey = self::POST_EDIT_COOKIE_KEY_PREFIX . $revisionId;

Dec 5 2018, 7:57 PM · Patch-For-Review, MediaWiki-Page-editing
Alexia created T211233: Setting the EditPage::POST_EDIT_COOKIE_KEY_PREFIX cookie on every edit causes the Cookie header to be truncated for bots and browsers..
Dec 5 2018, 7:51 PM · Patch-For-Review, MediaWiki-Page-editing

Dec 4 2018

Pcj awarded T210891: @import are broken due to be concatenated in the middle of output. a Orange Medal token.
Dec 4 2018, 8:50 PM · Performance-Team, MediaWiki-ResourceLoader

Dec 3 2018

Alexia added a comment to T210891: @import are broken due to be concatenated in the middle of output..

I wrote a function to hoist @import up to the top of files, but unfortunately in my digging it seems that resource loader is hell bent on keeping every single file separate until the very last moment. I can not find a good place to put this in.

Dec 3 2018, 7:04 PM · Performance-Team, MediaWiki-ResourceLoader

Nov 30 2018

Alexia updated the task description for T210891: @import are broken due to be concatenated in the middle of output..
Nov 30 2018, 10:11 PM · Performance-Team, MediaWiki-ResourceLoader
Alexia created T210891: @import are broken due to be concatenated in the middle of output..
Nov 30 2018, 9:35 PM · Performance-Team, MediaWiki-ResourceLoader
Alexia added a comment to T204816: LESS in ResourceLoader can't parse two ampersands on one line.

less.php hasn't been touched in two years and has 88 open issues: https://github.com/oyejorge/less.php :/

Nov 30 2018, 9:17 PM · Upstream, Performance-Team (Radar), MediaWiki-ResourceLoader

Nov 27 2018

Alexia closed T210453: DeleteBatch overwrites the global $wgUser context causing errors and session collisions. as Resolved.
Nov 27 2018, 10:37 PM · MediaWiki-extensions-Other, Patch-For-Review
Alexia closed T210429: Update to use OOUI JS button and inputs to fix out of place button. as Resolved.
Nov 27 2018, 10:37 PM · Patch-For-Review, MediaWiki-extensions-Drafts
Alexia updated subscribers of T210453: DeleteBatch overwrites the global $wgUser context causing errors and session collisions..

@ashley: You might be interested in this one since you were working on it recently.

Nov 27 2018, 10:27 PM · MediaWiki-extensions-Other, Patch-For-Review

Nov 26 2018

Alexia added a comment to T210453: DeleteBatch overwrites the global $wgUser context causing errors and session collisions..

The "MediaWiki-extensions-DeleteBatch" tag does not exist so I can not add it.

Nov 26 2018, 9:33 PM · MediaWiki-extensions-Other, Patch-For-Review
Alexia created T210453: DeleteBatch overwrites the global $wgUser context causing errors and session collisions..
Nov 26 2018, 9:33 PM · MediaWiki-extensions-Other, Patch-For-Review
Alexia updated the task description for T210429: Update to use OOUI JS button and inputs to fix out of place button..
Nov 26 2018, 7:21 PM · Patch-For-Review, MediaWiki-extensions-Drafts
Alexia updated subscribers of T210429: Update to use OOUI JS button and inputs to fix out of place button..
Nov 26 2018, 6:16 PM · Patch-For-Review, MediaWiki-extensions-Drafts
Alexia created T210429: Update to use OOUI JS button and inputs to fix out of place button..
Nov 26 2018, 6:10 PM · Patch-For-Review, MediaWiki-extensions-Drafts

Nov 18 2018

Pcj awarded T209543: Cargo causes a DBTransactionStateError when attempting to store when a table does not exist. a Like token.
Nov 18 2018, 5:09 PM · MediaWiki-extensions-Cargo

Nov 15 2018

Alexia created T209600: The #pos parser function will throw E_WARNING if the offset is longer than the string..
Nov 15 2018, 4:13 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), MW-1.32-release, MW-1.31-release, Patch-For-Review, ParserFunctions

Nov 14 2018

Alexia created T209543: Cargo causes a DBTransactionStateError when attempting to store when a table does not exist..
Nov 14 2018, 10:08 PM · MediaWiki-extensions-Cargo

Oct 30 2018

Alexia updated the task description for T208345: Add AWS Aurora MySQL Driver.
Oct 30 2018, 7:38 PM · Core Platform Team Legacy (Watching / External), Patch-For-Review, Wikimedia-Rdbms
Alexia created T208345: Add AWS Aurora MySQL Driver.
Oct 30 2018, 7:36 PM · Core Platform Team Legacy (Watching / External), Patch-For-Review, Wikimedia-Rdbms

Oct 29 2018

Alexia updated the task description for T208268: New AbuseFilterCentralDb class to fix using the wrong credentials for external databases..
Oct 29 2018, 9:17 PM · Patch-For-Review, AbuseFilter
Alexia created T208268: New AbuseFilterCentralDb class to fix using the wrong credentials for external databases..
Oct 29 2018, 9:12 PM · Patch-For-Review, AbuseFilter
Alexia added a comment to T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database..

The recommend fix does work for our extension. I apparently had configured Echo properly in the past so it was working properly. For AbuseFilter I had to patch it to use the same pattern since it only specifies the database and not the cluster to use.

What is the patch diff? There shouldn't be any need to change AbuseFilter itself (at least not git master).

Oct 29 2018, 6:58 PM · Performance-Team, MW-1.32-release, MW-1.31-release, Wikimedia-Rdbms
Alexia added a comment to T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database..

The recommend fix does work for our extension. I apparently had configured Echo properly in the past so it was working properly. For AbuseFilter I had to patch it to use the same pattern since it only specifies the database and not the cluster to use.

Oct 29 2018, 6:22 PM · Performance-Team, MW-1.32-release, MW-1.31-release, Wikimedia-Rdbms

Oct 23 2018

Alexia added a comment to T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database..

Extension:GlobalBlock(No 'ing) is an internal extension that works with Gamepedia/Twitch authentication servers. That code example is based on a previous version of Echo.

Oct 23 2018, 4:13 PM · Performance-Team, MW-1.32-release, MW-1.31-release, Wikimedia-Rdbms

Oct 17 2018

Alexia added a comment to T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database..

We applied this patch as a temporary work around for our MW 1.31 testing.

Oct 17 2018, 5:46 PM · Performance-Team, MW-1.32-release, MW-1.31-release, Wikimedia-Rdbms
Alexia added a comment to T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database..

Previously with MW 1.29 in LoadBalancer::reallyOpenConnection( array $server, $dbNameOverride = false ) $server['dbname'] would only be overwritten if an override was passed. An override was never passed though since LoadBalancer::openConnection() was always passing false for that parameter.

Oct 17 2018, 4:13 PM · Performance-Team, MW-1.32-release, MW-1.31-release, Wikimedia-Rdbms

Oct 16 2018

Alexia created T207223: getDBLoadBalancerFactory()->getExternalLB() returns a LB with the wrong database..
Oct 16 2018, 9:59 PM · Performance-Team, MW-1.32-release, MW-1.31-release, Wikimedia-Rdbms

May 23 2018

Alexia added a comment to T191926: The extraInput array key in LoginSignupSpecialPage was accidentally lowercased which broke extensions that relied on it..

The issue was that when I submitted this patch 1.5 years ago that it broke several extensions that relied on it and had not been updated yet.(Such as ConfirmEdit.) Looking at my current local code base all of those extensions have been updated and no longer rely on it. This can be abandoned.

May 23 2018, 5:52 PM · MediaWiki-User-login-and-signup, Patch-For-Review

Apr 16 2018

Alexia added a comment to T191931: MailAddress needs to be quoting the name part of the mail headers..

I will fix this patch this week.

Apr 16 2018, 5:20 AM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release, MediaWiki-Email, Patch-For-Review

Apr 11 2018

Alexia added a comment to T191937: ResourceLoader LESS cache should vary on wiki-global vars (aside from module own vars).

I will add that task to Hydra's internal Jira to move to extending the Module set of classes for this.

Apr 11 2018, 6:49 PM · MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Performance-Team, MediaWiki-ResourceLoader
Alexia added a comment to T191931: MailAddress needs to be quoting the name part of the mail headers..

I updated the test to match the new conditions.

Apr 11 2018, 6:10 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release, MediaWiki-Email, Patch-For-Review

Apr 10 2018

Alexia added a project to T191933: The old tryUISubmit and the new submitForm will blissfully return Status::newGood() even when it isn't good.: MediaWiki-General.
Apr 10 2018, 10:48 PM · MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), MediaWiki-User-preferences
Alexia updated the task description for T191937: ResourceLoader LESS cache should vary on wiki-global vars (aside from module own vars).
Apr 10 2018, 10:42 PM · MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Performance-Team, MediaWiki-ResourceLoader
Alexia created T191937: ResourceLoader LESS cache should vary on wiki-global vars (aside from module own vars).
Apr 10 2018, 10:40 PM · MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Performance-Team, MediaWiki-ResourceLoader
Alexia created T191934: Add support for HTTP 307 and 308 to OutputPage::redirect.
Apr 10 2018, 10:31 PM · MediaWiki-Interface, Patch-For-Review
Alexia created T191933: The old tryUISubmit and the new submitForm will blissfully return Status::newGood() even when it isn't good..
Apr 10 2018, 10:24 PM · MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), MediaWiki-User-preferences
Alexia created T191931: MailAddress needs to be quoting the name part of the mail headers..
Apr 10 2018, 10:15 PM · MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), MW-1.31-release, MediaWiki-Email, Patch-For-Review
Alexia created T191929: Linker throws E_WARNING when trying to preg_match when an empty expression.
Apr 10 2018, 10:05 PM · MediaWiki-Interface, Patch-For-Review
Alexia created T191927: Abstract out the authentication error handling and call try catch handler.
Apr 10 2018, 9:52 PM · MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), MediaWiki-JobQueue, Performance-Team (Radar)
Alexia created T191926: The extraInput array key in LoginSignupSpecialPage was accidentally lowercased which broke extensions that relied on it..
Apr 10 2018, 9:52 PM · MediaWiki-User-login-and-signup, Patch-For-Review

Apr 9 2018

Alexia added a comment to T191652: ResourceLoader addModuleStyles() ignores dependencies..

@Alexia I believe you misunderstood my example. I've altered the second example below, in hope to provide clarity. If needed, I can also elaborate on the JavaScript example, but let us focus on the styles issue first.
Situation s1:

  • addModuleStyles( [ 'foo' ] )
  • Dependencies supported (e.g. with your patch).
  • foo depends on bar.

Outputs:

/wiki/Example
<link rel=stylesheet href="load.php... foo, bar">

This HTML may be cached. For example, by user web browsers, or by own File Cache, by own cache proxies, or by company cache proxies (office, WiFi, ISP). This cache is public, typically expires after some days, and is validated based on contents and/or timestamp of the wiki page revision.
Situation s2:

  • foo no longer depends on bar, but now depends on quux.
  • foo.css is changed to assume and override styles from quux. Its logic for "bar" is removed.

Expected outcome:

  • Either the page looks the same as before (bar with v1 of "foo", unchanged), or the page looks like the new situation s2.

Actual outcome:

  • Users will view "Example" (still cached) with a request for modules=foo,bar (cache expired, result will be fresh).
  • The response will not contain "quux".
  • The response will contain "bar" and the new version of "foo".
Apr 9 2018, 7:00 PM · Performance-Team, MediaWiki-ResourceLoader
Alexia added a comment to T191652: ResourceLoader addModuleStyles() ignores dependencies..

We also fixed several other context bugs that caused ResourceLoader to rapidly evict the cache due to it not handling cache keys correctly.(Thus causing slow downs due to having to recache constantly.)

Is this referring to T188076?

Apr 9 2018, 5:53 PM · Performance-Team, MediaWiki-ResourceLoader
Alexia added a comment to T191652: ResourceLoader addModuleStyles() ignores dependencies..

(I am trying to follow along, but poorly.) If you remove "quux" from the repository then Javascript would not be able to load it either. It is missing. Though if you mean removing "quux" as a dependency and just hoping it gets included somewhere that would be an odd choice to make. I just deployed this ResourceLoader change out to live Gamepedia/Hydra if you wish to see it live. We have a test wiki available: https://meeseeks.gamepedia.com/Meeseeks_Wiki

Apr 9 2018, 5:35 PM · Performance-Team, MediaWiki-ResourceLoader

Apr 6 2018

Alexia added a comment to T191652: ResourceLoader addModuleStyles() ignores dependencies..

I put in a work around for this on the Hydra Wiki Platform that removes FOUC and puts all the CSS into one minified file.

Apr 6 2018, 6:12 PM · Performance-Team, MediaWiki-ResourceLoader
Alexia created T191652: ResourceLoader addModuleStyles() ignores dependencies..
Apr 6 2018, 6:09 PM · Performance-Team, MediaWiki-ResourceLoader

Mar 15 2018

Alexia updated the task description for T189812: PF_AutoeditAPI.php logs users out on MediaWiki 1.27+ that use the AuthManager and SessionManager API..
Mar 15 2018, 7:17 PM · MediaWiki-extensions-Page_Forms
Alexia created T189812: PF_AutoeditAPI.php logs users out on MediaWiki 1.27+ that use the AuthManager and SessionManager API..
Mar 15 2018, 7:16 PM · MediaWiki-extensions-Page_Forms
Alexia created T189786: Fix User::idFromName() ignoring cache for non-existent users..
Mar 15 2018, 3:38 PM · MW-1.31-release-notes (WMF-deploy-2018-03-20 (1.31.0-wmf.26)), Patch-For-Review, MediaWiki-User-management

Mar 12 2018

Alexia added a comment to T188474: SQLinjection in Extension:Cargo CREATE TABLE.

I just got notification of this. Patched on Gamepedia/Hydra wikis. However, our version of MySQL is patched already for the table of death issue.

Mar 12 2018, 2:19 PM · Vuln-Inject, MediaWiki-extensions-Cargo, Security

Feb 28 2018

Alexia added a comment to T148701: Automatic references list after page-terminal ordered or bullet list generates unbalanced HTML.
Feb 28 2018, 10:12 PM · good first bug, Cite

Feb 1 2018

Alexia added a comment to T186146: Anonymous users editing a page do not trigger Cargo to update a table..

Many years ago there were several third party extensions that had a habit of opening new database transactions, but never closing them. So as a work around in several of Hydra's own extensions we put $db->commit() in place to fix them breaking transactions.

Feb 1 2018, 7:03 PM · MediaWiki-extensions-Cargo
Alexia added a comment to T186146: Anonymous users editing a page do not trigger Cargo to update a table..

This was the entire change. Basically it had not been updated for MediaWiki's newer API for atomic database transactions.

Feb 1 2018, 4:39 PM · MediaWiki-extensions-Cargo
Alexia added a comment to T186146: Anonymous users editing a page do not trigger Cargo to update a table..

I found the issue. Another extension was throwing an exception for logged out users that was causing this issue for Cargo. However, due to an exception handling change in MediaWiki 1.29 those kind of exceptions were quietly being dropped and MediaWiki would go on pretending everything was fine.

Feb 1 2018, 4:27 PM · MediaWiki-extensions-Cargo
Alexia closed T186146: Anonymous users editing a page do not trigger Cargo to update a table. as Invalid.
Feb 1 2018, 4:26 PM · MediaWiki-extensions-Cargo
Alexia added a comment to T186146: Anonymous users editing a page do not trigger Cargo to update a table..

Morning update: I have found that the hook "PageContentSaveComplete" is not being ran or being interrupted somehow. The onPageContentSaveComplete function in Cargo never gets called.

Feb 1 2018, 4:14 PM · MediaWiki-extensions-Cargo
Alexia added a comment to T186146: Anonymous users editing a page do not trigger Cargo to update a table..

Regular page edits through the standard source editor are what cause this behavior.

Feb 1 2018, 8:02 AM · MediaWiki-extensions-Cargo

Jan 31 2018

Alexia created T186146: Anonymous users editing a page do not trigger Cargo to update a table..
Jan 31 2018, 8:05 PM · MediaWiki-extensions-Cargo

Jan 9 2018

Alexia created T184543: "ParseError: Unrecognised input in ../mmv.mixins.less" (due to unescaped input?).
Jan 9 2018, 5:49 PM · MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Patch-For-Review, Multimedia, MediaViewer

Dec 2 2017

Alexia added a comment to T181818: DynamicPageList uncaught exception PHP fatal error.

@Reception123 DPL3 is meant to replace all previous iterations of DPL.

Dec 2 2017, 3:12 PM · DynamicPageList (Wikimedia)
Alexia added a comment to T181818: DynamicPageList uncaught exception PHP fatal error.

You should not be running both of these extensions at the same time. Intersection is a legacy extension and fork/branch of the previous iterations of DPL.

Dec 2 2017, 2:52 PM · DynamicPageList (Wikimedia)

Nov 17 2017

Alexia added a comment to T180550: Reserved MySQL keywords cause query errors..

It probably will! I will get this fix deployed on the Gamepedia stack today.

Nov 17 2017, 3:37 PM · MediaWiki-extensions-Cargo

Nov 16 2017

Alexia added a comment to T180550: Reserved MySQL keywords cause query errors..

A similar error on line 244 of drilldown/CargoFilter.php. Path of Exile has weapons with range so that conflicts with the MySQL reserved word.

Nov 16 2017, 8:44 PM · MediaWiki-extensions-Cargo

Nov 15 2017

Alexia created T180550: Reserved MySQL keywords cause query errors..
Nov 15 2017, 1:48 AM · MediaWiki-extensions-Cargo

Aug 7 2017

Alexia closed T172707: wfLoadExtension shim breaks on case sensitive file systems. as Resolved.
Aug 7 2017, 4:41 PM · EasyTimeline
Alexia added a comment to T172707: wfLoadExtension shim breaks on case sensitive file systems..

I think I know why this happened then. Our development machines are OS X case-insensitive. So most likely at some point it was capitalized way in the past, but future file copies went fine since OS X will not rename/ignore the difference. I will mark this as closed.

Aug 7 2017, 4:41 PM · EasyTimeline
Alexia created T172707: wfLoadExtension shim breaks on case sensitive file systems..
Aug 7 2017, 4:31 PM · EasyTimeline

Jul 26 2017

Alexia created T171749: Argument 1 passed to DOMXPath::__construct() must be an instance of DOMDocument..
Jul 26 2017, 2:58 PM · MediaWiki-extensions-RandomImage

Jun 2 2017

Alexia created T166913: Create a conversion utility to update extension manifest v1 to v2..
Jun 2 2017, 9:38 PM · MediaWiki-Maintenance-scripts, Patch-For-Review

May 26 2017

Alexia added a comment to T165981: Implement a prototype JavaScript review system for MediaWiki.

On Gamepedia we use a vetting process before giving people administrator level access and we actively engage with the administrators in our IRC/Slack channels. However, an extension like this would be useful once the number of wikis/admins grow past what is reasonable to handle. As for taking over accounts we have our own AuthenticationProvider and SessionProvider that more or less mitigates those possibilities.(I won't say it is impossible though!)

May 26 2017, 8:20 AM · Security, Developer-Advocacy, MediaWiki-extension-requests, Security-General, JavaScript, Wikimedia-Hackathon-2017

Jan 5 2017

Alexia added a comment to T151770: Frequent loss of session data in Firefox (since around 2016-11-28).

I can confirm that our editors at Gamepedia are experiencing the same issue with *.gamepedia.com wikis. Our top wiki editors primarily use Firefox and they all began to experience this issue after upgrading to Firefox 50 in November 2016. Since there are many wikis they visit they regularly break that 150 cookie limit. I tested and checked this with an editor today observing that despite cookies being set on individual subdomains(example.gamepedia.com) Firefox is keeping a limit of 150 cookies for the whole of gamepedia.com.

Jan 5 2017, 10:12 PM · User-notice, Upstream, Browser-Support-Firefox, MediaWiki-Authentication-and-authorization, Contributors-Team

Oct 19 2016

Alexia added a comment to T147212: Do not rely on indexed fields in MySQL queries in CargoUtils::getTables()..

I made a patch that fixes all of these instances.

Oct 19 2016, 6:13 PM · MediaWiki-extensions-Cargo
Alexia added a comment to T147212: Do not rely on indexed fields in MySQL queries in CargoUtils::getTables()..

This shows up as issue in the CargoTables special page as well.

Oct 19 2016, 5:38 PM · MediaWiki-extensions-Cargo

Oct 3 2016

Alexia created T147212: Do not rely on indexed fields in MySQL queries in CargoUtils::getTables()..
Oct 3 2016, 5:31 PM · MediaWiki-extensions-Cargo

Aug 15 2016

Alexia created T143041: [Spike: 1 hour] The mobileaction URL toggle piece only sets a cookie on special pages..
Aug 15 2016, 7:47 PM · Spike, Readers-Web-Backlog, MobileFrontend

May 21 2016

Alexia added a comment to T135876: setupSkinUserCss (Hook SkinVectorStyleModules) is no longer called..

That doesn't explain anything. I still don't see why the small change in when the hook gets called broke your extension. The function is still called, and it's still called with the same parameters. So is the hook in Vector.

May 21 2016, 9:29 AM · Readers-Web-Backlog (Tracking), Vector
Alexia added a comment to T135876: setupSkinUserCss (Hook SkinVectorStyleModules) is no longer called..

That change was part of https://gerrit.wikimedia.org/r/#/c/273745/ by @Krinkle.
The setupSkinUserCss() method should still be called from OutputPage::buildCssLinks(). Is that not working for you for some reason?

May 21 2016, 8:21 AM · Readers-Web-Backlog (Tracking), Vector

May 20 2016

Alexia created T135876: setupSkinUserCss (Hook SkinVectorStyleModules) is no longer called..
May 20 2016, 8:57 PM · Readers-Web-Backlog (Tracking), Vector

Mar 15 2016

Alexia added a comment to T101652: Unclosed "Enlarge" <a> tag from thumbnail is leaking on Special:BookSources.

Here is a very simple way to reproduce it tossing it into any page. $wgTidyConfig is the default of null and $wgUseTidy is the default of false. I have not figured out a fix yet.

Mar 15 2016, 8:26 PM · ImageMap, MediaWiki-Parser, MediaWiki-Special-pages

Feb 16 2016

Alexia added a comment to T126644: Investigation: Gamepedia's cross-wiki watchlist code.

The develop branch contains several untested fixes that should make it easier to run it outside the Hydra Wiki Platform.

  • Switched to CentralIdLookup factory.
  • Renamed $dsSiteKey to $wgSiteKey - This will have to be defined per site configuration.
  • Database schema updates will run if the site being updated has $wgSiteKey set to 'master'.
Feb 16 2016, 8:55 PM · Community-Tech

Feb 12 2016

Alexia added a comment to T126644: Investigation: Gamepedia's cross-wiki watchlist code.

Now open sourced:
https://github.com/HydraWiki/GlobalWatchlist

Feb 12 2016, 9:52 PM · Community-Tech

Feb 11 2016

Alexia added a comment to T126644: Investigation: Gamepedia's cross-wiki watchlist code.

Yes, it is on my list to make open source. I am not entirely sure it will be usable in its current state due it being a memory hog. My 20% time is on Fridays so I will look at this tomorrow and sanitize any strings that might be considered proprietary before pushing it up to GitHub.

Feb 11 2016, 9:59 PM · Community-Tech