This may deserve another separate ticket, but I see a bunch of articles where they have legend-dictated shading for the tables yet in dark mode it doesn’t carry over
Nov 30 2021
Nov 28 2021
Hi any update on this ticket?
@MattCleinman do you ever see an item like this being picked up or do items that fall into the backlog like this ultimately fall into the “we’re not gonna fix it” category
Are any of the open tickets planning to address the more common dark issues that appear quite often more directly OR is leaving it to the editors to notice the route you guys are sticking to the most right now?
Nov 12 2021
I’d also be curious if the preview feature will basically be a “passing the buck” of responsibility to the template editors that may ultimately result in a lot of prolonged inaction and a continued ruined experience with dark mode in the apps?
Sep 7 2021
@MSantos, wanted to circle back just once more please on Infobox baseball biography vs Infobox NFL biography please.
Hey @MSantos, again not to oversimplify but wanted to circle back to one approach one more time please just to make sure it’s indeed not possible as it seems to me like a feasible approach .
Aug 27 2021
@MSantos just checked the wmflabs preview pages and perhaps you’re right (if so my apologies). Was just surprising as it always appears the examples I provide are fixed ahead of the other examples that are identical. But perhaps vadim or whomever is fixing it is fastracking those examples leading to me jumping the gun🤷♂️
Aug 26 2021
@MSantos @vadim-kovalenko, I’m still very confused why it appears some of these articles are being fixed. But only as one offs and tons of other errored articles remain. Wouldn’t fixing the templates improve them in bulk? What makes them unique?
Aug 25 2021
The one last thing I’ll say (this is more subjective), since you pointed out how the templates are unique, is that I do like how the theming works for NBA and NFL players more than how it is for MLB where the theming applies to the succeeding headers as opposed to the titular athlete name box
Aug 24 2021
@MSantos, are some of these items being fixed article-by-article, one by one, rather than being addressed with a more universal approach?
Aug 23 2021
@MSantos, I have a good bit more but I’m saving them on the back burner for now so as not to overwhelm as these cover most use cases. Will reevaluate once we make headway on the above.
@MSantos any specific reason you left off the first few bullets regarding TV items for the edit above?
Hi @MSantos, would you agree with most of what’s outlined in previous comment? (Especially still a ton of black on black and white on white in TV templates and for sports, most themes are still missing in dark mode)
Aug 17 2021
Hey @MSantos, for my last comment I was actually specifically focusing on TV episode tables as that was more specific to this thread
Aug 16 2021
@MSantos, hi circling back again. Since I saw at least a fix was deployed today, just want to make sure you’re aware this is still of issue with most articles. While athlete pages are by far the most off, focusing solely on just TV episode page tables as this ticket does, there are still tons of episode pages that haven’t been fixed. Apologies if jumping the gun, but since I saw it was in deployed state, just wanted to make sure as we’ve already gone through 4 rounds before without it ever hitting the core examples I first sent.
Jul 14 2021
Thanks @vadim-kovalenko for the update. Yes was following that patch but wasn’t sure since it didn’t seem to have an update in a few weeks. Keep in mind I had added some variations even beyond those covered in https://phabricator.wikimedia.org/T252904 above, but I’ll stay tuned
Jul 13 2021
Any chance to get an update please @MSantos @vadim-kovalenko but any chance to confirm if you agree on any of the more recent comments? Not to be too impatient but I opened this ticket here late in 2020 and have been emailing support even months before that. Understand that merge requests take time but I am hoping to approach this more universally rather than template-by-template if at all possible, but if there’s a 3 month gap between every single time we add a new merge request in this may take years to fix. As shown by some of the images in my comment prior to this, so many articles are affected where not only is text hard to read but even invisible in dark mode. And I’m sure you don’t want to create an experience where we have to constantly bounce between dark and light themes
Jul 8 2021
@MSantos @vadim-kovalenko, while my past two comments went more in depth, still think athlete pages like these are the ones that have been most affected by the recent changes. As mentioned above, the dark pages have actually deprecated since the work started. Should be pretty clear to see the drastic difference between light and dark mode:
•black text on black background
•completely obscured text
•split half-light&half dark panels, etc.
Jun 23 2021
Hi @vadim-kovalenko, thanks for the update. Few remarks
Jun 12 2021
May 3 2021
Thanks @MattCleinman understood it wasn’t a high priority and that’s ok!, but hopefully bug backlog means hopefully at some point this year (maybe during a bug fixing sprint) and not into an abyss of prob falling off forever 😬. But thank you for confirming!
Apr 30 2021
Hey @MattCleinman, did my latest comment allow for you to reproduce this consistently?
Apr 24 2021
Ah ok, that makes total sense, thanks @Art.tsymbar sorry to doubt. Just wanted to make sure it wasn’t an accidental revert. Appreciate the work :)
Apr 23 2021
Hey @MSantos @Art.tsymbar this actually regressed. You guys did patchwork for the light themes and I mentioned the issue persists still in dark mode. I noticed last month on the betas, that the improvement for light mode was reverted as well and it went back to how it was originally. I chose to be patient and wait until the public update though to circle back which was published today, but it’s the same situation. Is that intended?
Mar 9 2021
@MattCleinman, I have a much more succinct way to sum up this issue. If You go down enough in a longer article, the TOC will never scroll to keep up with your progress for the first attempt. All that matters to reproduce is if you proceed straight to a section beyond the break in the TOC
Feb 25 2021
Awesome. Thanks @MSantos, glad to hear it does sound like it can be patched as well as opposed to being chalked up to the editors responsibility. Will stay tuned, but probably revisit this once you guys have a chance to go about the 2nd go-around to see if any common edge-cases still slip through that may be able to grabbed in bulk :)
Feb 23 2021
Jan 21 2021
As simply a passionate user who’s been pushing for this to be improved for a bit, assuming this being pushed to code review means good things, just wanted to pop in to say thanks for the work! 👌