Mentioned in SAL (#wikimedia-operations) [2025-12-07T02:05:58Z] <ladsgroup@cumin1003> dbctl commit (dc=all): 'Repooling after maintenance db1212 (T410589)', diff saved to https://phabricator.wikimedia.org/P86439 and previous config saved to /var/cache/conftool/dbconfig/20251207-020558-ladsgroup.json

https://www.mediawiki.org/w/index.php?title=Help:Merge_history&diff=prev&oldid=8062608

Change #1216183 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/core@master] Improve wording of MergeHistory merge notice

https://gerrit.wikimedia.org/r/1216183

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/560850/3/src/Cite.php#496 Line 496 is now:
$responsive !== null ? $responsive !== '0' : $wgCiteResponsiveReferences,

I ran a poll on fedi – options 2 and 3 each got 3/5 votes (so one person voted for both), option 1 got none, nobody suggested anything else. @Legoktm raised the good point that option 3 is best for usage with TypeScript, because you can enforce correct parameters (and, in the case of JSON-returning methods, provide more information about the response structure) with a lot of overloads like:

In T411926#11438373, @IKhitron wrote:

In T411926#11438369, @Tacsipacsi wrote:

I tried, but the Patch Demo destroyed the wiki entirely, because I've fixed the patch after your comments, and it needs Jenkins bot approval.

That sounds like another bug: if you’re not allowed to update a patch demo, it should just not do anything, rather than destroying the existing patch demo…

You are absolutely right.

I am not very sure, but it looks like a problem with this commit, doesn't it? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/560850

@thiemowmde: With this I add you as subscriber because of this: https://de.wikipedia.org/wiki/Wikipedia:Technik/Werkstatt#VE_tut_ungefragt_Dinge_%282%29

If a patch by someone as experiences as Sohom Datta languishes without review for a year this clearly isn't a good first task.

This is trickier then it looks - on large wikis like enwiki most groups do have a project-namespace page about the group so linking to the specific page like https://en.wikipedia.org/wiki/Wikipedia:Administrators is better than https://en.wikipedia.org/wiki/Special:ListUsers/sysop

In T228194#5834707, @Addshore wrote:

Need to verify if this is still happening.

Oh, I am not familiar with this area. I filed for MediaWiki-Codesniffer just because they mentioned that particular sniff, which may also need to be fixed.

Apparently nobody cares.

What's left here is shuffling through abandoned, unmaintained codebases. That's the antithesis of a good first task.

Thank you for tagging this task with good first task for Wikimedia newcomers!

This is not a playground.

Since this requires cross-file type information, it’s more like the job of phan, isn’t it?

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/486

In T411890#11438103, @Cookroach wrote:

Thanks you very much Ragesoss for your restoration work. Which data records or which time period have actually been lost and cannot be restored? Background: We have a challenge that started on December 1. best regards

Mobile width (640px) is when tables in Minerva are set to display: block among other qualities and given the behavior here this is probably specifically width: fit-content at tables.less line 16 which was added due to T402066. That rationale seems fine to me.

https://github.com/internetarchive/internetarchivebot/pull/165

Thanks for fixing this, my bad!

Change #1215531 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SUL3: Show expiry message only if user isn't logged-in centrally

https://gerrit.wikimedia.org/r/1215531

Change #1215531 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] SUL3: Show expiry message only if user isn't logged-in centrally

https://gerrit.wikimedia.org/r/1215531

I think these three address the issues around mw.ext.cargo.declare, and a possible TypeError on mw.ext.cargo.store. Still, .store could benefit from some type checking improvements (check if literal then type-convert to string) as previously there's been a number of issues resulting from this not being done, so this task shouldn't be closed just yet. (I can submit a patch probably some time during the week). Other decent improvement would be throwing inside of .declare on an error rather than requiring that the user includes the output (which may be a null) in their function's output.

The number of places where we have to check $wgWatchlistExpiry has grown since this task was filed. Running this by the MediaWiki Stakeholders' Group sounds fine. The only argument for keeping it is with third party usage. Such users here include myself and presumably Sam, who were also incidentally co-authors of this feature. But the line must drawn somewhere… I see folks asking for even more features with respect to watchlist expiry, so my opinion has since changed. At this point, the maintenance burden is probably outweighing the benefits of offering a simpler experience for smaller wikis.

Change #1216155 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] IcuCollation: Support numeric sorting for non-default collations

https://gerrit.wikimedia.org/r/1216155

Possible that this patch results in a minor regression with non-wikitext pages no longer saving records to special tables like _pageData. Posting this just to document the difference, I don't think it's really significant.

Change #1216143 had a related patch set uploaded (by Alex44019; author: Alex44019):

[mediawiki/extensions/Cargo@master] LuaLibrary: In `declare`, improve argument handling and forward impl. output

https://gerrit.wikimedia.org/r/1216143

Change #1216144 had a related patch set uploaded (by Alex44019; author: Alex44019):

[mediawiki/extensions/Cargo@master] LuaLibrary: In `store`, remove PHP argument type hints and indicate correct function on type error

https://gerrit.wikimedia.org/r/1216144

Change #1216145 had a related patch set uploaded (by Alex44019; author: Alex44019):

[mediawiki/extensions/Cargo@master] CargoDeclare: Perform the namespace check inside `declareTable`

https://gerrit.wikimedia.org/r/1216145

Test wiki created on Patch demo by IKhitron using patch(es) linked to this task:
https://567e917e4e.catalyst.wmcloud.org/w/

The "our" part of the bug is resolved, continuing to work.

In T411926#11438369, @Tacsipacsi wrote:

I tried, but the Patch Demo destroyed the wiki entirely, because I've fixed the patch after your comments, and it needs Jenkins bot approval.

That sounds like another bug: if you’re not allowed to update a patch demo, it should just not do anything, rather than destroying the existing patch demo…

You are absolutely right.

In T411926#11438337, @taavi wrote:

This is the reason:

2025-12-06T19:05:23.364972084Z: Composer plugins have been disabled for safety in this non-interactive session.
2025-12-06T19:05:23.365021154Z: Set COMPOSER_ALLOW_SUPERUSER=1 if you want to allow plugins to run as root/super user.
2025-12-06T19:05:23.365033373Z: Do not run Composer as root/super user! See https://getcomposer.org/root for details

composer-merge-plugin is required for composer to pick up dependencies from extensions, and if that does not run then exactly this will happen.

Thanks a lot, @Tacsipacsi, it works. Part of the patch is fine, part isn't, I'll debug it tomorrow, I think.