Change 975889 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Revert "Disable flakey test"

https://gerrit.wikimedia.org/r/975889

Merged and backported to production; you might need ?action=purge on Parsoid Read Views pages for a while to get the sidebar links correct, since we need to regenerate the page without the <base href> in the ParserOutput::addHeadItems.

We originally didnt add Echo to the sticky header due to technical debt relating to the extension (T343838) and uncertainty around whether it will be ported to Codex. I'd say that's a subtask(blocker) for this task.

This will be implemented as part of T346689

Others have already commented on the integration benefits, user expectations, and operational cost/complexity trade-offs. I'll mention that I agree with Moriel and Gergő. I think an extension yields product results quicker, and costs less both in human effort and operational cost.

Change 975919 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Make the limited width and font size controls work for logged in users

https://gerrit.wikimedia.org/r/975919

That might share a similar root cause as T282893: Various CI jobs failing after "mkdir: cannot create directory ‘log’: Permission denied"

Please review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/975908 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/975918 and move to QA.

Change 975918 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] MobileDiff: bytes removed/no change icon should be rotated

https://gerrit.wikimedia.org/r/975918

@Eileenmcnaughton It looks like my WMF Stock import template is good now - all mapping fields are saving as well as the rules at the top of the mapping page. I tested this one with fake data and it worked! We just have to figure out the civi auto TYL suppression rules so it doesn't send a TY for gifts $10K and up. At the moment I think it is just suppressing all until we do that.

@taavi Is this problem due to CPU limit?

Sorry, just getting back to this. I tested the new wordmark on my local. I'm on a retina monitor so I can't say if it looks better (though I think it does), but it's also a little bit larger than the current tagline, which I think would help too. Would this arrangement be OK?

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:46:54Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:975596|[parsoid] Fix Parsoid relative links (T350952)]] (duration: 19m 32s)

In T346689#9322243, @AAlhazwani-WMF wrote:

i'm able to reproduce both issues (the increased border radius, and the missing border radius reset when the menu is open) if i visit the link that you shared on an iPhone SE 2020, iOS 17.1.1, both Safari and Firefox for iOS

and also when i open the same link in the iOS simulator, iPhone SE 2023, iOS 16.4, Safari

Change 972524 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove all usages of mw-ui-icon- prefix in MobileFrontend

https://gerrit.wikimedia.org/r/972524

Some notes today:

Change 975889 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Revert "Disable flakey test"

https://gerrit.wikimedia.org/r/975889

In T334634#8904574, @matmarex wrote:

So the user is supposed to be logged in and on the mobile website for this test, but in these videos, they are logged out and on desktop website.

There are currently several issues open about logging in on mobile not working, see e.g. T312042 and the other reports linked there. This is probably the root cause, and not the test itself.

The page loads for me. I don't have any specific edits to the config I want to make right now so can't test anything else about it.

I tried a few of the bugs linked in T257852#9252513 that had clear reproduction steps, and closed 3 that were definitely fixed by this work (T335125 T312042 T318138).

I can't reproduce this today.

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:28:40Z] <catrope@deploy2002> catrope and cscott: Backport for [[gerrit:975596|[parsoid] Fix Parsoid relative links (T350952)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:27:22Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:975596|[parsoid] Fix Parsoid relative links (T350952)]]

Change 975596 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.5] [parsoid] Fix Parsoid relative links

https://gerrit.wikimedia.org/r/975596

Looks resolved by @Tgr's changes in T257852.

Mentioned in SAL (#wikimedia-operations) [2023-11-20T22:15:41Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:975366|Revert "mw.notify: Limit width of overlay to max-width-page-container" (T349622)]] (duration: 17m 40s)

Looks resolved by @Tgr's changes in T257852.

Looks resolved by @Tgr's changes in T257852.

Patch has been reverted. Over to Justin for design.

In my testing this has been resolved by @fgiunchedi's patch

Mentioned in SAL (#wikimedia-operations) [2023-11-20T21:59:22Z] <catrope@deploy2002> jdlrobson and catrope: Backport for [[gerrit:975366|Revert "mw.notify: Limit width of overlay to max-width-page-container" (T349622)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-20T21:58:00Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:975366|Revert "mw.notify: Limit width of overlay to max-width-page-container" (T349622)]]

Change 975366 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.42.0-wmf.5] Revert "mw.notify: Limit width of overlay to max-width-page-container"

https://gerrit.wikimedia.org/r/975366

Thanks for spotting this @JMando, having looked through the transactions, this seems unique to Adyen.

Change 975915 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Add a strict regex on $field on expression builder

https://gerrit.wikimedia.org/r/975915

@Punith.nyk Thank you for this bug report. It would be helpful if you described the issue using words rather than the attached mp4 screen recording. What screen were you on? What were you trying to accomplish? What unexpected behavior did you find? https://www.mediawiki.org/wiki/How_to_report_a_bug has some additional advice on creating actionable bug reports.

While $field can take raw SQL but it's different from status quo drastically, we don't take fields from user input so the chance of sql injection is much lower, on top of that, the plan is have strict regex on field (allowing only a-zA-Z\d\.) so it's different from the current wild west.

Mentioned in SAL (#wikimedia-operations) [2023-11-20T21:38:16Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:975879|Disable MobileFrontend AMC drawer temporarily while erroring (T351669)]] (duration: 22m 11s)

Going to post about this here since, although I solved the problem myself, this was what came up when I searched for it, so maybe other people will be here scratching their heads:

I also found this in whatwg spec:

<iframe sandbox src="https://usercontent.example.net/getusercontent.cgi?id=12193"></iframe>
[Warning!] It is important to use a separate domain so that if the attacker convinces the user to visit that page directly, the page doesn't run in the context of the site's origin, which would make the user vulnerable to any attack found in the page.

Mentioned in SAL (#wikimedia-operations) [2023-11-20T21:17:24Z] <catrope@deploy2002> catrope and jdlrobson: Backport for [[gerrit:975879|Disable MobileFrontend AMC drawer temporarily while erroring (T351669)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)