01tonythomas (Tony Thomas)
Volunteer, Past GSoC+Outreachy org-admin with Wikimedia

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:03 PM (176 w, 1 d)
Availability
Available
IRC Nick
tonythomas
LDAP User
01tonythomas
MediaWiki User
01tonythomas

You can find me either on #wikimedia-dev, #wikimedia-devrel or not find at all.

E-mail : 01tonythomas [at] gmail [dot] com

Lately found here too: https://www.mediawiki.org/wiki/Code_of_Conduct/Committee_members#Tony_Thomas_.2801tonythomas.29

Recent Activity

Wed, Feb 14

01tonythomas awarded T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California a Love token.
Wed, Feb 14, 5:46 PM · Developer-Relations (Jan-Mar-2018), Google-Code-in-2017

Mon, Feb 12

01tonythomas added a comment to T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California.

Since I couldnt mentor as many tasks as I mentored last year, I dont know where my answer stands - but count me in as well if there is space :P

Mon, Feb 12, 4:42 PM · Developer-Relations (Jan-Mar-2018), Google-Code-in-2017

Thu, Feb 1

01tonythomas closed T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work, a subtask of T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes, as Resolved.
Thu, Feb 1, 4:45 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work as Resolved.

All patchsets merged, closing now. Thanks.

Thu, Feb 1, 4:45 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183821: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work as Resolved.

All patchsets merged, closing now. Thanks.

Thu, Feb 1, 4:44 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183821: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work, a subtask of T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace, as Resolved.
Thu, Feb 1, 4:44 AM · MediaWiki-extensions-Newsletter

Wed, Jan 31

01tonythomas created T186093: Coordinate MediaWiki Training 2018, Bangalore.
Wed, Jan 31, 6:32 AM · User-Jayprakash12345, events

Jan 13 2018

01tonythomas closed T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php` as Resolved.
Jan 13 2018, 11:01 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Jan 13 2018, 11:01 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Jan 3 2018

01tonythomas reassigned T183189: Special:Newsletter/id/subscribers does not properly update subscriber count from 01tonythomas to Phantom42.
Jan 3 2018, 6:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter
01tonythomas closed T183189: Special:Newsletter/id/subscribers does not properly update subscriber count as Resolved.

Nice catch. Thanks!

Jan 3 2018, 6:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter

Dec 31 2017

01tonythomas added a comment to T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes.

Thanks, works!

Dec 31 2017, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes as Resolved.
Dec 31 2017, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes, a subtask of T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace, as Resolved.
Dec 31 2017, 4:59 PM · MediaWiki-extensions-Newsletter

Dec 30 2017

01tonythomas created T183821: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work.
Dec 30 2017, 4:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work.
Dec 30 2017, 4:00 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas added a project to T183818: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created : Google-Code-in-2017.
Dec 30 2017, 3:56 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes.
Dec 30 2017, 3:55 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183818: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created .
Dec 30 2017, 3:52 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace.
Dec 30 2017, 3:51 PM · MediaWiki-extensions-Newsletter
01tonythomas created T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace.
Dec 30 2017, 3:48 PM · MediaWiki-extensions-Newsletter
01tonythomas added a project to T183816: [Unit testing] Add unit tests to Newsletter create operations: Google-Code-in-2017.

This should possibly go to tests/specials/SpecialNewsletterCreateTest.php as well.

Dec 30 2017, 3:41 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T183816: [Unit testing] Add unit tests to Newsletter create operations.
Dec 30 2017, 3:41 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183816: [Unit testing] Add unit tests to Newsletter create operations.
Dec 30 2017, 3:39 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas reopened T183632: [Unit testing] Add unit tests to Newsletter validations as "Open".

My patchset https://gerrit.wikimedia.org/r/#/c/399995/ is sadly open.

Dec 30 2017, 3:28 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T166002: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear as Resolved.
Dec 30 2017, 3:05 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T178743: Remove code duplication in EditPage and NewsletterContentUpdate as Resolved.

Oh yes. resolving then.

Dec 30 2017, 3:04 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), MediaWiki-extensions-Newsletter
01tonythomas created T183813: [Unit testing] Unit test `newsletterExistsForMainPage` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 3:03 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183812: [Unit testing] Unit test `getSubscribersFromID` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 3:01 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183811: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 2:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php`.
Dec 30 2017, 2:57 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183809: [Unit testing] Unit test `getPublishersFromID` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 2:55 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183808: [Unit testing] Unit test `getNewsletterSubscribersCount` in `includes/NewsletterDb.php`.
Dec 30 2017, 2:53 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183806: [Unit testing] Unit test `addNewsletterIssue` in `includes/NewsletterDb.php`.
Dec 30 2017, 2:48 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183618: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` as Resolved.
Dec 30 2017, 2:46 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183618: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 30 2017, 2:46 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183620: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` as Resolved.
Dec 30 2017, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183620: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 30 2017, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 29 2017

01tonythomas closed T183658: Add/Remove/Notify of Publishers should happen in bulk as Resolved.

Thanks :)

Dec 29 2017, 9:18 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 28 2017

01tonythomas closed T183616: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php` as Resolved.

Nice one! Thanks.

Dec 28 2017, 8:33 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183616: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 28 2017, 8:33 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate as Resolved.

Great work. Thanks !

Dec 28 2017, 9:41 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate, a subtask of T183632: [Unit testing] Add unit tests to Newsletter validations, as Resolved.
Dec 28 2017, 9:41 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 27 2017

01tonythomas closed T183619: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php` as Resolved.
Dec 27 2017, 8:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183619: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 27 2017, 8:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 26 2017

01tonythomas closed T183622: [Unit testing] Unit test `restoreNewsletter` in `includes/NewsletterDb.php` as Resolved.

Nice. Thank you!

Dec 26 2017, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183622: [Unit testing] Unit test `restoreNewsletter` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 26 2017, 2:44 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183614: [Unit testing] Unit test removeSubscription in `includes/NewsletterDb.php` as Resolved.

Thanks, keep it coming!

Dec 26 2017, 1:49 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183614: [Unit testing] Unit test removeSubscription in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 26 2017, 1:49 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183617: [Unit testing] Unit test `addNewsletter` in `includes/NewsletterDb.php` as Resolved.

Thanks. Keep it coming!

Dec 26 2017, 11:09 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183617: [Unit testing] Unit test `addNewsletter` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 26 2017, 11:09 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate.

@Ryan10145 I see the point. Can you try creating the first one like - https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/tests/specials/SpecialNewsletterCreateTest.php#L44 (that is a direct creation to the db, but not a problem).

Dec 26 2017, 9:57 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183621: [Unit testing] Unit test `deleteNewsletter` in `includes/NewsletterDb.php` as Resolved.

Thanks!

Dec 26 2017, 9:49 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183621: [Unit testing] Unit test `deleteNewsletter` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 26 2017, 9:49 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 25 2017

01tonythomas closed T183635: [GCI][Unit testing] Unit test condition "The main page should exist" in NewsletterCreate as Resolved.
Dec 25 2017, 10:05 AM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183635: [GCI][Unit testing] Unit test condition "The main page should exist" in NewsletterCreate, a subtask of T183632: [Unit testing] Add unit tests to Newsletter validations, as Resolved.
Dec 25 2017, 10:05 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 24 2017

01tonythomas closed T183615: [Unit testing] Unit test addPublisher in `includes/NewsletterDb.php` as Resolved.

Nice work! Thanks.

Dec 24 2017, 12:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183615: [Unit testing] Unit test addPublisher in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 24 2017, 12:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183658: Add/Remove/Notify of Publishers should happen in bulk.
Dec 24 2017, 12:11 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 23 2017

01tonythomas updated the task description for T183632: [Unit testing] Add unit tests to Newsletter validations.
Dec 23 2017, 5:06 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate.
Dec 23 2017, 5:05 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183637: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate.
Dec 23 2017, 5:04 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183635: [GCI][Unit testing] Unit test condition "The main page should exist" in NewsletterCreate.
Dec 23 2017, 5:02 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas edited projects for T183632: [Unit testing] Add unit tests to Newsletter validations, added: Google-Code-in-2017; removed Patch-For-Review.
Dec 23 2017, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T183632: [Unit testing] Add unit tests to Newsletter validations.
Dec 23 2017, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183632: [Unit testing] Add unit tests to Newsletter validations.
Dec 23 2017, 4:14 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas added a project to T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension: Google-Code-in-2017.
Dec 23 2017, 12:20 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183622: [Unit testing] Unit test `restoreNewsletter` in `includes/NewsletterDb.php`.
Dec 23 2017, 12:19 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183621: [Unit testing] Unit test `deleteNewsletter` in `includes/NewsletterDb.php`.
Dec 23 2017, 12:18 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183620: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php`.
Dec 23 2017, 12:17 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183619: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php`.
Dec 23 2017, 12:16 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183618: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php`.
Dec 23 2017, 12:15 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183617: [Unit testing] Unit test `addNewsletter` in `includes/NewsletterDb.php`.
Dec 23 2017, 12:14 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183616: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php`.
Dec 23 2017, 12:13 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183615: [Unit testing] Unit test addPublisher in `includes/NewsletterDb.php`.
Dec 23 2017, 12:12 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183614: [Unit testing] Unit test removeSubscription in `includes/NewsletterDb.php`.
Dec 23 2017, 12:11 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension.
Dec 23 2017, 12:05 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 20 2017

01tonythomas added a comment to T183189: Special:Newsletter/id/subscribers does not properly update subscriber count.

Wow. then its a bug then. Let me deploy the latest to our http://newsletter-test.wmflabs.org/

Dec 20 2017, 12:37 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter

Dec 19 2017

01tonythomas added a comment to T183189: Special:Newsletter/id/subscribers does not properly update subscriber count.

Well, I see that the counts are getting updated on all sub/unsub from http://newsletter-test.wmflabs.org/wiki/Special:Newsletters -- and due to our application limitations of course, we cannot update this on real time when you have it done on say a seperate tab on http://newsletter-test.wmflabs.org/wiki/Special:Newsletter/2/subscribe.

Dec 19 2017, 8:29 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter
01tonythomas added a comment to T183189: Special:Newsletter/id/subscribers does not properly update subscriber count.

Yes yes. I can mentor. Lets make this happen.

Dec 19 2017, 10:12 AM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter

Dec 1 2017

01tonythomas added a comment to T180987: Inconsistent descriptions in the Newsletter interface for creating and unsubscribing .

@divadsn Great work. just to let you know that a task is closed as Resolved only after the corresponding patchests that fix it gets merged to master branch (or wherever it should go to). Not a problem, but just keep in mind from next time.

Dec 1 2017, 8:39 PM · MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Nov 13 2017

01tonythomas added a comment to T180392: Newsletter notifications should be Notices instead of Alerts.

Change 391088 had a related patch set uploaded (by Chico Venancio; owner: Chico Venancio):
[mediawiki/extensions/Newsletter@master] [bugfix] Newsletter: notifications as Notices, not ALerts

https://gerrit.wikimedia.org/r/391088

Nov 13 2017, 9:28 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T180392: Newsletter notifications should be Notices instead of Alerts.

Is there a list somewhere of all the notification types?

Nov 13 2017, 9:19 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T180392: Newsletter notifications should be Notices instead of Alerts.

@Quiddity Is this all notifications or a specific kind?

Nov 13 2017, 8:52 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter

Nov 4 2017

01tonythomas updated subscribers of T169412: Strange behaviour on Newsletter ApiEdit with bad publishers field .

@Florian : without the patch, on a request:

Nov 4 2017, 4:49 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated subscribers of T174667: Newsletter extension doesn't notify users when they are removed as publishers.

@Florian is one it people 😎

Nov 4 2017, 2:46 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T163486: Newsletter::fillParserOutput might have slave lag issues as Resolved.

Closing as resolved.

Nov 4 2017, 2:45 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175497: Fields of newsletter not being updated in the newsletter info page.

Probably caused to our APIEdit stuff, which is kind of fixed one of these days. Can someone confirm this is happening now ?

Nov 4 2017, 2:44 PM · MediaWiki-extensions-Newsletter
01tonythomas awarded T179573: Need more code reviewers? a Yellow Medal token.
Nov 4 2017, 1:51 PM · MediaWiki-extensions-Newsletter

Oct 23 2017

01tonythomas removed a project from T127961: From field should reflect the origin domain: Easy.

Hi , I am new to media wiki codebase. Could you tell me where to get started with this issue?

Oct 23 2017, 4:53 PM · MediaWiki-Email

Oct 21 2017

01tonythomas added a comment to T178743: Remove code duplication in EditPage and NewsletterContentUpdate.

Let me attach a screen record to show that things are not broken after this refactor. (also contains how to test this one).

Oct 21 2017, 5:13 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), MediaWiki-extensions-Newsletter
01tonythomas created T178743: Remove code duplication in EditPage and NewsletterContentUpdate.
Oct 21 2017, 5:00 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), MediaWiki-extensions-Newsletter

Oct 15 2017

01tonythomas added a comment to T163486: Newsletter::fillParserOutput might have slave lag issues.

I think this should be resolved now. Right @Bawolff ?

Oct 15 2017, 12:54 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T178154: Newsletter content pages should use "Edit" and instead of "Edit source".

ah. I see it when the user is non-admin though.

Oct 15 2017, 12:53 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T178154: Newsletter content pages should use "Edit" and instead of "Edit source".

Cannot reproduce this - as look at this one here:

Oct 15 2017, 12:51 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T177064: When creating a newsletter, the default newsletter page should be offered as Main Page.

well - this can affect the logic a bit as we require the page to exist during the time of Newsletter creation. Can be changed, of course.

Oct 15 2017, 12:49 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175069: A Newsletter publisher can announce a new issue without providing a title for it.

I think it wasnt submission without a title, but submission without a summary - as - it throws up an errror whenever the title box is not set. Its a question if we want to make the Summary optional or mandatory.

Oct 15 2017, 12:45 PM · MediaWiki-extensions-Newsletter
01tonythomas claimed T166002: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear.
Oct 15 2017, 12:18 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

Well - we have some basic thingy there. https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/ff7c57489a539320a63b9c25f745c072e9680ae8/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js#L140

Oct 15 2017, 10:00 AM · MediaWiki-extensions-Newsletter

Oct 14 2017

QuimGil awarded T174667: Newsletter extension doesn't notify users when they are removed as publishers a Party Time token.
Oct 14 2017, 10:31 PM · Patch-For-Review, MediaWiki-extensions-Newsletter