01tonythomas (Tony Thomas)
Volunteer, Past GSoC+Outreachy org-admin with Wikimedia

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:03 PM (163 w, 18 h)
Availability
Available
IRC Nick
tonythomas
LDAP User
01tonythomas
MediaWiki User
01tonythomas

You can find me either on #wikimedia-dev, #wikimedia-devrel or not find at all.

E-mail : 01tonythomas [at] gmail [dot] com

Lately found here too: https://www.mediawiki.org/wiki/Code_of_Conduct/Committee_members#Tony_Thomas_.2801tonythomas.29

Recent Activity

Mon, Nov 13

01tonythomas added a comment to T180392: Newsletter notifications should be Notices instead of Alerts.

Change 391088 had a related patch set uploaded (by Chico Venancio; owner: Chico Venancio):
[mediawiki/extensions/Newsletter@master] [bugfix] Newsletter: notifications as Notices, not ALerts

https://gerrit.wikimedia.org/r/391088

Mon, Nov 13, 9:28 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T180392: Newsletter notifications should be Notices instead of Alerts.

Is there a list somewhere of all the notification types?

Mon, Nov 13, 9:19 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T180392: Newsletter notifications should be Notices instead of Alerts.

@Quiddity Is this all notifications or a specific kind?

Mon, Nov 13, 8:52 PM · MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)), Patch-For-Review, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter

Sat, Nov 4

01tonythomas updated subscribers of T169412: Strange behaviour on Newsletter ApiEdit with bad publishers field .

@Florian : without the patch, on a request:

Sat, Nov 4, 4:49 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated subscribers of T174667: Newsletter extension doesn't notify users when they are removed as publishers.

@Florian is one it people 😎

Sat, Nov 4, 2:46 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T163486: Newsletter::fillParserOutput might have slave lag issues as Resolved.

Closing as resolved.

Sat, Nov 4, 2:45 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175497: Fields of newsletter not being updated in the newsletter info page.

Probably caused to our APIEdit stuff, which is kind of fixed one of these days. Can someone confirm this is happening now ?

Sat, Nov 4, 2:44 PM · MediaWiki-extensions-Newsletter
01tonythomas awarded T179573: Need more code reviewers? a Yellow Medal token.
Sat, Nov 4, 1:51 PM · MediaWiki-extensions-Newsletter

Mon, Oct 23

01tonythomas removed a project from T127961: From field should reflect the origin domain: Easy.

Hi , I am new to media wiki codebase. Could you tell me where to get started with this issue?

Mon, Oct 23, 4:53 PM · MediaWiki-Email

Oct 21 2017

01tonythomas added a comment to T178743: Remove code duplication in EditPage and NewsletterContentUpdate.

Let me attach a screen record to show that things are not broken after this refactor. (also contains how to test this one).

Oct 21 2017, 5:13 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas created T178743: Remove code duplication in EditPage and NewsletterContentUpdate.
Oct 21 2017, 5:00 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter

Oct 15 2017

01tonythomas added a comment to T163486: Newsletter::fillParserOutput might have slave lag issues.

I think this should be resolved now. Right @Bawolff ?

Oct 15 2017, 12:54 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T178154: Newsletter content pages should use "Edit" and instead of "Edit source".

ah. I see it when the user is non-admin though.

Oct 15 2017, 12:53 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T178154: Newsletter content pages should use "Edit" and instead of "Edit source".

Cannot reproduce this - as look at this one here:

Oct 15 2017, 12:51 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T177064: When creating a newsletter, the default newsletter page should be offered as Main Page.

well - this can affect the logic a bit as we require the page to exist during the time of Newsletter creation. Can be changed, of course.

Oct 15 2017, 12:49 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175069: A Newsletter publisher can announce a new issue without providing a title for it.

I think it wasnt submission without a title, but submission without a summary - as - it throws up an errror whenever the title box is not set. Its a question if we want to make the Summary optional or mandatory.

Oct 15 2017, 12:45 PM · MediaWiki-extensions-Newsletter
01tonythomas claimed T166002: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear.
Oct 15 2017, 12:18 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

Well - we have some basic thingy there. https://github.com/wikimedia/mediawiki-extensions-VisualEditor/blob/ff7c57489a539320a63b9c25f745c072e9680ae8/modules/ve-mw/ui/inspectors/ve.ui.MWLinkAnnotationInspector.js#L140

Oct 15 2017, 10:00 AM · MediaWiki-extensions-Newsletter

Oct 14 2017

QuimGil awarded T174667: Newsletter extension doesn't notify users when they are removed as publishers a Party Time token.
Oct 14 2017, 10:31 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T166002: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear.

If someone can type in what a real description looks like, one of the devs can add that in few minutes 😎

Oct 14 2017, 6:59 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas claimed T174667: Newsletter extension doesn't notify users when they are removed as publishers.
Oct 14 2017, 6:58 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174667: Newsletter extension doesn't notify users when they are removed as publishers.

New shiny notifs up!

Oct 14 2017, 6:48 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated subscribers of T174664: Support interwiki links for new Newsletter issues.

Alright - one way to fix this would be to define a separate text field for Newsletter extension which ignores any titles that has a <> : <> I dont know how exactly feasible this is (like should we validate if the left is a valid interwiki ? How to do that ? @Bawolff @Addshore might know this ?

Oct 14 2017, 6:14 PM · MediaWiki-extensions-Newsletter
01tonythomas created T178230: No documentation on interwiki role (Mediawiki Vagrant).
Oct 14 2017, 5:59 PM · MediaWiki-Vagrant, Documentation

Oct 7 2017

D3r1ck01 awarded T159075: Fix character escaping throughout the extension files a Mountain of Wealth token.
Oct 7 2017, 5:34 PM · Patch-For-Review, MediaWiki-extensions-Newsletter

Sep 2 2017

01tonythomas added a comment to T174602: Double notification received for becoming a Newsletter publisher.

There are 2 EchoEvent::create calls for "EchoEvent::create"

One in NewsletterDataUpdate and one in NewsletterEditPage

Sep 2 2017, 10:30 AM · Patch-For-Review, User-Addshore, MediaWiki-extensions-Newsletter

Aug 31 2017

01tonythomas added a comment to T174602: Double notification received for becoming a Newsletter publisher.

I am not sure. I still think there is something with the Echo job queue here. Might not be a newsletter triggered thing as I tried condition (3) mentioned above just now - and only got *one*. Can someone from the echo team take a look, or someone with Echo jobs take a look at what is happening ?

Aug 31 2017, 12:15 PM · Patch-For-Review, User-Addshore, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174602: Double notification received for becoming a Newsletter publisher.

@01tonythomas I just added you as publisher to https://test.wikipedia.org/wiki/Newsletter:The_Technical_Collaboration_Observer

Did you receive one or two notifications?

Aug 31 2017, 10:15 AM · Patch-For-Review, User-Addshore, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174602: Double notification received for becoming a Newsletter publisher.

@Qgil I just tried to reproduce this - but sadly couldnt. I just get one notification. My only assumption was that the form was submitted twice. Can you check this thing now (after our yesterdays patch - which was unrelated though) ?

Aug 31 2017, 10:04 AM · Patch-For-Review, User-Addshore, MediaWiki-extensions-Newsletter

Aug 30 2017

01tonythomas added a comment to T174605: HTTP Error 500 when trying to publish a Newsletter issue in test.wikipedia.org.
[DBQuery] my_wiki ROLLBACK /* MWExceptionHandler::rollbackMasterChangesAndLog */
[exception] [3cc99aa78a37d851d8c41bdb] /core/index.php/Special:Newsletter/1/announce Error from line 331 of /var/www/html/core/extensions/Newsletter/includes/specials/SpecialNewsletter.php: Call to undefined method Newsletter::getSubscriberCount()
[DBQuery] my_wiki BEGIN /* Wikimedia\Rdbms\Database::query (LCStoreDB::get) */
Aug 30 2017, 8:31 PM · RelEng-Archive-FY201718-Q1, Patch-For-Review, Regression, MediaWiki-extensions-Newsletter
01tonythomas closed T173282: Unused class ApiNewsletterManage.php in Newsletter extension ? as Resolved.

The patch has been merged. Is the problem fixed now?

Aug 30 2017, 6:28 AM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, MediaWiki-extensions-Newsletter

Aug 13 2017

01tonythomas added a comment to T169412: Strange behaviour on Newsletter ApiEdit with bad publishers field .

Well - this second patch - 371763 - https://gerrit.wikimedia.org/r/#/c/371763/2 shows a better error message though

Aug 13 2017, 10:50 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T169412: Strange behaviour on Newsletter ApiEdit with bad publishers field .

^^ that patch can fix the fatal - but still dont show up a clear error message to the client like "Bad username in publishers field"

Aug 13 2017, 10:27 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas created T173282: Unused class ApiNewsletterManage.php in Newsletter extension ?.
Aug 13 2017, 10:19 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, MediaWiki-extensions-Newsletter

Jul 26 2017

01tonythomas renamed T171709: Create ext:Newsletter tasks/feature/enhancement goals for Wikimania Hackathon 2017 from Create tasks/feature/enhancement goals for Wikimania Hackathon 2017 to Create ext:Newsletter tasks/feature/enhancement goals for Wikimania Hackathon 2017.
Jul 26 2017, 8:25 AM · Wikimania-Hackathon-2017, MediaWiki-extensions-Newsletter
01tonythomas created T171709: Create ext:Newsletter tasks/feature/enhancement goals for Wikimania Hackathon 2017.
Jul 26 2017, 8:25 AM · Wikimania-Hackathon-2017, MediaWiki-extensions-Newsletter

Jul 1 2017

01tonythomas updated subscribers of T169423: UsersMultiselectWidget does not show the usernames anymore .
Jul 1 2017, 11:13 AM · OOjs-UI
01tonythomas created T169423: UsersMultiselectWidget does not show the usernames anymore .
Jul 1 2017, 11:12 AM · OOjs-UI
01tonythomas created T169421: Newsletter publisher name not showing up correctly on Manage page. .
Jul 1 2017, 10:48 AM · MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas created T169412: Strange behaviour on Newsletter ApiEdit with bad publishers field .
Jul 1 2017, 9:32 AM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), Patch-For-Review, MediaWiki-extensions-Newsletter

Jun 29 2017

01tonythomas added a comment to T110170: Goal: Deploy Newsletter extension in Wikimedia.

Woho. We got the final blocker https://gerrit.wikimedia.org/r/#/c/355226/ too merged! Yay! Time to get this on prod!

Jun 29 2017, 6:03 PM · wikimedia-extension-review-queue, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), User-Addshore, Patch-For-Review, User-notice, Goal, Community-Liaisons, Wikimedia-Hackathon-2016, MediaWiki-extensions-Newsletter

Jun 26 2017

Johan awarded T115095: Security review of Newsletter extension a Like token.
Jun 26 2017, 2:44 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter
Trizek-WMF awarded T115095: Security review of Newsletter extension a Like token.
Jun 26 2017, 2:39 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter
Elitre awarded T115095: Security review of Newsletter extension a Like token.
Jun 26 2017, 2:39 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter

Jun 23 2017

01tonythomas added a comment to T115095: Security review of Newsletter extension.

A month later... this security review is still open and the extension hasn't been deployed yet. @01tonythomas, can you explain what is the status, please?

Jun 23 2017, 12:32 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter

Jun 12 2017

01tonythomas added a member for TCB-Team: 01tonythomas.
Jun 12 2017, 6:00 PM
01tonythomas removed a watcher for TCB-Team: 01tonythomas.
Jun 12 2017, 6:00 PM

Jun 10 2017

01tonythomas placed T66312: Move "Permanent link" out of the sidebar toolbox (behind "last modified" timestamp) up for grabs.
Jun 10 2017, 3:13 PM · Patch-For-Review, Easy, Design, MediaWiki-General-or-Unknown
01tonythomas placed T49544: <references/> list item must not wrap the text in <span> up for grabs.
Jun 10 2017, 3:12 PM · Wikisource, Patch-For-Review, Technical-Debt, Easy, Cite
01tonythomas closed T144143: Mailgun extension producing PHP Fatal Error about dependency Guzzle6 as Resolved.
Jun 10 2017, 3:11 PM · MediaWiki-extensions-Mailgun
01tonythomas added a comment to T132287: Convert Special:AbuseLog to use HTMLForm.

anything left here ? Or should this be Resolved ?

Jun 10 2017, 3:11 PM · MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), Patch-For-Review, AbuseFilter
01tonythomas placed T65577: Create a "Watching and notifications" tab in MediaWiki core up for grabs.
Jun 10 2017, 3:10 PM · Collaboration-Team-Triage, Patch-For-Review, Easy, MediaWiki-User-preferences
01tonythomas added a comment to T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories.
  1. I have no objection to having the code of conduct in the repositories
  2. If anything i would encourage it
  3. I do not think that a code of conduct file in a repo is a requirement for enforcement of said code of conduct
  4. As much as i'm a old-hand Mac fan, i think files without file extensions are annoying
  5. I don't think we need to do things because github does them, but if we can piggyback on an emerging convention that requires us to add 3 characters that should already have been there, to a filename, than that seems totally logical.
Jun 10 2017, 1:48 PM · User-Tgr, MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations
01tonythomas added a watcher for TCB-Team: 01tonythomas.
Jun 10 2017, 9:38 AM

May 24 2017

01tonythomas updated subscribers of T162066: Cannot revert revision on Newsletter description edit .

I meant whether you think it is a blocker or not, but of course the best way to discuss this is to provide a patch that fixes the problem. :D

May 24 2017, 9:04 AM · Patch-For-Review, MediaWiki-extensions-Newsletter

May 23 2017

01tonythomas added a comment to T165466: Volunteer Group: Blogging.

I missed the blog guidelines, hence my post would be a bit more personal - here https://tttwrites.wordpress.com/2017/05/24/wmhack-17-what-can-possibly-happen-in-3-days/

May 23 2017, 10:40 PM · Wikimedia-Hackathon-2017-Organization, Developer-Relations (Apr-Jun 2017)
01tonythomas updated the task description for T159083: Database Query improvements for the Newsletter extension.
May 23 2017, 1:20 PM · Patch-For-Review, MediaWiki-extensions-Newsletter

May 22 2017

01tonythomas added a comment to T159083: Database Query improvements for the Newsletter extension.

Now that we are done with the security review, I guess the DB improvements at https://phabricator.wikimedia.org/T159083 looks like a blocker for deployment as per https://phabricator.wikimedia.org/T159081#3203545

Mmm... who decides whether this is a blocker or not? Are these database performance problems critical for a first deployment limited to new newsletters in MediaWiki.org (which is the current plan)?

May 22 2017, 5:35 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Qgil awarded T131607: Add filter for 'Most Popular' or 'Most Subscribed' newsletters a Yellow Medal token.
May 22 2017, 5:00 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Keegan awarded T115095: Security review of Newsletter extension a Love token.
May 22 2017, 4:46 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter
Qgil awarded T160854: Newsletter strange behaviour on an API create/edit a Party Time token.
May 22 2017, 4:40 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
Qgil awarded T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal a Party Time token.
May 22 2017, 4:36 PM · Patch-For-Review, MediaWiki-extensions-Newsletter

May 21 2017

01tonythomas awarded T165844: Gender Gap Dashboard a Yellow Medal token.
May 21 2017, 8:08 PM · Wikimedia-Hackathon-2017-Newcomer-Contribution, Wikimedia-Hackathon-2017
01tonythomas updated the task description for T159083: Database Query improvements for the Newsletter extension.
May 21 2017, 5:30 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T131607: Add filter for 'Most Popular' or 'Most Subscribed' newsletters as Resolved.

Yay yay yay! We are done with this!

May 21 2017, 5:29 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T131607: Add filter for 'Most Popular' or 'Most Subscribed' newsletters, a subtask of T159083: Database Query improvements for the Newsletter extension, as Resolved.
May 21 2017, 5:29 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal as Invalid.

We have alternate code fixing things, and this is no more reproducible.

May 21 2017, 5:28 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas moved T131607: Add filter for 'Most Popular' or 'Most Subscribed' newsletters from Confirmed to Security Review (production blockers) on the MediaWiki-extensions-Newsletter board.
May 21 2017, 4:47 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas moved T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal from Backlog to Security Review (production blockers) on the MediaWiki-extensions-Newsletter board.
May 21 2017, 4:47 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal .

Probably should be safe to remove the MediaWiki-extensions-Newsletter tag even after https://gerrit.wikimedia.org/r/#/c/354905/

May 21 2017, 4:45 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas created T166019: Missing documentation on database access methods .
May 21 2017, 4:19 PM · MediaWiki-Documentation, Documentation
01tonythomas added a parent task for T131607: Add filter for 'Most Popular' or 'Most Subscribed' newsletters: T159083: Database Query improvements for the Newsletter extension.
May 21 2017, 4:03 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a subtask for T159083: Database Query improvements for the Newsletter extension: T131607: Add filter for 'Most Popular' or 'Most Subscribed' newsletters.
May 21 2017, 4:03 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T159081: [Non-security] General improvements for the Newsletter extension.
May 21 2017, 1:05 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review, Wikimedia-Hackathon-2017, MediaWiki-extensions-Newsletter

May 20 2017

01tonythomas updated the task description for T159083: Database Query improvements for the Newsletter extension.
May 20 2017, 5:55 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T159083: Database Query improvements for the Newsletter extension.
May 20 2017, 5:44 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T159083: Database Query improvements for the Newsletter extension.
May 20 2017, 4:55 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T165851: Combo boxes in Special:ApiSandox > main do not show what is typed .

Hi @01tonythomas,

I'm not sure, what exactly you mean, yould you give some more information? If I type in the select field, it will select and highlight the one, which matches my typed string :)

May 20 2017, 10:29 AM · Design, MediaWiki-API
01tonythomas closed T163487: Newsletter extension should use phpcs to enforce mediawiki coding standards. as Resolved.

@Bawolff said this should be a good to go after https://gerrit.wikimedia.org/r/349282

May 20 2017, 10:02 AM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a project to T162001: Special:ApiSandbox text box too small (specially with JSON data) : Easy.
May 20 2017, 9:49 AM · Easy, MediaWiki-Special-pages
01tonythomas created T165851: Combo boxes in Special:ApiSandox > main do not show what is typed .
May 20 2017, 9:48 AM · Design, MediaWiki-API
01tonythomas added a comment to T110170: Goal: Deploy Newsletter extension in Wikimedia.

Now that we are done with the security review, I guess the DB improvements at https://phabricator.wikimedia.org/T159083 looks like a blocker for deployment as per https://phabricator.wikimedia.org/T159081#3203545

May 20 2017, 9:23 AM · wikimedia-extension-review-queue, MW-1.30-release-notes (WMF-deploy-2017-08-08_(1.30.0-wmf.13)), User-Addshore, Patch-For-Review, User-notice, Goal, Community-Liaisons, Wikimedia-Hackathon-2016, MediaWiki-extensions-Newsletter
01tonythomas assigned T163487: Newsletter extension should use phpcs to enforce mediawiki coding standards. to Bawolff.

@Bawolff < should be resolved> ?

May 20 2017, 8:53 AM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T163486: Newsletter::fillParserOutput might have slave lag issues.

Right now we have additional checks - https://github.com/wikimedia/mediawiki-extensions-Newsletter/blob/master/includes/content/NewsletterContent.php#L177

May 20 2017, 8:50 AM · MediaWiki-extensions-Newsletter

May 19 2017

01tonythomas updated the task description for T159081: [Non-security] General improvements for the Newsletter extension.
May 19 2017, 9:09 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review, Wikimedia-Hackathon-2017, MediaWiki-extensions-Newsletter
01tonythomas created T165808: Add a 'Contributing' section to 'Template:Extension' .
May 19 2017, 8:05 PM · Documentation
01tonythomas added a comment to T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal .

@Bawolff says it has something to do with my local install though.

May 19 2017, 7:43 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T115095: Security review of Newsletter extension.
May 19 2017, 5:48 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter
01tonythomas closed T160854: Newsletter strange behaviour on an API create/edit , a subtask of T115095: Security review of Newsletter extension, as Resolved.
May 19 2017, 5:45 PM · Patch-For-Review, Security-Team, Wikimedia-Hackathon-2016, Security-Reviews, MediaWiki-extensions-Newsletter
01tonythomas closed T160854: Newsletter strange behaviour on an API create/edit as Resolved.

Yay. We got it merged finally - Thanks to @Bawolff!!!!!!!!!

May 19 2017, 5:45 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T160854: Newsletter strange behaviour on an API create/edit .

Update from @Bawolff : The query in https://gerrit.wikimedia.org/r/#/c/346055/24/includes/content/NewsletterDataUpdate.php 44-50 needs to be fixed to make it better. Right now it just picks up everything from the db.

May 19 2017, 3:06 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal .

Just found that this happens only when the user is logged in. Probably we should not be hacking it with my previous patch then.

May 19 2017, 2:46 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T159081: [Non-security] General improvements for the Newsletter extension.

I find the following too, unused functions from includes/NewsletterStore.php

May 19 2017, 12:52 PM · MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), Patch-For-Review, Wikimedia-Hackathon-2017, MediaWiki-extensions-Newsletter

May 18 2017

01tonythomas awarded T165680: Fatal Uncaught Error: Call to undefined method BlueSkyTemplate::userHasCookies() a Pterodactyl token.
May 18 2017, 4:16 PM · BlueSky
01tonythomas awarded T165540: Add CODE_OF_CONDUCT.md to Wikimedia repositories a Yellow Medal token.
May 18 2017, 10:17 AM · User-Tgr, MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)), Patch-For-Review, Repository-Admins, Gerrit, GitHub-Mirrors, Developer-Relations

May 17 2017

01tonythomas added a comment to T162967: Skillshare: Setup MediaWiki development environment .

Yes, me :) I've also set up my own docker-based dev environment and would love to learn what other people are doing.

Awesome, there will be at least 3 of us then!
I would be keen to get some sort of docker-compose.json file merged into core at this hackathon for super easy dev environments!

May 17 2017, 4:23 PM · Developer-Relations (Apr-Jun 2017), Wikimedia-Hackathon-2017
01tonythomas added a comment to T164938: Requesting access to Wikimedia CoC for Technical spaces internal communications .

I assume this task is done? I can confirm that Tony has signed L2 and L35.

May 17 2017, 11:53 AM · WMF-NDA-Requests

May 14 2017

01tonythomas added a comment to T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal .

Change 353768 had a related patch set uploaded (by 01tonythomas; owner: 01tonythomas):
[mediawiki/extensions/Newsletter@master] Disable page navigations on Special:Newsletter

https://gerrit.wikimedia.org/r/353768

May 14 2017, 2:48 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T165234: Navigation buttons on Special:Newsletter (when more than 60 newsletters) fatal .
May 14 2017, 2:10 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T162967: Skillshare: Setup MediaWiki development environment .

Alright - so just to be sure - this will run as part of the mentoring program (since we are in for Room Wiaschtl, where the mentoring program is scheduled to).

May 14 2017, 2:02 PM · Developer-Relations (Apr-Jun 2017), Wikimedia-Hackathon-2017