Page MenuHomePhabricator

01tonythomas (Tony Thomas)
Volunteer, Past GSoC+Outreachy org-admin with Wikimedia

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:03 PM (281 w, 6 h)
Availability
Available
IRC Nick
tonythomas
LDAP User
01tonythomas
MediaWiki User
01tonythomas [ Global Accounts ]

You can find me either on #wikimedia-dev, #wikimedia-devrel or not find at all.

E-mail : 01tonythomas [at] gmail [dot] com

Lately found here too: https://www.mediawiki.org/wiki/Code_of_Conduct/Committee_members#Tony_Thomas_.2801tonythomas.29

Recent Activity

Sun, Feb 9

01tonythomas added a comment to T202002: Error in edit newsletter page: Call to a member function getPrefixedText() on null.

%D0%9D%D0%BE%D0%B2%D1%8B%D0%B5_%D0%BF%D1%83%D0%B1%D0%BB%D0%B8%D0%BA%D0%B0%D1%86%D0%B8%D0%B8

Personally to me, this URL sounds weird. Like, when you create a newsletter with the decoded Новые публикации, the newsletter is created at Newsletter:Newsletter:Новые_публикации. See screenshots:

Sun, Feb 9, 10:12 AM · MediaWiki-extensions-Newsletter

Sat, Feb 1

01tonythomas closed T185907: MW-Vagrant role for Mailgun extension as Resolved.
Sat, Feb 1, 11:44 AM · MediaWiki-extensions-Mailgun

Jan 25 2020

01tonythomas closed T241446: Allow an option to remove pictures after selection before uploading as Resolved.

Thank you @Dwu1011!

Jan 25 2020, 10:58 AM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas closed T241447: Redesign the post upload complete success screen as Resolved.

Thank you! @Crutishnyk !

Jan 25 2020, 10:58 AM · Google-Drive-to-Commons, Google-Code-in-2019

Jan 22 2020

01tonythomas added a comment to T242783: Special:Newsletters on mediawikiwiki says none exist.

I can see that things are back. However, I only see around 14 newsletters. Is that all we have ? If yes, we should close this as Resolved.

Jan 22 2020, 9:26 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), MediaWiki-extensions-Newsletter

Jan 3 2020

01tonythomas added a comment to T241822: Support PostgreSQL in the BounceHandler extension.

Should be trivial actually. We might be able to even make this a Google-Code-in-2019 task.

Jan 3 2020, 1:11 PM · Patch-For-Review, PostgreSQL, MediaWiki-extensions-BounceHandler

Jan 1 2020

01tonythomas renamed T241645: Bump up Mailgun library to v3.0.0 from Bump up Mailgun library to v2.4.0 to Bump up Mailgun library to v3.0.0.
Jan 1 2020, 1:29 PM · Patch-For-Review, MediaWiki-extensions-Mailgun

Dec 31 2019

01tonythomas created T241645: Bump up Mailgun library to v3.0.0.
Dec 31 2019, 12:29 PM · Patch-For-Review, MediaWiki-extensions-Mailgun
01tonythomas claimed T185907: MW-Vagrant role for Mailgun extension.

I'm going to fix it myself, probably making it easier for GCI students to start contributing to the extensions easily.

Dec 31 2019, 12:07 PM · MediaWiki-extensions-Mailgun
01tonythomas added a comment to T236396: Mailgun extension should allow use of other alternate mailgun api endpoints.

We might be able to make this a Google-Code-in-2019 task as well. Probably once we upgrade the composer library, $mailgunAPIEndpoint as a parameter to the conf and probably some edits on https://github.com/wikimedia/mediawiki-extensions-Mailgun/blob/master/MailgunHooks.php#L54 ?

Dec 31 2019, 11:13 AM · MediaWiki-extensions-Mailgun

Dec 30 2019

01tonythomas added a project to T241596: Write an equivalent of SpecialUpload::getInitialPageText for Gdrives uploader: Google-Code-in-2019.

Perfect. Imported as https://codein.withgoogle.com/dashboard/tasks/5343599848325120/

Dec 30 2019, 5:09 PM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas added a comment to T241596: Write an equivalent of SpecialUpload::getInitialPageText for Gdrives uploader.

This could even be a possible Google-Code-in-2019 task.

Dec 30 2019, 4:36 PM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas created T241596: Write an equivalent of SpecialUpload::getInitialPageText for Gdrives uploader.
Dec 30 2019, 4:36 PM · Google-Code-in-2019, Google-Drive-to-Commons

Dec 26 2019

01tonythomas added a comment to T241464: [Backend] Logging uploads on Google Drive to Commons tool.

Later, we should have tasks to make this information available on an API and show it on the homepage as well.

Dec 26 2019, 4:01 PM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas created T241464: [Backend] Logging uploads on Google Drive to Commons tool.
Dec 26 2019, 4:01 PM · Google-Drive-to-Commons, Google-Code-in-2019

Dec 25 2019

01tonythomas added a comment to T241447: Redesign the post upload complete success screen .

Created https://codein.withgoogle.com/dashboard/tasks/5895383222321152/

Dec 25 2019, 7:37 PM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas created T241447: Redesign the post upload complete success screen .
Dec 25 2019, 7:35 PM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas added a comment to T241446: Allow an option to remove pictures after selection before uploading .

Added as https://codein.withgoogle.com/dashboard/tasks/6122497670381568/

Dec 25 2019, 7:25 PM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas updated the task description for T241446: Allow an option to remove pictures after selection before uploading .
Dec 25 2019, 7:24 PM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas created T241446: Allow an option to remove pictures after selection before uploading .
Dec 25 2019, 7:20 PM · Google-Drive-to-Commons, Google-Code-in-2019
01tonythomas added a comment to T241443: Design a logo for our Google Drive to Wikimedia Commons Uploader .

Created: https://codein.withgoogle.com/dashboard/tasks/4589095762788352/

Dec 25 2019, 4:38 PM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas created T241443: Design a logo for our Google Drive to Wikimedia Commons Uploader .
Dec 25 2019, 4:37 PM · Google-Code-in-2019, Google-Drive-to-Commons

Dec 24 2019

01tonythomas added projects to T241425: A license selection drop down before uploading pictures: Google-Drive-to-Commons, Google-Code-in-2019.
Dec 24 2019, 5:33 PM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas created T241425: A license selection drop down before uploading pictures.
Dec 24 2019, 5:33 PM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas added a comment to T223541: Tool to upload Google photos to Wikimedia commons.

Update: We actually miss a critical functionality as of today to add license to uploaded files. Hopefully, we plan to get it done with the Google Code In session going on.

Dec 24 2019, 4:07 PM · Google-Drive-to-Commons, User-notice, Wikimedia-Hackathon-2019 (Newcomer friendly)
01tonythomas added a project to T241412: Minor HTML+CSS+JS improvements to tool home page : Google-Code-in-2019.
Dec 24 2019, 10:45 AM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas created T241412: Minor HTML+CSS+JS improvements to tool home page .
Dec 24 2019, 10:44 AM · Google-Code-in-2019, Google-Drive-to-Commons
01tonythomas updated the task description for T235969: Prepare documentation for Gdrive-to-commons tool and make it GCI 2019 ready.
Dec 24 2019, 10:44 AM · Documentation, Google-Drive-to-Commons
01tonythomas added a watcher for Google-Drive-to-Commons: 01tonythomas.
Dec 24 2019, 10:14 AM
01tonythomas added a comment to T235969: Prepare documentation for Gdrive-to-commons tool and make it GCI 2019 ready.

Okey, I created a paste https://phabricator.wikimedia.org/P10014 which is dev only from my configurations to make it easy for developers to start developing on the application. Tasks, coming in soon then.

Dec 24 2019, 10:13 AM · Documentation, Google-Drive-to-Commons

Dec 23 2019

01tonythomas added a comment to T226052: Google OAuth verification for tools require domain verification.

+ TODO: Update Wikitech OAuth application to support our new subdomain. Right now, it redirects to the old app.

Dec 23 2019, 10:52 AM · cloud-services-team, Google-Drive-to-Commons

Dec 22 2019

01tonythomas added a comment to T226052: Google OAuth verification for tools require domain verification.

I took a closer look at this today, and I see that we are currently able to serve our app on https://gdrive-to-commons.toolforge.org/google-drive-photos-to-commons/. This is great. However, I see a problem while completing the Google OAuth verification screen:

Dec 22 2019, 11:06 AM · cloud-services-team, Google-Drive-to-Commons
01tonythomas added a comment to T235969: Prepare documentation for Gdrive-to-commons tool and make it GCI 2019 ready.

I think for the time being, it can live in the Github repo. Most of our development documentations are there. I will update it soon, and link it.

Dec 22 2019, 9:57 AM · Documentation, Google-Drive-to-Commons

Dec 5 2019

01tonythomas added a comment to P9831 python3.7.

i'm gonna try with:

Dec 5 2019, 3:58 PM

Nov 29 2019

01tonythomas added a comment to T76260: Need an option to show what access keys are.

Sure. Thank you!

Nov 29 2019, 8:34 AM · MediaWiki-User-preferences

Nov 17 2019

01tonythomas added a comment to T125589: Allow each tool to have its own subdomain for browser sandbox/cookie isolation.

Ping on this one again, and I see action going on at https://phabricator.wikimedia.org/T215531 which is great! However, do we have an approximate ETA on when we would finish the migration ?

Nov 17 2019, 5:51 PM · Security, cloud-services-team (Kanban), Toolforge

Oct 20 2019

01tonythomas added a comment to T162001: Special:ApiSandbox text box too small (specially with JSON data) .

I'm an outreachy applicant interested in contributing to this task, please how can i go about it @01tonythomas ?

If you are interested in submitting a fix, you should probably follow https://www.mediawiki.org/wiki/Gerrit/Tutorial and produce a patch to mediawki-core I guess. A good first step would be to reproduce the same in your latest development environment.

Oct 20 2019, 2:28 PM · MediaWiki-API, good first task
01tonythomas created T235969: Prepare documentation for Gdrive-to-commons tool and make it GCI 2019 ready.
Oct 20 2019, 11:14 AM · Documentation, Google-Drive-to-Commons
01tonythomas added a project to T230739: Mailgun, Warning: : array_key_exists() expects parameter 2 to be array, null given in : good first task.
Oct 20 2019, 11:00 AM · Google-Code-in-2019, good first task, MediaWiki-extensions-Mailgun

Sep 1 2019

01tonythomas added a comment to T226052: Google OAuth verification for tools require domain verification.

@bd808 someone on #wikimedia-cloud told me that our task is blocked by T215531

arturo> tonythomas: I can give you some more concrete information if you are interested
16:27 <tonythomas> arturo: please yes! 
16:29 <arturo> tonythomas: first, I would point you towards this: https://wikitech.wikimedia.org/wiki/Wikimedia_Cloud_Services_team/EnhancementProposals/DNS_domain_usage#Resolution i.e, we plan to use `$tool.toolforge.org`. For implementing that, upgrading our kubernetes deployment is probably the first step, and we are working on that in this phabricator task: T215531
16:29 <•stashbot> T215531: Deploy upgraded Kubernetes to toolsbeta - https://phabricator.wikimedia.org/T215531
16:37 <tonythomas> arturo: thank you. I will keep an eye on those tasks! Thanks.
Sep 1 2019, 8:12 AM · cloud-services-team, Google-Drive-to-Commons

Aug 28 2019

01tonythomas added a comment to T226052: Google OAuth verification for tools require domain verification.

Sounds like this task is blocked on the road by https://phabricator.wikimedia.org/T215531 ? Atleast that is what I hear from #wikimedia-cloud. :-(

Aug 28 2019, 6:29 PM · cloud-services-team, Google-Drive-to-Commons

Jun 18 2019

01tonythomas created T226052: Google OAuth verification for tools require domain verification.
Jun 18 2019, 8:43 PM · cloud-services-team, Google-Drive-to-Commons

Jun 16 2019

01tonythomas closed T225368: Need a Google Organisation to setup Google OAuth login on photo uploader to Commons as Invalid.
Jun 16 2019, 9:13 AM · cloud-services-team, Google-Drive-to-Commons
01tonythomas added a comment to T225368: Need a Google Organisation to setup Google OAuth login on photo uploader to Commons.

Good one @bd808. I missed that the In addition, part was an addition to in-org use case.

Jun 16 2019, 9:13 AM · cloud-services-team, Google-Drive-to-Commons

Jun 8 2019

01tonythomas updated the task description for T225368: Need a Google Organisation to setup Google OAuth login on photo uploader to Commons.
Jun 8 2019, 9:31 PM · cloud-services-team, Google-Drive-to-Commons
01tonythomas created T225368: Need a Google Organisation to setup Google OAuth login on photo uploader to Commons.
Jun 8 2019, 9:30 PM · cloud-services-team, Google-Drive-to-Commons

May 25 2019

01tonythomas added a project to T223541: Tool to upload Google photos to Wikimedia commons: Google-Drive-to-Commons.
May 25 2019, 9:03 PM · Google-Drive-to-Commons, User-notice, Wikimedia-Hackathon-2019 (Newcomer friendly)
01tonythomas updated the task description for T224332: Phabricator project for Google Drive to Commons.
May 25 2019, 9:56 AM · Project-Admins
01tonythomas updated the task description for T224332: Phabricator project for Google Drive to Commons.
May 25 2019, 9:55 AM · Project-Admins
01tonythomas updated the task description for T224332: Phabricator project for Google Drive to Commons.
May 25 2019, 9:55 AM · Project-Admins
01tonythomas updated subscribers of T224332: Phabricator project for Google Drive to Commons.
May 25 2019, 9:08 AM · Project-Admins
01tonythomas created T224332: Phabricator project for Google Drive to Commons.
May 25 2019, 9:08 AM · Project-Admins

May 24 2019

01tonythomas added a comment to T224307: Allow an option to delete an OAuth Consumer.

Thank you! Just waiting for it to roll out!

May 24 2019, 6:23 PM · MediaWiki-extensions-OAuth
01tonythomas created T224307: Allow an option to delete an OAuth Consumer.
May 24 2019, 5:55 PM · MediaWiki-extensions-OAuth

May 19 2019

01tonythomas updated the task description for T223541: Tool to upload Google photos to Wikimedia commons.
May 19 2019, 2:14 PM · Google-Drive-to-Commons, User-notice, Wikimedia-Hackathon-2019 (Newcomer friendly)
MusikAnimal awarded T223541: Tool to upload Google photos to Wikimedia commons a Love token.
May 19 2019, 1:47 PM · Google-Drive-to-Commons, User-notice, Wikimedia-Hackathon-2019 (Newcomer friendly)

May 18 2019

zeljkofilipin awarded T212558: Fix Newsletter failing builds on Jenkins a Party Time token.
May 18 2019, 2:27 PM · Patch-For-Review, User-zeljkofilipin, Wikimedia-Hackathon-2019 (Newcomer friendly), MediaWiki-extensions-Newsletter
01tonythomas closed T212558: Fix Newsletter failing builds on Jenkins as Resolved.

Thanks @zeljkofilipin ! This is green now! a

May 18 2019, 12:53 PM · Patch-For-Review, User-zeljkofilipin, Wikimedia-Hackathon-2019 (Newcomer friendly), MediaWiki-extensions-Newsletter
01tonythomas added a comment to T212558: Fix Newsletter failing builds on Jenkins.

Let’s do it.

May 18 2019, 7:04 AM · Patch-For-Review, User-zeljkofilipin, Wikimedia-Hackathon-2019 (Newcomer friendly), MediaWiki-extensions-Newsletter

May 17 2019

01tonythomas created T223541: Tool to upload Google photos to Wikimedia commons.
May 17 2019, 10:27 AM · Google-Drive-to-Commons, User-notice, Wikimedia-Hackathon-2019 (Newcomer friendly)
01tonythomas updated subscribers of T212558: Fix Newsletter failing builds on Jenkins.

@zeljkofilipin I was looking at the results of the build, and things of interest are:

Alpine users please run: `sudo apk add python make g++`
gyp WARN EACCES user "jenkins-deploy" does not have permission to access the dev dir "/nonexistent/.node-gyp/6.11.0"
gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"
Traceback (most recent call last):
  File "/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py", line 13, in <module>
    import gyp
  File "/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 8, in <module>
    import gyp.input
  File "/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/pylib/gyp/input.py", line 5, in <module>
    from compiler.ast import Const
ImportError: No module named compiler.ast
gyp ERR! configure error 
gyp ERR! stack Error: `gyp` failed with exit code: 1
May 17 2019, 9:25 AM · Patch-For-Review, User-zeljkofilipin, Wikimedia-Hackathon-2019 (Newcomer friendly), MediaWiki-extensions-Newsletter
01tonythomas added a project to T212558: Fix Newsletter failing builds on Jenkins: Wikimedia-Hackathon-2019 (Newcomer friendly).

Adding to Wikimedia hackathon board as we have the team here that can get this fixed.

May 17 2019, 8:57 AM · Patch-For-Review, User-zeljkofilipin, Wikimedia-Hackathon-2019 (Newcomer friendly), MediaWiki-extensions-Newsletter

Dec 22 2018

01tonythomas created T212558: Fix Newsletter failing builds on Jenkins.
Dec 22 2018, 1:08 PM · Patch-For-Review, User-zeljkofilipin, Wikimedia-Hackathon-2019 (Newcomer friendly), MediaWiki-extensions-Newsletter

Nov 18 2018

01tonythomas added a comment to T209752: SVG file: Upload error on Wikimedia Commons for namespace "http://iptc.org/std/iptc4xmpcore/1.0/xmlns/".

I think this is more or less a file related issue. Like I can see this error showing up while opening up the second file https://drive.google.com/file/d/1RD-M9jhI_Sj980F1uMxS_41YTgETIvm_/view?usp=sharing on google-chrome. See:

Nov 18 2018, 3:05 PM · MediaWiki-Uploading, Multimedia

Nov 10 2018

01tonythomas updated the task description for T175432: Newsletter summary length issues.
Nov 10 2018, 12:18 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter

Nov 3 2018

01tonythomas closed T175069: A Newsletter publisher can announce a new issue without providing a title for it as Resolved.

Thank you!

Nov 3 2018, 1:27 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, good first task, Google-Code-in-2018, MediaWiki-extensions-Newsletter

Oct 28 2018

Restricted Application added a project to T174658: Have a way to differenciate the Newsletter title in Notifications.: Growth-Team.

I like that button (or something similar) saying View new issue though.

Oct 28 2018, 4:45 PM · Growth-Team, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter
01tonythomas closed T154223: Update Extension:Newsletter page for administrators as Resolved.

I think should be done at this point. I added some #CONTRIBUTING docs too for the Mozilla program.

Oct 28 2018, 4:43 PM · Google-Code-In-2016, Documentation, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175365: Find a way for ability to talk with subscribers.

Sounds reasonable, but we need some mockups. If someone can push this, we might be able to get this into Google-Code-in-2018.

Oct 28 2018, 4:41 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T131673: Announce new Newsletter issues to social media in one go.

I was thinking about it for a while, and here are my impressions:

Oct 28 2018, 4:36 PM · MediaWiki-extensions-Newsletter
01tonythomas lowered the priority of T174664: Support interwiki links for new Newsletter issues from High to Low.
Oct 28 2018, 3:09 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas moved T175069: A Newsletter publisher can announce a new issue without providing a title for it from Confirmed to Google Code In 2018 on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 3:09 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, good first task, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas lowered the priority of T154761: "Register" newsletters instead of "Create" from Medium to Low.
Oct 28 2018, 3:09 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, User-Zoranzoki21, Google-Code-in-2018, Google-Code-In-2016, MediaWiki-extensions-Newsletter
01tonythomas moved T175432: Newsletter summary length issues from Confirmed to Google Code In 2018 on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 3:08 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T177064: When creating a newsletter, the default newsletter page should be offered as Main Page from Confirmed to Google Code In 2018 on the MediaWiki-extensions-Newsletter board.

https://codein.withgoogle.com/dashboard/tasks/5517245053665280/

Oct 28 2018, 3:08 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas triaged T177064: When creating a newsletter, the default newsletter page should be offered as Main Page as Medium priority.
Oct 28 2018, 3:07 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T177064: When creating a newsletter, the default newsletter page should be offered as Main Page.

In terms of UI, the field would be optional (now is required) and by default it would show the title of the page to be created, in gray letters. The label would still say "Wiki page with information about the newsletter", no changes there.

Oct 28 2018, 3:06 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175069: A Newsletter publisher can announce a new issue without providing a title for it.

Imported as https://codein.withgoogle.com/dashboard/tasks/4609274035568640/

Oct 28 2018, 3:00 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, good first task, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174927: Don't hide the View newsletter link?.

All patch-sets related to this task are merged. Safe to close ?

Oct 28 2018, 2:57 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Growth-Team, Patch-For-Review, Notifications, MediaWiki-extensions-Newsletter
01tonythomas added a project to T175432: Newsletter summary length issues: Google-Code-in-2018.

Imported as https://codein.withgoogle.com/dashboard/tasks/4743320233312256/

Oct 28 2018, 2:55 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T175069: A Newsletter publisher can announce a new issue without providing a title for it from Needs discussion to Confirmed on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 2:49 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, good first task, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T175432: Newsletter summary length issues from Needs discussion to Confirmed on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 2:49 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175432: Newsletter summary length issues.

Looks like a good Google-Code-in-2018 task as well. Let me upload this to the GCI site.

Oct 28 2018, 2:49 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas closed T183632: [Unit testing] Add unit tests to Newsletter validations as Resolved.

All patch sets are merged. This is good to go.

Oct 28 2018, 11:46 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas triaged T194981: Write E2E Test: Check creation of newsletter validation as Low priority.
Oct 28 2018, 11:15 AM · User-zeljkofilipin, Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T155273: Log in subscription to newsletter activity from Needs discussion to Needs Code Review on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 11:15 AM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas closed T119060: Implement caching for newsletters as Declined.

Since we are using ContentHandler and hence extending MW base page objects, caching is not required anymore.

Oct 28 2018, 11:01 AM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175069: A Newsletter publisher can announce a new issue without providing a title for it.

Alright. Lets make it required then. Makes sense to me.

Oct 28 2018, 10:40 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, good first task, Google-Code-in-2018, MediaWiki-extensions-Newsletter

Jul 28 2018

01tonythomas added a comment to T175497: Fields of newsletter not being updated in the newsletter info page.

@Niharika can you also point on which wiki this is happening ? Probably it was from a previous version I guess - but cant say without taking a good look. Thanks.

Jul 28 2018, 8:24 AM · Patch-For-Review, MediaWiki-extensions-Newsletter

Jul 22 2018

01tonythomas updated the task description for T199880: Wikimania 2018 Hackathon Showcase.
Jul 22 2018, 10:19 PM · Wikimania-Hackathon-2018-Organization, Wikimania-Hackathon-2018

Jul 21 2018

01tonythomas claimed T155273: Log in subscription to newsletter activity.
Jul 21 2018, 3:20 PM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas awarded T199882: Make some terrible logos at wikimania hackathon 2018 a Pirate Logo token.
Jul 21 2018, 12:46 PM · Logos, Wikimania-Hackathon-2018
01tonythomas added a comment to T155273: Log in subscription to newsletter activity.

Found a hack btw. Now it works like this:

  • When the are subscribers logs public is checked, *everyone* see the whole version of the message.
  • When its unchecked, publishers see an anonymised version of the subscription logs (also on Special:Log). This would just say - A subscriber was added/removed on Newsletter:Link
Jul 21 2018, 11:23 AM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T155273: Log in subscription to newsletter activity.

We ran into a problem. Newsletter logs are by default logged in Special:Log. Currently, I can configure the extension to not show up this at Newsletter:NewsletterName, but this wont stop it from showing up at Special:Logs/newsletter. Currently, mediawiki-core do not allow some kind of dynamic plugs on this.

Jul 21 2018, 9:00 AM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter

Jul 20 2018

01tonythomas added a comment to T155273: Log in subscription to newsletter activity.

Some early peeks to the solution (in the patchset above)

Jul 20 2018, 4:44 PM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas added a project to T155273: Log in subscription to newsletter activity: Wikimania-Hackathon-2018.

My proposition:

  • While creating a newsletter, now you can specify if the subscription logs are public. Probably add something like a checkbox there ? Default to False
  • Add a Subscription activity log to Newsletter:Name bottom. This is only available to publishers/admins when above setting is unchecked. Else, available to public.
Jul 20 2018, 12:23 PM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter

Jul 19 2018

01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

Notifications are maybe the only thing that worries me a little. Right now on local, it redirects me to the page on my local language.

Jul 19 2018, 2:27 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

So I just thought about it - and found that we are not really using the issue id for anything else at this point. This would mean that I can safely implement the feature without affecting migrations, even though I would get the desired:

Jul 19 2018, 2:26 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

Initial impression: If we are supporting interwiki links, we need the following changes:

  • Store interwiki links somehow in nl_newsletters. Right now we store nl_id. Probably we store the whole title name then ? 🤔 (also, this needs to be done for all newsletters). This might need migration changes as it cannot be empty for existing deployments.
  • Modfily newsletter contenthandler to add the whole title as well.
  • API edits ? Needs changes on DataUpdate
  • Validation changes (fail only if not interwiki link, etc).
Jul 19 2018, 1:58 PM · Patch-For-Review, MediaWiki-extensions-Newsletter

Jul 18 2018

01tonythomas added a project to T194455: Draw smoothed polygons and lines: Wikimania-Hackathon-2018.

smoothFactor in lib/external/mapbox/mapbox-lib.js: 8768 can do what we want.

Jul 18 2018, 7:31 PM · Wikimania-Hackathon-2018, Maps (Kartographer)