01tonythomas (Tony Thomas)
Volunteer, Past GSoC+Outreachy org-admin with Wikimedia

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:03 PM (218 w, 4 d)
Availability
Available
IRC Nick
tonythomas
LDAP User
01tonythomas
MediaWiki User
01tonythomas [ Global Accounts ]

You can find me either on #wikimedia-dev, #wikimedia-devrel or not find at all.

E-mail : 01tonythomas [at] gmail [dot] com

Lately found here too: https://www.mediawiki.org/wiki/Code_of_Conduct/Committee_members#Tony_Thomas_.2801tonythomas.29

Recent Activity

Sun, Nov 18

01tonythomas added a comment to T209752: SVG file: Upload error on Wikimedia Commons for namespace "http://iptc.org/std/iptc4xmpcore/1.0/xmlns/".

I think this is more or less a file related issue. Like I can see this error showing up while opening up the second file https://drive.google.com/file/d/1RD-M9jhI_Sj980F1uMxS_41YTgETIvm_/view?usp=sharing on google-chrome. See:

Sun, Nov 18, 3:05 PM · MediaWiki-Uploading, Multimedia

Nov 10 2018

01tonythomas updated the task description for T175432: Newsletter summary length issues.
Nov 10 2018, 12:18 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter

Nov 3 2018

01tonythomas closed T175069: A Newsletter publisher can announce a new issue without providing a title for it as Resolved.

Thank you!

Nov 3 2018, 1:27 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, goodfirstbug, Google-Code-in-2018, MediaWiki-extensions-Newsletter

Oct 28 2018

Restricted Application added a project to T174658: Have a way to differenciate the Newsletter title in Notifications.: Growth-Team.

I like that button (or something similar) saying View new issue though.

Oct 28 2018, 4:45 PM · Growth-Team, Collaboration-Team-Triage, Notifications, MediaWiki-extensions-Newsletter
01tonythomas closed T154223: Update Extension:Newsletter page for administrators as Resolved.

I think should be done at this point. I added some #CONTRIBUTING docs too for the Mozilla program.

Oct 28 2018, 4:43 PM · Google-Code-In-2016, Documentation, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175365: Find a way for ability to talk with subscribers.

Sounds reasonable, but we need some mockups. If someone can push this, we might be able to get this into Google-Code-in-2018.

Oct 28 2018, 4:41 PM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T131673: Announce new Newsletter issues to social media in one go.

I was thinking about it for a while, and here are my impressions:

Oct 28 2018, 4:36 PM · MediaWiki-extensions-Newsletter
01tonythomas lowered the priority of T174664: Support interwiki links for new Newsletter issues from High to Low.
Oct 28 2018, 3:09 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas moved T175069: A Newsletter publisher can announce a new issue without providing a title for it from Confirmed to Google Code In 2018 on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 3:09 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, goodfirstbug, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas lowered the priority of T154761: "Register" newsletters instead of "Create" from Normal to Low.
Oct 28 2018, 3:09 PM · Patch-For-Review, User-Zoranzoki21, Google-Code-in-2018, Google-Code-In-2016, MediaWiki-extensions-Newsletter
01tonythomas moved T175432: Newsletter summary length issues from Confirmed to Google Code In 2018 on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 3:08 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T177064: When creating a newsletter, the default newsletter page should be offered as Main Page from Confirmed to Google Code In 2018 on the MediaWiki-extensions-Newsletter board.

https://codein.withgoogle.com/dashboard/tasks/5517245053665280/

Oct 28 2018, 3:08 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas triaged T177064: When creating a newsletter, the default newsletter page should be offered as Main Page as Normal priority.
Oct 28 2018, 3:07 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T177064: When creating a newsletter, the default newsletter page should be offered as Main Page.

In terms of UI, the field would be optional (now is required) and by default it would show the title of the page to be created, in gray letters. The label would still say "Wiki page with information about the newsletter", no changes there.

Oct 28 2018, 3:06 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175069: A Newsletter publisher can announce a new issue without providing a title for it.

Imported as https://codein.withgoogle.com/dashboard/tasks/4609274035568640/

Oct 28 2018, 3:00 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, goodfirstbug, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174927: Don't hide the View newsletter link?.

All patch-sets related to this task are merged. Safe to close ?

Oct 28 2018, 2:57 PM · MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Growth-Team, Collaboration-Team-Triage (Collab-Team-This-Quarter), Patch-For-Review, Notifications, MediaWiki-extensions-Newsletter
01tonythomas added a project to T175432: Newsletter summary length issues: Google-Code-in-2018.

Imported as https://codein.withgoogle.com/dashboard/tasks/4743320233312256/

Oct 28 2018, 2:55 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T175069: A Newsletter publisher can announce a new issue without providing a title for it from Needs discussion to Confirmed on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 2:49 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, goodfirstbug, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T175432: Newsletter summary length issues from Needs discussion to Confirmed on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 2:49 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175432: Newsletter summary length issues.

Looks like a good Google-Code-in-2018 task as well. Let me upload this to the GCI site.

Oct 28 2018, 2:49 PM · Patch-For-Review, Google-Code-in-2018, MediaWiki-extensions-Newsletter
01tonythomas closed T183632: [Unit testing] Add unit tests to Newsletter validations as Resolved.

All patch sets are merged. This is good to go.

Oct 28 2018, 11:46 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas triaged T194981: Write E2E Test: Check creation of newsletter validation as Low priority.
Oct 28 2018, 11:15 AM · User-zeljkofilipin, Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas moved T155273: Log in subscription to newsletter activity from Needs discussion to Needs Code Review on the MediaWiki-extensions-Newsletter board.
Oct 28 2018, 11:15 AM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas closed T119060: Implement caching for newsletters as Declined.

Since we are using ContentHandler and hence extending MW base page objects, caching is not required anymore.

Oct 28 2018, 11:01 AM · MediaWiki-extensions-Newsletter
01tonythomas added a comment to T175069: A Newsletter publisher can announce a new issue without providing a title for it.

Alright. Lets make it required then. Makes sense to me.

Oct 28 2018, 10:40 AM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, goodfirstbug, Google-Code-in-2018, MediaWiki-extensions-Newsletter

Jul 28 2018

01tonythomas added a comment to T175497: Fields of newsletter not being updated in the newsletter info page.

@Niharika can you also point on which wiki this is happening ? Probably it was from a previous version I guess - but cant say without taking a good look. Thanks.

Jul 28 2018, 8:24 AM · Patch-For-Review, MediaWiki-extensions-Newsletter

Jul 22 2018

01tonythomas updated the task description for T199880: Wikimania 2018 Hackathon Showcase.
Jul 22 2018, 10:19 PM · Wikimania-Hackathon-2018-Organization, Wikimania-Hackathon-2018

Jul 21 2018

01tonythomas claimed T155273: Log in subscription to newsletter activity.
Jul 21 2018, 3:20 PM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas awarded T199882: Make some terrible logos at wikimania hackathon 2018 a Pirate Logo token.
Jul 21 2018, 12:46 PM · Wikimania-Hackathon-2018
01tonythomas added a comment to T155273: Log in subscription to newsletter activity.

Found a hack btw. Now it works like this:

  • When the are subscribers logs public is checked, *everyone* see the whole version of the message.
  • When its unchecked, publishers see an anonymised version of the subscription logs (also on Special:Log). This would just say - A subscriber was added/removed on Newsletter:Link
Jul 21 2018, 11:23 AM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T155273: Log in subscription to newsletter activity.

We ran into a problem. Newsletter logs are by default logged in Special:Log. Currently, I can configure the extension to not show up this at Newsletter:NewsletterName, but this wont stop it from showing up at Special:Logs/newsletter. Currently, mediawiki-core do not allow some kind of dynamic plugs on this.

Jul 21 2018, 9:00 AM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter

Jul 20 2018

01tonythomas added a comment to T155273: Log in subscription to newsletter activity.

Some early peeks to the solution (in the patchset above)

Jul 20 2018, 4:44 PM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas added a project to T155273: Log in subscription to newsletter activity: Wikimania-Hackathon-2018.

My proposition:

  • While creating a newsletter, now you can specify if the subscription logs are public. Probably add something like a checkbox there ? Default to False
  • Add a Subscription activity log to Newsletter:Name bottom. This is only available to publishers/admins when above setting is unchecked. Else, available to public.
Jul 20 2018, 12:23 PM · Patch-For-Review, Wikimania-Hackathon-2018, MediaWiki-extensions-Newsletter

Jul 19 2018

01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

Notifications are maybe the only thing that worries me a little. Right now on local, it redirects me to the page on my local language.

Jul 19 2018, 2:27 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

So I just thought about it - and found that we are not really using the issue id for anything else at this point. This would mean that I can safely implement the feature without affecting migrations, even though I would get the desired:

Jul 19 2018, 2:26 PM · Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T174664: Support interwiki links for new Newsletter issues.

Initial impression: If we are supporting interwiki links, we need the following changes:

  • Store interwiki links somehow in nl_newsletters. Right now we store nl_id. Probably we store the whole title name then ? 🤔 (also, this needs to be done for all newsletters). This might need migration changes as it cannot be empty for existing deployments.
  • Modfily newsletter contenthandler to add the whole title as well.
  • API edits ? Needs changes on DataUpdate
  • Validation changes (fail only if not interwiki link, etc).
Jul 19 2018, 1:58 PM · Patch-For-Review, MediaWiki-extensions-Newsletter

Jul 18 2018

01tonythomas added a project to T194455: Draw smoothed polygons and lines: Wikimania-Hackathon-2018.

smoothFactor in lib/external/mapbox/mapbox-lib.js: 8768 can do what we want.

Jul 18 2018, 7:31 PM · Wikimania-Hackathon-2018, Maps (Kartographer)
01tonythomas added a comment to T110645: Interwiki support for Newsletter extension.

But announce and notification will be triggered on local wiki, I hope, not on meta?

We just discussed this and it seems like notifying a user on a specific wiki is possible. We have to think:

  • Should a user be able to configure, say by Special:Preferences on which wiki to get notified
  • Always notify on the $wiki the newsletter is connected to. (we have this information already)
Jul 18 2018, 4:18 PM · Patch-For-Review, Wikimania-Hackathon-2018, Wikimedia-Israel-Hackers, MediaWiki-extensions-Newsletter
01tonythomas added a comment to T110645: Interwiki support for Newsletter extension.

Tentative plan after meeting with @Addshore:

Jul 18 2018, 3:29 PM · Patch-For-Review, Wikimania-Hackathon-2018, Wikimedia-Israel-Hackers, MediaWiki-extensions-Newsletter
Volker_E awarded T132284: Convert Special:AbuseFilter to OOUI a Mountain of Wealth token.
Jul 18 2018, 1:42 PM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
01tonythomas created T199897: Special:Log/interwiki broken after role provision.
Jul 18 2018, 11:04 AM · MediaWiki-extensions-Interwiki, MediaWiki-Special-pages
01tonythomas created T199894: Need Documentation for Vagrant roles - `interwiki` .
Jul 18 2018, 10:45 AM · MediaWiki-Vagrant, Documentation
01tonythomas added a project to T110645: Interwiki support for Newsletter extension: Wikimania-Hackathon-2018.

I see that this is the task blocking our deploy strategy.

Jul 18 2018, 8:48 AM · Patch-For-Review, Wikimania-Hackathon-2018, Wikimedia-Israel-Hackers, MediaWiki-extensions-Newsletter

Jun 4 2018

01tonythomas added a comment to T194981: Write E2E Test: Check creation of newsletter validation.

Well, the idea was that the parent - https://phabricator.wikimedia.org/T194959 - to introduce selenium test to Newsletter extension, and this one to actually test a specific Newsletter use case.

Jun 4 2018, 2:52 PM · User-zeljkofilipin, Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter

May 19 2018

01tonythomas created T195055: mw-buttons not clickable with debug toolbar enabled.
May 19 2018, 12:49 PM · MediaWiki-Core-Tests, User-zeljkofilipin
01tonythomas awarded T194030: Phabricator admin request for Ladsgroup a Like token.
May 19 2018, 9:15 AM · Phabricator
01tonythomas closed T194967: Shift from `jscs` & `jshint` to eslint as Resolved.
May 19 2018, 9:05 AM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas updated subscribers of T194967: Shift from `jscs` & `jshint` to eslint.

Thanks @Florian for pitching in.

May 19 2018, 9:05 AM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter

May 18 2018

01tonythomas created T194981: Write E2E Test: Check creation of newsletter validation.
May 18 2018, 5:43 PM · User-zeljkofilipin, Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas created T194967: Shift from `jscs` & `jshint` to eslint.
May 18 2018, 4:09 PM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Wikimedia-Hackathon-2018, MediaWiki-extensions-Newsletter
01tonythomas added a parent task for T194959: Write selenium tests for Newsletter extension : T190687: Pair on writing Selenium tests in JavaScript/Node.js.
May 18 2018, 2:58 PM · MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Wikimedia-Hackathon-2018, Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas added a subtask for T190687: Pair on writing Selenium tests in JavaScript/Node.js: T194959: Write selenium tests for Newsletter extension .
May 18 2018, 2:58 PM · JavaScript, User-zeljkofilipin, Release-Engineering-Team (Kanban), Wikimedia-Hackathon-2018
01tonythomas created T194959: Write selenium tests for Newsletter extension .
May 18 2018, 2:58 PM · MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Wikimedia-Hackathon-2018, Patch-For-Review, MediaWiki-extensions-Newsletter

Apr 6 2018

RandomDSdevel awarded T132284: Convert Special:AbuseFilter to OOUI a Doubloon token.
Apr 6 2018, 7:47 PM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization

Apr 3 2018

Framawiki awarded T132284: Convert Special:AbuseFilter to OOUI a Love token.
Apr 3 2018, 5:07 PM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization

Feb 14 2018

01tonythomas awarded T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California a Love token.
Feb 14 2018, 5:46 PM · Developer-Advocacy (Jan-Mar-2018), Google-Code-in-2017

Feb 12 2018

01tonythomas added a comment to T186600: Decide which GCI mentor/admin to attend GCI Grand Prize winners weekend (June 25-28, 2018) at Google HQ in California.

Since I couldnt mentor as many tasks as I mentored last year, I dont know where my answer stands - but count me in as well if there is space :P

Feb 12 2018, 4:42 PM · Developer-Advocacy (Jan-Mar-2018), Google-Code-in-2017

Feb 1 2018

01tonythomas closed T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work, a subtask of T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes, as Resolved.
Feb 1 2018, 4:45 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work as Resolved.

All patchsets merged, closing now. Thanks.

Feb 1 2018, 4:45 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183821: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work as Resolved.

All patchsets merged, closing now. Thanks.

Feb 1 2018, 4:44 AM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183821: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work, a subtask of T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace, as Resolved.
Feb 1 2018, 4:44 AM · MediaWiki-extensions-Newsletter

Jan 31 2018

01tonythomas created T186093: Coordinate MediaWiki Training 2018, Bangalore.
Jan 31 2018, 6:32 AM · User-Jayprakash12345, events

Jan 13 2018

01tonythomas closed T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php` as Resolved.
Jan 13 2018, 11:01 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Jan 13 2018, 11:01 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Jan 3 2018

01tonythomas reassigned T183189: Special:Newsletter/id/subscribers does not properly update subscriber count from 01tonythomas to nikitavbv.
Jan 3 2018, 6:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter
01tonythomas closed T183189: Special:Newsletter/id/subscribers does not properly update subscriber count as Resolved.

Nice catch. Thanks!

Jan 3 2018, 6:02 PM · MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)), MediaWiki-extensions-Newsletter

Dec 31 2017

01tonythomas added a comment to T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes.

Thanks, works!

Dec 31 2017, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes as Resolved.
Dec 31 2017, 4:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes, a subtask of T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace, as Resolved.
Dec 31 2017, 4:59 PM · MediaWiki-extensions-Newsletter

Dec 30 2017

01tonythomas created T183821: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work.
Dec 30 2017, 4:02 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183820: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work.
Dec 30 2017, 4:00 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas added a project to T183818: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created : Google-Code-in-2017.
Dec 30 2017, 3:56 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183819: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes.
Dec 30 2017, 3:55 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183818: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created .
Dec 30 2017, 3:52 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace.
Dec 30 2017, 3:51 PM · MediaWiki-extensions-Newsletter
01tonythomas created T183817: [Unit testing] Add unit tests to API operations on Newsletter namespace.
Dec 30 2017, 3:48 PM · MediaWiki-extensions-Newsletter
01tonythomas added a project to T183816: [Unit testing] Add unit tests to Newsletter create operations: Google-Code-in-2017.

This should possibly go to tests/specials/SpecialNewsletterCreateTest.php as well.

Dec 30 2017, 3:41 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas updated the task description for T183816: [Unit testing] Add unit tests to Newsletter create operations.
Dec 30 2017, 3:41 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183816: [Unit testing] Add unit tests to Newsletter create operations.
Dec 30 2017, 3:39 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas reopened T183632: [Unit testing] Add unit tests to Newsletter validations as "Open".

My patchset https://gerrit.wikimedia.org/r/#/c/399995/ is sadly open.

Dec 30 2017, 3:28 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T166002: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear as Resolved.
Dec 30 2017, 3:05 PM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Patch-For-Review, MediaWiki-extensions-Newsletter
01tonythomas closed T178743: Remove code duplication in EditPage and NewsletterContentUpdate as Resolved.

Oh yes. resolving then.

Dec 30 2017, 3:04 PM · MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)), MediaWiki-extensions-Newsletter
01tonythomas created T183813: [Unit testing] Unit test `newsletterExistsForMainPage` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 3:03 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183812: [Unit testing] Unit test `getSubscribersFromID` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 3:01 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183811: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 2:59 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183810: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php`.
Dec 30 2017, 2:57 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183809: [Unit testing] Unit test `getPublishersFromID` in newsletters `includes/NewsletterDb.php`.
Dec 30 2017, 2:55 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183808: [Unit testing] Unit test `getNewsletterSubscribersCount` in `includes/NewsletterDb.php`.
Dec 30 2017, 2:53 PM · MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas created T183806: [Unit testing] Unit test `addNewsletterIssue` in `includes/NewsletterDb.php`.
Dec 30 2017, 2:48 PM · Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183618: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` as Resolved.
Dec 30 2017, 2:46 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183618: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 30 2017, 2:46 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183620: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` as Resolved.
Dec 30 2017, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183620: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 30 2017, 2:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 29 2017

01tonythomas closed T183658: Add/Remove/Notify of Publishers should happen in bulk as Resolved.

Thanks :)

Dec 29 2017, 9:18 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 28 2017

01tonythomas closed T183616: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php` as Resolved.

Nice one! Thanks.

Dec 28 2017, 8:33 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183616: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 28 2017, 8:33 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate as Resolved.

Great work. Thanks !

Dec 28 2017, 9:41 AM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183638: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate, a subtask of T183632: [Unit testing] Add unit tests to Newsletter validations, as Resolved.
Dec 28 2017, 9:41 AM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter

Dec 27 2017

01tonythomas closed T183619: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php` as Resolved.
Dec 27 2017, 8:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Newsletter
01tonythomas closed T183619: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php`, a subtask of T183613: [GCI][Unit testing] Unit test db operations on Newsletter extension, as Resolved.
Dec 27 2017, 8:45 PM · MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), Google-Code-in-2017, MediaWiki-extensions-Newsletter