In T340845#9724972, @ecarg wrote:

Hello! Any updates on the discussion/thread? Have we decided on what to go with?

In T360610#9724982, @ecarg wrote:

I really like the idea of this functionality

In T346031#9724986, @ecarg wrote:

To confirm, this is still occurring and we still want to make this change when in 'Read' mode bc it is fine in 'Edit' mode?

In T335922#9724989, @ecarg wrote:

Hello! Does this task still exist as an issue or are there any updates to this?

In T343125#9724994, @ecarg wrote:

Hello! Is this still an issue? Also, what do we mean by 'ULS'?

can't scroll down when there is too much text. https://wikimedia.slack.com/archives/C06KW5BGEBB/p1713364682437669

In T359664#9709254, @GrounderUK wrote:

Thank you 🙏

In T359664#9706260, @AAlhazwani-WMF wrote:

…we also explored a drag-and-drop interaction…

That looks pretty classy!
🤔…but a purely drag-and-drop solution has accessibility implications, so “insert” should be the priority.

thank you @GrounderUK

@Jdforrester-WMF when an editor enters "edit source" mode, would it be possible to check what are their user rights, and programmatically display a message in-page? very poorly written message eg. "⚠️ While you can edit this page, based on your current user group you will not be able to publish your changes."

In T359231#9634038, @AAlhazwani-WMF wrote:

after chatting with @gengh it seems that is not possible to assert when to trigger a warning and when not to. i would wait to see what happens when renderers and parsers are in use.

tested on beta today, and the issue is still present. if possible, we'd like to vertically align the text with the bullet (or the chevron). both for single-line text,

as a first step, we are thinking about leveraging the existing contextual menu (use to change the mode or delete a list item) to also display 2 new options: move up, and move down.

In T349408#9676238, @Jdlrobson wrote:

the page scrolls horizontally because (it seems that) the header is larger than the viewport. it happens both when logged in or not. i also tried larger phones and the issue is still present.

I flagged to James that right now Vector 2022 has a min width for what the web team is willing to support. This was introduced a while back when we had no need for a responsive Vector 2022 skin, but that has changed now. If you open a ticket asking us to support below that threshold I will happily get us to remove that (at the very least when the wgVectorResponsive flag is enabled).

this work can be part of a larger area of work on translation and multilingual editing, if it gets accepted for the upcoming quarter, see PRD.

un-assigning and moving back go the ready column as we might address this as part of a larger area of work on multilingual contributions

un-assigning and moving back go the ready column as we might address this as part of a larger area of work on multilingual contributions

In T342609#9661497, @Amire80 wrote:

If we don't consider that to be a fraction what we could do is to add an optional translation for RTL languages that instead of displaying in RTL

These aren't fractions. A message that says "out of $1" is probably a better solution. And it will be clearer in all languages, not only the RTL ones.

i've been testing this on betacluster and i'd like to report a couple of minor things for us or the web team to consider.

In T360169#9652342, @DVrandecic wrote:

I love all suggestions.

The reason why I lean a bit towards "Join empty strings - Wikifunctions" is to keep it consistent with the other Wikimedia properties (i.e. Wikipedia has "Milan - Wikipedia", Wikidata has "San Francisco - Wikidata", etc.) -- but happy to even go one step further :) Leaving the decision with you, @AAlhazwani-WMF (and once you made it, untag yourself and design and it can be picked up by engineering)

In T348182#9228952, @Jdforrester-WMF wrote:

Should this be on Ctrl+Enter / Apple+Enter instead?

there might be a couple of options to address this. when someone clicks on "cancel" button in the publish dialog, what is their expectation? are they cancelling the publishing step (to go back to their edits/changes), or are they cancelling "everything" (similarly to refresh/close the tab of the browser)?

that could work! i would also like to explore how might we include the zid directly to about widget, rather than the mediawiki header.

after chatting with @gengh it seems that is not possible to assert when to trigger a warning and when not to. i would wait to see what happens when renderers and parsers are in use.

I.e. if you go to https://www.wikifunctions.org/view/en/Z10000 and tripleclick on join, it selects "join strings Z10000" (but weirdly not the brackets around the ZID).

I think we can drop the ZID from the title, and maybe even the type (i.e. "Function" in the example), so it is only

"join strings - Wikifunctions"

In T350683#9616223, @Jdforrester-WMF wrote:

We've not actually made this change, but a fair number of changes have been made to the object selector workflow since this was filed. Can we declare this Resolved at this point?

posting final decisions after chatting with @gengh

In T353236#9599761, @gengh wrote:

@AAlhazwani-WMF I initially thought this task was for the description field in the about widget.

Do we wanna change the about widget description field to a textarea too?

If we add a float: right property to the __counter css, when the page is rtl, it will replace that style with float: left automatically:

In T358889#9592115, @CCiufo-WMF wrote:

This isn't reproducible for me:

As you mentioned, this might have been a temporary issue caused by the CSS variables or Night Mode work?

ooooh sorry, i didn't see my own typo 🤦🏼‍♂️

In T353236#9591606, @ecarg wrote:

Hi @AAlhazwani-WMF what do we mean by 'LTR' and 'RLT'? Google says, 'long term relationship' and 'revocable living trust' 😆 .

At first I thought it might be 'left to right' but then that would mean it would be 'RTL' for 'right to left' but it's 'RLT' 🤔 so I didn't know anymore.

thank you @gengh!

pinging @Jdforrester-WMF for guidance, see comment above ^

You can see this in the current WIP ZObjectStringRenderer.vue component, in the methods from lines 134 and 164.

tested in production, seems to be fixed now.

In T346006#9566996, @gengh wrote:

Is a valid issue and a good point. Whenever we initialize a string object, we set it to empty string, so in this component we decided to interpret an empty string as an unset one and offer the call to action "Enter string" instead.
Because empty strings are perfectly valid, I would suggest removing the "Enter string" call to action to simply put "empty string" or "".

@AAlhazwani-WMF @Jdforrester-WMF any thoughts?

In T353236#9566820, @gengh wrote:

@AAlhazwani-WMF Do we wanna use textarea for descriptions in the Function Editor as well?

In T343202#9564032, @nimishmedatwal wrote:

This can be easily achieved by playing with tabindex attribute of various elements. Can I get assigned to this issue?

i've tested this on beta/prod and we consistently display floating messages at the center-bottom of the screen.

this is looking gooood! thank you @AnneT @Catrope @CCiufo-WMF 🙏🏼

UI-wise we could drive inspiration from the user contributions page et similar where there is an accordion at the top of the page with bespoke filters based on the page type.

blocked by T350946: Lookup: Option to open menu when field is focused

note to self, found this neat visual treatment on slack for uncomplete usernames

sharing a few examples that i've been collecting in the past months as we've been working on the nested/expanding/collapsing UI on wikifuntions

some more updates after a first round of feedback. left is current, centered is proposal with all accordions collapsed, and right is proposal with all accordions expanded

started to explore few ideas on how we might improve the content displayed in this dialog. i've been mostly focusing on the information architecture, and not questioning the current content, which is probably out of scope for this task.

@gengh i would like to contribute to this task this week. could you give me more context on the design needs for this dialog? if i'm not mistaken, we're already using cdx-dialog. also, is this the dialog in question?

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)

In T356026#9507484, @MNeisler wrote:

@AAlhazwani-WMF
The instrumentation currently proposed on this ticket is based on the potential metrics you proposed in the H1 measurement plan for evaluating updates to the function viewer experience.

Can you please review and confirm if all of the interactions identified in the task description are still correct? Are they all still needed to evaluate the impact of planned changes or can this list be refined a little bit?

It might help to think through what questions we are looking to answer with these new events and the decisions they will inform.

this task is also valid for read mode, in this example i published an empty list

(3) the space between the lang icon and is rather tight.

i've reviewed, edited, and updated the description of this task, and most of the noted issues have been addressed. the remaining (small) things have been filed as separate tasks. i'd suggest to verify and resolve this task.