Page MenuHomePhabricator

Aashaka (Aashaka)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 20 2015, 5:23 PM (204 w, 2 d)
Availability
Available
LDAP User
Aashaka
MediaWiki User
Unknown

Recent Activity

Sep 15 2016

Aashaka added a comment to T116561: Position of boolean operators inside an if condition.

Any updates/reviews on this?

Sep 15 2016, 12:28 PM · Patch-For-Review, MediaWiki-Codesniffer

May 1 2016

Restricted Application updated subscribers of T49544: <references/> list item must not wrap the text in <span>.

Please review :)

May 1 2016, 5:26 PM · Wikisource, Patch-For-Review, Technical-Debt, good first bug, Cite

Apr 24 2016

Aashaka created T133478: Make a contributing.md file or add to README, steps to contribute to Mediawiki Codesniffer.
Apr 24 2016, 1:59 AM · MediaWiki-Codesniffer

Apr 19 2016

Restricted Application updated subscribers of T116561: Position of boolean operators inside an if condition.

https://www.mediawiki.org/wiki/Manual:Coding_conventions#Line_continuation has changed. It now suggests using operator at the end of the previous line. I have changed my patch accordingly!

Apr 19 2016, 1:28 PM · Patch-For-Review, MediaWiki-Codesniffer

Apr 11 2016

Aashaka claimed T68859: Logo: add nolink attribute.
Apr 11 2016, 3:36 AM · Patch-For-Review, good first bug, Chameleon

Apr 10 2016

Aashaka added a comment to T128718: Cite allows block content inside a span.

I am not sure, but I guess will likely put less constraints on how reference text can be made in the future. I would like to know the opinion of the other experienced members.

Apr 10 2016, 7:20 AM · Patch-For-Review, good first bug, Cite

Apr 7 2016

Aashaka updated the task description for T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.
Apr 7 2016, 10:59 AM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer

Mar 30 2016

Aashaka added a comment to T116561: Position of boolean operators inside an if condition.

I understand. At that time, I had forgotten that Reviewer-bot asked reviewers to do patch review too.

Mar 30 2016, 3:14 AM · Patch-For-Review, MediaWiki-Codesniffer

Mar 27 2016

Aashaka added a comment to T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.

@Legoktm , @EBernhardson , @Addshore, and others, I have changed my proposal to reflect the final draft submitted at the Summer of Code with Google site. :)

Mar 27 2016, 6:29 PM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer
Aashaka updated the task description for T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.
Mar 27 2016, 6:24 PM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer

Mar 25 2016

Aashaka added a comment to T116561: Position of boolean operators inside an if condition.

@Legoktm : Please review :)

Mar 25 2016, 3:21 PM · Patch-For-Review, MediaWiki-Codesniffer
Aashaka claimed T116561: Position of boolean operators inside an if condition.
Mar 25 2016, 11:06 AM · Patch-For-Review, MediaWiki-Codesniffer
Aashaka added a comment to T127572: "Uninitialized string offset: 72" errors from SpaceBeforeSingleLineCommentSniff.php.

@Jdforrester-WMF : I am unable to recreate the PHP Notice by running composer test on mw-config. Can you explain how to?
I also found that this kind of Notice comes when we reference a string like it is an array. ( $content over here in line 69). Once I test it locally after recreating the error, I'll submit a patch.

Mar 25 2016, 3:54 AM · Patch-For-Review, MediaWiki-Codesniffer

Mar 23 2016

Aashaka claimed T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.
Mar 23 2016, 1:39 PM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer

Mar 21 2016

Aashaka added a comment to T89682: Improving static analysis tools for MediaWiki.

@Legoktm @EBernhardson : Could you provide some microtasks to work on? Thanks!

Mar 21 2016, 6:55 AM · MediaWiki-Codesniffer (MediaWiki-Codesniffer-GSoC-2016), Outreachy-Round-12, Google-Summer-of-Code (2016)
Aashaka updated the task description for T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.
Mar 21 2016, 6:53 AM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer
Aashaka removed a project from T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki: Possible-Tech-Projects.
Mar 21 2016, 6:21 AM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer

Mar 18 2016

Aashaka added a comment to T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.

@Legoktm, @EBernhardson and the rest of the community : Do have a look and suggest improvements in the proposal!

Mar 18 2016, 5:03 PM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer
Aashaka created T130382: GSoC/Outreachy Proposal for Improving static analysis tools for Mediawiki.
Mar 18 2016, 5:00 PM · Google-Summer-of-Code (2016), MediaWiki-Codesniffer

Mar 15 2016

Aashaka updated subscribers of T50963: Add sniff to detect usage of deprecated $wgUser.

@Addshore, I think that @hashar's patch with changes to the description and a few other changes is what I had in mind. May I amend @hashar's patch, or submit a new one? I am relatively new here, and would love some guidance.

Mar 15 2016, 3:11 AM · good first bug, MediaWiki-Codesniffer

Mar 14 2016

Aashaka added a comment to T50963: Add sniff to detect usage of deprecated $wgUser.

I am interested in working on this. Should the PHP CodeSniffer sniff for $wgUser and warn to use RequestContext::getMain()->getUser() instead? Also, should it be automatically replaceable using phpcbf?

Mar 14 2016, 5:59 PM · good first bug, MediaWiki-Codesniffer
Aashaka placed T48109: Do not format messages by direct formatting, wrap them in classed/id'ed element instead up for grabs.
Mar 14 2016, 12:22 PM · Patch-For-Review, Accessibility, good first bug, MediaWiki-extensions-Scribunto

Mar 12 2016

Aashaka added a comment to T117743: Convert Special:ListFiles to OOUI and improve UX.

I see. So should I bring the label and the field in the same line, or is there something else which needs to be worked upon?

Mar 12 2016, 1:22 PM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MediaWiki-Special-pages, UI-Standardization
Aashaka claimed T117743: Convert Special:ListFiles to OOUI and improve UX.
Mar 12 2016, 10:15 AM · MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MediaWiki-Special-pages, UI-Standardization

Mar 10 2016

Aashaka claimed T48109: Do not format messages by direct formatting, wrap them in classed/id'ed element instead.
Mar 10 2016, 1:13 PM · Patch-For-Review, Accessibility, good first bug, MediaWiki-extensions-Scribunto

Mar 9 2016

Aashaka added a comment to T128718: Cite allows block content inside a span.

I would like to work on this bug. I have changed span to div where required and applied display:inline styling to div.reference-text in ext.cite.styles.css.
I also made suitable changes in citeParserTests.txt. But I got confused by the presence of this file, as I didn't see any tests for Cite extension. Are there tests for this extension which I am not able find?

Mar 9 2016, 12:56 PM · Patch-For-Review, good first bug, Cite

Mar 7 2016

Aashaka added a comment to T73660: Add ZIM format support to OCG.

I would like to work on this project as a part of Outreachy round 12/ GSoC 2016. I am fairly good at PHP and know some Node.JS. I have read about the ZIM format and OCG. I intend to look at the present stub of solution implemented in the next couple days, and in parallel solve the microtasks. @cscott, will you be willing to work as a mentor for this project?

Mar 7 2016, 5:32 PM · OCG-General

Jan 30 2016

Aashaka added a comment to T105648: ChangeTags::formatSummaryRow needs a context.

@Florian, A small doubt regarding your comment in https://gerrit.wikimedia.org/r/#/c/267250/.
https://github.com/wikimedia/mediawiki-extensions-InterwikiIntegration/blob/a96ddf567627b860f0b00f2ad3c69930a9972076/InterwikiIntegrationChangesList.php#L47 uses RequestContext::getMain(). Should I use it too? I read https://www.mediawiki.org/wiki/Manual:RequestContext which said use it as a last resort.
Thanks :)

Jan 30 2016, 11:52 AM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-Change-tagging, good first bug

Jan 27 2016

Aashaka added a comment to T105648: ChangeTags::formatSummaryRow needs a context.

I see. I was going through the https://www.mediawiki.org/wiki/Manual:Pre-commit_checklist, which included performing unit tests. I suppose I will just test it by running it on Vagrant.

Jan 27 2016, 9:04 AM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-Change-tagging, good first bug
Aashaka added a comment to T105648: ChangeTags::formatSummaryRow needs a context.

Thanks for your reply Aklapper. I was travelling for a while. I have gone through it. I couldn't find a unit test for the ChangeTags class.

Jan 27 2016, 8:43 AM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-Change-tagging, good first bug

Jan 20 2016

Aashaka added a comment to T105648: ChangeTags::formatSummaryRow needs a context.

According to me the changes should be adding a parameter IContextSource $context to the function, and change

wfMessage('tag-list-wrapper') to $context->msg( 'tag-list-wrapper' )

and

$wgLang->commaList( $displayTags ) to $context->getLanguage()->commaList( $displayTags )
Jan 20 2016, 6:57 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-Change-tagging, good first bug
Restricted Application updated subscribers of T105648: ChangeTags::formatSummaryRow needs a context.

I would like to work on this bug. Since I am new to MediaWiki, it would be helpful if someone could point me in the right direction.

Jan 20 2016, 6:57 PM · MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), MediaWiki-Change-tagging, good first bug