Page MenuHomePhabricator

AdamCuerden (Adam Cuerden)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2015, 7:38 PM (451 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Adam Cuerden [ Global Accounts ]

Recent Activity

Feb 3 2024

AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

I'm going to be honest (although you probably expect that at this point): I don't quite understand what's so hard about just... coding a graceful failure state for anything that seems non-simple. If you end up with, say, https://commons.wikimedia.org/wiki/File:Edward_Duncan_-_The_Explosion_of_the_United_States_Steam_Frigate_Missouri_-_Original.tiff - where there's three creator cards and an awful lot of important text explaining the roles - it's probably going to be far easier to just direct people to the file description page than try to convert it to an attribution line. Like, it really feels like an attempt at perfection is overruling the simple solution of just... handling the trivial cases you can handle and including a "see here" link for anything not readily machine readable.

Feb 3 2024, 6:48 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer

May 11 2022

AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

Seriously, if you think no work was done in it, why not switch all usages over to the unrestricted version, https://www.loc.gov/pictures/resource/pga.04038/ ? The one with rips, pockmarks, poor colour fidelity, etc.

May 11 2022, 4:53 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer
AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

That actually works out well for Battle of Spottsylvania by Thure de Thulstrup.jpg where the text outside the hcard template is not related to authorship

May 11 2022, 4:44 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer

Apr 25 2022

Josve05a awarded T68606: Media viewer fails to give credit to all people in specific circumstances a Manufacturing Defect? token.
Apr 25 2022, 6:49 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer

Jan 16 2022

AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

Little followup. Here we see Media Viewer turning a CC-by image that requires crediting me into a Public Domain image that does not credit me.

Jan 16 2022, 6:21 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer
AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

I should probably give an example, to show the problem is widespread.

Jan 16 2022, 4:47 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer
AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

@AdamCuerden: Please read and follow https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette If you would like to be active here. This is an issue tracker and not a random forum. Thanks for your understanding.

Jan 16 2022, 4:30 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer
AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

I've just discovered this is more broken than I thought: It's not even an edge case: It can't handle more than one {{Creator}} template. So in literally any case where an image has more than one creator, it will fail to credit at least one person.

Jan 16 2022, 4:22 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer
AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

Look, it's been 8 years. Make a fix, and if it causes problems, make another, but in those 8 years countless sites have used my work, not needed the big version, so just used the Media Viewer copy. And I want my work used, but I really would like credit, and, honestly, have a legal right to it. The legal concept of moral rights kind of have to overwhelm "it might not look nice in some cases", because I'm honestly infinitely patient for Wikipedia's bullcrap to sort itself out, but not everyone's going to be, and this affects literally every situation where a more-famous author with a Creator template has a co-author that doesn't.

Jan 16 2022, 5:57 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer

Jan 14 2022

AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

Seriously, how will structured data be any more structured than "The stuff in the Author field of the Information Template. Include it all or be violating copyright? Or are you going to hand-redo a few thousand files to suit this new data?

Jan 14 2022, 5:59 PM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer
Sdkb awarded T299230: Incorrect attribution in Mediawiki Image viewer a Like token.
Jan 14 2022, 5:23 PM · MediaViewer
AdamCuerden created T299230: Incorrect attribution in Mediawiki Image viewer.
Jan 14 2022, 4:52 PM · MediaViewer

Mar 21 2019

AdamCuerden added a comment to T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.

That's unfair. FileImporter IS a good substitute in most cases. But if it has a limit, there are going to be cases it needs done by hand.

Mar 21 2019, 10:11 AM · Commons, Wikimedia-Site-requests
AdamCuerden added a comment to T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.

FileImporter may eventually be a good substitute, but unless the maximum size on it is moved WAY, WAY up, we need a way to do it by hand.

Mar 21 2019, 9:37 AM · Commons, Wikimedia-Site-requests
AdamCuerden added a comment to T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.

Maybe the new beta FileImporter can handle your file? That would also copy the history and that sounds better than the url upload

https://www.mediawiki.org/wiki/Help:Extension:FileImporter

Mar 21 2019, 9:36 AM · Commons, Wikimedia-Site-requests

Mar 19 2019

AdamCuerden added a comment to T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.

Also: There are copyrighted images on many of the whitelisted sites - loc.gov bnf.fr , most likely others. It's not like the whitelist means the site is 100% copyright-free.

Mar 19 2019, 10:29 PM · Commons, Wikimedia-Site-requests
AdamCuerden added a comment to T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.

No more so than any other problematic upload on Commons. They happen sometimes; they're probably less likely to happen using the method that requires a fair bit more technical knowledge.

Mar 19 2019, 10:23 PM · Commons, Wikimedia-Site-requests
AdamCuerden added a comment to T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.

Checking, it's wikimedia.org since the actual site is uploads.wikimedia.org

Mar 19 2019, 9:29 PM · Commons, Wikimedia-Site-requests
AdamCuerden created T218745: Add wikipedia.org to the wgCopyUploadsDomains whitelist of Wikimedia Commons.
Mar 19 2019, 9:26 PM · Commons, Wikimedia-Site-requests

Jun 6 2017

Jdlrobson awarded T141349: Change the default mode of <gallery> tags to mode=packed on English Wikipedia a Pirate Logo token.
Jun 6 2017, 4:24 PM · Technical-Debt, Reading-Web-Sprint-80-V-for-Vandalism, Reading-Web-Sprint-78-Terminal-Velocity, Reading-Web-Sprint-77-Segmentation-fault, Multimedia, Wikimedia-Site-requests, MediaWiki-Gallery

May 6 2017

AdamCuerden added a comment to T35186: Provide a well-performing API to rotate an image.

The biggest problem with this patch is that it came out of a request to
allow rotations in multiples of 90°. Commons does not need or want anything
besides that, because you don't want eyeballed rotations, and 90° multiples
are about the only ones you can do eyeballing that are worth doing.
Anything else you want people taking the image to proper image editing
software, with guidelines and care.

May 6 2017, 9:16 AM · Patch-For-Review, User-TheresNoTime, Platform Engineering, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-Action-API

Oct 27 2016

AdamCuerden added a comment to T141349: Change the default mode of <gallery> tags to mode=packed on English Wikipedia.

I don't see it working at that link? Is it turned back off?

Oct 27 2016, 1:44 AM · Technical-Debt, Reading-Web-Sprint-80-V-for-Vandalism, Reading-Web-Sprint-78-Terminal-Velocity, Reading-Web-Sprint-77-Segmentation-fault, Multimedia, Wikimedia-Site-requests, MediaWiki-Gallery

Sep 16 2016

AdamCuerden added a comment to T109201: Adjustable image spacing in packed gallery mode.

More practically, I think the only real issue is with very tall, but narrow images that have captions. Could a minimum width/height be instituted, so that the space occupied can't get too narrow leading to

Sep 16 2016, 6:24 PM · Multimedia, MediaWiki-Gallery, Design

Aug 15 2016

AdamCuerden added a comment to T141349: Change the default mode of <gallery> tags to mode=packed on English Wikipedia.

Any updates on progress?

Aug 15 2016, 4:38 PM · Technical-Debt, Reading-Web-Sprint-80-V-for-Vandalism, Reading-Web-Sprint-78-Terminal-Velocity, Reading-Web-Sprint-77-Segmentation-fault, Multimedia, Wikimedia-Site-requests, MediaWiki-Gallery

Jul 26 2016

AdamCuerden created T141349: Change the default mode of <gallery> tags to mode=packed on English Wikipedia.
Jul 26 2016, 10:36 AM · Technical-Debt, Reading-Web-Sprint-80-V-for-Vandalism, Reading-Web-Sprint-78-Terminal-Velocity, Reading-Web-Sprint-77-Segmentation-fault, Multimedia, Wikimedia-Site-requests, MediaWiki-Gallery

Jun 28 2016

AdamCuerden added a comment to T138796: Over-sharpening of professional/high-res JPEG images uploaded to Wikimedia Commons.

As I understand it, all JPEGs are sharpened the same amount, and all PNGs not at all. My experience with older photos (with film grain and such) and engravings is that some sharpening is needed, though I suspect a bit less could work in most cases. But we need this feature.

Jun 28 2016, 5:50 PM · Thumbor, Commons

Jun 27 2016

AdamCuerden added a comment to T138711: Enable Machine Translation in English in the content translation tool.

Anyway, as I said (with a typo correction): I don't think any major translator service doesn't start with a machine translation and then improve it by comparison with the original language's text. This machine translation is already available, and offered to other languages, help those of us out who translate into English: Turn it on; if people don't want it, they don't have to use it.

Jun 27 2016, 8:26 AM · CX-deployments, Community-consensus-needed, OKR-Work
AdamCuerden added a comment to T138711: Enable Machine Translation in English in the content translation tool.

...Oops. Serves me right for trying to do this on a dodgy wifi. Sorry for the triple-merge

Jun 27 2016, 8:23 AM · CX-deployments, Community-consensus-needed, OKR-Work
AdamCuerden merged T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]] into T138711: Enable Machine Translation in English in the content translation tool.
Jun 27 2016, 8:22 AM · CX-deployments, Community-consensus-needed, OKR-Work
AdamCuerden merged task T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]] into T138711: Enable Machine Translation in English in the content translation tool.
Jun 27 2016, 8:22 AM · ContentTranslation-Deployments
AdamCuerden merged T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]] into T138711: Enable Machine Translation in English in the content translation tool.
Jun 27 2016, 8:22 AM · CX-deployments, Community-consensus-needed, OKR-Work
AdamCuerden merged task T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]] into T138711: Enable Machine Translation in English in the content translation tool.
Jun 27 2016, 8:22 AM · ContentTranslation-Deployments
AdamCuerden merged T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]] into T138711: Enable Machine Translation in English in the content translation tool.
Jun 27 2016, 8:22 AM · CX-deployments, Community-consensus-needed, OKR-Work
AdamCuerden merged task T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]] into T138711: Enable Machine Translation in English in the content translation tool.
Jun 27 2016, 8:22 AM · ContentTranslation-Deployments

Jun 26 2016

AdamCuerden created T138735: Add English to the languages that get machine translation in [[Special:ContentTranslation]].
Jun 26 2016, 6:06 PM · ContentTranslation-Deployments

Feb 5 2016

AdamCuerden added a comment to T68606: Media viewer fails to give credit to all people in specific circumstances.

Well, we agree it's bad to leave out one of the credits, right?

Feb 5 2016, 2:45 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), Multimedia, CommonsMetadata, MediaViewer

Feb 3 2016

AdamCuerden added a comment to T34875: Provide an interface to rotate an image.

Remember that images degrade with every rotation. Further, we're rotating rectangles, not circles: if you rotate a rectangle anything but 90 degrees, you end up with either triangular gaps in the corners where the rotated image is put into a larger box, or you have to crop, throwing information away. **We do not want to encourage throwing away information before it's even saved, using a Web-based device that people will quickly eyeball the rotation and hit save on, because what else are they going to do.

Feb 3 2016, 3:40 AM · Commons, Multimedia, MediaWiki-File-management
AdamCuerden added a comment to T34875: Provide an interface to rotate an image.

Again, please only allow 90 degree rotations. We do NOT, under ANY circumstances want people guessing at rotations at upload, then doing rough crops before any original copy has even been saved. 90 degree rotations are safe both at upload or later. Anything more than that, and we must save the original copy first

Feb 3 2016, 3:36 AM · Commons, Multimedia, MediaWiki-File-management

Jan 12 2016

AdamCuerden added a comment to T123381: Thumbnailer giving random changes in contrast/white point for greyscale PNG.

Last three images now, sorry: Wanted to fix some bright spots.

Jan 12 2016, 5:56 PM · MediaWiki-File-management, Multimedia, Commons
AdamCuerden created T123381: Thumbnailer giving random changes in contrast/white point for greyscale PNG.
Jan 12 2016, 5:46 PM · MediaWiki-File-management, Multimedia, Commons

Sep 24 2015

AdamCuerden added a comment to T48741: UploadWizard unable to override "similar name"/"same name" detection warning.

Thank you so much for this.

Sep 24 2015, 9:01 AM · User-notice-archive, MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-13_(1.27.0-wmf.3)), WMF-deploy-2015-09-15_(1.26wmf23), MW-1.26-release, Patch-For-Review, Multimedia, UploadWizard
AdamCuerden added a comment to T4700: Pre-save transform skips extensions using wikitext (gallery, references, footnotes, Cite, status indicators, pipe trick, subst, signatures).

this has surely gone on long enough, with maqsses of lost resources.

Sep 24 2015, 8:58 AM · Patch-For-Review, Cite, Epic, MediaWiki-Parser
AdamCuerden raised the priority of T4700: Pre-save transform skips extensions using wikitext (gallery, references, footnotes, Cite, status indicators, pipe trick, subst, signatures) from High to Unbreak Now!.
Sep 24 2015, 8:58 AM · Patch-For-Review, Cite, Epic, MediaWiki-Parser

Sep 16 2015

AdamCuerden added a comment to T35186: Provide a well-performing API to rotate an image.

As stated earlier in the comment thread, 90 degree rotations can be performed losslessly on many formats (the vast majority of our originals, when you look at the distribution of file types), including JPEG without having to use EXIF rotation. jpegtran is what allows lossless EXIF-free rotation of JPEGs.

Sep 16 2015, 4:59 AM · Patch-For-Review, User-TheresNoTime, Platform Engineering, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-Action-API

Sep 15 2015

AdamCuerden added a comment to T35186: Provide a well-performing API to rotate an image.

See http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/ - it's not perfectly supported by every website, but Wikipedia handles it quite well, and it's not like we haven't led things before. OGG support was almost non-existent before Wikipedia.

Sep 15 2015, 4:37 PM · Patch-For-Review, User-TheresNoTime, Platform Engineering, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-Action-API
AdamCuerden added a comment to T35186: Provide a well-performing API to rotate an image.

It rather seems like the scope of this is growing into something the community doesn't want or need, when all we really need is the ability to correct simple 90° rotations. Hell, even just the ability to set an orientation code in the EXIF might be enough.

Sep 15 2015, 4:35 PM · Patch-For-Review, User-TheresNoTime, Platform Engineering, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-Action-API
AdamCuerden added a comment to T35186: Provide a well-performing API to rotate an image.

That's what's image editing programs are for. I think it's actually kind of dangerous: Each change degrades an image slightly, and arbitrary rotation - in the absence of things like guides and such - are likely to be too approximate. And heaven help us if we allow arbitrary cropping on upload - we already have a problem with engravings and such being inappropriately cropped in ways that kills a lot of their reusability. (e.g. removing the edges, meaning they can no longer be reproduced in their original form; removing text that was a part of the engraving (and often not documenting it) etc.

Sep 15 2015, 4:28 PM · Patch-For-Review, User-TheresNoTime, Platform Engineering, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-Action-API

Sep 14 2015

AdamCuerden added a comment to T35186: Provide a well-performing API to rotate an image.

Can I make a request that this ONLY be done for 90, 180, or 270° rotations? Anything that needs a crop or transparency should require actual human thought.

Sep 14 2015, 3:28 AM · Patch-For-Review, User-TheresNoTime, Platform Engineering, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-Action-API

Aug 6 2015

AdamCuerden reopened T55120: Remove deprecated sajax js library from MediaWiki core as "Stalled".
Aug 6 2015, 2:21 PM · User-notice-archive, Wikimedia-Performance-publish, Performance-Team, MW-1.26-release, Technical-Debt, MediaWiki-General
AdamCuerden reopened T55120: Remove deprecated sajax js library from MediaWiki core, a subtask of T42787: Remove legacy ajax interface, as Stalled.
Aug 6 2015, 2:21 PM · MW-1.38-release, Platform Engineering Code Jam-2021, CreateAPage, Platform Engineering Roadmap Decision Making, TechCom, Technical-Debt (Deprecation process), MediaWiki-General
AdamCuerden added a comment to T55120: Remove deprecated sajax js library from MediaWiki core.

Agreed. Processes affected include, [[:en:Wikipedia:Featured picture candidates]] and - it would appear - a good section of [[:en:WP:TWINKLE]]. These are perfectly fixable, but '''there is literally no reason whatsoever on the developer's part to break them without any warning whatsoever.

Aug 6 2015, 2:19 PM · User-notice-archive, Wikimedia-Performance-publish, Performance-Team, MW-1.26-release, Technical-Debt, MediaWiki-General

Jul 26 2015

AdamCuerden created T106985: Edit cannot be saved because of loss of Session data .
Jul 26 2015, 4:15 PM

Jul 24 2015

AdamCuerden added a comment to T106895: Thumbnails no longer rendering for recent local uploads.

Last two links should be

Jul 24 2015, 9:24 PM · User-notice-archive, SRE, Wikimedia-Media-storage, Multimedia
AdamCuerden created T106895: Thumbnails no longer rendering for recent local uploads.
Jul 24 2015, 9:23 PM · User-notice-archive, SRE, Wikimedia-Media-storage, Multimedia