Page MenuHomePhabricator

Addshore (Adam_WMDE)
Community & WMDE Developer (Wikidata Tech Lead 🐢)

Projects (50)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:43 PM (258 w, 2 d)
Availability
Away Away until Sep 30.
IRC Nick
Addshore
LDAP User
Addshore
MediaWiki User
Addshore [ Global Accounts ]

Recent Activity

Tue, Sep 10

Addshore merged Restricted Task into T232491: Numerous people reporting issues saving edits and viewing previews/diffs.
Tue, Sep 10, 10:34 PM · netops, Traffic, Wikimedia-General-or-Unknown, Operations

Mon, Sep 9

Addshore added a comment to T232248: The Wikibase web interface shows non-functional sitelink groups.

Looks like we tried to fix this at some point but it got lost in the backlog of things.

Mon, Sep 9, 7:04 PM · Patch-For-Review, MediaWiki-extensions-WikibaseRepository, Wikidata

Sun, Sep 8

Addshore added a comment to T208493: Create testing framework for Wikimedia wiki config (mediawiki/config).

Dupes?

Sun, Sep 8, 6:12 PM · Wikidata, Wikidata-Campsite
Addshore added a comment to T220775: Consider creating a puppet-compiler equivalent for mediawiki-config.git.

I think this and T208493 are essentially dupes of each other.

Sun, Sep 8, 6:12 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, serviceops-radar, Continuous-Integration-Config, Wikimedia-Site-requests
Addshore added a comment to T227643: dumpRDF.php generates a hash-based conceptUri.

What config was that updater running with?
Why is it getting subjects with localhost referenced like http://localhost:8181/entity/Q2 ?

Sun, Sep 8, 6:11 PM · Wikidata-Campsite, User-Ladsgroup, Wikidata-Query-Service, Wikibase-Containers, Wikidata
Addshore added a comment to T227035: Cant log into discuss space in discourse Android app, 503.

I just checked again and I still get redirected to a 5** error, now a 502, on the URL as described in this ticket :/

Sun, Sep 8, 6:01 PM · Space
Addshore added a comment to T231845: wdqs update with restricted view access on anonymous users.

Tagged the query service as this is a usecase for third party wikis that may want a little bit of thought.

Sun, Sep 8, 5:59 PM · Wikidata-Query-Service, Wikidata, Wikibase-Containers
Addshore added a project to T231845: wdqs update with restricted view access on anonymous users: Wikidata-Query-Service.

Hmm, that is indeed correct, the query service updater needs read access.

Sun, Sep 8, 5:59 PM · Wikidata-Query-Service, Wikidata, Wikibase-Containers
Addshore added a comment to T231646: Investigate removing interdependence between page id and id of mediainfo item in a slot on that page.

It seems like the dependency between the page_id and the MediaInfo item id is baked in at a very deep level

Sun, Sep 8, 5:55 PM · Structured-Data-Team-Current-Work, Structured-Data-Backlog (Current Work), WikibaseMediaInfo

Tue, Sep 3

Addshore added a comment to T172937: Cursor jumping to next field and overlapping of menus.

I'm guessing this shouldn't still be subscribed to @hoo

Tue, Sep 3, 1:17 PM · Wikidata-Campsite, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata
Addshore placed T172937: Cursor jumping to next field and overlapping of menus up for grabs.
Tue, Sep 3, 1:17 PM · Wikidata-Campsite, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Wikidata

Thu, Aug 29

Addshore assigned T231547: 404 error at https://wikiba.se/ontology to MasinAlDujailiWMDE.
Thu, Aug 29, 12:43 PM · wikiba.se website, Wikidata
Addshore updated subscribers of T231547: 404 error at https://wikiba.se/ontology.
Thu, Aug 29, 12:43 PM · wikiba.se website, Wikidata
Addshore updated subscribers of T231547: 404 error at https://wikiba.se/ontology.
Thu, Aug 29, 12:42 PM · wikiba.se website, Wikidata

Wed, Aug 28

Addshore added a comment to T68025: [Story] Monitor size of some Wikidata database tables.

There is only a single point right now (per metric) and it might have dropped off the time range by now! But it is there :)
In grafana you might find it doesn't draw a line when looking at a time range including the point.

Wed, Aug 28, 3:22 PM · WMDE-Analytics-Engineering, DBA, Story, Wikidata, Wikidata.org

Tue, Aug 27

Addshore committed rADESc3894cc0e970: Create script tracking number of slots on wikibase repos (authored by Addshore).
Create script tracking number of slots on wikibase repos
Tue, Aug 27, 7:48 PM
Addshore committed rADES972b53c36de2: Create script tracking number of slots on wikibase repos (authored by Addshore).
Create script tracking number of slots on wikibase repos
Tue, Aug 27, 7:48 PM
Addshore added a comment to T68025: [Story] Monitor size of some Wikidata database tables.

Looks like the data has landed.

Tue, Aug 27, 7:12 PM · WMDE-Analytics-Engineering, DBA, Story, Wikidata, Wikidata.org
Addshore added a comment to T230288: Allow CHUNK value to be passed in as an option for munge.sh.

Great!

Tue, Aug 27, 7:04 PM · Discovery-Wikidata-Query-Service-Sprint, User-Addshore, Wikidata-Query-Service, Wikidata
Addshore added a comment to T228513: Start using webpack for dependency management and bundling.
  • How build process of webpack packs will integrate with our build pipeline? Checking in compiled packs will cause merging separate patches harder

Yeah, that's a drawback

Tue, Aug 27, 6:55 PM · RL Module Terminators Trailblazing, Developer Productivity, User-Alaa, Patch-For-Review, Wikidata-Trailblazing-Exploration, Wikidata, Performance
Addshore added a comment to T68025: [Story] Monitor size of some Wikidata database tables.

I just hit +2 on the patch.
It runs weekly, which is "every sunday at 01 hours".
So let's check back next week!

Tue, Aug 27, 6:43 PM · WMDE-Analytics-Engineering, DBA, Story, Wikidata, Wikidata.org
Addshore added a comment to T230288: Allow CHUNK value to be passed in as an option for munge.sh.

@Addshore I was planning to do 0.3.2 pretty soon, if that is easier for you you could use that.

Tue, Aug 27, 6:21 PM · Discovery-Wikidata-Query-Service-Sprint, User-Addshore, Wikidata-Query-Service, Wikidata
Addshore renamed T230975: change LocalSettings.php on a running system wikibase-docker from change LocalSettings.php on a running system to change LocalSettings.php on a running system wikibase-docker.
Tue, Aug 27, 6:20 PM · User-Addshore, Wikidata, Wikibase-Containers
Addshore closed T230975: change LocalSettings.php on a running system wikibase-docker as Resolved.

I see the following options, not sure which is the best one or if there is some better alternative

change the file directly in the docker image
    do the changes persist on restarting?
Tue, Aug 27, 6:20 PM · User-Addshore, Wikidata, Wikibase-Containers
Addshore added a comment to T231128: allow to easily relate a published image tag with a wikibase-docker commit.

I guess this mainly applies to the wdqs frontend?

Tue, Aug 27, 6:09 PM · Wikibase-Containers, Wikidata
Addshore added a comment to T229241: restrict length of string value input.

I would just keep it simple for now and mark it as unstable and only for use with the bridge.
Just include what you need there, and call it something like wbbridgesettings for now?
I can defiantly see a need for more things like this in the future but it probably isn't worth the time thinking too deeply about those cases yet.

Tue, Aug 27, 2:54 PM · Wikidata, Wikidata-Bridge
Addshore added a comment to T231204: track Bridge openings by property datatype.

Sounds like the right way for this would be JS -> graphite via statsv and statsd and then just displaying the data in grafana.
https://wikitech.wikimedia.org/wiki/Graphite#statsv included the needed infomation using mw.track in JS.

Tue, Aug 27, 2:47 PM · Wikidata-Bridge, Wikidata
Addshore added a comment to T227811: docker-compose wdqs-frontend generates unresolvable item links in results.

tear down the services with docker-compose down then boot them up again docker-compose up -d. note: this is seems to be required for wdqs-updater if it was run first time with a wikibase instance that had no entities yet.. so in case you had already the bundle setup and wdqs-updater running properly you might not need this step.

Tue, Aug 27, 2:44 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
Addshore added a comment to T227811: docker-compose wdqs-frontend generates unresolvable item links in results.

The URI returned by the query service is all down to the URI written to the query service during updating.
This is set using the WIKIBASE_HOST env var for the updater service / wherever the update runs.

Tue, Aug 27, 2:39 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata

Tue, Aug 20

Addshore added a comment to T227032: Start tagging images of Query Service UI.

At any given point, the latest image might be broken.

Tue, Aug 20, 12:22 PM · Wikidata-Campsite, Wikidata Query UI, Wikibase-Containers, Wikidata

Aug 19 2019

Addshore created T230739: Mailgun, Warning: : array_key_exists() expects parameter 2 to be array, null given in .
Aug 19 2019, 5:42 PM · MediaWiki-extensions-Mailgun
Addshore added a comment to T230288: Allow CHUNK value to be passed in as an option for munge.sh.

Amazing, would it be possible to get this bakcported to 0.3.1?
Or should I just back it into the docker images ? :)

Aug 19 2019, 2:50 PM · Discovery-Wikidata-Query-Service-Sprint, User-Addshore, Wikidata-Query-Service, Wikidata

Aug 12 2019

Addshore updated subscribers of T212117: Do API permission checks before validation.

There are a couple of situations that I remember where some validation needs to take place first in order to know what permissions to check.
This mainly applies to api modules that act on multiple entity types where entity type specific permissions also exist.
As for the points #1,2,3 in the description I agree with the order there.

Aug 12 2019, 5:36 PM · Wikidata-Trailblazing-Exploration, Technical-Debt, Wikidata, Wikidata-Campsite
Addshore updated subscribers of T207407: Remove legacy Database search integration of ArticlePlaceholder.

@alaa_wmde feel like a campsite candidate to you?

Aug 12 2019, 5:33 PM · Wikidata-Trailblazing-Exploration, Technical-Debt, Wikidata, ArticlePlaceholder
Addshore moved T205094: Investigate restructure SQL directory from Backlog to On Hold / Stalled on the Wikidata-Trailblazing-Exploration board.

I'm very pro us having a cleaner structure for our DB updates, but rather than spend time on this now we should probably see how T191231 finishes evolving and if any standards come out of that.

Aug 12 2019, 5:33 PM · Wikidata-Trailblazing-Exploration, Technical-Debt, wikidata-tech-focus, Wikidata
Addshore moved T226773: Refactor ReplicaMasterAwareRecordIdsAcquirer from Backlog to Campsite Candidates on the Wikidata-Trailblazing-Exploration board.

This feels like a campsite candidate to you too @Addshore ?

Aug 12 2019, 5:31 PM · Patch-For-Review, Wikidata-Trailblazing-Exploration, Wikidata
Addshore added a comment to T228513: Start using webpack for dependency management and bundling.

@Ladsgroup does the MobileFrontend skin use minification in webpack, or leave it down the RL?
My main though here is it would be nice to not have minified things with debug=true?

Aug 12 2019, 5:19 PM · RL Module Terminators Trailblazing, Developer Productivity, User-Alaa, Patch-For-Review, Wikidata-Trailblazing-Exploration, Wikidata, Performance
Addshore added a comment to T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase.

I think the reason is that the graphs are in log scale

can't see where they are in log scale, they are all in time or percentage here https://grafana.wikimedia.org/d/000000615/wikibase-editentity?orgId=1

Aug 12 2019, 5:08 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Performance, Wikidata

Aug 10 2019

Addshore moved T230288: Allow CHUNK value to be passed in as an option for munge.sh from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.
Aug 10 2019, 11:20 PM · Discovery-Wikidata-Query-Service-Sprint, User-Addshore, Wikidata-Query-Service, Wikidata
Addshore added a project to T230288: Allow CHUNK value to be passed in as an option for munge.sh: User-Addshore.
Aug 10 2019, 11:20 PM · Discovery-Wikidata-Query-Service-Sprint, User-Addshore, Wikidata-Query-Service, Wikidata
Addshore created T230288: Allow CHUNK value to be passed in as an option for munge.sh.
Aug 10 2019, 11:19 PM · Discovery-Wikidata-Query-Service-Sprint, User-Addshore, Wikidata-Query-Service, Wikidata
Addshore moved T230244: Restore wdqs1009 to its role as auto-deploy testing from incoming to monitoring on the Wikidata board.
Aug 10 2019, 3:44 PM · Discovery-Wikidata-Query-Service-Sprint, Wikidata-Query-Service, Wikidata
Addshore moved T230247: Increase VCPU quota for wikidata-query project from incoming to monitoring on the Wikidata board.
Aug 10 2019, 3:43 PM · cloud-services-team (Kanban), Cloud-VPS (Quota-requests), Discovery-Wikidata-Query-Service-Sprint, Wikidata, Wikidata-Query-Service
Addshore assigned T155359: wikiba.se should use HTTPS to MasinAlDujailiWMDE.
Aug 10 2019, 3:27 AM · User-Addshore, wikiba.se website, Wikidata

Aug 9 2019

Addshore moved T99531: [Task] move wikiba.se webhosting to wikimedia cluster from Back Burner 🏛️ to Watching 👀 on the User-Addshore board.
Aug 9 2019, 7:28 PM · User-Addshore, serviceops, wikidata-tech-focus, Traffic, wikiba.se website, Operations, Wikidata-Sprint-2016-11-08, Wikidata
Addshore added a comment to T207683: Wikibase Repo api modules and special pages should be conditionally loaded based on entity types enabled (or at least, not crash).

Yup, it would also make sense to conditionally load those.

Aug 9 2019, 7:23 PM · Structured-Data-Backlog, Structured Data Engineering, StructuredDataOnCommons, Wikidata
Addshore added a comment to T99531: [Task] move wikiba.se webhosting to wikimedia cluster.

It seems like we have been in a Mexican standoff / impasse here since July 2017 which is unfortunate, I don't want to know how many hours have been spent trying to figure this out.

Aug 9 2019, 7:22 PM · User-Addshore, serviceops, wikidata-tech-focus, Traffic, wikiba.se website, Operations, Wikidata-Sprint-2016-11-08, Wikidata
Addshore added a comment to T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same.

It's a shame we have cases of self redirects already in history that we have to try to deal with.

Aug 9 2019, 7:16 PM · Multi-Content-Revisions (Tech Debt), CPT Initiatives (MCR), wikidata-tech-focus, User-Addshore, Wikimedia-production-error, Wikidata-Campsite, Wikidata, Dumps-Generation
Addshore updated subscribers of T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same.
Aug 9 2019, 7:13 PM · Multi-Content-Revisions (Tech Debt), CPT Initiatives (MCR), wikidata-tech-focus, User-Addshore, Wikimedia-production-error, Wikidata-Campsite, Wikidata, Dumps-Generation
Addshore added a comment to T155359: wikiba.se should use HTTPS.

Sounds like we should:

  • Leave this ticket open
  • Move the NS servers for wikiba.se back to the WMDE controlled ones
  • Remove the DNS stuff I added to wmf stuff for wikibase.se
  • Setup letsencrypt or something similar for wikiba.se as controlled by wmde
  • Close this ticket.
Aug 9 2019, 7:11 PM · User-Addshore, wikiba.se website, Wikidata
Addshore added a comment to T99531: [Task] move wikiba.se webhosting to wikimedia cluster.

It sounds like we should just close this ticket as Declined then @WMDE-leszek ?

Aug 9 2019, 7:11 PM · User-Addshore, serviceops, wikidata-tech-focus, Traffic, wikiba.se website, Operations, Wikidata-Sprint-2016-11-08, Wikidata
Addshore added a comment to T48643: [Story] Dispatching via delayed jobs (instead of cron script).

The estimation comes down to, do we:

  1. Just more the dispatching mechanism over to jobs, using the same or very similar logic that we currently have.
    • Probably not the most efficient dispatching logic
    • Least effort to get there
    • Solves most of the issues outlined in T48643#5336132
  2. Change the way dispatching works while we move over to jobs
    • More work & time
    • Probably makes dispatching faster, more efficient, more reliable and easier to understand
    • Best use of job queue for dispatching
    • Also solves the issues outlined in T48643#5336132
Aug 9 2019, 7:04 PM · Wikidata-Trailblazing-Exploration, Story, Wikidata, MediaWiki-extensions-WikibaseRepository
Addshore added a comment to T228986: Talk with component library internal stakeholders.

Is this to be considered an official WMDE product, and if so, who owns it in terms of product and strategy? (@Lydia_Pintscher? Lead Devs? UX (@Jan_Dittrich, @Charlie_WMDE)? )

Aug 9 2019, 6:58 PM · Wikidata-Bridge-Sprint-4, User-Michael, Wikidata-Bridge-Sprint-3, Wikidata-Bridge-Sprint-2, Wikidata
Addshore added a comment to T217770: [Story] Never show anything from a language that is not currently Wikidata conform.
  1. When data load from the storage contains entries using a language code that is not recognized by Wikibase, those entries must not be presented to the user (e.g. for reason X there a label related to the invalid language code stored in the DB,

I seem to remember us talking about this at length but I didn't see it clearly here. Does this mean that we expect historic revisions of entities that contain languages that were valid at the time to now silently not show them?

Aug 9 2019, 6:51 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Addshore added a comment to T214362: RFC: Store WikibaseQualityConstraint check data in persistent storage.
Aug 9 2019, 6:36 PM · Wikibase-Quality-Constraints, Core Platform Team Legacy (Designing), Services (designing), User-mobrovac, wikidata-tech-focus, TechCom-RFC, Wikibase-Quality, Wikidata
Addshore updated subscribers of T227758: [investigate] purging strategy.

Usually, I believe MediaWiki guards against this with the ChronologyProtector, which saves the current replication position in the user’s session and waits until the replica selected for a request has at least caught up with that position. I don’t think that works very well cross-wiki; we could try to make it work, but it’s probably easier to duplicate its functionality client-side.

Aug 9 2019, 6:34 PM · Wikidata, Wikidata-Bridge
Addshore added a comment to T227849: Guarantee that FileImporter imported pages are discoverable after a failure.

So, the last state that this was in was:

Aug 9 2019, 6:20 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), WMDE-QWERTY-Sprint-2019-09-10, WMDE-QWERTY-Sprint-2019-09-04, Patch-For-Review, WMDE-QWERTY-Sprint-2019-08-21 , Move-Files-To-Commons, TCB-Team
Addshore added a comment to T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase.

I believe this one was deployed with:

Aug 9 2019, 12:59 AM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Performance, Wikidata
Addshore added a comment to T226084: Wikidata server slow.

Just checking back on this ticket.
Is this still happening?

Aug 9 2019, 12:44 AM · TestMe, Wikidata-Campsite, Wikidata
Addshore moved T230015: Make "analytics/wmde/toolkit-analyzer-build" use git lfs from incoming to in progress on the Wikidata board.
Aug 9 2019, 12:40 AM · User-Ladsgroup, Release-Engineering-Team (Development services), Release-Engineering-Team-TODO (201908), Gerrit, WMDE-Analytics-Engineering, Wikidata
Addshore moved T230135: Wikidata queries in PAWS return HTTP Error 403: Forbidden from incoming to monitoring on the Wikidata board.
Aug 9 2019, 12:39 AM · Wikidata-Query-Service, Wikidata, PAWS
Addshore moved T230051: wikidata.org handles GET MWAPI requests, but silently fails on POST from incoming to monitoring on the Wikidata board.
Aug 9 2019, 12:39 AM · Traffic, Core Platform Team Workboards (Clinic Duty Team), Operations, Wikidata-Campsite, Wikidata, MediaWiki-API

Aug 8 2019

Addshore added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

Looking at the code it looks like indeed either a new TermIndex type thing would be needed for media info, or the fetching of terms, as currently done in https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/84e2062770467eacbb42e8a55bdf77e11141834f/lib/includes/Store/Sql/TermSqlIndex.php#L638-L686, would need to be factored out in some way.

Aug 8 2019, 3:59 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
Addshore added a comment to T225814: m.wikidata: login status not detected.

My hunch would be that this has to do with the CA cookie domain for things like wikipedia being set to ".wikipedia.org" but the domain for wikidata gets set to "www.wikidata.org".

Aug 8 2019, 3:44 PM · MediaWiki-Authentication-and-authorization, Wikidata Mobile, Wikidata-Termbox, MediaWiki-extensions-CentralAuth, Wikidata
Addshore added a project to T225814: m.wikidata: login status not detected: MediaWiki-Authentication-and-authorization.

Also going to tag MediaWiki-Authentication-and-authorization as it could be related and likely to catch some more eyes.

Aug 8 2019, 3:32 PM · MediaWiki-Authentication-and-authorization, Wikidata Mobile, Wikidata-Termbox, MediaWiki-extensions-CentralAuth, Wikidata
Addshore added a comment to T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same.

@ArielGlenn do I understand correctly however that this revision on wikidata.org is not an issue for dumps?

Aug 8 2019, 3:28 PM · Multi-Content-Revisions (Tech Debt), CPT Initiatives (MCR), wikidata-tech-focus, User-Addshore, Wikimedia-production-error, Wikidata-Campsite, Wikidata, Dumps-Generation

Aug 7 2019

Addshore added a comment to T218998: Track WDQS updater UA in wikidata-special-entitydata grafana dashboard.

Note: If T199219: WDQS should use internal endpoint to communicate to Wikidata gets done (which IMO, it should) we can't use hadoop to track UA. The WDQS itself should add stats when requesting our endpoint.

Aug 7 2019, 4:56 PM · Analytics, Wikidata-Campsite, WMDE-Analytics-Engineering, Wikidata

Jul 30 2019

Addshore added a comment to T228978: Unknown placeholder: entityViewPlaceholder-entitytermsview-entitytermsforlanguagelistview-class.

You could include the same logic checking shouldRenderTermbox and checking the current key / options for pcached content in the parsercacherejectvalur hook.
This would allow you to reject values where you want to use SSR and the caged Verizon doesn't already have an SSR term box, then re parsing and using a key with the new value.

Jul 30 2019, 1:55 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, Wikibase-Termbox-Iteration-20, Wikidata, Wikimedia-production-error, Wikidata-Campsite
Addshore added a comment to T228978: Unknown placeholder: entityViewPlaceholder-entitytermsview-entitytermsforlanguagelistview-class.

Indeed we are only talking about the mobile term box right now.
Looking at the 2 Gerrit changes I think something like #1 would be best (I haven't seen the hook in #2 used at all anywhere).
Although #1 could en changed to register a new parser option called wb-termbox for example, default value null, used in cache key and when termbox is rendered set it to 2.

Jul 30 2019, 3:04 AM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, Wikibase-Termbox-Iteration-20, Wikidata, Wikimedia-production-error, Wikidata-Campsite

Jul 29 2019

Addshore added a comment to T228978: Unknown placeholder: entityViewPlaceholder-entitytermsview-entitytermsforlanguagelistview-class.

It sounds like when old parser cache entries are encountered the old behaviour should continue to happen, and the new SSR service should not be called.
Otherwise turning on the feature will essentially purge / reject / ignore all previously cached pages, which is not a best situation.

Jul 29 2019, 5:58 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Patch-For-Review, Wikibase-Termbox-Iteration-20, Wikidata, Wikimedia-production-error, Wikidata-Campsite

Jul 27 2019

dlo awarded T147407: Need 'dbDirectory' or 'dbFilePath' parameter. on SQLITE a Love token.
Jul 27 2019, 6:35 PM · Core Platform Team, MW-1.28-release (WMF-deploy-2016-10-11_(1.28.0-wmf.22)), MW-1.28-release-notes, User-Addshore, Patch-For-Review, Wikimedia-Rdbms, Regression

Jul 25 2019

Pintoch awarded T205252: Reduce text returned by EntityContent::getTextForFilters a Like token.
Jul 25 2019, 2:50 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Technical-Debt, wikidata-tech-focus, Wikidata

Jul 22 2019

Addshore added a comment to T228439: Add WikibaseQualityConstraints extension to wikibase bundle docker image.

Fine with me!

Jul 22 2019, 8:51 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata, Wikibase-Containers

Jul 21 2019

Addshore added a comment to T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items.

So, unless access is needed via a media info caption, we do not need an index.
So if we just want lookup by media info id we can close T227847 and T227848.

Jul 21 2019, 8:28 PM · Structured-Data-Backlog (Current Work), Structured Data Engineering, Structured-Data-Team-Current-Work, Patch-For-Review, Wikidata, SDC General, Wikibase-Lua, MediaWiki-extensions-WikibaseClient
Addshore added a comment to T68025: [Story] Monitor size of some Wikidata database tables.

Switched to weekly in the latest PR and also fixed the missing ;.
If you give it a +1 I'll go ahead and get it running in the coming days.

Jul 21 2019, 8:18 PM · WMDE-Analytics-Engineering, DBA, Story, Wikidata, Wikidata.org
Addshore added a comment to T207893: Partial Blocks are enforced as Sitewide blocks in Wikibase entities.

@dbarratt @Niharika I added you both to the admin group on test wikidata

Jul 21 2019, 8:05 PM · MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), User-Noarave, Anti-Harassment (The Letter Song), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore added a comment to T359: Document the Wikidata API in the Developer Hub.

I like the changes. The page is much easier to follow now due to its shorter length, and also we no longer need to try and keep the same docs up to date in 2 places!

Jul 21 2019, 8:00 PM · Documentation, ECT-April-2015, ECT-March-2015, ECT-February-2015, Wikidata, Web-APIs-Hub
Addshore added a comment to T227847: Backfill terms index.

Also why captions even matter for T223792 - shouldn't getEntity look up by ID (which in case of MediaInfo is straight page id) not by caption?

Jul 21 2019, 7:56 PM · Structured Data Engineering, Multimedia, SDC General
Addshore added a project to T179663: What happens if the Wikibase project specifies a version of a library outside of the range included in mediawiki-vendor?: User-Addshore.
Jul 21 2019, 7:49 PM · User-Addshore, Release-Engineering-Team-TODO, Core Platform Team Legacy (Watching / External), Patch-For-Review, Wikidata
Addshore moved T227811: docker-compose wdqs-frontend generates unresolvable item links in results from incoming to consider for next sprint on the Wikidata board.
Jul 21 2019, 7:45 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
Addshore moved T227811: docker-compose wdqs-frontend generates unresolvable item links in results from Bugs to Features on the Wikibase-Containers board.
Jul 21 2019, 7:45 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
Addshore moved T227811: docker-compose wdqs-frontend generates unresolvable item links in results from Incoming to Ready to estimate on the Wikidata-Campsite board.
Jul 21 2019, 7:45 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
Addshore triaged T227811: docker-compose wdqs-frontend generates unresolvable item links in results as Normal priority.
Jul 21 2019, 7:44 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata
Addshore added a comment to T227811: docker-compose wdqs-frontend generates unresolvable item links in results.

Indeed, port 80 is hardcoded.

Jul 21 2019, 7:42 PM · Wikidata-Campsite, Wikibase-Containers, Wikidata

Jul 18 2019

Addshore added a comment to T227847: Backfill terms index.

If elastic already has captions indexed then yes this could probably just use elastic. (There would be slightly more delay and potential unpredictability using elastic than some mysql tables like wb_terms).

Jul 18 2019, 4:09 PM · Structured Data Engineering, Multimedia, SDC General
Addshore added a comment to T227758: [investigate] purging strategy.

Note to researcher.
The normal way of this happening would be via the dispatch system.
I imagine whoever does this research will need to look into that a fair bit! :)

Jul 18 2019, 4:04 PM · Wikidata, Wikidata-Bridge
Addshore added a comment to T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo.

I don't think wb_terms should be used at all for media info.
A custom system or new table or set of tables should be decided on, created, and populated.
Temporarily using wb_terms just to remove it would cause more trouble that it is worth and could just lead to it still existing in a few years and us having to do another massive migration.

Jul 18 2019, 4:02 PM · Multimedia, Wikidata, SDC General, Structured Data Engineering
Addshore added a comment to T227937: In grafana shows numbers of different entities in separate graphs.

Not sure what we would gain by adding a panel per entity type.

Jul 18 2019, 3:59 PM · Wikidata
Addshore moved T228299: ModifyEntity.php database error from Incoming to Needs Work on the Wikidata-Campsite board.
Jul 18 2019, 3:56 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
Addshore added a project to T228299: ModifyEntity.php database error: Wikidata-Campsite.
Jul 18 2019, 3:56 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
Addshore moved T228299: ModifyEntity.php database error from incoming to needs discussion or investigation on the Wikidata board.
Jul 18 2019, 3:56 PM · Wikidata-Campsite, Wikidata, Wikimedia-production-error
Addshore lowered the priority of T205192: Create a property link formatter that uses cache instead of wb_terms table from Normal to Low.

Not sure if this is done or not, the estimation should perhaps take that into account.

Jul 18 2019, 3:43 PM · Wikidata
Addshore moved T226216: Statement GUIDs should not appear in AbuseFilter text for Wikibase from Needs Work to Ready to estimate on the Wikidata-Campsite board.
Jul 18 2019, 3:37 PM · User-Ladsgroup, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Performance, Wikidata
Addshore renamed T224398: Configure 'grunt fix' task for eslint on Wikibase.git from Configure 'grunt fix' task for eslint on Wikibase to Configure 'grunt fix' task for eslint on Wikibase.git.
Jul 18 2019, 3:36 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first bug, Developer Productivity, Wikidata
Addshore triaged T224398: Configure 'grunt fix' task for eslint on Wikibase.git as Low priority.
Jul 18 2019, 3:35 PM · MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first bug, Developer Productivity, Wikidata
Addshore renamed T197587: [Story] Add WikibaseQualityConstraints to the docker image & configure? from Add WikibaseQualityConstraints to the docker image to [Story] Add WikibaseQualityConstraints to the docker image & configure?.
Jul 18 2019, 3:34 PM · Wikidata-Campsite, Wikibase-Quality, Wikibase-Quality-Constraints, Wikidata, Wikibase-Containers
Addshore triaged T228439: Add WikibaseQualityConstraints extension to wikibase bundle docker image as Low priority.
Jul 18 2019, 3:34 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata, Wikibase-Containers
Addshore moved T228439: Add WikibaseQualityConstraints extension to wikibase bundle docker image from Incoming to Ready to estimate on the Wikidata-Campsite board.
Jul 18 2019, 3:33 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata, Wikibase-Containers
Addshore updated the task description for T228439: Add WikibaseQualityConstraints extension to wikibase bundle docker image.
Jul 18 2019, 3:33 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata, Wikibase-Containers
Addshore created T228439: Add WikibaseQualityConstraints extension to wikibase bundle docker image.
Jul 18 2019, 3:32 PM · Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata, Wikibase-Containers