Page MenuHomePhabricator

Addshore (Adam_WMDE)
Community & WMDE Developer (Wikidata Tech Lead 🐢)

Projects (50)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:43 PM (241 w, 2 d)
Availability
Away Away until May 31.
IRC Nick
Addshore
LDAP User
Addshore
MediaWiki User
Addshore [ Global Accounts ]

Recent Activity

Tue, May 21

Esc3300 awarded T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text a Dislike token.
Tue, May 21, 1:11 PM · Wikidata-Campsite, Patch-For-Review, Wikidata

Wed, May 15

Addshore updated the task description for T220826: Wikibase Special:EntityData has 2 parameters that do the same thing.
Wed, May 15, 5:13 PM · Wikidata-Campsite, wikidata-tech-focus, Wikidata
Addshore added a comment to T220826: Wikibase Special:EntityData has 2 parameters that do the same thing.

Looking at the query in P8524, do I interpret it right that oldid use is only counted when the revision parameter is not used? Do we care about cases when both revision and oldid are part of the input?

Wed, May 15, 5:12 PM · Wikidata-Campsite, wikidata-tech-focus, Wikidata
Addshore added a comment to T223310: Investigate increase in tx bandwidth usage for mc1033.

For things added my wmf.3, it looks like there were indeed some chronology protector changes https://github.com/wikimedia/mediawiki/compare/wmf/1.34.0-wmf.1...wmf/1.34.0-wmf.3

Wed, May 15, 4:59 PM · Patch-For-Review, Growth-Team, Wikidata, Wikidata-Campsite, Performance-Team, User-jijiki, serviceops, Operations
Addshore added a comment to T223087: SWAT Shepherds seem wrong.

My name will be back on the list once I am fully back from vacation

Wed, May 15, 4:53 PM · Release-Engineering-Team (Kanban), User-zeljkofilipin, MediaWiki-SWAT-deployments
Addshore created P8531 (An Untitled Masterwork).
Wed, May 15, 4:45 PM

Tue, May 14

Addshore placed T192792: Document wikibase configuration options pertaining to wikibase-docker up for grabs.
Tue, May 14, 11:27 PM · Federated-Wikibase-Workshops@Antwerp-2018, Wikibase-Containers, Wikidata, User-Addshore
Addshore closed T215870: Docker-compose failing at installation - ES patches need backporting & new image building as Resolved.

Going to mark this as resolved now

Tue, May 14, 11:21 PM · User-Addshore, Wikidata-Campsite, Wikidata, Wikibase-Containers
Addshore moved T222509: building of wikibase 1.31 fails in Docker due to newer ca-certificates package from Backlog to Doing on the Wikibase-Containers board.
Tue, May 14, 11:20 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Containers, Wikidata
Addshore added a comment to T221504: investigate why content history dump of certain wikidata page ranges is so slow.

Isn't there some way to be more concise in these entries? So far there's only around 250 of them, but each one of them is over 1GB of data for all of its revisions, *compressed*. We kind of expect articles to take their time to get huge...

Tue, May 14, 11:19 PM · Wikidata, Dumps-Generation
Addshore awarded T222788: Request to be added to the ldap/wmde group a Like token.
Tue, May 14, 9:10 PM · WMF-Legal, LDAP-Access-Requests, Operations, WMF-NDA-Requests
Addshore added a comment to T222509: building of wikibase 1.31 fails in Docker due to newer ca-certificates package.

In most situations you will just want to pull the image from Docker hub rather than building it yourself too.
Unless you want to make modifications to the build.

Tue, May 14, 8:59 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Containers, Wikidata
Addshore moved T223106: Token missing from Incoming to In Progress on the Addwiki board.
Tue, May 14, 8:44 PM · Addwiki
Addshore added a comment to T220798: Decide how and where to configure Wikidata/Wikibase monolingual text languages.

I guess a way forward for now would be to introduce the extra configuration option, and then next time we want to add a new language code for monolingual text, we can think whether it belongs in the hard-coded list or in the new config variable…?

Tue, May 14, 8:34 PM · MediaWiki-Configuration, I18n, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore added a comment to T215380: Content too big! Entity: Q27972199.

Looks like this has now not happened since March 1st

Tue, May 14, 8:24 PM · User-Noarave, Performance, Wikidata-Campsite, Wikidata, Wikimedia-production-error
Addshore added a comment to T218081: Log failed node -> mediawiki requests.

Maybe use a log channel like Wikibase.TermboxSSR. c.f. Wikibase.NewItemIdFormatter extensions/Wikibase/repo/WikibaseRepo.datatypes.php:383

Tue, May 14, 8:12 PM · Wikidata-Termbox-Iteration-16, Wikidata
Addshore added a comment to T222497: dumpRDF for MediaInfo entities loads each page individually.

Some batching could be added to RdfDumpGenerator::preBatchDump rather than just doing the array_map there with Title::getTitleForId.

Tue, May 14, 6:08 PM · WikibaseMediaInfo, Wikidata-Query-Service, SDC General, Commons, Wikidata
Addshore updated the task description for T220826: Wikibase Special:EntityData has 2 parameters that do the same thing.
Tue, May 14, 5:30 PM · Wikidata-Campsite, wikidata-tech-focus, Wikidata
Addshore created P8524 (An Untitled Masterwork).
Tue, May 14, 5:29 PM
Addshore added a comment to T220826: Wikibase Special:EntityData has 2 parameters that do the same thing.

I took a look at the usage on a current day:

Tue, May 14, 5:29 PM · Wikidata-Campsite, wikidata-tech-focus, Wikidata
Addshore added a comment to T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern.

That all looks fine.
I added a new panel to https://grafana.wikimedia.org/d/000000574/t204083-investigation?orgId=1 showing the stats for WANObjectCache and these keys.

Tue, May 14, 5:12 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore updated subscribers of T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern.
Tue, May 14, 3:42 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore added a comment to T217897: Reduce / remove the aggessive cache busting behaviour of wdqs-updater.

So, I did some really crappy analysis of the hit rate in varnish before and after this change, looking at the 5th of april and the 5th of may (one before and one after as far as I can tell).

Tue, May 14, 12:41 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-Smalyshev, Wikidata, Wikidata-Query-Service, Traffic, Operations

Mon, May 13

Addshore added a comment to T217329: bug in 1.33.0-wmf.18 breaks abstract dumps on testwikidatawiki | MWContentSerializationException $entityId and $targetId can not be the same.

As this is just test wiki (and not a real wiki), and that this can no longer occur, perhaps we should just totally nuke the page from the db

Mon, May 13, 11:52 PM · Core Platform Team Backlog (Watching / External), Multi-Content-Revisions, Core Platform Team (MCR), wikidata-tech-focus, User-Addshore, Wikimedia-production-error, Wikidata-Campsite, Wikidata, Dumps-Generation
Addshore moved T222509: building of wikibase 1.31 fails in Docker due to newer ca-certificates package from Incoming to Ready to go on the Wikidata-Campsite board.
Mon, May 13, 11:44 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Containers, Wikidata
Addshore added a project to T222509: building of wikibase 1.31 fails in Docker due to newer ca-certificates package: Wikidata-Campsite.
Mon, May 13, 11:44 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikibase-Containers, Wikidata
Addshore closed T221752: Cognate data is not restored (any more) on page undeletion as Resolved.

Looking at the patch that was merged, I think we can close this, as it indeed looks like it was just a test issue.

Mon, May 13, 11:33 PM · User-Addshore, MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Wikidata-Campsite, Core Platform Team, Wikidata, Cognate
Addshore added a project to T222321: Make /entity/ alias work for Commons: Wikimedia-Apache-configuration.

For wikidata this is done in

Mon, May 13, 11:24 PM · Wikimedia-Apache-configuration, User-Smalyshev, WikibaseMediaInfo, Wikidata-Query-Service, SDC General, Commons, Wikidata
Addshore added a comment to T222306: RDF export generates wrong IDs for federated entities.

Quickly looking over this ticket:

Mon, May 13, 11:17 PM · User-Smalyshev, WikibaseMediaInfo, Wikidata-Query-Service, SDC General, Commons, Wikidata
Addshore added a comment to T217709: The external client site ". . ." did not provide page information for page ". . .".

When you changed from http to https did you change anything in the sites table of the wikibase?
Is there a redirect in place?

Mon, May 13, 11:01 PM · Wikidata, Wikibase-Containers
Addshore added a comment to T221407: Unrecognized subject messages in Updater.

All of the options seem like they would work, looks like 1 was the easiest and it seems you've already done it?

Mon, May 13, 10:56 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, Discovery-Wikidata-Query-Service-Sprint, Wikidata-Query-Service, Wikidata
Addshore added a comment to T220823: Use ElasticSearch for bulk Wikidata entity term lookup.

pinging @Fjalapeno from your comments the other day I understand Wikidata is going to use cassandra for these use cases at the end? cc @Addshore

Mon, May 13, 10:47 PM · Discovery-Search, User-Addshore, wikidata-tech-focus, Wikidata
Addshore added a comment to T125050: [Task] Add Scribunto to extension-gate in CI.

Sounds okay to me!

Mon, May 13, 10:14 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Patch-For-Review, Continuous-Integration-Config, MediaWiki-extensions-Scribunto, Wikidata
Ladsgroup awarded T87781: Split mediawiki tests into unit and integration tests a Yellow Medal token.
Mon, May 13, 10:13 PM · Patch-For-Review, User-kostajh, Wikimedia-Hackathon-2019, Code-Health-Metrics, Epic, MediaWiki-Core-Testing
Addshore moved T207749: Improve code examples of the Wikidata Query UI from in progress to ready to go on the Wikidata board.

Partly done, but not actively being worked on, so moved back to ready to go from doing

Mon, May 13, 10:12 PM · Patch-For-Review, Google-Code-in-2018, patch-welcome, Wikidata, Wikidata Query UI
Addshore added a comment to T88258: Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration.

That sounds like a great idea :)

Mon, May 13, 10:10 PM · Story, Technical-Debt, wikidata-tech-focus, Wikidata-Campsite, Wikidata-Turtles-Tech-Debt, Wikidata-Ministry-Of-Magic-Tech-Debt, Wikidata-Sprint-2017-12-20, Wikidata-Sprint-2015-08-11, Wikidata-Sprint-2015-06-30, Wikidata-Sprint-2015-06-16, Wikidata-Sprint-2015-06-02, MediaWiki-extensions-WikibaseRepository, Wikidata, MediaWiki-extensions-WikibaseClient
Addshore renamed T221213: Create 1.33 release of wikibase docker image from Create 1.33 release to Create 1.33 release of wikibase docker image.
Mon, May 13, 10:04 PM · Wikidata, Wikibase-Containers
Addshore added a comment to T221215: Change mediawiki container default password.

Exact duplicate of T221214 @Tarrow ?

Mon, May 13, 10:04 PM · Wikidata, Wikibase-Containers
Addshore awarded T220967: Support Lexeme in Addwiki a Like token.
Mon, May 13, 10:00 PM · Addwiki
Addshore added a comment to T197667: Parsoid/Restbase for VisualEditor in container for use with wikibase-docker / wikibase-containers.

I removed "development" from the title as the images we are talking about here are not intended for development use.

Mon, May 13, 9:46 PM · Wikibase-Containers, Wikidata
Addshore renamed T197667: Parsoid/Restbase for VisualEditor in container for use with wikibase-docker / wikibase-containers from Parsoid/Restbase in Wikibase development containers for VisualEditor to Parsoid/Restbase for VisualEditor in container for use with wikibase-docker / wikibase-containers.
Mon, May 13, 9:46 PM · Wikibase-Containers, Wikidata
Addshore added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

For "Iteration 1 Acceptance Criteria" rather than specifically counting, I think logging these would be enough, then we can count these in logstash.

Mon, May 13, 9:08 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore awarded T220696: Create better edit summaries for wbeditentity API endpoint a Like token.
Mon, May 13, 8:53 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Addshore added a comment to T221602: [Problem] Discontinued support of a language breaks edits in Terms.

I'm not clear that this is necessary. If we remove the "dead languages" at the time of discontinuing them then it shouldn't be something we need to ignore. If people are trying to make edits that include now-defunct languages I think it might be better that we error and let them know rather than silently ignoring them and leaving them to wonder why the edit they asked for wasn't made; I think this would only happen in the end someone was trying to edit with outdated-data or old code that needs updating.

Mon, May 13, 8:35 PM · Wikidata, Wikidata-Campsite
Addshore awarded T203337: Fix wbeditentity API ignoring setting aliases to an empty set a Like token.
Mon, May 13, 8:22 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-WikibaseRepository
Addshore added a comment to T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern.

I just flicked back to https://grafana.wikimedia.org/d/000000574/t204083-investigation today and noticed that as of 1.34.wmf.3 a pattern similar to what we were seeing before is back?
https://tools.wmflabs.org/sal/log/AWp6A7RAEHTBTPG-zSOo

Mon, May 13, 8:09 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore added a comment to T221928: [Refactoring] Use PSR-6 interfaces in caching services again.

I don't think we will be able to expose the bits of WANCache that we need in some places through an interface such as PSR6 or bagostuff.
For the places where we do need such complex set get delete purge etc logic for caching for a multi DC situation we will have to write the code to use the WANCache interface, or something like it.
As we already have to write that logic, I'm not sure I see the value in then also allowing either a regular bagostuff or psr6 thing here.
At the end of the day one can create a WANObjectCache instance that just contains a single bagostuff as far as I know, rather than having code in wikibase do different types of caching based on the interface passed in.

Mon, May 13, 8:06 PM · Wikidata, Wikidata-Campsite
Addshore added a comment to T93142: [Task] Look into Wikibase use of memcached to see what needs broadcasted purges.

CacheAwarePropertyInfoStore is solved with T218197

Mon, May 13, 7:59 PM · Performance, Wikidata

Sun, May 12

Addshore added a comment to T220798: Decide how and where to configure Wikidata/Wikibase monolingual text languages.

I month on, is there a decision then? or? :)

Sun, May 12, 9:37 PM · MediaWiki-Configuration, I18n, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore added a comment to T220480: Migration Plan 3.

My only thought when reading this is that when we get onto point 3 for items, data in wb_terms will remain and slowly become out of date? (unless there are some deletes happening during these writes?)

Sun, May 12, 9:31 PM · Wikidata, User-Ladsgroup, Wikidata wb_terms Trailblazing

Apr 12 2019

Addshore added a comment to T220823: Use ElasticSearch for bulk Wikidata entity term lookup.

A couple of comments from IRC so we don't forget them in the coming months:

Apr 12 2019, 2:27 PM · Discovery-Search, User-Addshore, wikidata-tech-focus, Wikidata
Addshore triaged T220826: Wikibase Special:EntityData has 2 parameters that do the same thing as Low priority.
Apr 12 2019, 2:04 PM · Wikidata-Campsite, wikidata-tech-focus, Wikidata
Addshore created T220826: Wikibase Special:EntityData has 2 parameters that do the same thing.
Apr 12 2019, 2:04 PM · Wikidata-Campsite, wikidata-tech-focus, Wikidata
Addshore updated subscribers of T220823: Use ElasticSearch for bulk Wikidata entity term lookup.
Apr 12 2019, 1:55 PM · Discovery-Search, User-Addshore, wikidata-tech-focus, Wikidata
Addshore created T220823: Use ElasticSearch for bulk Wikidata entity term lookup.
Apr 12 2019, 1:51 PM · Discovery-Search, User-Addshore, wikidata-tech-focus, Wikidata
Addshore added a comment to T155359: wikiba.se should use HTTPS.

I guess we need to update operations/dns then?

Apr 12 2019, 1:04 PM · User-Addshore, wikiba.se website, Wikidata
Addshore added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

I had a quick look around and found a few examples of legitimate aliases or labels with |s in:

Apr 12 2019, 12:34 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore added a comment to T220150: [Story] Clean up unused records.

My final thought here before heading to vacation is, when terms are removed from an entity, we already know what terms therefor might need to be removed from the other tables, so we should probably use that information rather than have some secondary process cycle through the millions of terms trying to find what to remove.

Apr 12 2019, 12:16 PM · Wikidata, Wikidata wb_terms Trailblazing
Addshore updated subscribers of T155359: wikiba.se should use HTTPS.

Ping @MasinAlDujailiWMDE ? :)

Apr 12 2019, 12:03 PM · User-Addshore, wikiba.se website, Wikidata
Addshore added a comment to T220798: Decide how and where to configure Wikidata/Wikibase monolingual text languages.

It sounds like we shouldn't really be removing things from WikibaseContentLanguages::getDefaultMonolingualTextLanguages().
For wikidata.org we should have some configuration which can add language codes to that list.
If we want them to be available for all wikibases then of course they should be added to the main list.

Apr 12 2019, 12:01 PM · MediaWiki-Configuration, I18n, MediaWiki-extensions-WikibaseRepository, Wikidata

Apr 11 2019

thiemowmde awarded T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text a Dislike token.
Apr 11 2019, 5:32 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore added a comment to T220150: [Story] Clean up unused records.

I have no idea how these queries would perform, but they are scary and I don't think we should be running them on the production master DB.
If cleanup is wanted from some sort of maintenance script it should probably use batches of deletes and or selects.

Apr 11 2019, 12:31 PM · Wikidata, Wikidata wb_terms Trailblazing
Addshore added a comment to T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.

Are we really sure disallowing aliases with |s in is the right path forward?
What are we going to do with the 56k aliases that currently have pipes in them? (Note this is 56k alias strings, not 56k items (it will be more items I expect).

Apr 11 2019, 12:21 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore closed T220682: Security Review For wikibase-term-store as Invalid.

After I had a look at the code I don't think this one needs a security review.
So i went ahead and merged the patch merging it into mediawiki-vendor.

Apr 11 2019, 10:12 AM · Security-Team-Reviews
Addshore added a project to T189333: Changing Kibana filters is ridiculously slow: Wikidata-Campsite.
Apr 11 2019, 8:50 AM · Wikidata-Campsite, User-Addshore, wikidata-tech-focus, Wikidata, Wikimedia-Logstash

Apr 9 2019

Addshore added a comment to T220150: [Story] Clean up unused records.

I'm slightly confused with the description 2 comments up.

Apr 9 2019, 7:37 PM · Wikidata, Wikidata wb_terms Trailblazing
Addshore added a comment to T92961: [Story] Versioning in JSON output.

This will likely get worked on, at least for Api output with the work on federation that should happen toward the end of this year.

Apr 9 2019, 10:00 AM · Story, Wikidata, MediaWiki-extensions-WikibaseRepository
Addshore added a comment to T183553: Travis CI fails on HHVM and addwiki/wikibase-api.

I'm pretty sure no current users of the thing use hhvm

Apr 9 2019, 9:52 AM · User-Addshore, Addwiki
Addshore closed T218122: Cache property info with one key per property, a subtask of T218115: [Story] Implement per property caching for CacheAwarePropertyInfoStore, as Resolved.
Apr 9 2019, 9:35 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Performance-Team (Radar), Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore closed T218122: Cache property info with one key per property as Resolved.
Apr 9 2019, 9:35 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞)
Addshore closed T218115: [Story] Implement per property caching for CacheAwarePropertyInfoStore, a subtask of T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern, as Resolved.
Apr 9 2019, 9:34 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore closed T218115: [Story] Implement per property caching for CacheAwarePropertyInfoStore as Resolved.
Apr 9 2019, 9:34 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Performance-Team (Radar), Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore closed T218124: Read from key-per-property cache as Resolved.
Apr 9 2019, 9:33 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Performance-Team (Radar), Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore closed T218124: Read from key-per-property cache, a subtask of T218115: [Story] Implement per property caching for CacheAwarePropertyInfoStore, as Resolved.
Apr 9 2019, 9:33 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, Performance-Team (Radar), Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore closed T218197: CacheAwarePropertyInfoStore & CachingPropertyInfoLookup should use WANObjectCache instead of BagOStuff as Resolved.
Apr 9 2019, 9:32 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Addshore closed T218197: CacheAwarePropertyInfoStore & CachingPropertyInfoLookup should use WANObjectCache instead of BagOStuff, a subtask of T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern, as Resolved.
Apr 9 2019, 9:32 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore closed T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern as Resolved.

Amazing, I think we can resolve this then!

Apr 9 2019, 9:31 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata

Apr 8 2019

Addshore created P8373 ElasticSearch terms lookup queries.
Apr 8 2019, 11:03 PM

Apr 5 2019

Mill <mill@mail.com> committed rEWLE6b3a5bc74bb5: 1nbaaaaaaaaaaa (authored by Addshore).
1nbaaaaaaaaaaa
Apr 5 2019, 10:42 PM
Addshore added a comment to T97368: Fix inefficient CacheAwarePropertyInfoStore memcached access pattern.

We should see changes in 1.33.0-wmf.24.
It looks like the train didn't make it past group0 this week, so no change really spotted yet.

Apr 5 2019, 10:08 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Elukey, Wikidata-Campsite, MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), User-Addshore, Performance-Team (Radar), Patch-For-Review, Wikimedia-Incident, Operations, wikidata-tech-focus, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository, Wikidata
Addshore added a comment to T218197: CacheAwarePropertyInfoStore & CachingPropertyInfoLookup should use WANObjectCache instead of BagOStuff.

It looks like the train didn't make it past group0 this week, so no change really spotted yet.

Apr 5 2019, 10:08 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata

Apr 4 2019

Addshore added a comment to T220150: [Story] Clean up unused records.

As pointed out at some point we probably want to remove the strings from the table fairly sharpish, as content my be removed, revdeled, and should not continue to appear in public places such as labs dB replicas. So that rules out maintenance scripts run periodically .

Apr 4 2019, 8:56 PM · Wikidata, Wikidata wb_terms Trailblazing
Addshore added a comment to T220084: analytics-wmde group addition for Lucas Werkmeister.

I believe analytics-wmde is enough (as it gives you sudo on the analytics wmde users, but should be double checked if one can actually SSH into the machines with this.

Apr 4 2019, 10:45 AM · Patch-For-Review, Operations, SRE-Access-Requests
Addshore awarded T220084: analytics-wmde group addition for Lucas Werkmeister a Like token.
Apr 4 2019, 10:45 AM · Patch-For-Review, Operations, SRE-Access-Requests

Mar 29 2019

Addshore added a comment to T217897: Reduce / remove the aggessive cache busting behaviour of wdqs-updater.

WDQS does know what the latest version of the entity that it is trying to get updates for is,

But "last version that WDQS knows of" can be very different from "last version that Wikidata has". That's the whole issue.

I had an idea recently though. Maybe we could work it in two modes - if the stream is lagged sufficiently, we use the "latest available" mode - to jump to the front, but if we're more or less current, the probability of our change being current is high, so we could use "by revision ID" mode. Need to look at edit timings to see if it's workable but may be splitting two cases - catching up from large lag and keeping current - would be more efficient and allows us to use cache for the most frequent case (which is "keeping current"). That would be easy to implement and test - just a couple of if's in proper places.

Mar 29 2019, 8:35 AM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-Smalyshev, Wikidata, Wikidata-Query-Service, Traffic, Operations

Mar 28 2019

Addshore moved T219539: Browsing to Special:Search is broken on wmf.23, redirects to Special:Search&ns0=1 not Special:Search?ns0=1 from Unsorted 💣 to Active 🚁 on the User-Addshore board.
Mar 28 2019, 5:55 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Addshore, TCB-Team, Advanced-Search, Discovery-Search, MediaWiki-Search, Discovery
Addshore claimed T219539: Browsing to Special:Search is broken on wmf.23, redirects to Special:Search&ns0=1 not Special:Search?ns0=1.
Mar 28 2019, 5:44 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, User-Addshore, TCB-Team, Advanced-Search, Discovery-Search, MediaWiki-Search, Discovery
Addshore added a comment to T217897: Reduce / remove the aggessive cache busting behaviour of wdqs-updater.

the cache we are talking about there would be unnecessary if the wdqs just hit varnish.

It is problematic for WDQS to "just hit varnish", because varnish does not know if certain revision is the latest one available or not. Wikidata on the other hand does.

Mar 28 2019, 5:23 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), User-Smalyshev, Wikidata, Wikidata-Query-Service, Traffic, Operations
Addshore triaged T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text as Normal priority.
Mar 28 2019, 1:34 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore added a comment to T216987: Allow editing of fields.

So, the mock suggests that "|" will be used for inputting multiple aliases.
Currently in the wikidata UI one can enter aliases with |s in them
Example: https://test.wikidata.org/w/index.php?title=Q214&diff=489761&oldid=2181
The special page is actually destructive here and loading the page for the entity and clicking save results in loosing data: https://test.wikidata.org/w/index.php?title=Q214&diff=489762&oldid=489761
I filed a task for that @ T219499

Mar 28 2019, 1:32 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), Patch-For-Review, Wikidata-Termbox-Iteration-13, Wikidata-Termbox-Iteration-12 ✓, Wikidata-Termbox-Iteration-11
Addshore updated the task description for T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.
Mar 28 2019, 1:31 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore created T219499: [Problem] `Special:SetAliases`, `Special:NewItem` and `Special:NewProperty` separates aliases with | character but have no way to make a | part of one alias' text.
Mar 28 2019, 1:31 PM · Wikidata-Campsite, Patch-For-Review, Wikidata
Addshore added a comment to T219438: Add Windows installation Documentation and Install Script for local-charts repo.

Note that you can get a 90 days Windows VM directly from Microsoft: https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/ They provide a VirtualBox image.

Those images are intended to provided web browser to web developers so they can verify websites work as expected on IE / Edge. So it is a narrow focus, but maybe the VM ship enough material to actually replay the install of local charts.

The machines expires after 90 days.

Mar 28 2019, 1:23 PM · Release-Engineering-Team (Backlog), Developer Productivity
Addshore added a comment to T219450: "wikitext" content is not allowed on page … in slot "Main".

presumably the federation which we now disabled was used for something (“depicts” statements, right?), so the Structured Data on Commons team might need to communicate that it’s currently unavailable

Mar 28 2019, 1:01 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Wikimedia-production-error, Wikimedia-Incident, MediaWiki-Page-editing, Wikidata, StructuredDataOnCommons, Commons
Addshore updated subscribers of T219450: "wikitext" content is not allowed on page … in slot "Main".
Mar 28 2019, 12:54 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Wikimedia-production-error, Wikimedia-Incident, MediaWiki-Page-editing, Wikidata, StructuredDataOnCommons, Commons
Addshore added a comment to T219450: "wikitext" content is not allowed on page … in slot "Main".

Reproducible on testcommons

Mar 28 2019, 12:53 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Wikimedia-production-error, Wikimedia-Incident, MediaWiki-Page-editing, Wikidata, StructuredDataOnCommons, Commons
Addshore added a hashtag to Wikidata-Termbox-Iteration-12 ✓: #wikidata-termbox-iteration-12.
Mar 28 2019, 12:40 PM
Addshore set the color for Wikidata-Termbox-Iteration-12-OLD to Red.
Mar 28 2019, 12:40 PM
Addshore renamed Wikidata-Termbox-Iteration-12-OLD from Wikidata-Termbox-Iteration-12 to Wikidata-Termbox-Iteration-12-OLD.
Mar 28 2019, 12:39 PM
Addshore updated the task description for T200432: Labels/aliases/descriptions in Toki Pona need to be removed.
Mar 28 2019, 12:35 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), wikidata-tech-focus, Wikidata.org, Wikidata