Page MenuHomePhabricator

Addshore
Community Developer

Projects (47)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 9:43 PM (450 w, 5 d)
Availability
Busy Busy until Jul 1.
IRC Nick
Addshore
LDAP User
Addshore
MediaWiki User
Addshore [ Global Accounts ]

Recent Activity

Thu, May 25

Addshore committed rEFILEEXPORT61cb02946b99: Initial Commit (authored by Addshore).
Initial Commit
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORTc59d6c63abd0: Rename extension to FileExporter (authored by Addshore).
Rename extension to FileExporter
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORT0178f5e34ef8: Add COPYING file (authored by Addshore).
Add COPYING file
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORT914480cb9000: Add basic README file (authored by Addshore).
Add basic README file
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORTb8b473232481: TAB indents in .json files (authored by Addshore).
TAB indents in .json files
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORTaa96e36833fc: TAB indent composer.json file (authored by Addshore).
TAB indent composer.json file
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORTd9e5b4fc187d: Only show move-link for autoconfirmed users (authored by Addshore).
Only show move-link for autoconfirmed users
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORT9ed68845fa39: Open a new tab when users click on link (authored by Addshore).
Open a new tab when users click on link
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORT0f5a604385f9: Add config doc in extension.json (authored by Addshore).
Add config doc in extension.json
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORT9e341caea90c: Actually pass the current URL (authored by Addshore).
Actually pass the current URL
Thu, May 25, 6:52 PM
Addshore committed rEFILEEXPORTf019db26c8e8: Only show link for local files (authored by Addshore).
Only show link for local files
Thu, May 25, 6:52 PM
Addshore committed rEPS644acfc38f85: Specify 'wikibase items' in propertysuggester-desc (authored by Addshore).
Specify 'wikibase items' in propertysuggester-desc
Thu, May 25, 6:47 PM
Addshore committed rEPSfdc388552aa2: Merge pull request #128 from Wikidata-lib/travis (authored by Addshore).
Merge pull request #128 from Wikidata-lib/travis
Thu, May 25, 6:47 PM
Addshore committed rEPS607d2c3bac9d: Merge pull request #127 from Wikidata-lib/terms (authored by Addshore).
Merge pull request #127 from Wikidata-lib/terms
Thu, May 25, 6:47 PM
Addshore committed rEPS43711952437a: Remove usage of TermIndex::getMatchingIDs (authored by Addshore).
Remove usage of TermIndex::getMatchingIDs
Thu, May 25, 6:47 PM
Addshore committed rEPS99ba23b2e350: Bump to 2.3.0 + Add release notes (authored by Addshore).
Bump to 2.3.0 + Add release notes
Thu, May 25, 6:47 PM
Addshore committed rEPSfe107c6675f5: Rel 2.3.1 (authored by Addshore).
Rel 2.3.1
Thu, May 25, 6:47 PM
Addshore committed rEPS65c49fe44911: General Cleanup (authored by Addshore).
General Cleanup
Thu, May 25, 6:47 PM
Addshore committed rEPS447b8ded70d8: Fix WikibaseApiTestCase namespace (authored by Addshore).
Fix WikibaseApiTestCase namespace
Thu, May 25, 6:47 PM
Addshore committed rEPSacfd7b9ff9cf: Merge pull request #135 from Wikidata-lib/cleanup (authored by Addshore).
Merge pull request #135 from Wikidata-lib/cleanup
Thu, May 25, 6:47 PM
Addshore committed rEPS4a40e376bc26: Bump version number to 2.4.0 (authored by Addshore).
Bump version number to 2.4.0
Thu, May 25, 6:47 PM
Addshore committed rEPSe67eb143e4a7: Merge pull request #139 from thiemowmde/mocks (authored by Addshore).
Merge pull request #139 from thiemowmde/mocks
Thu, May 25, 6:47 PM
Addshore committed rEPSe8129fac0d28: Update release notes for 2.4.0 (authored by Addshore).
Update release notes for 2.4.0
Thu, May 25, 6:47 PM
Addshore committed rEPS10c283e431e6: Use EntityLookup from DataModelServices (authored by Addshore).
Use EntityLookup from DataModelServices
Thu, May 25, 6:47 PM
Addshore committed rEPS9e542048ff67: Merge pull request #138 from Wikidata-lib/i18n (authored by Addshore).
Merge pull request #138 from Wikidata-lib/i18n
Thu, May 25, 6:47 PM
Addshore committed rEPS439f407bf81c: Add missing api param desc for 'search' (authored by Addshore).
Add missing api param desc for 'search'
Thu, May 25, 6:47 PM
Addshore committed rEPS96ce1483661b: Merge pull request #142 from Wikidata-lib/dm (authored by Addshore).
Merge pull request #142 from Wikidata-lib/dm
Thu, May 25, 6:47 PM
Addshore committed rEPSf8641a6eee41: Merge pull request #141 from thiemowmde/aliases (authored by Addshore).
Merge pull request #141 from thiemowmde/aliases
Thu, May 25, 6:47 PM
Addshore committed rEPSfa1495e9784f: Merge pull request #144 from Wikidata-lib/data-model-services-2.0 (authored by Addshore).
Merge pull request #144 from Wikidata-lib/data-model-services-2.0
Thu, May 25, 6:47 PM
Addshore committed rEPS044bbca7f624: Merge pull request #148 from Wikidata-lib/datamodelservices (authored by Addshore).
Merge pull request #148 from Wikidata-lib/datamodelservices
Thu, May 25, 6:47 PM
Addshore committed rEPS18f8fabdf03c: Merge pull request #149 from Wikidata-lib/rel-2.4.3 (authored by Addshore).
Merge pull request #149 from Wikidata-lib/rel-2.4.3
Thu, May 25, 6:47 PM
Addshore committed rEPS2e6838a103ba: Merge pull request #151 from siebrand/i18n (authored by Addshore).
Merge pull request #151 from siebrand/i18n
Thu, May 25, 6:47 PM
Addshore committed rEPSe991635f0c63: Fix apihelp-wbsgetsuggestions-example-4 (authored by Addshore).
Fix apihelp-wbsgetsuggestions-example-4
Thu, May 25, 6:46 PM
Addshore committed rEPSc4e25abb5963: Use Database instead of DatabaseBase (authored by Addshore).
Use Database instead of DatabaseBase
Thu, May 25, 6:46 PM
Addshore committed rEPS7c11bc884a6b: Add temporary workaround to be able to make Wikibase PSR-4 compatible (#186) (authored by thiemowmde).
Add temporary workaround to be able to make Wikibase PSR-4 compatible (#186)
Thu, May 25, 6:46 PM
Addshore committed rEPS3e7e5075a8c7: Remove misplaced @group WikibaseRepo (#188) (authored by thiemowmde).
Remove misplaced @group WikibaseRepo (#188)
Thu, May 25, 6:46 PM
Addshore committed rEPS5b9f0374d98b: Add \ to start of namespaced @covers tags (authored by Addshore).
Add \ to start of namespaced @covers tags
Thu, May 25, 6:45 PM

Tue, May 2

Addshore updated Addshore.
Tue, May 2, 2:31 PM

Sun, Apr 30

Addshore moved T334362: mw docker mediawiki create fails from Inbox to Priority Backlog on the mwcli board.
Sun, Apr 30, 4:38 PM · mwcli

Apr 19 2023

Addshore created P47263 (An Untitled Masterwork).
Apr 19 2023, 9:57 PM

Apr 18 2023

Addshore awarded T327428: Investigate ways to reduce the resources consumed by ES a Party Time token.
Apr 18 2023, 11:01 PM · Wikibase.cloud, Patch-For-Review
Addshore added a comment to T334912: Investigate "no text in this page" errors.

Greping code I assume this is coming from https://github.com/wikimedia/mediawiki/blob/REL1_39/includes/page/Article.php#L361

Apr 18 2023, 9:39 PM · Wikibase.cloud (WB Cloud Sprint 18)

Apr 16 2023

Addshore added a comment to T334362: mw docker mediawiki create fails.

What is the contents of the .env file in /home/lectrician1/.config/mwcli/mwdd/default/?

Apr 16 2023, 6:24 PM · mwcli
Addshore added a comment to T334362: mw docker mediawiki create fails.

What is the contents of the .env file in /home/lectrician1/.config/mwcli/mwdd/default/?

Apr 16 2023, 6:22 PM · mwcli

Apr 10 2023

Addshore added a comment to T334362: mw docker mediawiki create fails.

Can you run mw -v=2 docker mediawiki create to see what the additional output is please?

Apr 10 2023, 3:13 PM · mwcli

Apr 5 2023

Addshore added a comment to T333095: Integration of Wikibase Local Media.

Use case(s): There is currently no possibility to display images and other media in a Wikibase.cloud-instance. The only option is to show a link, but not the media.
The integration of the Local Media extension would change that.

Apr 5 2023, 5:59 PM · Wikibase.cloud
Addshore added a comment to T325894: Investigate missing Admin Users on Wiki Creation.

The failed jobs DB table should reveal the reason for the failures.

Apr 5 2023, 5:56 PM · Wikibase.cloud

Apr 1 2023

Addshore placed T251792: Wiktionary Cognate Dashboard not updated up for grabs.
Apr 1 2023, 3:40 PM · Cognate, Wikidata, Wikidata-Campsite, User-ItamarWMDE, All-and-every-Wiktionary, WMDE-Analytics-Engineering, User-GoranSMilovanovic

Mar 31 2023

Addshore added a comment to T330389: Run Mediawiki Jobs in the background not at the end of requests.

For reasons not clear, we need to limit the amount of jobs per request to MediaWiki to 2 (https://www.mediawiki.org/wiki/Manual:Job_queue).

Mar 31 2023, 11:51 AM · Wikibase.cloud (Kanban board Q2 2023)

Mar 29 2023

Addshore moved T330310: Bash completion makes terminal hang when config file is missing from Watching & Blocked to Priority Backlog on the mwcli board.
Mar 29 2023, 5:44 PM · mwcli

Mar 27 2023

Addshore added a comment to T333029: Gitlab-Github mirror broken.

Alternative is to have Gitlab replication to use it is own based after the GitLab repository name instead of the Gerrit one. Eg:

SourceGitHub
Gerrit mediawiki/tools/clihttps://github.com/wikimedia/mediawiki-tools-cli
Gitlab releng/clihttps://github.com/wikimedia/releng-cli

(given that if on GitHub one renames mediawiki-tools-cli to releng-cli, I am pretty sure GitHub will honor the redirect when Gerrit replicates so we are back to point 1). Then for the mirror I don't think we need to keep the Gerrit based name.

Mar 27 2023, 12:58 PM · GitLab, mwcli

Mar 25 2023

Addshore added a comment to T333029: Gitlab-Github mirror broken.

Note: https://github.com/wikimedia/mediawiki-tools-cli is a mirror of the Gerrit repository https://gerrit.wikimedia.org/r/admin/repos/mediawiki/tools/cli

And it is indeed replicated:

gerrit1001:/var/log/gerrit/replication_log
[2023-03-24 05:42:12,197] Replication to git@github.com:wikimedia/mediawiki-tools-cli started... [CONTEXT pushOneId="3ed2eea4" ]
[2023-03-24 05:42:12,519] Push to git@github.com:wikimedia/mediawiki-tools-cli references: RemoteRefUpdate{refSpec=refs/heads/main:refs/heads/main, status=NOT_ATTEMPTED, id=(null)..AnyObjectId[e1fd6968eb15285bc159b7176b9aa54b4e4458d1], force=yes, delete=no, ffwd=no} [CONTEXT pushOneId="3ed2eea4" ]
[2023-03-24 05:42:13,105] Replication to git@github.com:wikimedia/mediawiki-tools-cli completed in 907ms, 809789ms delay, 7 retries [CONTEXT pushOneId="3ed2eea4" ]
Mar 25 2023, 3:28 PM · GitLab, mwcli

Mar 24 2023

Addshore added a comment to T333029: Gitlab-Github mirror broken.
13:get remote references: create git ls-remote: exit status 128, stderr: "@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\r\n@ WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED! @\r\n@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@\r\nIT IS POSSIBLE THAT SOMEONE IS DOING SOMETHING NASTY!\r\nSomeone could be eavesdropping on you right now (man-in-the-middle attack)!\r\nIt is also possible that a host key has just been changed.\r\nThe fingerprint for the RSA key sent by the remote host is\nSHA256:uNiVztksCsDhcc0u9e8BujQXVUpKZIDTMczCvj3tD2s.\r\nPlease contact your system administrator.\r\nAdd correct host key in /tmp/gitaly-ssh-invocation2616940952/known-hosts to get rid of this message.\r\nOffending RSA key in /tmp/gitaly-ssh-invocation2616940952/known-hosts:1\r\n remove with:\r\n ssh-keygen -f \"/tmp/gitaly-ssh-invocation2616940952/known-hosts\" -R \"github.com\"\r\nRSA host key for github.com has changed and you have requested strict checking.\r\nHost key verification failed.\r\nfatal: Could not read from remote repository.\n\nPlease make sure you have the correct access rights\nand the repository exists.\n".
Mar 24 2023, 6:19 PM · GitLab, mwcli
Addshore added a comment to T333029: Gitlab-Github mirror broken.

Looks like it is set up in the gitlab settings for the repo...

Mar 24 2023, 6:18 PM · GitLab, mwcli
Addshore created T333029: Gitlab-Github mirror broken.
Mar 24 2023, 6:17 PM · GitLab, mwcli
Addshore closed T332336: `mw docker update` panics on 0.22.0 as Resolved.
Mar 24 2023, 11:57 AM · mwcli
Addshore moved T332336: `mw docker update` panics on 0.22.0 from Pending Release to Done on the mwcli board.
Mar 24 2023, 11:56 AM · mwcli

Mar 16 2023

Addshore added a comment to T332336: `mw docker update` panics on 0.22.0.

0.22.1 is releasing now

Mar 16 2023, 6:11 PM · mwcli
Addshore moved T332336: `mw docker update` panics on 0.22.0 from Done to Pending Release on the mwcli board.
Mar 16 2023, 6:11 PM · mwcli
Addshore moved T332336: `mw docker update` panics on 0.22.0 from Review to Done on the mwcli board.
Mar 16 2023, 6:11 PM · mwcli
Addshore claimed T332336: `mw docker update` panics on 0.22.0.
Mar 16 2023, 5:52 PM · mwcli
Addshore moved T332336: `mw docker update` panics on 0.22.0 from Priority Backlog to Review on the mwcli board.
Mar 16 2023, 5:52 PM · mwcli
Addshore added a comment to T332336: `mw docker update` panics on 0.22.0.

Scratch that, I can, just I was on 0.21.0 to start with
Indeed this happens in 0.22.0!
And there is currently no e2e test for this method

Mar 16 2023, 5:47 PM · mwcli
Addshore added a comment to T332336: `mw docker update` panics on 0.22.0.

I don't appear to be able to reproduce :/

Mar 16 2023, 5:46 PM · mwcli
Addshore triaged T332336: `mw docker update` panics on 0.22.0 as High priority.
Mar 16 2023, 5:42 PM · mwcli
Addshore added a comment to T332336: `mw docker update` panics on 0.22.0.
gitlab.wikimedia.org/repos/releng/cli/internal/cmd/docker.NewMwddUpdateCmd.func1(0xc0006b3b00?, {0x1ca89b8?, 0x0?, 0x0?})
    /builds/repos/releng/cli/internal/cmd/docker/update.go:20 +0x137

This is...

Mar 16 2023, 5:38 PM · mwcli
Addshore added a comment to T330617: Support for Recipes to set up dev environment.

Ohia all, thanks for all the discussion :)

Mar 16 2023, 5:35 PM · mwcli
Addshore closed T328795: Allow defining the name of the default wiki as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T293548: mwcli mwdd simple continious job runner as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T331815: Add at least a simple e2e test for the mediawiki get-code command as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T327069: Allow use of multiple different custom service sets in mwcli as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T331815: Add at least a simple e2e test for the mediawiki get-code command, a subtask of T331806: "mediawiki get-code" fails, as Resolved.
Mar 16 2023, 1:38 AM · mwcli
Addshore closed T331215: mwcli docs publish edits to mediawiki.org should use the bot flag! as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T331993: mwcli: Add fresh-node v16, while also keeping node v14 as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T330954: mwcli docker, make a command that outputs the image used for the service as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T330955: mwcli docker, make a command that allows setting an image override for a service as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli
Addshore closed T332209: Add mwscript wrapper for `exec php maintenance/run.php` as Resolved.

Released in v0.22.0
https://gitlab.wikimedia.org/repos/releng/cli/-/releases/v0.22.0

Mar 16 2023, 1:38 AM · mwcli

Mar 15 2023

Addshore claimed T331815: Add at least a simple e2e test for the mediawiki get-code command.
Mar 15 2023, 10:57 PM · mwcli
Addshore moved T331815: Add at least a simple e2e test for the mediawiki get-code command from Review to Pending Release on the mwcli board.
Mar 15 2023, 10:57 PM · mwcli
Addshore moved T328795: Allow defining the name of the default wiki from In Progress to Pending Release on the mwcli board.
Mar 15 2023, 10:57 PM · mwcli
Addshore claimed T332209: Add mwscript wrapper for `exec php maintenance/run.php`.
Mar 15 2023, 8:53 PM · mwcli
Addshore moved T332209: Add mwscript wrapper for `exec php maintenance/run.php` from Review to Pending Release on the mwcli board.
Mar 15 2023, 8:53 PM · mwcli
Addshore added a comment to T328795: Allow defining the name of the default wiki.

Using an env var would also be "lame" as the env var only relates to the docker sub command, and having --context is quite a nice user experience...

Mar 15 2023, 8:52 PM · mwcli
Addshore added a comment to T328795: Allow defining the name of the default wiki.

Another option would be storing a default wiki name in the general mwcli config, or in a new mediawiki sub command specific config...
This would allow the persistent pre run of the mediawiki command to set the env var file itself.
Similar to what is done for the MEDIAWIKI_VOLUMES_DOT_COMPOSER variable right now

Mar 15 2023, 8:52 PM · mwcli
Addshore added a comment to T328795: Allow defining the name of the default wiki.

A tiny issue with being able to implement this right now is that the default flag value for dbname can not be correctly set in the help output, as if --context is used, the env var of the default db name would not be known
https://gitlab.wikimedia.org/repos/releng/cli/-/merge_requests/384/diffs#68bbf3d56ab35afc40a5844690acde92a7cf4d98_305_308

Mar 15 2023, 8:49 PM · mwcli
Addshore claimed T328795: Allow defining the name of the default wiki.
Mar 15 2023, 8:35 PM · mwcli
Addshore added a comment to T328795: Allow defining the name of the default wiki.

I wonder if this should be via mwdev docker env set DEFAULT_WIKI <wikiname>
This would mean that things such as mediawiki would know the default wiki (this is a win for running maintenance scripts etc)
But it would also require those containers to be restarted once the env var is set,
So the env command should probably suggest that containers be restarted once env vars are changed...

Mar 15 2023, 8:35 PM · mwcli
Addshore moved T331815: Add at least a simple e2e test for the mediawiki get-code command from Priority Backlog to Review on the mwcli board.
Mar 15 2023, 8:27 PM · mwcli
Addshore moved T332209: Add mwscript wrapper for `exec php maintenance/run.php` from Priority Backlog to Review on the mwcli board.
Mar 15 2023, 7:13 PM · mwcli
Addshore moved T332209: Add mwscript wrapper for `exec php maintenance/run.php` from Inbox to Priority Backlog on the mwcli board.
Mar 15 2023, 6:59 PM · mwcli
Addshore triaged T330617: Support for Recipes to set up dev environment as Medium priority.
Mar 15 2023, 6:15 PM · mwcli
Addshore triaged T314892: Finish implementing mwdd save service state feature as Low priority.
Mar 15 2023, 6:15 PM · mwcli
Addshore triaged T300989: mwcli mw install & install.php don't help developers if they change composer.lock.json as Low priority.
Mar 15 2023, 6:15 PM · mwcli
Addshore triaged T293086: macOS host environment management as Low priority.
Mar 15 2023, 6:14 PM · mwcli
Addshore triaged T291348: mwcli dev/docker with podman as Low priority.
Mar 15 2023, 6:13 PM · mwcli
Addshore triaged T307366: Graphite config differs between mwcli and graphite.wikimedia.org as Medium priority.
Mar 15 2023, 6:13 PM · mwcli
Addshore triaged T320324: Try to recover LocalSettings.php.mwdd.bak files if LocalSettings.php is not found as High priority.
Mar 15 2023, 6:13 PM · mwcli
Addshore triaged T300476: Display the changelog of all versions between last and new in update as Low priority.
Mar 15 2023, 6:13 PM · Wikimedia-Hackathon-2022, mwcli
Addshore triaged T301368: Provide a way for a user to set a default db type for use with mediawiki as Medium priority.
Mar 15 2023, 6:12 PM · mwcli
Addshore triaged T295999: Confusing HTTP timeout error message when installing as Lowest priority.
Mar 15 2023, 6:12 PM · mwcli