Addshore (Adam_WMDE)
Community & WMDE Developer (Wikidata Tech Lead 🐢)

Projects (49)
View All

Banner Campaign Autumn 2019
Milestone
CatWatch
Component
Cognate
Component
Deployment
Milestone
Deprecation process
Milestone

Calendar

User Details

User Since: Oct 6 2014, 9:43 PM (266 w, 1 d)
Availability: Available
IRC Nick: Addshore
LDAP User: Addshore
MediaWiki User: Addshore [ Global Accounts ]

Blog: http://addshore.com
Board: User-Addshore

Meta: http://meta.wikimedia.org/wiki/User:Addshore
Wikitech: https://wikitech.wikimedia.org/wiki/User:Addshore

🐢

Recent Activity
View All

Today

Addshore added a comment to T227071: Identify and Develop crucial paths e2e tests in Wikibase.

So, first thing we should look at (coming from tech conf 2019) https://www.mediawiki.org/wiki/MediaWiki_API_Integration_Tests

Tue, Nov 12, 3:32 PM · Wikidata, Wikidata-Trailblazing-Exploration

Addshore updated the task description for T234644: Wikimedia Technical Conference 2019 Session: Release "strategies" for MediaWiki and other elements of Wikimedia platform, for safe and efficient deployment and hosting.

Tue, Nov 12, 1:50 PM · User-Addshore, International-Developer-Events, Wikimedia-Technical-Conference-2019

Addshore added a comment to T234644: Wikimedia Technical Conference 2019 Session: Release "strategies" for MediaWiki and other elements of Wikimedia platform, for safe and efficient deployment and hosting.

Another point that came up at the start of Monday:

Tue, Nov 12, 1:48 PM · User-Addshore, International-Developer-Events, Wikimedia-Technical-Conference-2019

Fri, Nov 8

Addshore moved T233213: XSS in Wikidata Query Service UI from Stalled/Waiting to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

Fri, Nov 8, 11:03 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore closed T213704: Wikidata Tours don't load correctly as Resolved.

Fri, Nov 8, 10:51 AM · User-Mrjohncummings, Wikidata-Campsite, User-Sebastian_Berlin-WMSE, Wikidata

Addshore placed T233213: XSS in Wikidata Query Service UI up for grabs.

Fri, Nov 8, 10:46 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

@JBennett I think we can make this public now?
I had a quick flick through the comments and don't see anything private in here.

Fri, Nov 8, 10:46 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore closed T208493: Create testing framework for Wikimedia wiki config (mediawiki/config) as Declined.

declining for one of the other linked tickets

Fri, Nov 8, 10:39 AM · Wikidata

Addshore added a comment to T223552: external ID linking issue on Factgrid.

What is $wgWBRepoSettings['formatterUrlProperty'] set to?

Fri, Nov 8, 10:36 AM · Wikidata-Campsite, FactGrid, Wikidata

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Fri, Nov 8, 10:22 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Thu, Nov 7

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 5:12 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 4:59 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 4:50 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 4:36 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 4:02 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 1:38 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 1:32 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Thu, Nov 7, 1:32 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore moved T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3) from Incoming to Ready to estimate on the Wikidata-Campsite board.

Thu, Nov 7, 1:25 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata, Continuous-Integration-Config, Wikidata Query UI

Addshore added a project to T235651: Update wikidata-query-gui-build job versions (from Jessie, Node v6, npm v3): Wikidata-Campsite.

Thu, Nov 7, 1:24 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Ladsgroup, Wikidata, Continuous-Integration-Config, Wikidata Query UI

Addshore added a comment to T227032: Start tagging images of Query Service UI.

Marking has high, has not having done this already has stung us a couple of times in the past weeks and wasted hours of time.

Thu, Nov 7, 12:02 PM · Wikidata-Campsite, Wikidata Query UI, Wikibase-Containers, Wikidata

Addshore raised the priority of T227032: Start tagging images of Query Service UI from Normal to High.

Thu, Nov 7, 12:02 PM · Wikidata-Campsite, Wikidata Query UI, Wikibase-Containers, Wikidata

Addshore added a project to T237579: Wikistats data discrepancy for India page views from hive data pull : Analytics-Wikistats.

Thu, Nov 7, 10:02 AM · Analytics-Wikistats, Analytics

Addshore added a project to T237611: RC: strange format of [sichten] link in recent changes: Wiktionary.

Thu, Nov 7, 10:02 AM · Wiktionary, Growth-Team, MediaWiki-Recent-changes

Addshore added a project to T237611: RC: strange format of [sichten] link in recent changes: MediaWiki-Recent-changes.

Thu, Nov 7, 10:01 AM · Wiktionary, Growth-Team, MediaWiki-Recent-changes

Addshore added a comment to T223552: external ID linking issue on Factgrid.

I don't think that says anything about the external ID config.

Thu, Nov 7, 8:42 AM · Wikidata-Campsite, FactGrid, Wikidata

Wed, Nov 6

Addshore updated the task description for T233213: XSS in Wikidata Query Service UI.

Wed, Nov 6, 5:17 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

In T233213#5641189, @WMDE-leszek wrote:

wikidata-tech as well?

Wed, Nov 6, 5:06 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

The one thing that remains to figure out is updating the zips on https://archiva.wikimedia.org/repository/snapshots/org/wikidata/query/rdf/service

Wed, Nov 6, 5:05 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore claimed T233213: XSS in Wikidata Query Service UI.

Has a little chat with @Reedy and got some things figured out.

Wed, Nov 6, 4:54 PM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore moved T213704: Wikidata Tours don't load correctly from Needs Work to Blocked / Waiting / External on the Wikidata-Campsite board.

Wed, Nov 6, 3:01 PM · User-Mrjohncummings, Wikidata-Campsite, User-Sebastian_Berlin-WMSE, Wikidata

Addshore assigned T213704: Wikidata Tours don't load correctly to Mrjohncummings.

Sounds good to me

Wed, Nov 6, 3:01 PM · User-Mrjohncummings, Wikidata-Campsite, User-Sebastian_Berlin-WMSE, Wikidata

Addshore added a comment to T237522: Investigate options to get block and protection info from remote repository.

It looks like all of the code needed for changes is in the nice new PermissionManager.php in core

Wed, Nov 6, 2:50 PM · Wikidata, Wikidata-Bridge

Addshore added a comment to T237522: Investigate options to get block and protection info from remote repository.

In T237522#5640567, @Lucas_Werkmeister_WMDE wrote:

Actually, this doesn’t tell us what the protection level is, and it looks like it might not distinguish between regular and cascading protection either… as far as I know, we want those distinctions for the messages :/

Wed, Nov 6, 2:45 PM · Wikidata, Wikidata-Bridge

Addshore added a comment to T237522: Investigate options to get block and protection info from remote repository.

Looks like what you want might already exist

Wed, Nov 6, 2:40 PM · Wikidata, Wikidata-Bridge

Addshore added a comment to T237522: Investigate options to get block and protection info from remote repository.

endpoint (in core) for whether a user is allowed to edit a page (incl. protection and block status)

Wed, Nov 6, 2:34 PM · Wikidata, Wikidata-Bridge

Addshore closed T216641: WikibaseLexeme browser tests failing with Invalid CSRF Token error as Resolved.

Wed, Nov 6, 1:46 PM · Wikidata-Campsite, Browser-Tests, Wikidata, Lexicographical data

Addshore added a comment to T213704: Wikidata Tours don't load correctly.

A couple months down the line, any movement here? Is this done?

Wed, Nov 6, 1:40 PM · User-Mrjohncummings, Wikidata-Campsite, User-Sebastian_Berlin-WMSE, Wikidata

Addshore removed a project from T222707: switch eslint to require dangling comma with "always-multiline": Wikidata-Campsite.

Wed, Nov 6, 1:39 PM · Front-end-Standards-Group, Wikidata, JavaScript, Code-Health

Addshore triaged T236998: 404 for wikitech chart from rest_v1/page/graph/png as Lowest priority.

Wed, Nov 6, 12:15 PM · User-Addshore, RESTBase-API, wikitech.wikimedia.org, MediaWiki-extensions-Graph

Addshore added a comment to T236998: 404 for wikitech chart from rest_v1/page/graph/png.

Going to reopen and assign myself then so I can create the correct ticket when I find the time

Wed, Nov 6, 12:15 PM · User-Addshore, RESTBase-API, wikitech.wikimedia.org, MediaWiki-extensions-Graph

Addshore reopened T236998: 404 for wikitech chart from rest_v1/page/graph/png as "Open".

Wed, Nov 6, 12:15 PM · User-Addshore, RESTBase-API, wikitech.wikimedia.org, MediaWiki-extensions-Graph

Addshore closed T220666: quibble-vendor-mysql-hhvm-docker fails in Wikibase as Resolved.

I'm going to close this as resolved? As noone has complained here in months.

Wed, Nov 6, 12:08 PM · Wikidata, Lexicographical data, Wikidata-Campsite

Addshore changed the status of T214378: Check simple format constraints (no grouping) in PHP instead of SPARQL, a subtask of T176312: Don’t check format constraint via SPARQL (safely evaluating user-provided regular expressions), from Open to Stalled.

Wed, Nov 6, 12:08 PM · TechCom-RFC, Wikibase-Quality-Constraints, Wikibase-Quality, Wikidata

Addshore changed the status of T214378: Check simple format constraints (no grouping) in PHP instead of SPARQL from Open to Stalled.

Wed, Nov 6, 12:08 PM · Security-Team, Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata

Addshore moved T214378: Check simple format constraints (no grouping) in PHP instead of SPARQL from Needs Work to Blocked / Waiting / External on the Wikidata-Campsite board.

Probably blocked on the RFC around regexes.
RFC will be written in T236150

Wed, Nov 6, 12:07 PM · Security-Team, Wikidata-Campsite, Wikibase-Quality-Constraints, Wikidata

Addshore closed T217335: Call to the Wikibase API for entity types that are not enabled it should been handled gracefully, not surface as an exception as Resolved.

Going to close this as resolved now as the cases noticed seem fine.
Any new cases should be reported in seperate tickets.

Wed, Nov 6, 12:05 PM · User-Addshore, TestMe, Wikidata, Wikidata-Campsite

Addshore lowered the priority of T208493: Create testing framework for Wikimedia wiki config (mediawiki/config) from Low to Lowest.

Removing from the campsite, Might close in the future too, as I think T220775 would be enough

Wed, Nov 6, 12:03 PM · Wikidata

Addshore closed T220829: Wikidata edit (rollback) not propagated to Wikipedia after 10 days as Declined.

Not able to reproduce, and this is quite old now.
Please report back if it happens again

Wed, Nov 6, 11:58 AM · Wikidata-Campsite, Wikidata, MediaWiki-extensions-WikibaseRepository

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

In T233213#5639673, @Physikerwelt wrote:

The patch is a significant change to the rendering which was done without community involvement.

Wed, Nov 6, 10:46 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore closed T236491: Cache php.getEntityStatements in mw.wikibase as Resolved.

Wed, Nov 6, 10:39 AM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, Wikibase-Lua

Addshore triaged T223552: external ID linking issue on Factgrid as Normal priority.

Wed, Nov 6, 10:37 AM · Wikidata-Campsite, FactGrid, Wikidata

Addshore moved T223552: external ID linking issue on Factgrid from incoming to monitoring on the Wikidata board.

Wed, Nov 6, 10:37 AM · Wikidata-Campsite, FactGrid, Wikidata

Addshore added a comment to T223552: external ID linking issue on Factgrid.

@Olaf_Simons if you could provide us with your wikibase configuration, then we can probably help some more.

Wed, Nov 6, 10:36 AM · Wikidata-Campsite, FactGrid, Wikidata

Addshore added a comment to T236998: 404 for wikitech chart from rest_v1/page/graph/png.

In T236998#5635135, @mobrovac wrote:

As @bd808 points out, wikitech is a special wiki, and because of its set-up outside the main WM cluster, RESTBase is not available for it. Hence, any wikitech.wikimedia.org/api/rest_v1/-prefixed URL will 404.

Wed, Nov 6, 10:17 AM · User-Addshore, RESTBase-API, wikitech.wikimedia.org, MediaWiki-extensions-Graph

Addshore updated subscribers of T233213: XSS in Wikidata Query Service UI.

Wed, Nov 6, 9:40 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

In T233213#5639449, @Physikerwelt wrote:

Yes. The layout in firefox and chrome looks different now. And the success criteria defined in T214980 are not fulfilled.

Wed, Nov 6, 9:21 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

XSS looks fixed to me :)

Wed, Nov 6, 9:15 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore moved T237248: Convert wdqs docker image to not run blazegraph as root from Backlog to Doing on the Wikibase-Containers board.

Wed, Nov 6, 8:48 AM · Wikidata, Wikidata-Campsite, Wikibase-Containers

Addshore added a comment to T233213: XSS in Wikidata Query Service UI.

I just checked the live site and I still see the old code deployed when looking at the minified JS.

Wed, Nov 6, 8:47 AM · Discovery-Search (Current work), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Vuln-XSS, Wikidata, Wikidata Query UI, Security

Addshore added a comment to T237502: Provide public "reload entity to WDQS" API.

In T237502#5639339, @MisterSynergy wrote:

I used to ask Stas every couple of months in the past, in order to use that shell script for a couple of hundred items each time. IMO it does not make sense to waste technician time for such requests, and I would be willing to trigger the reloading by myself if I could.

Wed, Nov 6, 8:39 AM · Wikidata-Query-Service, Wikidata

Tue, Nov 5

Addshore added a comment to T234415: wdqs_updater fails when importing entities.

So, here is the blog post that I wrote too
https://addshore.com/2019/11/changing-the-concept-uri-of-an-existing-wikibase-with-data/

Tue, Nov 5, 5:13 PM · User-Addshore, Wikidata-Query-Service, Wikidata, Wikibase-Containers

Addshore added a comment to T197658: Provide easy script to reset Blazegraph.

Relevant to this ticket.
I just wrote a blog post guiding through the process of changing concept URI of a wikibase and reloading data into a fresh query service.
https://addshore.com/2019/11/changing-the-concept-uri-of-an-existing-wikibase-with-data/

Tue, Nov 5, 5:12 PM · Discovery, Wikidata-Query-Service, Wikidata, Wikibase-Containers

Addshore closed T228402: Reduce the number of ResourceLoader modules that WikibaseRepo registers as Resolved.

Done in https://phabricator.wikimedia.org/tag/rl_module_terminators_trailblazing/

Tue, Nov 5, 3:48 PM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, Performance Issue

Addshore placed T219805: Investigate Doctrine DBAL usage possibility up for grabs.

Tue, Nov 5, 3:44 PM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review

Addshore moved T219805: Investigate Doctrine DBAL usage possibility from Backlog to On Hold / Stalled on the Wikidata-Trailblazing-Exploration board.

Tue, Nov 5, 3:43 PM · User-Addshore, Wikidata-Trailblazing-Exploration, Wikidata, TechCom, Patch-For-Review

Addshore closed T68253: [Task] Browsertests for CommonsMedia gadget on beta as Declined.

Going to close this 4+ year old ancient ticket as we may not even want these things now.
We have a new story that will be taking a fresh look at our tests.
If we decide we want these things, new tasks would be created or reopened etc.
T226975: [Story] Restructuring Wikibase extension tests

Tue, Nov 5, 2:23 PM · Browser-Tests, Wikidata-Gadgets, Wikidata, MediaWiki-extensions-WikibaseRepository

Addshore closed T68253: [Task] Browsertests for CommonsMedia gadget on beta, a subtask of T67257: Create tests for default gadgets (tracking), as Declined.

Tue, Nov 5, 2:23 PM · Browser-Tests-Infrastructure, Wikidata-Gadgets, Wikidata, Tracking-Neverending, MediaWiki-extensions-WikibaseRepository

Addshore closed T68253: [Task] Browsertests for CommonsMedia gadget on beta, a subtask of T88541: [DO NOT USE] Wikidata Browsertests (tracking) [superseded by #Browser-Tests], as Declined.

Tue, Nov 5, 2:23 PM · Browser-Tests-Infrastructure, Tracking-Neverending, Wikidata

Addshore closed T88548: [Task] Browsertests for wikibase-property value input as Declined.

Tue, Nov 5, 2:22 PM · Browser-Tests, MediaWiki-extensions-WikibaseRepository, Wikidata

Addshore closed T88548: [Task] Browsertests for wikibase-property value input, a subtask of T55845: Browsertests for currently used datavalues (tracking), as Declined.

Tue, Nov 5, 2:22 PM · Browser-Tests-Infrastructure, Tracking-Neverending, Wikidata, MediaWiki-extensions-WikibaseRepository

Addshore closed T88796: [Task] Browsertests for badges functionality (on the client) as Declined.

Tue, Nov 5, 2:22 PM · Browser-Tests, MediaWiki-extensions-WikibaseClient, Wikidata

Addshore closed T88796: [Task] Browsertests for badges functionality (on the client), a subtask of T88541: [DO NOT USE] Wikidata Browsertests (tracking) [superseded by #Browser-Tests], as Declined.