Page MenuHomePhabricator

AdhamKhatean (Adham Khatean)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 2 2020, 1:40 PM (39 w, 2 d)
Availability
Available
LDAP User
AdhamKhatean
MediaWiki User
AdhamKhatean [ Global Accounts ]

Recent Activity

Aug 29 2020

AdhamKhatean added a watcher for Anti-Harassment: AdhamKhatean.
Aug 29 2020, 6:05 PM
AdhamKhatean created T261544: Divide maps consumer info to be edited separately .
Aug 29 2020, 9:04 AM · Patch-For-Review, TemplateData, VisualEditor

Aug 20 2020

AdhamKhatean created T260902: Add "appeal" call to action in block drawer .
Aug 20 2020, 11:58 AM · MediaWiki-Blocks

Jul 9 2020

AdhamKhatean added a comment to F31918803: expand.png.

I prefer This one looks better, But it is still has a problem as when I hit enter after a number of lines the scrollbar insides the text-box starts blinking while expanding which is annoying. And I face the same you mentioned earlier as the text-box does not expand to fit the maps object coming from the visual editor if it exceeds the rows number although it should expand till the maxRows value instead it sticks to the value of rows number until I hit enter. I think having a static text-box size with scrollbar like in the visual editor might be a better solution, But I am still thinking how to get that to fill the panel as it is not affected with my CSS and it does not have this built in.

Jul 9 2020, 3:36 PM

Jun 25 2020

AdhamKhatean updated the task description for T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".
Jun 25 2020, 6:19 AM · Anti-Harassment, Google-Summer-of-Code (2020)

Jun 4 2020

AdhamKhatean created T254478: Create the initial UI of Maps panel in TemplateData GUI.
Jun 4 2020, 2:01 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Anti-Harassment, TemplateData, VisualEditor, Patch-For-Review

Mar 30 2020

AdhamKhatean added a comment to T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

well, that is good we need to worry about any more. then we only need to focus on adding the maps parameter to the front-end.
could you please review this proposal for the last time before I upload it.

Mar 30 2020, 1:16 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean updated the task description for T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".
Mar 30 2020, 1:09 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean added a comment to T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

I'm not sure what you mean by auto-generate - do you mean suggesting the template parameters to use in the map?

Mar 30 2020, 12:31 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean added a comment to T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

So, instead of directly storing the data inserted by the user from the GUI editor, we place them in the text editor using JS and it will be saved as usual we the user clicks "Save changes"? won't this make it harder for us to auto-generate things serial numbers, DOIs, ISSNs, etc? anyway if this does not seem achievable or unnecessary using Php, we can still do it with JS.

Mar 30 2020, 12:12 AM · Anti-Harassment, Google-Summer-of-Code (2020)

Mar 28 2020

AdhamKhatean added a comment to T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

Hello @Mvolz, @Tchanders, @Mooeypoo - I hope you are fine.
I would like to know what do you think about the proposal and the project description? as I will have to submit my proposal soon.

Mar 28 2020, 8:26 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean updated the task description for T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".
Mar 28 2020, 8:19 PM · Anti-Harassment, Google-Summer-of-Code (2020)

Mar 27 2020

AdhamKhatean claimed T126150: TemplateData display table should not be sortable when there's zero or one parameter.
Mar 27 2020, 7:34 PM · User-Ryasmeen, Anti-Harassment, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), VisualEditor, TemplateData
AdhamKhatean updated subscribers of T126150: TemplateData display table should not be sortable when there's zero or one parameter.
Mar 27 2020, 3:48 PM · User-Ryasmeen, Anti-Harassment, MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), VisualEditor, TemplateData
AdhamKhatean claimed T248486: Top and bottom borders for the alias pills in the TemplateData editor are cut off.
Mar 27 2020, 1:42 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), TemplateData, VisualEditor

Mar 25 2020

AdhamKhatean updated the task description for T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".
Mar 25 2020, 11:40 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean added a comment to T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

@Tchanders - Thanks, I have seen the new timeline. I was just wondering if the timeline in this proposal seems reasonable or you think it is unrealistic and I underestimated something?

Mar 25 2020, 11:33 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean added a comment to T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

To me this "custom fields" sounds like adding hardcoded support for parameters like ISSN and DOI? Not sure if it's just that the language is unclear, but the fields in the the maps parameter can be literally anything, so those are good examples, but in the proposal it might make sense to make the language clearer here.

Mar 25 2020, 11:23 PM · Anti-Harassment, Google-Summer-of-Code (2020)
AdhamKhatean updated subscribers of T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".

@Mvolz, @Tchanders, @Mooeypoo - Hello,
I am adham Khatean, an undergraduate student from Egypt pursuing degree in physics, I am interested in participating in "support maps parameter in TemplateData editor (GUI) " as a GSoC student.

Mar 25 2020, 9:17 AM · Anti-Harassment, Google-Summer-of-Code (2020)

Mar 22 2020

AdhamKhatean added a comment to T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime.

@Florian - I also felt like I am going in the wrong direction So, I posted here. But, now thanks to you I think I have an idea about what I should do. :)
I will keep you update, and next time I will upload the patch directly to Gerrit instead of writing here. excuse me for taking screenshots and posting here, this OpenSource experience is kinda new to me.

Mar 22 2020, 7:33 PM · Patch-Needs-Improvement, Platform Engineering (Icebox), Google-Code-in-2019, good first task, MediaWiki-Logevents
AdhamKhatean created T248267: GSoC proposal for Support the ‘maps’ parameter in TemplateData Editor (GUI)".
Mar 22 2020, 6:41 PM · Anti-Harassment, Google-Summer-of-Code (2020)

Mar 20 2020

AdhamKhatean added a comment to T208305: Support 'maps' parameter in TemplateData Editor (GUI).

It worked! thanks a lot!
I did not restart my server at first so that is why it kept showing me the old value (120s).

Mar 20 2020, 3:46 PM · User-Ryasmeen, Google-Summer-of-Code (2020), VisualEditor, Outreach-Programs-Projects, TemplateData
AdhamKhatean added a comment to T208305: Support 'maps' parameter in TemplateData Editor (GUI).

@AdhamKhatean, if you search on Google, you'll get answers, such as: https://www.mediawiki.org/wiki/Topic:Veh8l4gmryp07fzh

Mar 20 2020, 3:23 PM · User-Ryasmeen, Google-Summer-of-Code (2020), VisualEditor, Outreach-Programs-Projects, TemplateData
AdhamKhatean added a comment to T208305: Support 'maps' parameter in TemplateData Editor (GUI).

Hello, I am interested in participating in the project as part of GSoC. I have installed MediaWiki on my device in addition to some other extensions including the required ones for this project and now trying to work around to really get familiar with the codebase. However, I have a problem importing Template:cite_journal


as one of these two errors always appear:

Mar 20 2020, 2:50 PM · User-Ryasmeen, Google-Summer-of-Code (2020), VisualEditor, Outreach-Programs-Projects, TemplateData

Mar 17 2020

AdhamKhatean added a comment to T200385: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime.

Hello, @Florian - I am interested in this task. And I have tried doing it assuming that the log type is always the same as the extension name as I noticed from interwiki extension

InterwikiHooks.php

Mar 17 2020, 1:58 AM · Patch-Needs-Improvement, Platform Engineering (Icebox), Google-Code-in-2019, good first task, MediaWiki-Logevents

Mar 15 2020

AdhamKhatean added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

@Yaron_Koren - Kindly, check if any changes need to be done on this contribution I11b6a1b32de5adb5a030c2b31f53feb66cc4bda9
Thanks in advance.

Mar 15 2020, 6:45 PM · MediaWiki-extensions-Page_Forms

Mar 11 2020

AdhamKhatean added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

@Yaron_Koren - Thank you now it works perfectly

but it does check/uncheck even if I click on the label

Mar 11 2020, 3:19 PM · MediaWiki-extensions-Page_Forms
AdhamKhatean added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

@Yaron_Koren - I created a new form using PageSchemas then edited its definition manually,


But, I did not get checkboxes of the list of values I added or any other input type. Instead this is what happened.

could you please tell me what is wrong with what I did or direct me to where can I learn more preferably with code example(s).

Mar 11 2020, 1:50 PM · MediaWiki-extensions-Page_Forms

Mar 9 2020

AdhamKhatean added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

@Yaron_Koren - I have created a page using the form I created through "Special:CreateClass"


, and I checked "List of values?" and added several options for every field. But, what I got was a form with text boxes instead of checkboxes.

So, I tried to edit it manually but have not noticed any change.

Mar 9 2020, 1:10 PM · MediaWiki-extensions-Page_Forms

Mar 8 2020

AdhamKhatean added a comment to T217516: Page Forms: Checkboxes labels in multiple-instance templates are not clickable.

Hello, @Yaron_Koren does this issue still exist? If yes, I have been trying to experience this issue from what I learned from your discussion with Prondubuisi and what I understood from the documentation so far. But, I am still stuck. could you please give me any pointers or hints? thanks in advance.

Mar 8 2020, 10:45 PM · MediaWiki-extensions-Page_Forms