@Soda Can you please review my patch
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/907830

In T332517#8803507, @Soda wrote:

What do you mean ? I'm pretty sure you can run different processes in the same dockerfile as a container. I did a basic test on my PC and was able to come up with a basic config that worked.

version: '3.9'
services:
  videocuttool:
    container_name: videocuttool
    build:
      context: .
      dockerfile: Dockerfile.dev
    volumes:
      - ./src:/app/src:ro
      - ./server:/app/server
      - ./public:/app/public
      - '/app/node_modules'
      - '/app/server/node_modules'
    ports:
      - '3000:3000'
      - '4000:4000'
    environment:
      - CHOKIDAR_USEPOLLING=true
      - NODE_ENV=development
      - DB_CONNECTION_URL=mongodb://videocuttool-mongo:27017/video-cut-tool
      - BACKEND_URL=http://videocuttool:4000/api/
    env_file:
      - .env.dev
    depends_on:
      - mongo
  mongo:
    container_name: videocuttool-mongo
    image: 'mongo:4'
    volumes:
      - ./mongo-data:/data/db
    ports:
      - '27017:27017'
  nginx:
    restart: always
    image: nginx:latest
    depends_on:
      - videocuttool
    ports:
      - 80:80
    volumes:
      - ./nginx/default.conf:/etc/nginx/conf.d/default.conf

In T332517#8801563, @Soda wrote:

@Aditiganvir28 It still seems to have npm processes, can we not do this with only two containers, one with the npm servers and one with the nginx server ? The architecture I was looking for was to have one service with both npm servers and one with only a nginx connection

@Soda Can you please review my patch.
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/907830

In T332517#8784244, @Soda wrote:

In T332517#8784239, @Aditiganvir28 wrote:

In T332517#8784209, @Soda wrote:

In T332517#8783736, @Aditiganvir28 wrote:

@Soda I tried removing dockerfile from nginx folder. But instead of that I have to run the nginx command
CMD ["sh", "-c", "nginx -g 'daemon off;' & npm run dev"].
Should I also bring default.conf file in the main directory instead of creating nginx folder.

I don't have a problem with a different container, what I don't understand is why we need a new dockerfile for it

AFAIK If we are not using a separate dockerfile then we have to run the nginx server after running our react app and backend. At first it was showing error running both but the issue was I didn't installed nginx in Dockerfile.dev. Now what I did is using only one container. If we want to use different containers we can do that also. In the new patchset upoladed I have used only one container.

I would prefer it to be a different container

In T332517#8784209, @Soda wrote:

In T332517#8783736, @Aditiganvir28 wrote:

@Soda I tried removing dockerfile from nginx folder. But instead of that I have to run the nginx command
CMD ["sh", "-c", "nginx -g 'daemon off;' & npm run dev"].
Should I also bring default.conf file in the main directory instead of creating nginx folder.

I don't have a problem with a different container, what I don't understand is why we need a new dockerfile for it

In T332517#8784210, @Soda wrote:

Also please stop uploading improvements as new patches, that is not how Gerrit is supposed to be used, and causes multiple spam commit/entries. Please unabandon your last change and upload your change as a patchset on top of the old change as per the guide linked in the description.

@Soda I tried removing dockerfile from nginx folder. But instead of that I have to run the nginx command
CMD ["sh", "-c", "nginx -g 'daemon off;' & npm run dev"].
Should I also bring default.conf file in the main directory instead of creating nginx folder.

In T332517#8783597, @Soda wrote:

What error are you getting

@Soda If I am removing dockerfile.dev form nginx folder and docker-compose.dev.yml it is giving me error.

@Soda I had added the new patch for review. Kindly please review it.
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/907830

In T332517#8747765, @Aklapper wrote:

@Aditiganvir28: Again, please stop creating new patches for the same issue in Gerrit. Please fix existing patches instead by amending: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 . Please abandon patches in Gerrit if they are not relevant anymore. Thanks.

@Soda I had uploaded the patch for review. Can you please review it.
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/904589

@Soda do we need hot reloading for both frontend and backend

@Soda Kindly please review my code
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/902612
Patchset 5

In T332517#8731599, @Soda wrote:

In T332517#8726680, @Aditiganvir28 wrote:

Yeah sure should I push to the same branch

Can you mention which change is final, you have two patches for the same change

@Soda Kindly please review my code

Yeah, I am sorry for that

This one
https://gerrit.wikimedia.org/r/c/labs/tools/VideoCutTool/+/902612
Patchset 3

@Soda I had squash the two commits can you please review it

@Soda I am getting this error when I am trying to squash the commits

Yeah sure should I push to the same branch

@Soda I have made the required imporvements you told and now the backend and frontend are both running on localhost:8000.
Should I make the patch request again

In T332517#8726508, @Soda wrote:

In T332517#8725986, @Aditiganvir28 wrote:

Actually If I used just node:16 , 'Run apk update' is showing error so I have to use node:16-alpine so that it doesn't show error

Why do you need apk update ? We can just use apt to do the same thing

In T332517#8725985, @Soda wrote:

I have left comments about improvements that need to be made

Actually If I used just node:16 , 'Run apk update' is showing error so I have to use node:16-alpine so that it doesn't show error

@Soda Is the code verified or should I make changes in it

Hey @Soda @Gopavasanth My frontend and backend both are running and also nginx is running successfully but I am getting 502 bad gateway error on localhost:8000 (proxy server) . Can you please guide me what should I do

@Soda In docker-compose.dev..yml no different services are defined like client and api . in videocuttool itself both the ports are defined for frontend and backend.

Hey, @Soda I would like to work on this task

Hi and thank you for your interest! Please check thoroughly https://www.mediawiki.org/wiki/New_Developers (and all of its communication section!). The page covers how to get started, assigning tasks, task status, how to find a codebase, how to create patches, where to ask general development questions and where to get help with setup problems, and how to ask good questions. Thanks a lot! :)