Page MenuHomePhabricator

AlexMonk-WMF (Alex Monk)
Disabled

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2016, 8:15 PM (421 w, 3 d)
Roles
Disabled
IRC Nick
Krenair
LDAP User
Unknown
MediaWiki User
Alex Monk (WMF) [ Global Accounts ]
This account has been disabled.

Recent Activity

Jan 5 2017

AlexMonk-WMF removed a watcher for VisualEditor-MediaWiki-2017WikitextEditor: AlexMonk-WMF.
Jan 5 2017, 11:45 PM
AlexMonk-WMF removed a watcher for VisualEditor-MediaWiki: AlexMonk-WMF.
Jan 5 2017, 11:45 PM
AlexMonk-WMF removed a watcher for TemplateData: AlexMonk-WMF.
Jan 5 2017, 11:45 PM
AlexMonk-WMF removed a watcher for SRE-tools: AlexMonk-WMF.
Jan 5 2017, 11:44 PM
AlexMonk-WMF removed a watcher for Contributors-Analysis: AlexMonk-WMF.
Jan 5 2017, 11:44 PM
AlexMonk-WMF removed a watcher for Contributors-Analysis: AlexMonk-WMF.
Jan 5 2017, 11:44 PM
AlexMonk-WMF removed a watcher for Blocked-on-Editing: AlexMonk-WMF.
Jan 5 2017, 11:44 PM

Jan 1 2017

AlexMonk-WMF merged T154377: Not replacing pasted links into T154020: Selected text is not replaced in new wikitext editor when a paste gets transformed.
Jan 1 2017, 1:37 AM · VisualEditor-CopyPaste, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF merged task T154377: Not replacing pasted links into T154020: Selected text is not replaced in new wikitext editor when a paste gets transformed.
Jan 1 2017, 1:37 AM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Dec 31 2016

AlexMonk-WMF added a subtask for T50930: Database replication problems - production and labs (tracking): T154355: page_lang column of the page table is not replicated to Labs.
Dec 31 2016, 3:56 PM · SRE, DBA, Cloud-Services, Tracking-Neverending
AlexMonk-WMF edited parent tasks for T154355: page_lang column of the page table is not replicated to Labs, added: T50930: Database replication problems - production and labs (tracking); removed: T150767: Wikireplica service for tools and labs - issues and missing available views (tracking).
Dec 31 2016, 3:56 PM · DBA, Cloud-Services
AlexMonk-WMF removed a subtask for T150767: Wikireplica service for tools and labs - issues and missing available views (tracking): T154355: page_lang column of the page table is not replicated to Labs.
Dec 31 2016, 3:56 PM · Data-Services, Tracking-Neverending, DBA
AlexMonk-WMF added a comment to T154355: page_lang column of the page table is not replicated to Labs.

Nope, it's actually missing from most of the underlying databases.

Dec 31 2016, 3:53 PM · DBA, Cloud-Services
AlexMonk-WMF removed a project from T154355: page_lang column of the page table is not replicated to Labs: Toolforge.
Dec 31 2016, 11:47 AM · DBA, Cloud-Services
AlexMonk-WMF updated subscribers of T154355: page_lang column of the page table is not replicated to Labs.

This is listed as a fullview in maintain-replicas config. I guess we just need to run the script to recreate it and mysql will see the new field... @chasemp?

Dec 31 2016, 11:47 AM · DBA, Cloud-Services
AlexMonk-WMF added a parent task for T154355: page_lang column of the page table is not replicated to Labs: T150767: Wikireplica service for tools and labs - issues and missing available views (tracking).
Dec 31 2016, 11:44 AM · DBA, Cloud-Services
AlexMonk-WMF added a subtask for T150767: Wikireplica service for tools and labs - issues and missing available views (tracking): T154355: page_lang column of the page table is not replicated to Labs.
Dec 31 2016, 11:44 AM · Data-Services, Tracking-Neverending, DBA
AlexMonk-WMF added a comment to T154334: Can't use arrow keys to scroll through the preview.

This works when you first press the TAB key 3 times.

Dec 31 2016, 11:39 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Accessibility, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Dec 30 2016

AlexMonk-WMF added a comment to T154303: Fixing edit conflicts in 2017 editor doesn't work anymore.

Duplicate of T154217: Page blanked when editing a section after an edit conflict?

Dec 30 2016, 12:01 PM · Regression, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, User-Urbanecm
AlexMonk-WMF added a comment to T154226: NWE: Make links to &action=edit automatically redirect to NWE if beta feature is turned on.

The current production deployment schedule can be found at https://www.mediawiki.org/wiki/MediaWiki_1.29/Roadmap
I think 1.29.0-wmf.7 on cswiki will likely be scheduled for January 4th, when it would receive code up to date as of January 2nd

Dec 30 2016, 11:57 AM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF renamed T154227: URLs with title query string parameter and additional query string parameters do not redirect to mobile site from Make links to xy.wikipedia automatically redirect to xy.m.wikipedia if user is on a mobile phone to Redirect diff pages to mobile diff on mobile phones.
Dec 30 2016, 11:55 AM · Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board-Old, Patch-For-Review, Traffic, SRE, Web-Team-Backlog (Tracking), Puppet, patch-welcome, Mobile

Dec 28 2016

AlexMonk-WMF added a comment to T154217: Page blanked when editing a section after an edit conflict.

When you say you weren't able to reproduce it, was that just due to not being able to arrange for an edit conflict? Or were the same steps taken without such an error/bug occurring?

Dec 28 2016, 9:34 PM · MW-1.29-release (WMF-deploy-2017-04-04_(1.29.0-wmf.19)), User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T154204: Help communities replace page notices with collapsed templates as they're impossible for VE/NWE or mobile users.

in any case, I believe these are created by user (e.g., MediaWiki:Common.js) rather than MW code, so there's likely not much we can do on this side (VE isn't actually magic, it can't force everything else to become compatible)

Dec 28 2016, 9:17 PM · MediaWiki-Editnotice, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T154204: Help communities replace page notices with collapsed templates as they're impossible for VE/NWE or mobile users.

However merely fixing that is probably sub-par. In the normal editor the page notice is part of the page. The tools in the page notice remain visible and easily accessible. In the New Wikitext Editor the page notice is displayed in a popup. [...]

Dec 28 2016, 9:15 PM · MediaWiki-Editnotice, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T154227: URLs with title query string parameter and additional query string parameters do not redirect to mobile site.

If you want diff pages to redirect to mobile diffs when viewed on mobile devices, that doesn't seem to have much to do with VE. The VE behaviour here is expected. VE has no control over what is shown to readers after the edit is saved.

Dec 28 2016, 9:06 PM · Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board-Old, Patch-For-Review, Traffic, SRE, Web-Team-Backlog (Tracking), Puppet, patch-welcome, Mobile
AlexMonk-WMF added a comment to T154226: NWE: Make links to &action=edit automatically redirect to NWE if beta feature is turned on.

the production wikis use older code, I'm concerned with whether it's working on master (what beta runs)

Dec 28 2016, 9:03 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T154219: Consider making it possible to insert links, special characters, and other non-plain-text content into the heading box for a new section.

The section header here appears to be a separate input rather than a surface. Maybe we can reuse some tricks from the ProofreadPage integration?

Dec 28 2016, 9:02 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T154226: NWE: Make links to &action=edit automatically redirect to NWE if beta feature is turned on.

I just tested this on beta and with:

Dec 28 2016, 8:52 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T154227: URLs with title query string parameter and additional query string parameters do not redirect to mobile site.

This doesn't make much sense, ultimately the link created and shown to users wouldn't change like that.

Dec 28 2016, 8:47 PM · Unplanned-Sprint-Work, Readers-Web-Kanbanana-Board-Old, Patch-For-Review, Traffic, SRE, Web-Team-Backlog (Tracking), Puppet, patch-welcome, Mobile

Dec 27 2016

AlexMonk-WMF added a comment to T154182: [suggestion] NWE should allow shortcuts like Alt+Shift+P for preview etc..

See also: T153959: The keyboard shortcut for previewing a page (ctrl-option-p) doesn't do anything on some browsers, T153958: In Firefox: using the keyboard shortcut to open the preview breaks, T153937: LOST WORK BUG: If you use the shortcut keyboard command to preview, you lose all your changes. - which seem to imply we have a shortcut for this already

Dec 27 2016, 12:59 PM · User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Dec 26 2016

AlexMonk-WMF added a comment to T154161: Simultaneous opening of template page in 2010 and 2017 wikitext editors?.

What about reproducibility? Do you know the set of circumstances in which VE will get stuck like this?

Dec 26 2016, 9:00 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T154161: Simultaneous opening of template page in 2010 and 2017 wikitext editors?.

That's a screenshot taken in the process of VE loading over the top of OWE. It didn't get stuck there, did it? If it did get stuck there, what was in the console?

Dec 26 2016, 8:51 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF merged T154155: Raw HTML is shown in the wikitext mode into T153508: NWE surface showing parsoid HTML.
Dec 26 2016, 8:49 PM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF merged task T154155: Raw HTML is shown in the wikitext mode into T153508: NWE surface showing parsoid HTML.
Dec 26 2016, 8:49 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T154159: Parsoid-based preview is not compatible with Extension:TemplateSandbox.

Duplicate of T153367: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor?

Dec 26 2016, 8:40 PM · Parsoid, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Dec 25 2016

AlexMonk-WMF claimed T153297: After saving a section in NWE scroll to that section.
Dec 25 2016, 3:03 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Dec 24 2016

AlexMonk-WMF updated subscribers of T154020: Selected text is not replaced in new wikitext editor when a paste gets transformed.

I dug into this a bit, it looks like ve.ce.Surface.prototype.handleDataTransferItems always collapses to end. @Esanders?

Dec 24 2016, 5:58 PM · VisualEditor-CopyPaste, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T154041: Pasting to replace selected text doesn't replace the text.

Duplicate of T154020: Selected text is not replaced in new wikitext editor when a paste gets transformed?

Dec 24 2016, 5:24 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-CopyPaste, VisualEditor
AlexMonk-WMF added a comment to T151278: mw.DesktopArticleTarget.prototype#loadFail sometimes given (unexpected?) jqXHR.

Reproducible when you have VE configured to connect to RB directly from the client and it's not running. https://gerrit.wikimedia.org/r/#/c/327721/ seems to fix

Dec 24 2016, 12:25 PM · Technical-Debt, VisualEditor, VisualEditor-MediaWiki
AlexMonk-WMF renamed T153445: 2017WE doesn't allow accessing the Translate extension by clicking on Edit source from 2017WE doesn't allow accessing the Translate extension on Meta by clicking on Edit source to 2017WE doesn't allow accessing the Translate extension by clicking on Edit source.
Dec 24 2016, 12:02 PM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-Translate
AlexMonk-WMF added a comment to T154081: WikitextEditor overrides the ordinary translation mechanism.

This sounds like a dupe of T153445: 2017WE doesn't allow accessing the Translate extension by clicking on Edit source?

Dec 24 2016, 12:02 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Dec 23 2016

AlexMonk-WMF added a comment to T148717: Kill the labtest $realm.

I still see modules/standard/templates/mail/exim4.minimal.labtest.erb and modules/puppetmaster/files/labtest.hiera.yaml in the puppet repository

Dec 23 2016, 6:09 PM · Patch-For-Review, SRE, Cloud-Services
AlexMonk-WMF added a comment to T154014: VE: Use message sig-text when inserting a signature.

For the toolbar button, maybe. It might make less sense for the keyboard detection of ~~~~ to prepend --

Dec 23 2016, 11:27 AM · VisualEditor-MediaWiki, VisualEditor

Dec 22 2016

AlexMonk-WMF updated subscribers of T153987: [Regression] Many url values have a malformed subdomain in wiki meta_p database table.

This would be due to https://gerrit.wikimedia.org/r/#/c/325949/7/modules/role/files/labs/db/views/maintain-meta_p.py where the matches = re.match("^(.*)(wik[it].*)", db) and lang = matches.group(1) were changed to lang = db[:2]

Dec 22 2016, 11:49 PM · Patch-For-Review, Cloud-Services, Cloud-VPS, Regression
AlexMonk-WMF updated subscribers of T153609: &section=new results in an un-editable default edit summary.

It looks like this gets disabled whenever VE decides what the Subject part is going to be, presumably so the user can't change it? Can you shed some light on this behaviour @Esanders?

Dec 22 2016, 7:50 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T153956: Consider allowing sequences (like {{ [[ etc.) in wikitext mode.

I thought we already had this?

Dec 22 2016, 5:42 PM · VisualEditor-EditingTools, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T115026: Support a multi-domain model in keystone.

can we have more details for this please?

Dec 22 2016, 5:15 PM · Cloud-VPS, Cloud-Services, labs-sprint-117
AlexMonk-WMF added a comment to T115027: switch to keystone api v3.

We have the v3 API enabled and have done for a while now. Do we need to move everything to using it, or is this done?

Dec 22 2016, 5:14 PM · labs-sprint-117, Cloud-Services, Cloud-VPS
AlexMonk-WMF claimed T108625: Remove reliance on ldap $::projectid from shinkengen.

I think this was done by my previous puppet patch (https://gerrit.wikimedia.org/r/#/c/309008/). I think we should re-purpose it as 'remove reliance on ldap from shinkengen' and close it when my new puppet patch (https://gerrit.wikimedia.org/r/#/c/328611/) is done. @Andrew?

Dec 22 2016, 5:12 PM · Patch-For-Review, Cloud-Services, Labs-Sprint-109
AlexMonk-WMF added a comment to T108625: Remove reliance on ldap $::projectid from shinkengen.

I'm doing it in https://gerrit.wikimedia.org/r/#/c/328611/ - the roles thing is not exactly an OpenStack API, but it is an API that lets you query puppet roles for a given instance. And you can now use the OpenStack APIs to get lists of projects and instances.

Dec 22 2016, 9:30 AM · Patch-For-Review, Cloud-Services, Labs-Sprint-109

Dec 21 2016

AlexMonk-WMF created P4665 non-working keystone project list CLI command.
Dec 21 2016, 11:25 PM · Cloud-Services
AlexMonk-WMF created P4659 working keystone projects list code for inside labs instances.
Dec 21 2016, 2:01 AM · Cloud-Services
AlexMonk-WMF created T153807: openstackclient/keystoneclient on silver broken.
Dec 21 2016, 1:29 AM · Patch-For-Review, SRE, Cloud-Services
AlexMonk-WMF added a comment to T90784: Monitor nova-scheduler log for lost contact with compute nodes.

Basic API HTTP code check added in T42022

Dec 21 2016, 12:45 AM · cloud-services-team, Cloud-VPS, labs-sprint-118, labs-sprint-117, labs-sprint-116, Labs-Sprint-109, observability
AlexMonk-WMF added a comment to T133656: Have a paging check for Nova API accessible.

Basic check added in T42022. My question above should be pretty easy though.

Dec 21 2016, 12:45 AM · cloud-services-team (Kanban), Cloud-VPS, SRE, observability

Dec 20 2016

AlexMonk-WMF closed T153579: Mysterious warnings in WikitextEditor as Resolved.

I think I've fixed it - https://no.wikipedia.org/wiki/Spesial:Bidrag/Alex_Monk_(WMF)

Dec 20 2016, 2:12 AM · User-Urbanecm, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T153367: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor.

(I've accidentally linked to this task in a few unrelated revisions - if you're here from no.wikipedia.org please see T153579 instead)

Dec 20 2016, 2:08 AM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-TemplateSandbox, VisualEditor

Dec 19 2016

AlexMonk-WMF merged T153671: Section name not added to summary field in save dialog into T153245: NWE: Edit section does not add section title into summary.
Dec 19 2016, 2:04 PM · Verified-in-Phase0, Verified, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF merged task T153671: Section name not added to summary field in save dialog into T153245: NWE: Edit section does not add section title into summary.
Dec 19 2016, 2:04 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T153579: Mysterious warnings in WikitextEditor.

This'll be the same old broken editnotice code, I'll fix it when I'm not traveling. Do not delete it

Dec 19 2016, 9:31 AM · User-Urbanecm, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Dec 18 2016

AlexMonk-WMF claimed T153508: NWE surface showing parsoid HTML.
Dec 18 2016, 3:47 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T153508: NWE surface showing parsoid HTML.

This appears to happen when you:

  • have VE set to remember last editor, and you used visual mode last time,
  • try to action=edit,
  • try to edit only a section
  • try to edit a page that does not have visual mode enabled
Dec 18 2016, 3:35 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T153292: Use NWE to show source of an edit protected page.

Of course, the surface must be read-only, and all tools should be disabled, except perhaps the Find tool (which should only have the replace option disabled).

Dec 18 2016, 3:06 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T153561: Sometimes old WikiText editor loads after user has switched to new WikiText editor.

Randomly?

Dec 18 2016, 3:03 AM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-05-09_(1.30.0-wmf.1)), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF merged T153564: Section editing doesn't include the section name in the edit summary into T153245: NWE: Edit section does not add section title into summary.
Dec 18 2016, 2:45 AM · Verified-in-Phase0, Verified, MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF merged task T153564: Section editing doesn't include the section name in the edit summary into T153245: NWE: Edit section does not add section title into summary.
Dec 18 2016, 2:45 AM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Dec 17 2016

AlexMonk-WMF claimed T153472: Can't open VisualEditor with &uselang=qqx.
Dec 17 2016, 1:59 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T153472: Can't open VisualEditor with &uselang=qqx.

This is in console:
Uncaught Error: Incomplete trigger
ve.ui.TriggerRegistry.register @ ve.ui.TriggerRegistry.js?c7b3f:59
(anonymous function) @ ve.ui.MWSaveDialogAction.js?81b5a:94
(anonymous function) @ ve.ui.MWSaveDialogAction.js?81b5a:103

Dec 17 2016, 1:52 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF added a comment to T153472: Can't open VisualEditor with &uselang=qqx.

Need to add uselang/useskin to the whitelist of params we don't freak out about?

Dec 17 2016, 1:47 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF renamed T153508: NWE surface showing parsoid HTML from Wikitext editor displays HTML mojibake to NWE surface showing parsoid HTML.
Dec 17 2016, 1:33 AM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Dec 15 2016

AlexMonk-WMF renamed T153367: Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor from Support "Preview page with this template" in the new wikitext editor to Support "Preview page with this template" (TemplateSandbox) in the new wikitext editor.
Dec 15 2016, 11:40 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), Patch-For-Review, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-TemplateSandbox, VisualEditor
AlexMonk-WMF added a comment to T153305: NWE edits are not always tagged with the appropriate tag.

can you provide the full steps you went through for #2?

Dec 15 2016, 11:36 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-MediaWiki, VisualEditor
AlexMonk-WMF added a comment to T153293: Provide preview in visual mode so I can interact with the content (e.g. test out table sortability) without saving.

What kind of things?

Dec 15 2016, 11:25 PM · VisualEditor, VisualEditor-MediaWiki
AlexMonk-WMF renamed T153378: Uncaught TypeError: Cannot read property 'clone' of null when inserting language from Nothing happens when I click the "Insert" button in the "Language" box. It won't "Cancel", either. to Uncaught TypeError: Cannot read property 'clone' of null when inserting language.
Dec 15 2016, 11:15 PM · Verified, MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
AlexMonk-WMF claimed T153291: VisualEditor fails to load on first-run, throwing JS SecurityError due to ? reading from localStorage in maybeShowWelcomeDialog.
Dec 15 2016, 11:08 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor-MediaWiki, VisualEditor
AlexMonk-WMF added a comment to T153291: VisualEditor fails to load on first-run, throwing JS SecurityError due to ? reading from localStorage in maybeShowWelcomeDialog.

It looks like the behaviour that Chrome & FF exhibit when you disable cookies/localStorage will break this code (though I'm not sure what exactly causes "The operation is insecure" here), so let's assume that's the problem.

Dec 15 2016, 11:01 PM · MW-1.29-release (WMF-deploy-2017-01-03_(1.29.0-wmf.7)), VisualEditor-MediaWiki, VisualEditor
AlexMonk-WMF added a comment to T153294: Use NWE to revert edit(s).

Sounds like T78550 to me

Dec 15 2016, 10:44 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
AlexMonk-WMF added a comment to T153279: labnet/ labtestnet2001 - disk space - nova-api.log needs rotation.

yeah but virt-libvirt-driver doesn't use strtime, does it? this file (nova/contex.py) would come from the nova package

Dec 15 2016, 4:52 PM · cloud-services-team (Kanban), SRE, Cloud-Services
AlexMonk-WMF added a comment to T153279: labnet/ labtestnet2001 - disk space - nova-api.log needs rotation.

So this file has a lot of /usr/lib/python2.7/dist-packages/nova/context.py:181: DeprecationWarning: Using function/method 'oslo_utils.timeutils.strtime()' is deprecated in version '1.6' and will be removed in a future version: use either datetime.datetime.isoformat() or datetime.datetime.strftime() instead self, 'timestamp') else None, spam
Does the same occur on labnet1001?

Dec 15 2016, 3:26 PM · cloud-services-team (Kanban), SRE, Cloud-Services

Dec 13 2016

AlexMonk-WMF added a parent task for T16950: [Epic] Support global preferences on Wikimedia wikis: T153062: Editor dialog option for all wikis at once.
Dec 13 2016, 6:44 PM · User-notice-archive, Community-Wishlist-Survey-2016, Wikimedia-Developer-Summit (2017), Community-Tech, MediaWiki-extensions-GlobalPreferences, MediaWiki-extension-requests, Epic
AlexMonk-WMF added a subtask for T153062: Editor dialog option for all wikis at once: T16950: [Epic] Support global preferences on Wikimedia wikis.
Dec 13 2016, 6:44 PM · VisualEditor
AlexMonk-WMF edited projects for T153101: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500", added: Beta-Cluster-reproducible; removed Beta-Cluster-Infrastructure.
Dec 13 2016, 6:26 PM · Beta-Cluster-reproducible, Services (watching), Parsoid, VisualEditor
AlexMonk-WMF added a comment to T153101: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500".

https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/User%3ARYasmeen_(WMF)/349201?redirect=false returns the HTTP 500

Dec 13 2016, 6:23 PM · Beta-Cluster-reproducible, Services (watching), Parsoid, VisualEditor
AlexMonk-WMF added a project to T153101: Cannot open VE after saving an edit on a page, getting error "Error loading data from server: HTTP 500": RESTBase.
Dec 13 2016, 6:22 PM · Beta-Cluster-reproducible, Services (watching), Parsoid, VisualEditor

Dec 12 2016

AlexMonk-WMF added a comment to T142516: Custom task form for #WMF-NDA.

I think it's close, it just needs the tag field to always include WMF-NDA and I think the only way to do that right now is to lock it.

Dec 12 2016, 5:58 PM · Phabricator

Dec 10 2016

AlexMonk-WMF edited projects for T152645: Adding wikilinks to citations leads to weird link behaviour, added: Cite; removed Citoid.

It's actually the Cite extension (not the Citoid one) detecting a reference, then trying to render it using VE code that seems to have an issue.

Dec 10 2016, 5:56 PM · MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), VisualEditor-MediaWiki-References, Cite, VisualEditor
AlexMonk-WMF added a comment to T142830: Require/track Phabricator username.

Not all NDA statuses are stored in Phabricator (though it would be good if Phabricator actually knew about all Phab-based and historical NDA signatures)

Dec 10 2016, 2:25 PM · SRE
AlexMonk-WMF added a subtask for T142815: Enhance account handling (meta bug): T148048: Store Wikimedia unified account name (SUL) in LDAP directory.
Dec 10 2016, 2:25 PM · Infrastructure-Foundations, SRE
AlexMonk-WMF added a parent task for T148048: Store Wikimedia unified account name (SUL) in LDAP directory: T142815: Enhance account handling (meta bug).
Dec 10 2016, 2:25 PM · Patch-For-Review, User-bd808, Infrastructure-Foundations, LDAP, Striker
AlexMonk-WMF added a comment to T108078: audit labs versus production ssh keys.

Yes. Let's open a separate task (maybe a subtask of T142815) for that?

Dec 10 2016, 2:24 PM · SRE, Patch-For-Review, Cloud-Services
AlexMonk-WMF added a comment to T42022: Add icinga checks for all nova, glance, and keystone related services.

@Andrew, what other things should be checked?

Dec 10 2016, 2:17 PM · cloud-services-team (Kanban), Patch-For-Review, observability, Cloud-VPS

Dec 7 2016

AlexMonk-WMF added a comment to T152593: Redlinks should open the respective editor that's set in the user or global settings.

And yeah, we don't get notifications when you add tokens.

Dec 7 2016, 1:12 PM · WikiEditor, VisualEditor
AlexMonk-WMF added a comment to T152593: Redlinks should open the respective editor that's set in the user or global settings.

There's no regression, we resolved T55441 with a configuration variable that allows VE to load on action=edit in some cases, depending on a bunch of factors such as user preferences.

Dec 7 2016, 1:11 PM · WikiEditor, VisualEditor
AlexMonk-WMF added a comment to T69147: VisualEditor should support redirects to sections on a page.

So, when you have a title+section link in the text box, and the suggestions show the page name that's currently in there, an extra suggestion should be added for the full title+current section? I think anything more than that would be T52881

Dec 7 2016, 11:42 AM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
AlexMonk-WMF updated the task description for T69147: VisualEditor should support redirects to sections on a page.
Dec 7 2016, 11:40 AM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor

Dec 5 2016

AlexMonk-WMF added a project to T152434: Add method to Revision to check if it was a Revert, and whether an edit was Reverted: MediaWiki-Page-editing.
Dec 5 2016, 6:52 PM · Google-Summer-of-Code (2020), Growth-Team, Platform Team Legacy (Watching / External), Web-Team-Backlog (Tracking), Product-Infrastructure-Team-Backlog-Deprecated, Trending-Service, Epic, MediaWiki-Page-editing, Contributors-Team, MediaWiki-User-Interface
AlexMonk-WMF added a comment to T152434: Add method to Revision to check if it was a Revert, and whether an edit was Reverted.

Also I'd be careful about trying to invent such a field (to store whether a given revision was a revert). While you could do it for rollbacks, when you press the undo link you can still change the text to whatever you want. Other humans probably usually identify a revision as a revert by looking for the auto-generated (but entirely customisable) revision summary and trusting the user who made it. To find a simple single-revision revert you can compare the text/hash of your revision to the parent of the parent's text/hash, but beyond that things could get complicated.

Dec 5 2016, 6:51 PM · Google-Summer-of-Code (2020), Growth-Team, Platform Team Legacy (Watching / External), Web-Team-Backlog (Tracking), Product-Infrastructure-Team-Backlog-Deprecated, Trending-Service, Epic, MediaWiki-Page-editing, Contributors-Team, MediaWiki-User-Interface
AlexMonk-WMF added a comment to T152434: Add method to Revision to check if it was a Revert, and whether an edit was Reverted.

IIRC we can detect them in Echo because we hook functions running outside the scope of a revision, but that sort of context is lost as soon as the request has finished being handled. There's no good (quick + trustworthy) way to guess whether a given revision ID was a revert, we don't store the information.

Dec 5 2016, 6:47 PM · Google-Summer-of-Code (2020), Growth-Team, Platform Team Legacy (Watching / External), Web-Team-Backlog (Tracking), Product-Infrastructure-Team-Backlog-Deprecated, Trending-Service, Epic, MediaWiki-Page-editing, Contributors-Team, MediaWiki-User-Interface

Dec 1 2016

AlexMonk-WMF claimed T152154: [Regression pre-wmf.5] Searching for templates in VE throws error "Uncaught TypeError: this.getApi is not a function" .

yep. specifically when you get a valid result back. caused by https://gerrit.wikimedia.org/r/#/c/324531/

Dec 1 2016, 10:56 PM · Verified, MW-1.29-release (WMF-deploy-2016-12-06_(1.29.0-wmf.5)), VisualEditor-MediaWiki-Templates, VisualEditor
FoXFTW awarded T53375: TemplateData: Add parameter type for selecting one of predefined values (like "<select>" or ENUM) a Like token.
Dec 1 2016, 12:54 AM · VisualEditor-MediaWiki, VisualEditor, TemplateData