Feb 24 2020
This has been merged.
Feb 21 2020
Dec 16 2019
Nov 12 2019
I am closing this as invalid. There is a context issue with the DynamicSettings FarmInstaller that is causing this maintenance script to run against the wrong database. We will fix that on our end.
I deleted the updatelog entry and ran it manually. This time around it actually did the task. This is consistent behavior across every wiki that is being upgraded. It fails during update.php with a successful message, is logged as completed, but did not actually do anything. I am going to do tests against the MW 1.31 version of the database with debugging to see what is happening.
The maintenance script did run though:
Running maintenance/populateChangeTagDef.php... done. Adding index change_tag_rc_tag_id to table change_tag ...done. Adding ipb_sitewide field to table ipblocks ...done. Creating ipblocks_restrictions table ...done. Merging image_comment_temp into the image table Merging image_comment_temp into the image table... Completed merge of image_comment_temp into the image table, 0 image rows updated, 0 image_comment_temp rows deleted. done. Dropping table image_comment_temp ...done. Table change_tag contains ct_tag field. Dropping ...General exception while running update: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? Query: ALTER TABLE `change_tag` MODIFY ct_tag_id int unsigned NOT NULL
Jul 8 2019
Jun 14 2019
Jun 11 2019
Locally on Gamepedia we are removing this patch due to it negativity affecting many of our wikis breaking styling and layout. This issue only affects Chrome the worst, does not crash Safari(though never finishes loading), and loads fine in Firefox. It should be fixed by the browser vendors as needed.
Jun 9 2019
Looks good to me!
Jun 2 2019
Jan 9 2019
The $wgThumbLimits setting is default/stock in the Gamepedia stack.
Dec 14 2018
Dec 10 2018
I goofed and submitted a buggy patch. See the new patch set.
Understood. I changed our local CSS to embed the output of the Google Font URL call directly.(Which is not recommended, but not the worst thing.) We only use it in two places.
Dec 7 2018
Dec 5 2018
This is MediaWiki making many cookies. See EditPage::setPostEditCookie() where it creates the cookie key: $postEditKey = self::POST_EDIT_COOKIE_KEY_PREFIX . $revisionId;
Dec 4 2018
Dec 3 2018
I wrote a function to hoist @import up to the top of files, but unfortunately in my digging it seems that resource loader is hell bent on keeping every single file separate until the very last moment. I can not find a good place to put this in.
Nov 30 2018
Nov 27 2018
@ashley: You might be interested in this one since you were working on it recently.
Nov 26 2018
The "MediaWiki-extensions-DeleteBatch" tag does not exist so I can not add it.
Nov 18 2018
Nov 15 2018
Nov 14 2018
Oct 30 2018
Oct 29 2018
The recommend fix does work for our extension. I apparently had configured Echo properly in the past so it was working properly. For AbuseFilter I had to patch it to use the same pattern since it only specifies the database and not the cluster to use.
Oct 23 2018
Extension:GlobalBlock(No 'ing) is an internal extension that works with Gamepedia/Twitch authentication servers. That code example is based on a previous version of Echo.
Oct 17 2018
We applied this patch as a temporary work around for our MW 1.31 testing.
Previously with MW 1.29 in LoadBalancer::reallyOpenConnection( array $server, $dbNameOverride = false ) $server['dbname'] would only be overwritten if an override was passed. An override was never passed though since LoadBalancer::openConnection() was always passing false for that parameter.
Oct 16 2018
May 23 2018
The issue was that when I submitted this patch 1.5 years ago that it broke several extensions that relied on it and had not been updated yet.(Such as ConfirmEdit.) Looking at my current local code base all of those extensions have been updated and no longer rely on it. This can be abandoned.
Apr 16 2018
I will fix this patch this week.
Apr 11 2018
I will add that task to Hydra's internal Jira to move to extending the Module set of classes for this.
I updated the test to match the new conditions.
Apr 10 2018
Apr 9 2018
Apr 6 2018
I put in a work around for this on the Hydra Wiki Platform that removes FOUC and puts all the CSS into one minified file.
Mar 15 2018
Mar 12 2018
I just got notification of this. Patched on Gamepedia/Hydra wikis. However, our version of MySQL is patched already for the table of death issue.
Feb 28 2018
Feb 1 2018
Many years ago there were several third party extensions that had a habit of opening new database transactions, but never closing them. So as a work around in several of Hydra's own extensions we put $db->commit() in place to fix them breaking transactions.
This was the entire change. Basically it had not been updated for MediaWiki's newer API for atomic database transactions.
I found the issue. Another extension was throwing an exception for logged out users that was causing this issue for Cargo. However, due to an exception handling change in MediaWiki 1.29 those kind of exceptions were quietly being dropped and MediaWiki would go on pretending everything was fine.
Morning update: I have found that the hook "PageContentSaveComplete" is not being ran or being interrupted somehow. The onPageContentSaveComplete function in Cargo never gets called.
Regular page edits through the standard source editor are what cause this behavior.
Jan 31 2018
Jan 9 2018
Dec 11 2017
Dec 9 2017
Dec 2 2017
@Reception123 DPL3 is meant to replace all previous iterations of DPL.
You should not be running both of these extensions at the same time. Intersection is a legacy extension and fork/branch of the previous iterations of DPL.
Nov 17 2017
It probably will! I will get this fix deployed on the Gamepedia stack today.
Nov 16 2017
A similar error on line 244 of drilldown/CargoFilter.php. Path of Exile has weapons with range so that conflicts with the MySQL reserved word.
Nov 15 2017
Aug 7 2017
I think I know why this happened then. Our development machines are OS X case-insensitive. So most likely at some point it was capitalized way in the past, but future file copies went fine since OS X will not rename/ignore the difference. I will mark this as closed.