Apr 9 2020
Jul 3 2019
@Ragesoss I think I will be able to fix this within a week or two.
Apr 10 2019
May 8 2018
@Milimetric changing the hover style to pointer, yes. That can be taken care of. Is that all? If you give a go ahead, I'll submit the change :)
Apr 20 2018
@Millimetric what do you think of the Semantic's own Radio styling? I guess it would go well with the site's design. This is the preview I got fiddling within the developer tools: https://www.useloom.com/share/8f9e578ed6844137b4d70104d8256658
Apr 12 2018
@Nuria sure. I'll remove all the other changes and will just implement that switch from green to blue for now :)
Apr 11 2018
Here's a quick preview of how the change affects the UI: https://www.useloom.com/share/e840f13d82f5478094fe656d8979a974
Apr 9 2018
@mforns yes. The ranking use case has been covered in the table view, but I think it is double work if the user quickly wanted to know. Also it is a lot more easier to just move the mouse over a country and know its rank than to go through the entire table looking for the country and then seeing it's rank.
Thanks @mforns! :)
Apr 3 2018
@mforns I guess the confusion stems from this "on-off" switch mechanism. Please see https://semantic-ui.com/modules/checkbox.html (Radio) button. If this is enabled, then exclusivity is implicit as users have been long accustomed to the working of radio buttons, while with this on-of switch there's some confusion.
Apr 1 2018
Here's the newer version which I think is more pragmatic: https://www.useloom.com/share/ea829701049a46ab886caf02bd7269f7
@sahil505 yes, I went through them. They were very insightful :) I am in the middle of implementing another patch, will work on this right after :]
@sahil505 yes, I too felt weird about the first two points. We could display "February" in place of "Monthly", that would make more sense. Will be submitting a patch for the same :]
Mar 31 2018
@fdans this is the preview of the changes I've made: https://www.useloom.com/embed/b49265a3960a482c87097aeae9e88a91
@Nuria I'd like to look into this. Can you please elaborate a bit more? A pseudo code of what we have now and what is expected would be great :]
@Nuria yeah. That makes sense. I've updated my changes. Here's the preview: https://www.useloom.com/share/9dbf7ff90a8c48b499a1053ffb520e0b Thanks :]
Mar 30 2018
@Nuria thanks! Here is the screen recording https://drive.google.com/file/d/1obp9JGeBla1wPhoReoDsdxCnCmoyUiYG/view
@sahil505 don't know. I thought claiming task was akin to issues "Assigned" in Github. Usually if a person is assigned a issue, only his work will be considered right? Whatever additional done is supplementary, that was my rationale.
Mar 29 2018
@ezachte glad it worked out :)
@Nuria if that was offensive, sorry about that :( Didn't mean to. I was just pointing out the second point of the Gerrit Commit Message Guidelines of the body section which states: Why should this change should be made? What is wrong with the current code?' Will condense and remove the inappropriate details from the commit message. Thanks for the review :]
Mar 28 2018
@Nuria I'll remember it the next time :) Sorry for the inconvenience.
Here's how it looks with the changes I've made - https://drive.google.com/file/d/1M7czDvN7Eqhf5DY6aIpDFMqyVX80oK3x/view.
Mar 24 2018
Mar 23 2018
@mforns, if that's the case, we could go one step ahead and do this: Make the first para visible in the tooltip and truncate the rest with ellipsis and provide a (read more) link within the tooltip, that would point to the help pages with the specific hash like, 'more_info#page_views'. I think, it will be a best of both worlds.
@mforns would displaying the description on the tooltip be enough? Currently, the tooltip that goes like, "Click this to get to that" is redundant as it is the basic functionality of an anchor tag. To click here to go somewhere. Instead, the tooltip could house a small para regarding what it does in layman's term so it truly is a "tool" "tip".