Page MenuHomePhabricator

Ammarpad
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 9:01 PM (187 w, 4 d)
Availability
Available
IRC Nick
Ammarpad
LDAP User
Ammarpad
MediaWiki User
Ammarpad [ Global Accounts ]

Open source enthusiast, mathematics buff.

Recent Activity

Tue, May 11

Ammarpad added a comment to T282384: Protection log summaries do not show wikilinked syntax (but only plain text without links).

I don't think that message ever allows wikitext. Also the message is shown in the protection form dropdown where wikitext will seemingly not work well too. You should either delete the message (revert to the canonical one) or just remove the wikilink

Tue, May 11, 4:57 AM · MediaWiki-Logevents

Mon, May 10

Ammarpad closed T280456: ForkController should not assume existence of PCNTL support or posix extension as Resolved.
Mon, May 10, 4:35 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-General

Fri, May 7

Ammarpad updated the task description for T282183: Hiding own edits on watchlist and recentchanges results in hiding all IP edits.
Fri, May 7, 10:35 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (Clinic Duty Team), MediaWiki-Recent-changes, Regression, Growth-Team, MediaWiki-Watchlist

Thu, May 6

Ammarpad created T282183: Hiding own edits on watchlist and recentchanges results in hiding all IP edits.
Thu, May 6, 8:31 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (Clinic Duty Team), MediaWiki-Recent-changes, Regression, Growth-Team, MediaWiki-Watchlist

Wed, May 5

Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Wed, May 5, 10:26 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms

Tue, Apr 27

Ammarpad created P15542 (An Untitled Masterwork).
Tue, Apr 27, 4:51 AM

Mon, Apr 19

Ammarpad removed a project from T280518: Postgres schema `mwuser` table is renamed: MediaWiki-extensions-MediaModeration.
Mon, Apr 19, 1:10 PM · MediaWiki-extensions-ConfirmAccount, MediaWiki-extensions-OpenID-Connect, MediaWiki-extensions-OpenID
Ammarpad created T280518: Postgres schema `mwuser` table is renamed.
Mon, Apr 19, 11:39 AM · MediaWiki-extensions-ConfirmAccount, MediaWiki-extensions-OpenID-Connect, MediaWiki-extensions-OpenID

Sat, Apr 17

Ammarpad created T280456: ForkController should not assume existence of PCNTL support or posix extension.
Sat, Apr 17, 9:15 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-General

Apr 15 2021

Ammarpad placed T277230: Migrating from 1.31.12 to 1.35.1 : error on populateContentTables.php up for grabs.
Apr 15 2021, 4:41 PM · MediaWiki-Maintenance-system

Apr 8 2021

Ammarpad added a comment to T279290: Synchronising Wikidata and Wikipedias using pywikibot - Task 6.

Working with Category:Netflix title ID not in Wikidata and Category:SoundCloud ID not in Wikidata

Apr 8 2021, 10:15 AM · Outreachy (Round 22)

Apr 5 2021

Ammarpad added a comment to T246242: Add tag description.

Hi, I would like to work on this issue, can anyone please guide me on
where is the repository and what description has to be added about this tag GWToolset

Apr 5 2021, 5:01 AM · good first task, MediaWiki-extensions-GWToolset, Commons

Apr 4 2021

Ammarpad updated the task description for T230428: Migrate tables.sql to abstract schema.
Apr 4 2021, 7:35 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer

Apr 1 2021

Ammarpad placed T27471: Add "Delete associated talk page" option to action=delete up for grabs.
Apr 1 2021, 3:51 PM · Platform Engineering, MediaWiki-Special-pages, MediaWiki-Page-deletion
Ammarpad placed T247160: Add range support to resetAuthenticationThrottle.php up for grabs.
Apr 1 2021, 5:13 AM · MediaWiki-Maintenance-system
Ammarpad placed T272081: Introduce StatusValue::ignore method up for grabs.
Apr 1 2021, 4:59 AM · Platform Team Workboards (MW Expedition)
Ammarpad closed T270363: Improve test coverage of core skin code as Declined.
Apr 1 2021, 4:57 AM · Test-Coverage, MediaWiki-Core-Skin-Architecture

Mar 28 2021

Ammarpad added a comment to T278620: Auto-remove never used dormant user accounts.

There's a script that does something like that https://www.mediawiki.org/wiki/Manual:RemoveUnusedAccounts.php. You need to check the limitations and what it considers 'unused'

Mar 28 2021, 10:19 AM · MediaWiki-extensions-UserMerge
Ammarpad updated the task description for T244383: Replace StubUserLang with a better lazy loading mechanism.
Mar 28 2021, 9:46 AM · Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-General, Technical-Debt

Mar 26 2021

Ammarpad closed T278512: PHP8: Fatal error: Cannot make non static method MediaWiki\Tests\Unit\MockServiceDependenciesTrait::fail() static in class PHPUnit\Framework\Assert as Declined.

Already fixed

Mar 26 2021, 2:00 PM · PHP 8.0 support
Ammarpad added a project to T278512: PHP8: Fatal error: Cannot make non static method MediaWiki\Tests\Unit\MockServiceDependenciesTrait::fail() static in class PHPUnit\Framework\Assert: PHP 8.0 support.
Mar 26 2021, 7:55 AM · PHP 8.0 support
Ammarpad created T278512: PHP8: Fatal error: Cannot make non static method MediaWiki\Tests\Unit\MockServiceDependenciesTrait::fail() static in class PHPUnit\Framework\Assert.
Mar 26 2021, 7:54 AM · PHP 8.0 support

Mar 25 2021

Ammarpad added a comment to T277601: EditHandler: Call to a member function getContent() on null.

The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.

SELECT ... FROM `revision` ... WHERE rev_id = 0

While generally this would be pointless but harmless, this actually led me to realize a flaw in my patch: the response representing the state after a null-edit should reflect information from the page's current revision, not the edit's base revision. I'll make another patch to improve this.

Pointless is the same as "doesn't make sense" No one says it's harmful.

Mar 25 2021, 6:18 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-REST-API, Wikimedia-production-error
Ammarpad closed T189967: User::findUsersByGroup() does not order its results, but its test assumes it does as Resolved.
Mar 25 2021, 5:31 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-User-management

Mar 24 2021

Ammarpad closed T277689: LanguageKk_cyrl->lastLetter: PHP Notice: Undefined offset: -1 as Resolved.
Mar 24 2021, 11:19 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Engineering, ParserFunctions, Wikimedia-production-error
Ammarpad renamed T278295: MergeHistory: Avoid querying master DB for the purpose of trivial message variation from MergeHistory should query master for the purpose of trivial message variation to MergeHistory: Avoid querying master DB for the purpose of trivial message variation.
Mar 24 2021, 9:56 AM · Patch-For-Review, MediaWiki-MergeHistory
Ammarpad created T278295: MergeHistory: Avoid querying master DB for the purpose of trivial message variation.
Mar 24 2021, 9:53 AM · Patch-For-Review, MediaWiki-MergeHistory
Ammarpad created T278293: MergeHistory message outputs unparsed HTML.
Mar 24 2021, 9:44 AM · Patch-For-Review, MediaWiki-MergeHistory

Mar 22 2021

Ammarpad reopened T252562: Error in "Page should be restorable" as "Open".

This is still happening

15:33:29 [0-1] AssertionError [ERR_ASSERTION] in "Page should be restorable"
15:33:29 Input A expected to strictly equal input B:
15:33:29 + expected - actual
15:33:29 
15:33:29 - 'BeforeEach-name-0.5544652739983722-Iñtërnâtiônàlizætiøn has been restored\n\nConsult the deletion log for a record of recent deletions and restorations.\n\nRetrieved from "http://127.0.0.1:9412/index.php/Special:Undelete"'
15:33:29 + 'BeforeEach-name-0.5544652739983722-Iñtërnâtiônàlizætiøn has been restored\n\nConsult the deletion log for a record of recent deletions and restorations.'
15:33:29 [0-1] FAILED in chrome - /tests/selenium/specs/page.js
Mar 22 2021, 5:27 PM · ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-extensions-ShortUrl, Browser-Tests
Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Mar 22 2021, 1:21 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms
Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Mar 22 2021, 1:20 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms
Ammarpad added a comment to T277601: EditHandler: Call to a member function getContent() on null.

The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.

Mar 22 2021, 6:18 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-REST-API, Wikimedia-production-error

Mar 21 2021

Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Mar 21 2021, 11:46 AM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms
Ammarpad added a comment to T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.

I ran this test in isolation with the evil hack given in T187581#4674890, both on PHP 7 and 8 but I cannot reproduce the failure. Maybe something has fixed elsewhere.

Mar 21 2021, 11:13 AM · MediaWiki-Debug-Logger, MediaWiki-Core-Tests
Ammarpad closed T233133: DefaultPreferencesFactoryTest:testIntvalFilter takes ~8s for a pretty trivial test for a single preference value, a subtask of T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min, as Resolved.
Mar 21 2021, 9:00 AM · Release-Engineering-Team (Next), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Patch-For-Review, Developer Productivity, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Tests, Continuous-Integration-Config
Ammarpad closed T233133: DefaultPreferencesFactoryTest:testIntvalFilter takes ~8s for a pretty trivial test for a single preference value as Resolved.
Mar 21 2021, 9:00 AM · MediaWiki-User-preferences, MediaWiki-Core-Tests
Ammarpad added a comment to T233133: DefaultPreferencesFactoryTest:testIntvalFilter takes ~8s for a pretty trivial test for a single preference value.

With PHP 8, it even takes less time (and less memory) consistently. Average is 2 seconds over 1000 runs.

MacBook:phpunit Ammar$ unit --filter testIntvalFilter includes/preferences/DefaultPreferencesFactoryTest.php
Using PHP 8.0.3
PHPUnit 8.5.14 by Sebastian Bergmann and contributors.
Mar 21 2021, 8:59 AM · MediaWiki-User-preferences, MediaWiki-Core-Tests

Mar 19 2021

Ammarpad added a comment to T277790: Reblocking IP range gives broken link (due to custom message on English Wikipedia).

This is English Wikipedia error from customization of this message. The original message does not even have a link.

<div class="alreadyblocked" id="alreadyblocked" style="color:red; font-weight:bold; font-size:96.75%;">[[User:$|$1]] ([[User talk:$1|talk]]• [[Special:Contributions/$1|contribs]]) is already blocked (<span class="plainlinks">[//en.wikipedia.org/w/index.php?title=Special:Log/block&page=User:$1 block log] • [//en.wikipedia.org/w/index.php?title=Special:IPBlockList&action=unblock&ip=$1&wpUnblockReason=unblock%20to%20change%20duration unblock]</span>) .</div>
Mar 19 2021, 6:25 AM · MediaWiki-Blocks, MediaWiki-User-management
Ammarpad raised the priority of T277809: MWException when setting protection date to year 9999 from Lowest to Needs Triage.

Ideally, it should not be possible for a user to be able to trigger exception at will

Mar 19 2021, 5:16 AM · MediaWiki-Page-protection

Mar 18 2021

Ammarpad closed T265665: MovePage::moveToInternal() should use Title::getArticleId() not Title::exists() as Resolved.
Mar 18 2021, 12:39 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-Page-rename, MediaWiki-Core-Hooks
Ammarpad added a comment to T277689: LanguageKk_cyrl->lastLetter: PHP Notice: Undefined offset: -1.

I believe, an empty string is being passed to {{GRAMMAR:}} magic word as the word to transform on whatever page is that

Mar 18 2021, 10:57 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Engineering, ParserFunctions, Wikimedia-production-error

Mar 17 2021

Ammarpad added a comment to T276133: Consider avoiding hardcoding integer sizes for blobs in abstract schema json.

I think we can do away with them by creating custom types for Blob, MediumBlob and maybe String type and then handling the numbers there. So in tables.json one will then only need to specify the type. We already do much more than that with custom types such as EnumType.

Mar 17 2021, 10:23 PM · MediaWiki-Installer
Ammarpad added a comment to T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".

The $mTempPath being null also caused T272328. But this possibility is still not documented

Mar 17 2021, 9:28 PM · Structured-Data-Backlog, Structured Data Engineering, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Uploading, Wikimedia-production-error
Ammarpad added a comment to T187491: ApiUpload throws MWException "No specifications provided to ArchivedFile constructor".

UploadBase::getTempFileSha1Base36() would fail and return false if $mTempPath is not yet set. This is the boolean that got passed to
ArchivedFile->__construct(NULL, integer, string, boolean),

Mar 17 2021, 9:24 PM · Structured-Data-Backlog, Structured Data Engineering, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Uploading, Wikimedia-production-error
Ammarpad closed T171391: Setting $wgPasswordResetRoutes to false still allows to go to Special:Preferences or Special:ChangePassword and reset the password as Resolved.

The documentation has been expanded a bit (although it's already correct).

Mar 17 2021, 4:14 PM · Documentation, MediaWiki-Configuration
Ammarpad added a comment to T171391: Setting $wgPasswordResetRoutes to false still allows to go to Special:Preferences or Special:ChangePassword and reset the password.

The premise of this task is invalid, but documentation can be improved. Already updated some parts here and here

Mar 17 2021, 4:01 PM · Documentation, MediaWiki-Configuration
Ammarpad closed T274900: $wgLogos DefaultSettings.php documentation mismatch as Resolved.
Mar 17 2021, 12:59 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MediaWiki-Configuration, Wikimedia-Site-requests, MediaWiki-Interface, Documentation
Ammarpad awarded T277459: Codesearch (Beta) not reachable a Like token.
Mar 17 2021, 8:30 AM · User-Ladsgroup, VPS-project-Codesearch
Ammarpad edited projects for T277606: Add noexternallanglinks state to action=info , added: MediaWiki-extensions-WikibaseClient; removed MediaWiki-Interface (actions).
Mar 17 2021, 5:34 AM · MediaWiki-extensions-WikibaseClient, Wikidata

Mar 16 2021

Ammarpad added a comment to T277332: Uncaught Error: Widget not found / Call to a member function getNsIndex() on null on CirrusSearch result page with internal error.

Reasonable chance this is because we are pulling ContLang from SearchConfig, ContLang was never configuration and might no longer be accessible that way.

Mar 16 2021, 12:56 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Discovery-Search (Current work), CirrusSearch, Wikimedia-production-error
Ammarpad updated the task description for T277459: Codesearch (Beta) not reachable.
Mar 16 2021, 6:27 AM · User-Ladsgroup, VPS-project-Codesearch
Ammarpad updated subscribers of T277459: Codesearch (Beta) not reachable.

Is this down completely? A day after (for me) it's still not working.

Mar 16 2021, 6:26 AM · User-Ladsgroup, VPS-project-Codesearch
Ammarpad added a comment to T277520: Allow extensions to specify immovable namespaces via extension.json.

I propose that it also be possible via extension.json when specifying namespaces, by adding a new property ismovable (defaulting to false).

There are only three namespaces with non-movable pages (per the task desc), which means the majority of namespaces are movable. So defaulting to false is not a good idea here.

Mar 16 2021, 5:58 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), User-DannyS712, MediaWiki-Configuration

Mar 15 2021

Ammarpad added a comment to T233133: DefaultPreferencesFactoryTest:testIntvalFilter takes ~8s for a pretty trivial test for a single preference value.

It seems this has changed

MacBook:tests Ammar$ php phpunit/phpunit.php --filter testIntvalFilter phpunit/includes/preferences/DefaultPreferencesFactoryTest.php
Using PHP 7.3.8
PHPUnit 8.5.14 by Sebastian Bergmann and contributors.
Mar 15 2021, 1:13 PM · MediaWiki-User-preferences, MediaWiki-Core-Tests
Ammarpad created T277459: Codesearch (Beta) not reachable.
Mar 15 2021, 12:52 PM · User-Ladsgroup, VPS-project-Codesearch

Mar 13 2021

Ammarpad added a comment to T277230: Migrating from 1.31.12 to 1.35.1 : error on populateContentTables.php.

The exception is intentionally thrown because of encountering missing content row just after its (supposed) insertion. I think we need to account for content rows that we are now skipping because of the BlobAccessException.

Mar 13 2021, 8:47 PM · MediaWiki-Maintenance-system
Ammarpad added a comment to T267313: Off-board from Release Engineering.

  • I'm a "member" in many milestones, but I don't know why

It's currently not possible to remove you from these groups, see T261642

Mar 13 2021, 8:33 PM · User-zeljkofilipin, Quality-and-Test-Engineering-Team (QTE)
Ammarpad added a comment to T277386: mw.config.get('debug') is not Boolean any more.

See T85805: ResourceLoader: Redesign how debug mode operates

Mar 13 2021, 6:26 PM · Performance-Team, MediaWiki-ResourceLoader

Mar 10 2021

Ammarpad updated the task description for T272199: Drop unsupported upgrade patch files and logic.
Mar 10 2021, 11:56 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms
Ammarpad updated the task description for T272199: Drop unsupported upgrade patch files and logic.
Mar 10 2021, 11:32 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms
Ammarpad added a comment to T254621: SqlBagOStuff::incr() fails with PostgreSQL.

The field has already been changed to TEXT but the issue still exists

Mar 10 2021, 10:12 AM · PostgreSQL, Platform Engineering, Wikimedia-Rdbms

Mar 9 2021

Ammarpad removed a project from T273978: Remove $wgPagePropsHaveSortkey: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).
Mar 9 2021, 10:44 AM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms
Ammarpad updated the task description for T272199: Drop unsupported upgrade patch files and logic.
Mar 9 2021, 6:10 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms

Mar 3 2021

Ammarpad added a comment to T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators.

We use title to construct the link, so a title is needed in the request. The links generated by the UI of history and diff pages both contain this parameter, so any link from there would work. I am not sure what tool is generating that URL without the title. The tool should be fixed. (I know the &title= is not required, but nevertheless, history/diff pages have it, so it not bad to ask whatever tool is that to also add it when generating that URL).

Mar 3 2021, 6:07 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Platform Team Workboards (External Code Reviews), MediaWiki-Page-deletion
Ammarpad placed T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators up for grabs.

The patch doesn't work here because it expects the user-provided title to be correct (it calls getArchivedRevisionRecord($oldid) on the PageArchive, which only looks up revisions for that page—the Main Page in Enterprisey's example, because the provided title is blank).

No, that's not the reason. The reason is a bug/old behavior from core T264765

Mar 3 2021, 5:40 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Platform Team Workboards (External Code Reviews), MediaWiki-Page-deletion

Feb 28 2021

Ammarpad added a comment to T247160: Add range support to resetAuthenticationThrottle.php.

@Reedy, T247162 has been merged since but the lib has not been updated in MediaWiki. So phan is failing for r583519 since it cannot find the method. When will this be updated?

When T248237: IPUtils >=2.0.0 test failures on MW core/https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/582528/ are resolved

Feb 28 2021, 9:26 AM · MediaWiki-Maintenance-system
Ammarpad closed T275960: Partially failed user suppression left revisions visible, with rev_deleted=0 as Invalid.
Feb 28 2021, 5:11 AM · Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralAuth, MediaWiki-Logevents, MediaWiki-User-management

Feb 20 2021

Ammarpad added a comment to T275261: title-invalid-characters error should be able to safely suggest a title.

Now that I've thought about it more, ideally we would do the ifexist check inside PHP, and then output a different message (e.g. title-invalid-characters-dym) if the fixed title does exist with a link using $3. Otherwise it would just use the default behavior. But this code is coming from MediaWikiTitleCodec which doesn't know whether titles exist or not.

I don't think the suggestion needs to bother about checking the title existence — just validity. If the page exists, that's fine, if it doesn't, normal flow of redlink will kick in. When you have "Download>", it's better to display redlink for "Download" than the present error message.

Feb 20 2021, 2:58 PM · MW-1.35-notes, MW-1.31-release-notes, MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), MediaWiki-General

Feb 17 2021

Ammarpad added a comment to T275067: CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImportFile).

@Krinkle, In my understanding, this error is not related to mediawiki core import-export feature, the error is from the file import feature of FileImporter extension. A recent User-related core change may play a role here, but even then that's likely unrelated to MediaWiki-Core-Snapshots since the extension is not using that logic.

Feb 17 2021, 9:59 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management, MediaWiki-Revision-backend, Move-Files-To-Commons, Release-Engineering-Team (Logspam), Wikimedia-production-error
Ammarpad added a project to T275067: CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImportFile): Move-Files-To-Commons.
Feb 17 2021, 9:47 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management, MediaWiki-Revision-backend, Move-Files-To-Commons, Release-Engineering-Team (Logspam), Wikimedia-production-error
Ammarpad removed a project from T275067: CannotCreateActorException: Cannot create an actor for a usable name that is not an existing user: … (via SpecialImportFile): MediaWiki-Core-Snapshots.
Feb 17 2021, 9:29 PM · Patch-For-Review, Platform Team Workboards (MW Expedition), MediaWiki-User-management, MediaWiki-Revision-backend, Move-Files-To-Commons, Release-Engineering-Team (Logspam), Wikimedia-production-error

Feb 16 2021

Ammarpad closed T267468: populateContentTables.php fails multiple times as Resolved.
Feb 16 2021, 12:52 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Platform Team Workboards (External Code Reviews), Platform Team Initiatives (MCR Schema Migration), MediaWiki-Maintenance-system
Ammarpad closed T274748: DBQuery error: Column 'rc_this_oldid' cannot be null as Resolved.
Feb 16 2021, 12:52 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Wikimedia-production-error, Growth-Team, MediaWiki-Recent-changes
Ammarpad closed T272637: ConvertibleTimestamp::getTimestamp: The timestamp cannot be represented in the specified format as Resolved.
Feb 16 2021, 12:51 PM · MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Wikimedia-Timestamp, User-brennen, Wikimedia-production-error

Feb 13 2021

Ammarpad updated the task description for T272199: Drop unsupported upgrade patch files and logic.
Feb 13 2021, 7:24 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms

Feb 12 2021

Ammarpad added a comment to T274591: "Failed assering that $jsonFilePath did not pass validation".

The error message is not complete here. There's '... is false' at the end. The full message should be something like

Failed asserting that {$exception->getMessage} is false
Feb 12 2021, 11:35 AM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-Configuration

Feb 11 2021

mmodell awarded T274526: Ranges in block logs can't be clicked to view contributions anymore a Yellow Medal token.
Feb 11 2021, 8:06 PM · Regression, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-Blocks, MediaWiki-Logevents
Ammarpad closed T274526: Ranges in block logs can't be clicked to view contributions anymore as Resolved.
Feb 11 2021, 7:53 PM · Regression, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-Blocks, MediaWiki-Logevents
Ammarpad claimed T274526: Ranges in block logs can't be clicked to view contributions anymore.
Feb 11 2021, 3:36 PM · Regression, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-Blocks, MediaWiki-Logevents
Ammarpad added a comment to T274526: Ranges in block logs can't be clicked to view contributions anymore.

UserNameUtils service and the underlying IPUtils::isValid() method do not consider IP range as a valid IP address, so they must be handled separately if something is allowed for IP OR IP range

Feb 11 2021, 2:17 PM · Regression, MW-1.36-notes (1.36.0-wmf.31; 2021-02-16), MediaWiki-Blocks, MediaWiki-Logevents

Feb 10 2021

Ammarpad merged T274405: LinkBatch::addResultToCache: encountered invalid title ErrorException into T272635: LinkBatch::addResultToCache: encountered invalid title.
Feb 10 2021, 9:58 PM · Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), User-brennen, MediaWiki-MergeHistory, Wikimedia-production-error
Ammarpad merged task T274405: LinkBatch::addResultToCache: encountered invalid title ErrorException into T272635: LinkBatch::addResultToCache: encountered invalid title.
Feb 10 2021, 9:58 PM · Release-Engineering-Team (Logspam), MediaWiki-MergeHistory, Wikimedia-production-error
Ammarpad added a comment to T274402: Fix typo in description of train deployments tasks.

https://phabricator.wikimedia.org/source/phab-extensions/browse/wmf%252Fstable/src/customfields/ReleaseDetailsCustomField.php

Feb 10 2021, 9:12 PM · Patch-For-Review, User-DannyS712, Phabricator
Ammarpad placed T235589: Fatal exception on Special:MovePage: "Failed to create null revision while moving page ID 123 to Draft:Foo" up for grabs.

Reopening since we use the task ID to track in logstash. This is still happening although the message has changed a bit. 225 times in 30 days:

Example:
ReqID: YCOC0jTBsMxjFfgbLAbFNAAAARU
Message: MWException: Failed to create null revision while moving page ID ###### to XXXXXX (page ID #####)

I guess the ##### are integers, can you post them here?. I want to know if they are equal

Feb 10 2021, 5:31 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, User-brennen, MediaWiki-Revision-backend, Wikimedia-production-error
Ammarpad merged task T269425: Logs are not sent if wiki throws "Uncaught ExtensionDependencyError" into T177735: Error handling is set up too late to catch extension registration errors.
Feb 10 2021, 5:26 PM · MediaWiki-Configuration, MediaWiki-Debug-Logger, User-RhinosF1
Ammarpad merged T269425: Logs are not sent if wiki throws "Uncaught ExtensionDependencyError" into T177735: Error handling is set up too late to catch extension registration errors.
Feb 10 2021, 5:26 PM · MediaWiki-Configuration, MediaWiki-Debug-Logger
Ammarpad raised the priority of T114532: MWDebug toolbar log is empty when Monolog is enabled from Low to Needs Triage.
Feb 10 2021, 4:48 PM · Patch-For-Review, MediaWiki-Debug-Logger
Ammarpad merged T248448: Debug toolbar does not show queries or debug log if $wgMWLoggerDefaultSpi is set into T114532: MWDebug toolbar log is empty when Monolog is enabled.
Feb 10 2021, 4:48 PM · Patch-For-Review, MediaWiki-Debug-Logger
Ammarpad merged task T248448: Debug toolbar does not show queries or debug log if $wgMWLoggerDefaultSpi is set into T114532: MWDebug toolbar log is empty when Monolog is enabled.
Feb 10 2021, 4:48 PM · MediaWiki-Debug-Logger
Ammarpad removed a project from T273603: Revisit tests marked as broken for a very long time: Patch-For-Review.
Feb 10 2021, 2:49 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MediaWiki-Core-Tests
Ammarpad merged T270802: Pages transcluding Special:PrefixIndex are displayed in Legacy Vector into T269860: Transcluding {{Special:ListFiles/$username}} on any page overrides the skin selected by the viewer in Preferences, makes it Vector-only.
Feb 10 2021, 1:59 PM · Beta-Cluster-reproducible, MediaWiki-General
Ammarpad merged task T270802: Pages transcluding Special:PrefixIndex are displayed in Legacy Vector into T269860: Transcluding {{Special:ListFiles/$username}} on any page overrides the skin selected by the viewer in Preferences, makes it Vector-only.
Feb 10 2021, 1:59 PM · Readers-Web-Backlog, Desktop Improvements
Ammarpad added a comment to T270802: Pages transcluding Special:PrefixIndex are displayed in Legacy Vector.

This seems to be not specific to Vector but default skin, and it's probably a core issue per T269860

Feb 10 2021, 1:58 PM · Readers-Web-Backlog, Desktop Improvements
Ammarpad renamed T272199: Drop unsupported upgrade patch files and logic from Drop unsupported patch files from upgrade to Drop unsupported upgrade patch files and logic.
Feb 10 2021, 1:27 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms
Ammarpad updated the task description for T272199: Drop unsupported upgrade patch files and logic.
Feb 10 2021, 1:24 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Patch-For-Review, MediaWiki-Installer, Wikimedia-Rdbms

Feb 9 2021

Ammarpad closed T273603: Revisit tests marked as broken for a very long time as Resolved.
Feb 9 2021, 7:37 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), MediaWiki-Core-Tests
Ammarpad closed T218688: Flaky test Monolog\CeeFormatterTest::testV1 as Resolved.
Feb 9 2021, 7:02 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, User-fgiunchedi, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Debug-Logger

Feb 8 2021

Ammarpad added a comment to T218688: Flaky test Monolog\CeeFormatterTest::testV1.

I have checked this while working on T273603 and I think there's an easy way to fix this.

Feb 8 2021, 11:48 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, User-fgiunchedi, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Debug-Logger
Ammarpad added a comment to T218688: Flaky test Monolog\CeeFormatterTest::testV1.
'datetime' => new DateTimeImmutable($this->microsecondTimestamps, $this->timezone),

It seems microsecondTimestamps is a boolean, but DateTimeImmutable::__construct accepts a parsed string (defaulting to "now"). Anyway, assuming that somehow works and actually creates a timestamp. I guess this is indeed where the time is decided and there's no way to override or inject that?

DateTimeImmutable is a class in Monolog/ namespace. It's not passing the $microsecondTimestamps prop to native DateTimeImmutable, which would have resulted in fatal exception

Feb 8 2021, 11:21 PM · MW-1.36-notes (1.36.0-wmf.30; 2021-02-09), Patch-For-Review, User-fgiunchedi, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-Debug-Logger
Ammarpad closed T241115: transcode-reset and transcode-status should be included in a grant, a subtask of T142308: Most extensions which add a user right should also add or extend a grant, as Resolved.
Feb 8 2021, 10:03 AM · good first task, Epic, MediaWiki-extensions-General, MediaWiki-Authentication-and-authorization, MediaWiki-extensions-OAuth