Page MenuHomePhabricator

Ammarpad
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 9:01 PM (321 w, 2 d)
Availability
Available
IRC Nick
Ammarpad
LDAP User
Ammarpad
MediaWiki User
Ammarpad [ Global Accounts ]

Long-time Wikimedian and MediaWiki developer

Recent Activity

Fri, Dec 1

Ammarpad added a comment to T345793: Broken protect history link causing database errors for PostgreSQL backend.

@Ammarpad Add me as reviewer, I'll take care of it.

Fri, Dec 1, 7:35 AM · MediaWiki-libs-Rdbms, PostgreSQL

Thu, Nov 30

Ammarpad updated the task description for T345793: Broken protect history link causing database errors for PostgreSQL backend.
Thu, Nov 30, 9:09 AM · MediaWiki-libs-Rdbms, PostgreSQL
Ammarpad merged T352359: PostgreSQL timestamp comparison throws exception with user input into T345793: Broken protect history link causing database errors for PostgreSQL backend.
Thu, Nov 30, 9:07 AM · MediaWiki-libs-Rdbms, PostgreSQL
Ammarpad merged task T352359: PostgreSQL timestamp comparison throws exception with user input into T345793: Broken protect history link causing database errors for PostgreSQL backend.
Thu, Nov 30, 9:06 AM · MediaWiki-libs-Rdbms, PostgreSQL
Ammarpad added a comment to T352359: PostgreSQL timestamp comparison throws exception with user input.

Already reported at T345793 which I intended to fix but forgot. My approach in the uncommited change was to convert the user-provided offset to DB timestamp and proceed if it works, otherwsise return no result (as does MySQL currently). That seems easier for the short term, but changing the field would be more effective long-term.

Thu, Nov 30, 9:06 AM · MediaWiki-libs-Rdbms, PostgreSQL
Ammarpad closed T352175: Uncaught Error: Widget not found on voting page as Resolved.
Thu, Nov 30, 6:54 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), JavaScript, MediaWiki-extensions-SecurePoll

Wed, Nov 29

Ammarpad added a comment to T352310: Unknown column 'bl_timestamp' in 'where clause'.

bl_timestamp is field alias and WHERE clause can be evaluated before the alias is created

Wed, Nov 29, 6:16 PM · Community-Tech (CommTech-Kanban), MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Multiblocks, MediaWiki-Blocks, Beta-Cluster-reproducible
Ammarpad added a project to T352309: Gerrit maintenance bot should throttle uploading patches: LSC.
Wed, Nov 29, 5:58 PM · LSC
Ammarpad added a comment to T310909: SecurePoll (votewiki) should import translations from Meta-Wiki.

On the translate subpage, if $wgSecurePollTranslationImportSourceUrl is set, there's currently a message that presumably claims anyone can 'import translations'

Wed, Nov 29, 3:52 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MediaWiki-extensions-SecurePoll

Tue, Nov 28

Ammarpad awarded T351972: Request membership in PageTriage group (+2) for Sohom Datta a Like token.
Tue, Nov 28, 4:52 PM · PageTriage, Gerrit-Privilege-Requests
Ammarpad committed rTAWR975e89994a66: Avoid deprecation warning for static properties (authored by Ammarpad).
Avoid deprecation warning for static properties
Tue, Nov 28, 3:34 PM
Ammarpad closed T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook, a subtask of T314099: PHP 8.2: Dynamic property creation is deprecated, as Resolved.
Tue, Nov 28, 2:45 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.35-notes, MW-1.38-notes, MW-1.37-notes, MediaWiki-Parser, MediaWiki-Core-Tests, MediaWiki-User-management, PHP 8.2 support
Ammarpad closed T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook as Resolved.
Tue, Nov 28, 2:45 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), PHP 8.2 support, ConfirmEdit (CAPTCHA extension), MediaWiki-Action-API
Ammarpad updated the task description for T352085: Make PHP 8.2 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries).
Tue, Nov 28, 2:45 PM · PHP 8.2 support
Ammarpad created T352175: Uncaught Error: Widget not found on voting page.
Tue, Nov 28, 1:25 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), JavaScript, MediaWiki-extensions-SecurePoll
Ammarpad reopened T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook, a subtask of T314099: PHP 8.2: Dynamic property creation is deprecated, as In Progress.
Tue, Nov 28, 10:49 AM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.35-notes, MW-1.38-notes, MW-1.37-notes, MediaWiki-Parser, MediaWiki-Core-Tests, MediaWiki-User-management, PHP 8.2 support
Ammarpad reopened T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook as "In Progress".
Tue, Nov 28, 10:49 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), PHP 8.2 support, ConfirmEdit (CAPTCHA extension), MediaWiki-Action-API
Ammarpad closed T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook as Resolved.
Tue, Nov 28, 10:49 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), PHP 8.2 support, ConfirmEdit (CAPTCHA extension), MediaWiki-Action-API
Ammarpad closed T326479: Replace dynamic property Status::$apiHookResult used by ApiEditPage and EditFilterMergedContentHook, a subtask of T314099: PHP 8.2: Dynamic property creation is deprecated, as Resolved.
Tue, Nov 28, 10:48 AM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MW-1.39-notes, MW-1.35-notes, MW-1.38-notes, MW-1.37-notes, MediaWiki-Parser, MediaWiki-Core-Tests, MediaWiki-User-management, PHP 8.2 support
Ammarpad claimed T352060: Wikimedia::TestingAccessWrapper raises a deprecation warning in PHP 8.3.
Tue, Nov 28, 6:57 AM · MediaWiki-Core-Tests, PHP 8.3 support

Mon, Nov 27

Ammarpad closed T349973: MediaWiki:Gadget-modrollback.js gadget blocks clicking Cancel and Rollback links in Rollback confirmation in Special:Preferences on ckb.wikipedia as Invalid.
Mon, Nov 27, 7:01 PM · MediaWiki-Core-Preferences

Thu, Nov 23

Ammarpad merged task T351769: Disabling WebAuthn could fail with Fatal Exception of type "TypeError" into T351806: TypeError: Argument 1 passed to MediaWiki\Extension\WebAuthn\HTMLForm\WebAuthnDisableForm::authenticate() must be of the type array, string given.
Thu, Nov 23, 2:51 PM · Wikimedia-production-error, MediaWiki-extensions-OATHAuth
Ammarpad merged T351769: Disabling WebAuthn could fail with Fatal Exception of type "TypeError" into T351806: TypeError: Argument 1 passed to MediaWiki\Extension\WebAuthn\HTMLForm\WebAuthnDisableForm::authenticate() must be of the type array, string given.
Thu, Nov 23, 2:51 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), MediaWiki-extensions-OATHAuth, Wikimedia-production-error

Sat, Nov 18

Ammarpad merged task T351580: Creation of dynamic property Wikimedia\Rdbms\DatabaseMySQL::$_originalTablePrefix is deprecated into T326466: Rework database setup in integration test to avoid dynamic properties under php8.2.
Sat, Nov 18, 7:28 AM · MediaWiki-Core-Tests, MediaWiki-libs-Rdbms
Ammarpad merged T351580: Creation of dynamic property Wikimedia\Rdbms\DatabaseMySQL::$_originalTablePrefix is deprecated into T326466: Rework database setup in integration test to avoid dynamic properties under php8.2.
Sat, Nov 18, 7:28 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), PHP 8.2 support, MediaWiki-Core-Tests

Sun, Nov 12

Ammarpad added a comment to T351024: When requesting content, drvlimit/adrlimit/arvlimit/rvlimit is 500, not 5000.

It depends on how you're making the request.

Sun, Nov 12, 8:06 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Documentation, MediaWiki-Action-API

Thu, Nov 9

Ammarpad closed T243660: Error message Wikibase-validator-url-scheme-missing is shown in content instead of user lanuage as Resolved.
Thu, Nov 9, 7:15 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), [DEPRECATED] wdwb-tech, I18n, WikibaseMediaInfo, SDC General, Wikidata

Nov 8 2023

Ammarpad merged T350741: Registration date for some users is "null" into T24097: Populate user.user_registration DB field on every wiki.
Nov 8 2023, 2:29 PM · Wikimedia-Site-requests
Ammarpad merged task T350741: Registration date for some users is "null" into T24097: Populate user.user_registration DB field on every wiki.
Nov 8 2023, 2:28 PM · Wikimedia-database-issue (Bad data), Turkish-Sites

Nov 6 2023

Ammarpad added a comment to T350535: Watchlist e-mails for deleted pages contain non-working links.

In some cases that's even desirable, see T257966: URL shall be terminated by %2E or _ if page name ends with dot

Nov 6 2023, 4:38 PM · Patch-For-Review, Growth-Team, MediaWiki-Watchlist
Ammarpad added a comment to T349431: MergeHistoryTest testSourceUpdateWithRedirectSupport doesn't test what it is supposed to.

doesn't test what it is supposed to

So what should it test for and what is it testing now?

Nov 6 2023, 3:43 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), MediaWiki-MergeHistory, MediaWiki-Core-Tests

Nov 4 2023

Ammarpad merged T350518: Can't access talk page history on mobile into T350515: Last-modified bar in Minerva is hidden on small screens.
Nov 4 2023, 11:03 AM · Verified, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3), MinervaNeue
Ammarpad merged task T350518: Can't access talk page history on mobile into T350515: Last-modified bar in Minerva is hidden on small screens.
Nov 4 2023, 11:03 AM · Mobile

Nov 3 2023

Ammarpad added a comment to T350440: Regression: Duplicate diff navigation links on mobile.

MobileFrontend already provides its own navigation links and now core navigation links are also being shown

Nov 3 2023, 5:44 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Regression, MediaWiki-Page-diffs, Web-Team-Backlog (Needs Prioritization (Tech)), MobileFrontend
Ammarpad added a comment to T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.

Seems it's still happening https://gerrit.wikimedia.org/r/c/mediawiki/core/+/971331

Nov 3 2023, 1:54 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MobileFrontend (MobileFrontend (Editor)), Editing-team, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), Browser-Tests, MinervaNeue
Ammarpad added a comment to T312888: PHP Warning: fopen(): Filename cannot be empty.

There's uptick of these warnings. In PHP 8 they will be elevated to ValueError exception

Nov 3 2023, 10:32 AM · Structured Data Engineering, Structured-Data-Backlog, MediaWiki-Uploading, Wikimedia-production-error
Ammarpad merged T350455: Unable to upload a specific file via UploadWizard into T328872: Commons: UploadChunkFileException: Error storing file: backend-fail-internal; local-swift-codfw.
Nov 3 2023, 10:02 AM · API Platform, MediaWiki-File-management, MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), Unstewarded-production-error, MediaWiki-Uploading, Wikimedia-production-error, SRE-swift-storage, Commons
Ammarpad merged task T350455: Unable to upload a specific file via UploadWizard into T328872: Commons: UploadChunkFileException: Error storing file: backend-fail-internal; local-swift-codfw.
Nov 3 2023, 10:02 AM · Commons, MediaWiki-File-management, Wikimedia-production-error

Nov 2 2023

Ammarpad merged T350400: PHP Notice: Trying to get property 'identifiers' of non-object into T349347: MathRestbaseInterface: PHP Notice: Trying to get property '[property]' of non-object.
Nov 2 2023, 3:36 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), User-Physikerwelt, RESTBase, Editing-team, User-brennen, Mathoid, Wikimedia-production-error, Math
Ammarpad merged task T350400: PHP Notice: Trying to get property 'identifiers' of non-object into T349347: MathRestbaseInterface: PHP Notice: Trying to get property '[property]' of non-object.
Nov 2 2023, 3:36 PM · MediaWiki-REST-API, Math, Wikimedia-production-error
Ammarpad added a comment to T313775: MinervaNeue "Wikitext Editor.Closing editor (overlay button)" test is flaky.

@Jdlrobson do you think the fix in T348539 will allow re-enabling this test?

Nov 2 2023, 8:06 AM · MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), User-zeljkofilipin, MinervaNeue

Nov 1 2023

Ammarpad claimed T327007: 'file' HTMLForm inputs don't process required=>true correctly.
Nov 1 2023, 5:32 PM · good first task, MediaWiki-HTMLForm
Ammarpad merged T350225: Wikitext Editor Closing editor (browser button): waitUntil condition timed out after 5000ms into T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.
Nov 1 2023, 11:00 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MobileFrontend (MobileFrontend (Editor)), Editing-team, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), Browser-Tests, MinervaNeue
Ammarpad merged task T350225: Wikitext Editor Closing editor (browser button): waitUntil condition timed out after 5000ms into T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.
Nov 1 2023, 10:59 AM · ci-test-error (WMF-deployed Build Failure), MinervaNeue, Browser-Tests

Oct 31 2023

Ammarpad created T350104: Incorrect message when using Gadget definition namespace .
Oct 31 2023, 7:45 AM · MediaWiki-extensions-Gadgets
Ammarpad added a comment to T327007: 'file' HTMLForm inputs don't process required=>true correctly.

an extension that is currently broken as a result.

Which extension? I can't reproduce the issue

Oct 31 2023, 7:01 AM · good first task, MediaWiki-HTMLForm
Ammarpad merged T349676: String stored as number triggers exception into T301632: Integer search terms cause error.
Oct 31 2023, 6:49 AM · Performance-Team, AhoCorasick
Ammarpad merged task T349676: String stored as number triggers exception into T301632: Integer search terms cause error.
Oct 31 2023, 6:49 AM · AhoCorasick
Ammarpad added a comment to T349676: String stored as number triggers exception.

Thanks, this has been fixed in T301632

Oct 31 2023, 6:49 AM · AhoCorasick

Oct 30 2023

Ammarpad claimed T350046: Create a new user group (trusteduser) on hiwiki.
Oct 30 2023, 10:04 PM · Hindi-Sites, Wikimedia-Site-requests
Ammarpad added a comment to T349676: String stored as number triggers exception.

@Xiaotai99 Please copy the complete exception trace and add it to this task.

Oct 30 2023, 6:41 PM · AhoCorasick
Ammarpad added a comment to T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.

There's also recent repeated failure in Math repo because of this. It seems no one is interested in fixing it. I think it should be disabled like the other test in the suite T313775 which was disabled with even lower failure rate.

Oct 30 2023, 4:43 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MobileFrontend (MobileFrontend (Editor)), Editing-team, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), Browser-Tests, MinervaNeue
Ammarpad added a comment to T349973: MediaWiki:Gadget-modrollback.js gadget blocks clicking Cancel and Rollback links in Rollback confirmation in Special:Preferences on ckb.wikipedia.

@Aram, on which wiki?

Oct 30 2023, 12:18 PM · MediaWiki-Core-Preferences
Ammarpad merged T349995: String stored as number triggers exception into T349676: String stored as number triggers exception.
Oct 30 2023, 9:17 AM · AhoCorasick
Ammarpad merged task T349995: String stored as number triggers exception into T349676: String stored as number triggers exception.
Oct 30 2023, 9:17 AM · AhoCorasick

Oct 29 2023

Ammarpad updated the task description for T298334: Validations for gadget definitions.
Oct 29 2023, 4:42 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), MediaWiki-extensions-Gadgets
Ammarpad added a project to T349963: Diff does not accurately show deleted text: wikidiff2.
Oct 29 2023, 3:05 PM · wikidiff2, MediaWiki-Page-diffs

Oct 26 2023

Ammarpad merged T349794: Timeless: null warning for array_map and implode into T349747: PHP Notice: Undefined index: normal.
Oct 26 2023, 11:51 AM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Timeless, Wikimedia-production-error
Ammarpad merged task T349794: Timeless: null warning for array_map and implode into T349747: PHP Notice: Undefined index: normal.
Oct 26 2023, 11:51 AM · Timeless, Wikimedia-production-error

Oct 25 2023

Ammarpad claimed T349726: "Revision as of" on diff links to incorrect target.
Oct 25 2023, 4:21 PM · MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Regression, MediaWiki-Page-diffs

Oct 24 2023

Ammarpad merged task T349574: Frequently failing browser test: "Wikitext Editor Closing editor" in MinervaNeue into T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.
Oct 24 2023, 2:05 PM · MinervaNeue, ci-test-error (WMF-deployed Build Failure)
Ammarpad merged T349574: Frequently failing browser test: "Wikitext Editor Closing editor" in MinervaNeue into T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.
Oct 24 2023, 2:05 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MobileFrontend (MobileFrontend (Editor)), Editing-team, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), Browser-Tests, MinervaNeue
Ammarpad merged T349616: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.1/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314 into T345319: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314.
Oct 24 2023, 1:43 PM · Patch-For-Review, HtmlFormatter, MediaWiki-Parser, Discovery-Search, CirrusSearch, Wikimedia-production-error
Ammarpad merged task T349616: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.1/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314 into T345319: TypeError: Argument 1 passed to HtmlFormatter\HtmlFormatter::onHtmlReady() must be of the type string, null given, called in /srv/mediawiki/php-1.41.0-wmf.24/vendor/wikimedia/html-formatter/src/HtmlFormatter.php on line 314.
Oct 24 2023, 1:42 PM · Wikimedia-production-error

Oct 19 2023

Ammarpad updated subscribers of T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.

This is happening at greater frequency now, adding @zeljkofilipin who will know better

Oct 19 2023, 8:51 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MobileFrontend (MobileFrontend (Editor)), Editing-team, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), Browser-Tests, MinervaNeue
Ammarpad added a comment to T348539: Slow connection warning in editor appearing in Selenium test: Error in "Wikitext Editor.Closing editor (browser button)" Error: waitUntil condition timed out after 5000ms.
Oct 19 2023, 8:45 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MobileFrontend (MobileFrontend (Editor)), Editing-team, Patch-For-Review, ci-test-error (WMF-deployed Build Failure), Browser-Tests, MinervaNeue
Ammarpad added a project to T349336: BotPasswords + Toolforge combination causing daily "login from new device" warning emails: MediaWiki-extensions-LoginNotify.
Oct 19 2023, 7:05 PM · Community-Tech, MediaWiki-extensions-LoginNotify, MediaWiki-Platform-Team, Toolforge, MediaWiki-Core-AuthManager
Ammarpad merged T349307: Internal error on uploading a replacement image into T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".
Oct 19 2023, 4:07 PM · Structured-Data-Backlog, Structured Data Engineering, Multimedia, MediaWiki-Uploading, Wikimedia-production-error
Ammarpad merged task T349307: Internal error on uploading a replacement image into T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".
Oct 19 2023, 4:06 PM · Commons, MediaWiki-File-management, Wikimedia-production-error
Ammarpad merged T347083: UploadStashFileNotFoundException: Key "[key]" not found in stash. into T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".
Oct 19 2023, 4:02 PM · Structured-Data-Backlog, Structured Data Engineering, Multimedia, MediaWiki-Uploading, Wikimedia-production-error
Ammarpad merged task T347083: UploadStashFileNotFoundException: Key "[key]" not found in stash. into T204827: Special:Upload responds with UploadStashFileNotFoundException "Key .. not found in stash".
Oct 19 2023, 4:02 PM · User-brennen, MediaWiki-Uploading, Wikimedia-production-error

Oct 17 2023

Ammarpad closed T346332: Installer generates incorrect wgDefaultSkin for MinervaNeue as Resolved.
Oct 17 2023, 7:23 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MediaWiki-Installer
Ammarpad added a comment to T346332: Installer generates incorrect wgDefaultSkin for MinervaNeue.

does this need back-porting to REL1_40?

done

Oct 17 2023, 6:02 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MediaWiki-Installer

Oct 16 2023

Ammarpad updated the task description for T348973: Error: Call to a member function getKey() on null.
Oct 16 2023, 4:14 PM · User-Physikerwelt, MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), RESTBase, Wikimedia-production-error, Math
Ammarpad renamed T348973: Error: Call to a member function getKey() on null from Fatal exception of type "Error" with {{#tag:chem}} to Error: Call to a member function getKey() on null.
Oct 16 2023, 4:09 PM · User-Physikerwelt, MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), RESTBase, Wikimedia-production-error, Math
Ammarpad added a comment to T348934: PushAll fails MediaWiki API structure tests.

@Ammarpad Thanks. Do you have an example in another extension?

See https://www.mediawiki.org/w/api.php?action=help&modules=shortenurl. The url parameter has description, which is defined at UrlShortener/i18n/api/en.json#9

How can I check if it's fixed in local?

Visit api.php?action=help&modules=pushallinfo locally. You'll currently see something like

Oct 16 2023, 12:39 PM · PushAll
Ammarpad added a comment to T348934: PushAll fails MediaWiki API structure tests.

This is due to missing API parameter description messages.

Oct 16 2023, 11:06 AM · PushAll

Oct 14 2023

Ammarpad added a comment to T348891: Sitenotice reappears after clicking the edit-button.

Please add browser and version. I suspect this is a duplicate of T277904

Oct 14 2023, 1:28 PM · DismissableSiteNotice
Ammarpad added a project to T277904: Can't properly dismiss Sitenotice in Firefox: Browser-Support-Firefox.
Oct 14 2023, 1:28 PM · Browser-Support-Firefox, DismissableSiteNotice

Oct 12 2023

Ammarpad closed T348040: Migrate hook VectorSearchResourceLoaderConfig to new hook system, a subtask of T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system, as Resolved.
Oct 12 2023, 10:04 AM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), MW-1.39-notes (1.39.0-wmf.27; 2022-08-29), MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General
Ammarpad closed T348040: Migrate hook VectorSearchResourceLoaderConfig to new hook system as Resolved.
Oct 12 2023, 10:03 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Platform Team Initiatives (New Hook System), Desktop Improvements (Vector 2022)

Oct 11 2023

Ammarpad closed T347721: 403 error when using MediaWiki REST API to `compare` revisions as Resolved.
Oct 11 2023, 7:20 PM · MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), API Platform, MediaWiki-REST-API

Oct 10 2023

Ammarpad added a comment to T348572: Wrong font size in OOUI dropdowns in Vector.

Probably more fallout from T345766. See T348530

Oct 10 2023, 7:30 PM · Verified, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 1), Patch-For-Review, Regression, Desktop Improvements (Vector 2022), Vector (legacy skin)

Oct 9 2023

Ammarpad added a project to T348451: InvalidArgumentException: WikiPage constructed on a Title that cannot exist as a page: Special:MyLanguage/Main Page: MediaWiki-Email.

Likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/935761, which does not have associated phab task.

Oct 9 2023, 2:37 PM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MediaWiki-Email, MediaWiki-General, Wikimedia-production-error
Ammarpad created T348451: InvalidArgumentException: WikiPage constructed on a Title that cannot exist as a page: Special:MyLanguage/Main Page.
Oct 9 2023, 2:03 PM · MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MediaWiki-Email, MediaWiki-General, Wikimedia-production-error
Ammarpad merged T348417: Commons updating video: Fatal exception of type "Wikimedia\Rdbms\DBUnexpectedError" into T348375: Commons removal of last remaining caption: Caught exception of type Wikimedia\Rdbms\DBUnexpectedError.
Oct 9 2023, 1:44 PM · MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), TimedMediaHandler-Transcode, Wikimedia-production-error, Structured-Data-Backlog
Ammarpad merged task T348417: Commons updating video: Fatal exception of type "Wikimedia\Rdbms\DBUnexpectedError" into T348375: Commons removal of last remaining caption: Caught exception of type Wikimedia\Rdbms\DBUnexpectedError.
Oct 9 2023, 1:44 PM · TimedMediaHandler-Transcode, Wikimedia-production-error

Oct 6 2023

Ammarpad closed T347814: Enable wgMinervaEnableSiteNotice for newiki as Resolved.
Oct 6 2023, 9:52 PM · Wikimedia-Site-requests

Oct 5 2023

Ammarpad created T348283: Hide Special pages that do not have default form or provide one.
Oct 5 2023, 9:35 PM · Campaign-Tools, CampaignEvents
Ammarpad merged T196861: Using Special:MyLanguage to access a page that includes a #redirect only shows a blank page into T164357: Let Special:MyLanguage be used as a redirect target.
Oct 5 2023, 9:15 PM · MediaWiki-Redirects, MediaWiki-Internationalization, User-Nikerabbit
Ammarpad merged task T196861: Using Special:MyLanguage to access a page that includes a #redirect only shows a blank page into T164357: Let Special:MyLanguage be used as a redirect target.
Oct 5 2023, 9:14 PM · MediaWiki-Internationalization, MediaWiki-Special-pages
Ammarpad added a comment to T345737: [[Special:MyLanguage/Special:MyLanguage/Something]] leads to a blank page.

This task (just like T196861) is also duplicate of T164357 (which is the oldest task).

Oct 5 2023, 9:12 PM · MediaWiki-Special-pages
Ammarpad added a comment to T196861: Using Special:MyLanguage to access a page that includes a #redirect only shows a blank page.

This is essentially the same issue as T164357

Oct 5 2023, 9:06 PM · MediaWiki-Internationalization, MediaWiki-Special-pages
Ammarpad added a comment to T164357: Let Special:MyLanguage be used as a redirect target.

This redirection is prevented by $wgDisableHardRedirects, which is true on all Wikimedia wikis save DonateWiki.

Oct 5 2023, 8:57 PM · MediaWiki-Redirects, MediaWiki-Internationalization, User-Nikerabbit
Ammarpad closed T344912: MediaWiki fails to send email for users with multibyte characters in their name as Resolved.
Oct 5 2023, 6:24 PM · MW-1.35-notes, MW-1.40-notes, MW-1.39-notes, MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), MW-1.39-release, MW-1.40-release, MW-1.35-release, I18n, MediaWiki-Email
Ammarpad removed a project from T347814: Enable wgMinervaEnableSiteNotice for newiki: Community-consensus-needed.
Oct 5 2023, 6:24 PM · Wikimedia-Site-requests

Oct 4 2023

Ammarpad added a comment to T346332: Installer generates incorrect wgDefaultSkin for MinervaNeue.

See T164408. Apparently that did not happen. So it needs special casing in the installer.

Oct 4 2023, 8:41 PM · MW-1.40-notes, MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), MediaWiki-Installer
Jdlrobson awarded T348040: Migrate hook VectorSearchResourceLoaderConfig to new hook system a Love token.
Oct 4 2023, 3:03 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Platform Team Initiatives (New Hook System), Desktop Improvements (Vector 2022)
Ammarpad claimed T348040: Migrate hook VectorSearchResourceLoaderConfig to new hook system.
Oct 4 2023, 10:45 AM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Platform Team Initiatives (New Hook System), Desktop Improvements (Vector 2022)

Oct 2 2023

Ammarpad updated subscribers of T347814: Enable wgMinervaEnableSiteNotice for newiki.

I actually don't think this requires any community consensus. Why are notices selectively hidden? I believe wgMinervaEnableSiteNotice was supposed to be temporary flag. If a community doesn not want to (for whatever reason) show notices on mobile there's already nomobile class which I believe works.

Oct 2 2023, 10:02 AM · Wikimedia-Site-requests