Page MenuHomePhabricator

Ammarpad
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 9:01 PM (159 w, 2 d)
Availability
Available
IRC Nick
Ammarpad
LDAP User
Ammarpad
MediaWiki User
Ammarpad [ Global Accounts ]

Open source enthusiast, mathematics buff.

Recent Activity

Yesterday

Ammarpad added a comment to T266871: Forbid use of class ReflectionObject and suggest use of TestingAccessWrapper::newFromObject instead.

What's the argument against?, I mean what's the problem of currently using reflection object directly where convenient? (These are only used, or generally allowed only in tests I believe).

Fri, Oct 30, 2:15 PM · MediaWiki-Codesniffer
Ammarpad updated the task description for T257183: Make SpecialMuteModifyFormFields hook to not pass the entire special page.
Fri, Oct 30, 12:34 PM · Patch-For-Review, good first task, MediaWiki-Special-pages
Ammarpad added a project to T266087: Echo should unset user-to-user email option when email features are disabled.: good first task.
Fri, Oct 30, 7:08 AM · good first task, Growth-Team, Notifications
Ammarpad updated the task description for T266850: CategoryChangesAsRdfTest::testCategorization: Failed asserting that two strings are equal..
Fri, Oct 30, 1:19 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Wikidata-Query-Service, MediaWiki-General, ci-test-error (WMF-deployed Build Failure)
Ammarpad updated the task description for T266850: CategoryChangesAsRdfTest::testCategorization: Failed asserting that two strings are equal..
Fri, Oct 30, 12:03 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Wikidata-Query-Service, MediaWiki-General, ci-test-error (WMF-deployed Build Failure)

Thu, Oct 29

Ammarpad triaged T266850: CategoryChangesAsRdfTest::testCategorization: Failed asserting that two strings are equal. as High priority.
Thu, Oct 29, 11:57 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Wikidata-Query-Service, MediaWiki-General, ci-test-error (WMF-deployed Build Failure)
Ammarpad created T266850: CategoryChangesAsRdfTest::testCategorization: Failed asserting that two strings are equal..
Thu, Oct 29, 11:56 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Wikidata-Query-Service, MediaWiki-General, ci-test-error (WMF-deployed Build Failure)
Ammarpad added a comment to T257183: Make SpecialMuteModifyFormFields hook to not pass the entire special page.

@Shubham656jain, You'd need to change the signature from 'current' to 'desired' as given in the task description.

Thu, Oct 29, 10:37 PM · Patch-For-Review, good first task, MediaWiki-Special-pages

Wed, Oct 28

Ammarpad added a comment to T266681: MediaWiki installer doesn't create tables for extensions registering updates with new Hook handler.

In the original report at https://github.com/MatmaRex/patchdemo/issues/166 it is said FlaggedRevs is also affected, but FlaggedRevs is not using Hook handler system (extension.json) and so its callback should be working fine in theory because it would be loaded same ways as other extensions (that're not using Hook handler and not affected here)

Wed, Oct 28, 11:13 PM · Patch-For-Review, Platform Engineering, AbuseFilter, MediaWiki-Installer
Ammarpad renamed T266681: MediaWiki installer doesn't create tables for extensions registering updates with new Hook handler from MediaWiki installer doesn't create AbuseFilter tables to MediaWiki installer doesn't create tables for extensions registering updates with new Hook handler.
Wed, Oct 28, 11:00 PM · Patch-For-Review, Platform Engineering, AbuseFilter, MediaWiki-Installer

Tue, Oct 27

Ammarpad added a comment to T266589: Unable to semi-protect properties on Wikidata.

This is because the entire namespace has been protected with that same level: T254280. There's no need for duplication.

Tue, Oct 27, 6:16 PM · MediaWiki-Page-protection, Wikidata
Ammarpad added a comment to T266578: Mysterious anonymous content page creations on English Wikipedia according to stats.wikimedia.org.

If an anonymous user creates article in draft namespace and it's later moved (with all the history) to content namespace, the end result is, I think, just as if they created it there. For instance, this article https://en.wikipedia.org/wiki/Rakeem_Buckles is created by IP today and it's in content namespace. You'd have to pay attention to the move null entry to get what's happening. The definition of 'new pages' as used in the stats does not seems to exclude such pages.

Tue, Oct 27, 5:31 PM · Analytics-Data-Quality, Analytics-Dashiki, Analytics, Analytics-Wikistats, Product-Analytics
Ammarpad added a project to T266559: PDF download generates invalid PDF files: Browser-support-print-media.
Tue, Oct 27, 4:11 PM · Operations, Traffic, Browser-support-print-media, Product-Infrastructure-Team-Backlog, Proton, serviceops
Ammarpad added a comment to T266559: PDF download generates invalid PDF files.

I couldn't reproduce this with Chrome 86. Also couldn't with Mac's Preview. I am not sure whether this might be caused by Chrome's upstream change (need to know the versions you used though). I think there was once such corruption and it was traced to upstream Chromium change.

Tue, Oct 27, 4:09 PM · Operations, Traffic, Browser-support-print-media, Product-Infrastructure-Team-Backlog, Proton, serviceops
Ammarpad updated Ammarpad.
Tue, Oct 27, 11:25 AM
Ammarpad closed T197920: Specific spam blacklist entry on fawiki did not work as Invalid.

The link already exists on the page as can be seen in the version of the page a day before that edit

Tue, Oct 27, 7:43 AM · SpamBlacklist

Mon, Oct 26

Ammarpad closed T265779: Fatal MWException when trying to rename a page as Resolved.
Mon, Oct 26, 7:41 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error
Ammarpad reopened T266394: Protection interface displays 'Allow all users' despite $wgNamespaceProtection being applied as "Open".

This is not a duplicate.

Mon, Oct 26, 5:07 AM · MediaWiki-Page-protection

Fri, Oct 23

Ammarpad added a comment to T266337: Personnal tools menu goes crazy .

Purge the page https://en.wikipedia.org/wiki/Hirsutism?action=purge, it will return back to normal.

Fri, Oct 23, 4:00 PM · MediaWiki-General
Ammarpad updated the task description for T230428: Migrate tables.sql to abstract schema.
Fri, Oct 23, 3:09 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer
Ammarpad updated the task description for T230428: Migrate tables.sql to abstract schema.
Fri, Oct 23, 2:02 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer

Thu, Oct 22

Ammarpad added a comment to T265767: Research to create service for CentralIdLookup::factory.

There are open patches for this: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/571411, https://gerrit.wikimedia.org/r/c/mediawiki/core/+/594533

Thu, Oct 22, 7:30 AM · MediaWiki-General, Dependency injection
Ammarpad added a comment to T251664: Disable auto-capitalization hint on search field of wikis with $wgCapitalLinks = false.

OK, that's good to hear.

Thu, Oct 22, 7:27 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), patch-welcome, MinervaNeue (Tracking), Readers-Web-Backlog, Wiktionary
Ammarpad added a comment to T251664: Disable auto-capitalization hint on search field of wikis with $wgCapitalLinks = false.

Since Wiktionary is case-sensitive on first character ($wgCapitalLinks is set to false), searching lower-case titles on mobile could be frustrating if > auto capitalization is enabled. The fix is just adding autocapitalize="off" to the search <input> element.

Let me clarify one thing here to avoid misunderstanding after the change, because this task description is assuming something which will not happen.

Thu, Oct 22, 6:23 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), patch-welcome, MinervaNeue (Tracking), Readers-Web-Backlog, Wiktionary

Wed, Oct 21

Ammarpad added a comment to T266108: Call to undefined method MediaWiki\Session\UserInfo::isVerifidd().

The method is named correctly. Apparently this is T245183 hitting harder

Wed, Oct 21, 10:06 AM · MediaWiki-extensions-CentralAuth, Wikimedia-production-error
Ammarpad added a comment to T265524: Cannot diff content types other than MassMessageListContent.

Intentionally thrown by extension: includes/Content/MassMessageListDiffEngine.php#29

Wed, Oct 21, 10:00 AM · Release-Engineering-Team (Logspam), MassMessage, Wikimedia-production-error
Ammarpad closed T246567: Avoid use of User::isAllowed as Resolved.
Wed, Oct 21, 7:40 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Technical-Debt, MediaWiki-extensions-OAuth
Ammarpad closed T213621: Offer a way to go to the previous or next non-deleted edit in an edit history of a page as Resolved.
Wed, Oct 21, 7:38 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-Page-History, MediaWiki-Page-Diffs
Ammarpad created T266087: Echo should unset user-to-user email option when email features are disabled..
Wed, Oct 21, 6:05 AM · good first task, Growth-Team, Notifications
Ammarpad added a project to T265779: Fatal MWException when trying to rename a page: Platform Engineering.

@Clarakosi For code review

Wed, Oct 21, 1:34 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error
Ammarpad renamed T251664: Disable auto-capitalization hint on search field of wikis with $wgCapitalLinks = false from Disable auto-capitalization on mobile Wiktionary search bar to Disable auto-capitalization hint on search field of wikis with $wgCapitalLinks = false.
Wed, Oct 21, 12:03 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), patch-welcome, MinervaNeue (Tracking), Readers-Web-Backlog, Wiktionary

Tue, Oct 20

Ammarpad edited projects for T265892: Pagetitle on main page of Wikimedia Project Sites in mobile version has an unneeded " - " prefix, added: MinervaNeue; removed MobileFrontend.

This is not MobileFrontend issue but MinervaNeue's. It can be fixed by setting the HTML title to be MediaWiki:Pagetitle-view-mainpage just as on desktop.

Tue, Oct 20, 10:35 AM · Readers-Web-Backlog, MinervaNeue
Ammarpad claimed T260006: Insert file dialog should ask for alt text.
Tue, Oct 20, 6:22 AM · Patch-For-Review, Accessibility, WikiEditor

Sat, Oct 17

Ammarpad claimed T265779: Fatal MWException when trying to rename a page.
Sat, Oct 17, 11:00 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error
Ammarpad added a project to T265779: Fatal MWException when trying to rename a page: Platform Engineering.

I think these are related: T217136, T210845

Sat, Oct 17, 10:59 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error
Ammarpad added a comment to T265779: Fatal MWException when trying to rename a page.

Seems like an AbuseFilter problem:
Of course, it should be shown as a normal error, not as an exception.

It does not seem to be AbuseFilter fault. AbuseFilter uses ArticleDeleteHook to filter deletion action (in this case). It founds the deletion should be disallowed (as configured) and the hook requires boolean return value to decide on whether to proceed with the deletion or not. So it's obvious, the only option for AbuseFilter is to return false to abort the deletion. It also sets the correct error message by modifying the supplied error variable in the hook. That's all it could do.

Sat, Oct 17, 5:34 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error

Thu, Oct 15

Ammarpad added a comment to T265523: PHP Notice: Undefined index: href (from ContentTranslationSpecialPage.php).

Even if the backend is changed to handle missing href, frontend does not handle it and produces links to the "null" page.

CX needs to unset the link. I have already wrote patch for that.

Thu, Oct 15, 11:45 AM · Language-Team (Language-2020-October-December), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), ContentTranslation, Wikimedia-production-error
Ammarpad added a subtask for T265402: Diff links in mobile watchlist and recent changes go to page instead of diff: T210168: [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core.
Thu, Oct 15, 11:08 AM · Regression, Advanced Mobile Contributions, MobileFrontend, Mobile
Ammarpad added a parent task for T210168: [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core: T265402: Diff links in mobile watchlist and recent changes go to page instead of diff.
Thu, Oct 15, 11:08 AM · User-Jdlrobson, Readers-Web-Backlog, Epic, MobileFrontend (MobileFrontend Special Pages)
Ammarpad added a comment to T174194: Display user account blocks in mobile view on Special:Contributions.

I see. Some of these issues have been lingering for close to four years and more are being filed e.g T265402, T233845, so I thought it'd be good to fix them, I see that's not the case now and that's fine.

Thu, Oct 15, 11:07 AM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), MediaWiki-Special-pages
Ammarpad changed the status of T265402: Diff links in mobile watchlist and recent changes go to page instead of diff from Open to Stalled.

This is caused by using mixture of core special page (AMC mode) and sending request from there to MobileFontend mobile special page. In desktop request cur_id is a valid substitute for page title. However, Jon made it clear in T174194 that there is no desire to continue fixing these mobile special page issues severally, instead, they should all wait for the eventual switch of the pages to use the original core special pages directly.

Thu, Oct 15, 10:56 AM · Regression, Advanced Mobile Contributions, MobileFrontend, Mobile
Ammarpad added a comment to T265355: MW 1.35 'noindex,nofollow' robot tag on every page.

Both Timeless and Vector do not set the tag but they do generate the same trace as posted

How do they generate the trace?, give clear steps to reproduce

Thu, Oct 15, 10:25 AM · Patch-For-Review, MediaWiki-HTML-Templating

Tue, Oct 13

Ammarpad added a comment to T265361: OAuth extension - get rid of isAllowed() deprecated method.

Have wrote patch for this in T246567

Tue, Oct 13, 9:41 PM · Platform Team Initiatives (API Gateway), Platform Team Workboards (S&F Workboard), MediaWiki-extensions-OAuth
Ammarpad added a comment to T265355: MW 1.35 'noindex,nofollow' robot tag on every page.

I'm seeing a very weird bug with MW 1.35 and the Citizen Skin (uses mustache).
Using the Timeless with ?useskin=timeless the robot tag disappears (correct behaviour).
...I've narrowed it down to line 1019 in Article.php.

If it's not happening in 'Timeless', then how are you sure the issue is not from the skin where you're seeing it?. It seems strange also to be skin specific.

Tue, Oct 13, 9:38 PM · Patch-For-Review, MediaWiki-HTML-Templating

Mon, Oct 12

Ammarpad claimed T265223: PHP warning from BaseTemplate::getFooterLinks() when $validFooterLinks is empty on PHP < 7.4.
Mon, Oct 12, 5:30 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MW-1.35-notes, MW-1.31-release-notes, MediaWiki-Debian, MW-1.35-release, MW-1.34-release, MW-1.31-release, MediaWiki-Interface
Ammarpad added a comment to T265201: Make SpecialVersion a real special page and move all helper function to own service.

Maybe create a VersionInfo service, analogous to GitInfo (not yet a service though itself), but they should all be.

Mon, Oct 12, 7:45 AM · Dependency injection, MediaWiki-Special-pages

Fri, Oct 9

Ammarpad added a comment to T174194: Display user account blocks in mobile view on Special:Contributions.

I think it's trivial to fix this. :-).

Fri, Oct 9, 9:53 AM · MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), MediaWiki-Special-pages
Ammarpad added a comment to T263213: SkinMustache should extend Skin not SkinTemplate.

I think there's a need to discuss this more before attempting implementing

Fri, Oct 9, 6:32 AM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-Core-Skin-Architecture

Thu, Oct 8

Ammarpad added a comment to T93469: MergeHistory breaks pages with content models that don't allow for redirects.

@Johan , Yes basically. But it's not the merge history that breaks itself, it's only the source page. Also the fix now is to record the page as deleted (instead of leaving it in corrupted state), I think that's important to mention

Thu, Oct 8, 12:23 PM · User-notice, Patch-For-Review, MediaWiki-MergeHistory
Ammarpad placed T235207: Some MediaWiki API call examples show an empty result set due to hardcoded "Main Page" title up for grabs.
Thu, Oct 8, 8:59 AM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Documentation, MediaWiki-API
Ammarpad added a project to T211910: Don't show misleading messages on Special:Contributions for IP ranges outside the CIDR limit: Platform Engineering.
Thu, Oct 8, 8:35 AM · Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-Special-pages
Ammarpad changed the subtype of T213621: Offer a way to go to the previous or next non-deleted edit in an edit history of a page from "Task" to "Bug Report".
Thu, Oct 8, 8:26 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-Page-History, MediaWiki-Page-Diffs
Ammarpad moved T213621: Offer a way to go to the previous or next non-deleted edit in an edit history of a page from Feature Requests to Review to Inbox on the Platform Engineering board.

This fixes a bug, so it's not a new feature. The merged task T225189 has more simpler steps to reproduce

Thu, Oct 8, 8:26 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-Page-History, MediaWiki-Page-Diffs

Wed, Oct 7

Ammarpad updated Ammarpad.
Wed, Oct 7, 2:01 PM
Ammarpad closed T245378: Remove or replace/rewrite message interfaceadmin-info (which says "recently"), a subtask of T40638: Interface messages needing rewording or documentation and other issues with existing messages (tracking), as Resolved.
Wed, Oct 7, 9:06 AM · Tracking-Neverending, I18n, MediaWiki-Interface
Ammarpad closed T245378: Remove or replace/rewrite message interfaceadmin-info (which says "recently") as Resolved.
Wed, Oct 7, 9:06 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), MediaWiki-General

Tue, Oct 6

Ammarpad added a comment to T261030: Fix ApiEditPage to return watchlist expiry if present when watchlist param is `nochange`.

In my view, if there's no expiry, then 'watchlistexpiry' should not appear in the result, that simply signifies that there's no expiry as the name suggests. That'd also be consistent with the conventional 'watch' action. (If you're not watching, the 'watched' status will not be included in the result at all).

Tue, Oct 6, 12:20 AM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-API, Expiring-Watchlist-Items

Sat, Oct 3

Ammarpad added a comment to T264492: Upgrading OATHAuth extension broken on sqlite.

According to @Ammarpad SQLite requires that NOT NULL columns have a default value.

I don't think this is completely true.

I didn't say for all commands. It's for ALTER, that's the source of the error being discussed

Sat, Oct 3, 2:27 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-extensions-OATHAuth, SQLite
Ammarpad added a comment to T199429: Special:Contributions&target= fails on mobile.

I have an idea for simple fix to this, since the big switch is clearly not happening anytime soon.

Sat, Oct 3, 8:49 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), MobileFrontend (MobileFrontend Special Pages), Readers-Web-Backlog (Tracking), MediaWiki-Special-pages

Thu, Oct 1

Ammarpad added a comment to T206253: Some ApiParse requests fail due to fatal MWException: "not supported for content model".

Still seen in Logstash.

It's trivial to fix, if someone is committing to review patch for that

Thu, Oct 1, 1:57 PM · Platform Engineering (Icebox), MediaWiki-ContentHandler, MediaWiki-API, Wikimedia-production-error
Ammarpad claimed T248515: Watchlist Expiry: Add watchlist expiry support to Block API [medium].
Thu, Oct 1, 1:17 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-API, Expiring-Watchlist-Items, archived--TCB-Team
Ammarpad closed T264200: ArgumentCountError on action=help&modules=threadaction as Resolved.
Thu, Oct 1, 11:53 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-DannyS712, MediaWiki-extensions-LiquidThreads, affects-translatewiki.net, MediaWiki-API, Platform Engineering
Ammarpad closed T264200: ArgumentCountError on action=help&modules=threadaction, a subtask of T263178: 1.36.0-wmf.12 deployment blockers, as Resolved.
Thu, Oct 1, 11:52 AM · Patch-For-Review, Release-Engineering-Team-TODO, Release, Train Deployments
Ammarpad added a comment to T240678: mw.title.new('#') returns object that errors when expensive data is accessed.

mw.title.new("#")

It does not return an object, there is no object to return

This can be fixed in mw.title.lua by checking that php.getExpensiveData( t.fullText ) on line 209 is not nil before iterating over it with pairs.

That's not the root cause of the problem, it merely propagates to there, and so that's no right place to tackle the issue

Thu, Oct 1, 3:51 AM · MediaWiki-extensions-Scribunto

Sep 30 2020

Ammarpad renamed T240678: mw.title.new('#') returns object that errors when expensive data is accessed from mw.title.new('#') returns a weird object to mw.title.new('#') does not return anything but error.
Sep 30 2020, 7:25 PM · MediaWiki-extensions-Scribunto
Ammarpad updated the task description for T259313: Deprecate Skin::subPageSubtitle as a public method.
Sep 30 2020, 7:09 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Editing-Team-Request, Patch-For-Review, CologneBlue, VisualEditor, Nostalgia, MediaWiki-Core-Skin-Architecture
Ammarpad added a comment to T264198: PHP warnings from ParserOptions::optionsHash.

This error has origin from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/629403. and other caching side effects, as I noticed it first after pulling that patch at the time. The patch was a revert, but it has since been restored again (with modification).

Sep 30 2020, 6:41 PM · affects-translatewiki.net, MediaWiki-extensions-LiquidThreads, MediaWiki-Parser
Ammarpad added a comment to T261030: Fix ApiEditPage to return watchlist expiry if present when watchlist param is `nochange`.

Could we solicit some help to get LiquidThreads fixed?

The page needs rewrite. But any significant rewrite even for supported extension would really take time. But LiquidThreads is essentially dead and ought to be undeployed T187487.

Sep 30 2020, 5:34 PM · Community-Tech (Kanban-2020-21-Q2), MW-1.35-notes, Patch-For-Review, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-API, Expiring-Watchlist-Items
Ammarpad closed T190285: ApiEditPage.php assumes that higher revision numbers have later timestamps as Resolved.
Sep 30 2020, 1:57 AM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), good first task, MediaWiki-API, MediaWiki-Page-editing
Ammarpad closed T116287: Special:MergeHistory does not merge watchlists as Resolved.

Watchlist entries are duplicated not sure whether it was added after this task or not though.

Sep 30 2020, 1:38 AM · Growth-Team, MediaWiki-MergeHistory, MediaWiki-Watchlist
Ammarpad edited projects for T263340: "Fatal Exception of Type InvalidArgumentException" when viewing pages with broken history caused by Special:MergeHistory, added: MediaWiki-MergeHistory; removed MediaWiki-Page-History.
Sep 30 2020, 1:33 AM · MediaWiki-MergeHistory, Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Ammarpad edited projects for T263340: "Fatal Exception of Type InvalidArgumentException" when viewing pages with broken history caused by Special:MergeHistory, added: MediaWiki-Page-History; removed MediaWiki-Revision-backend.
Sep 30 2020, 1:32 AM · MediaWiki-MergeHistory, Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error

Sep 29 2020

Ammarpad closed T263382: Remove ULS extension hacks from Vector and MobileFrontend as Resolved.
Sep 29 2020, 4:48 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Ammarpad awarded T263213: SkinMustache should extend Skin not SkinTemplate a Orange Medal token.
Sep 29 2020, 3:44 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-Core-Skin-Architecture
Ammarpad updated the task description for T263213: SkinMustache should extend Skin not SkinTemplate.
Sep 29 2020, 3:38 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), MediaWiki-Core-Skin-Architecture
Ammarpad added a project to T93469: MergeHistory breaks pages with content models that don't allow for redirects: User-notice.
Sep 29 2020, 2:23 PM · User-notice, Patch-For-Review, MediaWiki-MergeHistory
Ammarpad added a comment to T251910: "Main Page" incorrectly displayed as page title in error messages with "Return to $pagetitle".

Note that this is not an error per se. If you don't select any revision that does not make sense and so you'll be redirected to an error page, the "return to mainpage" is meant to guide you and everything back to normalcy. There are many pages (that are not normal to come by) that have that generic return message also.

Sep 29 2020, 2:16 PM · MediaWiki-General
Ammarpad removed a subtask for T251910: "Main Page" incorrectly displayed as page title in error messages with "Return to $pagetitle": T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators.
Sep 29 2020, 8:17 AM · MediaWiki-General
Ammarpad removed a parent task for T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators: T251910: "Main Page" incorrectly displayed as page title in error messages with "Return to $pagetitle".
Sep 29 2020, 8:17 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Platform Team Workboards (External Code Reviews), MediaWiki-Page-deletion
Ammarpad closed T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators, a subtask of T40638: Interface messages needing rewording or documentation and other issues with existing messages (tracking), as Resolved.
Sep 29 2020, 7:21 AM · Tracking-Neverending, I18n, MediaWiki-Interface
Ammarpad closed T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators, a subtask of T251910: "Main Page" incorrectly displayed as page title in error messages with "Return to $pagetitle", as Resolved.
Sep 29 2020, 7:21 AM · MediaWiki-General
Ammarpad closed T251066: MediaWiki:Missing-revision should provide link to deleted revision for administrators as Resolved.
Sep 29 2020, 7:21 AM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Platform Team Workboards (External Code Reviews), MediaWiki-Page-deletion
Ammarpad changed the status of T245378: Remove or replace/rewrite message interfaceadmin-info (which says "recently"), a subtask of T40638: Interface messages needing rewording or documentation and other issues with existing messages (tracking), from Stalled to Open.
Sep 29 2020, 6:27 AM · Tracking-Neverending, I18n, MediaWiki-Interface
Ammarpad changed the status of T245378: Remove or replace/rewrite message interfaceadmin-info (which says "recently") from Stalled to Open.
Sep 29 2020, 6:27 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), MediaWiki-General

Sep 28 2020

Ammarpad added a comment to T263382: Remove ULS extension hacks from Vector and MobileFrontend.

@Jdlrobson I'd need your help on how to reproduce the problem that $wgULSPosition ='none' hack is supposed to solve in MobileFrontend. Because me I am not seeing anything if I removed it (MobileFrontendHooks.php#L123).

Sep 28 2020, 3:14 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Readers-Web-Backlog, UniversalLanguageSelector, MobileFrontend, Vector
Ammarpad renamed T263681: PHP Warning: Illegal string offset 'value' and 'providedby' in extension.json with invalid values from Make sure string offset exists before using it in extractConfig2() - PHP Warning: Illegal string offset 'value' and 'providedby' to PHP Warning: Illegal string offset 'value' and 'providedby' in extension.json with invalid values.
Sep 28 2020, 1:08 PM · MediaWiki-Configuration
Ammarpad added a comment to T263340: "Fatal Exception of Type InvalidArgumentException" when viewing pages with broken history caused by Special:MergeHistory.

This will be temporarily fixed by having Scribunto content model to support redirects, there are some patches on that already. But to fix it once and for all, I can see two options: HistoryMerge needs to recognize these content models and delete the source page if no revision is remaining, since there's nothing more to see. It'll just be like how a move without leaving a redirect is currently treated. Otherwise this exception will always be thrown as these pages have all their revisions living elsewhere after the merge.
The other way is to make it mandatory for every content model to support redirect. That seems radical and may have its own downsides.

Sep 28 2020, 8:58 AM · MediaWiki-MergeHistory, Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Ammarpad added a comment to T240678: mw.title.new('#') returns object that errors when expensive data is accessed.

This needs to be fixed in includes/engines/LuaCommon/TitleLibrary.php if someone is interested. In PHP side, standalone '#' string will construct a valid title object with title text morphed to empty string (because of stripping of illegal chars) which will cause it to eventually just redirects to whatever the mainpage is.

Sep 28 2020, 6:12 AM · MediaWiki-extensions-Scribunto
Ammarpad added a comment to T262959: Special:Badtitle should not have class="new".

There's some info on Gerrit/Tutorial. You can also use Gerrit Patch Uploader tool.

Sep 28 2020, 5:17 AM · MediaWiki-Special-pages
Ammarpad added a comment to T262959: Special:Badtitle should not have class="new".

Is there a way do make it blue? F.Y.I. Special:Badtitle is red not just in Wikipedia, but red in about every single project.

If you want fix it, you can propose a patch. FYI this needs to be done in includes/Title.php

Sep 28 2020, 5:04 AM · MediaWiki-Special-pages

Sep 27 2020

Ammarpad merged task T263896: Unprotected error on accessing `exists` field of `mw.title` object created with an invalid title into T240678: mw.title.new('#') returns object that errors when expensive data is accessed.
Sep 27 2020, 10:22 AM · MediaWiki-extensions-Scribunto
Ammarpad merged T263896: Unprotected error on accessing `exists` field of `mw.title` object created with an invalid title into T240678: mw.title.new('#') returns object that errors when expensive data is accessed.
Sep 27 2020, 10:22 AM · MediaWiki-extensions-Scribunto
Ammarpad renamed T263937: Special:MobileDiff no longer allows viewing deleted diffs because of wrong context title from Cannot see a diff to Special:MobileDiff no longer allows viewing deleted diffs because of wrong context title.
Sep 27 2020, 10:19 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Editing-team, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), MobileFrontend
Ammarpad removed a project from T263937: Special:MobileDiff no longer allows viewing deleted diffs because of wrong context title: MediaWiki-Revision-deletion.

Caused by T245172/gerrit:625922 which changed context title to be the target title, hence why you're always being redirected to the talkpage

Sep 27 2020, 10:12 AM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Editing-team, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), MobileFrontend

Sep 25 2020

Ammarpad added a comment to T259890: Phan CI jobs should stop using checkstyle but use a text report instead.

Glad to know the issue is already known and being discussed. Yes, either of these two themes may apparently be better than the one in T259890#6493908.

Sep 25 2020, 12:05 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config, phan
Ammarpad added a comment to T259890: Phan CI jobs should stop using checkstyle but use a text report instead.

Some of the colors are really not good on white background.

Sep 25 2020, 11:44 AM · Patch-For-Review, Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Config, phan

Sep 24 2020

Ammarpad committed rEFLIe8298cf3e3df: Block page titles which are marked as fully protected on the target wiki (authored by thiemowmde).
Block page titles which are marked as fully protected on the target wiki
Sep 24 2020, 2:36 PM
Ammarpad added a comment to T262617: Minerva Selenium test for talk page creation was disabled (Can't call getText on element with selector ".section-heading" because element wasn't found).

Just a note that this is still occuring as of today https://gerrit.wikimedia.org/r/c/mediawiki/core/+/629514

Sep 24 2020, 12:33 PM · MinervaNeue, ci-test-error, Readers-Web-Backlog, User-zeljkofilipin, MW-1.36-notes (1.36.0-wmf.11; 2020-09-29)
WMDE-Fisch awarded T263690: Tests failing for the REL1_34 branch of ext:FileImporter within quibble-composer-mysql-php72-noselenium-docker a Love token.
Sep 24 2020, 7:46 AM · MW-1.34-release, Release-Engineering-Team, ci-test-error, Move-Files-To-Commons

Sep 23 2020

Ammarpad committed rEFLI476f4ada56e3: Use varargs for MessageLocalizer::msg implementation (authored by Umherirrender).
Use varargs for MessageLocalizer::msg implementation
Sep 23 2020, 11:01 PM