In T419895#11722581, @hueitan wrote:

As the contributor who made this change recently, i don't spot any error for now, but if revert works let's do it first.

In T417730#11629642, @Tgr wrote:

How can it not find EmptyIterator?

In T419427#11688330, @SomeRandomDeveloper wrote:

In T419427#11688321, @Ammarpad wrote:

Usages: https://codesearch.wmcloud.org/search/?q=HtmlCacheUpdater

Here is a more relevant search result: https://codesearch.wmcloud.org/search/?q=%28%22%7C%27%29HtmlCacheUpdater%28%22%7C%27%29&files=&excludeFiles=&repos=

There are only two extensions. Only one WMF-deployed.

As part of this I ideally also want to update places that call the old method name in MediaWikiServices (to make it easier to search for usages) and reference the old class name, which is why I chose to include all occurrences of the old service/class name. But yeah the deprecation will only affect those two

Here is a more relevant search result: https://codesearch.wmcloud.org/search/?q=%28%22%7C%27%29HtmlCacheUpdater%28%22%7C%27%29&files=&excludeFiles=&repos=

It also gives Vector 2022 links inconsistent visual state in some cases, e.g:

In T408968#11337329, @Jdlrobson-WMF wrote:

Also impacts Minerva

{F69819851}

Vector 2022 intentionally doesn't want the redlink: T312157, so I believe this is not a bug and the task should be closed this as invalid.

Hi @Quiddity, the email address is appended to the subject, but that is only if username is empty (which is not possible in this form)

It seems you found it. https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1237302. I left a comment there.

I can reproduce. The key is deleted by Vector legacy. I believe ruwiki still uses it as the default skin.

It took around 3 minutes

NAME                       STATUS     COMPLETIONS   DURATION   AGE    SCRIPT
mw-script.codfw.q170xceo   Complete   1/1           3m15s      12m    refreshImageMetadata.php

This has been completed. Please double check if everything is correct.

This has been completed. Please double check if everything is correct.

All subpages and talk pages must be moved as well

All fixed. The query returns an empty result.

The relevant pages have been moved. The script output contains the following excerpt (these are translatable subpages):

...

You can also see it in Monobook https://en.wikipedia.org/wiki/Yang_Guifei?useskin=monobook

Only the talkpage fails (because the target was not moved on wiki). But talkpage is not translatable anyway right? And it can be moved on wiki easily if needed.
Here are the last 5 lines of the script output.

(851/856) Translations:Extension:DynamicPageList3/Page display title/fr --> Translations:Extension:DynamicPageList4/Page display title/fr
(853/856) Translations:Extension:DynamicPageList3/Page display title/pt-br --> Translations:Extension:DynamicPageList4/Page display title/pt-br
(854/856) Translations:Extension:DynamicPageList3/Page display title/tr --> Translations:Extension:DynamicPageList4/Page display title/tr
(855/856) Translations:Extension:DynamicPageList3/Page display title/zh --> Translations:Extension:DynamicPageList4/Page display title/zh
(856/856) Failed to move Extension talk:DynamicPageList3 to Extension talk:DynamicPageList4
	Reason: A page already exists at [[:Extension talk:DynamicPageList4]], or the page name you have chosen is not valid.
Please choose another name.

@Pppery, this looks a bit complicated. I'm not inclined to do all the steps. Can you do the first step?
I'd do the translation move. Then you can finish the remaining steps since you know better what needs to be done for the on wiki parts.

php maintenance\run.php refreshImageMetadata --mediatype AUDIO --mime audio/mid --force --start=Segne_du,_Maria.mid --end=Segne_du,_Maria.mid

mime should be 'audio/midi'. I rerun with the correct one

In T414736#11533103, @Superpes15 wrote:

In the meantime, I'll proceed with fixing wordmark and tagline and with the patch. @Ammarpad, please also note that you need to do what enwiki/slwiki/kkwiki did (please see this comment and this page to hide the old globe on Vector 2022 via PC)! If you need any assistance, I can do this for you onwiki, being a Global sysop and being able to edit the interface! Thanks :)

My suggested fix is as follows:

If someone is deliberately browsing an old version of a page, I’m not sure they should be silently redirected to the current version (a reload should not mean navigating away from the current location).

but only Image [https://en.wikisource.org/wiki/Page:Haunted_Man_(Dickens,_1848).pdf/121?useskin=vector-2022 in Vector 2022],

They're all present. The other three, forward, backwards and index links are icons. I think that's likely why you didn't notice them.

Yes, looks good to me. I have left a comment there.

Yes, checking #p-associated-pages would be more correct. However, Timeless itself does not have the id now, it needs to be fixed.

In T409774#11513161, @Jdlrobson-WMF wrote:

1. Yes the display of the navigation bar is intentional as this feature is new and Vector is opting into it. T414246: Watchlist displays multiple 'edit watchlist' links (when wlenhancedfilters-disable is not true and skin is not using deprecated menus) will hopefully result in the removal of those additional links.

1. Special:Watchlist (with or without RCFilters App) will now show a navigation bar.
2. The navigation bar moves to namespace/page-actions level tab

In T409774#11471562, @Samwilson wrote:

It looks like Timeless now has two 'edit watchlist' links (when wlenhancedfilters-disable is not true):

(Noticed by @GMikesell-WMF in T411842.)

I believe the duplication is not related to this task. The right side link is added by core RCFilters App but only for skins that don't have the top bar. Presumaly Timeless should be added to the list.

I found this annoying a number of times. This particular repo results were never useful.

The error message looks OK on the central wiki (Commons). The client wiki will look like this when fixed, it may still be improved though.

central wiki error	client wiki error

Have you ran Babel tests without CC to arrive at such conclusion? I am quite sure its tests will not pass.

In T413718#11490492, @Pppery wrote:

AutoModerator should presumably hard-require CommunityConfiguration

There's a not even a choice, it's actually a hard dependency by design of CC. You can't soft-depend on it (at least in a nice way)

(from T367516) CommunityConfiguration is designed to be a hard dependency for its client extensions

From @matmarex gerrit comment:

... we'd just have to figure out what happens when the redirect source or target title is also variant-converted

It seems like the second line of this, as well as "for the following reason:" are useless here

I doubt if this premise is correct. It seems you're not sure either.

In T413580#11489070, @Umherirrender wrote:

It also says "Other values will be returned unchanged.", so null could be okay as well.

Well, 'other value' means other code (those not deprecated, hence not in the mapping). Not the value type. The function takes only strings.

Your page seems to have changed. But I can reproduce the issue by creating the pages locally with zh as content language.

This will resolve itself after T412518

Still happening https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1329852412#Error_while_opening_pages