Page MenuHomePhabricator

Ammarpad
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 9:01 PM (211 w, 9 h)
Availability
Available
IRC Nick
Ammarpad
LDAP User
Ammarpad
MediaWiki User
Ammarpad [ Global Accounts ]

Open source enthusiast, mathematics buff.

Recent Activity

Fri, Oct 22

Ammarpad added a comment to T266157: CSS error should be displayed while trying to save, not only when previewing.

Seems this is resolved somehow.

In order to see the warning, you have to preview.

I am seeing the warning without previewing. (The one for previewing is still there though, and styled differently)

Warning Warning shown for PublishWarning shown for Preview
Screen Shot 2021-10-22 at 12.52.38 PM.png (448×1 px, 56 KB)
Screen Shot 2021-10-22 at 12.53.00 PM.png (560×1 px, 74 KB)
Fri, Oct 22, 11:57 AM · MediaWiki-Page-editing, TemplateStyles, Regression

Wed, Oct 20

Ammarpad added a comment to T293941: [Regression] Browser tab title broken for mobile main page ("- Wikipedia").

The override is in MinervaNeue (now).

Wed, Oct 20, 10:24 PM · Readers-Web-Backlog, Regression, MobileFrontend

Mon, Oct 11

Ammarpad closed T237856: Live preview not working with skins not shown in preferences as Resolved.
Mon, Oct 11, 7:13 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Regression, Modern, MediaWiki-Page-editing, CologneBlue (Tracking), Platform Engineering (Icebox), MediaWiki-Interface, MediaWiki-API
Ammarpad closed T237856: Live preview not working with skins not shown in preferences, a subtask of T223824: Hide Cologne Blue skin in preferences , as Resolved.
Mon, Oct 11, 7:13 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), User-notice, Wikimedia-Site-requests, CologneBlue

Mon, Oct 4

Ammarpad closed T290607: Error: Call to a member function getModel() on null as Resolved.
Mon, Oct 4, 10:08 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Unstewarded-production-error, MediaWiki-Page-editing, MediaWiki-API, Wikimedia-production-error

Sun, Oct 3

Ammarpad claimed T290607: Error: Call to a member function getModel() on null.
Sun, Oct 3, 12:47 PM · MW-1.38-notes (1.38.0-wmf.3; 2021-10-05), Unstewarded-production-error, MediaWiki-Page-editing, MediaWiki-API, Wikimedia-production-error

Wed, Sep 29

Ammarpad added a comment to T292012: SpamBlacklist API response for failed edits has inconsistent data structure.

...(with numerical keys that I guess correspond to the count for each matched pattern) if there are multiple matches.
...I guess returning an object in all cases would work, assuming that the numerical keys are important and represent how many times the edit hit each URL pattern.

The numeric keys are not count for matched patterns; the are array indexes. They're non-consecutive because duplicate elements have been removed and the array is not reindexed.

Wed, Sep 29, 8:38 AM · SpamBlacklist

Sep 24 2021

Ammarpad added a comment to T191716: "stub" link styles should be applied only to links to article view, not to others actions like rollback, edit, diff, etc.
Sep 24 2021, 3:48 PM · MediaWiki-Core-Skin-Architecture, UI-Standardization, MediaWiki-Interface, MediaWiki-User-preferences, MediaWiki-Page-diffs, MediaWiki-Special-pages
Ammarpad added a comment to T191716: "stub" link styles should be applied only to links to article view, not to others actions like rollback, edit, diff, etc.

The stub threshold feature has been removed entirely T284917. I guess that renders this task invalid

Sep 24 2021, 6:27 AM · MediaWiki-Core-Skin-Architecture, UI-Standardization, MediaWiki-Interface, MediaWiki-User-preferences, MediaWiki-Page-diffs, MediaWiki-Special-pages

Sep 23 2021

Ammarpad closed T289221: Add template data to core based on Vector / Minerva usage as Resolved.
Sep 23 2021, 5:26 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), MediaWiki-Core-Skin-Architecture
Ammarpad claimed T289221: Add template data to core based on Vector / Minerva usage.
Sep 23 2021, 6:31 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), MediaWiki-Core-Skin-Architecture

Sep 22 2021

Ammarpad claimed T270754: [1.39] Remove the deprecated Skin::getSkinStylePath().
Sep 22 2021, 6:09 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Technical-Debt (Deprecation process), Material, Apex, Metrolook, MediaWiki-Core-Skin-Architecture

Sep 21 2021

Ammarpad closed T283039: Special:Deletedcontributions always shows "(newest | oldest)" navigation as Resolved.

Yes, indeed

Sep 21 2021, 5:45 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), MediaWiki-Page-deletion
Ammarpad closed T282203: MediaWiki:Rev-deleted-text-permission displays instead of MediaWiki:Rev-suppressed-text-permission when a non-oversighter tries to view a suppressed diff as Resolved.
Sep 21 2021, 5:45 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MediaWiki-Revision-deletion, MediaWiki-General

Sep 19 2021

Ammarpad changed the status of T291325: TypeError: Return value of BaseTemplate::getCopyrightIconHTML() must be of the type string, array returned from Open to In Progress.
Sep 19 2021, 2:18 PM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), MW-1.37-notes, User-xSavitar, MW-1.37-release, MediaWiki-Core-Skin-Architecture
Ammarpad added a comment to T291325: TypeError: Return value of BaseTemplate::getCopyrightIconHTML() must be of the type string, array returned.

This is already being fixed at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/721770

Sep 19 2021, 10:23 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), MW-1.37-notes, User-xSavitar, MW-1.37-release, MediaWiki-Core-Skin-Architecture

Sep 17 2021

Ammarpad added a comment to T291272: "Search" button disappears when clicking search box in Monobook.

Note: functionally these buttons generate different arguments as well:

GO: /index.php?title=Special%3ASearch&search=&go=Go
SEARCH: index.php?title=Special%3ASearch&search=&fulltext=Search

Though the resulting load page appears to be the same

It's different. 'Go' takes you directly to the page (if it exists) else to Special:Search. 'Search' takes you to Special:Search (always)

Sep 17 2021, 7:29 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.37-notes, Patch-For-Review, Modern, CologneBlue, Regression, MediaWiki-Search, Discovery-Search, MonoBook
Ammarpad added a comment to T291243: Change target for "Upload file" in sidebar on my.wikipedia.org.

Hi, going to https://my.wikipedia.org/ there is no ဖိုင်တင်ရန် in the sidebar. You are free to adjust sidebar items via https://my.wikipedia.org/wiki/မီဒီယာဝီကီ:Sidebar .

You might not see it because your account probably doesn't have permission to upload files on the wiki.

This is not a server configuration issue, thus I'm closing this ticket. If there are any questions, please refer to https://meta.wikimedia.org/wiki/Tech - thanks!

This upload link cannot be changed on wiki. $wgUploadNavigationUrl may need to be modified.

Sep 17 2021, 5:02 PM · User-Juan90264, Wikimedia-Site-requests

Sep 13 2021

Ammarpad added a project to T290818: Broken article categorization due to colon automatically inserted in front of category name: Regression.

This is still a regression since it breaks expected (and correct) behavior. Colon escaping of these links in main namespace is almost always wrong.

Sep 13 2021, 4:58 AM · MW-1.37-release, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Regression, WikiEditor

Sep 4 2021

Ammarpad awarded T266072: [GOAL] Build Minerva the way we build Vector (adoption of SkinMustache) a Like token.
Sep 4 2021, 6:56 PM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-Core-Skin-Architecture, Technical-Debt, MinervaNeue

Aug 30 2021

Ammarpad added a comment to T257704: Deprecate Skin::bottomScripts and SkinMustache::tailElement in favor of OutputPage::tailElement.

@Jdlrobson have you descoped this? See the second patch

Aug 30 2021, 4:56 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.37-release, MediaWiki-Interface, MediaWiki-Core-Skin-Architecture

Aug 21 2021

Ammarpad added a comment to T257704: Deprecate Skin::bottomScripts and SkinMustache::tailElement in favor of OutputPage::tailElement.

I will work on it. It's low-priority MediaWiki-Core-Skin-Architecture work that's why

Aug 21 2021, 6:11 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.37-release, MediaWiki-Interface, MediaWiki-Core-Skin-Architecture

Aug 11 2021

Ammarpad added a comment to T288653: Make URLShortener service discoverable for users.

There's no pre-filled GET processing (e.g. https://meta.wikimedia.org/wiki/Special:UrlShortener/https://fr.wikipedia.org/wiki/Variable_m%C3%A9tasyntaxique doesn't pre-fill the input)

There's. You have to use the url parameter: https://meta.wikimedia.org/wiki/Special:UrlShortener?url=https://fr.wikipedia.org/wiki/Variable_m%C3%A9tasyntaxique

Aug 11 2021, 8:12 PM · MediaWiki-extensions-UrlShortener

Aug 8 2021

Ammarpad merged T206642: Non-interface administrators can't view source of user .js pages into T249978: Unable to view source of empty protected page, have a message explaining why.
Aug 8 2021, 3:38 PM · MediaWiki-Page-editing, MediaWiki-Page-history, User-DannyS712
Ammarpad merged task T206642: Non-interface administrators can't view source of user .js pages into T249978: Unable to view source of empty protected page, have a message explaining why.
Aug 8 2021, 3:38 PM · MediaWiki-General
Ammarpad renamed T237856: Live preview not working with skins not shown in preferences from Live preview not working with Cologne Blue to Live preview not working with skins not shown in preference.
Aug 8 2021, 1:28 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Regression, Modern, MediaWiki-Page-editing, CologneBlue (Tracking), Platform Engineering (Icebox), MediaWiki-Interface, MediaWiki-API
Ammarpad raised the priority of T237856: Live preview not working with skins not shown in preferences from Low to Medium.

Intention of both T287616 and T223824 is to let existing users to continue using these skins with no change in behavior, so the API should support these skins since they are not really disabled. We can either go with T237856#5656455 or just add the skipped skins to the allowed values (which will avoid listing the internal skins; albeit they're already supported with ?useskin parameter anyway).

Aug 8 2021, 1:23 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Regression, Modern, MediaWiki-Page-editing, CologneBlue (Tracking), Platform Engineering (Icebox), MediaWiki-Interface, MediaWiki-API

Aug 7 2021

Ammarpad added a comment to T288351: Responsive skin preference is in wrong place.

It should probably also be made first in the list (given it's a more general option than the other individual skin options that may appear there).

Aug 7 2021, 5:07 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.37-release, good first task, MediaWiki-Core-Skin-Architecture, patch-welcome, MediaWiki-User-preferences

Jul 31 2021

Ammarpad awarded T287767: Make table of contents available in data format a Like token.
Jul 31 2021, 10:01 AM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Patch-For-Review, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture
Ammarpad claimed T257704: Deprecate Skin::bottomScripts and SkinMustache::tailElement in favor of OutputPage::tailElement.
Jul 31 2021, 10:00 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.37-release, MediaWiki-Interface, MediaWiki-Core-Skin-Architecture

Jul 30 2021

Ammarpad updated the task description for T287767: Make table of contents available in data format.
Jul 30 2021, 8:54 PM · MW-1.38-notes (1.38.0-wmf.7; 2021-11-02), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Patch-For-Review, MediaWiki-Parser, MediaWiki-Core-Skin-Architecture

Jul 26 2021

Ammarpad committed rECPA32e13c1ad3b7: includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo (authored by Chrishel).
includes/SpecialContact.php: Fixed to properly respect $wgUserEmailUseReplyTo
Jul 26 2021, 5:44 AM

Jul 14 2021

Ammarpad added a comment to T286611: TypeError: Return value of JsonSchemaHooks::onEditFilterMergedContent() must be of the type boolean, none returned.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/680364

Jul 14 2021, 9:59 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), User-Zabe, Analytics, Analytics-EventLogging, Wikimedia-production-error

Jul 3 2021

Ammarpad added a comment to T285991: MonoBook users should check their preferences to avoid disruption.

The description needs correction, see my comment at T285402#7195506

Jul 3 2021, 7:34 AM · MediaWiki-Core-Skin-Architecture, Patch-For-Review, User-notice
Ammarpad added a comment to T285402: "Enable responsive MonoBook design" should be a (renamed) core skin preference.

Note when this preference is set, it will apply to MonoBook...

Note this is not quite right, the new core pref will not apply to MonoBook yet (MonoBook does not set Skin->options['responsive'] unconditionally).

Jul 3 2021, 7:32 AM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, patch-welcome, MonoBook, MediaWiki-Core-Skin-Architecture

Jul 1 2021

Ammarpad committed rSMNB2f82aabd682c: monobook-responsive pref: Follow core preference if set (authored by Ammarpad).
monobook-responsive pref: Follow core preference if set
Jul 1 2021, 10:49 PM

Jun 29 2021

Ammarpad added a comment to T285640: Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box.

I use the non-cluttered interface by checking the "Use non-JavaScript interface" preference. I have added reproduction steps

Jun 29 2021, 8:21 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Browser-Support-Google-Chrome, good first task, Growth-Team, MediaWiki-Recent-changes
Ammarpad updated the task description for T285640: Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box.
Jun 29 2021, 8:19 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Browser-Support-Google-Chrome, good first task, Growth-Team, MediaWiki-Recent-changes

Jun 28 2021

Ammarpad added a comment to T285402: "Enable responsive MonoBook design" should be a (renamed) core skin preference.

After https://gerrit.wikimedia.org/r/c/mediawiki/skins/MonoBook/+/701445/5/includes/SkinMonoBook.php Monobook's skin basically exists to override this, so it will be nice to see this disappear. I guess there's a question about whether we need to map the old preference to the new preference or whether it's acceptable to lean on a user-notice for this.

I suggest to initially honor both. Send a notice that all those with 'monobook-responsive' should switch to the general pref, then after sometime TBD remove the preference from MonoBook OR write a script to automatically migrate users. I am not sure how many (active) people are using that preference though, and the numbers can give hint which way might be better.

Jun 28 2021, 9:33 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Patch-For-Review, patch-welcome, MonoBook, MediaWiki-Core-Skin-Architecture
Ammarpad closed T272588: Link to corresponding Manual docs for DBQueryError "run your application's database schema updater" as Resolved.
Jun 28 2021, 6:32 PM · MW-1.37-notes (1.37.0-wmf.12; 2021-06-28), Voice & Tone, MediaWiki-General

Jun 27 2021

Ammarpad renamed T285640: Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box from Horizontal rule on SpecialRecentChanges should not cut across legend box to Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box.
Jun 27 2021, 7:49 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Browser-Support-Google-Chrome, good first task, Growth-Team, MediaWiki-Recent-changes
Ammarpad created T285640: Horizontal rule on SpecialRecentChanges[Linked] should not cut across legend box.
Jun 27 2021, 7:47 PM · MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), Browser-Support-Google-Chrome, good first task, Growth-Team, MediaWiki-Recent-changes

Jun 25 2021

Ammarpad added a project to T278037: Premature access to service container during installation: Platform Engineering.

Adding Platform Engineering since they added the deprecation T153256/47bb958

Jun 25 2021, 6:38 PM · Platform Team Workboards (Clinic Duty Team), MW-1.37-release, MW-1.36-release, Patch-For-Review, MediaWiki-Installer

Jun 21 2021

Ammarpad added a comment to T285266: next-to-last editor link does not escape ampersands.

Screen Shot 2021-06-21 at 8.40.04 PM.png (419×1 px, 150 KB)

The link is added by RevisionJumper gadget, which is hosted on dewiki.

Jun 21 2021, 7:50 PM · WMF-General-or-Unknown

Jun 18 2021

Ammarpad added a comment to T220719: Standardize return type hint spacing.

MediaWiki favors a heavily-spaced style for optimum readability.

Therefore, it seems like a no-brainer to use function () : type.

I don't think this deductive submission is valid. If it were, then ( bool ) $foo would have already been allowed on similar premise.

That comparison was meant to refer to related language features such as function arguments, function calls and brace placement, which all have spaces in them.

I believe your submission T220719#5104780 does not seem to agree with what you're saying now. Additionally, even in "function calls" it's not true that they're heavily spaced; foo () is disallowed albeit it's valid syntax in PHP.

Jun 18 2021, 6:35 PM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer
Ammarpad added a comment to T220719: Standardize return type hint spacing.

What's the duration of the vote? How will people (beyond those subscribed here know a polling is going on?)

Jun 18 2021, 8:28 AM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer

Jun 17 2021

Ammarpad added a comment to T285103: Revdel should warn you if content you are hiding is also visible in the logs.

Is this duplicate of T261087?

Jun 17 2021, 6:25 PM
Ammarpad added a comment to T220719: Standardize return type hint spacing.

CSS convention does not apply to PHP

And from https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP

MediaWiki favors a heavily-spaced style for optimum readability.

Therefore, it seems like a no-brainer to use function () : type.

I don't think this deductive submission is valid. If it were, then ( bool ) $foo would have already been allowed on similar premise.

Jun 17 2021, 5:02 PM · Patch-For-Review, MediaWiki-Documentation, MediaWiki-Codesniffer

Jun 15 2021

Ammarpad added a comment to T274402: Fix typo in description of train deployments tasks.

It was fixed as part of d238db85b8d8

Jun 15 2021, 10:52 AM · User-DannyS712, Phabricator

Jun 11 2021

Ammarpad added a comment to T278037: Premature access to service container during installation.

This basically happens during fresh installation and is really not looking good.

Jun 11 2021, 8:15 AM · Platform Team Workboards (Clinic Duty Team), MW-1.37-release, MW-1.36-release, Patch-For-Review, MediaWiki-Installer
Ammarpad renamed T278037: Premature access to service container during installation from Premature access to service container on wiki without LocalSettings.php to Premature access to service container during installation.
Jun 11 2021, 8:14 AM · Platform Team Workboards (Clinic Duty Team), MW-1.37-release, MW-1.36-release, Patch-For-Review, MediaWiki-Installer
Ammarpad added projects to T278037: Premature access to service container during installation: MW-1.36-release, MW-1.37-release.
Jun 11 2021, 8:14 AM · Platform Team Workboards (Clinic Duty Team), MW-1.37-release, MW-1.36-release, Patch-For-Review, MediaWiki-Installer

Jun 9 2021

Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Jun 9 2021, 5:33 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms

May 29 2021

Ammarpad added a comment to T283915: Special:Contributions shows contribs when passed User:Foo, and also say "user does not exist".

For the subtitle links and the error message, the provided request parameter is used without strict validation because validation of the username (which will lead to normalizing such names) is not desirable because of IP usernames. The contributions query uses user_id not username, that's why a successful result is returned and displayed.

May 29 2021, 1:22 PM · Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Special-pages
Ammarpad added a comment to T283949: Running tests with --reuse-db (and partially with --use-normal-tables) became useless, because MediaWikiIntegrationTestCase now always deletes tables, even in --use-normal-tables mode.

It seems it has been removed entirely now T283146: Remove --reuse-db option from phpunit.php

May 29 2021, 5:13 AM · MediaWiki-Core-Tests

May 25 2021

Ammarpad claimed T283540: Hooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected.
May 25 2021, 8:26 AM · MW-1.36-notes, MW-1.35-notes, MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), MW-1.36-release, MW-1.35-release, MediaWiki-Core-Hooks
Ammarpad renamed T283540: Hooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected from MWHooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected to Hooks::register( 'Hook', [ self::class, 'onHook' ] ) doesn't work as expected.
May 25 2021, 5:34 AM · MW-1.36-notes, MW-1.35-notes, MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), MW-1.36-release, MW-1.35-release, MediaWiki-Core-Hooks

May 24 2021

Ammarpad added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

T220450 needs to be done eventually. But for short term, I was initially thinking of adding some logic to specify that "generate schema for this table only if the db is not postgres." But we can also create the table for "future use" if there's no problem with that.

May 24 2021, 12:35 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MW-1.36-notes, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Ladsgroup, Platform Engineering, TechCom-RFC (TechCom-RFC-Closed), Technical-Debt, PostgreSQL

May 19 2021

Ammarpad merged T283197: Template:Copy to Wikimedia Commons removal when importing file into T250992: Remove {{Copy to Commons}} on the source wiki if export is successful.
May 19 2021, 7:22 PM · Move-Files-To-Commons
Ammarpad merged task T283197: Template:Copy to Wikimedia Commons removal when importing file into T250992: Remove {{Copy to Commons}} on the source wiki if export is successful.
May 19 2021, 7:22 PM · Move-Files-To-Commons

May 18 2021

Ammarpad closed T274063: "&" in page names displayed as "&" by GlobalUsage as Resolved.
May 18 2021, 4:15 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Commons, GlobalUsage
Ammarpad added a comment to T268341: Possible XSS in SpecialGlobalUsage (CVE-2020-35622).

Caused T274063.

May 18 2021, 11:25 AM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Vuln-XSS, GlobalUsage, Security, Security-Team
Ammarpad added a comment to T274063: "&" in page names displayed as "&" by GlobalUsage.

This is caused by T268341: Possible XSS in SpecialGlobalUsage (CVE-2020-35622)

May 18 2021, 11:18 AM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), Commons, GlobalUsage
Ammarpad claimed T282203: MediaWiki:Rev-deleted-text-permission displays instead of MediaWiki:Rev-suppressed-text-permission when a non-oversighter tries to view a suppressed diff.
May 18 2021, 5:05 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MediaWiki-Revision-deletion, MediaWiki-General

May 17 2021

Ammarpad closed T262834: Clarify the labels for ucstart and ucend as Resolved.
May 17 2021, 8:30 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), good first task, Documentation, I18n, Platform Engineering, MediaWiki-API

May 11 2021

Ammarpad added a comment to T282384: Protection log summaries do not show wikilinked syntax (but only plain text without links).

I don't think that message ever allows wikitext. Also the message is shown in the protection form dropdown where wikitext will seemingly not work well too. You should either delete the message (revert to the canonical one) or just remove the wikilink

May 11 2021, 4:57 AM · MediaWiki-Logevents

May 10 2021

Ammarpad closed T280456: ForkController should not assume existence of PCNTL support or posix extension as Resolved.
May 10 2021, 4:35 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-General

May 7 2021

Ammarpad updated the task description for T282183: Hiding own edits on watchlist and recentchanges results in hiding all IP edits.
May 7 2021, 10:35 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (Clinic Duty Team), MediaWiki-Recent-changes, Regression, Growth-Team, MediaWiki-Watchlist

May 6 2021

Ammarpad created T282183: Hiding own edits on watchlist and recentchanges results in hiding all IP edits.
May 6 2021, 8:31 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (Clinic Duty Team), MediaWiki-Recent-changes, Regression, Growth-Team, MediaWiki-Watchlist

May 5 2021

Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
May 5 2021, 10:26 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms

Apr 27 2021

Ammarpad created P15542 (An Untitled Masterwork).
Apr 27 2021, 4:51 AM

Apr 19 2021

Ammarpad removed a project from T280518: Postgres schema `mwuser` table is renamed: MediaWiki-extensions-MediaModeration.
Apr 19 2021, 1:10 PM · MediaWiki-extensions-ConfirmAccount, MediaWiki-extensions-OpenID-Connect, MediaWiki-extensions-OpenID
Ammarpad created T280518: Postgres schema `mwuser` table is renamed.
Apr 19 2021, 11:39 AM · MediaWiki-extensions-ConfirmAccount, MediaWiki-extensions-OpenID-Connect, MediaWiki-extensions-OpenID

Apr 17 2021

Ammarpad created T280456: ForkController should not assume existence of PCNTL support or posix extension.
Apr 17 2021, 9:15 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), MediaWiki-General

Apr 15 2021

Ammarpad placed T277230: Migrating from 1.31.12 to 1.35.1 : error on populateContentTables.php up for grabs.
Apr 15 2021, 4:41 PM · MediaWiki-Maintenance-system

Apr 8 2021

Ammarpad added a comment to T279290: Synchronising Wikidata and Wikipedias using pywikibot - Task 6.

Working with Category:Netflix title ID not in Wikidata and Category:SoundCloud ID not in Wikidata

Apr 8 2021, 10:15 AM · Outreachy (Round 22)

Apr 5 2021

Ammarpad added a comment to T246242: Add tag description.

Hi, I would like to work on this issue, can anyone please guide me on
where is the repository and what description has to be added about this tag GWToolset

Apr 5 2021, 5:01 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), good first task, Commons, MediaWiki-extensions-GWToolset

Apr 4 2021

Ammarpad updated the task description for T230428: Migrate tables.sql to abstract schema.
Apr 4 2021, 7:35 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (Abstract Schema), User-Ladsgroup, MediaWiki-Installer

Apr 1 2021

Ammarpad placed T27471: Add "Delete associated talk page" option to action=delete up for grabs.
Apr 1 2021, 3:51 PM · Community-Tech (CommTech-Sprint-12), Undelete-Associated-Talk-Page (2021), Platform Engineering, MediaWiki-Page-deletion
Ammarpad placed T247160: Add range support to resetAuthenticationThrottle.php up for grabs.
Apr 1 2021, 5:13 AM · MediaWiki-Maintenance-system
Ammarpad placed T272081: Introduce StatusValue::ignore method up for grabs.
Apr 1 2021, 4:59 AM · Platform Team Workboards (MW Expedition)
Ammarpad closed T270363: Improve test coverage of core skin code as Declined.
Apr 1 2021, 4:57 AM · Test-Coverage, MediaWiki-Core-Skin-Architecture

Mar 28 2021

Ammarpad added a comment to T278620: Auto-remove never used dormant user accounts.

There's a script that does something like that https://www.mediawiki.org/wiki/Manual:RemoveUnusedAccounts.php. You need to check the limitations and what it considers 'unused'

Mar 28 2021, 10:19 AM · MediaWiki-extensions-UserMerge
Ammarpad updated the task description for T244383: Replace StubUserLang with a better lazy loading mechanism.
Mar 28 2021, 9:46 AM · Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-General, Technical-Debt

Mar 26 2021

Ammarpad closed T278512: PHP8: Fatal error: Cannot make non static method MediaWiki\Tests\Unit\MockServiceDependenciesTrait::fail() static in class PHPUnit\Framework\Assert as Declined.

Already fixed

Mar 26 2021, 2:00 PM · PHP 8.0 support
Ammarpad added a project to T278512: PHP8: Fatal error: Cannot make non static method MediaWiki\Tests\Unit\MockServiceDependenciesTrait::fail() static in class PHPUnit\Framework\Assert: PHP 8.0 support.
Mar 26 2021, 7:55 AM · PHP 8.0 support
Ammarpad created T278512: PHP8: Fatal error: Cannot make non static method MediaWiki\Tests\Unit\MockServiceDependenciesTrait::fail() static in class PHPUnit\Framework\Assert.
Mar 26 2021, 7:54 AM · PHP 8.0 support

Mar 25 2021

Ammarpad added a comment to T277601: EditHandler: Call to a member function getContent() on null.

The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.

SELECT ... FROM `revision` ... WHERE rev_id = 0

While generally this would be pointless but harmless, this actually led me to realize a flaw in my patch: the response representing the state after a null-edit should reflect information from the page's current revision, not the edit's base revision. I'll make another patch to improve this.

Pointless is the same as "doesn't make sense" No one says it's harmful.

Mar 25 2021, 6:18 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-REST-API, Wikimedia-production-error
Ammarpad closed T189967: User::findUsersByGroup() does not order its results, but its test assumes it does as Resolved.
Mar 25 2021, 5:31 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), MediaWiki-User-management

Mar 24 2021

Ammarpad closed T277689: LanguageKk_cyrl->lastLetter: PHP Notice: Undefined offset: -1 as Resolved.
Mar 24 2021, 11:19 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Engineering, ParserFunctions, Wikimedia-production-error
Ammarpad renamed T278295: MergeHistory: Avoid querying master DB for the purpose of trivial message variation from MergeHistory should query master for the purpose of trivial message variation to MergeHistory: Avoid querying master DB for the purpose of trivial message variation.
Mar 24 2021, 9:56 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-MergeHistory
Ammarpad created T278295: MergeHistory: Avoid querying master DB for the purpose of trivial message variation.
Mar 24 2021, 9:53 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-MergeHistory
Ammarpad created T278293: MergeHistory message outputs unparsed HTML.
Mar 24 2021, 9:44 AM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), MediaWiki-MergeHistory

Mar 22 2021

Ammarpad reopened T252562: Error in "Page should be restorable" as "Open".

This is still happening

15:33:29 [0-1] AssertionError [ERR_ASSERTION] in "Page should be restorable"
15:33:29 Input A expected to strictly equal input B:
15:33:29 + expected - actual
15:33:29 
15:33:29 - 'BeforeEach-name-0.5544652739983722-Iñtërnâtiônàlizætiøn has been restored\n\nConsult the deletion log for a record of recent deletions and restorations.\n\nRetrieved from "http://127.0.0.1:9412/index.php/Special:Undelete"'
15:33:29 + 'BeforeEach-name-0.5544652739983722-Iñtërnâtiônàlizætiøn has been restored\n\nConsult the deletion log for a record of recent deletions and restorations.'
15:33:29 [0-1] FAILED in chrome - /tests/selenium/specs/page.js
Mar 22 2021, 5:27 PM · ci-test-error (WMF-deployed Build Failure), MediaWiki-Core-Tests, MediaWiki-extensions-ShortUrl, Browser-Tests
Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Mar 22 2021, 1:21 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms
Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Mar 22 2021, 1:20 PM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms
Ammarpad added a comment to T277601: EditHandler: Call to a member function getContent() on null.

The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.

Mar 22 2021, 6:18 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-REST-API, Wikimedia-production-error

Mar 21 2021

Ammarpad updated the task description for T270033: Fix and enforce table prefix usage in columns and indexes in core.
Mar 21 2021, 11:46 AM · MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Wikimedia-Rdbms
Ammarpad added a comment to T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat fails when enabling $wgDebug vars.

I ran this test in isolation with the evil hack given in T187581#4674890, both on PHP 7 and 8 but I cannot reproduce the failure. Maybe something has fixed elsewhere.

Mar 21 2021, 11:13 AM · MediaWiki-Debug-Logger, MediaWiki-Core-Tests
Ammarpad closed T233133: DefaultPreferencesFactoryTest:testIntvalFilter takes ~8s for a pretty trivial test for a single preference value, a subtask of T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min, as Resolved.
Mar 21 2021, 9:00 AM · Release-Engineering-Team (Next), MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Patch-For-Review, Developer Productivity, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Tests, Continuous-Integration-Config