Page MenuHomePhabricator

Ammarpad
Engineering

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 9:01 PM (251 w, 5 d)
Availability
Available
IRC Nick
Ammarpad
LDAP User
Ammarpad
MediaWiki User
Ammarpad [ Global Accounts ]

Recent Activity

Mon, Jul 18

Ammarpad added a project to T313191: Page history link missing from top of page on mobile when logged out: MinervaNeue.
Mon, Jul 18, 7:38 AM · Readers-Web-Backlog, MinervaNeue, Mobile

Jul 6 2022

Ammarpad closed T312237: In "Special:WhatLinksHere", "Invert Selection" is hidden by Namespace pull-down. as Invalid.
Jul 6 2022, 6:14 PM · MediaWiki-Special-pages
Ammarpad added a comment to T312237: In "Special:WhatLinksHere", "Invert Selection" is hidden by Namespace pull-down..

The above is true. Inversion only works when you select a namespace. Inversion for 'all' will mean showing nothing, which does not make sense.

Jul 6 2022, 6:14 PM · MediaWiki-Special-pages
Ammarpad updated subscribers of T312206: Central Notice targets mobile site even though the box is not checked.

I did mention that I used 'preview' link in my comment, I didn't come across the banner normally. So given this explanation by @Pcoombe, I think there's no device targeting bug with CN here.

Jul 6 2022, 12:19 PM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Jun 28 2022

Ammarpad removed a project from T311539: Gadget to move [edit] link does not align with [subscribe] link in Discussion Tools: MediaWiki-extensions-Gadgets.
Jun 28 2022, 8:52 PM · DiscussionTools

Jun 16 2022

Ammarpad added a comment to T310679: Mobile frontend cannot identify special page from nonexistent page.

Per https://phabricator.wikimedia.org/T242195#5786788 the real issue here is these links should not be using this class. The red link is used for pages that don't exist. The contributions page does exist and shouldnt be red just because the user page link doesn't.

Jun 16 2022, 7:57 AM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Moderator-Tools-Team, Readers-Web-Backlog, Regression, MobileFrontend

Jun 15 2022

Ammarpad edited projects for T310679: Mobile frontend cannot identify special page from nonexistent page, added: Regression; removed Wikimedia-production-error.

This was supposed to be fixed by T242195. It probably regressed.

Jun 15 2022, 10:00 AM · MW-1.39-notes (1.39.0-wmf.22; 2022-07-25), Moderator-Tools-Team, Readers-Web-Backlog, Regression, MobileFrontend

Jun 9 2022

Ammarpad merged T310300: Thank option missing on Block Log (Wikiquote) into T268701: Ability to thank blocks.
Jun 9 2022, 7:07 PM · Growth-Team-Filtering, Patch-For-Review, Growth-Team, Thanks, MediaWiki-Blocks
Ammarpad merged task T310300: Thank option missing on Block Log (Wikiquote) into T268701: Ability to thank blocks.
Jun 9 2022, 7:07 PM

Jun 6 2022

Krinkle awarded T309907: Special RandomInCategory should not ouput the edittoken to the URL a Orange Medal token.
Jun 6 2022, 2:58 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), MediaWiki-General

Jun 4 2022

Ammarpad closed T309927: Unstyled headers on Special:DeletedContributions as Resolved.

This has been fixed in r802816.

Jun 4 2022, 8:40 PM · MediaWiki-Page-deletion

May 29 2022

Ammarpad created T309476: Wikimedia\Timestamp\TimestampException: Wikimedia\Timestamp\ConvertibleTimestamp::setTimezone: Invalid timezone..
May 29 2022, 6:12 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), MediaWiki-Installer, MW-1.39-release

May 23 2022

Ammarpad closed T307478: Portlet link for user to create short URL on pages as Invalid.

Please let's follow T267921: Roll out the Toolbox link for URL Shortener in Wikimedia sites for enabling the feature on Wikimedia prod wikis since it already exists.

May 23 2022, 10:35 AM · MediaWiki-extensions-UrlShortener

May 10 2022

Ammarpad awarded Blog Post: Should Vector be responsive? a Yellow Medal token.
May 10 2022, 8:44 PM · MediaWiki-Core-Skin-Architecture

May 4 2022

Ammarpad added a project to T307530: Special:Contributions namespace fields stuck in bad state after navigating back using the browser button: Browser-Support-Firefox.
May 4 2022, 6:49 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Browser-Support-Firefox, MediaWiki-Interface

May 3 2022

Ammarpad added a comment to T307478: Portlet link for user to create short URL on pages.

This is already available in the extension. It's purposely disabled on Wikimedia wikis

May 3 2022, 5:34 PM · MediaWiki-extensions-UrlShortener

May 2 2022

Ammarpad edited Description on VPS-project-Codesearch.
May 2 2022, 3:21 PM
Ammarpad added a comment to T307361: Input text should be kept when switching to another project.

You should use the beta https://codesearch-beta.wmcloud.org/ which has that feature and a lot more.

May 2 2022, 3:19 PM · VPS-project-Codesearch

Apr 27 2022

Ammarpad closed T306925: Deprecations: QuickTemplate::(get/html/text/haveData) with parameters bottomscripts and headelement as Resolved.
Apr 27 2022, 10:38 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), WikimediaApiPortal, User-brennen, Platform Engineering, Wikimedia-production-error
Ammarpad removed a subtask for T305216: 1.39.0-wmf.10 deployment blockers: T306925: Deprecations: QuickTemplate::(get/html/text/haveData) with parameters bottomscripts and headelement.
Apr 27 2022, 10:37 PM · Patch-For-Review, Release-Engineering-Team (Doing), Release, Train Deployments
Ammarpad removed a parent task for T306925: Deprecations: QuickTemplate::(get/html/text/haveData) with parameters bottomscripts and headelement: T305216: 1.39.0-wmf.10 deployment blockers.
Apr 27 2022, 10:37 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), WikimediaApiPortal, User-brennen, Platform Engineering, Wikimedia-production-error

Apr 25 2022

Ammarpad added a comment to T306817: Special:InvestigateBlock "Override existing blocks" is bugged.

You already blocked these seven accounts around 19:12 21 April 2022; they are the accounts that you're trying to reblock (as shown in your image). You can't reblock them with the same block settings, as the error clearly explained. You either need to make the block settings different or forgo the block.

Apr 25 2022, 10:45 PM · CheckUser, Spanish-Sites

Apr 18 2022

Ammarpad closed T271014: Update Gadgets to use the new HookContainer/HookRunner system as Resolved.
Apr 18 2022, 11:19 AM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MediaWiki-extensions-Gadgets, Platform Team Initiatives (New Hook System)
Ammarpad closed T271014: Update Gadgets to use the new HookContainer/HookRunner system, a subtask of T263353: Update all Wikimedia production extensions to use the new HookContainer/HookRunner system, as Resolved.
Apr 18 2022, 11:19 AM · Patch-For-Review, MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General
Ammarpad closed T271014: Update Gadgets to use the new HookContainer/HookRunner system, a subtask of T263364: Update all tarballed extensions to use the new HookContainer/HookRunner system, as Resolved.
Apr 18 2022, 11:19 AM · Platform Engineering Roadmap Decision Making, Platform Team Initiatives (New Hook System), MediaWiki-extensions-General

Apr 10 2022

Ammarpad changed the subtype of T305797: WMF wikis don't redirect to short url, and instead shows bare /w/index.php from "Bug Report" to "Feature Request".
Apr 10 2022, 8:38 PM · WMF-General-or-Unknown

Apr 5 2022

Ammarpad added a comment to T305422: Consider deprecating/removing MW_CMDLINE_CALLBACK constant.

This has been unused since its introduction in r54225.

It was once in use; and last appeared in r72551. It seems Maintenance::afterFinalSetup was introduced as a replacement.

Apr 5 2022, 6:38 PM · Performance-Team, Technical-Debt (Deprecation process), MediaWiki-Maintenance-system
Ammarpad added a comment to T299456: Make Skin::getPortletData private.

Ok, that's fine.

Apr 5 2022, 3:10 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, MW-1.39-release, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), MediaWiki-Core-Skin-Architecture
Ammarpad added a comment to T299456: Make Skin::getPortletData private.

Make Skin::getPortletData private and then hard deprecate it

If all usages are fixed... maybe just deprecate (and eventually remove)? I am not sure what the extra 'make private' stage will do

Apr 5 2022, 2:27 PM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, MW-1.39-release, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), MediaWiki-Core-Skin-Architecture

Mar 30 2022

Ammarpad renamed T304559: Edit fails with fatal IncompleteRevisionException: rev_page field must not be 0 from Commons edit fails with fatal IncompleteRevisionException: rev_page field must not be 0 to Edit fails with fatal IncompleteRevisionException: rev_page field must not be 0.
Mar 30 2022, 5:04 PM · MW-1.38-notes, Patch-For-Review, MW-1.38-release, MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), Platform Engineering, MediaWiki-Core-Revision-backend, Wikimedia-production-error
Ammarpad merged T305019: preload parameter has no effect when the mobile version is used into T213835: The mobile editor doesn't prefill with content like the desktop editor.
Mar 30 2022, 6:30 AM · MobileFrontend (MobileFrontend (Editor)), VisualEditor
Ammarpad merged task T305019: preload parameter has no effect when the mobile version is used into T213835: The mobile editor doesn't prefill with content like the desktop editor.
Mar 30 2022, 6:29 AM · Mobile, Chinese-Sites
Ammarpad added a comment to T299456: Make Skin::getPortletData private.

Thanks for the context @Nikerabbit. I'm not seeing any deprecation warnings in getPortletData for some reason and this function was deprecated in February. Perhaps there's a bug in the MWDebug::detectDeprecatedOverride call inside getPortletData in SkinTemplate and it only works for direct extending classes? SkinContentTranslation extends SkinMustache which extends SkinTemplate.

Mar 30 2022, 6:15 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, MW-1.39-release, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), MediaWiki-Core-Skin-Architecture

Mar 29 2022

Ammarpad awarded T304116: Making a MediaWiki Skin a Like token.
Mar 29 2022, 6:50 AM · Wikimedia-Hackathon-2022
Ammarpad added a comment to T299456: Make Skin::getPortletData private.

FemiwikiSkin and ContentTranslation skin are the remaining two callers of this method.

Mar 29 2022, 6:48 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, MW-1.39-release, MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), MediaWiki-Core-Skin-Architecture
Ammarpad updated the task description for T304320: Remove mediawiki.viewport module.
Mar 29 2022, 6:39 AM · Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), patch-welcome, MW-1.39-release, MediaWiki-Interface, good first task, MediaWiki-Core-Skin-Architecture

Mar 26 2022

Ammarpad changed the status of T228116: Make MediaWiki:Postedit-confirmation-saved differentiate between public wikis ("Your edit was published") and private wikis ("Your edit was saved") from In Progress to Open.

MediaWiki:Postedit-confirmation-created seems to have the same issue should be "The page has been published."

"The page has been published" is what I see on enwiki, are you seeing something different? Even for the edit it seems to work correctly for me now.

Mar 26 2022, 8:35 AM · Verified, MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Editing-team (FY2021-22 Kanban Board), MediaWiki-Page-editing, Voice & Tone
Ammarpad changed the status of T228116: Make MediaWiki:Postedit-confirmation-saved differentiate between public wikis ("Your edit was published") and private wikis ("Your edit was saved") from Open to In Progress.
Mar 26 2022, 7:43 AM · Verified, MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Editing-team (FY2021-22 Kanban Board), MediaWiki-Page-editing, Voice & Tone
Ammarpad added a comment to T228116: Make MediaWiki:Postedit-confirmation-saved differentiate between public wikis ("Your edit was published") and private wikis ("Your edit was saved").

This is supposed to be fixed by T183901. It indeed seems it probably never worked, because the JS variable (which controls varying the message) is set only on the editpage, not the published/saved page navigated to afterward.

Mar 26 2022, 6:43 AM · Verified, MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Editing-team (FY2021-22 Kanban Board), MediaWiki-Page-editing, Voice & Tone

Mar 25 2022

Ammarpad added a project to T266586: Use OOUI in SpecialCheckUserLog: CheckUser.
Mar 25 2022, 7:13 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Stewards-and-global-tools, CheckUser, Anti-Harassment
Ammarpad added a comment to T304574: [wmf.4] NewPagesFeed - Article for Creation filter does not work with All option.

I did not find what might have caused this recently.

Mar 25 2022, 7:28 AM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), PageTriage, Growth-Team

Mar 24 2022

Ammarpad closed T283915: Special:Contributions shows contribs when passed User:Foo, and also say "user does not exist" as Resolved.
Mar 24 2022, 7:13 PM · MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Platform Team Workboards (Clinic Duty Team), MediaWiki-Special-pages

Mar 23 2022

Ammarpad moved T304012: Future proof the live edit preview feature from Backlog to Live preview on the MediaWiki-Page-editing board.
Mar 23 2022, 5:23 PM · MediaWiki-Page-editing, MediaWiki-Interface, Editing-team
Ammarpad moved T304535: No media preview when enabled "uselivepreview" from Backlog to Live preview on the MediaWiki-Page-editing board.
Mar 23 2022, 5:22 PM · MediaWiki-Page-editing

Mar 21 2022

Ammarpad added a comment to T304353: PHP Warning: preg_match() expects parameter 2 to be string, array given.
Mar 21 2022, 8:52 PM · MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), API Platform, Platform Team Initiatives (MW REST API in PHP), User-Urbanecm_WMF (Engineering), Growth-Team (Current Sprint), MediaWiki-REST-API, GrowthExperiments-MentorDashboard, Wikimedia-production-error
Ammarpad updated the task description for T304325: Remove the ResourceLoaderSkinModule legacy feature stylesheet.
Mar 21 2022, 8:09 PM · MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), MediaWiki-skins-Amethyst, Anisa, BlueSky, MediaWiki-skins-Cavendish, GreyStuff, MediaWiki-skins-GuMaxDD, HasSomeColours, Truglass, WikimediaApiPortal, WoOgLeShades, MW-1.39-release

Mar 20 2022

Ammarpad claimed T252056: Regression: No page curation AfD log entries after 10 October 2019, and AfD nomination edit summary includes an empty string in parentheses.
Mar 20 2022, 7:04 PM · Growth-Team (Current Sprint), MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Regression, PageTriage
Ammarpad changed the status of T252056: Regression: No page curation AfD log entries after 10 October 2019, and AfD nomination edit summary includes an empty string in parentheses from Open to In Progress.

This is probably caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/535725 which was merged October 7, 2019, and reached enwiki October 10, which is the exact day the issue started.

Mar 20 2022, 11:59 AM · Growth-Team (Current Sprint), MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Regression, PageTriage
Ammarpad added a comment to T252056: Regression: No page curation AfD log entries after 10 October 2019, and AfD nomination edit summary includes an empty string in parentheses.

The empty parentheses are supposed to contain the nomination tag list, apparently empty list is sent to the API, but the parentheses are hard-corded in the message already.

Mar 20 2022, 11:43 AM · Growth-Team (Current Sprint), MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Regression, PageTriage

Mar 19 2022

Ammarpad closed T301752: API does not retrieve categories as Invalid.
Mar 19 2022, 4:55 AM · MediaWiki-Action-API, MediaWiki-Categories

Mar 18 2022

Ammarpad updated Ammarpad.
Mar 18 2022, 5:49 PM
Ammarpad closed T303690: Unchecking “Add header row” should remove the extra row in example preview, in Insert table dialog as Resolved.
Mar 18 2022, 1:12 PM · MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), WikiEditor
Ammarpad updated Ammarpad.
Mar 18 2022, 12:55 PM

Mar 16 2022

Ammarpad added a comment to T303862: TypeError: Argument 3 passed to MediaWiki\Mail\Emailer::send() must be of the type string, null given, called in /srv/mediawiki/php-1.38.0-wmf.25/includes/specials/SpecialEmailUser.php on line 500.

Note this is fixed only in master, which is 1.39 now. The error seems to be in 1.38.0-wmf.25, but I guess it's rare enough that this may not matter

Mar 16 2022, 7:44 PM · MW-1.39-notes (1.39.0-wmf.1; 2022-03-21-early), MediaWiki-Email, MediaWiki-Action-API, Wikimedia-production-error
Ammarpad added a comment to T303913: usprop=cancreate API returns a username can be created on some wikis but not actually.

I think it's better to provide a API parameter to decide whether to use user right in checking or to provide more information in API result.

Mar 16 2022, 11:57 AM · AntiSpoof, MediaWiki-extensions-CentralAuth
Ammarpad closed T303913: usprop=cancreate API returns a username can be created on some wikis but not actually as Invalid.
Mar 16 2022, 11:51 AM · AntiSpoof, MediaWiki-extensions-CentralAuth
Ammarpad added a comment to T303913: usprop=cancreate API returns a username can be created on some wikis but not actually.

Since we have unified login, I think it should have the same behavior on different wikis. It should return "cancreateerror" on zhwiki for username "BrionVIBBER".

It does (by default)

Screen Shot 2022-03-16 at 11.31.47 AM.png (807×1 px, 151 KB)

Mar 16 2022, 10:47 AM · AntiSpoof, MediaWiki-extensions-CentralAuth

Mar 15 2022

Ammarpad added a comment to T303571: Minerva should not touch red links to special pages.

Looks like this behaviour was added in T156879 but I don't see any involvement from WMF teams in this design decision which seems a little odd to me.

It was not added in that patch. It predates that patch for a decade actually, since 2007: 5bf4f2867748adba3a7d1678822a0ff78fba9ee8

Mar 15 2022, 11:50 AM · Patch-For-Review, Growth-Team, Readers-Web-Backlog, MinervaNeue

Mar 6 2022

Ammarpad created T303122: Do not show toolbar if textbox is hidden..
Mar 6 2022, 8:35 AM · MW-1.39-notes (1.39.0-wmf.2; 2022-03-21-late), WikiEditor

Mar 4 2022

Ammarpad closed T303033: Revision history not showing as Resolved.
Mar 4 2022, 2:49 PM · MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), MediaWiki-Page-history, Beta-Cluster-reproducible
Ammarpad removed a subtask for T300201: 1.38.0-wmf.25 deployment blockers: T303033: Revision history not showing.
Mar 4 2022, 2:48 PM · Patch-For-Review, Release-Engineering-Team (Next), Release, Train Deployments
Ammarpad removed a parent task for T303033: Revision history not showing: T300201: 1.38.0-wmf.25 deployment blockers.
Mar 4 2022, 2:48 PM · MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), MediaWiki-Page-history, Beta-Cluster-reproducible
Ammarpad added a comment to T303033: Revision history not showing.

This seems to be a fallout from https://gerrit.wikimedia.org/r/c/mediawiki/core/+/743562

Mar 4 2022, 9:58 AM · MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), MediaWiki-Page-history, Beta-Cluster-reproducible
Ammarpad triaged T303033: Revision history not showing as Unbreak Now! priority.
Mar 4 2022, 9:44 AM · MW-1.37-notes, MW-1.35-notes, MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), MediaWiki-Page-history, Beta-Cluster-reproducible

Mar 3 2022

Ammarpad added a comment to T302956: Tab uses "change protection settings for this page" even when the page isn't protected.

It can be temporarily fixed by creating the messages
https://www.mediawiki.org/wiki/MediaWiki:{skinname}-action-protect

Mar 3 2022, 8:27 AM · CologneBlue, Modern, MonoBook
Ammarpad edited projects for T302956: Tab uses "change protection settings for this page" even when the page isn't protected, added: MonoBook, Modern, CologneBlue; removed MediaWiki-Page-protection, MediaWiki-Interface (actions).

I don't think this should block the train, per the resolution of T300169. This only affects non-default skins.

Mar 3 2022, 8:13 AM · CologneBlue, Modern, MonoBook
Ammarpad added a comment to T302627: Skin continously switch to Vector 2022 despite (global) preferences.

FTR, this happens to me now for the third time (different days, all on mediawiki.org).

Mar 3 2022, 8:03 AM · MW-1.39-notes (1.39.0-wmf.6; 2022-04-04), MW-1.38-release, Community-Tech, MediaWiki-extensions-GlobalPreferences, Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Vector

Mar 1 2022

Ammarpad updated subscribers of T302840: Wrong language in en-gb MassMessage interface.

These translation were imported on Jan 28 here https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MassMessage/+/757824. They seem to be mistakenly done on en-gb, but were supposed to be Twi translations. Some (or all) of them were delated by @Amire80 few days after the import e.g https://translatewiki.net/wiki/MediaWiki:Massmessage-form-subject-help/en-gb, but I am not sure of the process that will kick to update that.

Mar 1 2022, 10:08 PM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), I18n, MassMessage
Ammarpad merged task T302829: Searching for numeric strings results in an Warning. into T301632: Integer search terms cause error.
Mar 1 2022, 7:45 PM · AhoCorasick
Ammarpad merged T302829: Searching for numeric strings results in an Warning. into T301632: Integer search terms cause error.
Mar 1 2022, 7:45 PM · AhoCorasick
Ammarpad added a comment to T299780: onMwLoadEnd test failing regularly blocking mergings across repositories.

Again for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/767224

✔ 1659 tests completed
19:11:49 ℹ 11 tests skipped
19:11:49 ✖ 1 test failed
19:11:49 
19:11:49 FAILED TESTS:
19:11:49   ext.navigationTiming
19:11:49     ✖ onMwLoadEnd - controlled
19:11:49       Chrome Headless 90.0.4430.212 (Linux x86_64)
19:11:49     resolved after fail+ok
19:11:49     Expected: [
19:11:49       "call"
19:11:49     ]
19:11:49     Actual: []
19:11:49         at Object.<anonymous> ( ...
Mar 1 2022, 6:30 PM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), ci-test-error (WMF-deployed Build Failure), Patch-For-Review, NavigationTiming, Performance-Team

Feb 28 2022

Ammarpad updated the task description for T302669: ApiOptionsHook should allow modifying options.
Feb 28 2022, 3:45 PM · MediaWiki-Core-Preferences, MediaWiki-Action-API
Ammarpad closed T294778: ApiQueryAllUsers with activeusers=1 excludes some clearly active users as Resolved.

This task and T263931 were reported a month apart, it was probably the same issue at the time.
I think we have to close this just like T263931 since it's not reproducible anymore and no clear way to even start debugging.

Feb 28 2022, 9:11 AM · MediaWiki-User-management

Feb 27 2022

Ammarpad added a comment to T302669: ApiOptionsHook should allow modifying options.

I think it can be used partially (i.e to block save or modify the value), but you cannot communicate back error/warning to the API (at least without some core modification).

Feb 27 2022, 8:08 PM · MediaWiki-Core-Preferences, MediaWiki-Action-API
Ammarpad added a comment to T300314: [breaking, April 2022] Plan for eventual removal of styles for messagebox, successbox, errorbox and warningbox classes in mediawiki core.

I'm a little bit confusing, is it means we are no longer allowed to use something like class="messagebox" etc. in pages and system message?

No. You can, but you have to provide the styling/CSS yourself. In other words, you should not use class="messagebox" in your scripts/on-wiki pages and expect MediaWiki core to provide the styling.

Feb 27 2022, 8:01 PM · User-notice
Ammarpad added a project to T294778: ApiQueryAllUsers with activeusers=1 excludes some clearly active users: TestMe.
Feb 27 2022, 10:17 AM · MediaWiki-User-management
Ammarpad added a comment to T294778: ApiQueryAllUsers with activeusers=1 excludes some clearly active users.

This is no longer reproducible, it seems. The user is shown at both the special page and the API list.

Feb 27 2022, 10:16 AM · MediaWiki-User-management
Ammarpad updated the task description for T302669: ApiOptionsHook should allow modifying options.
Feb 27 2022, 9:23 AM · MediaWiki-Core-Preferences, MediaWiki-Action-API
Ammarpad added a comment to T302250: Logstash Access for Ammarpad.

Thank you @Dzahn.

Feb 27 2022, 9:23 AM · SRE, LDAP-Access-Requests
Ammarpad created T302669: ApiOptionsHook should allow modifying options.
Feb 27 2022, 9:17 AM · MediaWiki-Core-Preferences, MediaWiki-Action-API

Feb 25 2022

Ammarpad added a comment to T298638: Make modifications to Pager HTML to add heading separators to support Minerva skinning.
QA Steps

@ovasileva I modified my css and I still don't see any difference in beta for these three pages with or without css in beta.

❓ AC2: If I edit my user CSS e.g. User:<your username>/common.css .mw-changeslist-time, .mw-index-pager-list-header { display: !important; } all edits on the Special:Contributions, Special:MergeHistory and history page should be separated by date.

There's a mistake in that CSS. I think the correct CSS should be:

.mw-index-pager-list-header { display: block !important; }
Feb 25 2022, 1:59 PM · User-brennen, MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, User-notice, Platform Engineering, Readers-Web-Backlog (Kanbanana-FY-2021-22), MediaWiki-Page-history, User-Jdlrobson, MobileFrontend (MobileFrontend Special Pages)

Feb 24 2022

Ammarpad added a comment to T296126: TypeError from line 1007 of Parser.php: Return value of Parser::getTitle() must be an instance of Title, null returned.

Here is a quick fix in MediaWiki core 1.35 or 1.36:

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/544249

I should be investigated further, but getTitle() simply returns $this->mTitle, which is documented as being Title|null, so it seems to be logical that getTitle() returns Title|null.

The doc has this:

/**
 * Since 1.34, leaving `mTitle` uninitialized or setting `mTitle` to
 * `null` is deprecated.
 *
 * @var Title|null
 * @deprecated since 1.35, use Parser::getTitle()
*/
Feb 24 2022, 6:03 PM · MediaWiki-extensions-Lingo
Ammarpad updated the task description for T263213: Data shared between SkinMustache and SkinTemplate should be common.
Feb 24 2022, 3:51 PM · MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), MediaWiki-Core-Skin-Architecture (Menus 2.0), MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Patch-For-Review, MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED)
Ammarpad renamed T301523: Create the SkinComponentTableOfContents from Create the SkinTableOfContentsComponent to Create the SkinComponentTableOfContents.
Feb 24 2022, 3:50 PM · MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), MediaWiki-Core-Skin-Architecture (Menus 2.0)
Ammarpad placed T270754: [1.39] Remove the deprecated Skin::getSkinStylePath() up for grabs.
Feb 24 2022, 11:59 AM · MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), Patch-For-Review, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Technical-Debt (Deprecation process), Material, Apex, Metrolook, MediaWiki-Core-Skin-Architecture
Ammarpad removed a project from T270033: Fix and enforce table prefix usage in columns and indexes in core: Patch-For-Review.
Feb 24 2022, 11:58 AM · Performance-Team (Radar), MW-1.37-notes (1.37.0-wmf.14; 2021-07-12), MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Wikimedia-Rdbms
Ammarpad closed T263340: Fatal InvalidArgumentException "the provided Title object belongs to page" when viewing pages with history broken by Special:MergeHistory as Resolved.

This task is resolved. See for T302486 the next step.

Feb 24 2022, 11:58 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Platform Team Workboards (Clinic Duty Team), MediaWiki-MergeHistory, Wikimedia-production-error
Ammarpad created T302486: Run fixMergeHistoryCorruption.php on affected wikis.
Feb 24 2022, 11:57 AM · Wikimedia-maintenance-script-run
Ammarpad placed T300358: Fix uses of (error|warning)box (MediaWiki core) up for grabs.
Feb 24 2022, 11:37 AM · MW-1.39-notes (1.39.0-wmf.5; 2022-03-28), Readers-Web-Backlog (Kanbanana-FY-2021-22), MW-1.39-release, MediaWiki-General, MediaWiki-Core-Skin-Architecture, MediaWiki-User-login-and-signup, Technical-Debt (Deprecation process), Platform Engineering
Ammarpad added a comment to T300069: wfMessageFallback doesn't play well with qqx.

This is now reverted per T302469: Recent message fallback change breaks fundraising banners

Feb 24 2022, 11:30 AM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), User-notice, Platform Engineering, MediaWiki-Internationalization
Ammarpad reopened T300069: wfMessageFallback doesn't play well with qqx as "Open".
Feb 24 2022, 11:27 AM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), User-notice, Platform Engineering, MediaWiki-Internationalization
Ammarpad added a comment to T302250: Logstash Access for Ammarpad.

Hi @Dzahn, I have sent.

Feb 24 2022, 11:26 AM · SRE, LDAP-Access-Requests

Feb 23 2022

Ammarpad merged T302376: Duplicated "Add discussion" button in talk pages on mobile into T302388: Discussion Tools features are unexpectedly enabled on mobile ([reply] links, "Add discussion" button, [subscribe] links).
Feb 23 2022, 1:25 PM · Verified, MW-1.38-notes (1.38.0-wmf.22; 2022-02-14), Editing-team (FY2021-22 Kanban Board), DiscussionTools, MinervaNeue
Ammarpad merged task T302376: Duplicated "Add discussion" button in talk pages on mobile into T302388: Discussion Tools features are unexpectedly enabled on mobile ([reply] links, "Add discussion" button, [subscribe] links).
Feb 23 2022, 1:24 PM · Mobile, MobileFrontend, MinervaNeue

Feb 22 2022

Ammarpad added a comment to T283915: Special:Contributions shows contribs when passed User:Foo, and also say "user does not exist".

https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Beitr%C3%A4ge/Benutzer:Umherirrender works (no warnbox, but header still shows the namespace), it is using the content language (de) form of NS_USER, while

The header is based on the bad URL, while it's good to fix, it doesn't seem essential to me here. The URL will anyway remain the way it is. It should be redirected to the canonical form and the header will then automatically update.

https://de.wikipedia.beta.wmflabs.org/wiki/Spezial:Beitr%C3%A4ge/User:Umherirrender does not work (it shows the warnbox)

Why will someone do that? (the interface will not output such links). Even on English Wikipedia User:User:User:Foo will not work because only the first prefix is stripped, but since this is garbage, it seems appropriate to return in kind.

It would also break with all the other title normalization like whitespaces

No, as Language itself does not do that always. Even if we use nsIndex, Language::getNsIndex("User ") is always false.

...underscores, case-insensitive of namespaces. The lookup text => constant typically ignore all of this parts (Language::getNsIndex).

Underscores are always removed, maybe case-insensitiveness can be supported, but same as above. It's not very common.

Feb 22 2022, 7:31 AM · MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Platform Team Workboards (Clinic Duty Team), MediaWiki-Special-pages

Feb 21 2022

Ammarpad closed T293665: User page link is red in diff and history pages edit summary despite global user page existing as Resolved.

This is now fixed. Example from dup (T297192): https://en.wikipedia.org/w/index.php?title=User:Alexis_Jazz/sandbox3&diff=1059094223&oldid=1042208596

Feb 21 2022, 9:36 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Regression, GlobalUserPage
Ammarpad created T302250: Logstash Access for Ammarpad.
Feb 21 2022, 9:32 PM · SRE, LDAP-Access-Requests

Feb 18 2022

Ammarpad merged task T302097: "View" tab no longer has a label into T302082: "Read" menu item does not appear correctly on articles.
Feb 18 2022, 8:31 PM · Desktop Improvements
Ammarpad merged T302097: "View" tab no longer has a label into T302082: "Read" menu item does not appear correctly on articles.
Feb 18 2022, 8:30 PM · Vector, Beta-Cluster-reproducible
Ammarpad moved T283915: Special:Contributions shows contribs when passed User:Foo, and also say "user does not exist" from Later to Inbox on the Platform Team Workboards (Clinic Duty Team) board.
Feb 18 2022, 8:09 PM · MW-1.38-notes (1.38.0-wmf.23; 2022-02-21), Platform Team Workboards (Clinic Duty Team), MediaWiki-Special-pages