Page MenuHomePhabricator

Amorymeltzer
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 21 2018, 9:21 PM (174 w, 16 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
Amorymeltzer [ Global Accounts ]

Recent Activity

Mon, Jun 7

Amorymeltzer awarded T270623: Add checkbox to toggle autoblocks on Special:BlockList a Love token.
Mon, Jun 7, 1:49 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), MediaWiki-Blocks

May 8 2021

Amorymeltzer added a comment to T23272: Graphically differentiate in history and logs revisions which are deleted from those suppressed.

I think OSers should see the bold — we want the visual differentiation — but it does show for non-OSErs. Is that a problem? It reveals more information that way. It's occasionally possible to determine via absence in public logs, but not always. Diffs aren't readily accessible, but they do appear to show the same thing and explicitly state revdel or OSed.

May 8 2021, 10:17 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-Revision-deletion

Apr 13 2021

Amorymeltzer awarded T278129: Install emacs-25 on bastion hosts a Love token.
Apr 13 2021, 6:17 PM · cloud-services-team (Kanban), Toolforge (Software install/update)

Mar 31 2021

Amorymeltzer added a comment to T278897: MediaWiki API is not returning blocks when start/end dates are set.

@Urbanecm I imagine most folks making the mistake expect "xxdir" to be a "sorted by," so likely misread "in which direction to enumerate" as "sort by" when it actually means "items move in this direction." Similar to if you're driving south, you'll pass the most-northern exit first.

Mar 31 2021, 10:53 AM · MediaWiki-API

Feb 27 2021

Amorymeltzer added a comment to T275755: Old revision edit summary doesn't show change tags.

@Aklapper Is it possible you misread this? I don't really know what the editor has to do with it (it's already there) or what this has to do with the latest revision specifically?

Feb 27 2021, 11:25 AM · MediaWiki-General

Feb 25 2021

Amorymeltzer created T275755: Old revision edit summary doesn't show change tags.
Feb 25 2021, 12:10 PM · MediaWiki-General

Feb 18 2021

Amorymeltzer added a comment to T275131: Use meaningful identifiers for fields in ProtectionForm to allow CSS styling.

You can use the name of the checkbox, so document.getElementsByName('mwProtect-cascade')[0]

Feb 18 2021, 3:26 PM · MediaWiki-Page-protection

Feb 3 2021

Amorymeltzer added a comment to T272179: Console warning from momentjs: "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format" when selecting block expiration.

No idea!

Feb 3 2021, 12:19 PM · MediaWiki-Blocks, JavaScript
Amorymeltzer added a comment to T273374: Uncaught TypeError: navigator.sendBeacon is not a function.

@Milimetric Ach yeah, it'll be some ad blocker. Haven't figured out which yet, but sorry for hassle. I've also just found T86680, which makes it clear.

Feb 3 2021, 11:57 AM · Patch-For-Review, Analytics-Kanban, Analytics, Analytics-EventLogging

Feb 2 2021

Amorymeltzer added a comment to T273374: Uncaught TypeError: navigator.sendBeacon is not a function.

@Ottomata Firefox 78, but I also get it in Safari; a quick test suggested I wasn't seeing it in Chrome?

Feb 2 2021, 6:23 PM · Patch-For-Review, Analytics-Kanban, Analytics, Analytics-EventLogging

Jan 31 2021

Amorymeltzer added a comment to T273374: Uncaught TypeError: navigator.sendBeacon is not a function.

@Aklapper it's navigator.sendBeacon(config.serviceUri, JSON.stringify(eventData)); in the core.submit definition, which, from codesearch, is from the Event Logging extension: https://gerrit.wikimedia.org/g/mediawiki/extensions/EventLogging/+/a27b4a1f3d235ace86d93c4f2bb4a60fcb7c9b97/modules/ext.eventLogging/core.js#398

Jan 31 2021, 1:54 PM · Patch-For-Review, Analytics-Kanban, Analytics, Analytics-EventLogging

Jan 30 2021

Amorymeltzer created T273374: Uncaught TypeError: navigator.sendBeacon is not a function.
Jan 30 2021, 10:23 PM · Patch-For-Review, Analytics-Kanban, Analytics, Analytics-EventLogging
Amorymeltzer added a comment to T72470: Remove legacy javascript globals.

Just by means of an enwiki update, I wanted to note this discussion on the int-admin's board: https://en.wikipedia.org/wiki/Wikipedia:Interface_administrators%27_noticeboard#Removing_legacy_javascript_globals_from_skin_pages

Jan 30 2021, 10:11 PM · User-Ladsgroup, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, MW-1.35-notes, Patch-For-Review, MW-1.35-release, User-notice, Technical-Debt (Deprecation process), Performance-Team-publish, Performance-Team, MediaWiki-ResourceLoader, JavaScript

Jan 26 2021

Amorymeltzer added a watcher for tech-decision-forum: Amorymeltzer.
Jan 26 2021, 2:22 AM

Jan 24 2021

Amorymeltzer added a comment to T72470: Remove legacy javascript globals.

There's a discrete (if lengthy) number of items, so one could list 'em all. Alternatively, regex makes it fairly doable (this is what I was doing).

Jan 24 2021, 11:32 AM · User-Ladsgroup, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, MW-1.35-notes, Patch-For-Review, MW-1.35-release, User-notice, Technical-Debt (Deprecation process), Performance-Team-publish, Performance-Team, MediaWiki-ResourceLoader, JavaScript

Jan 23 2021

Amorymeltzer added a comment to T72470: Remove legacy javascript globals.

FWIW on enwiki (which I presume is the bulk of it), I intend on reviving that this weekend since I do have a list to go off of.

Jan 23 2021, 11:10 AM · User-Ladsgroup, MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), MW-1.36-notes, MW-1.35-notes, Patch-For-Review, MW-1.35-release, User-notice, Technical-Debt (Deprecation process), Performance-Team-publish, Performance-Team, MediaWiki-ResourceLoader, JavaScript
Amorymeltzer added a comment to T272526: Change enwiki logo to "Option A" until February 4.

I'm discussing this with legoktm on-wiki, but I want to apologize here to all I put in a tough position on a Friday, especially you Andre as it seems I did not appreciate the severity or urgency of your note in T272526#6769471.

Jan 23 2021, 1:37 AM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Amorymeltzer awarded T272526: Change enwiki logo to "Option A" until February 4 a Love token.
Jan 23 2021, 1:35 AM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests

Jan 22 2021

Amorymeltzer added a comment to T272526: Change enwiki logo to "Option A" until February 4.

Wasn't trying to blame you or anyone @Urbanecm, sorry if it came off that way; I just meant that we were asked to deal with this locally since there wasn't movement here and folks were antsy. Not the first time that enwiki had a different timeline in line than the dev volunteers!

Jan 22 2021, 10:15 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Amorymeltzer added a comment to T272526: Change enwiki logo to "Option A" until February 4.

Yes, thanks @Aklapper, I was indeed aware of that. No one intends this to be the solution, just a stopgap since work here stalled and nobody can continue until the beginning of next week, nearly half-way through the allotted timeframe.

Jan 22 2021, 5:41 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Amorymeltzer added a comment to T272526: Change enwiki logo to "Option A" until February 4.

Per community consensus, I've put up the hacky CSS to put in a new image. This is not ideal, but given the time frame, folks wanted it. Please do revert if it slows everything way tf down

Jan 22 2021, 4:07 PM · Patch-For-Review, User-Urbanecm, Wikimedia-Site-requests
Amorymeltzer added a comment to T270796: Message boxes classes should carry `mw-`.

I may be mistaken, but isn't the issue with the eventual removal (not the deprecation here) that there are, as noted in T270796#6714564, a huge number of uses of these in active use? If there are really hundreds of thousands of edits to be made, I'm not sure saying "the old class names... don't work..." is entirely accurate.

Jan 22 2021, 1:34 PM · MediaWiki-Core-Skin-Architecture, MW-1.37-release, Readers-Web-Backlog, User-notice, MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Tech-Ambassadors, MediaWiki-Installer, MediaWiki-General, CSS

Jan 20 2021

Amorymeltzer added a comment to T268834: Watchlist Expiry: prop=info&inprop=watched should show some indication of expiry.

Already in use, thanks all!

Jan 20 2021, 12:41 AM · Community-Tech (Kanban-2020-21-Q3), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Expiring-Watchlist-Items
Amorymeltzer awarded T268834: Watchlist Expiry: prop=info&inprop=watched should show some indication of expiry a Like token.
Jan 20 2021, 12:41 AM · Community-Tech (Kanban-2020-21-Q3), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Expiring-Watchlist-Items

Jan 19 2021

Amorymeltzer added a comment to T272294: Add watchuser to userrights API.

Yes, just like block/T257662

Jan 19 2021, 11:21 AM · MediaWiki-User-management, MediaWiki-API

Jan 18 2021

Amorymeltzer created T272294: Add watchuser to userrights API.
Jan 18 2021, 12:32 PM · MediaWiki-User-management, MediaWiki-API

Jan 15 2021

Amorymeltzer renamed T272179: Console warning from momentjs: "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format" when selecting block expiration from Console warning: "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format" when selecting block expiration to Console warning from momentjs: "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format" when selecting block expiration.
Jan 15 2021, 8:09 PM · MediaWiki-Blocks, JavaScript
Amorymeltzer updated the task description for T272179: Console warning from momentjs: "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format" when selecting block expiration.
Jan 15 2021, 8:08 PM · MediaWiki-Blocks, JavaScript
Amorymeltzer created T272179: Console warning from momentjs: "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format" when selecting block expiration.
Jan 15 2021, 8:06 PM · MediaWiki-Blocks, JavaScript

Jan 13 2021

Amorymeltzer updated subscribers of T206954: Enable wgRelevantUserName for IP ranges.
Jan 13 2021, 8:00 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), MediaWiki-User-management, MediaWiki-Special-pages
Amorymeltzer created T271923: How to determine if an IP range is beyond $wgBlockCIDRLimit.
Jan 13 2021, 1:41 PM · MediaWiki-User-management

Jan 12 2021

Amorymeltzer added a comment to T271804: PHP Notice: Undefined index: Alsjdakjsdh.

Triggered by requesting page info of non-existing pages. Should be fixed by the patch I just uploaded.

Jan 12 2021, 3:30 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-Watchlist, Community-Tech, Growth-Team, Expiring-Watchlist-Items, Platform Team Initiatives (API Gateway), Wikimedia-production-error
Amorymeltzer added a comment to T268834: Watchlist Expiry: prop=info&inprop=watched should show some indication of expiry.

Just to confirm @MusikAnimal, am I right that this change has also tweaked (corrected?) the return value of watched when using format=json&formatversion=2? Without this change, a title I'm not watching returns "watched": false while after this change, it does not return watched. That's seems more correct, but just wanted to confirm since it wasn't mentioned.

Jan 12 2021, 12:08 PM · Community-Tech (Kanban-2020-21-Q3), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Expiring-Watchlist-Items

Dec 24 2020

Amorymeltzer added a comment to T146628: Add IP range support to [[Special:Log]].

This is likely to become more apparent once T206954 is fully implemented.

Dec 24 2020, 12:42 PM · MediaWiki-Logevents

Dec 22 2020

Amorymeltzer awarded T270737: Logs don't handle range blocks as expected a Like token.
Dec 22 2020, 9:45 PM · MediaWiki-Logevents, MediaWiki-API
Amorymeltzer edited projects for T270737: Logs don't handle range blocks as expected, added: MediaWiki-Logevents; removed MediaWiki-User-management.
Dec 22 2020, 9:21 PM · MediaWiki-Logevents, MediaWiki-API
Amorymeltzer renamed T270737: Logs don't handle range blocks as expected from logevents API doesn't handle range blocks as expected to Logs don't handle range blocks as expected.
Dec 22 2020, 9:20 PM · MediaWiki-Logevents, MediaWiki-API
Amorymeltzer added a comment to T270737: Logs don't handle range blocks as expected.

I suppose that's a better/bigger point than just the api: the on-wiki block log differs (1, 2) despite blocking being the same.

Dec 22 2020, 9:15 PM · MediaWiki-Logevents, MediaWiki-API
Amorymeltzer created T270737: Logs don't handle range blocks as expected.
Dec 22 2020, 8:31 PM · MediaWiki-Logevents, MediaWiki-API

Dec 21 2020

Amorymeltzer edited projects for T270623: Add checkbox to toggle autoblocks on Special:BlockList, added: MediaWiki-Blocks; removed MediaWiki-Special-pages.

I think -Blocks, but yeah, thanks

Dec 21 2020, 6:44 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), MediaWiki-Blocks
Amorymeltzer changed the subtype of T270623: Add checkbox to toggle autoblocks on Special:BlockList from "Task" to "Feature Request".
Dec 21 2020, 12:50 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), MediaWiki-Blocks
Amorymeltzer created T270623: Add checkbox to toggle autoblocks on Special:BlockList.
Dec 21 2020, 12:50 PM · MW-1.37-notes (1.37.0-wmf.9; 2021-06-07), Anti-Harassment (The Letter Song), MediaWiki-Blocks

Dec 19 2020

Amorymeltzer added a comment to T206954: Enable wgRelevantUserName for IP ranges.

I suppose it depends on how you view wgRelevantUserName. It doesn't exist for non-existent usernames, which maybe implies it shouldn't be defined outside CIDR limits? Regardless, that fact makes wgRelevantUserName a reliable "does this single editor exist?" marker. IPs and specifically IP ranges are clearly a different beast, but at the moment, wgRelevantUserName indicates a working single user (ip or registered username), and is unhelpful for ranges. After this, it will indicate a registered user, a single ip, or a range; if it doesn't take into account CIDR limits, then maybe it's sort of a "anything I see would have a talk page" marker, but it would no longer be a reliable marker for "can I do things (e.g. block) with this?" On the flip side, something like mw.util.isIPv4Address doesn't bother with CIDR limits, so one might not expect this to, either.

Dec 19 2020, 8:01 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), MediaWiki-User-management, MediaWiki-Special-pages
Amorymeltzer added a comment to T206954: Enable wgRelevantUserName for IP ranges.

Will this/these define wgRelevantUsername for a range outside of the CIDR limit? Similar to your proposed work in T211910 @Ammarpad, but curious to know.

Dec 19 2020, 12:59 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), MediaWiki-User-management, MediaWiki-Special-pages

Dec 16 2020

Amorymeltzer awarded T206954: Enable wgRelevantUserName for IP ranges a Party Time token.
Dec 16 2020, 8:14 PM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), MediaWiki-User-management, MediaWiki-Special-pages

Dec 15 2020

Amorymeltzer awarded T260904: Overhaul the interface for suppressing AbuseLog entries a Love token.
Dec 15 2020, 9:25 PM · User-notice, AbuseFilter (Overhaul-2020)

Dec 14 2020

Amorymeltzer added a comment to T270057: Expose watchlist (expiry) status to JS without another query.

That, and: since I can toggle my watchlist freely on the page, I think that would make it the *only* mw.config item to be able to change once the page has loaded? That would be weird.

Dec 14 2020, 12:55 PM · Expiring-Watchlist-Items, JavaScript, MediaWiki-API, Community-Tech

Dec 13 2020

Amorymeltzer changed the subtype of T270057: Expose watchlist (expiry) status to JS without another query from "Task" to "Feature Request".
Dec 13 2020, 9:01 PM · Expiring-Watchlist-Items, JavaScript, MediaWiki-API, Community-Tech
Amorymeltzer created T270057: Expose watchlist (expiry) status to JS without another query.
Dec 13 2020, 9:01 PM · Expiring-Watchlist-Items, JavaScript, MediaWiki-API, Community-Tech

Dec 7 2020

Amorymeltzer updated subscribers of T268834: Watchlist Expiry: prop=info&inprop=watched should show some indication of expiry.

To clarify (@DannyS712 you might be able to correct me if I'm wrong) without this, I don't think there's a reliable way to get watchlist expiry status for a given page? T263796 helps but wouldn't cover it.

Dec 7 2020, 5:20 PM · Community-Tech (Kanban-2020-21-Q3), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Expiring-Watchlist-Items

Nov 26 2020

Amorymeltzer added a watcher for Expiring-Watchlist-Items: Amorymeltzer.
Nov 26 2020, 3:11 PM
Amorymeltzer changed the subtype of T268834: Watchlist Expiry: prop=info&inprop=watched should show some indication of expiry from "Task" to "Feature Request".
Nov 26 2020, 3:01 PM · Community-Tech (Kanban-2020-21-Q3), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Expiring-Watchlist-Items
Amorymeltzer created T268834: Watchlist Expiry: prop=info&inprop=watched should show some indication of expiry.
Nov 26 2020, 3:00 PM · Community-Tech (Kanban-2020-21-Q3), MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Expiring-Watchlist-Items

Nov 23 2020

Amorymeltzer updated the task description for T268513: PageTriage's external Date.js modifies/overwrites native JavaScript Date prototype, should be updated.
Nov 23 2020, 7:01 PM · Patch-For-Review, Technical-Debt, Growth-Team-Filtering, Growth-Team, JavaScript, PageCuration
Amorymeltzer updated the task description for T268513: PageTriage's external Date.js modifies/overwrites native JavaScript Date prototype, should be updated.
Nov 23 2020, 6:24 PM · Patch-For-Review, Technical-Debt, Growth-Team-Filtering, Growth-Team, JavaScript, PageCuration
Amorymeltzer created T268513: PageTriage's external Date.js modifies/overwrites native JavaScript Date prototype, should be updated.
Nov 23 2020, 5:41 PM · Patch-For-Review, Technical-Debt, Growth-Team-Filtering, Growth-Team, JavaScript, PageCuration

Nov 21 2020

Amorymeltzer updated the task description for T267922: logevents letype=stable returns poorly formatted expiry.
Nov 21 2020, 1:07 AM · Platform Engineering, MediaWiki-API, MediaWiki-extensions-FlaggedRevs

Nov 16 2020

Amorymeltzer added projects to T267922: logevents letype=stable returns poorly formatted expiry: MediaWiki-extensions-FlaggedRevs, MediaWiki-API.
Nov 16 2020, 1:19 PM · Platform Engineering, MediaWiki-API, MediaWiki-extensions-FlaggedRevs
Amorymeltzer created T267922: logevents letype=stable returns poorly formatted expiry.
Nov 16 2020, 1:16 PM · Platform Engineering, MediaWiki-API, MediaWiki-extensions-FlaggedRevs

Nov 14 2020

Amorymeltzer added a watcher for JSDoc WMF theme: Amorymeltzer.
Nov 14 2020, 4:28 PM

Nov 13 2020

Amorymeltzer added a comment to T267837: Move in intestactions doesn't pick up if the page is only covered by cascading protection.

@Umherirrender Indeed — that'd be T27912, which, no joke, you opened exactly ten years ago!

Nov 13 2020, 7:15 PM · User-DannyS712, MediaWiki-Page-protection, Platform Engineering, MediaWiki-API
Amorymeltzer added a comment to T267837: Move in intestactions doesn't pick up if the page is only covered by cascading protection.

@DannyS712 Sorry, I realize in my haste I wasn't fully clear: I meant a page protected only by virtue of being transcluded, not the page that is directly cascade protected. See, e.g., https://test.wikipedia.org/w/api.php?action=query&format=json&prop=info&titles=Page4242&intestactions=edit%7Cmove

Nov 13 2020, 2:17 PM · User-DannyS712, MediaWiki-Page-protection, Platform Engineering, MediaWiki-API
Amorymeltzer renamed T267837: Move in intestactions doesn't pick up if the page is only covered by cascading protection from Move in intestactions doesn't pick up if the page is covered by cascading protection to Move in intestactions doesn't pick up if the page is only covered by cascading protection.
Nov 13 2020, 2:15 PM · User-DannyS712, MediaWiki-Page-protection, Platform Engineering, MediaWiki-API
Amorymeltzer created T267837: Move in intestactions doesn't pick up if the page is only covered by cascading protection.
Nov 13 2020, 1:35 PM · User-DannyS712, MediaWiki-Page-protection, Platform Engineering, MediaWiki-API

Nov 2 2020

Amorymeltzer added a comment to T267066: Top of page icons are oriented vertically rather than horizontally in modern skin.

Duplicate of T265763, I believe

Nov 2 2020, 8:46 PM · Modern

Oct 31 2020

Amorymeltzer added a comment to T246931: Modern echo icons too high up.

@Demian I filed that as T265832, I think it's related to T248751 not this, based on when it started to appear.

Oct 31 2020, 5:01 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), User-Demian, Notifications, Modern, Growth-Team

Oct 28 2020

Amorymeltzer awarded T256466: Opening Echo flyout undefines $.widget.extend (jQuery UI) if there are past notifications a Like token.
Oct 28 2020, 6:20 PM · Wikimedia-production-error, Growth-Team, Notifications

Oct 24 2020

Amorymeltzer added a comment to T265387: Uncaught TypeError: $.widget.extend is not a function at openDialog (logspam).

Superficially, this looks related to T256466? AFAICT that looks to have been resolved sometime in the last week or so, so I can't confirm the message I received there, but the (fractional?) request url here would suggest a different pathway.

Oct 24 2020, 12:31 AM · Editing-team, JavaScript, Wikimedia-production-error, WikiEditor
Amorymeltzer added a comment to T256466: Opening Echo flyout undefines $.widget.extend (jQuery UI) if there are past notifications.

@Fomafix Can you still see this? I'm no longer able to replicate it, so I'm hoping this got fixed somewhere.

Oct 24 2020, 12:27 AM · Wikimedia-production-error, Growth-Team, Notifications

Oct 21 2020

Amorymeltzer added a comment to T266082: When a revision is suppressed, any abusefilter hits should also be suppressed.

It is: the AbuseLog entry won't be crossed out and italicized, but it should have a trailing (hidden because revision has been deleted), which is accurate. It will still show up as "visible" in the search filter since it was not explicitly hidden, but it remains tied to the revision. That is, if the revision is unhidden, the AbuseLog entry will be as wel.

Oct 21 2020, 1:53 AM · MediaWiki-Revision-deletion, AbuseFilter

Oct 18 2020

Amorymeltzer changed the subtype of T265832: Weird text overlay in Modern's echo indicators from "Task" to "Bug Report".
Oct 18 2020, 5:42 PM · Modern (Tracking), Technical-Debt, User-Demian, Patch-For-Review
Amorymeltzer created T265832: Weird text overlay in Modern's echo indicators.
Oct 18 2020, 5:41 PM · Modern (Tracking), Technical-Debt, User-Demian, Patch-For-Review

Oct 17 2020

Amorymeltzer added a comment to T202989: Administrators can no longer view deleted history of js/css pages.

There is no justification for preventing administrators viewing or restoring this.

Oct 17 2020, 7:53 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-notice, User-DannyS712, Security, User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, JavaScript
Amorymeltzer added a comment to T222402: Page or file undelete/restore requests can deadlock (Fatal DBQueryError).

Thanks for the bump @Umherirrender, I've been meaning to comment that yes, I haven't run into it at all and even after removing my safeguards, don't trigger it anymore so seems great on my end AFAICT.

Oct 17 2020, 12:53 AM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Platform Team Workboards (External Code Reviews), Wikimedia-production-error, MediaWiki-Page-deletion, MediaWiki-API

Oct 16 2020

Amorymeltzer created T265763: .mw-indicators in Modern skin displaying vertically/improperly.
Oct 16 2020, 8:50 PM · MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), Regression, Modern

Oct 15 2020

Amorymeltzer created T265626: Protect API can allow (and display) an inaccurate move level alongside cascade protection.
Oct 15 2020, 3:21 PM · MediaWiki-API, MediaWiki-Page-protection

Sep 22 2020

Amorymeltzer awarded T263501: Move DeviceDetection.php from MobileFrontend to core a Like token.
Sep 22 2020, 11:17 AM · MobileFrontend (Tracking), Readers-Web-Backlog (Tracking), MediaWiki-Interface
Amorymeltzer added a comment to T263513: Create a Special:Namespaces page.

Love it.

Sep 22 2020, 11:16 AM · MediaWiki-General, Patch-For-Review, User-DannyS712

Sep 20 2020

Amorymeltzer added a comment to T247915: Deprecate 'watch' parameter in favor of 'watchlist' parameter in FlaggedRevs stabilize API.

FWIW, it looks apihelp-stabilize-param-watchlist needs adding to all the i18n pages. Presumably it can just copy the text used everywhere by apihelp-*-param-watchlist in core?

Sep 20 2020, 2:12 PM · MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), Platform Team Workboards (External Code Reviews), User-notice, User-DannyS712, MediaWiki-API, MediaWiki-extensions-FlaggedRevs

Sep 19 2020

Amorymeltzer added a subtask for T248407: Add expiry support to remaining APIs that watch pages: T263336: Add watchlist expiry support to FlaggedRevs' stabilize API.
Sep 19 2020, 6:40 PM · MediaWiki-API, Expiring-Watchlist-Items, Community-Tech
Amorymeltzer added a parent task for T263336: Add watchlist expiry support to FlaggedRevs' stabilize API: T248407: Add expiry support to remaining APIs that watch pages.
Sep 19 2020, 6:40 PM · Platform Engineering Roadmap Decision Making, Community-Tech, MediaWiki-API, Expiring-Watchlist-Items, MediaWiki-extensions-FlaggedRevs
Amorymeltzer created T263336: Add watchlist expiry support to FlaggedRevs' stabilize API.
Sep 19 2020, 6:39 PM · Platform Engineering Roadmap Decision Making, Community-Tech, MediaWiki-API, Expiring-Watchlist-Items, MediaWiki-extensions-FlaggedRevs

Sep 18 2020

Amorymeltzer added a comment to T255903: Wrap "username or IP address removed" comment in a span and appropriate class.

The difference, though, is that history-deleted is marking text that is used as a stand-in for the hidden user name in a history or diff, whereas this text is presented in addition in order to provide some information, as the username is not displayed on each li on Special:Contributions. This text is thus (potentially) the only marker on Special:Contributions that a revision has had just the username revdel'd. Removing it would be harmful: the main reason I opened this was so that scripts could detect hidden usernames on a contribs page, but even in normal usage, it's the best way to confirm that a user's revisions have been sufficiently hidden.

Sep 18 2020, 7:24 PM · Patch-For-Review, User-Majavah, good first task, CSS, MediaWiki-Special-pages, MediaWiki-Revision-deletion
Amorymeltzer added a comment to T255903: Wrap "username or IP address removed" comment in a span and appropriate class.

...history-deleted will gray and cross-out the message, which is not what would be wanted here.

Please explain why. I'd rather have the behavior be consistent (for things that are basically the same) than introduce new arbitrary class.

Sep 18 2020, 11:35 AM · Patch-For-Review, User-Majavah, good first task, CSS, MediaWiki-Special-pages, MediaWiki-Revision-deletion

Sep 15 2020

Amorymeltzer created T262912: Allow action=watch api to rely on user preferences.
Sep 15 2020, 10:51 AM · MediaWiki-API, Platform Engineering

Sep 8 2020

Amorymeltzer added a comment to T243884: Strange URL pattern after search https://en.wikipedia.org/w/index.php?sort=relevance&sort=relevance&sort=relevance&sort=relevance&sort=relevance&sort=relevance ....

That's a good bet, AFAICT, but hundreds of times?! It's clicking the button that adds the term and reloads, so getting to hundreds or even dozens seems unlikely from manual use. There are currently only seven users importing it so if so it should be easy to nail down, especially given the tight timeframe today.

Sep 8 2020, 5:53 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), Traffic, SRE, Advanced-Search, Readers-Web-Backlog (Tracking), Discovery-Search, Wikimedia-production-error

Aug 30 2020

Amorymeltzer added a comment to T243722: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions.

I think script authors should do some existence check instead of blindly assuming relevant user is set always.

Aug 30 2020, 11:22 AM · MediaWiki-Blocks, MediaWiki-Special-pages, JavaScript

Aug 8 2020

Amorymeltzer added a subtask for T97720: Add a tags parameter to API modules creating a logentry: T252980: Support revision/change tags for PageTriage API actions.
Aug 8 2020, 8:36 PM · Google-Code-In-2016, MW-1.29-release-notes, MW-1.27-release-notes, Patch-For-Review, MediaWiki-API, MediaWiki-Change-tagging
Amorymeltzer added a parent task for T252980: Support revision/change tags for PageTriage API actions: T97720: Add a tags parameter to API modules creating a logentry.
Aug 8 2020, 8:36 PM · Growth-Team-Filtering, Platform Team Workboards (External Code Reviews), Patch-For-Review, User-DannyS712, Growth-Team, PageCuration, MediaWiki-API
Amorymeltzer added a subtask for T97720: Add a tags parameter to API modules creating a logentry: T247721: Support revision/change tags for FlaggedRevs API actions.
Aug 8 2020, 8:35 PM · Google-Code-In-2016, MW-1.29-release-notes, MW-1.27-release-notes, Patch-For-Review, MediaWiki-API, MediaWiki-Change-tagging
Amorymeltzer added a parent task for T247721: Support revision/change tags for FlaggedRevs API actions: T97720: Add a tags parameter to API modules creating a logentry.
Aug 8 2020, 8:35 PM · MediaWiki-API, MediaWiki-extensions-FlaggedRevs, Platform Engineering
Amorymeltzer created T259983: Changetags for protection should show in page history.
Aug 8 2020, 8:31 PM · MediaWiki-Page-protection, MediaWiki-Change-tagging
Amorymeltzer added a watcher for MediaWiki-Change-tagging: Amorymeltzer.
Aug 8 2020, 8:16 PM

Aug 7 2020

Amorymeltzer changed the subtype of T259916: "Uncaught Error: Widget not found" on Special:Undelete with no deleted revisions from "Task" to "Bug Report".
Aug 7 2020, 7:21 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), JavaScript, MediaWiki-Special-pages
Amorymeltzer created T259916: "Uncaught Error: Widget not found" on Special:Undelete with no deleted revisions.
Aug 7 2020, 7:21 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), JavaScript, MediaWiki-Special-pages
Amorymeltzer added a comment to T243722: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions.

If it were up to me, I'd say it's better to have it defined; any script/etc. that's dependent on wgRelevantUserName (to, say, add links or lookup user info) wouldn't work otherwise. The target user is known, regardless of whether the viewer can manipulate the Special page in question. At the very least, there should be agreement.

Aug 7 2020, 6:43 PM · MediaWiki-Blocks, MediaWiki-Special-pages, JavaScript
Amorymeltzer updated the task description for T243722: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions.
Aug 7 2020, 4:20 PM · MediaWiki-Blocks, MediaWiki-Special-pages, JavaScript
Amorymeltzer added a comment to T243722: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions.
  1. Be a non-sysop user, including logged-out
  2. Go to Special:Block/Jimbo (the actual account being "viewed" doesn't matter)
  3. mw.config.get('wgRelevantUserName') -> Jimbo
  4. Go to Special:DeletedContributions/Jimbo (the actual account being "viewed" doesn't matter)
  5. mw.config.get('wgRelevantUserName') -> null
Aug 7 2020, 4:18 PM · MediaWiki-Blocks, MediaWiki-Special-pages, JavaScript
Amorymeltzer added a comment to T243722: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions.

I think you might be missing the "non-sysop" part? For a non-sysop, Special:Block defines the name, and links are provided in the sidebar for logged-in users (contributions, logs). For Special:DeletedContributions, this is not the case.

Aug 7 2020, 12:31 AM · MediaWiki-Blocks, MediaWiki-Special-pages, JavaScript

Jul 26 2020

Amorymeltzer added a comment to T258878: Diff parameter without a value will take you to latest diff of main page instead of showing a warning.

Isn't this expected behavior? /w/index.php is the default entry point, but wmf rewrites article paths to look pretty. /w/index.php?diff= does just what I'd expect with an empty or missing parameter diff parameter: it takes you to the latest diff of the page, which, when unprovided, defaults to the main page.

Jul 26 2020, 1:17 PM · MediaWiki-Page-diffs