Nope. Nothing remaining. Resolving this for now

In T304297#7922902, @Scardenasmolinar wrote:

Hi @Ankit18gupta! How are you doing with this ticket? Do you need any additional help, or are you not available to work on this?

In T304297#7882598, @Aklapper wrote:

@Ankit18gupta: Hi, do you plan to rework the patch?

Hi @Enterprisey , @Firefly , @SD0001 ,
I have created the first draft of my proposal. Please review it and provide any valuable feedback. Hoping to hear from you soon.

Filed the PR!!

In T304297#7792257, @Samwalton9 wrote:

Hi @Ankit18gupta. You should be able to count the results of a queryset to count the number of unique languages for all Available partners.

Hi @Samwalton9 ,
I will be working on this task. Can you please tell me how to access X?

Hi @Samwalton9 ,
Since this is my very first backend issue, could you please guide me on how to proceed? It would be very kind from your end.
Thanks

Filed the PR !!
https://github.com/WikipediaLibrary/TWLight/pull/978

Hi @Samwalton9 ,
Image attached. please confirm ASAP.

@Samwalton9
I have attached the image below(you could see both). Should I proceed with filing a PR now?

In T299037#7780764, @Samwalton9 wrote:

In T299037#7780494, @Ankit18gupta wrote:

Hi @Samwalton9 ,
After analyzing the issue deeply just a doubt of ambiguity. We cannot access the search feature if we are not logged in. To search a blank query we must be logged in to the library. So, why will anyone try to access the blank search query via the link above who is not logged in?
Please clarify my doubt since I don't see this as an issue.

Users can initiate that search URL from anywhere, without being logged in. They might have it bookmarked, for example.

In T300072#7781175, @Samwalton9 wrote:

In T300072#7781141, @Ankit18gupta wrote:

Hi @Samwalton9 ,
Thanks for helping me. I have attached an image, of how the button will look. Please provide feedback. Should I move on filing a PR?

Thanks, can you show me what it looks like for a tile which doesn't have an expiry?

Hi @Samwalton9 ,
Thanks for helping me. I have attached an image, of how the button will look. Please provide feedback. Should I move on filing a PR?

Hi @Samwalton9 ,
After analyzing the issue deeply just a doubt of ambiguity. We cannot access the search feature if we are not logged in. To search a blank query we must be logged in to the library. So, why will anyone try to access the blank search query via the link above who is not logged in?
Please clarify my doubt since I don't see this as an issue.

In T300072#7778492, @Samwalton9 wrote:

In T300072#7778091, @Ankit18gupta wrote:

In T300072#7778056, @Samwalton9 wrote:

To test this case, you need to set a resource object to have the 'Proxy' authorizaton method. Then file an application for it, selecting an expiry date. Navigate to the application ('view my applications') and set it to Approved. Then (after logging out and back in to clear the cache), you should have a new My Library tile for that resource, which has an expiration date.

This will enable to you test whether your solution works when the Extend button is present.

How to set - "set a resource object to have the 'Proxy' authorizaton method"

Navigate to /admin, then click Partners. Select one of them, make sure they have the Status of Available and set the Authorization Method to Proxy:

In T300072#7778056, @Samwalton9 wrote:

To test this case, you need to set a resource object to have the 'Proxy' authorizaton method. Then file an application for it, selecting an expiry date. Navigate to the application ('view my applications') and set it to Approved. Then (after logging out and back in to clear the cache), you should have a new My Library tile for that resource, which has an expiration date.

This will enable to you test whether your solution works when the Extend button is present.

@Samwalton9 Can you please provide me details to understand this - "you'll need to apply to a partner which is set to the PROXY access method, then you select an expiry date and this should display for you."
Also a image is attached for what I am referring to.

Hi @Samwalton9 ,
It looks this task is inactive for quite a long. Can you reassign this to me so that I can fix this issue?
Thanks.

Filed the PR #974. :)

Filed the PR!! :)

Hi @Samwalton9 ,
I have fixed the error. Please confirm if this is what you wanted.(image attached)(also in the image,page 16 is now clickable)

Hi,
Can you get me the link of review interface so that I can reproduce?

Hi @Samwalton9 ,
If the task is open to work OR whenever(if) it will be, can you assign it to me?

Hi @Samwalton9 , Just to confirm. The files in which changes are to be made - https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/forms.py and https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/views.py
Are these the files?

https://github.com/WikipediaLibrary/TWLight/pull/956

Is the target file where the changes are to be made - skins/vector/resources/common/components/Menu.less ?
If there are more files please tell me.

In T300374#7671036, @Samwalton9 wrote:

This looks good!

It looks like the partner name isn't coming through, however. Where I wrote <PARTNER NAME> in my description, you should add the required text to import the resource name, which may require editing the view code.

I notice I linked the wrong view earlier, I think this is the correct one: https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/applications/views.py#L122

You may need to add additional context data to that view so that you can access the partner name: https://docs.djangoproject.com/en/3.2/topics/class-based-views/generic-display/#adding-extra-context

In T290280#7628059, @Aklapper wrote:

@ishubham21: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or do you need any help?

Hi @Aklapper, if this issue is still open and there are no updates anyone working on this. Can I work on this?

Greetings!!
Is this issue still open to work? If yes, can anyone guide me through?

Hi @Samwalton9 , adding partner name is troubling me. How to access the partner name in views.py?

Is this fine?(image attached)

Hi @Samwalton9 , for this task do you want the line written just below the yellow alert? Also should the line come up as the same yellow alert?(image attached)

Hi @Samwalton9 , I have sent you a mail regarding this. Please check it. Actually I was stuck so mailed you and I was waiting for reply from you.

In T300492#7664732, @Samwalton9 wrote:

Yes, please. You don't need to ask permission to file a PR!

In T300492#7664680, @Samwalton9 wrote:

Yes this looks good :)

Greetings!!
Could you please guide me to the target file where the changes are supposed to be made?

{F34938290}Greetings!!
Just had a look at{F34938289} this issue too. Please tell me if this is what you wanted(image attached) so that I can go ahead making a PR.

In T300486#7663786, @Samwalton9 wrote:

Great! When you file a Pull Request you should see a template with the information you need to fill out. Other practices are documented at https://github.com/WikipediaLibrary/TWLight/wiki/Branches

I think it's fine now and sorry for the error. I should work on PR now. Please guide me if your project follows any specific practices for PR{F34937892}.

In T300486#7663574, @Samwalton9 wrote:

This looks good! Could you add paragraphing so that the new sentences is in its own paragraph, separate from the block sentences?

Greetings!!
I have completed task T300486 just the Pull Request is still not made. I would also like to work on this issue too as soon as possible.

@Samwalton9 Please confirm with me if this is what you wanted. I have attached an image with it. If yes, guide me through the next steps.

I don't know if this is the right place to ask the doubts I face while installing the setup. If not please guide me through where I can ask my doubts. As of now, I wanted to know for this issue, do I need to install the server setup too locally?

In T300486#7663063, @Samwalton9 wrote:

Hi @Ankit18gupta, thanks again for your interest. Yes, it's the same tool so the same setup process applies.

Could you please choose which task you plan to work on out of this one and T300374?

Hi !!
Can I work on this issue? Also please confirm me to work on this issue do I need to go through the same setup as mentioned here - https://github.com/WikipediaLibrary/TWLight/wiki

Greetings!!
I am new here. So for the very first contribution I need some guidance. I want to work on this issue. Please help me get started.