Thanks for the info and for adding those additional spec sheets! I think this looks great. I can only think of 2 additional things I'd like to see:
Tue, Jan 18
We might also want to consider incorporating the "suggestion" component used on the SuggestedTags page (you must be logged in and auto-confirmed to use this) and by some Growth team features: see this comment for some details on how this component works.
@Seddon This is definitely something we'll want to cover in the version of dropdown in the shared Vue library, which will be included in the initial release. I'll open a task on the Codex board to make sure we test our new Select component in VoiceOver.
Fri, Jan 14
Thu, Jan 13
Tue, Jan 11
I'm loving the level of detail and organization that goes into these new spec sheets!
Dec 20 2021
Excellent, thanks, @Jdforrester-WMF!
Dec 17 2021
What versions of node and npm are you running? Codex requires node 12.21.0 at the moment (pinned in .nvmrc, so you can run nvm install && nvm use), and npm 7.0.0 or greater, which you'll have to install manually. I'm using npm v8.0.0 FWIW
See the new Select component and useMenu composition function for the strategy we've landed on for menu components in Codex. We're sure to iterate on these solutions as we add more menu components, but I'm closing this task since we have an initial implementation merged.
@Jdlrobson That's exactly what I'm hoping for: to have TypeaheadSearch use the Lookup component internally. We should catch up either next week or after the break about how this could be implemented in Vector (the current use case and the Wikidata one).
Dec 16 2021
Dec 7 2021
Dec 1 2021
More details on what I'm experiencing:
Huh, in my experience the sidebar links work, but the markdown links we create when writing docs don't. If you're clicking on actual sidebar links and they aren't working, could you provide a bit more information about how to reproduce that?
Nov 19 2021
Nov 18 2021
Nov 16 2021
Nov 15 2021
I like those ideas for the show code/hide code button! I think the last thing here is layout: right now the controls look a bit disconnected from the demo, in my opinion, and could be better visually paired with it. But it's going to get more complicated once we add the show code/hide code button and the actual code sample into the mix.
@Inductiveload If you have the time and inclination to contribute the Spinner component to our new UI library, Codex, we would welcome that. You can check out the developer docs here. If you did port your WVUI patch over to Codex, the changes would be:
Nov 12 2021
Hey @Michael, thanks for the information! It's great to hear that you have some capacity for contributing to this work.
Nov 10 2021
Nov 9 2021
Could we consider an alternate solution where we use Netlify to deploy the site to codex.wikimedia.org? In my experience, setting up Netlify to automatically deploy the main branch when it's updated is extremely straightforward.
Nov 8 2021
@dchan I'd love to hear your thoughts on this one. We're wondering if the fact that Vue's v-model doesn't react to changes during IME composition will be an issue, if this is the behavior we want, or if it depends on the circumstances. As Roan noted in his comment (linked in the task description) we could provide ways for library users to get either the "coarse" value provided by v-model or a "granular" value that constantly updates even during IME composition.
Nov 5 2021
@DannyS712 now that we've worked out most of the kinks of setting up Codex, the ToggleButton and ProgressBar components can be added. Do you want to add one or both of these components to Codex yourself, or would you like the Design Systems team to port the WVUI versions over? Either way works for us: we'd love to have you contribute code to Codex if you have the time and inclination, but totally understand if you don't right now. We're hoping to get these two components into Codex by the end of the calendar year.
Closing this since Less has been implemented.