Page MenuHomePhabricator

AnneT (Anne Tomasevich)
Staff Software Engineer, Design Systems, Wikimedia Foundation

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 5 2019, 7:51 PM (241 w, 13 h)
Availability
Available
LDAP User
Anne Tomasevich
MediaWiki User
ATomasevich (WMF) [ Global Accounts ]

Recent Activity

Yesterday

AnneT added a comment to T359016: HTMLForm: Add support for fieldset description and "optional" tag.

@Catrope I want to clarify what this task covers. I see 3 distinct things that could have descriptions and optional flags:

Mon, Mar 18, 9:04 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex
AnneT changed the status of T359016: HTMLForm: Add support for fieldset description and "optional" tag from Open to In Progress.
Mon, Mar 18, 8:24 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex
AnneT changed the status of T359016: HTMLForm: Add support for fieldset description and "optional" tag, a subtask of T359011: [EPIC] CodexHTMLForm improvements for Multiblocks, from Open to In Progress.
Mon, Mar 18, 8:23 PM · Epic, Design-System-Team, Codex
AnneT changed the status of T359020: Use CSS-only Field component for fieldsets and legends in CodexHTMLForm from Open to In Progress.
Mon, Mar 18, 7:26 PM · Patch-For-Review, Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex
AnneT changed the status of T359020: Use CSS-only Field component for fieldsets and legends in CodexHTMLForm , a subtask of T359011: [EPIC] CodexHTMLForm improvements for Multiblocks, from Open to In Progress.
Mon, Mar 18, 7:26 PM · Epic, Design-System-Team, Codex
AnneT added a comment to T350477: Add Sort icon to OOUI and Codex.

Is this just one icon, or do we actually need 3?

  1. Sortable, but unsorted (both arrows)
  2. Sorted ascending (just the up arrow)
  3. Sorted descending (just the down arrow)
Mon, Mar 18, 5:52 PM · Design, Codex, Design-System-Team
AnneT closed T359074: Table: Add initial WIP component as Resolved.
Mon, Mar 18, 5:06 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT closed T359074: Table: Add initial WIP component, a subtask of T303320: Table: Add Table component to Codex, as Resolved.
Mon, Mar 18, 5:06 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
AnneT triaged T360349: Table: Add alignment prop as Medium priority.
Mon, Mar 18, 4:51 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, Codex
AnneT moved T360349: Table: Add alignment prop from Inbox to Up Next on the Design-System-Team board.
Mon, Mar 18, 4:51 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, Codex
AnneT updated the task description for T360349: Table: Add alignment prop.
Mon, Mar 18, 4:50 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, Codex
AnneT created T360349: Table: Add alignment prop.
Mon, Mar 18, 4:50 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, Codex
AnneT closed T359076: Table: Create subtasks for MVP features, a subtask of T303320: Table: Add Table component to Codex, as Resolved.
Mon, Mar 18, 4:38 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
AnneT closed T359076: Table: Create subtasks for MVP features as Resolved.
Mon, Mar 18, 4:38 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT updated the task description for T359076: Table: Create subtasks for MVP features.
Mon, Mar 18, 4:38 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT added a comment to T359074: Table: Add initial WIP component.

Would the prop modify the alignment of any elements within cells? I'm asking because probably the most common use case might be to center-align components.

Mon, Mar 18, 4:05 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT added a comment to T360221: Codex: Deprecate codex-search and codex-search-styles modules in ResourceLoader.

Documentation for code splitting usage was done with T350792; see https://www.mediawiki.org/wiki/Codex#Requiring_Codex_components_in_MediaWiki_and_extensions and https://www.mediawiki.org/wiki/Codex#Requiring_Codex_component_styles

Mon, Mar 18, 2:10 PM · MediaWiki-Platform-Team (Radar), MediaWiki-ResourceLoader, Documentation, Codex, Design-System-Team
AnneT added a comment to T359074: Table: Add initial WIP component.

@Sarai-WMDE is there a use case for aligning the text in a cell to the center? Eric brought up a good point in my patch to introduce a way to align text to the end: perhaps we should include a prop called align that defaults to "start" but has option start, end, and center. Thoughts?

Mon, Mar 18, 1:28 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex

Thu, Mar 14

AnneT created T360154: Table: Add pagination support.
Thu, Mar 14, 9:32 PM · Design-System-Team, Codex
AnneT added a comment to T360078: Table: enable sorting of rows.

Regarding the sort icon behavior, the only bit I would adjust is:

"When a user clicks a column to sort it, then clicks again, the column becomes sorted ascending" -> Observing existing examples, it appears that an ascending sorting order should be applied right away when the sortable column's heading is clicked.

Thu, Mar 14, 9:24 PM · Design-System-Team, Codex
AnneT updated the task description for T360078: Table: enable sorting of rows.
Thu, Mar 14, 9:24 PM · Design-System-Team, Codex
AnneT added a comment to T359074: Table: Add initial WIP component.

Regarding the footer: Looks like we just need to apply box-sizing: border-box to .cdx-table__footer in order for the padding to be included in the min-height

Thu, Mar 14, 5:29 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex

Wed, Mar 13

AnneT updated the task description for T360081: Table: Add CSS-only version.
Wed, Mar 13, 10:02 PM · Design-System-Team, Codex
AnneT updated the task description for T360081: Table: Add CSS-only version.
Wed, Mar 13, 9:59 PM · Design-System-Team, Codex
AnneT created T360081: Table: Add CSS-only version.
Wed, Mar 13, 9:59 PM · Design-System-Team, Codex
AnneT created T360080: Table: Design and build the demo page.
Wed, Mar 13, 9:55 PM · Design-System-Team, Codex
AnneT changed the status of T359076: Table: Create subtasks for MVP features from Open to In Progress.
Wed, Mar 13, 9:51 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT changed the status of T359076: Table: Create subtasks for MVP features, a subtask of T303320: Table: Add Table component to Codex, from Open to In Progress.
Wed, Mar 13, 9:51 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
AnneT created T360079: Table: Add row selection.
Wed, Mar 13, 9:49 PM · Design-System-Team, Codex
AnneT added a comment to T360078: Table: enable sorting of rows.

@Sarai-WMDE could you please confirm the sort icon functionality I listed in this task?

Wed, Mar 13, 9:43 PM · Design-System-Team, Codex
AnneT created T360078: Table: enable sorting of rows.
Wed, Mar 13, 9:43 PM · Design-System-Team, Codex
AnneT created T360071: Table: Add optional vertical borders.
Wed, Mar 13, 8:31 PM · Design-System-Team, Codex
AnneT updated the task description for T360069: Table: Add column width and min-width properties.
Wed, Mar 13, 8:25 PM · Design-System-Team, Codex
AnneT created T360069: Table: Add column width and min-width properties.
Wed, Mar 13, 8:19 PM · Design-System-Team, Codex
AnneT changed the visibility for F42604059: image.png.
Wed, Mar 13, 8:17 PM
AnneT added a comment to T359074: Table: Add initial WIP component.

@Sarai-WMDE I implemented both of these things, but wanted to get your feedback on the results.

Wed, Mar 13, 6:54 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT changed the visibility for F42602649: image.png.
Wed, Mar 13, 6:52 PM
AnneT changed the visibility for F42602643: image.png.
Wed, Mar 13, 6:52 PM
AnneT changed the visibility for F42602623: image.png.
Wed, Mar 13, 6:51 PM
AnneT changed the visibility for F42602595: image.png.
Wed, Mar 13, 6:50 PM
AnneT updated the task description for T359015: Implement Codex versions of HTMLFormFields needed for Special:Block.
Wed, Mar 13, 6:13 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Codex

Tue, Mar 12

AnneT updated the task description for T359015: Implement Codex versions of HTMLFormFields needed for Special:Block.
Tue, Mar 12, 8:01 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Codex
AnneT moved T359013: Refactor Codex HTMLForm fields to use a separate method instead of $isCodexForm from In Progress to Code Review on the Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)) board.
Tue, Mar 12, 7:49 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT updated the task description for T359015: Implement Codex versions of HTMLFormFields needed for Special:Block.
Tue, Mar 12, 7:48 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Codex
AnneT moved T359074: Table: Add initial WIP component from In Progress to Code Review on the Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)) board.
Tue, Mar 12, 7:47 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT moved T359015: Implement Codex versions of HTMLFormFields needed for Special:Block from Committed to In Progress on the Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)) board.
Tue, Mar 12, 7:47 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Patch-For-Review, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Codex
AnneT added a comment to T359884: Provide designers with a method to test Codex components in a 14px font size context.

Feedback that would be helpful:

  • What do you think of the proposed solutions?
  • Are there other potential solutions?
  • Does anything need to change on the Figma end, in addition to any changes we might make on the implementation end?
Tue, Mar 12, 7:19 PM · Codex, Design-System-Team
AnneT updated the task description for T359884: Provide designers with a method to test Codex components in a 14px font size context.
Tue, Mar 12, 7:14 PM · Codex, Design-System-Team
AnneT changed the visibility for F42579898: image.png.
Tue, Mar 12, 7:14 PM
AnneT added a comment to T359074: Table: Add initial WIP component.

Thanks for this feedback, @Sarai-WMDE! I've implemented items 1-6. For the header min-height, I added a component-level token. There are 2 items I haven't addressed yet:

Tue, Mar 12, 5:18 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex

Mon, Mar 11

AnneT created T359884: Provide designers with a method to test Codex components in a 14px font size context.
Mon, Mar 11, 9:00 PM · Codex, Design-System-Team
AnneT changed the visibility for F42554817: image.png.
Mon, Mar 11, 8:44 PM
AnneT changed the status of T359074: Table: Add initial WIP component from Open to In Progress.
Mon, Mar 11, 7:11 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT changed the status of T359074: Table: Add initial WIP component, a subtask of T303320: Table: Add Table component to Codex, from Open to In Progress.
Mon, Mar 11, 7:11 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
AnneT assigned T359021: Use CSS-only Field component for individual fields and labels in CodexHTMLForm to Catrope.
Mon, Mar 11, 7:06 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex

Fri, Mar 8

AnneT added a comment to T359074: Table: Add initial WIP component.

@Sarai-WMDE could you please check out these demos and let me know if you have any design feedback? Thanks!

Fri, Mar 8, 4:14 AM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex

Thu, Mar 7

AnneT added a comment to T359016: HTMLForm: Add support for fieldset description and "optional" tag.

FWIW, while the Codex Field component differentiates the label text and description text for fieldsets, they are both contained within the <legend> element - in my research, I found that this was the only reliable way to ensure that, when you tab into a fieldset, both the label and description are read to you. I still think this task needs to be done to allow you to pass in separate things for label, optional flag, and description, I just wanted to make this note about the resulting markup.

Thu, Mar 7, 5:53 PM · Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)), Codex

Mon, Mar 4

AnneT added a comment to T358703: CSS-only Select icons are broken in night mode.

@CCiufo-WMF the latter; we've thrown around some ideas but are far from a solid long-term solution IMO

Mon, Mar 4, 9:53 PM · Design-System-Team, Patch-For-Review, Codex
AnneT updated the task description for T353502: Contribute link is unspecified and doesn't throw error.
Mon, Mar 4, 9:29 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), JSDoc WMF theme
AnneT moved T358828: Improve link styling in page titles from Accepted Enhancement to Pending release on the JSDoc WMF theme board.
Mon, Mar 4, 8:53 PM · JSDoc WMF theme
AnneT updated subscribers of T358703: CSS-only Select icons are broken in night mode.

cc @CCiufo-WMF ^

Mon, Mar 4, 6:54 PM · Design-System-Team, Patch-For-Review, Codex
AnneT added a comment to T358703: CSS-only Select icons are broken in night mode.

This introduces a second hack into the Select component code related to supporting CSS custom properties - should we capture the work to create a more sustainable solution in the future somewhere?

Mon, Mar 4, 6:54 PM · Design-System-Team, Patch-For-Review, Codex
AnneT moved T359074: Table: Add initial WIP component from Inbox to Up Next on the Design-System-Team board.
Mon, Mar 4, 4:18 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT moved T359076: Table: Create subtasks for MVP features from Inbox to Up Next on the Design-System-Team board.
Mon, Mar 4, 4:18 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT set the point value for T359074: Table: Add initial WIP component to 5.

Some of this work has been completed in the prototype, but I think a few things will take time:

Mon, Mar 4, 4:18 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT set the point value for T359076: Table: Create subtasks for MVP features to 5.

IMO, creating and refining the tasks will take time, especially refining them to the point where they all have clear acceptance criteria, can be taken on by any developer, and any dependencies are clear.

Mon, Mar 4, 4:17 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT created T359076: Table: Create subtasks for MVP features.
Mon, Mar 4, 4:16 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT created T359074: Table: Add initial WIP component.
Mon, Mar 4, 4:14 PM · Design-System-Team (DST-Sprint-18 (2024-03-04 to 2024-03-15)), Codex
AnneT closed T357695: Table: Investigate open implementation questions as Resolved.

I'm resolving this task since we've done the exploration and provided a path forward on all the open questions. Anything that is not completely clear yet can be discussed in subtasks of the Table component for each feature. Thanks to everyone who contributed to this work!

Mon, Mar 4, 3:15 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT closed T357695: Table: Investigate open implementation questions, a subtask of T303320: Table: Add Table component to Codex, as Resolved.
Mon, Mar 4, 3:14 PM · Design-System-Team (Design-System-Product-Roadmap), Design, Codex
AnneT updated the task description for T357695: Table: Investigate open implementation questions.
Mon, Mar 4, 3:12 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T357695: Table: Investigate open implementation questions.

Thanks so much again for the thorough investigation, and the clear documentation of the outcomes @AnneT! 🙏🏻

Regarding sorting, as mentioned during our last meeting, I believe it sounds perfectly acceptable (and probably more scalable) to only emit events as part of the MVP. It would be very helpful, as I believe you mentioned, to collect feedback on how this "limitation" is welcomed by reusers of the component. Maybe we could reach out to the Growth team at some point? On the other hand, this is most likely a given, but I hope we are able to showcase the full sorting behavior in the Table's demo page. It would be ideal for clarity.

Mon, Mar 4, 3:11 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T358790: Field: Guidelines to explain the difference between Read-only and Disabled.

@DTorsani-WMF the guidelines you drafted look good to me!

Mon, Mar 4, 3:07 PM · Design, Codex, Design-System-Team
AnneT updated subscribers of T358844: Field: add Read-only state in the Configurable Demo.

We don't currently support the readonly attribute in the Field component, for 2 reasons:

  1. The Field component's parts (label, description, help text, message, etc) do not change at all when an input is readonly. There is nothing we needed to do inside the Field component to handle a readonly state.
  2. Only 2 components support the readonly attribute (TextInput and TextArea), so having a prop for the Field component for readonly could be confusing
Mon, Mar 4, 2:19 PM · Codex, Design-System-Team

Thu, Feb 29

AnneT added a comment to T356354: Fixed header obscures linked anchor element.

Thanks for the report and the suggested solution, @Jack_who_built_the_house! I've opened a patch implementing this, and cleaning up some other existing solutions that were causing inconsistent behavior.

Thu, Feb 29, 7:55 PM · JSDoc WMF theme
AnneT changed the status of T356354: Fixed header obscures linked anchor element from Open to In Progress.
Thu, Feb 29, 7:50 PM · JSDoc WMF theme
AnneT updated the task description for T357695: Table: Investigate open implementation questions.
Thu, Feb 29, 6:59 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T357695: Table: Investigate open implementation questions.

@Catrope that's a really good point - we will need to offer both options for pagination. I'll update the task description to note this.

Thu, Feb 29, 6:57 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T358790: Field: Guidelines to explain the difference between Read-only and Disabled.

I'd recommend including these guidelines in the new form guidelines in the style guide, plus on the TextInput and TextArea pages. readonly is not an attribute that's available for use in the Field component, and it only applies to two kinds of inputs, so I think it would be confusing to include it there.

Thu, Feb 29, 6:00 PM · Design, Codex, Design-System-Team
AnneT reassigned T357695: Table: Investigate open implementation questions from AnneT to Sarai-WMDE.

@Sarai-WMDE after discussing the open issues with the team, I've listed answers for all of the open questions in the task description. I think sorting was the biggest question mark after our last meeting, and it does seem like we agree that we shouldn't implement support for sorting logic in the Table component as part of MVP. Please check out the resolutions listed in the task description and let me know if you have further comments!

Thu, Feb 29, 4:49 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT updated the task description for T357695: Table: Investigate open implementation questions.
Thu, Feb 29, 4:46 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T357695: Table: Investigate open implementation questions.
  1. How should the "select all" checkbox for row selection work? E.g. when it's selected, then a row is unselected, should the "select all" box be indeterminate?

I think it should be indeterminate based on our definitions in the guidelines.

Thu, Feb 29, 4:45 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT updated the task description for T357695: Table: Investigate open implementation questions.
Thu, Feb 29, 4:30 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT moved T358271: Summary duplicated on module pages from Confirmed Problem to Pending release on the JSDoc WMF theme board.
Thu, Feb 29, 3:20 PM · JSDoc WMF theme
AnneT added a comment to T357695: Table: Investigate open implementation questions.

Thanks @Catrope, this is super helpful. I agree that 1A makes sense for MVP and we could pursue 2B post-MVP if we want to. 2B does feel better than 2A because it keeps the dev experience consistent whether you're using sorting or not.

Thu, Feb 29, 3:02 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex

Wed, Feb 28

AnneT updated subscribers of T357695: Table: Investigate open implementation questions.

@Catrope do you have any experience with table sorting in MediaWiki? Curious if you have any thoughts on my last comment.

Wed, Feb 28, 10:38 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T357695: Table: Investigate open implementation questions.

Supporting sort inside the Table component, in a way that would work across all languages, would be extraordinarily difficult. We should consider whether there is a reliable way to do this (like a library we could use) and how sort is handled in existing tables in the Wikiverse. Ultimately, we can do one of these options:

Wed, Feb 28, 10:35 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT updated the task description for T357695: Table: Investigate open implementation questions.
Wed, Feb 28, 9:40 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex

Tue, Feb 27

AnneT added a comment to T357695: Table: Investigate open implementation questions.

In the open questions I asked if pagination and sorting logic (i.e. determining which items to show and in what order) should be supported in Table, but I see now that they are totally separate issues. Pagination logic should be relatively easy to support in Table.

Tue, Feb 27, 10:40 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T357695: Table: Investigate open implementation questions.
  1. Passing in table data
Tue, Feb 27, 5:06 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT added a comment to T358513: CSS-only Select is almost invisible.

I've opened a proof-of-concept patch using background-blend-mode in the CSS icon mixin so we can play around with making it work for all icons

Tue, Feb 27, 3:37 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression
AnneT added a comment to T358513: CSS-only Select is almost invisible.

I've tried implementing this for all non-button icons and ran into a problem: the icon element must have a set background color. You can see this in action here, where I've set the background color of the second icon:

Tue, Feb 27, 2:38 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression
AnneT changed the visibility for F42180612: image.png.
Tue, Feb 27, 2:33 PM
AnneT added a comment to T358513: CSS-only Select is almost invisible.

Wow, amazing solution—this works perfectly for the Select icon! I agree we should explore implementing this instead of mask-image for all CSS icons. My biggest questions are:

  • Could this work with icons in buttons (I'm not sure how it would, since the color needs to change in the Button code when the state changes)? If not, are we okay with using different methods for icons inside and outside of buttons again?
  • Can we easily handle night mode, e.g. with a token for the blending mode? Is that even necessary?
Tue, Feb 27, 2:05 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression

Mon, Feb 26

AnneT claimed T358513: CSS-only Select is almost invisible.
Mon, Feb 26, 9:52 PM · MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex, Regression
AnneT added a comment to T357695: Table: Investigate open implementation questions.

Early notes on data flow; more on this next week.

There are a few ways we could enable users to pass in table data:

  1. By using normal table sub-elements, like thead, th, tr, etc. in the default slot
  2. By passing in an array of data, which gets output wrapped in appropriate table elements
  3. Same as 2, but also using slots to customize the layout of certain cells

I think we should definitely support 2 and 3, and I think we can fairly easily support 1 too. The details of slot implementation for 3 need to be ironed out, but there are a few ways we could approach this and I think it's quite doable.

Would we need 1 to support a CSS-only version of the Table component? 2 and 3 make sense for the Vue version.

Mon, Feb 26, 5:43 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex

Fri, Feb 23

AnneT added a comment to T357695: Table: Investigate open implementation questions.

Early notes on data flow; more on this next week.

Fri, Feb 23, 12:01 AM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex

Thu, Feb 22

AnneT added a comment to T357695: Table: Investigate open implementation questions.

I've been exploring options for table and column width and have some suggestions. I've built a prototype with few demos to aid in the discussion.

Thu, Feb 22, 11:52 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Design, Codex
AnneT closed T358246: Icon: explore supporting custom non-embedded SVG URLs for CSS-only icons as Invalid.

Sorry, this was a misunderstanding on my part

Thu, Feb 22, 5:32 PM · Codex, Design-System-Team
AnneT created T358247: Lookup: Make sure the menu is closed if there are no menu items.
Thu, Feb 22, 4:41 PM · Design-System-Team (DST-Sprint-17 (2024-02-20 to 2024-03-01)), Codex