Fri, Jan 24
Oops, the patch I referred to isn't on production yet. EntityLookupElement was refactored to EntityInputWidget, which is live on prod at the moment with the failing onMousedown method.
Thu, Jan 23
On the notion of using React without a build step: in my opinion, it's not worth using React at all if you're not going to use JSX. Even this sample code from the React docs is pretty gross compared to HTML, JSX, or a templating language:
Wed, Jan 22
Wed, Jan 15
Tue, Jan 14
Hey @Krinkle, thanks for the detailed info here. I was a bit uncertain when constructing these interwiki links so this helps.
This was easily fixed with a line of CSS that's also used for statement widget inputs. I noticed that, on my local site which doesn't have a Hebrew translation of "official website", the qualifier property text appears in English but aligned to the right. This seems to mirror Wikidata's UI, which only changes the language direction in the case of monolingual text.
Mon, Jan 13
Hey @Ramsey-WMF, we're using Wikibase's LanguageFallbackChainFactory method to get a language fallback chain for the user, and this generates a chain based on the user's interface language followed by the languages in their Babel template in order of skill level. So, in Timo's case, the chain would be British English, Dutch, English, German, and Western Frisian, which is why we're seeing Dutch words before English words for wikidata items without a British English translation.
I'd like to wrap this one up and after reading the comments it seems we can move forward with the following UI in RTL language mode:
Hey @Volker_E, do you have any thoughts on my comment above on how to improve tab navigation for this form? I'd like to get this fixed this month if possible while my team has time to make improvements to WBMI, and we are, unfortunately, without a designer at the moment.
Fri, Jan 10
Thu, Jan 9
Oof, yeah, this is a tough one. I'm fine merging as-is and reevaluating when we have a designer to consult.
One thing we should keep in mind is how the proposed changes here would impact the "copy to all" functionality.
@egardner One minor comment on your latest patch: can we add some visual separation between the statement input and the map for the first existing statement? It sort of looks like the map is more connected to the statement input than the existing statement. I realize this might be kind of difficult because this will cause the design for geocoordinate statement panels to diverge from other datatypes...happy to discuss this more!
Wed, Jan 8
@Ramsey-WMF, can you please check out my proposal and mockups above and let me know if you have any feedback? We can also discuss at the design-dev meeting tomorrow.
I believe the intention here was for users to click on each item in the booklet layout to add data to images, then click "publish data." However, this is not intuitive, and users tend to click "publish data" after tagging the first image. It took me a little while to figure out that the "publish data" button applied to all images, not just the first one.
Tue, Jan 7
I took a look at this and couldn't reproduce it in Chrome 79.0.3945.88. I've seen this behavior before locally when I've broken the publish functionality in some way, but never when things are working (including when errors are present but handled properly).
This turned out so well! I agree that hiding the map by default is better than showing it all the time, and could go either way on displaying it once the user is adding a new coordinate. I don't think it's totally necessary but it would be a nice feature.
Mon, Jan 6
Dec 20 2019
Dec 18 2019
Dec 17 2019
@Ramsey-WMF I confirmed with my WMF account that the onboarding dialog is appearing and functioning as expected on prod Commons
Dec 16 2019
Dec 13 2019
Dec 12 2019
Ongoing notes on this topic: https://docs.google.com/document/d/1Vj5PCSR_ySy6GASQ38c6Tq8_0TFtgwwul57-g_Tc2aU/edit#
Once this patch is deployed, submit errors will print to the page. As discussed in our design/dev meeting today, I'll update the UI a bit to follow foundation design standards and unify the error UX across different scenarios in the following ways:
Dec 11 2019
Dec 10 2019
Hey @PDrouin-WMF, I was hoping to get your thoughts on some possible solutions here.
Dec 9 2019
Dec 6 2019
Dec 4 2019
Hey @Wargo, I've been unable to reproduce this so far. Could you please try to reproduce it again and, if you can, provide the following info?
Dec 2 2019
Thanks very much for passing this along Lucas!
Nov 27 2019
Screenshot of updated design: