Moving this to "following" since we are completing the Codex part (T323987) but likely won't implementing supporting text for redirects in Vector (this task).
@bmartinezcalvo @Sarai-WMDE well, I'm a dummy and forgot that we had a special prop for match because we needed to be able to apply a lang attribute to the match itself, which might be different from the language of the label. So we do need to keep the match prop.
Wed, Nov 23
Based on a conversation between @bmartinezcalvo and I, the patch above makes the following changes:
- Changes the label from "direction" to "reading direction"
- Spells out the abbreviations (e.g. Left to right (LTR))
@bmartinezcalvo this is exactly what I needed, thank you!
Tue, Nov 22
Some positive feedback: I've used the spacing tokens a few times and find the scale quite intuitive and the most frequently used values (25 through 200) easy to remember
@bmartinezcalvo we could use some design review here! We've set up the following:
@bmartinezcalvo / @Volker_E / @Sarai-WMDE Could you help me understand what a designer on a product team will need to do to support their team adopting Codex? I'm not sure how familiar product designers are with the design system—I suspect they're quite familiar since the WMF design team has regular meetings, but I'm not exactly sure. I'm assuming that to start using Codex, a product designer would need access to the Codex components (and design tokens?) in Figma, and perhaps some familiarity with the Codex docs site. Is there anything else they will need to onboard? Are there specific resources we can point them to other than the Figma library and docs site?
Mon, Nov 21
I've got a WIP branch up for the docs site banners, which will have to wait to be merged until /codex/latest actually exists. Assigning to @Catrope to continue looking into the changes on the doc.wikimedia.org side
@DAbad Does this have a hard deadline? I'm trying to figure out when I should work on this in relation to other priorities.
Will try to work on this next week
@Aklapper yes, thanks for the heads up
Thu, Nov 17
I've started writing this task and subtasks, but haven't finished yet. I'm hoping to work on that early next week!
What would all of this mean for users who are just using Codex Vue components with a build tool outside MediaWiki? Ideally they should be able to import a Vue component and get both the base and interactive styles without having to do anything else.
@bmartinezcalvo I ended up adding a control to the configurable demo system for direction, so you can toggle between LTR and RTL there! For components that don't yet have a configurable demo, I added only the direction control to the first demo on the page. You can test this all on the live site. Let me know if you have any suggestions for improvements!
Wed, Nov 16
I added patches aiming to resolve this in Button and ToggleButton (I wanted a separate patch for ToggleButton because its active states are a bit confusing to me, so that patch might need more review with more people).
Per Volker's comment above, I'm going to close this since we're going to allow default browser behavior to win in this case.
Tue, Nov 15
Thu, Nov 10
@Lucas_Werkmeister_WMDE our next scheduled Codex release is Tuesday, November 22nd, so it would ride the train the following week. Is that acceptable, or is this needed sooner?
Wed, Nov 9
Mon, Nov 7
We have agreed on the proposal in Roan's comment above
@DAbad is it possible for us to "finalize" this as we're preparing for the roadshow ("finalize" being in quotes because this isn't set in stone)? I'm imagining posting this list with a brief explanation of what it is on mediawiki.org, and linking to that list on the Codex docs site. What do you think? I'm happy to create a subpage of our team page on mediawiki.org and draft the explanation and transfer the table of components there.
Wed, Nov 2
@Catrope please feel free to edit the task to add more info if I've missed anything
Tue, Nov 1
@EUdoh-WMF thanks for your review here! I agree that we should indicate to users, at least those experiencing a slower connection, that more results are loading, although I think that should be a separate task. I've opened T322136 to document this; please feel free to edit that task to add more info if you want to.
Mon, Oct 31
Could we accept such a slight divergence between Codex and OOUI? I would hate to hold back Codex because of the old system, and I'm not convinced that both versions must be completely in sync, especially when it comes to a single-pixel difference.
Oct 27 2022
cc @Sarai-WMDE on the message above ^ if you have a second, could you please confirm if this is the correct style now, especially for TypeaheadSearch? I had thought there was supposed to be a -1px margin-top on the menu, but it seems like that's not indicated in the designs.