Page MenuHomePhabricator

Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (249 w, 2 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Yesterday

Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

I'm a bit confused here, cause updated task description seems to collide (again) with https://phabricator.wikimedia.org/T113831

Thu, Jul 18, 4:33 PM · MediaWiki-Installer, Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic
Anomie moved T228425: User.php: Cannot create a user with no name, no ID, and no actor ID from Backlog to External Code Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Jul 18, 4:18 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Recent-changes, MediaWiki-API, Wikimedia-production-error
Anomie moved T228425: User.php: Cannot create a user with no name, no ID, and no actor ID from Unsorted to Needs Review on the MediaWiki-API board.

So after all, maybe the exception is reported because the parameter has been deprecated.

It's been deprecated 5 years ago ;) Maybe it's time to followup and remove it?

Thu, Jul 18, 4:17 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Recent-changes, MediaWiki-API, Wikimedia-production-error
Anomie added a comment to T228360: Narrow scope of MediaWiki-Database workboard.

Would using MediaWiki-Maintenance-scripts and/or MediaWiki-Installer be a more suitable place for those task two kinds of tasks?

Thu, Jul 18, 4:05 PM · DBA, Project-Admins, Performance-Team, Core Platform Team
Anomie added a project to T225853: BadMethodCallException for API call on ru.wikipedia: "Call to a member function getPrefixedText() on a non-object (null)": Core Platform Team (Code Health (TEC13)).
Thu, Jul 18, 2:36 PM · Core Platform Team (Code Health (TEC13)), good first bug, Core Platform Team Workboards (Clinic Duty Team), PageViewInfo, Wikimedia-production-error, MediaWiki-API
Anomie edited projects for T201749: Config script still sets "en_US.utf8" to "$wgShellLocale" for MW 1.30+, added: Core Platform Team (Code Health (TEC13)); removed Core Platform Team (PHP7 (TEC4)).
Thu, Jul 18, 2:35 PM · Core Platform Team (Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, MediaWiki-Installer, MediaWiki-Configuration
Anomie moved T201749: Config script still sets "en_US.utf8" to "$wgShellLocale" for MW 1.30+ from Inbox to PHP7 (TEC4) on the Core Platform Team board.
Thu, Jul 18, 2:35 PM · Core Platform Team (Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, MediaWiki-Installer, MediaWiki-Configuration
Anomie removed a project from T225853: BadMethodCallException for API call on ru.wikipedia: "Call to a member function getPrefixedText() on a non-object (null)": Core Platform Team.
Thu, Jul 18, 2:33 PM · Core Platform Team (Code Health (TEC13)), good first bug, Core Platform Team Workboards (Clinic Duty Team), PageViewInfo, Wikimedia-production-error, MediaWiki-API
Anomie edited projects for T227739: Contention on User::getActorId ?, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Jul 18, 2:30 PM · Wikimedia-database-error, Core Platform Team (Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, MediaWiki-User-management
Anomie closed T227973: Fatal error after 1.31.2 -> 1.33.0 - Unknown column 'pt_reason' in 'field list' as Invalid.

Thanks for reporting a bug.

Thu, Jul 18, 2:12 PM · MW-1.33-release, MediaWiki-General, Core Platform Team, MediaWiki-Comment-backend
Anomie moved T228345: Error from php7-fatal-error handler: Undefined variable 'err' and 'message' from Backlog to EM Sign Off on the Core Platform Team Workboards (Clinic Duty Team) board.

Seems done now? Not sure yet which CPT-CD workboard column is right, so guessing one.

Thu, Jul 18, 1:54 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), Wikimedia-production-error
Anomie edited projects for T228345: Error from php7-fatal-error handler: Undefined variable 'err' and 'message', added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Jul 18, 1:52 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), Wikimedia-production-error
Anomie moved T228360: Narrow scope of MediaWiki-Database workboard from Inbox to Tracking/Watching on the Core Platform Team board.

I'm not sure about the Schema-change part. That tag claims to be about actual schema changes. Glancing through the tasks currently in the schema change column of MediaWiki-Database, it seems a combination of actual schema changes, requests for maintenance scripts related to schema changes, and bugs in the updater when applying schema changes.

Thu, Jul 18, 1:51 PM · DBA, Project-Admins, Performance-Team, Core Platform Team

Wed, Jul 17

Anomie moved T188327: Deploy refactored actor storage from Backlog to Ready on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Jul 17, 8:03 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team (Revision Storage Schema Improvements), MW-1.33-notes, MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), MW-1.32-notes, Epic
Anomie added a comment to T218674: User::getRights() applies session rights restrictions to non-session users.

Err, this task is the real use case for that. But as mentioned the use case here could be satisfied by more explicit requests for "rights for the user in this session" versus "rights for this user generically".

Wed, Jul 17, 2:59 PM · MediaWiki-User-management, MediaWiki-API

Tue, Jul 16

Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.
  1. Tracking of which migration has run (and when) in a migrations table
Tue, Jul 16, 7:33 PM · MediaWiki-Installer, Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, Epic

Mon, Jul 15

Anomie added a comment to T226598: REST API i18n.

We could just say that it's always HTML and be done.

Mon, Jul 15, 6:48 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)
Anomie added a comment to T225853: BadMethodCallException for API call on ru.wikipedia: "Call to a member function getPrefixedText() on a non-object (null)".

It's possible that the reproduction case may have gone away if the page views data has changed so there's no longer an invalid title in the ruwiki results. The bug does still seem to exist in the code.

Mon, Jul 15, 4:22 PM · Core Platform Team (Code Health (TEC13)), good first bug, Core Platform Team Workboards (Clinic Duty Team), PageViewInfo, Wikimedia-production-error, MediaWiki-API
Anomie added a comment to T227447: Librarize i18n-related PHP classes in MediaWiki.

Is "wrap some part of the message in HTML" be a generic enough summary? That is, would ->someMethodName( 'n', $html ) with the $html string containing only $1 as the replacement be the right level of functionality?

Mon, Jul 15, 4:12 PM · Librarization, I18n, MediaWiki-Internationalization
Anomie added a comment to T218674: User::getRights() applies session rights restrictions to non-session users.

I agree that building that distinction into the new PermissionManager's interface would be beneficial.

Mon, Jul 15, 2:57 PM · MediaWiki-User-management, MediaWiki-API
Anomie added a comment to T227447: Librarize i18n-related PHP classes in MediaWiki.

I'll admit I don't deal much with the fancier bits of the UI, but in my limited experience a link is generally done with wikitext and a button or other widget doesn't seem very likely to need to take data from the "outer" message. But I can see how there are cases where the added complication might be required for complicated links or the like, though.

Mon, Jul 15, 2:54 PM · Librarization, I18n, MediaWiki-Internationalization
Anomie added a comment to T227447: Librarize i18n-related PHP classes in MediaWiki.

It's not clear to me what exactly your example is supposed to be showing. You seem to have a parameter that itself contains parameter-replacements, but without a clear indication as to what pattern that would replace.

Mon, Jul 15, 2:25 PM · Librarization, I18n, MediaWiki-Internationalization
Anomie added a comment to T226598: REST API i18n.

We've been discussing the intricacies of message input and output formats in more detail at T227447: Librarize i18n-related PHP classes in MediaWiki, we should probably have most of the discussion there instead.

Mon, Jul 15, 2:18 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)

Fri, Jul 12

Ladsgroup awarded T167246: Refactor "user" & "user_text" fields into "actor" reference table a Love token.
Fri, Jul 12, 4:19 PM · Schema-change, MediaWiki-General, Core Platform Team (Revision Storage Schema Improvements), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic
Anomie added a comment to T227739: Contention on User::getActorId ?.

There are two parts here:

Fri, Jul 12, 2:03 PM · Wikimedia-database-error, Core Platform Team (Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, MediaWiki-User-management
Anomie added a comment to T226704: Setup es4 and es5 replica sets for new read-write external store service.

No problem, it doesn't hurt to check. At one point we were considering the possibility of having the scripts update existing ES entries in place, but in the end we decided not to do that (instead the scripts would insert new ES entries so old ones can remain read-only). If we get back to either the recompression or reserialization projects, we'll consult you on the details then.

Fri, Jul 12, 1:54 PM · Epic, DBA

Thu, Jul 11

Anomie added a comment to T227776: Generalize ParserCache into a generic service class for large "current" page-derived data.

a standalone storage service which is then accessed from within core,

Thu, Jul 11, 8:57 PM · Core Platform Team, TechCom, User-Daniel, Proposal
Anomie added a comment to T224949: Failed to access name from slot_roles using id = 1.

I'd say so.

Thu, Jul 11, 8:05 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General
Anomie added a comment to T101631: rev_len should be available also for deleted revisions in database replicas.

@Anomie asked a good question on the patch review. "Should you do the same for ar_len, here and in the other archive views?" referring to: if(ar_deleted&1,null,ar_len) as ar_len

This is referring to deleted revisions, rather than archived revisions of deleted pages.

Based on @Krenair's comment, I think the answer is no but I'm not 100% sure.

Thu, Jul 11, 7:07 PM · cloud-services-team (Kanban), Data-Services, Cloud-VPS
Anomie added a comment to T208690: create revision_commentindex.

Using comment_revision would help with #2 by reducing the number of subqueries needed.

Thu, Jul 11, 7:06 PM · cloud-services-team (Kanban), Data-Services
Anomie added projects to T225853: BadMethodCallException for API call on ru.wikipedia: "Call to a member function getPrefixedText() on a non-object (null)": Core Platform Team Workboards (Clinic Duty Team), good first bug.
Thu, Jul 11, 7:06 PM · Core Platform Team (Code Health (TEC13)), good first bug, Core Platform Team Workboards (Clinic Duty Team), PageViewInfo, Wikimedia-production-error, MediaWiki-API
Anomie moved T225853: BadMethodCallException for API call on ru.wikipedia: "Call to a member function getPrefixedText() on a non-object (null)" from Unsorted to Needs Code on the MediaWiki-API board.

This seems to be similar to T208691, this time affecting the code path where ApiQueryMostViewed is being used as a generator. The fix would be similar, the return value from Title::newFromText() at line 50 needs to be checked for null before being added to the array.

Thu, Jul 11, 7:04 PM · Core Platform Team (Code Health (TEC13)), good first bug, Core Platform Team Workboards (Clinic Duty Team), PageViewInfo, Wikimedia-production-error, MediaWiki-API
Anomie moved T226072: Provide a way to get localized namespaces names through the API from Unsorted to Needs Code on the MediaWiki-API board.

meta=siteinfo&siprop=namespaces would not be the right place for this, as that's intended for returning namespace names that actually function on the wiki.

Thu, Jul 11, 7:01 PM · I18n, MediaWiki-API
Anomie removed a project from T226587: Notifications count via notwikis=* doesn’t work for sessions providers other than CentralAuth: MediaWiki-extensions-OAuth.

Not just OAuth, it also doesn't work with BotPasswords.

Thu, Jul 11, 6:57 PM · Growth-Team, MediaWiki-API, Notifications
Anomie renamed T226587: Notifications count via notwikis=* doesn’t work for sessions providers other than CentralAuth from Notifications count via notwikis=* doesn’t work via OAuth to Notifications count via notwikis=* doesn’t work for sessions providers other than CentralAuth.
Thu, Jul 11, 6:56 PM · Growth-Team, MediaWiki-API, Notifications
Anomie added a comment to T114384: Standardise procedures for deprecating public-facing code.

In case you're not already aware, I'm the primary maintainer of the Action API, i.e. api.php. Also, as a volunteer contributor, I run AnomieBOT on the English Wikipedia. I'm replying mainly from those perspectives. I don't know very much about JavaScript libraries loaded in MediaWiki for use by user scripts or about class names and DOM structure in the HTML.

Thu, Jul 11, 6:52 PM · Release-Engineering-Team (Development services), Release-Engineering-Team-TODO, WMF-Product-Development-Process, MediaWiki-API, Developer-Advocacy, User-notice
Anomie added a comment to T226704: Setup es4 and es5 replica sets for new read-write external store service.

Thanks for the ping, but I don't think we (meaning Core Platform Team) are working on the things that would touch on that maintenance at this time.

Thu, Jul 11, 6:45 PM · Epic, DBA
Anomie added a comment to T74153: meta=siteinfo&prop=langlinks should indicate whether a language is RTL.

but that would require a lot more work, I think, and might be overkill.

Thu, Jul 11, 6:44 PM · Developer-Wishlist (Next), Readers-Web-Backlog (Tracking), Patch-For-Review, RTL, I18n, MediaWiki-API
Anomie closed T108144: DB errors with non-UTF8 characters can not be serialized by the API as Resolved.

I can't manage to reproduce this (by hacking a throw of a similar exception with invalid UTF8 into an arbitrary API module), so I'm going to call this "resolved". Feel free to reopen with instructions on reproducing if you can reproduce it.

Thu, Jul 11, 6:42 PM · Core Platform Team Workboards (Clinic Duty Team), good first bug, MediaWiki-API, MediaWiki-Database
Anomie added a comment to T226972: Extension:Scribunto Script error: Lua error: Internal error: The interpreter has terminated with signal "11".

Where is the Lua binary installed on your server? What does the line for wgScribuntoEngineConf in your LocalSettings.php file?

Thu, Jul 11, 6:39 PM · MediaWiki-extensions-Scribunto
Anomie added a comment to T71222: list=logevents slow for users with last log action long time ago.

I think I am going to close this, as the task was really fixed with T71222#5012278. 10.1 will for sure not fix this issue as they are not going to make changes to the optimizer as per my last chat with MariaDB Dev Team. So we'll see if 10.3 got this fixed or it was just because we re-imported the table (although we didn't see that making any difference on 10.1 as well).

Thu, Jul 11, 6:38 PM · User-Marostegui, MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie moved T226830: Add information about available scaled images to list=allimages from Unsorted to Needs details or plan on the MediaWiki-API board.
Thu, Jul 11, 6:37 PM · WMCZ-Tracker, MediaWiki-API
Anomie added a comment to T226830: Add information about available scaled images to list=allimages.

The parameters in prop=imageinfo themselves aren't very good. See T89971: ApiQueryImageInfo is crufty, needs rewrite. Ideally T66214: Define an official thumb API would be done, then the API could just point to that.

Thu, Jul 11, 6:37 PM · WMCZ-Tracker, MediaWiki-API
Anomie added a comment to T224949: Failed to access name from slot_roles using id = 1.

Caching should not be the cause of any problems during upgrade. Unless the desired is found in the cache but isn't actually in the table, in which case it wouldn't get created in the table. But how would it get into the cache if it's not in the table? The cache is populated by loading from the database.
I still have no clue how this can happen, besides the upgrade is interrupted somehow, by an error, or ctrl-c, system failure, etc.

Thu, Jul 11, 6:37 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.34-release, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), MW-1.33-release, Patch-For-Review, MW-1.32-release, MediaWiki-General
Anomie closed T149077: Certain ApiQueryRecentChanges::run api query is too slow, slowing down dewiki as Declined.

I'm going to go ahead and just close this. Stuff happened 3 years ago, we didn't think of everything to test at the time, and now we have no way to reproduce it to see if MariaDB is now smarter about things than it was back in 2016.

Thu, Jul 11, 6:31 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-production-error, MediaWiki-API, DBA
Anomie added a comment to T227662: Update.php failure when upgrading from 1.32.1 to 1.33.

...comment table already exists.

			[ 'addTable', 'comment', 'patch-comment-table.sql' ],

^ So, it thinks it has already run the patch-comment-table.sql update... Which was in 1.30... So should've been added a while ago, and won't do any further modifications

Thu, Jul 11, 6:28 PM · MediaWiki-Installer
Anomie closed T227689: Allow bypassing TemplateStyles when viewing the content of a page as Declined.

Styles from TemplateStyles are very similar to inline styles, as @Tgr noted, since they're both part of the wikitext content of the page. Safemode disables user and site level customizations, not content.

Thu, Jul 11, 6:22 PM · TemplateStyles, User-DannyS712
Anomie added a comment to T227688: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData".

I guess this is a PHP bug of sorts?

PHP devs seem to disagree, although it's hard to see from the comments why: #42030

Thu, Jul 11, 6:20 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MediaWiki-extensions-OAuth, Wikimedia-production-error
Anomie added a comment to T227739: Contention on User::getActorId ?.

While it would be interesting to figure out the User::getActorId lock wait timeout, I see only 5 in the linked timeframe (and only 6 in the past 24 hours). They seem related to the same Special:Import as the rc_this_oldid error mentioned, but it's not obvious to me how or why. Most seem to be from job runners trying to process CategoryMembershipChangeJobs after the fact, just one is directly from the import.

Thu, Jul 11, 6:13 PM · Wikimedia-database-error, Core Platform Team (Code Health (TEC13)), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, MediaWiki-User-management
Anomie added a comment to T227447: Librarize i18n-related PHP classes in MediaWiki.

Re: escaping, basically messages are processed in two stages: first either leave as is or preprocess or fully parse, then either escape or leave as is (conceptually, sanitizing the HTML would be the third option, but that happens as part of the parse).

Thu, Jul 11, 6:07 PM · Librarization, I18n, MediaWiki-Internationalization
Anomie added a comment to T227776: Generalize ParserCache into a generic service class for large "current" page-derived data.

Overall I like the idea, but I'd want to see more details as to how all the "in addition support" stuff is actually going to work at an interface level that doesn't wind up turning it into just another generic key-value store.

Thu, Jul 11, 2:20 PM · Core Platform Team, TechCom, User-Daniel, Proposal

Wed, Jul 10

Anomie merged T227517: MWException when moving talk page on enwiki: "Failed to create null revision while moving page" into T205675: Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given".
Wed, Jul 10, 1:16 PM · Core Platform Team Workboards (Clinic Duty Team), User-zeljkofilipin, Technical-Debt, MediaWiki-General, Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Wikimedia-production-error
Anomie merged task T227517: MWException when moving talk page on enwiki: "Failed to create null revision while moving page" into T205675: Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given".
Wed, Jul 10, 1:16 PM · Core Platform Team, MediaWiki-General, Multi-Content-Revisions, User-DannyS712, Wikimedia-production-error

Tue, Jul 9

Anomie added a comment to T85000: Investigate query planning in MariaDB 10.

I found that the fifth possibility in T85000#936374 seems to do the right thing on 10.1.39.

wikiadmin@10.64.0.92(enwiki)> explain SELECT /*! STRAIGHT_JOIN */ page_namespace,page_title,page_id FROM `page`,`langlinks` WHERE page_namespace = '0' AND (page_id=ll_from) GROUP BY page_title ORDER BY page_title LIMIT 11;
+------+-------------+-----------+------+--------------------+------------+---------+---------------------+----------+--------------------------+
| id   | select_type | table     | type | possible_keys      | key        | key_len | ref                 | rows     | Extra                    |
+------+-------------+-----------+------+--------------------+------------+---------+---------------------+----------+--------------------------+
|    1 | SIMPLE      | page      | ref  | PRIMARY,name_title | name_title | 4       | const               | 23486175 | Using where; Using index |
|    1 | SIMPLE      | langlinks | ref  | PRIMARY            | PRIMARY    | 4       | enwiki.page.page_id |        3 | Using index              |
+------+-------------+-----------+------+--------------------+------------+---------+---------------------+----------+--------------------------+

So if we need to do something about the query at some point and 10.3 is the same as 10.1 here, I guess that's the thing to do.

Tue, Jul 9, 6:40 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, MediaWiki-General
Anomie added a comment to T184529: Define a way to get a database connection based on a logical wiki ID..

I think using strings for this at all is a big problem. And encoding any "real" information into these strings makes it even worse. Wiki IDs should be totally opaque identifiers, and we should have a class to model them.

Tue, Jul 9, 4:50 PM · Core Platform Team (Cross-Wiki (CDP2)), User-Daniel, MediaWiki-Database
Anomie added a comment to T224020: Create a class to represent the identity of wikis on the same wiki farm.

This seems very overcomplicated. The proposal in this task seems to be https://xkcd.com/927/ for the concept of "identifiers", and would likely turn out much like the last panel there.

Tue, Jul 9, 4:49 PM · Performance-Team (Radar), Proposal, MediaWiki-General, MediaWiki-Farmers, User-Daniel, Core Platform Team (Cross-Wiki (CDP2))
Anomie added a comment to T226598: REST API i18n.

I'm a bit worried that we'll end up with something clunky that tried to hard to fit all the use cases. Perhaps multiple more specific and lightweight libraries would be better.

Tue, Jul 9, 2:47 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)

Mon, Jul 8

Anomie added a comment to T227447: Librarize i18n-related PHP classes in MediaWiki.

I don't want to lick this cookie just yet, but I do hope to try to work on this sometime soon. Or at least parts of it, I doubt I'll bother with the "less-minimal implementation" bit.

Mon, Jul 8, 9:55 PM · Librarization, I18n, MediaWiki-Internationalization
Anomie added a comment to T226598: REST API i18n.

The action API has the errorlang parameter, which may be [...] "uselang" (apparently a misspelling of userlang)

Mon, Jul 8, 9:42 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2)), Services (watching)
Anomie moved T227066: Integrate MW_API with MediaWiki REST API framework from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Mon, Jul 8, 4:50 PM · MediaWiki-API, MediaWiki-REST-API
Anomie moved T226587: Notifications count via notwikis=* doesn’t work for sessions providers other than CentralAuth from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Mon, Jul 8, 4:05 PM · Growth-Team, MediaWiki-API, Notifications
Anomie added a comment to T227066: Integrate MW_API with MediaWiki REST API framework.
  • (?) allows use of the Promise-Non-Write-API-Action header (WebStart.php)
Mon, Jul 8, 3:49 PM · MediaWiki-API, MediaWiki-REST-API
Anomie closed T85000: Investigate query planning in MariaDB 10 as Declined.

which may kill performance for a lot of API queries. We should figure out if that's true

Mon, Jul 8, 2:51 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, MediaWiki-General

Fri, Jun 21

Anomie closed T224730: Update API documentation for new Timestamp library version as Resolved.
Fri, Jun 21, 9:07 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MediaWiki-API
Anomie closed T144482: ISO date format not honored by Mediawiki API (arvbadtimestamp_arvstart) as Resolved.
Fri, Jun 21, 9:06 PM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, Timestamp, MediaWiki-API

Thu, Jun 20

Anomie moved T224730: Update API documentation for new Timestamp library version from Blocked to Needs Review on the MediaWiki-API board.
Thu, Jun 20, 5:01 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), MediaWiki-API

Jun 13 2019

Anomie closed T224815: PHP error: Undefined index: 6::ofield and 7::nfield (from DeleteLogFormatter.php) as Resolved.
Jun 13 2019, 1:23 PM · Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), MediaWiki-Page-deletion, MediaWiki-API, Wikimedia-production-error, MediaWiki-Logging

Jun 12 2019

Anomie added a comment to T225574: The SiteConfiguration class (wgConf) should not skip extraction if default is specified as null.

This reminds me of T192855: Remex enabled on all wikis in MW 1.30-wmf.30 exposing corruption (signatures coloring unrelated follow-up sections, etc.) on unfixed content, related IRC discussion in https://wm-bot.wmflabs.org/logs/%23mediawiki-core/20180424.txt, and the workaround in rOMWCe674799cb346: Fix wgTidyConfig expansion to not ignore `null` as value.

Jun 12 2019, 3:34 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Configuration
Anomie closed T225462: Inform about localised special page aliases in Siteinfo API as Invalid.

I'll close this for now. No objection to reopening if the situation changes so aliases[0] is no longer suitable.

Jun 12 2019, 3:12 PM · MediaWiki-API
Anomie added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

The 7.3 failure in https://travis-ci.org/wikimedia/mediawiki/jobs/544313531 is T207100: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3.

Jun 12 2019, 2:41 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Anomie moved T225584: Enable UserFeedback Gadget on MediaWiki.org from Unsorted to Non-Code on the MediaWiki-API board.
Jun 12 2019, 2:14 PM · Developer-Advocacy (Apr-Jun 2019), Documentation, MediaWiki-API

Jun 11 2019

Anomie added a comment to T225462: Inform about localised special page aliases in Siteinfo API.

Some special pages can have English aliases and not have translated aliases, so that way of guessing can be wrong.

Jun 11 2019, 7:43 PM · MediaWiki-API
Anomie committed rMLOF7a05d6c915b4: Implement spec 'services' for DI (authored by Anomie).
Implement spec 'services' for DI
Jun 11 2019, 5:48 PM
Anomie committed rMLOFdf6bf21ab0e0: Enhance to be able to replace most/all MediaWiki object instantiation (authored by Anomie).
Enhance to be able to replace most/all MediaWiki object instantiation
Jun 11 2019, 5:48 PM
Anomie committed rMLOFf3206271db6e: Implement spec 'services' for DI (authored by Anomie).
Implement spec 'services' for DI
Jun 11 2019, 5:47 PM
Anomie committed rMLOFdedbaec685e6: Enhance to be able to replace most/all MediaWiki object instantiation (authored by Anomie).
Enhance to be able to replace most/all MediaWiki object instantiation
Jun 11 2019, 5:47 PM
Anomie moved T225244: Travis CI failures in ApiQueryLanguageinfoTest from Unsorted to In Dev on the MediaWiki-API board.
Jun 11 2019, 5:07 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Anomie moved T225462: Inform about localised special page aliases in Siteinfo API from Unsorted to Needs details or plan on the MediaWiki-API board.
Jun 11 2019, 5:07 PM · MediaWiki-API
Anomie added a comment to T225462: Inform about localised special page aliases in Siteinfo API.

but API doesn’t tell which one is being used as a ‘canonical’ special page name on a wiki

Jun 11 2019, 4:14 PM · MediaWiki-API
Anomie added a comment to T225244: Travis CI failures in ApiQueryLanguageinfoTest.

Okay, the Language::getLocalisationCache()->unloadAll(); doesn’t seem to make a difference. But I can keep trying more things (and adding debug code) on GitHub now that pull request building is enabled… though I don’t know how much time I’ll have for this :/

Jun 11 2019, 4:11 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-production-error (Shared Build Failure), MediaWiki-Internationalization, MediaWiki-API
Anomie committed R1985:5bebc322d268: Document supported formats in README.md (authored by Anomie).
Document supported formats in README.md
Jun 11 2019, 3:36 PM
Anomie added a comment to T200055: Some pages have revisions by invalid usernames (with leading or trailing space) which break the "Info" and "History" views.

That's a slightly different issue, having to do with recently added validation in Title rather than this task which has to do with usernames stored in the database. The specific example affects user pages only because it's WikiLove trying to find the user talk page for a user subpage.

Jun 11 2019, 2:19 PM · Core Platform Team (Security, stability, performance and scalability (TEC1)), Wikimedia-production-error, MediaWiki-General
Anomie added a comment to T223239: REST API Parameter Validation.

If I were saving generic requests to a database, I'd be more likely to have a table with fields "param_name" and "param_value" rather than trying to make every possible parameter name a separate field. Or serialize all the parameters to a single text field. If I were designing storage for a specific handler, I'd be more likely to be using a getWikiUserTextNameOrIP() method so the code doing the DB insertion didn't have to know or care how exactly that value was determined.

Jun 11 2019, 2:09 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2))
Anomie added a comment to T223239: REST API Parameter Validation.

Parameter names often make their way into case insensitive (e.g. SQL) systems, and dealing with different casing there can be a pain.

Jun 11 2019, 1:50 PM · Patch-For-Review, MediaWiki-REST-API, Core Platform Team (Parsoid REST API in PHP (CDP2))

Jun 10 2019

Anomie added a comment to T224919: Code Stewardship Review: OAuth extension.

{{citation needed}}. Tests on recent patches such as https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/513737 (on the same day this task was created) passed.

<ref> T223225: CI failing in CirrusSearch tests with “Undefined index: REQUEST_TIME_FLOAT” </ref>.

Jun 10 2019, 8:40 PM · Release-Engineering-Team (Code Health), Release-Engineering-Team-TODO, Code-Stewardship-Reviews
Anomie added a comment to T137805: API action=login is deprecated.

What do you do now, without BotPasswords? Have your test account have the same password everywhere?

Jun 10 2019, 7:54 PM · Pywikibot-tests, Pywikibot, Pywikibot-login.py
Anomie added a comment to T212482: Evolve hook system to support "filters" and "actions" only.

I just came across T157402: Provide a reliable way to pass information between hook handlers, "hooked" objects and I'm wondering how the use cases described there fit into the model proposed here.

Jun 10 2019, 7:25 PM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom
Anomie added a comment to T137805: API action=login is deprecated.
  • I believe it is possible to pass the botpassword in the classic login process by using "prefix@password" as password (this is not clearly documented on mw.org but is shown after creating a botpassword).
Jun 10 2019, 7:25 PM · Pywikibot-tests, Pywikibot, Pywikibot-login.py
Anomie updated subscribers of T224919: Code Stewardship Review: OAuth extension.

I found this after seeing https://www.mediawiki.org/w/index.php?diff=3261645&oldid=3261642 and searching, as the relevant project tags don't seem to have been added to this task. If this is about MediaWiki-extensions-OAuth as that edit indicates, the summary seems incorrect. If it's not about that extension, then the confusion should be cleared up.

Jun 10 2019, 7:24 PM · Release-Engineering-Team (Code Health), Release-Engineering-Team-TODO, Code-Stewardship-Reviews
Anomie added a comment to T225227: gsub error emitted by mw.text.trim().

Note that Scribunto provides the backtrace when you click the error that is output in the page, assuming you have JavaScript enabled:

Jun 10 2019, 7:16 PM · MediaWiki-extensions-Scribunto
Anomie added a comment to T206013: importDump.php --uploads crashes on wikitech-static.

It'd be nice to figure out why XMLReader::open() seems unable to open files that seem like they do in fact exist. Is there some sort of multiprocess work going on and the process doing the open() is racing with the process writing the file? Or is it possible multiple dump processes are trying to use the same temporary file names somehow and stomping on each other? But I don't know whether it's worth the time/effort if we have a workaround.

Jun 10 2019, 7:14 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release-notes, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release, MediaWiki-Export-or-Import, Patch-For-Review, cloud-services-team (Kanban), wikitech.wikimedia.org
Anomie added a comment to T167246: Refactor "user" & "user_text" fields into "actor" reference table.

One other thing I noticed: The bot flag seems like something intrinsic to the actor, not the action, but rc_bot was left on the recentchanges table. Also doesn't appear deprecated. Any plans there?

Jun 10 2019, 7:01 PM · Schema-change, MediaWiki-General, Core Platform Team (Revision Storage Schema Improvements), MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Epic
Anomie closed T225361: CannotCreateActorException from line 2516 of /../w/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user as Resolved.

In the end it issue is that SMW uses users for logging activities that are not registered. Since this worked for quite some time we are looking for advice on how to bring this behaviour back to life.

Jun 10 2019, 5:45 PM · MW-1.33-release, MediaWiki-User-management

Jun 7 2019

Anomie added a comment to T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).

Did you not provide an oldhtmlfile deliberately to mimic absence of RESTBase? Or was it unintentional? Because if you had provided the old HTML file, you wouldn't have uncovered this.

Jun 7 2019, 5:17 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor
Anomie added a comment to T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).

I just saw an edit on wikitech with a similar dirty diff: https://wikitech.wikimedia.org/w/index.php?title=Logstash&diff=1828764&oldid=1827679

Jun 7 2019, 1:16 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor

Jun 6 2019

Anomie added a comment to T224368: Ensure Linker::userLink is not called with empty user name.

Okay, so how many unhappy rows like this do we have in the actor table?

Jun 6 2019, 4:31 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging
jcrespo awarded T204729: Potential enwiki DOS due to slow WatchedItemStore::countVisitingWatchersMultiple a Love token.
Jun 6 2019, 4:01 PM · User-Addshore, MediaWiki-Database, Performance, MediaWiki-General, Security
Anomie closed T213999: luasandbox profiler test failing due to Linux kernel regression as Resolved.

Fixed in Debian's 4.19.16-1 package, and in Linux itself in 4.19.19, so I'm going to close this now.

Jun 6 2019, 3:03 PM · Upstream, LuaSandbox
Anomie created T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).
Jun 6 2019, 2:14 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor

Jun 5 2019

Anomie merged T74153: meta=siteinfo&prop=langlinks should indicate whether a language is RTL into T220415: Add API module to get language information.
Jun 5 2019, 1:52 PM · MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Wikimedia-Hackathon-2019, MediaWiki-API, MediaWiki-Internationalization