Page MenuHomePhabricator

Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (20)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (262 w, 6 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Today

Anomie added a comment to T235971: Run maintenance/cleanupUsersWithNoId.php on beta testwiki.

You need to supply --prefix, and you might want to use --assign too.

Mon, Oct 21, 7:46 PM · Wikimedia-maintenance-script-run, Beta-Cluster-Infrastructure
Anomie moved T230862: Create a way to filter only WB-related changes from Commons recentchanges from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Oct 21, 6:23 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog, MediaWiki-API, Wikidata-Query-Service, SDC General, Commons, Wikidata
Anomie added a project to T230862: Create a way to filter only WB-related changes from Commons recentchanges: Core Platform Team Workboards (Clinic Duty Team).
Mon, Oct 21, 6:23 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Structured Data Engineering, Structured-Data-Backlog, MediaWiki-API, Wikidata-Query-Service, SDC General, Commons, Wikidata
Anomie moved T152478: Doxygen method docs are not inherited (only when abstract classes are involved?) from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Oct 21, 4:44 PM · Release-Engineering-Team, Core Platform Team, Upstream, MediaWiki-Documentation
Anomie moved T162001: Special:ApiSandbox text box too small (specially with JSON data) from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Oct 21, 4:43 PM · Core Platform Team, MediaWiki-API, good first bug
Anomie moved T235922: Release MW 1.34.0-rc.1 from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Oct 21, 4:42 PM · Core Platform Team, MediaWiki-Releasing, MW-1.34-notes, MW-1.34-release
Anomie moved T235955: Update Revision classes to clarify that they accept DB domain values from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Oct 21, 4:36 PM · Patch-For-Review, Core Platform Team, Performance-Team (Radar), MediaWiki-Revision-backend
Anomie added a comment to T235955: Update Revision classes to clarify that they accept DB domain values.

IMO the exposure of "db domains" outside of internal LoadBalancer→Database communication was and is a bad idea. Most of the code should consider "wiki ids" as opaque strings. The public interfaces of LBFactory, LoadBalancer, and Database should follow suit.

Mon, Oct 21, 4:36 PM · Patch-For-Review, Core Platform Team, Performance-Team (Radar), MediaWiki-Revision-backend
Anomie moved T235978: In meta=allmessages API, amincludelocal does nothing from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Oct 21, 2:40 PM · Core Platform Team, MediaWiki-Internationalization, MediaWiki-API
Anomie moved T235978: In meta=allmessages API, amincludelocal does nothing from Unsorted to Needs details or plan on the MediaWiki-API board.
Mon, Oct 21, 2:40 PM · Core Platform Team, MediaWiki-Internationalization, MediaWiki-API
Anomie updated subscribers of T235978: In meta=allmessages API, amincludelocal does nothing.

Broken by rMWa3d6c1411dad: messagecache: avoid caching message pages that do not override, which made MessageCache::getAllMessageKeys() stop returning keys of custom messages.

Mon, Oct 21, 2:39 PM · Core Platform Team, MediaWiki-Internationalization, MediaWiki-API

Fri, Oct 18

Anomie moved T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Oct 18, 4:57 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, ci-test-error, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
Anomie added a comment to T235666: Implement GET /revision/{from}/intermediatecount/{to}.

Back in 2014 the following patch has added a limit to the Title::countRevisionsBetween method that we intend to use in the implementation here with a rationale that a query was causing DB timeouts. The query we're going to use is the same, thus I think it has the potential to keep timing out.

Fri, Oct 18, 2:43 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Anomie moved T226337: SpecialChangeEmail causes "MWException: CAS update failed on user_touched" from User.php from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Fri, Oct 18, 1:34 PM · Core Platform Team, Availability, Wikimedia-production-error, MediaWiki-User-preferences

Thu, Oct 17

Anomie added a comment to T235568: Implement Param Validation for Existence of Title and Access Rights.

@Pchelolo @Anomie Says the piece of work that impacts this is close to ready and he's going to prioritise it so we can wait with this task for that code to land.

Thu, Oct 17, 8:09 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Anomie moved T235801: Rework ParamValidator to use MessageValue from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Oct 17, 8:07 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team)
Anomie added a subtask for T142080: HTTP API typechecking method is very confusing and intimidating: T235801: Rework ParamValidator to use MessageValue.
Thu, Oct 17, 8:06 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API, Technical-Debt
Anomie added a subtask for T235568: Implement Param Validation for Existence of Title and Access Rights: T235801: Rework ParamValidator to use MessageValue.
Thu, Oct 17, 8:06 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Anomie added parent tasks for T235801: Rework ParamValidator to use MessageValue: T235568: Implement Param Validation for Existence of Title and Access Rights, T142080: HTTP API typechecking method is very confusing and intimidating.
Thu, Oct 17, 8:06 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team)
Anomie created T235801: Rework ParamValidator to use MessageValue.
Thu, Oct 17, 8:06 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team)
Anomie moved T199834: Implement a MW API module for interacting with Jade entities from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Oct 17, 1:27 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Scoring-platform-team (Current), Jade, Documentation
Anomie edited projects for T199834: Implement a MW API module for interacting with Jade entities, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Oct 17, 1:27 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Scoring-platform-team (Current), Jade, Documentation
Anomie added a comment to T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file.

Not a (recent) regression. It's certainly a duplicate of T212687, and related to if not a duplicate of T30299.

Thu, Oct 17, 1:21 PM · Structured-Data-Backlog, Structured Data Engineering, Regression, Core Platform Team, MediaWiki-File-management, Commons
Anomie merged T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file into T212687: Local file page has bugs if there is a redirect on Shared under the same name.
Thu, Oct 17, 1:21 PM · Multimedia, Commons, MediaWiki-File-management, MediaWiki-Redirects
Anomie merged task T235721: File page for local Wikipedia image wrongly shows thumbnail for remote Commons file into T212687: Local file page has bugs if there is a redirect on Shared under the same name.
Thu, Oct 17, 1:21 PM · Structured-Data-Backlog, Structured Data Engineering, Regression, Core Platform Team, MediaWiki-File-management, Commons

Wed, Oct 16

Anomie moved T231866: Circular dependency when creating service! ContentLanguage from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Oct 16, 8:30 PM · Core Platform Team, Performance-Team (Radar), Language-Team, MW-1.34-release, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, MediaWiki-extensions-Gadgets, MediaWiki-ServiceContainer
Anomie moved T200055: Some pages have revisions by invalid usernames (with leading or trailing space) which break the "Info" and "History" views from Waiting for Review to Ready on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Oct 16, 4:55 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, MediaWiki-General
Anomie moved T56035: API imageinfo should allow fetching multiple thumbnail sizes from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Oct 16, 4:03 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie moved T186573: Add information about hidden fields (e.g., userhidden, commenthidden, sha1hidden, etc.) to api.php documentation from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Oct 16, 1:31 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, good first bug, MediaWiki-API, Documentation, MediaWiki-Documentation
Anomie edited projects for T186573: Add information about hidden fields (e.g., userhidden, commenthidden, sha1hidden, etc.) to api.php documentation, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

I don't see any problems with the approach, or at a quick glance through the patch. I don't have time at the moment to give this one a full review; if you're confident that the change is good, feel free to merge.

Wed, Oct 16, 1:31 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, good first bug, MediaWiki-API, Documentation, MediaWiki-Documentation

Tue, Oct 15

Anomie moved T231366: Remove ProfilerOutputDb feature from MediaWiki core from Discussing to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 15, 4:45 PM · MW-1.34-notes, MW-1.35-release, Core Platform Team Workboards (Clinic Duty Team), Performance-Team, MediaWiki-Debug-Logger
Anomie closed T234368: mw.getCurrentFrame at module scope returns wrong frame for #invoke passed to #invoke as Resolved.
Tue, Oct 15, 3:55 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-Scribunto
Anomie removed a project from T132946: Deprecate videoinfo: Core Platform Team.
Tue, Oct 15, 3:16 PM · Technical-Debt (Deprecation process), TimedMediaHandler, MediaWiki-API
Anomie moved T219702: Page import can fail with "Lock wait timeout exceeded" in WikiPage::insertOn from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:15 PM · Core Platform Team Workboards (Clinic Duty Team), Wikimedia-database-error, MediaWiki-Revision-backend, MediaWiki-Export-or-Import, Wikimedia-production-error, Chinese-Sites
Anomie removed a project from T104083: Include Flow revisions in RecentChanges API: Core Platform Team.
Tue, Oct 15, 3:15 PM · Growth-Team, MediaWiki-API, StructuredDiscussions
Anomie moved T56035: API imageinfo should allow fetching multiple thumbnail sizes from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 15, 3:14 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie edited projects for T56035: API imageinfo should allow fetching multiple thumbnail sizes, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 15, 3:14 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie moved T235298: Follow RFC7807 for REST error format from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:13 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Anomie moved T235311: LBFactoryTest doesn't check for exception in the expected place from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:13 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Core-Testing, Wikimedia-Rdbms
Anomie moved T229443: Unable to view some pages on Incubator (Postcondition failed in Title::getBaseTitle via GeoCrumbsHooks) from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:12 PM · MediaWiki-extensions-WikimediaIncubator, Core Platform Team Workboards (Clinic Duty Team), GeoCrumbs, incubator.wikimedia.org, Wikimedia-production-error
Anomie moved T235355: REST Handler::getValidatedParams() return contract from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:11 PM · CPT Initiatives (Core REST API in PHP), MediaWiki-REST-API
Anomie moved T235512: Invalid magic word error on updating to MediaWiki 1.33.1 from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:10 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Parser, MediaWiki-Cache
Anomie moved T235357: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62 from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 3:01 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error
Anomie added a comment to T235357: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62.
path = /wiki/Wikimedia_Taiwan/wiki/index.php5/$1  pattern=/wiki/$1  SCRIPT_NAME=/wiki/Wikimedia_Taiwan/wiki/index.php5/$1
Tue, Oct 15, 3:01 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Wikimedia-production-error
Anomie added a comment to T235360: Call to a member function isSafeToLoad() on null.

@Krinkle: I've noticed that this format you're using for these bugs leaves out the location where the actual error occurred (exception.file), in this case /srv/mediawiki/php-1.35.0-wmf.1/languages/LanguageConverter.php:171.

Tue, Oct 15, 2:26 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, Wikimedia-production-error
Anomie moved T235360: Call to a member function isSafeToLoad() on null from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 2:21 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, Wikimedia-production-error
Anomie edited projects for T235360: Call to a member function isSafeToLoad() on null, added: MediaWiki-Internationalization; removed MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth, MediaWiki-Parser.

@Krinkle: I've noticed that this format you're using for these bugs leaves out the location where the actual error occurred (exception.file), in this case /srv/mediawiki/php-1.35.0-wmf.1/languages/LanguageConverter.php:171.

Tue, Oct 15, 2:21 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, Wikimedia-production-error
Pcoombe awarded T182549: Email sometimes not being sent when a task is created and "other task activity" is not set in user preferences a Burninate token.
Tue, Oct 15, 1:53 PM · Phabricator
Anomie moved T235395: Document how to get the current contents of a page via the MediaWiki API from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 1:13 PM · MediaWiki-API, Documentation, Outreachy, good first bug
Anomie moved T235476: ApiQueryExtLinksUsage euprop needs sanity check from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 1:13 PM · MediaWiki-API, Core Platform Team
Anomie moved T235477: ApiWatch result should emit namespace from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Oct 15, 1:12 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie moved T235476: ApiQueryExtLinksUsage euprop needs sanity check from Unsorted to Needs details or plan on the MediaWiki-API board.

Take, as an example, the query below. Clearly, the output is...not sane. In the event that no props are requested, the module should not run the query at all, and then either return an empty result set with a warning, or throw an error.

https://www.mediawiki.org/w/api.php?action=query&list=exturlusage&euprop=&eulimit=20

Tue, Oct 15, 1:12 PM · MediaWiki-API, Core Platform Team
Anomie moved T235477: ApiWatch result should emit namespace from Unsorted to Needs Code on the MediaWiki-API board.
Tue, Oct 15, 1:04 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API

Mon, Oct 14

Anomie moved T235316: PHP Notice: Undefined property: stdClass::$page_namespace from Unsorted to Needs Review on the MediaWiki-API board.
Mon, Oct 14, 12:27 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, MediaWiki-API, Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikimedia-production-error
Anomie moved T235316: PHP Notice: Undefined property: stdClass::$page_namespace from Inbox to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Oct 14, 12:27 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), MW-1.34-notes, MediaWiki-API, Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikimedia-production-error

Fri, Oct 11

Anomie added a comment to T235207: Some MediaWiki API call examples show an empty result set due to chosen query parameters.

You may have looked at them on enwiki or some other wiki where the main page is "Main Page". The old auto-generated documentation used the same examples as the current documentation does in almost all cases.

Fri, Oct 11, 9:27 PM · Documentation, MediaWiki-API, Core Platform Team
Anomie added a comment to T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.

And in some cases the actual article is at the lowercase-letter title, IIRC. The trick would be in determining which is which. Rather than do that for many different languages, we'll just move the pages to accessible titles and let each wiki's community decide whether they want to keep them, further rename them, or delete them.

Fri, Oct 11, 8:18 PM · CPT Initiatives (PHP7 (TEC4)), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, Operations, PHP 7.2 support, MediaWiki-General
Anomie moved T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Oct 11, 6:55 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, ci-test-error, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
Anomie added a project to T222416: WikibaseMediaInfo test MultiLingualCaptionsTest fails: Core Platform Team Workboards (Clinic Duty Team).
Fri, Oct 11, 6:55 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, ci-test-error, MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Wikimedia-production-error (Shared Build Failure), WikibaseMediaInfo
Anomie added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

@daniel, @aaron: I have a theory as to what's going on here.

Fri, Oct 11, 3:25 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Anomie added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

Seems unlikely. More likely is that the updating of the links tables to actually add it to the category listing didn't happen back in March when you made this edit. That situation persisted until a template used on that file page was edited, which triggered a reparse which finally did make it start showing up in the category.

Fri, Oct 11, 3:08 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Anomie added a comment to T231590: Implement GET Edit Count.

"unregistered" might be slightly more accurate than "anon" (or "IP"). But I'll leave the decision to you, I don't want to bikeshed.

Fri, Oct 11, 2:54 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Anomie moved T185508: Show “internal” API module help flag in Special:ApiSandbox from External Code Review In Progress to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Oct 11, 2:51 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie closed T185508: Show “internal” API module help flag in Special:ApiSandbox as Resolved.
Fri, Oct 11, 2:51 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie moved T235216: Reconsider memcached connection method for MW in PHP7 world from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Fri, Oct 11, 1:39 PM · Performance-Team (Radar), Core Platform Team, serviceops
Anomie moved T235244: Ensure operational visibility in ChronologyProtector from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Fri, Oct 11, 1:38 PM · Patch-For-Review, Core Platform Team, Wikimedia-Rdbms, observability
Anomie added a comment to T235265: Slow query on SpecialMostLinked creating lag on wikidata slaves.

We could probably eliminate the join with page in this query, but other than that I don't see much opportunity for improvement.

wikiadmin@10.64.32.113(wikidatawiki)> explain SELECT pl_namespace AS `namespace`,pl_title AS `title`,COUNT(*) AS `value`  FROM `pagelinks` GROUP BY pl_namespace,pl_title HAVING COUNT(*) > 1 ORDER BY value DESC LIMIT 5000;
+------+-------------+-----------+-------+---------------+--------------+---------+------+------------+----------------------------------------------+
| id   | select_type | table     | type  | possible_keys | key          | key_len | ref  | rows       | Extra                                        |
+------+-------------+-----------+-------+---------------+--------------+---------+------+------------+----------------------------------------------+
|    1 | SIMPLE      | pagelinks | index | NULL          | pl_namespace | 265     | NULL | 1311306562 | Using index; Using temporary; Using filesort |
+------+-------------+-----------+-------+---------------+--------------+---------+------+------------+----------------------------------------------+

The query is trying to find the 5000 (pl_namespace,pl_title) pairs with the most rows in pagelinks, so unfortunately it's going to have to scan the whole huge table and collect those counts. That expensive query is cached; updateSpecialPages.php is the maintenance script that runs periodically to update that cache.

Fri, Oct 11, 1:36 PM · Performance Issue, Core Platform Team Workboards (Clinic Duty Team), Wikidata, MediaWiki-Special-pages
Anomie moved T235265: Slow query on SpecialMostLinked creating lag on wikidata slaves from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Oct 11, 1:18 PM · Performance Issue, Core Platform Team Workboards (Clinic Duty Team), Wikidata, MediaWiki-Special-pages
Anomie edited projects for T235265: Slow query on SpecialMostLinked creating lag on wikidata slaves, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Fri, Oct 11, 1:18 PM · Performance Issue, Core Platform Team Workboards (Clinic Duty Team), Wikidata, MediaWiki-Special-pages

Thu, Oct 10

Anomie moved T235207: Some MediaWiki API call examples show an empty result set due to chosen query parameters from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Thu, Oct 10, 7:08 PM · Documentation, MediaWiki-API, Core Platform Team
Anomie triaged T235207: Some MediaWiki API call examples show an empty result set due to chosen query parameters as Low priority.

Someone could theoretically use Title::getMainPage(), but I'm not sure the extra complexity would really be worth it. Note that most of the time you'd also be needing to pass the main page title into the corresponding i18n message.

Thu, Oct 10, 7:08 PM · Documentation, MediaWiki-API, Core Platform Team
Anomie added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.
SELECT rev_text_id, bw_slots.*, bw_content.* FROM bw_revision LEFT JOIN bw_slots ON (slot_revision_id = rev_id) LEFT JOIN bw_content ON(content_id = slot_content_id) WHERE rev_id = 7714145;
+-------------+------------------+--------------+-----------------+-------------+------------+--------------+---------------------------------+---------------+-----------------+
| rev_text_id | slot_revision_id | slot_role_id | slot_content_id | slot_origin | content_id | content_size | content_sha1                    | content_model | content_address |
+-------------+------------------+--------------+-----------------+-------------+------------+--------------+---------------------------------+---------------+-----------------+
|     7493341 |          7714145 |            1 |         7631977 |     7714145 |    7631977 |          306 | hbcfzmjhq5y6tqydsgu14chmvx13ufp |             1 | tt:7493341      |
+-------------+------------------+--------------+-----------------+-------------+------------+--------------+---------------------------------+---------------+-----------------+
Thu, Oct 10, 5:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Anomie moved T185508: Show “internal” API module help flag in Special:ApiSandbox from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Oct 10, 5:26 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie edited projects for T185508: Show “internal” API module help flag in Special:ApiSandbox, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Oct 10, 5:26 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie added a comment to T235188: Some revisions' contents are incorrect in the cache - wrong contents shown in history & diffs.

@Nikerabbit: Try this:

SELECT rev_text_id, slots.*, content.* FROM revision LEFT JOIN slots ON (slot_revision_id = rev_id) LEFT JOIN content ON(content_id = slot_content_id) WHERE rev_id = 7714145;
Thu, Oct 10, 4:03 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), User-ArielGlenn, Language-Team (Language-2019-October-December), Patch-For-Review, MediaWiki-General, affects-translatewiki.net
Anomie added a comment to T185508: Show “internal” API module help flag in Special:ApiSandbox.

If you want to do anything in JS for it, you'd probably need to add another output array paralleling "deprecatedvalues".

Thu, Oct 10, 3:39 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie moved T233597: Refactor ApiMain to use OutputPage::sendCacheControl from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Oct 10, 3:13 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie edited projects for T233597: Refactor ApiMain to use OutputPage::sendCacheControl, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Oct 10, 3:13 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie moved T233597: Refactor ApiMain to use OutputPage::sendCacheControl from Unsorted to Needs Review on the MediaWiki-API board.
Thu, Oct 10, 3:13 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie added a comment to T227662: Update.php failure when upgrading from 1.32.1 to 1.33.

You should upgrade to 1.31.4, 1.32.4, or 1.33.1 as appropriate. Then update.php should work for you (or if it doesn't, it shouldn't be this issue).

Thu, Oct 10, 3:11 PM · MW-1.33-notes, MW-1.32-notes, MW-1.31-release-notes, MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie moved T185508: Show “internal” API module help flag in Special:ApiSandbox from Inbox to Triage Meeting Inbox on the Core Platform Team board.

Unless someone has a better suggestion, I’d display internal modules similar to deprecated ones: ordered at the end of the module list, strikethrough on the label, and with a bold red notice before the summary message.

Thu, Oct 10, 2:54 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie added a comment to T231366: Remove ProfilerOutputDb feature from MediaWiki core.

@WDoranWMF Forgot to say why I tagged, sorry. This feature doesn't have any steward and seems closely related to code we maintain. So as part of taking this on, we're also intending to sunset part of it.
I wanted to know whether CPT has any reservations about this feature, possible concerns, or knows about anyone using it – before we go ahead with its removal.

Thu, Oct 10, 1:52 PM · MW-1.34-notes, MW-1.35-release, Core Platform Team Workboards (Clinic Duty Team), Performance-Team, MediaWiki-Debug-Logger

Wed, Oct 9

Anomie closed T231071: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max as Resolved.

This should be gone now due to T176370, we no longer use HHVM so its limitation on length for serialized string values should no longer cause a problem.

Wed, Oct 9, 8:03 PM · PHP 7.2 support, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Wikimedia-production-error
Anomie added a comment to T231590: Implement GET Edit Count.

We thought getting reverted edits would be more difficult than getting minor edits so we updated the design to include minor edits. We'll be happy with either.

Wed, Oct 9, 4:30 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Anomie added a comment to T231598: Compose Count Queries.

Since it came up in discussion on T231590, here's the query for a count of minor edits:

Wed, Oct 9, 4:27 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Anomie added a comment to T231590: Implement GET Edit Count.

Let's take it as a given that our colleagues are competent and would not waste our development time or our server resources asking for features that users don't need.

Wed, Oct 9, 3:55 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Anomie added a comment to T233135: Schema change for refactored actor and comment storage.

Good catch. That's because protected_titles is in "fullviews" instead of "customviews".

Wed, Oct 9, 2:56 PM · Core Platform Team, Blocked-on-schema-change, DBA
Anomie moved T235011: API query times out from Unsorted to Needs details or plan on the MediaWiki-API board.

I see only four log entries for this request (specifically, for requests containing "Stift_Klosterneuburg_A3" in the URI) in the past 24 hours. Two indicate the same error as in T187759: API is returning 500 status code. One indicates that the query was being slow to execute. And one seems to be indicating that a 500 response was returned.

Wed, Oct 9, 2:51 PM · Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-API
Anomie moved T235011: API query times out from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Oct 9, 2:51 PM · Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-API
Anomie added a subtask for T89971: ApiQueryImageInfo is crufty, needs rewrite: T235011: API query times out.
Wed, Oct 9, 2:50 PM · Developer-Wishlist (2017), Technical-Debt, MediaWiki-API
Anomie added a parent task for T235011: API query times out: T89971: ApiQueryImageInfo is crufty, needs rewrite.
Wed, Oct 9, 2:50 PM · Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-API

Tue, Oct 8

Anomie moved T30751: prop=info&inprop=protection sometimes shows protection multiple times from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Oct 8, 9:06 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie edited projects for T30751: prop=info&inprop=protection sometimes shows protection multiple times, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Oct 8, 9:06 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie added a comment to T231590: Implement GET Edit Count.

I have to wonder why the IOS team needs all 5 numbers on every page. Then again, I also have to wonder why they need some of these numbers at all.

Tue, Oct 8, 8:59 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
Anomie added a comment to T234966: Decide on HTML format for machine-readable signatures.

As a base case, the current HTML emitted by a comment ending in ~~~~ in wikitext (with a sample comment text preceding) is:

<dd>The logo was never really non-free, as far as I can tell, it's been replaced by an identical SVG, which wouldn't change the non-free situation in any case.  But SVG is better than PNG, so go ahead, delete away. <a href="/wiki/User:Cananian" class="mw-redirect" title="User:Cananian">C. Scott Ananian</a> 18:07, 29 March 2007 (UTC)</dd>
Tue, Oct 8, 6:16 PM · OWC2020
Anomie added a comment to T234688: expose article count method through API.

If you consider that "hypothetical", then I guess it's hypothetical.

Tue, Oct 8, 5:52 PM · Core Platform Team, MediaWiki-API
Anomie closed T234795: Wikibase Travis CI jobs failing with the SQL syntax error as Resolved.
Tue, Oct 8, 5:07 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team, SQLite, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Anomie added a project to T234795: Wikibase Travis CI jobs failing with the SQL syntax error: Core Platform Team Workboards (Clinic Duty Team).
Tue, Oct 8, 4:56 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team, SQLite, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Anomie added a comment to T234795: Wikibase Travis CI jobs failing with the SQL syntax error.

Bah, I figured it out. I should have read https://www.sqlite.org/lang_UPSERT.html more closely. The diagram at the top shows part of the syntax is optional, but the text adds restrictions:

Tue, Oct 8, 4:50 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team, SQLite, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Anomie added a comment to T234795: Wikibase Travis CI jobs failing with the SQL syntax error.

But that doesn't change the fact that whatever PHP is using, it reports 3.24.0 but doesn't have the upsert syntax added in 3.24.0.

Tue, Oct 8, 4:31 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team, SQLite, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata