Page MenuHomePhabricator

Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (18)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (280 w, 1 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Today

Anomie merged T245573: LuaSandbox should clean up short_src for multibyte-safe truncation into T228746: mw.config empty on some pages due to non-UTF8 data from LuaSandbox.
Wed, Feb 19, 2:21 PM · Core Platform Team Workboards (Clinic Duty Team), LuaSandbox, MediaWiki-extensions-Scribunto, Wikimedia-production-error
Anomie merged task T245573: LuaSandbox should clean up short_src for multibyte-safe truncation into T228746: mw.config empty on some pages due to non-UTF8 data from LuaSandbox.
Wed, Feb 19, 2:21 PM · LuaSandbox

Yesterday

Anomie added a comment to T244204: siteinfo api calls should be cached for N minutes on the caching layer.

Should we set setCacheMaxAge() by default in ApiQuerySiteinfo?

Tue, Feb 18, 8:29 PM · Core Platform Team Workboards (Clinic Duty Team), Operations, serviceops, MediaWiki-General
Anomie added a comment to T244263: Document when, where and how changes to the API are announced.

I don't object to announcing of breaking changes to other APIs (besides the Action API) to mediawiki-api-announce. But it's intended to be a low-traffic announcements mailing list, so IMO we should strictly limit announcement of updates that aren't breaking changes.

Tue, Feb 18, 8:11 PM · Core Platform Team Workboards (Clinic Duty Team), Documentation
Anomie moved T245155: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin) from Waiting for Review to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Feb 18, 5:59 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Anomie added a comment to T245489: Possibly disable optimizer flag: rowid_filter on 10.4.

We can now actually try to see what the optimizer is really doing:

Tue, Feb 18, 4:58 PM · DBA
Anomie moved T244274: Write down good practices for Logstash dashboards from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Feb 18, 4:19 PM · Performance-Team (Radar), Core Platform Team, Developer Productivity
Anomie removed a project from T212851: Confusing error for OAuth consumers with rollback but not edit grant: Core Platform Team.
Tue, Feb 18, 4:18 PM · MediaWiki-API, MediaWiki-User-management, MediaWiki-extensions-OAuth
Anomie moved T238464: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Feb 18, 4:13 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, MediaWiki-Installer
Anomie edited projects for T238464: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}", added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Feb 18, 4:13 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Internationalization, MediaWiki-Installer
Anomie moved T245375: Issues running revactor_rev when joining page, revision, revision_actor_temp, and actor tables from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Feb 18, 4:09 PM · Core Platform Team Workboards (Clinic Duty Team), GLOW
Anomie edited projects for T245375: Issues running revactor_rev when joining page, revision, revision_actor_temp, and actor tables, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

Nothing has changed recently with any of these tables. What issues exactly are you seeing?

Tue, Feb 18, 4:09 PM · Core Platform Team Workboards (Clinic Duty Team), GLOW
Anomie moved T226337: SpecialConfirmEmail causes "MWException: CAS update failed on user_touched" from User.php from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Feb 18, 4:00 PM · Performance-Team (Radar), Core Platform Team, Availability, Wikimedia-production-error, MediaWiki-User-preferences
Anomie edited projects for T245492: Slow query: IndexPager::buildQueryInfo (MediaWiki\Linter\LintErrorsPager), added: Parsing-Team; removed Core Platform Team.

Since this is in the Linter extension, I'm going to push this over to Parsing-Team rather than Core Platform Team.

Tue, Feb 18, 3:40 PM · Parsing-Team, mariadb-optimizer-bug, MediaWiki-extensions-Linter, Performance Issue
Anomie added a comment to T245489: Possibly disable optimizer flag: rowid_filter on 10.4.
root@db1107.eqiad.wmnet[enwiki]> explain SELECT /* ApiQueryExtLinksUsage::run */ el_index_60, el_id, page_id, page_namespace, page_title, el_to FROM `page`, `externallinks` WHERE (page_id=el_from) AND (el_index_60 LIKE 'http://edu.utexas.cs.www./%' ESCAPE '`' ) AND (el_index LIKE 'http://edu.utexas.cs.www./%' ESCAPE '`' ) ORDER BY el_index_60, el_id LIMIT 501 /* ebd959f27d0c6fd989d1561b40ae8a3b db1107 enwiki 24s */;
+------+-------------+---------------+--------+-----------------------------------------------+----------+---------+------------------------------+------+-----------------------------+
| id   | select_type | table         | type   | possible_keys                                 | key      | key_len | ref                          | rows | Extra                       |
+------+-------------+---------------+--------+-----------------------------------------------+----------+---------+------------------------------+------+-----------------------------+
|    1 | SIMPLE      | externallinks | range  | el_from,el_index,el_index_60,el_from_index_60 | el_index | 62      | NULL                         | 553  | Using where; Using filesort |
|    1 | SIMPLE      | page          | eq_ref | PRIMARY                                       | PRIMARY  | 4       | enwiki.externallinks.el_from | 1    |                             |
+------+-------------+---------------+--------+-----------------------------------------------+----------+---------+------------------------------+------+-----------------------------+
2 rows in set (0.00 sec)
Tue, Feb 18, 3:04 PM · DBA
Anomie removed projects from T245374: WMFTimeoutException on non-existent files: MediaWiki-API, Core Platform Team.

Pywikibot is using POST and not GET, but it fails the same. Most recent attempt resulted in

{"error":{"code":"internal_api_error_WMFTimeoutException","info":"[XknCBQpAAEsAAJ7w@woAAACH] Caught exception of type WMFTimeoutException","errorclass":"WMFTimeoutException"},"servedby":"mw1280"}

Could someone with logstash access look into what's going on with the media-wiki end?

Tue, Feb 18, 2:51 PM · Pywikibot, Operations

Fri, Feb 14

Anomie added a comment to T88914: CSSMin library calls global function wfExpandUrl().

I did some investigation of libraries with high usage numbers on packagist.org, mainly by searching for mention of RFC 3986. Of the ones that have a "resolve" method at all,

Fri, Feb 14, 11:03 PM · Core Platform Team Workboards (Clinic Duty Team), patch-welcome, Performance-Team, Librarization, MediaWiki-ResourceLoader
Anomie changed the status of T106388: Audit all existing code to ensure that any extension currently or previously adding blobs to ExternalStore has been registering a reference in the text table (and fix up if wrong), a subtask of T106386: Compress data at external storage, from Open to Stalled.
Fri, Feb 14, 10:57 PM · MediaWiki-Revision-backend, Operations
Anomie changed the status of T106388: Audit all existing code to ensure that any extension currently or previously adding blobs to ExternalStore has been registering a reference in the text table (and fix up if wrong) from Open to Stalled.

Marking this stalled, since the subtask for fixing this issue for Flow has been declined...

Fri, Feb 14, 10:57 PM · Core Platform Team, Release-Engineering-Team, Release-Engineering-Team-TODO
Anomie changed the status of T106386: Compress data at external storage from Open to Stalled.

This can't be done until Flow's data isn't going to be deleted when the recompression is run. But now the tasks for moving Flow's data out of the MW ExternalStore have been declined...

Fri, Feb 14, 10:56 PM · MediaWiki-Revision-backend, Operations
Anomie added a comment to T240094: Create required table for new Watchlist Expiry feature.

Note that MediaWiki's database abstraction layer cannot generate a multi-table delete like this, and I'd probably oppose adding that functionality since multi-table delete seems MySQL-specific and is likely to go against patterns we encourage. Also the use of NOW() in there might not be replication-safe (or does replication account that?).

Can IDatabase::deleteJoin() be used for the multi-table deletion?

Fri, Feb 14, 10:38 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), DBA, Community-Tech (Kanban-Q3-2019-20), Core Platform Team Workboards (Clinic Duty Team), Expiring-Watchlist-Items
Anomie added a comment to T239639: Add filtering to list=allimages for feature parity with Special:NewFiles.

The media type filters and an equivalent to the "Hide patrolled uploads" checkbox are still missing. But since there's apparently no one asking for that anymore (the request seems to have been based on a misunderstanding), it doesn't matter much to me if we close this for now versus just untagging CPT.

Fri, Feb 14, 10:31 PM · MediaWiki-API, Core Platform Team
Anomie moved T241516: Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Fri, Feb 14, 9:39 PM · Core Platform Team, Wikimedia-Rdbms, MediaWiki-Debug-Logger
Anomie added a comment to T245075: Improve file attribution for “Called deprecation function” logs.

I think I agree with @Krinkle on this, turning things inside out with DeprecationHelper being passed a callback seems to have no advantage here over the more straightforward code calling wfDeprecated(). In my opinion, it actually makes the code more confusing.

Fri, Feb 14, 9:36 PM · Patch-For-Review, Core Platform Team, MediaWiki-Debug-Logger
Anomie moved T224808: Consider limiting SqlBagOStuff makeKey logic from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Fri, Feb 14, 9:32 PM · Core Platform Team, Technical-Debt, MediaWiki-Cache
Anomie moved T245244: Conflict resolution process ends with incorrect "This page has been restored" from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 14, 9:31 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-editing, Patch-For-Review, TCB-Team
Anomie edited projects for T245244: Conflict resolution process ends with incorrect "This page has been restored", added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Fri, Feb 14, 9:31 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-editing, Patch-For-Review, TCB-Team
Anomie moved T245310: API calls ignoring cmendsortkeyprefix parameter when continue parameter is present from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Fri, Feb 14, 9:28 PM · Core Platform Team, MediaWiki-API
Anomie moved T245310: API calls ignoring cmendsortkeyprefix parameter when continue parameter is present from Unsorted to Needs Code on the MediaWiki-API board.
Fri, Feb 14, 9:27 PM · Core Platform Team, MediaWiki-API
Anomie added a comment to T224808: Consider limiting SqlBagOStuff makeKey logic.

I'm not sure what the failure mode is right now if e.g. parser cache or CACHE_DB access provides a key that is too long.

Fri, Feb 14, 9:23 PM · Core Platform Team, Technical-Debt, MediaWiki-Cache
Anomie closed T237746: page ID accessed from Lua by calling "mw.title.getCurrentTitle().id" ocassionally returns "0" as Resolved.

The fix should be deployed with 1.35.0-wmf.20. If you empty the category after that version is deployed, and it starts filling up again, feel free to reopen.

Fri, Feb 14, 9:03 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-Scribunto, Commons, SDC General
Anomie moved T245149: API readapidenied with private wiki on v1.34 from Unsorted to Needs Review on the MediaWiki-API board.
Fri, Feb 14, 9:00 PM · Patch-For-Review, Regression, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, MediaWiki-Authentication-and-authorization
Anomie moved T245155: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin) from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 14, 8:59 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Anomie edited projects for T245155: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin), added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Fri, Feb 14, 8:59 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Anomie removed a project from T245155: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin): MediaWiki-API.

Bug is in StatusValue, it's assuming all message parameters are simple scalars and choking on something that's not (e.g. Message::plaintextParam(), Message::numParam(), or something like that).

Fri, Feb 14, 8:55 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
Anomie moved T245149: API readapidenied with private wiki on v1.34 from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 14, 8:42 PM · Patch-For-Review, Regression, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, MediaWiki-Authentication-and-authorization
Anomie edited projects for T245149: API readapidenied with private wiki on v1.34, added: Core Platform Team Workboards (Clinic Duty Team), Regression; removed Core Platform Team.

Thanks for posting the code. I've confirmed the bug; seems to be a regression from T130112.

Fri, Feb 14, 8:03 PM · Patch-For-Review, Regression, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, MediaWiki-Authentication-and-authorization

Wed, Feb 12

Anomie added a comment to T243313: Diffs sometimes fatal due to request timeout via ApiComparePages (revision comparisons).

I don't know much about wikidiff2, but I suspect it's similar to a parse in that there are probably complex cases that will always take a long time. I also don't know whether or not it has sufficient internal "steps" where a time check could be inserted.

Wed, Feb 12, 6:20 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-Diffs, MediaWiki-API, Wikimedia-production-error
Anomie removed a project from T193472: Log suppressed errors with level=DEBUG: Core Platform Team Workboards (Clinic Duty Team).

@Anomie Could you review this one?

Wed, Feb 12, 6:10 PM · MediaWiki-Debug-Logger
Anomie added a comment to T107610: Setup separate logical External Store for Flow in production.

This blocks T106363: Migrate Flow content to new separate logical External Store in production which blocks T106386: Compress data at external storage. If we want to do T106386 then this needs to be done.

Wed, Feb 12, 5:10 PM · Growth-Team, DBA, Operations, WorkType-Maintenance, StructuredDiscussions
Anomie closed T242534: The message apihelp-disabled-extended-description is undefined as Resolved.
Wed, Feb 12, 2:20 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie moved T244877: WanObjectCache::getWithSetCallback seems not to set objects when fetching data is slow from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Feb 12, 2:02 PM · Core Platform Team, MediaWiki-Cache, serviceops, Operations

Tue, Feb 11

Anomie moved T243913: Decrease public variables in Language class from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Feb 11, 5:01 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Internationalization, CPT Initiatives (Decoupling (CDP2)), I18n
Anomie moved T243233: MediaWiki should provide a LocalClusterObjectCache service from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.

(already has reviews, and Jenkins is giving a -1)

Tue, Feb 11, 4:33 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Cache
Anomie closed T241456: Special:History doesn't work as an alias for Special:PageHistory, a subtask of T13456: Add Special-page redirects for page actions for easy wiki linkage (Special:History, Special:Edit, Special:Purge, Special:PageInfo), as Declined.
Tue, Feb 11, 4:30 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-History, User-DannyS712, MediaWiki-Special-pages
Anomie closed T241456: Special:History doesn't work as an alias for Special:PageHistory as Declined.

I agree with @Krinkle, the better way to solve this is T210168. I'm going to go ahead and decline this task.

Tue, Feb 11, 4:30 PM · Core Platform Team Workboards (Clinic Duty Team), User-DannyS712, MediaWiki-Special-pages
Anomie updated subscribers of T239277: Add user right to delete single revision redirects, regardless of target, during page moves.

WDoranWMF moved this task from External Code Review In Progress to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.

Tue, Feb 11, 4:23 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Page-deletion, MediaWiki-User-management, User-DannyS712, MediaWiki-Redirects
Anomie added a watcher for CPT Initiatives (Abstract Schema): Anomie.
Tue, Feb 11, 3:59 PM
Anomie moved T238959: Make TextPassDumperTest work with 0.11 dump schema from Waiting for Review to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Feb 11, 3:57 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (MCR Schema Migration), Dumps-Generation, Structured-Data-Backlog, Multi-Content-Revisions (New Features), Structured Data Engineering, Wikidata
Anomie moved T107174: Add an API action to just change content model from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Feb 11, 3:49 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-ContentHandler, MediaWiki-API
Anomie removed a project from T36257: XSS vulnerability scanner false positives: Core Platform Team.
Tue, Feb 11, 3:02 PM · Security Related, Vuln-XSS, Security, MediaWiki-API
Anomie moved T152972: Accessing private information through SecurePoll should be logged from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Feb 11, 3:02 PM · Core Platform Team, Security Related, Security, Stewards-and-global-tools, MediaWiki-extensions-SecurePoll
Anomie moved T244058: Wiki diffs take over 15s to load from Inbox to Triage Meeting Inbox on the Core Platform Team board.

Sure, they do, but IIRC that limits the number of times we do parse that revision of that article in concurrency. What I am proposing is limiting the number of re-parses any single user is allowed to perform too, in order to rate-limit scrapers that generate expensive operations.

Tue, Feb 11, 3:01 PM · Performance-Team, Core Platform Team Workboards (Clinic Duty Team), serviceops, Operations, Wikimedia-production-error
Anomie moved T218207: Use disk-based LCStore by default in MediaWiki 1.35 from Inbox to Feature Requests to Review on the Core Platform Team board.
Tue, Feb 11, 2:54 PM · Core Platform Team Workboards (Clinic Duty Team), Performance-Team (Radar), MW-1.35-release, Language-Team, MediaWiki-Internationalization
Anomie closed T244786: rev_comment_id, comment_id join clause as Resolved.

Closing as the task is asking "how to fix this query", which was answered by @Reedy in T244786#5866961. Note the same applies to rev_actor, the column is currently in revision_actor_temp as revactor_actor.

Tue, Feb 11, 2:51 PM · Core Platform Team
Anomie moved T244864: web installer / upgrade doesn't seem to recognize extension.json configuration or overrides to that configuration from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Feb 11, 2:45 PM · MediaWiki-Stakeholders-Group, Release-Engineering-Team, MediaWiki-Installer, Core Platform Team
Anomie removed a project from T203133: Introduce a new "strict-boolean" MediaWiki API parameter type for better validation and semantics?: Core Platform Team.
Tue, Feb 11, 2:36 PM · MediaWiki-API

Mon, Feb 10

Anomie added a comment to T241940: No option to continue querying for more results in globalallusers API.

The real problem seems to be that the module thinks that it finished the result set when it actually didn't. Since it thinks it finished, it doesn't generate a continuation.

Mon, Feb 10, 8:47 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-CentralAuth, MediaWiki-API
Anomie closed T244533: Slow query taking up to 60 seconds to run IndexPager::buildQueryInfo (NewFilesPager) as Resolved.
Mon, Feb 10, 5:58 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), mariadb-optimizer-bug, Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-Special-pages, Commons
Anomie added a comment to T240405: WikiPage::updateCategoryCounts causing replication lag due to long-running writes on commonswiki.

I can't help but wonder whether this has something to do with the non-quoted category title issue identified by CDanis in the original post ("This should probably instead be WHERE cat_title = '11'.")

Mon, Feb 10, 4:00 PM · Wikimedia-database-error, Performance Issue, Core Platform Team Workboards (Clinic Duty Team), Release-Engineering-Team, Operations
Anomie closed T239882: TemplateSandbox: clear PreviewLimitReport as Resolved.
Mon, Feb 10, 3:57 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), User-DannyS712, MediaWiki-extensions-TemplateSandbox
Anomie closed T244187: MW OAuth2 doesn't seem to work as Resolved.

Fix should be deployed to Wikimedia sites with 1.35.0-wmf.19

Mon, Feb 10, 3:17 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-extensions-OAuth
Anomie added a comment to T243913: Decrease public variables in Language class.

Hmm. Phab apparently won't allow both Core Platform Team Workboards (Clinic Duty Team) and Core Platform Team Workboards (Contractor Workboard) on the task at the same time...

Mon, Feb 10, 2:59 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Internationalization, CPT Initiatives (Decoupling (CDP2)), I18n
Anomie moved T243913: Decrease public variables in Language class from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Feb 10, 2:58 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Internationalization, CPT Initiatives (Decoupling (CDP2)), I18n
Anomie edited projects for T243913: Decrease public variables in Language class, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team, Core Platform Team Workboards (Contractor Workboard).
Mon, Feb 10, 2:57 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Internationalization, CPT Initiatives (Decoupling (CDP2)), I18n
Anomie moved T244600: Interwiki Titles incorrectly return NS_MAIN from getNamespace() from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Feb 10, 2:54 PM · MediaWiki-General, Core Platform Team
Anomie moved T244613: Deprecate and remove ArticleEditUpdatesDeleteFromRecentchanges hook from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Feb 10, 2:53 PM · MW-1.36-release, Technical-Debt (Deprecation process), MediaWiki-Page-derived-data
Anomie edited projects for T244709: Add more doc annotations to LanguageConverter related classes, added: CPT Initiatives (Decoupling (CDP2)); removed Core Platform Team.
Mon, Feb 10, 2:52 PM · MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), CPT Initiatives (Decoupling (CDP2)), MediaWiki-Language-converter, Core Platform Team Workboards (Contractor Workboard)
Anomie closed T243908: API requests from the domain itself trigger CORS warnings in logs as Resolved.

This fix should be deployed to Wikimedia sites with 1.35.0-wmf.19, see https://www.mediawiki.org/wiki/MediaWiki_1.35/Roadmap for a (probably tentative) schedule.

Mon, Feb 10, 2:49 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie closed T244723: API query export returns two different XML and sha1 for same revision as Invalid.

How can it be that from this MediaWiki 1.31 wiki I get o2jw5c565achwt31azfnu9zc2zxgqpr (31 characters?) and 5702e4d5fd9173246331a889294caf01a3ad3706 for the same revision?

Mon, Feb 10, 2:44 PM · Core Platform Team, MediaWiki-Export-or-Import, MediaWiki-API

Fri, Feb 7

Anomie closed T235350: Consider moving site-wide config data out of the startup module, a subtask of T233676: Audit default page modules payload (2019), as Resolved.
Fri, Feb 7, 8:01 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Performance-Team
Anomie closed T235350: Consider moving site-wide config data out of the startup module as Resolved.
Fri, Feb 7, 8:01 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, Performance-Team
Anomie moved T244533: Slow query taking up to 60 seconds to run IndexPager::buildQueryInfo (NewFilesPager) from Discussing to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.

Heh, turns out we had a very similar issue in T124205.

Fri, Feb 7, 7:18 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), mariadb-optimizer-bug, Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-Special-pages, Commons
Anomie closed T244393: OAuth fails CI due to missing RSA tokens as Resolved.
Fri, Feb 7, 6:48 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (OAuth 2.0), MediaWiki-extensions-OAuth
Anomie closed T244415: Can't use access token generated with owner-only consumer key with OAuth 2.0 as Resolved.

The fix should be deployed to Wikimedia wikis with 1.35.0-wmf.19. Note that the fix applies to OAuth 2 consumer creation; the workaround in T244415#5854244 will need to be used for any consumers created before the fix is deployed.

Fri, Feb 7, 6:48 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-OAuth, CPT Initiatives (OAuth 2.0)
Anomie added a comment to T88914: CSSMin library calls global function wfExpandUrl().

That seems fine, yeah. I'm unsure about making wikimedia/cssmin depend on guzzle, though. That would inconvience re-usability and library maintenance (version matching etc, and extra auditing for re-users who don't need that). Perhaps as compromise we can make use of Guzzle's function in the injected closure?

Fri, Feb 7, 6:34 PM · Core Platform Team Workboards (Clinic Duty Team), patch-welcome, Performance-Team, Librarization, MediaWiki-ResourceLoader
Anomie moved T211450: importDump does not work with actor if the user name is not in canonical form from Waiting for Review to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 7, 5:54 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MW-1.34-notes, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Export-or-Import
Anomie moved T244569: SpecialRecentChanges::doMainQuery needs tunning from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 7, 4:26 PM · Growth-Team, Core Platform Team Workboards (Clinic Duty Team), Scoring-platform-team, Performance Issue, MediaWiki-Special-pages, ORES
Anomie edited projects for T244569: SpecialRecentChanges::doMainQuery needs tunning, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

Why is it deciding it needs to filesort? I see no reason it should need to with that plan, it should already be getting the rows in order.

Fri, Feb 7, 4:26 PM · Growth-Team, Core Platform Team Workboards (Clinic Duty Team), Scoring-platform-team, Performance Issue, MediaWiki-Special-pages, ORES
Anomie added a comment to T244575: Argument 1 passed to LanguageConverterFactory::getLanguageConverter() must be an instance of Language or null, instance of StubUserLang.

You don't specify which version of MediaWiki you were using, but your paths contain "2020-02-05_15:38:56" (no timezone indicated). I'm guessing that that was before rMWed18dba8f403: language: remove Language hints for type check as it breaks using of… was merged at about 2020-02-05 16:40:17 UTC.

Fri, Feb 7, 3:57 PM · Core Platform Team, MediaWiki-extensions-Translate
Anomie merged T244575: Argument 1 passed to LanguageConverterFactory::getLanguageConverter() must be an instance of Language or null, instance of StubUserLang into T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.
Fri, Feb 7, 3:56 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Core Platform Team Workboards (Contractor Workboard), Patch-For-Review, MediaWiki-General, Wikimedia-production-error
Anomie merged task T244575: Argument 1 passed to LanguageConverterFactory::getLanguageConverter() must be an instance of Language or null, instance of StubUserLang into T244300: Argument 1 passed to Title::getLanguageConverter() must be an instance of Language, instance of StubUserLang given, called in /srv/mediawiki/php-1.35.0-wmf.18/includes/Title.php on line 207.
Fri, Feb 7, 3:56 PM · Core Platform Team, MediaWiki-extensions-Translate
Anomie moved T244533: Slow query taking up to 60 seconds to run IndexPager::buildQueryInfo (NewFilesPager) from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Feb 7, 3:02 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), mariadb-optimizer-bug, Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-Special-pages, Commons
Anomie edited projects for T244533: Slow query taking up to 60 seconds to run IndexPager::buildQueryInfo (NewFilesPager), added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

Another bad plan issue. It should do something more like

wikiadmin@10.64.16.102(commonswiki)> explain SELECT /*!STRAIGHT_JOIN*/ /* IndexPager::buildQueryInfo (NewFilesPager) */ img_name, img_timestamp, actor_img_user.actor_user AS `img_user`, actor_img_user.actor_name AS `img_user_text`, img_actor FROM `image` JOIN `actor` `actor_img_user` ON ((actor_img_user.actor_id = img_actor)) LEFT JOIN `user_groups` ON (ug_group = 'bot' AND (ug_user = actor_img_user.actor_user) AND (ug_expiry IS NULL OR ug_expiry >= '20200206194925')) WHERE (ug_group IS NULL) ORDER BY img_timestamp DESC LIMIT 51;
+------+-------------+----------------+--------+----------------------------+---------------+---------+---------------------------------------------+------+-------------------------+
| id   | select_type | table          | type   | possible_keys              | key           | key_len | ref                                         | rows | Extra                   |
+------+-------------+----------------+--------+----------------------------+---------------+---------+---------------------------------------------+------+-------------------------+
|    1 | SIMPLE      | image          | index  | img_actor_timestamp        | img_timestamp | 18      | NULL                                        |   51 |                         |
|    1 | SIMPLE      | actor_img_user | eq_ref | PRIMARY                    | PRIMARY       | 8       | commonswiki.image.img_actor                 |    1 |                         |
|    1 | SIMPLE      | user_groups    | eq_ref | PRIMARY,ug_group,ug_expiry | PRIMARY       | 261     | commonswiki.actor_img_user.actor_user,const |    1 | Using where; Not exists |
+------+-------------+----------------+--------+----------------------------+---------------+---------+---------------------------------------------+------+-------------------------+

The estimate of 51 rows there is off a bit (actual for this query is something like 122 based on SHOW STATUS output), but still 122 is far better than 8 million and completes in 0.00 seconds. @Marostegui, think we should add that STRAIGHT_JOIN?

Fri, Feb 7, 3:02 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), mariadb-optimizer-bug, Core Platform Team Workboards (Clinic Duty Team), Performance Issue, MediaWiki-Special-pages, Commons

Thu, Feb 6

Anomie added a comment to T244440: Action API returns null for unset bool parameter.

How so? ApiBase passes the type unchanged to ParamValidator, which maps boolean to BooleanDef. So I don't think the patch changes anything.

Thu, Feb 6, 10:38 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie moved T235350: Consider moving site-wide config data out of the startup module from Ready to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Feb 6, 8:59 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-ResourceLoader, Performance-Team
Anomie added a comment to T88914: CSSMin library calls global function wfExpandUrl().

Seems fixable by making the class non-static and providing the callback via a constructor option instead. Similar to what we've done with objectcache and rdbms libs. Eg.. BagOStuff and WANObjectCache's asyncHandler option.

Thu, Feb 6, 6:48 PM · Core Platform Team Workboards (Clinic Duty Team), patch-welcome, Performance-Team, Librarization, MediaWiki-ResourceLoader
Anomie closed T244423: jwt.io shows owner-only tokens with an invalid "exp" claim date as Declined.

A client that wants a JWT should use the /oauth2/resource/profile endpoint (or some similar endpoint) rather than trying to interpret the access token. The token is supposed to be opaque.

Thu, Feb 6, 5:58 PM · MediaWiki-extensions-OAuth, CPT Initiatives (OAuth 2.0)
Anomie closed T240686: Allow content blobs to be marked as broken in the content table as Resolved.
Thu, Feb 6, 4:36 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend
Anomie closed T244254: ApiQueryExtLinksUsage::run needs tuning as Resolved.

Patch is merged (should go out next week with wmf.19), and T244254#5851375 seems to indicate the query killer is working. So I'm going to close the task.

Thu, Feb 6, 4:35 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), mariadb-optimizer-bug, MediaWiki-API, Performance Issue
Anomie moved T243920: Add a useskin= cookie for selecting the skin from External Code Review In Progress to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.

Done with CPT review. I'd want Operations and/or Performance-Team to weigh in on whether this would be bad for caching, so I'll leave it to others to do the final review.

Thu, Feb 6, 4:34 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review
Anomie closed T244423: jwt.io shows owner-only tokens with an invalid "exp" claim date as Declined.

Declining this for several reasons:

Thu, Feb 6, 4:30 PM · MediaWiki-extensions-OAuth, CPT Initiatives (OAuth 2.0)
Anomie closed T244440: Action API returns null for unset bool parameter, a subtask of T233867: 1.35.0-wmf.19 deployment blockers, as Resolved.
Thu, Feb 6, 3:37 PM · Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments
Anomie closed T244440: Action API returns null for unset bool parameter as Resolved.
Thu, Feb 6, 3:37 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie updated subscribers of T244408: Consolidate source code licenses to single line per file.

I like the idea, as well as the similar idea of shortening the header to one line something like

/* SPDX-License-Identifier: GPL-2.0-or-later */

or

/** @license GNU General Public License version 2 or later; see LICENSE

or whatever.

Thu, Feb 6, 3:22 PM · User-RhinosF1, Software-Licensing, WMF-Legal, Technical-Debt, Desktop Improvements
Anomie moved T243920: Add a useskin= cookie for selecting the skin from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Feb 6, 2:56 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review
Anomie moved T243920: Add a useskin= cookie for selecting the skin from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Feb 6, 2:48 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review
Anomie edited projects for T243920: Add a useskin= cookie for selecting the skin, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Feb 6, 2:47 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review
Anomie moved T244440: Action API returns null for unset bool parameter from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Feb 6, 2:44 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie edited projects for T244440: Action API returns null for unset bool parameter, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

Meh. For good measure I checked Wikimedia-deployed extensions and didn't see anything that would be affected by this. But it seems easy enough to fix.

Thu, Feb 6, 2:44 PM · MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API