Anomie (Brad Jorsch)
User

Projects (12)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (207 w, 20 h)
Availability
Available
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Today

Anomie updated subscribers of T203925: Save times for changes to translation variable text in centralnotice paralysingly slow.

I had a glance at this this evening. My main observation is that 30305 of the 30974 pages that are being loaded here seem to belong to CentralNotice (they begin with "Centralnotice-").

Wed, Sep 26, 1:47 AM · Core Platform Team, Performance-Team, Fundraising Sprint Sasquatches can't find us either, Patch-For-Review, Language-Team, Fundraising Sprint Raw data can give you salmonella, MediaWiki-extensions-Translate, Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Yesterday

Anomie added a comment to T194585: Expose whether a user is blocked from editing a specific page via the API.

I'm not sure "you're blocked!" is all that useful of a "why". Perhaps the better solution would be to have intestactions (optionally?) return the message data from Title::getUserPermissionsErrors().

Tue, Sep 25, 5:47 PM · Patch-For-Review, Anti-Harassment (AHT Sprint 29), MediaWiki-User-management, MediaWiki-API
Anomie added a comment to T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".

The error is no longer being generated in WMF production, but the patch to fix it when we try to redeploy it isn't merged yet.

Tue, Sep 25, 4:34 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Anomie created T205453: Capture failure logs from php-compile jobs (at least for luasandbox).
Tue, Sep 25, 4:07 PM · Continuous-Integration-Config
Anomie removed a subtask for T198308: Enable MCR migration stage "write both, read new" on live systems: T205432: Database errors related to actor table on testwiki.
Tue, Sep 25, 2:17 PM · MW-1.32-release, Multi-Content-Revisions (MCR Deployment), Wikidata, Structured-Data-Commons
Anomie removed a parent task for T205432: Database errors related to actor table on testwiki: T198308: Enable MCR migration stage "write both, read new" on live systems.
Tue, Sep 25, 2:17 PM · Core Platform Team
Anomie removed a project from T205432: Database errors related to actor table on testwiki: Multi-Content-Revisions.
Tue, Sep 25, 2:16 PM · Core Platform Team
Anomie moved T205357: SpecialApiSandbox needs PHPUnit integration tests from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Tue, Sep 25, 2:12 PM · Google-Code-in-2018, Test-Coverage, MediaWiki-API, MediaWiki-Special-pages
Anomie added a comment to T205339: Evaluate ease / difficulty of implementing Parsoid's API / URL routing in MediaWiki core.

I'm really excited to see there's a Parsoid-PHP board!

Tue, Sep 25, 2:09 PM · Parsoid-PHP
Anomie added a comment to T205432: Database errors related to actor table on testwiki.

This is a duplicate of T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)" and T204764: DB error in PageTriage: Unknown column 'actor_rev_user.actor_user' in 'on clause'. See those tasks for details.

Tue, Sep 25, 1:48 PM · Core Platform Team
Anomie merged T205432: Database errors related to actor table on testwiki into T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".
Tue, Sep 25, 1:48 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Anomie merged task T205432: Database errors related to actor table on testwiki into T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".
Tue, Sep 25, 1:48 PM · Core Platform Team

Mon, Sep 24

Anomie closed T205101: McrUndoAction preview doesn't work as Resolved.
Mon, Sep 24, 5:46 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018), Multi-Content-Revisions
Anomie added a comment to T205188: Specifying titles in ApiSandbox does not work.

It does. TagMultiSelectWidget doesn't generate a menu when there aren't predefined values.

Mon, Sep 24, 3:16 PM · MediaWiki-API
Anomie edited projects for T204475: update.php ends without messages after MCR migration when using WinCache, added: MediaWiki-Cache; removed AbuseFilter, MediaWiki-Installer, Multi-Content-Revisions.
Mon, Sep 24, 2:58 PM · MediaWiki-Cache
Anomie added a comment to T205197: Support insertion of Scribunto Lua modules using Visual Editor.

searching the main space of the English Wikipedia for insource:#invoke finds quite a lot of direct module invocations.

Mon, Sep 24, 2:48 PM · VisualEditor, MediaWiki-extensions-Scribunto, TemplateData
Anomie moved T205167: Review and improve: https://www.mediawiki.org/wiki/API:FAQ from Unsorted to Non-Code on the MediaWiki-API board.
Mon, Sep 24, 2:04 PM · Goal, Documentation, Developer-Advocacy (Jul-Sep 2018), MediaWiki-API
Anomie merged T205188: Specifying titles in ApiSandbox does not work into T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.
Mon, Sep 24, 2:02 PM · Patch-For-Review, Regression, OOUI
Anomie merged task T205188: Specifying titles in ApiSandbox does not work into T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused.
Mon, Sep 24, 2:02 PM · MediaWiki-API
Anomie moved T205199: Microtask: Pick a MediaWiki Action API page to review and improve. from Unsorted to Non-Code on the MediaWiki-API board.
Mon, Sep 24, 2:01 PM · MediaWiki-Documentation, MediaWiki-API, Outreach-Programs-Projects, Outreachy (Round 17)

Fri, Sep 21

Anomie moved T205156: Provide qpnamespace parameter for UnconnectedPages querypage in the api from Unsorted to Blocked on the MediaWiki-API board.

The QueryPage class does not provide a "namespace" parameter or filter. Such a thing would need to be added before ApiQueryQueryPage could sensibly have such a parameter.

Fri, Sep 21, 8:41 PM · MediaWiki-API, Wikidata
Anomie added a comment to T204475: update.php ends without messages after MCR migration when using WinCache.

If the one on line 84 isn't printed, try adding one between lines 81-82.

Fri, Sep 21, 6:44 PM · MediaWiki-Cache
Anomie added a comment to T204475: update.php ends without messages after MCR migration when using WinCache.

String inserted in line 74 was printed, but string inserted in line 86 wasn't.

Fri, Sep 21, 6:41 PM · MediaWiki-Cache
Anomie added a comment to T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".

Making the joins explicit should work fine. There's no reason that couldn't be a join condition (although it is kind of ugly and may be not performant, cf. T204669).

Fri, Sep 21, 6:29 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Anomie added a comment to T204888: Improve and update: https://www.mediawiki.org/wiki/API:Data_formats.

As I've said elsewhere, I like to think of the auto-generated documentation as the reference card and the on-wiki documentation as the user guide. If there's no need for user guide content for something, then there may not need to be an on-wiki page at all (or just a stub).

Fri, Sep 21, 5:44 PM · Goal, Documentation, Developer-Advocacy (Jul-Sep 2018), MediaWiki-API
Anomie moved T205101: McrUndoAction preview doesn't work from Backlog to In Progress on the Multi-Content-Revisions board.
Fri, Sep 21, 2:50 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018), Multi-Content-Revisions
Anomie moved T205101: McrUndoAction preview doesn't work from Backlog to Waiting for Review on the Core Platform Team (CPT-Q1-Jul-Sep-2018) board.
Fri, Sep 21, 2:50 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018), Multi-Content-Revisions
Anomie created T205101: McrUndoAction preview doesn't work.
Fri, Sep 21, 2:47 PM · MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018), Multi-Content-Revisions

Thu, Sep 20

Anomie moved T204983: maintenance/generateLocalAutoload.php ignores aliases for PSR4 from Backlog to Waiting for Review on the Core Platform Team (CPT-Q1-Jul-Sep-2018) board.
Thu, Sep 20, 5:49 PM · Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018)
Anomie created T204983: maintenance/generateLocalAutoload.php ignores aliases for PSR4.
Thu, Sep 20, 5:43 PM · Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018)
Anomie added a comment to T149077: Certain ApiQueryRecentChanges::run api query is too slow, slowing down dewiki.

Perhaps. If so, this task seems the more useful of the two. The discussion on T101502 seems focused around the index forcing which was removed with rMW2f1cfcf306bb: API: Remove index forcing in ApiQueryRecentChanges.

Thu, Sep 20, 4:13 PM · Wikimedia-production-error, Patch-For-Review, MediaWiki-API, DBA
Anomie closed T198309: Enable MCR migration stage "write both, read new" on testwiki as Resolved.
Thu, Sep 20, 4:02 PM · Patch-For-Review, Multi-Content-Revisions (MCR Deployment), Wikidata, Structured-Data-Commons
Anomie closed T198309: Enable MCR migration stage "write both, read new" on testwiki, a subtask of T198308: Enable MCR migration stage "write both, read new" on live systems, as Resolved.
Thu, Sep 20, 4:02 PM · MW-1.32-release, Multi-Content-Revisions (MCR Deployment), Wikidata, Structured-Data-Commons
Anomie added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

But on the other hand, we've mooted the idea of using the opt-in syntax to also opt-in to "better" template expansion semantics (where different people have different definitions of "better"). I'm not opposed to that in principle. We should use the opportunity we have to allow people to opt-in.

Thu, Sep 20, 4:00 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
Anomie added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

My thought is that "interpret argument as literal text" or "interpret argument as wikitext" is a decision to be made by the template author.

Thu, Sep 20, 3:36 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
Anomie added a comment to T204475: update.php ends without messages after MCR migration when using WinCache.

This has nothing to do with AbuseFilter, I'm afraid.

Thu, Sep 20, 2:50 PM · MediaWiki-Cache
Anomie moved T204926: ApiQueryRevisions::run has bad performance across API hosts from Unsorted to Needs Code on the MediaWiki-API board.

This seems like it may be related to T121333, T197486, and/or T88084.

Thu, Sep 20, 2:22 PM · MediaWiki-API, User-Banyek, MediaWiki-Database
Anomie added a project to T204926: ApiQueryRevisions::run has bad performance across API hosts: MediaWiki-API.
Thu, Sep 20, 2:03 PM · MediaWiki-API, User-Banyek, MediaWiki-Database
Anomie moved T204855: Review and update API client library lists on: https://www.mediawiki.org/wiki/API:Client_code from Unsorted to Non-Code on the MediaWiki-API board.

and/or point readers to a recommended library

Thu, Sep 20, 2:01 PM · Goal, Documentation, Developer-Advocacy (Jul-Sep 2018), MediaWiki-API
Anomie moved T204888: Improve and update: https://www.mediawiki.org/wiki/API:Data_formats from Unsorted to Non-Code on the MediaWiki-API board.

Make this page more of a reference doc than a user guide. The information here should be quickly and easily accessible to readers. Much of the contextual information is unnecessary for application developers who visit the page for simple information.

Thu, Sep 20, 1:56 PM · Goal, Documentation, Developer-Advocacy (Jul-Sep 2018), MediaWiki-API
Anomie added a comment to T204863: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.32 release.

WikiPage – Calling ::prepareContentForEdit with a revisionid rather than a Revision object

Thu, Sep 20, 1:50 PM · Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Technical-Debt, MediaWiki-General-or-Unknown, MW-1.32-release

Wed, Sep 19

Anomie added a comment to T194501: Top-level pages in the template namespace are not recognized as TemplateStyles stylesheets.

I guess it was a design to add a condition "subpage of Template" to mandate styles to be related to one (and only one) template, and possibly avoid generic styles like Template:Foo.css.

Wed, Sep 19, 6:59 PM · Patch-For-Review, TemplateStyles
Anomie added a comment to T204797: [Regression 1.32.0-wmf.22] ParserOutput::getLanguageLinks returns invalid values (Undefined index from ApiParse and LinksUpdate).

LanguageLinks hook doesn't provide any mechanism for accessing contextual information.

Wed, Sep 19, 2:51 PM · Language-Team, User-Nikerabbit, MediaWiki-extensions-Translate, Wikimedia-production-error
Anomie created T204824: There should be a CI check for files differing only by case.
Wed, Sep 19, 2:01 PM · Continuous-Integration-Config
Anomie moved T204773: Review and improve: https://www.mediawiki.org/wiki/API:FAQ from Unsorted to Non-Code on the MediaWiki-API board.
Wed, Sep 19, 1:50 PM · Goal, Documentation, Developer-Advocacy (Jul-Sep 2018), MediaWiki-API
Anomie edited projects for T204797: [Regression 1.32.0-wmf.22] ParserOutput::getLanguageLinks returns invalid values (Undefined index from ApiParse and LinksUpdate), added: MediaWiki-extensions-Translate; removed Core Platform Team, MediaWiki-General-or-Unknown.

It turns out the bad value is "x-pagetranslation-tag", added by the Translate extension since rETRAd3935a65cfca: Allow displaying page translation language list in the sidebar.

Wed, Sep 19, 1:47 PM · Language-Team, User-Nikerabbit, MediaWiki-extensions-Translate, Wikimedia-production-error
Anomie added a comment to T204756: DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php.

I'm not sure this actually comes from DerivedPageDataUpdater. The line indicated is trying to explode "iw:Target"-format language links, so the fault may lie in whatever called $parserOutput->addLanguageLink() with something not following the format.

Wed, Sep 19, 1:23 AM · Core Platform Team, MediaWiki-General-or-Unknown, Wikimedia-production-error

Tue, Sep 18

Anomie added a comment to T204767: Special:ActiveUsers fails with "Error: 1054 Unknown column 'rc_actor' in 'on clause' (10.192.32.110)".

Making the joins explicit should work fine. There's no reason that couldn't be a join condition (although it is kind of ugly and may be not performant, cf. T204669).

Tue, Sep 18, 8:58 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Anomie added a comment to T204475: update.php ends without messages after MCR migration when using WinCache.

Sounds like a fatal error in populateContentTables.php leaves the DB in an inconsistent state.

Tue, Sep 18, 6:59 PM · MediaWiki-Cache
Anomie moved T204610: Expose gender of gendered namespace aliases in siteinfo API from Unsorted to Needs details or plan on the MediaWiki-API board.

As stated, this request has two issues.

Tue, Sep 18, 3:26 PM · MediaWiki-API
Anomie added a project to T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode): Core Platform Team.

I may decide to instead revert the config change and rewrite the migration process to use "write-both-read-old"→"write-both-read-new" instead of "write-both-read-both"→"write-new-read-both"; particularly when the revision table and special pages are involved, "read both" quickly gets complicated.

Tue, Sep 18, 2:08 PM · Core Platform Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, Regression, MediaWiki-Special-pages, Performance
Anomie claimed T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode).

The specific query in T204669#4593536 is due to the enabling of actor table WRITE_BOTH mode on mediawiki.org (07a6db7), so we can hopefully find slow queries like this and fix them before they go out to big content wikis and cause more trouble. Currently that config change is also enabled on testwiki, test2wiki, and testwikidatawiki.

Tue, Sep 18, 1:25 PM · Core Platform Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, Regression, MediaWiki-Special-pages, Performance
Anomie moved T204612: MediaWiki Action API: Documentation improvements to the top 50 most viewed API pages on-wiki from Unsorted to Non-Code on the MediaWiki-API board.
Tue, Sep 18, 12:59 PM · MediaWiki-Documentation, MediaWiki-API, Outreach-Programs-Projects, Outreachy (Round 17)

Mon, Sep 17

Anomie added a comment to T204370: Behavior switch/magic word uniformity.

It doesn't seem that way to me. It seems like you're adding a pre-preprocessor that transforms the wikitext into some simplified pseudo-wikitext so you can have the preprocessor handle pseudo-wikitext instead. I don't see what that really gains us besides your hope that the "some simplified pseudo-wikitext" could be used by your T204375 scheme, at the cost of another pass and whatever extra time that might take.

Mon, Sep 17, 5:51 PM · MediaWiki-Parser, Parsoid
Anomie removed a project from T166733: Deploy refactored comment storage: Patch-For-Review.
Mon, Sep 17, 4:35 PM · Core Platform Team (CPT-Q1-Jul-Sep-2018), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie removed a project from T188327: Deploy refactored actor storage: Patch-For-Review.
Mon, Sep 17, 4:21 PM · Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018), Epic
Anomie updated the task description for T166733: Deploy refactored comment storage.
Mon, Sep 17, 3:04 PM · Core Platform Team (CPT-Q1-Jul-Sep-2018), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie updated the task description for T188327: Deploy refactored actor storage.
Mon, Sep 17, 3:03 PM · Patch-For-Review, Core Platform Team (CPT-Q1-Jul-Sep-2018), Epic
Anomie added a comment to T204370: Behavior switch/magic word uniformity.

The preprocessor (at least the PHP one) already dispatches template transclusions.

Mon, Sep 17, 2:44 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204375: Wikitext 2.0 as low-bandwidth transport for client-side rendering.

Note there will still need to be a way for clients without JavaScript enabled to view things.

Mon, Sep 17, 2:42 PM · Parsoid
Anomie added a comment to T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.

\o/

Mon, Sep 17, 1:28 PM · Core Platform Team, Patch-For-Review, Schema-change, DBA

Fri, Sep 14

Anomie added a comment to T204370: Behavior switch/magic word uniformity.

I think we'd also entertained thoughts of removing these behavior switches entirely and just setting the page props directly, maybe using MCR, the way we yanked interlanguage links out of the wikitext.

Fri, Sep 14, 6:56 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

While thinking through the details of argument expansion, it's probably important to figure out how to pass heredoc-quoted arguments through to child templates safely. That is, if Template:Foo is:

{{SomeOtherTemplate|{{{1}}}}}

and I invoke it like:

{{Foo|<<<bar=bat>>>}}

I probably want to select two different behaviors: (a) deliberately unquoted, so SomeOtherTemplate is given the named argument bar, and (b) deliberately quoted, so SomeOtherTemplate is given a single unnamed argument with the literal value bar=bat.

Fri, Sep 14, 6:37 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
Anomie added a comment to T204370: Behavior switch/magic word uniformity.

At least in the PHP parser, all the constructs delimited with {{ }}, {{{ }}}, [[ ]], and -{ }- share the same parsing code, so not extending the new quoting to them all might actually take more work than doing so (if only management of a flag to indicate when it should/shouldn't). The only edge case there is the handling of that first "argument" after the colon.

Fri, Sep 14, 6:28 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204371: Replace initial colon in (hash-prefixed) parser function invocation with vertical bar.

You might also have to be careful that you don't turn {{Project:Example}} from a transclusion of Project:Example into a transclusion of Template:Project passing "Example" as parameter 1.

Fri, Sep 14, 6:18 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204370: Behavior switch/magic word uniformity.

Rather than changing wikitext syntax for cases like {{DISPLAYTITLE:title}} => {{#displaytitle|title}} where the only real difference is the colon separating the name from the first argument, you might find it an easier sell to simply extend that construct with your reliable quoting for arguments too.

Fri, Sep 14, 6:16 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204370: Behavior switch/magic word uniformity.

Note that double-underscore magic words are automatically added as page properties (in the page_props table). You should be sure not to lose that behavior if someone uses your alternative syntax. Considering that they can't structurally have arguments, the justification for changing them given here ("with reliable quoting for arguments, instead of having a weird collection of ad hoc mechanisms for allowing arguments") doesn't seem to apply.

Fri, Sep 14, 6:06 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204371: Replace initial colon in (hash-prefixed) parser function invocation with vertical bar.

For hash-prefixed parser functions this should be fine. For those that can be used without the prefix though, doing this would hide a template with the same name.

Fri, Sep 14, 5:57 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204283: Serializing extension tags using TemplateData.

I'm trying to *avoid* adding heredocs to square bracket syntax, but I don't plan on deprecating square bracket syntax. I'd like to think of it as just sugar for the "long" {{#media|...}} form. Use it for conciseness in the common case and whereever possible, but as soon as you start to want to do "complicated" things in the caption or attributes, it's time to switch to the reliable quoting mechanism of {{#media....}}. I feel like I'm most likely to try to sneak in a better style mechanism at the same time I define #media, so further discussion of that will probably occur in T90914.

Fri, Sep 14, 4:37 PM · VisualEditor, TemplateData, Parsoid
Anomie added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

@Anomie is the expansion memoized? Presumably if I include {{1}} twice in guaranteed the same contents? (I should check this myself but I'm on mobile at the moment.)

Fri, Sep 14, 4:07 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
Anomie added a comment to T204283: Serializing extension tags using TemplateData.

This would also guide/simplify serialization. For simple values of attributes (no newlines, no quotes), we'd use the <ext attr="..."> syntax for the extension, but as soon as the attribute value got "complicated" we could switch to the {{#tag:ext|attr=<<<...>>>}} syntax.

Fri, Sep 14, 4:04 PM · VisualEditor, TemplateData, Parsoid
Anomie added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

Current template semantics expand the arguments before evaluating the template.

Fri, Sep 14, 3:59 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
Anomie added a comment to T204307: Parser Functions should support named parameters.

I note that the code at that link seems a bit outdated. A parser function that wants named arguments today should probably use SFH_OBJECT_ARGS and use PPNode->splitArg(), more or less like PPFrame_Hash::newChild() does or like Parser::braceSubstitution() does for special page transclusion.

Fri, Sep 14, 3:58 PM · MediaWiki-Parser, Parsoid
Anomie added a comment to T204283: Serializing extension tags using TemplateData.

we might eventually see:

{{#tag:gallery
|<<<File:Detroit Publishing Co. - A Yeoman of the Guard (N.B. actually a Yeoman Warder), full restoration.jpg|1>>>
|<<<File:Official_program_-_Woman_suffrage_procession_March_3,_1913_-_crop.jpg|2>>>
|<<<File:Thurston, the famous magician - East Indian Rope Trick.jpg|3>>>
|<<<File:Joseph Ferdinand Keppler - The Pirate Publisher - Puck Magazine - Restoration by Adam Cuerden.jpg|4>>>
}}
Fri, Sep 14, 3:35 PM · VisualEditor, TemplateData, Parsoid
Anomie added a comment to T204346: PHP-timed out requests also emit LoadBalancer::destruct error "you can't run this command now: COMMIT".

It looks like we have a backtrace for the same error in the "error" channel (link):

PHP Warning: Destructor threw an object exception: exception 'Wikimedia\Rdbms\DBQueryError' with message 'A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
Query: COMMIT
Function: Wikimedia\Rdbms\Database::close
Error: 2014 Commands out of sync; you can't run this command now (10.192.32.168)
' in /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php:1458
Stack trace:
#0 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(1428): Wikimedia\Rdbms\Database->makeQueryException()
#1 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(1198): Wikimedia\Rdbms\Database->reportQueryError()
#2 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(3893): Wikimedia\Rdbms\Database->query()
#3 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(3864): Wikimedia\Rdbms\Database->doCommit()
#4 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/database/Database.php(952): Wikimedia\Rdbms\Database->commit()
#5 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1263): Wikimedia\Rdbms\Database->close()
#6 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1762): Closure$Wikimedia\Rdbms\LoadBalancer::closeAll()
#7 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1264): Wikimedia\Rdbms\LoadBalancer->forEachOpenConnection()
#8 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1254): Wikimedia\Rdbms\LoadBalancer->closeAll()
#9 /srv/mediawiki/php-1.32.0-wmf.20/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1980): Wikimedia\Rdbms\LoadBalancer->disable()
#10 (): Wikimedia\Rdbms\LoadBalancer->__destruct()
#11 {main}
Fri, Sep 14, 2:07 PM · Performance-Team, Wikimedia-production-error, MediaWiki-Database

Thu, Sep 13

Anomie added a comment to T181650: Change views for the new columns of the refactored comment storage.

We're currently at "write both". Testing wikis and mediawiki.org may be changed to "write new" soon, but other wikis will wait until after the datacenter switch-back.

Thu, Sep 13, 4:39 PM · cloud-services-team (Kanban), Data-Services
Anomie updated subscribers of T189982: Move all apihelp translatable messages to separate files.

We'd like to make sure that for MediaWiki extensions, messages in i18n/api/ only begin with apihelp-, and then probably the inverse of no messages starting with that prefix in the other i18n directories.

Thu, Sep 13, 2:15 PM · MW-1.32-release-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), MediaWiki-General-or-Unknown, Patch-For-Review, translatewiki.net, goodfirstbug, I18n
Anomie added a comment to T204145: PHP Warning: session_id(): Cannot change session id when headers already sent.

Is your extra debug info printing to the console before Setup.php calls MediaWiki\Session\PHPSessionHandler::install() (line 884)?

Thu, Sep 13, 2:07 PM · PHP 7.2 support, MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth
Anomie added a comment to T204145: PHP Warning: session_id(): Cannot change session id when headers already sent.
Thu, Sep 13, 2:05 PM · PHP 7.2 support, MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth
Anomie added a comment to T204145: PHP Warning: session_id(): Cannot change session id when headers already sent.

The line numbers you report for SessionBackend.php do not match up with MediaWiki 1.31.

Thu, Sep 13, 1:46 PM · PHP 7.2 support, MediaWiki-Authentication-and-authorization, MediaWiki-extensions-CentralAuth

Wed, Sep 12

Anomie added a comment to T204158: Review namespacing of MCR classes.

I might rearrange these as follows (🔮 indicates classes that aren't created yet):

Wed, Sep 12, 8:31 PM · Patch-For-Review, Core Platform Team, Multi-Content-Revisions
Anomie created T204158: Review namespacing of MCR classes.
Wed, Sep 12, 8:26 PM · Patch-For-Review, Core Platform Team, Multi-Content-Revisions
Anomie added a comment to T99268: RfC: Create a proper command-line runner for MediaWiki maintenance tasks.

I noted this on the RFC talk page, but let me also put it here: Why limit to maintenance tasks ?
Why not a general architecture to run (command line) tools, of which the maintenance tool is just a more specific set/scope (maybe it's own registry ?)

Wed, Sep 12, 4:23 PM · Core Platform Team, MediaWiki-Maintenance-scripts, TechCom-RFC
Anomie moved T204099: Templatestyles can't work in app? from Up next to External on the TemplateStyles board.
Wed, Sep 12, 1:34 PM · Chinese-Sites, Android-app-Bugs, TemplateStyles, Wikipedia-Android-App-Backlog
Anomie added a comment to T204112: Support slots other than the main slot in EditPage.

Why is this separate from T174033: Refactor EditPage to allow multiple slots to be edited atomically [MCR]?

Wed, Sep 12, 1:31 PM · Patch-For-Review, Core Platform Team, Multi-Content-Revisions

Tue, Sep 11

Anomie added a comment to T203312: Add sniff that preg_quote should not be used with 1 argument.

Note that preg_quote quotes ! by default, which might explain its use as a delimiter. Also, just because a regex happens to include preg_quote doesn't mean that leaning toothpick syndrome won't apply to other parts of the regex.

Tue, Sep 11, 6:25 PM · MediaWiki-Codesniffer
Anomie added a comment to T174036: Diffs page should show diffs and content from multiple slots [MCR].

I don't think "make MCR feature-complete" can happen in time for 1.32, since that would require thing like T174033: Refactor EditPage to allow multiple slots to be edited atomically [MCR] as well.

Tue, Sep 11, 2:32 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), MW-1.32-release, Epic, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

and the whole point of this syntax is that you should be able to surround literally anything with no additional escaping needed

Doesn't that statement conflict with allowing expansion of templates inside a quoted-argument?

This is interesting. Presumably @Anomie is concerned with:

{{foo|<<< {{bar}} >>>}}

where {{bar}} could itself expand to >>>.

Tue, Sep 11, 1:58 PM · Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016, TechCom-RFC
Anomie added a comment to T203312: Add sniff that preg_quote should not be used with 1 argument.

/…/ is the standard, and used in the majority of cases – unless there is a good reason to free the slash from being a special character. A typical example is something like /^http:\/\/\w+\/\w+\//, which is painful and often written as !^http://\w+/\w+/! instead.

Tue, Sep 11, 1:44 PM · MediaWiki-Codesniffer
Anomie added a comment to T90528: Generated API Help doesn't indicate the MediaWiki versions that support a module and parameters..

Taking the example of maybe the automated documentation available for a popular module via Special:ApiHelp:

  • Default value and their type are not available for some parameters
Tue, Sep 11, 12:42 PM · Documentation, MediaWiki-API
Anomie added a comment to T204016: ArticleCreationWorkflow does not actually enforce enwp's autoconfirmed requirement for page creation in the permission system.

Anyway, personally I think the various user rights exceptions with hooks are really confusing and getting out of hand. I think we should do things around "rights" and assign things to groups, for clarity's sake.

Tue, Sep 11, 12:07 PM · Patch-For-Review, Security, Community-Tech-Sprint, Community-Tech, MediaWiki-extensions-ArticleCreationWorkflow

Mon, Sep 10

Anomie committed R1985:abdd0f70b059: Fix TS_POSTGRES to match PostgreSQL's actual output (authored by Anomie).
Fix TS_POSTGRES to match PostgreSQL's actual output
Mon, Sep 10, 7:04 PM
Anomie added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

OTOH, having a 'skin' attribute would mean we'd have to fragment the parser cache by skin, which would be a different kind of overhead.

Mon, Sep 10, 4:21 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), Patch-For-Review, TemplateStyles
Anomie closed T203967: TemplateStyles should allow for "mobile-only" styles as Declined.

To add to what @Krinkle said, I suppose a third case would be if you're trying to restyle some content hack that MobileFrontend applies.

Mon, Sep 10, 4:16 PM · Chinese-Sites, TemplateStyles
Anomie closed T203967: TemplateStyles should allow for "mobile-only" styles, a subtask of T138622: Help community migrate away from legacy Main page special casing, as Declined.
Mon, Sep 10, 4:16 PM · CommRel-Specialists-Support, Readers-Web-Backlog (Tracking), Readers-Community-Engagement, Reading-Web-Local-Wiki-Issues
Anomie added a comment to T189227: taint-checks for CentralAuth failing.

Well, I would argue that's bad practise (escaping should happen when the data is used, in the example, it should happen in javascript).

Mon, Sep 10, 4:07 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, phan-taint-check-plugin, MediaWiki-extensions-CentralAuth, Vuln-XSS, Security-Extensions, Security
Anomie added a comment to T189227: taint-checks for CentralAuth failing.

\Xml::encodeJsCall() is hardcoded as the second argument being self::ESCAPES_HTML...and while that's true, it's also irrelevant to whether it is being double escaped or not. Should I suppress it? (if so, it should be refactored into a smaller function so we don't have to suppress the entire execute()).

Mon, Sep 10, 3:21 PM · MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Patch-For-Review, phan-taint-check-plugin, MediaWiki-extensions-CentralAuth, Vuln-XSS, Security-Extensions, Security
Anomie closed T203785: Wikipedia API returning an empty string for text extract on some articles as Resolved.

This should be fixed now with the backport of rMW392446738756: Unwrap HTML loaded from parser cache.

Mon, Sep 10, 2:32 PM · Readers-Web-Backlog (Tracking), TextExtracts, MediaWiki-API
Anomie reassigned T203716: Duplicate mw-parser-output elements in action=parse API output from Anomie to Tgr.
Mon, Sep 10, 2:32 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Multi-Content-Revisions, Patch-For-Review, MediaWiki-Parser, MediaWiki-API
Anomie closed T203716: Duplicate mw-parser-output elements in action=parse API output as Resolved.

Fixed and backported.

Mon, Sep 10, 2:29 PM · MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Multi-Content-Revisions, Patch-For-Review, MediaWiki-Parser, MediaWiki-API