Page MenuHomePhabricator

Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (21)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (258 w, 5 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Fri, Sep 20

Anomie moved T223151: Review special replica partitioning of certain tables by `xx_user` from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Sep 20, 7:42 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance, Core Platform Team Legacy (Watching / External), DBA
Anomie added a project to T223151: Review special replica partitioning of certain tables by `xx_user`: Core Platform Team Workboards (Clinic Duty Team).
Fri, Sep 20, 7:41 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance, Core Platform Team Legacy (Watching / External), DBA
Anomie added a comment to T232485: RFC: Core REST API namespace and version.
  1. By convention we're asking extensions to use a namespace, but we don't have a technical way right now to prevent them from adding endpoints in the "main" namespace.
Fri, Sep 20, 7:09 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Anomie moved T233449: CommentStore should accept valid combinations of SCHEMA_COMPAT_* constants from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Sep 20, 6:51 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Comment-backend
Anomie created T233449: CommentStore should accept valid combinations of SCHEMA_COMPAT_* constants.
Fri, Sep 20, 6:49 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Comment-backend
Anomie added a comment to T223151: Review special replica partitioning of certain tables by `xx_user`.

All that reminds me of T71222#4994266. We might have to add index ignoring to LogPager like we did for ApiQueryLogEvents in rMWe6021abc9c16: ApiQueryLogEvents: Add IGNORE INDEX to avoid MariaDB optimizer bug.

Fri, Sep 20, 4:01 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance, Core Platform Team Legacy (Watching / External), DBA
Anomie closed T44886: No option to move over an existing non-redirect page in the API as Declined.

Since the behavior used as justification for reopening this has been deemed a bug, I'm going to re-decline this task.

Fri, Sep 20, 3:54 PM · Wikidata, Core Platform Team, MediaWiki-API
Anomie moved T75370: deletedrevs deprecated from External Review In Progress to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Sep 20, 3:45 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Pywikibot
Anomie closed T211175: api list=deletedrevs errors when drlimit given a float value as Resolved.

Fixed by the same patch that fixed T231582: ApiQueryRevisions.php: PHP Notice: A non well formed numeric value encountered.

Fri, Sep 20, 3:42 PM · MediaWiki-API
Anomie updated the task description for T161671: Compacting the revision table.
Fri, Sep 20, 2:04 PM · CPT Initiatives (Revision Storage Schema Improvements), MediaWiki-Revision-backend, Multi-Content-Revisions, Epic, Patch-For-Review, Schema-change

Thu, Sep 19

Anomie moved T233342: Standardise on Logstash field for exceptions with back traces from Inbox to Triage Meeting Inbox on the Core Platform Team board.
  1. For various other ad-hoc logging we seem to use [ 'trace' => … ] mostly.
Thu, Sep 19, 8:23 PM · Performance-Team, Core Platform Team, MediaWiki-Debug-Logger
Anomie added a comment to T222099: Staging release of RESTBagOStuff using Kask.

Kask doesn't do any serialization; The data is opaque, just bytes in and bytes out.

Thu, Sep 19, 7:41 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
Anomie moved T220834: Log entry unreachable via logid= if its type is among $wgFilterLogTypes from External Review In Progress to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 6:44 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Logging
Anomie moved T193068: Add support for SQLite and postgre when searching patterns from External Code Review Needed to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 6:26 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, AbuseFilter, PostgreSQL, SQLite
Anomie moved T231266: ApiQueryCheckUser should use a sensible default limit from External Code Review Needed to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 6:17 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, CheckUser
Anomie moved T220791: afl_filter should be split in afl_filter_id and afl_global from External Code Review Needed to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 5:25 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Anomie moved T220834: Log entry unreachable via logid= if its type is among $wgFilterLogTypes from External Code Review Needed to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 5:24 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Logging
Anomie moved T75370: deletedrevs deprecated from Inbox to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 4:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Pywikibot
Anomie added a project to T75370: deletedrevs deprecated: Core Platform Team Workboards (Clinic Duty Team).
Thu, Sep 19, 4:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Pywikibot
Anomie moved T220245: Introduce alphabetic pager for Special:EditWatchlist from External Code Review Completed to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 4:03 PM · Core Platform Team Workboards (Clinic Duty Team), Growth-Team (Current Sprint), Patch-For-Review, OOUI, MediaWiki-Watchlist, Wikimedia-production-error
Anomie added a comment to T219374: Prepare and check storage layer for hi.wikisource.
Thu, Sep 19, 4:00 PM · Core Platform Team Workboards (Clinic Duty Team), cloud-services-team, Analytics, Data-Services, DBA
Anomie moved T219374: Prepare and check storage layer for hi.wikisource from Inbox to External Code Review Completed on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Sep 19, 3:54 PM · Core Platform Team Workboards (Clinic Duty Team), cloud-services-team, Analytics, Data-Services, DBA
Anomie added a project to T219374: Prepare and check storage layer for hi.wikisource: Core Platform Team Workboards (Clinic Duty Team).
Thu, Sep 19, 3:54 PM · Core Platform Team Workboards (Clinic Duty Team), cloud-services-team, Analytics, Data-Services, DBA
Anomie added a comment to T233278: wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30.

Looks like it did exist until very recently.

Thu, Sep 19, 3:41 PM · MediaWiki-General, php-session-serializer
Anomie added a comment to T233278: wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30.

Want me to re-tag (and sign it) as I created the commits etc?

Thu, Sep 19, 1:28 PM · MediaWiki-General, php-session-serializer
Anomie added a comment to T233278: wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30.

It looks like v1.0.4 was supposed to be 4474af7a, based on the dates and also based on 363f19e21 (specifically this line).

Thu, Sep 19, 1:26 PM · MediaWiki-General, php-session-serializer
Anomie renamed T233278: wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30 from wikimedia/php-session/serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30 to wikimedia/php-session-serializer 1.0.4 is not tagged, despite being required by MediaWiki 1.30.
Thu, Sep 19, 1:18 PM · MediaWiki-General, php-session-serializer

Wed, Sep 18

Anomie added a comment to T198343: Replace all calls to Revision::getRevisionText().

See T221869: Remove deprecated ApiQueryDeletedRevs for what's needed to remove the module from a Wikimedia usage perspective. The status seems unchanged since that task was created.

Wed, Sep 18, 9:14 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Purple), Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Patch-For-Review, Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Wikidata
Anomie moved T214215: MinimumPasswordLengthToLogin error message is unhelpful from Inbox to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 9:09 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Authentication-and-authorization
Anomie added a project to T214215: MinimumPasswordLengthToLogin error message is unhelpful: Core Platform Team Workboards (Clinic Duty Team).
Wed, Sep 18, 9:04 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Authentication-and-authorization
Anomie moved T233119: Intended use of MinimumPasswordLengthToLogin not so clear from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 9:01 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup
Anomie added a project to T233119: Intended use of MinimumPasswordLengthToLogin not so clear: Core Platform Team Workboards (Clinic Duty Team).

@Tchanders: Maybe this summary will help:

Wed, Sep 18, 9:01 PM · Core Platform Team Workboards (Clinic Duty Team), MW-1.31-release-notes, MW-1.32-notes, MW-1.33-notes, Documentation, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Trust-and-Safety, MediaWiki-Authentication-and-authorization, Anti-Harassment, MediaWiki-User-login-and-signup
Anomie added a comment to T232485: RFC: Core REST API namespace and version.

Having the language or domain in the path would be very difficult to do within MediaWiki. Configuration based on language and project has already happened by the time the REST router is called. At Wikimedia sites, this "configuration" includes selection of the particular deployment branch to use. Changing all that would be difficult to say the least.

Wed, Sep 18, 8:40 PM · TechCom-RFC, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
Anomie moved T220834: Log entry unreachable via logid= if its type is among $wgFilterLogTypes from External Review In Progress to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 8:01 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Logging
Anomie moved T233004: Schema changes for `cu_changes` and `cu_log` table from Discussing to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 7:59 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Schema-change, DBA, CheckUser
Anomie moved T233223: One persistent script timeout error from Inbox to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 6:45 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-Scribunto
Anomie closed T233223: One persistent script timeout error as Invalid.

If the timeout errors aren't occasional, you need to rework your page so it doesn't use so much time.

Wed, Sep 18, 6:45 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-Scribunto
Anomie moved T232911: Consider removing "@file" from class files from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Sep 18, 6:32 PM · Core Platform Team, MediaWiki-Documentation
Anomie moved T233244: Convert MediaWiki core files in /doc to Markdown from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Sep 18, 6:31 PM · Core Platform Team, Documentation, MediaWiki-Documentation
Anomie added a comment to T233244: Convert MediaWiki core files in /doc to Markdown.

Too bad Doxygen doesn't use wikitext ;)

Wed, Sep 18, 6:30 PM · Core Platform Team, Documentation, MediaWiki-Documentation
Anomie added a comment to T229127: Bundle TextExtracts with MediaWiki.

Supports MySQL, SQLite, and Postgres (sqlite doesn't support regex, so that option is hidden)

Wed, Sep 18, 5:40 PM · MW-1.34-release, MediaWiki-Releasing, MediaWiki-Installer
Anomie added a comment to T229128: Bundle PageImages with MediaWiki.

Supports MySQL, SQLite, and Postgres (if there are schema changes)

Wed, Sep 18, 5:40 PM · MW-1.34-release, MediaWiki-Releasing, MediaWiki-Installer
Anomie added a comment to T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL.

Change 537694 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Remove MySQL index aliasing for user_newtalk indexes
https://gerrit.wikimedia.org/r/537694

Wed, Sep 18, 4:58 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie moved T233240: Remove MySQL aliasing for user_newtalk indexes from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.

@Marostegui: This isn't ready for the official Blocked-on-schema-change request yet, but I'm pinging you now in case you want to be aware of it.

Wed, Sep 18, 4:54 PM · User-Marostegui, Patch-For-Review, Schema-change, MediaWiki-General, Core Platform Team Workboards (Clinic Duty Team)
Krinkle awarded T233240: Remove MySQL aliasing for user_newtalk indexes a Orange Medal token.
Wed, Sep 18, 4:45 PM · User-Marostegui, Patch-For-Review, Schema-change, MediaWiki-General, Core Platform Team Workboards (Clinic Duty Team)
Anomie created T233240: Remove MySQL aliasing for user_newtalk indexes.
Wed, Sep 18, 4:43 PM · User-Marostegui, Patch-For-Review, Schema-change, MediaWiki-General, Core Platform Team Workboards (Clinic Duty Team)
Anomie moved T220514: MediaWiki web installer do not show extension when their dependency is missing from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Sep 18, 4:12 PM · Core Platform Team, MW-1.34-release, Regression, MW-1.32-release, MW-1.33-release, Continuous-Integration-Infrastructure, MediaWiki-Installer
Anomie moved T233222: Factor rev_deleted logic out of the API modules from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Sep 18, 4:12 PM · Technical-Debt, Core Platform Team, MediaWiki-Revision-backend
Anomie updated the task description for T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL.
Wed, Sep 18, 4:08 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie updated the task description for T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL.
Wed, Sep 18, 4:06 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie moved T229712: update.php keeps adding index usertext_timestamp on archive despite index not existing in tables.sql from Inbox to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 4:05 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Installer
Anomie added a project to T229712: update.php keeps adding index usertext_timestamp on archive despite index not existing in tables.sql: Core Platform Team Workboards (Clinic Duty Team).
Wed, Sep 18, 4:05 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Installer
Anomie claimed T104756: The "archive" database table schema is inconsistent with update patch.

Since rMWc29909e59fd8: Mostly drop old pre-actor user schemas dropped the index entirely, this is almost fixed now. https://gerrit.wikimedia.org/r/537676 is still needed to fully clean it up during update.php, as the confusing history of this index may have resulted in the index existing as ar_usertext_timestamp, usertext_timestamp, or both and c29909e59 only drops one name (which may therefore error out if that name happens to not exist).

Wed, Sep 18, 4:01 PM · MediaWiki-Page-deletion, MediaWiki-Installer, Patch-For-Review, Schema-change
Anomie added a comment to T233135: Schema change for refactored actor and comment storage.

WTF is going on there?

Wed, Sep 18, 3:55 PM · Core Platform Team, Blocked-on-schema-change, DBA
Anomie closed T229712: update.php keeps adding index usertext_timestamp on archive despite index not existing in tables.sql as Resolved.

See T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL for details on what's going on here.

Wed, Sep 18, 3:53 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-Installer
Anomie moved T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL from Doing to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 3:50 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie claimed T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL.
Wed, Sep 18, 3:23 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie moved T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL from Inbox to Doing on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Sep 18, 3:22 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie created T233221: update.php needs to drop both archive.usertext_timestamp and archive.ar_usertext_timestamp, if they exist, on MySQL.
Wed, Sep 18, 3:22 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Installer
Anomie added a comment to T233135: Schema change for refactored actor and comment storage.

Also, see T223151: Review special replica partitioning of certain tables by `xx_user` where we discussed this before since we knew this was coming.

Wed, Sep 18, 3:01 PM · Core Platform Team, Blocked-on-schema-change, DBA
Anomie added a comment to T233135: Schema change for refactored actor and comment storage.

No, MediaWiki knows nothing about the paritioning. That's purely a Wikimedia thing.

Wed, Sep 18, 3:00 PM · Core Platform Team, Blocked-on-schema-change, DBA
Anomie added a comment to T233135: Schema change for refactored actor and comment storage.

s6 db2089:3316
I found this error on the three wikis that live there: frwiki jawiki ruwiki

ERROR 1091 (42000) at line 37: Can't DROP 'ar_usertext_timestamp'; check that column/key exists

Which I guess it is the result of: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/346649/1/maintenance/archives/patch-rename-ar_usertext_timestamp.sql ?

Wed, Sep 18, 1:58 PM · Core Platform Team, Blocked-on-schema-change, DBA

Tue, Sep 17

Anomie moved T232464: Getting InvalidArgumentException when running a query on the API from Doing to Done on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Sep 17, 7:46 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie closed T232464: Getting InvalidArgumentException when running a query on the API as Resolved.

Maintenance script runs completed.

Tue, Sep 17, 7:41 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

I think ActingUser comes in two flavors, which could be subclasses or distinguished by asking the object: 1) a user acting via a web request. Additional restrictions may applies. 2) a user user acting without a web request, so no additional restrictions apply.

Then what exactly is the difference between your "ActingUser2" and a normal UserIdentity? Just some semantics with no actual code difference?

Yes. Doing a secure permission check on a plain UserIdentity should fail because that UserIdentity might be accidental, and in fact should be the ActingUser1, so additional restrictions should apply. ActingUser2 would basically say "no extra checks needed", ensuring this was deliberate.

Tue, Sep 17, 7:20 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
jcrespo awarded T166733: Deploy refactored comment storage a Yellow Medal token.
Tue, Sep 17, 6:55 PM · CPT Initiatives (Revision Storage Schema Improvements), Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Comment-backend, User-notice, Epic
Anomie moved T232672: API does not strip bidi characters (or trim whitespace) when validating IPs for 'user'-type parameters from Needs details or plan to Needs Code on the MediaWiki-API board.

So probably the most consistent thing to do here is to pass it through Title::newFromText( $value, NS_USER ) (then get the IP back out with ->getText()), like User::getCanonicalName() does for registered user names, before running the regexes to determine if it's an IP.

Tue, Sep 17, 6:46 PM · MediaWiki-API, Core Platform Team
Anomie added a subtask for T166732: Refactor comment storage in the database and abstract access in MediaWiki: T233004: Schema changes for `cu_changes` and `cu_log` table.
Tue, Sep 17, 6:43 PM · MediaWiki-Comment-backend, MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2017), MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), Patch-For-Review, Wikimedia-Rdbms
Anomie added a parent task for T233004: Schema changes for `cu_changes` and `cu_log` table: T166732: Refactor comment storage in the database and abstract access in MediaWiki.
Tue, Sep 17, 6:43 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Schema-change, DBA, CheckUser
Anomie added a comment to T232531: Refactor Comment fields for CheckUser Component.

Looks like T233004 is handling this already. Since there's more discussion on that on, I'm going to close this as the duplicate even though it's older.

Tue, Sep 17, 6:37 PM · Analytics, Core Platform Team, CheckUser
Anomie merged T232531: Refactor Comment fields for CheckUser Component into T233004: Schema changes for `cu_changes` and `cu_log` table.
Tue, Sep 17, 6:37 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Schema-change, DBA, CheckUser
Anomie merged task T232531: Refactor Comment fields for CheckUser Component into T233004: Schema changes for `cu_changes` and `cu_log` table.
Tue, Sep 17, 6:37 PM · Analytics, Core Platform Team, CheckUser
Anomie moved T75181: Remove HHVM revision tag from Inbox to External Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Sep 17, 6:35 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-WikimediaMaintenance, Patch-For-Review, HHVM, Wikimedia-General-or-Unknown
Anomie edited projects for T75181: Remove HHVM revision tag, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Sep 17, 6:34 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-extensions-WikimediaMaintenance, Patch-For-Review, HHVM, Wikimedia-General-or-Unknown
Anomie moved T233004: Schema changes for `cu_changes` and `cu_log` table from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Sep 17, 6:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Schema-change, DBA, CheckUser
Anomie edited projects for T233004: Schema changes for `cu_changes` and `cu_log` table, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Sep 17, 6:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Schema-change, DBA, CheckUser
Anomie moved T232931: Remove support for run-time automatic $wgServer default value from Inbox to Blocked Externally on the Core Platform Team Workboards (Clinic Duty Team) board.

Currently putting this in "Blocked Externally" on the CPT Clinic Duty board. Once the blocker is resolved, this should go to "External Code Review Needed".

Tue, Sep 17, 6:28 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), MediaWiki-General, Technical-Debt (Deprecation)
Anomie edited projects for T232931: Remove support for run-time automatic $wgServer default value, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Sep 17, 6:27 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Performance-Team (Radar), MediaWiki-General, Technical-Debt (Deprecation)
Anomie triaged T211555: Figure out how to inject MediaWiki's mime mapping into Guzzle as Low priority.
Tue, Sep 17, 6:21 PM · Core Platform Team, MediaWiki-libs-HTTP
Anomie added a comment to T233090: Should EditURI be calculated using the site's canonical protocol?.

After discussion in our triage meeting, we (CPT) decided this should be closed in favor of T118413: Wikimedia wikis should use https:// in $wgServer.

Tue, Sep 17, 6:19 PM · MediaWiki-General, Core Platform Team
Anomie merged T233090: Should EditURI be calculated using the site's canonical protocol? into T118413: Wikimedia wikis should use https:// in $wgServer.
Tue, Sep 17, 6:18 PM · Patch-For-Review, Wikimedia-Site-requests
Anomie merged task T233090: Should EditURI be calculated using the site's canonical protocol? into T118413: Wikimedia wikis should use https:// in $wgServer.
Tue, Sep 17, 6:18 PM · MediaWiki-General, Core Platform Team
Anomie updated the task description for T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table.
Tue, Sep 17, 5:49 PM · CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt), Schema-change
Anomie added a comment to T215466: Remove revision_comment_temp and revision_actor_temp.

Status: Blocked on T184615: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table also being ready to go. The intention is to combine all the alters of revision into one task for the DBAs.

Tue, Sep 17, 5:48 PM · CPT Initiatives (Revision Storage Schema Improvements), Technical-Debt, Epic
Anomie updated the task description for T215466: Remove revision_comment_temp and revision_actor_temp.
Tue, Sep 17, 5:43 PM · CPT Initiatives (Revision Storage Schema Improvements), Technical-Debt, Epic
Anomie moved T166733: Deploy refactored comment storage from Inbox to Done on the Core Platform Team Workboards (Clinic Duty Team) board.

Note the final Wikimedia production schema changes are tracked in T233135: Schema change for refactored actor and comment storage, and cleanup of revision_comment_temp in T215466: Remove revision_comment_temp and revision_actor_temp. Changes for any extensions should be tracked in their own tasks.

Tue, Sep 17, 5:42 PM · CPT Initiatives (Revision Storage Schema Improvements), Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Comment-backend, User-notice, Epic
Anomie moved T188327: Deploy refactored actor storage from Waiting for deployment to Done on the Core Platform Team Workboards (Clinic Duty Team) board.

Note the final Wikimedia production schema changes are tracked in T233135: Schema change for refactored actor and comment storage, and cleanup of revision_actor_temp in T215466: Remove revision_comment_temp and revision_actor_temp. Changes for any extensions should be tracked in their own tasks.

Tue, Sep 17, 5:42 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), CPT Initiatives (Revision Storage Schema Improvements), Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes, MW-1.32-notes, Epic
Anomie closed T166733: Deploy refactored comment storage, a subtask of T6715: Allow comments longer than 255 bytes, as Resolved.
Tue, Sep 17, 5:40 PM · MediaWiki-Comment-backend, Hindi-Sites, Malayalam-Sites, User-notice, Schema-change, Wikimedia-Rdbms
Anomie closed T166733: Deploy refactored comment storage as Resolved.
Tue, Sep 17, 5:40 PM · CPT Initiatives (Revision Storage Schema Improvements), Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Comment-backend, User-notice, Epic
Anomie closed T166733: Deploy refactored comment storage, a subtask of T227047: Complete actor table and comment table migration, as Resolved.
Tue, Sep 17, 5:40 PM · CPT Initiatives (Revision Storage Schema Improvements), Epic
Anomie closed T188327: Deploy refactored actor storage, a subtask of T227047: Complete actor table and comment table migration, as Resolved.
Tue, Sep 17, 5:40 PM · CPT Initiatives (Revision Storage Schema Improvements), Epic
Anomie closed T188327: Deploy refactored actor storage as Resolved.
Tue, Sep 17, 5:40 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), CPT Initiatives (Revision Storage Schema Improvements), Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes, MW-1.32-notes, Epic
Anomie moved T233135: Schema change for refactored actor and comment storage from Inbox to Tracking/Watching on the Core Platform Team board.
Tue, Sep 17, 5:39 PM · Core Platform Team, Blocked-on-schema-change, DBA
Anomie created T233135: Schema change for refactored actor and comment storage.
Tue, Sep 17, 5:39 PM · Core Platform Team, Blocked-on-schema-change, DBA
Anomie added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.

Yes, of course it matters for that wiki. But if we write both fields, shouldn't it be always fine for that wiki? The other value would just be ignored.

Tue, Sep 17, 5:18 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Anomie moved T233132: Expand QPS for partners when "stash=true" from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Sep 17, 5:11 PM · RESTBase-API, RESTBase, Core Platform Team
Anomie added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.

I hope that putting the schema and the code in different releases will help ensure that, by the time we add the flag, both the local and the foreign DB will have the new schema. I see it's not necessary, but I think it could help?

Tue, Sep 17, 4:42 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Anomie added a comment to T231930: Introduce ActingUser to represent the user performing the current request.

I think ActingUser comes in two flavors, which could be subclasses or distinguished by asking the object: 1) a user acting via a web request. Additional restrictions may applies. 2) a user user acting without a web request, so no additional restrictions apply.

Tue, Sep 17, 3:59 PM · MediaWiki-User-management, CPT Initiatives (Decoupling (CDP2))
Anomie added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.
  • 0 and 1: Nothing will try to access the new fields, so it doesn't matter whether they exist yet.

OK, so basically the idea is to create the schema *before* even adding the rest of the migration code, right? IIUC, we could for instance add the schema in 1.34, then the flag and the rest of the migration stuff in 1.35. This way, ideally all wikis should have the new columns by 1.35, unconditionally. Is that right?

Tue, Sep 17, 3:46 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Anomie moved T232021: Add some way to technically distinguish partial blocks and full blocks from Ready to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Sep 17, 3:31 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Anti-Harassment, MediaWiki-User-management