Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (214 w, 2 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Today

Anomie added a comment to T209556: In AuthManager, avoid encrypted storage of the password in the session.

My idea is to call a form processing method on all registered AuthenticationProvider instances when each form is submitted. This method will return a data array giving only the data the AuthenticationProvider will later need to authenticate the request. Then beginPrimaryAuthentication() will only be passed the pre-filtered data arrays previously returned by the form processing method, instead of all form data.

For example, LocalPasswordPrimaryAuthenticationProvider could just store a boolean value representing whether or not the password matched.

Thu, Nov 15, 5:21 AM · Security, MediaWiki-Authentication-and-authorization
Anomie added a comment to T206010: RfC: Session storage service interface.

22:27:36 <bawolff> So one feature that is requested sometimes is having the ability for users to view/terminate other sessions (like i think gmail lets you). I guess this interface would preclude that

Thu, Nov 15, 5:03 AM · User-Clarakosi, TechCom-RFC, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2)), User-Eevans

Yesterday

Aklapper awarded T209429: memcached error: A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE a Like token.
Wed, Nov 14, 10:14 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-JobQueue, Wikimedia-production-error
Anomie updated the task description for T188132: Merge image_comment_temp table into the image table.
Wed, Nov 14, 8:10 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), MediaWiki-Database
Anomie added a comment to T189158: Change `image` view to properly expose the new `img_description_id` field.

Yes, if it's deployed to all the cloud replicas this task can be closed.

Wed, Nov 14, 7:57 PM · cloud-services-team (Kanban), Patch-For-Review, Data-Services
Anomie added a comment to T209429: memcached error: A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE .

Sorry for the long time it took to add the stack trace to the log context, I ran a full scap instead of syncing just the file.

Wed, Nov 14, 7:38 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-JobQueue, Wikimedia-production-error
Anomie edited projects for T209429: memcached error: A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE , added: MediaWiki-JobQueue; removed MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review.

Looks like it's probably something to do with rMW51945dbca359: Use DB domain in JobQueueGroup and make WikiMap domain ID methods stricter. I'm continuing to investigate.

Wed, Nov 14, 6:34 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-JobQueue, Wikimedia-production-error
Anomie added a comment to T209423: Installer fails due to a Call Stack.

Can't reproduce with PHP 7.0.31 or HHVM 3.18.6, or in some quick tests with PHP 7.1.20, 7.2.11, or 7.3.0RC4.

Wed, Nov 14, 4:31 PM · Multi-Content-Revisions, MediaWiki-Installer
Anomie added a comment to T209429: memcached error: A BAD KEY WAS PROVIDED/CHARACTERS OUT OF RANGE .
Wed, Nov 14, 4:05 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, MediaWiki-JobQueue, Wikimedia-production-error
Anomie closed T209457: Allpages generator query combined with prop=langlinks leads to incorrect results as Invalid.

I expect that up until the article that is referred to in the tag "continue llcontinue" it will show all langlinks for all pages.
However for example the article "Oplegslot" show no langlinks in the generated list.

Wed, Nov 14, 3:47 PM · MediaWiki-API

Tue, Nov 13

Anomie reopened T209113: Argument 1 passed to CentralAuthUser::getMasterInstance() must be an instance of User, null given, as "Open".

Reopen since the fix was reverted.

Tue, Nov 13, 6:04 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Growth-Team, StructuredDiscussions
Anomie added a comment to T209031: Not able to scoop comment table in labs for mediawiki reconstruction process.

Materialized views in mariadb requires a plugin that basically is adding some kind of hooks.

Tue, Nov 13, 6:02 PM · Analytics-Kanban, DBA, Data-Services, Analytics
Anomie added a comment to T208769: Ensure that AbuseFilter applies to the content of all MCR slots.

After taking a bit of a closer look at it, it looks like the "old_wikitext", "new_wikitext", "old_content_model", and "new_content_model" would need to be replaced with something that allows fetching the values for each slot individually.

Tue, Nov 13, 5:53 PM · Core Platform Team Kanban, AbuseFilter, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering
Anomie updated the task description for T188327: Deploy refactored actor storage.
Tue, Nov 13, 4:18 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), Patch-For-Review, Epic
Anomie added a comment to T130482: Special:Linksearch should de/encode internationalized domain names.

Newly-created IDN links will now be translated.

Tue, Nov 13, 3:32 PM · Patch-For-Review, MediaWiki-Special-pages
Anomie added a subtask for T130482: Special:Linksearch should de/encode internationalized domain names: T209373: Run maintenance/refreshExternallinksIndex.php on all wikis.
Tue, Nov 13, 3:30 PM · Patch-For-Review, MediaWiki-Special-pages
Anomie added a parent task for T209373: Run maintenance/refreshExternallinksIndex.php on all wikis: T130482: Special:Linksearch should de/encode internationalized domain names.
Tue, Nov 13, 3:30 PM · Wikimedia-maintenance-script-run
Anomie removed a project from T59176: ApiQueryExtLinksUsage::run query has crazy limit: Patch-For-Review.
Tue, Nov 13, 3:06 PM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), MW-1.29-release-notes, Schema-change, DBA, MediaWiki-API, Performance, MediaWiki-Database
Anomie updated the task description for T59176: ApiQueryExtLinksUsage::run query has crazy limit.
Tue, Nov 13, 3:06 PM · MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), MW-1.29-release-notes, Schema-change, DBA, MediaWiki-API, Performance, MediaWiki-Database
Anomie triaged T209373: Run maintenance/refreshExternallinksIndex.php on all wikis as Normal priority.
Tue, Nov 13, 3:05 PM · Wikimedia-maintenance-script-run
Anomie added a comment to T166733: Deploy refactored comment storage.

All wikis except commonswiki passed. There were 13 rows in Commons's image table that didn't get updated, apparently due to page moves and the fact that image uses img_name as its PK rather than an immutable integer. They've been fixed, and I'm running the check again just to be sure.

Tue, Nov 13, 2:56 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie closed T209326: LuaSandbox timer test fails under reprotest/faketime as Invalid.

Searching for the error message lead me to https://github.com/wolfcw/libfaketime/issues/127 but it wasn't obvious to me if this is an issue in libfaketime since it still doesn't appear to work.

Tue, Nov 13, 2:42 PM · LuaSandbox
Anomie triaged T209310: Consider implementing Module:No globals / Log globals in Scribunto itself as Lowest priority.

(working on the assumption that globals should be avoided)

Tue, Nov 13, 2:24 PM · MediaWiki-extensions-Scribunto
Prtksxna awarded T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused a Yellow Medal token.
Tue, Nov 13, 12:28 AM · Patch-For-Review, OOUI (OOUI-0.29.4), Regression

Mon, Nov 12

Anomie added a comment to T166733: Deploy refactored comment storage.

At the table level, the following should all return zero rows:

SELECT * FROM comment WHERE comment_id = 0; -- Sanity check
SELECT * FROM revision LEFT JOIN revision_comment_temp ON (rev_id=revcomment_rev) LEFT JOIN comment ON (revcomment_comment_id=comment_id) WHERE comment_id IS NULL;
SELECT * FROM archive          LEFT JOIN comment ON (ar_comment_id=comment_id)        WHERE comment_id IS NULL;
SELECT * FROM ipblocks         LEFT JOIN comment ON (ipb_reason_id=comment_id)        WHERE comment_id IS NULL;
SELECT * FROM image            LEFT JOIN comment ON (img_description_id=comment_id)   WHERE comment_id IS NULL;
SELECT * FROM oldimage         LEFT JOIN comment ON (oi_description_id=comment_id)    WHERE comment_id IS NULL;
SELECT * FROM filearchive      LEFT JOIN comment ON (fa_deleted_reason_id=comment_id) WHERE comment_id IS NULL;
SELECT * FROM filearchive      LEFT JOIN comment ON (fa_description_id=comment_id)    WHERE comment_id IS NULL;
SELECT * FROM recentchanges    LEFT JOIN comment ON (rc_comment_id=comment_id)        WHERE comment_id IS NULL;
SELECT * FROM logging          LEFT JOIN comment ON (log_comment_id=comment_id)       WHERE comment_id IS NULL;
SELECT * FROM protected_titles LEFT JOIN comment ON (pt_reason_id=comment_id)         WHERE comment_id IS NULL;
Mon, Nov 12, 7:11 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T209031: Not able to scoop comment table in labs for mediawiki reconstruction process.

Note the actor view will likely turn out to have similar issues.

Mon, Nov 12, 6:25 PM · Analytics-Kanban, DBA, Data-Services, Analytics
Anomie added a comment to T166733: Deploy refactored comment storage.

Run those on the vslow replicas- they are precisely thought for that- and they have lower weights to avoid affecting other production hosts .

Mon, Nov 12, 4:49 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T166733: Deploy refactored comment storage.

There is now a need to check consistency configuration on all codfw hosts, which were altered to prevent lots of lagging behind, as well as I would recommend some light checking on the consistency of the affected tables.

Mon, Nov 12, 4:31 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie moved T209228: Action api should reject requests with unsupported http methods with a 405 from Unsorted to Needs Code on the MediaWiki-API board.
Mon, Nov 12, 2:26 PM · Google-Code-in-2018, MediaWiki-API
Anomie triaged T209228: Action api should reject requests with unsupported http methods with a 405 as Low priority.

It wouldn't hurt to return an error for unexpected verbs, probably somewhere near the check for POST being required.

Mon, Nov 12, 2:25 PM · Google-Code-in-2018, MediaWiki-API

Fri, Nov 9

Anomie added a comment to T166733: Deploy refactored comment storage.

enwiki finished much faster than I thought it would.

Fri, Nov 9, 10:45 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie updated the task description for T166733: Deploy refactored comment storage.
Fri, Nov 9, 10:45 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.

I don't see anything where your stuff would interact with my stuff.

Fri, Nov 9, 4:57 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
Anomie added a comment to T208909: [Bug] Update old nonuniformly distributed page_random values.
  1. We don’t know how long this script will take to run. [...] In your experience, how long does a change like this take?
Fri, Nov 9, 3:23 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), DBA, MediaWiki-General-or-Unknown
Anomie added a comment to T208487: [RfC] Add CURRENT_TIMESTAMP support for `wl_notificationtimestamps` in watchlist table.

For wl_notificationtimestamp, we set it to NULL when the user views the latest revision of the page, and when the page is edited we set all non-NULL entries to the time of the edit. This allows us to trivially find all watchlist entries where the page has/hasn't been edited since the last view: "has been edited" has wl_notificationtimestamp IS NOT NULL, while "hasn't been edited" has wl_notificationtimestamp IS NULL.

Fri, Nov 9, 2:04 PM · User-D3r1ck01, TechCom-RFC, Growth-Team, MediaWiki-Database

Thu, Nov 8

Anomie added a comment to T204160: Create a security issue task type with additional attributes.

The fields on the tasks are now showing as editable for me, thanks.

Thu, Nov 8, 5:10 PM · Release-Engineering-Team (Kanban), Security-Team, User-MModell, Phabricator
Anomie closed T206586: Write LuaSandbox DocBook manual as Resolved.
Thu, Nov 8, 4:48 PM · Core Platform Team Kanban (Done with CPT), Patch-For-Review, Documentation, Core Platform Team, LuaSandbox
Anomie added a comment to T208188: Proposal for partial opt-out method for Content security policy.

I see at least two ways we could accomodate this:

  • We could not support CSP exemptions from user scripts. This would mean that initially, only gadgets can obtain this exemption and that a user can't on their own write a script that sends to or obtains data from elsewhere and have it be used by users. Instead, communities may establish some kind of convention whereby they'd have a no-op gadget maintained by trusted administrators for specific domains used by user scripts on that wiki. A user script author would need to request from this gadget maintainer for any new domains to be added before their script can work and be shared, and they'd need to instruct users to ensure they have said gadget enabled before they can use the user script. I'm expecting this won't be "acceptable" by product and by communities but I'll mention it as an option due to the potentially high cost and complexity of the alternative.
Thu, Nov 8, 3:43 PM · TechCom-RFC, TechCom, Security-Team, Security
Anomie added a comment to T150526: BotPasswords: grant all rights.

No, there are no "parent accounts". The reporter seems to have been thinking of a BotPassword as a "sub account" rather than as a rights-limited login to the existing account.

Thu, Nov 8, 3:30 PM · MediaWiki-Authentication-and-authorization, Security
Anomie added a comment to T207253: Compare a few tables per section between hosts and DC.

The idea is to check some important (but not to big tables) that are likely to have many changes during the day, so we can detect differences.

We could start with the user table on one wiki per section.
This table is concurrent enough but not too big in size that it can be compared in less than an hour for enwiki for example and even if there are schema changes running on that table, they would not be big enough that they can take more than 24h to be completed.

Thu, Nov 8, 2:40 PM · Patch-For-Review, User-Banyek, Wikimedia-Incident, DBA
Anomie added a comment to T208954: Missing row in enwiki.archive on sanitarium.

@Anomie I do strongly believe that mediawiki has recently gone unsafe (regression) in the latest releases- this is one of the many replication issues we had recently- we should search recent commits for unsafe statements or this will continue happening.

There are no actionables for you here, feel free to unsubscribe, but I wanted to gives you a heads up that we do need to do some code audit for sql statements modifed recently (or batch-ran recently). Note that new sanitariums were setup very recently copied directly from production and do not carry the issues that were fixed long ago with the old, already fixed archive INSERT...SELECT.

Thu, Nov 8, 2:34 PM · User-Banyek, Patch-For-Review, DBA

Wed, Nov 7

Anomie added a comment to T166733: Deploy refactored comment storage.

enwiki is done with the revision table already, and is about 90% done with the archive table. It has 103098562 rows to process for the remaining tables. All the s2 wikis combined had 113906981 rows in those remaining tables, and all of s2 (including revision and archive) completed in under 6 days. So hopefully that means enwiki will be done by next week rather than the week after.

Wed, Nov 7, 8:09 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie moved T208929: RevisionAccessException from ApiComparePages.php: Could not determine title for page/revision ID from Unsorted to Non-core-API stuff on the MediaWiki-API board.

Example URLs to reproduce the error would be really helpful in bug reports like this. Even a link to the error in Kibana would be better than having to copy-paste the request ID.

Wed, Nov 7, 3:48 PM · Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Core Platform Team Kanban (Doing), Patch-For-Review, MediaWiki-History-or-Diffs, MediaWiki-API, Wikimedia-production-error
Anomie added a project to T208926: PHP Fatal from ApiMain.php: Header may not contain more than a single header, new line detected: Reading List Service.

It looks like every instance of this error logged in Kibana is correlated with an error in the restbase channel, and all have root_req_uri matching /en.wikipedia.org/v1/data/lists/631495/entries/batch?csrf_token=* or /en.wikipedia.org/v1/data/lists/631496/entries/batch?csrf_token=*, which as far as I can tell has something to do with Reading List Service.

Wed, Nov 7, 3:31 PM · Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Reading-Infrastructure-Team-Backlog, Reading List Service, MediaWiki-API, Wikimedia-production-error
Anomie moved T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser from Unsorted to Needs Code on the MediaWiki-API board.
Wed, Nov 7, 2:47 PM · MediaWiki-API, Wikidata-Campsite, Wikidata, Wikibase-DataModel, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error
Anomie added a project to T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser: MediaWiki-API.

There's a decent chance that the 2010-era code in ApiQueryQueryPage could use updating in some manner.

$qp = new $this->qpMap[$params['page']]();

It should probably use SpecialPageFactory somehow instead.

Wed, Nov 7, 2:46 PM · MediaWiki-API, Wikidata-Campsite, Wikidata, Wikibase-DataModel, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error

Tue, Nov 6

Anomie added a comment to T208868: Clicking a link unexpectedly changes 'usenewrc' preference.
  1. Have "Opt out of improvements" checked for RecentChanges and Watchlist preferences
Tue, Nov 6, 9:30 PM · Growth-Team, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, MediaWiki-Watchlist
Anomie created T208868: Clicking a link unexpectedly changes 'usenewrc' preference.
Tue, Nov 6, 4:47 PM · Growth-Team, MediaWiki-Recent-changes, Edit-Review-Improvements-RC-Page, MediaWiki-Watchlist
Anomie added a comment to T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode).

I don't know. rMW993baa3493f1: ActorMigration: Remove possibility of read-both is a bit of a large change, the default is MIGRATION_OLD, and if a wiki goes straight to MIGRATION_NEW they wouldn't run into this either.

Tue, Nov 6, 2:55 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Regression, MediaWiki-Special-pages, Performance
Anomie added a comment to T208695: Duplicate key on several s8 replicas breaking replication.

Q123507, specifically this revision.

Tue, Nov 6, 2:52 PM · Wikidata, Wikimedia-Incident, DBA
Anomie added a comment to T208821: Deprecate and remove PopupTagMultiselectWidget.

The integer input you might be able to replace with some sort of TagMultiselectWidget that has a filter on the input string so only in-range integers are allowed. The timestamp input, though, seems like it'd be difficult to replace. There's currently also the possibility of wrapping a password or limit input, but no examples of either.

Tue, Nov 6, 2:28 PM · MediaWiki-extensions-ApiSandbox, OOUI

Mon, Nov 5

Anomie added a comment to T205675: Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given".

I spot-checked a few of these "Failed to load latest revision ID $Y of page ID $X" errors, and in all 7 cases the revision that couldn't be loaded seems to have been a page move null-revision timestamped within a few seconds of the error message. It seems like we're running into a situation where, when a move gets double-submitted, the first submission does the move and somehow the second sees the updated page.page_latest but somehow can't load the RevisionRecord. I can't see how that would happen though.

Mon, Nov 5, 11:57 PM · MediaWiki-General-or-Unknown, Core Platform Team Kanban, MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (MCR), Multi-Content-Revisions (Reactive), Wikimedia-production-error
Anomie added a comment to T208695: Duplicate key on several s8 replicas breaking replication.

Could an interaction with archive create issues- eg. the undeletion of a revision so it gets moved from archive to revision and archive is know to been unreliable in the past?

Mon, Nov 5, 9:44 PM · Wikidata, Wikimedia-Incident, DBA
Anomie added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Could we configure CSP to not restrict CORS requests while still restricting <script> and the like? Or would there be no point then since an attacker could just load evil.js via CORS and eval it?

Mon, Nov 5, 7:46 PM · TechCom-RFC, TechCom, Security-Team, Security
Anomie added a comment to T208707: AuthManager::getAuthenticationRequests() and begin/continue* should be in the same authentication session.

AuthManager is already pretty stateless, as all state comes via the Session (which in turn comes via the WebRequest passed to the constructor).

Mon, Nov 5, 7:24 PM · MediaWiki-Authentication-and-authorization
Anomie added a comment to T207497: Excimer: Expose event_count in ExcimerLogEntry.

Personally I'm not too concerned about the name, just the lack of any way to see the value.

Mon, Nov 5, 6:06 PM · Core Platform Team Kanban, Core Platform Team (PHP7 (TEC4)), Excimer
Anomie added a comment to T208700: Give option to enable auto-update from mediawiki to modules.

This seems like more or less a hack around the lack of progress on T121470: Central Global Repository for Templates, Lua modules, and Gadgets.

Mon, Nov 5, 5:58 PM · MediaWiki-General-or-Unknown
Anomie added a comment to T208437: Consolidate and migrate Module namespace to Commons.

I think you're jumping the gun here by proposing a specific solution before T121470: Central Global Repository for Templates, Lua modules, and Gadgets has gotten any real progress.

Mon, Nov 5, 5:57 PM · Wikimedia-General-or-Unknown
Anomie closed T198308: Enable MCR migration stage "write both, read new" on live systems, a subtask of T174047: Hide deprecated/unused fields on toolforge replica [MCR], as Resolved.
Mon, Nov 5, 5:33 PM · Patch-For-Review, Cloud-Services, Multi-Content-Revisions (Deployment), Wikidata
Anomie closed T198308: Enable MCR migration stage "write both, read new" on live systems, a subtask of T174044: Deploy MCR storage layer, as Resolved.
Mon, Nov 5, 5:33 PM · Core Platform Team (MCR), Core Platform Team Backlog (Epic), SDC Engineering, Multi-Content-Revisions (Deployment), User-Addshore, Patch-For-Review, Epic, DBA, Wikidata
Anomie closed T198308: Enable MCR migration stage "write both, read new" on live systems as Resolved.
Mon, Nov 5, 5:33 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (MCR), SDC Engineering, MW-1.32-release, Multi-Content-Revisions (Deployment), Wikidata
Anomie edited projects for T208601: ForeignApi adds the origin parameter even if the other wiki is on the same domain, added: JavaScript, MediaWiki-Interface; removed MediaWiki-API.

MediaWiki-API isn't the right tag for issues with the client library included in resources/src/, much like it's not the right tag for things like Pywikibot. Feel free to retag if a problem is identified in the API itself rather than in a client library.

Mon, Nov 5, 5:17 PM · MediaWiki-Interface, JavaScript
Anomie moved T208691: Fatal exception from ApiQueryBase: Call to getNamespace() on non-object null from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Mon, Nov 5, 3:11 PM · Core Platform Team Backlog (Watching / External), PageViewInfo, MediaWiki-API, Wikimedia-production-error
Anomie added a comment to T208695: Duplicate key on several s8 replicas breaking replication.

The corresponding revision-table row is timestamped 2018-09-13T09:08:17Z. $wgCommentTableSchemaMigrationStage should have been WRITE_BOTH since February 2018, so the revision_comment_temp row should have already existed, so the migration script shouldn't have been having to insert it in the first place.

Mon, Nov 5, 2:56 PM · Wikidata, Wikimedia-Incident, DBA
Anomie added a comment to T208672: Duplicate rows error in db2095 replication @s7.

For the kowiki example, I note the following:

db1062 (current master)
+---------+--------------+---------------+------------+---------------+---------+--------------+----------+----------------+---------------+-----------+------------+------------+--------+------------+--------------+---------------------------------+------------------+-------------------+
| ar_id   | ar_namespace | ar_title      | ar_comment | ar_comment_id | ar_user | ar_user_text | ar_actor | ar_timestamp   | ar_minor_edit | ar_rev_id | ar_text_id | ar_deleted | ar_len | ar_page_id | ar_parent_id | ar_sha1                         | ar_content_model | ar_content_format |
+---------+--------------+---------------+------------+---------------+---------+--------------+----------+----------------+---------------+-----------+------------+------------+--------+------------+--------------+---------------------------------+------------------+-------------------+
| 1011832 |            0 | 수소_폭탄     |            |             3 |     942 | ChongDae     |        0 | 20050515134522 |             0 |     49191 |      49191 |          0 |     24 |      19711 |        89988 | hey8xwlrgqvp1qnq1na64hl4gecmpn6 | NULL             | NULL              |
| 1011833 |            0 | 수소_폭탄     |            |             3 |     942 | ChongDae     |        0 | 20050515133948 |             1 |     89988 |      89988 |          0 |     23 |      19711 |        49184 | cenuot3lw5x0rhfjqeshqnj0llipqw5 | NULL             | NULL              |
+---------+--------------+---------------+------------+---------------+---------+--------------+----------+----------------+---------------+-----------+------------+------------+--------+------------+--------------+---------------------------------+------------------+-------------------+
db2077
+---------+--------------+---------------+------------+---------------+---------+--------------+----------+----------------+---------------+-----------+------------+------------+--------+------------+--------------+---------------------------------+------------------+-------------------+
| ar_id   | ar_namespace | ar_title      | ar_comment | ar_comment_id | ar_user | ar_user_text | ar_actor | ar_timestamp   | ar_minor_edit | ar_rev_id | ar_text_id | ar_deleted | ar_len | ar_page_id | ar_parent_id | ar_sha1                         | ar_content_model | ar_content_format |
+---------+--------------+---------------+------------+---------------+---------+--------------+----------+----------------+---------------+-----------+------------+------------+--------+------------+--------------+---------------------------------+------------------+-------------------+
| 1011832 |            0 | 수소_폭탄     |            |             3 |     942 | ChongDae     |        0 | 20050515133948 |             1 |     89988 |      89988 |          0 |     23 |      19711 |        49184 | cenuot3lw5x0rhfjqeshqnj0llipqw5 | NULL             | NULL              |
| 1011833 |            0 | 수소_폭탄     |            |             3 |     942 | ChongDae     |        0 | 20050515134522 |             0 |     49191 |      49191 |          0 |     24 |      19711 |        89988 | hey8xwlrgqvp1qnq1na64hl4gecmpn6 | NULL             | NULL              |
+---------+--------------+---------------+------------+---------------+---------+--------------+----------+----------------+---------------+-----------+------------+------------+--------+------------+--------------+---------------------------------+------------------+-------------------+

It appears that somehow db2077 has these two rows switched around relative to db1062, as might have happened if they were created by a statement-replicated INSERT SELECT at some point.

Mon, Nov 5, 2:44 PM · DBA

Fri, Nov 2

Anomie added a comment to T189158: Change `image` view to properly expose the new `img_description_id` field.

It should be ready, yes. The image_comment_temp table is already emptied in production on all wikis, with all the rows having had the data migrated into img_description_id. Maintenance is in progress to backfill img_description_id from img_description.

Fri, Nov 2, 3:22 PM · cloud-services-team (Kanban), Patch-For-Review, Data-Services
Anomie added a comment to T208188: Proposal for partial opt-out method for Content security policy.

I've been thinking about this, and I'm not a fan of having bundles of common external sources as:

Fri, Nov 2, 3:20 PM · TechCom-RFC, TechCom, Security-Team, Security

Thu, Nov 1

Anomie added a comment to T208501: Will the contentmodel on prop=info be changing for MCR?.

Although that would likely have the same sort of breakage for unupdated clients that simply removing it would.

Thu, Nov 1, 7:30 PM · MediaWiki-API, Multi-Content-Revisions
Anomie moved T208501: Will the contentmodel on prop=info be changing for MCR? from Unsorted to Non-Code on the MediaWiki-API board.

The property will continue to refer to the main slot, although we should deprecate it. Unfortunately there's no way to track usage of API response properties, so it'll probably remain there-but-silently-deprecated for close to forever.

Thu, Nov 1, 7:14 PM · MediaWiki-API, Multi-Content-Revisions
Anomie added a comment to T171563: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.).

That makes sense, thanks for clarifying. Before we remove the "OR has .js extension" bit we might want to make sure there aren't any other cases where the content could be treated as JS despite the content type.

Thu, Nov 1, 5:35 PM · Security, Security-team-backlog, MediaWiki-Page-protection, JavaScript
Anomie added a comment to T171563: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.).

The "similar permission" in that case would be editmyuserjs, of course. The point it should only be possible to load a page as JS if editing it requires one of the JS-related permissions. For user subpages that's already the case (unless someone stores scripts with a nonstandard extension or on the talk page).

Thu, Nov 1, 5:01 PM · Security, Security-team-backlog, MediaWiki-Page-protection, JavaScript
Anomie moved T208517: Wikibase should add a property to the page response object that indicates the embeded entities from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Thu, Nov 1, 4:43 PM · MediaWiki-API, SDC General, MediaWiki-extensions-WikibaseRepository, Wikidata
Anomie updated the task description for T189158: Change `image` view to properly expose the new `img_description_id` field.
Thu, Nov 1, 4:21 PM · cloud-services-team (Kanban), Patch-For-Review, Data-Services
Anomie updated the task description for T189158: Change `image` view to properly expose the new `img_description_id` field.
Thu, Nov 1, 4:18 PM · cloud-services-team (Kanban), Patch-For-Review, Data-Services
Anomie updated the task description for T189158: Change `image` view to properly expose the new `img_description_id` field.
Thu, Nov 1, 4:13 PM · cloud-services-team (Kanban), Patch-For-Review, Data-Services
Anomie updated the task description for T188132: Merge image_comment_temp table into the image table.
Thu, Nov 1, 4:09 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), MediaWiki-Database
Anomie updated the task description for T188132: Merge image_comment_temp table into the image table.
Thu, Nov 1, 4:09 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), MediaWiki-Database
Anomie closed T207623: Unlike string.gsub, mw.ustring.gsub doesn't add whole match as first capture when pattern has no captures as Resolved.

This should be deployed to Wikimedia wikis with 1.33.0-wmf.3, see https://www.mediawiki.org/wiki/MediaWiki_1.33/Roadmap for a schedule.

Thu, Nov 1, 4:07 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, MediaWiki-extensions-Scribunto
Anomie closed T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode) as Resolved.
Thu, Nov 1, 4:06 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Regression, MediaWiki-Special-pages, Performance
Anomie closed T204669: Slow access to Special:Contributions on mediawiki.org (due to enabling actor table WRITE_BOTH mode), a subtask of T188327: Deploy refactored actor storage, as Resolved.
Thu, Nov 1, 4:06 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), Patch-For-Review, Epic
Anomie added a comment to T171563: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.).

An alternative approach (which maybe requires less effort on the communit side) would be to refuse loading anything that does not have the appropriate content model, and require editsitejs and similar permissions based on the content model (and on not being in userspace).

Thu, Nov 1, 3:57 PM · Security, Security-team-backlog, MediaWiki-Page-protection, JavaScript
Anomie added a comment to T203433: Viewing first revision via API gives baddiff error.

I'd agree with you if this were a new feature, except this is functionally a regression, in which case I think the correct thing to do is to restore the previous behavior (or emulate it as close to reasonably possible). So I'd prioritize back-compat first since AIUI it wasn't a intended breaking change.

Thu, Nov 1, 3:26 PM · MW-1.32-release, Anti-Harassment, InteractionTimeline, Patch-For-Review, Core Platform Team Kanban (Waiting for Review), Regression, MediaWiki-API, MediaWiki-History-or-Diffs
Anomie added a project to T208472: Block::getTarget() can return a User object or a string that is an invalid user name: Core Platform Team Kanban (Waiting for Review).
Thu, Nov 1, 2:41 PM · TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management
Anomie added a comment to T208472: Block::getTarget() can return a User object or a string that is an invalid user name.

A getTargetUser() method would have to return null for range blocks and auto-blocks, so that seems unlikely to be much of an improvement over the status quo. It might be easier to realize the right thing to do, I suppose.

Thu, Nov 1, 2:39 PM · TechCom, Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-User-management
Anomie added a comment to T208398: Fatal error on testwiki on viewing talk pages when blocked and logged in, and on editing pages when blocked.

ping @Anomie, since this appears to be an interaction between the Actor refactoring and the new "partial block" code. The concept of a "block target" doesn't seem to properly align with the concept of actors.

Thu, Nov 1, 1:45 PM · MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), Patch-For-Review, Anti-Harassment (AHT Sprint 32), MediaWiki-User-management, Regression

Wed, Oct 31

Anomie added a comment to T166733: Deploy refactored comment storage.

The group0 run went much faster, only 55 minutes, as there were many fewer rows: 624213 revision rows, 471326 archive rows, 1675 ipblocks rows, 5712 image rows, 1144 oldimage rows, 1748 filearchive rows, 504043 logging rows, and 91 protected_titles rows.

Wed, Oct 31, 4:36 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T166733: Deploy refactored comment storage.

That initial run of migrateComments.php (with --batch-size 2000) was recorded as taking about 11 hours and processed 2648580 revision rows, 500791 archive rows, 13591293 logging rows, 22539 ipblocks rows, 8824 image rows, 2226 oldimage rows, 30624 filearchive rows, and 564 protected_titles rows (and 0 recentchanges rows).

Wed, Oct 31, 2:03 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)

Mon, Oct 29

Anomie added a comment to T208188: Proposal for partial opt-out method for Content security policy.
  • I wonder whether it would be workable to have a whitelist of domain-regexes that users could enable, rather than the blacklist for Toolforge and Cloud VPS you're talking about.

I guess maybe, but who makes the list? I imagine community would want to vary it over time.

Mon, Oct 29, 8:56 PM · TechCom-RFC, TechCom, Security-Team, Security
Anomie edited projects for T208229: database update script reports duplicate database tables, added: MediaWiki-Installer; removed MediaWiki-API.

Which database backend are you using?

Mon, Oct 29, 8:46 PM · MediaWiki-Installer
Anomie added a comment to T159837: Introduce confirmation step if user tries to register without email.

Don't forget to add something about privacy, it may encourage people to add their email:

We are committed to never selling your information or sharing it with third parties for marketing purposes. Know more about our Privacy Policy.

Mon, Oct 29, 5:41 PM · User-notice, Patch-For-Review, Readers-Web-Backlog (Design), MediaWiki-User-login-and-signup
Anomie moved T208145: api.php?uselang=sr shows language converter syntax in the HTML from Unsorted to Needs Review on the MediaWiki-API board.
Mon, Oct 29, 4:31 PM · MediaWiki-API, Patch-For-Review, MediaWiki-Language-converter, MediaWiki-Parser
Anomie added a project to T208145: api.php?uselang=sr shows language converter syntax in the HTML: MediaWiki-API.
Mon, Oct 29, 4:31 PM · MediaWiki-API, Patch-For-Review, MediaWiki-Language-converter, MediaWiki-Parser
Anomie added a comment to T208145: api.php?uselang=sr shows language converter syntax in the HTML.

I note this came up previously as T74875: Superfluous -{R| }- appears on https://zh.wikipedia.org/w/api.php around links, but that was closed after someone claimed it didn't happen anymore.

Mon, Oct 29, 4:30 PM · MediaWiki-API, Patch-For-Review, MediaWiki-Language-converter, MediaWiki-Parser
Anomie added a comment to T208188: Proposal for partial opt-out method for Content security policy.

Some thoughts:

Mon, Oct 29, 2:11 PM · TechCom-RFC, TechCom, Security-Team, Security
Anomie added a project to T208132: API: extracts with explaintext doesn't put a newline after lists.: TextExtracts.

Possibly the same issue as T201946: Paragraph breaks returned by text API requests have changed.

Mon, Oct 29, 1:28 PM · Readers-Web-Backlog (Tracking), TextExtracts, MediaWiki-API

Fri, Oct 26

Anomie added a comment to T197486: prop=revisions API timing out for a specific user and pages they edited.

I'm pretty sure we're not on 10.1.37 yet.

Fri, Oct 26, 8:02 PM · DBA, MediaWiki-Database, MediaWiki-API
Anomie added a comment to T185904: Special:Upload fails on ":w:" as destination filename.

The same concerns raised in that task still apply.

Fri, Oct 26, 4:41 PM · Multimedia, MediaWiki-Uploading, MediaWiki-API

Thu, Oct 25

Anomie updated subscribers of T166733: Deploy refactored comment storage.

We could start backfilling as soon as Monday, although I have no estimate as to how long it'll take for the scripts to actually run over all the wikis.

Thu, Oct 25, 9:58 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie removed a project from T166733: Deploy refactored comment storage: Patch-For-Review.
Thu, Oct 25, 1:49 PM · MediaWiki-Commenting, Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic, Release-Engineering-Team (Watching / External)
Anomie moved T207818: Mark api.php HTML doc pages as robots noindex, nofollow from Unsorted to Needs Review on the MediaWiki-API board.

I note that Wikimedia sites already have Disallow: /w/ in their robots.txt, but this could benefit third parties.

Thu, Oct 25, 1:37 PM · Core Platform Team Kanban (Done with CPT), MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, MediaWiki-API