Anomie (Brad Jorsch)
User

Projects (14)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (175 w, 6 d)
Availability
Available
LDAP User
Anomie
MediaWiki User
Anomie

Recent Activity

Sat, Feb 17

Anomie removed a project from T187581: MWDebugTest::testAppendDebugInfoToApiResultXmlFormat failing on PHP 7.0 and 7.1 (assertArrayHasKey): MediaWiki-API.

This test has nothing to do with the API.

Sat, Feb 17, 2:59 AM · Patch-For-Review, NewPHP, MediaWiki-Core-Tests
Anomie moved T187603: Add JSON parameter type to the action API from Unsorted to Needs details or plan on the MediaWiki-API board.
Sat, Feb 17, 2:49 AM · MediaWiki-API, Reading-Infrastructure-Team-Backlog, Reading List Service, Epic
Anomie added a comment to T187603: Add JSON parameter type to the action API.

I note we discussed some of this previously in T182475.

Sat, Feb 17, 2:48 AM · MediaWiki-API, Reading-Infrastructure-Team-Backlog, Reading List Service, Epic

Fri, Feb 16

Anomie added a comment to T183457: regex or range search deleted contributions for IP addresses .

MCR itself won't make any difference.

Fri, Feb 16, 8:37 PM · MediaWiki-Special-pages
Anomie added a comment to T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches.

The API is just returning what it gets back from the search engine. For some reason CirrusSearch is returning pages that don't exist.

Fri, Feb 16, 8:19 PM · MediaWiki-API, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog, Discovery-Search, Discovery, CirrusSearch
Anomie moved T186147: [BUG][betalabs] "Uncaught TypeError: Cannot convert undefined or null to object" in some searches from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Fri, Feb 16, 8:19 PM · MediaWiki-API, MobileFrontend (MobileFrontend.js), Readers-Web-Backlog, Discovery-Search, Discovery, CirrusSearch
Anomie added a comment to T185167: Undeletion should allow resetting parent ids.

What exactly is rev_parent_id supposed to be? Just a pointer to the previous revision in the article's history, or a pointer to the revision that this revision was based on, or what? rSVN19843: Revision table tree patch (No objections have been raised so i'm committing… is not clear.

Fri, Feb 16, 5:04 PM · MediaWiki-History-or-Diffs, Multi-Content-Revisions, MediaWiki-Page-deletion
Anomie closed T170029: The requested page title was invalid, empty, or an incorrectly linked inter-language or inter-wiki title. as Resolved.

https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-jessie/19528/console

Fri, Feb 16, 3:49 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), Patch-For-Review, MediaWiki-Core-Tests
Anomie closed T170028: ThrottledErrorTest->testExceptionSetsStatusCode() errors out in jenkins as Resolved.

https://integration.wikimedia.org/ci/job/mediawiki-phpunit-hhvm-jessie/19528/console

Fri, Feb 16, 3:49 PM · Patch-For-Review, MediaWiki-Core-Tests

Thu, Feb 15

Anomie added a comment to T49104: Provide a method to create a non read-only copy of a mw.loadData result.

I think it would be very usefull on Wiktionary, where a language code could be stored for other modules called inside a language section.

Thu, Feb 15, 5:31 PM · MediaWiki-extensions-Scribunto

Wed, Feb 14

Anomie added a project to T177150: Add IP range support to list=usercontribs API: Technical-Debt.

@TBolliger removed a project: Community-Tech.

Wed, Feb 14, 1:25 PM · Community-Tech, Technical-Debt, MediaWiki-API

Tue, Feb 13

Anomie added a comment to T187142: Deduplicate template styles in Parsoid.

VE may not actually want deduplication anyway. If you delete the first transclusion of a template, the styles still need to stay if there are other transclusions. VE could handle this by either not having deduplicated content in the first place or by detecting when a <style data-mw-deduplicate> is being removed and re-duplicate the styles to the first matching <link rel="mw-deduplicated-inline-style"> marker.

Tue, Feb 13, 9:06 PM · Performance-Team (Radar), Parsoid, TemplateStyles
Anomie added a comment to T185355: Normalize change tag schema.

I think either of these (a default of empty string, or nullable) is fine. However, we also need to make the unique indexes non-unique if we make the field nullable, right?

Tue, Feb 13, 5:19 PM · MediaWiki-Database, MediaWiki-Change-tagging, Patch-For-Review, TechCom-RFC
Anomie added a comment to T153182: Perform schema change to add externallinks.el_index_60 to all wikis.

I'm going to guess this has to do with doing order by on a partial index being weird.

Tue, Feb 13, 2:30 PM · Patch-For-Review, Schema-change, Blocked-on-schema-change, DBA
Anomie added a comment to T186977: CentralLogin adds new accounts without any reason.

As I said, I could have used different options when running the script to better match Wikibase's behavior. But unless someone has a time machine they can use to tell me that last week, there's nothing we can do about it now.

Tue, Feb 13, 3:06 AM · MediaWiki-User-login-and-signup
Anomie updated the task description for T187141: Deduplicate template styles in mobileviews API.
Tue, Feb 13, 2:40 AM · Readers-Web-Backlog (Tracking), MobileFrontend, TemplateStyles
Anomie updated the task description for T187142: Deduplicate template styles in Parsoid.
Tue, Feb 13, 2:40 AM · Performance-Team (Radar), Parsoid, TemplateStyles
Anomie added a comment to T186977: CentralLogin adds new accounts without any reason.

It looks like the actual Wikibase code doesn't create SUL accounts where they don't exist, but I might be wrong.

Tue, Feb 13, 2:12 AM · MediaWiki-User-login-and-signup
Anomie added a comment to T186977: CentralLogin adds new accounts without any reason.

Recentchanges entries added to the local wiki for changes Wikidata. Perhaps I could have used different options to link them instead of creating the SUL accounts, but it's in the past now.

Tue, Feb 13, 2:03 AM · MediaWiki-User-login-and-signup

Mon, Feb 12

Anomie added a comment to T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.

We'd also need to make sure any newly-created wikis got the image table alter, at least until we merge a patch to update tables.sql. That's also a concern for T185128, now that I think about it.

Mon, Feb 12, 6:25 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie added a comment to T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.

It looks like there are only 33 wikis that don't need the image table altered for this task, all on s3. We could just do the image table alter on them too, either the same one or leave out the line altering img_description.

Mon, Feb 12, 6:22 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie moved T183398: list=alldeletedrevisions returns pageid=0 instead of ar_page_id from Unsorted to Needs Code on the MediaWiki-API board.
Mon, Feb 12, 5:04 PM · MediaWiki-API
Anomie triaged T183398: list=alldeletedrevisions returns pageid=0 instead of ar_page_id as Lowest priority.
Mon, Feb 12, 5:04 PM · MediaWiki-API
Anomie added a comment to T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.

Something else to consider would be to add the img_description_id and img_actor columns to the image table right away, since we're altering it anyway. We had originally planned to hold off on that because the table is so huge on Commons.

Mon, Feb 12, 5:03 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie updated subscribers of T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.
On IRC, @Marostegui wrote:

<marostegui> May I ask for the alter tables needed?

Mon, Feb 12, 4:53 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie added a comment to T185128: Schema change to prepare for dropping archive.ar_text and archive.ar_flags.

Combining the schema change to fix T187089 with this change might be beneficial from a time standpoint, and IMO T187089 is more important than this one.

Mon, Feb 12, 4:37 PM · Patch-For-Review, DBA, Blocked-on-schema-change, Multi-Content-Revisions, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Schema-change, MediaWiki-Database
Anomie updated the task description for T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.
Mon, Feb 12, 4:36 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie updated the task description for T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW.
Mon, Feb 12, 4:34 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie created P6683 Affected fields and wikis for T187089.
Mon, Feb 12, 4:33 PM
Anomie added a comment to T153182: Perform schema change to add externallinks.el_index_60 to all wikis.

This is how the table looks like after the ALTER:

Mon, Feb 12, 4:30 PM · Patch-For-Review, Schema-change, Blocked-on-schema-change, DBA
Anomie added a comment to T185128: Schema change to prepare for dropping archive.ar_text and archive.ar_flags.

This is how the archive table looks like after the alter:

Mon, Feb 12, 4:27 PM · Patch-For-Review, DBA, Blocked-on-schema-change, Multi-Content-Revisions, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Schema-change, MediaWiki-Database
Anomie triaged T187089: Fix WMF schemas to not break when comment store goes WRITE_NEW as High priority.
Mon, Feb 12, 4:26 PM · Patch-For-Review, Schema-change, DBA, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018)
Anomie added a comment to T186979: Special:ApiSandbox Request URL textbox too small and readonly.

It being read-only is intentional, since editing it would have no effect. If you're wanting to try editing the query directly, edit the browser's URL bar.

Mon, Feb 12, 3:42 PM · MediaWiki-API
Anomie moved T186979: Special:ApiSandbox Request URL textbox too small and readonly from Unsorted to Non-Code on the MediaWiki-API board.
Mon, Feb 12, 3:41 PM · MediaWiki-API
Anomie closed T186982: Add API action=parse example that works for more than a few lines, e.g., a file (solution attached) as Declined.

The action API examples are for use with ApiSandbox, and (where possible) by executing a GET request in a browser. A Linux-command-line example is out of place.

Mon, Feb 12, 3:34 PM · Documentation, MediaWiki-API
Anomie moved T186982: Add API action=parse example that works for more than a few lines, e.g., a file (solution attached) from Unsorted to Non-Code on the MediaWiki-API board.
Mon, Feb 12, 3:34 PM · Documentation, MediaWiki-API
Anomie added a comment to T186983: Mention units on apihighlimits.

Maximum values for "limit" parameters, and number of items for multi-valued parameters.

Mon, Feb 12, 3:32 PM · Documentation, MediaWiki-API
Anomie moved T186983: Mention units on apihighlimits from Unsorted to Non-Code on the MediaWiki-API board.
Mon, Feb 12, 3:31 PM · Documentation, MediaWiki-API
Anomie updated subscribers of T187079: Cannot query contributions of interwiki usernames.
Mon, Feb 12, 3:28 PM · Patch-For-Review, MediaWiki-API, MediaWiki-Special-pages
Anomie moved T187079: Cannot query contributions of interwiki usernames from Unsorted to Needs Review on the MediaWiki-API board.
Mon, Feb 12, 3:13 PM · Patch-For-Review, MediaWiki-API, MediaWiki-Special-pages
Anomie created T187079: Cannot query contributions of interwiki usernames.
Mon, Feb 12, 3:11 PM · Patch-For-Review, MediaWiki-API, MediaWiki-Special-pages

Sun, Feb 11

Anomie added a comment to T181731: Run maintenance/cleanupUsersWithNoId.php on all wikis.

Would we able to undo the results of this script or reconfigure it for the Nostalgia Wikipedia?

Sun, Feb 11, 9:51 PM · Wikimedia-Site-requests, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), User-notice, Wikimedia-maintenance-script-run
Anomie added a comment to T185623: Use background and background-* properties.

Better error messages about URL whitelist misses would be nice, but probably hard. I think this was discussed in the past but can't remember the details.

Sun, Feb 11, 3:56 PM · css-sanitizer, TemplateStyles
Anomie closed T186240: Clarify handling of integer array indexes in Scribunto and php-luasandbox as Resolved.
Sun, Feb 11, 3:01 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, LuaSandbox, MediaWiki-extensions-Scribunto
Anomie closed T168333: CSS is duplicated on each template usage as Resolved.

Nothing more is going to need to be done in TemplateStyles for Parsoid or mobileview. They'll need to do the equivalent of T160563: Provide infrastructure for embedding styles in the content HTML with deduplication / rMW9b2b375fcef1: ParserOutput: Add 'deduplicateStyles' post-cache transformation, for which separate tasks should be filed if necessary.

Sun, Feb 11, 2:39 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Performance-Team (Radar), Patch-For-Review, Technical-Debt, TemplateStyles
Anomie closed T160563: Provide infrastructure for embedding styles in the content HTML with deduplication as Resolved.

Infrastructure is provided, so resolving. Note the final implementation differs significantly from the straw proposal in the description.

Sun, Feb 11, 2:33 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Performance-Team (Radar), Readers-Web-Backlog (Tracking), Reading-Infrastructure-Team-Backlog, Patch-For-Review, MobileFrontend, Mobile-Content-Service, Performance, Parsoid, MediaWiki-Parser, MediaWiki-ResourceLoader
Anomie closed T160563: Provide infrastructure for embedding styles in the content HTML with deduplication, a subtask of T168333: CSS is duplicated on each template usage, as Resolved.
Sun, Feb 11, 2:33 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Performance-Team (Radar), Patch-For-Review, Technical-Debt, TemplateStyles
Anomie added a comment to T186977: CentralLogin adds new accounts without any reason.

From the timing these accounts seem to be created by some sort of maintenance script, possibly T181731: Run maintenance/cleanupUsersWithNoId.php on all wikis (@Anomie any thoughts?)

Sun, Feb 11, 2:30 PM · MediaWiki-User-login-and-signup
Anomie closed T179832: Handling of imported usernames as Resolved.

This has been implemented, I think we can close it now.

Sun, Feb 11, 2:26 PM · TechCom-RFC (TechCom-Approved)

Sat, Feb 10

Anomie closed T9240: Usernames in history of imported pages should refer to original wiki as Resolved.
Sat, Feb 10, 4:34 PM · Patch-For-Review, MediaWiki-Export-or-Import
Anomie closed T9240: Usernames in history of imported pages should refer to original wiki, a subtask of T87268: Copyright license and attribution issues (tracking), as Resolved.
Sat, Feb 10, 4:34 PM · Tracking, WMF-Legal
Anomie closed T181731: Run maintenance/cleanupUsersWithNoId.php on all wikis as Resolved.
Sat, Feb 10, 4:34 PM · Wikimedia-Site-requests, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), User-notice, Wikimedia-maintenance-script-run
Anomie closed T181731: Run maintenance/cleanupUsersWithNoId.php on all wikis, a subtask of T9240: Usernames in history of imported pages should refer to original wiki, as Resolved.
Sat, Feb 10, 4:34 PM · Patch-For-Review, MediaWiki-Export-or-Import
Anomie closed T181731: Run maintenance/cleanupUsersWithNoId.php on all wikis, a subtask of T179832: Handling of imported usernames, as Resolved.
Sat, Feb 10, 4:34 PM · TechCom-RFC (TechCom-Approved)
Anomie created T186965: Output HTML should not contain `<p><style>...</style></p>`.
Sat, Feb 10, 4:27 PM · RemexHtml, Parsoid, MediaWiki-Parser
Anomie added a comment to T185623: Use background and background-* properties.

Try using "https://upload.wikimedia.org/wikipedia/commons/f/f7/Loudspeaker.png" as the URL.

Sat, Feb 10, 2:46 AM · css-sanitizer, TemplateStyles

Fri, Feb 9

Anomie added a comment to T186905: Weird entries in CN Banner content log.

My fault, in rECNOa3e8074f9b12: Use CommentStore to access core comment fields when available. IndexPager wants getQueryInfo() to return $ret['join_conds'] for the join conditions, but I named it $ret['joins'] instead.

Fri, Feb 9, 7:23 PM · Fundraising Sprint Cottage Cheese isn't Made of Cottages, Patch-For-Review, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Anomie added a comment to T186831: Login page does not link to registration page when a login attempt results in a RESTART response.

Ok, I think I see what's going on here.

Fri, Feb 9, 6:46 PM · User-Tgr, MediaWiki-Authentication-and-authorization
Anomie added a comment to T166733: Deploy refactored comment storage.

It's truncated in advance. In case you're curious, the specific place that happens is CommentStore.php line 533.

Fri, Feb 9, 3:38 PM · Patch-For-Review, User-notice, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T186839: Divide by zero in PRSquare .

TL;DR: Changes to wikimedia/running-stat between the version included in wmf.17 and the version included in wmf.20 broke PHP serialization compatibility in a non-obvious way, and this error message is part of the fallout.

Fri, Feb 9, 3:15 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Regression, Wikimedia-log-errors
Anomie removed projects from T186839: Divide by zero in PRSquare : MediaWiki-extensions-Scribunto, MediaWiki-API.

This seems to have nothing to do with the API, here's one that's not via the API at all:

#0 /srv/mediawiki/php-1.31.0-wmf.20/vendor/wikimedia/running-stat/src/Wikimedia/PSquare.php(159): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.31.0-wmf.20/vendor/wikimedia/running-stat/src/Wikimedia/PSquare.php(123): Wikimedia\PSquare->computeParabolic(integer, integer)
#2 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/common/Hooks.php(218): Wikimedia\PSquare->addObservation(integer)
#3 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/common/Hooks.php(135): ScribuntoHooks::reportTiming(string, string, integer)
#4 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3407): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#5 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3108): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#6 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Preprocessor_Hash.php(1102): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#7 /srv/mediawiki/php-1.31.0-wmf.20/extensions/ParserFunctions/ParserFunctions_body.php(123): PPFrame_Hash->expand(PPNode_Hash_Tree)
#8 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3407): ExtParserFunctions::ifeqObj(Parser, PPTemplateFrame_Hash, array)
#9 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3108): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#10 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Preprocessor_Hash.php(1102): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#11 /srv/mediawiki/php-1.31.0-wmf.20/extensions/ParserFunctions/ParserFunctions_body.php(125): PPFrame_Hash->expand(PPNode_Hash_Tree)
#12 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3407): ExtParserFunctions::ifeqObj(Parser, PPTemplateFrame_Hash, array)
#13 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3108): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#14 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Preprocessor_Hash.php(1102): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#15 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/engines/LuaCommon/LuaCommon.php(889): PPFrame_Hash->expand(PPNode_Hash_Tree)
#16 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/engines/LuaCommon/LuaCommon.php(724): Scribunto_LuaEngine->doCachedExpansion(PPTemplateFrame_Hash, PPNode_Hash_Tree, array)
#17 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/engines/LuaSandbox/Engine.php(385): Scribunto_LuaEngine->expandTemplate(string, string, array)
#18 [internal function]: Scribunto_LuaSandboxCallback->__call(string, array)
#19 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/engines/LuaSandbox/Engine.php(313): LuaSandboxFunction->call(LuaSandboxFunction)
#20 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/engines/LuaCommon/LuaCommon.php(296): Scribunto_LuaSandboxInterpreter->callFunction(LuaSandboxFunction, LuaSandboxFunction)
#21 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/engines/LuaCommon/LuaCommon.php(963): Scribunto_LuaEngine->executeFunctionChunk(LuaSandboxFunction, PPTemplateFrame_Hash)
#22 /srv/mediawiki/php-1.31.0-wmf.20/extensions/Scribunto/common/Hooks.php(127): Scribunto_LuaModule->invoke(string, PPTemplateFrame_Hash)
#23 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3407): ScribuntoHooks::invokeHook(Parser, PPTemplateFrame_Hash, array)
#24 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3108): Parser->callParserFunction(PPTemplateFrame_Hash, string, array)
#25 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Preprocessor_Hash.php(1102): Parser->braceSubstitution(array, PPTemplateFrame_Hash)
#26 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(3286): PPFrame_Hash->expand(PPNode_Hash_Tree)
#27 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Preprocessor_Hash.php(1102): Parser->braceSubstitution(array, PPFrame_Hash)
#28 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(2923): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#29 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(1282): Parser->replaceVariables(string)
#30 /srv/mediawiki/php-1.31.0-wmf.20/includes/parser/Parser.php(443): Parser->internalParse(string)
#31 /srv/mediawiki/php-1.31.0-wmf.20/includes/content/WikitextContent.php(329): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#32 /srv/mediawiki/php-1.31.0-wmf.20/includes/content/AbstractContent.php(516): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#33 /srv/mediawiki/php-1.31.0-wmf.20/includes/poolcounter/PoolWorkArticleView.php(145): AbstractContent->getParserOutput(Title, integer, ParserOptions)
#34 /srv/mediawiki/php-1.31.0-wmf.20/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#35 /srv/mediawiki/php-1.31.0-wmf.20/includes/page/Article.php(597): PoolCounterWork->execute()
#36 /srv/mediawiki/php-1.31.0-wmf.20/includes/actions/ViewAction.php(68): Article->view()
#37 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(500): ViewAction->show()
#38 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#39 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(858): MediaWiki->performRequest()
#40 /srv/mediawiki/php-1.31.0-wmf.20/includes/MediaWiki.php(524): MediaWiki->main()
#41 /srv/mediawiki/php-1.31.0-wmf.20/index.php(42): MediaWiki->run()
#42 /srv/mediawiki/w/index.php(3): include(string)
#43 {main}
Fri, Feb 9, 3:13 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, Regression, Wikimedia-log-errors

Thu, Feb 8

Anomie added a comment to T166733: Deploy refactored comment storage.

The only feedback I'm really looking for is "oh crap something broke".

Thu, Feb 8, 10:30 PM · Patch-For-Review, User-notice, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, Release-Engineering-Team (Watching / External)
Anomie closed T186831: Login page does not link to registration page when a login attempt results in a RESTART response as Invalid.

This is not true, the link is still there. A "create account" link is also still present next to the "log in" link on every page (unless the wiki has $wgUseCombinedLoginLink set, or a skin that forces something similar). Also, users can still go directly to Special:CreateAccount.

Thu, Feb 8, 10:29 PM · User-Tgr, MediaWiki-Authentication-and-authorization
Anomie edited projects for T166733: Deploy refactored comment storage, added: User-notice; removed Patch-For-Review.

It may be time to mention this in Tech News. Perhaps something like this

Thu, Feb 8, 10:12 PM · Patch-For-Review, User-notice, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T160993: MysqlUpdater::doWatchlistUpdate is very slow.

Perhaps more interesting would be the output of

SELECT DISTINCT w1.wl_namespace, w1.wl_title FROM bw_watchlist w1 LEFT JOIN bw_watchlist w2 ON ((w1.wl_namespace ^ 1) = w2.wl_namespace AND w1.wl_title = w2.wl_title) WHERE w2.wl_id IS NULL;

That should tell us which entries, specifically, are missing from the database.

Thu, Feb 8, 8:19 PM · Patch-For-Review, Performance, MediaWiki-Database
Anomie added a comment to T160993: MysqlUpdater::doWatchlistUpdate is very slow.

Pinging @Legoktm and @Anomie because https://gerrit.wikimedia.org/r/c/406308/ might be related.

Thu, Feb 8, 7:25 PM · Patch-For-Review, Performance, MediaWiki-Database
Anomie moved T186766: MW api list=blocks doesn't return very old blocks where ipb_range_start is empty from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Thu, Feb 8, 5:53 PM · MediaWiki-Maintenance-scripts, MediaWiki-User-management, MediaWiki-API
Anomie added a project to T186766: MW api list=blocks doesn't return very old blocks where ipb_range_start is empty: MediaWiki-User-management.

IMO the proper fix is for someone to write and execute a maintenance script to populate the ipb_range_start and ipb_range_end fields for such blocks.

Thu, Feb 8, 5:53 PM · MediaWiki-Maintenance-scripts, MediaWiki-User-management, MediaWiki-API

Wed, Feb 7

Anomie added a comment to T180394: MediaWiki entry points should not be in the base repo directory.

I file this mainly because it kept getting mentioned but we didn't have a task for it. I'd be happy for someone else to actually push it forward.

Wed, Feb 7, 9:59 PM · TechCom-RFC, MediaWiki-General-or-Unknown
Anomie updated the task description for T166733: Deploy refactored comment storage.
Wed, Feb 7, 5:06 PM · Patch-For-Review, User-notice, MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Epic, Release-Engineering-Team (Watching / External)
Anomie added a comment to T153182: Perform schema change to add externallinks.el_index_60 to all wikis.

This has been waiting since December 2016, a little more time won't hurt anything.

Wed, Feb 7, 3:45 PM · Patch-For-Review, Schema-change, Blocked-on-schema-change, DBA
Anomie added a comment to T115890: Reduce and clarify ObjectCache entry points.

It seems to me that one useful improvement to the caching situation would be for there to be one interface rather than two similar but incompatible interfaces (WANObjectCache and BagOStuff).

Wed, Feb 7, 2:55 PM · Performance-Team (Radar), MediaWiki-Configuration, MediaWiki-Platform-Team, Technical-Debt, MediaWiki-Cache
Anomie added a comment to T174569: Schema change for refactored comment storage.

I just deleted two revisions on testwiki, ar_id 90260 and 90261. Let me know if you need more.

Wed, Feb 7, 2:15 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Patch-For-Review, Dumps-Generation, Data-Services, Blocked-on-schema-change, DBA

Tue, Feb 6

Anomie claimed T186240: Clarify handling of integer array indexes in Scribunto and php-luasandbox.
Tue, Feb 6, 10:22 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, LuaSandbox, MediaWiki-extensions-Scribunto
Anomie added a comment to T186556: Add a parameter Usercontribs API to limit results to contributions to pages that a list of users have edited.

Note that the Toolforge replicas, particularly the "analytics" replicas, have greater leeway for inefficient queries than the production databases do. He probably can get away with the straightforward query that filters at the database level but might touch millions of rows there.

Tue, Feb 6, 3:29 PM · MediaWiki-API
Anomie added a comment to T174569: Schema change for refactored comment storage.

I am still placing all the triggers on sanitariums, I will probably ask you soon to see if it is possible to generate some writes on a given wiki to make sure the filters are correctly in place for the ar_comment_id column which is the only one filtered.
Is that something doable from your side?

Tue, Feb 6, 2:57 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Patch-For-Review, Dumps-Generation, Data-Services, Blocked-on-schema-change, DBA
Anomie added a comment to T174569: Schema change for refactored comment storage.

The last host, s8 master finished the alter table.

Tue, Feb 6, 2:23 PM · MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Patch-For-Review, Dumps-Generation, Data-Services, Blocked-on-schema-change, DBA
Anomie moved T186573: Add information about hidden fields (e.g., userhidden, commenthidden, sha1hidden, etc.) to api.php documentation from Unsorted to Non-Code on the MediaWiki-API board.
Tue, Feb 6, 2:15 PM · Easy, MediaWiki-API, Documentation, MediaWiki-Documentation
Anomie added a project to T186573: Add information about hidden fields (e.g., userhidden, commenthidden, sha1hidden, etc.) to api.php documentation: MediaWiki-API.
Tue, Feb 6, 2:15 PM · Easy, MediaWiki-API, Documentation, MediaWiki-Documentation
Anomie updated subscribers of T186573: Add information about hidden fields (e.g., userhidden, commenthidden, sha1hidden, etc.) to api.php documentation.

We don't normally do much to describe the output fields. But if we want to do this, it would probably be most appropriate to describe them in the relevant prop option documentation.

Tue, Feb 6, 2:15 PM · Easy, MediaWiki-API, Documentation, MediaWiki-Documentation
Anomie committed rETSTf99d171c804f: Fix coverage (authored by Anomie).
Fix coverage
Tue, Feb 6, 3:38 AM
Anomie committed rETSTf72e12f25b9f: Fix coverage (authored by Anomie).
Fix coverage
Tue, Feb 6, 3:02 AM
Anomie committed rETSTb46e35ae5c97: Deduplicate embedded style rules (authored by Anomie).
Deduplicate embedded style rules
Tue, Feb 6, 2:34 AM
Anomie added a comment to T186556: Add a parameter Usercontribs API to limit results to contributions to pages that a list of users have edited.

The problem isn't a parameter, the problem is doing this in a way that won't let one request blow up the databases.

Tue, Feb 6, 1:55 AM · MediaWiki-API

Mon, Feb 5

Anomie moved T186556: Add a parameter Usercontribs API to limit results to contributions to pages that a list of users have edited from Unsorted to Needs details or plan on the MediaWiki-API board.
Mon, Feb 5, 10:12 PM · MediaWiki-API
Anomie triaged T186556: Add a parameter Usercontribs API to limit results to contributions to pages that a list of users have edited as Low priority.

This seems like a strange special case, but as stated it would be possible with caveats. I have to reject the direct approach unless the DBAs tell me it's ok if the query potentially has to touch millions of rows in some cases (i.e. bugs like T97797).

Mon, Feb 5, 10:11 PM · MediaWiki-API
Anomie added a watcher for LuaSandbox: Anomie.
Mon, Feb 5, 6:41 PM
Anomie added a comment to T185948: Update web UI for increased comment length.

Is there a reason why CommentStore::COMMENT_CHARACTER_LIMIT (the magical "1000" value) is a constant rather than a configuration variable?

Mon, Feb 5, 5:53 PM · User-notice, Patch-For-Review, VisualEditor, MediaWiki-User-management, MediaWiki-Page-deletion, MediaWiki-Page-protection, MediaWiki-Page-editing
Anomie committed rETST3882efa5d532: Deduplicate embedded style rules (authored by Anomie).
Deduplicate embedded style rules
Mon, Feb 5, 4:43 PM
Anomie added a comment to T143389: [Bug] Scribunto_LuaSandboxTests repeatedly fails because it relies on code execution time.

Does rELUA12acfa95efd9: Make Scribunto_LuaSandboxTests::testArgumentParsingTime more robust seem to have fixed this for you, i.e. can we close this now?

Mon, Feb 5, 3:02 PM · LuaSandbox, MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Patch-For-Review, Wikidata-Sprint-2016-08-16, MediaWiki-extensions-Scribunto, Wikidata

Sat, Feb 3

Anomie created T186428: Page protection cache is not cleared across deletion and undeletion.
Sat, Feb 3, 10:06 PM · MediaWiki-Page-protection
Anomie added a comment to T186390: Javascript preview feature broken when live previews are enabled.

@Anomie I wonder how this could work with https://gerrit.wikimedia.org/r/#/c/340768 which adds a way for extensions to influence the preview

Sat, Feb 3, 6:16 PM · JavaScript, MediaWiki-Page-editing

Fri, Feb 2

Anomie closed T181846: Use post-cache transforms to remove `wrapclass` from the parser cache key as Resolved.
Fri, Feb 2, 8:22 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), Patch-For-Review, MediaWiki-Cache, MediaWiki-Parser
Anomie closed T186091: LuaSandbox's Data type round-tripping [tests/datatypes.phpt] fails with PHP 7.2 as Resolved.
Fri, Feb 2, 4:00 PM · Patch-For-Review, NewPHP, MediaWiki-extensions-Scribunto
Anomie awarded T186302: Promote LuaSandbox as its own project, separate from Scribunto a Like token.
Fri, Feb 2, 3:17 PM · LuaSandbox, Librarization, MediaWiki-extensions-Scribunto
Anomie added a comment to T186303: Librarize LuaSandbox/LuaStandalone.

At a quick look, Scribunto_LuaStandaloneInterpreter + Scribunto_LuaStandaloneInterpreterFunction seems like the bit that would be usefully split into a separate library, along with the non-PHP files in the engines/LuaStandalone/ directory. The Engine class is where we get into a lot of MediaWiki-specific code.

Fri, Feb 2, 3:17 PM · LuaSandbox, Librarization, MediaWiki-extensions-Scribunto

Thu, Feb 1

Anomie created T186269: BenchmarkerTest division by zero.
Thu, Feb 1, 9:25 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Performance-Team (Radar), MediaWiki-Core-Tests
Anomie added a comment to T184171: CommandTest failing from time to time.

I ran into a similar bug today: this test was seeming to hang and I killed it. Probably it would eventually have timed out and given the failure here.

Thu, Feb 1, 7:22 PM · MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)), Patch-For-Review, MediaWiki-Core-Tests, MediaWiki-Shell
Anomie updated the task description for T186240: Clarify handling of integer array indexes in Scribunto and php-luasandbox.
Thu, Feb 1, 5:20 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, LuaSandbox, MediaWiki-extensions-Scribunto
Anomie added a comment to T186240: Clarify handling of integer array indexes in Scribunto and php-luasandbox.

Although, I might decide to take advantage of Zend PHP's unserialize() doing the right thing when given stringified integers as keys and let HHVM continue to be broken in this edge case until we drop HHVM support.

Thu, Feb 1, 5:18 PM · MW-1.31-release-notes (WMF-deploy-2018-02-13 (1.31.0-wmf.21)), Patch-For-Review, LuaSandbox, MediaWiki-extensions-Scribunto