Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (223 w, 15 h)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Yesterday

Anomie added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

The first instance looks like a race condition including a 3rd party client (bot). E.g. bot makes and edit, and immediately tries to load the revision. Or a bot lists revisions, and then tries to load their content by ID, in a different request, hitting a different replica that is more lagged.

Tue, Jan 15, 9:58 PM · Multi-Content-Revisions (Reactive), Core Platform Team Kanban, Core Platform Team (MCR), Wikimedia-production-error, MediaWiki-General-or-Unknown
Anomie added a comment to T213858: s3 master emergency failover (db1075).

Thanks for letting me know about the failover. It will probably kill the script anyway when the old master goes away, or at least whichever s3 wiki it happens to be processing at the time.

Tue, Jan 15, 9:40 PM · DBA, Operations
Anomie added a comment to T210739: Target deletion during page move fails.

I tried to test this on my wiki, and it succeeded 3-4 times in a row. I wonder if this could be due to some race condition...

Tue, Jan 15, 5:39 PM · Patch-For-Review, Multimedia, Commons, MediaWiki-File-management, Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Special-pages, Wikimedia-production-error
Anomie added a comment to T213796: Global rename of SuperVirtual → Dennis Radaelli: supervision needed.

Let's add @Anomie here once so he can verify this didn't affect ongoing actor migration as per https://wikitech.wikimedia.org/wiki/Deployments#Week_of_January_14th

Tue, Jan 15, 2:31 PM · DBA, Wikimedia-Site-requests

Mon, Jan 14

Anomie added a comment to T188327: Deploy refactored actor storage.

Weirdnesses encountered so far:

  • On enwiki, apparently some import of pre-2006 revisions created several rows with IP addresses in rev_user_text and non-zero (but non-existent) user IDs in rev_user. I manually zeroed those rev_users.
  • A few instances where rev_user had a non-zero ID that didn't exist in user. Some on enwiki like the above bullet, others that seem like weird one-offs. I'll likely fix these manually too, by either assigning the correct user ID if the name exists or prefixing with unknown> if it doesn't.
Mon, Jan 14, 10:19 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), Epic
Anomie added a comment to T213587: Permit url("data:image/svg+xml,...") in CSS Sanitizer if no external access.

May be this task is to be turned into Security Issue.

Mon, Jan 14, 10:10 PM · TemplateStyles
Anomie closed T213749: Enable TemplateStyles for Urdu Wikipedia (urwiki) as Invalid.

It already is enabled there, since August 2018 (rOMWC783c513b7b6f: Enable TemplateStyles everywhere).

Mon, Jan 14, 7:35 PM · Wikimedia-Site-requests, TemplateStyles
Anomie added a project to T208901: TemplateStyles breaks a paragraph if a file is inserted inline: RemexHtml.

After some experimentation, the issue seems to be in RemexHtml when it's adding the wrapping <p> tags:

anomie@mwmaint1002:~$ mwrepl enwiki
hphpd> $tidy = new MediaWiki\Tidy\RemexDriver( $wgTidyConfig );
hphpd> =$tidy->tidy( '<p>foo <style>/* ... */</style> bar</p>' );
"<p>foo <style>/* ... */</style> bar</p>"
hphpd> =$tidy->tidy( 'foo <style>/* ... */</style> bar' );
"<p>foo </p><style>/* ... */</style><p> bar</p>"
hphpd> =$tidy->tidy( '<div>foo <style>/* ... */</style> bar</div>' ); 
"<div>foo <style>/* ... */</style> bar</div>"
hphpd> =$tidy->tidy( '<blockquote>foo <style>/* ... */</style> bar</blockquote>' );
"<blockquote><p>foo </p><style>/* ... */</style><p> bar</p></blockquote>"

So any wikitext construct that causes the Parser to not output <p> tags itself around something Remex will add <p> tags to will result in this bug. In T208901#4726406 it's the <div> from the image syntax, while in T208901#4855856 with the <ref> added it's the <div> around the auto-generated reference list that winds up appended to the end of the paragraph there.

Mon, Jan 14, 4:49 PM · Parsoid, TemplateStyles, MediaWiki-Parser
Anomie added a watcher for TemplateStyles: Anomie.
Mon, Jan 14, 3:28 PM
Anomie triaged T213587: Permit url("data:image/svg+xml,...") in CSS Sanitizer if no external access as Lowest priority.

css-sanitizer by default allows all URLs. It also allows for users of the library to subclass Wikimedia\CSS\Grammar\MatcherFactory and override ->urlstring() and ->url() to provide matchers that filter the allowed URLs.

Mon, Jan 14, 3:26 PM · TemplateStyles
Anomie added a comment to T213613: The test timer.phpt fails in luasandbox.

The failing test should have generated a file tests/timer.log. Please provide the contents of that file.

Mon, Jan 14, 3:11 PM · LuaSandbox
Anomie closed T213437: Segfault in mediawiki-vagrant and php-luasandbox as Declined.
In T213437#4874877, jeblad wrote:

jeblad removed a subscriber: jeblad.

Mon, Jan 14, 2:59 PM · MediaWiki-Vagrant, MediaWiki-extensions-Scribunto

Sat, Jan 12

Anomie closed T212980: ImageListPager is broken again (miser mode and comment migration stage NEW) as Resolved.
Sat, Jan 12, 8:00 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Core Platform Team Kanban (Waiting for Review), MediaWiki-Special-pages
Anomie added a project to T213489: 'Warning: session_id(): Cannot change session id when session is active' intermittently on php7.3: Core Platform Team Kanban (Waiting for Review).
Sat, Jan 12, 7:56 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.3 support
Anomie added a comment to T213489: 'Warning: session_id(): Cannot change session id when session is active' intermittently on php7.3.

I can reproduce this with Firefox 64 by logging in with "Remember me" checked and using the Storage Inspector (Shift+F9) to delete the mywiki_session cookie.

Sat, Jan 12, 7:55 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, MediaWiki-General-or-Unknown, PHP 7.3 support
Anomie merged Restricted Task into T150421: Provide a sender email address alias for use in Special:Emailuser (aka 2-way email relay).
Sat, Jan 12, 4:46 PM · Anti-Harassment, Privacy, Trust-and-Safety, Mail, MediaWiki-Email

Fri, Jan 11

Anomie added a comment to T210739: Target deletion during page move fails.

Looks like something started triggering it again. Did that bot re-start or something?

archive/exception.log-20190105.gz:0
archive/exception.log-20190106.gz:0
archive/exception.log-20190107.gz:0
archive/exception.log-20190108.gz:0
archive/exception.log-20190109.gz:4
archive/exception.log-20190110.gz:24
archive/exception.log-20190111:208
exception.log:114
Fri, Jan 11, 2:27 PM · Patch-For-Review, Multimedia, Commons, MediaWiki-File-management, Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Special-pages, Wikimedia-production-error
Anomie added a comment to T213494: Installing composer modules for deployment.

For WMF deployments of MediaWiki, we use the mediawiki/vendor repo for the composer libraries in what sounds like much the same way as you use mediawiki/services/parsoid/deploy. When we get to the point of pulling the Parsoid-PHP library into MediaWiki, that's how it'll be done to deploy to Beta and prod.

Fri, Jan 11, 2:20 PM · Parsoid-PHP

Thu, Jan 10

Anomie added a comment to T213453: AbuseFilter MCR diff is comparing old value of one slot with the new value from another, not the old whole page with the new whole page.

Those 2 patches show roughly the evilness I was thinking about in T213453#4870354. They are here to get some more eyes and thoughts (untested right now).

Thu, Jan 10, 6:48 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), User-Addshore, SDC Engineering, Core Platform Team (MCR), AbuseFilter
Anomie updated subscribers of T213453: AbuseFilter MCR diff is comparing old value of one slot with the new value from another, not the old whole page with the new whole page.

Looks like in rEABF688eccea477a: Expose text from all slots to AbuseFilter @daniel fixed loading of old_wikitext and new_wikitext for the code path that goes via AFComputedVariable, e.g. for AbuseFilter::getEditVarsFromRCRow(). But that change overlooked where they get set in AbuseFilterHooks::newVariableHolderForEdit(), which is probably being called here via the 'EditFilterMergedContent' hook,[1] which doesn't seem to even get passed the slot.

Thu, Jan 10, 5:12 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), User-Addshore, SDC Engineering, Core Platform Team (MCR), AbuseFilter
Anomie changed the status of T213437: Segfault in mediawiki-vagrant and php-luasandbox from Open to Stalled.

Neither @Reedy nor I have been able to reproduce the segfault, e.g. as reported in T212950#4869625.

Thu, Jan 10, 2:50 PM · MediaWiki-Vagrant, MediaWiki-extensions-Scribunto
Anomie closed T212950: Luasandbox not loaded under PHP 7.2 Vagrant with Scribunto enabled as Resolved.

This is getting confusing. The original bug here was solved with rMWVA4e7a250ec503: Stop pinning php-luasandbox. Filing T213437: Segfault in mediawiki-vagrant and php-luasandbox for the segfault.

Thu, Jan 10, 2:48 PM · MediaWiki-Vagrant, MediaWiki-extensions-Scribunto
Anomie created T213437: Segfault in mediawiki-vagrant and php-luasandbox.
Thu, Jan 10, 2:48 PM · MediaWiki-Vagrant, MediaWiki-extensions-Scribunto
Anomie added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.

The point is to avoid having filters like "outputpage_render( OutputPage )" which don't relate to a tangible value, but a point in time ("event") given a monolithic object. Instead, I think these should have more granular filters like "outputpage_htmltitle( string $tilte, TitleValue, string $action )", "outputpage_bodyclass", ""outputpage_modules", which have a dedicated purpose and a limited set of factors by which we support their variance. The problems with monolithic hooks are reflected in the problem statement and objectives.

Thu, Jan 10, 2:40 PM · Performance-Team (Radar), TechCom-RFC, TechCom
Anomie added a comment to T212950: Luasandbox not loaded under PHP 7.2 Vagrant with Scribunto enabled.

Occams razor would imply php-sandbox has a bug or triggers a bug inside the virtual environment.

Thu, Jan 10, 2:24 PM · MediaWiki-Vagrant, MediaWiki-extensions-Scribunto
Anomie added a comment to T209590: HTTP/2 requests fail with too-long URLs.

Firefox 64 and Chromium 72 also react to the "enhance your calm" as a dropped connection rather than as a 414.

Thu, Jan 10, 2:12 PM · Patch-For-Review, Traffic, Operations

Wed, Jan 9

Anomie added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.

That would violate the principle and not be allowed under this RFC (as currently drafted). But, I understand your reasoning of course, and they're important concerns to think about.

Wed, Jan 9, 10:58 PM · Performance-Team (Radar), TechCom-RFC, TechCom
Anomie raised the priority of T212972: Remove reference to text fields replaced by the comment table from WMCS views from Low to Needs Triage.
Wed, Jan 9, 6:16 PM · Data-Services, Core Platform Team Backlog (Watching / External)
Anomie added a comment to T212972: Remove reference to text fields replaced by the comment table from WMCS views.

That's out of scope for this task. T212617 is the task for that.

Wed, Jan 9, 6:15 PM · Data-Services, Core Platform Team Backlog (Watching / External)
Anomie added a comment to T212617: archive_userindex view not updated to include ar_comment_id.

While this should be fixed for schema consistency, I note that

Wed, Jan 9, 6:14 PM · Data-Services
Anomie reopened T209590: HTTP/2 requests fail with too-long URLs as "Open".

Confirmed. The URLs described earlier work now, and there's even a range of URLs that give a 414 from Apache with HTTP/2 now, but I still get a dropped connection for a request such as curl --http2 -v "https://en.wikipedia.org/wiki/Main_Page?_=$(printf 'x%.0s' {1..10000})".

Wed, Jan 9, 3:23 PM · Patch-For-Review, Traffic, Operations
Anomie closed T213168: Move file page to new name that exists on commons throws Wikimedia\Rdbms\DBTransactionStateError on zhwiki as Resolved.

The fix should be deployed to Wikimedia wikis with 1.33.0-wmf.13, see https://www.mediawiki.org/wiki/MediaWiki_1.33/Roadmap for a schedule. If anyone thinks it's important enough to deploy sooner, you're welcome to follow the process described at https://wikitech.wikimedia.org/wiki/SWAT_deploys#How_to_submit_a_patch_for_SWAT.

Wed, Jan 9, 3:00 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages
Anomie added a comment to T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid.

I note that Parsoid probably currently ignores things such as ParserOptions::getCurrentRevisionCallback() which are used in various places (e.g. previews, MediaWiki-extensions-TemplateSandbox) to affect parses for previews and such. To replace the existing PHP Parser, implementations of the interface described here will need to take those sorts of things into account when fetching template contents.

Wed, Jan 9, 2:44 PM · Parsoid-PHP
Anomie updated the task description for T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid.
Wed, Jan 9, 2:35 PM · Parsoid-PHP
Anomie added projects to T213221: API Analytics - page views by country: PageViewInfo, Pageviews-API.
Wed, Jan 9, 2:31 PM · Pageviews-API, PageViewInfo, Analytics, MediaWiki-API
Anomie committed rCSSSba90bd7cc284: Use composer's PSR-4 auto-loading (authored by Anomie).
Use composer's PSR-4 auto-loading
Wed, Jan 9, 12:35 AM

Tue, Jan 8

Anomie added a comment to T212511: Deprecate comparing first revision to prev, last revision to next in API.

@Anomie There shouldn't be a significant performance difference between revision-as-diff and compare, except for the first revision.

Tue, Jan 8, 6:57 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie added a comment to T166733: Deploy refactored comment storage.

(It seems that the revision_comment_temp table has already been dropped on enwiki, i.e. the corresponding statement there would be outdated.)

Tue, Jan 8, 3:22 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Commenting, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic
Anomie added a comment to T210739: Target deletion during page move fails.

Still happens, see T213168

Tue, Jan 8, 2:56 PM · Patch-For-Review, Multimedia, Commons, MediaWiki-File-management, Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Special-pages, Wikimedia-production-error
Anomie reopened T213168: Move file page to new name that exists on commons throws Wikimedia\Rdbms\DBTransactionStateError on zhwiki as "Open".

This does not seem to be a duplicate of T210739.

Tue, Jan 8, 2:55 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Wikimedia-production-error, MediaWiki-Special-pages

Mon, Jan 7

Anomie moved T212950: Luasandbox not loaded under PHP 7.2 Vagrant with Scribunto enabled from Backlog to External on the MediaWiki-extensions-Scribunto board.

I was unable to reproduce this locally (post 4e7a250ec5, php-luasandbox version 3.0.3-1~bpo9+1~wmf+php72 was installed). The only differences in my test from the current description were a different directory for the checkout and the fact that I added vagrant config nfs_shares no.

Mon, Jan 7, 4:54 PM · MediaWiki-Vagrant, MediaWiki-extensions-Scribunto
Anomie added a comment to T212988: Allow clients to POST JSONs in the body.

Done.

Mon, Jan 7, 3:41 PM · Patch-For-Review, MediaWiki-API
Anomie updated the task description for T212988: Allow clients to POST JSONs in the body.
Mon, Jan 7, 3:40 PM · Patch-For-Review, MediaWiki-API
Anomie added a comment to T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.

We'll probably want to have more than one class here.

Mon, Jan 7, 3:31 PM · Parsoid-PHP
Anomie added a comment to T212951: Documentation pages on sr.wikipedia.

The current code has no way of supporting multiple suffixes. If you can settle on just one suffix, you can adjust https://sr.wikipedia.org/wiki/MediaWiki:Scribunto-doc-page-name to match.

Mon, Jan 7, 3:12 PM · MediaWiki-extensions-Scribunto, Serbian-Sites
Anomie added a comment to T212988: Allow clients to POST JSONs in the body.

The API's preferred way of sending parameters is via POST. Additionally, some Special pages expect the payload to be POSTed as well. Therefore, accept requests that have their data embedded as a JSON in the body.

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/388486

Mon, Jan 7, 2:41 PM · Patch-For-Review, MediaWiki-API
Anomie closed T213060: Continue parameter should be included with exportnowrap as Declined.

If you want API response fields like continue, don't use exportnowrap. Just use export and extract the export XML from the API response.

Mon, Jan 7, 2:28 PM · MediaWiki-API

Fri, Jan 4

Anomie created T212980: ImageListPager is broken again (miser mode and comment migration stage NEW).
Fri, Jan 4, 10:37 PM · MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), Patch-For-Review, Core Platform Team Kanban (Waiting for Review), MediaWiki-Special-pages
Anomie updated the task description for T166733: Deploy refactored comment storage.
Fri, Jan 4, 8:32 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Commenting, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic
Anomie triaged T212972: Remove reference to text fields replaced by the comment table from WMCS views as Low priority.
Fri, Jan 4, 8:31 PM · Data-Services, Core Platform Team Backlog (Watching / External)
Anomie added a comment to T209590: HTTP/2 requests fail with too-long URLs.

Note it's ok if the server implements some limits. The problem here is that the client isn't getting the expected 4xx response (e.g. 414 or 431) when the limit is hit, all it sees is a dropped connection.

Fri, Jan 4, 4:26 PM · Patch-For-Review, Traffic, Operations
Anomie added a comment to T210739: Target deletion during page move fails.

Probably downgrade it from UBN, since it seems it mostly stopped happening:

anomie@mwlog1001:/srv/mw-log$ zfgrep -c 'Failed to delete page-move revision' archive/exception.log-201812* archive/exception.log-201901* exception.log 
archive/exception.log-20181201.gz:336
archive/exception.log-20181202.gz:330
archive/exception.log-20181203.gz:126
archive/exception.log-20181204.gz:0
archive/exception.log-20181205.gz:0
archive/exception.log-20181206.gz:6
archive/exception.log-20181207.gz:2
archive/exception.log-20181208.gz:0
archive/exception.log-20181209.gz:0
archive/exception.log-20181210.gz:0
archive/exception.log-20181211.gz:0
archive/exception.log-20181212.gz:0
archive/exception.log-20181213.gz:0
archive/exception.log-20181214.gz:0
archive/exception.log-20181215.gz:0
archive/exception.log-20181216.gz:0
archive/exception.log-20181217.gz:0
archive/exception.log-20181218.gz:0
archive/exception.log-20181219.gz:0
archive/exception.log-20181220.gz:0
archive/exception.log-20181221.gz:0
archive/exception.log-20181222.gz:0
archive/exception.log-20181223.gz:0
archive/exception.log-20181224.gz:0
archive/exception.log-20181225.gz:18
archive/exception.log-20181226.gz:0
archive/exception.log-20181227.gz:0
archive/exception.log-20181228.gz:0
archive/exception.log-20181229.gz:6
archive/exception.log-20181230.gz:0
archive/exception.log-20181231.gz:0
archive/exception.log-20190101.gz:0
archive/exception.log-20190102.gz:2
archive/exception.log-20190103.gz:0
archive/exception.log-20190104:0
exception.log:0
Fri, Jan 4, 3:11 PM · Patch-For-Review, Multimedia, Commons, MediaWiki-File-management, Core Platform Team Backlog (Watching / External), Core Platform Team (Security, stability, performance and scalability (TEC1)), MediaWiki-Special-pages, Wikimedia-production-error
Anomie closed T92469: RSS RecentChanges does not work on login-required wiki as Declined.

Since someone dumped this on Core Platform Team...

Fri, Jan 4, 2:26 PM · MediaWiki-API, Core Platform Team

Thu, Jan 3

Anomie added a comment to T125337: Add OAuth 2.0 support to MediaWiki .

You can misuse user scripts to e.g. steal session cookies and use the stolen session to pass the OAuth check.

Thu, Jan 3, 3:58 PM · Discourse, Developer-Advocacy, MediaWiki-extensions-OAuth, VPS-Projects
Anomie moved T212851: Confusing error for OAuth consumers with rollback but not edit grant from Unsorted to Non-core-API stuff on the MediaWiki-API board.

There doesn't seem to be anything to do in the API itself here. Improvements to the error message here or changes in grants would have to be done in other code.

Thu, Jan 3, 2:40 PM · MediaWiki-API, MediaWiki-User-management, MediaWiki-extensions-OAuth
Anomie added a comment to T212851: Confusing error for OAuth consumers with rollback but not edit grant.
  • Change WikiPage::doRollback() to only require the “rollback” right.
Thu, Jan 3, 2:27 PM · MediaWiki-API, MediaWiki-User-management, MediaWiki-extensions-OAuth

Wed, Jan 2

Anomie added a comment to T125337: Add OAuth 2.0 support to MediaWiki .

Everything supports OAuth 2 (and usually only 2) these days, so in the long run we'd save time by adding OAuth 2 to MediaWiki instead of adding OAuth 1 to everything else.

Wed, Jan 2, 5:47 PM · Discourse, Developer-Advocacy, MediaWiki-extensions-OAuth, VPS-Projects
Anomie added a comment to T212511: Deprecate comparing first revision to prev, last revision to next in API.

I would expect it to diff against null if rev_parent_id is 0. If that database field is not accurate, then that is a different issue that should probably be resolved.

Wed, Jan 2, 5:38 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie added a comment to T125337: Add OAuth 2.0 support to MediaWiki .

(neither how our Phabricator supports Wikimedia SUL).

Wed, Jan 2, 4:57 PM · Discourse, Developer-Advocacy, MediaWiki-extensions-OAuth, VPS-Projects
Anomie added a comment to T49333: The disablepp parameter of action=parse doesn't work, "NewPP limit report" still in output.

Cannot reproduce anymore with the testcase above: curl -s "https://en.wikipedia.org/w/api.php?action=parse&format=jsonfm&page=User:Svick/Sandbox&prop=text&disablepp" | grep NewPP show no output. Obsolete?

Wed, Jan 2, 4:38 PM · MediaWiki-API
Anomie added a comment to T212511: Deprecate comparing first revision to prev, last revision to next in API.

Maybe we should support that metaphor for version history with a different but very similar API action, like asdiff ("show me this revision as a diff").

Wed, Jan 2, 4:23 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie closed T212719: Attempting to fetch privileged log type no longer yields a permission denied error as Invalid.

The regression occurred some time after November 18 2018.

Wed, Jan 2, 3:37 PM · SpamBlacklist, MediaWiki-API, Regression
Anomie added a project to T212742: ApiQueryLogEvents on enwiki can fatal with InvalidArgumentException due to unreadable Flow object: StructuredDiscussions.

The log entry causing the error seems to be https://en.wikipedia.org/wiki/Special:Log?logid=57466586. The specific cause seems to be that LogFormatter::newFromEntry( $logEntry )->formatParametersForApi() is returning an instance of Flow\Model\UUID as part of the log data. Normally that's ok as that class implements ApiSerializable, but Flow isn't actually installed on enwiki so the object is actually an instance of __PHP_Incomplete_Class.

Wed, Jan 2, 3:20 PM · Growth-Team, StructuredDiscussions, MediaWiki-API, Wikimedia-production-error
Anomie updated the task description for T212742: ApiQueryLogEvents on enwiki can fatal with InvalidArgumentException due to unreadable Flow object.
Wed, Jan 2, 2:55 PM · Growth-Team, StructuredDiscussions, MediaWiki-API, Wikimedia-production-error

Fri, Dec 21

Anomie added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.
  • Action hooks may do expensive work, which is acceptable because they are asynchronous in nature. That is, they are not part of the atomic transaction that spans the original action. Instead, they are run from a deferred update or job.
  • An action hook callback cannot be prevented from running by other callbacks. (Exceptions are caught, logged, and then the hook continues; similar to deferred updates). {note: open question}
Fri, Dec 21, 6:55 PM · Performance-Team (Radar), TechCom-RFC, TechCom
Anomie closed T189026: IndexPager::buildQueryInfo (contributions page unfiltered) query needs tuning as Resolved.

Yes. I left it open back in March because of concern that it might reoccur when we started changing configuration for T188327, but that concern was addressed by 993baa349 and 59e856e3e.

Fri, Dec 21, 5:20 PM · TestMe, MW-1.31-release-notes (WMF-deploy-2018-03-13 (1.31.0-wmf.25)), Wikidata, DBA, MediaWiki-Database
Anomie moved T212511: Deprecate comparing first revision to prev, last revision to next in API from Needs Code to Needs Review on the MediaWiki-API board.
Fri, Dec 21, 5:11 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie added a comment to T212511: Deprecate comparing first revision to prev, last revision to next in API.

After this, the result would be a baddiff error as in https://phabricator.wikimedia.org/T203433.

Fri, Dec 21, 5:11 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie moved T212511: Deprecate comparing first revision to prev, last revision to next in API from Unsorted to Needs Code on the MediaWiki-API board.
Fri, Dec 21, 4:30 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie added projects to T212511: Deprecate comparing first revision to prev, last revision to next in API: MediaWiki-API, Technical-Debt.
Fri, Dec 21, 4:30 PM · Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Technical-Debt, MediaWiki-API
Anomie awarded T212263: Migrate page issue styles from Minerva to TemplateStyles a Like token.
Fri, Dec 21, 3:15 PM · User-Jdlrobson, Technical-Debt, Reading-Web-Local-Wiki-Issues, Page-Issue-Warnings, MinervaNeue, Readers-Web-Backlog

Thu, Dec 20

Anomie added a comment to T212356: API should not return an error on batched deletions.

Note the fix should be deployed to Wikimedia wikis with 1.33.0-wmf.12, see https://www.mediawiki.org/wiki/MediaWiki_1.33/Roadmap for a schedule.

Thu, Dec 20, 7:10 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Regression, MW-1.32-release, Pywikibot, MediaWiki-API
Anomie added a comment to T200259: Investigate wrong entry order in the user contributions list.

You're welcome! I think the patch looks good now, we can finish it up in code review.

Thu, Dec 20, 4:25 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), WMDE-QWERTY-X-Mas-Sprint-2018-12-18, MediaWiki-Special-pages, Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Move-Files-To-Commons
Anomie moved T212356: API should not return an error on batched deletions from In Dev to Needs Review on the MediaWiki-API board.
Thu, Dec 20, 3:05 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Regression, MW-1.32-release, Pywikibot, MediaWiki-API
Anomie added projects to T212356: API should not return an error on batched deletions: MW-1.32-release, Regression.

Marking as a regression and blocking the 1.32 release.

Thu, Dec 20, 2:46 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Regression, MW-1.32-release, Pywikibot, MediaWiki-API
Anomie claimed T212356: API should not return an error on batched deletions.

I think there's no bug in pywikibot here. The addition of scheduled deletions to MediaWiki seems to have not been integrated well with the API.

Thu, Dec 20, 2:06 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Regression, MW-1.32-release, Pywikibot, MediaWiki-API

Wed, Dec 19

Anomie updated the task description for T166733: Deploy refactored comment storage.
Wed, Dec 19, 6:09 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Commenting, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic
Anomie removed a project from T166733: Deploy refactored comment storage: Patch-For-Review.
Wed, Dec 19, 6:07 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Commenting, Core Platform Team Kanban (Doing), Core Platform Team ( Code Health (TEC13)), User-notice, Epic
Anomie moved T212307: Interaction Timeline makes an API request to MediaWiki that returns a warning from Unsorted to Non-core-API stuff on the MediaWiki-API board.

Note that the normal web UI doesn't provide a diff in this situation either: https://test.wikipedia.org/wiki/Special:Diff/338497/prev produces

Wed, Dec 19, 4:32 PM · MediaWiki-API, InteractionTimeline
Anomie added a comment to T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser.

Moving to "done" on the MediaWiki-API workboard per rMWf54029806dad: Use SpecialPageFactory in ApiQueryQueryPage.

Wed, Dec 19, 3:10 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-API, Wikidata, Wikibase-DataModel, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error
Anomie moved T208924: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser from Needs Code to Done on the MediaWiki-API board.
Wed, Dec 19, 3:10 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Patch-For-Review, User-Michael, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-API, Wikidata, Wikibase-DataModel, MediaWiki-extensions-WikibaseClient, Wikimedia-production-error

Tue, Dec 18

Anomie added a comment to T200259: Investigate wrong entry order in the user contributions list.

I'm not very good in reading these EXPLAIN outputs. Can you help us understand what the consequence of what we see in there might be?

Tue, Dec 18, 7:57 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), WMDE-QWERTY-X-Mas-Sprint-2018-12-18, MediaWiki-Special-pages, Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Move-Files-To-Commons
Anomie edited projects for T210528: PHP/HHVM serialization incompatibility in some situations when using Serializable, added: Core Platform Team Kanban (Done with CPT); removed Core Platform Team Kanban (Waiting for Review), Patch-For-Review.

Current status: The known problems with the Message class have been worked around in various ways. It's possible that other classes using Serializable might still run into the same problem. Watch for log messages like "Unable to serialize r:46: Id 46 out of range.".

Tue, Dec 18, 3:23 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Core Platform Team (PHP7 (TEC4))
Anomie added a comment to T200259: Investigate wrong entry order in the user contributions list.
  • I wondered if the same if-else as in getIndexField is needed, choosing between ipc_rev_id and rev_id. Answer: No. The rev_id field is always available. The ipc_rev_id field is only available when a JOIN with ip_changes is made. This join is performed on 'LEFT JOIN', [ 'ipc_rev_id = rev_id' ], which means the two fields behave entirely identical within this query.
Tue, Dec 18, 3:10 PM · MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), WMDE-QWERTY-X-Mas-Sprint-2018-12-18, MediaWiki-Special-pages, Patch-For-Review, WMDE-QWERTY-Sprint-2018-12-04, TCB-Team, Move-Files-To-Commons
Anomie closed T203433: Viewing first revision via API gives baddiff error as Resolved.
Tue, Dec 18, 2:48 PM · MW-1.32-notes, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MW-1.32-release, Anti-Harassment, InteractionTimeline, Patch-For-Review, Regression, MediaWiki-API, MediaWiki-History-or-Diffs

Mon, Dec 17

Anomie closed T206568: update.php is super-slow thanks to populateChangeTagDef.php as Resolved.
Mon, Dec 17, 7:47 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), User-Ladsgroup, Patch-For-Review, MW-1.32-release, MediaWiki-Installer, MediaWiki-Change-tagging
Anomie added a comment to T212006: Ideas for Action API demo app tutorials.

For 2 "2. Featured articles reader" I would recommend the use of the REST API (https://en.wikipedia.org/api/rest_v1/#!/Feed/aggregatedFeed)

Mon, Dec 17, 7:46 PM · Developer-Advocacy (Jan-Mar 2019), Goal, Documentation, MediaWiki-API
Anomie added a comment to T210894: Maintenance scripts auto creating their own accounts is failing since migrating to actor.

If you think it's a different cause, you'll have to pinpoint on your own what that cause is.

Mon, Dec 17, 7:09 PM · MediaWiki-User-login-and-signup, MediaWiki-Database
Anomie added a comment to T188327: Deploy refactored actor storage.

Mentioned in SAL (#wikimedia-operations) [2018-12-17T16:07:32Z] <anomie@mwmaint1002> Running migrateActors.php on test wikis and mediawikiwiki for T188327

Mon, Dec 17, 5:36 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Core Platform Team Kanban (Blocked Externally), Core Platform Team ( Code Health (TEC13)), Epic
Anomie added a comment to T212069: API action=wbgetentities does not handle formatversion=2.

Relevant code for this specific example: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/6eea7f8d5e52a528877748391e3fae965f752018/repo/includes/Api/ResultBuilder.php#1019. Changing that "" to true should do it, although with how complicated Wikibase's code is I can't say for sure.

Mon, Dec 17, 2:20 PM · Wikidata, MediaWiki-API
Anomie moved T212069: API action=wbgetentities does not handle formatversion=2 from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Mon, Dec 17, 2:15 PM · Wikidata, MediaWiki-API

Dec 16 2018

Anomie renamed T209590: HTTP/2 requests fail with too-long URLs from API should return a helpful error message when URL is too long to HTTP/2 requests fail with too-long URLs.
Dec 16 2018, 2:46 AM · Patch-For-Review, Traffic, Operations
Anomie added a comment to T209590: HTTP/2 requests fail with too-long URLs.

Still not a bug in the API. But it does seem to be a bug somewhere in the infrastructure. I've managed to get consistent results by using only ASCII characters in the URL.

Dec 16 2018, 2:46 AM · Patch-For-Review, Traffic, Operations
Anomie created P7918 HTTP/1.1 query works, even with much longer URLs.
Dec 16 2018, 2:44 AM
Anomie created P7917 HTTP/2 query that fails.
Dec 16 2018, 2:44 AM
Anomie created P7916 HTTP/2 query that works.
Dec 16 2018, 2:44 AM

Dec 14 2018

Anomie added a comment to T212006: Ideas for Action API demo app tutorials.

Seems like a good list of ideas.

Dec 14 2018, 8:07 PM · Developer-Advocacy (Jan-Mar 2019), Goal, Documentation, MediaWiki-API
Anomie moved T212006: Ideas for Action API demo app tutorials from Unsorted to Non-Code on the MediaWiki-API board.
Dec 14 2018, 7:46 PM · Developer-Advocacy (Jan-Mar 2019), Goal, Documentation, MediaWiki-API
Anomie added a comment to T206568: update.php is super-slow thanks to populateChangeTagDef.php.

Sorry, I misinterpreted your earlier comment.

Dec 14 2018, 6:05 PM · MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), User-Ladsgroup, Patch-For-Review, MW-1.32-release, MediaWiki-Installer, MediaWiki-Change-tagging
Anomie closed T167942: Database::upsert() for Postgres triggers an (ignored) error, by design as Resolved.

It looks like the error in the task description was fixed for users of PostgreSQL 9.5+ in MediaWiki 1.31 with rMWcc0473766a53: rdbms: Remove support for PostgreSQL < 9.2, and improve INSERT IGNORE for 9.5, as calls to ->insert() with the IGNORE option no longer log an error to MediaWiki's log files. Thus I'm going to close this as Resolved.

Dec 14 2018, 4:22 PM · MW-1.32-release, PostgreSQL, MediaWiki-Database