Anomie (Brad Jorsch)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (197 w, 3 d)
Availability
Available
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Yesterday

Anomie added a comment to T195747: Create views for the schema change for refactored actor storage.

There are two aspects to compatibility joins here:

Fri, Jul 20, 6:29 PM · Core-Platform-Team, Patch-For-Review, Data-Services
Anomie merged Restricted Task into T200014: Potentially security bug in /tests/qunit/data/load.mock.php .
Fri, Jul 20, 3:13 PM · MediaWiki-Core-Tests, Vuln-XSS, Security
Anomie closed T199949: API shouldn't log error-level exception for invalid 'formatversion' parameter as Resolved.
Fri, Jul 20, 2:54 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-API, Wikimedia-log-errors
Anomie added a comment to T200055: Some pages have revisions by invalid usernames (with leading or trailing space) which break the "Info" and "History" views.

This seems like more or less a duplicate or effect of T2323: usernames in really old revisions (copied from pre-MediaWiki versions of Wikipedia) cause various problems.

Fri, Jul 20, 1:54 PM · Wikimedia-log-errors, Core-Platform-Team, MediaWiki-General-or-Unknown

Thu, Jul 19

Anomie added a comment to T197617: TemplateStyles should be able to add skin-specific CSS.

I'd like to propose a new attribute "skins" for templatestyles. For example:

Thu, Jul 19, 7:17 PM · TemplateStyles
Anomie moved T198563: Make "write both, read old" the default MCR migration stage on master / for CI from Ready to Done on the Core-Platform-Team (CPT-Q1-Jul-Sep-2018) board.
Thu, Jul 19, 5:46 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Multi-Content-Revisions (MCR Deployment), Wikidata
Anomie closed T198563: Make "write both, read old" the default MCR migration stage on master / for CI as Resolved.
Thu, Jul 19, 5:46 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Multi-Content-Revisions (MCR Deployment), Wikidata
Anomie closed T198563: Make "write both, read old" the default MCR migration stage on master / for CI, a subtask of T198561: Make "write both, read new" the default MCR migration stage for fresh MediaWiki installs / for CI, as Resolved.
Thu, Jul 19, 5:45 PM · Multi-Content-Revisions (MCR Deployment), Patch-For-Review, User-Daniel, MW-1.32-release, Wikidata
Anomie moved T197818: Enable MCR migration stage "write both, read old" on commons beta. from Ready to Done on the Core-Platform-Team (CPT-Q1-Jul-Sep-2018) board.
Thu, Jul 19, 5:45 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Multi-Content-Revisions (MCR Deployment), Patch-For-Review, Structured-Data-Commons, Wikidata
Anomie added a project to T197818: Enable MCR migration stage "write both, read old" on commons beta.: Core-Platform-Team (CPT-Q1-Jul-Sep-2018).
Thu, Jul 19, 5:45 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Multi-Content-Revisions (MCR Deployment), Patch-For-Review, Structured-Data-Commons, Wikidata
Anomie moved T199152: mysql.php reacts to signals intended for mysql from Ready to Done on the Core-Platform-Team (CPT-Q1-Jul-Sep-2018) board.
Thu, Jul 19, 5:44 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts
Anomie edited projects for T199152: mysql.php reacts to signals intended for mysql, added: Core-Platform-Team (CPT-Q1-Jul-Sep-2018); removed Core-Platform-Team.
Thu, Jul 19, 5:44 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts
Anomie reassigned T199152: mysql.php reacts to signals intended for mysql from Anomie to tstarling.
Thu, Jul 19, 5:43 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts
Anomie closed T199152: mysql.php reacts to signals intended for mysql as Resolved.

Ok, let's call this fixed. The Ctrl+Z thing seems way to complicated to worry about.

Thu, Jul 19, 5:43 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts
Anomie moved T170971: iconv(): Detected an illegal character in CentralAuthUser from Ready to Waiting for Review on the Core-Platform-Team (CPT-Q1-Jul-Sep-2018) board.

Let's just cut the knot here and use Wikimedia\suppressWarnings() to make the warning go away.

Thu, Jul 19, 5:40 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-extensions-CentralAuth, Wikimedia-log-errors
Anomie added a project to T170971: iconv(): Detected an illegal character in CentralAuthUser: Core-Platform-Team (CPT-Q1-Jul-Sep-2018).
Thu, Jul 19, 5:39 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-extensions-CentralAuth, Wikimedia-log-errors
Anomie closed T194153: UTF-8 error in Lua when using terms in Turkish as Invalid.

I see in the discussion that the user said https://tr.wiktionary.org/w/index.php?title=Mod%C3%BCl:tr-ad&oldid=2945196 raises an error which was fixed by https://tr.wiktionary.org/w/index.php?title=Mod%C3%BCl:tr-ad&diff=next&oldid=2945196. Looking at the change made, the issue is obvious: if you byte-reverse a UTF-8 string, as string.reverse does, the result is not valid UTF-8.

Thu, Jul 19, 5:13 PM · MediaWiki-extensions-Scribunto, Wikidata, Wikibase-Lua
Anomie closed T197818: Enable MCR migration stage "write both, read old" on commons beta. as Resolved.
Thu, Jul 19, 3:29 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Multi-Content-Revisions (MCR Deployment), Patch-For-Review, Structured-Data-Commons, Wikidata
Anomie closed T197818: Enable MCR migration stage "write both, read old" on commons beta., a subtask of T197817: Enable MCR migration stage "write both, read old" on testwiki, as Resolved.
Thu, Jul 19, 3:29 PM · Multi-Content-Revisions (MCR Deployment), Structured-Data-Commons, Wikidata
Anomie updated subscribers of T200000: Elaborate match Google user with e-mail address in addition to user ID.

What exactly is the request here? Something like this?

Thu, Jul 19, 3:22 PM · GoogleLogin
Anomie added a project to T200000: Elaborate match Google user with e-mail address in addition to user ID: GoogleLogin.
Thu, Jul 19, 2:49 PM · GoogleLogin
Anomie added a comment to T187980: Memcached error "A TIMEOUT OCCURRED" for keys.

The original complaint here does not seem to be the case anymore. In the past 30 days the TIMEOUT error was in a distant fifth place:

Thu, Jul 19, 2:32 PM · Core-Platform-Team, Performance-Team (Radar), Wikimedia-log-errors, MediaWiki-Cache
Anomie moved T199949: API shouldn't log error-level exception for invalid 'formatversion' parameter from Unsorted to Needs Review on the MediaWiki-API board.
Thu, Jul 19, 1:49 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-API, Wikimedia-log-errors
Anomie moved T199949: API shouldn't log error-level exception for invalid 'formatversion' parameter from Ready to Waiting for Review on the Core-Platform-Team (CPT-Q1-Jul-Sep-2018) board.

When the printer throws an error, ApiMain tries to recreate the printer and sets a flag to have it ignore the request parameters to avoid exactly this situation. But it turns out that ApiModuleManager caching was causing it to reuse the same object instead of creating a new one.

Thu, Jul 19, 1:47 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-API, Wikimedia-log-errors
Anomie claimed T199949: API shouldn't log error-level exception for invalid 'formatversion' parameter.
Thu, Jul 19, 1:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-API, Wikimedia-log-errors

Wed, Jul 18

Anomie closed T199809: New Botpassword requires whenever someone else requests a new password for main account as Resolved.

The fix should be deployed to Wikimedia wikis with 1.32.0-wmf.14 or later.

Wed, Jul 18, 4:31 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization
Anomie added a comment to T191939: How to deal with blocked messages on client that require advanced parsing?.

This task is probably not the right place to have that discussion.

Wed, Jul 18, 4:29 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), Patch-For-Review, Readers-Web-Backlog (Tracking), Language-Team, Anti-Harassment, MediaWiki-API, Front-end-Standards-Group, MediaWiki-User-management, MediaWiki-Parser
Anomie added a comment to T143367: Users getting logged-out during minor network glitches.
Wed, Jul 18, 4:20 PM · Performance-Team, Availability (MediaWiki-MultiDC), MediaWiki-Authentication-and-authorization
Anomie changed the status of T199852: mw.text.unstripNoWiki doesn't work in special:ExpandTemplates from Invalid to Declined.
Wed, Jul 18, 3:55 PM · MediaWiki-Parser, MediaWiki-Special-pages, MediaWiki-extensions-Scribunto
Anomie closed T199852: mw.text.unstripNoWiki doesn't work in special:ExpandTemplates as Invalid.

Non-"function" tags, including <nowiki>, aren't expanded by the parsing mode used in Special:ExpandTemplates. Instead they get internally handled using general strip markers, which Scribunto cannot unstrip.

Wed, Jul 18, 3:55 PM · MediaWiki-Parser, MediaWiki-Special-pages, MediaWiki-extensions-Scribunto
Anomie added a comment to T199152: mysql.php reacts to signals intended for mysql.

Hmm. If I use PHP 7.0 on mwmaint1001, I get different behavior. Sometimes it works right, sometimes the fg unsuspends all the processes but doesn't correctly make them the foreground process, and sometimes it manages to not unsuspend the mysql process.

Wed, Jul 18, 2:47 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts
Anomie added a comment to T199152: mysql.php reacts to signals intended for mysql.

On my local machine, with bash as the shell, before Ctrl+Z:

brad     10280  0.9  1.2 230104 45680 pts/7    S+   10:12   0:00 php maintenance
brad     10281  0.0  0.0   2368   752 pts/7    S+   10:12   0:00 sh -c 'mysql' '
brad     10282  0.2  0.1  23288  7432 pts/7    S+   10:12   0:00 mysql --default

After Ctrl+Z:

brad     10280  0.4  1.2 230104 45680 pts/7    T    10:12   0:00 php maintenance
brad     10281  0.0  0.0   2368   752 pts/7    T    10:12   0:00 sh -c 'mysql' '
brad     10282  0.1  0.1  23288  7432 pts/7    T    10:12   0:00 mysql --default

After fg:

brad     10280  0.2  1.2 230104 45680 pts/7    S+   10:12   0:00 php maintenance
brad     10281  0.0  0.0   2368   752 pts/7    S+   10:12   0:00 sh -c 'mysql' '
brad     10282  0.0  0.1  23288  7432 pts/7    T+   10:12   0:00 mysql --default
Wed, Jul 18, 2:18 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts

Tue, Jul 17

Anomie added a comment to T199790: Special:Log/Fanghong results in fatal exception of type "Wikimedia\Rdbms\DBQueryTimeoutError".

Looking at the queries, I see SHOW EXPLAIN says it's using an even worse plan:

wikiadmin@10.64.0.164(commonswiki)> show explain for 3441450538;
+------+--------------------+---------------------+--------+----------------------------------------------+-----------+---------+------------------------------------+----------+-----------------------------+
| id   | select_type        | table               | type   | possible_keys                                | key       | key_len | ref                                | rows     | Extra                       |
+------+--------------------+---------------------+--------+----------------------------------------------+-----------+---------+------------------------------------+----------+-----------------------------+
|    1 | PRIMARY            | logging             | index  | type_time,user_time,times,log_user_type_time | user_time | 20      | NULL                               | 77328774 | Using where; Using filesort |
|    1 | PRIMARY            | comment_log_comment | eq_ref | PRIMARY                                      | PRIMARY   | 8       | commonswiki.logging.log_comment_id |        1 |                             |
|    1 | PRIMARY            | user                | eq_ref | PRIMARY                                      | PRIMARY   | 4       | commonswiki.logging.log_user       |        1 |                             |
|    2 | DEPENDENT SUBQUERY | change_tag          | ref    | ct_log_id,change_tag_log_tag                 | ct_log_id | 5       | commonswiki.logging.log_id         |        1 | Using index                 |
+------+--------------------+---------------------+--------+----------------------------------------------+-----------+---------+------------------------------------+----------+-----------------------------+

Looks like it's scanning the whole table and filesorting, WTF.

Tue, Jul 17, 9:02 PM · Patch-For-Review, DBA, Commons, User-Josve05a, MediaWiki-Database, MediaWiki-Special-pages, Wikimedia-log-errors
Anomie added a comment to T199790: Special:Log/Fanghong results in fatal exception of type "Wikimedia\Rdbms\DBQueryTimeoutError".
/*!50100 PARTITION BY RANGE (log_user)
Tue, Jul 17, 8:57 PM · Patch-For-Review, DBA, Commons, User-Josve05a, MediaWiki-Database, MediaWiki-Special-pages, Wikimedia-log-errors
Anomie added a comment to T199809: New Botpassword requires whenever someone else requests a new password for main account.

It's intended that changing your authentication credentials generally will invalidate all bot passwords. But there should be an exception for the temporary emailed password.

Tue, Jul 17, 8:10 PM · Patch-For-Review, MediaWiki-Authentication-and-authorization
Anomie updated subscribers of T199762: WikiPage::updateCategoryCounts causing Lock wait timeout exceeded.

I ran some checks across the log files in mwlog1001, which go back to 2018-04-17, looking at exception.log entries containing Lock wait timeout and `category`.

Tue, Jul 17, 3:50 PM · Patch-For-Review, Wikimedia-log-errors, Performance-Team, Core-Platform-Team, MediaWiki-Database
Anomie added a comment to T54712: WikiPage::updateCategoryCounts causing Lock wait timeout exceeded.

Sorry, I misinterpreted "which seems like it should've avoided this sort of error" as meaning "this is probably fixed but needs verification" (rather than "that should have fixed it, but apparently didn't") and didn't check the edits to the description.

Tue, Jul 17, 1:51 PM · Wikimedia-log-errors, Performance-Team, Core-Platform-Team, MediaWiki-Database, MediaWiki-Page-deletion
Anomie moved T199716: BlueSpice BSApiTasksTestBase causes Undefined index: from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Tue, Jul 17, 1:30 PM · MediaWiki-API, BlueSpice
Anomie closed T198618: TOC processing should strip contents of <style> tags as Resolved.

This should be deployed to Wikimedia sites with 1.32.0-wmf.13 or later.

Tue, Jul 17, 1:29 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Parser, TemplateStyles
Anomie added a comment to T165768: $wgShowSQLErrors doesn't seem to be working anymore.

Key is correct nomenclature.

Tue, Jul 17, 2:46 AM · Patch-For-Review, MediaWiki-Debug-Logger, MediaWiki-Database
Anomie closed T54712: WikiPage::updateCategoryCounts causing Lock wait timeout exceeded as Declined.

Recently Aaron and I changed a bit in this code, so the task from 2013 seems likely to be obsolete. Let's close this for now and if the problem occurs again we can reopen or file a new task.

Tue, Jul 17, 1:47 AM · Wikimedia-log-errors, Performance-Team, Core-Platform-Team, MediaWiki-Database, MediaWiki-Page-deletion
Anomie closed T54712: WikiPage::updateCategoryCounts causing Lock wait timeout exceeded, a subtask of T30499: 1205: Lock wait timeout exceeded; try restarting transaction (tracking), as Declined.
Tue, Jul 17, 1:47 AM · Technical-Debt, Tracking, MediaWiki-Database
Anomie added a comment to T197472: edit.php and rollbackEdits.php scripts failing with MWException "CAS update failed on user_touched".

I poked at this and couldn't manage to reproduce it locally, both with an existing maintenance user and with needing the creation of the maintenance user.

Tue, Jul 17, 1:42 AM · Core-Platform-Team, MediaWiki-Maintenance-scripts
Anomie added a comment to T165768: $wgShowSQLErrors doesn't seem to be working anymore.

One subtlety is that ApiMain::errorMessagesFromException() is currently sending a key of 'apierror-databaseerror' only for DBError exceptions when $wgShowSQLErrors is false. For DBError exceptions when $wgShowSQLErrors is true, it is sending a key of 'apierror-exceptioncaught'. In other words, it either sends a key indicating the exception was database-related OR it sends the details, but never both.

Is that intentional? For consistency, I'm tempted to send 'apierror-databaseerror' for all DBError exceptions, whether we are including details or not.

Tue, Jul 17, 1:22 AM · Patch-For-Review, MediaWiki-Debug-Logger, MediaWiki-Database

Mon, Jul 16

Anomie moved T199647: Failing ParserIntegrationTest PHPUnit test causes CI failures for various extensions from Ready to Waiting for Review on the Core-Platform-Team (CPT-Q1-Jul-Sep-2018) board.
Mon, Jul 16, 2:56 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, SyntaxHighlight, MediaWiki-Parser, User-zeljkofilipin
Anomie added a project to T199647: Failing ParserIntegrationTest PHPUnit test causes CI failures for various extensions: Core-Platform-Team (CPT-Q1-Jul-Sep-2018).
Mon, Jul 16, 2:56 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, SyntaxHighlight, MediaWiki-Parser, User-zeljkofilipin
Anomie updated subscribers of T128394: Deprecate and remove User::isSafeToLoad.

I think we're saying the same thing with different words.

Mon, Jul 16, 2:10 PM · Technical-Debt (Deprecation), MediaWiki-User-login-and-signup
Anomie edited projects for T199647: Failing ParserIntegrationTest PHPUnit test causes CI failures for various extensions, added: SyntaxHighlight; removed MediaWiki-extensions-FlaggedRevs, ContentTranslation, RelatedArticles, MediaWiki-extensions-Scribunto.

The failure is coming from a test in SyntaxHighlight, caused by rMWbe266087b47c: Don't armor french spaces before punctuation followed by word characters removing a case where a space was getting turned into a non-breaking space.

Mon, Jul 16, 1:21 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, SyntaxHighlight, MediaWiki-Parser, User-zeljkofilipin

Sun, Jul 15

Anomie updated subscribers of T199554: Switching between visual editor and source mode gives error message.

rMW264b4039b30f: Remove outdated transition code seems suspicious. Perhaps VE and other scripts are still relying on the old behavior removed in that patch.

Sun, Jul 15, 10:35 PM · VisualEditor

Fri, Jul 13

Anomie closed T194263: Deprecate/Remove ContentHandler::makeParserOptions() as Resolved.
Fri, Jul 13, 7:48 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie closed T194263: Deprecate/Remove ContentHandler::makeParserOptions(), a subtask of T194048: Introduce RevisionRenderer, as Resolved.
Fri, Jul 13, 7:48 PM · Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Patch-For-Review, Structured-Data-Commons, Wikidata
Anomie edited projects for T199495: Allow $input in LogEventsListGetExtraInputs hook, deprecate it, added: MediaWiki-Logging; removed MediaWiki-API.

This seems to have nothing to do with the action API.

Fri, Jul 13, 2:45 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), MediaWiki-Logging

Thu, Jul 12

Anomie added a comment to T189808: Make undo work with multiple slots..

I note there's no reason the edit form with the undo content would have to actually be editable for any particular field or having the raw content of that field being displayed to the user, as long as the preview and show changes functions work sensibly. In the extreme case, an "undo without edit" could have all fields' content as <input type="hidden"> or as data stored in the session server-side.

Thu, Jul 12, 8:36 PM · Patch-For-Review, Core-Platform-Team, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie closed T198525: Can't log into mobile on Commons as Resolved.

Unless someone backports it, the fix should be deployed with 1.32.0-wmf.13 or later. That should be Wednesday, July 18.

Thu, Jul 12, 7:40 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, MediaWiki-Authentication-and-authorization, Wikimedia-General-or-Unknown
Anomie added a comment to T194263: Deprecate/Remove ContentHandler::makeParserOptions().

The longer I think about this, the more I want ParserOptions creation to have a Title for context.
The reason is that default parser behavior may vary with the type of page. The special case for conversion tables in WikiPage::makeParserOptions() is the point in case.

Thu, Jul 12, 5:40 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie merged Restricted Task into T71222: list=logevents slow for users with last log action long time ago.
Thu, Jul 12, 4:05 PM · DBA, Performance, MediaWiki-API
Anomie added a comment to T199393: Reproducible deadlock in User::addToDatabase() when api.php?action=createaccount is called simultaneously by several users.

Using MariaDB 10.1.29 locally, I narrowed it down to the following series of queries being executed (intermixed with many other queries) as part of the account creation process:

A: BEGIN;
A: SELECT user_id  FROM `user` WHERE user_name = 'T199393.153140698912290'  LIMIT 1   LOCK IN SHARE MODE;
Thu, Jul 12, 3:28 PM · MediaWiki-Authentication-and-authorization, MediaWiki-Database
Anomie added a comment to T199393: Reproducible deadlock in User::addToDatabase() when api.php?action=createaccount is called simultaneously by several users.

Does the deadlock also happen if multiple users use the web UI Special:CreateAccount?

Thu, Jul 12, 2:05 PM · MediaWiki-Authentication-and-authorization, MediaWiki-Database
Anomie moved T199438: Unit of measure in Quantity datatype when written with bots (Wikidata API) is not (correctly) shown in Wikidata pages. from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Thu, Jul 12, 2:03 PM · MediaWiki-API, Operations, MediaWiki-General-or-Unknown

Wed, Jul 11

Anomie committed rETST435e06e2f5bc: Replace deprecated ContentHandler::makeParserOptions() (authored by Anomie).
Replace deprecated ContentHandler::makeParserOptions()
Wed, Jul 11, 6:38 PM
Anomie closed T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions(), a subtask of T194263: Deprecate/Remove ContentHandler::makeParserOptions(), as Resolved.
Wed, Jul 11, 5:52 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie closed T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions() as Resolved.
Wed, Jul 11, 5:52 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), User-Daniel, MediaWiki-extensions-WikibaseRepository, Wikidata
Anomie added a comment to T117549: ApiParse: Do not generate warning on parameter `variant`.

Resolving T44240: LanguageConverter should not inspect global state to determine the variant would make it easier to progress on this task, since then the API can have more direct control over the variant used (or at least better knowledge of how the variant is going to be determined).

Wed, Jul 11, 5:48 PM · Patch-Needs-Improvement, MediaWiki-API
Anomie renamed T44240: LanguageConverter should not inspect global state to determine the variant from Refactor LanguageConverter to decouple it from various $wg objects to LanguageConverter should not inspect global state to determine the variant.
Wed, Jul 11, 5:46 PM · Technical-Debt, MediaWiki-Language-converter
Anomie added a comment to T194263: Deprecate/Remove ContentHandler::makeParserOptions().

ParserOptions::newCanonical() already exists, taking a User and a Language for the 'userlang' option. If they're not passed, they currently default to $wgUser and $wgLang. Now that I think about it fresh, I think I'll just extend that method to accept an IContextSource or the string 'canonical' too.

Wed, Jul 11, 3:39 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie added a comment to T51199: Add index log_type_action.

After all the changes on the logging table related to the actor refactoring, what should we do with this ticket?

Wed, Jul 11, 2:52 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Blocked-on-schema-change, MediaWiki-Database, Schema-change
Anomie added a comment to T199323: cuc_comment is incompatible with Comments.

If you want a quick fix instead of going ahead and updating CheckUser to use the comment table, sure.

Wed, Jul 11, 1:46 PM · CheckUser
Anomie added a comment to T195515: GUC query performance regressed 100x from <3s to 80-300s.

There are two types of joins going on for the actor and comment table stuff:

Wed, Jul 11, 1:41 PM · Stewards-and-global-tools, Data-Services, cloud-services-team, Tool-Global-user-contributions
Anomie added a comment to T199323: cuc_comment is incompatible with Comments.

rc_comment is also in the process of being replaced by rc_comment_id referencing the comment table.

Wed, Jul 11, 1:24 PM · CheckUser
Anomie added a comment to T199316: "sql wikishared" doesn't work on mwmaint1001.

The new way to access that be something like sql wikishared --cluster=extension1. The old sql script had a special case doing the equivalent for "wikishared" (and only "wikishared").

Wed, Jul 11, 12:06 PM · Patch-For-Review, Core-Platform-Team, Scap
Anomie added a comment to T195515: GUC query performance regressed 100x from <3s to 80-300s.

Fine by me. When I made the suggestion, it was only a suggestion pending it being feasible and desired.

Wed, Jul 11, 11:46 AM · Stewards-and-global-tools, Data-Services, cloud-services-team, Tool-Global-user-contributions

Tue, Jul 10

Anomie added a comment to T151415: Log email changes for all users.

Now in Gerrit as https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/445016

Tue, Jul 10, 8:49 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-Special-pages, MediaWiki-Authentication-and-authorization, MediaWiki-User-preferences, Security
Anomie moved T194263: Deprecate/Remove ContentHandler::makeParserOptions() from Ready to In Progress on the MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018) board.
Tue, Jul 10, 8:39 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie added a project to T194263: Deprecate/Remove ContentHandler::makeParserOptions(): MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018).
Tue, Jul 10, 8:39 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie added a comment to T194263: Deprecate/Remove ContentHandler::makeParserOptions().

For now, it probably OK to move the logic to WikiPage::makeParserOptions().

Tue, Jul 10, 8:38 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Structured-Data-Commons, Wikidata
Anomie moved T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions() from Ready to Waiting for Review on the MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018) board.
Tue, Jul 10, 7:58 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), User-Daniel, MediaWiki-extensions-WikibaseRepository, Wikidata
Anomie edited projects for T190712: Wikibase\Repo\Content\EntityHandler should not override makeParserOptions(), added: MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018); removed Patch-For-Review.
Tue, Jul 10, 7:58 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), User-Daniel, MediaWiki-extensions-WikibaseRepository, Wikidata
Anomie added a comment to T151415: Log email changes for all users.

Fine by me. I only put it here because that's what we do for private Security tasks.

Tue, Jul 10, 6:37 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-Special-pages, MediaWiki-Authentication-and-authorization, MediaWiki-User-preferences, Security
Anomie moved T151415: Log email changes for all users from Ready to Waiting for Review on the MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018) board.

Tue, Jul 10, 6:16 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-Special-pages, MediaWiki-Authentication-and-authorization, MediaWiki-User-preferences, Security
Anomie added a project to T151415: Log email changes for all users: MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018).
Tue, Jul 10, 6:15 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), MediaWiki-Special-pages, MediaWiki-Authentication-and-authorization, MediaWiki-User-preferences, Security
Anomie added a comment to T198869: [Bug] CentralNotice: "Failed to load data blob" error when editing translatable messages.

...looks like loadRevisionFromId() needs a $queryFlag parameter which it can then pass to loadRevisionFromConds(). newNullRevision() can then call loadRevisionFromId with READ_LATEST. That should fix the issue, but always hitting master when creating a null revision may not be desirable.

Tue, Jul 10, 5:20 PM · Core-Platform-Team, Fundraising Sprint Naming Sprints Is Not Important, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, Multi-Content-Revisions, Fundraising Sprint Matt Damon to head up Space Force, MediaWiki-extensions-CentralNotice, Fundraising-Backlog
Anomie added a comment to T100782: http://en.wikipedia.org//wiki/Main_Page raise "Redirect loop detected!" because of the double slash.

If we normalize the entire path in PathRouter

Tue, Jul 10, 4:00 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-General-or-Unknown, Wikimedia-log-errors
Anomie added a comment to T189022: Deploy TemplateStyles to zhwiki on 2018-07-19.

Remaining lint errors shouldn't be a problem. The wait for Remex was because wikitext like[1]

Lorem ipsum dolor sit amet, consectetur adipiscing elit,<templatestyles src="foo.css"/> sed do eiusmod tempor incididunt.

would incorrectly render like this with Raggett Tidy:

<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit,</p>
<style>...</style>
<p>sed do eiusmod tempor incididunt.</p>

Note the paragraph is broken at the <style> tag.

Tue, Jul 10, 2:27 PM · Reading-Infrastructure-Team-Backlog, Patch-For-Review, User-Zoranzoki21, Wikimedia-Site-requests, Chinese-Sites, TemplateStyles
Addshore awarded T198973: Wikibase tests are failing CI on unrelated changes a Cup of Joe token.
Tue, Jul 10, 8:51 AM · Release-Engineering-Team (Kanban), Wikidata-Campsite, Wikidata, Continuous-Integration-Infrastructure, Wikibase-DataModel-JavaScript

Mon, Jul 9

Anomie created T199152: mysql.php reacts to signals intended for mysql.
Mon, Jul 9, 8:52 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, MediaWiki-Maintenance-scripts
Anomie moved T199044: Special:ActiveUsers results in fatal exception of type "Wikimedia\Rdbms\DBQueryTimeoutError" from Ready to Waiting for Review on the MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018) board.
Mon, Jul 9, 7:37 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, Commons, User-Josve05a, MediaWiki-Special-pages, MediaWiki-Database, Wikimedia-log-errors
Anomie edited projects for T199044: Special:ActiveUsers results in fatal exception of type "Wikimedia\Rdbms\DBQueryTimeoutError", added: MediaWiki-Platform-Team (MWPT-Q1-Jul-Sep-2018); removed MediaWiki-Platform-Team.
Mon, Jul 9, 7:37 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, Commons, User-Josve05a, MediaWiki-Special-pages, MediaWiki-Database, Wikimedia-log-errors
Anomie added a comment to T199044: Special:ActiveUsers results in fatal exception of type "Wikimedia\Rdbms\DBQueryTimeoutError".

The part of the query on recentchanges here seems to be the problem. It's having to go through every user from querycachetwo that meets the other conditions in order to filter two for the result, and since it's doing a filesort it can't stop early as soon as it finds two that pass.

Mon, Jul 9, 4:23 PM · Core-Platform-Team (CPT-Q1-Jul-Sep-2018), Patch-For-Review, Commons, User-Josve05a, MediaWiki-Special-pages, MediaWiki-Database, Wikimedia-log-errors

Sun, Jul 8

Anomie added a comment to T198525: Can't log into mobile on Commons.

rMW23706be35c03: Disable WebResponse setters for post-send processing broke the WebResponseSetCookie hook's ability to alter the cookie being set, which broke the mobile hack for T49647: meta.m.wikimedia.org user login doesn't work, so it was trying to set the CentralAuth cookies with domain=commons.wikimedia.org instead of domain=commons.m.wikimedia.org.

Sun, Jul 8, 7:32 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, MediaWiki-Authentication-and-authorization, Wikimedia-General-or-Unknown

Fri, Jul 6

Anomie added a comment to T190015: Create separate user group for editing sitewide CSS/JavaScript that does not include administrators by default.

Both this and T71445 are useful things to do.

Fri, Jul 6, 4:21 PM · User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, Patch-For-Review, Security, JavaScript, Security-Core
Anomie triaged T198973: Wikibase tests are failing CI on unrelated changes as Unbreak Now! priority.
Fri, Jul 6, 3:01 PM · Release-Engineering-Team (Kanban), Wikidata-Campsite, Wikidata, Continuous-Integration-Infrastructure, Wikibase-DataModel-JavaScript
Anomie created T198973: Wikibase tests are failing CI on unrelated changes.
Fri, Jul 6, 3:01 PM · Release-Engineering-Team (Kanban), Wikidata-Campsite, Wikidata, Continuous-Integration-Infrastructure, Wikibase-DataModel-JavaScript
Anomie moved T198935: Clean up the mess with one-off transformations for some preferences from Unsorted to Non-core-API stuff on the MediaWiki-API board.
Fri, Jul 6, 1:48 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, MediaWiki-API, Community-Tech-Sprint, MediaWiki-User-preferences

Thu, Jul 5

Anomie added a project to T198916: Investigate and improve MediaWiki Action API documentation : Documentation.

There are currently 26 open tasks tagged with MediaWiki-API and Documentation, but most don't seem relevant to the scope of this task. At first glance, these do:

Thu, Jul 5, 9:42 PM · Goal, Documentation, Developer-Advocacy (Jul-Sep 2018), MediaWiki-API
Anomie added a comment to T59176: ApiQueryExtLinksUsage::run query has crazy limit.

Yes. I forgot there was a checklist in here.

Thu, Jul 5, 6:34 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), MW-1.29-release-notes, Patch-For-Review, Schema-change, DBA, MediaWiki-API, Performance, MediaWiki-Database
Anomie updated the task description for T59176: ApiQueryExtLinksUsage::run query has crazy limit.
Thu, Jul 5, 6:34 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), MW-1.29-release-notes, Patch-For-Review, Schema-change, DBA, MediaWiki-API, Performance, MediaWiki-Database
Anomie added a comment to T197891: Schema change to drop default from externallinks.el_index_60.

@Anomie this is how the table looks like after the alter:

Thu, Jul 5, 5:20 PM · Patch-For-Review, Schema-change, DBA
Anomie added a comment to T196379: Schema change: Add unique index on archive.ar_rev_id.

@Anomie this is how the table looks like once altered in codfw:

Thu, Jul 5, 5:13 PM · Patch-For-Review, Schema-change, DBA
Anomie added a comment to T133410: Deploy TemplateStyles to WMF production.

Added a mention in https://www.mediawiki.org/w/index.php?title=Extension:TemplateStyles&diff=2822114&oldid=2810115.

Thu, Jul 5, 4:38 PM · Epic, Performance-Team (Radar), User-notice, Readers-Web-Backlog (Tracking), Traffic, Operations, Wikimedia-Extension-setup, TemplateStyles
Anomie added a comment to T198701: Create RevisionStoreFactory [MCR].

Perhaps we could use SiteConfiguration to gain access to the various migration stages on the different wikis: If a SiteConfiguration is injected, the local values of the migrations tage for MCR, CommentStore and Actor are overwritten by the value for the target wiki retrieved from SiteConfiguration.

Thu, Jul 5, 3:59 PM · Patch-For-Review, User-Addshore, Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), Wikidata