Page MenuHomePhabricator

Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (17)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (270 w, 2 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Today

Anomie closed T240567: luasandbox on Debian Buster pulls in some default php7.3 packages though PHP 7.4 is installed from a DPA as Invalid.

There's no bug in LuaSandbox here. It compiles and passes tests with PHP 7.4.1.[1] The issues described here are entirely due to an attempt to mix third-party[2] packages from different sources.

Thu, Dec 12, 3:06 PM · LuaSandbox, PHP 7.4 support, User-MacFan4000
Anomie moved T240565: Expose own IP address in API from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Thu, Dec 12, 2:46 PM · Patch-For-Review, User-Michael, Privacy, MediaWiki-API, Core Platform Team
Anomie removed projects from T240519: Upstream API error handling from VisualEditor to MediaWiki: Core Platform Team, MediaWiki-API.

As this task relates to a particular library for accessing the API rather than the API itself, removing MediaWiki-API.

Thu, Dec 12, 2:46 PM · Patch-For-Review, VisualEditor (Current work), MediaWiki-General, DiscussionTools
Anomie moved T240565: Expose own IP address in API from Unsorted to Needs details or plan on the MediaWiki-API board.

I note you could do this by forcing a logged-out response, as that reports the IP as the username. There are a few ways to do that. Given that, adding the client IP specifically to meta=userinfo doesn't seem like much of a problem.

Thu, Dec 12, 2:40 PM · Patch-For-Review, User-Michael, Privacy, MediaWiki-API, Core Platform Team

Yesterday

Anomie added a comment to T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5].

Could that be deferred until the point where the User object would usually be initialized from the session?

Wed, Dec 11, 7:15 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikidata, Wikimedia-production-error
Anomie added a comment to T239645: Postgres error on type mismatch.

After digging into the call stack, it seems likely it was the same underlying issue as T239877, fixed by 9a1ecf2ef.

Wed, Dec 11, 3:56 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Parser, PostgreSQL
Anomie moved T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5] from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Wed, Dec 11, 3:22 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikidata, Wikimedia-production-error
Anomie added a comment to T240083: "User::loadFromSession called before the end of Setup.php" (violation by Wikibase/ULS) [Story Points 5].

User::saveSettings is calling Title::purgeSquid. It is undocumented why changing preferences requires purging the user page, unconditionally, synchronously.

Wed, Dec 11, 3:22 PM · Core Platform Team Workboards (Clinic Duty Team), Core Platform Team, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseClient, UniversalLanguageSelector, Wikidata, Wikimedia-production-error
Anomie moved T240418: Slow query on arwiki for ApiQueryUserContribs::execute from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Dec 11, 2:56 PM · mariadb-optimizer-bug, Core Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms, Performance Issue
Anomie edited projects for T240418: Slow query on arwiki for ApiQueryUserContribs::execute, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.

Typical bad planner choice. It's meant to be using the actor_timestamp index on revision_actor_temp. If we force that:

wikiadmin@10.64.48.109(arwiki)> explain SELECT /* ApiQueryUserContribs::execute */ rev_id, rev_page, rev_timestamp, rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_sha1, comment_rev_comment.comment_text AS `rev_comment_text`, comment_rev_comment.comment_data AS `rev_comment_data`, comment_rev_comment.comment_id AS `rev_comment_cid`, actor_rev_user.actor_user AS `rev_user`, actor_rev_user.actor_name AS `rev_user_text`, temp_rev_user.revactor_actor AS `rev_actor`, page_namespace, page_title, page_id, page_latest, page_is_redirect, page_len FROM `revision` JOIN `revision_comment_temp` `temp_rev_comment` ON ((temp_rev_comment.revcomment_rev = rev_id)) JOIN `comment` `comment_rev_comment` ON ((comment_rev_comment.comment_id = temp_rev_comment.revcomment_comment_id)) JOIN `revision_actor_temp` `temp_rev_user` force index (actor_timestamp) ON ((temp_rev_user.revactor_rev = rev_id)) JOIN `actor` `actor_rev_user` ON ((actor_rev_user.actor_id = temp_rev_user.revactor_actor)) JOIN `page` ON ((page_id = rev_page)) WHERE ((temp_rev_user.revactor_actor = 8)) AND ((rev_deleted & 4) != 4) ORDER BY revactor_timestamp, revactor_rev LIMIT 2;
+------+-------------+---------------------+--------+--------------------------------------------------------+-----------------+---------+-----------------------------------------------+----------+--------------------------+
| id   | select_type | table               | type   | possible_keys                                          | key             | key_len | ref                                           | rows     | Extra                    |
+------+-------------+---------------------+--------+--------------------------------------------------------+-----------------+---------+-----------------------------------------------+----------+--------------------------+
|    1 | SIMPLE      | actor_rev_user      | const  | PRIMARY                                                | PRIMARY         | 8       | const                                         |        1 |                          |
|    1 | SIMPLE      | temp_rev_user       | ref    | actor_timestamp                                        | actor_timestamp | 8       | const                                         | 16759310 | Using where; Using index |
|    1 | SIMPLE      | temp_rev_comment    | ref    | PRIMARY,revcomment_rev                                 | PRIMARY         | 4       | arwiki.temp_rev_user.revactor_rev             |        1 | Using index              |
|    1 | SIMPLE      | comment_rev_comment | eq_ref | PRIMARY                                                | PRIMARY         | 8       | arwiki.temp_rev_comment.revcomment_comment_id |        1 |                          |
|    1 | SIMPLE      | revision            | eq_ref | PRIMARY,page_timestamp,page_user_timestamp,rev_page_id | PRIMARY         | 4       | arwiki.temp_rev_user.revactor_rev             |        1 | Using where              |
|    1 | SIMPLE      | page                | eq_ref | PRIMARY                                                | PRIMARY         | 4       | arwiki.revision.rev_page                      |        1 |                          |
+------+-------------+---------------------+--------+--------------------------------------------------------+-----------------+---------+-----------------------------------------------+----------+--------------------------+
wikiadmin@10.64.48.109(arwiki)> SELECT /* ApiQueryUserContribs::execute */ rev_id, rev_page, rev_timestamp, rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_sha1, comment_rev_comment.comment_text AS `rev_comment_text`, comment_rev_comment.comment_data AS `rev_comment_data`, comment_rev_comment.comment_id AS `rev_comment_cid`, actor_rev_user.actor_user AS `rev_user`, actor_rev_user.actor_name AS `rev_user_text`, temp_rev_user.revactor_actor AS `rev_actor`, page_namespace, page_title, page_id, page_latest, page_is_redirect, page_len FROM `revision` JOIN `revision_comment_temp` `temp_rev_comment` ON ((temp_rev_comment.revcomment_rev = rev_id)) JOIN `comment` `comment_rev_comment` ON ((comment_rev_comment.comment_id = temp_rev_comment.revcomment_comment_id)) JOIN `revision_actor_temp` `temp_rev_user` force index (actor_timestamp) ON ((temp_rev_user.revactor_rev = rev_id)) JOIN `actor` `actor_rev_user` ON ((actor_rev_user.actor_id = temp_rev_user.revactor_actor)) JOIN `page` ON ((page_id = rev_page)) WHERE ((temp_rev_user.revactor_actor = 8)) AND ((rev_deleted & 4) != 4) ORDER BY revactor_timestamp, revactor_rev LIMIT 2;
[...]
2 rows in set (0.00 sec)
Wed, Dec 11, 2:56 PM · mariadb-optimizer-bug, Core Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms, Performance Issue
Anomie moved T240405: WikiPage::updateCategoryCounts causing replication lag due to long-running writes on commonswiki from Inbox to Waiting for deployment on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Dec 11, 2:46 PM · Core Platform Team Workboards (Clinic Duty Team), Release-Engineering-Team, Wikimedia-Rdbms, Operations
Anomie edited projects for T240405: WikiPage::updateCategoryCounts causing replication lag due to long-running writes on commonswiki, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Wed, Dec 11, 2:46 PM · Core Platform Team Workboards (Clinic Duty Team), Release-Engineering-Team, Wikimedia-Rdbms, Operations
Anomie added a comment to T240405: WikiPage::updateCategoryCounts causing replication lag due to long-running writes on commonswiki.

I think that rMW8acea5491dce: Handle database error with LinksUpdate and numeric category names fixes this. That patch is in wmf.10, but wasn't backported to wmf.8.

Wed, Dec 11, 2:45 PM · Core Platform Team Workboards (Clinic Duty Team), Release-Engineering-Team, Wikimedia-Rdbms, Operations

Tue, Dec 10

Anomie added a comment to T240307: Hook container with strong types and DI.

Long-term direction being that core namespaces would be more akin to extension namespaces in that MediaWiki\Watchlist would not only contain the value classes and service classes, but also the API/Special subclasses.

Tue, Dec 10, 7:15 PM · User-Daniel, Core Platform Team, TechCom-RFC
Anomie removed projects from T240316: Issue with QuickStatements "you are blocked on Wikidata": Core Platform Team, MediaWiki-API.

Actually the reason is QuickStatements use a single IP to edit on behalf of different users, so once a QuickStatement user is blocked other is autoblocked.
Therefore the toolforge IP range should be added to https://www.wikidata.org/wiki/MediaWiki:Autoblock_whitelist. we have 10.0.0.0/8 in the list, but the IP range of Labs is now 172.16.0.0/12.

Tue, Dec 10, 5:57 PM · User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata
Anomie added a comment to T240307: Hook container with strong types and DI.

I don't feel strongly either way on that. If we often had code calling hooks from different subsystems there would be advantage to not requiring that code to have multiple HookRunner-type objects, but that doesn't seem likely to actually be the case. Usually code only has one hook, or a few that are related enough they'd probably be in the same runner anyway.

Tue, Dec 10, 5:44 PM · User-Daniel, Core Platform Team, TechCom-RFC
Anomie added a comment to T107610: Setup separate logical External Store for Flow in production.

It doesn't look like ExternalStoreDB currently supports overriding the dbname, it always uses $wgDBname (or an LBFactory thing that corresponds to it).

Tue, Dec 10, 3:55 PM · Growth-Team, DBA, Operations, WorkType-Maintenance, StructuredDiscussions
Anomie added a comment to T239213: Conflicting timestamp in file history.

Any image with a version showing "No thumbnail" will probably give you the response described in this task. It's not necessary to give more examples of the same.

Tue, Dec 10, 3:21 PM · Regression, Core Platform Team Workboards (Clinic Duty Team), Pywikibot-Commons, MW-1.34-release, MediaWiki-API, Pywikibot, MediaWiki-File-management, Commons
Anomie added a comment to T240307: Hook container with strong types and DI.

I note that for cases where ExtensionFoo wants to add a listener for a hook from ExtensionBar but also wants to maintain the ability to be used when ExtensionBar is not installed, it will need to register a separate listener just for ExtensionBar's hooks because the requisite interfaces won't be available when ExtensionBar is not available. That seems easily possible with the design described here, but may warrant documentation as it may not be immediately obvious.

Tue, Dec 10, 3:08 PM · User-Daniel, Core Platform Team, TechCom-RFC

Mon, Dec 9

Anomie added a comment to T237709: Cannot view diffs on Special:Undelete - ends in InvalidArgumentException.

If I'm reading the roadmap correctly, the fix is due to roll out for enwiki as part of 1.35.0-wmf.10, on December 12th.
Somebody please correct me if I've misunderstood the roadmap.

Mon, Dec 9, 4:28 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Page-Diffs, MediaWiki-Page-deletion, Wikimedia-production-error
Anomie moved T70174: securepoll-votereligibility-list-* messages should be documented in comments from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 9, 2:57 PM · good first task, Core Platform Team, I18n, MediaWiki-extensions-SecurePoll
Anomie removed a project from T108414: Load API request count and latency data from Hadoop to a dashboard: Core Platform Team.
Mon, Dec 9, 2:57 PM · Better Use Of Data, Product-Analytics, Product-Infrastructure-Team-Backlog, Analytics, MediaWiki-API
Anomie removed a project from T208517: Should Wikibase add a property to the page response object that indicates the embedded entities?: Core Platform Team.

According to https://www.mediawiki.org/wiki/Extension:WikibaseMediaInfo#MediaInfo_Entity, the entity ID is "in the form Mxxx, where xxx is the id of the associated wiki page". So you can look at the pageid field in the response and prepend "M".

Mon, Dec 9, 2:56 PM · MediaWiki-API, SDC General, MediaWiki-extensions-WikibaseRepository, Wikidata
Anomie moved T240000: Config on the RequestContext may not be the same as the main config from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 9, 2:36 PM · Anti-Harassment, MediaWiki-General, Core Platform Team

Fri, Dec 6

Anomie added a comment to T239743: Provide cached access to Parsoid PHP within core.

Hey, @Pchelolo . Why does the cache have to be implemented within Parsoid/PHP? Couldn't it be implemented like...
[...]
That would keep the Parsoid/PHP code simpler, and let us use simpler caching mechanics.

Fri, Dec 6, 6:09 PM · User-ArielGlenn, Parsoid-PHP, Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
Anomie added a comment to T239878: Fatal error: "Call to a member function clear() on null" from TemplateStylesHooks.

Heh, this is the hard part. I see various paths:

  • $this->mFirstCall is set by something other than firstCallInit; specifically, something that does not trigger the ParserFirstCallInit hook
Fri, Dec 6, 4:55 PM · Product-Infrastructure-Team-Backlog, TemplateStyles, Wikimedia-production-error
Anomie added a comment to T239878: Fatal error: "Call to a member function clear() on null" from TemplateStylesHooks.

How is it managing to not create the member via the 'ParserFirstCallInit' hook? If nothing else, $parser->firstCallInit() is called at the start of clearState().

Yes, although AFAICS firstCallInit can return early if it's not the first call. Maybe the property is correctly created on the first call, but then deleted before clearState() is called?

Fri, Dec 6, 3:54 PM · Product-Infrastructure-Team-Backlog, TemplateStyles, Wikimedia-production-error
Anomie updated the task description for T161671: Compacting the revision table.
Fri, Dec 6, 3:01 PM · CPT Initiatives (Revision Storage Schema Improvements), MediaWiki-Revision-backend, Multi-Content-Revisions, Epic, Patch-For-Review, Schema-change
Anomie updated the task description for T161671: Compacting the revision table.
Fri, Dec 6, 3:00 PM · CPT Initiatives (Revision Storage Schema Improvements), MediaWiki-Revision-backend, Multi-Content-Revisions, Epic, Patch-For-Review, Schema-change
Anomie added a comment to T239591: Update mediawiki-history to use new Multi-Content-Revision tables.

The text-related fields (text_id, text_len) are planned to be deleted from the revisiontable, and access for the same data will need to use slots and content tables.

Fri, Dec 6, 2:56 PM · Core Platform Team, Analytics
Anomie moved T239591: Update mediawiki-history to use new Multi-Content-Revision tables from Inbox to Tracking/Watching on the Core Platform Team board.
Fri, Dec 6, 2:34 PM · Core Platform Team, Analytics
Anomie removed a project from T205357: SpecialApiSandbox needs PHPUnit integration tests: Core Platform Team.
Fri, Dec 6, 2:33 PM · Google-Code-in-2019, Google-Code-in-2018, Test-Coverage, MediaWiki-API
Anomie moved T239972: ApiQueryAbuseLog: user_rights should be provided as an array from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Fri, Dec 6, 2:33 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-API, AbuseFilter
Anomie edited projects for T239972: ApiQueryAbuseLog: user_rights should be provided as an array, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Fri, Dec 6, 2:32 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-API, AbuseFilter

Thu, Dec 5

Anomie added a comment to T239900: Sync understanding of MediaWiki rdbms 'weight' behaviour with DBAs.

We used to have vslow,dump with weight 0 just in case the dumps could create lag with the heavy queries.
I do see a reason to keep replicas with weight 0 for that specific reason, dumps is a good example, we have hosts that we still have pooled for an specific kind of traffic that might be ok with lag or some lag at least.

Thu, Dec 5, 7:41 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-Rdbms
Anomie added a comment to T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".

These queries showed up at the time of the incident, and I cannot see them happening before it:
P9822
I have not been able to see those slow queries before 4th Dec 20:21 UTC, so they might be new and could be potentially causing issues. They are definitely very slow and need to be looked at.

Thu, Dec 5, 5:44 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Anomie added a comment to T239900: Sync understanding of MediaWiki rdbms 'weight' behaviour with DBAs.

We can't entirely throw away the loadbalancer/lbfactory code, as it's also used to manage connections to different (conceptual) databases. For example, connecting to the current wiki's main DB versus one of the several ExternalStore DBs (two active, several others read-only) versus Commons or Wikidata's DB (rather than making an internal HTTP request) versus the shared DB for CentralAuth data. Even if haproxy can handle routing requests by the MySQL database being connected to (can it?), we'd still probably lose the ability to reuse the same opened connection for all s3 wikis instead of reconnecting a few hundred times as we cycle through them all.

Thu, Dec 5, 5:02 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-Rdbms
Anomie added a comment to T239878: Fatal error: "Call to a member function clear() on null" from TemplateStylesHooks.

How is it managing to not create the member via the 'ParserFirstCallInit' hook? If nothing else, $parser->firstCallInit() is called at the start of clearState().

Thu, Dec 5, 4:13 PM · Product-Infrastructure-Team-Backlog, TemplateStyles, Wikimedia-production-error
Anomie moved T239883: Watchlist api: Anon flag omitted if false in formatversion=2 from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.

DannyS712 edited projects, added Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
DannyS712 moved this task from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.

Thu, Dec 5, 4:07 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-API
Anomie added a comment to T239883: Watchlist api: Anon flag omitted if false in formatversion=2.

That was intentional. Values that are often going to be false are sometimes still omitted.

Thu, Dec 5, 4:04 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-API
Anomie closed T239916: Cascading protection on different than sysop levels has not valid effect - protection works as sysop-protected regardless of another level set as Invalid.

This report seems to be based on an incorrect understanding of how protection actually works. As the only part of this that seems potentially accurate is a duplicate of T71607, I'm going to close this as Invalid.

Thu, Dec 5, 3:59 PM · MediaWiki-Page-protection, Core Platform Team
Anomie closed T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title, a subtask of T87645: Existing pages without ability to reach and obviously wrong namespace, as Resolved.
Thu, Dec 5, 3:58 PM · User-Ladsgroup, Chinese-Sites, Wikimedia-General-or-Unknown
Anomie closed T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title as Resolved.
Thu, Dec 5, 3:58 PM · MW-1.33-notes, MW-1.31-release-notes, MW-1.32-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie updated subscribers of T239466: Possible to circumvent title-blacklist (CVE-2019-19709).

@sbassett: I'm backporting the fix for this to Wikimedia sites now. I'll leave it to your team to backport the fix to 1.34 and earlier, if you feel that would be desirable.

Thu, Dec 5, 3:09 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie moved T239900: Sync understanding of MediaWiki rdbms 'weight' behaviour with DBAs from Inbox to Discussing on the Core Platform Team Workboards (Clinic Duty Team) board.
Thu, Dec 5, 3:01 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-Rdbms
Anomie edited projects for T239900: Sync understanding of MediaWiki rdbms 'weight' behaviour with DBAs, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Thu, Dec 5, 3:01 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-Rdbms
Anomie added a comment to T239900: Sync understanding of MediaWiki rdbms 'weight' behaviour with DBAs.
  1. Does MediaWiki as used by WMF (wikimedia/rdbms, LBFactoryMulti) support giving the master db non-zero weight in terms of read queries intended for replicas?
Thu, Dec 5, 3:01 PM · Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-Rdbms

Wed, Dec 4

Anomie closed T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via SpecialNewFiles) as Resolved.

Again, the other patch should still proceed on its own merits, even though the log message this task is about has been resolved.

Wed, Dec 4, 9:41 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, MediaWiki-Special-pages, User-D3r1ck01, Patch-For-Review, Wikimedia-production-error
Anomie closed T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange) as Resolved.
Wed, Dec 4, 9:40 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie removed a project from T239459: service-runner apps (wikifeeds/cxserver at the least) running on kubernetes emit logs with log level 50 : Core Platform Team.
Wed, Dec 4, 7:55 PM · Core Platform Team Workboards (Clinic Duty Team), CX-cxserver, serviceops-radar, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Operations
Anomie moved T111789: Disallow renaming own accounts with Special:GlobalRenameQueue from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Wed, Dec 4, 7:48 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Majavah, MediaWiki-extensions-CentralAuth, GlobalRename
daniel awarded T239717: Incorrect rev_sha1 and rev_len on some revisions a The World Burns token.
Wed, Dec 4, 7:48 PM · Core Platform Team Workboards (Clinic Duty Team), User-Daniel, CPT Initiatives (MCR), Multi-Content-Revisions
Anomie edited projects for T111789: Disallow renaming own accounts with Special:GlobalRenameQueue, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Wed, Dec 4, 7:48 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Majavah, MediaWiki-extensions-CentralAuth, GlobalRename
Anomie claimed T207217: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via SpecialNewFiles).

I'm going to reassign this task to myself and submit a less ambitious fix, since the existing patch seems stalled. The existing patch would still probably be an improvement.

Wed, Dec 4, 2:54 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-User-management, MediaWiki-Special-pages, User-D3r1ck01, Patch-For-Review, Wikimedia-production-error
Anomie claimed T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange).
Wed, Dec 4, 2:53 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie edited projects for T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange), added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Wed, Dec 4, 2:52 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie added a comment to T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange).

If we uphold that this is the callers responsibility, then, after these two issues are fixed, this might be a good place to adopt a type hint so as to make these fail hard instead of allowing execution to silently continue.

Wed, Dec 4, 2:05 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie removed a project from T239772: ActorMigration.php: PHP Warning: Invalid argument supplied for foreach (via RevisionStore::getRecentChange): MediaWiki-API.
Wed, Dec 4, 2:04 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend, Wikimedia-production-error
Anomie updated the task description for T239809: Book refs confuse in-text numbering..
Wed, Dec 4, 1:14 PM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing
Anomie created T239810: Book refs cannot extend references defined in {{#tag:references}}.
Wed, Dec 4, 1:10 PM · Book-Referencing
Anomie created T239809: Book refs confuse in-text numbering..
Wed, Dec 4, 1:10 PM · WMDE-QWERTY-Sprint-2019-12-11, WMDE-QWERTY-Sprint-2019-11-20, Book-Referencing
Anomie added a comment to T239788: Same extension creates new subref .

This would be inconsistent with the behavior of <ref> tags that don't use "extends". See also T11945: Automatically combine <ref>s containing the same text and T18222: Merge references stated multiple times (if 100% equal).

Wed, Dec 4, 12:55 PM · Book-Referencing

Tue, Dec 3

Anomie removed a project from T145050: Wikibase API should use the modern JSON syntax in API response on formatversion=2: Core Platform Team.
Tue, Dec 3, 9:16 PM · MediaWiki-API, MediaWiki-extensions-WikibaseRepository, Wikidata
Anomie added a comment to T239527: list=blocks does not support IPv4 ranges.

Probably the thing to do would be to create "User::isIPRange()" or the like, fix User::isIP to not return true for IPv6 ranges, and switch callers of isIP to the new method where that seems to give more-correct behavior.

Tue, Dec 3, 5:13 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie added a comment to T195807: Fix failing MediaWiki core tests on Postgres database backend.

Ideally people would CR-1 patches trying to add new skips of that type.

Tue, Dec 3, 4:57 PM · Core Platform Team, MediaWiki-Revision-backend, Wikimedia-production-error (Shared Build Failure), PostgreSQL
Anomie added a comment to T239639: Add filtering to list=allimages for feature parity with Special:NewFiles.

What I'd like is the ability to make an API request that returns the same info as is available at https://commons.wikimedia.org/wiki/Special:NewFiles . The second page has many more pictures available. Note that the first page has only a couple of pictures from September, then before that nothing all the way back to mid March.

Tue, Dec 3, 4:51 PM · MediaWiki-API, Core Platform Team
Anomie moved T239717: Incorrect rev_sha1 and rev_len on some revisions from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Tue, Dec 3, 3:09 PM · Core Platform Team Workboards (Clinic Duty Team), User-Daniel, CPT Initiatives (MCR), Multi-Content-Revisions
Anomie created T239717: Incorrect rev_sha1 and rev_len on some revisions.
Tue, Dec 3, 3:03 PM · Core Platform Team Workboards (Clinic Duty Team), User-Daniel, CPT Initiatives (MCR), Multi-Content-Revisions
Anomie moved T235769: Add before execute hook into Special:Import and ApiImport from Inbox to External Code Review Needed on the Core Platform Team Workboards (Clinic Duty Team) board.
Tue, Dec 3, 2:21 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Rxy, MediaWiki-Export-or-Import
Anomie edited projects for T235769: Add before execute hook into Special:Import and ApiImport, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Tue, Dec 3, 2:21 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-Rxy, MediaWiki-Export-or-Import

Mon, Dec 2

Anomie moved T235207: Some MediaWiki API call examples show an empty result set due to hardcoded "Main Page" title from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Dec 2, 7:42 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Documentation, MediaWiki-API
Anomie edited projects for T235207: Some MediaWiki API call examples show an empty result set due to hardcoded "Main Page" title, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Mon, Dec 2, 7:42 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Documentation, MediaWiki-API
Anomie moved T204193: SecurePoll auth-api.php needs to be rewritten to be a normal api module from External Code Review Needed to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Dec 2, 7:14 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-Needs-Improvement, Africa-Wikimedia-Developers, good first task, MediaWiki-extensions-SecurePoll
Anomie moved T239648: Document mapping between Special Pages and API modules from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 2, 7:10 PM · Documentation, MediaWiki-Special-pages, Core Platform Team, MediaWiki-API
Anomie moved T239648: Document mapping between Special Pages and API modules from Unsorted to Needs details or plan on the MediaWiki-API board.

The easiest and most flexible thing might be to just add the information to the existing on-wiki help pages linked from the special pages and Action API auto-generated docs, e.g. https://www.mediawiki.org/wiki/Help:New_files and https://www.mediawiki.org/wiki/API:Allimages for the pair mentioned in T239639.

Mon, Dec 2, 7:10 PM · Documentation, MediaWiki-Special-pages, Core Platform Team, MediaWiki-API
Anomie moved T132720: ApiHelp on api.php should set OutputPage::disallowUserJs from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 2, 7:03 PM · Core Platform Team, Security-team-backlog, MediaWiki-API
Anomie moved T195807: Fix failing MediaWiki core tests on Postgres database backend from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 2, 7:01 PM · Core Platform Team, MediaWiki-Revision-backend, Wikimedia-production-error (Shared Build Failure), PostgreSQL
Anomie moved T239639: Add filtering to list=allimages for feature parity with Special:NewFiles from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 2, 7:00 PM · MediaWiki-API, Core Platform Team
Anomie moved T239639: Add filtering to list=allimages for feature parity with Special:NewFiles from Unsorted to Needs Code on the MediaWiki-API board.

I note Special:NewFiles seems almost the same as the existing list=allimages with aisort=timestamp. Missing features are the media type filters and an equivalent to the "Hide patrolled uploads" checkbox. The best thing to do would probably be to add those features to the existing module.

Mon, Dec 2, 6:51 PM · MediaWiki-API, Core Platform Team
Anomie added a comment to T239350: SQL Injection Vulnerabilities in MediaWiki using PostgreSQL db.

Though I'm not sure if the following non-security bug needs a task to address it (or if one exists):

I did get an error here, but not because of anything in the query. The cause is a MySQLism introduced in rMWd4efceaac90b: Join decomposition on change_tag and change_tag_def when filtering. Once I fix that, no error results.

Mon, Dec 2, 5:01 PM · PostgreSQL, MediaWiki-General, Security-Team, Security
Anomie added a comment to T234450: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException.

I'm guessing that fixing the underlying issue here [that there's not a direct connection between a Mediawiki appserver giving up on a request (e.g. due to timeout) and the cancellation of the corresponding MySQL query] is probably difficult, but I think it does seem worthy of some CPT time in the future.

Mon, Dec 2, 4:55 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), Vuln-DoS, Security, Performance Issue, MediaWiki-Special-pages, Wikimedia-production-error
Anomie reopened T195807: Fix failing MediaWiki core tests on Postgres database backend as "Open".

Reopening, there are still several tests with "FIXME: fails under postgres".

Mon, Dec 2, 4:05 PM · Core Platform Team, MediaWiki-Revision-backend, Wikimedia-production-error (Shared Build Failure), PostgreSQL
Anomie removed a project from T145541: Make Hovercards work with Special:MyLanguage links: Core Platform Team.
Mon, Dec 2, 4:01 PM · MediaWiki-Internationalization, Readers-Web-Backlog, MediaWiki-API, Page-Previews
Anomie moved T43838: Make it possible for users without the editinterface right to edit the AbuseFilter messages from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 2, 4:00 PM · User-DannyS712, Core Platform Team, AbuseFilter
Anomie moved T239451: DBPerformance: Unexpected masterConns on GET from ApiQueryInfo via BlockManager.php from Inbox to Triage Meeting Inbox on the Core Platform Team board.
Mon, Dec 2, 3:58 PM · Patch-For-Review, Wikimedia-production-error, MediaWiki-API, Core Platform Team, MediaWiki-User-management, Anti-Harassment, Performance-Team (Radar)
Anomie updated subscribers of T239483: Make sure CPT patches in Gerrit not linked to a Phab task are looked at.

Pinging @WDoranWMF and @CCicalese_WMF, who seem most likely to know how to answer this.

Mon, Dec 2, 3:58 PM · User-WDoran, Core Platform Team, Code-Review-Workgroup
Anomie added a comment to T239527: list=blocks does not support IPv4 ranges.

I have a tiny worry some consumers of Users:isIP rely on this misbehaviour, but the tests are all green.

Mon, Dec 2, 3:52 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie moved T239527: list=blocks does not support IPv4 ranges from Inbox to External Code Review In Progress on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Dec 2, 2:47 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie edited projects for T239527: list=blocks does not support IPv4 ranges, added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Mon, Dec 2, 2:47 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MediaWiki-API
Anomie added a comment to T239466: Possible to circumvent title-blacklist (CVE-2019-19709).

See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/554084, which incidentally fixes this while fixing T239428.

Mon, Dec 2, 2:45 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie moved T239466: Possible to circumvent title-blacklist (CVE-2019-19709) from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Dec 2, 2:45 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie edited projects for T239466: Possible to circumvent title-blacklist (CVE-2019-19709), added: Core Platform Team Workboards (Clinic Duty Team); removed Core Platform Team.
Mon, Dec 2, 2:44 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie moved T239466: Possible to circumvent title-blacklist (CVE-2019-19709) from Unsorted to Needs Review on the MediaWiki-API board.
Mon, Dec 2, 2:44 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie moved T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title from Unsorted to Needs Review on the MediaWiki-API board.
Mon, Dec 2, 2:42 PM · MW-1.33-notes, MW-1.31-release-notes, MW-1.32-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie moved T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title from Inbox to Waiting for Review on the Core Platform Team Workboards (Clinic Duty Team) board.
Mon, Dec 2, 2:42 PM · MW-1.33-notes, MW-1.31-release-notes, MW-1.32-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie added a comment to T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title.
Mon, Dec 2, 2:38 PM · MW-1.33-notes, MW-1.31-release-notes, MW-1.32-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie claimed T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title.
Mon, Dec 2, 2:37 PM · MW-1.33-notes, MW-1.31-release-notes, MW-1.32-notes, MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API
Anomie added a comment to T239466: Possible to circumvent title-blacklist (CVE-2019-19709).

Yes, that's indeed the case. TitleBlacklist thinks the page being created is "w:Google.123.html", which doesn't match the specific rule in question. Rules beginning with .*, like most on the current blacklist, do not seem able to be bypassed in this manner since the .* will match the spurious interwiki prefix.

Mon, Dec 2, 2:28 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie added a comment to T239466: Possible to circumvent title-blacklist (CVE-2019-19709).

It seems likely that fixing T239428: API edit on page with non-resolvable redirect and redirect=1 creates page with invalid title will also fix this.

Mon, Dec 2, 2:12 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-API, TitleBlacklist, Security
Anomie closed T239410: API: Provide parsedtags information as Declined.

As the developer of DannyS712-Global_watchlist.js, I want an option to, via the watchlist api, retrieve the parsed html of tags associated with an edit, instead of just the plain text

Mon, Dec 2, 2:04 PM · Core Platform Team, MediaWiki-Watchlist, User-DannyS712, Growth-Team, MediaWiki-API