Page MenuHomePhabricator

Anomie (Brad Jorsch)
Senior Software Engineer, WMF

Projects (16)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 1:25 PM (232 w, 1 d)
Availability
Available
IRC Nick
anomie
LDAP User
Anomie
MediaWiki User
Anomie [ Global Accounts ]

Recent Activity

Yesterday

thiemowmde awarded T218324: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants redundant "mixed|null" a Like token.
Wed, Mar 20, 8:18 PM · MediaWiki-Codesniffer
Anomie added a comment to T218816: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants null even if type is nullable.

?string and string|null mean the same thing, I suppose the question is which of those we want in the docs.

Wed, Mar 20, 7:46 PM · MediaWiki-Codesniffer
Anomie created T218797: Code sniffer expects mismatched syntax for referenced varargs @params.
Wed, Mar 20, 4:14 PM · MediaWiki-Codesniffer

Tue, Mar 19

Anomie added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.
2019-01-15 09:53:13 [XD2tiApAAD0AAEcJ8wsAAAAR] mw1266 zhwiki 1.33.0-wmf.12 exception ERROR: [XD2tiApAAD0AAEcJ8wsAAAAR] /zh-cn/Delon_Thamrin   MediaWiki\Revision\RevisionAccessException from line 1465 of /srv/mediawiki/php-1.33.0-wmf.12/includes/Revision/RevisionStore.php: Failed to load data blob from tt:9375723: Failed to load blob from address tt:9375723 {"exception_id":"XD2tiApAAD0AAEcJ8wsAAAAR","exception_url":"/zh-cn/Delon_Thamrin","caught_by":"mwe_handler"}
Tue, Mar 19, 7:07 PM · Patch-For-Review, MediaWiki-Revision-backend, Core Platform Team Kanban (Doing), Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
Anomie added a comment to T218674: User::getRights() applies session rights restrictions to non-session users.

Looks like that check was first added in rSVN56325, fixing a similar bug where it was using the request's IP when checking blocks for all User objects rather than only the session user. No indication as to whether they compared user names (versus mFrom === 'session' or the like) there for a specific reason or just because that seemed like the safest way to not maybe break something else.

Tue, Mar 19, 6:21 PM · MediaWiki-User-management, MediaWiki-API
Anomie added a comment to T203913: User.php: Cannot create a user with no name, no ID, and no actor ID (Unable to delete certain pages on Chinese Wikisource).

Copy-pasting from IRC #mediawiki-core:

Tue, Mar 19, 6:07 PM · Growth-Team, MediaWiki-Page-deletion, MediaWiki-User-management, Wikimedia-production-error, Chinese-Sites
Anomie added a project to T218702: ParserIntegrationTest for Scribunto failing in Wikibase CI: SyntaxHighlight.

Looks like two of the failures are in Scribunto, but the other 9 are in SyntaxHighlight.

Tue, Mar 19, 5:29 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), SyntaxHighlight, User-Addshore, Wikimedia-production-error (Shared Build Failure), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-Scribunto, MediaWiki-Core-Testing
Anomie created T218674: User::getRights() applies session rights restrictions to non-session users.
Tue, Mar 19, 1:56 PM · MediaWiki-User-management, MediaWiki-API

Mon, Mar 18

Anomie added a comment to T91454: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason.

Train blockers are UBN!

Mon, Mar 18, 10:27 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Analytics, Analytics-EventLogging, Google-Code-In-2015, good first bug, MediaWiki-API
Anomie added a comment to T91454: ApiJsonSchema implements ApiBase::getCustomPrinter for no good reason.

Change 264494 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Remove getCustomPrinter() from ApiJsonSchema

https://gerrit.wikimedia.org/r/264494

Mon, Mar 18, 3:51 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Analytics, Analytics-EventLogging, Google-Code-In-2015, good first bug, MediaWiki-API
Anomie added a comment to T215832: PHP Warning: LuaSandboxFunction::call(): Unable to convert object of type stdClass.

I see no instances of this message in Kibana for the past 30 days.

Mon, Mar 18, 3:42 PM · MediaWiki-extensions-Scribunto, Wikimedia-production-error
Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

I'm worried that we'll wind up doing more work to address mismatches between DBAL and MediaWiki than we would to just directly implement code that works as part of Wikimedia\Rdbms without mismatches.

Mon, Mar 18, 2:58 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie added a comment to T218127: Use CommentStoreComment throughout MediaWiki.

Well, Message doesn’t have to be the only way to do i18n. We can add some hook that lets us completely bypass the Message and comment_text, and instead directly return HTML based on the comment_data,

Mon, Mar 18, 2:44 PM · Shape Expressions, Wikidata, MediaWiki-Comment-backend
Anomie moved T218489: Add auprops=groupmemberships parameter to list=allusers from Unsorted to Needs details or plan on the MediaWiki-API board.

We'd have to investigate whether the added queries would be prohibitive from a performance perspective (requiring a lowered maximum for aulimit). Other than that, seems a straightforward request.

Mon, Mar 18, 1:32 PM · MediaWiki-API

Sat, Mar 16

Anomie updated subscribers of T218473: Simultaneous configuring of pending changes and page protection fails to apply page protection.

I confrm the Googol example at about 2019-03-16T13:42Z via the web UI. And I confirm it was "fixed" as of 14:10, probably thanks to DumbBOT's edit.

Sat, Mar 16, 2:54 PM · Performance-Team, MediaWiki-Page-protection, MediaWiki-extensions-FlaggedRevs

Fri, Mar 15

Anomie closed T183156: ApiFeatureUsage data is not being populated in the Beta Cluster as Resolved.

Let's call this resolved then, unless you want to keep it open for your check in 30 days?

Fri, Mar 15, 5:55 PM · Discovery-Search (Current work), Elasticsearch, Wikimedia-Logstash, Beta-Cluster-Infrastructure
Anomie changed the status of T188327: Deploy refactored actor storage from Open to Stalled.

Status update: Currently blocked on T215525: log_search rows with ls_field='target_author_actor' and empty ls_value are created during actor migration.

Fri, Mar 15, 4:44 PM · Core Platform Team Kanban (Doing), MW-1.32-notes, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, Core Platform Team (Code Health (TEC13)), Epic
Anomie added a comment to T183156: ApiFeatureUsage data is not being populated in the Beta Cluster.

Confirmed that deployment-elastic05 now contains indexes for apifeatureusage for the past two days, and seems to be receiving new entries. Thanks!

Fri, Mar 15, 3:26 PM · Discovery-Search (Current work), Elasticsearch, Wikimedia-Logstash, Beta-Cluster-Infrastructure
Anomie added a comment to T216297: Develop method for identifying reverts in EventBus data.

But I think there are several reasons why people have not been using them for reverts and instead relied on content-based revert detection, e.g. the fact that edits tagged "undo" might not actually be reverts because the user can modify the content before saving.

Fri, Mar 15, 3:14 PM · Core Platform Team Backlog (Watching / External), Contributors-Analysis, Product-Analytics

Thu, Mar 14

Anomie created T218324: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants redundant "mixed|null".
Thu, Mar 14, 5:23 PM · MediaWiki-Codesniffer
Anomie closed T213228: Implement class (name to be decided) to provide access to preprocessor, extensions, and other metadata needed by Parsoid as Resolved.
Thu, Mar 14, 4:49 PM · Patch-For-Review, Parsoid-PHP
Anomie added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.
  • includes/search/SearchPostgres.php

odd stuff, maybe @Anomie can help. Two uses seem completely pointless, the third one should probably use getQueryInfo?

Thu, Mar 14, 4:35 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

I note the review so far seems to have ignored that part of schema changes is checking the existing schema to determine whether the schema needs changing (MW currently does a somewhat crappy job of this).

Good point but I think we should focus scope of this ticket to unify and abstract away schema changes and not fix all of the issues with our current schema change system.

Thu, Mar 14, 4:07 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie added a comment to T216689: Merge blocker: quibble-vendor-mysql-hhvm-docker in gate fails for most merges (exit status -11).
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x00007f557214ac5e in __pthread_create_2_1 (newthread=newthread@entry=0x7f55614b9e18, attr=attr@entry=0x7f5552aa62f8, 
    start_routine=start_routine@entry=0x7f556f461c20 <timer_sigev_thread>, arg=<optimized out>) at pthread_create.c:813
813	pthread_create.c: No such file or directory.
[Current thread is 1 (Thread 0x7f55614be3c0 (LWP 2354))]
Thu, Mar 14, 3:50 PM · Wikimedia-production-error (Shared Build Failure), Language-Team (Language-2019-January-March), Continuous-Integration-Infrastructure, HHVM

Wed, Mar 13

Anomie added a comment to T218127: Use CommentStoreComment throughout MediaWiki.

If we want to remove the Message handling from CommentStore and let Wikibase do its i18n based on ->data (in either a modified 'FormatAutocomments' that gets the data or some higher-level hook added to Linker::formatComment()), I can't think of any major objection at the moment.

Wed, Mar 13, 5:45 PM · Shape Expressions, Wikidata, MediaWiki-Comment-backend
Anomie added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

I'll also remove any references to the other two fields [text.old_id and archive.ar_text_id]

Wed, Mar 13, 5:35 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
Anomie added a comment to T217973: mw.ustring.toNFD(str) and mw.ustring.toNFKD(str) can't work properly in Korean Hangul contents?.

Let's look at the one example you actually provided:

= #(mw.ustring.toNFC('ᄉᄐ'))

You claim that's an L jamo and a V jamo. But the characters you have there are U+1109 and U+1110, both of which are L jamos. V jamos are in the range U+1160–U+11A7, although only U+1161–U+1175 participate in precomposed Hangul syllable conversion.

Wed, Mar 13, 3:29 PM · MediaWiki-extensions-Scribunto, utfnormal
Anomie added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Yes. You should just be able to delete the two references.

Wed, Mar 13, 2:23 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban, Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
Anomie added a comment to T218127: Use CommentStoreComment throughout MediaWiki.

Then why are we even using the Message class for comments?

Wed, Mar 13, 2:05 PM · Shape Expressions, Wikidata, MediaWiki-Comment-backend

Tue, Mar 12

Anomie added a comment to T162379: Decide which non-standard CSS properties to support in TemplateStyles.

I note that's for what browsers need to support never-updated websites. It includes things like -webkit-linear-gradient() which https://caniuse.com/#search=linear-gradient reports hasn't been needed for any browser released in the past 5 years.

Tue, Mar 12, 8:15 PM · Core Platform Team, Core Platform Team Backlog (Later), Patch-For-Review, css-sanitizer, TemplateStyles
Anomie added a comment to T183156: ApiFeatureUsage data is not being populated in the Beta Cluster.

Did you figure out logging in to horizon?

Tue, Mar 12, 8:04 PM · Discovery-Search (Current work), Elasticsearch, Wikimedia-Logstash, Beta-Cluster-Infrastructure
Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

I note the review so far seems to have ignored that part of schema changes is checking the existing schema to determine whether the schema needs changing (MW currently does a somewhat crappy job of this), and also to have ignored data type requirements. But if @Ladsgroup wants to try writing an implementation, I won't say he can't.

Tue, Mar 12, 7:56 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie added a comment to T217972: log_user_text is missing for some logs in fawiki.

Why do you think that? Both of the tasks you linked are closed as "Declined" and there's no indication the maintenance script was ever run.

Tue, Mar 12, 6:55 PM · MediaWiki-Logging, Wikimedia-Site-requests
Anomie added a comment to T217972: log_user_text is missing for some logs in fawiki.

The actor is filled, maybe the row was written while the migration was in process

Tue, Mar 12, 6:37 PM · MediaWiki-Logging, Wikimedia-Site-requests
Anomie closed T218110: ManualLogEntry::publish( $id, 'udp' ) does not save change tags as Resolved.
Tue, Mar 12, 6:21 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban (Done with CPT), Patch-For-Review, MediaWiki-Change-tagging, MediaWiki-Logging
Anomie added a comment to T218127: Use CommentStoreComment throughout MediaWiki.

How exactly this proper rendering looks like, though, is not yet clear.

Tue, Mar 12, 5:18 PM · Shape Expressions, Wikidata, MediaWiki-Comment-backend
Anomie added a comment to T149077: Certain ApiQueryRecentChanges::run api query is too slow, slowing down dewiki.

It looks like this Wikimedia-production-error task does not have an error associated with it. Is this hitting an execution timeout exception, or DBPerformance warning?

Tue, Mar 12, 4:52 PM · Core Platform Team Kanban (Waiting for Review), Core Platform Team Backlog (Watching / External), Wikimedia-production-error, Patch-For-Review, MediaWiki-API, DBA
pmiazga awarded T218110: ManualLogEntry::publish( $id, 'udp' ) does not save change tags a Orange Medal token.
Tue, Mar 12, 4:36 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban (Done with CPT), Patch-For-Review, MediaWiki-Change-tagging, MediaWiki-Logging
Anomie created T218112: Create an implementation of Env etc for testing by accessing a MediaWiki installation via the Action API.
Tue, Mar 12, 3:22 PM · Parsoid-PHP
Anomie created T218110: ManualLogEntry::publish( $id, 'udp' ) does not save change tags.
Tue, Mar 12, 2:56 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban (Done with CPT), Patch-For-Review, MediaWiki-Change-tagging, MediaWiki-Logging
Anomie added a comment to T153994: Migrate MediaWiki extensions away from UtfNormal in MediaWiki core to external UtfNormal library.

I.e. you switched from one implementation of toNFD to another one.

There's an evidcence that there are (or there has been) two distinct implementations in existing code or these implementations have changed somewhere and one of them is now incorrect.

Tue, Mar 12, 2:25 PM · Patch-For-Review, Google-Code-In-2016, utfnormal, good first bug, Technical-Debt
Anomie closed T217973: mw.ustring.toNFD(str) and mw.ustring.toNFKD(str) can't work properly in Korean Hangul contents? as Invalid.

UtfNormal (and Scribunto's standalone ustring library) are currently written for Unicode 8.0. Scribunto passes all tests in http://unicode.org/Public/8.0.0/ucd/NormalizationTest.txt, which by proxy means utfnormal does as well.

Tue, Mar 12, 2:13 PM · MediaWiki-extensions-Scribunto, utfnormal
Anomie added a comment to T61767: setting to specify location of NormalizationTest.txt.

Note actually including this file raises the number of tests run for Scribunto from 1378 to around 38000.

Tue, Mar 12, 2:12 PM · MediaWiki-extensions-Scribunto
Anomie moved T217973: mw.ustring.toNFD(str) and mw.ustring.toNFKD(str) can't work properly in Korean Hangul contents? from Backlog to External on the MediaWiki-extensions-Scribunto board.
Tue, Mar 12, 1:44 PM · MediaWiki-extensions-Scribunto, utfnormal
Anomie added a comment to T208437: Consolidate and migrate Module namespace to mediawiki.org.

@Capankajsmilyo renamed this task from Consolidate and migrate Module namespace to Commons to Consolidate and migrate Module namespace to Mediawiki.

Tue, Mar 12, 1:38 PM · Wikimedia-General-or-Unknown
Anomie renamed T208437: Consolidate and migrate Module namespace to mediawiki.org from Consolidate and migrate Module namespace to Mediawiki to Consolidate and migrate Module namespace to mediawiki.org.
Tue, Mar 12, 1:38 PM · Wikimedia-General-or-Unknown

Sat, Mar 9

Anomie removed a project from T71222: list=logevents slow for users with last log action long time ago: Patch-For-Review.

The query with IGNORE INDEX should be deployed next week with 1.33.0-wmf.21. I'll leave it to DBAs to decide whether to close this or keep it open for future re-review on MariaDB/MySQL upgrades.

Sat, Mar 9, 2:34 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie moved T71222: list=logevents slow for users with last log action long time ago from Non-Code to Done on the MediaWiki-API board.
Sat, Mar 9, 2:34 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie added a comment to T192666: Gerrit's New UI reply dialog ignores Ctrl-Z.

Still not working for me in Firefox 65 at https://gerrit.wikimedia.org/

Sat, Mar 9, 2:29 PM · Upstream, Gerrit

Fri, Mar 8

Anomie added a comment to T217384: phpunit drops dead on some extension tests on hhvm.

That one broke at around test 6893 of 19954, 34.54% of the way through the run versus 66.15% for the other one. Why such a big difference?

Fri, Mar 8, 10:13 PM · HHVM, Jenkins, Release-Engineering-Team, Continuous-Integration-Infrastructure
Anomie added a comment to T212482: RFC: MediaWiki 2018 extension interfaces.

@daniel: You should go read what I wrote in T212482#4841064.

Fri, Mar 8, 4:13 PM · Core Platform Team (Extension Interfaces (CDP2)), Core Platform Team Backlog (Watching / External), Performance-Team (Radar), TechCom-RFC, TechCom
Anomie added a comment to T217384: phpunit drops dead on some extension tests on hhvm.

This time the log is produced and ends with:

PHPUnitCommand] Start test Scribunto_LuaTextLibraryTest::testLua with data set #70
Parser: using preprocessor: Preprocessor_Hash
[Scribunto] Scribunto_LuaStandaloneInterpreter::__construct: creating interpreter: 'exec' '/bin/sh' '/workspace/src/extensions/Scribunto/includes/engines/LuaStandalone/lua_ulimit.sh' '30' '31' '48828' ''\''/workspace/src/extensions/Scribunto/includes/engines/LuaStandalone/binaries/lua5_1_5_linux_64_generic/lua'\'' '\''/workspace/src/extensions/Scribunto/includes/engines/LuaStandalone/mw_main.lua'\'' '\''/workspace/src/extensions/Scribunto/includes'\'' '\''439'\'' '\''8'\'''

So it may be Scribunto test crashing?

Fri, Mar 8, 3:06 PM · HHVM, Jenkins, Release-Engineering-Team, Continuous-Integration-Infrastructure

Thu, Mar 7

Anomie added a project to T217867: Port domino (or another spec-compliant DOM library) to PHP: Core Platform Team Backlog (Attic).

I'm going to throw this on Core Platform Team Backlog, mainly for the possibility of making it a PHP extension since Tim and I have some experience with that from LuaSandbox and Excimer. If it gets to that point we might talk to @Smalyshev too.

Thu, Mar 7, 10:23 PM · Core Platform Team Backlog (Attic), Parsoid-PHP
Anomie created T217861: Missing detection of incorrect spacing in function syntax.
Thu, Mar 7, 7:58 PM · MediaWiki-Codesniffer
Anomie added a comment to T199004: RFC: Add a frontend build step to skins/extensions to our deploy process.

Besides what I said earlier in T199004#4445485,

Thu, Mar 7, 7:21 PM · TechCom-RFC, Proposal, User-Jdlrobson
Anomie closed T217525: Special:ActiveUsers seems to be truncated as Resolved.
Thu, Mar 7, 6:06 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban (Done with CPT), Patch-For-Review, MediaWiki-Special-pages
Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.
Thu, Mar 7, 6:01 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie closed T217776: CodeEditor incorrectly shown for edit notices for CSS pages as Declined.

There's nothing more we can sensibly do here beyond the workaround mentioned in T217776#5007529, as it would be prohibitive to try to configure lists of local exceptions for every wiki.

Thu, Mar 7, 5:38 PM · TemplateStyles, CodeEditor
Anomie removed a project from T217823: Wikitech static: InvalidArgumentException from load.php and some content pages show Class 'ScopedCallback' not found: MediaWiki-extensions-Scribunto.

According to https://wikitech-static.wikimedia.org/wiki/Special:Version. the wiki is running MediaWiki 1.32 and Scribunto with git hash a665621, which is the version for MediaWiki 1.28. That's not supported. Someone needs to upgrade the extensions on wikitech-static to 1.32 versions to match the version of MediaWiki.

Thu, Mar 7, 5:30 PM · wikitech.wikimedia.org
Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

Reading the minutes of the meeting (sorry I couldn't join) I volunteer to do a basic research on Doctorine and how feasible it is to use. Is it okay with the TechCom and @Anomie ?

Thu, Mar 7, 3:25 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie added a comment to T216791: Make clean script path the default canonical url for the Main Page.

Would it perhaps be better to have it as a redirect to Main_Page (or whichever page the admin wants it to point to) ?

Thu, Mar 7, 3:21 PM · TechCom-RFC, MediaWiki-General-or-Unknown
Anomie added a comment to T217807: Renaming users on officewiki throws an error even after the rename happens.

The error recorded here seems pretty straightforward: the early return at line 208 doesn't close the atomic section started at line 200.

Thu, Mar 7, 2:29 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Patch-For-Review, MediaWiki-extensions-Renameuser

Wed, Mar 6

Anomie claimed T216086: ErrorException from includes/HeaderCallback.php: PHP Notice: Undefined offset: 1.
Wed, Mar 6, 6:19 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Wikimedia-production-error
Anomie closed T212982: Create a ParsingEnvironment class for use with Parsoid/PHP as Resolved.

Ok, let's call this resolved now.

Wed, Mar 6, 4:49 PM · Patch-For-Review, Parsoid-PHP
Anomie moved T217722: Support (part of?) Selectors level 4 in css-sanitizer from Unsorted to Needs code on the css-sanitizer board.

W3C Working Draft, editor's draft

Wed, Mar 6, 4:31 PM · css-sanitizer

Tue, Mar 5

Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

But discussion of this argument with regards to things other than databases is off topic here.

That makes no sense, why is it off topic? I don't think it's very fair for you to make a broad claim saying that we should remove support for non-free software in core that CI doesn't test and then respond to a counter-argument with "that's off topic".

Tue, Mar 5, 11:24 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie added a comment to T217387: API: how to get the page-size from query-langlinks.
  • when you have a new page and link it to a page in some other language you have to add this to all wikis that are already linked anyway the only additional information is the size - and you have the size of this page in your language anyway so for adding there is no additional effort
Tue, Mar 5, 11:19 PM · MediaWiki-API
Anomie added a comment to T212982: Create a ParsingEnvironment class for use with Parsoid/PHP.

Is there anything else we want to do for this class (e.g. make an equivalent of JS's "env" object), or should we close this?

Tue, Mar 5, 5:37 PM · Patch-For-Review, Parsoid-PHP
Anomie added a comment to T215000: Fill gaps in PHP DOM's functionality.

But as mentioned above it does not protect against the opposite failure (when ids in a freshly appended subtree are not indexed yet), and I don't think there's an easy workaround for that.

Tue, Mar 5, 4:34 PM · Patch-For-Review, Parsoid-PHP

Mon, Mar 4

Anomie closed T217382: APIEditPage -> ApiBase->checkTitleUserPermissions PHP Warning: Invalid operand type was used: Invalid type used as key as Resolved.

Feel free to backport if riding the train this week isn't fast enough. Since this wasn't UBN I'm guessing it's not that common.

Mon, Mar 4, 8:34 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MediaWiki-API, Wikimedia-production-error
Anomie closed T217382: APIEditPage -> ApiBase->checkTitleUserPermissions PHP Warning: Invalid operand type was used: Invalid type used as key, a subtask of T206673: 1.33.0-wmf.19 deployment blockers, as Resolved.
Mon, Mar 4, 8:34 PM · Release-Engineering-Team (Kanban), Release, Train Deployments
Anomie added a comment to T215445: comment and actor view challenges for Cloud Services.

I'd be happy to review the slides. Send me an email with the information whenever you're ready.

Mon, Mar 4, 7:12 PM · cloud-services-team (Kanban), Data-Services
Anomie changed the status of T217387: API: how to get the page-size from query-langlinks from Invalid to Declined.

But would it be possible to add a new field "ll_size" to the table "langlinks"?
Then it would be very fast...

Mon, Mar 4, 5:35 PM · MediaWiki-API
Anomie added a comment to T191231: RFC: Abstract schemas and schema changes.

Correct me if I'm wrong but it seems the reason for this is that our current system is not extendible for other types of databases so it's either we support it or we can't support it (even through an extension). This is one of things this RFC can look into and move away MSSQL and other propriety databases to extensions and leave it to people who wants to maintain it.

Mon, Mar 4, 4:51 PM · Patch-For-Review, User-Addshore, Core Platform Team (Code Health (TEC13)), Core Platform Team Backlog (Epic), TechCom-RFC, SQLite, Oracle Database, MSSQL, PostgreSQL, MediaWiki-Database, Epic
Anomie added a comment to T217500: Provide a loadJsonData with same characteristics as loadData.

mw.loadData() will work with that in exactly the same way it would work if "Module:FooBarData" contained something like

return {
    foo = "bar",
    bar = { 1, 2, 3, 4, 5 }
}

(or whatever Lua code matches your JSON).

Mon, Mar 4, 4:21 PM · MediaWiki-extensions-Scribunto
Anomie added a comment to T71222: list=logevents slow for users with last log action long time ago.

I think we've analyzed this to the point where we can say that the best short-term fix will be to have the API alter its query to add IGNORE INDEX (times) to avoid this problem occurring more frequently when we start using log_actor rather than log_user in the near future. Then, as usual, we should review this again when we upgrade MySQL/MariaDB to see if the optimizer has been fixed.

Mon, Mar 4, 3:54 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie added a comment to T217397: logging.log_title_time and logging.log_title_type_time indexes are not on tables.sql but they exist on most of the wikis.
KEY `log_user_text_time` (`log_user_text`(16),`log_timestamp`),
Mon, Mar 4, 3:37 PM · Patch-For-Review, MediaWiki-Database, Schema-change
Anomie added a comment to T71222: list=logevents slow for users with last log action long time ago.

Unfortunately that made db2038 start using times rather than actor_time for the second query. I was hoping it would go the other way, because we want actor_time for this query.

Mon, Mar 4, 3:15 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie added a comment to T217500: Provide a loadJsonData with same characteristics as loadData.

Maybe this task is trivial per Lego's comment and can be done in calling code already. I don't understand the infrastructure enough to know whether it is or isn't.

Mon, Mar 4, 2:34 PM · MediaWiki-extensions-Scribunto
Anomie claimed T217525: Special:ActiveUsers seems to be truncated.
Mon, Mar 4, 4:06 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Core Platform Team Kanban (Done with CPT), Patch-For-Review, MediaWiki-Special-pages
Anomie added a comment to T217387: API: how to get the page-size from query-langlinks.

If you're wanting the sizes of the other-wiki pages the langlinks point to, that's certainly not going to happen. It would be far too complex and expensive to try to do cross-wiki page lookups for something like this.

Mon, Mar 4, 3:34 AM · MediaWiki-API

Fri, Mar 1

Anomie added a comment to T71222: list=logevents slow for users with last log action long time ago.
explain SELECT log_id,log_type,log_action,log_timestamp,log_deleted  FROM `logging` LEFT JOIN `user` ON ((user_id=log_user)) LEFT JOIN `page` ON ((log_namespace=page_namespace) AND (log_title=page_title))  WHERE (log_type != 'suppress') AND log_user = '103726' AND ((log_deleted & 12) != 12)  ORDER BY log_timestamp DESC,log_id DESC LIMIT 2;
explain SELECT log_id,log_type,log_action,log_timestamp,log_deleted  FROM `logging` LEFT JOIN `user` ON ((user_id=log_user)) LEFT JOIN `page` ON ((log_namespace=page_namespace) AND (log_title=page_title))  WHERE (log_type != 'suppress') AND log_actor = '154300' AND ((log_deleted & 12) != 12)  ORDER BY log_timestamp DESC,log_id DESC LIMIT 2;
Fri, Mar 1, 6:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie added a comment to T217239: Expose the graph of language fallbacks in an API.

I tried the following via shell.php to get some idea of the timing.

$t0 = microtime( true );
foreach ( Language::fetchLanguageNames() as $code => $name ) {
    Language::getFallbacksFor( $code, Language::STRICT_FALLBACKS );
}
$t1 = microtime( true );

On mwmaint1002, it took 0.04s. On my laptop, it took 148.14s for the first run, and 1.56s for a second, and back to 141s after I deleted the files in $wgCacheDirectory.

Fri, Mar 1, 5:55 PM · Patch-For-Review, Wikidata, MediaWiki-API, MediaWiki-Internationalization
Anomie added a comment to T71222: list=logevents slow for users with last log action long time ago.

Looking back at this, db1100 still uses the times index for the original query, and it uses the right plan when told to ignore log_user_type_time. On the other hand, it now also uses the right plan when told to ignore times, unlike what was the case in T71222#4456488.

Fri, Mar 1, 5:31 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), DBA, Performance, MediaWiki-API
Anomie added a comment to T217397: logging.log_title_time and logging.log_title_type_time indexes are not on tables.sql but they exist on most of the wikis.

As I mentioned at T51199#4969053, the log_title(16) at the start of the index seems pretty strange to me. I'd think queries that would use log_title_time would probably work as well or better using page_time (which is (`log_namespace`,`log_title`,`log_timestamp`)), and queries using log_title_type_time would probably work as well or better using an index on (log_namespace, log_title, log_type, log_timestamp). But without knowing what those queries actually are, I can't say for sure.

Fri, Mar 1, 3:20 PM · Patch-For-Review, MediaWiki-Database, Schema-change
Anomie moved T217382: APIEditPage -> ApiBase->checkTitleUserPermissions PHP Warning: Invalid operand type was used: Invalid type used as key from Unsorted to Needs Review on the MediaWiki-API board.
Fri, Mar 1, 2:59 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MediaWiki-API, Wikimedia-production-error
Anomie claimed T217382: APIEditPage -> ApiBase->checkTitleUserPermissions PHP Warning: Invalid operand type was used: Invalid type used as key.

Hmm, probably somehow we're getting an array where the first element is a Message object there. I'll add a check for that.

Fri, Mar 1, 2:40 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MediaWiki-API, Wikimedia-production-error
Anomie edited projects for T217407: Indexing of https://www.wikidata.org in the Yandex Search Engine, added: Traffic; removed MediaWiki-API.

This has nothing to do with the API itself, it's a question about use of the API. So I'm going to remove MediaWiki-API. It may be that the best way to index wikidata.org isn't to use the API at all, but to use dumps and/or other feeds.

Fri, Mar 1, 2:38 PM · Operations, Traffic

Thu, Feb 28

jcrespo awarded T215169: Database::update() with IGNORE option fails on PostgreSQL (MW-1.32 migration error) a 100 token.
Thu, Feb 28, 9:34 PM · MW-1.32-notes, MW-1.31-release-notes, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MW-1.33-release, MW-1.32-release, MW-1.31-release, MediaWiki-Database, PostgreSQL
Anomie closed T215169: Database::update() with IGNORE option fails on PostgreSQL (MW-1.32 migration error) as Resolved.
Thu, Feb 28, 7:48 PM · MW-1.32-notes, MW-1.31-release-notes, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, MW-1.33-release, MW-1.32-release, MW-1.31-release, MediaWiki-Database, PostgreSQL

Wed, Feb 27

Anomie moved T108414: Load API request count and latency data from Hadoop to a dashboard from Non-Code to Non-core-API stuff on the MediaWiki-API board.

Also, back then Reading Infrastructure was the team closest to owning the API so the ApiAction work was done by us. I have no idea how responsibilities are split today within the teams participating in the Better Use of Data CDP.

Wed, Feb 27, 9:26 PM · Better Use Of Data, Product-Analytics, Reading-Infrastructure-Team-Backlog, Analytics, MediaWiki-API
Anomie moved T217162: The api-feature-usage log channel should use log context instead of parsing a string from Needs details or plan to Needs Review on the MediaWiki-API board.
Wed, Feb 27, 9:07 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-Logstash, MediaWiki-API
Anomie added a comment to T217162: The api-feature-usage log channel should use log context instead of parsing a string.

I was hoping it would be that simple, that the variables set in the context would just automatically be present without any magic on the logstash end. Thanks!

Wed, Feb 27, 7:52 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-Logstash, MediaWiki-API
Anomie added a comment to T213489: 'Warning: session_id(): Cannot change session id when session is active' intermittently on php7.3.

issu not solved

Wed, Feb 27, 6:18 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), MW-1.32-notes, MW-1.31-release-notes, MW-1.30-release-notes, MediaWiki-General-or-Unknown, PHP 7.3 support
Anomie added a comment to T217162: The api-feature-usage log channel should use log context instead of parsing a string.
  1. Update the if [channel] == "api-feature-usage" {...} config in filter-mediawiki.conf to use the structured data from the context rather than grok-parsing the human readable message string
Wed, Feb 27, 4:42 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-Logstash, MediaWiki-API
Anomie moved T217239: Expose the graph of language fallbacks in an API from Unsorted to Needs details or plan on the MediaWiki-API board.

As a tool developer, it would be very useful to access the language fallback graph from an API.

Wed, Feb 27, 4:31 PM · Patch-For-Review, Wikidata, MediaWiki-API, MediaWiki-Internationalization
fgiunchedi awarded T217162: The api-feature-usage log channel should use log context instead of parsing a string a Like token.
Wed, Feb 27, 3:32 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-Logstash, MediaWiki-API

Tue, Feb 26

Anomie moved T130911: redirect.py fails for RuntimeError from Unsorted to Non-core-API stuff on the MediaWiki-API board.

@Dvorapa added a project: MediaWiki-API.

Tue, Feb 26, 6:39 PM · MediaWiki-API, MediaWiki-Redirects, Upstream, Patch-For-Review, Pywikibot-redirect.py, Pywikibot
Anomie updated subscribers of T217162: The api-feature-usage log channel should use log context instead of parsing a string.

@bd808: Any idea what goes in the "???" in the checklist? I ask you because you made the mistake of doing the logging a few years ago ;)

Tue, Feb 26, 6:27 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-Logstash, MediaWiki-API
Anomie created T217162: The api-feature-usage log channel should use log context instead of parsing a string.
Tue, Feb 26, 6:26 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Core Platform Team Kanban (Waiting for Review), Patch-For-Review, Wikimedia-Logstash, MediaWiki-API