While the above patch fixes the crasher and improves the rendering from before it was exposed, there's still some work to do to match the php parser's output.

Oct 26 2018, 1:09 AM · Parsoid

Oct 25 2018

Arlolra claimed T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position.

Oct 25 2018, 7:51 PM · Parsoid

Arlolra added a comment to T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position.

and others.

Oct 25 2018, 5:40 PM · Parsoid

Arlolra added a comment to T206040: Timeout parsing largish page.

But, the other major difference seems to be in the reported PEG time ... which doesn't make any sense to me. Is that faulty profiling? Total PEG time should not change whether we do sync tokenizing or async tokenizing unless this is causing some backtracking pathology to kick in.

Oct 25 2018, 4:12 PM · Parsoid

Arlolra created T207957: Cannot read property 'replace' of null.

Oct 25 2018, 3:28 PM · Parsoid

Arlolra created T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position.

Oct 25 2018, 3:27 PM · Parsoid

Arlolra added a comment to T206040: Timeout parsing largish page.

Wrong diagnosis

Oct 25 2018, 2:55 PM · Parsoid

Oct 22 2018

Arlolra renamed T207710: Extlink url should be terminated by extension tag from The Hebrew Wikipedia "rambi" template is rendered correctly, but is displayed incorrectly when edited in Visual Editor to Extlink url should be terminated by extension tag.

Oct 22 2018, 11:53 PM · Parsoid

Arlolra moved T207710: Extlink url should be terminated by extension tag from Backlog to Links on the Parsoid board.

Oct 22 2018, 11:52 PM · Parsoid

Arlolra triaged T207710: Extlink url should be terminated by extension tag as Normal priority.

Oct 22 2018, 11:50 PM · Parsoid

Arlolra added a comment to T207710: Extlink url should be terminated by extension tag.

A reduced test case is,

Oct 22 2018, 11:50 PM · Parsoid

Arlolra added a comment to T207504: Visual editor returns following error code: `Error loading data from server: apierror-visualeditor-docserver-http-error: (curl error: 7) Couldn't connect to server. Would you like to retry`.

Your MediaWiki instance is served with TLS.

Oct 22 2018, 6:53 PM · Parsoid

How would I configure Parsoid to listen to https connection?

Oct 22 2018, 6:30 PM · Parsoid

Oct 19 2018

Arlolra closed T207504: Visual editor returns following error code: `Error loading data from server: apierror-visualeditor-docserver-http-error: (curl error: 7) Couldn't connect to server. Would you like to retry` as Resolved.

Well, you haven't configured Parsoid to listen for HTTPS connections on port 8000, only HTTP. But also, you probably aren't exposing 8000 for external connections (through your firewall, or whathaveyou) so only connections to the loopback address (localhost) are connecting. Parsoid might not also be listening for that specific host (your domain).

Oct 19 2018, 9:13 PM · Parsoid

What happens when you change,

Oct 19 2018, 7:57 PM · Parsoid

Ok, so presumably curl http://localhost:8000/wiki.jackalope.tech/v3/page/html/Main_Page will render your main page now.

Oct 19 2018, 6:57 PM · Parsoid

Is it fair to say that your current status is where we left on https://www.mediawiki.org/w/index.php?title=Topic:Umuo9t5f9ox3umdq&topic_showPostId=umvhwzu6vyhzj3xr#flow-post-umvhwzu6vyhzj3xr

Oct 19 2018, 6:17 PM · Parsoid

@Thedonquixotic You've got multiple threads going on https://www.mediawiki.org/wiki/Talk:Parsoid and https://discourse-mediawiki.wmflabs.org/ and now here on Phabricator.

Oct 19 2018, 6:02 PM · Parsoid

Arlolra closed T186965: Output HTML should not contain `<style>...</style>` as Resolved.

Oct 19 2018, 3:51 AM · Parsoid-Read-Views, MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)), MediaWiki-Parser, RemexHtml, Patch-For-Review, TemplateStyles

Oct 18 2018

Arlolra lowered the priority of T207279: Redlinks DOM pass adds mw api + network latency to parse time from Normal to Low.

12:02 <+subbu> arlolra, reg. the redlinks and media passes and the serial processing for those 
               ... that probably doesn't matter for the PHP port, does it? unless there are 
               ways of structuring those requests that benefits from mysql or other caching 
               across page parse requests.
12:05 <+arlolra> yeah, I wasn't planning on doing it ... but the imageinfo requests would be a 
                 short term regression
12:08 <+subbu> have you looked at how the php parser does the media and redlink processing .. 
               i.e. are they also post-processing passes or are they looked up one at a time .. 
               iirc, tim had mentioned that it does batching too.
12:09 <+arlolra> i have not
12:09 <+arlolra> but i'll check it out
12:09 <+subbu> k. asking in case the restructuring should be done in a particular way to 
               benefit form whatever existing code there is.
12:09 <+subbu> *from

Oct 18 2018, 5:50 PM · Parsoid

Oct 17 2018

Arlolra renamed T207279: Redlinks DOM pass adds mw api + network latency to parse time from Using batch API for redlinks DOM pass adds mw api + network latency to parse time to Redlinks DOM pass adds mw api + network latency to parse time.

Oct 17 2018, 7:35 PM · Parsoid

Arlolra added a comment to T207279: Redlinks DOM pass adds mw api + network latency to parse time.

Adding redlinks is only enabled when using batching so you're comparing against a no-op,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/DOMPostProcessor.js#L323-L329

Oct 17 2018, 5:25 PM · Parsoid

Oct 16 2018

Arlolra closed T207093: AssertionError: undefined as Resolved.

Oct 16 2018, 9:24 PM · Patch-For-Review, Parsoid

Arlolra claimed T207093: AssertionError: undefined.

Oct 16 2018, 5:31 PM · Patch-For-Review, Parsoid

Oct 15 2018

Arlolra created T207093: AssertionError: undefined.

Oct 15 2018, 9:06 PM · Patch-For-Review, Parsoid

Arlolra created T207091: Parsoid no longer active-active.

Oct 15 2018, 8:28 PM · Datacenter-Switchover-2018, Operations, Parsoid

Oct 11 2018

Arlolra added a comment to T128040: Document and implement the REST API format versioning and negotiation policy.

See the discussion at https://github.com/wikimedia/restbase/pull/1073#pullrequestreview-163606489 when it comes to the documenting portion of this task

Oct 11 2018, 1:22 AM · Services (next), Documentation, Patch-For-Review, Services-next, RESTBase

Oct 9 2018

Arlolra added a comment to T203293: {{Row indexer}} completely fails on the Android app / VisualEditor.

That comment is incorrect. The table is not "already rendered" at that stage in the processing; the unstrip call is returning partially-escaped wikitext of the table, which the module then unescapes and processes. The actual rendering of the table happens after the module returns.

Oct 9 2018, 10:11 PM · VisualEditor, Parsoid-Rendering, Parsoid, Wikipedia-Android-App-Backlog