Page MenuHomePhabricator

Arlolra (Arlo Breault)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:34 PM (277 w, 5 h)
Availability
Available
IRC Nick
arlolra
LDAP User
Arlolra
MediaWiki User
Arlolra [ Global Accounts ]

Recent Activity

Yesterday

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Mon, Jan 27, 4:20 PM · Patch-For-Review, Parsoid-PHP

Thu, Jan 23

Arlolra closed T235273: Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retired as Resolved.
Thu, Jan 23, 9:35 PM · Parsoid-PHP

Wed, Jan 22

Pols12 awarded T242513: VE: <references /> tag should be followed by a carriage return when inserted (as block element format) a Barnstar token.
Wed, Jan 22, 9:48 PM · User-Ryasmeen, Parsoid, Parsing-Team, VisualEditor
Arlolra closed T241146: Text w/o a context crasher in Parsoid/PHP LanguageConverter as Resolved.
Wed, Jan 22, 9:30 PM · Parsoid-PHP

Tue, Jan 21

Arlolra closed T243008: PHP Notice: Undefined variable: headers as Resolved.
Tue, Jan 21, 8:46 PM · Parsoid-PHP

Fri, Jan 17

Arlolra closed T242513: VE: <references /> tag should be followed by a carriage return when inserted (as block element format) as Resolved.
Fri, Jan 17, 4:34 PM · User-Ryasmeen, Parsoid, Parsing-Team, VisualEditor

Thu, Jan 16

Arlolra assigned T243008: PHP Notice: Undefined variable: headers to cscott.
Thu, Jan 16, 7:27 PM · Parsoid-PHP
Arlolra created T243008: PHP Notice: Undefined variable: headers.
Thu, Jan 16, 7:26 PM · Parsoid-PHP

Wed, Jan 15

Arlolra added a comment to T239642: We need to run tests on the PHP code in the deploy repo.

Here's a patch with the above diff,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/deploy/+/564792

Wed, Jan 15, 6:32 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Parsoid-PHP

Tue, Jan 14

Arlolra added a comment to T239642: We need to run tests on the PHP code in the deploy repo.
diff --git a/composer.json b/composer.json
index 3faae9a20..df6195d45 100644
--- a/composer.json
+++ b/composer.json
@@ -29,6 +29,7 @@
                "wikimedia/scoped-callback": "3.0.0",
                "wikimedia/wikipeg": "2.0.3",
                "wikimedia/zest-css": "1.1.2",
+               "monolog/monolog": "~1.25.2",
                "ext-dom": "*",
                "ext-json": "*"
        },
@@ -36,7 +37,6 @@
                "jakub-onderka/php-parallel-lint": "1.0.0",
                "jakub-onderka/php-console-highlighter": "0.4.0",
                "jakub-onderka/php-console-color": "0.2",
-               "monolog/monolog": "~1.25.2",
                "mediawiki/mediawiki-codesniffer": "28.0.0",
                "mediawiki/mediawiki-phan-config": "0.9.0",
                "mediawiki/minus-x": "0.3.2",
@@ -49,14 +49,14 @@
        },
        "autoload": {
                "psr-4": {
-                       "Parsoid\\": ["src/placeholder", "src"]
+                       "Parsoid\\": ["src/placeholder", "src"],
+                       "Parsoid\\Tools\\": "tools/",
+                       "Parsoid\\Tests\\": "tests/mocks/"
                }
        },
        "autoload-dev": {
                "psr-4": {
-                       "Parsoid\\Tests\\": "tests/mocks/",
                        "Parsoid\\Tests\\ParserTests\\": "tests/ParserTests",
-                       "Parsoid\\Tools\\": "tools/",
                        "Test\\": "tests/phpunit/"
                }
        },
Tue, Jan 14, 9:49 PM · Patch-For-Review, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Parsoid-PHP
Arlolra closed T137122: Debugging endpoints (/_html/, /_wikitext/, etc.) seem to assume parsoidConfig.loadWMF = true as Declined.

These endpoints weren't ported to php.

Tue, Jan 14, 8:17 PM · Parsoid
Arlolra added a comment to T242777: Content in list item not serialized correctly.

Similarly T55568

Tue, Jan 14, 8:15 PM · Parsoid-Serializer
Arlolra added a comment to T242782: Stop running Parsoid-JS tests in CI.

Can we archive /deploy now, as part of this?

Tue, Jan 14, 7:15 PM · Continuous-Integration-Config, Patch-For-Review, Parsoid
Arlolra created T242782: Stop running Parsoid-JS tests in CI.
Tue, Jan 14, 7:12 PM · Continuous-Integration-Config, Patch-For-Review, Parsoid

Fri, Jan 10

Arlolra added a comment to T239806: Parsoid/PHP errors.

Bumping to 1 GiB seems to have reduced the number of OOMs

Fri, Jan 10, 8:56 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra closed T228217: Ensure all the features of parse.js are covered by parse.php as Resolved.
Fri, Jan 10, 8:55 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Fri, Jan 10, 8:53 PM · Patch-For-Review, Parsoid-PHP

Wed, Jan 8

Arlolra added a comment to T242297: Call to a member function run() on null.
PHP Notice: Undefined index: /html/body/section[5]/section[1]/div/div[2]/section[2]/table/tbody/tr[3]/td[5]/font/span[2]/p
#0 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/MachineLanguageGuesser.php(94): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/ConversionTraverser.php(101): Parsoid\Language\MachineLanguageGuesser->guessLang(DOMElement)
#2 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/ConversionTraverser.php(59): Parsoid\Language\ConversionTraverser->langContextHandler(DOMElement, Parsoid\Config\Env, boolean, stdClass)
#3 [internal function]: Parsoid\Language\ConversionTraverser->Parsoid\Language\{closure}(DOMElement, Parsoid\Config\Env, boolean, stdClass)
#4 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(86): call_user_func(Closure, DOMElement, Parsoid\Config\Env, boolean, stdClass)
#5 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(154): Parsoid\Utils\DOMTraverser->callHandlers(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#6 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#7 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#8 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#9 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#10 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#11 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#12 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#13 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#14 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#15 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#16 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, NULL)
#17 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, NULL)
#18 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/LanguageConverter.php(288): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean)
#19 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/LanguageConverter.php(222): Parsoid\Language\LanguageConverter::baseToVariant(Parsoid\Config\Env, DOMElement, string, NULL)
#20 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Parsoid.php(246): Parsoid\Language\LanguageConverter::maybeConvert(Parsoid\Config\Env, DOMDocument, string, NULL)
#21 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/extension/src/Rest/Handler/ParsoidHandler.php(1032): Parsoid\Parsoid->html2html(MWParsoid\Config\PageConfig, string, string, array, NULL)
#22 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/extension/src/Rest/Handler/ParsoidHandler.php(913): MWParsoid\Rest\Handler\ParsoidHandler->languageConversion(Parsoid\Config\Env, array, array)
#23 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/extension/src/Rest/Handler/TransformHandler.php(106): MWParsoid\Rest\Handler\ParsoidHandler->pb2pb(Parsoid\Config\Env, array)
#24 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/Router.php(314): MWParsoid\Rest\Handler\TransformHandler->execute()
#25 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/Router.php(285): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\TransformHandler)
#26 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/EntryPoint.php(111): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#27 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/EntryPoint.php(78): MediaWiki\Rest\EntryPoint->execute()
#28 /srv/mediawiki/php-1.35.0-wmf.11/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#29 /srv/mediawiki/w/rest.php(3): require(string)
#30 {main}
Wed, Jan 8, 11:36 PM · Parsoid-PHP
Arlolra added a comment to T242297: Call to a member function run() on null.
PHP Notice: Undefined index: 
#0 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/vendor/wikimedia/langconv/src/ReplacementMachine.php(158): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/ConversionTraverser.php(118): Wikimedia\LangConv\ReplacementMachine->convert(DOMDocument, string, string, NULL)
#2 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/ConversionTraverser.php(69): Parsoid\Language\ConversionTraverser->aHandler(DOMElement, Parsoid\Config\Env, boolean, stdClass)
#3 [internal function]: Parsoid\Language\ConversionTraverser->Parsoid\Language\{closure}(DOMElement, Parsoid\Config\Env, boolean, stdClass)
#4 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(86): call_user_func(Closure, DOMElement, Parsoid\Config\Env, boolean, stdClass)
#5 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(154): Parsoid\Utils\DOMTraverser->callHandlers(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#6 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#7 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#8 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#9 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#10 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#11 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#12 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#13 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#14 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#15 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#16 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, stdClass)
#17 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, NULL)
#18 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Utils/DOMTraverser.php(166): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean, NULL)
#19 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/LanguageConverter.php(288): Parsoid\Utils\DOMTraverser->traverse(DOMElement, Parsoid\Config\Env, array, boolean)
#20 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Language/LanguageConverter.php(222): Parsoid\Language\LanguageConverter::baseToVariant(Parsoid\Config\Env, DOMElement, string, NULL)
#21 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/src/Parsoid.php(246): Parsoid\Language\LanguageConverter::maybeConvert(Parsoid\Config\Env, DOMDocument, string, NULL)
#22 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/extension/src/Rest/Handler/ParsoidHandler.php(1032): Parsoid\Parsoid->html2html(MWParsoid\Config\PageConfig, string, string, array, NULL)
#23 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/extension/src/Rest/Handler/ParsoidHandler.php(913): MWParsoid\Rest\Handler\ParsoidHandler->languageConversion(Parsoid\Config\Env, array, array)
#24 /srv/deployment/parsoid/deploy-cache/revs/45a4245d5f122ee190adf5465b36c4741c8bd330/src/extension/src/Rest/Handler/TransformHandler.php(106): MWParsoid\Rest\Handler\ParsoidHandler->pb2pb(Parsoid\Config\Env, array)
#25 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/Router.php(314): MWParsoid\Rest\Handler\TransformHandler->execute()
#26 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/Router.php(285): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\TransformHandler)
#27 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/EntryPoint.php(111): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#28 /srv/mediawiki/php-1.35.0-wmf.11/includes/Rest/EntryPoint.php(78): MediaWiki\Rest\EntryPoint->execute()
#29 /srv/mediawiki/php-1.35.0-wmf.11/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#30 /srv/mediawiki/w/rest.php(3): require(string)
#31 {main}
Wed, Jan 8, 11:36 PM · Parsoid-PHP
Arlolra created T242299: PHP Notice: Undefined property: stdClass::$pi.
Wed, Jan 8, 11:32 PM · Parsoid-PHP
Arlolra created T242298: Invariant failed: Bad UTF-8 at end of string (2 byte sequence).
Wed, Jan 8, 11:32 PM · Parsoid-PHP
Arlolra created T242297: Call to a member function run() on null.
Wed, Jan 8, 11:30 PM · Parsoid-PHP
Arlolra closed T237318: Invariant failed: Bad UTF-8 at end of string (2 byte sequence), a subtask of T229015: Tracking: Direct live production traffic at Parsoid/PHP, as Resolved.
Wed, Jan 8, 10:04 PM · User-notice, Core Platform Team, User-WDoran, Parsoid-PHP
Arlolra closed T237318: Invariant failed: Bad UTF-8 at end of string (2 byte sequence) as Resolved.
Wed, Jan 8, 10:04 PM · Parsoid-PHP

Mon, Jan 6

Arlolra claimed T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers).
Mon, Jan 6, 4:41 PM · Parsing-critical-path, Parsoid-PHP

Dec 20 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 5:22 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 5:22 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

config is not really relevant. We could point it at a file with $wgParsoidSettings, like in,
https://github.com/wikimedia/parsoid/blob/master/tests/RTTestSettings.php
but for now using LocalSettings.php in integrated mode should suffice.

Dec 20 2019, 5:22 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 4:47 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 3:40 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 3:39 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 12:19 AM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

contentmodel support hasn't been ported Parsoid/PHP yet, so that can be done with T236112

Dec 20 2019, 12:19 AM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 12:16 AM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

domdiff is broken in Parsoid/JS so we can ignore that,
https://github.com/wikimedia/parsoid/blob/master/lib/parse.js#L229-L234

Dec 20 2019, 12:16 AM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T229469: Reduce / eliminate Parsoid's knowledge of what mode it is running in (standalone, integrated, offline).

This currently exists as a noDataAccess flag, which nothing seems to be using. We can probably move that code out to a NoDataAccess instance, as suggested in the comment,
https://github.com/wikimedia/parsoid/blob/master/src/Config/Env.php#L68-L74

Dec 20 2019, 12:09 AM · Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 20 2019, 12:06 AM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

offline is pretty much covered by --mock and can be further discussed in T229469

Dec 20 2019, 12:06 AM · Patch-For-Review, Parsoid-PHP

Dec 19 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 19 2019, 11:25 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

color was a standard option that doesn't seem to have been used in parse.js

Dec 19 2019, 11:25 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Dec 19 2019, 11:19 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

record and replay aren't really relevant in Parsoid/PHP

Dec 19 2019, 11:19 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T241164: Implement and add html/parsoid sections for new citeParserTests.
Dec 19 2019, 6:56 PM · Cite, Parsoid

Dec 18 2019

Arlolra added a comment to T239806: Parsoid/PHP errors.

Bumping to 1 GiB seems to have reduced the number of OOMs but still need to try to compare it with the rate of Parsoid/JS. The default on 64-bit platforms for node is 1400 MB, but note that we've disabled GC for Parsoid/PHP.

Dec 18 2019, 10:14 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T241041: Port Book Referencing parser tests over to Parsoid.

We had to do a citeParserTests sync today for the changes to "<ref> defined in <references> error conditions"

Dec 18 2019, 9:11 PM · Book-Referencing, Parsoid
Arlolra committed rECIT6d55f9e8cc6b: Sync up with Parsoid citeParserTests.txt (authored by Arlolra).
Sync up with Parsoid citeParserTests.txt
Dec 18 2019, 8:53 PM

Dec 17 2019

Arlolra added a comment to T239806: Parsoid/PHP errors.

Removing -"tried to allocate" filtering from the Parsoid/PHP dashboard seems to match up the fatals with the above mentioned RESTBase dashboard.

Dec 17 2019, 11:42 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T239806: Parsoid/PHP errors.

That seems to be configured with,

Dec 17 2019, 11:35 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T239806: Parsoid/PHP errors.

Although, there does seem to be a $wmgMemoryLimitParsoid from T236833#5716665

Dec 17 2019, 11:33 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T239806: Parsoid/PHP errors.

Locally, my memory_limit = 8G because of the langconv requirements when running composer test

Dec 17 2019, 11:30 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T239806: Parsoid/PHP errors.

Looking at the parser-tests dashboard, I see,

Dec 17 2019, 11:23 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T239806: Parsoid/PHP errors.

Parsoid/JS does better here,

Dec 17 2019, 11:14 PM · User-brennen, Patch-For-Review, Parsoid-PHP
Arlolra updated subscribers of T214649: VE's gallery representation differs enough so that selser is never applied?.
Dec 17 2019, 7:52 PM · Patch-For-Review, Regression, VisualEditor
Arlolra created T240919: Start a background job to rerender all of storage.
Dec 17 2019, 12:58 AM · Parsoid-PHP

Dec 16 2019

Arlolra added a comment to T214649: VE's gallery representation differs enough so that selser is never applied?.

With that deploy, nativeGallery is now re-disabled. That should returns things to how they've been the past year, where only the extension tag attributes are dirty normalized, as in T211246#4829298, and the content normalization described here only happens when the gallery is edited and the extsrc is removed by VE.

Dec 16 2019, 11:28 PM · Patch-For-Review, Regression, VisualEditor
Arlolra closed T239929: Class 'Parsoid\Language\LanguageKk' not found as Resolved.
Dec 16 2019, 8:22 PM · Parsoid-PHP
Arlolra closed T239830: Add metrics for startup time for language variant code as Resolved.
Dec 16 2019, 8:04 PM · Parsoid-PHP
Arlolra added a comment to T214649: VE's gallery representation differs enough so that selser is never applied?.

Sorry but that is not correct.

Dec 16 2019, 5:07 PM · Patch-For-Review, Regression, VisualEditor
Arlolra added a comment to T214649: VE's gallery representation differs enough so that selser is never applied?.

Adding the regression tag as the bug happens now on every edit with a gallery tag since December 4th 2019, see duplicate task T239783.

Dec 16 2019, 4:17 PM · Patch-For-Review, Regression, VisualEditor

Dec 13 2019

Arlolra closed T236912: Return value of Parsoid\Wt2Html\PP\Processors\WrapSections::getDSR() must be of the type integer, null returned as Resolved.
Dec 13 2019, 8:32 PM · Parsoid-PHP
Arlolra closed T239651: Direct scandium parsoid-test metrics to a different top-level bucket as Resolved.
Dec 13 2019, 8:30 PM · Parsoid-PHP
Arlolra closed T240091: "PHP Notice: Undefined offset: 2" in WikitextEscapeHandlers as Resolved.
Dec 13 2019, 3:20 PM · Parsoid-PHP

Dec 12 2019

Arlolra moved T240642: PHP Notice: Undefined property: stdClass::$pi from Backlog to Bugs, Notices, Crashers on the Parsoid-PHP board.
Dec 12 2019, 11:41 PM · Parsoid-PHP
Arlolra added a comment to T240642: PHP Notice: Undefined property: stdClass::$pi.
PHP Notice: Undefined property: stdClass::$parts
Dec 12 2019, 11:40 PM · Parsoid-PHP
Arlolra triaged T240642: PHP Notice: Undefined property: stdClass::$pi as Medium priority.
Dec 12 2019, 11:39 PM · Parsoid-PHP
Arlolra created T240642: PHP Notice: Undefined property: stdClass::$pi.
Dec 12 2019, 11:39 PM · Parsoid-PHP
Arlolra added a comment to T240057: Temporarily disable wikitext linting updates to help resolve some cluster overload scenarios.

With T237326#5737277, linting is now re-enabled.

Dec 12 2019, 7:59 PM · User-notice, MediaWiki-extensions-Linter, Parsoid
Arlolra closed T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB as Resolved.
Dec 12 2019, 7:58 PM · Core Platform Team, User-WDoran, Parsoid-PHP
Arlolra claimed T240091: "PHP Notice: Undefined offset: 2" in WikitextEscapeHandlers .
Dec 12 2019, 5:38 PM · Parsoid-PHP

Dec 11 2019

Arlolra created T240511: Invariant failed: /srv/deployment/parsoid/deploy-cache/revs/5ba7506af29dcae5e74a69d7f3e4e414572607a6/vendor/wikimedia/langconv/src/../fst/brack-zh-hans-noop.pfst.
Dec 11 2019, 10:03 PM · Parsoid-PHP
Arlolra closed T239252: Invariant failed: Bad SourceRange length as Resolved.

This now results in the more typical,

Dec 11 2019, 5:52 PM · Parsoid-PHP

Dec 10 2019

Arlolra merged task T239645: Postgres error on type mismatch into T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".
Dec 10 2019, 5:43 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Parser, PostgreSQL
Arlolra merged T239645: Postgres error on type mismatch into T239877: After deploy of 1.35.0-wmf.8 to group1, surge of "Cannot access the database: Unknown error".
Dec 10 2019, 5:43 PM · MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Core Platform Team Workboards (Clinic Duty Team), DBA, Wikimedia-production-error
Arlolra added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

Maybe we should consider marking fostered content such that it is uneditable?

Dec 10 2019, 5:39 PM · OWC2020, VisualEditor, Parsoid

Dec 9 2019

Arlolra added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

All the content in the table in your example is found in a fosterable position.

Dec 9 2019, 11:36 PM · OWC2020, VisualEditor, Parsoid

Dec 6 2019

Arlolra added a project to T239875: VE leaves around inline data-parsoid on edited content: VisualEditor.
Dec 6 2019, 9:53 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T97059: \r is handled inconsistently in the tokenizer.

Somewhat related is T237306

Dec 6 2019, 9:52 PM · Parsoid
Arlolra merged T226206: Tokenizer errors: "Expected end of input or tlb but "\r" found" into T237306: PEG error: Expected end of input or tlb but "\r" found..
Dec 6 2019, 9:50 PM · Parsoid
Arlolra merged task T226206: Tokenizer errors: "Expected end of input or tlb but "\r" found" into T237306: PEG error: Expected end of input or tlb but "\r" found..
Dec 6 2019, 9:50 PM · Parsoid
Arlolra closed T237306: PEG error: Expected end of input or tlb but "\r" found. as Resolved.
Dec 6 2019, 9:49 PM · Parsoid
Arlolra closed T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given as Resolved.
Dec 6 2019, 9:48 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T240053: Detect potential selser corruption.
Dec 6 2019, 9:47 PM · Parsoid
Arlolra placed T237463: Resolve all PORT-FIXMEs up for grabs.
Dec 6 2019, 8:15 PM · Parsoid-PHP
Arlolra claimed T237306: PEG error: Expected end of input or tlb but "\r" found..
Dec 6 2019, 8:06 PM · Parsoid
Arlolra added a comment to T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given.

T237306 is a similar case, where \r is found is stray position (before "titre"),

Dec 6 2019, 7:27 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given.

The page seems to start with a carriage return (0d), which throws Parsoids into a loop.

Dec 6 2019, 6:26 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T239875: VE leaves around inline data-parsoid on edited content.

I am assuming this is because of the need to preserved syntactic variations (of pasted content) that are currently stored in data-parsoid properties. So, this is a trickier problem. Maybe VE needs to signal the cloned nature of data-parsoid with an attribute or in some other fashion.

Dec 6 2019, 5:08 PM · VisualEditor, Parsoid-PHP

Dec 5 2019

Arlolra claimed T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given.
Dec 5 2019, 11:54 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given.

The above patch resolves this error but the example page now hits a maximum execution time error despite its small size. Same is true on Parsoid/JS. I wonder what's going on there ...

Dec 5 2019, 11:54 PM · Patch-For-Review, Parsoid-PHP
Arlolra renamed T239875: VE leaves around inline data-parsoid on edited content from Parsoid Error HTTP 500 on a single page on officewiki to VE leaves around inline data-parsoid on edited content.
Dec 5 2019, 10:49 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T239875: VE leaves around inline data-parsoid on edited content.

Maybe VE just expects to have to remove the ids that are returned.

Dec 5 2019, 10:47 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T239875: VE leaves around inline data-parsoid on edited content.

(Still probably my fault, since I think I wrote that particular bit of VE code, but still.)

Dec 5 2019, 8:09 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T239645: Postgres error on type mismatch.

Related to this might be T239877

Dec 5 2019, 8:05 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), MediaWiki-Parser, PostgreSQL
Arlolra added a comment to T239875: VE leaves around inline data-parsoid on edited content.

Checking copy(ve.init.target.docToSave.body.outerHTML), we get,

Dec 5 2019, 7:55 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T239875: VE leaves around inline data-parsoid on edited content.

So, it must be that the string is less than $start characters long, so we're returning FALSE and crashing.

Dec 5 2019, 7:50 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T239875: VE leaves around inline data-parsoid on edited content.

I can only reproduce it on a single page and only on officewiki,

Dec 5 2019, 6:45 PM · VisualEditor, Parsoid-PHP
Arlolra added a comment to T239169: Media links with underscores in the URL are dirty-diffed (with no underscores).

I don't know whether it makes any difference, but I'd like to point out that this also happens for media links inside <gallery> tags, see example.

Dec 5 2019, 6:42 PM · Parsoid
Arlolra created T239929: Class 'Parsoid\Language\LanguageKk' not found.
Dec 5 2019, 4:32 PM · Parsoid-PHP
Arlolra edited projects for T239875: VE leaves around inline data-parsoid on edited content, added: Parsoid-PHP; removed Parsoid.

Return value of Parsoid\Html2Wt\SerializerState::getOrigSrc() must be of the type string or null, boolean returned

Dec 5 2019, 4:23 PM · VisualEditor, Parsoid-PHP

Dec 4 2019

Arlolra added a comment to T238777: Argument 1 passed to Parsoid\Wt2Html\TT\OnlyInclude::onTag() must be an instance of Parsoid\Tokens\Token, array given.

The above patch resolves this error but the example page now hits a maximum execution time error despite its small size. Same is true on Parsoid/JS. I wonder what's going on there ...

Dec 4 2019, 11:01 PM · Patch-For-Review, Parsoid-PHP