User Details
- User Since
- Oct 6 2014, 10:34 PM (210 w, 6 d)
- Availability
- Available
- IRC Nick
- arlolra
- LDAP User
- Arlolra
- MediaWiki User
- Arlolra [ Global Accounts ]
Fri, Oct 19
Well, you haven't configured Parsoid to listen for HTTPS connections on port 8000, only HTTP. But also, you probably aren't exposing 8000 for external connections (through your firewall, or whathaveyou) so only connections to the loopback address (localhost) are connecting. Parsoid might not also be listening for that specific host (your domain).
What happens when you change,
Ok, so presumably curl http://localhost:8000/wiki.jackalope.tech/v3/page/html/Main_Page will render your main page now.
Is it fair to say that your current status is where we left on https://www.mediawiki.org/w/index.php?title=Topic:Umuo9t5f9ox3umdq&topic_showPostId=umvhwzu6vyhzj3xr#flow-post-umvhwzu6vyhzj3xr
@Thedonquixotic You've got multiple threads going on https://www.mediawiki.org/wiki/Talk:Parsoid and https://discourse-mediawiki.wmflabs.org/ and now here on Phabricator.
Thu, Oct 18
12:02 <+subbu> arlolra, reg. the redlinks and media passes and the serial processing for those
... that probably doesn't matter for the PHP port, does it? unless there are
ways of structuring those requests that benefits from mysql or other caching
across page parse requests.
12:05 <+arlolra> yeah, I wasn't planning on doing it ... but the imageinfo requests would be a
short term regression
12:08 <+subbu> have you looked at how the php parser does the media and redlink processing ..
i.e. are they also post-processing passes or are they looked up one at a time ..
iirc, tim had mentioned that it does batching too.
12:09 <+arlolra> i have not
12:09 <+arlolra> but i'll check it out
12:09 <+subbu> k. asking in case the restructuring should be done in a particular way to
benefit form whatever existing code there is.
12:09 <+subbu> *fromWed, Oct 17
Adding redlinks is only enabled when using batching so you're comparing against a no-op,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/DOMPostProcessor.js#L323-L329
Tue, Oct 16
Mon, Oct 15
Thu, Oct 11
See the discussion at https://github.com/wikimedia/restbase/pull/1073#pullrequestreview-163606489 when it comes to the documenting portion of this task
Tue, Oct 9
That comment is incorrect. The table is not "already rendered" at that stage in the processing; the unstrip call is returning partially-escaped wikitext of the table, which the module then unescapes and processes. The actual rendering of the table happens after the module returns.
Thu, Oct 4
@mobrovac The above patch is deployed. Please confirm it meets your expectations
Wed, Oct 3
Can you reproduce this locally?
I'm assuming it's this series of patches that broke it
Tue, Oct 2
That patch hasn't been deployed yet
Mon, Oct 1
Fri, Sep 28
Presumably this is fixed by https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/461708
Thu, Sep 27
Wed, Sep 26
To elucidate why the Main_Page was showing up,
The stored content for User:RYasmeen_(WMF)/384154 is now at 2.0.0, which downgrades just fine, since it's a major version downgrade, and is probably why you couldn't reproduce this. The bug is somewhere in that minor version downgrade path.
Well, if I do,
Here's a guess.
Sep 19 2018
This is now on the beta cluster for testing.
Sep 18 2018
Ok :/
Aware of not having npm in stretch?
The last Parsoid deploy to beta was Wed or Thursday of last week.
Probably the same thing that caused T198421 cropping up again
Sep 17 2018
17:30 <+cscott> https://stackoverflow.com/questions/8707235/how-to-create-new-property-dynamically has some benchmarks
17:24 <+cscott> i think PHP supports "property added after the fact", sort of like JS does
17:24 <+cscott> but (a) it's known to be quite slow in PHP, probably not appropriate for something used as often as data-parsoid/etc annotations
17:24 <+cscott> and (b) it *may* not be supported on native objects, which the DOM node classes might be? worth a test, maybe...
17:25 <+cscott> ...but better yet if we don't need to
17:25 <+cscott> http://php.net/manual/en/book.dom.php
17:25 <+cscott> i don't immediately see anything specific to mapping DOM nodes to native PHP objects
17:22 <+subbu> arlolra, "DU.(get|set)NodeData touch node object internals, which won't be available after a php port." ... I annotated the notes later indicating that I may have been mistaken because Tim seems have to written code assuming it works (in 2014).
17:22 <+subbu> so, either the dom impl has changed, he didn't test it, or i didn't use the right api method.
17:22 <+subbu> that apart, it is still useful to do the bag on the side impl.
A reduced test case is {{1x|;hi}}:ho, which is closer to what's happening in T99843
Sep 14 2018
Sep 13 2018
Noted that these values are suspicious and being fixed,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/deploy/+/460449 is deployed to the beta cluster
Sorry, I will change that for the beta cluster and restart Parsoid there.
Right now if I request 1.9.0 from Parsoid, it returns 2.0.0 instead of throwing. We can fix that in RB, but I think Parsoid should throw too.
Seems a bit hacky.. how hard would it be to special-case? I'm ok to follow this path too with some good commenting, but still, a bit hacky..
I thought the plan was to downgrade HTML on the way out of RESTBase and on the way back provide downgraded new HTML and latest old HTML&Data-Parsoid from storage for a transform T202666.
Sep 12 2018
Great, thanks! It'd be even better if the Parsing-Team were tagged on those
Sep 7 2018
If we're going to do this, the module shouldn't have to sometimes remove stray <nowiki> tags and sometimes not.
For example. this template is using it as an adhoc escape mechanism, where heredoc args would be preferable (see T114432)
I have no idea what Parsoid does or is intending to do.
Digging a little deeper, since c7a8875 in core, nowikis are stripped as general markers while preprocessing only (ie. ot['pre'], and not ot['html']). A change like,
Sep 5 2018
The example from https://en.wikipedia.org/wiki/Template:Row_indexer in https://en.wikipedia.org/wiki/Special:ExpandTemplates produces,
Aug 31 2018
Aug 30 2018
That proposal says,
If the rerender returned version semver minor less then requested - return. why isn't that a 406 as well?
Aug 28 2018
Aug 23 2018
That's up for discussion in T202593
Aug 22 2018
Oh, I see T202593. Yes, we've established precedence here, so adding warnings for those other cases should be fine, if so desired.
What's the other issue you mentioned?
However, it still doesn't work because of the SSL issues.
Actually that file doesn't match up with deployment-tin:/srv/deployment/parsoid/deploy/conf/wmf/betalabs.localsettings.js
Host: sv.wikipedia.beta.wmflabs.org. is not in the cert