Page MenuHomePhabricator

Arlolra (Arlo Breault)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:34 PM (254 w, 2 d)
Availability
Available
IRC Nick
arlolra
LDAP User
Arlolra
MediaWiki User
Arlolra [ Global Accounts ]

Recent Activity

Mon, Aug 19

Arlolra updated the task description for T227209: Security Review For Parsoid-PHP.
Mon, Aug 19, 8:45 PM · Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

For development and debugging purposes, Parsoid also supports accessing an external MediaWiki installation via its action API. Parsoid/JS doesn't require that external wiki to have installed the ParsoidBatchAPI extension, but Parsoid/PHP depends on that currently (* TODO: Verify *).

Mon, Aug 19, 8:44 PM · Restricted Project, Parsoid-PHP, Security-Team-Reviews

Sat, Aug 17

ToBeFree awarded T118517: [RFC] Use <figure> for media a Like token.
Sat, Aug 17, 11:23 PM · Accessibility, Parsing-Team, Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, MediaWiki-Parser, TechCom-RFC

Tue, Aug 13

Dalba awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Dislike token.
Tue, Aug 13, 11:33 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Thu, Aug 8

Arlolra created P8890 (An Untitled Masterwork).
Thu, Aug 8, 10:20 PM
Arlolra created P8889 (An Untitled Masterwork).
Thu, Aug 8, 10:09 PM

Mon, Aug 5

Arlolra closed T229531: Ensure change from git a0a27f5 is applied to extension/src/Config/SiteConfig as well as Resolved.

The extension implementation is as follow,

Mon, Aug 5, 11:16 PM · Parsoid-PHP
Arlolra added a comment to T200678: (OoW) wtp2011 memory correctable errors.

After the upgrade, I confirmed the host was still running the currently deployed version,

Mon, Aug 5, 10:15 PM · Operations, ops-codfw
Arlolra added a comment to T200678: (OoW) wtp2011 memory correctable errors.

I ran, SSH_AUTH_SOCK=/run/keyholder/proxy.sock ssh -l deploy-service wtp2011 'depool service=parsoid' from deployment.eqiad.wmnet and it's now showing {"wtp2011.codfw.wmnet": {"weight": 10, "pooled": "no"}, "tags": "dc=codfw,cluster=parsoid,service=parsoid"}

Mon, Aug 5, 9:34 PM · Operations, ops-codfw
Arlolra closed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint, a subtask of T229356: Run roundtrip tests with Parsoid/PHP on scandium, as Resolved.
Mon, Aug 5, 8:11 PM · Parsoid-PHP
Arlolra closed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint as Resolved.
Mon, Aug 5, 8:11 PM · Parsoid-PHP

Sat, Aug 3

Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

With that ^ the rt test script at least runs

Sat, Aug 3, 2:36 PM · Parsoid-PHP

Fri, Aug 2

Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

A quick test with, node bin/roundtrip-test.js --domain ve --parsoidURL http://localhost/rest.php "Main Page", is returning,

Fri, Aug 2, 9:43 PM · Parsoid-PHP

Wed, Jul 31

Arlolra added a comment to T226523: Template in wikilink target position also returns pipe separated params.

I don't think the last fix deployment has fixed anything regarding that ticket. The Parsoid output is still broken so far I can see.

Wed, Jul 31, 4:39 PM · Patch-For-Review, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Parsoid
Arlolra added a comment to T229375: TypeError in references endpoint.

In the meantime, here's an edit that fixes it,
https://en.wikipedia.org/w/index.php?title=Maine&type=revision&diff=908732865&oldid=908276611&diffmode=source

Wed, Jul 31, 4:34 PM · Parsoid, Page Content Service, Reading-Infrastructure-Team-Backlog
Arlolra added a comment to T229375: TypeError in references endpoint.

The content seems to contain {{#tag:ref|Maine does not ... <references group="nb" /> |group="nb"}}, which results in references in references.

Wed, Jul 31, 4:25 PM · Parsoid, Page Content Service, Reading-Infrastructure-Team-Backlog

Tue, Jul 30

Arlolra claimed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.
Tue, Jul 30, 4:48 PM · Parsoid-PHP
Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

How do we pass in the rt testing flag to Parsoid?

Tue, Jul 30, 4:34 PM · Parsoid-PHP
Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

The parsoid config is only used to get prefixes, which isn't really needed.

Tue, Jul 30, 4:07 PM · Parsoid-PHP

Fri, Jul 26

Jdforrester-WMF awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Like token.
Fri, Jul 26, 5:43 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016
Ladsgroup awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Love token.
Fri, Jul 26, 11:18 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Wed, Jul 24

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Wed, Jul 24, 8:26 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Wed, Jul 24, 7:41 PM · Patch-For-Review, Parsoid-PHP

Tue, Jul 23

Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

There should probably be better test coverage of this bin or at least fixing this,
https://github.com/wikimedia/parsoid/blob/master/bin/toolcheck.sh#L19-L21

Tue, Jul 23, 10:34 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 10:32 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 9:28 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 9:27 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 6:16 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 5:45 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 4:19 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Tue, Jul 23, 4:18 PM · Patch-For-Review, Parsoid-PHP

Jul 22 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 22 2019, 10:08 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

Trying to address T178914: parse.js should have standard arguments as part of this port might be something worth considering.

Jul 22 2019, 9:41 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).

@Arlolra has some WIP patches as well so maybe he has some insight into this question.

Jul 22 2019, 5:13 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Jul 19 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 19 2019, 4:01 AM · Patch-For-Review, Parsoid-PHP

Jul 18 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 18 2019, 5:49 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

genTest is not relevant in the post-javascript world, so I'm crossing those off

Jul 18 2019, 5:49 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 18 2019, 5:38 PM · Patch-For-Review, Parsoid-PHP

Jul 17 2019

Arlolra closed T228223: tokensToString being called on KV->V looks like a signature mismatch as Resolved.
Jul 17 2019, 10:25 PM · Patch-For-Review, Parsoid-PHP

Jul 16 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 16 2019, 10:50 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T228223: tokensToString being called on KV->V looks like a signature mismatch.
Jul 16 2019, 10:44 PM · Patch-For-Review, Parsoid-PHP
Arlolra triaged T228217: Ensure all the features of parse.js are covered by parse.php as Normal priority.
Jul 16 2019, 8:54 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 16 2019, 8:53 PM · Patch-For-Review, Parsoid-PHP
Arlolra placed T217540: Mobile-Sections returns missing images up for grabs.
Jul 16 2019, 7:19 PM · ChangeProp, Reading-Infrastructure-Team-Backlog

Jun 28 2019

Arlolra updated the task description for T214994: PP passes that run `atTopLevel` omit HTML stashed in data-mw.
Jun 28 2019, 1:27 PM · Parsoid-Read-Views

Jun 27 2019

Arlolra closed T226583: Support selser in the bin/parse.php as Resolved.
Jun 27 2019, 7:58 PM · Parsoid-PHP

Jun 25 2019

Arlolra triaged T226583: Support selser in the bin/parse.php as Normal priority.
Jun 25 2019, 9:38 PM · Parsoid-PHP
Arlolra created T226583: Support selser in the bin/parse.php.
Jun 25 2019, 9:38 PM · Parsoid-PHP
Arlolra closed T226451: Possible bug in PHP Tokenizer: Unexpected OOM as Resolved.
Jun 25 2019, 8:02 PM · Parsoid-PHP
Arlolra renamed T226523: Template in wikilink target position also returns pipe separated params from Getting wikitext [[ from MCS on EU wiki to Template in wikilink target position also returns pipe separated params.
Jun 25 2019, 6:56 PM · Patch-For-Review, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Parsoid
Arlolra moved T226523: Template in wikilink target position also returns pipe separated params from Backlog to Link syntax (links & media) on the Parsoid board.
Jun 25 2019, 6:52 PM · Patch-For-Review, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Parsoid
Arlolra triaged T226523: Template in wikilink target position also returns pipe separated params as Normal priority.
Jun 25 2019, 6:52 PM · Patch-For-Review, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Parsoid
Arlolra added a comment to T226523: Template in wikilink target position also returns pipe separated params.

This simplifies as, [[{{1x|Main{{!}}Page}}]]

Jun 25 2019, 6:49 PM · Patch-For-Review, Mobile-Content-Service, Reading-Infrastructure-Team-Backlog, Parsoid

Jun 24 2019

Arlolra claimed T226451: Possible bug in PHP Tokenizer: Unexpected OOM.
Jun 24 2019, 11:26 PM · Parsoid-PHP
Arlolra closed T225026: Implement Parsoid, the entry point interface, to the Parsoid/PHP composer library as Resolved.

Change 516451 merged by jenkins-bot:

Jun 24 2019, 10:41 PM · Patch-For-Review, Parsoid-PHP
Arlolra closed T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib as Resolved.

Change 509531 merged by jenkins-bot:

Jun 24 2019, 10:23 PM · Patch-For-Review, Parsoid-PHP
Arlolra closed T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib, a subtask of T225026: Implement Parsoid, the entry point interface, to the Parsoid/PHP composer library, as Resolved.
Jun 24 2019, 10:22 PM · Patch-For-Review, Parsoid-PHP
Arlolra merged task T186298: Crash on tree depth of ~4k into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:05 PM · Parsoid
Arlolra merged T186298: Crash on tree depth of ~4k into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:05 PM · Parsoid
Arlolra merged T225974: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged task T225974: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra added a comment to T225974: RangeError: Maximum call stack size exceeded.

Probably from,
https://it.wikipedia.org/wiki/Nati_nel_1974
https://it.wikipedia.org/wiki/Nati_nel_1992
etc.

Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged T208794: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged task T208794: RangeError: Maximum call stack size exceeded into T188319: RangeError: Maximum call stack size exceeded.
Jun 24 2019, 7:04 PM · Parsoid
Arlolra merged task T211909: Cannot read property '0' of undefined into T208793: Crasher from missing DSR info -> failed encap -> failed wrapSections.
Jun 24 2019, 6:58 PM · Parsoid
Arlolra merged T211909: Cannot read property '0' of undefined into T208793: Crasher from missing DSR info -> failed encap -> failed wrapSections.
Jun 24 2019, 6:58 PM · Parsoid

Jun 18 2019

Arlolra closed T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least as Resolved.
Jun 18 2019, 6:11 PM · Patch-For-Review, Parsoid-PHP
Arlolra closed T211251: Cannot read property 'nodeName' of undefined as Resolved.
Jun 18 2019, 12:24 AM · Parsoid

Jun 17 2019

Arlolra created T225974: RangeError: Maximum call stack size exceeded.
Jun 17 2019, 10:19 PM · Parsoid
Arlolra claimed T211251: Cannot read property 'nodeName' of undefined.
Jun 17 2019, 10:18 PM · Parsoid
Arlolra closed T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki) as Resolved.
Jun 17 2019, 8:55 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor
Arlolra added a comment to T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).

A post-deploy test seems to preserve headline spacing,
https://office.wikimedia.org/w/index.php?title=User:ABreault_(WMF)/sandbox&type=revision&diff=253119&oldid=253118&diffmode=source

Jun 17 2019, 8:55 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor

Jun 12 2019

Arlolra updated subscribers of T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least.

As @cscott says,

Jun 12 2019, 4:15 PM · Patch-For-Review, Parsoid-PHP

Jun 11 2019

Arlolra added a comment to T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least.

The JS mock API and the ApiHelper.php don't exactly play nice together, in that they have different ideas of which formatversion to use. There's also some redundancy with the JS baseconfigs and the ApiHelper.php cached data.

Jun 11 2019, 10:51 PM · Patch-For-Review, Parsoid-PHP

Jun 7 2019

Arlolra added a comment to T225217: VE is removing spaces (dirty diffs) on some wikis (wikitech, officewiki).

Only on private wikis.

Jun 7 2019, 4:42 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor

Jun 6 2019

Arlolra created T225235: Hybrid testing should use the JS mock API on the PHP side, for files at least.
Jun 6 2019, 5:04 PM · Patch-For-Review, Parsoid-PHP

May 29 2019

Arlolra closed T219927: Move parsoid logging to new logging pipeline, a subtask of T211125: Move service-runner to new logging infrastructure, as Resolved.
May 29 2019, 8:40 PM · observability, Core Platform Team Legacy (Watching / External), Patch-For-Review, service-runner, Wikimedia-Logstash, Operations
Arlolra closed T219927: Move parsoid logging to new logging pipeline as Resolved.
May 29 2019, 8:40 PM · observability, Parsoid, Core Platform Team Legacy (Watching / External), Services (watching), service-runner, Wikimedia-Logstash, Operations

May 23 2019

Arlolra added a comment to T224241: Generate ids based on dsr info.

Since templated regions might expand or contract between parses, the encoding should probably include both dsr[0] and dsr[1]. Contractions that expose nodes could result in additional dirty diff'ing, but shouldn't produce corruption.

May 23 2019, 8:24 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T224241: Generate ids based on dsr info.

I guess the next steps are,

May 23 2019, 8:08 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T224241: Generate ids based on dsr info.

Right, I think I've exhausted my usefulness here, thanks.

May 23 2019, 7:49 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T224241: Generate ids based on dsr info.

If there's a solution to assign stable ids to the nested content, why not just use that for the entire page?

May 23 2019, 7:38 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T224241: Generate ids based on dsr info.

dsr isn't applied in templated regions (all data-parsoid is dropped in there as is), it only corresponds to the top-level page.

May 23 2019, 6:45 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T224241: Generate ids based on dsr info.

Basically, this amounts to, if we have valid dsr info, use that for generating an id. If not, discard data-parsoid for that node.

May 23 2019, 6:28 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T224241: Generate ids based on dsr info.

For the most part, this corresponds with the code here,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/pp/handlers/CleanUp.js#L194-L214

May 23 2019, 6:27 PM · Patch-For-Review, Parsoid
Arlolra triaged T224241: Generate ids based on dsr info as Normal priority.
May 23 2019, 6:23 PM · Patch-For-Review, Parsoid
Arlolra created T224241: Generate ids based on dsr info.
May 23 2019, 6:23 PM · Patch-For-Review, Parsoid

May 21 2019

Arlolra updated the task description for T214651: The extension api seems to want a dom-diff-handler.
May 21 2019, 3:37 PM · Parsoid-Read-Views

May 1 2019

Arlolra claimed T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib.
May 1 2019, 2:47 AM · Patch-For-Review, Parsoid-PHP

Apr 29 2019

Arlolra placed T211161: Tweaks to genTest option in parse.js up for grabs.
Apr 29 2019, 10:38 PM · Patch-For-Review, Parsoid-PHP

Apr 26 2019

Arlolra closed T205338: Extract and use a DOMHandler interface (API) for HTML -> wt handlers defined on DOM nodes as Resolved.
Apr 26 2019, 11:05 PM · Patch-For-Review, Parsoid-PHP
Arlolra created T221988: Spec a PHP interface that will serve as an entry point into the Parsoid-PHP composer lib.
Apr 26 2019, 7:07 PM · Patch-For-Review, Parsoid-PHP

Apr 24 2019

Arlolra claimed T205338: Extract and use a DOMHandler interface (API) for HTML -> wt handlers defined on DOM nodes.
Apr 24 2019, 6:40 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a parent task for T221790: Parsoid extension API should use DOM fragments, not documents: T179082: Use one ownerDocument for the entire parse.
Apr 24 2019, 5:52 PM · Parsoid-PHP
Arlolra added a subtask for T179082: Use one ownerDocument for the entire parse: T221790: Parsoid extension API should use DOM fragments, not documents.
Apr 24 2019, 5:52 PM · Parsoid

Apr 9 2019

Arlolra added a comment to T110961: Error handling in Parsoid.

See T123446#5098558

Apr 9 2019, 5:55 PM · Parsoid-Robustness, Parsoid
Arlolra added a comment to T123446: Bring back the req. timeouts without cancelling the cpu timeout.

Is the process.exit going to be removed? It's causing issues in MWOffliner

Apr 9 2019, 5:54 PM · Patch-For-Review, Parsoid-Web-API, Parsoid

Mar 26 2019

Arlolra added a comment to T219023: Source editor and VisualEditor force piped-link creation for links when using lower-case first character and more than one word.

Post deploy testing,
https://en.wikipedia.org/w/index.php?title=User:Arlolra/sandbox&type=revision&diff=889591137&oldid=884316233&diffmode=source

Mar 26 2019, 5:41 PM · User-Ryasmeen, Patch-For-Review, Parsoid, Regression, VisualEditor, MediaWiki-Page-editing

Mar 25 2019

Arlolra committed rELINTbdb69813e761: Remove Column 'Nested wikilinks in external links that need to be fixed' (authored by farida29).
Remove Column 'Nested wikilinks in external links that need to be fixed'
Mar 25 2019, 10:22 PM
Arlolra committed rELINT9ce3988ec3af: Remove Column 'Nested wikilinks in external links that need to be fixed' (authored by farida29).
Remove Column 'Nested wikilinks in external links that need to be fixed'
Mar 25 2019, 10:05 PM