Page MenuHomePhabricator

Arlolra (Arlo Breault)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:34 PM (329 w, 1 d)
Availability
Available
IRC Nick
arlolra
LDAP User
Arlolra
MediaWiki User
Arlolra [ Global Accounts ]

Recent Activity

Yesterday

Arlolra updated the task description for T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..
Tue, Jan 26, 10:39 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra updated subscribers of T273014: Caption as link content for inline broken media.

WRT captions appearing in the error case:
The {MediaWiki DOM Spec](https://www.mediawiki.org/wiki/Specs/HTML/2.2.0#Images) says:

<figcaption (absent when inline)>...</figcaption>

and

The outer <figure> element needs to become a <span> element when the figure is rendered inline, since otherwise the HTML5 parser will interrupt a surrounding block context. The inner <figcaption> element is rendered as a data-mw attribute in this case (since block content in an invisible caption would otherwise break parsing).

So the issue here is a bit of ambiguity in what "when rendered inline" means, and we can be more precise about it. But probably "rendered inline" meaning "uses a span as the wrapper" and so if we decide to output the caption for broken error cases we should also change the outer wrapper from "span" to "figure". That might also cause rendering differences, but at least it would be self-consistent. Then we'd just need to clarify that media will be "rendered inline" only for non-error cases.

Tue, Jan 26, 10:38 PM · Patch-For-Review, Parsoid
Arlolra triaged T273014: Caption as link content for inline broken media as Medium priority.
Tue, Jan 26, 10:37 PM · Patch-For-Review, Parsoid
Arlolra created T273014: Caption as link content for inline broken media.
Tue, Jan 26, 10:37 PM · Patch-For-Review, Parsoid
Arlolra updated the task description for T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..
Tue, Jan 26, 10:32 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra triaged T273013: Dynamically adjust size for broken media as Medium priority.
Tue, Jan 26, 10:31 PM · Parsoid
Arlolra created T273013: Dynamically adjust size for broken media.
Tue, Jan 26, 10:30 PM · Parsoid

Mon, Jan 25

Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

https://mw-expt-tests.wmflabs.org/diff/dewiki/Ingvar_Carlsson is an example where the image in the figcaption overflows, resulting in a rendering difference. This similar to T171761 but the word-break isn't going to work here

Mon, Jan 25, 11:30 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra committed rIVDI4873caa71d88: Revert some of 15541e1 (authored by Arlolra).
Revert some of 15541e1
Mon, Jan 25, 10:18 PM

Thu, Jan 21

Arlolra updated the task description for T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..
Thu, Jan 21, 11:18 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser

Wed, Jan 20

Arlolra closed T270373: Wikisource Export: Underscores show instead of spaces in some titles as Resolved.
Wed, Jan 20, 7:40 PM · Community-Tech, Parsoid, Wikisource Export
Arlolra merged T272507: mw.text.unstripNoWiki doesn't unstrip when using Parsoid into T203293: Strip state: {{Row numbers}} completely fails on the Android app / VisualEditor.
Wed, Jan 20, 5:28 PM · MediaWiki-Parser, VisualEditor, Parsoid-Rendering, Parsoid, Wikipedia-Android-App-Backlog
Arlolra merged task T272507: mw.text.unstripNoWiki doesn't unstrip when using Parsoid into T203293: Strip state: {{Row numbers}} completely fails on the Android app / VisualEditor.
Wed, Jan 20, 5:27 PM · MediaWiki-Parser, Parsoid, MediaWiki-extensions-Scribunto

Tue, Jan 19

Arlolra updated the task description for T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..
Tue, Jan 19, 9:29 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

Also on https://mw-expt-tests.wmflabs.org/diff/enwiki/Diffusion, it appears that thumb at "Diffusion in the context of different disciplines" is clearing right, when it shouldn't be, since it's floating above the heading. That's a bug in the CSS that needs resolving.

Tue, Jan 19, 9:25 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a comment to T270373: Wikisource Export: Underscores show instead of spaces in some titles.

What's the wikitext source?

Tue, Jan 19, 6:28 PM · Community-Tech, Parsoid, Wikisource Export

Mon, Jan 18

Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

Only thumbnails should get the margin-bottom: 0.5em; from,
https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.less#L110

Mon, Jan 18, 4:17 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser

Fri, Jan 15

Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

Also on https://mw-expt-tests.wmflabs.org/diff/enwiki/Diffusion, it appears that thumb at "Diffusion in the context of different disciplines" is clearing right, when it shouldn't be, since it's floating above the heading. That's a bug in the CSS that needs resolving.

Fri, Jan 15, 10:40 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

https://mw-expt-tests.wmflabs.org/diff/enwiki/Diffusion shows that TimedMediaHandler isn't recognizing the new output. That should be handled in T272186

Fri, Jan 15, 10:35 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra triaged T272186: Update extensions to handle the new media structure as Medium priority.
Fri, Jan 15, 10:34 PM · Parsoid
Arlolra created T272186: Update extensions to handle the new media structure.
Fri, Jan 15, 10:33 PM · Parsoid
Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

https://mw-expt-tests.wmflabs.org/diff/dewiki/Liste%20der%20preu%C3%9Fischen%20Handelsminister is an example of https://gerrit.wikimedia.org/r/c/mediawiki/core/+/507512/16/includes/Linker.php#b417

Fri, Jan 15, 10:20 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

From the early results, https://mw-expt-tests.wmflabs.org/diff/enwiki/Anglo-Saxon%20settlement%20of%20Britain is an example of T169975#4176954

Fri, Jan 15, 9:39 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

We might want to do a round of $wgParserOutputLegacyMediaDOM = true; vs HEAD^ to establish a baseline that nothing is broken.

Fri, Jan 15, 8:12 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a comment to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..

A round of visual diff'ing is now running with the key "media-test", results at https://mw-expt-tests.wmflabs.org/

Fri, Jan 15, 8:08 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra committed rIVDIb6995c2da459: Default examples for uprightdiff to /usr/local/bin/ (authored by Arlolra).
Default examples for uprightdiff to /usr/local/bin/
Fri, Jan 15, 7:08 PM

Thu, Jan 14

Arlolra added a comment to T233252: Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage.

Maybe just mention T252246 or T262833 here so that we add coverage when doing those?

Thu, Jan 14, 6:19 PM · Parsoid

Wed, Jan 13

Arlolra committed rIVDIbb4bfc176e20: Revert most of 70ae32d (authored by Arlolra).
Revert most of 70ae32d
Wed, Jan 13, 9:19 PM
Arlolra closed T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation as Resolved.
Wed, Jan 13, 6:54 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid

Fri, Jan 8

Arlolra closed T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI as Resolved.
Fri, Jan 8, 10:12 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra triaged T270150: Selectors in content.media.less need improvement in terms of performance and stability as Medium priority.
Fri, Jan 8, 7:09 PM · Parsoid
Arlolra moved T270150: Selectors in content.media.less need improvement in terms of performance and stability from Needs Investigation to Media Structure on the Parsoid board.
Fri, Jan 8, 7:09 PM · Parsoid
Arlolra closed T271357: PHP Notice: Undefined property: stdClass::$extsrc as Resolved.
Fri, Jan 8, 5:07 PM · Parsoid, Wikimedia-production-error

Mon, Jan 4

Arlolra committed rIVDI2edd6a922790: Pretty much revert f01a5bc (authored by Arlolra).
Pretty much revert f01a5bc
Mon, Jan 4, 10:13 PM
Arlolra added a reverting change for rIVDIf01a5bcff8bf: Further tweaks + fix syntax error: rIVDI2edd6a922790: Pretty much revert f01a5bc.
Mon, Jan 4, 10:13 PM
Arlolra updated subscribers of T271114: Update site specific css for new media structure.

From @ssastry on irc,

Mon, Jan 4, 9:58 PM · Parsoid
Arlolra added a comment to T271157: https://fr.wikipedia.org/wiki/MediaWiki:Common.js makes use of image alt text, which Parsoid doesn't output.

For where this is used, see for example "Localisation" in the infobox on https://fr.wikipedia.org/wiki/Bratislava

Mon, Jan 4, 8:45 PM · Parsoid
Arlolra added a comment to T271157: https://fr.wikipedia.org/wiki/MediaWiki:Common.js makes use of image alt text, which Parsoid doesn't output.

See the tooltip issue in T108380

Mon, Jan 4, 8:44 PM · Parsoid
Arlolra created T271157: https://fr.wikipedia.org/wiki/MediaWiki:Common.js makes use of image alt text, which Parsoid doesn't output.
Mon, Jan 4, 8:43 PM · Parsoid
Arlolra triaged T271129: Update tests for $wgUseNewMediaStructure as Medium priority.
Mon, Jan 4, 6:01 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, Parsoid
Arlolra created T271129: Update tests for $wgUseNewMediaStructure.
Mon, Jan 4, 6:00 PM · MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, Parsoid
Arlolra moved T51097: Use figure and figcaption HTML5 elements when possible from Needs Triage to Media Structure on the Parsoid board.
Mon, Jan 4, 5:56 PM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
Arlolra added a project to T51097: Use figure and figcaption HTML5 elements when possible: Parsoid.
Mon, Jan 4, 5:55 PM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
Arlolra moved T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc. from Needs Triage to Media Structure on the Parsoid board.
Mon, Jan 4, 5:55 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra added a project to T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc.: Parsoid.
Mon, Jan 4, 5:54 PM · MW-1.36-notes (1.36.0-wmf.29; 2021-02-02), Parsoid, MediaWiki-Parser
Arlolra moved T113258: Draft email announcement about proposed change to output <figure> from PHP parser for images from Current & Upcoming Work to Media Structure on the Parsoid board.
Mon, Jan 4, 5:51 PM · Parsoid, MediaWiki-Parser
Arlolra moved T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI from Current & Upcoming Work to Media Structure on the Parsoid board.
Mon, Jan 4, 5:51 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra moved T268250: Decide on a structure for galleries from Current & Upcoming Work to Media Structure on the Parsoid board.
Mon, Jan 4, 5:51 PM · Parsing-Active-Work, Parsoid
Arlolra moved T271114: Update site specific css for new media structure from Needs Triage to Media Structure on the Parsoid board.
Mon, Jan 4, 5:50 PM · Parsoid
Arlolra claimed T271114: Update site specific css for new media structure.
Mon, Jan 4, 5:48 PM · Parsoid
Arlolra created T271114: Update site specific css for new media structure.
Mon, Jan 4, 3:41 PM · Parsoid

Dec 20 2020

Arlolra claimed T113258: Draft email announcement about proposed change to output <figure> from PHP parser for images.
Dec 20 2020, 4:41 PM · Parsoid, MediaWiki-Parser

Dec 18 2020

Arlolra added a subtask for T263082: add <langconvert> parser tag: T270516: Add support for <langconvert> to Parsoid.
Dec 18 2020, 6:37 PM · User-notice, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Parsoid (Tracking), MediaWiki-Language-converter, Chinese-Sites, MediaWiki-Parser, Patch-For-Review
Arlolra added a parent task for T270516: Add support for <langconvert> to Parsoid: T263082: add <langconvert> parser tag.
Dec 18 2020, 6:36 PM · Parsoid
Arlolra created T270516: Add support for <langconvert> to Parsoid.
Dec 18 2020, 6:36 PM · Parsoid

Dec 16 2020

Arlolra closed T266143: Parsoid clients should handle inline media HTML change from <figure-inline> to <span> as Resolved.

It looks like this is just waiting on QA in T268309 so I'm going to close it but please reopen if that proves problematic.

Dec 16 2020, 9:10 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Editing-team (Tracking), Patch-For-Review, Parsoid, DiscussionTools, StructuredDiscussions, ContentTranslation, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Page Content Service, Growth-Team, VisualEditor
Arlolra closed T251641: RFC: HTML element for inline media from wikitext as Resolved.

Parsoid started producing spans again in version 2.2.0 of its output.

Dec 16 2020, 9:07 PM · Patch-For-Review, MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), TechCom-RFC (TechCom-RFC-Closed), Parsing-Active-Work, Parsing-Team--ARCHIVED
Arlolra moved T270326: regression-testing.sh (and downstream scripts) should be able to pass outputContentVersion per commit from Needs Triage to Testing on the Parsoid board.
Dec 16 2020, 5:58 PM · Parsoid
Arlolra triaged T270326: regression-testing.sh (and downstream scripts) should be able to pass outputContentVersion per commit as Low priority.
Dec 16 2020, 5:57 PM · Parsoid
Arlolra created T270326: regression-testing.sh (and downstream scripts) should be able to pass outputContentVersion per commit.
Dec 16 2020, 5:56 PM · Parsoid

Dec 15 2020

Arlolra added a comment to T270199: Table of contents in Parsoid output.

Also related, T92999

Dec 15 2020, 6:11 PM · Parsoid-Rendering, Parsoid
Arlolra added a comment to T51097: Use figure and figcaption HTML5 elements when possible.

But @Arlolra seems to have found the exception to that rule which we've all forgotten; I await with bated breath.

Dec 15 2020, 3:48 PM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
Arlolra added a comment to T51097: Use figure and figcaption HTML5 elements when possible.

I said this because I think the place where the stylesheet is saying to hide the figcaption is misleading. Those are inline images where it isn't even emitted and the content is placed in the data-mw.

Dec 15 2020, 3:18 PM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
Arlolra added a comment to T51097: Use figure and figcaption HTML5 elements when possible.

I think we should file individual tasks for these things so they can be researched more thoroughly.

Dec 15 2020, 3:22 AM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
Arlolra added a subtask for T51097: Use figure and figcaption HTML5 elements when possible: T270150: Selectors in content.media.less need improvement in terms of performance and stability.
Dec 15 2020, 2:17 AM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface
Arlolra added a subtask for T258836: [EPIC] Ensure Parsoid meets performance criteria for serving read views on the Parsoid cluster: T270150: Selectors in content.media.less need improvement in terms of performance and stability.
Dec 15 2020, 2:17 AM · Platform Engineering, Performance-Team (Radar), Parsoid, Parsoid-Rendering
Arlolra added parent tasks for T270150: Selectors in content.media.less need improvement in terms of performance and stability: T258836: [EPIC] Ensure Parsoid meets performance criteria for serving read views on the Parsoid cluster, T51097: Use figure and figcaption HTML5 elements when possible.
Dec 15 2020, 2:17 AM · Parsoid
Arlolra created T270150: Selectors in content.media.less need improvement in terms of performance and stability.
Dec 15 2020, 2:16 AM · Parsoid
Arlolra updated subscribers of T51097: Use figure and figcaption HTML5 elements when possible.

@Arlolra @Jdlrobson The new selectors introduced here seem quite bad in terms of performance and stability. They seem very fragile, and I don't think we should use those on production page views.

Code in question at mediawiki.skinning/content.media.less.

Dec 15 2020, 1:15 AM · Parsoid, Patch-For-Review, MediaWiki-Parser, Parsing-Team--ARCHIVED, Accessibility, MediaWiki-Interface

Dec 14 2020

Arlolra added a comment to T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.

T258719 is perhaps relevant for which selector to use, but orthogonal to the issue here.

Dec 14 2020, 10:33 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra claimed T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.
Dec 14 2020, 10:32 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra added a comment to T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.

It does use mw-content-$dir elsewhere, but see T258719

Dec 14 2020, 6:26 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra added a comment to T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.

Parsoid sets mw-content-$dir based on the page language,
https://github.com/wikimedia/parsoid/blob/master/src/Wt2Html/DOMPostProcessor.php#L734

Dec 14 2020, 6:23 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid

Dec 11 2020

Arlolra closed T266148: Add feature flag to protect core media output change patches as Resolved.

This exists as $wgUseNewMediaStructure now

Dec 11 2020, 8:15 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), Patch-For-Review, MediaWiki-Parser

Dec 10 2020

Arlolra closed T127884: Respect $wgAllowImageTag wiki configuration flag in the Sanitizer as Declined.

This was deprecated in https://github.com/wikimedia/mediawiki/commit/8c43d758414925bae6e4442486f3c768102fecd1 as part of T254802

Dec 10 2020, 8:25 PM · Parsoid (Third-party), Parsoid-Rendering

Dec 9 2020

Arlolra closed T269748: Cite / References: strtolower() expects parameter 1 to be string, integer given as Resolved.
Dec 9 2020, 4:17 PM · Parsoid, Wikimedia-production-error
Arlolra closed T266146: Update Page Content Service to handle Parsoid HTML change from <figure-inline> to <span>, a subtask of T266143: Parsoid clients should handle inline media HTML change from <figure-inline> to <span>, as Resolved.
Dec 9 2020, 3:22 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Editing-team (Tracking), Patch-For-Review, Parsoid, DiscussionTools, StructuredDiscussions, ContentTranslation, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Page Content Service, Growth-Team, VisualEditor
Arlolra closed T266146: Update Page Content Service to handle Parsoid HTML change from <figure-inline> to <span> as Resolved.
Dec 9 2020, 3:22 PM · Product-Infrastructure-Team-Backlog, Page Content Service

Dec 8 2020

Arlolra renamed T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI from Default horizontal alignment should depend on content language, not the UI to Default horizontal alignment of thumbnails should depend on content language, not the UI.
Dec 8 2020, 8:19 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra created T269704: Default horizontal alignment of thumbnails should depend on content language, not the UI.
Dec 8 2020, 8:19 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Parsoid
Arlolra added a comment to T233736: Testing the REST API in CI.

When I want to test this locally, I'll put in my LocalSettings.php,

Dec 8 2020, 8:02 PM · Patch-For-Review, Parsoid

Dec 7 2020

Arlolra added a comment to T269271: Settle on a suitable name for the DOM library.

@Arlolra had a more clever idea, which I'll let him relate.

Dec 7 2020, 6:57 PM · Parsoid

Dec 3 2020

Arlolra added a comment to T266143: Parsoid clients should handle inline media HTML change from <figure-inline> to <span>.

T266143#6668090 starts on looking at the changes Mobile-Content-Service made in T177301

Dec 3 2020, 10:44 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Editing-team (Tracking), Patch-For-Review, Parsoid, DiscussionTools, StructuredDiscussions, ContentTranslation, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Page Content Service, Growth-Team, VisualEditor
Arlolra added a comment to T266143: Parsoid clients should handle inline media HTML change from <figure-inline> to <span>.

It looks like StructuredDiscussions is backwards compatible for T173972. The above patch in T266143#6667623 just updates the test suite.

Dec 3 2020, 7:43 PM · User-Ryasmeen, MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), Editing-team (Tracking), Patch-For-Review, Parsoid, DiscussionTools, StructuredDiscussions, ContentTranslation, Mobile-Content-Service, Product-Infrastructure-Team-Backlog, Page Content Service, Growth-Team, VisualEditor

Nov 30 2020

Arlolra added a comment to T269022: Parsoid Gallery doesn't specify any JS modules in its output unlike core Gallery implementation.

After that's merged, I think this can be closed as a dupe of T162399

Nov 30 2020, 10:18 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T269022: Parsoid Gallery doesn't specify any JS modules in its output unlike core Gallery implementation.

Registering a modulestyle with the extension seems like a pretty coarse grained api. The legacy parser only adds the styles/scripts if the tag is used on the page. We currently do that for places where we call the out to the legacy parser, with env->addOutputProperty

Nov 30 2020, 9:05 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T268947: Gallery rendering difference on eswiki.

Looks like it's happening in https://es.wikipedia.org/w/load.php?lang=es&modules=mediawiki.page.gallery&only=scripts&raw=1&skin=vector&debug=true

Nov 30 2020, 6:09 PM · Parsoid-Rendering, Parsoid
Arlolra added a comment to T268947: Gallery rendering difference on eswiki.

The legacy output has the same dimensions height="120" as Parsoid,

Nov 30 2020, 5:24 PM · Parsoid-Rendering, Parsoid

Nov 25 2020

Arlolra closed T171761: Figcaption overflows image width on unbroken words as Resolved.
Nov 25 2020, 9:21 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering
Arlolra added a comment to T171761: Figcaption overflows image width on unbroken words.

In https://github.com/wikimedia/mediawiki/commit/16b76a486d774e31283a62c0a17cfc9f356ca106 we changed the figcaption from display: table-caption; to display: block; since the figcaption wasn't always present and we didn't want the bottom border to depend on it.

Nov 25 2020, 7:25 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering

Nov 24 2020

Arlolra closed T249742: Call to a member function getAttribute() on null as Resolved.
Nov 24 2020, 5:06 PM · Wikimedia-production-error, Parsoid
Arlolra claimed T249742: Call to a member function getAttribute() on null.
Nov 24 2020, 3:55 PM · Wikimedia-production-error, Parsoid
Arlolra moved T171761: Figcaption overflows image width on unbroken words from Incoming Work (but not yet ready) to Doing (Roadmap Critical Path) on the Parsing-Active-Work board.
Nov 24 2020, 12:12 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering
Arlolra added a project to T171761: Figcaption overflows image width on unbroken words: Parsing-Active-Work.
Nov 24 2020, 12:12 AM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering

Nov 23 2020

Arlolra claimed T171761: Figcaption overflows image width on unbroken words.
Nov 23 2020, 6:25 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering
Arlolra placed T171761: Figcaption overflows image width on unbroken words up for grabs.
Nov 23 2020, 6:25 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering
Arlolra moved T171761: Figcaption overflows image width on unbroken words from Known Differences to Current & Upcoming Work on the Parsoid board.
Nov 23 2020, 6:24 PM · MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), Parsing-Active-Work, MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), Parsoid, Parsoid-Rendering
Arlolra claimed T268250: Decide on a structure for galleries.
Nov 23 2020, 6:24 PM · Parsing-Active-Work, Parsoid
Arlolra added a comment to T248369: Add linting rule for detecting presence of image wikitext in extlinks.

See T267282#6641741 where we're saying this is valid in the case where |link=| suppresses the anchor element around the image.

Nov 23 2020, 6:20 PM · MediaWiki-extensions-Linter, Parsoid

Nov 21 2020

Arlolra closed T265061: Use one document in the serializing direction as well as Resolved.
Nov 21 2020, 1:06 AM · Patch-For-Review, Parsoid