Page MenuHomePhabricator

Arlolra (Arlo Breault)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:34 PM (304 w, 1 d)
Availability
Available
IRC Nick
arlolra
LDAP User
Arlolra
MediaWiki User
Arlolra [ Global Accounts ]

Recent Activity

Today

Arlolra created T259715: Consistent casing for command arguments.
Wed, Aug 5, 2:20 PM · Parsoid
Arlolra added a comment to T259685: Zeroconf VisualEditor/Parsoid doesn't seem to work on SQLite .

Yeah, this was a problem with Parsoid/JS and SQLite as well,
https://www.mediawiki.org/wiki/Topic:Vde0xothlxmwzg2y

Wed, Aug 5, 1:50 PM · Parsoid, VisualEditor, MW-1.35-release, SQLite

Yesterday

Arlolra added a comment to T217705: RemexHTML should be able to parse HTML into an existing DOM node.

https://github.com/fgnass/domino/issues/73

Tue, Aug 4, 7:28 PM · Patch-For-Review, RemexHtml

Wed, Jul 29

Arlolra closed T259063: ParsoidHandler::getParsedBody() needs error handling for json_decode as Resolved.
Wed, Jul 29, 9:35 PM · Parsoid

Tue, Jul 28

Arlolra added a comment to T255190: Parsoid "HTML4BlockTags" tokens are a lie.

VE needs to know the difference between inline and block tags to sensibly split and place new content, for example inline content can be inserted into a paragraph (and indeed must be wrapped in a paragraph or some other content branch), but inserting a table into a paragraph should result in the paragraph being split.

Tue, Jul 28, 8:56 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor
Arlolra added a comment to T259063: ParsoidHandler::getParsedBody() needs error handling for json_decode.

400 Bad Request

Tue, Jul 28, 6:58 PM · Parsoid
Arlolra claimed T217705: RemexHTML should be able to parse HTML into an existing DOM node.
Tue, Jul 28, 5:36 PM · Patch-For-Review, RemexHtml

Mon, Jul 27

Arlolra added a comment to T258856: Links to variants titles in Parsoid are still marked as red links.

But even there redlinks is the last pass to run, no?

Mon, Jul 27, 7:18 PM · Parsoid
Arlolra added a comment to T258856: Links to variants titles in Parsoid are still marked as red links.

Redlink processing is the last step though and Parsoid's parserTests pretty much considers all links as known when it's doing redlink processing,
https://github.com/wikimedia/parsoid/blob/master/src/Config/Api/DataAccess.php#L144-L146

Mon, Jul 27, 7:06 PM · Parsoid

Fri, Jul 24

Arlolra closed T258767: Parsoid parser test API framework gives video thumbnail URL incorrect when seek options are used as Invalid.

See the poster here,
https://en.wikipedia.org/api/rest_v1/page/html/Wikipedia:Extended_image_syntax#Temporal_media_fragments

Fri, Jul 24, 2:15 PM · Patch-For-Review, Parsoid

Thu, Jul 23

Arlolra renamed T248319: Document how to set up RESTBase w/ Parsoid/PHP from Document how to set up RestBASE w/ Parsoid/PHP to Document how to set up RESTBase w/ Parsoid/PHP.
Thu, Jul 23, 6:29 PM · Documentation, Parsoid, RESTBase
Arlolra placed T255190: Parsoid "HTML4BlockTags" tokens are a lie up for grabs.

We duplicate this list in VE, so that would need to be fixed too.

Thu, Jul 23, 6:27 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor

Tue, Jul 21

Arlolra added a comment to T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace.

Please let us know if there is an action for the Editing-team @ssastry

Tue, Jul 21, 8:16 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Editing-team (Tracking), Patch-For-Review, VisualEditor, Parsoid

Fri, Jul 17

Arlolra added a comment to T258302: Rollout Suggestor.

See T149961 where it says,

Fri, Jul 17, 11:20 PM · WMF-Legal, Tor, Suggestor
Arlolra added a comment to T149962: Edit proxy.

This is about automatic approval of the edits so they don't have to be queued though. It turns Suggestor into an editing proxy and is a great way to get it banned :)

Fri, Jul 17, 11:18 PM · Suggestor
Arlolra added a comment to T149960: Run edits through ORES.

But in any case, I thought ORES was for edits already on-wiki, is it possible to run proposed edits through it?

Fri, Jul 17, 11:12 PM · Suggestor
Arlolra claimed T179082: Use one ownerDocument for the entire parse.
Fri, Jul 17, 6:39 PM · Patch-For-Review, Parsoid
Arlolra claimed T221790: Parsoid extension API should use DOM fragments, not documents.
Fri, Jul 17, 6:39 PM · Patch-For-Review, Parsoid

Thu, Jul 16

Arlolra added a comment to T255190: Parsoid "HTML4BlockTags" tokens are a lie.

$HTML4BlockTags is no more

Thu, Jul 16, 10:05 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor

Thu, Jul 9

Arlolra added a comment to T255190: Parsoid "HTML4BlockTags" tokens are a lie.

Wrt HTML4BlockTags use and a general historical philosophy in Parsoid, https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/608968/3/src/Config/WikitextConstants.php#26, @ssastry says,

Thu, Jul 9, 4:32 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor

Wed, Jul 8

Arlolra placed T255795: Invalid / unavailable fragment id encountered while parsing up for grabs.
Wed, Jul 8, 10:36 PM · Parsoid-Rendering, Parsoid
Arlolra added a comment to T251842: Proposal for Parsoid Cite error html generation.

Ok, done

Wed, Jul 8, 7:40 PM · Parsing-Active-Work, Parsoid
Arlolra added a comment to T251842: Proposal for Parsoid Cite error html generation.

Should we remove https://www.mediawiki.org/wiki/Help:Cite#Parsoids_Cite_extension_is_changing_how_errors_are_handled_and_error_information_is_encoded_for_clients_to_use. ?

Wed, Jul 8, 3:08 PM · Parsing-Active-Work, Parsoid

Jul 2 2020

Arlolra added a comment to T251641: RFC: HTML element for inline media from wikitext.

@Krinkle Please bring this to last call whenever possible.

Jul 2 2020, 11:29 PM · TechCom-RFC (TechCom-RFC-Closed), Parsing-Active-Work, Parsing-Team

Jul 1 2020

Arlolra added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/607902 was also part of this

Jul 1 2020, 5:48 PM · Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 30 2020

Arlolra added a comment to T256687: Should VE copy ids?.

@JTannerWMF Yes, please, we need information. What's the goal in copying the ids and when is it done?

Jun 30 2020, 9:26 PM · Editing-team (Tracking), VisualEditor, Parsoid

Jun 29 2020

Arlolra closed T245206: VE removes space in wikitext in list elements starting with wikilinks as Resolved.

VE seems to be duplicating the id when inserting that paragraph,

Jun 29 2020, 9:00 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor
Arlolra added projects to T256687: Should VE copy ids?: Parsoid, VisualEditor.
Jun 29 2020, 8:57 PM · Editing-team (Tracking), VisualEditor, Parsoid
Arlolra created T256687: Should VE copy ids?.
Jun 29 2020, 8:56 PM · Editing-team (Tracking), VisualEditor, Parsoid
Arlolra moved T112045: Parsoid lacks support for mustRender in the non-extension DataAccesses from Needs Investigation to Missing Functionality on the Parsoid board.
Jun 29 2020, 5:14 PM · Parsoid, WMF-deploy-2015-09-15_(1.26wmf23), WMF-deploy-2015-09-08_(1.26wmf22), Parsoid-Rendering
Arlolra renamed T112045: Parsoid lacks support for mustRender in the non-extension DataAccesses from Parsoid lacks support for mustRender to Parsoid lacks support for mustRender in the non-extension DataAccesses.
Jun 29 2020, 5:14 PM · Parsoid, WMF-deploy-2015-09-15_(1.26wmf23), WMF-deploy-2015-09-08_(1.26wmf22), Parsoid-Rendering
Arlolra placed T112045: Parsoid lacks support for mustRender in the non-extension DataAccesses up for grabs.

This support is now there in the Parsoid Batching API. If all testing goes well, that will be enabled in production next week. So, the only thing left here is support in the non-batching API. It is unclear how easy it is to do it there, and if the batching API becomes the default, it is low priority to do this for the non-batching API use case.

Jun 29 2020, 5:12 PM · Parsoid, WMF-deploy-2015-09-15_(1.26wmf23), WMF-deploy-2015-09-08_(1.26wmf22), Parsoid-Rendering

Jun 26 2020

Arlolra added a comment to T253481: The number of citation doesn't match when using `/api/rest_v1/page/mobile-sections/`.

Dangling references are inconsistently supported though. If it's in an image caption, ex. [[File:Test.png|Hi<ref>ho</ref>]], Parsoid will find it with $extApi->processHiddenHTMLInDataAttributes. So maybe this is another case that method should be handling.

Jun 26 2020, 12:33 AM · Cite, Parsoid, Product-Infrastructure-Team-Backlog

Jun 25 2020

Arlolra added a comment to T191641: Graceful degradation of generated HTML in the face of template-wrapping, section-wrapping, or other edit-client-support features.

We should start by gathering some data on how often these failures occur.

Jun 25 2020, 6:10 PM · Parsoid-Rendering, Parsoid

Jun 23 2020

Arlolra claimed T255190: Parsoid "HTML4BlockTags" tokens are a lie.
Jun 23 2020, 6:05 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor

Jun 22 2020

Arlolra closed T255746: Conversion error for leading whitespaces in pararaph and indent-pre suppressing contexts as Resolved.
Jun 22 2020, 10:02 PM · Parsoid

Jun 19 2020

Arlolra claimed T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments).
Jun 19 2020, 5:28 PM · Patch-Needs-Improvement, TechCom-RFC (TechCom-RFC-Closed), Parsing-Team, Wikimedia-Developer-Summit-2016

Jun 18 2020

Arlolra claimed T255795: Invalid / unavailable fragment id encountered while parsing.
Jun 18 2020, 9:16 PM · Parsoid-Rendering, Parsoid
Arlolra moved T70466: Add parser test for multiline <pre> or <syntaxhighlight> elements inside a dd element created by ":" from Testing to Known Differences on the Parsoid board.
Jun 18 2020, 8:45 PM · MediaWiki-Parser, Parsoid-Tests, Parsoid
Arlolra added a project to T70466: Add parser test for multiline <pre> or <syntaxhighlight> elements inside a dd element created by ":": MediaWiki-Parser.

This is because <syntaxhighlight> gets unstripped before doBlockLevels(),
https://github.com/wikimedia/mediawiki/blob/08510de602c239a60d0918bdbf666250d8ac5846/includes/parser/Parser.php#L1651-L1653

Jun 18 2020, 8:44 PM · MediaWiki-Parser, Parsoid-Tests, Parsoid
Arlolra created T255798: Missing serialization spec.
Jun 18 2020, 5:09 PM · Parsoid

Jun 17 2020

Arlolra closed T255500: DSR info not present on mw:DisplaySpace as Resolved.
Jun 17 2020, 7:47 PM · Parsoid
Arlolra added a comment to T231570: DomSourceRange serializes with null entries.

There's a bit of an analysis / discussion of what it means for the open / close widths to be null in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/606035/3/src/Wt2Html/PP/Handlers/DisplaySpace.php#13

Jun 17 2020, 5:59 PM · Parsoid

Jun 15 2020

Arlolra added a comment to T255500: DSR info not present on mw:DisplaySpace.
17:54 <subbu> if you need a test page for T255500 I think it is arwiki النادي الأهلي (طرابلس)
17:54 <subbu> or enwiki List of future tallest buildings
17:54 <subbu> as in I don't know which one it is :-) 
17:54 <subbu> but probably the arwiki one.
Jun 15 2020, 9:55 PM · Parsoid
Arlolra moved T255500: DSR info not present on mw:DisplaySpace from Needs Triage to Bugs & Crashers on the Parsoid board.
Jun 15 2020, 9:37 PM · Parsoid
Arlolra triaged T255500: DSR info not present on mw:DisplaySpace as High priority.
Jun 15 2020, 9:37 PM · Parsoid
Arlolra created T255500: DSR info not present on mw:DisplaySpace.
Jun 15 2020, 9:37 PM · Parsoid
Arlolra added a comment to T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace.

Update the spec when this is resolved.

Jun 15 2020, 9:18 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Editing-team (Tracking), Patch-For-Review, VisualEditor, Parsoid
Arlolra closed T254500: Update spec to include mw:DisplaySpace as Resolved.

Added in https://www.mediawiki.org/w/index.php?title=Specs/HTML/2.1.0&type=revision&diff=3912001&oldid=3735022&diffmode=source

Jun 15 2020, 9:17 PM · Parsoid
Arlolra closed T168473: Parsoid should record server hostname that served the API response in case of errors/warnings as Resolved.

No longer in relevant since Parsoid/PHP makes these calls directly,
https://github.com/wikimedia/parsoid/blob/master/extension/src/Config/DataAccess.php#L343

Jun 15 2020, 6:38 PM · Parsoid
Arlolra created P11507 (An Untitled Masterwork).
Jun 15 2020, 5:36 PM
Arlolra triaged T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules as High priority.
Jun 15 2020, 5:12 PM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra moved T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules from Needs Triage to Bugs & Crashers on the Parsoid board.
Jun 15 2020, 5:11 PM · MediaWiki-Parser, TemplateStyles, Parsoid

Jun 12 2020

Arlolra claimed T254500: Update spec to include mw:DisplaySpace.
Jun 12 2020, 3:46 AM · Parsoid

Jun 11 2020

Arlolra added a comment to T255190: Parsoid "HTML4BlockTags" tokens are a lie.

Re: <video>, the comment there says,

Jun 11 2020, 9:56 PM · Editing-team (FY2020-21 Kanban Board), Patch-For-Review, VisualEditor
Arlolra added a comment to T247168: A space should be included after list token when adding a new item to an existant list.

I'm not sure that duplicating the id is working out so well. See T245206#6208042

Jun 11 2020, 1:33 PM · VisualEditor
Arlolra added a comment to T245206: VE removes space in wikitext in list elements starting with wikilinks.

Continuing from the some of the discussion in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/604035,

Jun 11 2020, 1:31 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor
Arlolra added a project to T245206: VE removes space in wikitext in list elements starting with wikilinks: Parsing-Active-Work.
Jun 11 2020, 12:41 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor
Arlolra removed projects from T245206: VE removes space in wikitext in list elements starting with wikilinks: Parsing-Active-Work, Patch-For-Review.
Jun 11 2020, 12:35 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

The space after the CSS escape is harmless. For it's own baroque reasons, CSS doesn't have separate escape mechanisms for 2-hex-digit and 4-hex-digit unicode escapes, so instead it collects digits until it sees a non-digit, and if the non-digit is a space then it eats it. https://drafts.csswg.org/css-syntax/#consume-escaped-code-point

Jun 11 2020, 12:19 PM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

so there seem to be multiple layers of brokenness here

Jun 11 2020, 1:56 AM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

The space is probably necessary to avoid the escaped character combining in any nefarious way.

Jun 11 2020, 12:42 AM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

Somehow the \a0 (correct CSS escape for a non-breaking space) is turned into \a0 (extra space at the end)

Jun 11 2020, 12:32 AM · MediaWiki-Parser, TemplateStyles, Parsoid

Jun 10 2020

Arlolra claimed T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.
Jun 10 2020, 11:54 PM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

Why would the sanitizer be invoked for the contents of a TemplateStyles <style> tag though, which is not an attribute and has its own sanitizer?

Jun 10 2020, 11:52 PM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

TemplateStyles seems to be using a nowiki to avoid doBlockLevels processing,
https://github.com/wikimedia/mediawiki-extensions-TemplateStyles/blob/324dcb3d0612e778764ae675fff3491218591a91/includes/TemplateStylesHooks.php#L378-L381

Jun 10 2020, 11:47 PM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra added a comment to T255007: Unwanted non-breaking space added before a ':' in TemplateStyles rules.

Yeah, this was a result of the changes in T197879

Jun 10 2020, 11:00 PM · MediaWiki-Parser, TemplateStyles, Parsoid
Arlolra moved T251641: RFC: HTML element for inline media from wikitext from P1: Define to P4: Tune on the TechCom-RFC board.
Jun 10 2020, 8:51 PM · TechCom-RFC (TechCom-RFC-Closed), Parsing-Active-Work, Parsing-Team
Arlolra reopened T251641: RFC: HTML element for inline media from wikitext as "Open".
Jun 10 2020, 8:51 PM · TechCom-RFC (TechCom-RFC-Closed), Parsing-Active-Work, Parsing-Team
Arlolra closed T251641: RFC: HTML element for inline media from wikitext as Declined.

<figure> has semantic meaning from the HTML5 spec. <figure-inline> does not. It is a non-standard element with the same default semantics of an inline element as <span>, no different from <mw-xyz>.

If the only benefit for the custom element is that of standardisation, then I think we should shy away from it in our page view output until and unless such a standard has emerged. We can certainly push for that with our W3C membership and contacts at WHATWG, but unless we want to block this RFC on that, I think for this RFC the only point in favour of <figure-inline> is compat for existing Parsoid clients. Would you agree?

Jun 10 2020, 6:45 PM · TechCom-RFC (TechCom-RFC-Closed), Parsing-Active-Work, Parsing-Team

Jun 9 2020

Arlolra added a comment to T245206: VE removes space in wikitext in list elements starting with wikilinks.

Yes: to reproduce list2 bug, you must add a new paragraph just before the list (in addition to format first word of one element)

Jun 9 2020, 10:32 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor
Arlolra added a comment to T245206: VE removes space in wikitext in list elements starting with wikilinks.

Please look at this diff.

Jun 9 2020, 5:42 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor
Arlolra claimed T245206: VE removes space in wikitext in list elements starting with wikilinks.
Jun 9 2020, 5:07 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor

Jun 8 2020

Arlolra added a comment to T245206: VE removes space in wikitext in list elements starting with wikilinks.

Given that we just discussed this in the context of https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/591224

Jun 8 2020, 11:22 PM · User-Ryasmeen, Patch-For-Review, Parsing-Active-Work, Parsoid, VisualEditor

Jun 7 2020

Arlolra moved T254678: Add unit tests for PegTokenizer from Needs Triage to Testing on the Parsoid board.
Jun 7 2020, 12:58 AM · Parsoid
Arlolra triaged T254678: Add unit tests for PegTokenizer as Medium priority.
Jun 7 2020, 12:58 AM · Parsoid
Arlolra closed T222774: Parser rule clean-up: url & autourl as Resolved.

Btw url is a starting rule, and I don't see any test code for this rule

We probably need unit tests for all the starting rules.

Jun 7 2020, 12:57 AM · Parsing-Active-Work, Parsoid
Arlolra created T254678: Add unit tests for PegTokenizer.
Jun 7 2020, 12:57 AM · Parsoid

Jun 5 2020

Arlolra closed T222770: Parser rule clean-up: extlink_preprocessor_text_parameterized as Resolved.
Jun 5 2020, 5:38 PM · Parsing-Active-Work, Parsoid
Arlolra closed T197879: Fix mw:DisplaySpace to match PHP "armorFrenchSpaces" as Resolved.
Jun 5 2020, 12:29 AM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Parsing-Active-Work, Parsoid, Parsoid-Rendering

Jun 4 2020

Arlolra added a comment to T251346: ERROR: Error: Undefined constant 'ast\AST_LIST' .

This seems to be crashing Parsoid CI now? @Arlolra has details.

Jun 4 2020, 9:10 PM · Patch-For-Review, phan-taint-check-plugin
Arlolra added a comment to T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace.

Depending on the resolution here, we might need to mark mw:DisplaySpace as uneditable in the TestRunner.
See https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/602477

Jun 4 2020, 8:33 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Editing-team (Tracking), Patch-For-Review, VisualEditor, Parsoid
Arlolra closed T254512: mw:DisplaySpace doesn't need a data-parsoid src, a subtask of T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace, as Invalid.
Jun 4 2020, 8:05 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Editing-team (Tracking), Patch-For-Review, VisualEditor, Parsoid
Arlolra closed T254512: mw:DisplaySpace doesn't need a data-parsoid src as Invalid.

The src belongs the mw:Placeholder

Jun 4 2020, 8:05 PM · Parsoid
Arlolra added a parent task for T254512: mw:DisplaySpace doesn't need a data-parsoid src: T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace.
Jun 4 2020, 8:01 PM · Parsoid
Arlolra added a subtask for T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace: T254512: mw:DisplaySpace doesn't need a data-parsoid src.
Jun 4 2020, 8:01 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Editing-team (Tracking), Patch-For-Review, VisualEditor, Parsoid
Arlolra added a comment to T254512: mw:DisplaySpace doesn't need a data-parsoid src.

See https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/591224/10/src/Wt2Html/PP/Handlers/DisplaySpace.php

Jun 4 2020, 8:00 PM · Parsoid
Arlolra added a comment to T254502: Remove mw:Placeholder and data-parsoid from mw:DisplaySpace.

See T94509 for context

Jun 4 2020, 5:37 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Editing-team (Tracking), Patch-For-Review, VisualEditor, Parsoid
Arlolra renamed T254500: Update spec to include mw:DisplaySpace from Update spec to include mw:DisplayHack to Update spec to include mw:DisplaySpace.
Jun 4 2020, 5:21 PM · Parsoid
Arlolra added a comment to T254501: Implement htmlPreprocess and maybe use it for mw:DisplaySpace and DSR conversion.

We used to have one,
https://github.com/wikimedia/parsoid/commit/02b09d887c9c5d8afa3d9c7dae69aede0182f94b
https://github.com/wikimedia/parsoid/blob/master/lib/FromHTML.js

Jun 4 2020, 5:20 PM · Parsoid
Arlolra created T254501: Implement htmlPreprocess and maybe use it for mw:DisplaySpace and DSR conversion.
Jun 4 2020, 5:16 PM · Parsoid
Arlolra created T254500: Update spec to include mw:DisplaySpace.
Jun 4 2020, 5:11 PM · Parsoid
Arlolra added a comment to T106561: Decide on a strategy for the special-casing of auto-whitespace in front of colons for French output.

Or maybe it only got fixed in T241906

Jun 4 2020, 2:12 PM · User-Ryasmeen, VisualEditor, Parsoid
Arlolra added a comment to T106561: Decide on a strategy for the special-casing of auto-whitespace in front of colons for French output.

Probably related to when T94509 was being deployed.

Jun 4 2020, 2:10 PM · User-Ryasmeen, VisualEditor, Parsoid

Jun 3 2020

Arlolra added a comment to T251641: RFC: HTML element for inline media from wikitext.

Notes from last week:

  • What's the expected benefit of a dedicated element? For example, does this enable particular optimisations or something within Parsoid's codebase?
Jun 3 2020, 2:42 PM · TechCom-RFC (TechCom-RFC-Closed), Parsing-Active-Work, Parsing-Team
Arlolra closed T106561: Decide on a strategy for the special-casing of auto-whitespace in front of colons for French output as Resolved.

Hm, I can't seem to reproduce this with Parsoid. Could this be VE's fault?

Jun 3 2020, 1:54 AM · User-Ryasmeen, VisualEditor, Parsoid

Jun 1 2020

Arlolra added a parent task for T247110: Parsoid needs to implement the Pre-Save Transform (PST): T139159: Pre-save transforms aren't executed on VE<->WT switch, so e.g. signatures are nowiki'ed, pipe trick links are left unresolved.
Jun 1 2020, 5:04 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsoid
Arlolra added a subtask for T139159: Pre-save transforms aren't executed on VE<->WT switch, so e.g. signatures are nowiki'ed, pipe trick links are left unresolved: T247110: Parsoid needs to implement the Pre-Save Transform (PST).
Jun 1 2020, 5:04 PM · VisualEditor-MediaWiki, Parsoid, VisualEditor
Arlolra added a comment to T247110: Parsoid needs to implement the Pre-Save Transform (PST).

The above patch and https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/256052 remove some support for PST from the grammar. Noting them here in case they need to be restored.

Jun 1 2020, 5:02 PM · MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), Parsoid
Arlolra added a comment to T249931: Add support for i18n for error messages.

The current string in Parsoid can be found here https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/599115

Jun 1 2020, 4:56 PM · Parsoid