The final result, I41a45266d266195aa6002d3854e018cacf052ca6, is the one we want but since they all stack on top of each other, you might have to do all three. It's fine to just rebase the last one though.

Mar 20 2019, 10:40 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-zeljkofilipin, Patch-For-Review, Core Platform Team, Parsing-Team, MediaWiki-Parser, Wikimedia-production-error

Arlolra added a comment to T218817: PHP Warning: count(): Parameter must be an array or an object that implements Countable.

Hold up, there's another bug here with ExplodeIterator we're discussing.

Mar 20 2019, 8:59 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-zeljkofilipin, Patch-For-Review, Core Platform Team, Parsing-Team, MediaWiki-Parser, Wikimedia-production-error

Arlolra added a comment to T218817: PHP Warning: count(): Parameter must be an array or an object that implements Countable.

@zeljkofilipin Looking, thanks. Maybe it should be an iterator_count ...

Mar 20 2019, 8:22 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-zeljkofilipin, Patch-For-Review, Core Platform Team, Parsing-Team, MediaWiki-Parser, Wikimedia-production-error

Mar 19 2019

Arlolra closed T218702: ParserIntegrationTest for Scribunto failing in Wikibase CI as Resolved.

Since https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/497320 merged, I'm going to assume this is done.

Mar 19 2019, 6:58 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), SyntaxHighlight, User-Addshore, Wikimedia-production-error (Shared Build Failure), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), Wikidata, MediaWiki-extensions-Scribunto, MediaWiki-Core-Testing

Arlolra closed T208070: Parse requests return gratuitous newlines as Resolved.

Mar 19 2019, 2:59 PM · MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-Parser, Parsoid

Mar 14 2019

Arlolra added a comment to T217867: Port domino (or another spec-compliant DOM library) to PHP.

We've been looking for alternate DOM libraries and they don't seem to be common, alas.

Mar 14 2019, 6:48 PM · Core Platform Team Backlog (Attic), Parsoid-PHP

Mar 13 2019

Arlolra closed T213950: Links: External links with special characters, and surrounded by square brakets, are not rendered properly as Resolved.

Mar 13 2019, 10:44 PM · User-Ryasmeen, Patch-For-Review, Parsoid-Edit-Support, VisualEditor-MediaWiki-Links, VisualEditor

Mar 4 2019

Arlolra added a comment to T202905: Outreach-17 Project: Add a new Linter Category: Links-in-Links.

We should remove the column that says "Nested wikilinks in external links that need to be fixed" since it doesn't seem to be used.

Mar 4 2019, 10:36 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Parsoid-Linter, Outreach-Programs-Projects, Outreachy (Round 17), MediaWiki-extensions-Linter

Arlolra added a comment to T202905: Outreach-17 Project: Add a new Linter Category: Links-in-Links.

but there doesn't appear to be good dsr info to act on,

Mar 4 2019, 10:35 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Parsoid-Linter, Outreach-Programs-Projects, Outreachy (Round 17), MediaWiki-extensions-Linter

Arlolra added a comment to T214099: Stress test Parsoid's HTTP API.

For the record, this is what was done from T214099#4981608,

Mar 4 2019, 10:22 PM · Patch-For-Review, Services (watching), Parsoid-Web-API, Parsoid

Arlolra added a comment to T202905: Outreach-17 Project: Add a new Linter Category: Links-in-Links.

This category is now being populated, but there doesn't appear to be good dsr info to act on,
https://en.wikipedia.org/wiki/Special:LintErrors/wikilink-in-extlink

Mar 4 2019, 10:18 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, Parsoid-Linter, Outreach-Programs-Projects, Outreachy (Round 17), MediaWiki-extensions-Linter

Arlolra added a comment to T217604: Could not find config setting ` default_dsh_targets`.

T217597 looks related

Mar 4 2019, 9:25 PM · Release-Engineering-Team, Scap, Parsoid

Arlolra created T217604: Could not find config setting ` default_dsh_targets`.

Mar 4 2019, 9:20 PM · Release-Engineering-Team, Scap, Parsoid

Arlolra added a comment to T217540: Mobile-Sections returns missing images.

Hmm, so the file was renamed recently on 2018-02-10,
https://commons.wikimedia.org/w/index.php?title=File%3ACoat_of_arms_of_Seychelles.svg&type=revision&diff=338463956&oldid=338257332

Mar 4 2019, 7:50 PM · Reading-Infrastructure-Team-Backlog, Mobile-Content-Service, Parsoid

Feb 28 2019

Arlolra added a comment to T205943: RESTBase hacks for compatibility to Parsoid.

RESTBase provides fake Main_Page title to transform endpoint. I'm not sure if that's even needed any more, but seems like just a workaround of a bug in Parsoid request validation.

Feb 28 2019, 11:37 PM · Core Platform Team Backlog (Watching / External), Services (watching), Parsoid, RESTBase

Feb 27 2019

Arlolra closed T214099: Stress test Parsoid's HTTP API as Resolved.

Feb 27 2019, 10:39 PM · Patch-For-Review, Services (watching), Parsoid-Web-API, Parsoid

Feb 25 2019

Arlolra closed T217093: Cannot read property 'docId' of undefined as Resolved.

Feb 25 2019, 10:18 PM · Patch-For-Review, Parsoid

Arlolra created T217098: Testing infra that pushes real pages through the language converter endpoint.

Feb 25 2019, 10:18 PM · Parsoid

Arlolra closed T214103: Instrument Parsoid language variant conversions as Resolved.

Feb 25 2019, 10:12 PM · Patch-For-Review, Services (watching), Parsoid

Arlolra added a comment to T217093: Cannot read property 'docId' of undefined.

In any case, @cscott, this is a testing gap currently.

Feb 25 2019, 10:00 PM · Patch-For-Review, Parsoid

Arlolra claimed T217093: Cannot read property 'docId' of undefined.

Feb 25 2019, 9:35 PM · Patch-For-Review, Parsoid

Arlolra created T217095: Aborted deploy does not revert config changes.

Feb 25 2019, 9:34 PM · Release-Engineering-Team, Parsoid, Scap

Arlolra added a project to T217093: Cannot read property 'docId' of undefined: Parsoid.

Feb 25 2019, 9:28 PM · Patch-For-Review, Parsoid

Arlolra created T217093: Cannot read property 'docId' of undefined.

Feb 25 2019, 9:28 PM · Patch-For-Review, Parsoid

Arlolra added a comment to T214099: Stress test Parsoid's HTTP API.

Why is num_workers set to 1 there? I'm reading the git commit message that changed it, but I don't understand the rationale.

Feb 25 2019, 7:34 PM · Patch-For-Review, Services (watching), Parsoid-Web-API, Parsoid

Arlolra closed T216534: Parsoid fails to deploy to beta cluster as Resolved.

This wasn't an issue deployed today.

Feb 25 2019, 6:06 PM · Release-Engineering-Team, Beta-Cluster-Infrastructure, Parsoid

Arlolra added a comment to T214099: Stress test Parsoid's HTTP API.

Pretty sure the following patch is the problem of why Parsoid's maxConcurrentCalls isn't being respected.

Feb 25 2019, 4:50 PM · Patch-For-Review, Services (watching), Parsoid-Web-API, Parsoid

Feb 23 2019

Arlolra added a comment to T214099: Stress test Parsoid's HTTP API.

Pretty sure the following patch is the problem of why Parsoid's maxConcurrentCalls isn't being respected.

Feb 23 2019, 12:32 AM · Patch-For-Review, Services (watching), Parsoid-Web-API, Parsoid

Feb 21 2019

Arlolra closed T204608: Use a bag-on-the-side implementation, rather than an internal .dataobject for node data as Resolved.

Feb 21 2019, 3:36 PM · Patch-For-Review, Parsoid-PHP

Arlolra claimed T214099: Stress test Parsoid's HTTP API.

Feb 21 2019, 3:35 PM · Patch-For-Review, Services (watching), Parsoid-Web-API, Parsoid

Feb 19 2019

Arlolra added projects to T216534: Parsoid fails to deploy to beta cluster: Beta-Cluster-Infrastructure, Release-Engineering-Team.

Feb 19 2019, 6:35 PM · Release-Engineering-Team, Beta-Cluster-Infrastructure, Parsoid

Arlolra created T216534: Parsoid fails to deploy to beta cluster.

Feb 19 2019, 6:33 PM · Release-Engineering-Team, Beta-Cluster-Infrastructure, Parsoid

Arlolra added a comment to T216289: Parsoid is incompatible with node v11 due to about ID nondeterminism.

Is there a phab task somewhere for "Parsoid is nondeterministic" generally? I seem to recall creating one for the "reproducible parses" issue...

Feb 19 2019, 4:26 PM · Parsoid

Feb 15 2019

Arlolra added a comment to T216289: Parsoid is incompatible with node v11 due to about ID nondeterminism.

I think you're confused between the test failure and the blacklist change.

Feb 15 2019, 11:17 PM · Parsoid

Arlolra added a comment to T216289: Parsoid is incompatible with node v11 due to about ID nondeterminism.

From https://github.com/wikimedia/parsoid/commit/05f0f9b92314f64e567ef2fd4a04b4c9e8ee4692 when it was ignored in CI,

Feb 15 2019, 10:47 PM · Parsoid

Arlolra added a comment to T179082: Use one ownerDocument for the entire parse.

That's from T204608

Feb 15 2019, 5:00 PM · Parsoid

Arlolra added a comment to T179082: Use one ownerDocument for the entire parse.

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/490654 identifies where all the docs are currently created.

Feb 15 2019, 4:59 PM · Parsoid

Arlolra added a comment to T216203: RESTBase content-negotiation tests are broken.

Tests for content-negotiation rely on Parsoid being able to produce 2 different major content versions. Since a change in Parsoid 1.x content version is not supported anymore.

Feb 15 2019, 4:57 PM · RESTBase, Parsoid, Services (later)

Feb 12 2019

Arlolra closed T215824: AddMediaInfo pass isn't robust to link-in-link as Resolved.

Feb 12 2019, 12:22 AM · Patch-For-Review, Parsoid

Feb 11 2019

Arlolra triaged T215824: AddMediaInfo pass isn't robust to link-in-link as Normal priority.

Feb 11 2019, 10:42 PM · Patch-For-Review, Parsoid

Arlolra closed T213468: Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded as Resolved.

https://en.wikipedia.org/api/rest_v1/page/html/User:ESanders_(WMF)%2Fsandbox/877762681 now has,

Feb 11 2019, 9:57 PM · Patch-For-Review, Parsoid

Arlolra updated the task description for T215824: AddMediaInfo pass isn't robust to link-in-link.

Feb 11 2019, 6:23 PM · Patch-For-Review, Parsoid

Arlolra added a comment to T215824: AddMediaInfo pass isn't robust to link-in-link.

http://localhost:8000/nl.wikipedia.org/v3/page/html/De_Meern/53147456 give this example,

Feb 11 2019, 6:23 PM · Patch-For-Review, Parsoid

Arlolra created T215824: AddMediaInfo pass isn't robust to link-in-link.

Feb 11 2019, 5:33 PM · Patch-For-Review, Parsoid

Feb 8 2019

Arlolra closed T215638: List tokens use special-cased "bullets" property instead of stuffing it in attribs like other tokens as Resolved.

Feb 8 2019, 11:32 PM · Patch-For-Review, Parsoid-PHP

Feb 7 2019

Arlolra added a comment to T215537: Investigate 500s from batch request failures.

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.02.07/parsoid?id=AWjIsGyznlBds_JjA_-S&_g=h@44136fa
http://localhost:8000/fr.wikipedia.org/v3/page/html/Utilisateur%3AChico75%2Fpages_avec_pourcent/156246032

Feb 7 2019, 5:51 PM · Patch-For-Review, Parsoid

Arlolra added a subtask for T215537: Investigate 500s from batch request failures: T215110: ParsoidBatchAPI timeout on frwikisource due to Score extension.

Feb 7 2019, 5:30 PM · Patch-For-Review, Parsoid

Arlolra added a parent task for T215110: ParsoidBatchAPI timeout on frwikisource due to Score extension: T215537: Investigate 500s from batch request failures.

Feb 7 2019, 5:30 PM · Parsoid, MediaWiki-extensions-Score

Arlolra created T215537: Investigate 500s from batch request failures.

Feb 7 2019, 5:30 PM · Patch-For-Review, Parsoid

Arlolra closed T180995: Batch API request error as Resolved.

No longer seems to be an issue with http://localhost:8000/sr.wikisource.org/v3/page/html/%D0%9A%D0%BE%D1%81%D0%BE%D0%B2%D1%81%D0%BA%D0%B8_%D0%B1%D0%BE%D1%98_(%D1%80%D1%83%D0%BA%D0%BE%D0%BF%D0%B8%D1%81)/60110

Feb 7 2019, 5:22 PM · Parsoid-Read-Views

Feb 6 2019

Arlolra added a comment to T215474: Simplify isSolTransparent / isRenderingTransparentNode predicates.

See the review at https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/488100/6//COMMIT_MSG

Feb 6 2019, 11:31 PM · Technical-Debt, Parsoid

Arlolra added a comment to T214241: data-mw info is clobbered by template annotations.

Note that this also happens when unpacking dom fragments,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/pp/handlers/unpackDOMFragments.js#L200-L204

Feb 6 2019, 10:59 PM · Parsoid

Arlolra closed T169975: Missing images render as broken img tags, not redlinks, a subtask of T39902: RFC: Implement rendering of redlinks in Parsoid HTML as post-processor, as Resolved.

Feb 6 2019, 6:28 PM · TechCom-RFC (TechCom-Approved), Services (blocked), User-mobrovac, Parsing-Team, Parsoid

Arlolra closed T169975: Missing images render as broken img tags, not redlinks as Resolved.

Feb 6 2019, 6:28 PM · Patch-For-Review, Parsoid-Read-Views

Feb 1 2019

Arlolra closed T153080: Parse images synchronously without making imageinfo requests and use a final postprocessing pass to fixup image HTML as Resolved.

Feb 1 2019, 11:26 PM · Patch-For-Review, Parsoid-PHP

Jan 31 2019

Arlolra added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

@ssastry Parsoid needs an equivalent patch that removes,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/pp/processors/PWrap.js#L35-L36

Jan 31 2019, 12:09 AM · Patch-For-Review, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Parsoid, TemplateStyles, MediaWiki-Parser

Jan 30 2019

Arlolra created T214994: PP passes that run `atTopLevel` omit HTML stashed in data-mw.

Jan 30 2019, 10:47 PM · Parsoid-Read-Views

Jan 25 2019

Arlolra created T214725: transformTests CI script isn't aborting on failure.

Jan 25 2019, 8:42 PM · Patch-For-Review, Parsoid

Arlolra placed T207279: Redlinks DOM pass adds mw api + network latency to parse time up for grabs.

Jan 25 2019, 5:21 PM · Parsoid

Arlolra placed T179605: LintError bogus-image-options triggers on "Thumbtime" up for grabs.

Jan 25 2019, 5:20 PM · Parsoid-Linter, MediaWiki-extensions-Linter

Jan 24 2019

Arlolra updated the task description for T214648: DOMDiff'ing doesn't traverse into galleries.

Jan 24 2019, 11:04 PM · Parsoid-Edit-Support, Patch-For-Review

Arlolra updated the task description for T214649: VE's gallery representation differs enough so that selser is never applied?.

Jan 24 2019, 11:02 PM · Patch-For-Review, VisualEditor, Parsoid

Arlolra merged task T211246: Diffs to be investigated into T214649: VE's gallery representation differs enough so that selser is never applied?.

Jan 24 2019, 10:55 PM · Parsoid-Serializer, Parsoid

Arlolra merged T211246: Diffs to be investigated into T214649: VE's gallery representation differs enough so that selser is never applied?.

Jan 24 2019, 10:55 PM · Patch-For-Review, VisualEditor, Parsoid

Arlolra added a subtask for T214651: The extension api seems to want a dom-diff-handler: T214648: DOMDiff'ing doesn't traverse into galleries.

Jan 24 2019, 10:33 PM · Parsoid-Read-Views

Arlolra added a parent task for T214648: DOMDiff'ing doesn't traverse into galleries: T214651: The extension api seems to want a dom-diff-handler.

Jan 24 2019, 10:33 PM · Parsoid-Edit-Support, Patch-For-Review

Arlolra created T214651: The extension api seems to want a dom-diff-handler.

Jan 24 2019, 10:33 PM · Parsoid-Read-Views

Arlolra updated the task description for T214648: DOMDiff'ing doesn't traverse into galleries.

Jan 24 2019, 10:23 PM · Parsoid-Edit-Support, Patch-For-Review

Arlolra created T214649: VE's gallery representation differs enough so that selser is never applied?.

Jan 24 2019, 10:23 PM · Patch-For-Review, VisualEditor, Parsoid

Arlolra created T214648: DOMDiff'ing doesn't traverse into galleries.

Jan 24 2019, 10:14 PM · Parsoid-Edit-Support, Patch-For-Review

Arlolra added a comment to T211246: Diffs to be investigated.

These are going to be exacerbated now that "extsrc" is gone,
https://en.wikipedia.org/w/index.php?title=Kashubian_language&curid=17254&diff=880004780&oldid=879154010&diffmode=source

Jan 24 2019, 7:12 PM · Parsoid-Serializer, Parsoid

Arlolra added a comment to T211895: VE shouldn't add the File: prefix when missing in a gallery.

Here's a list of pages with gallery normalizations to explore,
https://phabricator.wikimedia.org/P8032

Jan 24 2019, 5:58 PM · Parsoid, VisualEditor

Arlolra created P8032 (An Untitled Masterwork).

Jan 24 2019, 5:56 PM

Arlolra added a comment to T214601: Gallery media is erroneously using sub-typeof if format is supplied.

In "plwiki/Leonardo da Vinci", the dimensions gets applied, which is similar,

Jan 24 2019, 4:59 PM · Parsoid

Arlolra created T214603: "thumbtime" is lost when roundtripping in gallery.

Jan 24 2019, 4:57 PM · Parsoid

Arlolra added a comment to T214601: Gallery media is erroneously using sub-typeof if format is supplied.

Roundtripping the bogus option would be part of T211895 / T151367

Jan 24 2019, 4:56 PM · Parsoid

Arlolra created T214601: Gallery media is erroneously using sub-typeof if format is supplied.

Jan 24 2019, 4:51 PM · Parsoid

Arlolra added a comment to T106431: Audit SOL state of subpipelines.

The current values were made explicit in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/482761

Jan 24 2019, 2:06 AM · Parsoid-Read-Views, Parsoid-Tokenizer

Jan 23 2019

Arlolra closed T214443: Packed gallery mode has no tests as Resolved.

Jan 23 2019, 6:52 PM · Patch-For-Review, Parsoid

Arlolra closed T187958: Parsoid and PHP parser parse <gallery caption="…"> differently as Resolved.

Jan 23 2019, 6:51 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Parsoid-Read-Views, Patch-For-Review, MediaWiki-Parser

Arlolra placed T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position up for grabs.

Jan 23 2019, 4:53 PM · Parsoid

Arlolra placed T210647: Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code up for grabs.

Jan 23 2019, 4:52 PM · Parsoid-Read-Views

Arlolra placed T186278: Attributes that expand to block? elements fail to roundtrip up for grabs.

Jan 23 2019, 4:50 PM · Parsoid

Arlolra placed T126834: Table end tag following nl emitting template in attribute position up for grabs.

Jan 23 2019, 4:50 PM · Parsoid-DOM, Parsoid

Jan 22 2019

Arlolra triaged T214443: Packed gallery mode has no tests as Normal priority.

Jan 22 2019, 10:29 PM · Patch-For-Review, Parsoid

Arlolra created T214443: Packed gallery mode has no tests.

Jan 22 2019, 10:29 PM · Patch-For-Review, Parsoid

Arlolra removed a project from T126834: Table end tag following nl emitting template in attribute position: Patch-For-Review.

Jan 22 2019, 7:53 PM · Parsoid-DOM, Parsoid

Arlolra renamed T126834: Table end tag following nl emitting template in attribute position from Multi-transclusion template ending in `|}` breaks whole page rendering (presumably end of table is ignored as not in single line context?) to Table end tag following nl emitting template in attribute position.

Jan 22 2019, 7:52 PM · Parsoid-DOM, Parsoid

Arlolra (Arlo Breault)
User

Projects (24)
View All

Calendar

Today

Tomorrow

Thursday

User Details

Recent Activity
View All

Tue, Apr 9

Tue, Mar 26

Mon, Mar 25

Mar 21 2019

Mar 20 2019

Mar 19 2019

Mar 14 2019

Mar 13 2019

Mar 4 2019

Feb 28 2019

Feb 27 2019

Feb 25 2019

Feb 23 2019

Feb 21 2019

Feb 19 2019

Feb 15 2019

Feb 12 2019

Feb 11 2019

Feb 8 2019

Feb 7 2019

Feb 6 2019

Feb 1 2019

Jan 31 2019

Jan 30 2019

Jan 25 2019

Jan 24 2019

Jan 23 2019

Jan 22 2019

Arlolra (Arlo Breault)User

Projects (24)View All

Calendar

Today

Tomorrow

Thursday

User Details

Recent ActivityView All

Tue, Apr 9

Tue, Mar 26

Mon, Mar 25

Mar 21 2019

Mar 20 2019

Mar 19 2019

Mar 14 2019

Mar 13 2019

Mar 4 2019

Feb 28 2019

Feb 27 2019

Feb 25 2019

Feb 23 2019

Feb 21 2019

Feb 19 2019

Feb 15 2019

Feb 12 2019

Feb 11 2019

Feb 8 2019

Feb 7 2019

Feb 6 2019

Feb 1 2019

Jan 31 2019

Jan 30 2019

Jan 25 2019

Jan 24 2019

Jan 23 2019

Jan 22 2019

Arlolra (Arlo Breault)
User

Projects (24)
View All

Recent Activity
View All