Fri, Dec 7
And more likely hasBadNesting and T165098
This just seemed odd ... why are ref names unquoted?
Wed, Dec 5
This one is just dirty ... why are gallery attributes being normalized?
Tue, Dec 4
See the blacklisted test in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/477421
Fri, Nov 30
A good place to start is,
Thu, Nov 29
Looking at the histogram in logstash, these coincide with yesterday's deploy.
Seeing some more of these.
Parsoid has tested against v8.x in CI since Sept. 2017,
Wed, Nov 28
After that deploy, Parsoid now gets this right too https://www.mediawiki.org/api/rest_v1/page/html/User:Arlolra%2Fsandbox/2986673
There's ~80 semantic regression on https://parsoid-rt-tests.wikimedia.org/regressions/between/970751a51b4c706a0be449cdd12f6f61f35f88bb/179b04141edea6b9fc6658b891ca198c405b771f
After the swat just now, these errors have been reduced to zero.
The oldid for the page I was rendering is https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=2986673
I think you forgot to purge the parser cache when you were testing?
@cscott Unfortunately, I wasn't able to confirm that the patch was fixing the issue so we rolled it back.
Tue, Nov 27
Wed, Nov 21
TypeError: The header content contains invalid characters
Tue, Nov 20
Is there any other information I can give you to make the debugging easier?
Fri, Nov 16
Wed, Nov 14
Just linking with MediaWiki-extensions-AccountInfo to note the overlap.
Nov 8 2018
Cannot reproduce this locally. Can you?
What you've produced is not the crash, but the reason for it. You're piping the rendered page into /dev/null, meaning it didn't crash.
The "Main_Page" probably means it was using the default to parse a snippit. This one's going to require manual inspection.
Nov 7 2018
Did you check the other issues from https://phabricator.wikimedia.org/T206940#4670526 ?
@cscott Although this is much improved and the "after" (from above) of the edit now renders as expected,
Nov 6 2018
Nov 5 2018
Nov 1 2018
Oct 31 2018
Oct 29 2018
Can you reproduce this locally?
Oct 26 2018
Is that faulty profiling?
Added in: v8.5.0
The source on that fiwiki page is pretty much,
Just noting the original reduced test case as,
While the above patch fixes the crasher and improves the rendering from before it was exposed, there's still some work to do to match the php parser's output.
Oct 25 2018
But, the other major difference seems to be in the reported PEG time ... which doesn't make any sense to me. Is that faulty profiling? Total PEG time should not change whether we do sync tokenizing or async tokenizing unless this is causing some backtracking pathology to kick in.
Oct 22 2018
A reduced test case is,
Your MediaWiki instance is served with TLS.
How would I configure Parsoid to listen to https connection?
Oct 19 2018
Well, you haven't configured Parsoid to listen for HTTPS connections on port 8000, only HTTP. But also, you probably aren't exposing 8000 for external connections (through your firewall, or whathaveyou) so only connections to the loopback address (localhost) are connecting. Parsoid might not also be listening for that specific host (your domain).
What happens when you change,
Ok, so presumably curl http://localhost:8000/wiki.jackalope.tech/v3/page/html/Main_Page will render your main page now.
Is it fair to say that your current status is where we left on https://www.mediawiki.org/w/index.php?title=Topic:Umuo9t5f9ox3umdq&topic_showPostId=umvhwzu6vyhzj3xr#flow-post-umvhwzu6vyhzj3xr
Oct 18 2018
12:02 <+subbu> arlolra, reg. the redlinks and media passes and the serial processing for those ... that probably doesn't matter for the PHP port, does it? unless there are ways of structuring those requests that benefits from mysql or other caching across page parse requests. 12:05 <+arlolra> yeah, I wasn't planning on doing it ... but the imageinfo requests would be a short term regression 12:08 <+subbu> have you looked at how the php parser does the media and redlink processing .. i.e. are they also post-processing passes or are they looked up one at a time .. iirc, tim had mentioned that it does batching too. 12:09 <+arlolra> i have not 12:09 <+arlolra> but i'll check it out 12:09 <+subbu> k. asking in case the restructuring should be done in a particular way to benefit form whatever existing code there is. 12:09 <+subbu> *from
Oct 17 2018
Adding redlinks is only enabled when using batching so you're comparing against a no-op,
Oct 16 2018
Oct 15 2018
Oct 11 2018
See the discussion at https://github.com/wikimedia/restbase/pull/1073#pullrequestreview-163606489 when it comes to the documenting portion of this task
Oct 9 2018
That comment is incorrect. The table is not "already rendered" at that stage in the processing; the unstrip call is returning partially-escaped wikitext of the table, which the module then unescapes and processes. The actual rendering of the table happens after the module returns.
Oct 4 2018
@mobrovac The above patch is deployed. Please confirm it meets your expectations
Oct 3 2018
Can you reproduce this locally?
I'm assuming it's this series of patches that broke it
Oct 2 2018
That patch hasn't been deployed yet