Page MenuHomePhabricator

Arlolra (Arlo Breault)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:34 PM (266 w, 17 h)
Availability
Available
IRC Nick
arlolra
LDAP User
Arlolra
MediaWiki User
Arlolra [ Global Accounts ]

Recent Activity

Fri, Nov 8

Arlolra claimed T237463: Resolve all PORT-FIXMEs.
Fri, Nov 8, 10:29 PM · Parsoid-PHP
Arlolra claimed T237666: Parsoid/PHP fails for transforms for new pages with slashes in the title.
Fri, Nov 8, 9:46 PM · Parsoid-PHP

Thu, Nov 7

Arlolra placed T228217: Ensure all the features of parse.js are covered by parse.php up for grabs.
Thu, Nov 7, 4:34 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

I might recommend setting up the SecurityCheckPlugin as a test script for Parsoid/PHP, as it's already using Phan.

Working on this in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/542604

Thu, Nov 7, 12:26 AM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra claimed T237556: Detect html2wt reqs issued to Parsoid/PHP with data-parsoid blobs generated by Parsoid/JS and issue a HTTP 421.
Thu, Nov 7, 12:11 AM · Parsoid-PHP
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.
  1. I noticed a few issues with bin/parse.php. Since this is a test script, these may not really be issues:
    1. The --inputfile, --domain and --apiURL options do not do much in the way of validation. It's trivial to pass garbage data to them to cause PHP warnings and exceptions.
Thu, Nov 7, 12:05 AM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Wed, Nov 6

Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

Additionally, I noticed that Phan's current config for Parsoid/PHP doesn't appear to leverage any of its bundled plugins. Some of these create a lot of noise (UnknownElementTypePlugin, NumericalComparison, WhitespacePlugin et al) but some of them are fairly useful from a security-adjacent standpoint. For example, there were a few things that caught my eye, which are probably fine, but might warrant some review:

src/Utils/TokenUtils.php:376 PhanPluginDollarDollar $$ Variables are not allowed.
src/Utils/TokenUtils.php:377 PhanPluginDollarDollar $$ Variables are not allowed.
src/Wt2Html/TT/ParserFunctions.php:116 PhanPluginAlwaysReturnMethod Method \Parsoid\Wt2Html\TT\ParserFunctions::noTrimRes has a return type of array, but may fail to return a value
tests/porting/hybrid/runDOMPass.php:411 PhanPluginDuplicateArrayKey Duplicate/Equivalent array key value('omit') detected in array - the earlier entry will be ignored.

These were found using some of the basic Phan plugins documented here. And here's a handy way to list and format some of the bundled plugins:

ls -p1 vendor/phan/phan/.phan/plugins/ |grep -Ev "(/|README)" |sed -e s/\.php// |xargs printf "\t\'%s\',\n"
Wed, Nov 6, 11:59 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T236275: Parsoid-php doesn't get updated after a code deploy.

Oh, and the above log is from the beta cluster deploy.

Wed, Nov 6, 10:37 PM · PHP 7.2 support, serviceops, Parsoid, Parsing-Team
Arlolra added a comment to T236275: Parsoid-php doesn't get updated after a code deploy.

Some notes from today's deploy.

Wed, Nov 6, 10:30 PM · PHP 7.2 support, serviceops, Parsoid, Parsing-Team
Arlolra closed T236865: Validation of `domain` failed: mwparsoid-invalid-domain as Resolved.

If that just happened once or few times on October 29th then i think that was me doing the tests

Wed, Nov 6, 10:05 PM · Parsoid-PHP
Arlolra created P9543 (An Untitled Masterwork).
Wed, Nov 6, 7:57 PM
Arlolra added a comment to T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB.

One thing to consider (maybe a separate bug needs filing) is that Parsoid/JS has been sending dsr info that has been used in browser by JS to show where errors occur in the markup. dsr info from Parsoid/PHP is using a different encoding so the offsets might not line up. We probably want to clear out old lints and then update the Linter extension to account for the difference.

Wed, Nov 6, 6:52 PM · Core Platform Team, User-WDoran, Parsoid-PHP
Arlolra added a comment to T236865: Validation of `domain` failed: mwparsoid-invalid-domain.

This one is a little more interesting,

Wed, Nov 6, 4:19 PM · Parsoid-PHP
Arlolra added a comment to T236865: Validation of `domain` failed: mwparsoid-invalid-domain.

From an example query, https://logstash.wikimedia.org/app/kibana#/dashboard/AW4Y6bumP44edBvO7lRc?_g=h@2d95062&_a=h@67f6f50

Wed, Nov 6, 4:05 PM · Parsoid-PHP

Thu, Oct 31

Arlolra added a comment to T237040: Visual editor changing automatically something in text while saving.

Might be similar to T214649

Thu, Oct 31, 8:14 PM · VisualEditor (Current work), MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Parsoid

Wed, Oct 30

Arlolra added a comment to T236275: Parsoid-php doesn't get updated after a code deploy.

Alas, we're not quite there for beta,

Wed, Oct 30, 7:59 PM · PHP 7.2 support, serviceops, Parsoid, Parsing-Team
Arlolra renamed T236930: API Developer supports different request media types from Support for other content encodings the REST API to Support for other content encodings in the REST API.
Wed, Oct 30, 5:23 PM · Story, Core Platform Team Workboards (User Stories), CPT Initiatives (Parsoid REST API in PHP (CDP2)), MediaWiki-REST-API, Parsoid-PHP
Arlolra created T236930: API Developer supports different request media types.
Wed, Oct 30, 5:22 PM · Story, Core Platform Team Workboards (User Stories), CPT Initiatives (Parsoid REST API in PHP (CDP2)), MediaWiki-REST-API, Parsoid-PHP
Arlolra added a comment to T236836: RESTBase warning missing Content-Language or Vary header in pb.body.html.headers.

I will have a look at this from RESTBase perspective tomorrow.

Wed, Oct 30, 3:39 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
Arlolra added a comment to T236836: RESTBase warning missing Content-Language or Vary header in pb.body.html.headers.

From scandium, if I curl -H "Host: en.wikipedia.org" https://parsoid-php.discovery.wmnet/w/rest.php/en.wikipedia.org/v3/page/pagebundle/User%3ABSitzmann_%28WMF%29%2FMCS%2FTest%2FFrankenstein/860183819

Wed, Oct 30, 3:35 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
Arlolra added a comment to T236836: RESTBase warning missing Content-Language or Vary header in pb.body.html.headers.

Looking at the log, there are some oddities,

Wed, Oct 30, 3:28 AM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP

Tue, Oct 29

Arlolra added a comment to T236836: RESTBase warning missing Content-Language or Vary header in pb.body.html.headers.

Hmm, this was implemented in https://github.com/wikimedia/parsoid/commit/96ae83f3806b85e42d235777cba3e21947c14406

Tue, Oct 29, 8:01 PM · Core Platform Team Workboards (Clinic Duty Team), RESTBase, Parsoid-PHP
Arlolra closed T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?, a subtask of T221738: Parsoid REST API routes in MediaWiki, as Resolved.
Tue, Oct 29, 7:56 PM · CPT Initiatives (Parsoid REST API in PHP (CDP2)), Growth-Team, StructuredDiscussions, MediaWiki-REST-API, Parsoid-PHP, Services (watching), MediaWiki-Parser
Arlolra closed T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision? as Resolved.
Tue, Oct 29, 7:56 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.
  1. I was able to get an exception in src/Utils/Util.php when testing with bin/parse.php --html2html with the following payload: <script\x20type=\"text/javascript\">javascript:alert(1);</script> (note the \x20 character): BadMethodCallException from line 61 of src/Utils/Util.php: Use lowercase tag names
Tue, Oct 29, 7:46 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Mon, Oct 28

Arlolra added a comment to T227209: Security Review For Parsoid-PHP.
  1. While testing with bin/parse.php and the --html2html and --wt2html options I found an odd notice when sending data with the <poem> tag: PHP Notice: Uninitialized string offset: 0 in src/Ext/Poem/Poem.php on line 55
Mon, Oct 28, 7:55 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T236275: Parsoid-php doesn't get updated after a code deploy.
Mon, Oct 28, 7:07 PM · PHP 7.2 support, serviceops, Parsoid, Parsing-Team
Arlolra added a comment to T236275: Parsoid-php doesn't get updated after a code deploy.

When trying to deploy to the beta cluster today, we hit,

Mon, Oct 28, 7:06 PM · PHP 7.2 support, serviceops, Parsoid, Parsing-Team

Sun, Oct 27

Arlolra added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

The language conversion code is also still being reviewed, which is necessary to call this task done.

Sun, Oct 27, 9:24 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
Arlolra closed T236435: parse.php: Initialize PageConfig properties based on title (-pageName arg OR default) as Resolved.
Sun, Oct 27, 9:20 PM · Technical-Debt, Parsoid-PHP

Thu, Oct 24

Arlolra added a comment to T236435: parse.php: Initialize PageConfig properties based on title (-pageName arg OR default).

There's a proposed solution to this in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/545391/4/src/Config/Api/PageConfig.php

Thu, Oct 24, 8:31 PM · Technical-Debt, Parsoid-PHP
Arlolra added a comment to T236382: Parsoid/PHP HTML output for PageBundle should contain Content-Language and Vary headers.

Unless the LC endpoints are done, how difficult is it to pull out the code that sets these headers into a separate patch so we can merge that and unblock Marko?

Thu, Oct 24, 5:43 PM · Patch-For-Review, RESTBase, Core Platform Team Workboards (Clinic Duty Team), Parsing-Team, Parsoid-PHP
Arlolra claimed T236382: Parsoid/PHP HTML output for PageBundle should contain Content-Language and Vary headers.

This is fixed in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/545391/3/src/PageBundle.php#77

Thu, Oct 24, 3:35 PM · Patch-For-Review, RESTBase, Core Platform Team Workboards (Clinic Duty Team), Parsing-Team, Parsoid-PHP

Tue, Oct 22

Arlolra closed T235837: Unable using visual editor in Balinese Wikipedia, a subtask of T234768: Create Balinese Wikipedia, as Resolved.
Tue, Oct 22, 5:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, User-Ladsgroup, User-Urbanecm, Wiki-Setup (Create)
Arlolra closed T235837: Unable using visual editor in Balinese Wikipedia as Resolved.

The revised plan is to deploy this tomorrow around 10 am PT.

Tue, Oct 22, 5:42 PM · Parsoid

Mon, Oct 21

Arlolra closed T235460: Parsoid/PHP does not emit ETags as Resolved.
Mon, Oct 21, 3:12 PM · CPT Initiatives (Parsoid REST API in PHP (CDP2)), Parsoid-PHP
Arlolra closed T235462: Parsoid/JS / RESTBase ETag harmonisation as Resolved.
Mon, Oct 21, 3:12 PM · Core Platform Team Workboards (Clinic Duty Team), Parsing-Team, RESTBase-API, RESTBase, Parsoid

Fri, Oct 18

Arlolra added a comment to T235709: Too many diffs on this page.

https://phabricator.wikimedia.org/P9393

Fri, Oct 18, 8:14 PM · Parsoid-PHP
Arlolra created P9393 (An Untitled Masterwork).
Fri, Oct 18, 7:41 PM

Wed, Oct 16

Arlolra added a comment to T235229: Extension:Indicator renders as a <link /> in Parsoid/PHP and a <span></span> in Parsoid/JS.

This is not because of the indicator extension but because of the maplink extension that surrounds it. This was traced to the ParserAfterParse parser hook not being invoked for the Kartographer extension.

Wed, Oct 16, 8:43 PM · Patch-For-Review, Parsoid-PHP

Oct 11 2019

Arlolra added a comment to T233736: Testing the REST API in CI.

Probably depends on T227352

Oct 11 2019, 11:32 PM · Parsoid-PHP
Arlolra triaged T231570: DomSourceRange serializes with null entries as Normal priority.
Oct 11 2019, 11:30 PM · Parsoid-PHP
Arlolra closed T234057: Get rid of hybrid testing code as Resolved.
Oct 11 2019, 11:28 PM · Parsoid-PHP
Arlolra added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

With the above patches merged, the mocha tests for this endpoint are passing. They can be run with the following,

Oct 11 2019, 11:13 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
Arlolra created T235307: Stop using the Env class outside of the Parsoid library (particularly in the extension REST handlers).
Oct 11 2019, 11:00 PM · Parsoid-PHP
Arlolra claimed T234057: Get rid of hybrid testing code.
Oct 11 2019, 9:59 PM · Parsoid-PHP
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

wonder if we should handle T234057: Get rid of hybrid testing code

Oct 11 2019, 9:56 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

npm audit and snyk found some vulnerable Node dependencies for the dev dependency nsp (oddly enough, the old package which turned into audit) and service-runner's ms dependency. As I understand it, these packages are not relevant for Parsoid/PHP. Reporting here for the sake of completeness.

Oct 11 2019, 9:52 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Oct 9 2019

Arlolra created P9290 (An Untitled Masterwork).
Oct 9 2019, 9:37 PM

Oct 1 2019

Arlolra added a comment to T233818: Call to a member function getContent() on null.

Presumably selser will not call getContent() in fallback paths ... but if so, that is one place where this edge case will pop up.

Oct 1 2019, 8:09 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a comment to T233818: Call to a member function getContent() on null.

Well, we have to be able to create a page from scratch (with no previous revision). So a zero-length string seems reasonable to me as a fallback, in both the Api config and the integrated config.

Oct 1 2019, 7:50 PM · Patch-For-Review, Parsoid-PHP

Sep 30 2019

Arlolra created T234266: Cannot read property 'stored' of undefined.
Sep 30 2019, 8:31 PM · Parsoid

Sep 26 2019

Arlolra added a comment to T233818: Call to a member function getContent() on null.

I think I just fixed this in I62868e8dc9eabea4da68a556e692f5f135924a8a

Sep 26 2019, 10:23 PM · Patch-For-Review, Parsoid-PHP

Sep 25 2019

Arlolra placed T233815: html2wt: TypeError in ConstrainedText.php up for grabs.
Sep 25 2019, 6:00 PM · Parsoid-PHP
Arlolra claimed T233815: html2wt: TypeError in ConstrainedText.php.
Sep 25 2019, 5:29 PM · Parsoid-PHP
Arlolra closed T233819: array_merge(): Argument #2 is not an array as Resolved.
Sep 25 2019, 5:28 PM · Parsoid-PHP
Arlolra claimed T233819: array_merge(): Argument #2 is not an array.
Sep 25 2019, 5:08 PM · Parsoid-PHP

Sep 24 2019

Arlolra added a subtask for T228217: Ensure all the features of parse.js are covered by parse.php: T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess.
Sep 24 2019, 4:38 PM · Patch-For-Review, Parsoid-PHP
Arlolra added a parent task for T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess: T228217: Ensure all the features of parse.js are covered by parse.php.
Sep 24 2019, 4:38 PM · Parsoid-PHP
Arlolra created T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess.
Sep 24 2019, 4:37 PM · Parsoid-PHP
Arlolra created T233736: Testing the REST API in CI.
Sep 24 2019, 4:34 PM · Parsoid-PHP

Sep 23 2019

Arlolra claimed T233459: Undefined property: stdClass::$src in TokenUtils.php::tokensToString.
Sep 23 2019, 10:10 PM · Parsoid-PHP
Arlolra renamed T233459: Undefined property: stdClass::$src in TokenUtils.php::tokensToString from Undefined $src in TokenUtils.php::tokensToString to Undefined property: stdClass::$src in TokenUtils.php::tokensToString.
Sep 23 2019, 10:03 PM · Parsoid-PHP

Sep 17 2019

Arlolra added a comment to T233062: Tag new release of remex-html.

I think we're just waiting for https://gerrit.wikimedia.org/r/c/mediawiki/libs/RemexHtml/+/535291 to get in as well.

Sep 17 2019, 12:54 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, RemexHtml

Sep 12 2019

Arlolra added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

Env, for one, is specifically not intended for use outside of Parsoid.

Sep 12 2019, 7:54 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

Should I rebase the security branch with latest changes to master?

Sep 12 2019, 3:42 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Aug 29 2019

Arlolra closed T231592: Parsoid/PHP parser tests run takes 2.5x as long as Parsoid/JS parser tests run as Invalid.

On my laptop

Aug 29 2019, 9:48 PM · Parsoid-PHP, Performance Issue
Arlolra created T231570: DomSourceRange serializes with null entries.
Aug 29 2019, 3:40 PM · Parsoid-PHP

Aug 28 2019

Arlolra added a comment to T230666: git grep strtolower/strtoupper and see which one of them need to be mb_strtolower/mb_strtoupper.

Note function names are case insensitive for when you're grepping.

Aug 28 2019, 8:55 PM · Parsoid-PHP

Aug 19 2019

Arlolra updated the task description for T227209: Security Review For Parsoid-PHP.
Aug 19 2019, 8:45 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews
Arlolra added a comment to T227209: Security Review For Parsoid-PHP.

For development and debugging purposes, Parsoid also supports accessing an external MediaWiki installation via its action API. Parsoid/JS doesn't require that external wiki to have installed the ParsoidBatchAPI extension, but Parsoid/PHP depends on that currently (* TODO: Verify *).

Aug 19 2019, 8:44 PM · Patch-For-Review, Restricted Project, Parsoid-PHP, Security-Team-Reviews

Aug 17 2019

ToBeFree awarded T118517: [RFC] Use <figure> for media a Like token.
Aug 17 2019, 11:23 PM · TechCom-RFC (TechCom-Approved), Accessibility, Parsing-Team, Wikipedia-Android-App-Backlog, MediaWiki-Parser

Aug 13 2019

Dalba awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Dislike token.
Aug 13 2019, 11:33 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Aug 8 2019

Arlolra created P8890 (An Untitled Masterwork).
Aug 8 2019, 10:20 PM
Arlolra created P8889 (An Untitled Masterwork).
Aug 8 2019, 10:09 PM

Aug 5 2019

Arlolra closed T229531: Ensure change from git a0a27f5 is applied to extension/src/Config/SiteConfig as well as Resolved.

The extension implementation is as follow,

Aug 5 2019, 11:16 PM · Parsoid-PHP
Arlolra added a comment to T200678: (OoW) wtp2011 memory correctable errors.

After the upgrade, I confirmed the host was still running the currently deployed version,

Aug 5 2019, 10:15 PM · Operations, ops-codfw
Arlolra added a comment to T200678: (OoW) wtp2011 memory correctable errors.

I ran, SSH_AUTH_SOCK=/run/keyholder/proxy.sock ssh -l deploy-service wtp2011 'depool service=parsoid' from deployment.eqiad.wmnet and it's now showing {"wtp2011.codfw.wmnet": {"weight": 10, "pooled": "no"}, "tags": "dc=codfw,cluster=parsoid,service=parsoid"}

Aug 5 2019, 9:34 PM · Operations, ops-codfw
Arlolra closed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint, a subtask of T229356: Run roundtrip tests with Parsoid/PHP on scandium, as Resolved.
Aug 5 2019, 8:11 PM · Parsoid-PHP
Arlolra closed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint as Resolved.
Aug 5 2019, 8:11 PM · Parsoid-PHP

Aug 3 2019

Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

With that ^ the rt test script at least runs

Aug 3 2019, 2:36 PM · Parsoid-PHP

Aug 2 2019

Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

A quick test with, node bin/roundtrip-test.js --domain ve --parsoidURL http://localhost/rest.php "Main Page", is returning,

Aug 2 2019, 9:43 PM · Parsoid-PHP

Jul 31 2019

Arlolra added a comment to T226523: Template in wikilink target position also returns pipe separated params.

I don't think the last fix deployment has fixed anything regarding that ticket. The Parsoid output is still broken so far I can see.

Jul 31 2019, 4:39 PM · Patch-For-Review, Mobile-Content-Service, Parsoid, Product-Infrastructure-Team-Backlog
Arlolra added a comment to T229375: TypeError in references endpoint.

In the meantime, here's an edit that fixes it,
https://en.wikipedia.org/w/index.php?title=Maine&type=revision&diff=908732865&oldid=908276611&diffmode=source

Jul 31 2019, 4:34 PM · Parsoid, Page Content Service, Product-Infrastructure-Team-Backlog
Arlolra added a comment to T229375: TypeError in references endpoint.

The content seems to contain {{#tag:ref|Maine does not ... <references group="nb" /> |group="nb"}}, which results in references in references.

Jul 31 2019, 4:25 PM · Parsoid, Page Content Service, Product-Infrastructure-Team-Backlog

Jul 30 2019

Arlolra claimed T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.
Jul 30 2019, 4:48 PM · Parsoid-PHP
Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

How do we pass in the rt testing flag to Parsoid?

Jul 30 2019, 4:34 PM · Parsoid-PHP
Arlolra added a comment to T229348: Test roundtrip-test.js locally and verify it works with a Parsoid/PHP endpoint.

The parsoid config is only used to get prefixes, which isn't really needed.

Jul 30 2019, 4:07 PM · Parsoid-PHP

Jul 26 2019

Jdforrester-WMF awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Like token.
Jul 26 2019, 5:43 PM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016
Ladsgroup awarded T114432: [RFC] Heredoc arguments for templates (aka "hygienic" or "long" arguments) a Love token.
Jul 26 2019, 11:18 AM · TechCom-RFC (TechCom-Approved), Patch-For-Review, Parsing-Team, Wikimedia-Developer-Summit-2016

Jul 24 2019

Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 24 2019, 8:26 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 24 2019, 7:41 PM · Patch-For-Review, Parsoid-PHP

Jul 23 2019

Arlolra added a comment to T228217: Ensure all the features of parse.js are covered by parse.php.

There should probably be better test coverage of this bin or at least fixing this,
https://github.com/wikimedia/parsoid/blob/master/bin/toolcheck.sh#L19-L21

Jul 23 2019, 10:34 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 10:32 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 9:28 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 9:27 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 6:16 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 5:45 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 4:19 PM · Patch-For-Review, Parsoid-PHP
Arlolra updated the task description for T228217: Ensure all the features of parse.js are covered by parse.php.
Jul 23 2019, 4:18 PM · Patch-For-Review, Parsoid-PHP