Arlolra (Arlo Breault)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 6 2014, 10:34 PM (227 w, 5 d)
Availability
Available
IRC Nick
arlolra
LDAP User
Arlolra
MediaWiki User
Arlolra [ Global Accounts ]

Recent Activity

Fri, Feb 15

Arlolra added a comment to T216289: Parsoid is incompatible with node v11.

I think you're confused between the test failure and the blacklist change.

Fri, Feb 15, 11:17 PM · Parsoid
Arlolra added a comment to T216289: Parsoid is incompatible with node v11.

From https://github.com/wikimedia/parsoid/commit/05f0f9b92314f64e567ef2fd4a04b4c9e8ee4692 when it was ignored in CI,

Fri, Feb 15, 10:47 PM · Parsoid
Arlolra added a comment to T179082: Use one ownerDocument for the entire parse.

That's from T204608

Fri, Feb 15, 5:00 PM · Parsoid
Arlolra added a comment to T179082: Use one ownerDocument for the entire parse.

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/490654 identifies where all the docs are currently created.

Fri, Feb 15, 4:59 PM · Parsoid
Arlolra added a comment to T216203: RESTBase content-negotiation tests are broken.

Tests for content-negotiation rely on Parsoid being able to produce 2 different major content versions. Since a change in Parsoid 1.x content version is not supported anymore.

Fri, Feb 15, 4:57 PM · RESTBase, Parsoid, Services (later)

Tue, Feb 12

Arlolra closed T215824: AddMediaInfo pass isn't robust to link-in-link as Resolved.
Tue, Feb 12, 12:22 AM · Patch-For-Review, Parsoid

Mon, Feb 11

Arlolra triaged T215824: AddMediaInfo pass isn't robust to link-in-link as Normal priority.
Mon, Feb 11, 10:42 PM · Patch-For-Review, Parsoid
Arlolra closed T213468: Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded as Resolved.

https://en.wikipedia.org/api/rest_v1/page/html/User:ESanders_(WMF)%2Fsandbox/877762681 now has,

Mon, Feb 11, 9:57 PM · Patch-For-Review, Parsoid
Arlolra updated the task description for T215824: AddMediaInfo pass isn't robust to link-in-link.
Mon, Feb 11, 6:23 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T215824: AddMediaInfo pass isn't robust to link-in-link.

http://localhost:8000/nl.wikipedia.org/v3/page/html/De_Meern/53147456 give this example,

Mon, Feb 11, 6:23 PM · Patch-For-Review, Parsoid
Arlolra created T215824: AddMediaInfo pass isn't robust to link-in-link.
Mon, Feb 11, 5:33 PM · Patch-For-Review, Parsoid

Fri, Feb 8

Arlolra closed T215638: List tokens use special-cased "bullets" property instead of stuffing it in attribs like other tokens as Resolved.
Fri, Feb 8, 11:32 PM · Patch-For-Review, Parsoid-PHP

Thu, Feb 7

Arlolra added a comment to T215537: Investigate 500s from batch request failures.

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2019.02.07/parsoid?id=AWjIsGyznlBds_JjA_-S&_g=h@44136fa
http://localhost:8000/fr.wikipedia.org/v3/page/html/Utilisateur%3AChico75%2Fpages_avec_pourcent/156246032

Thu, Feb 7, 5:51 PM · Patch-For-Review, Parsoid
Arlolra added a subtask for T215537: Investigate 500s from batch request failures: T215110: ParsoidBatchAPI timeout on frwikisource due to Score extension.
Thu, Feb 7, 5:30 PM · Patch-For-Review, Parsoid
Arlolra added a parent task for T215110: ParsoidBatchAPI timeout on frwikisource due to Score extension: T215537: Investigate 500s from batch request failures.
Thu, Feb 7, 5:30 PM · Parsoid, MediaWiki-extensions-Score
Arlolra created T215537: Investigate 500s from batch request failures.
Thu, Feb 7, 5:30 PM · Patch-For-Review, Parsoid
Arlolra closed T180995: Batch API request error as Resolved.

No longer seems to be an issue with http://localhost:8000/sr.wikisource.org/v3/page/html/%D0%9A%D0%BE%D1%81%D0%BE%D0%B2%D1%81%D0%BA%D0%B8_%D0%B1%D0%BE%D1%98_(%D1%80%D1%83%D0%BA%D0%BE%D0%BF%D0%B8%D1%81)/60110

Thu, Feb 7, 5:22 PM · Parsoid-Read-Views

Wed, Feb 6

Arlolra added a comment to T215474: Simplify isSolTransparent / isRenderingTransparentNode predicates.

See the review at https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/488100/6//COMMIT_MSG

Wed, Feb 6, 11:31 PM · Technical-Debt, Parsoid
Arlolra added a comment to T214241: data-mw info is clobbered by template annotations.

Note that this also happens when unpacking dom fragments,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/pp/handlers/unpackDOMFragments.js#L200-L204

Wed, Feb 6, 10:59 PM · Parsoid
Arlolra closed T169975: Missing images render as broken img tags, not redlinks, a subtask of T39902: RFC: Implement rendering of redlinks in Parsoid HTML as post-processor, as Resolved.
Wed, Feb 6, 6:28 PM · TechCom-RFC (TechCom-Approved), Services (blocked), User-mobrovac, Parsing-Team, Parsoid
Arlolra closed T169975: Missing images render as broken img tags, not redlinks as Resolved.
Wed, Feb 6, 6:28 PM · Patch-For-Review, Parsoid-Read-Views

Fri, Feb 1

Arlolra closed T153080: Parse images synchronously without making imageinfo requests and use a final postprocessing pass to fixup image HTML as Resolved.
Fri, Feb 1, 11:26 PM · Patch-For-Review, Parsoid-PHP

Thu, Jan 31

Arlolra added a comment to T208901: TemplateStyles breaks a paragraph if a file is inserted inline.

@ssastry Parsoid needs an equivalent patch that removes,
https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/pp/processors/PWrap.js#L35-L36

Thu, Jan 31, 12:09 AM · Patch-For-Review, Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Parsoid, TemplateStyles, MediaWiki-Parser

Wed, Jan 30

Arlolra created T214994: PP passes that run `atTopLevel` omit HTML stashed in data-mw.
Wed, Jan 30, 10:47 PM · Parsoid

Fri, Jan 25

Arlolra created T214725: transformTests CI script isn't aborting on failure.
Fri, Jan 25, 8:42 PM · Parsoid
Arlolra placed T207279: Redlinks DOM pass adds mw api + network latency to parse time up for grabs.
Fri, Jan 25, 5:21 PM · Parsoid
Arlolra placed T179605: LintError bogus-image-options triggers on "Thumbtime" up for grabs.
Fri, Jan 25, 5:20 PM · Parsoid-Linter, MediaWiki-extensions-Linter

Thu, Jan 24

Arlolra updated the task description for T214648: DOMDiff'ing doesn't traverse into galleries.
Thu, Jan 24, 11:04 PM · Patch-For-Review, Parsoid
Arlolra updated the task description for T214649: VE's gallery representation differs enough so that selser is never applied?.
Thu, Jan 24, 11:02 PM · Patch-For-Review, VisualEditor, Parsoid
Arlolra merged task T211246: Diffs to be investigated into T214649: VE's gallery representation differs enough so that selser is never applied?.
Thu, Jan 24, 10:55 PM · Parsoid-Serializer, Parsoid
Arlolra merged T211246: Diffs to be investigated into T214649: VE's gallery representation differs enough so that selser is never applied?.
Thu, Jan 24, 10:55 PM · Patch-For-Review, VisualEditor, Parsoid
Arlolra added a subtask for T214651: The extension api seems to want a dom-diff-handler: T214648: DOMDiff'ing doesn't traverse into galleries.
Thu, Jan 24, 10:33 PM · Parsoid
Arlolra added a parent task for T214648: DOMDiff'ing doesn't traverse into galleries: T214651: The extension api seems to want a dom-diff-handler.
Thu, Jan 24, 10:33 PM · Patch-For-Review, Parsoid
Arlolra created T214651: The extension api seems to want a dom-diff-handler.
Thu, Jan 24, 10:33 PM · Parsoid
Arlolra updated the task description for T214648: DOMDiff'ing doesn't traverse into galleries.
Thu, Jan 24, 10:23 PM · Patch-For-Review, Parsoid
Arlolra created T214649: VE's gallery representation differs enough so that selser is never applied?.
Thu, Jan 24, 10:23 PM · Patch-For-Review, VisualEditor, Parsoid
Arlolra created T214648: DOMDiff'ing doesn't traverse into galleries.
Thu, Jan 24, 10:14 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T211246: Diffs to be investigated.

These are going to be exacerbated now that "extsrc" is gone,
https://en.wikipedia.org/w/index.php?title=Kashubian_language&curid=17254&diff=880004780&oldid=879154010&diffmode=source

Thu, Jan 24, 7:12 PM · Parsoid-Serializer, Parsoid
Arlolra added a comment to T211895: VE shouldn't add the File: prefix when missing in a gallery.

Here's a list of pages with gallery normalizations to explore,
https://phabricator.wikimedia.org/P8032

Thu, Jan 24, 5:58 PM · Parsoid, VisualEditor
Arlolra created P8032 (An Untitled Masterwork).
Thu, Jan 24, 5:56 PM
Arlolra added a comment to T214601: Gallery media is erroneously using sub-typeof if format is supplied.

In "plwiki/Leonardo da Vinci", the dimensions gets applied, which is similar,

Thu, Jan 24, 4:59 PM · Parsoid
Arlolra created T214603: "thumbtime" is lost when roundtripping in gallery.
Thu, Jan 24, 4:57 PM · Parsoid
Arlolra added a comment to T214601: Gallery media is erroneously using sub-typeof if format is supplied.

Roundtripping the bogus option would be part of T211895 / T151367

Thu, Jan 24, 4:56 PM · Parsoid
Arlolra created T214601: Gallery media is erroneously using sub-typeof if format is supplied.
Thu, Jan 24, 4:51 PM · Parsoid
Arlolra added a comment to T106431: Audit SOL state of subpipelines.

The current values were made explicit in,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/482761

Thu, Jan 24, 2:06 AM · Parsoid-Read-Views, Parsoid-Tokenizer

Wed, Jan 23

Arlolra closed T214443: Packed gallery mode has no tests as Resolved.
Wed, Jan 23, 6:52 PM · Patch-For-Review, Parsoid
Arlolra closed T187958: Parsoid and PHP parser parse <gallery caption="…"> differently as Resolved.
Wed, Jan 23, 6:51 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Parsoid-Read-Views, Patch-For-Review, MediaWiki-Parser
Arlolra placed T207956: Token stream patcher table start retokenizing doesn't handle non-string tokens in table attribute position up for grabs.
Wed, Jan 23, 4:53 PM · Parsoid
Arlolra placed T210647: Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code up for grabs.
Wed, Jan 23, 4:52 PM · Parsoid-Read-Views
Arlolra placed T186278: Attributes that expand to block? elements fail to roundtrip up for grabs.
Wed, Jan 23, 4:50 PM · Parsoid
Arlolra placed T126834: Table end tag following nl emitting template in attribute position up for grabs.
Wed, Jan 23, 4:50 PM · Parsoid-DOM, Parsoid

Tue, Jan 22

Arlolra triaged T214443: Packed gallery mode has no tests as Normal priority.
Tue, Jan 22, 10:29 PM · Patch-For-Review, Parsoid
Arlolra created T214443: Packed gallery mode has no tests.
Tue, Jan 22, 10:29 PM · Patch-For-Review, Parsoid
Arlolra removed a project from T126834: Table end tag following nl emitting template in attribute position: Patch-For-Review.
Tue, Jan 22, 7:53 PM · Parsoid-DOM, Parsoid
Arlolra renamed T126834: Table end tag following nl emitting template in attribute position from Multi-transclusion template ending in `|}` breaks whole page rendering (presumably end of table is ignored as not in single line context?) to Table end tag following nl emitting template in attribute position.
Tue, Jan 22, 7:52 PM · Parsoid-DOM, Parsoid

Sat, Jan 19

Arlolra created T214241: data-mw info is clobbered by template annotations.
Sat, Jan 19, 4:48 PM · Parsoid

Jan 17 2019

Arlolra added a comment to T213900: Leaving out 'prefix' option breaks Visual Editor when Collection extension is installed.

I must say I have no idea how they are even related.

Jan 17 2019, 10:20 PM · Collection, Parsoid, VisualEditor
Arlolra created T214099: Stress test Parsoid's HTTP API.
Jan 17 2019, 9:57 PM · Services (watching), Parsoid-Web-API, Parsoid

Jan 16 2019

Arlolra triaged T213950: Links: External links with special characters, and surrounded by square brakets, are not rendered properly as Normal priority.
Jan 16 2019, 6:22 PM · Parsoid-Edit-Support, VisualEditor-MediaWiki-Links, VisualEditor
Arlolra added a comment to T213950: Links: External links with special characters, and surrounded by square brakets, are not rendered properly.

Parsoid has some code to cover this case https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/tt/WikiLinkHandler.js#L312-L331
but it probably never reaches it because it bails early on the percent encode chars https://github.com/wikimedia/parsoid/blob/master/lib/wt2html/tt/WikiLinkHandler.js#L296-L298

Jan 16 2019, 6:22 PM · Parsoid-Edit-Support, VisualEditor-MediaWiki-Links, VisualEditor

Jan 9 2019

Arlolra added a comment to T213345: RFC: Spin off (Parsoid) language variants functionality as a Node.js microservice?.

Needs evaluation with respect to T208524

Jan 9 2019, 10:08 PM · TechCom-RFC, serviceops, User-mobrovac, Core Platform Team Backlog (Designing), Services (designing), MediaWiki-Language-converter, Parsoid, Language-Team, Parsing-Team

Dec 20 2018

Arlolra added a project to T208070: Parse requests return gratuitous newlines: MediaWiki-Parser.
Dec 20 2018, 12:56 AM · Patch-For-Review, MediaWiki-Parser, Parsoid

Dec 18 2018

Arlolra triaged T212184: Shadow metas shouldn't clone dataAttribs as Normal priority.
Dec 18 2018, 2:34 AM · Patch-For-Review, Parsoid
Arlolra created T212184: Shadow metas shouldn't clone dataAttribs.
Dec 18 2018, 2:34 AM · Patch-For-Review, Parsoid
Arlolra closed T209772: visitDOM makes an invalid assumption about its handlers as Invalid.

For this helper to work the way you want, you'd either need to bind the handler before passing it in or pass in a context to apply to. The execution context of a reassigned method just isn't what this task implies it should be.

Dec 18 2018, 1:39 AM · Patch-For-Review, Parsoid

Dec 17 2018

Arlolra closed T211738: Clarify "mw:ExpandedAttr" annotation as Resolved.

Some spec changes in this diff,
https://www.mediawiki.org/w/index.php?title=Specs/HTML/2.0.0&type=revision&diff=3013988&oldid=2949580&diffmode=source

Dec 17 2018, 10:29 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T211246: Diffs to be investigated.

https://en.wikipedia.org/w/index.php?title=Caterpillar_D9&curid=289912&diff=874218659&oldid=872850603&diffmode=source
https://en.wikipedia.org/w/index.php?title=Venn_diagram&curid=61701&diff=874218778&oldid=874085957&diffmode=source

Dec 17 2018, 9:51 PM · Parsoid-Serializer, Parsoid
Arlolra triaged T208070: Parse requests return gratuitous newlines as Normal priority.
Dec 17 2018, 8:52 PM · Patch-For-Review, MediaWiki-Parser, Parsoid

Dec 14 2018

Arlolra closed T211941: node.getAttribute is not a function as Resolved.
Dec 14 2018, 9:26 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T211895: VE shouldn't add the File: prefix when missing in a gallery.

and remove the wikitext body

Dec 14 2018, 4:32 PM · Parsoid, VisualEditor

Dec 13 2018

Arlolra claimed T211941: node.getAttribute is not a function.

Starting from https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/476979

Dec 13 2018, 11:28 PM · Patch-For-Review, Parsoid
Arlolra created T211941: node.getAttribute is not a function.
Dec 13 2018, 11:17 PM · Patch-For-Review, Parsoid
Arlolra added a comment to T211895: VE shouldn't add the File: prefix when missing in a gallery.

I guess it was premature to close T151367 :(

Dec 13 2018, 9:15 PM · Parsoid, VisualEditor
Arlolra created T211909: Cannot read property '0' of undefined.
Dec 13 2018, 6:22 PM · Parsoid
Arlolra added a comment to T211738: Clarify "mw:ExpandedAttr" annotation.

The spec only says transclusion (but should be edited) ...

Dec 13 2018, 3:37 AM · Patch-For-Review, Parsoid

Dec 12 2018

Arlolra lowered the priority of T211816: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) from Normal to Low.

I think we can and should break compatibility in these cases.

Dec 12 2018, 9:52 PM · Parsoid, MediaWiki-Parser
Arlolra triaged T211816: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) as Normal priority.

The result is identical in the PHP parser as well as Parsoid (probably since rGPAR00ac33236f2a: Match broken attribute parsing with the php parser).

Dec 12 2018, 9:48 PM · Parsoid, MediaWiki-Parser

Dec 11 2018

Arlolra claimed T211738: Clarify "mw:ExpandedAttr" annotation.
Dec 11 2018, 11:01 PM · Patch-For-Review, Parsoid
Arlolra created T211738: Clarify "mw:ExpandedAttr" annotation.
Dec 11 2018, 11:00 PM · Patch-For-Review, Parsoid

Dec 10 2018

Arlolra added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

$wgULSLanguageDetection = false;

Dec 10 2018, 11:38 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team
Arlolra added a comment to T204566: cloudvps: wikitextexp project trusty deprecation.

Something that is missing that I noticed right away is that the skins aren't localized on these new vms .. http://de-expt-wikitextexp.wmflabs.org/wiki/Main_Page vs http://de.expt.wikitextexp.wmflabs.org/wiki/Main_Page ... but, this may just be a matter of tweaking some mediawiki config (unless I am missing some vagrant role). @Arlolra fyi in case you know what this is since I remember you messed with this on the old vms.

Dec 10 2018, 11:33 PM · Cloud-VPS (Ubuntu Trusty Deprecation), Parsing-Team

Dec 7 2018

Arlolra added a comment to T49963: Block content in links..

And more likely hasBadNesting and T165098

Dec 7 2018, 11:50 PM · Parsoid-Robustness, Parsoid, Parsoid-DOM
Arlolra added a comment to T49963: Block content in links..

See PipelineUtils.getWrapperTokens

Dec 7 2018, 11:13 PM · Parsoid-Robustness, Parsoid, Parsoid-DOM
Arlolra added a comment to T211246: Diffs to be investigated.

This just seemed odd ... why are ref names unquoted?

Dec 7 2018, 12:24 AM · Parsoid-Serializer, Parsoid

Dec 5 2018

Arlolra added a project to T211251: Cannot read property 'nodeName' of undefined: Parsoid.
Dec 5 2018, 10:22 PM · Parsoid
Arlolra created T211251: Cannot read property 'nodeName' of undefined.
Dec 5 2018, 10:22 PM · Parsoid
Arlolra added a comment to T211246: Diffs to be investigated.

This one is just dirty ... why are gallery attributes being normalized?

Dec 5 2018, 10:05 PM · Parsoid-Serializer, Parsoid
Arlolra created T211246: Diffs to be investigated.
Dec 5 2018, 9:50 PM · Parsoid-Serializer, Parsoid
Arlolra closed T210550: "Empty JSON response" from ParsoidBatchAPI when content includes <mapframe> as Resolved.
Dec 5 2018, 8:12 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, Maps (Kartographer), Parsoid

Dec 4 2018

Arlolra removed a project from T210647: Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code: Patch-For-Review.
Dec 4 2018, 10:20 PM · Parsoid-Read-Views
Arlolra assigned T211074: Support BCP 47 codes in Parsoid to cscott.

See the blacklisted test in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/477421

Dec 4 2018, 1:31 AM · Parsoid
Arlolra created T211074: Support BCP 47 codes in Parsoid.
Dec 4 2018, 1:30 AM · Parsoid

Nov 30 2018

Arlolra added a comment to T110986: Parsoid eats paragraph breaks in lists and other single-line constructs - consider inserting <br><br> instead.

A good place to start is,
https://www.mediawiki.org/wiki/How_to_contribute

Nov 30 2018, 12:12 AM · Parsoid
Arlolra removed a project from T206222: Make "about" attribute IDs deterministic: Patch-For-Review.
Nov 30 2018, 12:05 AM · Parsoid

Nov 29 2018

Arlolra added a comment to T194083: Found nested inserted dom-diff flags!.

Looking at the histogram in logstash, these coincide with yesterday's deploy.

Nov 29 2018, 6:58 PM · Patch-For-Review, Parsoid
Arlolra reopened T194083: Found nested inserted dom-diff flags! as "Open".

Seeing some more of these.

Nov 29 2018, 6:56 PM · Patch-For-Review, Parsoid
Arlolra closed T210727: Make Parsoid ready for Nodejs 8.x as Resolved.
Nov 29 2018, 6:42 PM · Parsoid
Arlolra added a comment to T210727: Make Parsoid ready for Nodejs 8.x.

Parsoid has tested against v8.x in CI since Sept. 2017,
https://github.com/wikimedia/parsoid/commit/fd4dc9322420701c631b5b18a05755a99d5931de

Nov 29 2018, 3:26 PM · Parsoid

Nov 28 2018

Arlolra added a comment to T209236: "&params" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms).

After that deploy, Parsoid now gets this right too https://www.mediawiki.org/api/rest_v1/page/html/User:Arlolra%2Fsandbox/2986673

Nov 28 2018, 9:36 PM · MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), Patch-For-Review, Regression, MediaWiki-Parser
Arlolra claimed T210647: Paragraph wrapper introduces <p></p> in output HTML -- investigate and kill them where they are a result of edge case diffs between PHP parser and Parsoid code.
Nov 28 2018, 7:54 PM · Parsoid-Read-Views