Page MenuHomePhabricator

AronManning (Demian)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Sep 12 2019, 6:40 PM (18 w, 5 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Aron Manning [ Global Accounts ]

Recent Activity

Today

AronManning added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I think the greatest risk to Vue, is that Vue Technology, LLC goes out of business and the foundation is forced to either start investing heavily in its maintenance or migrating to a different framework. If we want to take on that risk, that is totally fine, but can we call a spade a spade and acknowledge the business risk associated with choosing Vue?
In a lot of ways, this reminds me of how WordPress and Drupal chose jQuery, and Joomla! chose MooTools. I have no idea which one is technically superior, but I don't want to be the Joomla of this story. Of course, none of us know the future, but if we're going to walk into this, I hope we can with our eyes wide open.

Wed, Jan 22, 7:05 AM · Security-Team, TechCom-RFC
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

Mock:

Wed, Jan 22, 1:35 AM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning updated the task description for T243268: Choose expressive icons for the header buttons.
Wed, Jan 22, 12:43 AM · Design, Desktop Improvements
AronManning updated the task description for T243268: Choose expressive icons for the header buttons.
Wed, Jan 22, 12:39 AM · Design, Desktop Improvements
AronManning updated the task description for T243268: Choose expressive icons for the header buttons.
Wed, Jan 22, 12:33 AM · Design, Desktop Improvements
AronManning updated the task description for T243268: Choose expressive icons for the header buttons.
Wed, Jan 22, 12:33 AM · Design, Desktop Improvements
AronManning updated the task description for T243268: Choose expressive icons for the header buttons.
Wed, Jan 22, 12:31 AM · Design, Desktop Improvements

Yesterday

AronManning updated the task description for T243268: Choose expressive icons for the header buttons.
Tue, Jan 21, 10:51 PM · Design, Desktop Improvements
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

After thinking about it more, I think that this mockup is the direction that we should go in. My thinking is that (ideally) a user needs to read the message before they start writing a response because if they do choose to log in, they will most likely lose their reply.

That's good reasoning that I've thought about too. For me, the warning is just as noticeable below the editbox, but you're right it's timing is more appropriate before writing the message.
Both positions are reasonable and my primary concern is to occupy less space with it. If you would minimize the huge vertical padding and lower the horizontal padding to 1em, it would be less in the way to see the original comment. On a wider screen than the screenshot, it would fit into one line, further reducing the impact.

Tue, Jan 21, 10:37 PM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning added a comment to T26070: Provide a dark skin (CSS).

There's an experimental dark theme overlay for those interested: https://www.mediawiki.org/wiki/User:Aron_Manning/Skin_themes
Supports Timeless and Vector skins as of January 2020, Minerva and the 2 oldtimers in the future.

Tue, Jan 21, 10:07 PM · MediaWiki-Interface
AronManning added a comment to T243268: Choose expressive icons for the header buttons.

Removed the bar

Tue, Jan 21, 9:52 AM · Design, Desktop Improvements
AronManning renamed T243268: Choose expressive icons for the header buttons from Choose expressive icons for the headerbar buttons to Choose expressive icons for the header buttons.
Tue, Jan 21, 9:52 AM · Design, Desktop Improvements
AronManning added a project to T243268: Choose expressive icons for the header buttons: Desktop Improvements.
Tue, Jan 21, 9:35 AM · Design, Desktop Improvements
AronManning added a subtask for T240856: [EPIC] New header for desktop improvements project: T243268: Choose expressive icons for the header buttons.
Tue, Jan 21, 9:34 AM · Performance-Team (Radar), Desktop Improvements, Epic
AronManning added a parent task for T243268: Choose expressive icons for the header buttons: T240856: [EPIC] New header for desktop improvements project.
Tue, Jan 21, 9:34 AM · Design, Desktop Improvements
AronManning created T243268: Choose expressive icons for the header buttons.
Tue, Jan 21, 9:32 AM · Design, Desktop Improvements
AronManning awarded T117279: [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remove MobileDiff) a Like token.
Tue, Jan 21, 6:01 AM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), User-Jdlrobson, Desktop Improvements, TechCom, MobileFrontend (MobileFrontend Special Pages), Multi-Content-Revisions, Readers-Web-Backlog (Tracking), Technical-Debt (RW-Tech-Debt)

Mon, Jan 20

AronManning added a comment to T171701: Use better site navigation on large screens for Minerva.

+1 to a center aligned logo!!

That's a nice idea! When the article scrolls down, the article title could be shown there too.

Mon, Jan 20, 10:21 PM · Desktop Improvements, Readers-Web-Backlog (Kanbanana-2019-20-Q2), Design (RW-Design-Debt), MinervaNeue (Desktop)
AronManning awarded T240608: Standardise a control for switching diff types from side by side to inline/visual a Like token.
Mon, Jan 20, 6:59 PM · Patch-For-Review, VisualEditor, Readers-Web-Backlog (Design), User-Jdlrobson, Core Platform Team Workboards (Clinic Duty Team), Desktop Improvements, Multi-Content-Revisions, Technical-Debt (RW-Tech-Debt)
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

Please explore the idea of moving the warning directly above or below the buttons, reduce the vertical padding to about 2px and the horizontal to 1em. As it stands now it takes up significant, valuable screen space and turns it into empty space between the editors and the responded comment that we wanted to keep close together. I'm sorry to repeat my previous comment, it might have been missed.

Mon, Jan 20, 5:39 PM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning added a comment to T237052: Why are there 2 search bars on Special:Search ?.

"Other sites:"

Mon, Jan 20, 6:06 AM · Desktop Improvements, TCB-Team, Advanced-Search, Readers-Web-Backlog (Design)
AronManning added a comment to T26070: Provide a dark skin (CSS).

Updated link: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)/Archive_131#Dark_colour_schemes_and_the_interface_between_the_system,_browser_and_Wikipedia

Mon, Jan 20, 1:13 AM · MediaWiki-Interface
AronManning added a comment to T26070: Provide a dark skin (CSS).
Mon, Jan 20, 1:12 AM · MediaWiki-Interface
AronManning updated AronManning.
Mon, Jan 20, 1:02 AM
AronManning updated AronManning.
Mon, Jan 20, 1:02 AM
AronManning updated AronManning.
Mon, Jan 20, 1:01 AM
AronManning added a watcher for MediaViewer: AronManning.
Mon, Jan 20, 12:59 AM
AronManning added a watcher for Vector: AronManning.
Mon, Jan 20, 12:57 AM
AronManning added a watcher for Desktop Improvements: AronManning.
Mon, Jan 20, 12:50 AM

Sat, Jan 18

AronManning added a comment to T234907: RFC: Where to implement Desktop Improvements project.

This RfC might have been closed and I've had missed it, however, I haven't found a follow-up discussion, therefore I hope this comment is fine here.

Sat, Jan 18, 11:06 PM · TechCom-RFC (TechCom-Approved), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

I endorse @ppelberg's answers to these questions.

  1. Where should the IP warning be displayed?
    • I'm not sure. Is there a best practice here in OOUI?
  • I think the warning is the best placed between the preview and the submit-cancel buttons. Possibly on one line, if there is no legal disclaimer (about freely licenseing the contribution). In that place it will be immediately visible when the reply editor opens and still visible before the final decision to submit the comment.
    • Thinking: When I finish writing a comment, I move on to the preview (below) to check the formatting, then move further below to click Submit. Before I make that decision (after which there's no revert), it's best that I'm reminded if I have forgotten to log in and I'm about to disclose my IP.
Sat, Jan 18, 5:16 PM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

How do you tell an IP to comment here? That is the advice given on the Help Desk.

By making an account. No IP editing on phabricator. If this is related to the scroll-up bug after viewing and closing an image, then you could link to the Help Desk request, or tell them the fix is under review, which might take weeks.
If the request is from a MediaWiki operator in dire need of a fix, with the necessary technical skills, they can check out the fix into a folder with:

mkdir MultimediaViewer && cd MultimediaViewer
git clone "https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer" .
git fetch "https://gerrit.wikimedia.org/r/mediawiki/extensions/MultimediaViewer" refs/changes/76/560576/14 && git checkout FETCH_HEAD

and use that folder as the htdocs/w/extensions/MultimediaViewer folder by symlinking it or replacing it. At their own risk only.

Sat, Jan 18, 12:29 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Fri, Jan 17

AronManning added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

The Great Wall of Text above might be easier to read on-wiki: https://www.mediawiki.org/wiki/User:Aron_Manning/Which_web_framework_to_choose

Fri, Jan 17, 9:53 PM · Security-Team, TechCom-RFC
AronManning added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

I forgot to mention that both WordPress (as of version 5.0) and Drupal (future) use React. I think it might be wise to consult with these two projects and see why they chose React over Vue.

One can have the opposite argument: Wouldn't it be wise to consult with big projects, which use Vue, as to why they chose it?

Fri, Jan 17, 9:25 PM · Security-Team, TechCom-RFC
AronManning added a comment to T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki.

When choosing a framework, the most important in my view is that the chosen framework be tailored to the specific needs of the project and the community's experience. I think this aspect should be explored in detail as well, so in the next 1 or 2 decades (until these frameworks are superseded and we have this discussion again), we get the best out of the chosen framework.

Fri, Jan 17, 12:55 PM · Security-Team, TechCom-RFC
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

Hiding the "2 more paragraphs" is a great idea. With a slow transition, when it is hidden...
I find the (blue) border between the editor and the preview important. The scrollbar above a certain size (1/3 or 1/2 screen) looks good.

Fri, Jan 17, 3:15 AM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning added a comment to T238782: CU 2.0: Display data in the Compare tab.

@Prtksxna have you looked at the patches I've submitted? Those are fairly trivial. Is there something wrong with it?

Fri, Jan 17, 2:12 AM · Anti-Harassment (The Letter Song), CheckUser
AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

The patch passes the QUnit and Selenium-Cucumber tests. It's ready for hands-on testing.
If it gets accepted, will there be an internal test period on beta before it goes live?

Fri, Jan 17, 1:18 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Thu, Jan 16

AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.
Thu, Jan 16, 10:29 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Wed, Jan 15

AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

Are you proposing to remove MMV's scroll position logic because you expect that the browser's own logic in Chrome and Firefox works fine by default? (Just want to double check that I understand correctly.)

Wed, Jan 15, 8:40 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

Whilst staging and verifying this on www.mediawiki.org, I still encountered the bug in Firefox. It still worked the same in Firefox as before, and still worked correctly in other browsers. I've deployed it regardless to keep the state matching with master and to see if maybe it's a caching issue.

Wed, Jan 15, 8:33 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Tue, Jan 14

AronManning awarded T59154: Flow: Prettify thread permalink URLs/Titles (they are not human readable!) a Like token.
Tue, Jan 14, 4:41 PM · Growth-Team, Collaboration-Team-Triage, StructuredDiscussions

Mon, Jan 13

AronManning awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Like token.
Mon, Jan 13, 8:23 PM · Security-Team, TechCom-RFC
AronManning awarded T241180: RFC: Adopt a modern JavaScript framework for use with MediaWiki a Orange Medal token.
Mon, Jan 13, 7:59 PM · Security-Team, TechCom-RFC

Sat, Jan 11

AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

Patch is up, grunt test passed locally.

Sat, Jan 11, 10:13 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.
  • Relationship of reply/preview to comment: I agree with the framing that @AronManning provided in terms of the options that we have - but I'll throw in another one - we can keep the version that we have in iteration v2 or v3 and draw a stronger relationship to the reply a la reddit. Something like these options:

That's a good option too. Is it correct to say that's the "preview below editbox" variant with the border between the two removed + a darker background to distinguish the preview?
I feel the difference should be more accentuated (a tiny bit darker background) and/or possibly a sublime border that's hardly noticeable. On this preview, I have to think twice which text can be edited.
It seems to me this is a styling question - one worth exploring, to more intuitively communicate the tool's usage.

Sat, Jan 11, 5:03 AM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design

Fri, Jan 10

AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.
  1. This scenario assumes the text input area continues to be shown beneath the comment a contributor is responding to, as it currently does on the prototype.
Fri, Jan 10, 1:33 PM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

Re: preview iterations


Css: https://gist.github.com/AronMan5/dc4843b2fe8f0ed022fc123ab5aab879

Fri, Jan 10, 1:29 AM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design

Thu, Jan 9

AronManning added a comment to T238177: Create mockup for a new approach to previewing a reply.

Thanks for the previews, great work!

Thu, Jan 9, 11:57 PM · VisualEditor (Current work), Editing-team, OWC2020, Editing Design
AronManning added a comment to T238782: CU 2.0: Display data in the Compare tab.

@Niharika for effectively using the checkuser it would be important to also present the subnet/ISP the IP belongs to. I've suggested adding this to the design 2 months ago in T237593#5643299, but there was no discussion about it since then. I reckon if this is not done now with the fundamental design work, then it won't be done in the coming years. This is the best time to make that part of the design.

Thu, Jan 9, 1:22 AM · Anti-Harassment (The Letter Song), CheckUser
AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

@matthiasmullie Yes, I've completely removed the need to restore the position, also removing in the process a number of re-layouts, the jump to the top and back. That noticeable jump, the delay all got removed from the user experience. It is an extensive refactoring / cleanup. I expect it to be more reliable and smooth than getting the timing / order right, which can break for unexpected reasons.

Thu, Jan 9, 12:17 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Thu, Jan 2

AronManning added a comment to T218626: [Epic] Partial block rollout.

I don't get why the Wikimedia Foundation doesn't just implement this by default, what would we truly lose if partial blocks were implemented? Admins aren’t forced to use them when they don't want to, “giving the community a choice” just means that they (we) could prevent something that's a net benefit to it.
In fact, policies are written around the technical capabilities and limitations of the MediaWiki software, not vice versa.

Thu, Jan 2, 4:57 AM · Patch-For-Review, Epic, MediaWiki-User-management, User-notice, Wikimedia-Site-requests, Anti-Harassment

Wed, Dec 25

AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

The above patch separates the MediaViewer's scrolling to the overlay (body > .mw-mmv-wrapper) element and disables scrolling on the body with overflow: hidden, thereby eliminating the need to hide the content with display:none on open and to restore the scroll position on close. Restoring the scroll position produced a noticeable, disturbing jump to the top of the content and back and depending on browser and CPU load it failed as the content was not laid out in time.

Wed, Dec 25, 2:54 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Mon, Dec 23

AronManning added a comment to T229484: After closing, browser sometimes scrolls to the top of the page in Firefox 70.

This is driving me bonkers... for me it seems to happen on Firefox, but not Chrome

Mon, Dec 23, 11:57 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), Structured-Data-Backlog (Current Work), Readers-Web-Backlog (Tracking), Upstream, Browser-Support-Firefox, MediaViewer

Dec 16 2019

AronManning updated the task description for T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates..
Dec 16 2019, 9:02 AM · MediaWiki-User-management
AronManning added a subtask for T204903: Epic ⚡️ unprioritized Partial Blocks features: T202673: RFC: Multiblocks - let admins create multiple, overlapping blocks on a single user.
Dec 16 2019, 9:01 AM · Anti-Harassment
AronManning added a parent task for T202673: RFC: Multiblocks - let admins create multiple, overlapping blocks on a single user: T204903: Epic ⚡️ unprioritized Partial Blocks features.
Dec 16 2019, 9:01 AM · TechCom-RFC
AronManning updated the task description for T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates..
Dec 16 2019, 9:00 AM · MediaWiki-User-management

Dec 15 2019

AronManning awarded T160233: Enable administrators to update block logs a Like token.
Dec 15 2019, 12:04 PM · Anti-Harassment, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-Logging, MediaWiki-User-management, Community-Wishlist-Survey-2016

Dec 12 2019

AronManning added a comment to T240360: Determine our approach for displaying date and time a comment was made, in a user's local timezone and preferred date format.

Personal views:

  1. I think "Browser-local time" should be a preference for "Time zone" and used only if that's the chosen setting. Could be the default setting, though for new users. Disclosure: I use UTC, not local time (possible bias).
    • Currently there's only a "Fill in from browser" option, that grabs the browser's time offset (that includes the current day-light saving) and stores as a setting. That setting does not follow day-light and timezone changes, therefore it's not really useful.
  2. I often copy the date-time, including timezone to refer to specific comments/diffs or to search for the time in the history. For these usages consistency of the comment timestamps and history timestamp is important, both should follow the wiki preference.
  3. Showing the relative time by default and the absolute time (wiki preference / UTC) on hover is common in messaging software and quite convenient in Flow. However, the tooltip popup solution of reddit is not so convenient imo.
    • It would be a nice feature to have with a setting that enables it (could be enabled by default for new users). Note: I actually don't use it, but I know editors who have some script to do this for talk page comments.
    • The user should be able to easily select and copy the absolute time. If the presentation changes on hover, there should be some padding to allow for the mouse pointer to move past the last character. Currently, in Flow the user has to stop moving the mouse precisely after the last (first) character.
  4. Communicating using UTC in global communities is common. There should be an option to show the time in UTC zone on hover, regardless of the wiki preference and whether relative time is shown by default.
Dec 12 2019, 12:07 PM · VisualEditor (Current work), Editing Design, Editing-team, OWC2020
AronManning added a comment to T218626: [Epic] Partial block rollout.

Will this be rolled out on en.wiki without an RfC [...]?

Dec 12 2019, 6:34 AM · Patch-For-Review, Epic, MediaWiki-User-management, User-notice, Wikimedia-Site-requests, Anti-Harassment

Dec 11 2019

AronManning added a comment to T160233: Enable administrators to update block logs.

@DannyS712 I've looked at the patch set. Please correct me if I'm wrong: as I see you've implemented the "make comment-only entries in block logs" proposal, that adds a new entry without modifying previous entries, thus only the user's visible block reason is changed. I don't see any changes to the block log (Special:Log/block) in the patchset, therefore the previous log entries (and the annotation entries) are all visible there, unmodified.

Dec 11 2019, 12:57 AM · Anti-Harassment, Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, User-DannyS712, MediaWiki-Logging, MediaWiki-User-management, Community-Wishlist-Survey-2016

Dec 10 2019

AronManning added a comment to T218626: [Epic] Partial block rollout.

I don't get why the Wikimedia Foundation doesn't just implement this by default, what would we truly lose if partial blocks were implemented? Admins aren’t forced to use them when they don't want to, “giving the community a choice” just means that they (we) could prevent something that's a net benefit to it.
In fact, policies are written around the technical capabilities and limitations of the MediaWiki software, not vice versa. There is literally not a single reason why a piece of software that doesn't limit anything possible today but only expand it should not just be enabled by default, if partial blocks had the potential to damage the workflow of the community I could understand that it would require prior discussion, but this is unnecessary bureaucracy.

Dec 10 2019, 10:09 PM · Patch-For-Review, Epic, MediaWiki-User-management, User-notice, Wikimedia-Site-requests, Anti-Harassment
AronManning moved T240313: Partial Block UI: Pop-up editor for long lists of pages from Backlog to User blocking on the MediaWiki-User-management board.
Dec 10 2019, 6:10 AM · MediaWiki-User-management
AronManning created T240313: Partial Block UI: Pop-up editor for long lists of pages.
Dec 10 2019, 6:07 AM · MediaWiki-User-management
AronManning updated the task description for T119795: Add new user block option "can edit Wikipedia:Appealing_a_block" .
Dec 10 2019, 5:54 AM · MediaWiki-General
AronManning updated the task description for T27400: Software should allow admins to give specific users permission to edit specific pages through blocks (whitelist).
Dec 10 2019, 5:52 AM · MediaWiki-User-management
AronManning updated the task description for T240311: Partial Block UI: White-list of pages allowed to edit for site-wide blocks.
Dec 10 2019, 5:51 AM · MediaWiki-User-management
AronManning updated the task description for T240311: Partial Block UI: White-list of pages allowed to edit for site-wide blocks.
Dec 10 2019, 5:50 AM · MediaWiki-User-management
AronManning updated the task description for T27400: Software should allow admins to give specific users permission to edit specific pages through blocks (whitelist).
Dec 10 2019, 5:49 AM · MediaWiki-User-management
AronManning added a subtask for T204903: Epic ⚡️ unprioritized Partial Blocks features: T240311: Partial Block UI: White-list of pages allowed to edit for site-wide blocks.
Dec 10 2019, 5:44 AM · Anti-Harassment
AronManning added a parent task for T240311: Partial Block UI: White-list of pages allowed to edit for site-wide blocks: T204903: Epic ⚡️ unprioritized Partial Blocks features.
Dec 10 2019, 5:44 AM · MediaWiki-User-management
AronManning created T240311: Partial Block UI: White-list of pages allowed to edit for site-wide blocks.
Dec 10 2019, 5:43 AM · MediaWiki-User-management
AronManning added a subtask for T204903: Epic ⚡️ unprioritized Partial Blocks features: T240310: Partial Block UI: List articles recently edited by the user.
Dec 10 2019, 5:38 AM · Anti-Harassment
AronManning added a parent task for T240310: Partial Block UI: List articles recently edited by the user: T204903: Epic ⚡️ unprioritized Partial Blocks features.
Dec 10 2019, 5:38 AM · MediaWiki-User-management
AronManning created T240310: Partial Block UI: List articles recently edited by the user.
Dec 10 2019, 5:37 AM · MediaWiki-User-management
AronManning updated the task description for T194697: Multiblocks — Allow for multiple, simultaneously blocks with different expiration dates..
Dec 10 2019, 5:21 AM · MediaWiki-User-management

Dec 6 2019

AronManning added a comment to T239680: CU 2.0: Persist the form state.

Sorry, I'm confused, let me try and clarify for my own mental image; why would going from "submit" and into any of the "sub" details ("compare" vs details, etc) be another check?

The "Submit" button brings up the "Preliminary check" tab. As I understand the purpose of that is to not run the actual check (thus no cu log entry created). The first query is run when the "Compare" or "Timeline" tab is opened. I think the UI workflow is a bit confusing, as there is no big button that actually runs the check, or I am misunderstanding the proposed workflow.

Dec 6 2019, 2:42 PM · Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
AronManning added a comment to T239680: CU 2.0: Persist the form state.

CU log entries and CU investigations have a 1-1 relation. Calling it a "log" is arbitrary, reflecting the original use-case. Maybe calling it "CU investigations" in the DB would be more appropriate while calling it "CU log" on the UI.
I see only one limiting factor with the current cu_log table: cul_user is an N-1 relation, that cannot accommodate for multiple users checked in one investigation. That will require a new table (schema change).

Naive question: Is it a problem if we add multiple rows per the same investigation to this log?
Technically, it seems to me that this is more or less what is already done, isn't it? If an investigation about a certain IP reveals multiple users, that then require
individual "attention" by the checker, they'll review each (relevant) username, yet the investigation itself is for a single purpose.

I used the wrong word "investigation", I meant "check". An investigation might require more checks. I'm editing that comment to fix this.

Dec 6 2019, 5:13 AM · Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
AronManning added a comment to T239680: CU 2.0: Persist the form state.

To authorize a subsequent request (sorting/paging), checking the existence of a CU log entry (with the CU user, check timestamp, target users) should be necessary and sufficient.

Well that's an interesting idea... feels like a bit of an "abuse" of a log (i.e. I think an application should function even if logging is unavailable)... but certainly not unprecedented.

Dec 6 2019, 4:23 AM · Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)
AronManning added a comment to T239680: CU 2.0: Persist the form state.

I'm going to explore tokenizing/signing the request. It looks like we are already using a JWT library in production so I can't imagine why it would be an issue to reuse that.

Dec 6 2019, 2:49 AM · Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Dec 4 2019

AronManning added a comment to T237300: CU 2.0: Sorting in the Compare tab.

A few thoughts on the implementation:

Dec 4 2019, 9:34 PM · Anti-Harassment (The Letter Song), CheckUser
AronManning added a comment to T239680: CU 2.0: Persist the form state.

Persistence across tabs -- PHP sessions are stored per browser (not tab) so they persist across tabs. Is that okay?

Dec 4 2019, 9:07 PM · Security-Team, Patch-For-Review, CheckUser, Anti-Harassment (The Letter Song)

Dec 2 2019

AronManning added a comment to T238714: CU 2.0: Fetch information to be displayed in Compare tab.

Where do unregistered edits on that IP fall? is that part of the 10 edits from 3 other users or do we want to exclude those?

I assumed the IP would be one of the users, though I suppose it depends on how you interpret the word "user."

Dec 2 2019, 5:15 PM · Patch-For-Review, Anti-Harassment (The Letter Song), CheckUser

Nov 21 2019

AronManning added a comment to T175587: Add a user-agent parser to CheckUser.

Parsing looks good. Reliable enough for the purpose: only distinguishing different agents, versions, OSs is important, 100% accuracy is not needed.
WhichBrowser returns more detailed version numbers, that's a plus. Stores patterns in php files.
DeviceDetector stores its pattern data in yaml and requires a yaml parser, thus it can be expected to load slower.

Nov 21 2019, 9:03 PM · Anti-Harassment, CheckUser
AronManning added a comment to T175587: Add a user-agent parser to CheckUser.

As a non-wm CU my order of evidence strength is (decreasing):

  1. obviously fabricated UA (uncommon, only trolls do that), 2) same UA 3) browser version increased (updated) 4) same device and OS, different browser 5) different UA

The strength of the CU match adds up with the strength of the IP match:

  1. same IP in a short timeframe or static IP 2) same subnet, if there aren't many users from the subnet/ISP 3) if accounts use IPs from random countries, that's unlikely to be due to travel 4) IPs reported as proxy/vpn
Nov 21 2019, 4:19 PM · Anti-Harassment, CheckUser
AronManning added a comment to T237034: CheckUser 2.0: Input form.

@JJMC89 Yes, requiring a link to the cause is unnecessary for private/small wikis. Thanks for mentioning this.
It only matters on wikimedia wikis, where there are strong guarantees of privacy.
@Niharika It can be enabled with a flag in the configuration.

Nov 21 2019, 3:42 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), CheckUser

Nov 20 2019

AronManning added a comment to T175587: Add a user-agent parser to CheckUser.

The full UA can be displayed as a mouseover popup of the "Browser" field (title="<UA>") and also copied to the clipboard for further analysis when the field is clicked.
Whenever pattern-matching the UA fails the "Browser" column can display "Unknown", or the first ca. 20 characters of the UA with a different color. The user will mouseover to see the actual UA.
This might become tedious if there are more, that failed parsing, eg. more than 3. In that case (or in all cases) an extra column can be shown with all the full UA strings.
This column will likely overflow the screen and require horizontal scrolling.

Nov 20 2019, 12:46 AM · Anti-Harassment, CheckUser
AronManning added a comment to T237034: CheckUser 2.0: Input form.

@Niharika the field is short for a textual description and a link. Either a longer 2-line textfield or 2 fields would be enough.
In any case, the comments should instruct to paste the link to the cause and form validation should check its presence.
The check is a bit simpler with a separate field, but it is less busy with one longer field.

Nov 20 2019, 12:19 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), CheckUser

Nov 18 2019

AronManning added a comment to T237034: CheckUser 2.0: Input form.

The cause of doing CU is often an SPI or a user request or suspicious edit. In any case, the reason should link to this cause and the form should require this link for the reason.
Would a separate field for the link be better or a two-line reason field?
With two separate fields I think it would be cleaner:

Nov 18 2019, 8:28 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Anti-Harassment (The Letter Song), CheckUser

Nov 16 2019

AronManning added a comment to T213451: Review Special:Block design once partial blocks are more fully implemented.

3 suggested improvements to the partial blocking UI:

Nov 16 2019, 11:26 AM · Anti-Harassment, MediaWiki-User-management

Nov 8 2019

AronManning added a comment to T236981: CheckUser 2.0: Create a new Special page in CheckUser for the redesigned version.

Imo CheckUserTest or CheckUserDev or CheckUserAlpha. I assume when it goes to production (new version enabled in config) it will replace the current CheckUser and this in-development name will be dropped.

Nov 8 2019, 4:06 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), Anti-Harassment (The Letter Song), CheckUser

Nov 7 2019

AronManning added a comment to T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses.

Besides subnet (whois) and geolocation, presenting Proxy/VPN data would be useful for CU. Example: https://www.ipqualityscore.com/free-ip-lookup-proxy-vpn-test/lookup/86.187.160.157
This data is no more reliable than Geoloc data, yet it is a good clue for determining the likelihood of a proxy user.

Nov 7 2019, 9:16 AM · Patch-For-Review, User-Huji, MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser
AronManning added a subtask for T237593: [Epic] CheckUser 2.0: Compare: T234980: Implement an option to highlight non-standard user-agent strings in CheckUser.
Nov 7 2019, 9:09 AM · Epic, Anti-Harassment, CheckUser
AronManning removed a subtask for T237595: [Epic] CheckUser 2.0: Timeline: T234980: Implement an option to highlight non-standard user-agent strings in CheckUser.
Nov 7 2019, 9:09 AM · Epic, Anti-Harassment, CheckUser
AronManning edited parent tasks for T234980: Implement an option to highlight non-standard user-agent strings in CheckUser, added: T237593: [Epic] CheckUser 2.0: Compare; removed: T237595: [Epic] CheckUser 2.0: Timeline.
Nov 7 2019, 9:09 AM · CheckUser
AronManning added a comment to T237595: [Epic] CheckUser 2.0: Timeline.

^^^^ For description.

Nov 7 2019, 9:07 AM · Epic, Anti-Harassment, CheckUser
AronManning updated subscribers of T237593: [Epic] CheckUser 2.0: Compare.
Nov 7 2019, 8:45 AM · Epic, Anti-Harassment, CheckUser
AronManning added a comment to T237593: [Epic] CheckUser 2.0: Compare.

A more substantive task.
Add 3 columns: Subnet (name and ip range of the subnetwork), Geolocation (closest city, generally), Proxy/VPN (reported/detected proxies)
This would greatly increase the efficiency of recognizing IPs from around the world (VPN users), dynamic ips on the same subnet, open proxies/free VPNs, etc.

Nov 7 2019, 8:29 AM · Epic, Anti-Harassment, CheckUser
AronManning added a comment to T237593: [Epic] CheckUser 2.0: Compare.

@Niharika ^^^^ for Description.

Nov 7 2019, 8:01 AM · Epic, Anti-Harassment, CheckUser