BGerstle-WMF (Brian Gerstle)Disabled, Email Not Verified
Disabled

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 14 2015, 1:18 AM (162 w, 2 d)
Roles
Disabled
Availability
Available
IRC Nick
bgerstle
LDAP User
Unknown
MediaWiki User
BGerstle (WMF)

Recent Activity

May 4 2017

BGerstle-WMF committed rAPIOSd77115096c0f: playing with HTML opts (authored by BGerstle-WMF).
playing with HTML opts
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOS708c34499aaf: super hacky transitions (authored by BGerstle-WMF).
super hacky transitions
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOS2b6327bdfad8: uncrustify (authored by BGerstle-WMF).
uncrustify
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOSc989cd2a1467: add images (authored by BGerstle-WMF).
add images
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOSfd4a8048b83b: site & title initWithURL (authored by BGerstle-WMF).
site & title initWithURL
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOS62a32409601b: WIP: DTCoreText contentview (authored by BGerstle-WMF).
WIP: DTCoreText contentview
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOS103a33aa4574: added reg/compact mode (authored by BGerstle-WMF).
added reg/compact mode
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOSec90cc0446d5: add CocoaLumberjack (authored by BGerstle-WMF).
add CocoaLumberjack
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOS573e4528b2e8: update & reorganize pods (authored by BGerstle-WMF).
update & reorganize pods
May 4 2017, 4:57 PM
BGerstle-WMF committed rAPIOS0f908ab1d366: add article presenter & hook up sharing (authored by BGerstle-WMF).
add article presenter & hook up sharing
May 4 2017, 4:57 PM

Apr 17 2017

GitHub <noreply@github.com> committed rAPIOS2c5949a782ec: Merge 2c41932cfadd228cc77977c4e8d4427d561d8142 into… (authored by BGerstle-WMF).
Merge 2c41932cfadd228cc77977c4e8d4427d561d8142 into…
Apr 17 2017, 4:56 AM

Jun 30 2016

BGerstle-WMF committed rAPIOSec184e9309c9: Merge 7da011c4d6cf957d36b66e8b101cb9f4fe810c28 into… (authored by BGerstle-WMF).
Merge 7da011c4d6cf957d36b66e8b101cb9f4fe810c28 into…
Jun 30 2016, 1:15 AM
BGerstle-WMF committed rAPIOSa0e39350a787: makefile: fix clean goal (authored by BGerstle-WMF).
makefile: fix clean goal
Jun 30 2016, 1:15 AM
BGerstle-WMF committed rAPIOS8a6f3a3214ed: ignore mobileprovision and fix early return (authored by BGerstle-WMF).
ignore mobileprovision and fix early return
Jun 30 2016, 1:15 AM
BGerstle-WMF committed rAPIOS6acadd91e8c1: Merge 19f32b21ee55c1030c02f0ae7d47a28fc7c24b74 into… (authored by BGerstle-WMF).
Merge 19f32b21ee55c1030c02f0ae7d47a28fc7c24b74 into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS485142f26bdc: Merge 97057db92a5073f4351901ab13e73e7663cfdf67 into… (authored by BGerstle-WMF).
Merge 97057db92a5073f4351901ab13e73e7663cfdf67 into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS97057db92a50: add unit testing target (authored by BGerstle-WMF).
add unit testing target
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSe236b75290c9: re-add schemes (authored by BGerstle-WMF).
re-add schemes
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS6f5907ead28e: Merge 2a3ddfb81337e3db88097ca1631941bd9c4914e7 into… (authored by BGerstle-WMF).
Merge 2a3ddfb81337e3db88097ca1631941bd9c4914e7 into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSb098649c11dd: remove conflict markers (authored by BGerstle-WMF).
remove conflict markers
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSfee8f3936fd8: remove beta.xcconfig (authored by BGerstle-WMF).
remove beta.xcconfig
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS9a0313ced6d4: remove extra schemes and double check old data model inclusion (authored by BGerstle-WMF).
remove extra schemes and double check old data model inclusion
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS75137393a5b7: makefile & fastlane follow-on (authored by BGerstle-WMF).
makefile & fastlane follow-on
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS3ab48c57ba7f: clean up FastFile and set vim filetype (authored by BGerstle-WMF).
clean up FastFile and set vim filetype
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOScf5865e594e5: update Gemfile and ignore fastflane artifacts (authored by BGerstle-WMF).
update Gemfile and ignore fastflane artifacts
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS6343679c7358: Merge 2a3ddfb81337e3db88097ca1631941bd9c4914e7 into… (authored by BGerstle-WMF).
Merge 2a3ddfb81337e3db88097ca1631941bd9c4914e7 into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS2a3ddfb81337: travis & coveralls (authored by BGerstle-WMF).
travis & coveralls
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS36272c796ee5: Merge pull request #9 from bgerstle/feature/T96206 (authored by BGerstle-WMF).
Merge pull request #9 from bgerstle/feature/T96206
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS18c7a200e7f6: Merge pull request #11 from bgerstle/feature/fix-hockey-alert (authored by BGerstle-WMF).
Merge pull request #11 from bgerstle/feature/fix-hockey-alert
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS71a134c46769: add more negative tests for article migration (authored by BGerstle-WMF).
add more negative tests for article migration
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS7674a5e48052: remove article data when migration fails (authored by BGerstle-WMF).
remove article data when migration fails
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS9bf9b040091b: Merge pull request #8 from bgerstle/migration-failure-handling (authored by BGerstle-WMF).
Merge pull request #8 from bgerstle/migration-failure-handling
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS1221cc41eb52: show simple alert before migration (authored by BGerstle-WMF).
show simple alert before migration
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS321a4a164a97: localized prompt in english (authored by BGerstle-WMF).
localized prompt in english
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSb9751e658172: revert build script phase comments (authored by BGerstle-WMF).
revert build script phase comments
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS311115e29f6e: refactor and add fix for failing test (authored by BGerstle-WMF).
refactor and add fix for failing test
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS264c7a35f7e9: failing section list exception handling test (authored by BGerstle-WMF).
failing section list exception handling test
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS052d32a9dc1b: bump build, commit, tag, and push for alpha builds (authored by BGerstle-WMF).
bump build, commit, tag, and push for alpha builds
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS57fbd8cc6375: Version Bump (authored by BGerstle-WMF).
Version Bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS8ed952ac1ef3: Version Bump (authored by BGerstle-WMF).
Version Bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS309ac7e149b0: Merge e51de205ebff3b8c5ff5f1b12962bf2f2c0cfd67 into… (authored by BGerstle-WMF).
Merge e51de205ebff3b8c5ff5f1b12962bf2f2c0cfd67 into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSbbe2fd13bd94: Version Bump (authored by BGerstle-WMF).
Version Bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSfce987c44ca8: Version Bump (authored by BGerstle-WMF).
Version Bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSc574f4f88993: Version Bump (authored by BGerstle-WMF).
Version Bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS71f6a4ebea9a: automate bumping via fastlane (authored by BGerstle-WMF).
automate bumping via fastlane
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS12e78c7b4e43: fastlane + version bump (authored by BGerstle-WMF).
fastlane + version bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS26886e1bc2f6: version bump + fastlane changes (authored by BGerstle-WMF).
version bump + fastlane changes
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS5cd8d2b43437: Version Bump (authored by BGerstle-WMF).
Version Bump
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS30ea1fb6e9d0: test fork pr (authored by BGerstle-WMF).
test fork pr
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS2c41932cfadd: another wild commit appeared! (authored by BGerstle-WMF).
another wild commit appeared!
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS3ad4f437b565: fastlane dev (authored by BGerstle-WMF).
fastlane dev
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSaa0e6927a19e: Merge 2c41932cfadd228cc77977c4e8d4427d561d8142 into… (authored by BGerstle-WMF).
Merge 2c41932cfadd228cc77977c4e8d4427d561d8142 into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOSa0dece4ce20d: Version Bump to 178 (authored by BGerstle-WMF).
Version Bump to 178
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS3752d0cbecd9: Merge 402e81c01a95d3f3e9dabb1e21f0a2d737a49a0e into… (authored by BGerstle-WMF).
Merge 402e81c01a95d3f3e9dabb1e21f0a2d737a49a0e into…
Jun 30 2016, 1:10 AM
BGerstle-WMF committed rAPIOS334d8ea56214: Merge 6137acc25e89cf990e1c20f015e838e88e3642bb into… (authored by BGerstle-WMF).
Merge 6137acc25e89cf990e1c20f015e838e88e3642bb into…
Jun 30 2016, 1:10 AM

Mar 18 2016

BGerstle-WMF committed rAPIOS85ed4730456d: fix framework import (authored by BGerstle-WMF).
fix framework import
Mar 18 2016, 6:33 PM
BGerstle-WMF committed rAPIOS1600201bd6f7: remove empty search button tests compile phase action (authored by BGerstle-WMF).
remove empty search button tests compile phase action
Mar 18 2016, 6:33 PM
BGerstle-WMF committed rAPIOSb4197e19b5ea: re-enable "legacy" code coverage" (authored by BGerstle-WMF).
re-enable "legacy" code coverage"
Mar 18 2016, 6:33 PM
BGerstle-WMF committed rAPIOS71b88bb6b49b: remove SSDataSources from test target (authored by BGerstle-WMF).
remove SSDataSources from test target
Mar 18 2016, 6:33 PM

Mar 3 2016

BGerstle-WMF added a comment to T113274: As a user, I can see the Wikipedia iOS app description in my App Store language.

maybe we could use comm's system

Mar 3 2016, 9:12 PM · iOS-app-v5-production, Wikipedia-iOS-App-Backlog
BGerstle-WMF added a comment to T113274: As a user, I can see the Wikipedia iOS app description in my App Store language.

did a little brainstorming in planning, we might need a separate system for translating short-lived strings in a smaller time window

Mar 3 2016, 9:12 PM · iOS-app-v5-production, Wikipedia-iOS-App-Backlog
BGerstle-WMF committed rAPIOS664f7e1e2cdc: uncrustify (authored by BGerstle-WMF).
uncrustify
Mar 3 2016, 7:55 PM
BGerstle-WMF committed rAPIOSc8560004f52e: add weakify/strongify for article image protocol repsonse handling (authored by BGerstle-WMF).
add weakify/strongify for article image protocol repsonse handling
Mar 3 2016, 7:53 PM
BGerstle-WMF committed rAPIOS0fa2ba0804fc: only ever show gallery after article data has arrived (authored by BGerstle-WMF).
only ever show gallery after article data has arrived
Mar 3 2016, 7:44 PM
BGerstle-WMF committed rAPIOSfcc80811383c: prevent nil obj in placeholder array crash, add lang/site fallbacks (authored by BGerstle-WMF).
prevent nil obj in placeholder array crash, add lang/site fallbacks
Mar 3 2016, 7:17 PM

Mar 2 2016

BGerstle-WMF committed rAPIOS9808a6aba3b8: Bump to 770 (authored by BGerstle-WMF).
Bump to 770
Mar 2 2016, 10:05 PM
BGerstle-WMF committed rAPIOSec440d541f9b: revamp store lane, remove hockeyapp ID's, remove unused rc lane (authored by BGerstle-WMF).
revamp store lane, remove hockeyapp ID's, remove unused rc lane
Mar 2 2016, 10:05 PM
BGerstle-WMF committed rAPIOS848fe7c04046: Merge pull request #569 from wikimedia/twn/03-02-2016 (authored by BGerstle-WMF).
Merge pull request #569 from wikimedia/twn/03-02-2016
Mar 2 2016, 9:44 PM
BGerstle-WMF moved T128649: [5.0.0 (634)] Crash when attempting to preview non HTTP links from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.
Mar 2 2016, 9:42 PM · iOS-app-v5-production, Wikipedia-iOS-App-Development
BGerstle-WMF moved T128532: App store draft strings for 5.0.0 public release from Ready for Development to Needs Code Review on the Wikipedia-iOS-App-Development board.
Mar 2 2016, 9:42 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF committed rAPIOS451b7d356a32: fix reversed dolla dolla dolla sign (authored by BGerstle-WMF).
fix reversed dolla dolla dolla sign
Mar 2 2016, 9:33 PM
BGerstle-WMF renamed T128652: As a user, I shouldn't need to re-download the same data from As a user, I shouldn't need to re-download the same content for the feed over and over again to As a user, I shouldn't need to re-download the same data.
Mar 2 2016, 9:14 PM · Wikipedia-iOS-App-Backlog
BGerstle-WMF created T128652: As a user, I shouldn't need to re-download the same data.
Mar 2 2016, 9:12 PM · Wikipedia-iOS-App-Backlog
BGerstle-WMF moved T128608: [REGRESSION 5.0.0(764)] Nearby cells don't update from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.
Mar 2 2016, 9:05 PM · Wikipedia-iOS-App-Backlog, iOS-app-Bugs, iOS-app-v5-production, Wikipedia-iOS-App-Development
BGerstle-WMF moved T128554: [Crash] 5.0.0 764 Crash with clean install on iPad Mini from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.
Mar 2 2016, 9:05 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF moved T127612: As a user I want to be able to search the wikipedia iOS app from spotlight from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.
Mar 2 2016, 9:05 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF claimed T128649: [5.0.0 (634)] Crash when attempting to preview non HTTP links.
Mar 2 2016, 9:05 PM · iOS-app-v5-production, Wikipedia-iOS-App-Development
BGerstle-WMF created T128649: [5.0.0 (634)] Crash when attempting to preview non HTTP links.
Mar 2 2016, 9:05 PM · iOS-app-v5-production, Wikipedia-iOS-App-Development
BGerstle-WMF committed rAPIOS61c2f6bd30b6: Merge pull request #561 from wikimedia/feature/language-bar-align-fix (authored by BGerstle-WMF).
Merge pull request #561 from wikimedia/feature/language-bar-align-fix
Mar 2 2016, 9:03 PM
BGerstle-WMF committed rAPIOSd287e04cbf4a: only show safariVC if HTTP link (authored by BGerstle-WMF).
only show safariVC if HTTP link
Mar 2 2016, 9:03 PM
BGerstle-WMF committed rAPIOSba405eb2a92e: Merge pull request #565 from wikimedia/welcomeTweaks (authored by BGerstle-WMF).
Merge pull request #565 from wikimedia/welcomeTweaks
Mar 2 2016, 8:58 PM
BGerstle-WMF committed rAPIOSea7f2a68d80c: Merge pull request #564 from wikimedia/feature/remove-html-in-spotlight (authored by BGerstle-WMF).
Merge pull request #564 from wikimedia/feature/remove-html-in-spotlight
Mar 2 2016, 8:58 PM
BGerstle-WMF committed rAPIOS4b7d9d8cce25: Merge pull request #566 from wikimedia/feature/splash/T128547 (authored by BGerstle-WMF).
Merge pull request #566 from wikimedia/feature/splash/T128547
Mar 2 2016, 8:58 PM
BGerstle-WMF created T128641: As a user, I should always see thumbnails for spotlight results of articles that have lead images.
Mar 2 2016, 8:41 PM · iOS-app-v5.1.0-Saturn, Wikipedia-iOS-App-Backlog
BGerstle-WMF committed rAPIOS9c39e204a065: remove remaining references to old onboarding graphics (authored by BGerstle-WMF).
remove remaining references to old onboarding graphics
Mar 2 2016, 8:23 PM
BGerstle-WMF added a comment to T128387: [5.0.0(720+)] article is set on view before it is loaded.

Resolving, will reopen if the crash appears again in HockeyApp

Mar 2 2016, 8:21 PM · WorkType-Maintenance, iOS-app-v5-production, Wikipedia-iOS-App-Development
BGerstle-WMF closed T128387: [5.0.0(720+)] article is set on view before it is loaded as Resolved.
Mar 2 2016, 8:21 PM · WorkType-Maintenance, iOS-app-v5-production, Wikipedia-iOS-App-Development
BGerstle-WMF closed T127841: Set threshold on shared image cache to limit number of images stored in memory. as Resolved.

I can see the code that changed it, unfortunately I'm not seeing a large difference in memory usage. NSCache (infamously) omits any guarantee that it will evict objects once the count limit is exceeded. And after browsing many POTD and several articles, I should have easily hit 50 images and started to see things level off. Resolving that the work was done, but it's unclear if there was any significant improvement.

Mar 2 2016, 8:17 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF added a comment to T128532: App store draft strings for 5.0.0 public release.

@JMinor need access to Google doc w/ screenshots

Mar 2 2016, 8:03 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF added a comment to T128532: App store draft strings for 5.0.0 public release.

some formatting tweaks and updated the "Feedback" instructions. Also, our "feedback" mechanism is really, really buried. At the very least we should make it a button in Settings (instead of a link at the bottom of the "About" page).

Mar 2 2016, 8:01 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF updated the task description for T128532: App store draft strings for 5.0.0 public release.
Mar 2 2016, 8:00 PM · Wikipedia-iOS-App-Development, iOS-app-v5-production
BGerstle-WMF added a comment to T123250: As a user, I should only see placeholders when scrolling quickly or my connection is slow.

More like a performance enhancement

Mar 2 2016, 7:53 PM · Wikipedia-iOS-App-Backlog
BGerstle-WMF added a comment to T128545: Pressing share with more than one image displayed, crashes the app.

so in the app store, the app would just pick one

Mar 2 2016, 6:46 PM · User-Josve05a, Wikipedia-iOS-App-Backlog
BGerstle-WMF added a comment to T128545: Pressing share with more than one image displayed, crashes the app.

@JMinor @Josve05a this isn't a crash, it's an assertion since normally (when there's only one image "displayed"), we only expect to get one visible image. however, in this case we could just pick the left-most (or right-most in RTL?) or disable chrome interaction entirely while scrolling

Mar 2 2016, 6:45 PM · User-Josve05a, Wikipedia-iOS-App-Backlog
BGerstle-WMF committed rAPIOS7f921779ba74: raise pageview data availability threshold (12:00 UTC) (authored by BGerstle-WMF).
raise pageview data availability threshold (12:00 UTC)
Mar 2 2016, 6:28 PM
BGerstle-WMF committed rAPIOS0d551617f503: remove feed filtering tweak, update w/ new titles (authored by BGerstle-WMF).
remove feed filtering tweak, update w/ new titles
Mar 2 2016, 6:28 PM
BGerstle-WMF committed rAPIOSa0a76c00eb72: raise pageview data availability threshold to 09:00 (authored by BGerstle-WMF).
raise pageview data availability threshold to 09:00
Mar 2 2016, 6:25 PM
BGerstle-WMF committed rAPIOS80f8be962cc9: remove feed filtering tweak, update w/ new titles (authored by BGerstle-WMF).
remove feed filtering tweak, update w/ new titles
Mar 2 2016, 6:25 PM
BGerstle-WMF added a comment to T124716: EPIC: Add Top read articles to the app.

Also, strangely fitting how that title stays at the top of the list... Damn robots

Mar 2 2016, 6:09 PM · iOS-app-feature-TopRead, Epic, Wikipedia-iOS-App-Backlog, Category, iOS-app-v5-production
BGerstle-WMF added a comment to T124716: EPIC: Add Top read articles to the app.

Aww I actually clicked on that one :-(

Mar 2 2016, 6:08 PM · iOS-app-feature-TopRead, Epic, Wikipedia-iOS-App-Backlog, Category, iOS-app-v5-production