Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (207 w, 2 d)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Thu, Jun 23

BPirkle updated the task description for T299735: Pageviews integration testing.
Thu, Jun 23, 11:03 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle added a subtask for T288160: Development and test environment for AQS: T311190: Establish testing procedure for Druid-based endpoints.
Thu, Jun 23, 10:52 PM · User-Eevans
BPirkle added a parent task for T311190: Establish testing procedure for Druid-based endpoints: T288160: Development and test environment for AQS.
Thu, Jun 23, 10:52 PM · Analytics, API Platform
BPirkle renamed T288160: Development and test environment for AQS from Develepment and test environment for AQS to Development and test environment for AQS.
Thu, Jun 23, 10:51 PM · User-Eevans
BPirkle moved T311190: Establish testing procedure for Druid-based endpoints from Backlog to Work In Progress on the API Platform board.
Thu, Jun 23, 1:24 AM · Analytics, API Platform
BPirkle triaged T311190: Establish testing procedure for Druid-based endpoints as Medium priority.
Thu, Jun 23, 1:23 AM · Analytics, API Platform
BPirkle created T311190: Establish testing procedure for Druid-based endpoints.
Thu, Jun 23, 1:22 AM · Analytics, API Platform
BPirkle moved T311187: OAuth grant type validation/display improvements from Ready/Groomed to Backlog on the API Platform board.
Thu, Jun 23, 1:13 AM · API Platform, MediaWiki-extensions-OAuth
BPirkle moved T311187: OAuth grant type validation/display improvements from Backlog to Ready/Groomed on the API Platform board.
Thu, Jun 23, 1:13 AM · API Platform, MediaWiki-extensions-OAuth
BPirkle closed T297888: OAuth v2 client request form ignores default grant type values as Resolved.
Thu, Jun 23, 1:13 AM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), API Platform, MediaWiki-extensions-OAuth
BPirkle created T311187: OAuth grant type validation/display improvements.
Thu, Jun 23, 1:11 AM · API Platform, MediaWiki-extensions-OAuth
BPirkle closed T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL as Resolved.
Thu, Jun 23, 1:07 AM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), API Platform, Platform Team Workboards (Clinic Duty Team), Documentation, MediaWiki-extensions-OAuth
BPirkle closed T300570: Split out OAuth v1 and v2 forms as Resolved.
Thu, Jun 23, 1:06 AM · MediaWiki-extensions-OAuth, API Platform
BPirkle closed T305043: Provide CSRF-checking logic in the REST API framework as Resolved.
Thu, Jun 23, 1:05 AM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Campaign-Tools, Campaign-Registration, API Platform, Platform Engineering, MediaWiki-REST-API
BPirkle closed T288127: Design the Example Node API, a subtask of T284325: Example Node Prototype API, as Resolved.
Thu, Jun 23, 1:04 AM · Epic, API Platform (Product Roadmap)
BPirkle closed T288127: Design the Example Node API as Resolved.
Thu, Jun 23, 1:04 AM · API Platform
BPirkle closed T290506: Add tests for initial endpoint, a subtask of T288133: Create endpoint, as Resolved.
Thu, Jun 23, 1:02 AM · API Platform
BPirkle closed T290506: Add tests for initial endpoint as Resolved.
Thu, Jun 23, 1:02 AM · Patch-For-Review, API Platform
BPirkle closed T288133: Create endpoint, a subtask of T284325: Example Node Prototype API, as Resolved.
Thu, Jun 23, 1:02 AM · Epic, API Platform (Product Roadmap)
BPirkle closed T288133: Create endpoint as Resolved.
Thu, Jun 23, 1:02 AM · API Platform
BPirkle closed T290503: Add initial endpoint to spec.yaml, a subtask of T288133: Create endpoint, as Resolved.
Thu, Jun 23, 1:01 AM · API Platform
BPirkle closed T290503: Add initial endpoint to spec.yaml as Resolved.
Thu, Jun 23, 1:01 AM · API Platform
BPirkle closed T293821: Create local command to generate API description as Resolved.
Thu, Jun 23, 1:00 AM · API Platform
BPirkle closed T293821: Create local command to generate API description, a subtask of T284506: Automate API Reference Documentation (Node APIs), as Resolved.
Thu, Jun 23, 1:00 AM · API Platform (Product Roadmap), Epic
BPirkle closed T290505: Create minimal "hello world" endpoint implementation, a subtask of T288133: Create endpoint, as Resolved.
Thu, Jun 23, 12:59 AM · API Platform
BPirkle closed T290505: Create minimal "hello world" endpoint implementation as Resolved.
Thu, Jun 23, 12:59 AM · API Platform
BPirkle closed T284329: [SPIKE] Investigate potential solutions for canonical service catalog as Resolved.

Closing this, as we selected Backstage and completed a proof-of-concept implementation, including mirroring on API Portal. If this decision were to be reconsidered before officially releasing the catalog, that should occur under a separate task.

Thu, Jun 23, 12:57 AM · API Platform
BPirkle closed T284329: [SPIKE] Investigate potential solutions for canonical service catalog, a subtask of T285008: View API Inventory, as Resolved.
Thu, Jun 23, 12:57 AM · Epic, API Platform (Product Roadmap)
BPirkle closed T303825: Path-to-Production Image Suggestions API as Resolved.

Closing this, as there seems to be no further need for API Platform involvement. Feel free to reopen if we are needed.

Thu, Jun 23, 12:52 AM · API Platform

Wed, Jun 15

BPirkle moved T264516: Documentation does not mention that OAuth2 does NOT support "use as prefix" option for callback URL from Ready/Groomed to Sign-off on the API Platform board.
Wed, Jun 15, 1:09 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), API Platform, Platform Team Workboards (Clinic Duty Team), Documentation, MediaWiki-extensions-OAuth
BPirkle moved T300570: Split out OAuth v1 and v2 forms from QA/Review to Sign-off on the API Platform board.
Wed, Jun 15, 1:07 PM · MediaWiki-extensions-OAuth, API Platform

Thu, Jun 9

BPirkle added a comment to T288301: AQS 2.0: Implement wikistats 2 endpoints.

@JAllemandou , we're finally getting ready to do actual work on this endpoint and could use some advice, specifically on best practices for testing.

Thu, Jun 9, 5:32 PM · Data-Engineering, User-Eevans, Platform Engineering Roadmap

Tue, Jun 7

BPirkle moved T264669: Move VE API from RESTBase into core. from Ready/Groomed to Work In Progress on the API Platform board.
Tue, Jun 7, 1:26 PM · Patch-For-Review, Epic, Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
BPirkle moved T288296: AQS 2.0: Implement pageviews endpoints from Work In Progress to QA/Review on the API Platform board.
Tue, Jun 7, 1:12 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle moved T288298: AQS 2.0: Implement the unique devices endpoints from Work In Progress to QA/Review on the API Platform board.
Tue, Jun 7, 1:11 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle closed T309388: Cannot send CSRF token in the request body if using HTTP DELETE, a subtask of T305697: Add registration header to public event page, as Resolved.
Tue, Jun 7, 1:01 PM · Patch-For-Review, Campaign-Tools (Campaign-Tools-Sprint-15), CampaignEvents, Campaign-Registration
BPirkle closed T309388: Cannot send CSRF token in the request body if using HTTP DELETE as Resolved.
Tue, Jun 7, 1:01 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Campaign-Tools, API Platform, Platform Engineering, MediaWiki-REST-API
BPirkle moved T309388: Cannot send CSRF token in the request body if using HTTP DELETE from Backlog to Done on the API Platform board.
Tue, Jun 7, 1:01 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Campaign-Tools, API Platform, Platform Engineering, MediaWiki-REST-API

Thu, Jun 2

BPirkle added a comment to T309388: Cannot send CSRF token in the request body if using HTTP DELETE.

To be clear, the patch I just uploaded ONLY adds tests for the existing functionality, to establish a baseline. After tests are merged, I'll make the requested change in a separate patch. That way in the unlikely event that the change has to be rolled back, we don't lose the tests. And it is also a bit clearer looking back at git history months from now exactly what was done and why.

Thu, Jun 2, 12:32 AM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Campaign-Tools, API Platform, Platform Engineering, MediaWiki-REST-API

Wed, Jun 1

BPirkle claimed T309388: Cannot send CSRF token in the request body if using HTTP DELETE.

I started to implement this, decided to do TDD by writing the test first, looked for the unit test for the Validator class, and didn't find one. Validator is largely a wrapper, so maybe we originally didn't think it necessary. But it seems like the behavior of confirming which methods must or must not have a body is worth testing, especially as we've found it necessary to make changes to that behavior. So I'll add that unit test as part of this task.

Wed, Jun 1, 3:07 AM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Campaign-Tools, API Platform, Platform Engineering, MediaWiki-REST-API

Mon, May 30

BPirkle updated subscribers of T309388: Cannot send CSRF token in the request body if using HTTP DELETE.

For prior WMF usages of combining DELETE and tokens, I found this in RESTBase. I don't fully understand RESTBase, but at a glance this seems to at least not prohibit that combination.

Mon, May 30, 4:30 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Campaign-Tools, API Platform, Platform Engineering, MediaWiki-REST-API

Fri, May 27

BPirkle closed T304735: AQS 2.0 local tests fail when mwcli is running as Resolved.

This was done here

Fri, May 27, 7:34 PM · API Platform, Analytics

Thu, May 26

BPirkle moved T288298: AQS 2.0: Implement the unique devices endpoints from Backlog to Work In Progress on the API Platform board.
Thu, May 26, 3:45 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle moved T297888: OAuth v2 client request form ignores default grant type values from Ready/Groomed to QA/Review on the API Platform board.
Thu, May 26, 3:23 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), API Platform, MediaWiki-extensions-OAuth
BPirkle moved T308588: Do not cache fast parsoid output in ParserCache (exploration) from Backlog to Investigate on the API Platform board.
Thu, May 26, 3:17 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Editing-team (Tracking), Platform Team Workboards (MW Expedition), User-xSavitar, API Platform, Code-Health-Objective, VisualEditor, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
BPirkle moved T308152: Action API siteinfo should return canonical name for namespace 0 from Backlog to Sign-off on the API Platform board.
Thu, May 26, 3:14 PM · API Platform, Wikimedia Enterprise, Foundational Technology Requests

May 25 2022

BPirkle moved T305043: Provide CSRF-checking logic in the REST API framework from Investigate to Sign-off on the API Platform board.
May 25 2022, 8:03 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Campaign-Tools, Campaign-Registration, API Platform, Platform Engineering, MediaWiki-REST-API

May 19 2022

BPirkle added a comment to T308152: Action API siteinfo should return canonical name for namespace 0.

Do you know if it is called something other than "Main" across language projects (beyond the language translation) - is that queryable / accessible somewhere in documentation?

May 19 2022, 3:49 AM · API Platform, Wikimedia Enterprise, Foundational Technology Requests

May 18 2022

BPirkle added a comment to T308152: Action API siteinfo should return canonical name for namespace 0.

The canonical field is explicitly excluded if it is falsey.

May 18 2022, 1:41 PM · API Platform, Wikimedia Enterprise, Foundational Technology Requests
BPirkle added a comment to T308152: Action API siteinfo should return canonical name for namespace 0.

I've confirmed that my comment above is accurate.

May 18 2022, 12:15 AM · API Platform, Wikimedia Enterprise, Foundational Technology Requests

May 17 2022

BPirkle added a comment to T308152: Action API siteinfo should return canonical name for namespace 0.

tl;dr: I think that's a feature, not a bug.

May 17 2022, 10:47 PM · API Platform, Wikimedia Enterprise, Foundational Technology Requests

May 4 2022

BPirkle added a comment to T305043: Provide CSRF-checking logic in the REST API framework.

I've posted a speculative work-in-progress change, mostly for discussion.

May 4 2022, 4:32 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Campaign-Tools, Campaign-Registration, API Platform, Platform Engineering, MediaWiki-REST-API

Apr 28 2022

BPirkle claimed T300570: Split out OAuth v1 and v2 forms .

Switching roles - chatted with Thomas outside Phab. I'll finish the coding work and Thomas will review.

Apr 28 2022, 4:05 PM · MediaWiki-extensions-OAuth, API Platform

Apr 27 2022

BPirkle updated subscribers of T305043: Provide CSRF-checking logic in the REST API framework.

I'm planning to look at it next week (the week that starts on May 2nd).

Apr 27 2022, 8:19 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Campaign-Tools, Campaign-Registration, API Platform, Platform Engineering, MediaWiki-REST-API

Apr 26 2022

BPirkle added a comment to T305506: Promote or remove experimental MW core API endpoints.

Status update: patch to remove the contributions endpoint remains in-flight, but we have not conclusively determined whether to land that as-is. Other options on the table include moving the endpoints to an extension. or promoting them to "official".

Apr 26 2022, 4:28 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle moved T264671: Deprecate and remove MCS endpoints from RESTBase from QA/Review to Ready/Groomed on the API Platform board.

The status change immediately above should have been applied to T305506: Promote or remove experimental MW core API endpoints, not this ticket. Sorry for any miscommunication or distraction.

Apr 26 2022, 4:26 PM · API Platform, Code-Health-Objective, Mobile-Content-Service, Platform Engineering Roadmap, Product-Infrastructure-Team-Backlog, Platform Engineering Roadmap Decision Making
BPirkle moved T299735: Pageviews integration testing from Backlog to Work In Progress on the API Platform board.
Apr 26 2022, 1:04 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle moved T305502: Audit/review pageviews test cases from Backlog to Work In Progress on the API Platform board.
Apr 26 2022, 1:04 PM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap
BPirkle added a project to T305502: Audit/review pageviews test cases: API Platform.
Apr 26 2022, 1:04 PM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap
BPirkle added a project to T299735: Pageviews integration testing: API Platform.
Apr 26 2022, 1:04 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap

Apr 21 2022

BPirkle added a comment to T299735: Pageviews integration testing.

I dug a bit into the existing production code. The "www" stripping was added as its own commit with this comment in the code:

Apr 21 2022, 9:53 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle added a comment to T299735: Pageviews integration testing.

Yeah, I thought it was a little unusual as well. I tested the existing production service using this url and it felt weird to even type.

Apr 21 2022, 8:39 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap
BPirkle added a comment to T305506: Promote or remove experimental MW core API endpoints.

Thank you! I'm not sure yet what their disposition will end up being, but it is good to know that we have all our options available without stepping on anyone's toes.

Apr 21 2022, 6:08 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle updated the task description for T299735: Pageviews integration testing.
Apr 21 2022, 2:19 AM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap

Apr 20 2022

BPirkle added a comment to T305502: Audit/review pageviews test cases.

This is great. Should we turn this into a checklist of completion criteria in T299735: Pageviews integration testing?

Apr 20 2022, 5:39 PM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap
BPirkle updated the task description for T299735: Pageviews integration testing.
Apr 20 2022, 5:35 PM · API Platform, Data-Engineering, User-Eevans, Platform Engineering Roadmap

Apr 19 2022

BPirkle added a comment to T304735: AQS 2.0 local tests fail when mwcli is running.

FWIW, here are the commands I executed to run tests, in order:

Apr 19 2022, 6:05 PM · API Platform, Analytics
BPirkle updated subscribers of T305502: Audit/review pageviews test cases.
Apr 19 2022, 12:58 AM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap
BPirkle added a comment to T305502: Audit/review pageviews test cases.

Comparing existing production "per-project" tests to the new ones in development, it looks to me like the new tests add some test cases not previously covered (good) but miss some others (bad).

Apr 19 2022, 12:58 AM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap

Apr 18 2022

BPirkle updated subscribers of T305506: Promote or remove experimental MW core API endpoints.

We are considering whether to remove or promote the experimental contributions endpoints.

Apr 18 2022, 6:20 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform

Apr 14 2022

BPirkle moved T304735: AQS 2.0 local tests fail when mwcli is running from Backlog to Ready/Groomed on the API Platform board.
Apr 14 2022, 4:12 PM · API Platform, Analytics
BPirkle moved T305506: Promote or remove experimental MW core API endpoints from Ready/Groomed to Work In Progress on the API Platform board.
Apr 14 2022, 4:01 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform

Apr 13 2022

BPirkle updated subscribers of T305506: Promote or remove experimental MW core API endpoints.
Apr 13 2022, 3:04 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle added a comment to T305506: Promote or remove experimental MW core API endpoints.

I looked a bit deeper, and (as often happens) things got murky.

Apr 13 2022, 2:56 AM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle closed T283552: Invalid client secrets in API Portal, a subtask of T284344: Streamline API Portal Onboarding Experience, as Resolved.
Apr 13 2022, 2:12 AM · Epic, API Platform (Product Roadmap)
BPirkle closed T283552: Invalid client secrets in API Portal, a subtask of T301375: API Platform Clinic Duty, as Resolved.
Apr 13 2022, 2:12 AM · Epic, API Platform (Product Roadmap)
BPirkle closed T283552: Invalid client secrets in API Portal as Resolved.
Apr 13 2022, 2:12 AM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), API Platform, MediaWiki-extensions-WikimediaApiPortalOAuth, API-Portal

Apr 12 2022

BPirkle added a comment to T305502: Audit/review pageviews test cases.

The AQS endpoints are read-only. The POSTs you're seeing are a RESTBase'ism. What we're doing instead, is using a test environment that bootstraps a Cassandra instance with some test data, historical results queried directly from the production service, so we get apples-to-apples when testing against it.

Apr 12 2022, 1:02 AM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap

Apr 11 2022

BPirkle added a comment to T305506: Promote or remove experimental MW core API endpoints.

It seems that most of those hits from my overly-broad query were normal hits to pages that happened to have the string "coredev" in the name, rather than API calls. Here are actual REST API coredev hits from March:

Apr 11 2022, 7:32 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle added a comment to T305506: Promote or remove experimental MW core API endpoints.

Tried a broad query against analytics data, in hopes that none of these were getting any traffic at all:

Apr 11 2022, 5:06 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform

Apr 7 2022

BPirkle added a comment to T305502: Audit/review pageviews test cases.

I did an initial inventory of the current production service test file (test/features/pageviews/pageviews.js) before looking at the new service.

Apr 7 2022, 3:22 AM · API Platform, Data-Engineering-Radar, Platform Engineering Roadmap

Apr 5 2022

BPirkle moved T305506: Promote or remove experimental MW core API endpoints from Backlog to Ready/Groomed on the API Platform board.
Apr 5 2022, 8:33 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle triaged T305506: Promote or remove experimental MW core API endpoints as Medium priority.
Apr 5 2022, 8:28 PM · MW-1.39-notes (1.39.0-wmf.8; 2022-04-18), Patch-For-Review, Platform Team Initiatives (MW REST API in PHP), MediaWiki-REST-API, API Platform
BPirkle moved T302799: Post-creation work for shnwikivoyage from Backlog to Work In Progress on the API Platform board.
Apr 5 2022, 7:34 PM · Wikidata-Campsite, Wikidata, wdwb-tech, API Platform, Platform Engineering, Wiki-Setup
BPirkle moved T303762: Post-creation work for guwwiki from Backlog to Work In Progress on the API Platform board.
Apr 5 2022, 7:34 PM · wdwb-tech, Wikidata-Campsite, Wikidata, API Platform, Platform Engineering, Wiki-Setup
BPirkle added a project to T302799: Post-creation work for shnwikivoyage: API Platform.
Apr 5 2022, 7:33 PM · Wikidata-Campsite, Wikidata, wdwb-tech, API Platform, Platform Engineering, Wiki-Setup
BPirkle added a project to T303762: Post-creation work for guwwiki: API Platform.
Apr 5 2022, 7:33 PM · wdwb-tech, Wikidata-Campsite, Wikidata, API Platform, Platform Engineering, Wiki-Setup

Mar 31 2022

BPirkle added a comment to T304735: AQS 2.0 local tests fail when mwcli is running.

If we choose to tweak the README, also consider making the "Wait until you see the 'Startup complete' log message, then in another terminal, bootstrap the database schema and sample data", in the "Dockerized Cassandra test environment" section, more explicit that you must leave the command for starting the test environment running in the foreground in the terminal you start it in. The README does say "in another terminal", but it is a little easy to misunderstand what you're supposed to do.

Mar 31 2022, 2:20 PM · API Platform, Analytics

Mar 30 2022

BPirkle added a project to T305043: Provide CSRF-checking logic in the REST API framework: API Platform.
Mar 30 2022, 4:16 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Campaign-Tools, Campaign-Registration, API Platform, Platform Engineering, MediaWiki-REST-API
BPirkle added a comment to T305043: Provide CSRF-checking logic in the REST API framework.

Yeah, the current implementation doesn't do much around this. It pretty much just checks SessionProvider::safeAgainstCsrf(), and only in EditHandler. You're clearly aware of that, because you used it in

Mar 30 2022, 4:15 PM · MW-1.39-notes (1.39.0-wmf.14; 2022-05-30), Campaign-Tools, Campaign-Registration, API Platform, Platform Engineering, MediaWiki-REST-API

Mar 25 2022

BPirkle triaged T304735: AQS 2.0 local tests fail when mwcli is running as Low priority.
Mar 25 2022, 7:01 PM · API Platform, Analytics
BPirkle created T304735: AQS 2.0 local tests fail when mwcli is running.
Mar 25 2022, 7:00 PM · API Platform, Analytics

Mar 23 2022

BPirkle updated subscribers of T303825: Path-to-Production Image Suggestions API .

@CBogen, my impression was:

Mar 23 2022, 5:22 PM · API Platform

Mar 17 2022

BPirkle added a comment to T303822: Evaluate API Platform Tasks Related to RestBase Sunset.

Summary: there seem to be both straightforward and involved tasks that the API Platform could reasonably help with.

Mar 17 2022, 6:13 PM · API Platform
BPirkle added a comment to T288981: Clarify use of redirect_uri in portal key form.

Related: T266355: Clarify validation for redirect URI

Mar 17 2022, 4:14 PM · API Platform, API-Portal
BPirkle moved T302349: API Portal default skin doesn't apply to new user from Backlog to Ready/Groomed on the API Platform board.
Mar 17 2022, 4:06 PM · API Platform, API-Portal

Mar 12 2022

BPirkle added a comment to T294468: [SPIKE] Decide on best approach for API access to Cassandra.

When the user is looking at an article that we know has image recommendations, we do a query to the image suggestions API using the path /image-suggestions/v0/{wiki}/{lang}/pages?source=ima&id={pageID}. From T294468#7748996 it sounds like /public/image_suggestions/:wiki/:page_id is a drop in replacement and that ima (image matching algorithm) is the default. Is that correct? @nnikkhoui or @BPirkle based on your work with mediawiki/services/image-suggestion-api does that sound right?

Mar 12 2022, 4:41 AM · Spike, Generated Data Platform

Mar 7 2022

BPirkle closed T297317: SearchHandler: PHP Warning: array_merge(): Argument #2 is not an array as Resolved.

Closed, as this appears to be fixed. We can reopen if necessary.

Mar 7 2022, 7:16 PM · MediaWiki-REST-API, API Platform, Wikimedia-production-error
BPirkle closed T297317: SearchHandler: PHP Warning: array_merge(): Argument #2 is not an array, a subtask of T301375: API Platform Clinic Duty, as Resolved.
Mar 7 2022, 7:16 PM · Epic, API Platform (Product Roadmap)

Feb 4 2022

BPirkle added a comment to T283552: Invalid client secrets in API Portal.

Looks like this was already fixed once here:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/633551

Feb 4 2022, 6:09 PM · MW-1.38-notes (1.38.0-wmf.25; 2022-03-07), API Platform, MediaWiki-extensions-WikimediaApiPortalOAuth, API-Portal