Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (68 w, 7 h)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Yesterday

BPirkle added a comment to T234941: Curator gets minor edit count.

In that case - can we sneak this in without deprecation and just do it?

Wed, Oct 23, 8:38 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle updated the task description for T235587: Add minor edit count to REST API history count endpoint.
Wed, Oct 23, 8:27 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234941: Curator gets minor edit count.

If I understand T232485: RFC: Core REST API namespace and version correctly, the deprecation process for the older parameter values is trivial from a coding standpoint. Shall we hot-add a task for deprecating the old parameters and adding the new ones to the current sprint? That way, as few callers as possible (ideally, none) ever use the old values.

Wed, Oct 23, 8:23 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle moved T235572: Compose query for minor edit count from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Wed, Oct 23, 4:29 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235657: Compose query for minor edit history from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Wed, Oct 23, 4:29 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235657: Compose query for minor edit history.
SELECT  rev_id,rev_page,rev_timestamp,rev_minor_edit,rev_deleted,rev_len,rev_parent_id,rev_sha1,
  comment_rev_comment.comment_text AS `rev_comment_text`,
  comment_rev_comment.comment_data AS `rev_comment_data`,
  comment_rev_comment.comment_id AS `rev_comment_cid`,
  actor_rev_user.actor_user AS `rev_user`,
  actor_rev_user.actor_name AS `rev_user_text`,
  temp_rev_user.revactor_actor AS `rev_actor`
FROM `revision`
JOIN `revision_comment_temp` `temp_rev_comment`
  ON ((temp_rev_comment.revcomment_rev = rev_id))
JOIN `comment` `comment_rev_comment`
  ON ((comment_rev_comment.comment_id = temp_rev_comment.revcomment_comment_id))
JOIN `revision_actor_temp` `temp_rev_user`
  ON ((temp_rev_user.revactor_rev = rev_id AND revactor_page = rev_page))
JOIN `actor` `actor_rev_user`
  ON ((actor_rev_user.actor_id = temp_rev_user.revactor_actor))
WHERE rev_page = ?
  AND (rev_minor_edit != 0)
ORDER BY rev_timestamp DESC, rev_id DESC
LIMIT 21;
Wed, Oct 23, 4:03 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T235660: Add minor edit filter type to REST API history endpoint.
Wed, Oct 23, 3:11 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235660: Add minor edit filter type to REST API history endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Wed, Oct 23, 3:11 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T235657: Compose query for minor edit history.
Wed, Oct 23, 3:11 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235657: Compose query for minor edit history from Ready to Doing on the Core Platform Team Workboards (Green) board.
Wed, Oct 23, 3:11 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T235587: Add minor edit count to REST API history count endpoint.
Wed, Oct 23, 3:10 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235587: Add minor edit count to REST API history count endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Wed, Oct 23, 3:10 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234941: Curator gets minor edit count.

Looking at this now in engineering task T235587: Add minor edit count to REST API history count endpoint, all the other count types explicitly include "edits":

Wed, Oct 23, 3:01 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle updated the task description for T235587: Add minor edit count to REST API history count endpoint.
Wed, Oct 23, 2:58 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Tue, Oct 22

BPirkle renamed T235666: REST: Add 'from' and 'to' parameters to historycount endpoint. from Implement GET /revision/{from}/intermediatecount/{to} to REST: Add 'from' and 'to' parameters to historycount endpoint..
Tue, Oct 22, 10:55 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

The most similar code I found in Action API was this bit in ApiQueryUserContribs.php:

Tue, Oct 22, 5:00 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.
SELECT  COUNT(*)  FROM `revision`
WHERE rev_page = ? 
AND (rev_minor_edit != 0)  
LIMIT 1;
Tue, Oct 22, 2:59 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Mon, Oct 21

BPirkle claimed T235572: Compose query for minor edit count.
Mon, Oct 21, 9:37 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235572: Compose query for minor edit count from Ready to Doing on the Core Platform Team Workboards (Green) board.
Mon, Oct 21, 9:37 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle closed T235565: Add Core REST API examples to the Example extension as Resolved.
Mon, Oct 21, 8:46 PM · Patch-For-Review, MediaWiki-extensions-Examples, MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Wed, Oct 16

BPirkle added a comment to T233192: Consider splitting rest- messages to a separate file.

The number of these messages is likely to grow, perhaps significantly. Splitting them seems like a good idea.

Wed, Oct 16, 11:01 PM · translatewiki.net, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Green), MediaWiki-Internationalization, MediaWiki-REST-API, I18n
BPirkle closed T235559: Fix error in RESTBagOStuff class comment as Resolved.
Wed, Oct 16, 10:32 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, MW-1.34-release, CPT Initiatives (Session Management Service (CDP2))
BPirkle closed T233963: Add serialization options to RESTBagOStuff as Resolved.
Wed, Oct 16, 10:31 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle created T235666: REST: Add 'from' and 'to' parameters to historycount endpoint..
Wed, Oct 16, 3:45 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235665: Compose query for intermediate revision count.
Wed, Oct 16, 3:41 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235660: Add minor edit filter type to REST API history endpoint.
Wed, Oct 16, 2:29 PM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T235657: Compose query for minor edit history.

For reference, count queries for the existing filter types were created under T231599: Compose New History Queries and implemented under T231597: Implement GET History Filter

Wed, Oct 16, 2:24 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T235572: Compose query for minor edit count.
Wed, Oct 16, 2:21 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235657: Compose query for minor edit history.
Wed, Oct 16, 2:21 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235587: Add minor edit count to REST API history count endpoint.

The existing counts for this endpoint do not have unit tests? Should we add a unit test for the new count (and possibly the existing ones)? Or will we cover that with integration tests?

Wed, Oct 16, 3:15 AM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

What (if anything) do we need to do with the rev_deleted field in this query?

Wed, Oct 16, 3:14 AM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235587: Add minor edit count to REST API history count endpoint.
Wed, Oct 16, 3:07 AM · Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234941: Curator gets minor edit count.

Body: JSON, object with following fields
minor: total number of minor edits

Wed, Oct 16, 3:01 AM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)

Tue, Oct 15

BPirkle moved T235572: Compose query for minor edit count from Backlog to Next Sprint on the Core Platform Team Workboards (Green) board.
Tue, Oct 15, 10:44 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T235572: Compose query for minor edit count.

For reference, count queries for the existing count types were created under T231598: Compose Count Queries and implemented under T231590: Implement GET Edit Count

Tue, Oct 15, 10:44 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235572: Compose query for minor edit count.
Tue, Oct 15, 10:44 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235565: Add Core REST API examples to the Example extension.

It would also be useful to add additional examples, such as how to inject services, use a factory function, etc. Those things would be better done under their own tasks - I mention them here just to bring up the possibility.

Tue, Oct 15, 9:32 PM · Patch-For-Review, MediaWiki-extensions-Examples, MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235565: Add Core REST API examples to the Example extension.
Tue, Oct 15, 9:31 PM · Patch-For-Review, MediaWiki-extensions-Examples, MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle triaged T235559: Fix error in RESTBagOStuff class comment as High priority.
Tue, Oct 15, 8:54 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, MW-1.34-release, CPT Initiatives (Session Management Service (CDP2))
BPirkle created T235559: Fix error in RESTBagOStuff class comment.
Tue, Oct 15, 8:54 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, MW-1.34-release, CPT Initiatives (Session Management Service (CDP2))
BPirkle moved T233963: Add serialization options to RESTBagOStuff from Waiting for Review to Done on the Core Platform Team Workboards (Green) board.
Tue, Oct 15, 3:58 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Sun, Oct 13

BPirkle added a comment to T235375: Parsoid/PHP responds with 404 for titles with slashes and revision.

Several of the new Core REST API endpoints accept titles. We should see if they are similarly affected.

Sun, Oct 13, 6:02 PM · Core Platform Team Workboards (Clinic Duty Team), Parsing-Team, RESTBase, MediaWiki-REST-API, Parsoid-PHP

Fri, Oct 11

BPirkle added a comment to T231590: Implement GET Edit Count.

I like consistency. Any renaming we choose to do would be safe, fast, and would not threaten our deadline.

Fri, Oct 11, 3:40 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle moved T234485: Implement Editors Count Endpoint from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 3:32 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234485: Implement Editors Count Endpoint.

This was done as part of T231590

Fri, Oct 11, 3:32 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T234486: Implement reverted edits count endpoint from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 3:31 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234486: Implement reverted edits count endpoint.

This was done as part of T231590

Fri, Oct 11, 3:31 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T234487: Implement anonymous edit count endpoint from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 3:31 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234487: Implement anonymous edit count endpoint.

This was done as part of T231590

Fri, Oct 11, 3:30 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T234488: Implement bot edit count endpoint from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 3:30 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234488: Implement bot edit count endpoint.

This was done as part of T231590

Fri, Oct 11, 3:30 AM · MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T231588: Implement GET Page Revision from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 3:28 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235146: Improve GET History Filter from Doing to Done on the Core Platform Team Workboards (Green) board.
Fri, Oct 11, 3:28 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Thu, Oct 10

NHarateh_WMF awarded T231590: Implement GET Edit Count a Party Time token.
Thu, Oct 10, 7:37 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle added a comment to T233963: Add serialization options to RESTBagOStuff.

@Reedy, the OATHAuth and WebAuthn patches look like they're generally on the right track to me and unless that approach proves to be unnecessarily painful, I'd recommend continuing that direction.

Thu, Oct 10, 4:50 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle moved T231597: Implement GET History Filter from Doing to Done on the Core Platform Team Workboards (Green) board.
Thu, Oct 10, 4:32 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T231558: Implement GET page history from Doing to Done on the Core Platform Team Workboards (Green) board.
Thu, Oct 10, 4:32 AM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle moved T235146: Improve GET History Filter from Backlog to Doing on the Core Platform Team Workboards (Green) board.
Thu, Oct 10, 4:31 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle created T235146: Improve GET History Filter.
Thu, Oct 10, 4:31 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Wed, Oct 9

BPirkle added a comment to T231580: Implement GET Revision Comparison.

Just speaking for myself, I understand what this task is about conceptually, but I don't know anything about its status or the details of the code. I'm happy to take a closer look if time allows, but I assume my priority is to complete the tasks that I'm the primary coder for.

Wed, Oct 9, 5:17 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Tue, Oct 8

BPirkle added a comment to T231590: Implement GET Edit Count.

@Anomie , discussion arose during our Green Team checking meeting today about 5 endpoints vs 1 endpoint. I know you are tasked with unrelated things right now, but if you have time to give an opinion it would be very helpful.

Tue, Oct 8, 8:00 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Mon, Oct 7

BPirkle added a comment to T231588: Implement GET Page Revision.

So, all slots except "main" go into a slots property that maps the slot name to an object that describes the slot? @daniel any thoughts?

Mon, Oct 7, 3:32 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234779: Removed deprecated "legacy" serialization type from RESTBagOStuff.

Marking this as "Stalled" because it cannot be done until after the 1.34 release.

Mon, Oct 7, 4:58 AM · MW-1.35-release, Core Platform Team Workboards (Green)
BPirkle changed the status of T234779: Removed deprecated "legacy" serialization type from RESTBagOStuff from Open to Stalled.
Mon, Oct 7, 4:58 AM · MW-1.35-release, Core Platform Team Workboards (Green)
BPirkle created T234779: Removed deprecated "legacy" serialization type from RESTBagOStuff.
Mon, Oct 7, 4:57 AM · MW-1.35-release, Core Platform Team Workboards (Green)

Fri, Oct 4

BPirkle triaged T233963: Add serialization options to RESTBagOStuff as High priority.
Fri, Oct 4, 2:43 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle added a project to T233963: Add serialization options to RESTBagOStuff: MW-1.34-release.
Fri, Oct 4, 2:42 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Thu, Oct 3

BPirkle added a comment to T231590: Implement GET Edit Count.

@eprodromou , could you reconsider splitting the task up? Most of the code is the same between these endpoints - they differ only in the query - so I implemented them using a common base class.

Thu, Oct 3, 3:24 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Wed, Oct 2

BPirkle added a comment to T232355: Implement Core REST API routes and handler stubs.

@eprodromou The associated patch was not merged, so we never did. Unless someone had pulled down that unmerged gerrit change and was using it locally or something, but even then the paths were wrong.

Wed, Oct 2, 9:18 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

@BPirkle why don't we just revert RESTBagOStuff to its pre-Kask version, and make the new version KaskBagOStuff? We'd need to change the config for WMF production but otherwise harmless.

Wed, Oct 2, 2:31 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Tue, Oct 1

BPirkle added a comment to T231597: Implement GET History Filter.

Hey @BPirkle. Doesn't T231599 define this already? Looks like undo and rollback, am I correct?

Tue, Oct 1, 10:42 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T231590: Implement GET Edit Count.
Tue, Oct 1, 5:17 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle moved T231590: Implement GET Edit Count from Ready to Doing on the Core Platform Team Workboards (Green) board.
Tue, Oct 1, 5:17 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle moved T233963: Add serialization options to RESTBagOStuff from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Tue, Oct 1, 5:16 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle added a comment to T231597: Implement GET History Filter.

tl;dr: @eprodromou , what change tags are considered "reverted"? Just mw-undo and mw-rollback, or others too?

Tue, Oct 1, 1:45 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Mon, Sep 30

BPirkle added a comment to T231597: Implement GET History Filter.

Thank you @Anomie .

Mon, Sep 30, 9:32 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T231597: Implement GET History Filter.

In T231599: Compose New History Queries @Anomie (thanks for the queries!) said this:

Mon, Sep 30, 4:07 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Thu, Sep 26

BPirkle moved T232355: Implement Core REST API routes and handler stubs from Doing to Blocked on the Core Platform Team Workboards (Green) board.
Thu, Sep 26, 4:06 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T233963: Add serialization options to RESTBagOStuff from Ready to Doing on the Core Platform Team Workboards (Green) board.
Thu, Sep 26, 4:06 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle moved T233963: Add serialization options to RESTBagOStuff from Backlog to Ready on the Core Platform Team Workboards (Green) board.
Thu, Sep 26, 4:05 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

I've created T233963: Add serialization options to RESTBagOStuff and added people who are subscribed here as subscribers to that new task.

Thu, Sep 26, 4:04 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle created T233963: Add serialization options to RESTBagOStuff.
Thu, Sep 26, 4:03 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle updated subscribers of T233537: Document and communicate potentially breaking session storage serialization change.

So ... I just checked an email from @CCicalese_WMF from about a week ago, and the 1.34 release branch is scheduled to be created on Sept. 29, three days from now. If I need to make changes to RESTBagOStuff before the release, time is growing short.

Thu, Sep 26, 3:02 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Wed, Sep 25

BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

For any legacy cases, if they exist

Wed, Sep 25, 2:59 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Tue, Sep 24

BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

PHP sessions normally support storing PHP-serializable objects. Breaking that assumption, but only when RESTBagOStuff happens to be being used, seems liable to become a recurring issue which we could easily avoid.

Tue, Sep 24, 11:02 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle moved T231597: Implement GET History Filter from Ready to Doing on the Core Platform Team Workboards (Green) board.
Tue, Sep 24, 1:28 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T231597: Implement GET History Filter.
Tue, Sep 24, 1:27 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Sep 23 2019

BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

This beggs the question, though. Why this solution rather than implementing proper PHP serialization in RestBagOStuff so $_SESSION and corresponding Session functionality works like everyone else expects it to?
In terms of T161647, this would fall under the "Any edge cases that require use of serialize or unserialize complicated classes" clause.

Sep 23 2019, 11:31 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Sep 22 2019

BPirkle moved T233537: Document and communicate potentially breaking session storage serialization change from Backlog to Ready on the Core Platform Team Workboards (Green) board.
Sep 22 2019, 8:00 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

Was this actually announced anywhere that I probably should've seen it?

Sep 22 2019, 7:59 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle created T233537: Document and communicate potentially breaking session storage serialization change.
Sep 22 2019, 7:56 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Sep 20 2019

BPirkle added a comment to T233345: Move iOS History API endpoints to an extension.

The first step is picking a name for the extension. The task title says "iOS History API", so I could just make a name out of that. But first, do we:

  1. foresee non-iOS endpoints being added to this extension?
  2. foresee non-History endpoints being added to this extension?
Sep 20 2019, 4:17 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

This is clearly a breaking change, no argument there. Fortunately, it is a configuration-dependent one and we've only affected ourselves, and in a limited fashion. I'm glad we were as conservative in rolling it out as we were, and I'm suddenly thankful for the the Kask performance investigation (now complete) that delayed further rollout.

Sep 20 2019, 12:07 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle added a comment to T231558: Implement GET page history.

I assume that revisions in the response should normally be ordered from newest to oldest (which facilitates looping through them via the paging pseudocode above, which starts at the newest revision and progresses through older revisions). But if newer_than is specified, they should be ordered oldest to newest (which facilitates the inverse direction of looping starting at an older revision and progressing through newer revisions. Am I correct in that assumption?

Sep 20 2019, 1:53 AM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Sep 17 2019

Physikerwelt awarded T137926: Support running MediaWiki without 'curl' PHP extension a Like token.
Sep 17 2019, 6:42 PM · Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), TechCom-RFC (TechCom-Approved), MediaWiki-Installer
BPirkle claimed T231558: Implement GET page history.
Sep 17 2019, 4:13 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle moved T231558: Implement GET page history from Ready to Doing on the Core Platform Team Workboards (Green) board.
Sep 17 2019, 4:12 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle added a comment to T232948: Bundle Math extension with MediaWiki.

Also consider T137926 (Support running MediaWiki without 'curl' PHP extension)

Sep 17 2019, 2:42 PM · MW-1.35-release, Math

Sep 13 2019

BPirkle moved T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision? from Waiting for Review to Done on the Core Platform Team Workboards (Green) board.
Sep 13 2019, 1:42 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API

Sep 12 2019

BPirkle added a comment to T231588: Implement GET Page Revision.

@eprodromou is there documentation for what should be returned in various error conditions? The most obvious and likely in this case would be if the revision could not be found, but I'm curious if we have any general conventions about error return values for the REST API.

Sep 12 2019, 4:35 PM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)