Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (81 w, 2 d)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Thu, Jan 23

BPirkle moved T236170: Implement get media file endpoint from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Thu, Jan 23, 4:38 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Wed, Jan 22

BPirkle updated the task description for T238374: Client Developer uses client-side cache.
Wed, Jan 22, 10:53 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Mon, Jan 13

BPirkle added a comment to T230845: Reader gets media links.

Thanks for the replies, @eprodromou. Changes made and new patchset uploaded under engineering task T236169. I still need to sync changes with T236170 (file description endpoint) and resolve some cut-and-paste-code, but that's mostly just housekeeping.

Mon, Jan 13, 4:10 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Thu, Jan 9

BPirkle added a comment to T230848: Reader gets file description.
  • make the following fields available only on "original" (or alternatively, at the top level): size, duration, mediatype

Can you just put "null" for information we don't have? It's unfortunate we don't get file size or mediatype for thumbnails, but that seems like something we could fix in the future. I'd like to keep the duration on all file representations even if the value is inapplicable or we don't know it.
I'll open tickets for this stuff.

Thu, Jan 9, 4:31 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Wed, Jan 8

BPirkle added a comment to T230845: Reader gets media links.
  • we do not need a limit on the underlying query that retrieves images for a page, do we? (if we did, we might need pagination)

This is a good question. My understanding is that images on a page are typically O(10) and at the limits O(100). I think that doesn't require segmenting the list. Can we verify this with a database query?

Wed, Jan 8, 7:23 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Dec 19 2019

BPirkle added a comment to T230848: Reader gets file description.

Just found that I can get a thumbnail size from options, in the same way I get the default size. I can use that instead of the somewhat arbitrary 512 from the task description. That'll make it overridable in settings, and more likely to correspond to an image already existing in the filesystem. On my local wiki this size is 320x240, so seems appropriate.

Dec 19 2019, 9:53 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T230848: Reader gets file description.

Summary of my local testing:

Dec 19 2019, 4:38 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Dec 5 2019

BPirkle added a comment to T230842: Contributor creates a page.

Given that EditPage is undergoing massive refactoring, are we not going to be writing code to immediately through it away soon?

Dec 5 2019, 11:21 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T230842: Contributor creates a page.

Implementation note: the ApiEditPage class handles both edits and creates in a single function: https://gerrit.wikimedia.org/g/mediawiki/core/+/1f77235c14ab05ceb46f9a6ab64b718f0560a95a/includes/api/ApiEditPage.php#36

Dec 5 2019, 9:36 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T230842: Contributor creates a page.

Does the "license" field need updated to match recent changes to T229663: Contributor gets page source? If so, presumably T230843: Contributor updates a page would also need a similar update.

Dec 5 2019, 4:53 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)

Dec 4 2019

BPirkle added a comment to T234377: Reader reads a page online.

Two more thoughts:

Dec 4 2019, 5:05 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234377: Reader reads a page online.

Reversible HTML for the page as generated by Parsoid. No skin or navigation.

Dec 4 2019, 4:06 PM · Core Platform Team Workboards (Green), Story, CPT Initiatives (Core REST API in PHP)

Dec 3 2019

BPirkle added a comment to T230848: Reader gets file description.

Invalid file extension found in the path info or query string.

The fix for this is https://gerrit.wikimedia.org/r/c/mediawiki/core/+/552679 . I added you as a reviewer.

Dec 3 2019, 9:13 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T238376: System Administrator uses object cache to lower database traffic.
Dec 3 2019, 5:28 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T238374: Client Developer uses client-side cache.
Dec 3 2019, 5:27 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle moved T236172: Implement get language links endpoint from Waiting for Review to Done on the Core Platform Team Workboards (Green) board.
Dec 3 2019, 5:03 PM · Patch-For-Review, CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Nov 27 2019

BPirkle added a comment to T230848: Reader gets file description.

tl;dr: let's add "mustrender" and "badfile" (or snakecased version of those names as you prefer) to the response data.

Nov 27 2019, 9:14 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 22 2019

BPirkle added a comment to T230845: Reader gets media links.

Questions for @eprodromou :

Nov 22 2019, 2:51 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T230848: Reader gets file description.

Questions for @eprodromou :

Nov 22 2019, 2:42 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 21 2019

BPirkle added a comment to T230848: Reader gets file description.

@eprodromou , we talked in the check-in meeting regarding the "thumbnail" naming in the code Tim posted, and a concern that we didn't want the preferred image to be a small thumbnail. Local testing of uploading a 1000x667 image resulted in the API returning a preferred image size of 800x534, which seems reasonable to me.

Nov 21 2019, 5:31 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 20 2019

BPirkle added a comment to T237854: Client Developer knows semantic version of API.

@Pchelolo, I agree with most or all of your concerns, but I think I'm less opposed than you are to the proposal, as it seems to me one of the less bad ways to deal with the problem. Here are my thoughts in more detail.

Nov 20 2019, 7:50 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T233977: Document REST API interface.

Reviewed, looks great! I made a couple of additional minor suggestions on the discussion page.

Nov 20 2019, 4:37 AM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP), Documentation

Nov 19 2019

BPirkle added a comment to T230848: Reader gets file description.

I'm hitting an unexpected little issue. The extension is part of the title, so I need to hit urls like (from my local, but similar urls will be true for live):

Nov 19 2019, 4:05 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T230845: Reader gets media links.

I've posted a speculative work-in-progress patch to T236169. Among its deficiencies are wholesale copying of two functions from the ImagePage class, and its failure to factor out code that will be needed for T236170. Other questions or known areas that need attention are marked with todo's.

Nov 19 2019, 4:59 AM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 18 2019

BPirkle added a comment to T230848: Reader gets file description.

How do I get "transforms" and know which representation is "preferred" vs "latest"?

Nov 18 2019, 4:03 AM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 14 2019

BPirkle added a comment to T230845: Reader gets media links.

Thank you, @Pchelolo and @Mholloway !

Nov 14 2019, 9:49 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 13 2019

BPirkle added a comment to T230845: Reader gets media links.

There's already a media-list endpoint used by Android app, we need to chat with reading infrastructure team and maybe try to align the two endpoints, so that maybe they can switch to using the new endpoint on the app

Nov 13 2019, 5:26 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)

Nov 12 2019

BPirkle added a comment to T237854: Client Developer knows semantic version of API.
  1. I wonder what a minor version release patch will look like. We could try, in one code change, to modify the version endpoint (or whatever it pulls its version data from) as well as all the affected handlers, to guarantee that there's never an inconsistent point. Alternatively, assuming a train deploy, we could do this in multiple patches, but we'd have to carefully make sure they all rode the train together. Regardless of how we approach this, it seems to require more coordination than an average change.

I was thinking that all it would mean would be changing the routes of the new endpoints from /coredev/v0 to /v1 in coreroutes.json. I guess the integration tests would need to be updated too.

Nov 12 2019, 10:39 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T237854: Client Developer knows semantic version of API.

@BPirkle when I talked about this in our last checkin, you questioned the idea. Can you let me know if this makes sense for you now?

Nov 12 2019, 8:43 PM · Core Platform Team Workboards (Green), Story, MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Nov 7 2019

BPirkle moved T236170: Implement get media file endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Nov 7 2019, 9:57 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle claimed T236170: Implement get media file endpoint.
Nov 7 2019, 9:57 PM · CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Nov 6 2019

BPirkle added a comment to T230845: Reader gets media links.

Are there any de facto test pages for media links? For example, any pages with a very large number of embedded files or files with notably uncommon characteristics?

Nov 6 2019, 8:26 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T230845: Reader gets media links.

Following @Pchelolo comment in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/548860/, should we use v1/page/title/links/media instead of v1/page/{title}/medialinks?

Nov 6 2019, 6:39 PM · Core Platform Team Workboards (User Stories), Story, CPT Initiatives (Core REST API in PHP)
BPirkle claimed T236169: Implement get media links endpoint.
Nov 6 2019, 4:51 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)
BPirkle moved T236169: Implement get media links endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Nov 6 2019, 4:51 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), CPT Initiatives (Core REST API in PHP), Core Platform Team Workboards (Green)

Nov 5 2019

BPirkle added a comment to T237430: Add object caching and PoolCounter to minor edit count endpoint.

T237043: Keep edit counts in separate database table and update on edit proposes a db table for edit counts, and also discusses some additional possibilities. We should consider our overall plan for the counts before implementing either that task or this one, so that we don't do unnecessary work.

Nov 5 2019, 4:53 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Performance Issue, Core Platform Team Workboards (Green), MediaWiki-REST-API
BPirkle added a comment to T237043: Keep edit counts in separate database table and update on edit.

T237430: Add object caching and PoolCounter to minor edit count endpoint proposes adding object caching and PoolCounter, at least for the minor edit count endpoint. We should consider our overall plan for the counts before implementing either that task or this one, so that we don't do unnecessary work.

Nov 5 2019, 4:52 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Nov 4 2019

BPirkle added a comment to T235572: Compose query for minor edit count.

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/545590/ was merged, with the "check edit count before executing minor edit count" safety net, returning 500 if the edit count limit is exceeded, as discussed.

Nov 4 2019, 10:07 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

Option 1 seems to have the fewest question marks and should be straightforward to implement:

Nov 4 2019, 4:13 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

This is server-side code, just to keep this particular endpoint from bringing down the whole site. I think we'll live with the risk that someone would DOS this endpoint over the next couple of weeks while we wait to get a more permanent solution done.

Nov 4 2019, 3:24 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

Regarding rate limiting, @Anomie pointed me at User::pingLimiter when rate limiting was previously mentioned. I have thus far only glanced at that code, and am not stating it is a viable solution to the issue being discussed in this task. But I bring it up just because it may be relevant.

Nov 4 2019, 2:37 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 31 2019

BPirkle added a comment to T235572: Compose query for minor edit count.

To clarify status: it appears all the primary people involved (myself, @eprodromou , @WDoranWMF , and @jcrespo ) agree to proceed with the "index+limit" approach, using the code that is already in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/545590/

Oct 31 2019, 10:59 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T237043: Keep edit counts in separate database table and update on edit.

Okay, one more thought - we might be able to backfill the pages with the largest number of revisions asynchronously before we activate the new system, so that the real-time backfill is acceptable. This concern, and the potential need to remediate it, might affect wikis other than enwiki, not sure what data sizes on the various other wikis look like.

Oct 31 2019, 8:22 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T237043: Keep edit counts in separate database table and update on edit.

A few thoughts for (eventual) discussion:

Oct 31 2019, 8:17 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235666: REST: Add 'from' and 'to' parameters to historycount endpoint..

Not sure if I should review https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/543718/

Oct 31 2019, 7:29 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

Fiddling a bit more on my local (which has very few pages, so absolutely not representative, but still):

Oct 31 2019, 3:03 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

For the benefit of those of us not intimately familiar with our db indexes, here's what they currently look like on the revision table:

Oct 31 2019, 2:26 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

Correct, just testwiki, so the impact of a hard cutover would be minimal. I suggest we just do it without transition.

Oct 31 2019, 1:27 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle added a comment to T235572: Compose query for minor edit count.

To add more context: Please don't blame us DBAs! 0:-)

Oct 31 2019, 1:25 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 30 2019

BPirkle updated the task description for T236323: Deprecate "revertededits" in favour of "reverted".
Oct 30 2019, 10:12 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T236325: Deprecate `botedits` in favor of `bot`.
Oct 30 2019, 10:12 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T236324: Deprecate `anonedits` in favour of `anonymous`.
Oct 30 2019, 10:12 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

I hoper we're going to apply the limit to all the count types right?

Oct 30 2019, 9:14 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

@BPirkle let's say the cap is 500. You should set your LIMIT to 501. If you get back 501, the output should be {"count": 500, "limit": true} meaning "more than 500". If you get back 500, the output should be {"count": 500, "limit": false} meaning "exactly 500". Make sense?

Oct 30 2019, 9:12 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

Prospective change uploaded to https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/545590/

Oct 30 2019, 9:08 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

I'm going to look around in our codebase for an example of doing counts with limits. But as a quick sanity check, this returns virtually immediately:

Oct 30 2019, 4:40 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/545590/

Oct 30 2019, 2:36 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T235660: Add minor edit filter type to REST API history endpoint.
Oct 30 2019, 1:26 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 28 2019

BPirkle added a comment to T235572: Compose query for minor edit count.

Anomie thought it looked okay. To quote him from IRC:

Oct 28 2019, 9:24 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T235572: Compose query for minor edit count.

Some context, just to be sure everyone is on the same page: the proposed query is part of the "GET history counts" core REST API endpoint, as originally implemented under T231590: Implement GET Edit Count, using queries discussed in T231598: Compose Count Queries. This endpoint returns various counts, each of which is implemented using its own query. The handler class for this API endpoint is here: https://codesearch.wmflabs.org/search/?q=class%20PageHistoryCountHandler&i=nope&files=&repos=

Oct 28 2019, 4:12 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235660: Add minor edit filter type to REST API history endpoint from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Oct 28 2019, 3:49 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235657: Compose query for minor edit history from Waiting for Review to Done on the Core Platform Team Workboards (Green) board.
Oct 28 2019, 3:45 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235657: Compose query for minor edit history.

Per IRC discussion, this query is approved. The query in T235572: Compose query for minor edit count is still being discussed, but does not block this task, or other engineering tasks for the related user story.

Oct 28 2019, 3:45 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T234941: Curator gets minor edit count.
Oct 28 2019, 2:56 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle added a comment to T234941: Curator gets minor edit count.

Here are the deprecation-related headers the endpoint is currently sending if a deprecated count type is specified:

Oct 28 2019, 2:55 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)

Oct 25 2019

BPirkle updated the task description for T236325: Deprecate `botedits` in favor of `bot`.
Oct 25 2019, 3:58 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T236324: Deprecate `anonedits` in favour of `anonymous`.
Oct 25 2019, 3:58 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle updated the task description for T236323: Deprecate "revertededits" in favour of "reverted".
Oct 25 2019, 3:58 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T234941: Curator gets minor edit count.
Oct 25 2019, 3:36 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle added a comment to T234941: Curator gets minor edit count.

Uploaded a patch that does full deprecation, with support for both old and new names. It sends "Deprecation" and "Link" headers if someone uses the old names. It wasn't 100% clear to me if T232485: RFC: Core REST API namespace and version required us to send these headers for changes in parameters, or if that was just when we deprecated entire endpoints. But I also didn't see that it prohibited sending them, and it seemed like a good idea.

Oct 25 2019, 3:35 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle claimed T236325: Deprecate `botedits` in favor of `bot`.
Oct 25 2019, 3:28 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T236324: Deprecate `anonedits` in favour of `anonymous`.
Oct 25 2019, 3:28 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)
BPirkle claimed T236323: Deprecate "revertededits" in favour of "reverted".
Oct 25 2019, 3:27 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP)

Oct 23 2019

BPirkle added a comment to T234941: Curator gets minor edit count.

In that case - can we sneak this in without deprecation and just do it?

Oct 23 2019, 8:38 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle updated the task description for T235587: Add minor edit count to REST API history count endpoint.
Oct 23 2019, 8:27 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234941: Curator gets minor edit count.

If I understand T232485: RFC: Core REST API namespace and version correctly, the deprecation process for the older parameter values is trivial from a coding standpoint. Shall we hot-add a task for deprecating the old parameters and adding the new ones to the current sprint? That way, as few callers as possible (ideally, none) ever use the old values.

Oct 23 2019, 8:23 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle moved T235572: Compose query for minor edit count from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Oct 23 2019, 4:29 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235657: Compose query for minor edit history from Doing to Waiting for Review on the Core Platform Team Workboards (Green) board.
Oct 23 2019, 4:29 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235657: Compose query for minor edit history.
SELECT  rev_id,rev_page,rev_timestamp,rev_minor_edit,rev_deleted,rev_len,rev_parent_id,rev_sha1,
  comment_rev_comment.comment_text AS `rev_comment_text`,
  comment_rev_comment.comment_data AS `rev_comment_data`,
  comment_rev_comment.comment_id AS `rev_comment_cid`,
  actor_rev_user.actor_user AS `rev_user`,
  actor_rev_user.actor_name AS `rev_user_text`,
  temp_rev_user.revactor_actor AS `rev_actor`
FROM `revision`
JOIN `revision_comment_temp` `temp_rev_comment`
  ON ((temp_rev_comment.revcomment_rev = rev_id))
JOIN `comment` `comment_rev_comment`
  ON ((comment_rev_comment.comment_id = temp_rev_comment.revcomment_comment_id))
JOIN `revision_actor_temp` `temp_rev_user`
  ON ((temp_rev_user.revactor_rev = rev_id AND revactor_page = rev_page))
JOIN `actor` `actor_rev_user`
  ON ((actor_rev_user.actor_id = temp_rev_user.revactor_actor))
WHERE rev_page = ?
  AND (rev_minor_edit != 0)
ORDER BY rev_timestamp DESC, rev_id DESC
LIMIT 21;
Oct 23 2019, 4:03 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T235660: Add minor edit filter type to REST API history endpoint.
Oct 23 2019, 3:11 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235660: Add minor edit filter type to REST API history endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Oct 23 2019, 3:11 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T235657: Compose query for minor edit history.
Oct 23 2019, 3:11 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235657: Compose query for minor edit history from Ready to Doing on the Core Platform Team Workboards (Green) board.
Oct 23 2019, 3:11 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle claimed T235587: Add minor edit count to REST API history count endpoint.
Oct 23 2019, 3:10 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235587: Add minor edit count to REST API history count endpoint from Ready to Doing on the Core Platform Team Workboards (Green) board.
Oct 23 2019, 3:10 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T234941: Curator gets minor edit count.

Looking at this now in engineering task T235587: Add minor edit count to REST API history count endpoint, all the other count types explicitly include "edits":

Oct 23 2019, 3:01 PM · MediaWiki-REST-API, CPT Initiatives (Core REST API in PHP), Story, Core Platform Team Workboards (User Stories)
BPirkle updated the task description for T235587: Add minor edit count to REST API history count endpoint.
Oct 23 2019, 2:58 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 22 2019

BPirkle renamed T235666: REST: Add 'from' and 'to' parameters to historycount endpoint. from Implement GET /revision/{from}/intermediatecount/{to} to REST: Add 'from' and 'to' parameters to historycount endpoint..
Oct 22 2019, 10:55 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.

The most similar code I found in Action API was this bit in ApiQueryUserContribs.php:

Oct 22 2019, 5:00 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle added a comment to T235572: Compose query for minor edit count.
SELECT  COUNT(*)  FROM `revision`
WHERE rev_page = ? 
AND (rev_minor_edit != 0)  
LIMIT 1;
Oct 22 2019, 2:59 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 21 2019

BPirkle claimed T235572: Compose query for minor edit count.
Oct 21 2019, 9:37 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle moved T235572: Compose query for minor edit count from Ready to Doing on the Core Platform Team Workboards (Green) board.
Oct 21 2019, 9:37 PM · DBA, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle closed T235565: Add Core REST API examples to the Example extension as Resolved.
Oct 21 2019, 8:46 PM · Patch-For-Review, MediaWiki-extensions-Examples, MediaWiki-REST-API, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)

Oct 16 2019

BPirkle added a comment to T233192: Consider splitting rest- messages to a separate file.

The number of these messages is likely to grow, perhaps significantly. Splitting them seems like a good idea.

Oct 16 2019, 11:01 PM · translatewiki.net, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Green), MediaWiki-Internationalization, MediaWiki-REST-API, I18n
BPirkle closed T235559: Fix error in RESTBagOStuff class comment as Resolved.
Oct 16 2019, 10:32 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Patch-For-Review, MW-1.34-release, CPT Initiatives (Session Management Service (CDP2))
BPirkle closed T233963: Add serialization options to RESTBagOStuff as Resolved.
Oct 16 2019, 10:31 PM · MW-1.34-notes, MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), MW-1.34-release, Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle created T235666: REST: Add 'from' and 'to' parameters to historycount endpoint..
Oct 16 2019, 3:45 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), Patch-For-Review, Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235665: Compose query for intermediate revision count.
Oct 16 2019, 3:41 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle created T235660: Add minor edit filter type to REST API history endpoint.
Oct 16 2019, 2:29 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)
BPirkle updated subscribers of T235657: Compose query for minor edit history.

For reference, count queries for the existing filter types were created under T231599: Compose New History Queries and implemented under T231597: Implement GET History Filter

Oct 16 2019, 2:24 PM · Core Platform Team Workboards (Green), CPT Initiatives (Core REST API in PHP)