Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (41 w, 5 d)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Wed, Apr 17

BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

I am not aware of any resolution or progress on this task (beyond @MaxSem 's abandoned patch above).

Wed, Apr 17, 9:50 PM · PHP 7.2 support, Core Platform Team Backlog (Next), Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)
BPirkle added a comment to T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..

Ooops, too fast, there is an open patch needing review: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500755

Wed, Apr 17, 2:33 PM · Core Platform Team Kanban (Waiting for Review), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Fri, Apr 12

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

I have, on my local development wiki, a working KaskBagOStuff (naming suggestions welcome) that communicates with the development instance at deployment-sessionstore01.deployment-prep.eqiad.wmflabs (via some tricky port forwarding) and successfully allows basic session management for happy login and logout.

Out of curiosity, what is it that prevents you from using RESTBagOStuff?

Fri, Apr 12, 2:44 PM · User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans
Eevans awarded T215533: Enable use of session storage service in MediaWiki a Cookie token.
Fri, Apr 12, 2:32 PM · User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans

Thu, Apr 11

BPirkle updated subscribers of T215533: Enable use of session storage service in MediaWiki.
Thu, Apr 11, 10:24 PM · User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans
BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

I have, on my local development wiki, a working KaskBagOStuff (naming suggestions welcome) that communicates with the development instance at deployment-sessionstore01.deployment-prep.eqiad.wmflabs (via some tricky port forwarding) and successfully allows basic session management for happy login and logout.

Thu, Apr 11, 10:15 PM · User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans

Mon, Apr 8

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Per discussion in this task, I created new task T220450 for the additional Postgres changes (searchindex table).

Mon, Apr 8, 9:05 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle created T220450: Make Postgres search use a searchindex table.
Mon, Apr 8, 9:04 PM · PostgreSQL, MediaWiki-Database, Multi-Content-Revisions (Tech Debt), Technical-Debt

Thu, Apr 4

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

Relevant documentation: https://www.mediawiki.org/wiki/Requests_for_comment/SessionStorageAPI
Development instance is at deployment-sessionstore01.deployment-prep.eqiad.wmflabs

Thu, Apr 4, 5:32 PM · User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans
BPirkle added a comment to T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..

Usages found:

Thu, Apr 4, 2:55 AM · Core Platform Team Kanban (Waiting for Review), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 21 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.
  • includes/search/SearchPostgres.php

odd stuff, maybe @Anomie can help. Two uses seem completely pointless, the third one should probably use getQueryInfo?

Note in the PostgreSQL schema the "text" table is named "pagecontent". That was done in rSVN15791; I don't know why quoting wasn't just used instead. The plan for T164898/T191231 includes renaming it back to "text".

It looks like that file needs some Technical-Debt cleanup to use the IDatabase querying methods rather than building SQL strings directly, but that alone would probably be out of scope here.

What is in scope is that it's trying to search directly against the text table, having added an extra column for that purpose, and will need to be converted to use a searchindex table like MySQL does.

Mar 21 2019, 3:38 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 14 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Here's one place where Daniel and I differ: I'd put most of these in one patch instead of having 10+ single-file changes.

Ok, compromise: one patch for SearchPostgres, one for checkStorage.php and compressOld.php, and one for the rest.

Mar 14 2019, 8:46 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 13 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated)

getQueryInfo() should have proper gating as well. If you think it does not, let's talk before you change things.

Mar 13 2019, 10:05 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

MessageCache.php was not listed in my previous comment, because I've already incorporated Daniel's patch from June into my local codebase, but that'll be part of the final change as well.

Mar 13 2019, 6:07 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle updated subscribers of T198341: Remove all references to the rev_text_id and ar_text_id fields.

Thank you. With that in mind, here's my current understanding. The list below applies only to rev_text_id, not ar_text_id or text.old_id. When touching code for rev_text_id, I'll also remove any references to the other two fields. I'll then loop back and review/remove any remaining references to them.

Mar 13 2019, 3:57 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Thank you. Will ping Tim on that one when it is daylight for him.

Mar 13 2019, 2:16 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Question on one occurrence of these fields: is the maintenance script fixT22757.php still relevant?

Mar 13 2019, 4:19 AM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 8 2019

BPirkle added a comment to T202352: Convert MultiHttpClient to use Guzzle.

@hashar , sorry for the inconvenience, I'm glad reverting the change made things happy again.

Mar 8 2019, 4:54 AM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Core Platform Team Kanban (Waiting for Review), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Mar 5 2019

Krinkle awarded T202352: Convert MultiHttpClient to use Guzzle a Orange Medal token.
Mar 5 2019, 11:34 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Core Platform Team Kanban (Waiting for Review), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown
BPirkle added a comment to T207977: remove prev/next message dependency from Language.

My comment with the Deprecation policy link was simply because we were discussing the possibility of an external contractor working on this task, and the link seemed relevant to have available. Sorry, I should have included context.

Mar 5 2019, 4:12 PM · Core Platform Team Kanban, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review

Mar 4 2019

BPirkle added a comment to T207977: remove prev/next message dependency from Language.

Deprecation policy: https://www.mediawiki.org/wiki/Deprecation_policy

Mar 4 2019, 2:42 PM · Core Platform Team Kanban, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review

Feb 28 2019

BPirkle reassigned T214317: Phase out deprecated Title::isValidMoveTarget from BPirkle to Hknust.
Feb 28 2019, 8:24 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Decoupling (CDP2)), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management
BPirkle reassigned T214316: Remove unused method Title::validateFileMoveOperation from BPirkle to Hknust.
Feb 28 2019, 8:23 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Feb 26 2019

BPirkle added a comment to T214316: Remove unused method Title::validateFileMoveOperation.

This is a protected function that has existed since at least 1.32 (although it appeared to be unused in core there too, I didn't check extensions yet).

Feb 26 2019, 6:09 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Feb 20 2019

BPirkle added a comment to T216086: ErrorException from includes/HeaderCallback.php: PHP Notice: Undefined offset: 1.

Confirmed that the Guzzle-based MultiHttpClient code in T202352 is unaffected by this issue. So this issue will not reappear when that code is merged.

Feb 20 2019, 3:38 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Wikimedia-production-error

Feb 18 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Task description refers to "RevisionStore::newRevisionRecordFromRow()". Should that be "RevisionStore::newRevisionFromRow()"?

Feb 18 2019, 7:01 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198557: Remove support for legacy pre-MCR schema.

I was, however, able to claim T198341. I'll start there.

Feb 18 2019, 4:17 PM · Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Later), Core Platform Team (MCR), MW-1.33-release, Wikidata
BPirkle claimed T198341: Remove all references to the rev_text_id and ar_text_id fields.
Feb 18 2019, 4:16 PM · Core Platform Team Kanban (Waiting for Review), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198557: Remove support for legacy pre-MCR schema.

I'm happy to, but it appears that I cannot edit or claim the task.

Feb 18 2019, 4:12 PM · Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Later), Core Platform Team (MCR), MW-1.33-release, Wikidata
BPirkle added a comment to T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .

Task description edited to include WMF-maintained extensions.

Feb 18 2019, 4:11 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
BPirkle updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Feb 18 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Feb 13 2019

BPirkle added a comment to T213893: Allow extensions to define additional command line parameters to "update.php".

Per discussion with @tstarling , and consistent with discussion on the GitHub issue, I plan to add a hook allowing extensions to manipulate parameters to maintenance scripts. I'm now working out what the parameters to that hook should be, and how extensions should be allowed to manipulate these values.

Feb 13 2019, 12:47 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Doing), User-Nikerabbit, MediaWiki-Installer
BPirkle updated subscribers of T213893: Allow extensions to define additional command line parameters to "update.php".
Feb 13 2019, 12:34 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Doing), User-Nikerabbit, MediaWiki-Installer

Feb 8 2019

BPirkle closed T214703: Change HttpRequestFactory default to guzzle as Resolved.

This has been merged

Feb 8 2019, 2:35 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review

Feb 5 2019

BPirkle updated the task description for T212175: Support callback functions in GuzzleHttpRequest and MultiHttpClient.
Feb 5 2019, 1:50 AM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Jan 25 2019

BPirkle updated subscribers of T214703: Change HttpRequestFactory default to guzzle.
Jan 25 2019, 4:31 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review
BPirkle moved T214703: Change HttpRequestFactory default to guzzle from Inbox to Ready on the Core Platform Team Kanban board.
Jan 25 2019, 4:30 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review
BPirkle created T214703: Change HttpRequestFactory default to guzzle.
Jan 25 2019, 4:20 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review
BPirkle placed T206296: PhpTags tests fail on PHP 7.1 up for grabs.
Jan 25 2019, 2:42 PM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags
BPirkle closed T212175: Support callback functions in GuzzleHttpRequest and MultiHttpClient as Resolved.

Patch merged, this is complete

Jan 25 2019, 2:39 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Jan 22 2019

BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

We identified this task as a likely candidate for an outside contractor to complete, based on current team structure and availability. The goal is to restore logging of stack traces that would be lost in a switch to PHP7 / php-fpm.

Jan 22 2019, 3:42 PM · PHP 7.2 support, Core Platform Team Backlog (Next), Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)

Jan 17 2019

BPirkle added a comment to T202352: Convert MultiHttpClient to use Guzzle.

Security review was completed in Dec. 2018. The patch should now pass tests and is awaiting code review.

Jan 17 2019, 5:50 PM · Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Core Platform Team Kanban (Waiting for Review), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Jan 16 2019

BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

Error and stack trace follows for a different failure (Failed to load blob) that generates the same exception. I've reviewed logs and thus far have found only these three types of failures (the one below, plus the two above) resulting in a RevisionAccessException. All three failure types occur multiple times in the logs.

Jan 16 2019, 11:45 PM · Core Platform Team Kanban (Contractor - Ready), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
BPirkle claimed T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Jan 16 2019, 4:04 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Jan 15 2019

BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

My local results for the api instance match what @Anomie described: a "200 OK" with a body including an api_internal_error code, as follows:

Jan 15 2019, 10:23 PM · Core Platform Team Kanban (Contractor - Ready), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

First instance from above (the api one) reproduced locally by being evil to my database.

Jan 15 2019, 9:58 PM · Core Platform Team Kanban (Contractor - Ready), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

Two examples from exception.log:

Jan 15 2019, 5:35 PM · Core Platform Team Kanban (Contractor - Ready), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), Patch-For-Review, MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error

Dec 17 2018

BPirkle created T212175: Support callback functions in GuzzleHttpRequest and MultiHttpClient.
Dec 17 2018, 11:53 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Dec 15 2018

mmodell awarded T198176: Mediawiki page deletions should happen in batches of revisions a Barnstar token.
Dec 15 2018, 7:54 PM · Core Platform Team Kanban (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (Code Health (TEC13)), Wikimedia-production-error, Patch-For-Review, MediaWiki-Page-deletion

Dec 14 2018

BPirkle claimed T212005: PHP Notice: Undefined index: 1 from line 424 of includes/http/MWHttpRequest.php: .
Dec 14 2018, 9:37 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MediaWiki-libs-HTTP, Wikimedia-production-error
BPirkle added a comment to T207530: Deleting pages on the English Wikipedia is very slow.

@Krinkle , have you seen evidence of an ongoing problem, or can we resolve this task?

Dec 14 2018, 4:38 AM · Performance-Team (Radar), MW-1.32-release, Operations, MediaWiki-Page-deletion

Dec 13 2018

BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

Looks good. Upload of a large file to test.wikipedia.org, which failed earlier today with the the "exceeded memory limit" error, now succeeds.

Dec 13 2018, 10:35 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

I think this is my error and not Guzzle's.

Dec 13 2018, 4:47 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

From fatal.log:

Dec 13 2018, 3:45 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

Agreed. Not a dupe, but appears related. I don't have an immediate answer for what's happening, but I'm looking as well.

Dec 13 2018, 3:19 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle updated the task description for T176370: Migrate to PHP 7 in WMF production.
Dec 13 2018, 3:13 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
BPirkle closed T209981: Confirm that post-send functions work fine with mediawiki under PHP 7 as Resolved.

It seems that post-send functions work equivalently between php-fpm and hhvm. So I'm closing this task and marking it as complete on the php7 checklist. If we want to investigate/adjust timeouts and look at related concerns (queuing, etc.), let's do that under a separate task.

Dec 13 2018, 3:12 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle closed T209981: Confirm that post-send functions work fine with mediawiki under PHP 7, a subtask of T176370: Migrate to PHP 7 in WMF production, as Resolved.
Dec 13 2018, 3:12 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Dec 12 2018

BPirkle added a comment to T211806: Passing in the "body" request option as an array to send a POST request has been deprecated.

This looks more promising:

Dec 12 2018, 11:59 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Collection, Wikidata-Campsite, Wikidata, MediaWiki-extensions-JsonConfig, MediaWiki-Vendor
BPirkle added a comment to T211806: Passing in the "body" request option as an array to send a POST request has been deprecated.

Reproduced the exception locally using trivial test data:

Dec 12 2018, 10:40 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Collection, Wikidata-Campsite, Wikidata, MediaWiki-extensions-JsonConfig, MediaWiki-Vendor
BPirkle added a comment to T211806: Passing in the "body" request option as an array to send a POST request has been deprecated.

GuzzleHttpRequest.php line 94, we are indeed setting the 'body' field and trusting that $postData was happily passed to the constructor by calling code. Fiddling...

Dec 12 2018, 10:15 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Collection, Wikidata-Campsite, Wikidata, MediaWiki-extensions-JsonConfig, MediaWiki-Vendor
BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

I checked a variety of fatal errors on both production HHVM and our current php-fpm configuration using the fatal-errors.php script from T210567. Here's what I found. (Disclaimer: I'm still relatively new to our error logging, so there may be something obvious that I missed.)

Dec 12 2018, 5:53 PM · PHP 7.2 support, Core Platform Team Backlog (Next), Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)
BPirkle added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

Further testing on production via the fatal-errors.php script from T210567 shows that timeout errors in a post-send function (which that script generates via infinite loop) occur on at 200 seconds under both HHVM and php7.

Dec 12 2018, 3:24 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Dec 11 2018

BPirkle closed T210567: Create a way to intentionally trigger fatal errors in MediaWiki as Resolved.

Closing this task, because the script is deployed and functioning as designed.

Dec 11 2018, 4:16 PM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Dec 10 2018

BPirkle added a comment to T110022: Create a library with HTTP related functions/code.

Guzzle has been added to the codebase and made available through the new GuzzleHttpRequest class, per T202110.

Dec 10 2018, 4:03 PM · MediaWiki-libs-HTTP, Addwiki, Wikidata, Librarization
BPirkle closed T202110: Create GuzzleHttpRequest class as new default for HttpRequestFactory as Resolved.
Dec 10 2018, 3:57 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (Code Health (TEC13)), Patch-For-Review, MediaWiki-General-or-Unknown

Dec 6 2018

BPirkle added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

@tstarling, in IRC @Joe raised a concern that the current method of transmitting the password would cause it to being revealed in logging, which I had not considered. He suggested http basic auth as an alternative. Unless you have another idea, I'm planning to look into that possibility tomorrow.

Dec 6 2018, 3:56 AM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Dec 5 2018

BPirkle added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

Thank you @Nikerabbit . As part of testing T210567 locally on 7.2 php-fpm, I confirmed that behavior - my post-send processing was terminated by max_execution_time.

Dec 5 2018, 1:11 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Dec 3 2018

BPirkle added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

A first draft of this script is mostly finished and I'm testing locally. A few notes:

Dec 3 2018, 11:01 PM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Nov 28 2018

BPirkle closed T206291: MultiMaps tests are failing on PHP 7.1 as Resolved.

A fix for this issue has been merged.

Nov 28 2018, 3:39 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.1 support, MediaWiki-extensions-Other
BPirkle created T210567: Create a way to intentionally trigger fatal errors in MediaWiki.
Nov 28 2018, 12:47 AM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Nov 27 2018

BPirkle updated the task description for T176370: Migrate to PHP 7 in WMF production.
Nov 27 2018, 10:27 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Nov 21 2018

BPirkle updated subscribers of T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.
Nov 21 2018, 9:46 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

Things I've done so far:

Nov 21 2018, 9:46 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Nov 20 2018

BPirkle moved T209981: Confirm that post-send functions work fine with mediawiki under PHP 7 from Inbox to Doing on the Core Platform Team Kanban board.
Nov 20 2018, 5:19 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle updated the task description for T176370: Migrate to PHP 7 in WMF production.
Nov 20 2018, 5:17 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
BPirkle added a subtask for T176370: Migrate to PHP 7 in WMF production: T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.
Nov 20 2018, 5:16 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
BPirkle added a parent task for T209981: Confirm that post-send functions work fine with mediawiki under PHP 7: T176370: Migrate to PHP 7 in WMF production.
Nov 20 2018, 5:16 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle created T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.
Nov 20 2018, 5:16 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle added a project to T206291: MultiMaps tests are failing on PHP 7.1: Core Platform Team.
Nov 20 2018, 2:18 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.1 support, MediaWiki-extensions-Other

Nov 19 2018

BPirkle claimed T206291: MultiMaps tests are failing on PHP 7.1.
Nov 19 2018, 3:58 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.1 support, MediaWiki-extensions-Other
BPirkle added a comment to T206291: MultiMaps tests are failing on PHP 7.1.

Reproduced locally. This appears related to https://wiki.php.net/rfc/precise_float_value

Nov 19 2018, 3:58 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.1 support, MediaWiki-extensions-Other
BPirkle added a comment to T206296: PhpTags tests fail on PHP 7.1.

It is also worth noting that the test "testRun_echo_list_11" passes under PHP 7.0+. This test executes (via the PhpTags runtime engine) the following PhpTags code and checks the result:

Nov 19 2018, 3:56 AM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags

Nov 15 2018

BPirkle updated subscribers of T206296: PhpTags tests fail on PHP 7.1.
Nov 15 2018, 5:53 PM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags
BPirkle added a comment to T206296: PhpTags tests fail on PHP 7.1.

tl;dr: this extension (kind of) emulates PHP within a wiki page. How should it handle differences in PHP versions? Should it match the PHP version on the underlying web server, or define its own behavior? Either way has advantages and disadvantages.

Nov 15 2018, 5:51 PM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags

Nov 14 2018

BPirkle added a comment to T206296: PhpTags tests fail on PHP 7.1.

From http://php.net/manual/en/migration71.other-changes.php

Nov 14 2018, 3:15 AM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags
BPirkle triaged T206296: PhpTags tests fail on PHP 7.1 as Normal priority.
Nov 14 2018, 1:04 AM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags
BPirkle claimed T206296: PhpTags tests fail on PHP 7.1.

Reproduced locally, investigating

Nov 14 2018, 1:03 AM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags

Nov 13 2018

BPirkle closed T188585: PhpTags tests fail on PHP 7.0 as Resolved.
Nov 13 2018, 11:00 PM · Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.0 support, MediaWiki-extensions-PhpTags
BPirkle closed T206411: Empty JSON keys are replaced with "_empty_" as Resolved.
Nov 13 2018, 10:59 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), MediaWiki-ContentHandler, HHVM, PHP 7.0 support, MediaWiki-General-or-Unknown

Nov 12 2018

BPirkle added a comment to T188585: PhpTags tests fail on PHP 7.0.

Thank you, @hashar , the change in list() behavior appears to be exactly what the problem was.

Nov 12 2018, 8:04 PM · Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.0 support, MediaWiki-extensions-PhpTags

Nov 9 2018

BPirkle claimed T188585: PhpTags tests fail on PHP 7.0.

Reproduced locally, investigating

Nov 9 2018, 12:10 AM · Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.0 support, MediaWiki-extensions-PhpTags

Nov 8 2018

BPirkle committed rECKT524d978d6e32: Fix for PHP7.2 compatibility (authored by BPirkle).
Fix for PHP7.2 compatibility
Nov 8 2018, 7:00 PM
BPirkle claimed T206900: CollaborationHubContentTest::testGetMembersBlock fails on PHP 7.2.

Reproduced locally, investigating

Nov 8 2018, 5:37 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support, MediaWiki-extensions-CollaborationKit
BPirkle added a comment to T202143: Security review for Guzzle 6.3.3.

Bump, just to make sure this doesn't fall off the radar.

Nov 8 2018, 3:32 AM · User-Addshore, Security-Team-Reviews, MediaWiki-Vendor

Nov 7 2018

BPirkle added a comment to T206411: Empty JSON keys are replaced with "_empty_".

Unfortunately, there's an additional and competing complication: empty JSON objects.

Nov 7 2018, 3:15 AM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), MediaWiki-ContentHandler, HHVM, PHP 7.0 support, MediaWiki-General-or-Unknown

Nov 6 2018

BPirkle closed T198176: Mediawiki page deletions should happen in batches of revisions as Resolved.
Nov 6 2018, 4:06 PM · Core Platform Team Kanban (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (Code Health (TEC13)), Wikimedia-production-error, Patch-For-Review, MediaWiki-Page-deletion
BPirkle closed T198176: Mediawiki page deletions should happen in batches of revisions, a subtask of T207940: Large transaction-related errors and other problems (tracking), as Resolved.
Nov 6 2018, 4:06 PM · MediaWiki-General-or-Unknown, Tracking-Neverending
BPirkle added a comment to T198176: Mediawiki page deletions should happen in batches of revisions.

@MarcoAurelio and @jcrespo : retrying deletion of a page several times *should* be fine, and was tested locally (as was editing a page that was in the process of being deleted). With that said, rechecking on production is prudent. Please let me know if you see any issues.

Nov 6 2018, 4:05 PM · Core Platform Team Kanban (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (Code Health (TEC13)), Wikimedia-production-error, Patch-For-Review, MediaWiki-Page-deletion
BPirkle closed T207974: Export with full history creates broken XML (missing end tag </page>) as Resolved.
Nov 6 2018, 2:27 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (Security, stability, performance and scalability (TEC1)), MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Regression, MediaWiki-Export-or-Import