Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (58 w, 5 d)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Fri, Aug 16

BPirkle added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

This endpoint has four (non-error) paths:

Fri, Aug 16, 3:55 PM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API

Wed, Aug 14

BPirkle updated subscribers of T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.
Wed, Aug 14, 3:06 AM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API
BPirkle updated subscribers of T221175: POST /:domain/v3/transform/wikitext/to/lint/:title?/:revision?.
Wed, Aug 14, 3:06 AM · Core Platform Team Workboards (Green), MediaWiki-REST-API

Tue, Aug 13

BPirkle added a comment to T229931: Parsoid development setup.
Tue, Aug 13, 9:30 PM · Documentation, Core Platform Team Workboards (Green), MediaWiki-REST-API
BPirkle added a comment to T221174: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision?.

The pb2pb function in routes.js calls functions like updateRedLinks and languageConversion. I searched, but didn't see PHP equivalents. Do they exist? If not, is it within the scope of this task to create them, or is that covered elsewhere?

Tue, Aug 13, 3:03 AM · Patch-For-Review, Core Platform Team Workboards (Green), MediaWiki-REST-API

Mon, Aug 12

BPirkle added a comment to T221175: POST /:domain/v3/transform/wikitext/to/lint/:title?/:revision?.

I'm new to Parsoid, so some clarification and context would be helpful.

Mon, Aug 12, 6:49 PM · Core Platform Team Workboards (Green), MediaWiki-REST-API

Wed, Aug 7

BPirkle updated subscribers of T229931: Parsoid development setup.

Per advice from @Tgr , I have:

Wed, Aug 7, 3:04 PM · Documentation, Core Platform Team Workboards (Green), MediaWiki-REST-API

Tue, Aug 6

BPirkle moved T229931: Parsoid development setup from Backlog to Doing on the Core Platform Team Workboards (Green) board.
Tue, Aug 6, 2:23 PM · Documentation, Core Platform Team Workboards (Green), MediaWiki-REST-API
BPirkle created T229931: Parsoid development setup.
Tue, Aug 6, 2:22 PM · Documentation, Core Platform Team Workboards (Green), MediaWiki-REST-API

Mon, Aug 5

BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

We have completed all stages of the migration for testwiki. Testwiki is now using only kask for session storage, and is not using redis at all. Everything looks good from my end.

Mon, Aug 5, 6:15 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle added a comment to T227096: Test migration process for session storage.

We have completed all stages of the migration for testwiki. Testwiki is now using only kask for session storage, and is not using redis at all. Everything looks good from my end.

Mon, Aug 5, 6:14 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle moved T222099: Staging release of RESTBagOStuff using Kask from Doing to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.
Mon, Aug 5, 6:12 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle moved T227096: Test migration process for session storage from Doing to PM User Story Sign Off on the Core Platform Team Workboards (Green) board.
Mon, Aug 5, 6:12 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Thu, Aug 1

BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

We have now completed two deploys that affect testwiki (only):

  1. use MultiWriteBagOStuff to write sessions to both redis and Kask, with reads from redis as primary, and kask as fallback
  2. use MultiWriteBagOStuff to write sessions to both redis and Kask, with reads from kask as primary, and redis as fallback
Thu, Aug 1, 6:13 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans

Wed, Jul 31

BPirkle moved T227096: Test migration process for session storage from Next Sprint to Doing on the Core Platform Team Workboards (Green) board.
Wed, Jul 31, 3:24 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle moved T229352: Code Review for Changes that Move Components Away from MainStash from Next Sprint to Doing on the Core Platform Team Workboards (Green) board.
Wed, Jul 31, 3:23 PM · Core Platform Team Workboards (Green)
BPirkle moved T222099: Staging release of RESTBagOStuff using Kask from Next Sprint to Doing on the Core Platform Team Workboards (Green) board.
Wed, Jul 31, 3:23 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle closed T227696: OAuth extension uses session object store directly, a subtask of T222099: Staging release of RESTBagOStuff using Kask, as Resolved.
Wed, Jul 31, 1:04 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle closed T227696: OAuth extension uses session object store directly as Resolved.

The config change has now been merged and deployed.

Wed, Jul 31, 1:04 PM · CPT Initiatives (Mainstash Multi-DC), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, User-Clarakosi, User-Eevans
BPirkle closed T227097: Make sure that we're taking CentralAuth into consideration for staging release, a subtask of T222099: Staging release of RESTBagOStuff using Kask, as Resolved.
Wed, Jul 31, 1:03 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle closed T227097: Make sure that we're taking CentralAuth into consideration for staging release as Resolved.

The config change has now been merged and deployed.

Wed, Jul 31, 1:03 PM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans

Tue, Jul 30

BPirkle added a project to T227097: Make sure that we're taking CentralAuth into consideration for staging release: Operations.
Tue, Jul 30, 6:30 PM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans
BPirkle reopened T227696: OAuth extension uses session object store directly, a subtask of T222099: Staging release of RESTBagOStuff using Kask, as Open.
Tue, Jul 30, 5:06 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle reopened T227696: OAuth extension uses session object store directly as "Open".

We still need the config change to be merged/deployed.

Tue, Jul 30, 5:06 PM · CPT Initiatives (Mainstash Multi-DC), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, User-Clarakosi, User-Eevans
BPirkle added a comment to T227097: Make sure that we're taking CentralAuth into consideration for staging release.

We still need the config change to be merged/deployed.

Tue, Jul 30, 5:05 PM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans
BPirkle reopened T227097: Make sure that we're taking CentralAuth into consideration for staging release, a subtask of T222099: Staging release of RESTBagOStuff using Kask, as Open.
Tue, Jul 30, 5:05 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle reopened T227097: Make sure that we're taking CentralAuth into consideration for staging release as "Open".
Tue, Jul 30, 5:05 PM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans

Jul 14 2019

BPirkle added a comment to T226979: Increase curl timeout for importImages.php.

I have not forgotten about T202352, which converts MultiHttpClient to use Guzzle internally. If no one else gets to that first, I'll eventually get back to it, and will update that patch for this timeout change, plus any additional changes that have occurred since I last worked on that. Guzzle (on our stack) will ultimately use curl anyway, and the timeout change will still be relevant.

Jul 14 2019, 2:31 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), User-Urbanecm, Multimedia, Commons, MediaWiki-File-management

Jul 12 2019

BPirkle added a project to T227836: Create maintenance script to delete orphaned content: MediaWiki-extensions-DeletePagesForGood.
Jul 12 2019, 2:40 AM · CPT Initiatives (MCR), MediaWiki-extensions-DeletePagesForGood, Multi-Content-Revisions (Tech Debt)
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

I've uploaded patches for all issues identified in this task. In an effort to keep this task focused on ar_text_id and rev_text_id, I created several related tasks for things that deserve attention and which are related to MCR, but not directly to rev_text_id or ar_text_id:

Jul 12 2019, 2:39 AM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198431: Edit interface of Special:Interwiki is missing.

The mention of this task in T227840 was a typo, sorry.

Jul 12 2019, 2:33 AM · MediaWiki-extensions-Interwiki, MediaWiki-Interwiki, MediaWiki-Special-pages
BPirkle updated the task description for T227840: Update the Duplicator extension for MCR.
Jul 12 2019, 2:32 AM · CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt), MediaWiki-extensions-Duplicator
BPirkle triaged T227840: Update the Duplicator extension for MCR as Normal priority.
Jul 12 2019, 2:27 AM · CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt), MediaWiki-extensions-Duplicator
BPirkle created T227840: Update the Duplicator extension for MCR.
Jul 12 2019, 2:27 AM · CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt), MediaWiki-extensions-Duplicator

Jul 11 2019

BPirkle triaged T227836: Create maintenance script to delete orphaned content as Normal priority.
Jul 11 2019, 11:49 PM · CPT Initiatives (MCR), MediaWiki-extensions-DeletePagesForGood, Multi-Content-Revisions (Tech Debt)
BPirkle triaged T227835: Add notion of deletion to BlobStore as Normal priority.
Jul 11 2019, 11:49 PM · CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt)
BPirkle created T227836: Create maintenance script to delete orphaned content.
Jul 11 2019, 11:49 PM · CPT Initiatives (MCR), MediaWiki-extensions-DeletePagesForGood, Multi-Content-Revisions (Tech Debt)
BPirkle created T227835: Add notion of deletion to BlobStore.
Jul 11 2019, 11:49 PM · CPT Initiatives (MCR), Multi-Content-Revisions (Tech Debt)
BPirkle committed rEOAUa6ec212b25ee: Allow separating OAuth and per-wiki session storage. (authored by BPirkle).
Allow separating OAuth and per-wiki session storage.
Jul 11 2019, 8:11 PM

Jul 10 2019

BPirkle added a comment to T227696: OAuth extension uses session object store directly.

OAuth change posted, OAuth configuration added to the existing configuration change.

Jul 10 2019, 8:55 PM · CPT Initiatives (Mainstash Multi-DC), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, User-Clarakosi, User-Eevans
BPirkle added a comment to T227696: OAuth extension uses session object store directly.

Thanks @EvanProdromou , I'm working on a change for this.

Jul 10 2019, 6:43 PM · CPT Initiatives (Mainstash Multi-DC), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), Patch-For-Review, User-Clarakosi, User-Eevans

Jul 9 2019

BPirkle added a comment to T227097: Make sure that we're taking CentralAuth into consideration for staging release.

I have pushed two Gerrit changes:

Jul 9 2019, 2:50 AM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans

Jul 3 2019

BPirkle updated the task description for T217831: Add a check to populateContentTables.php to ensure that populateRevisionSha1.php is run first.
Jul 3 2019, 10:17 PM · MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (Needs Cleaning - Security, stability, performance and scalability (TEC1))
BPirkle updated the task description for T217829: Update populateRevisionSha1.php to run over the content table.
Jul 3 2019, 4:09 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (Needs Cleaning - Security, stability, performance and scalability (TEC1))
BPirkle added a comment to T227097: Make sure that we're taking CentralAuth into consideration for staging release.

In looking back over session storage tasks, I came across this relevant comment by @Eevans in T222907:

Jul 3 2019, 2:26 AM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans
BPirkle added a comment to T227097: Make sure that we're taking CentralAuth into consideration for staging release.

@Tgr , thank you for your reply.

Jul 3 2019, 2:03 AM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans

Jul 2 2019

BPirkle updated subscribers of T227097: Make sure that we're taking CentralAuth into consideration for staging release.

From what I can quickly tell, Evan's analysis is correct - if we were to move ahead with deploying the session storage change as-is, we would also affect storage for CentralAuth. I don't pretend to understand CentralAuth well enough to know what impact that might have. Some things I am concerned about are:

Jul 2 2019, 5:20 PM · Operations, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Patch-For-Review, Core Platform Team Workboards (Team 2), User-Clarakosi, User-Eevans

Jul 1 2019

BPirkle updated subscribers of T224993: Example configuration clauses for using RESTBagOStuff with Kask.

After discussion with @WDoranWMF and @daniel , it might be prudent to deploy to production in multiple steps. One option would be:

Jul 1 2019, 5:59 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Jun 27 2019

BPirkle added a comment to T224993: Example configuration clauses for using RESTBagOStuff with Kask.

Prospective configuration change pushed for review under T222099. That change will transition only testwiki to use Kask, for testing. Once T222099 is closed and testing is complete, next steps will be:

Jun 27 2019, 7:42 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))
BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

Prospective configuration change pushed for review. Once this is merged and deployed, sessions for testwiki will be stored to both Redis and Kask, and will be continue to be read from Redis. (Other wikis will be unaffected and will continue to use only Redis.) Next steps will be:

Jun 27 2019, 7:27 PM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle added a comment to T221986: Security Review of RESTBagOStuff.

@Eevans and @BPirkle I feel pretty satisfied. I'm not a security professional, but I'm having a hard time thinking up other attacks than those listed. I have three questions left for you, and then I think we can close this ticket.

  • Are there attacks you can think of that I didn't list?
Jun 27 2019, 6:00 PM · Core Platform Team Workboards (Team 2), Core Platform Team (Session Management Service (CDP2))
BPirkle added a comment to T226666: RESTBagOStuff client error handling.

Currently, if decoding fails, RESTBagOStuff will simply log the error without any extended information. This would include only:

  • a message describing the operation that was being attempted (ex. "Failed to store XXXX")
  • the HTTP error code (ex. 500)
  • the HTTP response string (ex. "Internal Server Error")

So we would have a record of the error,. But if the body contained error information beyond the HTTP code/string, that information would be lost. In the example from the task description, we would not lose anything.

Jun 27 2019, 12:26 AM · Core Platform Team (Multi-DC (TEC1)), User-Clarakosi, Core Platform Team Legacy (Next), User-Eevans

Jun 26 2019

BPirkle added a comment to T221986: Security Review of RESTBagOStuff.

Thank you, @EvanProdromou for this list! Responses follow to items I'm familiar with.

Jun 26 2019, 9:34 PM · Core Platform Team Workboards (Team 2), Core Platform Team (Session Management Service (CDP2))
BPirkle added a comment to T224993: Example configuration clauses for using RESTBagOStuff with Kask.

One issue here is that you're planning to hard-code the session store host into CommonSettings.php - that's not great as it will not work for labs for example. The common pattern here is to utilize $wmfLocalServices for hosts and then add app the path portion of the URI in CommonSettings.
Second, why are we redefining the kask-session config within kask-transition? Can we just use the same pattern as for redis_local and just use ObjectCache::getInstance('kask-session') to obtain an already defined instance?

Jun 26 2019, 5:42 AM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Jun 14 2019

BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

What happens if we (in repository mediawiki-config):

Jun 14 2019, 1:58 AM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2)), User-Clarakosi, User-Eevans
BPirkle added a comment to T224993: Example configuration clauses for using RESTBagOStuff with Kask.

T220401 contains deployment details. Here's the relevant part, in action:

Jun 14 2019, 1:48 AM · Core Platform Team Workboards (Green), CPT Initiatives (Session Management Service (CDP2))

Jun 13 2019

BPirkle added a comment to T217829: Update populateRevisionSha1.php to run over the content table.

The task description currently reads "content_sha1 needs to be populated by the populateRevisionSha1.php script". However, unless I'm misunderstanding things, this would cause a chicken-and-egg problem.

Jun 13 2019, 3:44 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.34-release, Core Platform Team Workboards (Team 3), Multi-Content-Revisions (Reactive), Core Platform Team (Needs Cleaning - Security, stability, performance and scalability (TEC1))

Jun 11 2019

BPirkle added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

I'm looking into the related tasks (T217829 and T217831) now. Just a note for anyone who may read this in the future and may consider executing the query that was mentioned in earlier comments:

Jun 11 2019, 3:45 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions

Jun 10 2019

BPirkle added a comment to T224368: Ensure Linker::userLink is not called with empty user name.

I'll post the short-term fix to Linker::revUserTools() here. I also created T225469 for @Anomie 's maintenance script suggestion.

Jun 10 2019, 9:57 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging
BPirkle created T225469: Create maintenance script for bad actor data cleanup.
Jun 10 2019, 9:55 PM · CPT Initiatives (Decoupling (CDP2)), MediaWiki-Maintenance-scripts

Jun 5 2019

BPirkle added a comment to T224368: Ensure Linker::userLink is not called with empty user name.

The first item in the description turns out to be actual bad data rather than user suppression. @daniel , I dug into this further after we discussed it in our 1:1. My initial analysis failed to consider actor migration. It turns out there is less bad data than I originally thought. Specifically, there is exactly one bad row of this particular type. Details follow.

Jun 5 2019, 8:05 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging

Jun 4 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

I concur with @EvanProdromou . I'm glad we investigated doing this in code, but my takeaway is that a code-based solution is unnecessarily awkward, and a configuration-based solution is sufficient and appropriate.

Jun 4 2019, 4:19 PM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))

May 30 2019

BPirkle claimed T224368: Ensure Linker::userLink is not called with empty user name.
May 30 2019, 4:22 AM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Core Platform Team Workboards (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging

May 29 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

As discussed on IRC, another alternative is to not make any code changes, and instead simply require both MediaWiki core and Kask to have the same TTL setting.

May 29 2019, 2:52 PM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))

May 28 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

Speculative code posted. While this may not be the right answer, it gives us something solid to critique.

May 28 2019, 3:36 AM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))

May 24 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

Is $wgObjectCacheSessionExpiry specific to session storage? Could we override the default with something obviously contrived (-1?)

May 24 2019, 2:58 PM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))

May 21 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

Oh, and FWIW, it is possible to configure RESTBagOStuff to send a cache-control header to Kask in the current implementation, with no code changes, as follows (tested on my local, hence 127.0.01.)

May 21 2019, 11:13 PM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))
BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

We're done when we've...

checked MediaWiki code to see if we set different session TTLs for different sessions within a wiki for some reason
checked if we have session TTLs set at different values for different wikis
May 21 2019, 11:09 PM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))

May 16 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

RESTBagOStuff internally uses MultiHttpClient for communications, which supports TLS + signed certs. I haven't actually tried this, but the code looks solid.

May 16 2019, 2:57 AM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans

May 15 2019

BPirkle added a comment to T222908: Determine if set-if-not-exists method is necessary for session storage.

I agree that the existing SessionManager code doesn't use the add() function (or any of the other functions that call it). And add() already has a TODO indicating that it is not atomic, so I think we're good. I'm hesitant to add logging, given that RESTBagOStuff is a general-purpose class that may be used in the future for things other than session storage. Logging that made sense when the class was used for one purpose might be nonsensical in another.

May 15 2019, 11:25 PM · Core Platform Team Workboards (Done with CPT), Core Platform Team (Session Management Service (CDP2))

May 6 2019

BPirkle claimed T222529: Wikimedia\Assert\ParameterAssertionException when rendering a log snippet and log_user_text is empty.

I'll pick up where @Simetrical left off.

May 6 2019, 5:22 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MediaWiki-Logging, MediaWiki-Revision-backend, Wikimedia-production-error

May 2 2019

BPirkle claimed T222381: Force user ID to 0 when reading revisions from another wiki's database.

Sure. As this is prioritized as high, I'll transition to it shortly.

May 2 2019, 4:48 PM · CPT Initiatives (MCR), Core Platform Team Workboards (Done with CPT), MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Multi-Content-Revisions (Reactive)

Apr 29 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

First cut at a patch set posted. Per feedback, I made RESTBagOStuff configurable instead of creating a new KaskBagOStuff class. If we stay with this approach, we'll want to update a bunch of tickets that @EvanProdromou created (sorry).

Apr 29 2019, 9:51 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans

Apr 24 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Unless I'm missing something, @Anomie already did the bulk of the work for the first two (ApiQueryAllDeletedRevisions and ApiQueryDeletedRevisions) in commit 07842be3 as part of T200568, particularly by adding ApiQueryRevisionsBase::extractSlotInfo().

Apr 24 2019, 9:49 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Apr 23 2019

BPirkle added a comment to T217136: Unhandled internal error from page deletion during Special:MovePage (Fatal MWException).

I was indeed involved with the changes to delete via the job queue for pages with "many" revisions. However, I don't think that change is related to this issue. I was able to reproduce (on a local test wiki) the Internal Error behavior with AbuseFilter (plus an appropriate filter) on a version of Mediawiki from before T198176.

Apr 23 2019, 9:41 PM · MediaWiki-Special-pages, MediaWiki-Page-deletion, User-Daimona, User-revi, Wikimedia-production-error
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

I'm also seeing three few ungated ar_text_id references in core:

Apr 23 2019, 5:25 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Apr 17 2019

BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

I am not aware of any resolution or progress on this task (beyond @MaxSem 's abandoned patch above).

Apr 17 2019, 9:50 PM · observability, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (PHP7 (TEC4)), MediaWiki-Debug-Logger, serviceops-radar, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), wmerrors, Wikimedia-Logstash, Operations, User-herron, PHP 7.2 support, Performance-Team (Radar)
BPirkle added a comment to T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..

Ooops, too fast, there is an open patch needing review: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500755

Apr 17 2019, 2:33 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Apr 12 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

I have, on my local development wiki, a working KaskBagOStuff (naming suggestions welcome) that communicates with the development instance at deployment-sessionstore01.deployment-prep.eqiad.wmflabs (via some tricky port forwarding) and successfully allows basic session management for happy login and logout.

Out of curiosity, what is it that prevents you from using RESTBagOStuff?

Apr 12 2019, 2:44 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans
Eevans awarded T215533: Enable use of session storage service in MediaWiki a Cookie token.
Apr 12 2019, 2:32 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans

Apr 11 2019

BPirkle updated subscribers of T215533: Enable use of session storage service in MediaWiki.
Apr 11 2019, 10:24 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans
BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

I have, on my local development wiki, a working KaskBagOStuff (naming suggestions welcome) that communicates with the development instance at deployment-sessionstore01.deployment-prep.eqiad.wmflabs (via some tricky port forwarding) and successfully allows basic session management for happy login and logout.

Apr 11 2019, 10:15 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans

Apr 8 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Per discussion in this task, I created new task T220450 for the additional Postgres changes (searchindex table).

Apr 8 2019, 9:05 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
BPirkle created T220450: Make Postgres search use a searchindex table.
Apr 8 2019, 9:04 PM · Discovery-Search, MediaWiki-Search, PostgreSQL, Multi-Content-Revisions (Tech Debt), Technical-Debt

Apr 4 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

Relevant documentation: https://www.mediawiki.org/wiki/Requests_for_comment/SessionStorageAPI
Development instance is at deployment-sessionstore01.deployment-prep.eqiad.wmflabs

Apr 4 2019, 5:32 PM · Core Platform Team Workboards (Epics), Epic, CPT Initiatives (Session Management Service (CDP2)), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, User-Eevans
BPirkle added a comment to T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..

Usages found:

Apr 4 2019, 2:55 AM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Mar 21 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.
  • includes/search/SearchPostgres.php

odd stuff, maybe @Anomie can help. Two uses seem completely pointless, the third one should probably use getQueryInfo?

Note in the PostgreSQL schema the "text" table is named "pagecontent". That was done in rSVN15791; I don't know why quoting wasn't just used instead. The plan for T164898/T191231 includes renaming it back to "text".
It looks like that file needs some Technical-Debt cleanup to use the IDatabase querying methods rather than building SQL strings directly, but that alone would probably be out of scope here.
What is in scope is that it's trying to search directly against the text table, having added an extra column for that purpose, and will need to be converted to use a searchindex table like MySQL does.

Mar 21 2019, 3:38 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Mar 14 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Here's one place where Daniel and I differ: I'd put most of these in one patch instead of having 10+ single-file changes.

Ok, compromise: one patch for SearchPostgres, one for checkStorage.php and compressOld.php, and one for the rest.

Mar 14 2019, 8:46 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Mar 13 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated)

getQueryInfo() should have proper gating as well. If you think it does not, let's talk before you change things.

Mar 13 2019, 10:05 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

MessageCache.php was not listed in my previous comment, because I've already incorporated Daniel's patch from June into my local codebase, but that'll be part of the final change as well.

Mar 13 2019, 6:07 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
BPirkle updated subscribers of T198341: Remove all references to the rev_text_id and ar_text_id fields.

Thank you. With that in mind, here's my current understanding. The list below applies only to rev_text_id, not ar_text_id or text.old_id. When touching code for rev_text_id, I'll also remove any references to the other two fields. I'll then loop back and review/remove any remaining references to them.

Mar 13 2019, 3:57 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Thank you. Will ping Tim on that one when it is daylight for him.

Mar 13 2019, 2:16 PM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Question on one occurrence of these fields: is the maintenance script fixT22757.php still relevant?

Mar 13 2019, 4:19 AM · Structured-Data-Backlog, CPT Initiatives (MCR Schema Migration), Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Structured Data Engineering, Patch-For-Review, Wikidata

Mar 8 2019

BPirkle added a comment to T202352: Convert MultiHttpClient to use Guzzle.

@hashar , sorry for the inconvenience, I'm glad reverting the change made things happy again.

Mar 8 2019, 4:54 AM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), MediaWiki-General

Mar 5 2019

Krinkle awarded T202352: Convert MultiHttpClient to use Guzzle a Orange Medal token.
Mar 5 2019, 11:34 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), MediaWiki-General
BPirkle added a comment to T207977: deprecate Language::viewPrevNext.

My comment with the Deprecation policy link was simply because we were discussing the possibility of an external contractor working on this task, and the link seemed relevant to have available. Sorry, I should have included context.

Mar 5 2019, 4:12 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Technical-Debt (Deprecation), Core Platform Team Workboards (Team 3), MediaWiki-extensions-General, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review

Mar 4 2019

BPirkle added a comment to T207977: deprecate Language::viewPrevNext.

Deprecation policy: https://www.mediawiki.org/wiki/Deprecation_policy

Mar 4 2019, 2:42 PM · MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), Technical-Debt (Deprecation), Core Platform Team Workboards (Team 3), MediaWiki-extensions-General, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review

Feb 28 2019

BPirkle reassigned T214317: Phase out deprecated Title::isValidMoveTarget from BPirkle to Hknust.
Feb 28 2019, 8:24 PM · CPT Initiatives (Decoupling (CDP2)), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management
BPirkle reassigned T214316: Remove unused method Title::validateFileMoveOperation from BPirkle to Hknust.
Feb 28 2019, 8:23 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Feb 26 2019

BPirkle added a comment to T214316: Remove unused method Title::validateFileMoveOperation.

This is a protected function that has existed since at least 1.32 (although it appeared to be unused in core there too, I didn't check extensions yet).

Feb 26 2019, 6:09 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Workboards (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management