Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (110 w, 2 d)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Tue, Aug 11

BPirkle removed a project from T260062: Jobqueue warnings for old processMediaModeration jobs should be turned off: Platform Team Workboards (Clinic Duty Team).

Made this a subtask of T256982 and removed clinic duty. @eprodromou can schedule this for implementation.

Tue, Aug 11, 8:31 PM · WMF-JobQueue, MediaWiki-extensions-MediaModeration
BPirkle added a subtask for T256982: MediaModeration Productionizing: T260062: Jobqueue warnings for old processMediaModeration jobs should be turned off.
Tue, Aug 11, 8:30 PM · Epic, Platform Team Workboards (Epics), Platform Team Initiatives (Hash Checking)
BPirkle added a parent task for T260062: Jobqueue warnings for old processMediaModeration jobs should be turned off: T256982: MediaModeration Productionizing.
Tue, Aug 11, 8:30 PM · WMF-JobQueue, MediaWiki-extensions-MediaModeration
BPirkle removed a project from T187518: Contributions of imported users can not be displayed: Platform Engineering.
Tue, Aug 11, 8:27 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), MediaWiki-Export-or-Import
BPirkle edited projects for T226337: SpecialConfirmEmail causes "MWException: CAS update failed on user_touched" from User.php, added: Platform Team Workboards (External Code Reviews); removed Platform Engineering.
Tue, Aug 11, 8:27 PM · Platform Team Workboards (External Code Reviews), Patch-For-Review, Performance-Team (Radar), Sustainability, Wikimedia-production-error, MediaWiki-User-preferences
BPirkle added a comment to T187518: Contributions of imported users can not be displayed.

Untagging Platform Team, retag us if code review is necessary. We put related task T259962 into our External Code Review column.

Tue, Aug 11, 8:24 PM · MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), MediaWiki-Export-or-Import
BPirkle moved T258480: Query plan changes on enwiki.revision queries with MCR change from Discussing to Next on the Platform Team Workboards (Clinic Duty Team) board.
Tue, Aug 11, 8:20 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR Schema Migration)
BPirkle edited projects for T258480: Query plan changes on enwiki.revision queries with MCR change, added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Tue, Aug 11, 8:20 PM · Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR Schema Migration)
BPirkle moved T259771: RFC: Drop support for database upgrade older than two LTS releases from Inbox to Feature Requests to Review on the Platform Engineering board.
Tue, Aug 11, 8:19 PM · MediaWiki-Stakeholders-Group, Platform Engineering, TechCom-RFC
BPirkle edited projects for T259962: Beta cluster main page fails to load with a linker error, added: Platform Team Workboards (External Code Reviews); removed Platform Engineering.
Tue, Aug 11, 8:18 PM · Platform Team Workboards (External Code Reviews), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), MediaWiki-Export-or-Import, Beta-Cluster-reproducible, Wikimedia-production-error
BPirkle triaged T259960: Inject services into API modules and special pages as Low priority.
Tue, Aug 11, 8:14 PM · Platform Engineering, TechCom, Dependency injection, MediaWiki-Special-pages, MediaWiki-API
BPirkle moved T260099: Special:ApiSandbox should note internal modules from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Tue, Aug 11, 8:11 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-Documentation, MediaWiki-API, User-DannyS712
BPirkle triaged T260099: Special:ApiSandbox should note internal modules as Low priority.
Tue, Aug 11, 8:11 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-Documentation, MediaWiki-API, User-DannyS712
BPirkle moved T260179: The ApiQueryDescription should handle Chinese language variant correctly from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Tue, Aug 11, 8:08 PM · Chinese-Sites, Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Wikidata
BPirkle triaged T260179: The ApiQueryDescription should handle Chinese language variant correctly as Medium priority.
Tue, Aug 11, 8:07 PM · Chinese-Sites, Platform Team Workboards (Clinic Duty Team), MediaWiki-API, Wikidata

Thu, Aug 6

BPirkle moved T259448: Fatal Error running update.php: Circular dependency when creating service in DBLoadBalancerFactory from Next to Done on the Platform Team Workboards (Clinic Duty Team) board.
Thu, Aug 6, 7:09 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, Wikimedia-Rdbms

Wed, Aug 5

BPirkle added a comment to T259448: Fatal Error running update.php: Circular dependency when creating service in DBLoadBalancerFactory.

I tried a few things and was unable to reproduce this. @Ablum010777, can you update to the latest 1.35 code and see if this still occurs?

Wed, Aug 5, 9:37 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, Wikimedia-Rdbms
BPirkle added a comment to T259448: Fatal Error running update.php: Circular dependency when creating service in DBLoadBalancerFactory.

From the stack trace:

Wed, Aug 5, 6:23 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, Wikimedia-Rdbms
BPirkle added a comment to T259043: Write unit tests for new endpoints in the OAuth extension.

General rule: our unit tests should test contracts, not implementations. In other words, test what the class/interface/handler is supposed to do, rather than using special knowledge about how it accomplishes it. (Note: testing failures is fine, failing according to contract is super important)

Wed, Aug 5, 3:56 PM · Patch-For-Review, Platform Team Workboards (S&F Workboard), Platform Team Initiatives (API Gateway), MediaWiki-extensions-OAuth

Tue, Aug 4

BPirkle added a comment to T207535: Rendering of \oinit very dense.

Two deployment notes, by the way:

Tue, Aug 4, 10:09 PM · Platform Team Workboards (External Code Reviews), User-Physikerwelt, Patch-For-Review, Math
BPirkle added a comment to T207535: Rendering of \oinit very dense.

All steps completed. How do we confirm it works as intended?

Tue, Aug 4, 9:54 PM · Platform Team Workboards (External Code Reviews), User-Physikerwelt, Patch-For-Review, Math

Mon, Aug 3

BPirkle moved T258693: Discourage “traditional” / ANSI-89 JOINs (in WHERE instead of JOIN) in IDatabase documentation from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.
Mon, Aug 3, 7:59 PM · MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), Platform Team Workboards (External Code Reviews), Wikimedia-Rdbms, Sustainability (Incident Followup)

Thu, Jul 30

BPirkle added a comment to T207535: Rendering of \oinit very dense.

We need to

Thu, Jul 30, 8:31 PM · Platform Team Workboards (External Code Reviews), User-Physikerwelt, Patch-For-Review, Math

Wed, Jul 29

BPirkle added a comment to T93273: UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php.

6 occurrences seen in logstash on 2020-07-29.

Wed, Jul 29, 6:59 PM · Structured-Data-Backlog, Wikibase-SDC-Shared, Wikidata-Campsite, Structured Data Engineering, Wikimedia-production-error, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Wikidata
BPirkle added a comment to T258641: Elastica\Exception\ResponseException from line 56 of /srv/mediawiki/php-1.35.0-wmf.41/extensions/GeoData/includes/Searcher.php: .

Seen in logstash on 2020-07-29:

Wed, Jul 29, 6:54 PM · Release-Engineering-Team (Logspam), Discovery-Search, GeoData, Wikimedia-production-error
BPirkle added a comment to T259004: Move muswiki and mhwiktionary (closed wikis) from s3 to s5.

See in logstash on 2020-07-29:

Wed, Jul 29, 6:50 PM · User-Urbanecm, Patch-For-Review, DBA
BPirkle created T259181: Use of Revision::getId was deprecated in MediaWiki 1.31. [Called from MediaWiki\Storage\DerivedPageDataUpdater::grabCurrentRevision].
Wed, Jul 29, 6:43 PM · User-brennen, Platform Team Workboards (Clinic Duty Team), User-DannyS712, AbuseFilter, Wikimedia-production-error
BPirkle added a project to T259179: Use of Article::getContentModel was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute]: Platform Engineering.
Wed, Jul 29, 6:41 PM · Platform Team Workboards (Clinic Duty Team), AbuseFilter, Wikimedia-production-error
BPirkle created T259180: Use of Article::prepareContentForEdit was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute].
Wed, Jul 29, 6:41 PM · Platform Team Workboards (Clinic Duty Team), AbuseFilter, Wikimedia-production-error
BPirkle created T259179: Use of Article::getContentModel was deprecated in MediaWiki 1.35. [Called from AFComputedVariable::compute].
Wed, Jul 29, 6:36 PM · Platform Team Workboards (Clinic Duty Team), AbuseFilter, Wikimedia-production-error
BPirkle created T259177: TimedMediaHandler: PHP Notice: Undefined offset: 1.
Wed, Jul 29, 6:28 PM · User-brennen, TimedMediaHandler, Wikimedia-production-error
BPirkle updated the task description for T259175: MediaWiki::restInPeace: transaction round 'UpdateBetaFeatureUserCountsJob::run' still running.
Wed, Jul 29, 6:25 PM · BetaFeatures, Wikimedia-production-error
BPirkle created T259175: MediaWiki::restInPeace: transaction round 'UpdateBetaFeatureUserCountsJob::run' still running.
Wed, Jul 29, 6:24 PM · BetaFeatures, Wikimedia-production-error

Tue, Jul 28

BPirkle added a comment to T207535: Rendering of \oinit very dense.

To be able to publish the packages to npm I need to your npm account name. Can you please send it to me either in this ticket or via email?

Tue, Jul 28, 6:26 PM · Platform Team Workboards (External Code Reviews), User-Physikerwelt, Patch-For-Review, Math
BPirkle updated the task description for T259001: Add relevant people of the core services team (and others) to the npm repo for mathoid and its dependencies.
Tue, Jul 28, 6:23 PM · Platform Team Workboards (External Code Reviews), User-Physikerwelt, Math
BPirkle added a comment to T259022: Revision 105215021 belongs to page ID 2442048, the provided Title object belongs to page ID 8437055.

I'm no train log triage expert, so I could be misinterpreting. But looking back over the last couple of months, I'm seeing this in multiple mediawiki versions, and I'm not seeing an enormous spike in recent frequency. Maybe the last few days have been slightly higher, but not by orders of magnitude. So from a train conductor's perspective, I'm not seeing anything worthy of train blocking.

Tue, Jul 28, 6:04 PM · MediaWiki-extensions-Scribunto, MediaWiki-Parser, Wikimedia-production-error
BPirkle added a comment to T259022: Revision 105215021 belongs to page ID 2442048, the provided Title object belongs to page ID 8437055.

If I'm reading this correctly, the error is occurring in 1.36.0-wmf.1, but 9bd04f784566 didn't hit until 1.36.0-wmf.2. Let me know if I'm not looking at that correctly.

Tue, Jul 28, 5:11 PM · MediaWiki-extensions-Scribunto, MediaWiki-Parser, Wikimedia-production-error
BPirkle updated subscribers of T259022: Revision 105215021 belongs to page ID 2442048, the provided Title object belongs to page ID 8437055.

Will look at this sometime today if someone doesn't beat me to it. Daniel is out this week. Adding @Pchelolo and @DannyS712 (who have also recently worked on Revision code) and @CCicalese_WMF (who is currently on Platform Team Clinic Duty).

Tue, Jul 28, 3:14 PM · MediaWiki-extensions-Scribunto, MediaWiki-Parser, Wikimedia-production-error

Mon, Jul 27

BPirkle claimed T207535: Rendering of \oinit very dense.

Sure thing. I am not yet familiar with backporting upstream mathjax changes, so (as @Physikerwelt said) this will take some extra time for learning. But that's knowledge I need to acquire anyway, so should be time well spent.

Mon, Jul 27, 5:36 PM · Platform Team Workboards (External Code Reviews), User-Physikerwelt, Patch-For-Review, Math
BPirkle closed T257804: Update docs/hooks.txt to reflect the new hook system. as Resolved.
Mon, Jul 27, 3:50 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation

Fri, Jul 17

Akuckartz awarded T257804: Update docs/hooks.txt to reflect the new hook system. a Like token.
Fri, Jul 17, 4:56 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation

Jul 15 2020

BPirkle claimed T257804: Update docs/hooks.txt to reflect the new hook system..
Jul 15 2020, 8:52 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation
BPirkle moved T257804: Update docs/hooks.txt to reflect the new hook system. from Ready to Doing on the Platform Team Workboards (Clinic Duty Team) board.
Jul 15 2020, 8:52 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation

Jul 14 2020

BPirkle moved T252812: Investigate watchlist sizes (limiting or handling large ones properly) from Inbox to Discussing on the Platform Team Workboards (Clinic Duty Team) board.

@tstarling , do you have any thoughts here? (Note to other people on this task - Tim is on vacation until July 20, so an answer may be delayed.)

Jul 14 2020, 9:01 PM · Platform Team Workboards (Clinic Duty Team), Community-Tech (Kanban-2020-21-Q1), Expiring-Watchlist-Items
BPirkle edited projects for T252812: Investigate watchlist sizes (limiting or handling large ones properly), added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Jul 14 2020, 9:00 PM · Platform Team Workboards (Clinic Duty Team), Community-Tech (Kanban-2020-21-Q1), Expiring-Watchlist-Items
BPirkle added a comment to T257124: Page is blank when edited a page on gomwiktionary with VisualEditor (new pages are missing on some RESTBase servers).

@JTannerWMF , we are trying to triage this and it is unclear what is needed. Review on the patch, or does something need to be done to RESTBase?

Jul 14 2020, 8:55 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Editing-team (Tracking), Platform Team Workboards (Clinic Duty Team), RESTBase, VisualEditor
BPirkle moved T257583: Run EventBus tests in MediaWiki core CI from Inbox to Tracking/Watching on the Platform Engineering board.
Jul 14 2020, 8:45 PM · Analytics-Radar, Platform Engineering, Event-Platform, WMF-JobQueue, ChangeProp, Release-Engineering-Team
BPirkle triaged T257586: ExtensionRegistry is difficult to use as a singleton as Low priority.
Jul 14 2020, 8:44 PM · MediaWiki-General, Platform Engineering
BPirkle triaged T257620: Beta cluster changeprop job queue down since 2020-06-18 as Medium priority.
Jul 14 2020, 8:42 PM · Platform Engineering, Beta-Cluster-Infrastructure
BPirkle moved T257965: [Bug] page/summary and page/mobile-html do not handle specific redirect titles correctly from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Jul 14 2020, 8:40 PM · Platform Team Workboards (Clinic Duty Team), RESTBase, Page Content Service, Product-Infrastructure-Team-Backlog
BPirkle triaged T257965: [Bug] page/summary and page/mobile-html do not handle specific redirect titles correctly as Medium priority.

@Pchelolo , any thoughts here?

Jul 14 2020, 8:39 PM · Platform Team Workboards (Clinic Duty Team), RESTBase, Page Content Service, Product-Infrastructure-Team-Backlog
BPirkle removed a project from T257662: Add watchuser to unblock API: Platform Engineering.

Removing tag that was auto-added by Herald. Retag if there's work for CPT here.

Jul 14 2020, 8:37 PM · MediaWiki-Blocks, MediaWiki-API
BPirkle removed a project from T257755: Changing the PostgreSQL MediaWiki schema to use BYTEA where MySQL uses VARBINARY / VARCHAR BINARY would break SQL queries: Platform Engineering.

Please retag if there's work for CPT on this.

Jul 14 2020, 8:32 PM · Platform Engineering, Wikimedia-Rdbms, PostgreSQL
BPirkle triaged T257789: Update stability annotations to conform to new policy. as High priority.
Jul 14 2020, 8:30 PM · MediaWiki-Stakeholders-Group, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Documentation, MW-1.35-release
BPirkle triaged T257800: Replace direct constructor of Parser with calls to ParserFactory in extensions as Medium priority.
Jul 14 2020, 8:26 PM · MediaWiki-Parser, patch-welcome, Platform Engineering, Platform Team Initiatives (Decoupling (CDP2))
BPirkle moved T257802: Backport SameSite fixes to all supported MediaWiki branches from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Jul 14 2020, 8:24 PM · Platform Team Workboards (Clinic Duty Team), MW-1.34-release, MW-1.31-release, MediaWiki-General
BPirkle triaged T257802: Backport SameSite fixes to all supported MediaWiki branches as Medium priority.
Jul 14 2020, 8:23 PM · Platform Team Workboards (Clinic Duty Team), MW-1.34-release, MW-1.31-release, MediaWiki-General
BPirkle moved T257804: Update docs/hooks.txt to reflect the new hook system. from Next to Ready on the Platform Team Workboards (Clinic Duty Team) board.
Jul 14 2020, 8:21 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation
BPirkle moved T257804: Update docs/hooks.txt to reflect the new hook system. from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Jul 14 2020, 8:20 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation
BPirkle triaged T257804: Update docs/hooks.txt to reflect the new hook system. as High priority.

hooks.txt already references Hooks.md. It seems like we can simply eliminate everything from hooks.txt except the first sentence.

Jul 14 2020, 8:20 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.1; 2020-07-21), Platform Team Workboards (Clinic Duty Team), MW-1.35-release, MediaWiki-Core-Hooks, Documentation
BPirkle edited projects for T257838: Model contributions as distinct from revisions, added: Platform Team Workboards (Green); removed Platform Engineering.
Jul 14 2020, 8:13 PM · Platform Team Sprints Board (Sprint 1), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
BPirkle edited projects for T257839: Only include page revisions in the contributions endpoints, added: Platform Team Workboards (Green); removed Platform Engineering.
Jul 14 2020, 8:12 PM · Platform Team Sprints Board (Sprint 1), MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Platform Team Workboards (Green), MediaWiki-REST-API, Platform Team Initiatives (MW REST API in PHP)
BPirkle moved T257944: [EPIC] Article description editing API from Inbox to Feature Requests to Review on the Platform Engineering board.
Jul 14 2020, 8:09 PM · Epic, Platform Engineering
BPirkle added a comment to T233537: Document and communicate potentially breaking session storage serialization change.

Status note: related tasks T233963: Add serialization options to RESTBagOStuff and T234779: Removed deprecated "legacy" serialization type from RESTBagOStuff are complete. RESTBagOStuff now supports (only) PHP and JSON serialization types, with (optional) hmac protection. It is in use on production wikis of all groups to store sessions in Kask, using PHP serialization and hmac protection.

Jul 14 2020, 1:48 PM · Platform Team Initiatives (Session Management Service (CDP2))

Jul 13 2020

BPirkle closed T234779: Removed deprecated "legacy" serialization type from RESTBagOStuff as Resolved.
Jul 13 2020, 8:18 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), MediaWiki-Cache, Technical-Debt (Deprecation process), MW-1.35-release
BPirkle closed T256127: Improve logging for "Main slot of revision (number) not found in database!", a subtask of T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!, as Resolved.
Jul 13 2020, 2:19 PM · Platform Team Workboards (Clinic Duty Team), User-brennen, Platform Team Initiatives (MCR), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Wikimedia-production-error
BPirkle closed T256127: Improve logging for "Main slot of revision (number) not found in database!" as Resolved.
Jul 13 2020, 2:19 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR), MediaWiki-Revision-backend, Multi-Content-Revisions

Jul 2 2020

BPirkle claimed T256127: Improve logging for "Main slot of revision (number) not found in database!".
Jul 2 2020, 2:15 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR), MediaWiki-Revision-backend, Multi-Content-Revisions
BPirkle moved T256127: Improve logging for "Main slot of revision (number) not found in database!" from Ready to Doing on the Platform Team Workboards (Clinic Duty Team) board.
Jul 2 2020, 2:15 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR), MediaWiki-Revision-backend, Multi-Content-Revisions
BPirkle added a comment to T256127: Improve logging for "Main slot of revision (number) not found in database!".

Looking a bit more, RevisionStore::constructSlotRecords (the function that throws the exception in question) already logs related diagnostic info via $this->logger->info(), so I followed that same pattern for the new log message with revision id.

Jul 2 2020, 2:14 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR), MediaWiki-Revision-backend, Multi-Content-Revisions

Jun 30 2020

BPirkle added a comment to T256766: Disallow public access to OAuth client ID management API.

I do not believe this an actual security concern from a technical/code perspective. However, it may be a concern from a policy/legal perspective.

Jun 30 2020, 6:38 PM · Platform Team Initiatives (API Gateway)

Jun 25 2020

BPirkle added a comment to T253083: Create Core REST API examples in PHP.

Yep, that syntax would create the desired structure.

Jun 25 2020, 11:41 PM · Platform Team Initiatives (MW REST API in PHP), Platform Team Workboards (Green)
BPirkle added a comment to T255213: MW service factories supply local wiki config into services created for foreign wikis.

This sounds like the kind of thing that doesn't matter very much, until it does. Then it matters a lot, and is difficult to fix quickly.

Jun 25 2020, 3:58 PM · Platform Team Initiatives (Decoupling (CDP2)), Platform Engineering

Jun 24 2020

BPirkle moved T255842: Restoring default settings is not working in all wikis from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Jun 24 2020, 8:58 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.4; 2020-08-11), Platform Team Workboards (Clinic Duty Team), Contributors-Team, Tech-Ambassadors, Beta-Cluster-reproducible, Regression, MediaWiki-User-preferences
BPirkle edited projects for T255309: Remove UserRightsProxy and replace it's usages with UserGroupManager, added: Platform Team Initiatives (Decoupling (CDP2)); removed Platform Team Workboards (Clinic Duty Team).
Jun 24 2020, 8:57 PM · Platform Team Initiatives (Decoupling (CDP2)), MediaWiki-User-management
BPirkle moved T255684: Fix aggregation of change-prop exec time metric from Inbox to Doing on the Platform Team Workboards (Clinic Duty Team) board.
Jun 24 2020, 8:55 PM · ChangeProp, WMF-JobQueue, Platform Team Workboards (Clinic Duty Team)
BPirkle triaged T256296: Fatal exception from FlaggedRevs: "Flagged revision with ID … exists with unexpected fr_page_id" as Medium priority.
Jun 24 2020, 8:52 PM · Platform Team Workboards (Clinic Duty Team), User-brennen, MediaWiki-extensions-FlaggedRevs, Wikimedia-production-error
BPirkle removed a project from T246284: Hard deprecate the Revision class: Platform Engineering.

Already in CPT External Code Reviews, so untagging CPT so that it moves out of the inbox.

Jun 24 2020, 8:48 PM · MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Platform Engineering, Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712
BPirkle moved T256287: "Database selection is disallowed to enable reuse" is badly worded from Inbox to Doing on the Platform Team Workboards (Clinic Duty Team) board.
Jun 24 2020, 8:47 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MW-1.34-notes, Patch-For-Review, Developer Productivity, Platform Team Workboards (Clinic Duty Team), Performance-Team, Wikimedia-Rdbms
BPirkle edited projects for T256287: "Database selection is disallowed to enable reuse" is badly worded, added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Jun 24 2020, 8:47 PM · MW-1.35-notes, MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MW-1.34-notes, Patch-For-Review, Developer Productivity, Platform Team Workboards (Clinic Duty Team), Performance-Team, Wikimedia-Rdbms
BPirkle removed a project from T255202: Logstash messages for DBQueryError should contain the actual error: Platform Engineering.

Is this done?

Jun 24 2020, 8:46 PM · MW-1.35-notes (1.35.0-wmf.38; 2020-06-23), Performance-Team, Wikimedia-Rdbms, Developer Productivity
BPirkle edited projects for T155395: Create documentation about the proper use of the dependency injection infrastructure in MediaWiki , added: Platform Team Workboards (Green); removed Platform Engineering.

Adding @apaskulin as a subscriber.

Jun 24 2020, 8:44 PM · Dependency injection, MediaWiki-Documentation, MediaWiki-General, Documentation, User-Daniel
BPirkle removed a project from T242083: test_page_from_repository fails with EntityTypeUnknownException on multiple sites: Platform Engineering.
Jun 24 2020, 8:42 PM · MediaWiki-API, Upstream, Pywikibot-Wikidata, Pywikibot, Pywikibot-tests
BPirkle moved T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Jun 24 2020, 8:40 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)
BPirkle edited projects for T255056: MediaWikiIntegrationTestCase::setTemporaryHook needs to support new style hooks , added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Jun 24 2020, 8:40 PM · MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (New Hook System)
BPirkle edited projects for T255700: "Bad content model: expected wikitext but got javascript" while saving/stashing an edit, added: Platform Team Workboards (External Code Reviews); removed Platform Engineering.
Jun 24 2020, 8:38 PM · Performance-Team, Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-API, MediaWiki-Revision-backend, Wikimedia-production-error
BPirkle removed a project from T255804: overzealous throttling on Wikidata: Platform Engineering.

Untagging CPT as this may not actually be an issue. Retag us if needed.

Jun 24 2020, 8:35 PM · Wikidata-Campsite, Wikidata
BPirkle lowered the priority of T35186: Provide a well-performing API to rotate an image from High to Low.
Jun 24 2020, 8:33 PM · Platform Engineering, Patch-Needs-Improvement, Multimedia, Contributors-Team, MediaWiki-Uploading, Commons, MediaWiki-API
BPirkle moved T256127: Improve logging for "Main slot of revision (number) not found in database!" from Inbox to Ready on the Platform Team Workboards (Clinic Duty Team) board.
Jun 24 2020, 8:29 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR), MediaWiki-Revision-backend, Multi-Content-Revisions
BPirkle edited projects for T256127: Improve logging for "Main slot of revision (number) not found in database!", added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.
Jun 24 2020, 8:29 PM · MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), Patch-For-Review, Platform Team Workboards (Clinic Duty Team), Platform Team Initiatives (MCR), MediaWiki-Revision-backend, Multi-Content-Revisions
BPirkle closed T165851: Combo boxes in Special:ApiSandbox > main do not show what is typed as Declined.

Declining. Reopen if you think this is important.

Jun 24 2020, 8:26 PM · MediaWiki-Special-pages, Platform Engineering, Design, MediaWiki-API
BPirkle moved T255907: alreadyblocked error when reblocking IP range with unnormalized block address via API from Inbox to Next on the Platform Team Workboards (Clinic Duty Team) board.
Jun 24 2020, 8:22 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-API, MediaWiki-Blocks
BPirkle triaged T255907: alreadyblocked error when reblocking IP range with unnormalized block address via API as Medium priority.
Jun 24 2020, 8:21 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-API, MediaWiki-Blocks
BPirkle triaged T256006: Test fails with "Can't reopen table" error. as Medium priority.
Jun 24 2020, 8:19 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), Tracking-Neverending, Platform Engineering, MediaWiki-Core-Testing, Wikimedia-Rdbms, Testing-Roadblocks
BPirkle triaged T256141: Remove/archive remaining legacy Change Propagation components as Medium priority.

Already assigned to @hnowlan , so moving to Green Team board.

Jun 24 2020, 8:15 PM · Platform Team Sprints Board (Sprint 1), Platform Team Workboards (Green), ChangeProp
BPirkle added a comment to T256298: TypeError from line 27 of /srv/mediawiki/tags/2020-06-24_17:40:57/extensions/Thanks/includes/ThanksHooks.php: Argument 1 passed to ThanksHooks::insertThankLink() must be an instance of MediaWiki\Revision\RevisionRecord, bool given.

@DannyS712 , moved this to CPT watching, but please reach out to us if we can help.

Jun 24 2020, 8:11 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), User-DannyS712, Platform Engineering, Thanks, affects-translatewiki.net, Growth-Team
BPirkle moved T256298: TypeError from line 27 of /srv/mediawiki/tags/2020-06-24_17:40:57/extensions/Thanks/includes/ThanksHooks.php: Argument 1 passed to ThanksHooks::insertThankLink() must be an instance of MediaWiki\Revision\RevisionRecord, bool given from Inbox to Tracking/Watching on the Platform Engineering board.
Jun 24 2020, 8:10 PM · MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), User-DannyS712, Platform Engineering, Thanks, affects-translatewiki.net, Growth-Team
BPirkle moved T256305: Fatal Error: Class MediaWiki\HookContainer\HookRunner contains 1 abstract method and must therefore be declared abstract from Inbox to Ready on the Platform Team Workboards (Clinic Duty Team) board.

@tstarling , does this make any sense to you?

Jun 24 2020, 8:08 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-Change-tagging, MediaWiki-Core-Hooks, Commons, Wikimedia-production-error
BPirkle edited projects for T256305: Fatal Error: Class MediaWiki\HookContainer\HookRunner contains 1 abstract method and must therefore be declared abstract, added: Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

Unclear how this would have worked on group0. We will look into it further to see what we can learn.

Jun 24 2020, 8:07 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-Change-tagging, MediaWiki-Core-Hooks, Commons, Wikimedia-production-error

Jun 23 2020

BPirkle added a subtask for T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!: T256127: Improve logging for "Main slot of revision (number) not found in database!".
Jun 23 2020, 2:02 PM · Platform Team Workboards (Clinic Duty Team), User-brennen, Platform Team Initiatives (MCR), MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Wikimedia-production-error