Page MenuHomePhabricator

BPirkle (BPirkle)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 4 2018, 5:34 PM (50 w, 4 d)
Availability
Available
LDAP User
BPirkle
MediaWiki User
BPirkle (WMF) [ Global Accounts ]

Recent Activity

Fri, Jun 14

BPirkle added a comment to T222099: Staging release of RESTBagOStuff using Kask.

What happens if we (in repository mediawiki-config):

Fri, Jun 14, 1:58 AM · Core Platform Team Kanban (Team 2), User-Clarakosi, Core Platform Team (Session Management Service (CDP2)), User-Eevans
BPirkle added a comment to T224993: Example configuration clauses for using RESTBagOStuff with Kask.

T220401 contains deployment details. Here's the relevant part, in action:

Fri, Jun 14, 1:48 AM · Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2))

Thu, Jun 13

BPirkle added a comment to T217829: Update populateRevisionSha1.php to run over the content table.

The task description currently reads "content_sha1 needs to be populated by the populateRevisionSha1.php script". However, unless I'm misunderstanding things, this would cause a chicken-and-egg problem.

Thu, Jun 13, 3:44 AM · Patch-For-Review, Core Platform Team Kanban (Team 3), MW-1.33-release, Multi-Content-Revisions (Reactive), Core Platform Team (Security, stability, performance and scalability (TEC1))

Tue, Jun 11

BPirkle added a comment to T200653: Error undeleting page: IncompleteRevisionException: sha1 field must not be !.

I'm looking into the related tasks (T217829 and T217831) now. Just a note for anyone who may read this in the future and may consider executing the query that was mentioned in earlier comments:

Tue, Jun 11, 3:45 PM · MW-1.31-release, MediaWiki-Revision-deletion, Multi-Content-Revisions

Mon, Jun 10

BPirkle added a comment to T224368: Ensure Linker::userLink is not called with empty user name.

I'll post the short-term fix to Linker::revUserTools() here. I also created T225469 for @Anomie 's maintenance script suggestion.

Mon, Jun 10, 9:57 PM · Patch-For-Review, Core Platform Team Kanban (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging
BPirkle created T225469: Create maintenance script for bad actor data cleanup.
Mon, Jun 10, 9:55 PM · MediaWiki-Maintenance-scripts, Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Team 3)

Wed, Jun 5

BPirkle added a comment to T224368: Ensure Linker::userLink is not called with empty user name.

The first item in the description turns out to be actual bad data rather than user suppression. @daniel , I dug into this further after we discussed it in our 1:1. My initial analysis failed to consider actor migration. It turns out there is less bad data than I originally thought. Specifically, there is exactly one bad row of this particular type. Details follow.

Wed, Jun 5, 8:05 PM · Patch-For-Review, Core Platform Team Kanban (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging

Tue, Jun 4

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

I concur with @EvanProdromou . I'm glad we investigated doing this in code, but my takeaway is that a code-based solution is unnecessarily awkward, and a configuration-based solution is sufficient and appropriate.

Tue, Jun 4, 4:19 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))

Thu, May 30

BPirkle claimed T224368: Ensure Linker::userLink is not called with empty user name.
Thu, May 30, 4:22 AM · Patch-For-Review, Core Platform Team Kanban (Team 3), Core Platform Team (Decoupling (CDP2)), MediaWiki-Revision-backend, MediaWiki-Logging

Wed, May 29

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

As discussed on IRC, another alternative is to not make any code changes, and instead simply require both MediaWiki core and Kask to have the same TTL setting.

Wed, May 29, 2:52 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))

Tue, May 28

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

Speculative code posted. While this may not be the right answer, it gives us something solid to critique.

Tue, May 28, 3:36 AM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))

May 24 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

Is $wgObjectCacheSessionExpiry specific to session storage? Could we override the default with something obviously contrived (-1?)

May 24 2019, 2:58 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))

May 21 2019

BPirkle added a comment to T222907: Determine if per-request TTLs are needed.

Oh, and FWIW, it is possible to configure RESTBagOStuff to send a cache-control header to Kask in the current implementation, with no code changes, as follows (tested on my local, hence 127.0.01.)

May 21 2019, 11:13 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))
BPirkle added a comment to T222907: Determine if per-request TTLs are needed.
We're done when we've...
 checked MediaWiki code to see if we set different session TTLs for different sessions within a wiki for some reason
 checked if we have session TTLs set at different values for different wikis
May 21 2019, 11:09 PM · Patch-For-Review, Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))

May 16 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

RESTBagOStuff internally uses MultiHttpClient for communications, which supports TLS + signed certs. I haven't actually tried this, but the code looks solid.

May 16 2019, 2:57 AM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans

May 15 2019

BPirkle added a comment to T222908: Determine if set-if-not-exists method is necessary for session storage.

I agree that the existing SessionManager code doesn't use the add() function (or any of the other functions that call it). And add() already has a TODO indicating that it is not atomic, so I think we're good. I'm hesitant to add logging, given that RESTBagOStuff is a general-purpose class that may be used in the future for things other than session storage. Logging that made sense when the class was used for one purpose might be nonsensical in another.

May 15 2019, 11:25 PM · Core Platform Team Kanban (Doing), Core Platform Team (Session Management Service (CDP2))

May 6 2019

BPirkle claimed T222529: Wikimedia\Assert\ParameterAssertionException when rendering a log snippet and log_user_text is empty.

I'll pick up where @Simetrical left off.

May 6 2019, 5:22 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MediaWiki-Logging, MediaWiki-Revision-backend, Wikimedia-production-error

May 2 2019

BPirkle claimed T222381: Force user ID to 0 when reading revisions from another wiki's database.

Sure. As this is prioritized as high, I'll transition to it shortly.

May 2 2019, 4:48 PM · MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), Patch-For-Review, Core Platform Team (MCR), Core Platform Team Kanban, Multi-Content-Revisions (Reactive)

Apr 29 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

First cut at a patch set posted. Per feedback, I made RESTBagOStuff configurable instead of creating a new KaskBagOStuff class. If we stay with this approach, we'll want to update a bunch of tickets that @EvanProdromou created (sorry).

Apr 29 2019, 9:51 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans

Apr 24 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Unless I'm missing something, @Anomie already did the bulk of the work for the first two (ApiQueryAllDeletedRevisions and ApiQueryDeletedRevisions) in commit 07842be3 as part of T200568, particularly by adding ApiQueryRevisionsBase::extractSlotInfo().

Apr 24 2019, 9:49 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Apr 23 2019

BPirkle added a comment to T217136: Unhandled internal error from page deletion during Special:MovePage (Fatal MWException).

I was indeed involved with the changes to delete via the job queue for pages with "many" revisions. However, I don't think that change is related to this issue. I was able to reproduce (on a local test wiki) the Internal Error behavior with AbuseFilter (plus an appropriate filter) on a version of Mediawiki from before T198176.

Apr 23 2019, 9:41 PM · MediaWiki-Special-pages, MediaWiki-Page-deletion, User-Daimona, User-revi, Wikimedia-production-error
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

I'm also seeing three few ungated ar_text_id references in core:

Apr 23 2019, 5:25 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Apr 17 2019

BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

I am not aware of any resolution or progress on this task (beyond @MaxSem 's abandoned patch above).

Apr 17 2019, 9:50 PM · serviceops, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), wmerrors, Wikimedia-Logstash, MediaWiki-Logging, Operations, User-herron, PHP 7.2 support, Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)
BPirkle added a comment to T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..

Ooops, too fast, there is an open patch needing review: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500755

Apr 17 2019, 2:33 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Apr 12 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

I have, on my local development wiki, a working KaskBagOStuff (naming suggestions welcome) that communicates with the development instance at deployment-sessionstore01.deployment-prep.eqiad.wmflabs (via some tricky port forwarding) and successfully allows basic session management for happy login and logout.

Out of curiosity, what is it that prevents you from using RESTBagOStuff?

Apr 12 2019, 2:44 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans
Eevans awarded T215533: Enable use of session storage service in MediaWiki a Cookie token.
Apr 12 2019, 2:32 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans

Apr 11 2019

BPirkle updated subscribers of T215533: Enable use of session storage service in MediaWiki.
Apr 11 2019, 10:24 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans
BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

I have, on my local development wiki, a working KaskBagOStuff (naming suggestions welcome) that communicates with the development instance at deployment-sessionstore01.deployment-prep.eqiad.wmflabs (via some tricky port forwarding) and successfully allows basic session management for happy login and logout.

Apr 11 2019, 10:15 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans

Apr 8 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Per discussion in this task, I created new task T220450 for the additional Postgres changes (searchindex table).

Apr 8 2019, 9:05 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle created T220450: Make Postgres search use a searchindex table.
Apr 8 2019, 9:04 PM · PostgreSQL, MediaWiki-Database, Multi-Content-Revisions (Tech Debt), Technical-Debt

Apr 4 2019

BPirkle added a comment to T215533: Enable use of session storage service in MediaWiki.

Relevant documentation: https://www.mediawiki.org/wiki/Requests_for_comment/SessionStorageAPI
Development instance is at deployment-sessionstore01.deployment-prep.eqiad.wmflabs

Apr 4 2019, 5:32 PM · MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Patch-For-Review, User-Clarakosi, Core Platform Team Backlog (Next), Core Platform Team (Session Management Service (CDP2)), User-Eevans
BPirkle added a comment to T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo()..

Usages found:

Apr 4 2019, 2:55 AM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 21 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.
  • includes/search/SearchPostgres.php

odd stuff, maybe @Anomie can help. Two uses seem completely pointless, the third one should probably use getQueryInfo?

Note in the PostgreSQL schema the "text" table is named "pagecontent". That was done in rSVN15791; I don't know why quoting wasn't just used instead. The plan for T164898/T191231 includes renaming it back to "text".

It looks like that file needs some Technical-Debt cleanup to use the IDatabase querying methods rather than building SQL strings directly, but that alone would probably be out of scope here.

What is in scope is that it's trying to search directly against the text table, having added an extra column for that purpose, and will need to be converted to use a searchindex table like MySQL does.

Mar 21 2019, 3:38 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 14 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Here's one place where Daniel and I differ: I'd put most of these in one patch instead of having 10+ single-file changes.

Ok, compromise: one patch for SearchPostgres, one for checkStorage.php and compressOld.php, and one for the rest.

Mar 14 2019, 8:46 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 13 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated)

getQueryInfo() should have proper gating as well. If you think it does not, let's talk before you change things.

Mar 13 2019, 10:05 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

MessageCache.php was not listed in my previous comment, because I've already incorporated Daniel's patch from June into my local codebase, but that'll be part of the final change as well.

Mar 13 2019, 6:07 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle updated subscribers of T198341: Remove all references to the rev_text_id and ar_text_id fields.

Thank you. With that in mind, here's my current understanding. The list below applies only to rev_text_id, not ar_text_id or text.old_id. When touching code for rev_text_id, I'll also remove any references to the other two fields. I'll then loop back and review/remove any remaining references to them.

Mar 13 2019, 3:57 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Thank you. Will ping Tim on that one when it is daylight for him.

Mar 13 2019, 2:16 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Question on one occurrence of these fields: is the maintenance script fixT22757.php still relevant?

Mar 13 2019, 4:19 AM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata

Mar 8 2019

BPirkle added a comment to T202352: Convert MultiHttpClient to use Guzzle.

@hashar , sorry for the inconvenience, I'm glad reverting the change made things happy again.

Mar 8 2019, 4:54 AM · Core Platform Team Kanban, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Mar 5 2019

Krinkle awarded T202352: Convert MultiHttpClient to use Guzzle a Orange Medal token.
Mar 5 2019, 11:34 PM · Core Platform Team Kanban, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown
BPirkle added a comment to T207977: remove prev/next message dependency from Language.

My comment with the Deprecation policy link was simply because we were discussing the possibility of an external contractor working on this task, and the link seemed relevant to have available. Sorry, I should have included context.

Mar 5 2019, 4:12 PM · Technical-Debt (Deprecation), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Core Platform Team Kanban (Team 3), MediaWiki-extensions-General, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review

Mar 4 2019

BPirkle added a comment to T207977: remove prev/next message dependency from Language.

Deprecation policy: https://www.mediawiki.org/wiki/Deprecation_policy

Mar 4 2019, 2:42 PM · Technical-Debt (Deprecation), MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), Core Platform Team Kanban (Team 3), MediaWiki-extensions-General, Core Platform Team (Decoupling (CDP2)), MediaWiki-Internationalization, Patch-For-Review

Feb 28 2019

BPirkle reassigned T214317: Phase out deprecated Title::isValidMoveTarget from BPirkle to Hknust.
Feb 28 2019, 8:24 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Decoupling (CDP2)), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management
BPirkle reassigned T214316: Remove unused method Title::validateFileMoveOperation from BPirkle to Hknust.
Feb 28 2019, 8:23 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Feb 26 2019

BPirkle added a comment to T214316: Remove unused method Title::validateFileMoveOperation.

This is a protected function that has existed since at least 1.32 (although it appeared to be unused in core there too, I didn't check extensions yet).

Feb 26 2019, 6:09 PM · Core Platform Team (Decoupling (CDP2)), Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management

Feb 20 2019

BPirkle added a comment to T216086: ErrorException from includes/HeaderCallback.php: PHP Notice: Undefined offset: 1.

Confirmed that the Guzzle-based MultiHttpClient code in T202352 is unaffected by this issue. So this issue will not reappear when that code is merged.

Feb 20 2019, 3:38 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Wikimedia-production-error

Feb 18 2019

BPirkle added a comment to T198341: Remove all references to the rev_text_id and ar_text_id fields.

Task description refers to "RevisionStore::newRevisionRecordFromRow()". Should that be "RevisionStore::newRevisionFromRow()"?

Feb 18 2019, 7:01 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198557: Remove support for legacy pre-MCR schema.

I was, however, able to claim T198341. I'll start there.

Feb 18 2019, 4:17 PM · MW-1.34-release, Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Later), Core Platform Team (MCR), Wikidata
BPirkle claimed T198341: Remove all references to the rev_text_id and ar_text_id fields.
Feb 18 2019, 4:16 PM · Core Platform Team Kanban (Doing), MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Multi-Content-Revisions (Tech Debt), Core Platform Team (MCR), SDC Engineering, Patch-For-Review, Wikidata
BPirkle added a comment to T198557: Remove support for legacy pre-MCR schema.

I'm happy to, but it appears that I cannot edit or claim the task.

Feb 18 2019, 4:12 PM · MW-1.34-release, Multi-Content-Revisions (Tech Debt), Core Platform Team Backlog (Later), Core Platform Team (MCR), Wikidata
BPirkle added a comment to T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .

Task description edited to include WMF-maintained extensions.

Feb 18 2019, 4:11 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler
BPirkle updated the task description for T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Feb 18 2019, 4:10 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Feb 13 2019

BPirkle added a comment to T213893: Allow extensions to define additional command line parameters to "update.php".

Per discussion with @tstarling , and consistent with discussion on the GitHub issue, I plan to add a hook allowing extensions to manipulate parameters to maintenance scripts. I'm now working out what the parameters to that hook should be, and how extensions should be allowed to manipulate these values.

Feb 13 2019, 12:47 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Doing), User-Nikerabbit, MediaWiki-Installer
BPirkle updated subscribers of T213893: Allow extensions to define additional command line parameters to "update.php".
Feb 13 2019, 12:34 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team (Security, stability, performance and scalability (TEC1)), Core Platform Team Kanban (Doing), User-Nikerabbit, MediaWiki-Installer

Feb 8 2019

BPirkle closed T214703: Change HttpRequestFactory default to guzzle as Resolved.

This has been merged

Feb 8 2019, 2:35 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review

Feb 5 2019

BPirkle updated the task description for T212175: Support callback functions in GuzzleHttpRequest and MultiHttpClient.
Feb 5 2019, 1:50 AM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Jan 25 2019

BPirkle updated subscribers of T214703: Change HttpRequestFactory default to guzzle.
Jan 25 2019, 4:31 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review
BPirkle moved T214703: Change HttpRequestFactory default to guzzle from Inbox to Ready on the Core Platform Team Kanban board.
Jan 25 2019, 4:30 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review
BPirkle created T214703: Change HttpRequestFactory default to guzzle.
Jan 25 2019, 4:20 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), Patch-For-Review
BPirkle placed T206296: PhpTags tests fail on PHP 7.1 up for grabs.
Jan 25 2019, 2:42 PM · Core Platform Team Backlog (Watching / External), PHP 7.1 support, MediaWiki-extensions-PhpTags
BPirkle closed T212175: Support callback functions in GuzzleHttpRequest and MultiHttpClient as Resolved.

Patch merged, this is complete

Jan 25 2019, 2:39 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Jan 22 2019

BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

We identified this task as a likely candidate for an outside contractor to complete, based on current team structure and availability. The goal is to restore logging of stack traces that would be lost in a switch to PHP7 / php-fpm.

Jan 22 2019, 3:42 PM · serviceops, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), wmerrors, Wikimedia-Logstash, MediaWiki-Logging, Operations, User-herron, PHP 7.2 support, Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)

Jan 17 2019

BPirkle added a comment to T202352: Convert MultiHttpClient to use Guzzle.

Security review was completed in Dec. 2018. The patch should now pass tests and is awaiting code review.

Jan 17 2019, 5:50 PM · Core Platform Team Kanban, Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Jan 16 2019

BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

Error and stack trace follows for a different failure (Failed to load blob) that generates the same exception. I've reviewed logs and thus far have found only these three types of failures (the one below, plus the two above) resulting in a RevisionAccessException. All three failure types occur multiple times in the logs.

Jan 16 2019, 11:45 PM · Core Platform Team Kanban (Team 3), MW-1.32-release, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
BPirkle claimed T155582: Deprecate Content::getNativeData(), defined TextContent::getText() to replace it. .
Jan 16 2019, 4:04 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Core Platform Team Kanban (Doing), Core Platform Team (Security, stability, performance and scalability (TEC1)), Patch-For-Review, Technical-Debt, User-Daniel, MediaWiki-ContentHandler

Jan 15 2019

BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

My local results for the api instance match what @Anomie described: a "200 OK" with a body including an api_internal_error code, as follows:

Jan 15 2019, 10:23 PM · Core Platform Team Kanban (Team 3), MW-1.32-release, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

First instance from above (the api one) reproduced locally by being evil to my database.

Jan 15 2019, 9:58 PM · Core Platform Team Kanban (Team 3), MW-1.32-release, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error
BPirkle added a comment to T212428: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database!.

Two examples from exception.log:

Jan 15 2019, 5:35 PM · Core Platform Team Kanban (Team 3), MW-1.32-release, MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), MediaWiki-Revision-backend, Multi-Content-Revisions (Reactive), Core Platform Team (MCR), Wikimedia-production-error

Dec 17 2018

BPirkle created T212175: Support callback functions in GuzzleHttpRequest and MultiHttpClient.
Dec 17 2018, 11:53 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Patch-For-Review, Core Platform Team (Code Health (TEC13)), MediaWiki-General-or-Unknown

Dec 15 2018

mmodell awarded T198176: Mediawiki page deletions should happen in batches of revisions a Barnstar token.
Dec 15 2018, 7:54 PM · Core Platform Team Kanban (Done with CPT), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Core Platform Team (Code Health (TEC13)), Wikimedia-production-error, Patch-For-Review, MediaWiki-Page-deletion

Dec 14 2018

BPirkle claimed T212005: PHP Notice: Undefined index: 1 from line 424 of includes/http/MWHttpRequest.php: .
Dec 14 2018, 9:37 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), MediaWiki-libs-HTTP, Wikimedia-production-error
BPirkle added a comment to T207530: Deleting pages on the English Wikipedia is very slow.

@Krinkle , have you seen evidence of an ongoing problem, or can we resolve this task?

Dec 14 2018, 4:38 AM · Performance-Team (Radar), MW-1.32-release, Operations, MediaWiki-Page-deletion

Dec 13 2018

BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

Looks good. Upload of a large file to test.wikipedia.org, which failed earlier today with the the "exceeded memory limit" error, now succeeds.

Dec 13 2018, 10:35 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

I think this is my error and not Guzzle's.

Dec 13 2018, 4:47 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

From fatal.log:

Dec 13 2018, 3:45 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle added a comment to T211886: Fatal error: request has exceeded memory limit in /srv/mediawiki/php-1.33.0-wmf.8/vendor/guzzlehttp/psr7/src/Stream.php on line 97 .

Agreed. Not a dupe, but appears related. I don't have an immediate answer for what's happening, but I'm looking as well.

Dec 13 2018, 3:19 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), MediaWiki-Vendor
BPirkle updated the task description for T176370: Migrate to PHP 7 in WMF production.
Dec 13 2018, 3:13 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
BPirkle closed T209981: Confirm that post-send functions work fine with mediawiki under PHP 7 as Resolved.

It seems that post-send functions work equivalently between php-fpm and hhvm. So I'm closing this task and marking it as complete on the php7 checklist. If we want to investigate/adjust timeouts and look at related concerns (queuing, etc.), let's do that under a separate task.

Dec 13 2018, 3:12 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle closed T209981: Confirm that post-send functions work fine with mediawiki under PHP 7, a subtask of T176370: Migrate to PHP 7 in WMF production, as Resolved.
Dec 13 2018, 3:12 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Dec 12 2018

BPirkle added a comment to T211806: Passing in the "body" request option as an array to send a POST request has been deprecated.

This looks more promising:

Dec 12 2018, 11:59 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Collection, Wikidata-Campsite, Wikidata, MediaWiki-extensions-JsonConfig, MediaWiki-Vendor
BPirkle added a comment to T211806: Passing in the "body" request option as an array to send a POST request has been deprecated.

Reproduced the exception locally using trivial test data:

Dec 12 2018, 10:40 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Collection, Wikidata-Campsite, Wikidata, MediaWiki-extensions-JsonConfig, MediaWiki-Vendor
BPirkle added a comment to T211806: Passing in the "body" request option as an array to send a POST request has been deprecated.

GuzzleHttpRequest.php line 94, we are indeed setting the 'body' field and trusting that $postData was happily passed to the constructor by calling code. Fiddling...

Dec 12 2018, 10:15 PM · MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Collection, Wikidata-Campsite, Wikidata, MediaWiki-extensions-JsonConfig, MediaWiki-Vendor
BPirkle added a comment to T187147: Port mediawiki/php/wmerrors to PHP7 and deploy.

I checked a variety of fatal errors on both production HHVM and our current php-fpm configuration using the fatal-errors.php script from T210567. Here's what I found. (Disclaimer: I'm still relatively new to our error logging, so there may be something obvious that I missed.)

Dec 12 2018, 5:53 PM · serviceops, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Core Platform Team Kanban (Doing), wmerrors, Wikimedia-Logstash, MediaWiki-Logging, Operations, User-herron, PHP 7.2 support, Core Platform Team (PHP7 (TEC4)), Performance-Team (Radar)
BPirkle added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

Further testing on production via the fatal-errors.php script from T210567 shows that timeout errors in a post-send function (which that script generates via infinite loop) occur on at 200 seconds under both HHVM and php7.

Dec 12 2018, 3:24 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Dec 11 2018

BPirkle closed T210567: Create a way to intentionally trigger fatal errors in MediaWiki as Resolved.

Closing this task, because the script is deployed and functioning as designed.

Dec 11 2018, 4:16 PM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Dec 10 2018

BPirkle added a comment to T110022: Create a library with HTTP related functions/code.

Guzzle has been added to the codebase and made available through the new GuzzleHttpRequest class, per T202110.

Dec 10 2018, 4:03 PM · MediaWiki-libs-HTTP, Addwiki, Wikidata, Librarization
BPirkle closed T202110: Create GuzzleHttpRequest class as new default for HttpRequestFactory as Resolved.
Dec 10 2018, 3:57 PM · Core Platform Team Kanban (Done with CPT), MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Core Platform Team (Code Health (TEC13)), Patch-For-Review, MediaWiki-General-or-Unknown

Dec 6 2018

BPirkle added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

@tstarling, in IRC @Joe raised a concern that the current method of transmitting the password would cause it to being revealed in logging, which I had not considered. He suggested http basic auth as an alternative. Unless you have another idea, I'm planning to look into that possibility tomorrow.

Dec 6 2018, 3:56 AM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Dec 5 2018

BPirkle added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

Thank you @Nikerabbit . As part of testing T210567 locally on 7.2 php-fpm, I confirmed that behavior - my post-send processing was terminated by max_execution_time.

Dec 5 2018, 1:11 AM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Dec 3 2018

BPirkle added a comment to T210567: Create a way to intentionally trigger fatal errors in MediaWiki.

A first draft of this script is mostly finished and I'm testing locally. A few notes:

Dec 3 2018, 11:01 PM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Nov 28 2018

BPirkle closed T206291: MultiMaps tests are failing on PHP 7.1 as Resolved.

A fix for this issue has been merged.

Nov 28 2018, 3:39 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, PHP 7.1 support, MediaWiki-extensions-Other
BPirkle created T210567: Create a way to intentionally trigger fatal errors in MediaWiki.
Nov 28 2018, 12:47 AM · serviceops, User-Joe, Core Platform Team Kanban (Done with CPT), Patch-For-Review, Core Platform Team (PHP7 (TEC4)), PHP 7.2 support

Nov 27 2018

BPirkle updated the task description for T176370: Migrate to PHP 7 in WMF production.
Nov 27 2018, 10:27 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations

Nov 21 2018

BPirkle updated subscribers of T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.
Nov 21 2018, 9:46 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle added a comment to T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.

Things I've done so far:

Nov 21 2018, 9:46 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support

Nov 20 2018

BPirkle moved T209981: Confirm that post-send functions work fine with mediawiki under PHP 7 from Inbox to Doing on the Core Platform Team Kanban board.
Nov 20 2018, 5:19 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support
BPirkle updated the task description for T176370: Migrate to PHP 7 in WMF production.
Nov 20 2018, 5:17 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
BPirkle added a subtask for T176370: Migrate to PHP 7 in WMF production: T209981: Confirm that post-send functions work fine with mediawiki under PHP 7.
Nov 20 2018, 5:16 PM · Core Platform Team Kanban (Doing), Core Platform Team (PHP7 (TEC4)), Patch-For-Review, TechCom-RFC (TechCom-Approved), User-ArielGlenn, HHVM, Operations
BPirkle added a parent task for T209981: Confirm that post-send functions work fine with mediawiki under PHP 7: T176370: Migrate to PHP 7 in WMF production.
Nov 20 2018, 5:16 PM · Core Platform Team Kanban (Done with CPT), Core Platform Team (PHP7 (TEC4)), PHP 7.0 support