Pull request on https://gerrit.wikimedia.org/r/#/c/425583/

I notice that in the code of RequestContext
there is a todo that (if a check on the return value is added) will probably solve this. Sorry I should have looked better before reporting.

In T191997#4123886, @Krinkle wrote:

@BeeBringer

• What version of MediaWiki are you using?
• How is the site configured to enable MW_NO_SETUP?
• Why are you setting MW_NO_SETUP? What do you think should happen?
• What code are you running to reproduce the issue? I mean not just the class and method, but also how that code is reached by a user.

The MW_NO_SETUP feature was removed in MediaWiki 1.29.0. Before that, it existed to allow extensions to re-initiate MediaWiki from within itself (for example, to start a fake command-line process from within a web page). For that purpose, it was important to not perform Setup as second time (in the command-line sub process), given it will have already happened for the web process.

We found out that MW_NO_SETUP was not needed anymore, because PHP's require_once feature already makes sure it only happens once.

It was removed in edc9edbc769b57. The only user of it was the Maintenance extension, which was unaffected by its removal.

In T191997#4123864, @Aklapper wrote:

Thanks for taking a look at the code!
You are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review them quickly and provide feedback.
If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!

$this->checkMaxLag(); in function MediaWiki::run() will give the HTTP ERROR 500