In T278816#6970262, @Helix17 wrote:

@Bharatkhatri351 Okay, so the change has been made but it's not updated on the production level.

Hello @Luensu1959
Thanks for you concern
As far as i know the build of portal
At the time of production build of wikimedia.org all templates compile into a single html file and that file is hosted on server.
As you can see in above screenshot Lìgure language is present in 10,000+ group in localhost it's mean every thing is working fine.
It will be updated soon at time of next production build.
If you have any query remains let me know. :-)

In T262783#6967643, @VrushtiMody wrote:

I'd like to work on this. @Bharatkhatri351 you mind if I give it a shot?

In T262658#6967565, @Tsiruot wrote:

@Bharatkhatri351
No one claimed this task at the time I started working on it. Plus, you unassigned yourself a few days back.
It is always better to ask first mate :)
Anyhow, I will continue with the work.

But I have never assigned this task for me i was working on this normally my fault But No worry You can work on it if you have assigned it:)
Go for it ...

In T262658#6967502, @Tsiruot wrote:

Hey @Bharatkhatri351 , It'd be appreciated if you could ask people if they're working on a task already because it creates a room for merge conflicts sometimes. Also, I have been working on this (claimed the task) :)

hello @Iniquity i just see your proposal. In this proposal you mentioned font sizes are not according to the style guide.
Can you tell me the present scenerio if still these changes are required. I would love to work on this.

In T278035#6932876, @Saudshaikh99 wrote:

can someone please explain to me the process of Review code review, I created pull requested and I got this message " Hi @saudshk99,

Thank you for contributing to Wikimedia! This Github repository is a read-only mirror.
The project uses Gerrit for code review.
Please submit your pull request to Gerrit, so your code changes can be reviewed."
and suddenly pull request closed

This task should wait until a separate config.js file has been created as part of T277405.

In T274886#6913984, @Tsiruot wrote:

@Jdrewniak I tried to implement this and it is working fine. But the lines of code have increased significantly.

This will find all the files in /cache directory, options is an object for cwd
glob('*', options, findFiles)

This will find stats of all the files. Notice the resolvePath() for absolute path.

function findFiles(err, files) {
		if(err) console.log(err);
		else {
			files.forEach(el => {
				fs.stat(resolvePath(el) , findStats.bind(this, el));
			})
		}}

This will check number of days that have been passed since the file was last modified.

	function checkStats(stats) {
		var days = ((Date.now() - stats.mtime.getTime()) / (24*60*60*1000));
		if(days > 2) return true;
		else return false;
	}

This will delete the file from the directory.

	function deleteFile(el) {
		fs.unlink(resolvePath(el), (err) => {
			console.error( 'Error deleting old cached stats', err );
		});
	}

This might not be the best approach but just a rough implementation

Also, the resolvePath() function

	function resolvePath(file) {
		var p = path.resolve(__dirname, '.' , 'cache', file);
		return p;
	}

Hey @Iniquity

In T255711#6915487, @gerritbot wrote:

Change 672527 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[wikimedia/portals@master] Closing of border line and container in not smooth

https://gerrit.wikimedia.org/r/672527

In T255711#6910950, @gerritbot wrote:

Change 671632 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[wikimedia/portals@master] Too large link's area in 'Other project' section on wikipedia.org

https://gerrit.wikimedia.org/r/671632

hey,
@Jdrewniak
I have moved "helptask" to help.js..kindly review the changes.

In T277405#6912058, @Tsiruot wrote:

@Bharatkhatri351 We could discuss about it on Zulip

ok good idea...

In T277405#6912019, @Tsiruot wrote:

@Bharatkhatri351 I am sorry if it felt unfair to you. I have already submitted two patches for other tasks and now I have also started working on this task. Like @Jdrewniak said this task can be divided into multiple patches, so let's work together on this task and get it done :)

Hey, @Tsiruot i want to work on this task as i observed. you claimed three of the task @Jdrewniak without submitting the patch for it .....Which i think is not a good practice. every one want to contribute..
Thanks : )

its feel great to solve issues..:)

In T273179#6905792, @Jdrewniak wrote:

If anyone needs a more chat-like format to discuss this project, I created the following topic on Zulip:
https://wikimedia.zulipchat.com/#narrow/stream/274201-gsoc21-outreachy22/topic/portals

@Dasgupta002 you can use chat stream for your queries....

I have submit the patch again according to your need...please check it out.
I felt #eaecf0 best matches with theme..
"#eaf3ff75" this color was not going with theme and #eaf3ff is very light for a white background.
but i personally felt this hover effect not looking good on articles link. because it showing underline effect too.
But if you feel comfortable with this patch you can merge this : ) .

Hello @Gopavasanth
as this patch is merged now u can review my patch now...
i have noticed this bug is still exist in videocuttool

I have added border and padding according to your instructions...adding border created a small effect in link automatically....
please check is this effect is good for portal or i have to do some changes in it...

In T255929#6910883, @Iniquity wrote:

In T255929#6910881, @Bharatkhatri351 wrote:

Yes, in my opinion the problem has been fixed! All the same, there is no smoothness, but that's another task. Thank :)

If you want i can try to add smoothness...
what exactly do you want in smoothness if you will create a issue for it
i feel happy to work on it.
Thanks:)

It seems to me that the border disappears very abruptly. Compared to the appearance of a border. Perhaps disappearing should be started before the menu closes.

Yes, in my opinion the problem has been fixed! All the same, there is no smoothness, but that's another task. Thank :)

If you want i can try to add smoothness...
what exactly do you want in smoothness if you will create a issue for it
i feel happy to work on it.
Thanks:)

Hello @Iniquity
i have decrease width of link border.

I gone through this issue deeply...this actually not a browser bug...
this is human typo error.
Because time delay was set 400s which was very much....
I have fixed the issue.
Please check this out

In T262783#6906105, @Ashish1312 wrote:

I just went through the past discussion
@Bharatkhatri351 I understood what you said but not completely can you once again elaborate the observation perspective?

Convert your browser language to persian (from settings of your browser).Then Open wikipedia portal main page then you can observe this issue..
i have mentioned some screenshots of issue above....

@Jdrewniak
thats fine..
hope they will be fixed in future..

┌──────────────────────────────────────────────────────────────────────────────┐
│ Manual Review │
│ Some vulnerabilities require your attention to resolve │
│ │
│ Visit https://go.npm.me/audit-guide for additional guidance │
└──────────────────────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate │ Denial of Service │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ js-yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=3.13.0 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ gulp-cssnano [dev] │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ gulp-cssnano > cssnano > postcss-svgo > svgo > js-yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://npmjs.com/advisories/788 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High │ Code Injection │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ js-yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=3.13.1 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ gulp-cssnano [dev] │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ gulp-cssnano > cssnano > postcss-svgo > svgo > js-yaml │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://npmjs.com/advisories/813 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low │ Prototype Pollution │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ minimist │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=0.2.1 <1.0.0 || >=1.2.3 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ gulp-svg-sprite [dev] │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ gulp-svg-sprite > svg-sprite > mocha > mkdirp > minimist │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://npmjs.com/advisories/1179 │
└───────────────┴──────────────────────────────────────────────────────────────┘
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Low │ Prototype Pollution │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package │ yargs-parser │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Patched in │ >=13.1.2 <14.0.0 || >=15.0.1 <16.0.0 || >=18.1.2 │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ gulp-svg-sprite [dev] │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path │ gulp-svg-sprite > svg-sprite > yargs > yargs-parser │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info │ https://npmjs.com/advisories/1500 │
└───────────────┴──────────────────────────────────────────────────────────────┘

This task involves running npm audit --fix to fix 7 of them.

Fixed 7 of them...using npm audit fix...
how can remaining dependicies can be fixed manually?

In T262783#6895802, @Tsiruot wrote:

After hours of going through the codebase this is what I know :

• It will be quite easy to convert the articles count to their local string using Number.toLocaleString() but this will convert every articles count irrespective of language. e.g. If a person's preferred browser language is Persian then he/she will be able to see the Eastern Arabic numerals but this will also convert counts of other languages too. I don't think it'd be good idea to have numerals of one language with text of some other language.
• To have both numerals and text in the same language, we'd require complete locale code. e.g. hi-IN, fa-IR etc. which then would be used as an argument for toLocaleString() function. This is not available as of now, we just have hi, fa etc.

How exactly do we want them to be displayed? @Jdrewniak @Aklapper

But I am not sure if we're just talking about the numerals used for displaying articles count because those are the only numerals which are not converted to the local string.

Because fa.wikipedia.org correctly translates all the numerals to Eastern Arabic.
Correct me if I am wrong but currently only main portal has the JavaScript based translation mechanism, then

In T219917#6876084, @Aklapper wrote:

@Bharatkhatri351: It was not according to the guidelines, that's why I edited it, and that's why the edited version triggered the gerritbot notification in Phab. Feel free to compare the two commit messages in the Gerrit UI interface. Further comments about the patch itself should go to Gerrit, not here in Phab. Thanks.

In T219917#6874610, @Aklapper wrote:

@Bharatkhatri351: Hi and thanks for investigating. Please see and follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - thanks a lot! :)

I have deep dug regarding this bug.

hello @Jdrewniak
I am working on this isssue can you help me out please i am stuck at a point
i have change my browser prefered language and this result as shown

In T275597#6855882, @Jdrewniak wrote:

hmm, that is odd. These are what my browser language preferences look like in Chrome:

and this is what I see when I go to www.wikipedia.org

Let me know what your browser and settings look like and I'll see if I can replicate.

In T273179#6845616, @Abhinay76 wrote:

Hi @Jdrewniak I am Abhinay and I'm interested in particpating in GSoC'21. I cloned the repository but I'm unable to start the server using npm start command. Could someone please help me through it so that i can start contributing to the project.

Hello
I want to work on this issue.
I made a researched about the issue what this issue exactly demands
Can you give me some insights so i can proceed further to solve this issue.
And i also want to know that how can i convert the language of wikipedia portal from english to persian language.
Because at main page https://www.wikipedia.org/ i can only see the option to read articles in persian not to convert the language of the page
and a search box where i can search any article in persian

Hello @Techwizzie Are You still working on this issue???

In T194134#6845482, @Aklapper wrote:

can you tell me why this is happening...

Please see the task description: "developers don't have to install Gulp globally and can instead rely on the local node_modules version" together with "UPDATE".

May be gulp global dependencies is not required.

@Shivas1000 i am still working on this issue.
actually i am new to gulp so i am learning it to solve the issue.
But if you have prior experience with gulp
u can solve this.. :)

hey @Jdrewniak i learned basics of gulp to understand this issue..
Can you tell me is i am thinking right or not
According to this we have to convert all gulp function in npm scripts.
like compilation and minification watch CreateSvgSprites etc.
and totally remove gulp.js from it

@Jdrewniak
As it Mentioned above Readme file is not updated.
so according to the issue i have to remove site-def.json , site-def.js , site-state.json text from readme
so what i have to write in place of this text.
which script and file are doing those function now
which are done by those files earlier.(site-def.json , site-def.js , site-state.json)

@Jdrewniak thankx for your support i will try to use window linux system.

Hi @Bharatkhatri351, I'm sorry you're having trouble with the build pipeline.
The problem you'r encountering looks to be that the following path is incorrect.
E:\portals\dev\wikipedia.org/assets/l10n
The following string /assets/l10n/**/*.json assumes a unix-based development machine, and isn't formatted to work on Windows.

I'm going to have to review that code and make sure it uses the Node path.resolve() functions to allow it to work on windows.

I'm sorry for this issue, but I'll review this code on Windows this week and hopefully I'll have this resolved soon.

@Khr2003 Nicely Done...
Appreciable Man :)

@SarthakKundra Actually i was not able to run this project in my pc because of a some path issue. As @Jdrewniak told me he will fix this issue in somedays
(for window users). So when the issue will be fix i will start working on it.
But if This project somehow is running on you pc you can resolve this issue.:)

I am getting this error tried a lot but not able to resolve this.
any idea what is going wrong.????????