Mon, Sep 20
Wed, Sep 15
Fri, Sep 10
Wed, Aug 25
The root cause of this was this change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/713957. Is it possible that this will cause issues in other skins?
Thanks. Yes, agreed, it is ready to be cherry-picked to the wmf/1.37.0-wmf.20 branch.
Jul 23 2021
Jul 20 2021
Jul 17 2021
Jun 30 2021
May 26 2021
May 23 2021
No, array_merge_recursive does not do the correct thing here. If it finds a key in both arrays, it merges the results. For the example above, array_merge_recursive would give:
Can this task be merged with T142663, which has likely been resolved by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684668?
May 11 2021
May 10 2021
May 7 2021
git bisect indicates that the issue may have been caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/680822. Pinging @tstarling. I took a look and didn't find anything obvious.
I have indeed been working on the watchlist code recently. I will look into this. Thanks for the ping.
May 5 2021
All core changes and Wikimedia production extension/skin changes have been merged. Patches have been submitted against non-Wikimedia extensions/skins, but it is up to their maintainers to complete that process.
Apr 30 2021
Apr 29 2021
This was accomplished by implementing the WatchlistManager service instead of adding permission checks to WatchedItemStore.