Page MenuHomePhabricator

Cblair91 (Kris)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 25 2014, 6:39 PM (347 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Developaws [ Global Accounts ]

Recent Activity

May 11 2021

Cblair91 added a comment to T279365: Replace usages of Linker::link() and Linker::linkKnown() in extension Patroller.

Gerrit change fixed.

May 11 2021, 5:43 AM · Patch-For-Review, MediaWiki-extensions-Patroller, Technical-Debt

Sep 16 2019

Cblair91 added a comment to T232716: Add Extension:Patroller to translatewiki.net.

@MarcoAurelio I just did a quick search over on translatewiki for "patrol", and can't seem to find any keys that would match this.

Sep 16 2019, 6:31 PM · MediaWiki-extensions-Patroller, translatewiki.net
Cblair91 added a comment to T232985: Fatal exception: Invalid non-numeric limit passed to limitResult().

I am currently under a gerrit release for 2.2, awaiting feedback :)
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Patroller/+/536219/

Sep 16 2019, 1:27 PM · MediaWiki-extensions-Patroller
Cblair91 added a comment to T232985: Fatal exception: Invalid non-numeric limit passed to limitResult().

This got pushed into the master branch as of this gerrit commit;
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Patroller/+/536142/

Sep 16 2019, 1:23 PM · MediaWiki-extensions-Patroller
Cblair91 added a watcher for MediaWiki-extensions-ImportArticles: Cblair91.
Sep 16 2019, 1:17 PM
Cblair91 added a watcher for MediaWiki-extensions-Patroller: Cblair91.
Sep 16 2019, 1:16 PM
Cblair91 added a comment to T232716: Add Extension:Patroller to translatewiki.net.

I am still supporting this extension actively :)

Sep 16 2019, 1:12 PM · MediaWiki-extensions-Patroller, translatewiki.net
Cblair91 closed T232985: Fatal exception: Invalid non-numeric limit passed to limitResult() as Resolved.

This got resolved already, sorry for the delay :P

Sep 16 2019, 1:11 PM · MediaWiki-extensions-Patroller

Sep 12 2019

Cblair91 committed rEPAT7c3653f45bf8: Fixing a database issue with limit query (authored by Cblair91).
Fixing a database issue with limit query
Sep 12 2019, 12:39 PM
Cblair91 moved T232716: Add Extension:Patroller to translatewiki.net from Backlog to New projects for translation on the translatewiki.net board.
Sep 12 2019, 9:50 AM · MediaWiki-extensions-Patroller, translatewiki.net
Cblair91 created T232716: Add Extension:Patroller to translatewiki.net.
Sep 12 2019, 9:49 AM · MediaWiki-extensions-Patroller, translatewiki.net

Jan 18 2017

Cblair91 closed T112453: Complete the qqq.json messages as Resolved.

Version 2.1.0 is now live.

Jan 18 2017, 8:18 PM · Patch-For-Review, MediaWiki-extensions-Patroller

Jan 12 2017

Cblair91 added a project to T112453: Complete the qqq.json messages: Patch-For-Review.

There is now a patch that should resolve this issue.

Jan 12 2017, 9:43 PM · Patch-For-Review, MediaWiki-extensions-Patroller

Apr 28 2016

Cblair91 closed T114604: jquery.tablesorter: Breaking tfoot with rowspans as Resolved by committing rMWc7770078c91f: Fixes T114604.
Apr 28 2016, 3:05 AM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript

Nov 14 2015

Cblair91 added a comment to T118647: Add suffix for Api QueryAllImages.

Well there are other API parameters that could be classed as "expensive", since they don't call indexed columns. Surely it'd be classed as the same thing?

Nov 14 2015, 7:11 PM · Performance Issue, MediaWiki-API
Cblair91 added a comment to T118647: Add suffix for Api QueryAllImages.

Hmm, I can see the issue with active indexing causing it to run slow. Still, surely it's implementable if it's flagged as an expensive call.

Nov 14 2015, 7:06 PM · Performance Issue, MediaWiki-API
Cblair91 added a comment to T118647: Add suffix for Api QueryAllImages.

Patch above is half-complete, submitting fix on top which contains API field.

Nov 14 2015, 6:36 PM · Performance Issue, MediaWiki-API
Cblair91 added a comment to T118647: Add suffix for Api QueryAllImages.

I suppose we could tag is as being an expensive call? Would still be nice to have the availability for it to be there.

Nov 14 2015, 6:34 PM · Performance Issue, MediaWiki-API
Cblair91 created T118647: Add suffix for Api QueryAllImages.
Nov 14 2015, 6:31 PM · Performance Issue, MediaWiki-API

Oct 7 2015

Cblair91 updated the task description for T114607: jQuery.makeCollapsible not compatible with jquery.tablesorter.
Oct 7 2015, 3:40 AM · Patch-For-Review, MediaWiki-jQuery-Tablesorter--archived, JavaScript

Oct 5 2015

Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.
{| class="wikitable sortable"
! Month
! Content
|-
! January
| rowspan="2" | '''Added some stuff.'''
|-
! February
|}
Oct 5 2015, 3:34 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

Practical. A sortable table exists on one of my wikis, and is causing this issue currently. And yes, on a page using wikicode =]

Oct 5 2015, 3:26 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript

Oct 4 2015

Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

Oh didn't notice that until now =] Thanks. And commit message updated.

Oct 4 2015, 6:31 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

Sadly, I do not have access to GIT at this time. If somebody else could ammend the commit message, that would be great (Y)

Oct 4 2015, 5:41 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

Can't do that using the patcher :(

Oct 4 2015, 5:26 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

-sigh- 3rd patch fixes all JSLint issues. Should do patches in future when not sleepy.

Oct 4 2015, 5:17 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

Woops, can somebody close that patch. Forgot a comma =]

Oct 4 2015, 5:02 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 created T114607: jQuery.makeCollapsible not compatible with jquery.tablesorter.
Oct 4 2015, 3:02 PM · Patch-For-Review, MediaWiki-jQuery-Tablesorter--archived, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

I think it's best that a developer takes a look, since the code is hacky and could be majorly improved. =]

Oct 4 2015, 2:47 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.
for ( i = len - 1; i >= 0; i-- ) {
	if ( $( $rows[ i ] ).children( 'td' ).length ) {
		break;
	}
	$tfoot.prepend( $( $rows[ i ] ) );
}

Changes to:

var tfootAdditions = [], rowspan, ii;
for ( i = len - 1; i >= 0; i-- ) {
	if ( $( $rows[ i ] ).children( 'td' ).length ) {
		rowspanNum = $( $rows[ i ] ).children( 'td' ).attr( 'rowspan' );
		if ( rowspan !== undefined ) {
			for ( ii = parseInt( rowspan ); ii < parseInt( rowspan ).length; ii++ ) {
				if ( tfootAdditions.indexOf( i + parseInt( rowspan ) ) !== -1 ) {
					tfootAdditions.splice( tfootAdditions.indexOf( i + parseInt( rowspan ) ) );
				}
			}
		}
		continue;
	}
	tfootAdditions.push( i );
}
for ( i = 0; i < tfootAdditions.length; i++ ) {
	$tfoot.prepend( $( $rows[ i ] ) );
}
Oct 4 2015, 1:55 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 added a comment to T114604: jquery.tablesorter: Breaking tfoot with rowspans.

@Krenair:

Oct 4 2015, 1:40 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 renamed T114604: jquery.tablesorter: Breaking tfoot with rowspans from jquery.sorted.js tfoot with rowspans to jquery.tablesorter.js: tfoot with rowspans.
Oct 4 2015, 1:39 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript
Cblair91 created T114604: jquery.tablesorter: Breaking tfoot with rowspans.
Oct 4 2015, 12:54 PM · MediaWiki-Interface (Tables), Patch-For-Review, JavaScript

Sep 13 2015

Cblair91 closed T112454: Replace deprecated wfMsg with wfMessage as Resolved.

Should be resolved. :-)

Sep 13 2015, 9:51 PM · Patch-For-Review, MediaWiki-extensions-Patroller
Cblair91 added a comment to T112454: Replace deprecated wfMsg with wfMessage.

https://gerrit.wikimedia.org/r/#/c/238002/ :-) Thought you might like

Sep 13 2015, 5:41 PM · Patch-For-Review, MediaWiki-extensions-Patroller
Cblair91 added a comment to T112454: Replace deprecated wfMsg with wfMessage.

Should have it done by some time later today :) Weekends = personal projects time, so lots to do aha

Sep 13 2015, 11:41 AM · Patch-For-Review, MediaWiki-extensions-Patroller

Sep 12 2015

Cblair91 added a comment to T112252: Create Phabricator project #MediaWiki-Extensions-ImportArticles.

@Aklapper aha I thought by the reply with the link, you was telling me to create my own ticket for this. My bad :)

Sep 12 2015, 7:22 PM · Project-Admins
Cblair91 closed T112252: Create Phabricator project #MediaWiki-Extensions-ImportArticles as Declined.

Transferred to T112387 (Since presuming the author has to request it by @Aklapper's response)

Sep 12 2015, 3:36 PM · Project-Admins
Cblair91 created T112387: Create new project #MediaWiki-Extensions-ImportArticles.
Sep 12 2015, 3:34 PM · Project-Admins

Sep 8 2015

Cblair91 created T111832: Patroller extension.
Sep 8 2015, 5:20 PM · Repository-Ownership-Requests

Mar 4 2015

Cblair91 added a comment to T89208: MediaWiki Extension "ImportArticles" project.

I am intending to implement some more stuff regarding it to handle the loading better (and not through the API possibly). A single instance is fine :)

Mar 4 2015, 5:32 PM · Cloud-Services

Feb 11 2015

Cblair91 created T89208: MediaWiki Extension "ImportArticles" project.
Feb 11 2015, 4:27 AM · Cloud-Services

Nov 25 2014

Cblair91 added a comment to T75910: Protectable MediaWiki NS.

Surely if it's set to sysop-only, the protection dropdown should not appear?

Nov 25 2014, 6:45 PM · MediaWiki-Page-protection
Cblair91 created T75910: Protectable MediaWiki NS.
Nov 25 2014, 6:40 PM · MediaWiki-Page-protection