In T238728#5891027, @Lydia_Pintscher wrote:

Looks good! Thank you.
Small thing: I think there should be no "the" in "the Creative Commons CC0".

changes to bullet points:

• wiki name
• article name
• item id
• property ID

@Lydia_Pintscher ready from my side

Michael, sarai, charlie agreed we go by:

closing this for now as discussed in the daily. possible improvements would get an extra ticket.

In T233295#5865259, @Lucas_Werkmeister_WMDE wrote:

i noticed this as well. i am not how costly it would e to improve this and depending on that whether @Lydia_Pintscher
sees this as part of step 1 or not.

Well, what improvement do you have in mind? We already show the property label as soon as we can.

In T233295#5864969, @Tonina_Zhelyazkova_WMDE wrote:

A few observations:

• When the bridge is loading (loading bar is visible) the header shows the property id and when bridge fully loads it shows the property label, resulting in a visual jump.

cool! thank you!

wait, but they're two distinct things. there's some value/unknown value, and no value. they are not the same, no?

sorry, i moved this already but i actually have one more question: the link on the beta page sais "somevalue statement" but the modal then sais "unknown value". Is this a mixup or am i missing smth? @Lucas_Werkmeister_WMDE

looks good!

looks good!

cool! looks good to me!

In T240212#5864004, @Michael wrote:

In T240212#5863965, @Charlie_WMDE wrote:

question: is this "String Property: multiple statement" the property name? seems weird to me.

It is. But feel free to change it. The goal was to communicate that this property exists specifically to test otherwise valid properties/statements that just has multiple values.
Mh, just noticed, that "multiple statements" is not really, right, should be "multiple values". I changed that. Feel free to change it more, maybe the description of the property is enough to communicate its purpose?

question: is this "String Property: multiple statement" the property name? seems weird to me.

lookin good!

sorry to be the party pooper. I found these very strange margin sizes (should be 16 at the bottom and 24 on top). do you know what's causing them? in other places i get the correct 8/16/24px so it can't be purely a conversion thing i guess

@Lydia_Pintscher who is responsible for tracking the completed error messages in this ticket. it looks like some of them are already done or in doing at least but it's currently not being reflected in this ticket.

looks good to me \o/

In T238660#5848511, @Lucas_Werkmeister_WMDE wrote:

Should the heading really be “Editing the value for $property is not supported”? That’s the same heading as for unsupported datatypes (T235753), but in this case, the problem isn’t the property, it’s the particular statement.

In T237507#5848435, @Lucas_Werkmeister_WMDE wrote:

@Lucas_Werkmeister_WMDE do you want to make an extra ticket for this? since this was not part of the initial AC

I also realized two things:

• The MediaWiki core message doesn’t have anything GENDER-able either.
• There is no reason for the German translation to use the gendered word „Administrator“. The English original (of both MediaWiki core and Wikidata Bridge) doesn’t say “The block was made by the administrator $1”, only “The block was made by $1”.

So I’ve just updated the message to remove the word „Administrator“ (both for MediaWiki core and Wikidata Bridge), and I think we can leave it at that.

the margins on the right side of the modal are not correct yet in the top part. as you can see in the bottom, there's an additional 24px margin around the main element, plus the 16px that go all around the modal.
the text of the top section is going over the line as you can see in the screenshot, but it should have the same restriction.

currently looks like this in my browser (firefox)

In T237507#5845332, @Lucas_Werkmeister_WMDE wrote:

we only pass in a DOM element with the user name, not anything that could be passed into {{GENDER}}.

It turns out that gender in jqueryMsg works differently anyways. You don’t pass in any user name, you pass in the gender directly – "male", "female", "unknown". (That’s all MediaWiki recognizes, sadly.)
But that means we need to make another API call – something like https://de.wikipedia.beta.wmflabs.org/w/api.php?action=query&list=users&usprop=gender&ususerids=689 – to get something we can pass into the message. (Probably as a new $10 parameter.) And I don’t think we can batch this with anything.