Page MenuHomePhabricator

Charlie_WMDE (Charlie Kritschmar)
UX-Designer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 11 2016, 3:31 PM (254 w, 5 d)
Availability
Available
IRC Nick
Incabell
LDAP User
Unknown
MediaWiki User
Charlie Kritschmar (WMDE) [ Global Accounts ]

Recent Activity

Thu, Feb 25

Charlie_WMDE updated the task description for T275542: (MS 6) tooltips for some of the UI components.
Thu, Feb 25, 1:16 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T275542: (MS 6) tooltips for some of the UI components.
Thu, Feb 25, 1:14 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T275397: Change title of Query builder.

@Michael added it as an AC to the ticket description

Thu, Feb 25, 11:14 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T275397: Change title of Query builder.
Thu, Feb 25, 11:14 AM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Charlie_WMDE renamed T275542: (MS 6) tooltips for some of the UI components from tooltips for some of the UI components to [MS 6] tooltips for some of the UI components.
Thu, Feb 25, 10:40 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a parent task for T273041: (MS 6) Create popover component: T275542: (MS 6) tooltips for some of the UI components.
Thu, Feb 25, 9:10 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a subtask for T275542: (MS 6) tooltips for some of the UI components: T273041: (MS 6) Create popover component.
Thu, Feb 25, 9:09 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T273046: Allow buttons to be full width.

looks good from my side. will wait for @Sarai-WMDE to close it in case i'm missing smth

Thu, Feb 25, 9:00 AM · Wikidata, Wikidata Query Builder

Tue, Feb 23

Charlie_WMDE moved T275542: (MS 6) tooltips for some of the UI components from Incoming to Backlog on the Wikidata Query Builder board.
Tue, Feb 23, 7:15 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE created T275542: (MS 6) tooltips for some of the UI components.
Tue, Feb 23, 7:15 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T273002: (MS 6) 🛑 Create Date input component.
Tue, Feb 23, 9:04 AM · Wikidata, Wikidata Query Builder

Mon, Feb 22

Charlie_WMDE updated the task description for T272697: (MS 6) Query for date values.
Mon, Feb 22, 9:45 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE added a comment to T275189: Favicon for the Simple Query Builder.

If it's going to be a subpage of wdqs, we can't change the favicon for production. For toolforge, sure.

Mon, Feb 22, 4:41 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE closed T274283: UX/UI improvements for the Query Builder as Resolved.

looks good!

Mon, Feb 22, 4:40 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE created T275397: Change title of Query builder.
Mon, Feb 22, 3:02 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder

Tue, Feb 16

Charlie_WMDE added a comment to T274799: input component should remove error state when cause of error is removed.

I tested it with this link (hope that's correct)
works great!

Tue, Feb 16, 5:26 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T272984: scrolling to new condition.

even better than what i wanted! \o/

Tue, Feb 16, 5:23 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T274283: UX/UI improvements for the Query Builder.

thanks @Ladsgroup and @Michael

Tue, Feb 16, 5:05 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE claimed T271296: [WIP] deciding which columns should be shown in the results.
Tue, Feb 16, 11:28 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T273046: Allow buttons to be full width.

yes, agree. i have made the same comment in the UI improvements ticket

Tue, Feb 16, 11:26 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T274283: UX/UI improvements for the Query Builder.

Improvement C:
i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop and they're all using the same token. let me know if this should be an extra ticket or can be done in this one

Tue, Feb 16, 11:19 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata

Mon, Feb 15

Charlie_WMDE created T274799: input component should remove error state when cause of error is removed.
Mon, Feb 15, 3:50 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Charlie_WMDE closed T273052: Value type not detected in the visual query after using 'regardless of value' as Resolved.
Mon, Feb 15, 3:49 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE added a comment to T273052: Value type not detected in the visual query after using 'regardless of value' .

@bete thanks for the link!

Mon, Feb 15, 3:33 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE added a comment to T274659: "Subtask-Checkbox" should be visible right from the beginning if a datatype wikibase-item is reconstructed.

seems to be working for me now with the provided test link.

Mon, Feb 15, 3:04 PM · User-Michael, Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T273052: Value type not detected in the visual query after using 'regardless of value' .

@bete where can i test the bugfix?

Mon, Feb 15, 3:02 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE moved T268942: (MS 3) 🛑 query for quantity values from Backlog to Ready for story time on the Wikidata Query Builder board.
Mon, Feb 15, 10:42 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE moved T273001: (MS 3) Create Quantity input component from Backlog to Ready for story time on the Wikidata Query Builder board.
Mon, Feb 15, 10:42 AM · User-Michael, Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T272702: (MS 7) Link from Query Service UI to Query Builder.
Mon, Feb 15, 9:49 AM · Wikidata Query Builder, Wikidata
Charlie_WMDE assigned T272702: (MS 7) Link from Query Service UI to Query Builder to Erdinc_Ciftci_WMDE.
Mon, Feb 15, 9:40 AM · Wikidata Query Builder, Wikidata
Charlie_WMDE added a comment to T274283: UX/UI improvements for the Query Builder.

made an extra ticket for improvement G so we can close A-F: T274754

Mon, Feb 15, 9:16 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE created T274754: Help links in the description should open in new tabs.
Mon, Feb 15, 9:13 AM · Wikidata Query Builder, Wikidata

Fri, Feb 12

Charlie_WMDE updated subscribers of T274101: Filter by References not working.

looking good from my side
@Lydia_Pintscher @amy_rc ?

Fri, Feb 12, 12:07 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE created T274634: Investigate intended behavior of including subclasses in search.
Fri, Feb 12, 12:00 PM · Wikidata, Wikidata Query Builder

Thu, Feb 11

Charlie_WMDE renamed T274283: UX/UI improvements for the Query Builder from UI improvements for the Query Builder to UX/UI improvements for the Query Builder.
Thu, Feb 11, 3:19 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE updated the task description for T274283: UX/UI improvements for the Query Builder.
Thu, Feb 11, 3:19 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata

Tue, Feb 9

Charlie_WMDE placed T274283: UX/UI improvements for the Query Builder up for grabs.
Tue, Feb 9, 6:32 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE created T274283: UX/UI improvements for the Query Builder.
Tue, Feb 9, 5:35 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE created T274273: Accessibility improvements for the Query Builder.
Tue, Feb 9, 4:48 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE updated subscribers of T273168: (MS 5) Use quiet button with icon.

@Lydia_Pintscher I think originally we needed this ticket for the "share link to query" button. After the change I've made we instead need a "button, icon only" which we already have, so i assume this ticket can go back in the backlog for now unless i'm overlooking something.

Tue, Feb 9, 2:53 PM · Wikidata Query Builder, Wikidata Design System, Wikidata
Charlie_WMDE changed the status of T272887: (MS 5) expose visual query sharing via URL in the UI from Stalled to Open.
Tue, Feb 9, 2:38 PM · Wikidata, Wikidata Query Builder

Thu, Feb 4

Charlie_WMDE closed T272682: (MS5) Open the query in the query service as Resolved.
Thu, Feb 4, 2:55 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata

Tue, Feb 2

Charlie_WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Tue, Feb 2, 5:03 PM · User-Michael, Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T273001: (MS 3) Create Quantity input component.
Tue, Feb 2, 3:53 PM · User-Michael, Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T268942: (MS 3) 🛑 query for quantity values.
Tue, Feb 2, 3:41 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T272055: Set max width for entire UI.

looks great! \o/

Tue, Feb 2, 9:29 AM · Wikidata, Wikidata Query Builder

Mon, Feb 1

Charlie_WMDE changed the status of T272887: (MS 5) expose visual query sharing via URL in the UI from Open to Stalled.

stalled while i figure some things out

Mon, Feb 1, 3:51 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE added a comment to T272682: (MS5) Open the query in the query service.

looks good apart from the link only appearing after i've run the query. i'd expect it to always be there. if clicked before having ever run a query, it would just lead you to an empty QS page

Mon, Feb 1, 3:30 PM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE added a comment to T265238: (MS 4) negate query.

looking good! @Lydia_Pintscher ?

Mon, Feb 1, 11:10 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata

Fri, Jan 29

Charlie_WMDE added a comment to T268982: (MS 2) remove a query block/condition.

that's the one i tried out. i thought it said 38x37.x when i tested it but now it says 38x32.8 which i think is fine. can be merged then from my side!

Fri, Jan 29, 4:22 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE added a comment to T268982: (MS 2) remove a query block/condition.

i seem to still have the same problem. maybe it's my browser?

Fri, Jan 29, 4:03 PM · Wikidata Query Builder, User-Michael, Wikidata

Jan 27 2021

Charlie_WMDE claimed T272887: (MS 5) expose visual query sharing via URL in the UI.
Jan 27 2021, 4:36 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T272609: fix checkbox issues.
Jan 27 2021, 10:00 AM · Wikidata Query Builder, Wikidata
Charlie_WMDE updated the task description for T272699: (MS 6) Filter by references.
Jan 27 2021, 9:55 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE updated the task description for T272887: (MS 5) expose visual query sharing via URL in the UI.
Jan 27 2021, 9:53 AM · Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T272682: (MS5) Open the query in the query service.
Jan 27 2021, 9:45 AM · User-Ladsgroup, Wikidata Query Builder, Wikidata
Charlie_WMDE updated the task description for T272887: (MS 5) expose visual query sharing via URL in the UI.
Jan 27 2021, 9:26 AM · Wikidata, Wikidata Query Builder

Jan 26 2021

Charlie_WMDE updated the task description for T272887: (MS 5) expose visual query sharing via URL in the UI.
Jan 26 2021, 5:12 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE created T272984: scrolling to new condition.
Jan 26 2021, 3:31 PM · User-Ladsgroup, Wikidata, Wikidata Query Builder
Charlie_WMDE updated the task description for T272694: (MS 4) connect query conditions via OR.
Jan 26 2021, 3:15 PM · Wikidata Query Builder, Wikidata

Jan 25 2021

Charlie_WMDE updated the task description for T272694: (MS 4) connect query conditions via OR.
Jan 25 2021, 6:30 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE updated the task description for T272692: (MS3) 🛑 Query for specific property with values in a specific range.
Jan 25 2021, 5:46 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE updated the task description for T272055: Set max width for entire UI.
Jan 25 2021, 5:27 PM · Wikidata, Wikidata Query Builder

Jan 21 2021

Charlie_WMDE created T272609: fix checkbox issues.
Jan 21 2021, 3:23 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE closed T271794: (MS 5) Create results header/frame as Resolved.

looks good to me and can be merged! \o/

Jan 21 2021, 3:11 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE closed T272053: (MS 2) Make the last condition removable as well as Resolved.

okay, that makes sense! thanks for looking into it. closing this ticket now \o/

Jan 21 2021, 1:00 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE closed T272053: (MS 2) Make the last condition removable as well, a subtask of T268982: (MS 2) remove a query block/condition, as Resolved.
Jan 21 2021, 1:00 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE closed T268941: (MS 3) allow to include results from subclasses as Resolved.

looks good!

Jan 21 2021, 11:30 AM · Wikidata Query Builder, Wikidata
Charlie_WMDE closed T272456: Disable subclass checkbox for "regardless of value" conditions as Resolved.

ok weird, now it works. will move to done

Jan 21 2021, 11:29 AM · Wikidata Query Builder, Wikidata, User-Ladsgroup
Charlie_WMDE closed T270712: add limit ui elements to QB, a subtask of T270179: (MS 5) limit the number of results, as Resolved.
Jan 21 2021, 11:23 AM · Wikidata Query Builder, Wikidata
Charlie_WMDE closed T270712: add limit ui elements to QB as Resolved.
Jan 21 2021, 11:23 AM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE closed T270179: (MS 5) limit the number of results as Resolved.

i guess we don't have a done column anymore so i will just resolve the ticket

Jan 21 2021, 11:22 AM · Wikidata Query Builder, Wikidata
Charlie_WMDE added a comment to T272053: (MS 2) Make the last condition removable as well.

@Ladsgroup looks good but all the spacing is 14px instead of 16px(dimension-layout-xsmall) for some reason. is that some firefox issue?

Jan 21 2021, 11:18 AM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE added a comment to T272456: Disable subclass checkbox for "regardless of value" conditions.

@Ladsgroup for me when testing the checkbox is unchecked disabled, instead of checked disabled.

Jan 21 2021, 11:14 AM · Wikidata Query Builder, Wikidata, User-Ladsgroup
Charlie_WMDE updated the task description for T271794: (MS 5) Create results header/frame.
Jan 21 2021, 9:19 AM · Wikidata Query Builder, User-Ladsgroup, Wikidata

Jan 15 2021

Charlie_WMDE added a comment to T269470: (MS 2) A Decorator visually frames the query conditions.

Sorry! 😬

Jan 15 2021, 2:27 PM · User-Michael, Wikidata Query Builder (Wikidata Query Builder - sprint 6), Wikidata
Charlie_WMDE closed T269470: (MS 2) A Decorator visually frames the query conditions as Resolved.

amazing! thank you! moving this to done! \o/

Jan 15 2021, 2:10 PM · User-Michael, Wikidata Query Builder (Wikidata Query Builder - sprint 6), Wikidata

Jan 14 2021

Charlie_WMDE created T272055: Set max width for entire UI.
Jan 14 2021, 5:19 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE renamed T271794: (MS 5) Create results header/frame from [MS5] Create results header/frame to (MS 5) Create results header/frame.
Jan 14 2021, 5:11 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE moved T272053: (MS 2) Make the last condition removable as well from Incoming to Backlog on the Wikidata Query Builder board.
Jan 14 2021, 5:11 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE renamed T272053: (MS 2) Make the last condition removable as well from Make the last condition removable as well to (MS 2) Make the last condition removable as well.
Jan 14 2021, 5:11 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE added a parent task for T272053: (MS 2) Make the last condition removable as well: T268982: (MS 2) remove a query block/condition.
Jan 14 2021, 5:11 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE added a subtask for T268982: (MS 2) remove a query block/condition: T272053: (MS 2) Make the last condition removable as well.
Jan 14 2021, 5:11 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE created T272053: (MS 2) Make the last condition removable as well.
Jan 14 2021, 5:09 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE added a comment to T269470: (MS 2) A Decorator visually frames the query conditions.

i found another thing. the dropdown seems to be slightly misaligned in height with it's surrounding neighbors even though i can't pinpoint it using the dev tools. maybe you could take a look to see what's going on?

Jan 14 2021, 3:28 PM · User-Michael, Wikidata Query Builder (Wikidata Query Builder - sprint 6), Wikidata
Charlie_WMDE added a comment to T268814: (MS 3) allow to query for Item values.

\o/ it works!

Jan 14 2021, 3:03 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 6), Wikidata
Charlie_WMDE moved T270712: add limit ui elements to QB from Done to Test (Verification) on the Wikidata Query Builder (Wikidata Query Builder - sprint 6) board.

Sorry, just noticed one more thing!

Jan 14 2021, 2:53 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE reopened T270712: add limit ui elements to QB, a subtask of T270179: (MS 5) limit the number of results, as Open.
Jan 14 2021, 2:52 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE reopened T270712: add limit ui elements to QB as "Open".
Jan 14 2021, 2:52 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE closed T270712: add limit ui elements to QB, a subtask of T270179: (MS 5) limit the number of results, as Resolved.
Jan 14 2021, 2:50 PM · Wikidata Query Builder, Wikidata
Charlie_WMDE closed T270712: add limit ui elements to QB as Resolved.

looks great, thanks!

Jan 14 2021, 2:50 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE added a comment to T269470: (MS 2) A Decorator visually frames the query conditions.

love the progress it looks so cool! <3

Jan 14 2021, 12:21 PM · User-Michael, Wikidata Query Builder (Wikidata Query Builder - sprint 6), Wikidata
Charlie_WMDE added a comment to T268982: (MS 2) remove a query block/condition.

After discussing this topic with Lydia, we agreed to make following change in this ticket:

Jan 14 2021, 11:59 AM · Wikidata Query Builder, User-Michael, Wikidata

Jan 12 2021

Charlie_WMDE added a comment to T270712: add limit ui elements to QB.

just realised this is strictly the UI ticket, not including the functionality. sorry about that!

Jan 12 2021, 5:07 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE added a comment to T270712: add limit ui elements to QB.

When i try to run the query with letters instead of a number, it's as if the checkbox isn't selected at all ie. i get all the results. I understand we won't do validation in this ticket, but the fallback behavior should be the default setting imo which is a limit of 100

Jan 12 2021, 5:05 PM · Wikidata Query Builder, User-Michael, Wikidata
Charlie_WMDE added a comment to T270556: (MS 5) show only IDs in the results.

looking good from my side!

Jan 12 2021, 5:02 PM · Wikidata Query Builder (Wikidata Query Builder - sprint 6), Wikidata
Charlie_WMDE moved T271788: (MS4) Toggle button group component from Incoming to Backlog on the Wikidata Query Builder board.
Jan 12 2021, 4:23 PM · Wikidata, Wikidata Query Builder
Charlie_WMDE moved T271794: (MS 5) Create results header/frame from Incoming to Backlog on the Wikidata Query Builder board.
Jan 12 2021, 4:23 PM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE renamed T271794: (MS 5) Create results header/frame from Create results header/frame to [MS5] Create results header/frame.
Jan 12 2021, 10:33 AM · Wikidata Query Builder, User-Ladsgroup, Wikidata
Charlie_WMDE created T271794: (MS 5) Create results header/frame.
Jan 12 2021, 10:32 AM · Wikidata Query Builder, User-Ladsgroup, Wikidata