Thu, Feb 25
@Michael added it as an AC to the ticket description
looks good from my side. will wait for @Sarai-WMDE to close it in case i'm missing smth
Tue, Feb 23
Mon, Feb 22
Tue, Feb 16
I tested it with this link (hope that's correct)
even better than what i wanted! \o/
yes, agree. i have made the same comment in the UI improvements ticket
i forgot to leave specs for the placement of the checkboxes inside of the decorator. i added them now in the mobile mock for space reasons, but the same specs apply for desktop and they're all using the same token. let me know if this should be an extra ticket or can be done in this one
Mon, Feb 15
@bete thanks for the link!
seems to be working for me now with the provided test link.
@bete where can i test the bugfix?
made an extra ticket for improvement G so we can close A-F: T274754
Fri, Feb 12
Thu, Feb 11
Tue, Feb 9
@Lydia_Pintscher I think originally we needed this ticket for the "share link to query" button. After the change I've made we instead need a "button, icon only" which we already have, so i assume this ticket can go back in the backlog for now unless i'm overlooking something.
Thu, Feb 4
Tue, Feb 2
looks great! \o/
Mon, Feb 1
stalled while i figure some things out
looks good apart from the link only appearing after i've run the query. i'd expect it to always be there. if clicked before having ever run a query, it would just lead you to an empty QS page
looking good! @Lydia_Pintscher ?
Fri, Jan 29
that's the one i tried out. i thought it said 38x37.x when i tested it but now it says 38x32.8 which i think is fine. can be merged then from my side!
i seem to still have the same problem. maybe it's my browser?
Jan 27 2021
Jan 26 2021
Jan 25 2021
Jan 21 2021
looks good to me and can be merged! \o/
okay, that makes sense! thanks for looking into it. closing this ticket now \o/
ok weird, now it works. will move to done
i guess we don't have a done column anymore so i will just resolve the ticket
@Ladsgroup looks good but all the spacing is 14px instead of 16px(dimension-layout-xsmall) for some reason. is that some firefox issue?
@Ladsgroup for me when testing the checkbox is unchecked disabled, instead of checked disabled.
Jan 15 2021
amazing! thank you! moving this to done! \o/
Jan 14 2021
i found another thing. the dropdown seems to be slightly misaligned in height with it's surrounding neighbors even though i can't pinpoint it using the dev tools. maybe you could take a look to see what's going on?
\o/ it works!
Sorry, just noticed one more thing!
looks great, thanks!
love the progress it looks so cool! <3
After discussing this topic with Lydia, we agreed to make following change in this ticket:
Jan 12 2021
just realised this is strictly the UI ticket, not including the functionality. sorry about that!
When i try to run the query with letters instead of a number, it's as if the checkbox isn't selected at all ie. i get all the results. I understand we won't do validation in this ticket, but the fallback behavior should be the default setting imo which is a limit of 100
looking good from my side!