• Red link: I think it's okay that this is still a red link. I'm going to put this in the "future versions" section of the description as something to think about in the future for when we want to drive more traffic to the page.

Thanks @Volker_E, I like this new styling for the messages, and I've already used them in T222848!

@SBisson This task was also reported by me. Same behavior and console output as T225661, plus:

[Report Only] Refused to load https://meta.m.wikimedia.beta.wmflabs.org/w/index.php?title=Special:BannerLoader&campaign=CN+browser+tests&banner=browser_test_b1&uselang=en&debug=false because it does not appear in the script-src directive of the Content Security Policy.

@SBisson I reported it, and it's still happening on Safari iOS 10. However I can't reproduce in any other version of Safari and Safari iOS.
Here is the console output

Failed to set referrer policy: The value 'origin-when-crossorigin' is not one of 'no-referrer', 'origin', 'no-referrer-when-downgrade', or 'unsafe-url'. Defaulting to 'no-referrer'.

@SBisson overwriting the flex attribute in

.growthexperiments-homepage-module-start > .growthexperiments-homepage-module-body .growthexperiments-homepage-module {
  display: flex;
}

to block in

.growthexperiments-homepage-mobile-details .growthexperiments-homepage-module-start > .growthexperiments-homepage-module-section-body .growthexperiments-homepage-module {
  display: block;
}

fixes the issue for me.

@SBisson @kostajh
I have updated the specifications in the task description, and uploaded up-to-date mockups to Zeplin.

@SBisson

Mobile toasts can be closed by tapping on them. They can also auto-close after a delay. The two standard delays are "short" (5 seconds) and "long" (30 seconds). Note: if we allow auto-close, they can always be closed by tapping, we can't turn that off. @Cntlsn, @MMiller_WMF let me know how you want it to behave.

Thanks @Krinkle for the clarification, and thanks @Catrope for explaining how this could actually be done.

@Catrope yep! and happy to help with debugging.

Added a couple of issues to T225288. Moving to "Needs PM Review" column

This is ready for development

Looping @SBisson in since we just discussed in chat that making a message dismissable for no-Js users would potentially be too much work for supporting a small percentage of no-Js browsers.

Thanks @Catrope @kostajh @MMiller_WMF for your input.

@MMiller_WMF
I'm actually a bit divided on this. I like the idea of removing text in general, but considering the feedback we received from the user test (some users wondering why they got a mentor) I think in this case the intro text will actually be helpful on the first visit. And it would anyway be removed after the user has asked a question to their mentor, so the module would potentially display more text only on the first visit (or few visits, until there is user interaction).

@JTannerWMF
We are working on T222848 and T222852 at the moment, while T222847 is on hold to avoid redundancy until we define a more comprehensive approach to aid Homepage discovery. I think this task can stay as it is for now, until we decide how to move forward.

@JTannerWMF For both, thanks!

@JTannerWMF For both, thanks!

@MMiller_WMF
Ok about not dealing with it now, but I think we should take care of it at some point, as the copy could be misleading.

@MMiller_WMF @SBisson @kostajh looks good to me!

@MMiller_WMF @SBisson
I agree that the whole preview card should link to the fullscreen view of the impact module.

In T216220#5249736, @alexhollender wrote:

@Cntlsn I wonder if a shorter message would work?

The issue has been added to the list at T225288

@MMiller_WMF @SBisson
As pointed out by @Etonkovidova at https://phabricator.wikimedia.org/T224526#5249110, it can feel confusing to show the number 0 in the impact module preview while the system is calculating user's first edit pageviews.

@MMiller_WMF

• (3): this is not a bug. Readers Web said both those links are supposed to be there for now.
• (8): similarly, I don't think this is a bug. @Cntlsn, didn't Readers Web say that those links are supposed to be there for now? I don't think we want to alter the user page.

Thanks @MMiller_WMF and @alexhollender for your input on this.

Looks good, moving to PM review @MMiller_WMF

@Etonkovidova
I'll clarify my question: would it be possible to have edits showing up in Special:Contributions that are not counted as "edits to articles" or "edits to other kinds of pages"?

Thanks @Etonkovidova for your comments

Thanks @Etonkovidova, good to me.

@MMiller_WMF
I did some thinking about this, and my conclusions are that if our goal is to push more users to conclude the process and submit their questions, I agree that we would need to give the right (and right amount) of information before they push the "post my question" button, but also minimize the opportunities of leaving the flow mid-way (for instance by offering links to other places)

@Catrope @MMiller_WMF
About the banners in the sitenotice area, the reason why I opted for not relying on those is that I tried disabling Js (Firefox 67) and couldn't see them on no-JS

I'm good with that, and changing the mockups accordingly, thanks!

Thanks @MMiller_WMF
Sizes are actually correct.

@Etonkovidova @MMiller_WMF Thanks!

Thanks @Urbanecm for posting this!

My proposal for the mobile version of the Homepage discovery aid after account creation is slightly less aggressive than its desktop counterpart, but embraces a standard mobile pattern that would potentially be as effective, while eliminating the "reading effort".

@MMiller_WMF
Thanks for your comment and for making some clarity on the state of the task.

@SBisson looks good to me, thanks!

I think I actually saw something similar in a mockup by @alexhollender. Looping him in so maybe he can tell us if that's actually something already released for mobile.
This is the mockup we're talking about https://phab.wmfusercontent.org/file/data/prox6tif35umw45lnrg4/PHID-FILE-rqv66vibc5iisldmte2g/Screenshot_2019-06-06_19.34.27.png

@SBisson I have added mobile mockups to the task description

Thanks @Volker_E for all your notes!

Thanks a lot @Catrope for making some clarity on this!

I was trying to trace back to the decision about adding the intro text to the homepage T217927, and I believe it was added because of concern that the modules were not self-explanatory enough.

@MMiller_WMF
You are right, but the previous mockups didn't feature the "By the way..." copy, and I only discovered about that by looking carefully at the help panel mockups (meaning I was never able to read it after posting my test questions on beta...)

@MMiller_WMF
Thanks for taking the time to do this!
Things are organized correctly, and I have updated the mockups with the new copy on both InVision and Zeplin.

@Etonkovidova thanks for spotting that! I forgot to update the desktop version. Now updated in both InVision and Zeplin.

Thanks @kostajh and @Catrope for your feedback on this!

removing the text is also an option

@MMiller_WMF

• Do you think that the issues identified in the mobile user tests also apply to desktop? All the copy is currently the same between the mobile designs and the desktop software, and so do we think that users would have the same confusion? If so, should we also be making any changes to desktop?

@MMiller_WMF
I have added mockups in T223219
Copy is still TBC.

Me and @MMiller_WMF discussed about this, the most correct call-to-action to be featured in the unactivated state of the Impact module would be a link to structured editing, but the team is not gonna work on this in the near term.

I agree that it's possible that users won't read it on their first visit.
On mobile it's pretty prominent though (just to make sure we're aligned on the fact that it's only for mobile I have renamed the task). And during user tests most users seemed to read it (it's also true that testers are a bit biased since we asked them to describe what they would see in the homepage...)