So say we add a 'structured-data-mediainfo' tag to every revision that has a mediainfo slot - would that be adequate? @EBernhardson ?

@brennen a fix for T231276 deployed to production yesterday may have (mostly) fixed this, can you verify?

Can this be closed?

Ok great, closing

That'd mean we'd (potentially) have to edit the json blob for slots when a page is deleted/restored

So ... @zeljkofilipin can we close this now?

The reason for this is happening is the following code in MediaInfoHandler.php

Yeah, same here - it's been introduced recently

The "you" in that comment is myself - I tried to federate wikidata from my local env many times, so I needed a comment to remind me why I shouldn't :p

It seems like the dependency between the page_id and the MediaInfo item id is baked in at a very deep level

@Mholloway here's the section of my local config where I turn federation on:

Decided not to do it, at least for now

Works for me on beta, except for [[ T232101 | this bug ]]

This approach means that if you have MediaInfo content in a slot on the page, and someone edits the wikitext to make the page into a redirect, then the MediaInfo content becomes inaccessible.

@alaa_wmde I'll take a look tomorrow

WMDE is thinking about a different solution the parent task atm ...

@Pablo-WMDE if you change your mind let me know, and I'll fix up the broken unit tests

Cool, sounds good to me

@Pablo-WMDE this bit of code in WikibaseMediaInfoHooks.php is what triggers the error:

The hook approach doesn't work for MediaInfo, becase the hook doesn't fire if a MediaInfo item doesn't exist for a File page - which it doesn't if no structured data has been added to the page

The new "actual" ID needs to be forced into the Entity data, I commented on the patch to that effect.

Maybe it's broken somehow, and every undelete changes the page ID again? Needs investigation, because if that was true, it would greatly aggravate the effect of the MediaInfoID problem.

@Urbanecm the patch prevents the fatal error, but there are other errors if, for example, a user tries to edit a caption.

Not really - the MediaInfo id refers to a slot rather than a page, and isn't accessible via a url. I think the | ArticleUndelete solution will work

Here's an example campaign set up to have P276 (wikidata property 'location') set up as a suggested statement on the metadata page of UW with the value Q1761 (wikidata item 'Dublin'):

Here's an example campaign set up to have P276 (wiidata property 'location') set up as a suggested statement on the metadata page of UW: