@Ramsey-WMF to test this today and see if it's still an issue

OK to close this now @dcausse ?

I thought the wb_terms table was being deprecated ... hmmm, maybe I'm mixing it up with something else

Yeah, reckon so - closing

Erm ... this is getting a bit philosophical, but I don't really see that labels and descriptions have much semantic meaning associated with them, except for one would expect a label to be shorter than a description.

@Edtadros this is now available on https://test-commons.wikimedia.org . Basically we just need to make sure that adding qualifiers using an auto-suggest for the property as well as the value works, and nothing else is broken

We're not going to do it this way after all

I guess it is, but that'd effectively mean there'd be no 'publish' step for 'remove all' - it'd just warn you when you clicked it and remove-and-publish when you click 'ok'

@PDrouin-WMF any thoughts?

Update: it looks like after you add a qualifier then just the first qualifier for all statements in the panel disappears.

Ok cool, marking as invalid in favour of the other tickets

I think that might be hand-holding the user a little too much, but will defer to @PDrouin-WMF

Not really sure which JSON structure you mean @Addshore - but yeah, perhaps we should just explicitly index this stuff differently when doing the indexing. That's easy enough atm, but raises 2 questions:

Problem here was quantities with >1 commas - only the first was being replaced, and that made the javascript go screwy

We're storing captions in label because captions are essentially labels for images, and we already have a 'description' field in UploadWizard for wikitext

There are two things here to untangle, which really have very little to do with
each other, though they may sound similar.

The brief here is to make something that functions the same as the geo-coordinate input on wikidata

Yeah, I think they're being indexed as label fields, and also written into opening_text. See https://commons.wikimedia.org/wiki/File:Mute_swan_(Cygnus_olor)_in_Bowness-on-Windermere,_England.jpg?action=cirrusDump

This patch made a change to /includes/specials/pagers/ImageListPager.php on a line that calls getUrl() https://gerrit.wikimedia.org/r/c/mediawiki/core/+/510199

Live on commons now. Ok to close the ticket @Yupik @Zache @Keegan ?

Erm ... I think we're using the framed one, would be nice if it wasn't deleted

Happy to be able to help! :)

@Yupik hoping we can get the patch above deployed next week

@PDrouin-WMF this is on production now, I think we can resolve it?

This has been in production for 6 weeks. @Ramsey-WMF can we resolve it?

sorry, resolved by accident ...

Should be verifiable on production on Thurs, June 20

so ... what's the status here? We have a merged patch, but it's still in doing ... @egardner ?

Unassigning from myself - will reassign when ready for testing on beta

... or, indeed, on production

Should be able to test this on beta again now (or on test commons https://test-commons.wikimedia.org/wiki/Main_Page)

This has been released to production, so may as well check it there. Example file https://commons.wikimedia.org/wiki/File:Bellura_gortynoides.jpg

De-assigning from myself - will reassign once it's ready for testing on beta

Moving to "blocked" - we have a working (unreviewed) patch, but haven't decided to proceed with this approach