Page MenuHomePhabricator

CraigKahle
User

Projects

User does not belong to any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Monday

  • No visible events.

User Details

User Since
Nov 29 2024, 2:02 AM (60 w, 1 d)
Availability
Available
LDAP User
CraigKahle
MediaWiki User
CPKahle [ Global Accounts ]

Recent Activity

Jan 21 2025

CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

Hello again. Thank you very much @sbassett for the explanation. I would love to complete this task, however someone with deeper knowledge of the extension submodule structure may be better equipped to complete this. Thanks again to everyone that assisted and commented.

Jan 21 2025, 2:59 PM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security

Dec 7 2024

CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

Hey Gergő. Hope you are doing well. I wanted to check back in on this to ensure that CheckMatrixWidget.php needs updating. I will update the test later today.

Dec 7 2024, 6:06 PM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security

Dec 4 2024

CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

Thanks for taking a look. Looking at CheckMatrixWidget.php , it looks to be using OOUI ? If that isn't the case I can add to my feature branch. Which extensions should be updated? I am happy to take that on if it is in scope for this ticket.

Dec 4 2024, 2:22 AM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security

Dec 3 2024

CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

Thanks Gergő. Understood; I would agree with that. After tracing through each result from the regex you provided (thanks), I am only seeing two direct uses of HTMLForm:

Dec 3 2024, 6:28 AM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security

Nov 30 2024

CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

Gergő - I really appreciate the detailed response and advice. With that information, I'm going to give it another shot.

Nov 30 2024, 8:05 PM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security
CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

I added a topic branch to get started on this. Before I continue I wanted to ensure I'm on the right path. I am a new contributor and have a couple of questions:

Nov 30 2024, 2:02 AM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security

Nov 29 2024

CraigKahle added a comment to T356971: Rename help key to help-raw in HTMLForm and deprecate old key name.

I could take this on. The way I'm searching for deprecated usage is: 'help' => wfMessage; if I'm missing something, please let me know. Cheers and happy Thanksgiving for those who celebrate.

Nov 29 2024, 3:44 AM · MW-1.44-notes (1.44.0-wmf.12; 2025-01-14), MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), SecTeam-Processed, MediaWiki-HTMLForm, Vuln-XSS, Security