Page MenuHomePhabricator

Cyde (CydeWeys)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 14 2016, 1:39 AM (413 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Cyde [ Global Accounts ]

Recent Activity

Oct 1 2018

Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

I'm curious, what's the external blocker?

Oct 1 2018, 7:33 PM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer

Sep 24 2018

Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

Let me know if I can help with that in any way.

Sep 24 2018, 5:43 PM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer

Sep 20 2018

Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

I'm glad to see that Mozilla has fixed what ended up being a larger HSTS preload list syncing bug. Thanks for filing that.

Sep 20 2018, 4:17 PM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer

Aug 2 2018

Cyde added a comment to T200758: Performance review for SecureLinkFixer extension.

Another potential optimization -- because of the above restrictions, the overwhelming number of entries on the list have 2 labels. Using a dumb regex against the raw Chromium json file, I'm seeing 5.1K entries with 3 labels and 49K labels with 2 parts, almost 10X as many. Given that, it might make sense to consult the second-level domain first, and then the third-level domain, and then finally the TLD. I know the code won't be as clean but I suspect it'll be faster, because you'll be querying in order of highest hit rate.

Aug 2 2018, 2:58 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Performance-Team (Radar), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200758: Performance review for SecureLinkFixer extension.

In addition to checking access time, you should also check memory usage. How much bigger is the nested structure than the single level hashmap?

Aug 2 2018, 2:52 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Performance-Team (Radar), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200758: Performance review for SecureLinkFixer extension.

Yes, that's correct, you wouldn't also have to look up .org given that wikipedia.org is in the HSTS preload list. I was thinking from the perspective of some other domain that isn't preloaded individually but that is on a preloaded TLD, e.g. http://blog.google should always be rewritten to https://blog.google because .google is preloaded.

Aug 2 2018, 2:51 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Performance-Team (Radar), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

Yeah, it currently only seems to be once per release cycle. That might be all they need though based on their use case, seeing as how they're building a hard-coded list into a compiled and tested executable that will be widely distributed. Your use case is different -- you're not building and testing a browser, you just want the most up to date version of the list possible, whereas they might not want the list changing around during a release cycle as it could make testing difficult.

Aug 2 2018, 1:14 PM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer

Jul 31 2018

Cyde added a comment to T200758: Performance review for SecureLinkFixer extension.

Small correction to the description -- For that sample domain some.fake.domain.wikipedia.org, you'd also have to check whether org is preloaded, as TLDs themselves can be preloaded (e.g. .app, .dev, .google, and 10 more). Assuming that your 39K static array is kept in-memory and is implemented internally using a hashtable (I don't know enough about the internal workings of PHP), I'd think that'd be good enough. The only negative cache entries you'd be hitting more than some small fraction of the time would be those for common TLDs, at which point that lookup probably costs similar to the lookup into the array.

Jul 31 2018, 10:15 PM · Patch-For-Review, MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Performance-Team (Radar), Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

Unfortunately the lag time between Chromium's and Firefox's preload list can be substantial, potentially up to one full Firefox release lifecycle (12 weeks). For instance, this batch of domains added to Chromium's list on 2018-05-22 still hasn't made it to Firefox's list as of today, 2018-07-31. So you're looking at up to 13 weeks of total potential lag time (plus up to 30 days for parser caches) between a site being added to the list and it being enforced by this extension.

Jul 31 2018, 8:43 PM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

I see that you're using the Firefox HSTS preload list. Any particular reason for that? It's a copy of the master list maintained by the Chromium project, except with some additional lag time. So then there's lag time between Chromium and Firefox, and lag time between Firefox and MediaWiki.

Jul 31 2018, 2:52 AM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

Great. Thanks again!

Jul 31 2018, 1:40 AM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer
Cyde added a comment to T200745: Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list.

This is awesome! What a nice boon for the security of users on older or alternative browsers (especially the hundreds of millions of people using UC Browser). Let me know if you need any help re: the HSTS preload list; I know the guy who manages it.

Jul 31 2018, 1:17 AM · Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), WMF-General-or-Unknown, MediaWiki-extensions-SecureLinkFixer

May 21 2016

Cyde updated the task description for T135918: Port clear_cfd_templates.py to pywikibot-core.
May 21 2016, 6:56 PM · Pywikibot, Pywikibot-Scripts, Pywikibot-compat-to-core
Cyde updated the task description for T135918: Port clear_cfd_templates.py to pywikibot-core.
May 21 2016, 6:32 PM · Pywikibot, Pywikibot-Scripts, Pywikibot-compat-to-core
Cyde added a comment to T135918: Port clear_cfd_templates.py to pywikibot-core.

Here is the existing script that runs on pywikibot-compat:

May 21 2016, 6:27 PM · Pywikibot, Pywikibot-Scripts, Pywikibot-compat-to-core
Cyde created T135918: Port clear_cfd_templates.py to pywikibot-core.
May 21 2016, 6:25 PM · Pywikibot, Pywikibot-Scripts, Pywikibot-compat-to-core

May 16 2016

jayvdb awarded T135298: Improve edit summaries on CFD category moves a Cookie token.
May 16 2016, 2:20 AM · Patch-For-Review, Pywikibot-category.py
Cyde created T135354: Add CFD working page parameter to cfd.py.
May 16 2016, 2:18 AM · Patch-For-Review, Pywikibot-compat-to-core, Pywikibot-category.py
Cyde closed T135298: Improve edit summaries on CFD category moves as Resolved.
May 16 2016, 2:16 AM · Patch-For-Review, Pywikibot-category.py

May 14 2016

Cyde created T135298: Improve edit summaries on CFD category moves.
May 14 2016, 1:59 AM · Patch-For-Review, Pywikibot-category.py
Cyde added a member for Pywikibot-General: Cyde.
May 14 2016, 1:41 AM
Cyde added a member for Pywikibot-category.py: Cyde.
May 14 2016, 1:40 AM