D3r1ck01 (Derick Alangi)
Software Engineer | V. Developer {at} Wikimedia

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2015, 6:40 AM (179 w, 1 d)
Availability
Available
IRC Nick
xSavitar
LDAP User
Unknown
MediaWiki User
X-Savitar [ Global Accounts ]

Attempting to be punctilious, so I make good use of my personal work board: User-D3r1ck01.

Recent Activity

Yesterday

D3r1ck01 placed T202230: Populate the contributors.json file in awmd-stats tool with contributors details up for grabs.

@Ifeanyijasper, I've removed you as assignee as the task is a continuous process for volunteer developers to add themselves and reference the issue. It's not a one-time kinda task to do and resolve. I've reviewed your patch as well, check!

Mon, Feb 18, 11:09 PM · good first bug, Africa-Wikimedia-Developers
D3r1ck01 added a member for Africa-Wikimedia-Developers: Ifeanyijasper.
Mon, Feb 18, 10:59 PM
D3r1ck01 placed T146418: Special:Contributions lists namespaces by index number, which is not intuitive up for grabs.

Removing self as assignee till a direction is agreed upon and if the pending patch should be continued.

Mon, Feb 18, 9:38 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

Per above messages, it would be better for a design discussion or decision to be made on this before further work is done on it. Once a direction is agreed upon, implementing it would not be an overkill, so far, the comments are gradually scoping to a direction but let the experts speak on this.

Mon, Feb 18, 9:36 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

For Čeština which is the language spoken in Czech supported by MediaWiki, image below;

Mon, Feb 18, 8:40 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

I've tested this patch across 3 different languages, respectively - English(en), French(fr), Espanol(es) and Kotana, see images below;

Mon, Feb 18, 8:35 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

So @Amorymeltzer, in summary, the algorithm should work irrespective of the list given to it. All it cares about is what to reserve which are ("all" and "(Main)), then the rest will be handled accordingly :)

Mon, Feb 18, 8:04 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 added a comment to T146418: Special:Contributions lists namespaces by index number, which is not intuitive.

@Amorymeltzer, basically, the algorithm I used just checks if "all" and "(Main)" is available and reserve their positions, then sorts the rest alphabetically but keeps their values (namespace constants - integers) in tact.

Mon, Feb 18, 8:01 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 moved T146418: Special:Contributions lists namespaces by index number, which is not intuitive from Radar to Doing (Work In Progress) on the User-D3r1ck01 board.
Mon, Feb 18, 7:38 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 claimed T146418: Special:Contributions lists namespaces by index number, which is not intuitive.
Mon, Feb 18, 7:38 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 updated the task description for T146418: Special:Contributions lists namespaces by index number, which is not intuitive.
Mon, Feb 18, 7:37 PM · Design, User-D3r1ck01, Patch-For-Review, MediaWiki-Special-pages
D3r1ck01 moved T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number from Radar to Pending Review on the User-D3r1ck01 board.
Mon, Feb 18, 2:24 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), User-D3r1ck01, Wikimedia-production-error, MediaWiki-Special-pages
D3r1ck01 claimed T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number.
Mon, Feb 18, 2:24 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), User-D3r1ck01, Wikimedia-production-error, MediaWiki-Special-pages
D3r1ck01 moved T212938: Variable doc for api Variable ends with irrelevant string from New Contributor's Tasks (Incoming) to Technical Tasks (Completed) on the Africa-Wikimedia-Developers board.
Mon, Feb 18, 1:37 PM · Patch-For-Review, Africa-Wikimedia-Developers, good first bug, FormWizard
D3r1ck01 closed T212938: Variable doc for api Variable ends with irrelevant string as Resolved.
Mon, Feb 18, 1:37 PM · Patch-For-Review, Africa-Wikimedia-Developers, good first bug, FormWizard
D3r1ck01 committed rEFWZ93225b777bc3: Remove irrelevant `` in ext.formwizard.js (authored by Mahveotm).
Remove irrelevant `` in ext.formwizard.js
Mon, Feb 18, 1:31 PM
D3r1ck01 committed rEFWZ2c25faf9ccd0: Remove irrelevant `` from ext.formwizard.js (authored by Mahveotm).
Remove irrelevant `` from ext.formwizard.js
Mon, Feb 18, 1:31 PM

Sun, Feb 17

D3r1ck01 added a comment to T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number.

@Krinkle, I've walked through the problem and attempted to solve it using the second approach you suggested here: T150324#4897404, it indeed needed sometime to get the solution through. I've tagged you for review, thanks!

Sun, Feb 17, 9:13 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), User-D3r1ck01, Wikimedia-production-error, MediaWiki-Special-pages
D3r1ck01 added a comment to T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number.

@Krinkle, I followed the steps but I'll like to exactly explain here what the issue is as the description above is not that specific as per what is going wrong.

Sun, Feb 17, 8:40 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), User-D3r1ck01, Wikimedia-production-error, MediaWiki-Special-pages

Sat, Feb 16

D3r1ck01 added a comment to T150324: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number.

As of 1.33.0-alpha (333eaea), this has disappeared. The page no longer throws a fatal error processes the request and no result is returned with the message No changes were found matching these criteria. Also, below are the following notices;

Sat, Feb 16, 11:02 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), User-D3r1ck01, Wikimedia-production-error, MediaWiki-Special-pages

Fri, Feb 15

D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Feb 15, 9:29 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 removed a project from T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php: Patch-For-Review.
Fri, Feb 15, 9:28 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 updated the task description for T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.
Fri, Feb 15, 9:28 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 updated subscribers of T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.

Thanks @thiemowmde for reviewing and merging the patch that attempts to fix the issue and nicely does so :), per https://doc.wikimedia.org/cover-extensions/MobileFrontend/MobileFrontend.skin.hooks.php.html, we now have the method fully covered to 100%.

Fri, Feb 15, 9:28 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 added a comment to T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.

@Jdlrobson, code coverage https://doc.wikimedia.org/cover-extensions/MobileFrontend/MobileFrontend.skin.hooks.php.html reports 95.56%.

Fri, Feb 15, 8:19 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Thu, Feb 14

D3r1ck01 added a comment to T214878: English Wikivoyage NavPopups gadget conflicts with Page previews .

You're welcome sir! :)

Thu, Feb 14, 8:03 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), User-D3r1ck01, Patch-For-Review, Need-volunteer, Wikimedia-Site-requests
D3r1ck01 awarded T214878: English Wikivoyage NavPopups gadget conflicts with Page previews a Party Time token.
Thu, Feb 14, 8:03 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), User-D3r1ck01, Patch-For-Review, Need-volunteer, Wikimedia-Site-requests
D3r1ck01 reassigned T214878: English Wikivoyage NavPopups gadget conflicts with Page previews from D3r1ck01 to Jdlrobson.
Thu, Feb 14, 7:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), User-D3r1ck01, Patch-For-Review, Need-volunteer, Wikimedia-Site-requests
D3r1ck01 added a comment to T214878: English Wikivoyage NavPopups gadget conflicts with Page previews .

@Jdlrobson, this has been deployed and it's live, Will leave this for you to sign-off :)

Thu, Feb 14, 7:17 PM · Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), User-D3r1ck01, Patch-For-Review, Need-volunteer, Wikimedia-Site-requests
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Thu, Feb 14, 3:30 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 edited projects for T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php, added: Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Readers-Web-Backlog.
Thu, Feb 14, 3:30 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Wed, Feb 13

D3r1ck01 updated subscribers of T179513: Special:Emailuser is using project name in the From field.

Related ticket is: T188495: Display emails sent from Special:EmailUser as "$username via $wgSiteName" as sender.

Wed, Feb 13, 10:51 AM · MediaWiki-Email

Mon, Feb 11

D3r1ck01 moved T215385: Africa Wikimedia Developers IRC general meeting #15 from Non-Technical Tasks (Completed) to Upcoming Events on the Africa-Wikimedia-Developers board.
Mon, Feb 11, 11:46 AM · Africa-Wikimedia-Developers
D3r1ck01 added a member for Africa-Wikimedia-Developers: farida29.
Mon, Feb 11, 11:44 AM

Sat, Feb 9

D3r1ck01 awarded T215249: SparkPost reply-to function support, please a Party Time token.
Sat, Feb 9, 12:30 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

Same problem as mentioned in T214664 . Where multiple Content-Transfer-Encoding made contents after the first Content-Transfer-Encoding become random code like =E6 . Might need to reopen T214664 .

Sat, Feb 9, 12:29 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 moved T182743: djvu related binaries should have shell restrictions applied from Pending Review to Doing (Work In Progress) on the User-D3r1ck01 board.
Sat, Feb 9, 11:02 AM · User-D3r1ck01, Patch-For-Review, Multimedia, MediaWiki-DjVu, MediaWiki-Shell
D3r1ck01 moved T215249: SparkPost reply-to function support, please from Doing (Work In Progress) to Pending Review on the User-D3r1ck01 board.
Sat, Feb 9, 11:01 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

So what are the random content errors? Any example?

Sat, Feb 9, 11:01 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

@Zoglun, you're up for testing and let me know if it works as expected. Thanks!

Sat, Feb 9, 10:47 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

Not at all, wanted to clear some privacy concerns! Patch is already ready and coming out soon!

Sat, Feb 9, 10:30 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 moved T215249: SparkPost reply-to function support, please from Radar to Doing (Work In Progress) on the User-D3r1ck01 board.
Sat, Feb 9, 10:30 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a project to T215249: SparkPost reply-to function support, please: User-D3r1ck01.
Sat, Feb 9, 10:30 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost

Tue, Feb 5

D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

@Zoglun, I think I know what is happening but like I said, I'll get back to you on this. Thanks :)

Tue, Feb 5, 1:09 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

@Zoglun, I think I know what is happening but like I said, I'll get back to you on this. Thanks :)

Tue, Feb 5, 12:55 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

Also, I'm trying to reproduce this using the SendGrid extension to see if it's the same problem!

Tue, Feb 5, 12:46 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

Hmmm... not sure but I think that should be normal behavior or expected? Extracted from the $wgUserEmailUseReplyTo page;

MediaWiki installations on a shared server may fail to send user-to-user email due to spam prevention by disabling open mail relaying.
Setting to true may create a privacy issue, as bounces containing the recipient's email address may get returned to the server's sending user email address.
Tue, Feb 5, 12:34 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

@Zoglun, pull and test. Make sure $wgUserEmailUseReplyTo is set to true too. Thanks, looking forward to your feedback.

Tue, Feb 5, 12:15 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 claimed T215249: SparkPost reply-to function support, please.
Tue, Feb 5, 12:02 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

Hmm... so this doesn't relate to core as far as I see, it's just some feature to add to any email extension. I've made a patch which I'll merge soon and you'll test. Thanks :)

Tue, Feb 5, 12:01 PM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

Okay! Let me try to tackle this at the level of this extension then see what is happening deep down within the core then!

Tue, Feb 5, 11:39 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T215249: SparkPost reply-to function support, please.

@Zoglun, does that mean when you set $wgUserEmailUserReplyTo = true, it doesn't set the reply_to field in the request header? So this config is not enough?

Tue, Feb 5, 11:32 AM · User-D3r1ck01, Patch-For-Review, MediaWiki-extensions-SparkPost

Mon, Feb 4

D3r1ck01 updated the task description for T212847: [Extension Request] Build a SparkPost Email Delivery extension for MediaWiki.
Mon, Feb 4, 2:28 PM · MediaWiki-extensions-SparkPost, MediaWiki-extension-requests, User-D3r1ck01
D3r1ck01 closed T214918: [[MediaWiki:Timeless-sitetitle]] should transclude {{int:}} instead of {{Mediawiki:}} as Resolved.

Thanks for your review @Isarra!

Mon, Feb 4, 2:03 PM · MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), Timeless, Patch-For-Review, I18n
D3r1ck01 moved T213333: PHPUnit: Cover all code paths for the SparkPost extension from Radar to Doing (Work In Progress) on the User-D3r1ck01 board.
Mon, Feb 4, 9:39 AM · Patch-For-Review, MediaWiki-extensions-SparkPost, User-D3r1ck01
D3r1ck01 claimed T213333: PHPUnit: Cover all code paths for the SparkPost extension.
Mon, Feb 4, 9:39 AM · Patch-For-Review, MediaWiki-extensions-SparkPost, User-D3r1ck01
D3r1ck01 awarded T215144: Enforce @covers… tags to have full qualified class names starting with backslash a Like token.
Mon, Feb 4, 9:23 AM · MediaWiki-Codesniffer
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Ready for Signoff to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Mon, Feb 4, 9:21 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 removed a project from T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php: Patch-For-Review.
Mon, Feb 4, 9:21 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Sat, Feb 2

D3r1ck01 added a comment to T215078: TypeError when running solve_disambiguation.

I'll leave this for @Xqt to resolve. Thanks :)

Sat, Feb 2, 9:21 PM · Patch-For-Review, Regression, Pywikibot
Mahveotm awarded T184192: Africa Wikimedia Developers Leaderboard Monthly Statistics for the year 2018 a Love token.
Sat, Feb 2, 1:55 PM · Developer-Advocacy, Africa-Wikimedia-Developers
D3r1ck01 updated the task description for T213581: Africa Wikimedia Developers Leader Board Monthly Statistics for the year 2019.
Sat, Feb 2, 8:15 AM · Developer-Advocacy, Africa-Wikimedia-Developers

Fri, Feb 1

D3r1ck01 added a comment to T211471: taint-checks for Renameuser failing.

Occurred here too: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Renameuser/+/487134.

Fri, Feb 1, 6:15 PM · Patch-For-Review, MediaWiki-extensions-Renameuser, phan-taint-check-plugin
D3r1ck01 awarded T211471: taint-checks for Renameuser failing a Like token.
Fri, Feb 1, 6:14 PM · Patch-For-Review, MediaWiki-extensions-Renameuser, phan-taint-check-plugin
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Doing to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Feb 1, 8:57 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Ready for Signoff to Doing on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Fri, Feb 1, 8:36 AM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Thu, Jan 31

D3r1ck01 moved T182743: djvu related binaries should have shell restrictions applied from Radar to Pending Review on the User-D3r1ck01 board.
Thu, Jan 31, 7:06 PM · User-D3r1ck01, Patch-For-Review, Multimedia, MediaWiki-DjVu, MediaWiki-Shell
D3r1ck01 claimed T182743: djvu related binaries should have shell restrictions applied.
Thu, Jan 31, 7:06 PM · User-D3r1ck01, Patch-For-Review, Multimedia, MediaWiki-DjVu, MediaWiki-Shell
D3r1ck01 closed T182747: vips binary should have shell restrictions applied as Resolved.

Seems this has handled this bug already: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VipsScaler/+/384430. Marking as resolved!

Thu, Jan 31, 6:45 PM · MediaWiki-extensions-VipsScaler, MediaWiki-Shell
D3r1ck01 closed T182747: vips binary should have shell restrictions applied, a subtask of T172584: Securing external binaries run by MediaWiki, as Resolved.
Thu, Jan 31, 6:45 PM · MediaWiki-Shell, Operations, Wikimedia-General-or-Unknown, Security
D3r1ck01 closed T182745: Installer's shelling out to `locale` should have shell restrictions applied as Resolved.

Ah, caught this one too, was also handled by @MaxSem back in 2018. See patch here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/386330.

Thu, Jan 31, 6:41 PM · MediaWiki-Installer, MediaWiki-Shell
D3r1ck01 closed T182745: Installer's shelling out to `locale` should have shell restrictions applied, a subtask of T172584: Securing external binaries run by MediaWiki, as Resolved.
Thu, Jan 31, 6:41 PM · MediaWiki-Shell, Operations, Wikimedia-General-or-Unknown, Security
D3r1ck01 awarded T182744: $wgMimeDetectorCommand should have shell restrictions applied a Like token.
Thu, Jan 31, 6:29 PM · MediaWiki-File-management, Commons, MediaWiki-Shell
D3r1ck01 closed T182744: $wgMimeDetectorCommand should have shell restrictions applied as Resolved.

From what I see, this no longer exist, code has been refactored out and now uses services. Did some digging and noticed @MaxSem made the patch back in 2018: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/386329. So this can safely be marked as resolved!

Thu, Jan 31, 6:29 PM · MediaWiki-File-management, Commons, MediaWiki-Shell
D3r1ck01 closed T182744: $wgMimeDetectorCommand should have shell restrictions applied, a subtask of T172584: Securing external binaries run by MediaWiki, as Resolved.
Thu, Jan 31, 6:29 PM · MediaWiki-Shell, Operations, Wikimedia-General-or-Unknown, Security
D3r1ck01 added a member for BetaFeatures: D3r1ck01.
Thu, Jan 31, 5:23 PM

Wed, Jan 30

D3r1ck01 committed rTAWR089a4a6dc27e: Use self() instead of class name to make things flexible (authored by D3r1ck01).
Use self() instead of class name to make things flexible
Wed, Jan 30, 9:28 PM
D3r1ck01 added a comment to T209486: PHP Codesniffer errors and warnings misleading for phpunitannotations sniff.

Thanks for working on this @Umherirrender :)

Wed, Jan 30, 6:11 PM · Patch-For-Review, MediaWiki-Codesniffer
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Wed, Jan 30, 3:30 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 updated the task description for T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.
Wed, Jan 30, 3:30 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01

Tue, Jan 29

D3r1ck01 claimed T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.
Tue, Jan 29, 7:30 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Needs More Work to Needs Code Review on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 29, 7:27 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 removed a project from T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php: Patch-For-Review.
Tue, Jan 29, 6:08 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 moved T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php from Needs Code Review to Needs More Work on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.
Tue, Jan 29, 6:05 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 updated the task description for T214800: PHPUnit: Cover all methods in MobileFrontend.skin.hooks.php.
Tue, Jan 29, 6:05 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), MobileFrontend, User-D3r1ck01
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Perfect perfect perfect! Do you have an IRC handle so we can chat there, phabricator is kinda slow but it works though, just wondering if you're available on IRC.

Tue, Jan 29, 1:41 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 awarded T214664: Random codes in mail contents, when using sparkpost a Party Time token.
Tue, Jan 29, 1:24 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

@Zoglun, revert has been reverted. Let me know if everything is fine now. I'll like to bump this version of the extension to 1.1 too :). Confirm if everything is fine let me do that in an upcoming patch!

Tue, Jan 29, 1:22 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Okay, let me revert the revert then :D

Tue, Jan 29, 1:12 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Hmmm.... So are you suggesting we maintain the last change before revert or things are fine now?

Tue, Jan 29, 1:07 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

You're welcome anytime! Ops, sorry I didn't update you about the change in names to the config variable names, used "P" instead of "p". Sorry, I should have told you!

Tue, Jan 29, 12:55 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Okay cool! Nice to hear that, meaning I can revert the last patch as it's just same as previous but using a different approach. I'll prefer to use the previous rather than the last patch. Let me revert the latest patch :)

Tue, Jan 29, 12:47 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 removed a project from T214664: Random codes in mail contents, when using sparkpost: Patch-For-Review.

Please could you test again, I've made another patch to fix this issue. Looking forward to your feedback :)

Tue, Jan 29, 12:30 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

So I guess this could now be an issue with the format, let me fix this and make another follow up :), I guess the follow up will fix it. Hang on :)

Tue, Jan 29, 12:01 PM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Please, just in case, could you pull on master? I'm pretty sure things should be find now? Just double check let's see. :)

Tue, Jan 29, 11:52 AM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 removed a project from T214664: Random codes in mail contents, when using sparkpost: Patch-For-Review.
Tue, Jan 29, 11:44 AM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

@Zoglun, I was able to track down the issue. I've made another patch to fix it. I've merged it, let me know if that works now. Thanks :)

Tue, Jan 29, 11:44 AM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 removed a project from T214664: Random codes in mail contents, when using sparkpost: Patch-For-Review.
Tue, Jan 29, 11:07 AM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Ohhh, also, I think I know what is wrong, I'm making a quick follow up patch and merge while you test and also while I wait for the API Key to be using for testing for upcoming patches. Thanks!

Tue, Jan 29, 11:02 AM · User-D3r1ck01, MediaWiki-extensions-SparkPost
D3r1ck01 added a comment to T214664: Random codes in mail contents, when using sparkpost.

Ohhh, also, I think I know what is wrong, I'm making a quick follow up patch and merge while you test and also while I wait for the API Key to be using for testing for upcoming patches. Thanks!

Tue, Jan 29, 10:54 AM · User-D3r1ck01, MediaWiki-extensions-SparkPost