Attempting to be punctilious, so I make good use of my personal work board: User-D3r1ck01.
Ohhh, thank you :)
Soft deprecation done. Next is removal from use in Wikimedia production, then hard deprecation, then removal (in MW 1.35 if we get the rest done by MW 1.33).
Mon, Dec 17
Removed myself as I won't be part of the meeting!
Per https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/479757, @pmiazga submitted a PS for review, though it needs a rebase, so adjusting this appropriately.
Sun, Dec 16
@Aklapper, you're awesome, we now have the stats and yes, you can resolve it. Thanks a lot! <3
Hey, sorry for the delay. Stats can be published. I'm okay with it ;)
Should this be postponed (as it didn't take place) or should we mark it as resolved?
Sat, Dec 15
Thu, Dec 13
The game continues :)
Looks like the units are failing in core (T211903) so I'm going to do the easiest thing and revert these tests. Please don't be too dispirited - we'll attempt these again!
Wed, Dec 12
Thanks @Aklapper. So this task was mostly done by @Framawiki, @Dvorapa and @D3r1ck01. But I can't leave out @Xqt who did a lot of code review during GCI but wasn't a GCI mentor to be specific. So I'm wondering who will claim this but I assume @Framawiki for bringing up the idea :)
Tue, Dec 11
Should be good for review now!
Mon, Dec 10
Sun, Dec 9
On the root of VisualEditor (repo), here is a symlink (with name .stylelinkrc.json) I see;
Wed, Dec 5
Tue, Dec 4
Some good progress so far by @Reedy (thanks), @thiemowmde (for reviewing thoroughly) and finally @Legoktm (for landing the patch). So now with this patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GuidedTour/+/466675 with 1 autoloaded class and psr-4, we have the following error;
10:47:05 1) AutoLoaderStructureTest::testAutoLoadConfig 10:47:05 Failed asserting that two arrays are equal. 10:47:05 --- Expected 10:47:05 +++ Actual 10:47:05 @@ @@ 10:47:05 'ZeroPortal\ZeroConfigView' => '/workspace/src/extensions/Zer...ew.php' 10:47:05 + 'MediaWiki\GuidedTour\Launcher' => '/workspace/src/extensions/Gui...er.php' 10:47:05 ) 10:47:05 10:47:05 /workspace/src/tests/phpunit/structure/AutoLoaderStructureTest.php:19 10:47:05 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424 10:47:05 /workspace/src/maintenance/doMaintenance.php:94 10:47:05
So still for some reason, when autoload classes and psr-4 are used at the same time, the mapping of classes to their corresponding files is not still composed correctly. A follow up patch to AutoloaderStructureTest coming soon...
Mon, Dec 3
Note there are three Acceptance Criteria, but for whatever reason Phabricator does not show the last one as a list item.
Sun, Dec 2
Sat, Dec 1
Fri, Nov 30
@D3r1ck01 is there community support for this idea? Do many people find this useful?
Thu, Nov 29
Thanks for reviewing & merging @dcausse.
Can be nicely gently resolved(?). The CirrusSearch ticket is tracked here: T210512: MediaWiki Core LocalIdLookupTest uses undefined wgDBName.
Wed, Nov 28
@RazeSoldier, are you talking of https://codesearch.wmflabs.org/core/?q=Zlib&i=nope&files=&repos= or are there more?
Tue, Nov 27
Again, a request for a gentle review :), may likely move back to "Needs more work" but would like to know if this is the right direction :)