Page MenuHomePhabricator

DAlangi_WMF
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 7 2020, 11:30 AM (215 w, 1 d)
Availability
Available
IRC Nick
xSavitar
LDAP User
Unknown
MediaWiki User
DAlangi (WMF) [ Global Accounts ]

Official WMF Phabricator work account. @xSavitar is my volunteer account. Use that for non-WMF related things.

Recent Activity

Today

DAlangi_WMF moved T354975: ResourceLoaderSkinModule should load core styles before skin styles from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Wed, Feb 21, 7:47 AM · MediaWiki-ResourceLoader, MediaWiki-Platform-Team, Patch-For-Review, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), FY2023-24-WE 2.1 Typography and palette customizations, Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Desktop Improvements (Vector 2022), MediaWiki-Core-Skin-Architecture

Yesterday

DAlangi_WMF closed T105341: MemcachedPhpBagOStuff::incr() returns string instead of integer as Resolved.

After some digging, it turns out @tstarling already fixed this in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/807663 since back in 2022. Thank you Tim <3

Tue, Feb 20, 7:38 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
DAlangi_WMF reopened T105341: MemcachedPhpBagOStuff::incr() returns string instead of integer as "Open".

I misunderstood, this. This is about MemcachedPhpBagOStuff not wgMemc.

Tue, Feb 20, 5:31 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
DAlangi_WMF closed T105341: MemcachedPhpBagOStuff::incr() returns string instead of integer as Resolved.
Tue, Feb 20, 5:16 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
DAlangi_WMF added a comment to T105341: MemcachedPhpBagOStuff::incr() returns string instead of integer.
Tue, Feb 20, 5:14 PM · MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff

Mon, Feb 19

DAlangi_WMF closed T357854: Math CI tests are broken as Resolved.

This is now resolved. Math CI is no longer broken. See: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/1004309.

Mon, Feb 19, 4:09 PM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, ci-test-error
DAlangi_WMF changed the status of T356062: Migrate ObjectCache in MW core to StatsLib from Open to In Progress.
Mon, Feb 19, 1:37 PM · Patch-For-Review, MediaWiki-Platform-Team, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF changed the status of T356062: Migrate ObjectCache in MW core to StatsLib, a subtask of T343020: Converting MediaWiki Metrics to StatsLib, from Open to In Progress.
Mon, Feb 19, 1:37 PM · SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF changed the status of T357854: Math CI tests are broken from Open to In Progress.
Mon, Feb 19, 10:17 AM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, ci-test-error
DAlangi_WMF added a comment to T357854: Math CI tests are broken.

@Physikerwelt, I was able to track down the issue here. In summary, it's because the mock will return a NULL user object which will break in CA on the onGetPreferences() hook run. I've made a patch to fix this.

Mon, Feb 19, 10:16 AM · MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, ci-test-error

Fri, Feb 16

DAlangi_WMF closed T343963: CentralAuthUser::getInstanceByName (and similar) should normalize the user name as Resolved.

With the CA patch merged, I think this is resolved. Please reopen if there is something we're missing.

Fri, Feb 16, 7:15 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth

Thu, Feb 15

DAlangi_WMF moved T357477: InvalidArgumentException: Script must be a string or array from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Thu, Feb 15, 4:09 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-ResourceLoader, Wikimedia-production-error
DAlangi_WMF moved T357653: Replace usage of wfGetDB() in OAuth before the 1.42 cut so it can be hard-deprecated from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Thu, Feb 15, 4:09 PM · Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-OAuth, Technical-Debt

Fri, Feb 9

DAlangi_WMF moved T357160: Treat single and double quotes as equal in "when" operator from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Fri, Feb 9, 6:28 PM · MediaWiki-Platform-Team, Less.php
DAlangi_WMF closed T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib as Resolved.
Fri, Feb 9, 6:24 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats
DAlangi_WMF closed T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib, a subtask of T356062: Migrate ObjectCache in MW core to StatsLib, as Resolved.
Fri, Feb 9, 6:24 PM · Patch-For-Review, MediaWiki-Platform-Team, SRE Observability (FY2023/2024-Q3), Observability-Metrics

Thu, Feb 8

DAlangi_WMF added a comment to T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib.
new StatsFactory( new StatsCache, new NullEmitter, new NullLogger );

Would this work?

Thu, Feb 8, 5:51 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats

Mon, Feb 5

DAlangi_WMF moved T354928: Allow denial of account creation for IPs known to ipoid from Current Sprint to Radar on the MediaWiki-Platform-Team board.
Mon, Feb 5, 4:02 PM · MediaWiki-Platform-Team (Radar), MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), User-notice, Trust and Safety Product Team, iPoid-Service, MediaWiki-extensions-CentralAuth
DAlangi_WMF moved T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib from Current Sprint to Radar on the MediaWiki-Platform-Team board.
Mon, Feb 5, 10:24 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats
DAlangi_WMF placed T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib up for grabs.
Mon, Feb 5, 10:23 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats

Thu, Feb 1

DAlangi_WMF closed T354905: migrate MediaWiki.timing.editResponseTime to statslib as Resolved.

The tasks that this depends on has been resolved and the patch for this task has been merged as well. Marking this as resolved.

Thu, Feb 1, 11:57 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team, Patch-For-Review, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF closed T354905: migrate MediaWiki.timing.editResponseTime to statslib, a subtask of T350592: migrate in use metrics and dashboards to statslib, as Resolved.
Thu, Feb 1, 11:57 AM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), SRE Observability (FY2023/2024-Q3), MediaWiki-Platform-Team (Radar), Observability-Metrics

Wed, Jan 31

DAlangi_WMF added a comment to T356247: CI test failure due to Git error.

Thanks for merging @Jdforrester-WMF :)

Wed, Jan 31, 4:49 PM · Quibble, Continuous-Integration-Infrastructure, ci-test-error (WMF-deployed Build Failure), Growth-Team, Thanks
DAlangi_WMF updated subscribers of T356286: Consider changing StatsLib's handling of disallowed label values.
Wed, Jan 31, 4:48 PM · MediaWiki-libs-Stats
DAlangi_WMF added a comment to T356286: Consider changing StatsLib's handling of disallowed label values.

I was thinking about this a while ago and so far, the only idea that comes to mind is to use the <Metric_Name>.<Unknwown_Label> format.

Wed, Jan 31, 4:47 PM · MediaWiki-libs-Stats
DAlangi_WMF updated the task description for T356282: Git command error breaking CI builds.
Wed, Jan 31, 4:13 PM · ci-test-error, Gerrit
DAlangi_WMF created T356282: Git command error breaking CI builds.
Wed, Jan 31, 4:12 PM · ci-test-error, Gerrit
DAlangi_WMF moved T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Wed, Jan 31, 10:13 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats
DAlangi_WMF added a comment to T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib.

Let me know what you think about this @colewhite.

Wed, Jan 31, 10:13 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats
DAlangi_WMF renamed T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib from Introduce IStatsFactory and NullStatsFactory in StatsLib to Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib.
Wed, Jan 31, 10:13 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats
DAlangi_WMF created T356251: Proposal: Introduce IStatsFactory and NullStatsFactory in StatsLib.
Wed, Jan 31, 10:02 AM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team (Radar), MediaWiki-libs-Stats

Mon, Jan 29

DAlangi_WMF claimed T356062: Migrate ObjectCache in MW core to StatsLib.
Mon, Jan 29, 3:17 PM · Patch-For-Review, MediaWiki-Platform-Team, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF moved T356062: Migrate ObjectCache in MW core to StatsLib from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Jan 29, 3:17 PM · Patch-For-Review, MediaWiki-Platform-Team, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF created T356062: Migrate ObjectCache in MW core to StatsLib.
Mon, Jan 29, 3:16 PM · Patch-For-Review, MediaWiki-Platform-Team, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF moved T343963: CentralAuthUser::getInstanceByName (and similar) should normalize the user name from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.
Mon, Jan 29, 2:13 PM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
DAlangi_WMF moved T355378: Prepare OAuth extension for IP Masking from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Mon, Jan 29, 2:07 PM · Patch-For-Review, MediaWiki-Platform-Team, Temporary accounts, MediaWiki-extensions-OAuth

Tue, Jan 23

DAlangi_WMF added a comment to T355673: Check math BagOStuff cache.

I don't see any calls to that system (https://logstash.wikimedia.org/goto/a320f7f412a405e16722862a785cd60f), maybe it's cached in another layer.

Maybe this could help you figure out what's not working: https://performance.wikimedia.org/excimer/profile/2a392df184f9ca6d

Tue, Jan 23, 4:50 PM · MediaWiki-libs-BagOStuff, MediaWiki-Platform-Team, Math
DAlangi_WMF added a comment to T355673: Check math BagOStuff cache.

I tried to dig around Grafana's BagOStuff dashboard "by keygroup" to see if I can find something related to Math* keygroup but didn't find anything. For example: https://grafana.wikimedia.org/d/4plhqSPGk/bagostuff-stats-by-key-group?var-kClass=MathRenderer

Tue, Jan 23, 2:14 PM · MediaWiki-libs-BagOStuff, MediaWiki-Platform-Team, Math
DAlangi_WMF added a comment to T354907: migrate MediaWiki.RevisionSlider.timing.init to statslib.

@colewhite, this metric is tracked in JS land using the mw.track() method (doc) in ResourceLoader. I'm not sure we have an equivalent for statsLib yet.

Tue, Jan 23, 12:54 PM · SRE Observability (FY2023/2024-Q3), MediaWiki-Platform-Team (Radar), Observability-Metrics
DAlangi_WMF moved T354905: migrate MediaWiki.timing.editResponseTime to statslib from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.

Depends on: T355354 and T355361. Once that work is complete, we can make progress on this.

Tue, Jan 23, 12:41 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team, Patch-For-Review, SRE Observability (FY2023/2024-Q3), Observability-Metrics

Jan 22 2024

DAlangi_WMF merged task T355562: Link to Gerrit dashboard (MediaWiki platform broken) into T355561: Gerrit team dashboards no longer load.
Jan 22 2024, 4:14 PM · Gerrit (Gerrit 3.7)
DAlangi_WMF merged T355562: Link to Gerrit dashboard (MediaWiki platform broken) into T355561: Gerrit team dashboards no longer load.
Jan 22 2024, 4:14 PM · Gerrit (Gerrit 3.7)
DAlangi_WMF created T355562: Link to Gerrit dashboard (MediaWiki platform broken).
Jan 22 2024, 4:08 PM · Gerrit (Gerrit 3.7)
DAlangi_WMF closed T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc) as Resolved.

Finally 🎉

Jan 22 2024, 8:37 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF updated the task description for T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc).
Jan 22 2024, 8:36 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF added a comment to T355361: Support emitting a single sample to multiple statsd namespaces.

@colewhite, I like option 3. We already have plenty of places in our code bases where we support this kind of API for methods/functions (e.g. our config system and query builder - [1][2][3]) and also, I prefer it over option 1 which is purely fluent because we don't have to repeat calls/let the developer know they have to do this 3 times for the same method call. So option 3 would just take an array of keys and the magic will happen in the underground implementation.

Jan 22 2024, 8:16 AM · MW-1.42-notes (1.42.0-wmf.16; 2024-01-30), MediaWiki-libs-Stats

Jan 19 2024

DAlangi_WMF added a comment to T355375: Removed wgTemporaryParsoidHandlerParserCacheWriteRatio.

Thanks for this ticket C.Scott. I had made some patches last year to handle this when it's time and then forgot :(

Jan 19 2024, 9:16 AM · MediaWiki-Engineering, Parsoid (Tracking), Patch-For-Review, API Platform (RESTbase Deprecation Roadmap)

Jan 18 2024

DAlangi_WMF added a watcher for MediaWiki-libs-Stats: DAlangi_WMF.
Jan 18 2024, 7:55 PM
DAlangi_WMF updated subscribers of T355354: Metric instances do not check to ensure label compatibility when adding a sample.
Jan 18 2024, 7:55 PM · MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), MediaWiki-libs-Stats

Jan 17 2024

DAlangi_WMF added a comment to T268526: Use a dedicated mechanism to track page dependencies.

I vote for page_dependencies. Sounds more natural and describes the intention of what the table is just by the name. The only issue with that is "dependencies" in the name could not only mean it depends on other pages but on other things.

Jan 17 2024, 5:10 PM · Schema-change, MediaWiki-Page-derived-data, Patch-For-Review, Epic, MediaWiki-Parser

Jan 16 2024

DAlangi_WMF awarded Web Perf Hero to recipient: TK-999.
Jan 16 2024, 8:41 AM

Jan 15 2024

DAlangi_WMF claimed T354905: migrate MediaWiki.timing.editResponseTime to statslib.
Jan 15 2024, 12:08 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team, Patch-For-Review, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF moved T354905: migrate MediaWiki.timing.editResponseTime to statslib from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Jan 15 2024, 12:07 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team, Patch-For-Review, SRE Observability (FY2023/2024-Q3), Observability-Metrics
DAlangi_WMF edited projects for T354905: migrate MediaWiki.timing.editResponseTime to statslib, added: MediaWiki-Platform-Team; removed MediaWiki-Platform-Team (Radar).
Jan 15 2024, 12:07 PM · MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), MediaWiki-Platform-Team, Patch-For-Review, SRE Observability (FY2023/2024-Q3), Observability-Metrics

Jan 9 2024

DAlangi_WMF closed T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata as Resolved.
Jan 9 2024, 9:53 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF closed T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata , a subtask of T299369: Consider removing global $userLang from onPageContentLanguage hook, as Resolved.
Jan 9 2024, 9:52 AM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki CodeJam Dec 2023, MediaWiki-Platform-Team, Maintenance-Worktype, Content-Transform-Team-WIP, Sustainability (Incident Followup), MediaWiki-extensions-WikimediaIncubator, Technical-Debt (Deprecation process), MediaWiki-ContentHandler
DAlangi_WMF moved T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.
Jan 9 2024, 9:48 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF added a comment to T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .

@Krinkle, is this good to be resolved now or should we wait till end of week?

Jan 9 2024, 9:48 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF updated the task description for T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .
Jan 9 2024, 9:48 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering

Jan 8 2024

DAlangi_WMF moved T289543: Remove SiteConfiguration::getConfig (Fetch config via shell command) from Within 2 Qs to Soon on the MediaWiki-Platform-Team board.
Jan 8 2024, 10:48 AM · MW-1.42-release, MediaWiki-Engineering-Group-onboarding, MediaWiki-Platform-Team, Technical-Debt (Deprecation process), MediaWiki-Configuration
DAlangi_WMF claimed T343963: CentralAuthUser::getInstanceByName (and similar) should normalize the user name.
Jan 8 2024, 10:47 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
DAlangi_WMF moved T343963: CentralAuthUser::getInstanceByName (and similar) should normalize the user name from Within 2 Qs to Current Sprint on the MediaWiki-Platform-Team board.
Jan 8 2024, 10:47 AM · MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth
DAlangi_WMF updated the task description for T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc).
Jan 8 2024, 8:56 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF updated the task description for T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc).
Jan 8 2024, 8:56 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF reopened T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc) as "Open".

There is still wgCentralAuthTokenCacheType in CA, needs cleanup as well and removal from wmf-config repo.

Jan 8 2024, 8:38 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF closed T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc) as Resolved.

Deployed the config cleanup patch this morning. This can now be resolved and thanks a lot @Krinkle & @aaron for code reviews, guidance and discussions. <3

Jan 8 2024, 8:31 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF updated the task description for T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc).
Jan 8 2024, 8:28 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff
DAlangi_WMF moved T336004: Recognize 4th cache service interface in MediaWiki (Migrate ConfirmEdit tokens from MainStash to mcrouter-primary-dc) from Soon to Current Sprint on the MediaWiki-Platform-Team board.
Jan 8 2024, 7:53 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, ConfirmEdit (CAPTCHA extension), MediaWiki-libs-BagOStuff

Dec 21 2023

DAlangi_WMF moved T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata from Soon to Current Sprint on the MediaWiki-Platform-Team board.
Dec 21 2023, 2:59 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF moved T352481: Remove 'db-replicated' and ReplicatedBagOStuff from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.
Dec 21 2023, 2:58 PM · MW-1.43-release, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff

Dec 18 2023

DAlangi_WMF added a comment to T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .

@DAlangi_WMF The problematic hook that initiated this task (via the parent task) is onPageContentLanguage() which is called by Title->getPageViewLanguage(), but not directly. The hook call resides in ContentHandler::getPageViewLanguage() -> ContentHandler->getPageViewLanguage().

The reason Wikibase is out of scope, is that it implements a custom method called getPageViewLanguage in a subclass of ContentHandler, and shares no code with the base class in core. After we deprecate and remove this, the Wikibase continues to work on its own.

CommonsMetadata, however, does call into the affected core code. It makes the same kind of mistake as the other extensions we patched in this task, namely it deals with a ParserOutput, but instead of asking the ParserOutput object what the language of the HTML is, it tries to "guess" by invoking global state of ContentHandler::getPageViewLanguage.

Dec 18 2023, 1:27 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF updated the task description for T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .
Dec 18 2023, 1:26 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF added a comment to T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .

@Krinkle, what would be a good next logical step here? Maybe double check callers again (just in case), then if none found, soft and hard deprecate Title::getPageViewLanguage()?

Dec 18 2023, 12:00 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF updated the task description for T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .
Dec 18 2023, 11:59 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering
DAlangi_WMF added a comment to T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .

As discovered above, Wikibase (and CommonsMetadata too) actually use the ContentHandler::getPageViewLanguage rather than Title::getPageViewLanguage. I'm not sure if it was intended to be in scope for this task? It's similarly bad and indirectly reads from global state in the same way.

Dec 18 2023, 11:59 AM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering

Dec 14 2023

DAlangi_WMF updated the task description for T350806: Phase out Title::getPageViewLanguage in favour of ParserOutput metadata .
Dec 14 2023, 3:08 PM · MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), MediaWiki-Platform-Team, StructuredDiscussions, Growth-Team, wmde-wikidata-tech, Structured-Data-Backlog, MediaWiki-extensions-Scribunto, DiscussionTools, CommonsMetadata, Structured Data Engineering, MediaWiki-extensions-WikibaseRepository, Wikidata, Data-Engineering

Dec 12 2023

DAlangi_WMF updated the task description for T352481: Remove 'db-replicated' and ReplicatedBagOStuff.
Dec 12 2023, 8:51 AM · MW-1.43-release, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff

Dec 11 2023

DAlangi_WMF added a comment to T347366: Follow-up on wmf-config "ClusterConfig::isTest" method.

Per https://wikitech.wikimedia.org/wiki/Backport_windows/Deployers#Deploying_changes, I had to refresh my knowledge (again).

Dec 11 2023, 2:35 PM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team
DAlangi_WMF closed T347366: Follow-up on wmf-config "ClusterConfig::isTest" method as Resolved.
Dec 11 2023, 2:28 PM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team
DAlangi_WMF added a comment to T347366: Follow-up on wmf-config "ClusterConfig::isTest" method.

@Krinkle, hostnames seem to be different from how they were before (mwdebug1001, mwdebug1002 etc). Now we just have deploy1001, deploy2002 (the host I used today - in codfw DC).

So since the patch tries to look for "debug" in the hostname (as in mwdebugX00X) and doesn't see it for the "deploy2002" case, $cc->isDebug() returns false.

However, I accessed the k8s REPL shell to test our theory that the patch is doing what it's expected to do. On that environment (hostname like: mw-debug.codfw....), running $cc->isDebug() returns true as expected.

So we may have to improve on the patch a little but to check for more things. Maybe cases where we have "deploy1001" and "deploy2002" (as those are AFAIK are our debug hosts?). Let me know what you think.

Dec 11 2023, 2:28 PM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team
DAlangi_WMF updated the task description for T347366: Follow-up on wmf-config "ClusterConfig::isTest" method.
Dec 11 2023, 2:24 PM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team
DAlangi_WMF edited P54326 Testing plan for T347366.
Dec 11 2023, 9:17 AM
DAlangi_WMF created P54326 Testing plan for T347366.
Dec 11 2023, 9:16 AM
DAlangi_WMF added a comment to T347366: Follow-up on wmf-config "ClusterConfig::isTest" method.

@Krinkle, hostnames seem to be different from how they were before (mwdebug1001, mwdebug1002 etc). Now we just have deploy1001, deploy2002 (the host I used today - in codfw DC).

Dec 11 2023, 8:41 AM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team
DAlangi_WMF updated the task description for T347366: Follow-up on wmf-config "ClusterConfig::isTest" method.
Dec 11 2023, 8:34 AM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team

Dec 8 2023

DAlangi_WMF updated the task description for T352481: Remove 'db-replicated' and ReplicatedBagOStuff.
Dec 8 2023, 4:50 PM · MW-1.43-release, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
DAlangi_WMF updated the task description for T352481: Remove 'db-replicated' and ReplicatedBagOStuff.
Dec 8 2023, 4:46 PM · MW-1.43-release, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
DAlangi_WMF updated the task description for T352481: Remove 'db-replicated' and ReplicatedBagOStuff.
Dec 8 2023, 4:43 PM · MW-1.43-release, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff
DAlangi_WMF updated the task description for T352481: Remove 'db-replicated' and ReplicatedBagOStuff.
Dec 8 2023, 4:43 PM · MW-1.43-release, MediaWiki-Platform-Team, MediaWiki-libs-BagOStuff

Nov 30 2023

DAlangi_WMF closed T347223: Exception: Key contains invalid characters: centralauth:central-login-complete-token:1�À§À¢%2527%2522 as Resolved.

All clear, this can be resolved now. Thanks for the collaboration @Tgr, @Krinkle and @Jdforrester-WMF.

Nov 30 2023, 3:05 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error

Nov 29 2023

DAlangi_WMF updated the badge description for Web Perf Hero.
Nov 29 2023, 3:19 PM
DAlangi_WMF changed the status of T347366: Follow-up on wmf-config "ClusterConfig::isTest" method from Open to In Progress.
Nov 29 2023, 10:34 AM · MediaWiki-Engineering-Group-onboarding, Wikimedia-Site-requests, MediaWiki-Platform-Team

Nov 22 2023

DAlangi_WMF moved T351807: Vector2022 Do not call SkinMustache::getTemplateData twice from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
Nov 22 2023, 3:02 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MediaWiki-Platform-Team, Performance Issue, MediaWiki-Core-Skin-Architecture, Desktop Improvements (Vector 2022), Wikimedia-Performance-recommendation
DAlangi_WMF added a comment to T347223: Exception: Key contains invalid characters: centralauth:central-login-complete-token:1�À§À¢%2527%2522.

This will happen next week with wmf.7; there's no train this week.

Nov 22 2023, 2:36 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
DAlangi_WMF created T351806: TypeError: Argument 1 passed to MediaWiki\Extension\WebAuthn\HTMLForm\WebAuthnDisableForm::authenticate() must be of the type array, string given.
Nov 22 2023, 12:51 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), MediaWiki-extensions-OATHAuth, Wikimedia-production-error
DAlangi_WMF renamed T351805: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMDataUtils::stashObjectInDoc() must be an instance of Wikimedia\Parsoid\DOM\Document, null given from TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMDataUtils::stashObjectInDoc() must be an instance of Wikimedia\Parsoid\DOM\Document, null given, called in /srv/mediawiki/php-1.42.0-wmf.5/vendor/wikimedia/parsoid/src/ to TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMDataUtils::stashObjectInDoc() must be an instance of Wikimedia\Parsoid\DOM\Document, null given.
Nov 22 2023, 12:46 PM · Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
DAlangi_WMF created T351805: TypeError: Argument 1 passed to Wikimedia\Parsoid\Utils\DOMDataUtils::stashObjectInDoc() must be an instance of Wikimedia\Parsoid\DOM\Document, null given.
Nov 22 2023, 12:45 PM · Maintenance-Worktype, Content-Transform-Team-WIP, Parsoid, Wikimedia-production-error
DAlangi_WMF added a comment to T347223: Exception: Key contains invalid characters: centralauth:central-login-complete-token:1�À§À¢%2527%2522.

(update): The last patch on the chain of patches is riding the train this week. At this point, the migration is already complete and we're dropping support for the old key format. No incidents so far and things are working as expected.

Nov 22 2023, 11:17 AM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Patch-For-Review, MediaWiki-Platform-Team, MediaWiki-extensions-CentralAuth, Wikimedia-production-error
DAlangi_WMF moved T346690: mcrouter daemonset on mw-on-k8s from Current Sprint to Blocked/waiting on the MediaWiki-Platform-Team board.
Nov 22 2023, 11:13 AM · MediaWiki-Platform-Team (Radar), Patch-For-Review, serviceops, MW-on-K8s
DAlangi_WMF added a comment to T346690: mcrouter daemonset on mw-on-k8s.

(update): The config change got merged and deployed yesterday. So it's live now. Is there anything else needed from MediaWiki Platform Team side on this ticket?

Nov 22 2023, 11:13 AM · MediaWiki-Platform-Team (Radar), Patch-For-Review, serviceops, MW-on-K8s