Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (194 w, 4 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Tue, Jun 18

DLynch moved T221195: VE mobile default: design A/B test from In progress to Engineering QA on the VisualEditor (Current work) board.

Testing this patch beyond the superficial "it doesn't break the existing behavior" requires that you set the $wgMFDefaultEditor config variable, to one of source, visual, preference, or abtest. The first two are obvious, preference means it should obey your user's desktop preference, and abtest should do a 50/50 split which is persistent for a given user (including anonymous users, until cookies are cleared). Super-deep validation includes making sure that abtest causes eventlogging to include the anonymous_user_token and bucket fields with appropriate values.

Tue, Jun 18, 4:09 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error.

@marcella: I don't think there's a reason to do it and save it -- it's meaningless from a data standpoint, which is why doing this edit in other ways already shows an error; this is just a way to reach that state without the error being shown.

Tue, Jun 18, 4:03 PM · VisualEditor, TemplateData
DLynch added a comment to T225750: Add a useful call-to-action for citation needed templates while reading.

A really simple enhancement along the lines Ed suggests there would be to allow the link to Wikipedia:Citation_needed to have a hover preview like article links do. It seems plausible that the preview summary that appears then would provide enough information for the user to proceed with.

Tue, Jun 18, 2:48 PM · VisualEditor

Thu, Jun 13

DLynch added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

@ppelberg I think your questions are tangentially relevant to this specific ticket -- this one applies to once you're within the editor, and your questions largely apply to users who're still pre-editor and reading the article.

Thu, Jun 13, 5:25 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
DLynch added a comment to T221195: VE mobile default: design A/B test.

One problem: if we store it in user_id, we will have to start purging that field after 90 days, whereas we currently do not. We should instead add an anonymous_user_token field or similar to EditAttemptStep.

How's the purge configured? I don't know anything about the mechanism for it -- is it raw "empty this field after X time", or are there more conditions possible?

Thu, Jun 13, 5:15 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T218942: Random article widget.

@JMinor sorry, I was caught up in the Editing offsite when that comment came in and I missed having the time to work on it.

Thu, Jun 13, 2:52 PM · Wikipedia-iOS-App-Backlog

Wed, Jun 5

DLynch added a comment to T221195: VE mobile default: design A/B test.

Outcome of call: generating a persistent-ish anon userid (cookie, expiring 90 days) and storing it as a negative integer in the user_id schema field would be acceptable for analytics.

Wed, Jun 5, 5:10 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics

Tue, Jun 4

DLynch added a project to T224923: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces: Patch-For-Review.

Bot didn't add the patch: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/514369

Tue, Jun 4, 8:13 PM · VisualEditor-CopyPaste, VisualEditor (Current work), Patch-For-Review
DLynch added a comment to T224923: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces.

Alas, it doesn't. That said... possibly it's a useful bit of cleanup.

Tue, Jun 4, 6:48 PM · VisualEditor-CopyPaste, VisualEditor (Current work), Patch-For-Review

Mon, Jun 3

DLynch created T224923: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces.
Mon, Jun 3, 6:29 PM · VisualEditor-CopyPaste, VisualEditor (Current work), Patch-For-Review

May 23 2019

DLynch moved T217825: Editing timing data incorrect for second load from Engineering QA to Product owner review on the VisualEditor (Current work) board.
May 23 2019, 3:57 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

May 22 2019

Pols12 awarded T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error a Like token.
May 22 2019, 11:18 PM · VisualEditor, TemplateData
DLynch added a comment to T222543: In TemplateData param editor, typing a name equal to alias definitely disable Done button .

@Pols12: It's true that you can do this, but that was already the case before this patch, so "can now" doesn't seem accurate. Separate bug, I'd say. I've filed it as T224137.

May 22 2019, 4:33 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), TemplateData
DLynch created T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error.
May 22 2019, 4:33 PM · VisualEditor, TemplateData

May 21 2019

DLynch added a comment to T221195: VE mobile default: design A/B test.

To confirm and specify... we only set preferredEditor during calls to switch editor (to source, to visual).

May 21 2019, 5:19 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T221195: VE mobile default: design A/B test.

During the planning meeting @matmarex said that we only store the preference after a switch has happened, rather than when the editor is opened.

May 21 2019, 5:15 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), Patch-For-Review, VisualEditor (Current work), Product-Analytics

May 15 2019

DLynch added a comment to T211240: Mobile table editing should default to cell contents.

@Ryasmeen Yeah, the constraints on that space are such that the table-icon gets to take up the smallest amount of space of any of the table-adjacent options. It could become inconsistent with the others -- larger and floating over the other content a bit more, say -- or something like expanding the highlight could happen (so that there's that blue highlight joining the arrows to the table-icon and drawing eyes to it).

May 15 2019, 3:47 PM · Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

May 14 2019

DLynch added a comment to T211240: Mobile table editing should default to cell contents.

@Ryasmeen -- Hard to discover that clicking the box will do something, you mean? Or hard to work out what the options within will do?

May 14 2019, 8:16 PM · Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch moved T223322: Cross-wiki pastes of internal links result in broken links from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
May 14 2019, 7:36 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor (Current work)
DLynch created T223322: Cross-wiki pastes of internal links result in broken links.
May 14 2019, 7:35 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor (Current work)

May 9 2019

DLynch moved T222543: In TemplateData param editor, typing a name equal to alias definitely disable Done button from Code review to QA on the VisualEditor (Current work) board.
May 9 2019, 4:49 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), TemplateData
DLynch moved T220697: Editing timing data incorrect/meaningless when switching editor on mobile from In progress to Code review on the VisualEditor (Current work) board.
May 9 2019, 3:39 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

May 8 2019

DLynch moved T220697: Editing timing data incorrect/meaningless when switching editor on mobile from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
May 8 2019, 4:59 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T222247: "Find" doesn't scroll the viewport.

I can't reproduce it not scrolling while the find panel is open, but the jump to the top when the find panel closes is definitely there.

May 8 2019, 4:55 PM · Verified, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work)
DLynch claimed T222543: In TemplateData param editor, typing a name equal to alias definitely disable Done button .
May 8 2019, 4:11 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), TemplateData

May 2 2019

DLynch added a comment to T221967: Can't reliably gather list of annotation views from a DM offset.

I recall poking around for this in the past, and we've been fairly good at avoiding the model knowing about its views. Which is sensible design, but inconvenient at times like this.

May 2 2019, 4:17 PM · VisualEditor

Apr 24 2019

DLynch moved T221669: Error `Cannot read property 'getScrollContainer' of null` when saving on mobile from Code review to Product owner review on the VisualEditor (Current work) board.
Apr 24 2019, 1:23 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Apr 23 2019

DLynch added a comment to T221716: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active.

Heh. Amusingly (?) I remember explicitly testing that post-link stuff, and completely missing that the context behavior had changed because I was entirely focused on the select-inside aspect..

Apr 23 2019, 10:39 PM · Verified, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-Links, VisualEditor (Current work)
DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

@Ryasmeen Shouldn't be yet, I don't think. I believe it merged after the deploys started last week, and this week's the RelEng offsite so there's no train... so next week, I guess?

Apr 23 2019, 7:48 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
DLynch moved T221669: Error `Cannot read property 'getScrollContainer' of null` when saving on mobile from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Apr 23 2019, 5:00 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch created T221669: Error `Cannot read property 'getScrollContainer' of null` when saving on mobile.
Apr 23 2019, 4:45 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch moved T220513: Non-latin URL fragments don't reliably get scrolled to from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Apr 23 2019, 3:15 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
DLynch edited projects for T220513: Non-latin URL fragments don't reliably get scrolled to, added: VisualEditor (Current work); removed VisualEditor.

Yeah, I filed it here because it seemed to affect MobileFrontend generally, and just happened to be coming up in response to a redirect section-editing triggered.

Apr 23 2019, 3:15 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 19 2019

Ryasmeen awarded T220513: Non-latin URL fragments don't reliably get scrolled to a Like token.
Apr 19 2019, 1:41 AM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 18 2019

DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I said it on the other ticket as well, but I suspect that pages which start with a / are probably far less common than subpages, so it'd be a strange case to optimize for...

Apr 18 2019, 4:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T221028: Parsoid incorrectly parses links to pages starting with a slash '/' in namespaces that can have subpages.

I think the suggested behavior here is far less likely to be what people intended than the subpage behavior. Pages whose names start with a / are unusual, and I suspect people are more likely to be trying to link to a subpage.

Apr 18 2019, 4:45 PM · Parsoid-Read-Views

Apr 17 2019

DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

@Ryasmeen When this makes its way to bn.wikipedia we'll know how much it has helped your specific case. :D

Apr 17 2019, 3:47 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 12 2019

DLynch moved T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Apr 12 2019, 7:28 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch edited projects for T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving, added: VisualEditor (Current work); removed VisualEditor.
Apr 12 2019, 7:25 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

@janboehme I'd speculatively point to this commit but can't claim to have actually tested that.

Apr 12 2019, 4:06 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links

Apr 11 2019

DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I'm using a current checkout of it, so I suppose I have a few months of miscellaneous changes since the 0.10.0 release.

Apr 11 2019, 8:37 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I can't reproduce the bad link generation, though I agree the not-actually-a-redlink is still happening.

Apr 11 2019, 4:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T218942: Random article widget.

In part we speak here of pull request #2990.

Apr 11 2019, 3:33 PM · Wikipedia-iOS-App-Backlog

Apr 10 2019

DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

I think this is partially Toggler.prototype.reveal passing the urlencoded selector into jquery, which predictably throws, because $( '#%E0%A6%B6%E0%A6%BF%E0%A6%B0%E0%A7%8B%E0%A6%A8%E0%A6%BEma' ) is quite invalid.

Apr 10 2019, 5:06 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 9 2019

DLynch added a comment to T129546: Support preserving external links in pasted HTML content.

@Esanders: ...actually, as well as pasting from externally, I was copying external links within that instance on test2, and they were getting stripped. So we might have a separate issue?

Apr 9 2019, 5:20 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor, VisualEditor-CopyPaste
DLynch added a comment to T129546: Support preserving external links in pasted HTML content.

@mingle: It doesn't seem to? I just checked on test2, and cannot paste external links.

Apr 9 2019, 4:54 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor, VisualEditor-CopyPaste
DLynch created T220513: Non-latin URL fragments don't reliably get scrolled to.
Apr 9 2019, 2:38 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

Okay, that's a completely separate issue. Seems to be with MobileFrontend not handling non-latin fragments at all well for the initial pageload. I'll make a different ticket.

Apr 9 2019, 1:34 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Apr 8 2019

DLynch added a comment to T220090: Allow selection of the text in the Visual Editor reference inspector.

Until T208826 is done, this would have some side-effects, as removing the selection from within the text would immediately close the context popup. Once that ticket is done and the patches merged, it'd probably be doable.

Apr 8 2019, 4:09 PM · VisualEditor-EditingTools, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work)

Apr 4 2019

DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

@Ryasmeen -- honestly, the weird part there is that it worked on en.wiki. We have a train stall at the moment, so en.wiki should still be on 1.33.0-wmf.23 which doesn't have the latest patch.

Apr 4 2019, 9:57 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Apr 3 2019

DLynch moved T218163: [betalabs] EditAttemptStep has undeclared properties from Code review to Product owner review on the VisualEditor (Current work) board.
Apr 3 2019, 3:38 PM · Patch-For-Review, Skipped QA, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)

Apr 2 2019

DLynch added a comment to T218163: [betalabs] EditAttemptStep has undeclared properties.

@matmarex: see debug.js in the EventLogging extension for more details, but basically, do this in your console:

Apr 2 2019, 2:44 PM · Patch-For-Review, Skipped QA, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)

Apr 1 2019

DLynch moved T218163: [betalabs] EditAttemptStep has undeclared properties from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Apr 1 2019, 5:06 PM · Patch-For-Review, Skipped QA, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)

Mar 28 2019

DLynch moved T216285: Loss of 'alt' texts when manipulating image presentation form from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mar 28 2019, 4:24 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), VisualEditor (Current work), VisualEditor-DataModel
DLynch claimed T216285: Loss of 'alt' texts when manipulating image presentation form.
Mar 28 2019, 4:18 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), VisualEditor (Current work), VisualEditor-DataModel
DLynch moved T202148: Instrument editing pipeline to be able to figure out which common editing features are used from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Mar 28 2019, 3:30 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Mar 27 2019

DLynch added a comment to T218939: Deploy mobile section editing to the next set of wikis (listed in the description).

Ugh, reading things before responding to them. Terrible.

Mar 27 2019, 9:54 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Section Editing
DLynch added a comment to T219420: Update page dynamically after save on mobile.

MobileFrontend.hooks.php has onOutputPageBeforeHTML which does a relatively simple set of things to the content.

Mar 27 2019, 5:52 PM · MobileFrontend, Performance, VisualEditor, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T218939: Deploy mobile section editing to the next set of wikis (listed in the description).

Sorry, I missed seeing this question.

Mar 27 2019, 3:46 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Section Editing
DLynch added a comment to T218163: [betalabs] EditAttemptStep has undeclared properties.

Looking at it... I think we've just always been pouring all of these in, and letting the schema accept the ones it knows about. I believe that it just discards the unknown properties, rather than the entire event in those cases, right?

Mar 27 2019, 3:28 PM · Patch-For-Review, Skipped QA, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), VisualEditor (Current work)
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

A provision does seem to mostly work now... or didn't abort early, at least. Eventgate did throw out a bunch of errors when trying to build its node-rdkafka dependency, which can be seen in P8291 if you're curious.

Mar 27 2019, 2:18 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch created P8291 Vagrant eventgate node-rdkafka dependency error.
Mar 27 2019, 2:17 PM

Mar 19 2019

DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

Okay, yeah. Patch made it so that we do var fragment = this.getSectionFragmentFromPage(); but that just interrogates the current markup of the page pre-edit. This explains changing the section-name breaking things, since after the page-reload it'll be a different id to look for.

Mar 19 2019, 3:12 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mar 18 2019

Deskana awarded T218588: Security Issue Access Request for DLynch a Like token.
Mar 18 2019, 4:37 PM · Security-Team, Security
DLynch added a comment to T218588: Security Issue Access Request for DLynch.

Yup, I have it.

Mar 18 2019, 3:42 PM · Security-Team, Security
DLynch created T218588: Security Issue Access Request for DLynch.
Mar 18 2019, 3:36 PM · Security-Team, Security
DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

I note that @Ryasmeen changed the title of the section. Perhaps we're generating an outdated section-hash as a result rather than one based on the new hash for the new title? The video didn't show the URL, so I can't be sure.

Mar 18 2019, 3:26 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mar 15 2019

DLynch added a comment to T218275: Vagrant restbase can't launch: statsd.childClient is not a function.

I'll confirm that some forced-updating seems to have fixed this. Thanks!

Mar 15 2019, 6:57 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner, RESTBase, MediaWiki-Vagrant
DLynch created T218386: Invalid peer dependencies between eslint and plugins.
Mar 15 2019, 6:57 AM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), Citoid

Mar 14 2019

DLynch added a project to T218275: Vagrant restbase can't launch: statsd.childClient is not a function: service-runner.
Mar 14 2019, 2:08 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner, RESTBase, MediaWiki-Vagrant
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

Let's see... doing exactly-what-the-error-message-says and adding the npm::node_version: 10 to hieradata/common.yaml gets through with no errors after only a few runs of provision.

Mar 14 2019, 2:07 AM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch created T218275: Vagrant restbase can't launch: statsd.childClient is not a function.
Mar 14 2019, 2:06 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner, RESTBase, MediaWiki-Vagrant
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

The visualeditor role requires the restbase role which requires eventbus.

Mar 14 2019, 12:41 AM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant

Mar 13 2019

DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

Okay, I did a full re-initialization of vagrant, and this error didn't come up until I did role enable visualeditor. So one of the dependencies there is, I guess, not configured correctly?

Mar 13 2019, 9:48 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch merged T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor into T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.
Mar 13 2019, 6:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch merged task T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor into T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.
Mar 13 2019, 6:00 PM · VisualEditor (Current work), MobileFrontend, VisualEditor-MediaWiki-Mobile
DLynch updated subscribers of T218238: Vagrant initial provision fails on NodeJS version mismatch.
Mar 13 2019, 5:55 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

A side-effect of some sort from rMWVAbb776a65b3e6dcd7a077add48fd3f1870dba333e, I assume.

Mar 13 2019, 5:55 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch created T218238: Vagrant initial provision fails on NodeJS version mismatch.
Mar 13 2019, 5:49 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant

Mar 12 2019

DLynch added a comment to T217825: Editing timing data incorrect for second load.

Isn't the 24ms just it being a really quick load because ResourceLoader has already loaded everything that comes from the mw.loader.using( 'ext.visualEditor.targetLoader' ) call, so it's just legitimately much faster than the 2565ms the first time?

Mar 12 2019, 3:46 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

@elukey No, nothing to fix it. Though it had, looking at it just now, switched into wildly spamming this into the log instead:

Mar 12 2019, 2:26 PM · Core Platform Team Backlog (Watching / External), Services (watching), Analytics, MediaWiki-Vagrant

Mar 7 2019

ppelberg awarded T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE a 100 token.
Mar 7 2019, 11:38 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch moved T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE from Code review to QA on the VisualEditor (Current work) board.
Mar 7 2019, 9:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch added a comment to T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.

That patch handles this ticket's case. We should probably go through all the changes in that patch and make sure that switching them to deep-extend won't cause any issues.

Mar 7 2019, 6:16 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch updated subscribers of T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.

Seems to be the result of a8be7d15e94a8e by @Niedzielski, which changed how constructors initialize events. It passes event handlers into constructors, and does a non-deep merge of existing options with util.extend. This breaks if the existing options have any event handlers already.

Mar 7 2019, 6:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch claimed T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.
Mar 7 2019, 5:58 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch added a comment to T217825: Editing timing data incorrect for second load.

Specifically the timing.ve.mobile.performance bits?

Mar 7 2019, 4:40 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mar 6 2019

DLynch added a comment to T217783: Lose edits if idle on page.

Specifically: there's no autosave in wikitext mode, because that's not in the VE codebase -- there's no NWE on mobile currently. As far as I know we should have autosave working in visual mode, so it should recover from this case. It's possible that there's some disconnect in the recovery process, though, I haven't tested it.

Mar 6 2019, 5:52 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch added a comment to T217783: Lose edits if idle on page.

I don't think this is section-editing specific? This is just the page getting kicked out of memory, and us not having autosave working on mobile (I think).

Mar 6 2019, 5:43 PM · VisualEditor-MediaWiki-Mobile, VisualEditor

Mar 4 2019

DLynch updated subscribers of T212340: VisualEditor silently changes <references responsive="1" /> to <references responsive="" />.

This is because we don't actually try to preserve the value of the attribute, just its meaning. More potentially-confusing is that we discard the attribute entirely if it's the same as the wiki's default, so if the default changes lots of edits will suddenly be dirtied... and then toggle away from it if the default switches back again.

Mar 4 2019, 6:04 PM · Verified, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), VisualEditor (Current work)

Feb 28 2019

DLynch claimed T212253: Start oversampling all mobile visual editor EditAttemptStep events.
Feb 28 2019, 6:00 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, VisualEditor (Current work), Product-Analytics

Feb 27 2019

DLynch added a comment to T212253: Start oversampling all mobile visual editor EditAttemptStep events.

From a call today: Neil would prefer mobile-only oversampling. I'll work up a patch for that.

Feb 27 2019, 6:25 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, VisualEditor (Current work), Product-Analytics
DLynch merged T217257: Impossible to make a link from text containing non-breaking spaces into T217189: VisualEditor cannot set link when link label contains HTML entity.
Feb 27 2019, 5:28 PM · VisualEditor
DLynch merged task T217257: Impossible to make a link from text containing non-breaking spaces into T217189: VisualEditor cannot set link when link label contains HTML entity.
Feb 27 2019, 5:28 PM · VisualEditor

Feb 26 2019

DLynch updated subscribers of T212253: Start oversampling all mobile visual editor EditAttemptStep events.

Only mobile? I've taken a look at this, and @Catrope had hooked up mobile-and-desktop both to mw.config.get( 'wgWMESchemaEditAttemptStepOversample' ). If we want to only oversample mobile events, I think we'll need to tweak that.

Feb 26 2019, 6:02 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, VisualEditor (Current work), Product-Analytics

Feb 21 2019

DLynch added a comment to T213528: Adding a category to a page without any categories doesn't show up until saving.

The other side effect of this bug was that removing all non-hidden categories from the page would leave an empty categories box, when it should have been hidden.

Feb 21 2019, 5:42 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch moved T213528: Adding a category to a page without any categories doesn't show up until saving from In progress to Code review on the VisualEditor (Current work) board.
Feb 21 2019, 5:41 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch moved T213528: Adding a category to a page without any categories doesn't show up until saving from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Feb 21 2019, 5:37 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T213528: Adding a category to a page without any categories doesn't show up until saving.
Feb 21 2019, 5:37 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch moved T213528: Adding a category to a page without any categories doesn't show up until saving from Q4 to Up next on the VisualEditor board.
Feb 21 2019, 4:33 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki