Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (228 w, 5 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Mon, Feb 17

DLynch awarded Blog Post: Parsoid in PHP, or There and Back Again a Cup of Joe token.
Mon, Feb 17, 10:38 PM · Parsoid

Thu, Feb 13

DLynch added a comment to T242562: Develop a technical approach for editing a specific comment.

There's questions regarding whether we should include any sort of "this comment was edited" notice on an edited comment. Meeting discussion leans towards "no", in part because there's no good way to link to the revision history showing the change without making a second edit to add that link in.

Thu, Feb 13, 6:44 PM · Editing-team (Q3 2019-2020 Kanban Board), OWC2020

Wed, Feb 12

DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

@Mayakp.wiki I've made the very small required change to the schema here: https://meta.wikimedia.org/w/index.php?title=Schema:EditAttemptStep&type=revision&diff=19802113&oldid=19486181

Wed, Feb 12, 4:15 PM · Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor
DLynch added a comment to T240259: Implement `unload handlers` for compose.

Yes.

Wed, Feb 12, 12:11 AM · User-Ryasmeen, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.11; 2019-12-17)

Tue, Feb 11

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

I did some research into hiding tags: it hides the tag entirely if the associated message is present-but-disabled. (If there's no message at all, it just shows whatever the tag name is.) Messages are disabled by setting them to literally the empty-string or to -.

Tue, Feb 11, 4:46 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools
DLynch added a comment to T240259: Implement `unload handlers` for compose.

My theory is that @Ryasmeen has NWE enabled, and so "edit source" isn't technically a navigation event (because it's just replacing the contents of the current page). We need to special case detecting and canceling this somehow.

Tue, Feb 11, 4:32 PM · User-Ryasmeen, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.11; 2019-12-17)

Mon, Feb 10

DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

But Maya and I have spoken about it, and we know what needs to happen.

Mon, Feb 10, 10:37 PM · Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor
DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

@DLynch talking to @ppelberg, can you confirm this ticket doesn't need to be resolved in order to implement instrumentation for 1.0 T243364

Mon, Feb 10, 10:36 PM · Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor
marcella awarded T242184: Create a change tag for edits made using DiscussionTools a Cup of Joe token.
Mon, Feb 10, 2:33 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Fri, Feb 7

DLynch merged T244598: [Regression] Cannot reply to any comment on a Talk page, showing error "Invalid response from server." into T244586: Restbase routing down on beta, 2020-02-07.
Fri, Feb 7, 7:50 PM · User-Ryasmeen, Traffic, Operations, Beta-Cluster-Infrastructure, RESTBase
DLynch merged task T244598: [Regression] Cannot reply to any comment on a Talk page, showing error "Invalid response from server." into T244586: Restbase routing down on beta, 2020-02-07.
Fri, Feb 7, 7:50 PM · OWC2020, DiscussionTools
DLynch created T244592: No error message shown when restbase/parsoid is down.
Fri, Feb 7, 5:58 PM · VisualEditor
DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

@Esanders: I'm actually not sure what's going on there with 1. For me, locally, exact matches are working just fine. See:

Fri, Feb 7, 2:54 AM · OWC2020 (OWC2020 Replying 2.0), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Thu, Feb 6

DLynch updated subscribers of T232601: Provide a mechanism for in-surface autocomplete.

This is pretty tight, so we should some a top margin (0.5em?) as seen in Phab:

Mm, I do agree. I've updated the patch with a top margin 0.5ex, which looked better to me than 0.5em:

Thu, Feb 6, 5:05 PM · OWC2020 (OWC2020 Replying 2.0), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Wed, Feb 5

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

Why is it that a reply made using DiscussionTools in visual mode would receive three tags instead of two?

My initial logic was just that it'd be simpler for search, rather than anyone interested in the data having to know up front what all the possible modes were. That said, I can certainly remove the pure discussiontools tag, and you can remember when searching what the options are.

Wed, Feb 5, 6:10 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Fri, Jan 24

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

How – if at all – should the text input mode (e.g. source vs. rich text) be tracked?

Fri, Jan 24, 4:39 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Thu, Jan 23

DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

EditAttemptStep needs to be tweaked a little so it can apply to DiscussionTools being used to edit a page. I think what's needed is:

Thu, Jan 23, 6:51 AM · Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor

Wed, Jan 22

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

I'm working on a patch for this which will apply placeholder tags for likely edit types. The bulk of the actual technical work is adjusting the VisualEditorEdit API to allow the tags to be customized, anyway.

Wed, Jan 22, 6:50 PM · Verified, MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Tue, Jan 21

DLynch placed T229887: Audit notifications received by new users upon opening the editor up for grabs.

This is more work to audit than I have time to handle. The difficulty is mostly that any random wiki could have a gadget / extension which adds a message on arbitrary criteria... and even for just the core / extension code, there's enough different ways to trigger something like this that it's a real pain to search for it happening.

Tue, Jan 21, 5:25 PM · VisualEditor, Editing-team, Growth-Team

Jan 9 2020

DLynch added a comment to T230683: New syntax for multiline list items / talk page comments.

I do find @ssastry's heredoc argument on the grounds of "it's already being implemented for similar purposes elsewhere" to be quite compelling. I also agree on the useful clarity of it being a fairly generic thing that can be used to bypass wikitext newline behavior.

Jan 9 2020, 10:51 PM · OWC2020, MediaWiki-Parser
DLynch added a comment to T211240: Mobile table editing should default to cell contents.

That's the experience with a margin added so that the table is pushed in by a margin the size of the side context items. I can put it up on the prototype if you'd like to try it personally.

Jan 9 2020, 6:39 AM · Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, Patch-For-Review, VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor-MediaWiki-Mobile

Jan 7 2020

DLynch added a comment to T231847: Add ⓧ buttons in the form input fields to make text deletion easier.

This is a question which is lightly holding up this ticket in code review: https://phabricator.wikimedia.org/T229839

Jan 7 2020, 5:56 PM · VisualEditor

Dec 20 2019

DLynch added a comment to T239861: Bug: Not able to post comment on beta.

It's happening to other edits as well, so restbase is just down in general on beta, not in a talk-specific manner. E.g. https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/html/Cats/407373?redirect=false&stash=true

Dec 20 2019, 6:04 PM · User-Ryasmeen, Core Platform Team, VisualEditor (Current work), DiscussionTools, Editing-team, OWC2020

Dec 16 2019

DLynch added a comment to T240697: Measure % of edits coming from users without JS.

Server-side PHP sends EditAttemptStep events, right? And those are limited to action='init' & action='saveSuccess'?

@mpopov Yeah, that's my logic. It does also do saveAttempt and saveFailure server-side. Perhaps checking for saveAttempt would be most inclusive, since that'll always fire.

Dec 16 2019, 10:24 PM · VisualEditor, Product-Analytics
DLynch added a comment to T240875: Can't start a vagrant instance on a new buster-10.0 instance due to missing apparmor.

Oh, and on the debian-10.0-buster (deprecated 2019-12-15) image, apparmor is installed as apparmor/stable,now 2.13.2-10 amd64 [installed,automatic]. Automatic implies it was pulled in as a dependency, I think, so perhaps some part of debian (lxc?) stopped explicitly depending on apparmor in the last few weeks?

Dec 16 2019, 5:20 PM · cloud-services-team (Kanban), MediaWiki-Vagrant, Cloud-VPS
DLynch added a comment to T240875: Can't start a vagrant instance on a new buster-10.0 instance due to missing apparmor.

I also verified that a working vagrant VPS set up on the debian-10.0-buster (deprecated 2019-12-15) image does have apparmor installed. I can't say whether that's the image or some puppet change to the role::labs::mediawiki_vagrant role that has occurred in the last few weeks.

Dec 16 2019, 5:12 PM · cloud-services-team (Kanban), MediaWiki-Vagrant, Cloud-VPS

Dec 14 2019

DLynch added a comment to T240697: Measure % of edits coming from users without JS.

Define “edits done” — do you want all visits to the edit page, or can we restrict it to successfully completed edits? If the latter, I think we could use analysis of current EditAttemptStep data to compare sessions that are just made of ‘init’ and ‘saveSuccess’ to ones that also include ‘ready’/‘firstChange’.

Dec 14 2019, 1:04 AM · VisualEditor, Product-Analytics

Dec 13 2019

DLynch moved T240729: [Regression] "Cancel" button on Reply is not working on Beta cluster from Code review to QA on the VisualEditor (Current work) board.
Dec 13 2019, 11:07 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), DiscussionTools, OWC2020
DLynch moved T240729: [Regression] "Cancel" button on Reply is not working on Beta cluster from Incoming to Code review on the VisualEditor (Current work) board.
Dec 13 2019, 10:51 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), DiscussionTools, OWC2020
DLynch claimed T240729: [Regression] "Cancel" button on Reply is not working on Beta cluster.
Dec 13 2019, 10:51 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), VisualEditor (Current work), DiscussionTools, OWC2020

Dec 12 2019

DLynch added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

Is it just that list item pr everything else on the page beyond the list item? Reading the title and description, I got the impression it is just the table in that list item and hence is limited.

Dec 12 2019, 7:35 PM · Parsoid-Edit-Support, OWC2020, VisualEditor
DLynch added a comment to T240280: Parsoid removes all newlines from the page when editing a table inside a list item `:{|`.

I'm not convinced this should be invalid -- it's a pretty bad page-corruption issue if bad wikitext goes through Parsoid.

Dec 12 2019, 6:21 PM · Parsoid-Edit-Support, OWC2020, VisualEditor

Dec 10 2019

DLynch added a comment to T239248: [EPIC] Divide VectorTemplate into components.

Ah, hold on, I think you already fixed that in https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/555626/ and I was just using an unfortunately timed checkout on the VPS. So ignore me. :D

Dec 10 2019, 6:23 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Technical-Debt, Desktop Improvements, Vector
DLynch added a comment to T239248: [EPIC] Divide VectorTemplate into components.

https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Vector/+/554284/ seems to have caused some issues if you're using non-default languages. On a fairly stock mediawiki install, if I use the header selector to change my language to en-GB, I see this:

Dec 10 2019, 6:18 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Epic, Technical-Debt, Desktop Improvements, Vector
DLynch added a comment to T236548: "visualeditor" Cloud VPS project jessie deprecation.

Maybe a good first step would be to make a new server and see there's any problems getting vagrant going on it, then we can move to migrating needed test data to it if that works out?

Dec 10 2019, 5:10 PM · Cloud-VPS (Debian Jessie Deprecation)

Dec 5 2019

DLynch created T239933: mw-vagrant eventbus role doesn't install config file.
Dec 5 2019, 5:03 PM · MediaWiki-Vagrant
DLynch added a comment to T234365: mw-vagrant eventbus role causing 'device full' due to service start failure loop.

I think this is ultimately a duplicate of T158617?

Dec 5 2019, 4:59 PM · MediaWiki-Vagrant
DLynch added a comment to T158617: npm install fails for changeprop service in MW-Vagrant (cp rdkafka: permission denied).

This is definitely still an issue, and I just had to work around it while setting up a cloud VPS.

Dec 5 2019, 5:48 AM · Core Platform Team Legacy (Watching / External), Services (watching), MediaWiki-Vagrant

Dec 2 2019

DLynch added a comment to T239328: [SPIKE] What talk-related events are being tracked?.

I've raised this question before and not seen an answer: what edit_count data is being used to assign people to the junior/senior buckets? Is it assigned at time-of-posting or time-of-analysis? Are we counting all edits or just article-namespace edits towards this? This could make a notable difference if we, say, made it much easier for people to post a lot of comments quickly...

Dec 2 2019, 10:28 PM · Editing-team, OWC2020

Nov 22 2019

DLynch added a comment to T211240: Mobile table editing should default to cell contents.

Jess and I were talking about this and we agreed to try out adding a slight margin to tables on mobile only when they have focus, to see how that affects the experience.

Nov 22 2019, 4:57 PM · Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, Patch-For-Review, VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor-MediaWiki-Mobile

Nov 14 2019

DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

That last patch is a not-to-be-merged-but-useful-to-exist-for-testing one. The actual username completion will exist over in DiscussionTools, but that's not actually in a state where it's easy to use yet.

Nov 14 2019, 6:16 PM · OWC2020 (OWC2020 Replying 2.0), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Nov 7 2019

DLynch added a comment to T235356: Fatal from ApiGraph->getGraphSpec: "Call to a member function getExtensionData() on boolean".

I don't actually know anything about the Graph extension, but a quick glance at the code suggests that it's trying to load a graph-spec from a page that doesn't exist, and doesn't have a sensible check for that failure case.

Nov 7 2019, 9:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Editing-team, MediaWiki-extensions-Graph, Wikimedia-production-error

Nov 6 2019

DLynch added a comment to T234046: Create OWC metric definitions.

I'm interested in the ORES scores over reversion-rates as well, mostly because it lets us avoid all sorts of confusion about what counts/should-count as a revert, and side-effect like the mentioned "what if we overwhelm the people who'd be doing the reversions with a flood of content".

Nov 6 2019, 7:01 PM · Product-Analytics, VisualEditor (Current work), OWC2020
DLynch added a comment to T236548: "visualeditor" Cloud VPS project jessie deprecation.

Will the prototype servers really require too much work to migrate? They're running mediawiki-vagrant, as I recall, so as long as it's in a currently viable state for installs we should be able to spin a new one up from scratch.

Nov 6 2019, 6:16 PM · Cloud-VPS (Debian Jessie Deprecation)
DLynch added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

On the RESTBase side, the most numerous recorded cases were the ones where VE does not provide an If-Match header during transforms - there were 1122 such occurrences in the last 7 days, so I think we need to prioritise finding out how and why that happens.

Nov 6 2019, 4:33 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase

Nov 5 2019

DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

Thanks for looking into it! I'll just mention that, the schema can be changed to make the fields optional, which will then give you proper metrics showing how often this condition occurs.

Nov 5 2019, 10:20 PM · VisualEditor, Growth-Team, Editing-team
DLynch added a comment to T229074: Preparing VisualEditor for Parsoid-PHP switch.

That patch implements the strategy I described. Adding $wgVisualEditorRestbaseParsoidVariant = 'php'; to the config file triggers the appropriate header-sending.

Nov 5 2019, 4:48 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, Editing QA, Patch-For-Review, VisualEditor (Current work), Core Platform Team, Parsoid-PHP
DLynch added a comment to T229074: Preparing VisualEditor for Parsoid-PHP switch.

I'm thinking that we can't just push it everywhere, because that'd break any non-foundation user of VE who hasn't configured restbase to know about that variant. (E.g. my updated-yesterday vagrant install falls over and breaks as soon as I start sending that header.)

Nov 5 2019, 4:30 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, Editing QA, Patch-For-Review, VisualEditor (Current work), Core Platform Team, Parsoid-PHP

Nov 4 2019

DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

It's not just loaded_timing, there's also ready_timing.

Nov 4 2019, 5:47 PM · VisualEditor, Growth-Team, Editing-team

Oct 31 2019

DLynch added a comment to T236975: Vagrant eventbus role can't be installed because of node_version.

For now I went with making a puppet/hieradata/local.yaml file and including npm::node_version: 10 within it.

Oct 31 2019, 4:05 PM · MediaWiki-Vagrant
DLynch added a comment to T236975: Vagrant eventbus role can't be installed because of node_version.

This is probably a regression of T218238, which indicated that it was going to be making eventgate optional for cases which don't strictly require it.

Oct 31 2019, 3:57 AM · MediaWiki-Vagrant
DLynch created T236975: Vagrant eventbus role can't be installed because of node_version.
Oct 31 2019, 3:55 AM · MediaWiki-Vagrant

Oct 29 2019

DLynch added a comment to T234907: RFC: Where to implement Desktop Improvements project.

I want to second @Jdrewniak's point -- if we can refactor skins first so that skins really are a lighter presentation layer on top of a sensible base page structure, then whatever we choose for the rest of this doesn't matter so much. If we're not going to do that, there's a minefield ahead.

Oct 29 2019, 12:28 AM · TechCom-RFC (TechCom-Approved), Readers-Web-Backlog (Kanbanana-2019-20-Q3), Desktop Improvements

Oct 15 2019

DLynch added a comment to T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

Sorry, just to be explicit:

When does the 'dialog-review' and 'dialog-preview' get fired ?

When you click the "review your changes" or "show preview" buttons that are at the bottom of the save dialog.

Oct 15 2019, 5:40 PM · Product-Analytics (Kanban), VisualEditor (Current work)
DLynch updated subscribers of T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

During testing I also found a bunch of other actions being stored under the mwSave feature. We can ignore them if required as the number of times these actions appear is very very small..but it would help to know if its a bug:
review-initial-schnark
checkbox-has
checkbox-intersects
checkbox-unique
checkbox-wpReviewEdit

Those are all probably interactions with other code. The logging we do just does logging based on the ids that are present in the code. If other extensions / gadgets / userscripts insert things, they'll get included in the logging. wpReviewEdit is from the FlaggedRevs extension, for instance.

Oct 15 2019, 5:38 PM · Product-Analytics (Kanban), VisualEditor (Current work)
DLynch added a comment to T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

@DLynch - In QA, @Mayakp.wiki noticed the following mwSave feature actions were being recorded:

These are all from the last patch to that ticket, yes.

Oct 15 2019, 5:30 PM · Product-Analytics (Kanban), VisualEditor (Current work)

Oct 8 2019

DLynch added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.

Safari 13 has added Visual Viewport support, which can plausibly help with this.

Oct 8 2019, 4:29 PM · Readers-Web-Backlog (Tracking), MinervaNeue, iOS-app-Bugs, Mobile

Oct 3 2019

DLynch added a comment to T232790: Verify editing flow events are firing properly.

That said, the "Yes, but it's getting fired twice" shouldn't be firing twice. But I can't reproduce that myself, so I might need more information.

Oct 3 2019, 5:38 PM · User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08)
DLynch added a comment to T232790: Verify editing flow events are firing properly.

Everything Rummana saw looks correct, it's just a confusion about what the event name is. For the VisualEditorFeatureUse events it's two-part, there's a feature and action component, with the name being written here as [feature].[action].

Oct 3 2019, 5:30 PM · User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08)
DLynch updated the task description for T232790: Verify editing flow events are firing properly.
Oct 3 2019, 5:25 PM · User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08)

Sep 25 2019

DLynch added a comment to T232790: Verify editing flow events are firing properly.

It should all be mwSave as the feature and then the dialog-whatever as the action.

Sep 25 2019, 1:33 AM · User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08)

Sep 24 2019

DLynch added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

There must be some Etag manipulation going on on the client side (either in the PHP side of JS of the VE code) that alters it in some instances or removes it in other, given that we have evidence both cases mentioned in the description happen regularly (albeit with different frequencies).

Sep 24 2019, 3:21 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase

Sep 23 2019

DLynch added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

For what it's worth, I can't find anything in VE which ever alters an ETag. I.e. the weird suffix case should just be us passing whatever Restbase gave us when we loaded the article back to it.

Sep 23 2019, 4:41 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase

Sep 20 2019

DLynch moved T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving from Code review to QA on the VisualEditor (Current work) board.
Sep 20 2019, 3:21 PM · User-Ryasmeen, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor-MediaWiki-Links

Sep 18 2019

DLynch moved T229079: Instrument each step of mobile VE edit flow from Code review to Product owner review on the VisualEditor (Current work) board.

T232790 is basically the QA process, after all.

Sep 18 2019, 4:02 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch updated subscribers of T233174: [Regression pre-wmf.24] Cannot add a gallery, and cannot make any edit afterwards.

This one was a pain to track, but it's a caught-and-swallowed exception inside TreeModifier. (Swallowed because it occurs in a jQuery promise, where exceptions are discarded.)

Sep 18 2019, 12:55 AM · User-Ryasmeen, VisualEditor-ContentEditable, Verified, VisualEditor (Current work)
DLynch updated subscribers of T233170: [Regression pre-wmf.24] Cannot open citation dialog, error in the console "Uncaught TypeError: Cannot read property 'type' of undefined".

Here's the stack trace:

Sep 18 2019, 12:39 AM · User-Ryasmeen, VisualEditor-MediaWiki-References, Verified, VisualEditor (Current work)

Sep 17 2019

DLynch added a comment to T232237: VE mobile default test buckets are unbalanced.

Buckets are all assigned server-side, yes -- I posted a link to where it's done above.

Sep 17 2019, 9:33 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 11 2019

DLynch added a comment to T232237: VE mobile default test buckets are unbalanced.

@ppelberg They're assigned to the buckets server-side. They then log their bucket as the assigned one, regardless of which editor loads.

Sep 11 2019, 7:51 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 10 2019

DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

Okay, current patches implement firstChange in: desktop VisualEditor, desktop WikiEditor, MobileFrontend wikitext and visual.

Sep 10 2019, 2:52 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

We should also write patches for those editors.

Sep 10 2019, 2:02 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

Okay! That cluster of patches implements the firstTransaction step on desktop and mobile. It logs it with the timing as "time since the document was ready".

Sep 10 2019, 12:39 AM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

I have updated the schema for now, with time-since-ready: https://meta.wikimedia.org/w/index.php?title=Schema:EditAttemptStep&diff=19364181&oldid=19273145

Sep 10 2019, 12:07 AM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

@MNeisler - Sorry, I didn't think to ask -- for the timing, would it be more helpful if I stored time-since-initialization or time-since-ready? That'd sort of be whether this event is conceptually grouped with the editor-loading cluster or the saving cluster.

Sep 10 2019, 12:04 AM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile

Sep 9 2019

DLynch added a comment to T231847: Add ⓧ buttons in the form input fields to make text deletion easier.

From the patch where we started discussing this:

Sep 9 2019, 6:00 PM · VisualEditor
DLynch moved T229079: Instrument each step of mobile VE edit flow from Ready for Development to Code review on the VisualEditor (Current work) board.
Sep 9 2019, 3:53 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

When a contributors taps...

“<” in “Save your changes” dialogadded in patch: mwSave.dialog-abort
“<” in “Review your changes” viewadded in patch: mwSave.dialog-review
to "Preview"/"Review" their changesadded in patch: mwSave.dialog-review/preview
"Visual" or "Wikitext" in “Review your changes” viewadded in patch: mwSave.review-switch-source / mwSave.review-switch-visual
the "This is a minor edit" checkbox in the Save dialogadded in patch: mwSave.checkbox-wpMinoredit
the "Watch this page" checkbox in the Save dialogadded in patch: mwSave.checkbox-wpWatchthis
the “>” in v1 of the toolbaralready present in EditAttemptStep as saveIntent
Sep 9 2019, 3:53 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch moved T232347: Mobile Visual Editor on iOS has a suppressed error after saving from In progress to Code review on the VisualEditor (Current work) board.
Sep 9 2019, 3:02 PM · Verified, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch added a project to T232347: Mobile Visual Editor on iOS has a suppressed error after saving: VisualEditor-MediaWiki-Mobile.
Sep 9 2019, 2:51 PM · Verified, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch created T232347: Mobile Visual Editor on iOS has a suppressed error after saving.
Sep 9 2019, 2:51 PM · Verified, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

@Neil_P._Quinn_WMF / @MNeisler : Given that the "starts an edit" part requires a change to the EditAttemptStep schema, could you verify that all I'd need to do is add, say, "firstTransaction" to the action enum, and add a first_transaction_timing integer? No other extra data required?

Sep 9 2019, 2:30 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile

Sep 7 2019

DLynch added a comment to T232237: VE mobile default test buckets are unbalanced.

For the code-side generation of this distribution, this is where it's defined: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontendEditorHooks.php#L48

Sep 7 2019, 8:33 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 3 2019

DLynch moved T229841: Instrument Edit Cards v3 from Code review to Product owner review on the VisualEditor (Current work) board.
Sep 3 2019, 3:53 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch claimed T229841: Instrument Edit Cards v3.
Sep 3 2019, 2:21 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Aug 31 2019

DLynch claimed T228230: Add "✔️" into link modal.
Aug 31 2019, 12:02 AM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor-Edit Cards , Editing Design
DLynch edited projects for T228230: Add "✔️" into link modal, added: VisualEditor (Current work); removed VisualEditor.
Aug 31 2019, 12:01 AM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor-Edit Cards , Editing Design

Aug 30 2019

DLynch updated subscribers of T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown.

@Ryasmeen: for testing, the most likely side effect of this patch would be somehow breaking the ability to use the save shortcut again while the save dialog is open to trigger a save.

Aug 30 2019, 4:07 AM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch moved T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown from Code review to QA on the VisualEditor (Current work) board.
Aug 30 2019, 4:06 AM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T228230: Add "✔️" into link modal.

That patch is the most-limited version of this: it's just on mobile, and it's also just the mediawiki link inspector. If greater scope is desired, I can adjust this.

Aug 30 2019, 1:08 AM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor-Edit Cards , Editing Design
DLynch added a comment to T228230: Add "✔️" into link modal.

Actually, more extensive question: should this be just the link modal, or should this be all inspectors? If we're invoking a consistent visual language, after all...

Aug 30 2019, 1:00 AM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor-Edit Cards , Editing Design
DLynch added a comment to T228230: Add "✔️" into link modal.

On mobile:

Aug 30 2019, 12:59 AM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor-Edit Cards , Editing Design
DLynch added a comment to T228230: Add "✔️" into link modal.

Is this a mobile-only change?

Aug 30 2019, 12:37 AM · VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor-Edit Cards , Editing Design

Aug 29 2019

DLynch added a project to T203151: Consider adding a button to let users edit the whole page in MobileFrontend: Design.
Aug 29 2019, 4:27 PM · Design, MobileFrontend, VisualEditor

Aug 27 2019

DLynch moved T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown from Incoming to Code review on the VisualEditor (Current work) board.
Aug 27 2019, 8:40 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch edited projects for T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown, added: VisualEditor (Current work); removed VisualEditor.
Aug 27 2019, 8:40 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch claimed T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown.

After some research, it's a side-effect of a89c79dc7907fb32707c0fe535230cc04c38cae5 rather than being something tied to the save dialog actions -- intent is that if an accesskey hits the save-button while the save dialog is open, it triggers a save.

Aug 27 2019, 4:01 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Aug 22 2019

DLynch added a comment to T231031: Instrument usage of ISBN barcode scanner.

Educational DVDs can get them too! Though I admit I didn’t bother to look up whether there’s any distinguishing characteristic in the code.

Aug 22 2019, 6:01 PM · Editing-team (Q3 2019-2020 Kanban Board), Citoid
DLynch created T231031: Instrument usage of ISBN barcode scanner.
Aug 22 2019, 5:14 PM · Editing-team (Q3 2019-2020 Kanban Board), Citoid

Aug 21 2019

DLynch claimed T227317: Oversample mobile wikitext EditAttemptStep events on default editor A/B test wikis.
Aug 21 2019, 5:18 PM · User-Ryasmeen, VisualEditor (Current work)

Aug 20 2019

DLynch moved T229744: HTML entities in section headings show on a separate line in mobile visual editor from Code review to QA on the VisualEditor (Current work) board.
Aug 20 2019, 9:42 PM · Verified, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki