Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (288 w, 3 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Thu, Apr 8

DLynch added a comment to T267161: Improvements to wide tables in new Vector.

@alexhollender I don't think there's anything that Editing or general template-behavior has to say about this. From our end we just wind up creating wikitext tables. The Parsing team could change the output generated from wikitext tables, but there's enough complex possible outputs from table markup that I'd be concerned about breaking edge cases or community templates.

Thu, Apr 8, 5:25 PM · Readers-Web-Backlog (Kanbanana-FY-2020-21), Desktop Improvements, Vector
DLynch added a comment to T279149: Topic Subscriptions: Improve user interface element for subscribing and unsubscribing to topics on Talk Pages .

Interestingly, I think that 2 is the most-complex one to implement, because those links are already meddled with by VE so we'll need to be careful to not trip over each other.

Thu, Apr 8, 5:13 PM · Editing-team (FY2020-21 Kanban Board), OWC2020
DLynch added a comment to T279108: Introduce a Front-end Build Step for MediaWiki Skins and Extensions.

Otherwise we get a bunch of dirty diffs.

Unless I'm misunderstanding the goal or your objection, we wouldn't be getting dirty diffs because we'd not be committing the output of the build process.

Thu, Apr 8, 4:56 PM · Vue.js Migration, tech-decision-forum

Wed, Mar 31

DLynch moved T273044: Convert SecurePoll VotePage to use OOUI from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Wed, Mar 31, 9:08 PM · MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T278832: Update Ballot::getQuestionForm documentation to return an \OOUI\FieldsetLayout.

With https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/676086 having been merged, I think we can go one further and say that getQuestionForm can be documented to return a OOUI\FieldsetLayout.

Wed, Mar 31, 7:01 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T270636: Suppress EditAttemptStep events from visual editor reusers like Content Translation.
Wed, Mar 31, 4:43 PM · Editing-team (FY2020-21 Kanban Board), Language-Team, ContentTranslation, Product-Analytics, VisualEditor, VisualEditor-MediaWiki

Tue, Mar 30

DLynch moved T273045: Convert SecurePoll TranslatePage to use OOUI from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.
Tue, Mar 30, 11:09 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Tue, Mar 23

DLynch moved T273045: Convert SecurePoll TranslatePage to use OOUI from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Tue, Mar 23, 8:56 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T273045: Convert SecurePoll TranslatePage to use OOUI from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Tue, Mar 23, 4:19 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch edited projects for T273045: Convert SecurePoll TranslatePage to use OOUI, added: Anti-Harassment (The Letter Song); removed Anti-Harassment.
Tue, Mar 23, 4:19 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T273045: Convert SecurePoll TranslatePage to use OOUI.
Tue, Mar 23, 4:18 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.

This one's not really QA-able until the tally job patch is done.

Tue, Mar 23, 3:18 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Sat, Mar 20

DLynch moved T277216: Add getJSONResult to PluralityTallier and make getHTMLResult use it from In Progress 💪 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.
Sat, Mar 20, 6:00 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T277220: Add getJSONResult to SchulzeTallier and make getHTMLResult use it from In Progress 💪 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.
Sat, Mar 20, 6:00 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T277219: Add getJSONResult to HistorgramRangeTallier and make getHTMLResult use it from In Progress 💪 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.
Sat, Mar 20, 6:00 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch merged T277219: Add getJSONResult to HistorgramRangeTallier and make getHTMLResult use it into T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:59 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch renamed T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it from Add getJSONMethod to ElectionTallier and make getHTMLResult use it to Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:59 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch merged task T277219: Add getJSONResult to HistorgramRangeTallier and make getHTMLResult use it into T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:59 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch merged T277220: Add getJSONResult to SchulzeTallier and make getHTMLResult use it into T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:59 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch merged task T277220: Add getJSONResult to SchulzeTallier and make getHTMLResult use it into T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:59 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch merged T277216: Add getJSONResult to PluralityTallier and make getHTMLResult use it into T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:59 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch merged task T277216: Add getJSONResult to PluralityTallier and make getHTMLResult use it into T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Sat, Mar 20, 5:58 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Sat, Mar 20, 1:01 AM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Thu, Mar 18

DLynch added a comment to T274263: Add button to delete template in the context menu.

For what it's worth, you shouldn't need to do any direct work to add a button. There's already code for having a standardized delete button on context items, it's just restricted to the MobileContext. If you look up ve.ui.MobileContext.static.showDeleteButton you can trace through how its display is triggered.

Thu, Mar 18, 2:56 PM · WMDE-TechWish, WMDE-Templates-FocusArea
DLynch moved T276901: Convert ApprovalBallot to use OOUI from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.
Thu, Mar 18, 1:21 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Tue, Mar 16

DLynch added a comment to T275533: Create user script to prototype IP Info for usability test.

I tried enabling the script, and when hovering over an IP address on RecentChanges I just got this error: Uncaught (in promise) TypeError: Failed to fetch. This turned out to be because my adblocker dislikes ipinfo.io. Once I disabled that temporarily, it worked -- though I note that none of the ipinfo data is actually being used in the RecentChanges popup as far as I can see?

Tue, Mar 16, 4:35 PM · Design, Anti-Harassment (The Letter Song)
DLynch added a comment to T272632: `npm install` fails: eslint dependency is invalid.

I don't think anything is actually needed, since 1231ad4e9e72e3dc4cc2253675e83c993f62a376 should have fixed it. But @Mvolz might think there's more required?

Tue, Mar 16, 2:59 PM · Platform Engineering, Citoid

Mon, Mar 15

DLynch added a comment to T273047: Convert SecurePoll ListPage to use OOUI.

In fact:

Mon, Mar 15, 7:32 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T273047: Convert SecurePoll ListPage to use OOUI.

Because the patch update just now actively changed the layout...

Mon, Mar 15, 6:50 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Mon, Mar 15, 5:50 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch placed T277353: electionadmin group needs to be added to testwiki to restore securepolls testing functionality up for grabs.
Mon, Mar 15, 5:46 PM · Wikimedia-Site-requests, MediaWiki-extensions-SecurePoll
DLynch added a subtask for T271327: Require that a user is in the electionadmin group in order to be an admin for a poll: T277353: electionadmin group needs to be added to testwiki to restore securepolls testing functionality.
Mon, Mar 15, 4:43 PM · MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch removed a subtask for T180762: Editing eligibility requirements throws error "The end date given is before the start date.": T277353: electionadmin group needs to be added to testwiki to restore securepolls testing functionality.
Mon, Mar 15, 4:43 PM · MW-1.36-notes (1.36.0-wmf.34; 2021-03-09), Patch-For-Review, Anti-Harassment (The Letter Song), Platform Engineering, MediaWiki-extensions-SecurePoll
DLynch edited parent tasks for T277353: electionadmin group needs to be added to testwiki to restore securepolls testing functionality, added: T271327: Require that a user is in the electionadmin group in order to be an admin for a poll; removed: T180762: Editing eligibility requirements throws error "The end date given is before the start date.".
Mon, Mar 15, 4:43 PM · Wikimedia-Site-requests, MediaWiki-extensions-SecurePoll
DLynch added a comment to T277353: electionadmin group needs to be added to testwiki to restore securepolls testing functionality.

This was deliberately implemented by T271327.

Mon, Mar 15, 4:42 PM · Wikimedia-Site-requests, MediaWiki-extensions-SecurePoll

Sun, Mar 14

DLynch moved T276763: Convert RadioRangeBallot to use OOUI from Design Review 🔬 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Back to code review until someone approves the patch, I guess.

Sun, Mar 14, 6:27 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 12 2021

DLynch moved T276763: Convert RadioRangeBallot to use OOUI from Code Review 🔍 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.

@Prtksxna bumping this back into design review so you can say whether you're okay with this.

Mar 12 2021, 3:24 AM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 11 2021

DLynch updated the task description for T277224: Check on TallyPage.php for tally results and display them.
Mar 11 2021, 7:53 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T276763: Convert RadioRangeBallot to use OOUI.
Mar 11 2021, 4:12 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T276763: Convert RadioRangeBallot to use OOUI.

That patch is option 3, above. It winds up being really-equivalent to the current design, just with the OOUI radio widgets in the table.

Mar 11 2021, 3:48 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T273047: Convert SecurePoll ListPage to use OOUI from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Mar 11 2021, 5:10 AM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 10 2021

DLynch added a comment to T212016: Create a repository for sharing ad-hoc local development tools.

In the interest of seeing how it works, I wound up using wmf-utils for a recent helper script for some docker work: https://gerrit.wikimedia.org/r/c/wmf-utils/+/670320

Mar 10 2021, 11:00 PM · Developer Productivity
DLynch renamed T276490: Message in block drawer displays incorrectly in storybook from Message in block drawer displays incorrectly in stroybook to Message in block drawer displays incorrectly in storybook.
Mar 10 2021, 5:37 PM · Anti-Harassment, Readers-Web-Backlog (Tracking), MobileFrontend

Mar 9 2021

DLynch added a comment to T275051: Invalid VisualEditorFeatureUse events.

Well, the error did disappear before that, and I can't find any for VisualEditorFeatureUse on that new dashboard, so presumably my conclusion holds up...

Mar 9 2021, 8:45 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch added a comment to T275051: Invalid VisualEditorFeatureUse events.

Checking the logstash search, these errors appear to have stopped as of March 4th -- i.e. as of the last train deploy to group2.

Mar 9 2021, 8:12 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch added a comment to T273043: Update custom column label inputs to use OOUI widgets.

I went with leaving the + sign, mostly because I think it leads to more clarity now that the inputs can wrap lines.

Mar 9 2021, 7:55 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T273043: Update custom column label inputs to use OOUI widgets.

It'll be a 5 minute patch to fix that, so up to you if you'd like the administrative overhead of a new ticket.

Mar 9 2021, 6:36 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 8 2021

DLynch added a comment to T276763: Convert RadioRangeBallot to use OOUI.

I'll go ahead and do the more aggressive switch to getInputOOUI in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/669715/ since I think you'd want to do it here anyways.

Mar 8 2021, 7:22 PM · MW-1.36-notes (1.36.0-wmf.38; 2021-04-06), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T273047: Convert SecurePoll ListPage to use OOUI.
Mar 8 2021, 7:06 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T273043: Update custom column label inputs to use OOUI widgets from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Mar 8 2021, 7:49 AM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 3 2021

DLynch added a comment to T276354: Don't attempt to tally large encrypted elections via the TallyPage.

Meeting output:

  • pick a vote threshold
  • above said threshold show a warning, but still have the button available
Mar 3 2021, 5:21 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Mar 1 2021

DLynch moved T275648: Allow services to be injected into SecurePoll ActionPages from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.

I think this one can skip QA -- it doesn't really have anything specific to test.

Mar 1 2021, 8:38 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Anti-Harassment (The Letter Song), Dependency injection, MediaWiki-extensions-SecurePoll

Feb 26 2021

DLynch claimed T273043: Update custom column label inputs to use OOUI widgets.
Feb 26 2021, 8:45 PM · MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T275648: Allow services to be injected into SecurePoll ActionPages from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

I can do all the other page-ports quite quickly, but I want to get the review on the service done first so I don't wind up having to change and rebase everything if any major changes are requested.

Feb 26 2021, 8:42 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Anti-Harassment (The Letter Song), Dependency injection, MediaWiki-extensions-SecurePoll

Feb 25 2021

DLynch added a comment to T275572: Inappropriate line breaks inserted when editing in the visual mode.

Presumably, the complaint is about this diff?

I think it's more-specifically about this diff -- the other one just shows the undoing of the specific error.

Feb 25 2021, 8:17 PM · VisualEditor

Feb 24 2021

DLynch claimed T275648: Allow services to be injected into SecurePoll ActionPages.
Feb 24 2021, 7:54 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Patch-For-Review, Anti-Harassment (The Letter Song), Dependency injection, MediaWiki-extensions-SecurePoll
DLynch moved T275620: Improve support for non-alphanumeric characters in the interface for downloading User data from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Feb 24 2021, 7:45 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Anti-Harassment (The Letter Song), Data-Portability
DLynch claimed T275620: Improve support for non-alphanumeric characters in the interface for downloading User data.
Feb 24 2021, 7:35 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Anti-Harassment (The Letter Song), Data-Portability
DLynch added a comment to T271884: Investigate ways to allow WMF staff to be added to the voter list for board elections [8H].

You probably already thought about this (sorry) but you could also run a check against the centralauth database and filter out locked accounts (i.e. where gu_locked = 1), which in theory should find every staff account and could be done before an election by someone with access.

Do we lock (WMF) staff accounts when staff leave the foundation, such that this query+check would maybe get us "current staff"... or is that something which we can't work out from the database alone?

Feb 24 2021, 6:07 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T273056: [[MediaWiki:Securepoll-create-user-not-in-electionadmin-group]] should support gender.

Message changes: https://www.mediawiki.org/wiki/Localisation#%E2%80%A6on_user_names_via_GENDER

Feb 24 2021, 5:35 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll, Gender-Support
DLynch added a comment to T273096: Add DiscussionTools a/b test bucket information to events from VisualEditor and WikiEditor..

Megan: in the context of EditAttemptStep does page include edit attempts initiated via section edit links? Schema:EditAttemptStep leads me to think "yes," tho I wanted to be sure.

It's the integration, so yes. (You could distinguish section ones from init_type. But only for source mode, because we still haven't released visual section editing anywhere.)

Feb 24 2021, 2:57 AM · Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, Product-Analytics (Kanban), DiscussionTools, OWC2020

Feb 23 2021

DLynch added a comment to T275051: Invalid VisualEditorFeatureUse events.

I should note that I couldn't actually reproduce triggering a VisualEditorFeatureUse event which didn't have a session id, so this being the cause is largely speculation. Still, absent some really weird case I think this should fix any possible route to such an event being generated.

Feb 23 2021, 11:44 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch added a comment to T272020: Investigate missing dialog close events.

Mobile is the most likely situation for us not getting that final abort if they abandon the tab -- if they leave the browser app-or-tab, it can get pruned for memory conservation without ever getting to run events again. (But we should still get it if they're e.g. reloading the page.)

Feb 23 2021, 11:36 PM · Editing-team (Tracking), Analytics-Data-Quality, VisualEditor, WMDE-TechWish
DLynch added a comment to T272020: Investigate missing dialog close events.

I think we should try to piece together complete sessions from these events, and see what events (if any) happen after the "unpaired" open events.

Feb 23 2021, 9:24 PM · Editing-team (Tracking), Analytics-Data-Quality, VisualEditor, WMDE-TechWish
DLynch added a comment to T272020: Investigate missing dialog close events.

Getting out without a dialog-whatever event requires that the dialog be closed in such a way that the getTeardownProcess method is never called on it.

Feb 23 2021, 9:20 PM · Editing-team (Tracking), Analytics-Data-Quality, VisualEditor, WMDE-TechWish
DLynch claimed T275051: Invalid VisualEditorFeatureUse events.
Feb 23 2021, 9:13 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch added a comment to T275051: Invalid VisualEditorFeatureUse events.

There does seem to be a useful pattern: "integration": "discussiontools" was present on every event I checked. I suspect that this means there's a path to a VisualEditorFeatureUse event firing before the first EditAttemptStep init event, which is normally what would generate the sessionid.

Feb 23 2021, 9:03 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), DiscussionTools, Editing-team (FY2020-21 Kanban Board)
DLynch added a comment to T271884: Investigate ways to allow WMF staff to be added to the voter list for board elections [8H].

If one doesn't exist yet (and I think it doesn't), we could suggest that a user group be made for staff? It looks like the eligibility list is supposed to support "Include users in these groups, regardless of edits or other groups", and so that'd cover the whole thing without encoding any specific business logic. (It looks sort of broken because of hidden fields and cloner at the moment, so I'm kinda guessing about how it's supposed to work.)

Feb 23 2021, 5:21 PM · Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Feb 22 2021

DLynch moved T274253: Split up module specific-JS in SecurePoll from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.
Feb 22 2021, 6:37 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch moved T274253: Split up module specific-JS in SecurePoll from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Feb 22 2021, 5:51 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T274253: Split up module specific-JS in SecurePoll.
Feb 22 2021, 5:17 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T273091: Investigate: Measure how often IP addresses are copied [8H].

Outside of the technical implications, I would also like to run this by Legal to make sure we aren't doing something we are not supposed to do.

Feb 22 2021, 4:12 PM · Anti-Harassment (The Letter Song), IP Info

Feb 19 2021

DLynch added a comment to T273096: Add DiscussionTools a/b test bucket information to events from VisualEditor and WikiEditor..

I would expect there to be far fewer number of non-discussion tool edit attempts in the test group compared to the control group (especially on talk pages) as they are shown the reply tool as default. @DLynch - Any ideas as to why this might be?

Feb 19 2021, 12:56 AM · Editing-team (FY2020-21 Kanban Board), MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), Patch-For-Review, Product-Analytics (Kanban), DiscussionTools, OWC2020

Feb 18 2021

DLynch added a comment to T273091: Investigate: Measure how often IP addresses are copied [8H].

(Brought up on our meeting, and mentioning here for completeness.)

Feb 18 2021, 5:56 PM · Anti-Harassment (The Letter Song), IP Info
DLynch moved T274641: SecurePoll: "For wiki" label not greyed out when editing a running election from In Progress 💪 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.
Feb 18 2021, 4:36 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T274641: SecurePoll: "For wiki" label not greyed out when editing a running election.

@Tchanders I'm fine with that, and will update the patch.

Feb 18 2021, 3:20 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch added a comment to T274641: SecurePoll: "For wiki" label not greyed out when editing a running election.

This only occurs if the "more than 10 wikis are known about" case is hit, and is because in an autocompleteselect widget is used. This is one of the rare widgets which never got ported to OOUI exactly as-is, probably because it's not used anywhere in core. Codesearch turns up precisely one other use of it anywhere, in the ViewProtect extension where it's used only as a fallback if the combobox type doesn't exist.

Feb 18 2021, 9:05 AM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Feb 17 2021

DLynch added a comment to T267445: UserGetLanguageObjectHook is unsafe: "User::loadFromSession called before the end of Setup.php" [8H investigate].

An updated stack trace, since the line numbers have shifted since the one in the ticket:

Feb 17 2021, 5:42 PM · MW-1.36-notes (1.36.0-wmf.33; 2021-03-02), Anti-Harassment (The Letter Song), Language-Team (Language-2021-January-March), Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error, UniversalLanguageSelector
DLynch moved T274641: SecurePoll: "For wiki" label not greyed out when editing a running election from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Feb 17 2021, 5:26 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll
DLynch claimed T274641: SecurePoll: "For wiki" label not greyed out when editing a running election.
Feb 17 2021, 5:26 PM · MW-1.36-notes (1.36.0-wmf.32; 2021-02-23), Anti-Harassment (The Letter Song), MediaWiki-extensions-SecurePoll

Feb 15 2021

DLynch added a comment to T274783: Old and new way when using the New discussion tool.

For what it's worth, currently if you open the "add topic" link in a new tab, you'll get the old way.

Feb 15 2021, 3:31 PM · DiscussionTools

Feb 13 2021

DLynch created T274710: Can't immediately cancel adding a new topic.
Feb 13 2021, 6:46 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools

Feb 12 2021

DLynch added a comment to T119236: Make linear model data immutable.

Example: someone could make a change to the document without them being able to undo or redo that change because no record exists of that change being made.

Worse, in that scenario, attempting to undo/redo would break the document in unpredictable ways, because the transactions applied wouldn't account for the changed data.

Feb 12 2021, 4:53 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Editing-team (FY2020-21 Kanban Board), VisualEditor-DataModel, Technical-Debt, VisualEditor

Feb 11 2021

DLynch added a comment to T273946: Adjust Discussion Tools' sampling rates.

That patch changes the current state of affairs: the existing config setting 5 wikis to sample at 0.2 is removed, and replaced by oversampling all logging from DiscussionTools.

Feb 11 2021, 8:21 PM · Editing-team (Tracking), DiscussionTools
DLynch added a comment to T273946: Adjust Discussion Tools' sampling rates.

@MNeisler Actually, question, for data-integrity purposes do you (a) actually use EventLogging's oversampled attribute, and (b) if so should we be logging things as oversampled if they're being disproportionately sampled between tools? (Since it presumably gets more complicated to analyze comparisons if the rates are different?)

Feb 11 2021, 6:16 PM · Editing-team (Tracking), DiscussionTools
DLynch added a comment to T273946: Adjust Discussion Tools' sampling rates.

Events on all wikis where the New Discussion Tool and/or Reply Tool are available should be oversampnled.

Feb 11 2021, 6:12 PM · Editing-team (Tracking), DiscussionTools

Feb 9 2021

DLynch added a comment to T263817: DBA review: conversation subscriptions.

Work on this has been happening in T264885.

Feb 9 2021, 5:42 PM · Editing-team (FY2020-21 Kanban Board), DiscussionTools, OWC2020
DLynch added a comment to T260371: Develop an approach for storing thread subscriptions.

Work on this has been happening in T264885.

Feb 9 2021, 5:41 PM · DiscussionTools, Editing-team, OWC2020

Feb 8 2021

DLynch added a comment to T273946: Adjust Discussion Tools' sampling rates.

Explanation of sampling rate quirks:

Feb 8 2021, 8:16 PM · Editing-team (Tracking), DiscussionTools
DLynch added a comment to T273554: Make config change to enable Reply Tool A/B test .

In a backport window we would need to put:

Feb 8 2021, 7:41 PM · User-Ryasmeen, Editing QA, Chinese-Sites, Editing-team (FY2020-21 Kanban Board), DiscussionTools

Feb 3 2021

DLynch added a comment to T265099: Differentiate between events emitted from the Reply Tool and the New Discussion Tool.

Just as a note, we don't currently have a convenient setting for oversampling the logging for just one part of DiscussionTool. It's all-features or nothing, at the moment.

Feb 3 2021, 9:29 PM · Editing-team (FY2020-21 Kanban Board), Product-Analytics (Kanban), MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), DiscussionTools
DLynch added a comment to T238925: MySQL/MariaDB images for development environments.

but yeah it would be nice to make this easier and more up front for people.

I'm somewhat motivated by my team affiliation to argue for the configurations where it's possible to use VisualEditor being the defaults, admittedly. :D

Feb 3 2021, 9:02 PM · MediaWiki-Docker, User-brennen, dev-images
DLynch added a comment to T238925: MySQL/MariaDB images for development environments.

Having an easy and somewhat-official way to get a mediawiki+mysql instance running is what's needed. Whether it's the default or not doesn't really matter, I think, so long as we're fairly up-front about what the trade-offs are. (E.g. I think that DEVELOPERS.md should have an "only choose sqlite if..." disclaimer.)

Feb 3 2021, 8:56 PM · MediaWiki-Docker, User-brennen, dev-images

Feb 2 2021

DLynch added a comment to T238925: MySQL/MariaDB images for development environments.

It seems that a non-sqlite image is a requirement if you want to do development that touches on Parsoid via Restbase (so, VisualEditor / DiscussionTools stuff mostly), because of clashing database locks.

Feb 2 2021, 10:25 PM · MediaWiki-Docker, User-brennen, dev-images
DLynch added a comment to T261581: Request to parsoid failed on Docker Developer Environment at 80 port.

It does sound, from reading docker docs, that Mac and Linux behave differently for this, so it's possible that could be why our experience is different. I can say for me that I was never trying to use port 80, so there's at least one route into the issue that doesn't depend on that.

Feb 2 2021, 10:09 PM · Editing-team (Third-party), Parsoid (Tracking), MediaWiki-Docker, MW-1.35-release
DLynch added a comment to T266037: MediaWiki 1.35 Error contacting the Parsoid/RESTBase server: (curl error: 28) Timeout was reached.

Based on my cargo-cult usage of docker, I think that URL should be http://host.docker.internal/ rather than localhost.

Feb 2 2021, 9:45 PM · Editing-team (Third-party), Parsoid (Third-party)
DLynch added a comment to T261581: Request to parsoid failed on Docker Developer Environment at 80 port.

Just ran into part of this and did some work on debugging it for myself. The VE one, at least, is down to how Docker handles connecting internally -- localhost doesn't work, and you have to use host.docker.internal instead. Therefore I had to do this in my LocalSettings.php:

Feb 2 2021, 9:42 PM · Editing-team (Third-party), Parsoid (Tracking), MediaWiki-Docker, MW-1.35-release
DLynch added a comment to T273634: MediumSpecificBagOStuff undefined index errors on article pages.

Plausibly related to whatever was going on in T273006.

Feb 2 2021, 3:57 PM · MediaWiki-Vagrant
DLynch created T273634: MediumSpecificBagOStuff undefined index errors on article pages.
Feb 2 2021, 3:56 PM · MediaWiki-Vagrant
DLynch renamed T273633: Parsoid vagrant role throws errors from vagrant role throws errors to Parsoid vagrant role throws errors.
Feb 2 2021, 3:42 PM · Parsoid (Tracking), MediaWiki-Vagrant