DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (167 w, 2 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Thu, Dec 13

DLynch added a comment to T211698: 'trackdebug' mode doesn't work unless debug mode is enabled.

Second patch for the MobileFrontend side of the logging code, which had the same use of mw.log.

Thu, Dec 13, 4:01 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), Patch-For-Review, Technical-Debt
DLynch added a comment to T211156: Review EditAttemptStep validation failures in production.

There's also some intellectual verification -- turn on trackdebug, and verify that the timing keys in the logged events after a switch don't have any null / NaN values.

Thu, Dec 13, 3:56 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis

Wed, Dec 12

DLynch reassigned T211788: Identify IME behaviors that will need additional design treatment from DLynch to dchan.

Related is probably: T204387

Wed, Dec 12, 5:42 PM · VisualEditor
DLynch added a comment to T211156: Review EditAttemptStep validation failures in production.

Quick testing with trackdebug confirms that on mobile switching back and forth between visual and source modes causes a flurry of events which we probably don't want:

Wed, Dec 12, 4:03 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
DLynch added a comment to T211156: Review EditAttemptStep validation failures in production.

Kibana suggests upon following the provided link: "Unable to completely restore the URL, be sure to use the share functionality". I'm sufficiently unfamiliar with using it that the rest of this reply is going to be based just on what was said in the ticket description.

Wed, Dec 12, 3:46 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
DLynch added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

It should be pretty simple to do -- I've had it on my list of tasks to knock out when I have 15 minutes free.

Wed, Dec 12, 3:36 PM · VisualEditor
DLynch added a comment to T211240: Mobile table editing should default to cell contents.

We called it out in the planning document for T211255 as a related change that should be made. David or I could probably fit it in, depending on which of us finishes up our prototyping / research first.

Wed, Dec 12, 3:33 PM · VisualEditor-MediaWiki-Mobile, VisualEditor

Tue, Dec 11

DLynch moved T206050: Mobile visual editor does not log saveFailure events from In progress to Code review on the VisualEditor (Current work) board.
Tue, Dec 11, 5:00 PM · Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Wed, Dec 5

DLynch updated subscribers of T211240: Mobile table editing should default to cell contents.
Wed, Dec 5, 9:50 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch created T211240: Mobile table editing should default to cell contents.
Wed, Dec 5, 9:31 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch created T211236: After changing a link target, the link is selected such that typing will delete the link.
Wed, Dec 5, 8:00 PM · VisualEditor

Thu, Nov 29

DLynch claimed T206050: Mobile visual editor does not log saveFailure events.
Thu, Nov 29, 6:02 PM · Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch moved T205166: Mobile editors do not log timings for any Edit events from Code review to QA on the VisualEditor (Current work) board.
Thu, Nov 29, 4:36 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend, Editing Q1 2018-19 mobile improvements, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Nov 9 2018

DLynch added a comment to T209162: [Regression] Blockquotes can't be edited, because they're alienated content.

e.g. the parsoid HTML we get from the linked article is:

Nov 9 2018, 5:47 PM · VisualEditor
DLynch updated subscribers of T209162: [Regression] Blockquotes can't be edited, because they're alienated content.

I think this is from the patch on T110004 which merged in mid-July, but based on the timeline wouldn't have actually rolled out to production until quite recently (see: T198511).

Nov 9 2018, 5:46 PM · VisualEditor
DLynch renamed T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state from Loading an edit page while logged out changes to URL to an incorrect state to Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state.
Nov 9 2018, 5:31 PM · VisualEditor (Current work)
DLynch created T209163: Loading an edit page using veaction=edit in single-tab mode changes URL to an incorrect state.
Nov 9 2018, 5:25 PM · VisualEditor (Current work)

Nov 7 2018

DLynch moved T208515: Improve test coverage for ve.ce.ResizableNode from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Nov 7 2018, 7:14 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Test-Coverage, VisualEditor (Current work)
DLynch added a comment to T208515: Improve test coverage for ve.ce.ResizableNode.

That patch pushes it from 54.95% to 82.67% coverage.

Nov 7 2018, 5:54 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Test-Coverage, VisualEditor (Current work)

Nov 6 2018

DLynch claimed T208515: Improve test coverage for ve.ce.ResizableNode.
Nov 6 2018, 5:23 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Test-Coverage, VisualEditor (Current work)

Nov 5 2018

DLynch updated the task description for T208515: Improve test coverage for ve.ce.ResizableNode.
Nov 5 2018, 5:46 PM · MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), Patch-For-Review, Test-Coverage, VisualEditor (Current work)
DLynch updated the task description for T207084: Increase unit test coverage in ve.ce.GeneratedContentNode.
Nov 5 2018, 5:45 PM · Technical-Debt, VisualEditor

Oct 29 2018

DLynch added a comment to T207802: Growth team requests for Schema:VisualEditorFeatureUse.

Okay, patch is updated to handle these things. Tracking will cover popups opening via an actual click on the button rather than any arbitrary opening. Blue dots will be tracked via the education popup they trigger opening -- see the linkEducationPopup action in the screenshot below, followed by link which means the popup closed and the regular link action continued.

Oct 29 2018, 3:24 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team (Current Sprint), VisualEditor (Current work), Product-Analytics
DLynch moved T207802: Growth team requests for Schema:VisualEditorFeatureUse from In progress to Code review on the VisualEditor (Current work) board.
Oct 29 2018, 3:12 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team (Current Sprint), VisualEditor (Current work), Product-Analytics

Oct 25 2018

DLynch added a comment to T207802: Growth team requests for Schema:VisualEditorFeatureUse.

That patch tracks the blue dots and the ? button. It's explicitly ignoring notices while I await an answer on the initially-open thing.

Oct 25 2018, 3:34 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team (Current Sprint), VisualEditor (Current work), Product-Analytics
DLynch added a comment to T193665: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms.

@jeblad: Don't worry, you're closer to being the one who's "on topic" for this actual ticket. :D

Oct 25 2018, 2:54 PM · VisualEditor, Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T193665: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms.

I just ran a test using webpagetest.org. If you check the film strip you'll see that VE isn't usable until 23 seconds. If you scroll down and click web request #104 Wikipedia.org-stats.sv you'll see that VE reports back 15488ms. VE under-reported the time by 7.5 seconds. (That looks like a significant improvement, a similar VE tests last year on a smaller article took a lot longer, and it under reported by a more severe percentage.)

Oct 25 2018, 2:13 AM · VisualEditor, Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor

Oct 24 2018

DLynch added a comment to T207802: Growth team requests for Schema:VisualEditorFeatureUse.

Further question: the notices popup opens by default if there are any notices. Is what you want effectively whether people re-open it?

Oct 24 2018, 5:24 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team (Current Sprint), VisualEditor (Current work), Product-Analytics
DLynch added a comment to T207802: Growth team requests for Schema:VisualEditorFeatureUse.

For the dots, is knowing when the cite/link feature is used sufficient, or do you need specifically that it was a toolbar interaction? (Or even more specifically, a toolbar interaction while the dot is present?) If it's the former, we do have that already.

Oct 24 2018, 4:48 PM · MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), Patch-For-Review, Growth-Team (Current Sprint), VisualEditor (Current work), Product-Analytics

Oct 23 2018

DLynch created T207796: Add flag to log tracking events to console.
Oct 23 2018, 8:46 PM · VisualEditor

Oct 19 2018

DLynch added a comment to T198511: VisualEditor losing Media: links.

@rakekniven Sorry, I was talking about deployment-to-wikipedia more than about proper parsoid releases.

Oct 19 2018, 3:55 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Oct 18 2018

DLynch added a comment to T198511: VisualEditor losing Media: links.

@Deskana: It should fix any future mangling of Media: links. (Given: that the new parsoid release is deployed, which I believe it is.) Basically, paste [[Media:Test.pdf]] into a VE document. If the link context item you get shows it being a Media: link after you do that, it's fixed.

Oct 18 2018, 5:17 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.

Yes, this'll only happen with the app installed. It also then requires doing something that iOS considers intentionally accessing wikipedia in Safari, so as to not have the app automatically take over the request. (There are reasons to do this, of course; mostly edit-actions which the app doesn't provide.)

Oct 18 2018, 2:48 AM · MinervaNeue, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile

Oct 17 2018

DLynch moved T206829: Lack of next steps for new users on mobile devices when attempting to edit a protected page from To Triage to Needs Discussion/Analysis on the VisualEditor board.
Oct 17 2018, 4:04 PM · Readers-Web-Backlog (Design), MediaWiki-Page-protection, Wikipedia-iOS-App-Backlog, VisualEditor, MobileFrontend, Mobile

Oct 16 2018

DLynch added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.

@pmiazga / @Jdlrobson: MobileFrontend makes sense because its where some compensating CSS would need to be. As I said earlier, I don't think we can stop the banner appearing. (At least, not without the iOS app losing its entire ability to intercept links.)

Oct 16 2018, 3:36 PM · MinervaNeue, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile

Oct 11 2018

DLynch added a project to T206774: iOS Universal Links banner pushes toasts partially off-screen: iOS-app-Bugs.

Adding the iOS project here, in case there's anything configurable there for Universal Links which could avoid this. (I suspect not, given that my specific example is on an article page, and that's probably the most-reasonable place to hook into. But just in case...)

Oct 11 2018, 4:55 PM · MinervaNeue, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile
DLynch created T206774: iOS Universal Links banner pushes toasts partially off-screen.
Oct 11 2018, 4:39 PM · MinervaNeue, Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile

Oct 10 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

@Deskana: Sorry, we kinda answered that on the call yesterday, but putting it here for documentation and expansion... there's a patch for the actual instrumentation, and another for adding the schema to the events extension so we can use it. Once both of those are there, one last patch will actually hook up the logging in the MW-VE extension itself. (It can't go in with the WikimediaEvents patch, since it needs access to the session ID which the VE extension generates and doesn't expose...)

Oct 10 2018, 4:28 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Oct 3 2018

DLynch added a comment to T203136: Develop new schema for editing feature usage.

Currently it will track:

Oct 3 2018, 4:24 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Oct 2 2018

DLynch added a comment to T202147: Snapshot: which parts of the edit process cause people to abort edits?.

Might need to scope this one down to desktop-only, just because of the memory eviction behavior on mobile browsers potentially being difficult to account for?

Oct 2 2018, 4:45 PM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics

Oct 1 2018

RandomDSdevel awarded T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype a Haypence token.
Oct 1 2018, 1:05 AM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Sep 24 2018

DLynch added a comment to T205309: 2017 wikitext editor emits many ready events with platform "other".

I'd suspect this is going to be T205241, which @Esanders just put up a patch for.

Sep 24 2018, 5:05 PM · VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T205161: 2010 wikitext editor does not log timings for most Edit events.

Looks like client-side events get timings, server side ones don't. In fairness... this is tricky.

Sep 24 2018, 4:58 PM · VisualEditor, WikiEditor, Product-Analytics, Contributors-Analysis

Sep 19 2018

DLynch added a comment to T138683: Whitespace inside HTML comments in transclusion parameters are lost on editing(?).

Though do note, I think this'll still happen if it's a comment next to any more-specific TemplateData type. I.e. a comment after a boolean is going to get thrown away because the value will get coerced into a checkbox, etc.

Sep 19 2018, 5:05 PM · VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor, Parsoid

Sep 18 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

It's because those sessions stick a confirmation dialog in the middle of the loading process, between init and ready, and pause the process until the user chooses what to do with their autosave. Since most of this stuff was added for us to do performance testing, introducing a fairly randomly large delay into the timing there would throw the numbers off.

Sep 18 2018, 6:47 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Oh, thing to consider with this: we explicitly disable tracking for any session where we have to ask about restoring the autosave (i.e. any session where a new revision has been made since the autosave happened).

Sep 18 2018, 4:59 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Auto-save could go in the other schema (for editor life cycle events)

Sep 18 2018, 2:47 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Sep 17 2018

DLynch added a comment to T203618: Visual editor emits many init events with platform "other".

@Ryasmeen Sort of. You could paste this into your browser console:

Sep 17 2018, 2:20 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Sep 13 2018

DLynch claimed T190191: Line-breaks between list-items in template parameters are removed.
Sep 13 2018, 3:37 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)

Sep 12 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Useful thing Ed suggested in meeting: auto-save recovery?

Sep 12 2018, 5:35 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Sep 6 2018

DLynch moved T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it) from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sep 6 2018, 5:10 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
DLynch moved T198511: VisualEditor losing Media: links from In progress to Stalled/Waiting on the VisualEditor (Current work) board.
Sep 6 2018, 3:54 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch moved T203618: Visual editor emits many init events with platform "other" from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sep 6 2018, 3:53 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T203620: Implementations of the Edit schema generate session IDs differently.

I think you might be wrong about MobileFrontend using the persistent sessionId. Far as I can tell, it generates a new one via mw.user.generateRandomSessionId() for all the editor event logging every time the editor route is reached. (See: MinervaNeue's definition of the editor options in skins.minerva.editor/init.js.)

Sep 6 2018, 3:36 AM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T203621: 2010 wikitext editor logs init and save events to old schema.

Same reasoning as it not logging an init event, maybe? Insofar as there's not an in-page equivalent to the saveComplete event that VE emits, because there's a page-navigation in the way.

Sep 6 2018, 3:18 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Sep 5 2018

DLynch added a comment to T203619: 2010 wikitext editor does not emit init events.

I’m not clear on whether we should be changing this?

Sep 5 2018, 11:28 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch claimed T203618: Visual editor emits many init events with platform "other".
Sep 5 2018, 11:24 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T203618: Visual editor emits many init events with platform "other".

Patch for this already exists: https://gerrit.wikimedia.org/r/455850

Sep 5 2018, 11:24 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T202437: Identify and fix data quality problems in the Edit event log.

Unusually few abort events recorded for both mobile editors.
On the desktop editors, the combined number of abort and saveAttempt events roughly match the number of ready events, but that isn't the case here.

Sep 5 2018, 11:12 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch moved T101113: Come up with a way to move/remove/duplicate focusable nodes in mobile from Freezer to Needs Discussion/Analysis on the VisualEditor board.
Sep 5 2018, 4:38 PM · VisualEditor, Design, VisualEditor-MediaWiki-Mobile
DLynch moved T50429: [Epic] Support editing parts of a page in VisualEditor-MediaWiki from Freezer to Needs Discussion/Analysis on the VisualEditor board.
Sep 5 2018, 4:37 PM · VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki
DLynch moved T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console from To Triage to Needs Discussion/Analysis on the VisualEditor board.
Sep 5 2018, 4:30 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking)
DLynch added a comment to T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console.

My recollection of why I moved this in as a subtask: the parent passived scroll event handlers, but this ticket is talking about touchstart, which we should investigate as well.

Sep 5 2018, 3:50 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking)
DLynch added a comment to T190191: Line-breaks between list-items in template parameters are removed.

It does seem to legitimately feel that the author parameter has type=line in templatedata, so it's sort of a config issue on commons. That said, should we maybe detect this case (there are line-breaks in the existing value for a line field) and provide a multiline input regardless of the type?

Sep 5 2018, 3:39 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch added a comment to T190191: Line-breaks between list-items in template parameters are removed.
{{Information
|Description=Letter from US copyright office denying registration for the Subway logo.
|Source=https://www.ipmall.info/sites/default/files/hosted_resources/CopyrightAppeals/2004/Daniel%20Cislo.pdf
|Date=2013-07-16
|Author=*Maria A. Pallante, Register of Copyrights, United States Copyright Office
*William J. Roberts, Jr., Copyright Office Review Board, United States Copyright Office
|Permission=
}}
Sep 5 2018, 3:07 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch renamed T190191: Line-breaks between list-items in template parameters are removed from VE removes line-breaks of lists and breaks the layout to Line-breaks between list-items in template parameters are removed.
Sep 5 2018, 3:01 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)

Sep 4 2018

DLynch added a comment to T202656: Develop minimum set of UI Actions and Product Requirements.

Sep 4 2018, 5:11 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch moved T202656: Develop minimum set of UI Actions and Product Requirements from In progress to Code review on the VisualEditor (Current work) board.
Sep 4 2018, 4:09 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch moved T202656: Develop minimum set of UI Actions and Product Requirements from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Sep 4 2018, 4:09 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T202656: Develop minimum set of UI Actions and Product Requirements.

Patch hooks up most of the instrumentation. The rest will be in the MW extension (ve.init.mw.trackSubscriber.js), and is blocked on Neil's schema definition.

Sep 4 2018, 3:59 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Aug 29 2018

DLynch added a comment to T202437: Identify and fix data quality problems in the Edit event log.

Yup. This is because sessions launched by non-JS users won't trigger any JS-land activity (just server-side activity).

Aug 29 2018, 3:39 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Aug 28 2018

DLynch added a comment to T202656: Develop minimum set of UI Actions and Product Requirements.

There's already a bunch of discussion of implementation details in T202148.

Aug 28 2018, 4:54 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Aug 27 2018

DLynch updated subscribers of T202437: Identify and fix data quality problems in the Edit event log.

The init platform:other issue is that our tracking code tries to work out the platform via platform: ve.init && ve.init.target && ve.init.target.constructor.static.platformType || 'other',

Aug 27 2018, 10:24 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Summary of what I observed: SurfaceFragment.annotateContent is the underpinning of most of this. Logging on it would catch use of formatting annotations and links, but not using formatting annotations without any text content -- that's done by changing the insertion annotations, not actually setting any annotation.

Aug 27 2018, 3:50 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Aug 23 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Meeting outcome: we seemed happy with the idea that we'd log some specific window-opened events for everything non-annotation, as we're more concerned with interacting with features rather than success. (I.e. "add image", "modify image", "opened the image inspector and didn't modify it", and "opened the add image dialog and then canceled" would all be in the same "opened the image dialog" event.)

Aug 23 2018, 6:05 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it).

I observe that with the current patches, insert-table still leaves an empty paragraph (either via sequence or menu action).

Aug 23 2018, 5:10 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
DLynch added a comment to T198511: VisualEditor losing Media: links.

(That's very provisional.)

Aug 23 2018, 5:02 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

@ssastry Thanks for the update!

Aug 23 2018, 4:43 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

@rakekniven: No strict schedule. It's not very urgent to work on for us until the Parsoid patch lands, and I have no idea when that'll be. Sometime in the next few weeks is plausible.

Aug 23 2018, 4:37 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Aug 22 2018

DLynch added a comment to T198511: VisualEditor losing Media: links.

@rakekniven: Conceptually a solution is found, but it's incomplete. Once 451001 is merged into Parsoid, and a new Parsoid release happens, we'll need another patch to VE to actually use this new resource attribute.

Aug 22 2018, 7:28 PM · Editing QA, MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Aug 21 2018

DLynch added a comment to T187142: Deduplicate template styles in Parsoid.

Just to confirm, for VE it'd make our lives simpler if this doesn't happen.

Aug 21 2018, 11:12 PM · Patch-For-Review, Performance-Team (Radar), Parsoid, TemplateStyles
DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

...also, the TODO there may not be necessary to address, because I think the Parsoid output for us just has a <style> for every template rather than using <link>s for deduplication. Not 100% confident that's always the case, though.

Aug 21 2018, 3:53 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch moved T197563: Template styles get ignored when switching to Visual Editor from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Aug 21 2018, 3:51 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles

Aug 20 2018

DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

The remaining TODO after those patches: if multiple copies of a template with deduplicated styles are on the page, and the one containing the actual <style> is removed, all will lose their styling.

Aug 20 2018, 5:49 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles

Aug 16 2018

DLynch claimed T197563: Template styles get ignored when switching to Visual Editor.

We filter out the <style> in ve.ce.GeneratedContentNode.prototype.getRenderedDomElements, because it calls ve.filterMetaElements on the template's markup, which removes all the link and style tags present. (Apparently because them being in cut content was crashing Chrome, per T52043.)

Aug 16 2018, 4:51 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

@Ottomata: That still leaves zookeeper dying with the same exception as in my previous message, unfortunately.

Aug 16 2018, 3:17 PM · Services (watching), Analytics, MediaWiki-Vagrant

Aug 15 2018

DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

I have eventbus explicitly enabled, but I think I remember that being something I did on a suggestion from someone helping me debug this in IRC. My VM's setup very much comes from vagrant enable role visualeditor and then whatever falls in from that and a few other extensions.

Aug 15 2018, 3:58 PM · Services (watching), Analytics, MediaWiki-Vagrant

Aug 14 2018

DLynch updated subscribers of T201871: [regression] Layout issues in feedback dialog.

The checkbox alignment seems to be caused by T178456's patch (or, at least, disabling the padding-left rule it added fixes it; harder to test whether it predates that). @matmarex?

Aug 14 2018, 4:22 PM · User-Ryasmeen, Verified-in-Phase0, Verified, OOUI (OOUI-0.28.0), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression

Aug 11 2018

DLynch added a comment to T201538: Set up test instance for user testing editing prototypes.

Given the short-term prototyping goals of this, I'd assume that we'd want to quickly spin an instance up and discard it on a fairly short timeframe. Assuming that we can properly automate all that content-importing and patch-applying, this'd get us to a low maintenance state. Given that Vagrant itself is doing fine, of course.

Aug 11 2018, 11:31 PM · Developer Productivity, VisualEditor (Current work)

Aug 10 2018

DLynch updated subscribers of T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

I suppose that I'm not opposed to the combined field-button per-se, I'm just with matmarex in not really liking it in this specific instance. I'd probably be most visually happy just restoring the separation in this case. (And maybe other similar ones with this aesthetic incompatibility.)

Aug 10 2018, 4:44 AM · UI-Standardization, VisualEditor

Aug 9 2018

DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

I suspect the most relevant bit for that is ve.init.mw.Target.prototype.setupSurface, since that's where we actually turn the DOM into our model. (Though I grant I haven't stepped through and verified that the <style> hasn't been quietly stripped somewhere else where I didn't see it...)

Aug 9 2018, 5:21 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch claimed T201210: VisualEditor not switching to edit conflict interface.

Yeah, seems like that has indeed helped.

Aug 9 2018, 5:12 PM · Verified, VisualEditor (Current work), MediaWiki-Page-editing
DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

The requirement is more specific than just switching to VE -- it has to be switching to VE from the classic editpage, rather than from NWE, because that causes a load of VE without the underlying view of the page existing.

Aug 9 2018, 5:05 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch added a comment to T201538: Set up test instance for user testing editing prototypes.

Additional criteria: ease of deploying an arbitrary patch to the instance.

Aug 9 2018, 4:35 PM · Developer Productivity, VisualEditor (Current work)

Aug 8 2018

DLynch added a comment to T199554: Switching between visual editor and source mode gives error message.

(Note that there is no data loss, for VE or other affected tools, just a misleading message.)

Aug 8 2018, 8:46 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch added a comment to T201210: VisualEditor not switching to edit conflict interface.

The incompleteForm message part will be fixed when my patch on T199554 is merged. I'm not sure if that's the sole part that's holding up going to the conflict resolution interface, though -- I'll double-check it.

Aug 8 2018, 5:18 PM · Verified, VisualEditor (Current work), MediaWiki-Page-editing
DLynch added a comment to T201472: List insertion by typing '#<space>', '*<space>' is broken.

@Esanders: Makes sense, and I agree on the general case. If you merge it, I can make a new task for fixing it up more permanently.

Aug 8 2018, 4:37 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki

Aug 7 2018

DLynch moved T201472: List insertion by typing '#<space>', '*<space>' is broken from In progress to Code review on the VisualEditor (Current work) board.
Aug 7 2018, 11:37 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T201472: List insertion by typing '#<space>', '*<space>' is broken.
Aug 7 2018, 11:05 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch added a comment to T200525: Allow cursoring between active nodes.

Question 1 is what I was asking above in my first comment on this task, so I'd say that's somewhat-undecided. I think 2 is unintended, though; it should switch to cell selection first.

Aug 7 2018, 10:56 PM · User-Ryasmeen, Verified, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation