Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (389 w, 6 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Tue, Mar 21

DLynch added a comment to T331600: "Reference" text has gone from the Insert Reference button with Visual Editor at Basque Wikipedia.

Mind you, the icon in Citoid has also been that way for (gosh) about 8 years now, so changing it either way risks confusing an entrenched community. (Though, honestly, I agree that using the reference icon would make more sense overall...)

Tue, Mar 21, 5:33 PM · VisualEditor, VisualEditor-EditingTools

Fri, Mar 17

DLynch added a comment to T203151: Consider adding a button to let users edit the whole page in MobileFrontend.

The alternative, of course, being this patch: just have the top edit button edit the whole page. As was said, this is probably much more reasonable from a performance standpoint than back in 2017-or-so when the original decision was made.

Fri, Mar 17, 4:24 PM · Patch-For-Review, Design, MobileFrontend, VisualEditor

Tue, Mar 14

DLynch added a comment to T330815: Disallow preference setting by temporary users.

It's worth noting that there's some cases where temp users having preference-setting completely disallowed is going to give them a non-default experience, because there's places where we've left old defaults in place for existing users and set new "defaults" by overriding them for newly created users. See e.g. Echo, which changes what notifications are sent in this way.

Tue, Mar 14, 5:34 PM · Anti-Harassment, IP Masking
DLynch claimed T330191: Instrument the revised "Add topic" button treatment .
Tue, Mar 14, 2:31 PM · Product-Analytics, Editing QA, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), TPP-Phase1, Editing-team (Kanban Board), Goal, Editing Design, DiscussionTools

Thu, Mar 9

DLynch claimed T330536: Mobile section-level ... button and associated menu is cut off by the section container.
Thu, Mar 9, 11:12 PM · Verified, Editing-team (Kanban Board), DiscussionTools
DLynch claimed T330537: Mobile section-level ... button displays even when it doesn't have anything to show.
Thu, Mar 9, 11:12 PM · Verified, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Kanban Board), DiscussionTools
DLynch moved T330537: Mobile section-level ... button displays even when it doesn't have anything to show from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Mar 9, 11:11 PM · Verified, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Kanban Board), DiscussionTools
DLynch moved T330537: Mobile section-level ... button displays even when it doesn't have anything to show from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.
Thu, Mar 9, 5:58 PM · Verified, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Kanban Board), DiscussionTools
DLynch moved T330536: Mobile section-level ... button and associated menu is cut off by the section container from Incoming to Code Review on the Editing-team (Kanban Board) board.
Thu, Mar 9, 5:58 PM · Verified, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T330537: Mobile section-level ... button displays even when it doesn't have anything to show.

Patchdemo: https://patchdemo.wmflabs.org/wikis/56e9396b0e/wiki/Talk:DiscussionTools?useformat=mobile

Thu, Mar 9, 5:02 PM · Verified, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T330536: Mobile section-level ... button and associated menu is cut off by the section container.

Patchdemo: https://patchdemo.wmflabs.org/wikis/56e9396b0e/wiki/Talk:DiscussionTools?useformat=mobile

Thu, Mar 9, 5:02 PM · Verified, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T330537: Mobile section-level ... button displays even when it doesn't have anything to show.

We could probably merge this into T330536 -- turns out that the menu does contain the edit link, it's just that the clipping effect combines with the size of the non-discussion section heading perfectly to make it look like no menu is being shown.

Thu, Mar 9, 4:54 PM · Verified, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T331600: "Reference" text has gone from the Insert Reference button with Visual Editor at Basque Wikipedia.

@Theklan are you using the new skin? It has a bit less horizontal space available (particularly if you have both sidebars enabled), and that might be enough to account for the change depending on exactly how your space is set up.

Thu, Mar 9, 4:29 PM · VisualEditor, VisualEditor-EditingTools
DLynch added a comment to T331624: Find a way to avoid large indentation in deep discussion on mobile.

I like 4 the best, for making over-indention actually impossible while still giving visual cues. That said, 2's a decent compromise and will confirm closer to what people expect -- there's templates like that deindent one which put in an arrow breaking the flow, and they'll make more visual sense if there's some sort of indentation in play.

Thu, Mar 9, 4:27 PM · Mobile, Design, DiscussionTools
DLynch added a comment to T314588: Launch visual diffs on history pages out of beta and provide it to all users.

This is now launched everywhere but Wikipedias and Wiktionaries, and we should presumably decide when we want to launch it there. (I guess if no terrible issues develop in the next few weeks.)

Thu, Mar 9, 4:12 AM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), User-notice, Editing-team (Kanban Board), MediaWiki-Page-history, VisualEditor, VisualEditor-VisualDiffs
DLynch moved T328942: [Config Change] Enable all DiscussionTools as default-on features at Phase 2 wikis (mobile) from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Mar 9, 4:09 AM · Editing QA, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools

Wed, Mar 8

DLynch moved T328021: Provide a link to the template page from the template context item from Incoming to QA on the Editing-team (Kanban Board) board.
Wed, Mar 8, 9:04 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing QA, Editing-team (Kanban Board), Community-Wishlist-Survey-2023, VisualEditor-MediaWiki, VisualEditor
DLynch added a project to T328021: Provide a link to the template page from the template context item: Editing-team (Kanban Board).
Wed, Mar 8, 9:02 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing QA, Editing-team (Kanban Board), Community-Wishlist-Survey-2023, VisualEditor-MediaWiki, VisualEditor
DLynch moved T328942: [Config Change] Enable all DiscussionTools as default-on features at Phase 2 wikis (mobile) from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.
Wed, Mar 8, 6:24 AM · Editing QA, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
DLynch moved T330191: Instrument the revised "Add topic" button treatment from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.
Wed, Mar 8, 1:46 AM · Product-Analytics, Editing QA, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), TPP-Phase1, Editing-team (Kanban Board), Goal, Editing Design, DiscussionTools

Tue, Mar 7

DLynch added a comment to T330191: Instrument the revised "Add topic" button treatment .

As I understand the requirements, all that I need to do here is add the DesktopWebUIActionsTracking to the "add topic" button when it's promoted to the header. That patch logs it with the name "addsection-header". (As opposed to "ca-addsection" for the unpromoted version of the button, and "addsection-sticky-header" for the version in the sticky header.)

Tue, Mar 7, 10:06 PM · Product-Analytics, Editing QA, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), TPP-Phase1, Editing-team (Kanban Board), Goal, Editing Design, DiscussionTools
DLynch added a comment to T330802: Stray blockquote tag removed.

A combination, maybe? DT's DOM-fiddling removing that invalid </blockquote>, which then made that node get through selser and allowing the newline to get added incorrectly by parsoid.

Tue, Mar 7, 6:23 PM · Parsoid, DiscussionTools

Fri, Mar 3

DLynch added a comment to T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.

The described issue sounds consistent with the wikieditor JS and the mobile JS both running at the same time (such that the desktop wikieditor is loaded in the background), or possibly with the redirect-to-mobile code not running as expected (such that the desktop wikieditor loads, logs events, and then the redirect happens, rather than the redirect occurring before the form is loaded at all). However, I can't actually make this happen by directly navigating to an ?action=edit URL on mobile, so it's a bit confusing.

Fri, Mar 3, 8:15 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Product-Analytics (Kanban)

Wed, Mar 1

DLynch added a comment to T330802: Stray blockquote tag removed.

I do understand the parser confusion, since it was dealing with already-invalid markup -- note that it didn't add a blockquote, it just removed a meaningless closing-blockquote that didn't have a matching opening-blockquote.

Wed, Mar 1, 3:55 PM · Parsoid, DiscussionTools

Fri, Feb 24

DLynch created T330537: Mobile section-level ... button displays even when it doesn't have anything to show.
Fri, Feb 24, 10:17 PM · Verified, MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Editing-team (Kanban Board), DiscussionTools
DLynch created T330536: Mobile section-level ... button and associated menu is cut off by the section container.
Fri, Feb 24, 10:13 PM · Verified, Editing-team (Kanban Board), DiscussionTools

Thu, Feb 23

DLynch added a comment to T54750: VisualEditor: Make each reference editable where it appears in the reference list as well as on the edit surface.

Even if we switch to just using (2) this will mean that references are re-numbered when switching from read mode to edit mode.

Thu, Feb 23, 4:08 PM · WMDE-References-FocusArea, Community-Wishlist-Survey-2023, VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-EditingTools
DLynch added a comment to T54750: VisualEditor: Make each reference editable where it appears in the reference list as well as on the edit surface.

I was thinking that a quick path forward would be for the reference list to offer a button that opened up a variant on the reuse dialog. In its context item would be the easiest place.

Thu, Feb 23, 4:03 PM · WMDE-References-FocusArea, Community-Wishlist-Survey-2023, VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-EditingTools
DLynch added a comment to T330369: [SPIKE] Assess technical complexity of Editing Team-related wishes (top 50).

There's also Editing-related items in New Contributors and Translation.

Thu, Feb 23, 3:46 PM · DiscussionTools, VisualEditor, Editing-team (Kanban Board)

Tue, Feb 21

DLynch moved T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks from Code Review to QA on the Editing-team (Kanban Board) board.
Tue, Feb 21, 9:43 PM · Verified, Editing-team (Kanban Board), VisualEditor
DLynch closed T329686: Update Ace editor to 1.14.x/1.15.x?, a subtask of T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks, as Resolved.
Tue, Feb 21, 9:42 PM · Verified, Editing-team (Kanban Board), VisualEditor
DLynch closed T329686: Update Ace editor to 1.14.x/1.15.x? as Resolved.
Tue, Feb 21, 9:42 PM · Patch-For-Review, Ace editor updates
DLynch claimed T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks.

I've got an Ace update patch up on the subtask

Tue, Feb 21, 5:57 PM · Verified, Editing-team (Kanban Board), VisualEditor

Feb 21 2023

DLynch updated subscribers of T326147: Stop fragmenting ParserCache entries for mobile frontend .

Someone like @EAkinloose or @Ryasmeen might be better suited to give you a "what we do to comprehensively test DiscussionTools on mobile" overview, admittedly. 😅

Feb 21 2023, 12:57 AM · User-Ryasmeen, Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), DBA, Patch-For-Review, MediaWiki-Parser, MobileFrontend
DLynch added a comment to T326147: Stop fragmenting ParserCache entries for mobile frontend .

@nray you need to check a talk page on a wiki with DiscussionTools enabled for mobile (currently the default, and is turned on everywhere but enwiki) -- e.g. https://fr.m.wikipedia.org/wiki/Discussion:C%C3%B4te_d%27Ivoire. There should be:

Feb 21 2023, 12:56 AM · User-Ryasmeen, Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), DBA, Patch-For-Review, MediaWiki-Parser, MobileFrontend

Feb 19 2023

DLynch added a comment to T329866: Translate the VisualEditor to TypeScript.

Just bear in mind that this would be a large task. To port to ES6 we'd have to make meaningful semantic changes to every single file in the VE project and in various extensions, and deal with lots of areas where things like subclassing and accessing superclass properties occur. (And coordinate this across a number of extensions, including either porting OOUI to ES6 simultaneously or switching to something like Codex, etc.) It could be done, but it'd be a significant time investment, and I doubt we'd manage it without introducing new bugs.

Feb 19 2023, 12:19 AM · VisualEditor

Feb 18 2023

DLynch added a comment to T298066: Disable MobileFrontend talk page overlay.

We are down to enwiki as literally the only place that it's enabled, mind you. :D

Feb 18 2023, 4:48 PM · Editing-team (Kanban Board), DiscussionTools

Feb 16 2023

DLynch added a comment to T54750: VisualEditor: Make each reference editable where it appears in the reference list as well as on the edit surface.

Copying my comment in from the other ticket, since I think it remains relevant here:

The major hangup on this is that it's going to expose the challenges with VE seeing references that're defined within templates. (Because of the current lack of a centralized way to edit references, this is only really visible to users from the "reuse citation" part of the cite dialog, where such references don't appear.) I suspect that if we accept having those ones greyed out in the list with a "this can't be edited here" tooltip, the rest of this should be fairly simple to do -- unless I'm not thinking of something, it's "just" hooking up a few bits of already-existing functionality and doing some UI work to expose them.

Feb 16 2023, 10:06 PM · WMDE-References-FocusArea, Community-Wishlist-Survey-2023, VisualEditor-MediaWiki-References, VisualEditor, VisualEditor-EditingTools
DLynch moved T317035: Multiple new topic tools are opening for DT after making an edit in NWE from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 16 2023, 4:49 PM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), Editing QA, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T329847: Allow citations to be edited in the references section with VisualEditor.

The major hangup on this is that it's going to expose the challenges with VE seeing references that're defined within templates. (Because of the current lack of a centralized way to edit references, this is only really visible to users from the "reuse citation" part of the cite dialog, where such references don't appear.) I suspect that if we accept having those ones greyed out in the list with a "this can't be edited here" tooltip, the rest of this should be fairly simple to do -- unless I'm not thinking of something, it's "just" hooking up a few bits of already-existing functionality and doing some UI work to expose them.

Feb 16 2023, 4:03 PM · VisualEditor

Feb 14 2023

DLynch added a comment to T309013: EditAttemptStep Migration to MP.

I think there's validation occurring over in T320281.

Feb 14 2023, 10:57 PM · Metrics-Platform-Planning (Metrics Platform Kanban), MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Editing-team, DiscussionTools
DLynch added a comment to T320281: Instrumentation Data-QA for event.mediawiki_edit_attempt.

I think (based on my possibly-out-of-date understanding of the metrics platform) that the WikiEditor instrumentation is going to be incomplete, because the patch for it only added the client-side instrumentation. For WikiEditor the logging of the init, saveAttempt, saveSuccess, and saveFailure events is done server-side via EventLogging::logEvent.

Feb 14 2023, 10:53 PM · MW-1.40-notes (1.40.0-wmf.27; 2023-03-13), Product-Analytics (Kanban)
DLynch added a comment to T298066: Disable MobileFrontend talk page overlay.

This will automatically happen because the hook is directly tied to HookUtils::isFeatureEnabledForOutput( $output ) -- so any page that has DiscussionTools enabled will inherently have the MobileFrontend talk overlay disabled.

Feb 14 2023, 6:24 PM · Editing-team (Kanban Board), DiscussionTools
DLynch moved T308511: [SPIKE] Determine necessity of edit session continuity during data center switchovers from Ready to Be Worked On to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
Feb 14 2023, 5:17 PM · Editing-team (Kanban Board), VisualEditor

Feb 13 2023

DLynch added a comment to T329346: Subscribe the reviewer to any talk page discussions started due to their inputs.

(In fact, if we ever want to make that config change, it'd be good to avoid having other people manually creating subscriptions via the API, since that'll be a bit of a confusing doubling-up factor.)

Feb 13 2023, 7:55 PM · DiscussionTools, Growth-Team, PageTriage
DLynch added a comment to T329346: Subscribe the reviewer to any talk page discussions started due to their inputs.

We technically support this via the DiscussionToolsAutoTopicSubEditor config. It's set to discussiontoolsapi by default, which restricts it to only doing auto-subscription for edits made through the API, but if it's set to any then it'll auto-subscribe to anything that triggers our new-comment detection.

Feb 13 2023, 7:53 PM · DiscussionTools, Growth-Team, PageTriage
DLynch added a comment to T329548: TypeError: this.getTarget is not a function.

I believe this is a duplicate of T329439, the fix for which was backported a few hours ago.

Feb 13 2023, 5:27 PM · Editing-team, VisualEditor, Wikimedia-production-error

Feb 12 2023

DLynch moved T328980: DiscussionTools marker comments still appear in the output sometimes in weird places from Code Review to QA on the Editing-team (Kanban Board) board.

This needs general regression-testing of DT behaviors that (used to) depend on tracking comments added to parser output.

Feb 12 2023, 1:10 AM · Editing QA, MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Editing-team (Kanban Board), DiscussionTools

Feb 10 2023

DLynch updated subscribers of T328680: '.custom_data['mode'].data_type' should be equal to one of the allowed values.

"mode":{"data_type":"null","value":"null"} seems to be the problem.

Feb 10 2023, 1:52 AM · Editing-team, Metrics-Platform-Planning, Wikimedia-production-error

Feb 7 2023

DLynch added a comment to T328940: [Config Change] Enable all DiscussionTools as default-on features at Phase 1 wikis (mobile).

Which wikis should this be going out to?

Feb 7 2023, 6:23 PM · Verified, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
DLynch added a comment to T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks.

Ace has committed a fix for it, so we could presumably either backport that into our bundled version or await a new release.

Feb 7 2023, 4:41 PM · Verified, Editing-team (Kanban Board), VisualEditor
DLynch moved T327358: OOUI (and so things that use it, like DiscussionTools) should respect prefers-reduced-motion setting from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.

OOUI release has happened, so this should be testable.

Feb 7 2023, 3:56 PM · Verified, Editing-team (Kanban Board), OOUI, Accessibility, DiscussionTools
DLynch added a comment to T326147: Stop fragmenting ParserCache entries for mobile frontend .

Re: test cases, DiscussionTools does its own transforms on talk pages on mobile web, so Editing has some interest in keeping an eye on changes that affect this.

Feb 7 2023, 3:09 PM · User-Ryasmeen, Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), DBA, Patch-For-Review, MediaWiki-Parser, MobileFrontend

Feb 6 2023

DLynch moved T328955: TypeError: null is not an object (evaluating 'this.checkboxesByName.wpWatchthis') from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 6 2023, 10:55 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), VisualEditor, JavaScript, Wikimedia-production-error
DLynch moved T328955: TypeError: null is not an object (evaluating 'this.checkboxesByName.wpWatchthis') from Doing to Code Review on the Editing-team (Kanban Board) board.
Feb 6 2023, 10:00 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), VisualEditor, JavaScript, Wikimedia-production-error
DLynch moved T328955: TypeError: null is not an object (evaluating 'this.checkboxesByName.wpWatchthis') from Incoming to Doing on the Editing-team (Kanban Board) board.
Feb 6 2023, 9:57 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), VisualEditor, JavaScript, Wikimedia-production-error
DLynch claimed T328955: TypeError: null is not an object (evaluating 'this.checkboxesByName.wpWatchthis').
Feb 6 2023, 9:57 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), VisualEditor, JavaScript, Wikimedia-production-error
DLynch edited projects for T328955: TypeError: null is not an object (evaluating 'this.checkboxesByName.wpWatchthis'), added: VisualEditor; removed DiscussionTools.
Feb 6 2023, 9:51 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), VisualEditor, JavaScript, Wikimedia-production-error
DLynch added a comment to T328955: TypeError: null is not an object (evaluating 'this.checkboxesByName.wpWatchthis').

It's inside ve.init.mw.DesktopArticleTarget.prototype.onWatchToggle, and is pretty easy to trigger: watch/unwatch the page and then edit it. It doesn't handle the case of there already being something in the hook-queue and so it running before the page metadata has been parsed to setup the checkboxes.

Feb 6 2023, 9:51 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), VisualEditor, JavaScript, Wikimedia-production-error

Feb 3 2023

DLynch added a comment to T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks.

There's an issue open for it on Ace's repo, it seems: https://github.com/ajaxorg/ace/issues/5012

Feb 3 2023, 9:02 PM · Verified, Editing-team (Kanban Board), VisualEditor
DLynch renamed T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks from Visual Editor Math Formula insertion: cursor positioning incorrect to Visual Editor Ace text component: cursor positioning incorrect.
Feb 3 2023, 4:40 PM · Verified, Editing-team (Kanban Board), VisualEditor
DLynch added a comment to T328781: Visual Editor Ace text component: cursor positioning incorrect when editing math, code blocks.

This seems to specifically be related to the Ace editor component used in a MWAceEditorWidget, and seems to be tied to how the Ace editor is deciding how wide characters are. The line height seems to be off as well:

Feb 3 2023, 4:29 PM · Verified, Editing-team (Kanban Board), VisualEditor

Feb 2 2023

DLynch assigned T314596: Add instrumentation required to analyze engagement with talk page meta content (mobile) to MNeisler.

@MNeisler / @ppelberg that proposal-patch was done-and-launched last year, so I think this ticket just needs approval that it actually meets the not-written-yet requirements. :D

Feb 2 2023, 6:33 PM · Product-Analytics, Editing-team (Tracking), MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), DiscussionTools
DLynch moved T315730: Half of the edit summary missing from topic posted with the New Topic Tool after restoring autosave from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 2 2023, 5:51 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), DiscussionTools
DLynch moved T328094: "TypeError: Failed to construct 'URL': Invalid URL" from VisualEditor section edit link code from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

Patch is merging; we'll want to wait for this to roll out on the train and then for logging to actually happen, I assume.

Feb 2 2023, 3:55 PM · Skipped QA, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), JavaScript, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor, Wikimedia-production-error
DLynch moved T325578: Revise "Expand all sections" setting language from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 2 2023, 3:52 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Design, Editing-team (Kanban Board), DiscussionTools, MobileFrontend, Moderator-Tools-Team
DLynch merged T328629: Improve VisualEditor category suggestions to better handle capitalization into T59302: Suggest case insensitive results when searching for categories to add.
Feb 2 2023, 3:35 PM · Editing-team, VisualEditor, VisualEditor-MediaWiki
DLynch merged task T328629: Improve VisualEditor category suggestions to better handle capitalization into T59302: Suggest case insensitive results when searching for categories to add.
Feb 2 2023, 3:34 PM · VisualEditor

Feb 1 2023

DLynch moved T327443: Quotation marks in wiki editing: Toolbox/Special characters/Symbols for Slovenian from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 1 2023, 9:25 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), I18n, VisualEditor
DLynch added a comment to T328601: TypeError: Argument 2 passed to Parser::parse() must implement interface MediaWiki\Page\PageReference, null given, called in /srv/mediawiki/php-1.40.0-wmf.21/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbedd.

I'm immediately suspicious of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/803578/ (T309695) mostly because it was 5 days ago and is touching the precise argument that's erroring.

Feb 1 2023, 8:24 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), wdwb-tech, Wikidata, Maps (Kartographer), MediaWiki-extensions-WikibaseRepository, Wikimedia-production-error

Jan 31 2023

DLynch moved T328121: Vector 2022 full width toggle doesn't cause VE's surface to fire resize events from Code Review to Ready for Signoff on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
Jan 31 2023, 6:02 PM · Editing QA, Editing-team (Kanban Board), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022), VisualEditor
DLynch moved T328121: Vector 2022 full width toggle doesn't cause VE's surface to fire resize events from Incoming to Code Review on the Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 3) board.
Jan 31 2023, 4:14 PM · Editing QA, Editing-team (Kanban Board), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022), VisualEditor

Jan 30 2023

DLynch reassigned T321961: [Config Change] Start mobile DiscussionTools A/B test from DLynch to MNeisler.
Jan 30 2023, 6:16 PM · User-notice-archive, User-Ryasmeen, Sustainability (Incident Followup), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Editing-team (Kanban Board), Product-Analytics, Verified, DiscussionTools
DLynch added a comment to T321961: [Config Change] Start mobile DiscussionTools A/B test.

I think that following direct links would be the only way to make that happen, yes.

Jan 30 2023, 6:15 PM · User-notice-archive, User-Ryasmeen, Sustainability (Incident Followup), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Editing-team (Kanban Board), Product-Analytics, Verified, DiscussionTools
DLynch added a comment to T328121: Vector 2022 full width toggle doesn't cause VE's surface to fire resize events.

The same general issue as T300826, if we're tracking recurring patterns.

Jan 30 2023, 6:08 PM · Editing QA, Editing-team (Kanban Board), MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Desktop Improvements (Vector 2022), VisualEditor
DLynch added a comment to T327443: Quotation marks in wiki editing: Toolbox/Special characters/Symbols for Slovenian.

image.png (302×1 px, 82 KB)

Jan 30 2023, 5:48 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), I18n, VisualEditor
DLynch moved T327443: Quotation marks in wiki editing: Toolbox/Special characters/Symbols for Slovenian from Doing to Code Review on the Editing-team (Kanban Board) board.
Jan 30 2023, 5:44 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), I18n, VisualEditor
DLynch claimed T327443: Quotation marks in wiki editing: Toolbox/Special characters/Symbols for Slovenian.
Jan 30 2023, 5:44 PM · Verified, MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), Editing-team (Kanban Board), I18n, VisualEditor

Jan 26 2023

DLynch added a comment to T324363: Investigate sentence splitting.

Given that sentence splitting is (probably) going to need a server-side component, it might make sense for for us to make a prototype tool that can be thrown onto patchdemo and output some sort of visualization of an article and how it'd be split so we can get an idea of how viable this is for placement.

Jan 26 2023, 5:23 PM · Patch-For-Review, EditCheck, Editing-team (Kanban Board), Spike
DLynch added a comment to T327704: DiscussionTools: unable to save comment on metawiki with comment-became-transcluded error.

The template is sufficiently challenging to read that someone else might have better luck than me untangling what about it is leading to it not being closed...

Jan 26 2023, 4:58 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), Skipped QA, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T327704: DiscussionTools: unable to save comment on metawiki with comment-became-transcluded error.

I did a little bit of testing, and it's definitely related to having the {{Community Wishlist Survey/Proposal header|1=Auto-save feature}} template at the top of the page.

Jan 26 2023, 4:56 PM · MW-1.40-notes (1.40.0-wmf.20; 2023-01-23), Skipped QA, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T328041: Entering VisualEditor while a DT widget containing content is open prevents saving in VE.

@ppelberg I am, though it doesn't seem to happen on every pageload. It's possible it requires some state that I've not accounted for properly in the task description...

Jan 26 2023, 4:47 PM · VisualEditor, Editing-team, DiscussionTools
DLynch added a comment to T328041: Entering VisualEditor while a DT widget containing content is open prevents saving in VE.

I'd need to do a bit more testing to distinguish between this being ve.init.target not being replaced by the editor setup versus the DT autosave reinitializing it in the background and clobbering the editor's target.

Jan 26 2023, 4:42 PM · VisualEditor, Editing-team, DiscussionTools
DLynch created T328041: Entering VisualEditor while a DT widget containing content is open prevents saving in VE.
Jan 26 2023, 4:38 PM · VisualEditor, Editing-team, DiscussionTools
Krinkle awarded T327358: OOUI (and so things that use it, like DiscussionTools) should respect prefers-reduced-motion setting a Love token.
Jan 26 2023, 12:43 AM · Verified, Editing-team (Kanban Board), OOUI, Accessibility, DiscussionTools

Jan 25 2023

DLynch claimed T327358: OOUI (and so things that use it, like DiscussionTools) should respect prefers-reduced-motion setting.
Jan 25 2023, 4:12 PM · Verified, Editing-team (Kanban Board), OOUI, Accessibility, DiscussionTools

Jan 24 2023

DLynch added a comment to T324363: Investigate sentence splitting.

A complexity to bear in mind is that we're not splitting text, we're splitting either wikitext or HTML. This might cause some challenges around finding valid insertion points.

Jan 24 2023, 6:23 PM · Patch-For-Review, EditCheck, Editing-team (Kanban Board), Spike

Jan 23 2023

DLynch added a comment to T322682: Analyze blocked edit attempts.

I'd expect things to be heavily skewed towards blocks on loggedout wikieditor, because that's where all the automated crawlers are going to be hitting. e.g. a naïve spider crawling every link on wikipedia is going to hit the edit-link on every single page, and if its IP is blocked as many are.... Similarly, those spam scripts that just go around and try to submit every form they can find with links, etc.

Jan 23 2023, 7:07 PM · Product-Analytics (Kanban), Anti-Harassment
DLynch added a comment to T308511: [SPIKE] Determine necessity of edit session continuity during data center switchovers .

Is this task still needed? My impression was that the restbase switchover work is mostly-done? (And e.g. the referenced task in the description is closed, etc.)

Jan 23 2023, 4:38 PM · Editing-team (Kanban Board), VisualEditor

Jan 19 2023

DLynch added a comment to T327349: TypeError: mw.util.getTargetFromFragment is not a function .

It'd need to be a fairly extreme cache overreach -- that function was added back in fc96dcc9d966623821f2c802a0a1a6a91b7fbcb1 in August of last year.

Jan 19 2023, 4:58 PM · DiscussionTools, Wikimedia-production-error
DLynch added a comment to T327390: Vector 2022: edit preview is ignoring limited width choice (done by toggle or by Preferences).

Note: the new wikitext editor doesn't suffer from this, thanks to having a different preview mechanism.

Jan 19 2023, 4:11 PM · Editing-team, Desktop Improvements (Vector 2022)
DLynch added a comment to T327358: OOUI (and so things that use it, like DiscussionTools) should respect prefers-reduced-motion setting.

DiscussionTools' scrolling boils down to calling OO.ui.Element.static.scrollIntoView. It seems like the correct way to address this would be to update OOUI to only animate a scroll when prefers-reduced-motion isn't set. (But this might take a little investigation to make sure it doesn't break any cases where the animation is actually required?)

Jan 19 2023, 4:07 PM · Verified, Editing-team (Kanban Board), OOUI, Accessibility, DiscussionTools
DLynch added a comment to T327349: TypeError: mw.util.getTargetFromFragment is not a function .

Seems strange. The call to mw.util.getTargetFromFragment happens in highlighter.js, and that does list mediawiki.util as a dependency -- so absent some resourceloader bug or something like a gadget meddling with the globals, I don't think this error should be occurring.

Jan 19 2023, 3:54 PM · DiscussionTools, Wikimedia-production-error

Jan 17 2023

DLynch added a comment to T326500: The new talk pages should not send posts by pressing enter.

The explicit overrides we've done to standard behavior is to not submit the form if it doesn't pass validation (though technically you can also do that within HTML attributes; we're just doing it in JavaScript instead), and adding the meta-enter behavior to submit the form from within the multiline field.

Jan 17 2023, 8:29 PM · Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T326500: The new talk pages should not send posts by pressing enter.

@ppelberg We didn't do anything specifically about this, rather enter behaves consistently here with how it does in all HTML forms. (I.e. in multiline fields it adds a newline, otherwise it submits the form.) We can change that, but it's worth noting that it does depart from the generally expected behavior of the entire (browser) platform.

Jan 17 2023, 8:28 PM · Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T326946: CVE-2020-36649: PapaParse copy in VisualEditor.

I think it's only used in ve.ui.DSVFileTransferHandler, so it'll only trigger when an upload actually happens. I.e. you'd actually need to get someone to drag-drop a malicious file onto a VE window before this could be exploited.

Jan 17 2023, 6:45 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), Editing-team (Kanban Board), SecTeam-Processed, Vuln-VulnComponent, VisualEditor, Security, Security-Team

Jan 15 2023

DLynch added a comment to T327021: Signature containing only a contributions link not recognized by DiscussionTools.

It does work elsewhere with just the contributions link.

Jan 15 2023, 7:46 PM · MW-1.40-notes (1.40.0-wmf.19; 2023-01-16), Editing QA, Editing-team (Kanban Board), DiscussionTools

Jan 12 2023

DLynch added a comment to T321961: [Config Change] Start mobile DiscussionTools A/B test.

@Ryasmeen pointed out an issue with bucket assignment for logged out users that made me dig into it:

Jan 12 2023, 8:30 PM · User-notice-archive, User-Ryasmeen, Sustainability (Incident Followup), MW-1.40-notes (1.40.0-wmf.14; 2022-12-12), Editing-team (Kanban Board), Product-Analytics, Verified, DiscussionTools
DLynch renamed T311891: Gadget support: The editor should be capable of targeting editors of code via a message box from The editor should link to a reecommendations page for best practices and guidelines for building gadgets to The editor should link to a recommendations page for best practices and guidelines for building gadgets.
Jan 12 2023, 5:58 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), Readers-Web-Backlog (Web Team FY2022-23 Q3 Sprint 5), Navigation Restructure (Web), MW-1.39-notes (1.39.0-wmf.28; 2022-09-05), Patch-For-Review, Editing-team

Jan 9 2023

DLynch added a comment to T326484: Notes are missing.

I think it's references contained within templates not being added to the internal list. There should be 195 items in the internal list (194 references + 1 note), but there's actually only 189 in ve.init.target.surface.model.documentModel.internalList. There are six references in that article which are used entirely within templates (the infobox, and the review-scores template in the reception section), none of which are present in the internal list. (Which also throws the numbers off in e.g. the re-use dialog.)

Jan 9 2023, 5:25 PM · VisualEditor, Cite