Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (13)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (351 w, 1 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Wed, Jun 22

DLynch added a comment to T306176: Event tracking for Realtime Preview.

All looks fine to me. VisualEditorFeatureUse is very freeform; so long as you're avoiding collisions on the feature field and at least halfheartedly trying to match your action up with other semantically-equivalent ones, it's all good.

Wed, Jun 22, 6:39 PM · Community-Tech (CommTech-Sprint-27), Product-Analytics, Realtime-Preview-Wish-2021
DLynch added a comment to T307698: Add `platform` value to Android app editing data in EditAttemptStep .

There's a ticket for problems with platform already (T249944) which might be worth reviewing. (Basically: on web it currently just means "is MobileFrontend being used?" which is not necessarily what people would expect, and there's discussion of whether/how that should get changed.)

Wed, Jun 22, 6:36 PM · Product-Analytics (Kanban), Editing-team, Wikipedia-Android-App-Backlog (Android Release FY2021-22), Editing-Team-Request
DLynch updated subscribers of T310197: Move editing toolbar below page toolbar.

Poor DavidL suffers for my sins.

Wed, Jun 22, 4:27 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements

Fri, Jun 17

DLynch added a comment to T310833: Uploaded files via the drag-and-drop are defaulting to private-access.

I think it's mostly working as intended but is a fairly bad user experience and may have glitches.

Fri, Jun 17, 3:51 PM · Upstream, Phabricator (Upstream), User-brennen, Release-Engineering-Team

Thu, Jun 16

DLynch moved T307480: Modify VisualEditor to trigger a hook with sections data for table of contents re-rendering from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Jun 16, 5:30 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Skipped QA, DiscussionTools, Editing-team (FY2021-22 Kanban Board), VisualEditor

Wed, Jun 15

DLynch moved T298634: Track edit button clicks in sticky header in the EditAttemptStep schema from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jun 15, 7:57 AM · Editing QA, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Goal, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Desktop Improvements
DLynch moved T309364: Add URL parameter to trace WikiEditor edit sessions that originate via sticky header from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Jun 15, 7:57 AM · Editing QA, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Goal, Editing-team (FY2021-22 Kanban Board), WikiEditor
DLynch added a comment to T309260: Make EditAttemptStep sampling rate consistent with MobileWebUIActions and DesktopWebUI.

Can you confirm

Wed, Jun 15, 1:49 AM · Product-Analytics (Kanban), Patch-For-Review, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

Fri, Jun 10

DLynch added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

I'm not sure why lots don't have any mechanism recorded

It's because EditAttemptStep has a somewhat painful structure. The rows without an init_mechanism aren't inits, they're other types of event.

Fri, Jun 10, 4:36 PM · Community-Tech (CommTech-Sprint-27), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
DLynch added a comment to T310334: Topic subscription link absent on certain pages.

The enwiki one might be confusing because the first few sections don't contain any signed comments and so don't read as discussion sections to the parser.

Fri, Jun 10, 2:26 PM · DiscussionTools

Thu, Jun 9

DLynch added a comment to T309882: [Request] Standardize editor URls so that different editors should have unique URLs.
Thu, Jun 9, 6:42 PM · VisualEditor, Community-Tech, Editing-team
DLynch added a comment to T309882: [Request] Standardize editor URls so that different editors should have unique URLs.

Also worth considering that (in general) we'd like it if, when a link to an edit page is sent, the person following that link sees their own preferred editor rather than whichever editor was being used by the person who sent the link. Making more links which are editor-specific and don't respect the viewer's preferences seems like it'll decrease people getting their preferences respected.

Thu, Jun 9, 6:41 PM · VisualEditor, Community-Tech, Editing-team
DLynch added a comment to T307725: Make action=edit with 2010 wikitext editor a full-width page in Vector-2022.

This should hopefully be a rare case

Thu, Jun 9, 5:25 PM · Community-Tech (CommTech-Sprint-27), Editing-team, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Patch-For-Review, Desktop Improvements, Realtime-Preview-Wish-2021
DLynch updated subscribers of T113101: Images should be responsive in Vector and restrained to a max-size..

Copying over @Esanders' comment on the ticket that got this reverted:

Note that the VE surface approximately uses Parsoid HTML, which this change appears not to be compatible with. The selector seems scarily generic (.mw-parser-output img) so it should be tested against a wide range of content (e.g. galleries and other rich media extensions in both parsers) before merging it again.

Thu, Jun 9, 5:11 PM · Patch-For-Review, MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements, Design
DLynch added a comment to T309260: Make EditAttemptStep sampling rate consistent with MobileWebUIActions and DesktopWebUI.

That patch will synchronize the sampling rate in the UIActions schemas, EditAttemptStep, and VisualEditorFeature use all at 20% on the 9 partner wikis. I picked 20% because that's the rate the desktop-improvements wikis are set to, and there's no current separate config to have a different rate between desktop and mobile for EditAttemptStep so lining everything up with the highest one was easiest. It does mean that EditAttemptStep will be sampling at higher than its normal 1/16 rate, and the MobileUIActions will be sampling at double their normal 10% rate on those wikis.

Thu, Jun 9, 4:39 AM · Product-Analytics (Kanban), Patch-For-Review, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
DLynch added a comment to T303654: [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas.

@ppelberg Yes. None of those require a change to the sampling method, as they don't involve VE/WikiEditor. Those can all be logged via EditAttemptStep or the UIActions schemas.

Thu, Jun 9, 4:20 AM · User-Ryasmeen, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

Wed, Jun 8

DLynch added a comment to T310197: Move editing toolbar below page toolbar.

As well as the mode-switching, it also currently blocks the ability to quickly access the talk page or edit history (you'd have to leave edit mode in a fairly undiscoverable way, before you could reach any of those), both of which are useful during edits.

Wed, Jun 8, 11:55 PM · MW-1.39-notes (1.39.0-wmf.18; 2022-06-27), Patch-For-Review, Readers-Web-Backlog (Kanbanana-FY-2021-22), Desktop Improvements
DLynch added a comment to T309364: Add URL parameter to trace WikiEditor edit sessions that originate via sticky header.

@Jdlrobson Yeah, applying such a parameter generically to all edit links would be usable for this. So long as there's something indicating the source, it'll be sufficient. It doesn't matter for this ticket whether the links are unique to the type of editor or not, though.

Wed, Jun 8, 8:38 PM · Editing QA, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Goal, Editing-team (FY2021-22 Kanban Board), WikiEditor
DLynch added a comment to T310194: Relative timestamps do not update while the page is open.

I wonder if this'd be better addressed as some sort of mediawiki-wide fix? Anything with e.g. <span class="mw-relative-time" data-ts="123443432"> would get updated by some site-wide JS, extensions and pages wouldn't need to independently implement it, and users wouldn't have to remember which pages have this behavior and which don't...

Wed, Jun 8, 4:29 PM · Editing-team, DiscussionTools

Tue, Jun 7

DLynch added a comment to T309364: Add URL parameter to trace WikiEditor edit sessions that originate via sticky header.

@Jdlrobson No, because it wouldn't distinguish between links from the sticky header and the tabs -- it's still the same editor, just a different route taken to reach it.

Tue, Jun 7, 5:09 PM · Editing QA, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Goal, Editing-team (FY2021-22 Kanban Board), WikiEditor

Fri, Jun 3

DLynch added a comment to T309839: Echo web watchlist notifications should not include Flow or DiscussionTools.

I'll note that it's not going to be possible to catch all edits that will send DiscussionTools notifications, because they're generated from Echo's post-save deferredupdate by parsing new revisions for comments. Thus it also sends notifications when people edit via WikiEditor and so don't use the new tools at all.

Fri, Jun 3, 3:10 PM · Patch-For-Review, Growth community maintenance, Growth-Team (Current Sprint), Notifications

Wed, Jun 1

DLynch added a comment to T304030: Implement Topic Subscriptions A/B test bucketing.

1 On the task description, it mentions after logging into Beta Cluster, "Verify you have been assigned to the test or control group.

Wed, Jun 1, 1:10 AM · User-Ryasmeen, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Product-Analytics, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Thu, May 26

DLynch added a comment to T295490: Make click tracking work on reply tool talk page.

I'm pretty sure none of this should be going into that schema. Adding the data-event-name attribute should, as I understand what Jon said, make this all get logged into the MobileWebUIActions schema.

Thu, May 26, 5:17 PM · MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Editing QA, Goal, Editing-team (FY2021-22 Kanban Board), Mobile, DiscussionTools, OWC2020

May 23 2022

DLynch added a comment to T307603: User talk message notifications from notifications API does not encode link fragments.

I had the impression that the normal flow of calling Title->getFullURL (as DiscussionTools is doing) is supposed to escape the fragment. Presumably there's some chain of circumstances which is bypassing that...

May 23 2022, 4:48 PM · iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon, DiscussionTools, Growth-Team, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

May 20 2022

DLynch moved T302515: Unexpected DB insert from DiscussionTools::determineUserABTestBucket during GET request from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.

This is server-side warning-logging, so QA can't really check it easily.

May 20 2022, 10:19 PM · Skipped QA, Editing-team (FY2021-22 Kanban Board), Performance-Team (Radar), DiscussionTools, Performance Issue
DLynch added a comment to T306176: Event tracking for Realtime Preview.

I'm not sure how a time duration value should be stored. Perhaps there's an existing system for this sort of thing, or perhaps we can extract this info from other existing logs (e.g. the parse API? although of course that'd include other usages).

May 20 2022, 8:51 PM · Community-Tech (CommTech-Sprint-27), Product-Analytics, Realtime-Preview-Wish-2021

May 19 2022

DLynch moved T302515: Unexpected DB insert from DiscussionTools::determineUserABTestBucket during GET request from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
May 19 2022, 6:22 AM · Skipped QA, Editing-team (FY2021-22 Kanban Board), Performance-Team (Radar), DiscussionTools, Performance Issue
DLynch moved T304030: Implement Topic Subscriptions A/B test bucketing from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
May 19 2022, 6:22 AM · User-Ryasmeen, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Product-Analytics, Editing-team (FY2021-22 Kanban Board), DiscussionTools

May 18 2022

DLynch added a comment to T303654: [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas.

To clarify, do we anticipate this synchronization to cause any changes to the UIActions schema's current sampling rates?

May 18 2022, 7:02 PM · User-Ryasmeen, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

May 17 2022

DLynch moved T307995: It's possible to tab from the location bar to elements in the document behind any OOUI modal dialog from Incoming to QA on the Editing-team (FY2021-22 Kanban Board) board.
May 17 2022, 7:40 PM · WMDE-TechWish-Sprint-2022-06-22, WMDE-TechWish-Sprint-2022-06-08, WMDE-TechWish-Sprint-2022-05-25, Editing-team (FY2021-22 Kanban Board), Accessibility, OOUI, WMDE-TechWish-Sprint-2022-05-11, VisualEditor
DLynch edited projects for T307995: It's possible to tab from the location bar to elements in the document behind any OOUI modal dialog, added: Editing QA, Editing-team (FY2021-22 Kanban Board); removed Editing-team.
May 17 2022, 7:40 PM · WMDE-TechWish-Sprint-2022-06-22, WMDE-TechWish-Sprint-2022-06-08, WMDE-TechWish-Sprint-2022-05-25, Editing-team (FY2021-22 Kanban Board), Accessibility, OOUI, WMDE-TechWish-Sprint-2022-05-11, VisualEditor
DLynch moved T308448: Comment not recognized for no obvious reason from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
May 17 2022, 7:30 PM · Verified, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T308560: Map is broken after adding a line manually in VE.

Sounds like we might want to fix whatever parsing is happening inside the code running on maps.wikimedia.org -- it should probably treat an empty properties object the same as an entirely absent one.

May 17 2022, 4:03 PM · MW-1.39-notes (1.39.0-wmf.16; 2022-06-13), WMDE-TechWish-Sprint-2022-06-08, WMDE-TechWish-Sprint-2022-05-25, VisualEditor, WMDE-GeoInfo-FocusArea
DLynch added a comment to T302515: Unexpected DB insert from DiscussionTools::determineUserABTestBucket during GET request.

It looks like for T304030, we want to include every logged-in user in the test, so we might be able to just remove the preference stuff entirely, and compute the bucket from the user ID every time.

May 17 2022, 2:11 PM · Skipped QA, Editing-team (FY2021-22 Kanban Board), Performance-Team (Radar), DiscussionTools, Performance Issue

May 13 2022

DLynch renamed T307995: It's possible to tab from the location bar to elements in the document behind any OOUI modal dialog from It's possible to tab to elements in the document behind any VisualEditor dialog to It's possible to tab from the location bar to elements in the document behind any VisualEditor dialog.
May 13 2022, 7:36 PM · WMDE-TechWish-Sprint-2022-06-22, WMDE-TechWish-Sprint-2022-06-08, WMDE-TechWish-Sprint-2022-05-25, Editing-team (FY2021-22 Kanban Board), Accessibility, OOUI, WMDE-TechWish-Sprint-2022-05-11, VisualEditor

May 12 2022

DLynch added a comment to T308200: Remove keyboard shortcut helper text from mobile DiscussionTools dropdowns.

A more-sensible behavior than we have now would probably be to hide the shortcuts on phone screens (which have limited space), but show them on tablets (which have more space, and are more likely to have a keyboard available).

May 12 2022, 8:34 PM · Verified, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
DLynch added a comment to T308200: Remove keyboard shortcut helper text from mobile DiscussionTools dropdowns.

Hm, fair point. We should probably be consistent. Given that apparently some actual mobile on-screen keyboards are gaining modifier keys, the argument for being consistent in the other direction isn't a bad one now, though -- stronger than it was back in 2018, anyway.

May 12 2022, 7:54 PM · Verified, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
DLynch added a comment to T308259: Intermittent main thread pauses in Visual Editor on specific page.

Their "issues affecting wikipedia" ticket, is a way to keep an eye on progress here, we'd hope: https://bugs.chromium.org/p/chromium/issues/detail?id=463348

May 12 2022, 4:43 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T308259: Intermittent main thread pauses in Visual Editor on specific page.

Chrome has had some issues with spellchecking in contenteditable elements in recent versions -- they merged one fix back in v97, but it's either not completely fixed or has reemerged since then. We're working on seeing what they can do about it.

May 12 2022, 4:41 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T308259: Intermittent main thread pauses in Visual Editor on specific page.

Could you check whether turning off "check spelling while typing" fixes this? (In the browser's Edit > Spelling and Grammar menu.)

May 12 2022, 4:34 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T307640: Add page view token to UIAction schemas.

Rebasing required: T306648 just made its own changes to the UIActions schemas, so I'm going to have to put everything back on top of that.

May 12 2022, 3:56 PM · User-Ryasmeen, Editing-team (Tracking), MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Product-Analytics (Kanban), Goal, DiscussionTools
DLynch moved T308198: Following the "log in" or "create an account" links in reply tool not-logged-in warning loses extra URL parameters from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
May 12 2022, 3:23 PM · Verified, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T308200: Remove keyboard shortcut helper text from mobile DiscussionTools dropdowns.

I clicked in to say what Tacsipacsi did. If you're on a mobile device with a keyboard you can use them. Fairly common example would be an iPad with a keyboard-cover, but you can pair a bluetooth keyboard with basically-anything.

May 12 2022, 3:20 PM · Verified, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
DLynch added a comment to T308196: Add button to remove empty parameters.

I think the trash button going away was one of the WMDE changes that just went out via config.

May 12 2022, 1:23 AM · WMDE-Templates-FocusArea, VisualEditor-MediaWiki-Templates, VisualEditor

May 11 2022

DLynch moved T307410: [Config Change] Enable the New Topic Tool as opt-out at A/B test wikis from Doing to QA on the Editing-team (FY2021-22 Kanban Board) board.
May 11 2022, 10:45 PM · Verified, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
DLynch added a comment to T307727: [SPIKE] Decide on approach to potential differences in namespace and page title font heights .

Breakdown 1 is a lot more accurate. In breakdown 2, viewing the namespace part as a "label" feels like it carries incorrect implications to me -- the namespace is an important part of the page name not a separate thing. Particularly when you're dealing with namespaced pages that aren't in a talk namespace -- every talk/user_talk/project_talk/etc_talk page is implicitly paired with a non-talk page, and "Wikipedia:Something" isn't necessarily related in any way to "Something".

May 11 2022, 5:21 PM · Design, Editing-team, DiscussionTools, OWC2020
DLynch reassigned T304148: Scrollbars appear in popup on Minerva from cjming to Esanders.
May 11 2022, 4:40 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Anti-Harassment (AHaT Sprint 8: The Flat Cap), Readers-Web-Backlog (Kanbanana-FY-2021-22), MinervaNeue (Desktop), Patch-For-Review, IP Info
DLynch added a project to T307995: It's possible to tab from the location bar to elements in the document behind any OOUI modal dialog: OOUI.
May 11 2022, 2:47 PM · WMDE-TechWish-Sprint-2022-06-22, WMDE-TechWish-Sprint-2022-06-08, WMDE-TechWish-Sprint-2022-05-25, Editing-team (FY2021-22 Kanban Board), Accessibility, OOUI, WMDE-TechWish-Sprint-2022-05-11, VisualEditor

May 10 2022

DLynch added a comment to T304856: Ensure talk page comments that are not signed are visible in apps.

My understanding is that the outcome of various discussions is that we've committed to providing the contents of sections that don't contain any comments.

May 10 2022, 5:32 PM · Skipped QA, MW-1.39-notes (1.39.0-wmf.15; 2022-06-06), Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog
DLynch reassigned T298634: Track edit button clicks in sticky header in the EditAttemptStep schema from DLynch to MNeisler.
May 10 2022, 4:25 PM · Editing QA, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Goal, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Desktop Improvements
DLynch added a comment to T308029: Usability Problem: Make search for users using the @mention feature a more obvious affordance.

Seems challenging, because we're at a fairly industry-standard functionality for the tool. (i.e. it works about how, say, twitter's or phabricator's equivalents do.) The autocomplete also works about the same way as those -- pressing space moves on, pressing tab completes.

May 10 2022, 2:55 PM · Design, DiscussionTools
DLynch added a comment to T308026: Make mobile Topic Containers easier for people to parse.

Uncollapsing only one might just make it so that's the only section they think exist. I continue my staunch support for having everything uncollapsed by default!

May 10 2022, 2:52 PM · Goal, Editing-team (FY2021-22 Kanban Board), Design, DiscussionTools
DLynch added a comment to T308024: Usability Problem: Consider a different icon for switching modes in mobile .

Same icon's used on desktop as well -- this seems like it'd need to be a far-reaching change?

May 10 2022, 2:50 PM · Editing-team (Design Backlog), VisualEditor-MediaWiki-Mobile, Editing Design, VisualEditor
DLynch added a comment to T307995: It's possible to tab from the location bar to elements in the document behind any OOUI modal dialog.

For what it's worth, focus is contained to the dialog when it's open -- tabbing past the end of the elements in the dialog will send you back to the first element in the dialog, and vice versa. (I'll grant that I don't know to what extent accessibility tools could be used to bypass this. But regular keyboard navigation can't escape.)

May 10 2022, 2:46 PM · WMDE-TechWish-Sprint-2022-06-22, WMDE-TechWish-Sprint-2022-06-08, WMDE-TechWish-Sprint-2022-05-25, Editing-team (FY2021-22 Kanban Board), Accessibility, OOUI, WMDE-TechWish-Sprint-2022-05-11, VisualEditor
DLynch added a project to T307994: Make all VE maps dialog interactive elements reachable by tab key: OOUI.

This is a OOUI TabSelectWidget question, more than something VE-specific. As it works currently, you focus the widget, and then you can navigate between tabs with arrow keys (i.e. this is keyboard-reachable, with the right mental model). I'm sure this behavior is changeable, but we should watch out for side effects in various places that're using TabSelectWidget.

May 10 2022, 2:39 PM · WMDE-TechWish-Sprint-2022-05-11, OOUI, Maps (Kartographer), VisualEditor, WMDE-TechWish, WMDE-GeoInfo-FocusArea
DLynch added a comment to T219420: Update page dynamically after save on mobile.

@mewoph the remaining two patches will immediately enable the new behavior. There's not any config for it, it just changes how things behave.

May 10 2022, 2:34 PM · Verified, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Growth-Team, Editing-team (FY2021-22 Kanban Board), MobileFrontend, Performance Issue, VisualEditor, VisualEditor-MediaWiki-Mobile

May 9 2022

DLynch moved T307807: "New comments" highlighted while drafting should be dismissible by clicking from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
May 9 2022, 5:21 PM · Verified, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a project to T307875: Visual diff does not load: TypeError: Cannot read properties of undefined (reading 'forEach'): Editing QA.
May 9 2022, 2:43 PM · Verified, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing-team (FY2021-22 Kanban Board), VisualEditor

May 8 2022

DLynch updated subscribers of T307875: Visual diff does not load: TypeError: Cannot read properties of undefined (reading 'forEach').

Interesting, I think this could maybe be something to do with the recent translate annotations changes, insofar as this is the element that it's erroring on:

image.png (402×1 px, 100 KB)

May 8 2022, 7:14 PM · Verified, MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing-team (FY2021-22 Kanban Board), VisualEditor

May 6 2022

DLynch added a comment to T307640: Add page view token to UIAction schemas.

It's possible to correlate a page view logged in DesktopWebUIActions or MobileWebUIactions with any corresponding edit events (both page and discussiontool related events) that occur on the same page load logged in EditAttemptStep.

May 6 2022, 4:11 PM · User-Ryasmeen, Editing-team (Tracking), MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Product-Analytics (Kanban), Goal, DiscussionTools

May 5 2022

DLynch added a comment to T307698: Add `platform` value to Android app editing data in EditAttemptStep .

Isn't integration=app-android already a perfectly-distinguishing method of filtering for Android app edits? I don't understand why you'd need to do anything else.

May 5 2022, 11:14 PM · Product-Analytics (Kanban), Editing-team, Wikipedia-Android-App-Backlog (Android Release FY2021-22), Editing-Team-Request
DLynch added a comment to T305261: Mobile talk page empty state layout displays unexpectedly .

Actually, it's more likely that DiscussionTools is enabled but those pages aren't empty (as-in "not yet created, redlinks").

May 5 2022, 4:55 PM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T307640: Add page view token to UIAction schemas.

Those patches add a new field to both UIActions schemas called pageToken. It contains the same value from mw.user.getPageviewToken() that's logged in EditAttemptStep as page_token.

May 5 2022, 3:46 AM · User-Ryasmeen, Editing-team (Tracking), MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Product-Analytics (Kanban), Goal, DiscussionTools
DLynch added a comment to T303654: [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas.

@ppelberg Yes, that sounds correct.

May 5 2022, 2:48 AM · User-Ryasmeen, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

May 4 2022

DLynch added a comment to T298634: Track edit button clicks in sticky header in the EditAttemptStep schema.

This can be easily tracked for anything but WikiEditor -- it's logged server-side and wouldn't be distinguishable there from coming via existing methods, unless we add some otherwise-superfluous tracking parameters to the URLs.

May 4 2022, 8:40 PM · Editing QA, MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), Goal, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Desktop Improvements
DLynch added a comment to T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).

An argument for the blob-of-HTML method is that it lets DiscussionTools adding metadata to the ToC work without the client-side code needing to know about that.

May 4 2022, 5:09 PM · Patch-For-Review, VisualEditor, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
DLynch added a comment to T304030: Implement Topic Subscriptions A/B test bucketing.

To be clear, "People who have used [i] Topic Subscriptions prior to the A/B test beginning." in the requirements just means also-including them, not only-including them?

May 4 2022, 4:45 PM · User-Ryasmeen, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Product-Analytics, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch merged T304035: [SPIKE] Investigate practicality of making sampling rate consistent across *desktop* talk page schemas into T303654: [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas.
May 4 2022, 4:42 PM · User-Ryasmeen, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
DLynch merged task T304035: [SPIKE] Investigate practicality of making sampling rate consistent across *desktop* talk page schemas into T303654: [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas.
May 4 2022, 4:41 PM · Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
DLynch moved T307527: Small (but visible) templates shown with the icon meant for invisible templates from Backlog to Done on the VisualEditor-MediaWiki board.
May 4 2022, 4:06 PM · Verified, MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Editing-team (FY2021-22 Kanban Board), VisualEditor, VisualEditor-MediaWiki
DLynch updated subscribers of T306440: Add markup to article headings to distinguish between the namespace and the title.

@Jdlrobson I think it'd be a step towards it, at least from a display perspective -- it wouldn't help with the referenced translation concerns at all. It'd let the communities override the display via CSS, certainly, either to hide it entirely or to relocate it a bit. Though, that would make it easier to realize @Quiddity's concern about breaking the copy-paste workflows, but at least it'd be a community-chosen thing that we wouldn't have inherently pushed upon people (and e.g. in DiscussionTools we're making it *look* like there's a space, but it'll still copy just fine).

May 4 2022, 3:48 PM · Design, Editing-team, Patch-For-Review, MediaWiki-Core-Skin-Architecture

May 2 2022

DLynch added a comment to T305261: Mobile talk page empty state layout displays unexpectedly .

The smaller buttons aren't the empty-state. Those are ones where the discussion tool isn't enabled.

May 2 2022, 11:43 PM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T306705: Images are no longer displayed on mobile edit preview from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
May 2 2022, 5:29 PM · User-Ryasmeen, Editing QA, Verified, Editing-team (FY2021-22 Kanban Board), MobileFrontend (MobileFrontend (Editor)), Regression, Readers-Web-Backlog
DLynch added a comment to T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).

Assuming you mean the classic WikiEditor previews, yeah, that's a whole different editor than this task is talking about, which would presumably require a very different solution.

May 2 2022, 3:25 PM · Patch-For-Review, VisualEditor, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)
DLynch renamed T304036: [SPIKE] Investigate how sessionID is used in various schemas on talk pages from [SPIKE] Investigate how sessionID is used in various *desktop* talk page schemas to [SPIKE] Investigate how sessionID is used in various schemas on talk pages.
May 2 2022, 3:19 PM · User-Ryasmeen, Editing-team (FY2021-22 Kanban Board), Product-Analytics, Editing Design, DiscussionTools, OWC2020
DLynch merged T303653: [SPIKE] Investigate how sessionID is used in various *mobile* talk page schemas into T304036: [SPIKE] Investigate how sessionID is used in various schemas on talk pages.
May 2 2022, 3:19 PM · User-Ryasmeen, Editing-team (FY2021-22 Kanban Board), Product-Analytics, Editing Design, DiscussionTools, OWC2020
DLynch merged task T303653: [SPIKE] Investigate how sessionID is used in various *mobile* talk page schemas into T304036: [SPIKE] Investigate how sessionID is used in various schemas on talk pages.
May 2 2022, 3:18 PM · Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
DLynch added a comment to T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).

as far as I can tell this issue occurs when I'm editing in VE, or in the source editor shown below:

Yeah, that's the 2017 wikitext editor, which is based on VE.

May 2 2022, 2:55 PM · Patch-For-Review, VisualEditor, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Apr 30 2022

DLynch added a comment to T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).

Further clarification: I (naïvely) think that this should be happening in the editing modes based on VisualEditor (VE itself, and the 2017 wikitext editor), but not on classic WikiEditor. This is because the VE-based modes do an inline replacement of the article contents, while anything using the classic EditPage-based methods does a full page reload.

Apr 30 2022, 12:05 AM · Patch-For-Review, VisualEditor, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Apr 29 2022

DLynch added a comment to T307251: [ToC] Show new/modified sections after publishing an edit (new floating ToC).

This is specifically referring to the new Vector floating TOC, right? Or are you also seeing this on the traditional inline TOC?

Apr 29 2022, 7:30 PM · Patch-For-Review, VisualEditor, Desktop Improvements, Readers-Web-Backlog (Kanbanana-FY-2021-22)

Apr 27 2022

DLynch added a comment to T303995: Instrument blocked account registration and edit attempts .

For editing, I guess we'd want to settle on a definition of "edit attempt" for this. If we're okay with "viewed an edit page while blocked", it's probably doable. If we want it to be comparable to other logging of edit attempts, we'd probably want to do all the logs from the client-side.

Apr 27 2022, 9:51 PM · Editing-team (Tracking), VisualEditor, Anti-Harassment, Product-Analytics, Growth-Team
DLynch moved T291873: Deploy config change to "turn off" New Discussion Tool A/B test from Doing to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.

This has been deployed.

Apr 27 2022, 8:06 PM · Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
DLynch added a comment to T300560: Design persistent notification for when new comments are posted while drafting a reply.

Agreed that it's not obvious what clicking the button will do (or that it's a clickable-button), and since it's a fairly disruptive action (triggering a reload/refresh and viewport movement), it might be good to hint to users somehow what would occur. The real time preview project has a similar use case for a manual-refresh button in their preview UI, so it might be an opportunity to share some design cues?

Apr 27 2022, 4:42 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Editing QA, Design, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools

Apr 26 2022

DLynch moved T291873: Deploy config change to "turn off" New Discussion Tool A/B test from Ready to Be Worked On to Doing on the Editing-team (FY2021-22 Kanban Board) board.

I'll schedule this for a backport this week.

Apr 26 2022, 4:45 PM · Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020

Apr 25 2022

DLynch added a comment to T299772: Make MobileFrontend signal the user is viewing the mobile version of the site.

To spell out the solution: that patch added mw-mf as a class on the body element, which will only be present if the site is in MobileFrontend mode (regardless of skins, etc). Anything that wants a binary "is MF active" can check for that, and TemplateStyles can hang themselves from it.

Apr 25 2022, 5:42 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Readers-Web-Backlog (Kanbanana-FY-2021-22), Metrics-Platform, MobileFrontend
DLynch moved T290803: Duplicate notifications if a topic is archived by a user who posted in it from QA to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Apr 25 2022, 5:25 PM · Verified, MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Apr 21 2022

DLynch added a comment to T305261: Mobile talk page empty state layout displays unexpectedly .

Button width = is it possible to have the button width match the text width?

You mean the text around it, not the text inside it, right? It could be made to do so.

Apr 21 2022, 10:20 PM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T305261: Mobile talk page empty state layout displays unexpectedly from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Apr 21 2022, 4:16 PM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T305261: Mobile talk page empty state layout displays unexpectedly .

Patch is updated, it'll look like this:

image.png (1×734 px, 130 KB)

Apr 21 2022, 4:13 PM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T305541: Investigate instances of successfully posted comments without an associated logged saveSuccess event in EditAttemptStep.

Is the 502 Error something to worry about?

Apr 21 2022, 3:47 PM · Verified, MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), DiscussionTools, Editing-team (FY2021-22 Kanban Board), Product-Analytics

Apr 18 2022

DLynch added a comment to T304187: Introduce button for starting new topics within sticky header.

With that change, should we also change the "meta" requirements in the description? My impression of the outcome of that discussion was that we were, essentially, going to be putting the "add topic" button into the sticky header in New Vector regardless of any DT involvement (i.e. whenever it would appear in the page tabs, it'd also be in the header), but the current description still has it gated behind the visual enhancements preference and only on certain namespaces.

Apr 18 2022, 9:39 PM · Design, Editing-team, Desktop Improvements, Editing Design, DiscussionTools
DLynch added a comment to T304036: [SPIKE] Investigate how sessionID is used in various schemas on talk pages.

Is there a page_token within talk_page_edit or can this be easily added?

Apr 18 2022, 3:38 PM · User-Ryasmeen, Editing-team (FY2021-22 Kanban Board), Product-Analytics, Editing Design, DiscussionTools, OWC2020

Apr 15 2022

DLynch added a comment to T305261: Mobile talk page empty state layout displays unexpectedly .

For completeness sake, here's your own user talk page:

image.png (1×726 px, 129 KB)

Apr 15 2022, 12:12 AM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T305261: Mobile talk page empty state layout displays unexpectedly .

Patch has been updated from Jess' comments. Button's correct now, and the image has been adjusted to be smaller and below said button:

image.png (1×734 px, 162 KB)

Apr 15 2022, 12:10 AM · Verified, MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Apr 14 2022

DLynch added a comment to T303653: [SPIKE] Investigate how sessionID is used in various *mobile* talk page schemas.

My comment about the desktop also entirely applies to here: T304036#7856122

Apr 14 2022, 6:11 PM · Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
DLynch added a comment to T304036: [SPIKE] Investigate how sessionID is used in various schemas on talk pages.

Quick definition: I'm going to use "editing schemas" to refer to EditAttemptStep, VisualEditorFeatureUse, and talk_page_edit, and "UIActions schemas" to refer to DesktopWebUIActions and MobileWebUIActions.

Apr 14 2022, 6:10 PM · User-Ryasmeen, Editing-team (FY2021-22 Kanban Board), Product-Analytics, Editing Design, DiscussionTools, OWC2020
DLynch added a comment to T304035: [SPIKE] Investigate practicality of making sampling rate consistent across *desktop* talk page schemas.

My comment in T303654#7856027 applies to this as well. Summary: if we set the sample rates the same in config, this should work.

Apr 14 2022, 5:44 PM · Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
DLynch added a comment to T303654: [SPIKE] Investigate practicality of making sampling rate consistent across mobile talk page schemas.

Conveniently: everything about whether or not to log in both desktop and mobile DiscussionTools (assuming nothing triggering oversampling is present), and also the UIActions schemas, goes through mw.eventLog.inSample. Because of how this works, using a global "pageload token" as the sampling ID, any events with the same sampling rate on the same pageload are going to be sampled the same.

Apr 14 2022, 5:43 PM · User-Ryasmeen, Product-Analytics, Editing-team (FY2021-22 Kanban Board), Goal, DiscussionTools
DLynch added a comment to T305541: Investigate instances of successfully posted comments without an associated logged saveSuccess event in EditAttemptStep.

@EAkinloose that screenshot cuts off halfway through the event before where I'd expect saveSuccess to be -- is that because nothing followed it?

Apr 14 2022, 4:41 PM · Verified, MW-1.39-notes (1.39.0-wmf.7; 2022-04-11), DiscussionTools, Editing-team (FY2021-22 Kanban Board), Product-Analytics
DLynch added a comment to T305491: Deprecate/delete the mw.eventLog.Schema class.

Your codesearch is missing things -- it's used in MobileFrontend in schemaEditAttemptStep.js and schemaVisualEditorFeatureUse.js, and also in DiscussionTools.

Apr 14 2022, 4:02 PM · Patch-For-Review, Readers-Web-Backlog (Needs Prioritization (Tech)), Data-Engineering, MediaWiki-extensions-EventLogging