DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (159 w, 4 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Fri, Oct 19

DLynch added a comment to T198511: VisualEditor losing Media: links.

@rakekniven Sorry, I was talking about deployment-to-wikipedia more than about proper parsoid releases.

Fri, Oct 19, 3:55 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Thu, Oct 18

DLynch added a comment to T198511: VisualEditor losing Media: links.

@Deskana: It should fix any future mangling of Media: links. (Given: that the new parsoid release is deployed, which I believe it is.)

Thu, Oct 18, 5:17 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.

Yes, this'll only happen with the app installed. It also then requires doing something that iOS considers intentionally accessing wikipedia in Safari, so as to not have the app automatically take over the request. (There are reasons to do this, of course; mostly edit-actions which the app doesn't provide.)

Thu, Oct 18, 2:48 AM · Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile

Wed, Oct 17

DLynch moved T206829: Lack of next steps for new users on mobile devices when attempting to edit a protected page from To Triage to Needs Discussion on the VisualEditor board.
Wed, Oct 17, 4:04 PM · Readers-Web-Backlog (Design), MediaWiki-Page-protection, Wikipedia-iOS-App-Backlog, VisualEditor, MobileFrontend, Mobile

Tue, Oct 16

DLynch added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.

@pmiazga / @Jdlrobson: MobileFrontend makes sense because its where some compensating CSS would need to be. As I said earlier, I don't think we can stop the banner appearing. (At least, not without the iOS app losing its entire ability to intercept links.)

Tue, Oct 16, 3:36 PM · Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile

Thu, Oct 11

DLynch added a project to T206774: iOS Universal Links banner pushes toasts partially off-screen: iOS-app-Bugs.

Adding the iOS project here, in case there's anything configurable there for Universal Links which could avoid this. (I suspect not, given that my specific example is on an article page, and that's probably the most-reasonable place to hook into. But just in case...)

Thu, Oct 11, 4:55 PM · Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile
DLynch created T206774: iOS Universal Links banner pushes toasts partially off-screen.
Thu, Oct 11, 4:39 PM · Readers-Web-Backlog, Wikipedia-iOS-App-Backlog, iOS-app-Bugs, Mobile

Wed, Oct 10

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

@Deskana: Sorry, we kinda answered that on the call yesterday, but putting it here for documentation and expansion... there's a patch for the actual instrumentation, and another for adding the schema to the events extension so we can use it. Once both of those are there, one last patch will actually hook up the logging in the MW-VE extension itself. (It can't go in with the WikimediaEvents patch, since it needs access to the session ID which the VE extension generates and doesn't expose...)

Wed, Oct 10, 4:28 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Wed, Oct 3

DLynch added a comment to T203136: Develop new schema for editing feature usage.

Currently it will track:

Wed, Oct 3, 4:24 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Tue, Oct 2

DLynch added a comment to T202147: Snapshot: which parts of the edit process cause people to abort edits?.

Might need to scope this one down to desktop-only, just because of the memory eviction behavior on mobile browsers potentially being difficult to account for?

Tue, Oct 2, 4:45 PM · VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics

Mon, Oct 1

RandomDSdevel awarded T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype a Haypence token.
Mon, Oct 1, 1:05 AM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Mon, Sep 24

DLynch added a comment to T205309: 2017 wikitext editor emits many ready events with platform "other".

I'd suspect this is going to be T205241, which @Esanders just put up a patch for.

Mon, Sep 24, 5:05 PM · VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T205161: 2010 wikitext editor does not log timings for most Edit events.

Looks like client-side events get timings, server side ones don't. In fairness... this is tricky.

Mon, Sep 24, 4:58 PM · VisualEditor, WikiEditor, Product-Analytics, Contributors-Analysis

Sep 19 2018

DLynch added a comment to T138683: Whitespace inside HTML comments in transclusion parameters are lost on editing(?).

Though do note, I think this'll still happen if it's a comment next to any more-specific TemplateData type. I.e. a comment after a boolean is going to get thrown away because the value will get coerced into a checkbox, etc.

Sep 19 2018, 5:05 PM · VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor, Parsoid

Sep 18 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

It's because those sessions stick a confirmation dialog in the middle of the loading process, between init and ready, and pause the process until the user chooses what to do with their autosave. Since most of this stuff was added for us to do performance testing, introducing a fairly randomly large delay into the timing there would throw the numbers off.

Sep 18 2018, 6:47 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Oh, thing to consider with this: we explicitly disable tracking for any session where we have to ask about restoring the autosave (i.e. any session where a new revision has been made since the autosave happened).

Sep 18 2018, 4:59 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Auto-save could go in the other schema (for editor life cycle events)

Sep 18 2018, 2:47 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Sep 17 2018

DLynch added a comment to T203618: Visual editor emits many init events with platform "other".

@Ryasmeen Sort of. You could paste this into your browser console:

Sep 17 2018, 2:20 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Sep 13 2018

DLynch claimed T190191: Line-breaks between list-items in template parameters are removed.
Sep 13 2018, 3:37 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)

Sep 12 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Useful thing Ed suggested in meeting: auto-save recovery?

Sep 12 2018, 5:35 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Sep 6 2018

DLynch moved T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it) from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sep 6 2018, 5:10 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
DLynch moved T198511: VisualEditor losing Media: links from In progress to Stalled/Waiting on the VisualEditor (Current work) board.
Sep 6 2018, 3:54 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch moved T203618: Visual editor emits many init events with platform "other" from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Sep 6 2018, 3:53 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T203620: Implementations of the Edit schema generate session IDs differently.

I think you might be wrong about MobileFrontend using the persistent sessionId. Far as I can tell, it generates a new one via mw.user.generateRandomSessionId() for all the editor event logging every time the editor route is reached. (See: MinervaNeue's definition of the editor options in skins.minerva.editor/init.js.)

Sep 6 2018, 3:36 AM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T203621: 2010 wikitext editor logs init and save events to old schema.

Same reasoning as it not logging an init event, maybe? Insofar as there's not an in-page equivalent to the saveComplete event that VE emits, because there's a page-navigation in the way.

Sep 6 2018, 3:18 AM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Sep 5 2018

DLynch added a comment to T203619: 2010 wikitext editor does not emit init events.

I’m not clear on whether we should be changing this?

Sep 5 2018, 11:28 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch claimed T203618: Visual editor emits many init events with platform "other".
Sep 5 2018, 11:24 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T203618: Visual editor emits many init events with platform "other".

Patch for this already exists: https://gerrit.wikimedia.org/r/455850

Sep 5 2018, 11:24 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T202437: Identify and fix data quality problems in the Edit event log.

Unusually few abort events recorded for both mobile editors.
On the desktop editors, the combined number of abort and saveAttempt events roughly match the number of ready events, but that isn't the case here.

Sep 5 2018, 11:12 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch moved T101113: Come up with a way to move/remove/duplicate focusable nodes in mobile from Freezer to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:38 PM · VisualEditor, Design, VisualEditor-MediaWiki-Mobile
DLynch moved T50429: [Epic] Support editing parts of a page in VisualEditor-MediaWiki from Freezer to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:37 PM · VisualEditor, VisualEditor-Performance, VisualEditor-MediaWiki
DLynch moved T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console from To Triage to Needs Discussion on the VisualEditor board.
Sep 5 2018, 4:30 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking)
DLynch added a comment to T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console.

My recollection of why I moved this in as a subtask: the parent passived scroll event handlers, but this ticket is talking about touchstart, which we should investigate as well.

Sep 5 2018, 3:50 PM · VisualEditor (Current work), Readers-Web-Backlog (Tracking)
DLynch added a comment to T190191: Line-breaks between list-items in template parameters are removed.

It does seem to legitimately feel that the author parameter has type=line in templatedata, so it's sort of a config issue on commons. That said, should we maybe detect this case (there are line-breaks in the existing value for a line field) and provide a multiline input regardless of the type?

Sep 5 2018, 3:39 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch added a comment to T190191: Line-breaks between list-items in template parameters are removed.
{{Information
|Description=Letter from US copyright office denying registration for the Subway logo.
|Source=https://www.ipmall.info/sites/default/files/hosted_resources/CopyrightAppeals/2004/Daniel%20Cislo.pdf
|Date=2013-07-16
|Author=*Maria A. Pallante, Register of Copyrights, United States Copyright Office
*William J. Roberts, Jr., Copyright Office Review Board, United States Copyright Office
|Permission=
}}
Sep 5 2018, 3:07 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch renamed T190191: Line-breaks between list-items in template parameters are removed from VE removes line-breaks of lists and breaks the layout to Line-breaks between list-items in template parameters are removed.
Sep 5 2018, 3:01 PM · MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-MediaWiki-Templates, VisualEditor-MediaWiki, VisualEditor (Current work)

Sep 4 2018

DLynch added a comment to T202656: Develop minimum set of UI Actions and Product Requirements.

Sep 4 2018, 5:11 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch moved T202656: Develop minimum set of UI Actions and Product Requirements from In progress to Code review on the VisualEditor (Current work) board.
Sep 4 2018, 4:09 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch moved T202656: Develop minimum set of UI Actions and Product Requirements from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Sep 4 2018, 4:09 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T202656: Develop minimum set of UI Actions and Product Requirements.

Patch hooks up most of the instrumentation. The rest will be in the MW extension (ve.init.mw.trackSubscriber.js), and is blocked on Neil's schema definition.

Sep 4 2018, 3:59 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Aug 29 2018

DLynch added a comment to T202437: Identify and fix data quality problems in the Edit event log.

Yup. This is because sessions launched by non-JS users won't trigger any JS-land activity (just server-side activity).

Aug 29 2018, 3:39 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Aug 28 2018

DLynch added a comment to T202656: Develop minimum set of UI Actions and Product Requirements.

There's already a bunch of discussion of implementation details in T202148.

Aug 28 2018, 4:54 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Aug 27 2018

DLynch updated subscribers of T202437: Identify and fix data quality problems in the Edit event log.

The init platform:other issue is that our tracking code tries to work out the platform via platform: ve.init && ve.init.target && ve.init.target.constructor.static.platformType || 'other',

Aug 27 2018, 10:24 PM · Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Epic, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Summary of what I observed: SurfaceFragment.annotateContent is the underpinning of most of this. Logging on it would catch use of formatting annotations and links, but not using formatting annotations without any text content -- that's done by changing the insertion annotations, not actually setting any annotation.

Aug 27 2018, 3:50 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Aug 23 2018

DLynch added a comment to T202148: Instrument editing pipeline to be able to figure out which common editing features are used.

Meeting outcome: we seemed happy with the idea that we'd log some specific window-opened events for everything non-annotation, as we're more concerned with interacting with features rather than success. (I.e. "add image", "modify image", "opened the image inspector and didn't modify it", and "opened the add image dialog and then canceled" would all be in the same "opened the image dialog" event.)

Aug 23 2018, 6:05 PM · MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics
DLynch added a comment to T201573: Generalize logic for inserting a block level element into an empty paragraph (it should replace that paragraph, not insert before it).

I observe that with the current patches, insert-table still leaves an empty paragraph (either via sequence or menu action).

Aug 23 2018, 5:10 PM · User-Ryasmeen, Verified, MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), VisualEditor-DataModel, VisualEditor (Current work), VisualEditor-EditingTools, Technical-Debt
DLynch added a comment to T198511: VisualEditor losing Media: links.

(That's very provisional.)

Aug 23 2018, 5:02 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

@ssastry Thanks for the update!

Aug 23 2018, 4:43 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

@rakekniven: No strict schedule. It's not very urgent to work on for us until the Parsoid patch lands, and I have no idea when that'll be. Sometime in the next few weeks is plausible.

Aug 23 2018, 4:37 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Aug 22 2018

DLynch added a comment to T198511: VisualEditor losing Media: links.

@rakekniven: Conceptually a solution is found, but it's incomplete. Once 451001 is merged into Parsoid, and a new Parsoid release happens, we'll need another patch to VE to actually use this new resource attribute.

Aug 22 2018, 7:28 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Aug 21 2018

DLynch added a comment to T187142: Deduplicate template styles in Parsoid.

Just to confirm, for VE it'd make our lives simpler if this doesn't happen.

Aug 21 2018, 11:12 PM · Performance-Team (Radar), Parsoid, TemplateStyles
DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

...also, the TODO there may not be necessary to address, because I think the Parsoid output for us just has a <style> for every template rather than using <link>s for deduplication. Not 100% confident that's always the case, though.

Aug 21 2018, 3:53 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch moved T197563: Template styles get ignored when switching to Visual Editor from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Aug 21 2018, 3:51 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles

Aug 20 2018

DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

The remaining TODO after those patches: if multiple copies of a template with deduplicated styles are on the page, and the one containing the actual <style> is removed, all will lose their styling.

Aug 20 2018, 5:49 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles

Aug 16 2018

DLynch claimed T197563: Template styles get ignored when switching to Visual Editor.

We filter out the <style> in ve.ce.GeneratedContentNode.prototype.getRenderedDomElements, because it calls ve.filterMetaElements on the template's markup, which removes all the link and style tags present. (Apparently because them being in cut content was crashing Chrome, per T52043.)

Aug 16 2018, 4:51 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

@Ottomata: That still leaves zookeeper dying with the same exception as in my previous message, unfortunately.

Aug 16 2018, 3:17 PM · Services (watching), Analytics, MediaWiki-Vagrant

Aug 15 2018

DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

I have eventbus explicitly enabled, but I think I remember that being something I did on a suggestion from someone helping me debug this in IRC. My VM's setup very much comes from vagrant enable role visualeditor and then whatever falls in from that and a few other extensions.

Aug 15 2018, 3:58 PM · Services (watching), Analytics, MediaWiki-Vagrant

Aug 14 2018

DLynch updated subscribers of T201871: [regression] Layout issues in feedback dialog.

The checkbox alignment seems to be caused by T178456's patch (or, at least, disabling the padding-left rule it added fixes it; harder to test whether it predates that). @matmarex?

Aug 14 2018, 4:22 PM · User-Ryasmeen, Verified-in-Phase0, Verified, OOUI (OOUI-0.28.0), MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Regression

Aug 11 2018

DLynch added a comment to T201538: Set up test instance for user testing editing prototypes.

Given the short-term prototyping goals of this, I'd assume that we'd want to quickly spin an instance up and discard it on a fairly short timeframe. Assuming that we can properly automate all that content-importing and patch-applying, this'd get us to a low maintenance state. Given that Vagrant itself is doing fine, of course.

Aug 11 2018, 11:31 PM · Developer Productivity, VisualEditor (Current work)

Aug 10 2018

DLynch updated subscribers of T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

I suppose that I'm not opposed to the combined field-button per-se, I'm just with matmarex in not really liking it in this specific instance. I'd probably be most visually happy just restoring the separation in this case. (And maybe other similar ones with this aesthetic incompatibility.)

Aug 10 2018, 4:44 AM · UI-Standardization, VisualEditor

Aug 9 2018

DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

I suspect the most relevant bit for that is ve.init.mw.Target.prototype.setupSurface, since that's where we actually turn the DOM into our model. (Though I grant I haven't stepped through and verified that the <style> hasn't been quietly stripped somewhere else where I didn't see it...)

Aug 9 2018, 5:21 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch claimed T201210: VisualEditor not switching to edit conflict interface.

Yeah, seems like that has indeed helped.

Aug 9 2018, 5:12 PM · Verified, VisualEditor (Current work), MediaWiki-Page-editing
DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

The requirement is more specific than just switching to VE -- it has to be switching to VE from the classic editpage, rather than from NWE, because that causes a load of VE without the underlying view of the page existing.

Aug 9 2018, 5:05 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch added a comment to T201538: Set up test instance for user testing editing prototypes.

Additional criteria: ease of deploying an arbitrary patch to the instance.

Aug 9 2018, 4:35 PM · Developer Productivity, VisualEditor (Current work)

Aug 8 2018

DLynch added a comment to T199554: Switching between visual editor and source mode gives error message.

(Note that there is no data loss, for VE or other affected tools, just a misleading message.)

Aug 8 2018, 8:46 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch added a comment to T201210: VisualEditor not switching to edit conflict interface.

The incompleteForm message part will be fixed when my patch on T199554 is merged. I'm not sure if that's the sole part that's holding up going to the conflict resolution interface, though -- I'll double-check it.

Aug 8 2018, 5:18 PM · Verified, VisualEditor (Current work), MediaWiki-Page-editing
DLynch added a comment to T201472: List insertion by typing '#<space>', '*<space>' is broken.

@Esanders: Makes sense, and I agree on the general case. If you merge it, I can make a new task for fixing it up more permanently.

Aug 8 2018, 4:37 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki

Aug 7 2018

DLynch moved T201472: List insertion by typing '#<space>', '*<space>' is broken from In progress to Code review on the VisualEditor (Current work) board.
Aug 7 2018, 11:37 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T201472: List insertion by typing '#<space>', '*<space>' is broken.
Aug 7 2018, 11:05 PM · Verified, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch added a comment to T200525: Allow cursoring between active nodes.

Question 1 is what I was asking above in my first comment on this task, so I'd say that's somewhat-undecided. I think 2 is unintended, though; it should switch to cell selection first.

Aug 7 2018, 10:56 PM · User-Ryasmeen, Verified, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation
DLynch added a comment to T199925: Be able to insert horizontal rules (<hr> or ----).

It's the same as how pasting * doesn't make it become a list item. Which maybe it should? Not sure.

Aug 7 2018, 9:25 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki, User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))
DLynch updated subscribers of T198511: VisualEditor losing Media: links.

@cscott: Oh, I totally agree that this UX isn't optimal, and that we should add it to @iamjessklein's big pile of VE design thoughts. I'm just happy to fix the power-user case right now while we wait on that. (And we'll presumably need whatever functionality we add via resource for the nicely-designed option anyway, so that shouldn't hurt.)

Aug 7 2018, 2:56 AM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Aug 6 2018

DLynch added a comment to T198511: VisualEditor losing Media: links.

@cscott: Nope, this is all we get from Parsoid: [[Media:Logo.png]] => <p id="mwAQ"><a rel="mw:MediaLink" href="//upload.wikimedia.org/wikipedia/commons/c/c9/Logo.png" title="Logo.png" id="mwAg">Media:Logo.png</a></p> (with the link text obviously not being reliable, because people can change that).

Aug 6 2018, 11:45 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

Absent Parsoid output/input changes, I will make those editing experiences equivalent by:

Aug 6 2018, 11:11 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

From a UX standpoint, I'd expect that "link to file page on commons" vs "link directly to media download" is a checkbox in the link options somehow. I think we'd need some insight from a designer on how to best express this w/in the current VE framework. The magical checkbox would determine whether VE gave us back the mw:MediaLink or mw:ExtLink type.

Aug 6 2018, 10:15 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a project to T198511: VisualEditor losing Media: links: Parsoid.

Okay, so. I've gone and read wt2html/tt/LinkHandler.js and html2wt/LinkHandler.js in Parsoid, and I think that this never worked in VE, since Parsoid added this MediaLink stuff back in May of 2017.

Aug 6 2018, 7:15 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

Alas, testing indicates the behavior existed prior to that. So I'll just fix it rather than digging.

Aug 6 2018, 4:45 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

If I'm speculating wildly, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/436544 did change a bunch of our parsoid-and-links interactions recently.

Aug 6 2018, 4:41 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch claimed T198511: VisualEditor losing Media: links.

We have no explicit handling of mw:MediaLink, so I think what's happening here is just that it's treating it like any other link and falling back on that generic behavior.

Aug 6 2018, 4:38 PM · MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Aug 4 2018

DLynch added a comment to T201232: Clicking the "Change label" button needs to give the user clearer feedback.

There's some discussion of this in T124305 as well.

Aug 4 2018, 3:30 PM · Patch-For-Review, Design, VisualEditor

Aug 2 2018

DLynch claimed T199655: Switching between old WTE and visual editing doesn't preserve changes.

Not firefox specific. It does require that you have both multiple edit tabs, not be using NWE, and trigger the switch by clicking the "edit source" tab rather than through VE's menus, though, which I suspect is why Dan couldn't reproduce it.

Aug 2 2018, 4:58 PM · Verified-in-Phase0, Verified, MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Browser-Support-Firefox
DLynch added a comment to T200386: Switching to VE from New Section tab shows the confirmation dialog with option "Discard my changes and switch" when no changes were actually made. .

I think this is a dupe of T136267.

Aug 2 2018, 4:13 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch created T201019: Back button navigation to NWE doesn't restore section editing.
Aug 2 2018, 4:10 PM · VisualEditor
DLynch moved T199554: Switching between visual editor and source mode gives error message from In progress to Code review on the VisualEditor (Current work) board.
Aug 2 2018, 3:37 AM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)

Aug 1 2018

DLynch moved T199554: Switching between visual editor and source mode gives error message from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Aug 1 2018, 4:22 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch claimed T199554: Switching between visual editor and source mode gives error message.
Aug 1 2018, 4:22 PM · MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)

Jul 31 2018

DLynch added a comment to T200525: Allow cursoring between active nodes.

@Deskana: "active node" means one which can have cursor focus within it, in a way that's somewhat separate from the general article flow. This patch makes it so that moving your cursor with the arrow keys doesn't keep it trapped within those nodes. E.g. if you're in a table caption and press the up arrow, you would previously have stayed in the caption, but now you'll find the cursor in the preceding content.

Jul 31 2018, 11:31 PM · User-Ryasmeen, Verified, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation
DLynch moved T176070: action=edit does not show deletion log, where applicable from Ready for Pick Up to QA on the VisualEditor (Current work) board.
Jul 31 2018, 9:41 PM · Verified, VisualEditor-MediaWiki, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch claimed T176070: action=edit does not show deletion log, where applicable.
Jul 31 2018, 9:40 PM · Verified, VisualEditor-MediaWiki, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch merged task T199087: No warning shown in VE/NWE that a page has previously been deleted into T176070: action=edit does not show deletion log, where applicable.
Jul 31 2018, 9:39 PM · MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch merged T199087: No warning shown in VE/NWE that a page has previously been deleted into T176070: action=edit does not show deletion log, where applicable.
Jul 31 2018, 9:39 PM · Verified, VisualEditor-MediaWiki, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch added a comment to T176070: action=edit does not show deletion log, where applicable.

Am I right in thinking that T199087 is a duplicate of this? Because I have a patch for that which gets us:

Jul 31 2018, 4:59 PM · Verified, VisualEditor-MediaWiki, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch added a comment to T200525: Allow cursoring between active nodes.

For the table caption case, should we special case it so that it jumps the selection into the table rather than skipping it?

Jul 31 2018, 4:46 PM · User-Ryasmeen, Verified, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation
DLynch added a comment to T181416: In VE table editor, cannot move cursor out of caption area using keyboard.

Actually, new development, T200525 made it so that arrows will move out of it.

Jul 31 2018, 4:46 PM · User-Ryasmeen, WCAG-Level-A, Accessibility, VisualEditor, VisualEditor-Tables

Jul 30 2018

DLynch added a comment to T181416: In VE table editor, cannot move cursor out of caption area using keyboard.

As of T192163 this is fixed, insofar as the tab key now works to move in/out of table captions.

Jul 30 2018, 4:20 PM · User-Ryasmeen, WCAG-Level-A, Accessibility, VisualEditor, VisualEditor-Tables

Jul 26 2018

DLynch claimed T199925: Be able to insert horizontal rules (<hr> or ----).
Jul 26 2018, 4:34 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki, User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))

Jul 25 2018

DLynch added a comment to T197075: CX2: Show link card for source links.

@santhosh Context popups trigger in reaction to contextChange events, which I'm fairly sure only fire in response to things which happen to an enabled surface. Plus, complications of the surface not having a context if there's not a selection for it to know what that context should be. You could plausibly manually override this by directly asking ve.ui.contextItemFactory.getRelatedItems for context items for parts of the document you're interested in, and displaying those however you please -- that said, context items have a few parts which expect to interact with an enabled document (for links, that'd be the remove-annotation and select-label buttons), and those would cause issues with a disabled surface as well.

Jul 25 2018, 5:48 PM · Language-Team (Language-2018-October-December), ContentTranslation
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Trizek-WMF: You'll find extensive discussion of that approach in T55973, if you want to see the arguments. I had a patch which worked that way as well, and it was less popular than the one which we went with in the end.

Jul 25 2018, 3:29 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Jul 18 2018

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

I can explain why things are the way they are, at least.

Jul 18 2018, 5:34 PM · User-Ryasmeen, MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Jul 17 2018

DLynch added a comment to T184605: Restore keyboard shortcut in the visual editor to the same one that's used in older editors.

I think this is just an uncaught duplicate of T121183? (And so, fixed.)

Jul 17 2018, 4:54 PM · User-Ryasmeen, VisualEditor