Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (203 w, 3 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Thu, Aug 22

DLynch added a comment to T231031: Instrument usage of ISBN barcode scanner.

Educational DVDs can get them too! Though I admit I didn’t bother to look up whether there’s any distinguishing characteristic in the code.

Thu, Aug 22, 6:01 PM · VisualEditor, Citoid
DLynch created T231031: Instrument usage of ISBN barcode scanner.
Thu, Aug 22, 5:14 PM · VisualEditor, Citoid

Wed, Aug 21

DLynch claimed T227317: Oversample mobile wikitext EditAttemptStep events on default editor A/B test wikis.
Wed, Aug 21, 5:18 PM · User-Ryasmeen, VisualEditor (Current work)

Tue, Aug 20

DLynch moved T229744: HTML entities in section headings show on a separate line in mobile visual editor from Code review to QA on the VisualEditor (Current work) board.
Tue, Aug 20, 9:42 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch added a comment to T230807: v2 toolbar shows disabled edit tools on first load, then never again.

That screenshot does also remind me that we should, perhaps, hide the toolbar while that modal is displayed? Having non-disabled tools while the modal is present would be weird as well, after all.

Tue, Aug 20, 3:47 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE.

@Ryasmeen This one needs to wait for testing until OOJS-UI gets updated, sorry.

Tue, Aug 20, 3:02 PM · OOUI, VisualEditor (Current work)

Wed, Aug 14

DLynch added a comment to T228794: Investigate technical needs for native mobile diffs, including supporting APIs.

“if the visual diffs feature is self contained enough that it could be API-ified or bundled in the App as a JS library to run on a webview (or maybe as an API like page/mobile-html)”

Wed, Aug 14, 11:00 PM · Spike, iOS-app-v6.4-Seamonkey-On-A-Hoverboard, Wikipedia-iOS-App-Backlog
DLynch moved T230058: Change back action icon in toolbar to "<" from "x" from Incoming to Code review on the VisualEditor (Current work) board.
Wed, Aug 14, 4:52 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch added a comment to T229832: Conduct Edit Cards v3 usertesting.com test.

Following up on my earlier suggestion to document things...

Wed, Aug 14, 3:39 PM · Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Tue, Aug 13

DLynch added a comment to T211787: Design a Test for prototype.

Notes on the script: testers missed that they should highlight UNLINKED words at first, so that should be specified.

Tue, Aug 13, 5:00 PM · VisualEditor
DLynch added a comment to T228753: New mobile context ("edit cards") do not support multiple context items very well.

Some quick experimentation suggests that the edit card can't scroll, if it manages to expand past the screen height. Worse, in that case, the top of the card containing the close button is stuck off the top of the screen, leaving the user in an unrecoverable state.

Tue, Aug 13, 4:38 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, VisualEditor-Edit Cards
DLynch moved T229744: HTML entities in section headings show on a separate line in mobile visual editor from Incoming to Code review on the VisualEditor (Current work) board.
Tue, Aug 13, 4:33 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T229744: HTML entities in section headings show on a separate line in mobile visual editor.
Tue, Aug 13, 4:33 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki

Sat, Aug 10

DLynch moved T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE from In progress to Code review on the VisualEditor (Current work) board.
Sat, Aug 10, 2:31 AM · OOUI, VisualEditor (Current work)

Fri, Aug 9

DLynch moved T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE from Incoming to In progress on the VisualEditor (Current work) board.

Quirk seems to be with this CSS rule from OOUI

.oo-ui-popupWidget {
    filter: drop-shadow(0 2px 1px rgba(0,0,0,0.3));
}
Fri, Aug 9, 6:58 PM · OOUI, VisualEditor (Current work)
DLynch added a comment to T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE.

I can reproduce this, though it's a little inconsistent about when it happens. In my reproduction it's not required that I select another thing that triggers a context item -- many context items will leave their shadows behind to some extent. See:

Fri, Aug 9, 6:51 PM · OOUI, VisualEditor (Current work)

Thu, Aug 8

DLynch added a comment to T230133: Some EditAttemptStep events on existing pages do not have revision IDs.

So, null revision_id means that mw.config.get( 'wgRevisionId' ) didn't return anything. This implies bigger issues with the current session...

Thu, Aug 8, 4:37 PM · VisualEditor
DLynch added a comment to T229832: Conduct Edit Cards v3 usertesting.com test.

add ⓧ buttons in the form input fields to make text deletion easier

We could switch these to an OOJS-UI SearchInputWidget, probably. Easier for external than internal, because internal uses mw.widgets.TitleSearchWidget and we might need to make sure there wouldn't be any side-effects there.

Thu, Aug 8, 4:03 PM · Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch renamed T230058: Change back action icon in toolbar to "<" from "x" from Change back action icon in toolbar to ">" from "x" to Change back action icon in toolbar to "<" from "x".
Thu, Aug 8, 1:54 AM · Editing QA, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Tue, Aug 6

DLynch added a comment to T221197: VE mobile default: A/B test post-deployment data checks.

This is quite different from what I found in the VisualEditor on mobile report; the ready rate for the mobile visual there was about 95%. The difference may be that the old number was based on a self-selected group of VE users, while this new number is based on a more representative group. Alternatively, it could be the result of a regression during the past year.

Tue, Aug 6, 4:38 PM · User-Ryasmeen, Patch-For-Review, Product-Analytics, VisualEditor (Current work)

Mon, Aug 5

DLynch added a comment to T225634: Design "refreshed toolbar" v1.0.

We also said when moving to native affordances for dismissing the keyboard that the Android one is really bad and that we would consider augmenting it with out own button floating above the keyboard.

Mon, Aug 5, 4:59 PM · Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch moved T229579: Use simplified mobilefrontend copyright messages on mobile VE from Code review to QA on the VisualEditor (Current work) board.
Mon, Aug 5, 3:46 PM · Editing QA, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Fri, Aug 2

DLynch edited projects for T211789: Develop a working toolbar prototype v1, added: VisualEditor (Current work); removed VisualEditor.
Fri, Aug 2, 8:15 AM · VisualEditor (Current work), Patch-For-Review

Wed, Jul 31

DLynch added a comment to T227933: Context items: verify logging events are firing properly.
  1. The window-open events listed in the "Opening of windows" section of this task's description are not blocking Edit Cards v2 release. This is b/c answering the measurement questions we have listed in the description of T221252 depends on us being able to track the opening of context items, not windows.

That is my understanding of Neil's position. (I.e. the missing ones are generally off the toolbar buttons, rather that directly from the contexts of existing nodes.)

Wed, Jul 31, 5:30 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Tue, Jul 30

DLynch committed rECEXc9209ef36a9e: On manual template selection give the close a descriptive action (authored by DLynch).
On manual template selection give the close a descriptive action
Tue, Jul 30, 4:07 PM

Mon, Jul 29

DLynch added a comment to T229255: 'window-open-from-command' event is not getting fired while clicking on Add new citation>Manual>Book/Website etc..

This wound up already being fixed in a patch attached to that task.

Mon, Jul 29, 7:06 PM · VisualEditor
DLynch merged T229255: 'window-open-from-command' event is not getting fired while clicking on Add new citation>Manual>Book/Website etc. into T221305: Instrument revised *citation* edit workflows.
Mon, Jul 29, 7:05 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), VisualEditor-Edit Cards , VisualEditor (Current work)
DLynch merged task T229255: 'window-open-from-command' event is not getting fired while clicking on Add new citation>Manual>Book/Website etc. into T221305: Instrument revised *citation* edit workflows.
Mon, Jul 29, 7:05 PM · VisualEditor

Jul 25 2019

DLynch created T229028: Requesting production shell access for DLynch.
Jul 25 2019, 5:17 PM · Operations, SRE-Access-Requests
DLynch added a comment to T227200: Requesting access to analytics-privatedata-users for DLynch.

So, as far as I know, we're currently talking on a ticket which was created through all the "new users" steps stated on the request-shell-access document, and as far as I knew what I was doing here was requesting new production shell access with access to the analytics-privatedata-users group. Did I need to instead make two separate tickets for this? If so, it's not very clear in the documentation.

Jul 25 2019, 4:16 PM · VisualEditor (Current work), Operations, SRE-Access-Requests
DLynch added a comment to T227200: Requesting access to analytics-privatedata-users for DLynch.

I'm interested mainly in analytics data logged in relation to Editing products (the EditAttemptStep and VisualEditorFeatureUse schemas).

Jul 25 2019, 4:03 PM · VisualEditor (Current work), Operations, SRE-Access-Requests

Jul 24 2019

DLynch added a comment to T227933: Context items: verify logging events are firing properly.

I updated the link in the description to include useful URL parameters, and to link to a non-protected page. 👍🏻

Jul 24 2019, 7:36 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch updated the task description for T227933: Context items: verify logging events are firing properly.
Jul 24 2019, 7:36 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch updated the task description for T227933: Context items: verify logging events are firing properly.
Jul 24 2019, 5:33 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch moved T227933: Context items: verify logging events are firing properly from Incoming to QA on the VisualEditor (Current work) board.
Jul 24 2019, 5:16 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch edited projects for T227933: Context items: verify logging events are firing properly, added: VisualEditor (Current work); removed VisualEditor.

For event-monitoring, the instructions there are only really helpful in 100% oversampling situations. Otherwise you have to keep reloading the page until you manage to wind up in the sample, which is an incredibly annoying testing requirement. (Or do all your testing on one of the wikis which has oversampling turned on -- which only applies to mobile.)

Jul 24 2019, 5:16 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Jul 22 2019

DLynch committed rECITba9b0c280b80: Tracking for change events in citation-templates (authored by DLynch).
Tracking for change events in citation-templates
Jul 22 2019, 9:34 PM

Jul 18 2019

DLynch added a comment to T227933: Context items: verify logging events are firing properly.

I believe that document is up to date.

Jul 18 2019, 4:13 PM · Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Jul 16 2019

DLynch moved T221249: Instrument revised *link* edit workflows from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Jul 16 2019, 5:12 PM · VisualEditor-Edit Cards , MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)
DLynch moved T221252: Enhance instrumentation for context items and inspectors from Engineering QA to Product owner review on the VisualEditor (Current work) board.

I guess that since we have that separate ticket for the QA (T221254), we might as well push this to product owner review.

Jul 16 2019, 4:59 PM · VisualEditor-Edit Cards , MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor-MediaWiki, VisualEditor (Current work)

Jul 15 2019

DLynch added a comment to T227200: Requesting access to analytics-privatedata-users for DLynch.

@Nuria I am indeed a permanent employee of the foundation, and believe that I have a NDA on file.

Jul 15 2019, 2:03 PM · VisualEditor (Current work), Operations, SRE-Access-Requests

Jul 12 2019

DLynch closed T220697: Editing timing data incorrect/meaningless when switching editor on mobile as Resolved.
Jul 12 2019, 11:08 PM · Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Jul 9 2019

DLynch committed rECEXad868ed839e0: Extra tracking for VisualEditor's feature use (authored by DLynch).
Extra tracking for VisualEditor's feature use
Jul 9 2019, 10:46 AM
DLynch committed rECITeb37c893eaaf: Extra tracking for VisualEditor's feature use (authored by DLynch).
Extra tracking for VisualEditor's feature use
Jul 9 2019, 10:22 AM

Jul 8 2019

DLynch added a comment to T221197: VE mobile default: A/B test post-deployment data checks.

Does a ready event fire before or after a contributor taps the "Start editing" button at the bottom of the "Welcome to Wikipedia" overlay [1]?

Jul 8 2019, 9:29 PM · User-Ryasmeen, Patch-For-Review, Product-Analytics, VisualEditor (Current work)
DLynch added a comment to T221197: VE mobile default: A/B test post-deployment data checks.

@DLynch, while doing an extra check of ready counts as suggested by @ppelberg, I noticed that the default-visualeditor bucket is only logging 60% as many ready events as the default-source bucket among our test population (when factoring out oversampling). That's big and concerning, whether it's due to real user behavior or instrumentation issues.

Jul 8 2019, 9:28 PM · User-Ryasmeen, Patch-For-Review, Product-Analytics, VisualEditor (Current work)
DLynch edited projects for T221249: Instrument revised *link* edit workflows, added: VisualEditor (Current work); removed VisualEditor.
Jul 8 2019, 3:13 PM · VisualEditor-Edit Cards , MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)

Jul 3 2019

DLynch added a comment to T221197: VE mobile default: A/B test post-deployment data checks.

To copy from chat:

Jul 3 2019, 10:30 PM · User-Ryasmeen, Patch-For-Review, Product-Analytics, VisualEditor (Current work)
Restricted Application added a project to T227200: Requesting access to analytics-privatedata-users for DLynch: Operations.
Jul 3 2019, 3:16 PM · VisualEditor (Current work), Operations, SRE-Access-Requests
DLynch created P8708 (An Untitled Masterwork).
Jul 3 2019, 3:16 PM

Jul 2 2019

DLynch added a project to T226847: Mobile editors do not log new revision IDs on saveSuccess: Skipped QA.
Jul 2 2019, 8:20 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)

Jun 30 2019

ppelberg awarded T221196: Set VE as default for target wikis in A/B test a 100 token.
Jun 30 2019, 4:42 PM · VisualEditor-MediaWiki-Mobile, Wikimedia-Site-requests, VisualEditor (Current work)

Jun 29 2019

DLynch claimed T226847: Mobile editors do not log new revision IDs on saveSuccess.

TODO: more patches for mobile.

Jun 29 2019, 5:08 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)

Jun 28 2019

DLynch moved T221196: Set VE as default for target wikis in A/B test from Incoming to Code review on the VisualEditor (Current work) board.
Jun 28 2019, 4:54 PM · VisualEditor-MediaWiki-Mobile, Wikimedia-Site-requests, VisualEditor (Current work)

Jun 27 2019

DLynch added a comment to T221191: VE mobile default: start tracking editor switches on mobile + desktop.

I found an extra little data-glitch in there -- when switching from WikiEditor to VisualEditor it wouldn't log it properly, because it wasn't updated to correctly see the in-page load. It would thus wait to log an abort until VE was done and triggered a page-reload, and it wouldn't log that abort correctly as being a switch away from WikiEditor (because it detected that purely based on whether the link to visual editing currently had focus).

Jun 27 2019, 9:53 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)
DLynch added a comment to T221191: VE mobile default: start tracking editor switches on mobile + desktop.

@Neil_P._Quinn_WMF That's something which has been subject to general code-atrophy over time. It only fires the abort for a full teardown editor-switch on desktop (so NWE isn't counted), and mobile has gradually wound up getting in-line with that so it's not logging the aborts because it's not navigating away. I figured putting in a consistent "this is feature-usage, and not an abstract thing tied to page lifecycle" would get us a less fragile metric going forward.

Jun 27 2019, 7:34 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)
DLynch added a comment to T221191: VE mobile default: start tracking editor switches on mobile + desktop.

That's mobile done. Another patch for desktop will be forthcoming.

Jun 27 2019, 5:11 AM · Skipped QA, MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)

Jun 18 2019

DLynch moved T221195: VE mobile default: design A/B test from In progress to Engineering QA on the VisualEditor (Current work) board.

Testing this patch beyond the superficial "it doesn't break the existing behavior" requires that you set the $wgMFDefaultEditor config variable, to one of source, visual, preference, or abtest. The first two are obvious, preference means it should obey your user's desktop preference, and abtest should do a 50/50 split which is persistent for a given user (including anonymous users, until cookies are cleared). Super-deep validation includes making sure that abtest causes eventlogging to include the anonymous_user_token and bucket fields with appropriate values.

Jun 18 2019, 4:09 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), Product-Analytics
DLynch added a comment to T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error.

@marcella: I don't think there's a reason to do it and save it -- it's meaningless from a data standpoint, which is why doing this edit in other ways already shows an error; this is just a way to reach that state without the error being shown.

Jun 18 2019, 4:03 PM · VisualEditor, TemplateData
DLynch added a comment to T225750: Add a useful call-to-action for citation needed templates while reading.

A really simple enhancement along the lines Ed suggests there would be to allow the link to Wikipedia:Citation_needed to have a hover preview like article links do. It seems plausible that the preview summary that appears then would provide enough information for the user to proceed with.

Jun 18 2019, 2:48 PM · VisualEditor

Jun 13 2019

DLynch added a comment to T211243: Add a useful call-to-action in the context for citation needed templates.

@ppelberg I think your questions are tangentially relevant to this specific ticket -- this one applies to once you're within the editor, and your questions largely apply to users who're still pre-editor and reading the article.

Jun 13 2019, 5:25 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
DLynch added a comment to T221195: VE mobile default: design A/B test.

One problem: if we store it in user_id, we will have to start purging that field after 90 days, whereas we currently do not. We should instead add an anonymous_user_token field or similar to EditAttemptStep.

How's the purge configured? I don't know anything about the mechanism for it -- is it raw "empty this field after X time", or are there more conditions possible?

Jun 13 2019, 5:15 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), Product-Analytics
DLynch added a comment to T218942: Random article widget.

@JMinor sorry, I was caught up in the Editing offsite when that comment came in and I missed having the time to work on it.

Jun 13 2019, 2:52 PM · Wikipedia-iOS-App-Backlog

Jun 5 2019

DLynch added a comment to T221195: VE mobile default: design A/B test.

Outcome of call: generating a persistent-ish anon userid (cookie, expiring 90 days) and storing it as a negative integer in the user_id schema field would be acceptable for analytics.

Jun 5 2019, 5:10 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), Product-Analytics

Jun 4 2019

DLynch added a project to T224923: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces: Patch-For-Review.

Bot didn't add the patch: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/514369

Jun 4 2019, 8:13 PM · VisualEditor-CopyPaste, VisualEditor (Current work), Patch-For-Review
DLynch added a comment to T224923: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces.

Alas, it doesn't. That said... possibly it's a useful bit of cleanup.

Jun 4 2019, 6:48 PM · VisualEditor-CopyPaste, VisualEditor (Current work), Patch-For-Review

Jun 3 2019

DLynch created T224923: Dialog-embedded VE vanishes off-screen when pasting long content which does not contain spaces.
Jun 3 2019, 6:29 PM · VisualEditor-CopyPaste, VisualEditor (Current work), Patch-For-Review

May 23 2019

DLynch moved T217825: Editing timing data incorrect for second load from Engineering QA to Product owner review on the VisualEditor (Current work) board.
May 23 2019, 3:57 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

May 22 2019

Pols12 awarded T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error a Like token.
May 22 2019, 11:18 PM · VisualEditor, TemplateData
DLynch added a comment to T222543: In TemplateData param editor, typing a name equal to alias definitely disable Done button .

@Pols12: It's true that you can do this, but that was already the case before this patch, so "can now" doesn't seem accurate. Separate bug, I'd say. I've filed it as T224137.

May 22 2019, 4:33 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), TemplateData
DLynch created T224137: In TemplateData param editor, assigning an alias that's the same as the name doesn't cause an error.
May 22 2019, 4:33 PM · VisualEditor, TemplateData

May 21 2019

DLynch added a comment to T221195: VE mobile default: design A/B test.

To confirm and specify... we only set preferredEditor during calls to switch editor (to source, to visual).

May 21 2019, 5:19 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), Product-Analytics
DLynch added a comment to T221195: VE mobile default: design A/B test.

During the planning meeting @matmarex said that we only store the preference after a switch has happened, rather than when the editor is opened.

May 21 2019, 5:15 PM · MW-1.34-notes (1.34.0-wmf.11; 2019-06-26), VisualEditor (Current work), Product-Analytics

May 15 2019

DLynch added a comment to T211240: Mobile table editing should default to cell contents.

@Ryasmeen Yeah, the constraints on that space are such that the table-icon gets to take up the smallest amount of space of any of the table-adjacent options. It could become inconsistent with the others -- larger and floating over the other content a bit more, say -- or something like expanding the highlight could happen (so that there's that blue highlight joining the arrows to the table-icon and drawing eyes to it).

May 15 2019, 3:47 PM · VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

May 14 2019

DLynch added a comment to T211240: Mobile table editing should default to cell contents.

@Ryasmeen -- Hard to discover that clicking the box will do something, you mean? Or hard to work out what the options within will do?

May 14 2019, 8:16 PM · VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch moved T223322: Cross-wiki pastes of internal links result in broken links from Incoming to Code review on the VisualEditor (Current work) board.
May 14 2019, 7:36 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor (Current work)
DLynch created T223322: Cross-wiki pastes of internal links result in broken links.
May 14 2019, 7:35 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor (Current work)

May 9 2019

DLynch moved T222543: In TemplateData param editor, typing a name equal to alias definitely disable Done button from Code review to QA on the VisualEditor (Current work) board.
May 9 2019, 4:49 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), TemplateData
DLynch moved T220697: Editing timing data incorrect/meaningless when switching editor on mobile from In progress to Code review on the VisualEditor (Current work) board.
May 9 2019, 3:39 PM · Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

May 8 2019

DLynch moved T220697: Editing timing data incorrect/meaningless when switching editor on mobile from Incoming to In progress on the VisualEditor (Current work) board.
May 8 2019, 4:59 PM · Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T222247: "Find" doesn't scroll the viewport.

I can't reproduce it not scrolling while the find panel is open, but the jump to the top when the find panel closes is definitely there.

May 8 2019, 4:55 PM · Verified, MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), VisualEditor (Current work)
DLynch claimed T222543: In TemplateData param editor, typing a name equal to alias definitely disable Done button .
May 8 2019, 4:11 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), VisualEditor (Current work), TemplateData

May 2 2019

DLynch added a comment to T221967: Can't reliably gather list of annotation views from a DM offset.

I recall poking around for this in the past, and we've been fairly good at avoiding the model knowing about its views. Which is sensible design, but inconvenient at times like this.

May 2 2019, 4:17 PM · VisualEditor-DataModel, VisualEditor

Apr 24 2019

DLynch moved T221669: Error `Cannot read property 'getScrollContainer' of null` when saving on mobile from Code review to Product owner review on the VisualEditor (Current work) board.
Apr 24 2019, 1:23 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Apr 23 2019

DLynch added a comment to T221716: [Regression pre-wmf.2] After inserting a link, annotation cartouche and context menu is not active.

Heh. Amusingly (?) I remember explicitly testing that post-link stuff, and completely missing that the context behavior had changed because I was entirely focused on the select-inside aspect..

Apr 23 2019, 10:39 PM · Verified, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-Links, VisualEditor (Current work)
DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

@Ryasmeen Shouldn't be yet, I don't think. I believe it merged after the deploys started last week, and this week's the RelEng offsite so there's no train... so next week, I guess?

Apr 23 2019, 7:48 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
DLynch moved T221669: Error `Cannot read property 'getScrollContainer' of null` when saving on mobile from Incoming to Code review on the VisualEditor (Current work) board.
Apr 23 2019, 5:00 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch created T221669: Error `Cannot read property 'getScrollContainer' of null` when saving on mobile.
Apr 23 2019, 4:45 PM · Skipped QA, MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch moved T220513: Non-latin URL fragments don't reliably get scrolled to from Incoming to QA on the VisualEditor (Current work) board.
Apr 23 2019, 3:15 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend
DLynch edited projects for T220513: Non-latin URL fragments don't reliably get scrolled to, added: VisualEditor (Current work); removed VisualEditor.

Yeah, I filed it here because it seemed to affect MobileFrontend generally, and just happened to be coming up in response to a redirect section-editing triggered.

Apr 23 2019, 3:15 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 19 2019

Ryasmeen awarded T220513: Non-latin URL fragments don't reliably get scrolled to a Like token.
Apr 19 2019, 1:41 AM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 18 2019

DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I said it on the other ticket as well, but I suspect that pages which start with a / are probably far less common than subpages, so it'd be a strange case to optimize for...

Apr 18 2019, 4:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T221028: Parsoid incorrectly parses links to pages starting with a slash '/' in namespaces that can have subpages.

I think the suggested behavior here is far less likely to be what people intended than the subpage behavior. Pages whose names start with a / are unusual, and I suspect people are more likely to be trying to link to a subpage.

Apr 18 2019, 4:45 PM · Parsoid-Read-Views

Apr 17 2019

DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

@Ryasmeen When this makes its way to bn.wikipedia we'll know how much it has helped your specific case. :D

Apr 17 2019, 3:47 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend

Apr 12 2019

DLynch moved T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving from Incoming to Code review on the VisualEditor (Current work) board.
Apr 12 2019, 7:28 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch edited projects for T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving, added: VisualEditor (Current work); removed VisualEditor.
Apr 12 2019, 7:25 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

@janboehme I'd speculatively point to this commit but can't claim to have actually tested that.

Apr 12 2019, 4:06 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links

Apr 11 2019

DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I'm using a current checkout of it, so I suppose I have a few months of miscellaneous changes since the 0.10.0 release.

Apr 11 2019, 8:37 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I can't reproduce the bad link generation, though I agree the not-actually-a-redlink is still happening.

Apr 11 2019, 4:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T218942: Random article widget.

In part we speak here of pull request #2990.

Apr 11 2019, 3:33 PM · Wikipedia-iOS-App-Backlog