Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (243 w, 18 h)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Wed, May 27

DLynch updated subscribers of T253710: Make @ mention confirmation more clear.

This is one of those areas where our really lax username options make it tricky, because we allow spaces and many other punctuation characters.

Wed, May 27, 3:24 AM · Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor

Tue, May 26

DLynch added a comment to T244498: Replies v2.0: determine what additional instrumentation is needed.

Okay, schema-change updated to not have anything new that's required.

Tue, May 26, 4:57 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Editing-team (Tracking), Product-Analytics, OWC2020 (OWC2020 Replying 2.0)
DLynch added a comment to T244498: Replies v2.0: determine what additional instrumentation is needed.

@DLynch : I think this is the case but, again, to be super clear: to keep things backwards compatible the new properties should not be required, otherwise all events coming with the old schema version will fail validation . They should be optional.

Tue, May 26, 4:48 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Editing-team (Tracking), Product-Analytics, OWC2020 (OWC2020 Replying 2.0)

Mon, May 25

DLynch added a comment to T252931: Instrument Reply tool v2.0.

We need to go over the events for the mode-switching and ensure that they're firing appropriately.

Mon, May 25, 10:24 PM · DiscussionTools, Editing-team, OWC2020 (OWC2020 Replying 2.0)
DLynch added a comment to T244498: Replies v2.0: determine what additional instrumentation is needed.
  1. How – if at all – would we currently distinguish between the wikilink and user link (@-mention) sequences? I'm assuming both of the below will produce link:window-open-from-trigger events. [ii]

Depends when you mean. The @-mention dropdown will use the mwUsernameCompletion feature (and window-open-from-sequence) rather than link -- once the link is actually created, we haven't done anything with T252083 yet, so that'd still be link.

Mon, May 25, 10:00 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Editing-team (Tracking), Product-Analytics, OWC2020 (OWC2020 Replying 2.0)
DLynch added a comment to T244498: Replies v2.0: determine what additional instrumentation is needed.

Once the instrumentation is deployed, will this be handled automatically or are there any manual steps (by Analytics or other team) that will be required to make this happen ?

Mon, May 25, 9:49 PM · MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Editing-team (Tracking), Product-Analytics, OWC2020 (OWC2020 Replying 2.0)

Fri, May 22

DLynch added a comment to T252593: More robust timing reporting in client-side EditAttemptStep instrumentation.

@DLynch: what do you think about switching to performance.now(), rather than including the check-and-omit logic?

Fri, May 22, 5:07 PM · Patch-For-Review, Editing-team, Product-Analytics

Thu, May 14

DLynch added a project to T252794: EventLogging vagrant role fails to provision: Event-Platform.

I'd speculate it's to do with the changes from T240355.

Thu, May 14, 4:26 PM · Analytics, Event-Platform, MediaWiki-Vagrant
DLynch created T252794: EventLogging vagrant role fails to provision.
Thu, May 14, 4:23 PM · Analytics, Event-Platform, MediaWiki-Vagrant

Tue, May 12

DLynch updated subscribers of T252482: [INVESTIGATE] Why is VisualEditor not available in UI for logged out users at en.wiki?.

Might need to ask @Jdforrester-WMF if they can remember the context.

Tue, May 12, 5:11 PM · Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, VisualEditor-MediaWiki

Mon, May 11

DLynch added a comment to T252460: Keep '@' prefix in username auto-complete output.

@Dyolf77_WMF this ticket is for the default -- T250332 is going to expose customizing the message so individual wikis can make it more to their liking.

Mon, May 11, 9:27 PM · Verified, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 2.0), VisualEditor
DLynch added a comment to T252460: Keep '@' prefix in username auto-complete output.

Did you want the @ to be inside or outside the link?

Mon, May 11, 8:58 PM · Verified, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 2.0), VisualEditor

Sat, May 9

DLynch added a comment to T252169: Consider including IPs within the username suggestion llist.

Yeah, it is -- sorry, I made that comment without refreshing the page and you'd edited the description to include it as I did so.

Sat, May 9, 2:10 AM · Editing-team, Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor

Thu, May 7

DLynch added a comment to T252169: Consider including IPs within the username suggestion llist.

Implementation detail (which is not yet implemented): as in the signature, the IP address @mentioned should link to the Special:Contributions page for the IP address, not the (probably non-existent) user page for it.

Thu, May 7, 9:53 PM · Editing-team, Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

...and that got merged. So, adblockers may still be cutting off the beacon requests, but DoNotTrack should be applied to client-side and server-side equally now.

Thu, May 7, 6:30 PM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

@mpopov here's a quick implementation of respecting the DNT header server-side, for discussion: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventLogging/+/595005

Thu, May 7, 5:30 PM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor
DLynch closed T252134: EventLogging requires EventStreamConfig, which isn't installed as Invalid.

Hm, sorry, or maybe it is installed. The checkout has happened into extensions and running provision a few times seems to have eventually made the extension dependecy errors stop happening. So I'll go rebuild everything more thoroughly and see if that makes provision stop dying.

Thu, May 7, 5:22 PM · MediaWiki-Vagrant
DLynch created T252134: EventLogging requires EventStreamConfig, which isn't installed.
Thu, May 7, 5:13 PM · MediaWiki-Vagrant
DLynch added a comment to T252083: Treat links to user pages differently than normal wikilinks.

Links becoming out of sync with their labels is not a problem unique to user links:

Notably, we debated this general topic and behavior around it a lot while we were talking about the link-label field in the inspector in T55973.

Thu, May 7, 4:30 PM · OWC2020 (OWC2020 Replying 2.0), Editing Design, DiscussionTools, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board)
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

@mpopov there's also the visualeditor-nondefault group in config, which mostly consists of the various wikitionaries / wikisources / wikiquotes and similar... but has a few mainline wikipedias on it -- ganwiki, iuwiki, kkwiki, kuwiki, srwiki, tenwiki, tgwiki, uzwiki, and (probably the biggest?) zhwiki.

Thu, May 7, 4:27 PM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

I keep wondering if we could add a server-side EventLogging component to VE the way that WikiEditor has.

Thu, May 7, 3:34 PM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

Perhaps we could work out some sort of baseline adblocker-but-JS rate by looking at what percentage of edits are made with VE and EventLogging and seeing how that compares to our anticipated rate based on our sampling-rate? Then apply that to the WikiEditor data to compensate?

Thu, May 7, 12:12 AM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor
DLynch added a comment to T252083: Treat links to user pages differently than normal wikilinks.

Considerations:

  • Visual and source modes have different inspector behavior, and lots of our fancy behaviors will only apply to visual mode. Source mode just inserts the link wikitext -- if you put your cursor in it and deliberately trigger the inspector via the shortcut you'll see it, but it's much less amenable to the whole "you backspaced into this" stuff.
  • T250332 could result in what's inserted by the autocomplete not being a link. If it's a template, entirely different behavior applies.
Thu, May 7, 12:08 AM · OWC2020 (OWC2020 Replying 2.0), Editing Design, DiscussionTools, VisualEditor, Editing-team (Q3 2019-2020 Kanban Board)

Wed, May 6

DLynch added a comment to T251478: Create UI for in-surface auto-complete.

Actually @DLynch was right, we don't notify IPs, so they should just be removed.

Wed, May 6, 5:42 PM · Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

Client-side EventLogging respects browser do-not-track settings, and server-side doesn't. We could actually improve server-side in this regard, I think, by checking for the DNT HTTP header and treating it as equivalent to the client-side setting. That might help our tracking here.

Wed, May 6, 12:12 AM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor

Mon, May 4

DLynch added a comment to T251772: EditAttemptStep sent event with "ready_timing": -18446744073709543000.

If it's only happened once, I'm inclined to call it some sort of fluke.

Mon, May 4, 7:46 PM · Product-Analytics, Analytics-EventLogging, Analytics
DLynch added a comment to T251464: Spike : How will we Measure % of edits coming from users without JS.

I don't think that method can be relied upon, mostly because of caching.

Mon, May 4, 3:23 PM · Product-Analytics (Kanban), Editing-team (Tracking), Readers-Web-Backlog (Tracking), VisualEditor
DLynch updated subscribers of T251478: Create UI for in-surface auto-complete.

It's worth considering that the current popup styling is the OOUI MenuSelectWidget styles, so anything which we think is an improvement to general list styling / focus stuff might be worth coordinating with @Volker_E and just getting upstream.

Mon, May 4, 3:00 PM · Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor

Thu, Apr 30

DLynch added a comment to T247875: Assist with maintaining aggregate values in numerical tables.

(This sounds horrible but is actually only mildly horrible. Find the start and end of the table body (these don't change so could be shown by a marker comment), tokenize for |, ||, |-, <ref>, </ref>, <!--, -->, and process the stream with a simple state machine (in the table / in a comment / in a reference). There are a number of other states in wikitext, like inside a template or another extenstion tag, but it's reasonable to assume those won't ever be used in these tables.)

Thu, Apr 30, 5:35 PM · Readers-Web-Backlog (Tracking), covid-19, MediaWiki-General

Wed, Apr 29

DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

@Pbsouthwood Right now it'll show the popup as you're typing the email address -- I've been meaning to have it not trigger if there's a non-whitespace character immediately before the @, but haven't done so yet. Fortunately, the popup triggering doesn't inherently do/insert anything, so you can just keep typing and ignore it and it'll go away.

Wed, Apr 29, 4:13 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Apr 21 2020

DLynch added a comment to T244942: Make `unload handlers` work for contributors using NWE.

We talked about it in a meeting, and @Esanders supports the idea of making a generic hook (via mw.hook or a custom jQuery event or whatever) which VisualEditor/NWE can fire off to tell the page it's about to be taken over. This could then be registered by DiscussionTools (and other extensions like Thanks) so it can try to do a teardown there.

Apr 21 2020, 4:35 PM · Verified, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)

Apr 17 2020

DLynch added a comment to T250086: Add config override for instrumentation sampling rate.

We also haven't actually changed the event rate yet. Train was still going out until this afternoon, so we need to get a config-change patch out via a SWAT window now that's done.

Apr 17 2020, 4:25 AM · User-Ryasmeen, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), DiscussionTools

Apr 16 2020

DLynch updated the task description for T250332: Explore enabling wikis to customize what syntax is used for @ mentions.
Apr 16 2020, 1:43 AM · Editing-team (Tracking), OWC2020 (OWC2020 Replying 2.0), VisualEditor
DLynch added a comment to T250329: Show aliases in username completion list.

Here's my list-of-open-questions from T232601:

Apr 16 2020, 1:32 AM · Editing-team (Tracking), OWC2020 (OWC2020 Replying 2.0)

Apr 15 2020

DLynch added a comment to T250295: Should we display a note about automatically resolving an edit conflict?.

Two options seem to exist:

  1. Display a warning pre-submit that changes have been made, in case they want to check what was said before posting their own.
  2. Display a notice post-submit that other edits were made.
Apr 15 2020, 5:19 PM · OWC2020 (OWC2020 Replying 1.0), DiscussionTools
DLynch added a comment to T244942: Make `unload handlers` work for contributors using NWE.

Yes, section edit links are handled as well.

Apr 15 2020, 4:08 PM · Verified, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)
DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

Note: usernames will appear in the username results list exactly as they appear on the page. Meaning, if someone has a custom signature such that the username that is appended to the comments they post on talk pages [1] is different from the username that appears in the link to their user page [2], their alias will show up in the username results list. Pings to aliases will work the same way they do for non-aliases.[3]

Incorrect -- the only thing that appears in the completion list at the moment is the username that the signature links to. (I.e. the text of the link doesn't matter, just the URL it points to.)

Pings to aliases will work the same way they do for non-aliases.[3]

Only in the sense that so long as they get translated down to a link to the real username (which we don't currently do), they'll get picked up as a ping by Echo. Attempting to write @alias isn't going to do what the user expects in the current implementation.

The display text for the link should be the same as what is shown in the username results list. Which, in this case, is their alias.

But not in the current implementation.

Apr 15 2020, 5:56 AM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Apr 14 2020

DLynch added a comment to T249944: WikiEditor records all edits as platform = desktop in EventLogging.

This is slightly more complicated than just making WikiEditor detect whether it's being accessed by a mobile UA (server-side and client-side, because it's logging from both), because we'd probably still want to differentiate between MobileFrontend and WikiEditor. As-is, that desktop / phone split for platform is the only way to tell, I think.

Apr 14 2020, 4:11 PM · Product-Analytics, Editing-team (Q3 2019-2020 Kanban Board), Mobile, Analytics-Data-Quality, Analytics-EventLogging, Analytics, WikiEditor

Apr 13 2020

DLynch moved T250086: Add config override for instrumentation sampling rate from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Apr 13 2020, 3:31 PM · User-Ryasmeen, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), DiscussionTools
DLynch created T250086: Add config override for instrumentation sampling rate.
Apr 13 2020, 2:51 PM · User-Ryasmeen, Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), DiscussionTools

Apr 10 2020

DLynch added a comment to T240697: Measure % of edits coming from users without JS.

@kaldari Yeah, you beat me to it -- API requests shouldn't do any of this logging, and (assuming that the apps are both doing their logging and tagging it correctly) we can filter it down to just on-page stuff with the filter you suggested.

Apr 10 2020, 6:42 PM · Product-Analytics (Kanban), Readers-Web-Backlog (Tracking), Editing-team (Q3 2019-2020 Kanban Board), VisualEditor

Apr 8 2020

DLynch added a comment to T245628: Preview does not correctly parse five or more tildes at the end of the comment.

If nothing else, we should fix the preview.

Apr 8 2020, 6:03 PM · Verified, MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), Editing-team (Q3 2019-2020 Kanban Board), DiscussionTools, OWC2020 (OWC2020 Replying 1.0)

Mar 25 2020

DLynch claimed T244942: Make `unload handlers` work for contributors using NWE.
Mar 25 2020, 5:47 PM · Verified, MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)
DLynch moved T232601: Provide a mechanism for in-surface autocomplete from Code Review to Doing on the Editing-team (Q3 2019-2020 Kanban Board) board.
Mar 25 2020, 5:47 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Mar 18 2020

DLynch added a comment to T140871: Error thrown when deleting a heading next to a table.

I've verified that this is still happening, but I'm not actively looking at it.

Mar 18 2020, 4:17 PM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor
DLynch placed T140871: Error thrown when deleting a heading next to a table up for grabs.
Mar 18 2020, 4:17 PM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor

Mar 17 2020

DLynch updated subscribers of T247802: No reply links for any comments on Beta cluster.

It's because of @matmarex's patch on T245794 to turn it on as a beta feature on the beta cluster -- because of how T245539 implemented the beta-feature stuff, if it's in beta-features it hides unless the specific enabled-for-beta preference is set.

Mar 17 2020, 1:48 AM · User-Ryasmeen, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), DiscussionTools

Mar 11 2020

DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

Current behaviors for reference:

Mar 11 2020, 4:02 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Mar 10 2020

DLynch claimed T245781: Reply tool usually doesn't work in Safari.

I can confirm that it no longer happens for me on https://nl.wikipedia.org/wiki/Overleg_gebruiker:RYasmeen_%28WMF%29/Kladblok?dtenable=1&debug=1 (after a moment of worry before I aggressively cleared some caches).

Mar 10 2020, 10:35 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Browser-Support-Apple-Safari, DiscussionTools

Mar 5 2020

DLynch added a comment to T245781: Reply tool usually doesn't work in Safari.

For QA purposes: because of the restbase issues on beta (T246833) I don't know whether this issue could be reproduced there before this patch. So we might have to wait for it to get to production before we can know.

Mar 5 2020, 6:05 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Browser-Support-Apple-Safari, DiscussionTools
DLynch added a comment to T244874: QA replying workflow (v1.0) instrumentation.

My understanding of the current state is: almost everything is as-expected.

Mar 5 2020, 5:53 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Product-Analytics (Kanban), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)
DLynch added a comment to T240474: Performance review for the DiscussionTools extension.

I think we could squeeze it down to two (debug and everything else) if we don't mind loading both of the reply widget implementations and their dependencies at once despite only ever using one of them on a given wiki by config. That's definitely a performance trade-off, since one of them is the one which pulls in a large chunk of VisualEditor.

Mar 5 2020, 5:34 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Performance-Team, DiscussionTools
DLynch added a comment to T154844: New Wikitext Editor: Previews should use the article-view rendering engine.

@Tkarcher alas, no -- that's about how dependencies bundled with the preview markup are applied. Which parser is used makes no difference.

Mar 5 2020, 4:23 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T245781: Reply tool usually doesn't work in Safari.

Okay, it still fails on nlwiki now 1.35.0-wmf.22 has finished rolling out.

Mar 5 2020, 3:13 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Browser-Support-Apple-Safari, DiscussionTools

Mar 4 2020

DLynch added a comment to T245781: Reply tool usually doesn't work in Safari.

@matmarex Yeah, I have a patch for that locally which I made speculatively -- I just got held up on trying to prove to myself that it was making any sort of difference. That said, it probably shouldn't do anything bad to run fixBase, so I'll put it up for review anyway...

Mar 4 2020, 9:40 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Browser-Support-Apple-Safari, DiscussionTools
DLynch updated subscribers of T245781: Reply tool usually doesn't work in Safari.

So, it seems that in Safari findSignature always fails.

Mar 4 2020, 9:05 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Browser-Support-Apple-Safari, DiscussionTools
DLynch added a comment to T245781: Reply tool usually doesn't work in Safari.

Error's changed since this task was filed, and is now: "Could not find the comment you're replying to on the page. It might have been deleted or moved to another page. Please reload the page and try again."

Mar 4 2020, 5:53 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), Browser-Support-Apple-Safari, DiscussionTools

Feb 28 2020

DLynch added a comment to T246382: New EventLogging queue doesn't log events in window.unload.

And, given that times have changed since 2016 could the events possibly be attached to a more "modern" event from the page visibility API?

Feb 28 2020, 6:09 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging
DLynch added a comment to T246382: New EventLogging queue doesn't log events in window.unload.

The existing instrumentation is from VisualEditor, mostly applies to desktop, and has been in place since ~2016.

Feb 28 2020, 5:16 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging
DLynch added a comment to T246382: New EventLogging queue doesn't log events in window.unload.

I have some vague idea that this could be made better by using a promise instead..

Feb 28 2020, 4:55 AM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging

Feb 27 2020

DLynch added a comment to T244874: QA replying workflow (v1.0) instrumentation.

The not-logging issue should also currently be affecting VisualEditor, as I understand it.

Feb 27 2020, 11:59 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Product-Analytics (Kanban), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)
DLynch moved T246382: New EventLogging queue doesn't log events in window.unload from Needs Discussion / Investigation to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 27 2020, 9:33 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging
DLynch edited projects for T246382: New EventLogging queue doesn't log events in window.unload, added: Editing-team (Q3 2019-2020 Kanban Board); removed Editing-team.
Feb 27 2020, 9:33 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging
DLynch added a project to T246382: New EventLogging queue doesn't log events in window.unload: Editing-team.
Feb 27 2020, 9:32 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging
DLynch created T246382: New EventLogging queue doesn't log events in window.unload.
Feb 27 2020, 9:18 PM · User-Ryasmeen, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Analytics-Kanban, DiscussionTools, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), Analytics, VisualEditor, Analytics-EventLogging
DLynch moved T244874: QA replying workflow (v1.0) instrumentation from Blocked / Needs More Work to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 27 2020, 6:07 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Product-Analytics (Kanban), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)
DLynch added a comment to T244874: QA replying workflow (v1.0) instrumentation.

That's correct.

Feb 27 2020, 6:00 PM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Product-Analytics (Kanban), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)

Feb 26 2020

DLynch moved T230325: Make each ve.ce.ContentBranchNode track its own ve.ce.TextState from Code Review to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 26 2020, 4:05 PM · Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, Patch-For-Review, VisualEditor-ContentEditable
DLynch moved T140606: Check user signature for linter errors from Code Review to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 26 2020, 4:04 PM · Editing-team (Tracking), Patch-For-Review, OWC2020, MediaWiki-extensions-Linter, MediaWiki-User-preferences
DLynch moved T230652: Tilde stripping in signatures is inadequate from Code Review to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 26 2020, 4:04 PM · Editing-team (Tracking), Patch-For-Review, MediaWiki-Parser
DLynch moved T237700: Require user signatures to contain a link to their user page, talk page or contributions from Code Review to Blocked / Needs More Work on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 26 2020, 4:04 PM · Editing-team (Tracking), Patch-For-Review, OWC2020, MediaWiki-Parser, MediaWiki-User-preferences
DLynch moved T245576: Toggle buttons in table properties do have names missing label from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 26 2020, 4:02 PM · User-Ryasmeen, OOUI (OOUI-0.37.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Accessibility
DLynch moved T211240: Mobile table editing should default to cell contents from Code Review to Design Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 26 2020, 3:38 PM · Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, Patch-For-Review, VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T211240: Mobile table editing should default to cell contents.

@iamjessklein do you mean that in the sense that the patch for the margin is a good idea and should be merged, or that the feature is good as-is without that?

Feb 26 2020, 3:38 PM · Editing-team (Q3 2019-2020 Kanban Board), VisualEditor, Patch-For-Review, VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T244874: QA replying workflow (v1.0) instrumentation.

There's a combination of missing and questionably-applicable involved here:

Feb 26 2020, 5:44 AM · User-Ryasmeen, Verified, MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Product-Analytics (Kanban), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)

Feb 24 2020

DLynch claimed T245069: Hide generic `DiscussionTools` change tag.
Feb 24 2020, 5:02 PM · Patch-For-Review, DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)

Feb 21 2020

DLynch added a comment to T245839: API warnings on VE save.

The vetags one is being passed along for a onRecentChangeSave hook. campaign is doing similarly, but not in the VE extension itself. (You'd presumably also see dttags if you were examining a DiscussionTools save.)

Feb 21 2020, 4:39 PM · Regression, VisualEditor

Feb 20 2020

DLynch moved T243364: Instrument replying workflow (v1.0) from Doing to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
Feb 20 2020, 6:05 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), DiscussionTools, Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0)

Feb 19 2020

DLynch added a comment to T242134: Security Review For Talk pages project.

@matmarex from the way they phrased it, I get the impression it’s more “we agree that this is almost impossible to attack, but our analysis tools won’t shut up about it because they know nothing of the context things run in”. 😂

Feb 19 2020, 7:33 PM · secscrum, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Security, user-sbassett, Editing-team (Tracking), DiscussionTools, Security Readiness Reviews
DLynch added a comment to T242134: Security Review For Talk pages project.

A patch for the defensive programming on the maintenance script: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/573051

Feb 19 2020, 1:42 AM · secscrum, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Security, user-sbassett, Editing-team (Tracking), DiscussionTools, Security Readiness Reviews
DLynch added a comment to T242134: Security Review For Talk pages project.

There's a patch for the outdated packages which covers most of this: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/573048

Feb 19 2020, 1:37 AM · secscrum, MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Security, user-sbassett, Editing-team (Tracking), DiscussionTools, Security Readiness Reviews

Feb 17 2020

DLynch awarded Blog Post: Parsoid in PHP, or There and Back Again a Cup of Joe token.
Feb 17 2020, 10:38 PM · Parsoid

Feb 13 2020

DLynch added a comment to T242562: Develop a technical approach for editing a specific comment.

There's questions regarding whether we should include any sort of "this comment was edited" notice on an edited comment. Meeting discussion leans towards "no", in part because there's no good way to link to the revision history showing the change without making a second edit to add that link in.

Feb 13 2020, 6:44 PM · Editing-team (Tracking), DiscussionTools

Feb 12 2020

DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

@Mayakp.wiki I've made the very small required change to the schema here: https://meta.wikimedia.org/w/index.php?title=Schema:EditAttemptStep&type=revision&diff=19802113&oldid=19486181

Feb 12 2020, 4:15 PM · User-Ryasmeen, Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor
DLynch added a comment to T240259: Implement `unload handlers` for compose.

Yes.

Feb 12 2020, 12:11 AM · User-Ryasmeen, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.11; 2019-12-17)

Feb 11 2020

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

I did some research into hiding tags: it hides the tag entirely if the associated message is present-but-disabled. (If there's no message at all, it just shows whatever the tag name is.) Messages are disabled by setting them to literally the empty-string or to -.

Feb 11 2020, 4:46 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Verified, OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools
DLynch added a comment to T240259: Implement `unload handlers` for compose.

My theory is that @Ryasmeen has NWE enabled, and so "edit source" isn't technically a navigation event (because it's just replacing the contents of the current page). We need to special case detecting and canceling this somehow.

Feb 11 2020, 4:32 PM · User-Ryasmeen, OWC2020 (OWC2020 Replying 1.0), Editing-team (Q3 2019-2020 Kanban Board), MW-1.35-notes (1.35.0-wmf.11; 2019-12-17)

Feb 10 2020

DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

But Maya and I have spoken about it, and we know what needs to happen.

Feb 10 2020, 10:37 PM · User-Ryasmeen, Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor
DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

@DLynch talking to @ppelberg, can you confirm this ticket doesn't need to be resolved in order to implement instrumentation for 1.0 T243364

Feb 10 2020, 10:36 PM · User-Ryasmeen, Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor
marcella awarded T242184: Create a change tag for edits made using DiscussionTools a Cup of Joe token.
Feb 10 2020, 2:33 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Verified, OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Feb 7 2020

DLynch merged T244598: [Regression] Cannot reply to any comment on a Talk page, showing error "Invalid response from server." into T244586: Restbase routing down on beta, 2020-02-07.
Feb 7 2020, 7:50 PM · User-Ryasmeen, Operations, Traffic, Beta-Cluster-Infrastructure, RESTBase
DLynch merged task T244598: [Regression] Cannot reply to any comment on a Talk page, showing error "Invalid response from server." into T244586: Restbase routing down on beta, 2020-02-07.
Feb 7 2020, 7:50 PM · OWC2020, DiscussionTools
DLynch created T244592: No error message shown when restbase/parsoid is down.
Feb 7 2020, 5:58 PM · VisualEditor
DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

@Esanders: I'm actually not sure what's going on there with 1. For me, locally, exact matches are working just fine. See:

Feb 7 2020, 2:54 AM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Feb 6 2020

DLynch updated subscribers of T232601: Provide a mechanism for in-surface autocomplete.

This is pretty tight, so we should some a top margin (0.5em?) as seen in Phab:

Mm, I do agree. I've updated the patch with a top margin 0.5ex, which looked better to me than 0.5em:

Feb 6 2020, 5:05 PM · MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), Editing Design, OWC2020 (OWC2020 Replying 2.0), VisualEditor, Editing-team (Q3 2019-2020 Kanban Board), Patch-For-Review

Feb 5 2020

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

Why is it that a reply made using DiscussionTools in visual mode would receive three tags instead of two?

My initial logic was just that it'd be simpler for search, rather than anyone interested in the data having to know up front what all the possible modes were. That said, I can certainly remove the pure discussiontools tag, and you can remember when searching what the options are.

Feb 5 2020, 6:10 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Verified, OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Jan 24 2020

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

How – if at all – should the text input mode (e.g. source vs. rich text) be tracked?

Jan 24 2020, 4:39 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Verified, OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Jan 23 2020

DLynch added a comment to T243467: Changes to EditAttemptStep schema for Discussion Tools Replying V1.0.

EditAttemptStep needs to be tweaked a little so it can apply to DiscussionTools being used to edit a page. I think what's needed is:

Jan 23 2020, 6:51 AM · User-Ryasmeen, Product-Analytics, MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), Editing-team (Q3 2019-2020 Kanban Board), OWC2020 (OWC2020 Replying 1.0), VisualEditor

Jan 22 2020

DLynch added a comment to T242184: Create a change tag for edits made using DiscussionTools.

I'm working on a patch for this which will apply placeholder tags for likely edit types. The bulk of the actual technical work is adjusting the VisualEditorEdit API to allow the tags to be customized, anyway.

Jan 22 2020, 6:50 PM · MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), Verified, OWC2020 (OWC2020 Replying 1.0), OWC2020 Replying 1.0, Editing-team (Q3 2019-2020 Kanban Board), Editing Design, DiscussionTools

Jan 21 2020

DLynch placed T229887: Audit notifications received by new users upon opening the editor up for grabs.

This is more work to audit than I have time to handle. The difficulty is mostly that any random wiki could have a gadget / extension which adds a message on arbitrary criteria... and even for just the core / extension code, there's enough different ways to trigger something like this that it's a real pain to search for it happening.

Jan 21 2020, 5:25 PM · VisualEditor, Editing-team, Growth-Team