Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (441 w, 4 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Yesterday

DLynch assigned T359893: Templates which only render categories are not visible to Esanders.
Mon, Mar 18, 7:36 PM · Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
DLynch moved T359893: Templates which only render categories are not visible from Incoming to QA on the Editing-team (Kanban Board) board.
Mon, Mar 18, 7:35 PM · Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T359182: Instrument permalink timestamps.

@mpopov We haven't coordinated with them about it. That said, we've also not been touching the schemas (this patch did because desktop and mobile are inconsistent, but it wasn't necessary and so nobody has merged it), so is there actually anything to coordinate around the migration?

Mon, Mar 18, 4:07 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools

Sun, Mar 17

DLynch added a comment to T360274: #top fragment triggers DT's "This topic could not be found" notification.

e.g. https://en.wikipedia.org/wiki/User_talk:Aaron_Liu?dtenable=1&useskin=vector#top won't complain about this.

Sun, Mar 17, 11:23 PM · DiscussionTools
DLynch added a comment to T360274: #top fragment triggers DT's "This topic could not be found" notification.

It only triggers if an element with that ID isn't present on the page, which #top isn't since it's not part of the default skin, so a fun part of this is that there's a lot of semi-broken links being generated by the enwiki default signature (and that gadget).

Sun, Mar 17, 11:22 PM · DiscussionTools
DLynch added a comment to T360268: Unclosed decorative div tags on talk pages causing problems with rendering on mobile.

What's supposed to go inside that "learn more" dialog is the page's lede section if there's no comments within it. (That's why Redrose64's talk page doesn't have it hidden -- it has that "welcome" message that's signed.)

Sun, Mar 17, 8:25 PM · DiscussionTools, MobileFrontend

Thu, Mar 14

DLynch added a comment to T359943: Can't unset the group of a <ref>/<references> list in VisualEditor.

Those original lines (delete mwData.attrs.refGroup; rather than delete mwData.attrs.group;) have been that way for a very long time -- at least since 2016. Not sure if it's been broken the whole time, or if the name of the attribute coming from parsoid shifted at some point...

Thu, Mar 14, 4:36 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), WMDE-TechWish-Sprint-2024-03-13, Unplanned-Sprint-Work, VisualEditor-MediaWiki-References, VisualEditor-VisualDiffs, WMDE-TechWish-Sprint-2024-02-28, WMDE-References-FocusArea, VisualEditor
DLynch closed T358784: Newly installed extensions don't pick up localization messages as Resolved.

@Krinkle thanks for summarizing everything in the end. 👍🏻

Thu, Mar 14, 3:40 AM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker

Wed, Mar 13

DLynch added a comment to T359182: Instrument permalink timestamps.

I believe the webuiactionstracking schemas still apply sampling rates so we will be able to look at percentages but the actual numbers reported will be impacted.

Wed, Mar 13, 5:32 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch moved T360045: Cursor not visible when edit notice shown on load from Incoming to QA on the Editing-team (Kanban Board) board.
Wed, Mar 13, 5:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
DLynch assigned T360045: Cursor not visible when edit notice shown on load to Esanders.
Wed, Mar 13, 5:23 PM · Verified, MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T358784: Newly installed extensions don't pick up localization messages.

I mean, it'd be slightly slower. But it's an extremely infrequently run script anyway...

Wed, Mar 13, 5:21 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
DLynch added a comment to T358784: Newly installed extensions don't pick up localization messages.

Having it be an optional missable step feels less-ideal. Would there be any drawback to just making it be something that update.php always does?

Wed, Mar 13, 5:20 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
DLynch added a comment to T358784: Newly installed extensions don't pick up localization messages.

The difficulty here is that ConfigDependency is supposed to be a generic container for a value from any ServiceOptions config store. As such, altering its isExpired method to refetch its config store would require that it also knows which method to call to do so.

Wed, Mar 13, 4:42 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker

Fri, Mar 8

DLynch closed T352127: [Config] Enable the mobile visual editor by default for the initial set of wikis, a subtask of T351778: [MILESTONE] Offer mobile VE as default for at Edit Check partner + test wikis, as Resolved.
Fri, Mar 8, 4:38 AM · Editing-team (Kanban Board), Epic, VisualEditor
DLynch closed T352127: [Config] Enable the mobile visual editor by default for the initial set of wikis as Resolved.
Fri, Mar 8, 4:38 AM · User-notice-archive, Editing-team, Epic, VisualEditor
DLynch moved T359601: TypeError: Cannot read properties of undefined (reading 'abort') at ve.ui.CitoidInspector.performLookup from Doing to Code Review on the Editing-team (Kanban Board) board.

(I didn't notice it when testing the earlier patches because the request needs to have failed in the actual citoid lookup, rather than during the reliability check.)

Fri, Mar 8, 1:09 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), VisualEditor, Citoid, Wikimedia-production-error
DLynch claimed T359601: TypeError: Cannot read properties of undefined (reading 'abort') at ve.ui.CitoidInspector.performLookup.
Fri, Mar 8, 12:59 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), VisualEditor, Citoid, Wikimedia-production-error
DLynch added a comment to T359601: TypeError: Cannot read properties of undefined (reading 'abort') at ve.ui.CitoidInspector.performLookup.

Yes, it's related to that change.

Fri, Mar 8, 12:59 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), VisualEditor, Citoid, Wikimedia-production-error
DLynch moved T359601: TypeError: Cannot read properties of undefined (reading 'abort') at ve.ui.CitoidInspector.performLookup from Incoming to Doing on the Editing-team (Kanban Board) board.
Fri, Mar 8, 12:59 AM · MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), VisualEditor, Citoid, Wikimedia-production-error

Thu, Mar 7

DLynch closed T346837: Implement bucketing for Edit Check (references) A/B test, a subtask of T342930: [MILESTONE] Run an A/B test to evaluate Edit Check (references) impact, as Resolved.
Thu, Mar 7, 9:36 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), EditCheck, Editing-team, VisualEditor
DLynch closed T346837: Implement bucketing for Edit Check (references) A/B test as Resolved.

The bucketing implementation wound up happening tagged against T342930.

Thu, Mar 7, 9:36 PM · Product-Analytics, Editing-team
DLynch moved T352130: Report on Edit Check A/B test leading indicators from Incoming to Code Review on the Editing-team (Kanban Board) board.
Thu, Mar 7, 9:30 PM · Editing-team (Kanban Board), Patch-For-Review, Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch edited projects for T352130: Report on Edit Check A/B test leading indicators, added: Editing-team (Kanban Board); removed Editing-team (Tracking).
Thu, Mar 7, 9:30 PM · Editing-team (Kanban Board), Patch-For-Review, Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch added a comment to T359107: Copyvio Check: Prompt people pasting text to consider risk of copyright violation.

Sometimes new editors copy articles from one title to another because they do not know how Special:MovePage works, and are in fact fully unaware of it's existence. It is an false positive for an copy-paste copyvio check.

Thu, Mar 7, 6:28 PM · VisualEditor, EditCheck
DLynch added a comment to T13555: .mw-editsection links should not be part of the <h#> element.

Yeah, definitely seems like the subscribe button placement in the headers is different depending on whether visual enhancements are enabled. ext-discussiontools-init-section-subscribeButton winds up outside the h2, whereas ext-discussiontools-init-section-subscribe winds up inside it.

Thu, Mar 7, 6:04 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), User-notice, Patch-For-Review, Editing-team (Kanban Board), Web-Team-Backlog (Needs Prioritization (Tech)), Technical-Debt, Epic, Accessibility, MediaWiki-Parser
DLynch moved T338920: Discussion tool saved answer not accessible on mobile when multiple pages are included from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Mar 7, 5:21 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), MW-1.41-notes (1.41.0-wmf.15; 2023-06-27), Editing-team (Kanban Board), DiscussionTools
DLynch moved T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Mar 7, 5:14 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
DLynch moved T358962: Heading collapse button doesn't fully transition to the margin when opening mobile VE from To Triage to Triaged on the VisualEditor board.
Thu, Mar 7, 5:10 PM · Verified, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Editing-team (Kanban Board), VisualEditor, Regression, VisualEditor-MediaWiki-Mobile
DLynch moved T356157: Unable to fetch Parsoid HTML from To Triage to Triaged on the VisualEditor board.
Thu, Mar 7, 5:09 PM · Content-Transform-Team, Essential-Work, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Patch-For-Review, MediaWiki-REST-API, MediaWiki-Engineering, DiscussionTools, Parsoid, VisualEditor
DLynch moved T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference from To Triage to Triaged on the VisualEditor board.
Thu, Mar 7, 5:07 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid
DLynch moved T359527: Automatic reference to shortened URL "youtu.be" gives "unreliable site" warning, doesn't let you insert reference from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Mar 7, 3:34 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), EditCheck, VisualEditor, Citoid

Tue, Mar 5

DLynch added a comment to T359182: Instrument permalink timestamps.

Could probably hook in and make that removal of ‘markasread’ leave some trace that we could filter by if need be, but I’m also fine just not merging that patch if we don’t think we need it. (Part of the reason I made two patches. 🤩)

Tue, Mar 5, 11:31 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch updated subscribers of T359182: Instrument permalink timestamps.

@MNeisler may want to confirm that this is okay as a way to log it, also.

Tue, Mar 5, 6:09 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T359182: Instrument permalink timestamps.

https://gerrit.wikimedia.org/r/1008929 can be merged immediately and just logs when a permalink timestamp is clicked. (action: click, action_source: discussiontools.permalink-copied)

Tue, Mar 5, 6:02 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch moved T359182: Instrument permalink timestamps from Doing to Code Review on the Editing-team (Kanban Board) board.
Tue, Mar 5, 5:58 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch moved T359182: Instrument permalink timestamps from Incoming to Doing on the Editing-team (Kanban Board) board.
Tue, Mar 5, 5:36 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch claimed T359182: Instrument permalink timestamps.
Tue, Mar 5, 5:36 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T359128: Pre-/Post-analysis of mobile VE as default (partner wikis).

For the sake of precision, it set VE as the default mobile experience for: anyone who had never edited before. (Because if they had, even on desktop, they'd have a cookie/preference that we'd listen to instead.) In *practice*, this probably does boil down to new accounts and logged out accounts, with the caveat that logged out accounts do get a localStorage preference saved for the last editor used on that device.

Tue, Mar 5, 3:58 PM · Product-Analytics, Editing-team (Tracking), Epic, VisualEditor
DLynch added a comment to T359182: Instrument permalink timestamps.

Unless we want a whole new schema for this, it's probably a decent fit for <desktop/mobile>webuiactionstracking. (We already log clicks to the various add-topic buttons there.)

Tue, Mar 5, 3:52 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, Editing-team (Kanban Board), DiscussionTools

Mon, Mar 4

DLynch added a comment to T350622: Introduce a new tag to identify edits the Reference Reliability check is shown within.

Sort of iffy to do for statistics, since the only edits we can meaningfully tag are "someone was shown this, then fixed it" -- someone who bounces entirely just won't make an edit.

Mon, Mar 4, 6:42 PM · EditCheck, VisualEditor

Sun, Mar 3

DLynch added a comment to T358973: VisualEditor renders empty table rows (rows with no cells).

I think the new view is arguably more accurate -- the source is:

Sun, Mar 3, 7:38 PM · Parsoid (Tracking), VisualEditor, VisualEditor-Tables

Thu, Feb 29

DLynch moved T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well from Backlog to Triaged on the DiscussionTools board.
Thu, Feb 29, 5:55 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), DiscussionTools
DLynch moved T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well from Incoming to QA on the Editing-team (Kanban Board) board.
Thu, Feb 29, 5:54 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T358784: Newly installed extensions don't pick up localization messages.

I do feel like I did it in the sequence it said to in the installation instructions for the extension, at least.

Thu, Feb 29, 5:48 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
DLynch updated subscribers of T358784: Newly installed extensions don't pick up localization messages.
Thu, Feb 29, 5:10 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
DLynch updated subscribers of T358784: Newly installed extensions don't pick up localization messages.
Thu, Feb 29, 5:09 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker
DLynch created T358784: Newly installed extensions don't pick up localization messages.
Thu, Feb 29, 5:06 PM · MW-1.42-notes (1.42.0-wmf.23; 2024-03-19), MW-1.42-release, MediaWiki-Platform-Team, MediaWiki-Internationalization, MediaWiki-Docker

Wed, Feb 28

DLynch closed T353984: Sitenotice can appear as the preview in search results on google as Resolved.

Missed closing this because of the holidays.

Wed, Feb 28, 3:59 PM · MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Regression, SEO, MediaWiki-User-Interface
DLynch added a comment to T353911: iOS and Android - Explore adding app_install_id with edit data sent to Editattemptstep.

With that merged the apps will need to bump the schema version of EditAttemptStep that they're submitting with to 2.0.3 for this field to be present.

Wed, Feb 28, 12:56 AM · Product-Analytics (Kanban), Wikipedia-Android-App-Backlog (Android Release - FY2023-24), Wikipedia-iOS-App-Backlog

Tue, Feb 27

DLynch moved T353911: iOS and Android - Explore adding app_install_id with edit data sent to Editattemptstep from Doing to Needs Review on the Product-Analytics (Kanban) board.
Tue, Feb 27, 4:38 PM · Product-Analytics (Kanban), Wikipedia-Android-App-Backlog (Android Release - FY2023-24), Wikipedia-iOS-App-Backlog

Sat, Feb 24

DLynch added a comment to T353911: iOS and Android - Explore adding app_install_id with edit data sent to Editattemptstep.

@MNeisler no objections to that column, since we’ve not got anywhere else obvious to put that data. It should be a pretty simple change.

Sat, Feb 24, 12:24 AM · Product-Analytics (Kanban), Wikipedia-Android-App-Backlog (Android Release - FY2023-24), Wikipedia-iOS-App-Backlog

Fri, Feb 23

DLynch added a comment to T358321: When $wgArticlePath is set to '/$1', DiscussionTools does not work well.

This seems to be the wikitext your custom signature outputs:

Fri, Feb 23, 5:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), Editing-team (Kanban Board), DiscussionTools

Thu, Feb 22

DLynch claimed T352133: Instrument the reference reliability user experience.
Thu, Feb 22, 9:37 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Editing-team (Kanban Board), Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch moved T352133: Instrument the reference reliability user experience from Incoming to Code Review on the Editing-team (Kanban Board) board.
Thu, Feb 22, 9:35 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Editing-team (Kanban Board), Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch added a comment to T358261: Mobile VisualEditor inspectors have scrolling glitches on iOS.

Someone else tested on Android and didn't see this happening, so I presume it's something to do with either iOS keyboard issues or our previous attempts to mitigate said issues.

Thu, Feb 22, 6:29 PM · Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch added a project to T358261: Mobile VisualEditor inspectors have scrolling glitches on iOS: Editing-team (Kanban Board).
Thu, Feb 22, 6:12 PM · Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch created T358261: Mobile VisualEditor inspectors have scrolling glitches on iOS.
Thu, Feb 22, 6:12 PM · Editing-team (Kanban Board), VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch assigned T358248: Lists have too much spacing in VE to Esanders.
Thu, Feb 22, 4:59 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Desktop Improvements (Vector 2022), Editing-team (Kanban Board), Regression
DLynch added a comment to T354847: Citoid: Move 'insert' button to inspector header when only one result is presented.

I'd be inclined to just leave the heading as-is -- "insert the citation" sounds awkward.

Thu, Feb 22, 4:04 PM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Verified, Citoid, Editing-team (Kanban Board), EditCheck, VisualEditor

Wed, Feb 21

DLynch created T358160: Codex icons in Vector and Minerva are displaying incorrectly.
Wed, Feb 21, 11:45 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Web-Team-Backlog (FY2023-24 Q3 Sprint 3), Codex, Desktop Improvements (Vector 2022), Design-System-Team
DLynch added a comment to T358103: mwext-phpunit-coverage-patch-docker has failing core test when running code coverage checks on CheckUser extension.

The thing VE is doing that's causing database access is calling $title->getContentModel().

Wed, Feb 21, 3:11 PM · Content-Transform-Team-WIP, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), CheckUser, VisualEditor, MediaWiki-Core-Tests

Tue, Feb 20

DLynch moved T354847: Citoid: Move 'insert' button to inspector header when only one result is presented from Code Review to QA on the Editing-team (Kanban Board) board.
Tue, Feb 20, 5:31 AM · User-notice-archive, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Verified, Citoid, Editing-team (Kanban Board), EditCheck, VisualEditor

Mon, Feb 19

DLynch added a comment to T342930: [MILESTONE] Run an A/B test to evaluate Edit Check (references) impact.

I've been asked to include eswiki as well, so the config patch has been updated to add them.

Mon, Feb 19, 4:28 PM · Product-Analytics (Kanban), MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), EditCheck, Editing-team, VisualEditor

Feb 17 2024

DLynch added a comment to T357829: Encountered a `TypeError` in JavaScript code executed on multiple edit pages.

Fuller stack is:

at ve.ui.CompletionWidget.prototype.onMenuChoose 
at OO.EventEmitter.prototype.emit
at OO.ui.SelectWidget.prototype.chooseItem 
at OO.ui.MenuSelectWidget.prototype.chooseItem 
at OO.ui.SelectWidget.prototype.onDocumentKeyDown
at OO.ui.MenuSelectWidget.prototype.onDocumentKeyDown
at dispatch
Feb 17 2024, 12:01 AM · VisualEditor

Feb 16 2024

DLynch updated the task description for T357829: Encountered a `TypeError` in JavaScript code executed on multiple edit pages.
Feb 16 2024, 11:50 PM · VisualEditor
DLynch added a comment to T357742: Discussion tools indentation changed to browser default.

I think your screenshots are in reverse order? (They seem to imply that the incorrect state under "what happens" is the margin:0 one, which I think is wrong.)

Feb 16 2024, 3:42 AM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), DiscussionTools, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, MinervaNeue
DLynch added a comment to T357737: "Read as wiki page" on mobile talk page has default button styles.

Yeah, we'd had that open issue to clean this up for a while, so I figured that taking this opportunity when we were otherwise going to have to put work into fixing the feature just made sense.

Feb 16 2024, 3:35 AM · DiscussionTools, Web-Team-Backlog (Needs Prioritization (Tech)), Regression, CSS, MinervaNeue
DLynch edited projects for T357734: Visual Editor unable to be used when submitting Wikipedia:Did you know applications, added: DiscussionTools; removed VisualEditor.
Feb 16 2024, 1:44 AM · DiscussionTools

Feb 15 2024

DLynch added a comment to T357734: Visual Editor unable to be used when submitting Wikipedia:Did you know applications.

The behavior sounds basically-correct: Template isn't a namespace where you're allowed to use VisualEditor, because almost everything in that namespace is a template and VE would be extremely unhelpful for that. In this specific case there's a subpage which isn't really a template, but VE doesn't have any particular way to know about that.

Feb 15 2024, 11:55 PM · DiscussionTools
DLynch moved T280417: Converge on a single mobile talk page view from Incoming to QA on the Editing-team (Kanban Board) board.
Feb 15 2024, 11:35 PM · Verified, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Editing-team (Kanban Board), DiscussionTools
DLynch edited projects for T280417: Converge on a single mobile talk page view, added: Editing-team (Kanban Board), Editing QA; removed Editing-team (Tracking).
Feb 15 2024, 11:35 PM · Verified, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T357723: MediaWiki\Extension\DiscussionTools\Tests\ApiParseDiscussionToolsTest::testApiParseSections failure.

Bisecting indicates that it's https://gerrit.wikimedia.org/r/c/mediawiki/core/+/990744 @matmarex

Feb 15 2024, 8:49 PM · MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), ci-test-error (WMF-deployed Build Failure), DiscussionTools
DLynch added a comment to T357589: [Regression] Wikitables has unwanted border spacing on mobile.

It's already in that file, so I assume that the issue is something like that not actually being loaded on mobile. (And unifying all that would be a much bigger change...)

Feb 15 2024, 6:11 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Regression, Unplanned-Sprint-Work, Web-Team-Backlog (FY2023-24 Q3 Sprint 3), MinervaNeue
DLynch updated subscribers of T357589: [Regression] Wikitables has unwanted border spacing on mobile.

@Jdlrobson Specifically it's fallout from https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/995137 removing the generic border-collapse from all minerva tables.

Feb 15 2024, 6:04 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Regression, Unplanned-Sprint-Work, Web-Team-Backlog (FY2023-24 Q3 Sprint 3), MinervaNeue
DLynch added a comment to T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81.

@MusikAnimal Ah, thanks for working to combine disparate lists. Seems it's another of those fun "technically we own it, but nobody on the team has ever touched it" extensions.

Feb 15 2024, 5:05 PM · MW-1.39-notes, MW-1.41-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Parser, Editing-team, ImageMap, Wikimedia-production-error
DLynch added projects to T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81: Community-Tech, MediaWiki-Parser.

@Samwilson adding you/commtech since you reviewed the original patch, and ImageMap isn't in the component responsibility list.

Feb 15 2024, 4:46 PM · MW-1.39-notes, MW-1.41-notes, MW-1.40-notes, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MediaWiki-Parser, Editing-team, ImageMap, Wikimedia-production-error

Feb 12 2024

DLynch added a comment to T347644: Introduce hidden tag to identify edits when new sentences are added.

Alternately: adding a JSON blob of data to a single tag with the count of sentences, but then we'll need to write something to actually display that data since it's completely hidden by default.

Feb 12 2024, 6:10 PM · Goal, Editing-team (Kanban Board), EditCheck

Feb 9 2024

DLynch added a comment to T356519: Clarify the call to action on Edit check (references).

I can elaborate! I prefer alt 1 because the buttons don't require that you read the text to know what will happen. Makes it easier for someone who's working through a lot of suggestions to act quickly.

Feb 9 2024, 3:43 PM · EditCheck

Feb 8 2024

DLynch added a comment to T356700: Empty edit notice on visual editor of Persian Wikipedia.

@Ladsgroup thanks for handling that! (I didn't really want to try doing it myself, given my complete lack of speaking the language.)

Feb 8 2024, 8:43 PM · VisualEditor
DLynch added a comment to T356519: Clarify the call to action on Edit check (references).

For reference:

Feb 8 2024, 6:24 PM · EditCheck
DLynch moved T356983: Gallery node not highlighted after closing gallery dialog from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 8 2024, 4:52 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), VisualEditor-MediaWiki, Editing-team (Kanban Board), VisualEditor
DLynch moved T356700: Empty edit notice on visual editor of Persian Wikipedia from To Triage to Product Feedback Required on the VisualEditor board.

Akin to T337633. editnotice-0 is served on fawiki, and is:

Feb 8 2024, 4:41 PM · VisualEditor
DLynch added a comment to T354232: [Regression ?] Cannot edit the page after closing the save dialog in VE.

I can't reproduce this. Does it still happen to you?

Feb 8 2024, 4:20 PM · Editing-team, VisualEditor
DLynch assigned T356983: Gallery node not highlighted after closing gallery dialog to Esanders.
Feb 8 2024, 4:18 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), VisualEditor-MediaWiki, Editing-team (Kanban Board), VisualEditor
DLynch assigned T355865: Help popup button attached to FieldsetLayout has incorrect click target to Esanders.
Feb 8 2024, 4:16 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Editing-team (Kanban Board), VisualEditor, OOUI
DLynch moved T355865: Help popup button attached to FieldsetLayout has incorrect click target from Incoming to QA on the Editing-team (Kanban Board) board.
Feb 8 2024, 4:15 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Editing-team (Kanban Board), VisualEditor, OOUI
DLynch added a project to T355865: Help popup button attached to FieldsetLayout has incorrect click target: Editing-team (Kanban Board).
Feb 8 2024, 4:15 PM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Editing-team (Kanban Board), VisualEditor, OOUI

Feb 7 2024

DLynch added a comment to T352127: [Config] Enable the mobile visual editor by default for the initial set of wikis.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/997853 has merged, so we are now capable of doing this.

Feb 7 2024, 6:21 PM · User-notice-archive, Editing-team, Epic, VisualEditor
DLynch added a comment to T351778: [MILESTONE] Offer mobile VE as default for at Edit Check partner + test wikis.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/997853 has enabled this to occur.

Feb 7 2024, 6:20 PM · Editing-team (Kanban Board), Epic, VisualEditor

Feb 6 2024

DLynch added a comment to T356727: Add topic button showing on mobile diff view.

As I said in T332897#8721648 we could claim this is consistent with desktop behavior (which also shows "add topic" there), but the big popup button does make it land differently. In that ticket we restricted it to only action=view, but probably weren't thinking at the time about the strange state of affairs by which a diff page is also view.

Feb 6 2024, 2:05 AM · DiscussionTools, MediaWiki-Page-diffs

Feb 1 2024

DLynch added a comment to T352133: Instrument the reference reliability user experience.

(did not realize that was one of the options being considered)

Feb 1 2024, 9:27 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Editing-team (Kanban Board), Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch added a comment to T352133: Instrument the reference reliability user experience.

could that be instrumented as a separate event so we could differentiate between the reasons the notice was shown

Feb 1 2024, 9:02 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Editing-team (Kanban Board), Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch reassigned T352133: Instrument the reference reliability user experience from DLynch to MNeisler.

This doesn't really semantically align with other uses of context-show, which normally means that a context item has been shown. Here we're instead going to be notifying that a particular snippet of content was shown inside an inspector that was always going to be displayed. I'd suggest that we went with something a little more bespoke -- citation-blocked perhaps? (Could then be extended to link-blocked if we apply it to the link inspector as well...)

Feb 1 2024, 5:01 PM · Verified, MW-1.42-notes (1.42.0-wmf.20; 2024-02-27), Editing-team (Kanban Board), Product-Analytics (Kanban), EditCheck, VisualEditor
DLynch moved T356145: Unable to Expand Headings when Previewing New Page Created on Mobile from Code Review to QA on the Editing-team (Kanban Board) board.
Feb 1 2024, 4:43 PM · Verified, Editing-team (Kanban Board), Patch-For-Review, MobileFrontend (MobileFrontend (Editor))
DLynch edited projects for T356349: vector-user-links should accommodate longer user names , added: Web-Team-Backlog; removed Editing-team.
Feb 1 2024, 12:45 AM · Verified, MW-1.42-notes (1.42.0-wmf.18; 2024-02-13), Unplanned-Sprint-Work, Web-Team-Backlog (FY2023-24 Q3 Sprint 2), good first task, patch-welcome, Desktop Improvements (Vector 2022)

Jan 31 2024

DLynch added a comment to T349653: Permalink redirecting: Support plain section links.

@Jack_who_built_the_house okay, that should fix it for CD once that's deployed. 👍🏻

Jan 31 2024, 5:10 AM · Verified, MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), DiscussionTools, Editing-team (Kanban Board)
DLynch moved T356145: Unable to Expand Headings when Previewing New Page Created on Mobile from Incoming to Code Review on the Editing-team (Kanban Board) board.

Issue is a combination of two things:

Jan 31 2024, 3:56 AM · Verified, Editing-team (Kanban Board), Patch-For-Review, MobileFrontend (MobileFrontend (Editor))
DLynch claimed T356145: Unable to Expand Headings when Previewing New Page Created on Mobile.
Jan 31 2024, 3:47 AM · Verified, Editing-team (Kanban Board), Patch-For-Review, MobileFrontend (MobileFrontend (Editor))
DLynch added a comment to T356145: Unable to Expand Headings when Previewing New Page Created on Mobile.

It seems to be keyed to having followed an ?action=edit link. If I directly navigate to a #/editor/all link then it doesn't happen.

Jan 31 2024, 2:48 AM · Verified, Editing-team (Kanban Board), Patch-For-Review, MobileFrontend (MobileFrontend (Editor))