DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (120 w, 1 h)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF)

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Today

DLynch updated subscribers of T181766: [Regression] Changing image type while inserting a new image causes VE to crash.

I think this was fixed by @Esanders in c41fd90a15998f2e88a7a5a7abce8b198a826f9c.

Thu, Jan 18, 5:13 PM · VisualEditor
DLynch closed T121183: The <accesskey-save> keyboard shortcut doesn't trigger save in the Save dialog in (?) newer versions of Firefox as Resolved.
Thu, Jan 18, 4:17 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), MW-1.29-release-notes, Browser-Support-Firefox, Accessibility, VisualEditor-MediaWiki, VisualEditor

Tue, Jan 9

DLynch added a comment to T181822: VisualEditor dies on full storage, with my changes unsaved..

It's generally a 5MB quota per-host. We don't save much in VE, so it's probably something else on the host which has filled it up. (Unless there's some weird loop in storing in VE which I haven't noticed.)

Tue, Jan 9, 6:04 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), Patch-For-Review, VisualEditor

Fri, Jan 5

DLynch added a comment to T181075: When you edit a section, the URL should include a link to the section.

It's not Firefox, per-se. Rather it's related to the query in the URL. I didn't notice this happening because I was always testing with debug=true in mine, which made this not happen. Patch in a second.

Fri, Jan 5, 5:55 PM · Verified, MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Dec 19 2017

DLynch added a comment to T132745: Moving the cursor to a ToC template jumps the cursor to the bottom of the page in Firefox.

<meta>'s still there, but the bug doesn't happen any more in Firefox. Could be a Firefox change, or it could be an incidental fix from some cursoring fixes we've made in the last few months.

Dec 19 2017, 5:49 PM · User-Ryasmeen, Parsoid, VisualEditor

Dec 18 2017

DLynch added a comment to T183115: Position of mouse cursor can infer with links added via keyboard.

As I see it, the page which will be used for the link is the one with the highlight, right? It's the same behavior as if you clicked on one of those list items or used the arrow keys to scroll through them instead -- the text doesn't update to reflect the current selection, and probably shouldn't.

Dec 18 2017, 5:49 PM · VisualEditor, VisualEditor-MediaWiki-Links

Dec 14 2017

DLynch added a comment to T172476: VisualEditor fails to load if a plugin is not loadable.

Dec 14 2017, 5:37 PM · VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T172476: VisualEditor fails to load if a plugin is not loadable.

3 we can do fairly easily; the rest is harder. mw.loader.using doesn't provide any sort of granular feedback on success/failure, so we'd need to change some fairly core ResourceLoader stuff and watch out for side-effects.

Dec 14 2017, 5:19 PM · VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T181075: When you edit a section, the URL should include a link to the section.

I have a patch for this: https://gerrit.wikimedia.org/r/#/c/398285/

Dec 14 2017, 4:47 PM · Verified, MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)), User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Nov 21 2017

DLynch added a comment to T179750: Undoing after indenting a bullet/numbered list throws error "Uncaught TypeError: Cannot read property 'getSurface' of null".

Sorry, took me a bit to get back to this. Pressing undo multiple times still doesn't trigger this for me. Is it still happening for you?

Nov 21 2017, 5:34 PM · Verified, User-Ryasmeen, VisualEditor

Nov 7 2017

DLynch added a comment to T121588: data-ve-clipboard-key attribute added in wikitable.

Reproduction note: we only add the data-ve-clipboard-key span in browsers which don't support clipboardData custom data formats. This means Safari, IE (not Edge), or Firefox before version 48-ish (August 2016). It doesn't make a difference which browser you're pasting into, but it has to be copied from one of those.

Nov 7 2017, 5:23 PM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor-CopyPaste, VisualEditor
DLynch added a comment to T179750: Undoing after indenting a bullet/numbered list throws error "Uncaught TypeError: Cannot read property 'getSurface' of null".

I can't persuade this to happen with the reproduction steps given. More details?

Nov 7 2017, 4:44 PM · Verified, User-Ryasmeen, VisualEditor
DLynch added a comment to T152806: Wikitext representing an empty <tr> produces technically-invalid output.

Any reason not to decline this?

I'm of two minds. The biggest argument for it would be consistency with current output -- wikitext + Tidy removes empty <tr>s, and people write pages expecting that. But unless this gets written into wikitext + RemexHTML, Parsoid would become out of sync with that behavior whenever the switch happens.

Nov 7 2017, 4:25 PM · MediaWiki-extensions-Linter, Parsoid, Parsing-Team

Nov 2 2017

DLynch added a comment to T145252: Pasting text from Google docs into visual editor loses formatting if certain characters which look like wikitext are present.

@Deskana: A bit of searching, and all I turned up was one from the DraftsJS people which is aimed precisely at pasting Google Docs content. It's very small and narrowly tailored to the markup Google Docs produces.

Nov 2 2017, 3:30 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), VisualEditor-MediaWiki, VisualEditor-CopyPaste, VisualEditor

Nov 1 2017

DLynch added a comment to T145252: Pasting text from Google docs into visual editor loses formatting if certain characters which look like wikitext are present.

Updating on this: it's actually more consistent now! We always lose formatting on pastes from Google Docs regardless of wikitext-ish characters being present. This is because Google Docs copied HTML is really full of style.

Nov 1 2017, 5:00 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), VisualEditor-MediaWiki, VisualEditor-CopyPaste, VisualEditor

Oct 26 2017

DLynch added a subtask for T51622: Add support for (the equivalent of?) editintro and preload: T179092: Add support for nosummary parameter.
Oct 26 2017, 5:14 PM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools
DLynch added a parent task for T179092: Add support for nosummary parameter: T51622: Add support for (the equivalent of?) editintro and preload.
Oct 26 2017, 5:14 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
DLynch created T179092: Add support for nosummary parameter.
Oct 26 2017, 5:14 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Oct 24 2017

DLynch added a comment to T178933: Images shown in the link tool are very short and wide at cswiki.

To confirm, I did some testing of OOUI releases, and that icons commit does seem to have been the cause after all. The patch fixes it by increasing the specificity of our overrides so they (particularly the height) apply again.

Oct 24 2017, 9:15 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-Links
DLynch added a comment to T178933: Images shown in the link tool are very short and wide at cswiki.

I think this is further fallout from 8e31b2f27342f7fe3aa188412e719bf86249d08f.

Oct 24 2017, 7:55 PM · MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-Links

Oct 19 2017

DLynch added a comment to T126047: Black cloud upon pasting a ref into the Basic citation dialog in Safari (9 and below only?).

Well, trusting https://analytics.wikimedia.org/dashboards/browsers/, it seems Safari in its entirty has a 2.8% share on our sites this month, and only 29% of that is Safari 9 or below. So 0.812% of our overall browser usage is this.

Oct 19 2017, 4:36 PM · Browser-Support-Apple-Safari, VisualEditor-MediaWiki-References, VisualEditor-CopyPaste, VisualEditor
DLynch added a comment to T153754: Auto-generated <references /> list can't be moved in VE..

So, the situation is that we have a patch which works but is somewhat inelegant, and a proper place to do a fix but we're not sure what that fix would actually be. :D

Oct 19 2017, 3:00 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Parsoid, VisualEditor-MediaWiki-References, Cite, VisualEditor
DLynch added a comment to T153754: Auto-generated <references /> list can't be moved in VE..

I can see the argument, certainly. I did look at Parsoid's source, and I'm not sure I understand how it's supposed to be handling some of this -- it looks like it only drops the autoGenerated references if it's in a test mode, which is confusing if that's true.

Oct 19 2017, 2:09 PM · User-Ryasmeen, MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)), Parsoid, VisualEditor-MediaWiki-References, Cite, VisualEditor

Oct 16 2017

DLynch added a comment to T151021: Section(?) edit links aren't re-set-up on save, so clicking on section link opens OWE and then switches to NWE on second edit without a refresh.

I fixed something related for T159374, so this bug is now better-fixed. Current state is that in "always source" mode, the section-edit link after saving will still open visual mode.

Oct 16 2017, 5:03 PM · Verified, MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), User-Ryasmeen, Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Oct 8 2017

RandomDSdevel awarded T51622: Add support for (the equivalent of?) editintro and preload a Party Time token.
Oct 8 2017, 12:21 AM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools

Oct 3 2017

DLynch added a comment to T126649: If the selection is multiple cells on paste and the paste value is a single cell or a non-cell selection (e.g. a string of text or a template), paste the value into each cell, not just the first one.

Same question applies as in the merged task, though -- Is it the expected behavior? Google Docs doesn't do it. LibreOffice's Calc doesn't do it. Apple's Numbers does. No idea what Excel does. So it's an area where there's not really much functional consensus.

Oct 3 2017, 2:57 PM · VisualEditor-Tables, VisualEditor-CopyPaste, VisualEditor
DLynch merged task T129034: Pasting into a table selection should repeat to fill the selection into T126649: If the selection is multiple cells on paste and the paste value is a single cell or a non-cell selection (e.g. a string of text or a template), paste the value into each cell, not just the first one.
Oct 3 2017, 2:56 PM · VisualEditor-Tables, VisualEditor
DLynch merged T129034: Pasting into a table selection should repeat to fill the selection into T126649: If the selection is multiple cells on paste and the paste value is a single cell or a non-cell selection (e.g. a string of text or a template), paste the value into each cell, not just the first one.
Oct 3 2017, 2:56 PM · VisualEditor-Tables, VisualEditor-CopyPaste, VisualEditor
DLynch added a comment to T129034: Pasting into a table selection should repeat to fill the selection.

Is it the expected behavior? Google Docs doesn't do it. LibreOffice's Calc doesn't do it. Apple's Numbers does.

Oct 3 2017, 2:53 PM · VisualEditor-Tables, VisualEditor
Elitre awarded T51622: Add support for (the equivalent of?) editintro and preload a Mountain of Wealth token.
Oct 3 2017, 10:33 AM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools

Oct 2 2017

DLynch created T177238: Clicking to the left of a table that is the first node in the document twice misplaces the cursor.
Oct 2 2017, 5:16 PM · VisualEditor, VisualEditor-ContentEditable

Sep 26 2017

DLynch closed T146958: On blank lines, you can select multiple formats from the format menu; the surface only responds to the first, until there is cotent as Resolved.

This was incidentally fixed in 2ffadb015 for T151594 -- the same selection fix that stops the error also makes the format changes be noticed.

Sep 26 2017, 4:13 PM · Verified, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor, VisualEditor-EditingTools

Sep 21 2017

DLynch added a comment to T176440: Undefined variable: content in ApiVisualEditor.

Looks like I missed a path through the function. This is happening when a page that already exists is loaded with a preload parameter. Which does nothing, but it expects there to be content because preload was provided.

Sep 21 2017, 9:19 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), VisualEditor-MediaWiki, User-Ryasmeen, Patch-For-Review, VisualEditor, Wikimedia-log-errors
DLynch merged T174487: 2017 wikitext editor doesn't load if I create a new page with preload worksheet into T51622: Add support for (the equivalent of?) editintro and preload.
Sep 21 2017, 4:37 PM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools
DLynch merged task T174487: 2017 wikitext editor doesn't load if I create a new page with preload worksheet into T51622: Add support for (the equivalent of?) editintro and preload.
Sep 21 2017, 4:37 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Sep 20 2017

DLynch added a comment to T51622: Add support for (the equivalent of?) editintro and preload.

Just to confirm, now that patch has made its way to the beta cluster, the inputbox button works and gets us this:

Sep 20 2017, 8:32 PM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools
DLynch added a comment to T51622: Add support for (the equivalent of?) editintro and preload.

Ah, that's because I didn't remove preloadtitle from the unsupportedEditParams list.

Sep 20 2017, 3:13 PM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools

Sep 18 2017

DLynch updated subscribers of T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert".

Okay, bisect indicates that both the node is null error and the dialog issue were introduced by 37d1512, @dchan's TransactionProcessor patch.

Sep 18 2017, 9:59 PM · Verified, User-Ryasmeen, VisualEditor
DLynch added a comment to T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert".

@Ryasmeen: Could you check and let me know whether this happens to you on the beta cluster currently? I'm trying to work out whether I'm just having problems reproducing it, or if it's fixed, and Dan's trouble reproducing it in production makes everything ambiguous there.

Sep 18 2017, 9:12 PM · Verified, User-Ryasmeen, VisualEditor
DLynch added a comment to T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert".

Oh, also, in production that node is null error happens any time you hit enter, not just linked to the image-add.

Sep 18 2017, 4:45 PM · Verified, User-Ryasmeen, VisualEditor
DLynch added a comment to T175943: [Regression wmf.18] Cannot add any image with VE in Firefox, VE crashes upon clicking on "Insert".

I do see this in production, but not locally or in beta. Maybe we've fixed it accidentally somewhere else.

Sep 18 2017, 4:40 PM · Verified, User-Ryasmeen, VisualEditor
DLynch added a comment to T174487: 2017 wikitext editor doesn't load if I create a new page with preload worksheet .

I have https://gerrit.wikimedia.org/r/378343 in T51622 which will make this work. Could probably close this ticket as a duplicate of that one, since it's asking for the same thing.

Sep 18 2017, 2:54 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Sep 15 2017

DLynch added a comment to T51622: Add support for (the equivalent of?) editintro and preload.

That patch is very much the "better than nothing" version James suggested. It pulls the article, substitutes in the parameters, and then if it's in visual mode it runs it through Parsoid. It should be functionally-equivalent for the 2017 wikitext editor, though, since that doesn't rely on always containing valid documents.

Sep 15 2017, 9:47 PM · User-notice, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), MW-1.30-release-notes (WMF-deploy-2017-09-19 (1.30.0-wmf.19)), Patch-For-Review, VisualEditor-MediaWiki, MediaWiki-Page-editing, VisualEditor, VisualEditor-EditingTools

Sep 14 2017

DLynch added a comment to T169389: [Regression pre-wmf.8] Table context menu is appearing over table cell menu.

Okay, now we simultaneously have proper overlap:

Sep 14 2017, 8:16 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Verified-in-Phase0, Verified, VisualEditor-Tables, User-Ryasmeen, VisualEditor
DLynch added a comment to T169389: [Regression pre-wmf.8] Table context menu is appearing over table cell menu.

One second. This is my fault from c1c38136d, but I was *sure* I'd tested this as well.

Sep 14 2017, 8:10 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Verified-in-Phase0, Verified, VisualEditor-Tables, User-Ryasmeen, VisualEditor

Sep 12 2017

DLynch added a comment to T140871: Error thrown when deleting a heading next to a table.

Yeah, it's a really specific situation required to trigger it, so lower priority seems fair.

Sep 12 2017, 7:59 PM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor
DLynch reopened T140871: Error thrown when deleting a heading next to a table as "Open".

Still happens, I'm afraid:

Sep 12 2017, 7:57 PM · User-Ryasmeen, VisualEditor-DataModel, VisualEditor

Sep 11 2017

DLynch added a comment to T175417: VE table columns editing is destroyed in RTL.

...huh. I'll take a look.

Sep 11 2017, 9:19 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), User-Ryasmeen, Regression, RTL, I18n, VisualEditor

Sep 5 2017

DLynch added a comment to T174487: 2017 wikitext editor doesn't load if I create a new page with preload worksheet .

Preload is explicitly unsupported by VE and 2017 wikitext:

Sep 5 2017, 4:31 PM · VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Aug 30 2017

DLynch added a comment to T172419: Inline editing of image captions doesn't work if no caption has previously been added.

This seems to work just fine for me. Can anyone else reproduce it? (It's been a month, so we might have coincidentally fixed it.)

Aug 30 2017, 3:14 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, VisualEditor-MediaWiki-Media, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Aug 29 2017

DLynch added a comment to T172159: Inconsistencies around textbox highlighting in link inspector .

Ah, I think my own "try selecting something" phase accidentally hit some text which was a valid URL, explaining my problems.

Aug 29 2017, 3:52 PM · Verified, Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), User-Ryasmeen, VisualEditor-MediaWiki-Links, VisualEditor
DLynch added a comment to T172159: Inconsistencies around textbox highlighting in link inspector .

It seems to always be blue for me. Are you still seeing this, or...?

Aug 29 2017, 3:19 PM · Verified, Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), User-Ryasmeen, VisualEditor-MediaWiki-Links, VisualEditor

Aug 28 2017

DLynch added a comment to T172301: URLs containing quotation marks create broken links, and VisualEditor should fix them.

Funnily enough, I can't get it to break in the exact way yours is, with the link being split in half. Mine just goes to bad quote encoding instead:

Aug 28 2017, 4:18 PM · VisualEditor, VisualEditor-MediaWiki-Links

Aug 24 2017

DLynch added a comment to T123708: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor.

@Mbch331: Done that, thanks.

Aug 24 2017, 4:45 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T123708: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor.

Oh, I should also say that in February I improved our refreshing of bad edittokens functionality (8a7d44224), which might also have helped randomly fix this.

Aug 24 2017, 4:27 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T123708: Occasional "docserver-http: HTTP 404" when trying to save an edit made in the visual editor.

So, a quick skim of the Zeus mode gadget does suggest that it's doing something really messed up to the page with the edit form -- specifically, it's dumping the entire HTML of the edit page into its hidden div, including all the headers and scripts and whatnot. Since this includes various token-manipulation things, it wouldn't be surprising if this is causing problems. It's actually trying to not do this, but the method chosen was fragile and assumed the edit form markup would never change.

Aug 24 2017, 4:10 PM · User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T171422: Editing a ref causes it to disappear from the <references /> block.

I mean, I also get credit because it was probably fixed by my patch for that other bug. :D

Aug 24 2017, 3:02 PM · Verified, User-Ryasmeen, VisualEditor-MediaWiki-References, VisualEditor

Aug 23 2017

DLynch added a comment to T159529: "Often used" not shown in VisualEditor (kowiki).

Also, this is exactly the same error as T167051. @Esanders?

Aug 23 2017, 4:55 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T159529: "Often used" not shown in VisualEditor (kowiki).

So, it seems that in 미디어위키:Visualeditor-quick-access-characters.json it's seeing "{{llang||}}" as a key... and expanding the template.

Aug 23 2017, 4:44 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T159529: "Often used" not shown in VisualEditor (kowiki).

I'm calling this suspicious:

Aug 23 2017, 4:40 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T159529: "Often used" not shown in VisualEditor (kowiki).

I'm taking a look. It seems to be having a parse error on the JSON, though directly copying it locally causes nothing.

Aug 23 2017, 4:39 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), VisualEditor-MediaWiki, VisualEditor

Aug 22 2017

DLynch added a comment to T172861: VisualEditor: Provide an indication that a link is piped without requiring mouseover.

Worth bearing in mind that there's very few ways of interacting with a link which wouldn't make the popup appear. (Find/replace springs to mind.) This does mean that when you're e.g. changing [[Foo]] to [[Foo|Foo's]], the actual link target is on the screen without you needing any extra steps taken to reveal it. As such, I feel this suggestion is mostly applicable to checking for mistakes made in prior revisions.

Aug 22 2017, 4:34 PM · VisualEditor
DLynch added a comment to T173077: Clicking hyperlink and cite buttons twice breaks the editor.

I can only reproduce this on the live wikipedia. It doesn't happen locally or on beta. As such... I'd say either some gadget interaction, or it's going to go away when the next release deploy happens.

Aug 22 2017, 3:30 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)), VisualEditor-EditingTools, VisualEditor

Aug 21 2017

DLynch added a comment to T168932: Automatically generated references appear as empty in the list of all references, with an error "this.model is null".

Not quite! We also need https://gerrit.wikimedia.org/r/369949 to merge, after the core update lands.

Aug 21 2017, 3:10 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-References

Aug 16 2017

DLynch added a comment to T173239: Major loss of data when clicking outside of the "translate" editor box.

I don't know -- with a "done" button present, I'd expect just clicking outside the popup to be a cancel operation. That said, having made changes in the popup, asking the user to confirm that they want to discard those changes might make sense.

Aug 16 2017, 2:46 PM · MediaWiki-extensions-Translate, VisualEditor

Jul 31 2017

DLynch added a comment to T169136: Drag and drop (cut and paste) didn't work in Chrome.

Ed did track down what was causing this in Safari (T168901), so there's a chance there's a related-but-harder-to-trigger Chrome issue. Webkit cousins, and all.

Jul 31 2017, 2:36 PM · VisualEditor-CopyPaste, VisualEditor

Jul 25 2017

DLynch created T171650: RESTBase fails to start in MW-Vagrant.
Jul 25 2017, 8:36 PM · Patch-For-Review, RESTBase, MediaWiki-Vagrant
DLynch reopened T168932: Automatically generated references appear as empty in the list of all references, with an error "this.model is null" as "Open".

Okay, I need to look at this more. Get Citoid working properly on my VM again, for one thing, which I had been putting off.

Jul 25 2017, 4:38 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-References

Jul 24 2017

DLynch added a comment to T168932: Automatically generated references appear as empty in the list of all references, with an error "this.model is null".

@Deskana Looks like I actually missed a call to it in that patch, and it needs one more. One second.

Jul 24 2017, 4:30 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-References
DLynch added a comment to T166228: [Regression wmf.2] "Uncaught TypeError: Cannot read property 'getDocument' of null" appears after adding any citation.

Oh hey, I think this is T168932 as well. (Same error, at least.)

Jul 24 2017, 4:26 PM · User-Ryasmeen, VisualEditor
DLynch added a comment to T171422: Editing a ref causes it to disappear from the <references /> block.

Presumably related to T168932.

Jul 24 2017, 4:07 PM · Verified, User-Ryasmeen, VisualEditor-MediaWiki-References, VisualEditor

Jul 17 2017

DLynch added a comment to T138715: Welcome to Wikipedia message is shown even if page is protected.

Aha, I see what's different. One second.

Jul 17 2017, 10:16 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), User-Urbanecm, VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T138715: Welcome to Wikipedia message is shown even if page is protected.

@Ryasmeen: I can't reproduce that. Does your beta cluster account have any special privileges?

Jul 17 2017, 9:50 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)), User-Urbanecm, VisualEditor-MediaWiki, VisualEditor

Jul 13 2017

DLynch added a comment to T168932: Automatically generated references appear as empty in the list of all references, with an error "this.model is null".

That's *a* fix. A better one would be to finally fix T64682 and avoid the hack with the destroyed node in the first place. Or at least adjust MWReferencesListNode to delay the destroy calls -- sticking them behind a setTimeout would be adding a hack on top of a hack, but would probably also work.

Jul 13 2017, 4:41 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-References
DLynch added a comment to T168932: Automatically generated references appear as empty in the list of all references, with an error "this.model is null".

I think this is jQuery promise-async changes biting us again. MWReferencesListNode does a terribly hacky thing to generate the reference HTML and then put it in the list, by creating and then immediately destroying another node. The API call the generated node makes to build the reference HTML has a callback which assumes that there's a model available. Before the async promise change, this would have been true, as it would have been resolving immediately before the destroy could happen.

Jul 13 2017, 4:33 PM · MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), Patch-For-Review, User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-References

Jul 11 2017

DLynch added a comment to T169925: [Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'getTokens' of null" appears after adding a Code block for the second time or re-editing it.

I can see it happening, but it's definitely deep inside the ace editor component, and nothing surrounding this seems to have actually changed in the last few months.

Jul 11 2017, 4:48 PM · User-Ryasmeen, VisualEditor

Jul 10 2017

DLynch added a comment to T169844: [Regression pre-wmf.8] "Uncaught TypeError: Cannot read property 'resolve' of null" appears after re-using a reference.

I had some trouble reproducing this, until I realized that it only happens if Citoid is present -- the basic Cite extension reuse works just fine.

Jul 10 2017, 2:52 PM · Verified-in-Phase0, Verified, User-Ryasmeen, VisualEditor-MediaWiki-References, VisualEditor

Jul 6 2017

DLynch claimed T169389: [Regression pre-wmf.8] Table context menu is appearing over table cell menu.
Jul 6 2017, 3:09 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Verified-in-Phase0, Verified, VisualEditor-Tables, User-Ryasmeen, VisualEditor
DLynch added a comment to T169389: [Regression pre-wmf.8] Table context menu is appearing over table cell menu.

Yeah, bisect points to 73ce638f11.

Jul 6 2017, 3:04 PM · MW-1.30-release-notes (WMF-deploy-2017-09-12_(1.30.0-wmf.18)), Patch-For-Review, Verified-in-Phase0, Verified, VisualEditor-Tables, User-Ryasmeen, VisualEditor
DLynch added a comment to T169272: [Regression pre-wmf.8] VE crashes while opening Gallery and some other dialogs .

@Schnark: I actually did a little bit of looking into changing the prototype on the returned object, and I sadly realized it's impossible in IE10, which has neither Object.setPrototypeOf nor __proto__. If not for that it'd be workable, albeit horrific. (Though admittedly I didn't confirm that it wouldn't do something weird mid-constructor.)

Jul 6 2017, 2:13 PM · Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Verified, User-Ryasmeen, VisualEditor-MediaWiki, MediaWiki-Gallery, VisualEditor

Jul 3 2017

DLynch added a comment to T130434: Break up TextInputWidget.

So, important note about returning things from an object constructor: it breaks OOjs subclassing unless the subclasses are written to expect it. (And nobody does that.) This caused T169272, which was the issue Krinkle mentioned in the previous comment.

Jul 3 2017, 8:58 PM · Technical-Debt, OOUI
DLynch added a comment to T169272: [Regression pre-wmf.8] VE crashes while opening Gallery and some other dialogs .

To elaborate, I think the reason the deprecation didn't work is that it relied on returning a new OO.ui.MultilineTextInputWidget from TextInputWidget's constructor, and our WhitespacePreservingTextInputWidget emphatically didn't expect this (technically valid but unusual) possibility. As such, the widget we created effectively never had the parent constructor run on it, and all the expected properties were therefore missing.

Jul 3 2017, 8:00 PM · Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Verified, User-Ryasmeen, VisualEditor-MediaWiki, MediaWiki-Gallery, VisualEditor
DLynch added a comment to T169272: [Regression pre-wmf.8] VE crashes while opening Gallery and some other dialogs .

Also, I don't think that's quite the standard meaning of "deprecating change", insofar as it outright broke the functionality...

Jul 3 2017, 4:55 PM · Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Verified, User-Ryasmeen, VisualEditor-MediaWiki, MediaWiki-Gallery, VisualEditor
DLynch claimed T169272: [Regression pre-wmf.8] VE crashes while opening Gallery and some other dialogs .

Seems to be fallout from 1eb25592c removing multiline support from TextInputWidget. Only landed in OOui in 0.22.2, so it's only been visible in VE since 52e9cc34 on the 29th.

Jul 3 2017, 4:49 PM · Verified-in-Phase0, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), Verified, User-Ryasmeen, VisualEditor-MediaWiki, MediaWiki-Gallery, VisualEditor

Jun 29 2017

DLynch added a comment to T164584: Close widget for 'you switched editor' weirdly positioned.

This should, in fact, all be better now. Releases having happened, and all.

Jun 29 2017, 4:57 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor

Jun 10 2017

DLynch added a comment to T166593: URLs to a WMF site get converted to local links, even when they're not, in Safari (but not Chrome or Firefox).

Further digging: the deepest cause of this seems to be that a number of our wikis have a protocol-relative URL configured. So the parsoid response includes <base href="//office.wikimedia.org/wiki/">. Spec is... ambiguous about permitting this. In practice, Safari freaks out, and its error behavior isn't something that our fixupBase method catches. So: patch for fixupBase incoming.

Jun 10 2017, 5:00 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor

Jun 9 2017

DLynch added a comment to T166593: URLs to a WMF site get converted to local links, even when they're not, in Safari (but not Chrome or Firefox).

Okay! The specific issue with the baseURI is because using DomParser doesn't propagate the parent document's URL. It looks like this was a webkit issue, which was fixed in Chromium browsers in March.

Jun 9 2017, 9:33 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor
DLynch added a comment to T166593: URLs to a WMF site get converted to local links, even when they're not, in Safari (but not Chrome or Firefox).

Further investigation reveals that it's a problem (sort of) with ve.dm.MWInternalLinkAnnotation.static.getTargetDataFromHref. In Safari it's being passed a document whose baseURI is about:blank. In other browsers it's https://office.wikimedia.org/wiki/. The former seems to result in us constructing a regexp for which basically anything which contains /wiki/ is considered an internal link.

Jun 9 2017, 8:19 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor
DLynch added a comment to T166593: URLs to a WMF site get converted to local links, even when they're not, in Safari (but not Chrome or Firefox).

Okay, yeah, Safari-specific and I can reproduce it there. Doesn't happen in Chrome, so it's not just webkit-family stuff.

Jun 9 2017, 7:37 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor

Jun 6 2017

DLynch added a comment to T166593: URLs to a WMF site get converted to local links, even when they're not, in Safari (but not Chrome or Firefox).

Well, to be fair, it still doesn't get turned into [[mw:Editing]], but it does become a valid external link.

Jun 6 2017, 3:49 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor
DLynch added a comment to T166593: URLs to a WMF site get converted to local links, even when they're not, in Safari (but not Chrome or Firefox).

I cannot reproduce this. Is it still happening to you?

Jun 6 2017, 3:48 PM · User-Ryasmeen, Browser-Support-Apple-Safari, VisualEditor-CopyPaste, VisualEditor

Jun 5 2017

DLynch added a comment to T166228: [Regression wmf.2] "Uncaught TypeError: Cannot read property 'getDocument' of null" appears after adding any citation.

I haven't been able to reproduce this either, Chrome or Firefox. More detailed reproduction steps? (I also don't get that missing/empty |title error you have, also using bbc.co.uk, which may be related.)

Jun 5 2017, 11:28 PM · User-Ryasmeen, VisualEditor

Jun 1 2017

DLynch added a comment to T154019: Pasting URLs is slow in new wikitext editor.

I think T163237 was a duplicate of this, and thus this one is fixed as well?

Jun 1 2017, 4:41 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), Performance, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

May 24 2017

DLynch added a comment to T163510: OO.ui.alert|confirm|prompt don't work properly with jQuery 3.2.1.

Similarly, the transclusion dialog fails after you hit "insert", for what seems to be related reasons.

May 24 2017, 4:59 PM · OOUI (OOjs-UI-0.22.0), Patch-For-Review

May 21 2017

DLynch added a comment to T165892: [Regression pre-wmf.2] Context menu for table is appearing for template node.

I don't see this happening:

May 21 2017, 9:19 AM · VisualEditor-MediaWiki-Templates, VisualEditor-Tables, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), User-Ryasmeen, VisualEditor

May 19 2017

DLynch added a comment to T163536: OO.ui.ComboBoxInputWidget should scroll back to the top if no exact match is found after filtering via filterFromInput: true.

This wound up in v0.21.3, which was updated in MW core in adf31f97.

May 19 2017, 3:54 PM · User-Ryasmeen, MW-1.30-release-notes (WMF-deploy-2017-05-23_(1.30.0-wmf.2)), OOUI, VisualEditor, SyntaxHighlight
DLynch added a comment to T164584: Close widget for 'you switched editor' weirdly positioned.

Okay, it'll be better once the next OOjs-UI release happens.

May 19 2017, 2:45 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor
DLynch added a comment to T165746: Grammarly and VisualEditor.

I can't make this happen. Did you do anything interesting to the table first?

May 19 2017, 12:57 PM · User-Ryasmeen, VisualEditor
DLynch added a comment to T141174: [Regression] Link to editing help shown below edit form for JS/CSS pages.

If we wanted to hide it, we could add the hiding CSS to CodeEditor's styles. However, I don't know if we do? Reason it's hidden in WikiEditor is that there's a toolbar button for help, whereas JS pages that trigger CodeEditor don't have one unless you deliberately switch back to WikiEditor first.

May 19 2017, 12:55 PM · WikiEditor, Regression
DLynch claimed T164584: Close widget for 'you switched editor' weirdly positioned.

Floating the close button caused problems when long popup headers were being used.

May 19 2017, 12:19 PM · Verified-in-Phase2, Verified-in-Phase0, Verified, User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor