Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (312 w, 1 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Yesterday

DLynch added a comment to T291691: Add a link to jump into category-editing mode.

We also very-recently added a highlight to the category box when in VE mode, to bring it in line with other editable block elements in VE.

Fri, Sep 24, 2:28 PM · Patch-For-Review, Editing-team, VisualEditor
DLynch added a comment to T287098: Ensure discussiontools markup is hidden by CSS when parser split is removed.

@ppelberg Yes, that's the patch that was written for T273072.

Fri, Sep 24, 2:25 PM · User-Ryasmeen, Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T291691: Add a link to jump into category-editing mode.

That patch is very much a quick prototype that didn't consider any edge cases. A little thought would need to be put into e.g. "what if the user's launching VE for the first time and is going to get the Welcome dialog".

Fri, Sep 24, 2:20 PM · Patch-For-Review, Editing-team, VisualEditor
DLynch created T291691: Add a link to jump into category-editing mode.
Fri, Sep 24, 2:14 PM · Patch-For-Review, Editing-team, VisualEditor
DLynch moved T253082: Enhance mention notifications with DiscussionTools (link directly to the comment and highlight it) from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Fri, Sep 24, 2:14 AM · MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Editing QA, MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, Notifications, Growth-Team, DiscussionTools
DLynch moved T281590: Enhance own user talk page comment notifications with DiscussionTools (display a snippet, link directly to the comment and highlight it) from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Fri, Sep 24, 2:14 AM · Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Wed, Sep 22

DLynch added a comment to T291590: DiscussionTools markup appears in dropdowns on Special:MediaSearch.

@egardner If we're just fixing the use of parse in MediaSearch, I think it'd be quicker to do that (and backport it) than to revert the DiscussionTools patch.

Wed, Sep 22, 9:18 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Structured-Data-Backlog, SDAW-MediaSearch
DLynch added a comment to T291590: DiscussionTools markup appears in dropdowns on Special:MediaSearch.

Message does contains setInterfaceMessageFlag whose documentation seems to suggest it exists entirely to restore the interface behavior after setting a language. We could probably add that to the call chain in ResourceLoaderContext? I'm unsure of whether that'd cause side-effects we care about...

Wed, Sep 22, 8:47 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Structured-Data-Backlog, SDAW-MediaSearch
DLynch added a comment to T289795: Understand impact of Apple's Relay Service.

I would suspect that these IPs wouldn't be producing many (any?) automated actions, as inherently any requests from them should be coming from inside a Safari browser.

Wed, Sep 22, 8:42 PM · Analytics, User-Johan, Product-Analytics (Kanban), Wikipedia-iOS-App-Backlog
DLynch added a comment to T291002: Add a link to preferences within the Reply and New Discussion Tools.

I also agree about keeping it the same every time. (And avoiding extra storage.)

Wed, Sep 22, 8:28 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T291536: [SPIKE] How can we ensure the only people excluded from the A/B Test are those who have used the New Discussion Tool before?.

Specifically whatever metric we use shouldn't collide with anything that's set by the reply tool. E.g. "discussiontools-editmode preference is empty" would get us only people who had never used either the new discussion or reply tools.

Wed, Sep 22, 6:01 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T291002: Add a link to preferences within the Reply and New Discussion Tools.

I think that's a bunch of new-functionality requested for the core Special:Preferences page? (Linking to specific subsections, and adding some sort of first-run experience for said links.)

Wed, Sep 22, 5:44 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Tue, Sep 21

DLynch updated subscribers of T289795: Understand impact of Apple's Relay Service.

I was talking with @Urbanecm about this around mid-August, and they did some log-analysis. At that time, ~30% of beta users of iOS 15 visiting wikipedias were using Private Relay. That's perhaps a high-water mark, as I'd suspect that the sort of person who installs a beta OS is also relatively more-likely to be paying Apple for extra storage.

Tue, Sep 21, 11:06 PM · Analytics, User-Johan, Product-Analytics (Kanban), Wikipedia-iOS-App-Backlog
DLynch moved T291460: History view of talk pages displays incorrectly (entries split over multiple lines) from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Sep 21, 5:11 PM · Verified, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T291459: Reply link brackets appear in the preview while replying using reply tool in source mode from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Sep 21, 5:11 PM · Verified, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T291085: redlink=1 not respected in zhwiki from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.

You should be able to test this on beta using the links in matmarex's earlier post. Given the patch that was written, it'd be good if we could test anything you can think of around the empty-state display, with and without discussiontools enabled -- if we got the logic wrong, it could manifest as either the "edit" page appearing like the regular article view, or as the empty-state version not being shown.

Tue, Sep 21, 4:33 PM · Editing QA, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Regression, Chinese-Sites
DLynch added a comment to T290931: Log save_success_timing in DiscussionTools.

init_timing isn't particularly meaningful -- all the other timings are defined as "time since some other event", but init is the first event. We also try to log the init event basically-immediately after the click that triggers the session, so there's not much to record. (In DT it'd be bimodal -- either it'd be instant, or it'd take a few hundred milliseconds as we animate the closing of a different open reply widget.)

Tue, Sep 21, 3:14 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T290185: API to get the status of topic subscriptions on a page (action=discussiontoolsgetsubscriptions) from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Sep 21, 4:30 AM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Mon, Sep 20

DLynch added a comment to T291307: Implement New Discussion Tool A/B test bucketing.

In this context, "not used" is being defined as people whose discussiontools-editmode preference is empty.

Mon, Sep 20, 6:13 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
DLynch added a comment to T291085: redlink=1 not respected in zhwiki.

Yeah, looks like the onGetActionName hook should be a little smarter about this?

Mon, Sep 20, 5:14 PM · Editing QA, MW-1.38-notes (1.38.0-wmf.2; 2021-09-28), Editing-team (FY2021-22 Kanban Board), DiscussionTools, Regression, Chinese-Sites

Thu, Sep 16

DLynch moved T286954: Clarify the difference between "Talk page message" and "Talk page subscription" (on Special:Preferences → Notifications) from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Sep 16, 10:14 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Growth-Team, Notifications
DLynch moved T287547: Enable email delivery of topic subscription notifications for new users by default from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Sep 16, 5:10 AM · Editing QA, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020

Wed, Sep 15

DLynch added a comment to T290712: Determine how – if at all – the "Watch this page" checkbox relates to Topic Subscriptions.

We could probably do some analysis on this after it's available -- see whether watchlisting of talk pages drops noticeably? If so that'd be a good sign that removing the watchlist item would be a good idea.

Wed, Sep 15, 4:32 PM · Patch-For-Review, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Tue, Sep 14

DLynch added a comment to T285588: Investigate iOS 15's impact on VE (mobile and desktop).

iOS 15 will be out on September 20th: https://www.apple.com/newsroom/2021/09/apple-unveils-iphone-13-pro-and-iphone-13-pro-max-more-pro-than-ever-before/ (tucked away in the pricing and availability section)

Tue, Sep 14, 6:29 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, Editing-team
DLynch added a comment to T290931: Log save_success_timing in DiscussionTools.

Incidentally, we should still be able to (mostly) compare this new data after this merges to historical data -- the timing added to saveSuccess/saveFailure should be about equal to the time between the saveIntent and saveSuccess/saveFailure events in a given session. (With any difference being very minor and down to transmission time, I'd think.) This would be a more complicated query for Megan to run, but...

Tue, Sep 14, 4:24 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T284673: Determine best practices for communicating between VE and other UI components.

Depends a bit on the use-case of the integration, I think.

Tue, Sep 14, 1:05 AM · Design-Systems-team-project, Editing-team
DLynch added a comment to T290931: Log save_success_timing in DiscussionTools.

@ppelberg I don't know of a specific place. Thus far everything we're logging is the same as for VisualEditor -- it's the same two editing-related schemas. (This will change as the new instrumentation is about to add a commenting-specific schema.)

Tue, Sep 14, 12:46 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T290931: Log save_success_timing in DiscussionTools from Code Review to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.
Tue, Sep 14, 12:44 AM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Mon, Sep 13

DLynch added a comment to T290514: Reply tool has gotten slower?.

Note that it won't be perfectly comparable, since we've made the http error more granular so we can distinguish subtypes. http in the earlier logs will be comparable to http-[various-numbers] + timeout + abort + parsererror.

Mon, Sep 13, 5:21 PM · MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T279217: TypeError: undefined is not an object (evaluating 'this.mediaUploadBooklet.setFile') from Ready to Be Worked On to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.

This would appear to have completely stopped as of August 27th, which lines up nicely with the deployment.

Mon, Sep 13, 4:16 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), JavaScript, MinervaNeue (Tracking), Mobile, Wikimedia-production-error, VisualEditor
DLynch moved T279313: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackCommand.execute from Ready to Be Worked On to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.

This would appear to have completely stopped as of August 27th, which lines up nicely with the deployment.

Mon, Sep 13, 4:16 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Skipped QA, Editing-team (FY2021-22 Kanban Board), VisualEditor, Mobile, Wikimedia-production-error

Tue, Sep 7

DLynch added a comment to T288741: Talk Page Empty State: write English copy for translation.

My assumption was the same as @matmarex -- but I admit I didn't confirm it before implementing.

Tue, Sep 7, 3:25 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), DiscussionTools, Editing-team (FY2021-22 Kanban Board)

Mon, Sep 6

DLynch added a comment to T244609: [[officewiki:Contact list]] fails to load in VE since it receives a HTTP 504 from the server.

We saw some complaints of this again today on Slack, or at least a presumably very similar one where it's erroring with "Error contacting the Parsoid/RESTBase server: (curl error: 28) Timeout was reached". Couldn't reproduce it myself, though I was trying a few hours later, so it might have been some intermittent issue.

Mon, Sep 6, 3:33 PM · VisualEditor, Performance-Team (Radar), Editing-team (Tracking), Parsoid, Performance Issue

Thu, Sep 2

DLynch moved T287547: Enable email delivery of topic subscription notifications for new users by default from Code Review to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Sep 2, 7:29 PM · Editing QA, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
DLynch moved T288316: Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable) from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Sep 2, 7:28 PM · Verified, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T287901: Revise empty Title field warning message display logic from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Thu, Sep 2, 7:28 PM · Verified, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Wed, Sep 1

DLynch moved T284472: Empty reference list disappears while editing in VisualEditor from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Wed, Sep 1, 4:32 PM · Verified, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), VisualEditor
DLynch added a comment to T290112: The default mode for Reply tool is not consistent for logged out users on beta ko.wp.

I've also looked through this, and can't see how this would be happening. It'd have to involve something like different user-preferences or cookies showing up to different anon requests. Caching issue, maybe?

Wed, Sep 1, 4:10 PM · Beta-Cluster-Infrastructure, DiscussionTools

Fri, Aug 27

DLynch added a comment to T289354: Double deletion log in New Discussion Tool.

Bartosz did some quick searching and didn’t turn anything up. However, worst case it’ll be the status quo for editing a talk page, I think — with “opening the new topic widget” standing in for “navigating to the source edit page”.

Fri, Aug 27, 11:38 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Thu, Aug 26

DLynch added a comment to T289354: Double deletion log in New Discussion Tool.

Patch won't affect the user-not-registered case, as that's not a warningbox. (It's solely targetable as .mw-userpage-userdoesnotexist error, but it could easily be added in to the same behavior.)

Thu, Aug 26, 7:31 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch claimed T289354: Double deletion log in New Discussion Tool.
Thu, Aug 26, 7:26 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T289354: Double deletion log in New Discussion Tool.

Ahh, okay. I misinterpreted it as "hide it on pages where the empty state is showing", sorry. That sounds like a reasonable approach to me -- splitting the difference.

Thu, Aug 26, 6:04 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T289354: Double deletion log in New Discussion Tool.

The disadvantage to hiding the original notice seems to be that it conceals information that people who don't want to add a topic might still want to see, with no indication that it'll be present before you click the button.

Thu, Aug 26, 5:55 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T289354: Double deletion log in New Discussion Tool.

The notice is recreate-moveddeleted-warn.

Thu, Aug 26, 5:45 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T289354: Double deletion log in New Discussion Tool.

Any reason not to just add it to the list-o-suppressed-notices? (So the second one in the new-topic widget won't show up.)

Thu, Aug 26, 5:44 PM · Verified, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Aug 26 2021

DLynch added a comment to T288741: Talk Page Empty State: write English copy for translation.

Can't speak for the spelling-out-that-it's-public part, but I know that the link in the article-talk's title was deliberately removed because I asked about it as well. The desc and desc-user messages starting with similar text seems reasonable to me, and they do split into being page/user specific after that opening blurb.

Aug 26 2021, 12:03 AM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), DiscussionTools, Editing-team (FY2021-22 Kanban Board)

Aug 25 2021

DLynch moved T287779: Create empty state mockups for user talk pages (logged out) from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 25 2021, 7:36 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T288741: Talk Page Empty State: write English copy for translation from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 25 2021, 7:36 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), DiscussionTools, Editing-team (FY2021-22 Kanban Board)
DLynch moved T288556: Create empty state mockups for *own* user talk page (logged out) from Ready to Be Worked On to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 25 2021, 7:36 PM · MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T285588: Investigate iOS 15's impact on VE (mobile and desktop).

Good news on the “lots of mobile readers being IP-blocked” front, though: private relay will be off by default initially, though it sounds like they plan to flip that later in the 15 cycle.

Aug 25 2021, 6:33 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, Editing-team
DLynch added a comment to T287801: Deploy config to introduce manual topic subscriptions as Beta Feature at Phase 2 projects.

In Special:Preferences#mw-prefsection-betafeatures: the Discussion tools beta feature should contain a list item that reads: Receive notifications when new comments are added in sections you have subscribed to.

Aug 25 2021, 4:05 PM · User-Ryasmeen, Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
DLynch added a comment to T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation.

@MNeisler Thanks for checking -- let me go nudge this and see whether it's just logging being disabled, or if something else needs to happen to the schema...

Aug 25 2021, 1:52 AM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki

Aug 24 2021

DLynch reassigned T289324: [SPIKE] What percentage of Senior Contributors have email delivery turned on for Echo notifications? from DLynch to MNeisler.
Aug 24 2021, 5:10 PM · Editing-team (Tracking), Product-Analytics, Editing Design, DiscussionTools, OWC2020
DLynch added a comment to T285588: Investigate iOS 15's impact on VE (mobile and desktop).

Whereas the appearance as of beta 6 lets you just toggle approximately the current iOS 14 location bar between the top/bottom:

Safari-redesign-iOS-15-beta-6.jpg (1×3 px, 925 KB)

Aug 24 2021, 5:00 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, Editing-team
DLynch added a comment to T285588: Investigate iOS 15's impact on VE (mobile and desktop).

By "floating-oval" are you referring to how the address bar currently behaves[i]?

Aug 24 2021, 4:59 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, Editing-team
DLynch added a comment to T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation.

Having checked, I don't see any validation errors showing up referencing the integration field. If @MNeisler could confirm we're actually seeing events getting logged with integration==contenttranslation, this'll be done.

Aug 24 2021, 4:55 PM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki

Aug 23 2021

DLynch added a comment to T289324: [SPIKE] What percentage of Senior Contributors have email delivery turned on for Echo notifications?.

@MNeisler Sure! They're:

Aug 23 2021, 8:23 PM · Editing-team (Tracking), Product-Analytics, Editing Design, DiscussionTools, OWC2020
DLynch updated subscribers of T289324: [SPIKE] What percentage of Senior Contributors have email delivery turned on for Echo notifications?.

@MNeisler do you have access to querying the unfiltered user_properties? None of the properties here are in the filtered version.

Aug 23 2021, 5:08 PM · Editing-team (Tracking), Product-Analytics, Editing Design, DiscussionTools, OWC2020
DLynch added a comment to T285588: Investigate iOS 15's impact on VE (mobile and desktop).

As betas progress, the iOS Safari address bar has become less visually-radical, but now can be toggled to being either on the top or bottom. This seems easier to cope with than the floating-oval, but we should make sure that this doesn't cause any strange offset issues with e.g. mobile context items.

Aug 23 2021, 1:57 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, Editing-team

Aug 19 2021

DLynch added a comment to T287547: Enable email delivery of topic subscription notifications for new users by default.

Could we just change the default for existing users. It's a beta-feature and there's almost no users with subscriptions yet -- locking ourselves into creating preferences rows for all new users forevermore seems sub-optimal.

Aug 19 2021, 8:21 PM · Editing QA, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
DLynch claimed T287547: Enable email delivery of topic subscription notifications for new users by default.
Aug 19 2021, 5:32 PM · Editing QA, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
DLynch added a comment to T287547: Enable email delivery of topic subscription notifications for new users by default.

So, that patch changes the default for everyone. "Only affect new users" is a pain, because preferences.

Aug 19 2021, 5:31 PM · Editing QA, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), Editing-team (FY2021-22 Kanban Board), Editing Design, DiscussionTools, OWC2020
DLynch moved T289187: Repetitive text in "Discussion pages" preferences from Needs Discussion / Investigation to QA on the Editing-team (FY2021-22 Kanban Board) board.
Aug 19 2021, 2:42 PM · Verified, MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Aug 18 2021

DLynch moved T279313: TypeError: null is not an object (evaluating 've.init.target.tryTeardown') / TypeError: Cannot read property 'tryTeardown' of null at VeUiMWBackCommand.ve.ui.MWBackCommand.execute from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Aug 18 2021, 4:30 PM · MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Skipped QA, Editing-team (FY2021-22 Kanban Board), VisualEditor, Mobile, Wikimedia-production-error
DLynch added a comment to T280051: Make mobilefrontend talk overlay disableable.

Context: the remaining patch can't be merged until Peter approves merging the entire enabled-on-mobile patch stack.

Aug 18 2021, 4:23 PM · MW-1.37-notes (1.37.0-wmf.11; 2021-06-21), Patch-For-Review, MinervaNeue, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Aug 17 2021

DLynch moved T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation from Code Review to Blocked / Needs More Work on the Editing-team (FY2021-22 Kanban Board) board.

This should probably be verified once the train has gone out -- just double-checking that (a) @MNeisler seeing if there are events which are being stored with the appropriate integration, and (b) me making sure that we don't get some spike in schema validation errors in logstash. (I normally wouldn't worry, but this is the first time I've had to update one of the new-style schemas, so there's at least a chance I've missed something.)

Aug 17 2021, 2:10 AM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki
DLynch moved T262107: Create a hidden revision tag for talk page comments from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Aug 17 2021, 2:05 AM · Verified, MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), DiscussionTools, OWC2020
DLynch added a comment to T285588: Investigate iOS 15's impact on VE (mobile and desktop).

There's a little on-wiki discussion of the Private Relay feature and its blocking.

Aug 17 2021, 12:59 AM · VisualEditor-MediaWiki-Mobile, VisualEditor, Editing-team

Aug 16 2021

DLynch added a project to T286620: Bundled notifications get processed singly: Editing QA.
Aug 16 2021, 8:29 PM · Verified, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T286954: Clarify the difference between "Talk page message" and "Talk page subscription" (on Special:Preferences → Notifications) from Code Review to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.
Aug 16 2021, 8:29 PM · MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Growth-Team, Notifications
DLynch moved T286620: Bundled notifications get processed singly from Code Review to QA on the Editing-team (FY2021-22 Kanban Board) board.
Aug 16 2021, 8:29 PM · Verified, MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Editing-team (FY2021-22 Kanban Board), DiscussionTools

Aug 12 2021

DLynch added a comment to T288316: Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable).

Probably T275923.

Ah, right, and that's not working here because an empty page will be too short to be scrollable. This makes sense.

Aug 12 2021, 6:01 PM · Verified, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch renamed T276495: The New discussion tool does not work from history from The New discussion tool does not working from history to The New discussion tool does not work from history.
Aug 12 2021, 5:45 PM · User-Ryasmeen, Verified, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation from Doing to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 12 2021, 5:10 PM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki
DLynch added a comment to T288741: Talk Page Empty State: write English copy for translation.

Also, since the doc is restricted...

Aug 12 2021, 3:47 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), DiscussionTools, Editing-team (FY2021-22 Kanban Board)
DLynch added a comment to T288741: Talk Page Empty State: write English copy for translation.

Consideration: "Wikipedians" is a difficult thing to have in the copy. After all, this extension is going to be running on non-Wikipedia projects; should we call someone on Wikitionary a "Wikipedian"? (It can also be run on entirely non-Wikimedia projects -- if someone installs it on the wiki for their knitting community, they're not a Wikipedian.)

Aug 12 2021, 3:37 PM · Patch-For-Review, MW-1.37-notes (1.37.0-wmf.21; 2021-08-30), DiscussionTools, Editing-team (FY2021-22 Kanban Board)

Aug 11 2021

DLynch moved T277329: Implement empty state mockups for peoples' *own user* talk page (logged in) from Design Review to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 11 2021, 7:39 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Verified, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Editing Design, OWC2020
DLynch moved T274832: Implement user experience for non-existent (red-linked) *non-user* talk pages from Design Review to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 11 2021, 7:39 PM · Verified, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Editing Design, OWC2020
DLynch moved T274831: Implement empty state mockups for *user* talk pages (logged in) from Design Review to Code Review on the Editing-team (FY2021-22 Kanban Board) board.
Aug 11 2021, 7:39 PM · Verified, Editing-team (FY2021-22 Kanban Board), DiscussionTools, Editing Design, OWC2020
DLynch added a comment to T284322: Bug: Update contextual Subscribe/Unsubscribe button in real time when Unsubscribing from Echo Notification.

Copying Bartosz's comment from the original ticket:

Our interface and the notifications interface are not aware of each other, and our interface has no way to react to anything happening in the notifications interface. It is definitely possible to make that happen, but we'd need to make some changes to Echo, I'd prefer to handle this in a separate task.

Aug 11 2021, 4:42 PM · DiscussionTools, Growth-Team, Notifications
DLynch moved T287487: Uncaught TypeError: Cannot read property 'tools' of null from Ready to Be Worked On to Ready for Sign Off on the Editing-team (FY2021-22 Kanban Board) board.

There haven't been any of these errors since August 5th, so I think we've gotten it.

Aug 11 2021, 4:18 PM · Skipped QA, MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), VisualEditor, Wikimedia-production-error
DLynch added a comment to T285971: Update Talk API to support in-line replying on Android.

That patch is the most-naïve possible version to us providing our own comment structure. It's just dumping the flat comment list from CommentParser, resulting in something like:

Aug 11 2021, 2:25 PM · Wikipedia-iOS-App-Backlog, Wikipedia-Android-App-Backlog, Patch-For-Review, Editing-team, DiscussionTools, Platform Engineering
DLynch added a comment to T287098: Ensure discussiontools markup is hidden by CSS when parser split is removed.

Yeah, that one would be it.

Aug 11 2021, 2:03 PM · User-Ryasmeen, Editing QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation.

@santhosh Yes, sorry, I missed that one.

Aug 11 2021, 1:44 PM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki

Aug 10 2021

DLynch added a comment to T288320: Improve experience when publishing a new topic to an empty talk page.

While what was implemented in T288314 is an improvement, I think there is more that could be done (see the task description's newly-created ===Behavior section).

Aug 10 2021, 5:26 PM · Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch moved T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation from Ready to Be Worked On to Doing on the Editing-team (FY2021-22 Kanban Board) board.
Aug 10 2021, 5:14 PM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki

Aug 6 2021

DLynch claimed T288314: Empty state shown briefly when posting a new topic.
Aug 6 2021, 9:10 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch claimed T288317: Talk page empty state appearing in project namespace.
Aug 6 2021, 9:09 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288317: Talk page empty state appearing in project namespace.

T274832 did have a list. I think I can approximate the correct result by checking for "discussion enabled" + $title->isTalkPage()

Aug 6 2021, 8:33 PM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

would it be accurate for me to think the time between someone pressing Add topic and said topic being posted to the page will be significantly faster on production?

You mean compared to what's shown in the video there? That was taken locally in a docker container on my laptop. I'd generally expect production to be a bit quicker, though it's complicated. (Much more powerful servers, but serving more traffic at once, and with more room for your internet connection between you and the server to be slow. 🤷🏻)

Aug 6 2021, 8:28 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

Fine, fine, fine, it's now updated to work without even that flicker of the widget changing: https://youtu.be/5r4B_D-VKa8

Aug 6 2021, 8:19 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

I've updated the patch to be the more-expansive "don't teardown, but do clean up the reply widget" variant. There's no flash of empty state, though there's a moment of the widget having emptied itself out.

Aug 6 2021, 7:37 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

Actually, I noticed one more objection, which is that it makes the "you replied" toast appear, disappear, then appear again. (Because it appears for however long it takes the reload to happen, disappears until the page is loaded enough to show it, then times out naturally.)

Aug 6 2021, 7:10 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

That seems to be consistent with the pre-deploy rate of errors, so I don't think this patch actually touched whatever's causing this.

Aug 6 2021, 7:08 PM · MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Editing-team (FY2021-22 Kanban Board), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

Hmm, can we do this? It'd be a little inefficient, but it would look nicer.

I think the only objection would be that there's a chance the user would start interacting with the new contents and then lose that interaction as the page reloads.

Aug 6 2021, 6:44 PM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288316: Closing New Discussion Tool requires you to click "Cancel" twice (on pages too short to be scrollable).

This is the warning appearing when the focus is lost from the title, moving the cancel button out of the way before your click on it can happen. You don't actually have to click the cancel button twice, just click anywhere at all outside the title and then the cancel button.

Aug 6 2021, 12:48 AM · Verified, MW-1.37-notes (1.37.0-wmf.23; 2021-09-13), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288317: Talk page empty state appearing in project namespace.

It's appearing in any namespace where discussiontools would apply. You'll note that Wikipedia: pages get reply links, e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Wikipedia:Village_pump911

Aug 6 2021, 12:44 AM · User-Ryasmeen, Verified, MW-1.37-notes (1.37.0-wmf.18; 2021-08-09), Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

This is probably the most-trivial approach: https://youtu.be/aUCPBHUUCfs

Aug 6 2021, 12:37 AM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools
DLynch added a comment to T288314: Empty state shown briefly when posting a new topic.

So, the reason for this is that when we post a topic that creates a page, we're refreshing the entire page. (Because there's a lot of things on the page that need to be updated to reflect that it's a real page now, and that's difficult to update.)

Aug 6 2021, 12:19 AM · User-Ryasmeen, Skipped QA, Editing-team (FY2021-22 Kanban Board), DiscussionTools

Aug 5 2021

DLynch added a comment to T270636: Mark EditAttemptStep events from VisualEditor reusers like Content Translation.

Also, to adjust this going forwards, we could suppress (much) unknown reuse causing logging by just not having a default and making it abort logging if none is set. This wouldn't help with reusers who extend ve.init.mw.ArticleTarget, but the more-generic ve.init.mw.Target would cope.

Aug 5 2021, 8:12 PM · Product-Analytics (Kanban), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Editing-team (FY2021-22 Kanban Board), ContentTranslation, VisualEditor, VisualEditor-MediaWiki