DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (149 w, 5 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Yesterday

DLynch updated subscribers of T201871: [regression] Layout issues in feedback dialog.

The checkbox alignment seems to be caused by T178456's patch (or, at least, disabling the padding-left rule it added fixes it; harder to test whether it predates that). @matmarex?

Tue, Aug 14, 4:22 PM · OOUI (OOUI-0.28.0), MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Patch-For-Review, Regression

Sat, Aug 11

DLynch added a comment to T201538: Set up test instance for user testing editing prototypes.

Given the short-term prototyping goals of this, I'd assume that we'd want to quickly spin an instance up and discard it on a fairly short timeframe. Assuming that we can properly automate all that content-importing and patch-applying, this'd get us to a low maintenance state. Given that Vagrant itself is doing fine, of course.

Sat, Aug 11, 11:31 PM · Developer Productivity, VisualEditor (Current work)

Fri, Aug 10

DLynch updated subscribers of T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

I suppose that I'm not opposed to the combined field-button per-se, I'm just with matmarex in not really liking it in this specific instance. I'd probably be most visually happy just restoring the separation in this case. (And maybe other similar ones with this aesthetic incompatibility.)

Fri, Aug 10, 4:44 AM · VisualEditor

Thu, Aug 9

DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

I suspect the most relevant bit for that is ve.init.mw.Target.prototype.setupSurface, since that's where we actually turn the DOM into our model. (Though I grant I haven't stepped through and verified that the <style> hasn't been quietly stripped somewhere else where I didn't see it...)

Thu, Aug 9, 5:21 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch claimed T201210: VisualEditor not switching to edit conflict interface.

Yeah, seems like that has indeed helped.

Thu, Aug 9, 5:12 PM · VisualEditor (Current work), MediaWiki-Page-editing
DLynch added a comment to T197563: Template styles get ignored when switching to Visual Editor.

The requirement is more specific than just switching to VE -- it has to be switching to VE from the classic editpage, rather than from NWE, because that causes a load of VE without the underlying view of the page existing.

Thu, Aug 9, 5:05 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Templates, TemplateStyles
DLynch added a comment to T201538: Set up test instance for user testing editing prototypes.

Additional criteria: ease of deploying an arbitrary patch to the instance.

Thu, Aug 9, 4:35 PM · Developer Productivity, VisualEditor (Current work)

Wed, Aug 8

DLynch added a comment to T199554: Switching between visual editor and source mode gives error message.

(Note that there is no data loss, for VE or other affected tools, just a misleading message.)

Wed, Aug 8, 8:46 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch added a comment to T201210: VisualEditor not switching to edit conflict interface.

The incompleteForm message part will be fixed when my patch on T199554 is merged. I'm not sure if that's the sole part that's holding up going to the conflict resolution interface, though -- I'll double-check it.

Wed, Aug 8, 5:18 PM · VisualEditor (Current work), MediaWiki-Page-editing
DLynch added a comment to T201472: List insertion by typing '#<space>', '*<space>' is broken.

@Esanders: Makes sense, and I agree on the general case. If you merge it, I can make a new task for fixing it up more permanently.

Wed, Aug 8, 4:37 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki

Tue, Aug 7

DLynch moved T201472: List insertion by typing '#<space>', '*<space>' is broken from In progress to Code review on the VisualEditor (Current work) board.
Tue, Aug 7, 11:37 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T201472: List insertion by typing '#<space>', '*<space>' is broken.
Tue, Aug 7, 11:05 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch added a comment to T200525: Allow cursoring between active nodes.

Question 1 is what I was asking above in my first comment on this task, so I'd say that's somewhat-undecided. I think 2 is unintended, though; it should switch to cell selection first.

Tue, Aug 7, 10:56 PM · Verified, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation
DLynch added a comment to T199925: Be able to insert horizontal rules (<hr> or ----).

It's the same as how pasting * doesn't make it become a list item. Which maybe it should? Not sure.

Tue, Aug 7, 9:25 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))
DLynch updated subscribers of T198511: VisualEditor losing Media: links.

@cscott: Oh, I totally agree that this UX isn't optimal, and that we should add it to @iamjessklein's big pile of VE design thoughts. I'm just happy to fix the power-user case right now while we wait on that. (And we'll presumably need whatever functionality we add via resource for the nicely-designed option anyway, so that shouldn't hurt.)

Tue, Aug 7, 2:56 AM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Mon, Aug 6

DLynch added a comment to T198511: VisualEditor losing Media: links.

@cscott: Nope, this is all we get from Parsoid: [[Media:Logo.png]] => <p id="mwAQ"><a rel="mw:MediaLink" href="//upload.wikimedia.org/wikipedia/commons/c/c9/Logo.png" title="Logo.png" id="mwAg">Media:Logo.png</a></p> (with the link text obviously not being reliable, because people can change that).

Mon, Aug 6, 11:45 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

Absent Parsoid output/input changes, I will make those editing experiences equivalent by:

Mon, Aug 6, 11:11 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

From a UX standpoint, I'd expect that "link to file page on commons" vs "link directly to media download" is a checkbox in the link options somehow. I think we'd need some insight from a designer on how to best express this w/in the current VE framework. The magical checkbox would determine whether VE gave us back the mw:MediaLink or mw:ExtLink type.

Mon, Aug 6, 10:15 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a project to T198511: VisualEditor losing Media: links: Parsoid.

Okay, so. I've gone and read wt2html/tt/LinkHandler.js and html2wt/LinkHandler.js in Parsoid, and I think that this never worked in VE, since Parsoid added this MediaLink stuff back in May of 2017.

Mon, Aug 6, 7:15 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

Alas, testing indicates the behavior existed prior to that. So I'll just fix it rather than digging.

Mon, Aug 6, 4:45 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch added a comment to T198511: VisualEditor losing Media: links.

If I'm speculating wildly, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/436544 did change a bunch of our parsoid-and-links interactions recently.

Mon, Aug 6, 4:41 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)
DLynch claimed T198511: VisualEditor losing Media: links.

We have no explicit handling of mw:MediaLink, so I think what's happening here is just that it's treating it like any other link and falling back on that generic behavior.

Mon, Aug 6, 4:38 PM · Patch-For-Review, Parsoid, VisualEditor-Media, VisualEditor (Current work)

Sat, Aug 4

DLynch added a comment to T201232: Clicking the "Change label" button needs to give the user clearer feedback.

There's some discussion of this in T124305 as well.

Sat, Aug 4, 3:30 PM · Design, VisualEditor

Thu, Aug 2

DLynch claimed T199655: Switching between old WTE and visual editing doesn't preserve changes.

Not firefox specific. It does require that you have both multiple edit tabs, not be using NWE, and trigger the switch by clicking the "edit source" tab rather than through VE's menus, though, which I suspect is why Dan couldn't reproduce it.

Thu, Aug 2, 4:58 PM · Verified-in-Phase0, Verified, MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), VisualEditor-MediaWiki, VisualEditor (Current work), Browser-Support-Firefox
DLynch added a comment to T200386: Switching to VE from New Section tab shows the confirmation dialog with option "Discard my changes and switch" when no changes were actually made. .

I think this is a dupe of T136267.

Thu, Aug 2, 4:13 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch created T201019: Back button navigation to NWE doesn't restore section editing.
Thu, Aug 2, 4:10 PM · VisualEditor
DLynch moved T199554: Switching between visual editor and source mode gives error message from In progress to Code review on the VisualEditor (Current work) board.
Thu, Aug 2, 3:37 AM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)

Wed, Aug 1

DLynch moved T199554: Switching between visual editor and source mode gives error message from Up next to In progress on the VisualEditor (Current work) board.
Wed, Aug 1, 4:22 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)
DLynch claimed T199554: Switching between visual editor and source mode gives error message.
Wed, Aug 1, 4:22 PM · MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), User-Ryasmeen, VisualEditor-MediaWiki, VisualEditor (Current work)

Tue, Jul 31

DLynch added a comment to T200525: Allow cursoring between active nodes.

@Deskana: "active node" means one which can have cursor focus within it, in a way that's somewhat separate from the general article flow. This patch makes it so that moving your cursor with the arrow keys doesn't keep it trapped within those nodes. E.g. if you're in a table caption and press the up arrow, you would previously have stayed in the caption, but now you'll find the cursor in the preceding content.

Tue, Jul 31, 11:31 PM · Verified, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation
DLynch moved T176070: action=edit does not show deletion log, where applicable from Up next to QA on the VisualEditor (Current work) board.
Tue, Jul 31, 9:41 PM · VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch claimed T176070: action=edit does not show deletion log, where applicable.
Tue, Jul 31, 9:40 PM · VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch merged task T199087: No warning shown in VE/NWE that a page has previously been deleted into T176070: action=edit does not show deletion log, where applicable.
Tue, Jul 31, 9:39 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch merged T199087: No warning shown in VE/NWE that a page has previously been deleted into T176070: action=edit does not show deletion log, where applicable.
Tue, Jul 31, 9:39 PM · VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch added a comment to T176070: action=edit does not show deletion log, where applicable.

Am I right in thinking that T199087 is a duplicate of this? Because I have a patch for that which gets us:

Tue, Jul 31, 4:59 PM · VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work)
DLynch added a comment to T200525: Allow cursoring between active nodes.

For the table caption case, should we special case it so that it jumps the selection into the table rather than skipping it?

Tue, Jul 31, 4:46 PM · Verified, Patch-For-Review, VisualEditor-ContentEditable, VisualEditor (Current work), MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), ContentTranslation
DLynch added a comment to T181416: In VE table editor, cannot move cursor out of caption area using keyboard.

Actually, new development, T200525 made it so that arrows will move out of it.

Tue, Jul 31, 4:46 PM · User-Ryasmeen, WCAG-Level-A, Accessibility, VisualEditor, VisualEditor-Tables

Mon, Jul 30

DLynch added a comment to T181416: In VE table editor, cannot move cursor out of caption area using keyboard.

As of T192163 this is fixed, insofar as the tab key now works to move in/out of table captions.

Mon, Jul 30, 4:20 PM · User-Ryasmeen, WCAG-Level-A, Accessibility, VisualEditor, VisualEditor-Tables

Thu, Jul 26

DLynch claimed T199925: Be able to insert horizontal rules (<hr> or ----).
Thu, Jul 26, 4:34 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16))

Wed, Jul 25

DLynch added a comment to T197075: CX2: Show link card for source links.

@santhosh Context popups trigger in reaction to contextChange events, which I'm fairly sure only fire in response to things which happen to an enabled surface. Plus, complications of the surface not having a context if there's not a selection for it to know what that context should be. You could plausibly manually override this by directly asking ve.ui.contextItemFactory.getRelatedItems for context items for parts of the document you're interested in, and displaying those however you please -- that said, context items have a few parts which expect to interact with an enabled document (for links, that'd be the remove-annotation and select-label buttons), and those would cause issues with a disabled surface as well.

Wed, Jul 25, 5:48 PM · Language-2018-July-September, ContentTranslation
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Trizek-WMF: You'll find extensive discussion of that approach in T55973, if you want to see the arguments. I had a patch which worked that way as well, and it was less popular than the one which we went with in the end.

Wed, Jul 25, 3:29 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Wed, Jul 18

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

I can explain why things are the way they are, at least.

Wed, Jul 18, 5:34 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Tue, Jul 17

DLynch added a comment to T184605: Restore keyboard shortcut in the visual editor to the same one that's used in older editors.

I think this is just an uncaught duplicate of T121183? (And so, fixed.)

Tue, Jul 17, 4:54 PM · User-Ryasmeen, VisualEditor

Mon, Jul 16

DLynch added a comment to T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

Make the converter give us a CommentMetaItem instead? We try to do that for things like comments mixed into tables between rows already, I think.

Mon, Jul 16, 4:15 PM · Verified-in-Phase2, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs

Jul 12 2018

DLynch moved T199087: No warning shown in VE/NWE that a page has previously been deleted from Up next to Code review on the VisualEditor (Current work) board.
Jul 12 2018, 4:42 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch claimed T199087: No warning shown in VE/NWE that a page has previously been deleted .
Jul 12 2018, 4:42 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T199087: No warning shown in VE/NWE that a page has previously been deleted .

Gets us:

Jul 12 2018, 4:41 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T199138: NWE produces newline when selecting, copying and immediatly re-pasting text.

Sorry, do you mean a surplus new line is added in addition to the one you copied? The behavior you describe, as I read it, is what I'd expect from a text editor.

Jul 12 2018, 4:09 PM · User-Ryasmeen, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor

Jul 11 2018

DLynch updated subscribers of T199298: Visual diff fails with "jQuery.Deferred exception: listContents is undefined".

Let's see... this is ve.dm.VisualDiff.prototype.flattenList failing when it finds a CommentNode that's a child of a ListNode.

Jul 11 2018, 5:21 PM · Verified-in-Phase2, MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), VisualEditor (Current work), VisualEditor-VisualDiffs

Jul 9 2018

DLynch merged T199043: Uncaught type errors inserting citations with citoid, and adding or removing unused parameters to template inside ref in VE in production (but the changes are successful) into T198826: Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode.
Jul 9 2018, 5:19 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work), VisualEditor-MediaWiki-References, Cite, VisualEditor-MediaWiki
DLynch merged task T199043: Uncaught type errors inserting citations with citoid, and adding or removing unused parameters to template inside ref in VE in production (but the changes are successful) into T198826: Editing "Cite journal" template citation throws TypeError from VeCeMWTransclusionInlineNode.
Jul 9 2018, 5:19 PM · VisualEditor (Current work), Citoid
DLynch moved T197759: Preview shows categories in alphabetical order instead of original one from Up next to Code review on the VisualEditor (Current work) board.
Jul 9 2018, 2:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Verified, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch claimed T197759: Preview shows categories in alphabetical order instead of original one.
Jul 9 2018, 2:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Verified, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
Liuxinyu970226 awarded T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype a Orange Medal token.
Jul 9 2018, 4:07 AM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Jul 3 2018

DLynch added a comment to T198274: [Regression wmf.8?] The textbox size inside Add template dialog is too small on Firefox.

Esanders: Looks like it was removed in 24fe991c00. ...though I can't see any evidence that the .oo-ui-actionFieldLayout-field class that's removed there would ever actually have been created by ActionFieldLayout. So.

Jul 3 2018, 4:49 PM · User-Ryasmeen, Verified, Browser-Support-Firefox, VisualEditor-MediaWiki-Templates, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)
DLynch closed T198064: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link as Resolved.
Jul 3 2018, 4:33 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Verified, VisualEditor-EditingTools, VisualEditor (Current work), User-Ryasmeen, Easy

Jul 2 2018

DLynch added a comment to T198272: [Regression pre-wmf.10] After making an edit, clicking on "Edit Source" while VE is open, does not switch the editor anymore.

QA note: when merged this patch has a chance of regressing T157755, so double-check behavior with single/multi edit tabs on pages with __NEWSECTIONLINK__.

Jul 2 2018, 9:32 PM · User-Ryasmeen, Verified, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)

Jun 27 2018

DLynch moved T198272: [Regression pre-wmf.10] After making an edit, clicking on "Edit Source" while VE is open, does not switch the editor anymore from Up next to Code review on the VisualEditor (Current work) board.
Jun 27 2018, 11:28 PM · User-Ryasmeen, Verified, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)
DLynch claimed T198272: [Regression pre-wmf.10] After making an edit, clicking on "Edit Source" while VE is open, does not switch the editor anymore.
Jun 27 2018, 11:27 PM · User-Ryasmeen, Verified, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)
DLynch added a comment to T198272: [Regression pre-wmf.10] After making an edit, clicking on "Edit Source" while VE is open, does not switch the editor anymore.

As a version input, I tried it in Firefox 62, and also didn't see any problems.

Jun 27 2018, 7:19 PM · User-Ryasmeen, Verified, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)
DLynch renamed T198274: [Regression wmf.8?] The textbox size inside Add template dialog is too small on Firefox from [Regression wmf.8?] The textbox size inside Add citation dialog is too small on Firefox to [Regression wmf.8?] The textbox size inside Add template dialog is too small on Firefox.
Jun 27 2018, 4:52 PM · User-Ryasmeen, Verified, Browser-Support-Firefox, VisualEditor-MediaWiki-Templates, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), VisualEditor (Current work)

Jun 26 2018

DLynch claimed T198064: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link.
Jun 26 2018, 6:18 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Verified, VisualEditor-EditingTools, VisualEditor (Current work), User-Ryasmeen, Easy
DLynch added a comment to T198064: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link.

I'd say:

  1. Update the default message to "remove formatting" (as you say, it's better than "clear styling")
  2. Update the link context specifically to "remove link"
  3. Update the language context specifically to "remove language"
Jun 26 2018, 6:18 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Verified, VisualEditor-EditingTools, VisualEditor (Current work), User-Ryasmeen, Easy
DLynch merged T198225: Incorrect page title after editing; if editor is switched while editing into T197490: Page title stuck as "Editing ..." if a page is published after switching between VE/NWE.
Jun 26 2018, 4:57 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki
DLynch merged task T198225: Incorrect page title after editing; if editor is switched while editing into T197490: Page title stuck as "Editing ..." if a page is published after switching between VE/NWE.
Jun 26 2018, 4:57 PM · VisualEditor
DLynch added a comment to T198225: Incorrect page title after editing; if editor is switched while editing.

Should be today, I think, unless something blocks the train.

Jun 26 2018, 4:57 PM · VisualEditor
DLynch added a comment to T198064: visualeditor-clearbutton-tooltip shouldn't be used in link inspector to remove a link.

Note that this is totally my fault from back in 2015 with 7ecde6c05.

Jun 26 2018, 4:49 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Verified, VisualEditor-EditingTools, VisualEditor (Current work), User-Ryasmeen, Easy
DLynch updated subscribers of T198225: Incorrect page title after editing; if editor is switched while editing.

Duplicate of T197490, which @matmarex recently fixed, I think?

Jun 26 2018, 4:30 PM · VisualEditor

Jun 25 2018

DLynch added a comment to T197615: 2017 wikitext editor does not update the address bar URL after edit save.

Didn't strictly need to save -- any teardown would cause it. It relied on the single-edit-tab behavior of switching from veaction to action in URLs.

Jun 25 2018, 5:00 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12))
DLynch claimed T197615: 2017 wikitext editor does not update the address bar URL after edit save.
Jun 25 2018, 4:59 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12))

Jun 21 2018

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

We do already refer to the link text as "label" in other places -- e.g. a numbered link gets an "add label" button to swap out the "[3]" for text -- that said, if people think it's unclear and needs explanation in this situation, now would be a good time to quickly change that before people spend effort on translations.

Jun 21 2018, 4:53 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T197834: Regression: Editing workflow broken for non-JS users and template editors on mobile.

I do agree with matmarex's suggested approach. The issue here seems to stem from a lack of clarity (on my part, on reviewer's part, on the code's part, etc) about exactly when things are providing a mobile experience. Wiping that clean and getting a simple rule for it would make sense.

Jun 21 2018, 4:47 PM · Readers-Web-Backlog (Tracking), User-Jdlrobson, VisualEditor (Current work), MobileFrontend, Mobile, Regression

Jun 19 2018

DLynch added a comment to T197659: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked.

I found the simplest way to test reproducing this was to make a template which just contains a single link, include it on an editor page, and then use dev tools to outright remove the highlight node. Leaves the link easily accessible for clicking.

Jun 19 2018, 6:58 PM · Verified-in-Phase2, VisualEditor (Current work), VisualEditor-MediaWiki-Templates
DLynch moved T197659: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked from Up next to Code review on the VisualEditor (Current work) board.
Jun 19 2018, 5:02 PM · Verified-in-Phase2, VisualEditor (Current work), VisualEditor-MediaWiki-Templates
DLynch claimed T197659: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked.
Jun 19 2018, 4:53 PM · Verified-in-Phase2, VisualEditor (Current work), VisualEditor-MediaWiki-Templates

Jun 18 2018

DLynch moved T197445: Can't reload a page by clicking article tab after editing in VE from Up next to Code review on the VisualEditor (Current work) board.
Jun 18 2018, 7:04 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T197445: Can't reload a page by clicking article tab after editing in VE.
Jun 18 2018, 3:48 PM · Verified, VisualEditor (Current work), VisualEditor-MediaWiki

Jun 15 2018

DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

The overlay shouldn't be loading on desktop though. Overlays only really make sense on a mobile/tablet device.

Jun 15 2018, 9:54 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Trizek-WMF If Ed approves and merges the patch, it could all happen today. So the timeline is pretty much "once approvals come in", unfortunately.

Jun 15 2018, 3:05 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

@Jdlrobson The merged patches should mean that the case you show there will result in the full article appearing in the editor. You can see it on beta: https://simple.wikipedia.beta.wmflabs.org/wiki/Barack_Obama?useskin=minerva&action=edit

Jun 15 2018, 4:36 AM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend

Jun 14 2018

DLynch moved T196915: Give mobile editor a way to edit more than just a single section at once from Done to Code review on the VisualEditor (Current work) board.
Jun 14 2018, 9:09 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch updated subscribers of T197250: Tabbing from "find text" in find and replace dialog takes you to "site search" before "replace text".

I've done some hunting down of this -- the issue is that the windowmanager div the toolbar (and inspectors) is in has aria-hidden=true, which makes my tab isolation code assume that nothing in it should be treated as being visible for tabbing purposes.

Jun 14 2018, 8:25 PM · VisualEditor-EditingTools, VisualEditor (Current work)
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

For what it's worth, I'm thinking of this ticket as a two-part thing. Part one is the existing patches which will restore the ?action=edit behavior of getting the full text, and part two would be working out the right place to put the UI to expose it more thoroughly. (I'd argue that the edit button at the top of a mobile page next to all the other page-level actions should trigger /all, but there's probably an argument to be had here...)

Jun 14 2018, 4:53 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

Yeh the magic password bit doesn't help this problem. mobileeditorsuppress is not exactly easy to remember and is also hard to type on mobile. I personally don't think this gains much unless it's linked to in the interface.

Jun 14 2018, 4:45 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

@Deskana: That all sounds correct.

Jun 14 2018, 3:59 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

I've updated the patch for option 1 for now. (Since it's the simple just-make-it-not-bold adjustment.)

Jun 14 2018, 3:46 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch updated subscribers of T196915: Give mobile editor a way to edit more than just a single section at once.

From @Deskana I guess? (It's mobile, but it's also editing, so...)

Jun 14 2018, 3:34 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend

Jun 13 2018

DLynch added a comment to T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

@Volker_E So, I feel like the styling now suggests that the action button is "inside" the input. (Maximally so in the field-with-search-icon case.) That makes it feel wrong to me when the field focus excludes the button. It breaks the "this is one unit" message that the no-spacing-shared-borders design seems to be going for.

Jun 13 2018, 5:20 PM · VisualEditor
DLynch added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

That said, I just tried to reproduce this with the new steps, and it still doesn't produce the error for me.

Jun 13 2018, 4:21 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Ryasmeen, Verified, VisualEditor (Current work)
DLynch updated subscribers of T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

It maybe looks a little weird with the focus highlight and the disabled action button. If @Volker_E would like to tweak that combination somehow?

Jun 13 2018, 4:06 PM · VisualEditor
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Esanders I do like how 2 winds up looking, particularly for longer labels. Want to wait for @Pginer-WMF to weigh in with a Design-y opinion?

Jun 13 2018, 4:04 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch moved T196915: Give mobile editor a way to edit more than just a single section at once from Up next to Code review on the VisualEditor (Current work) board.
Jun 13 2018, 3:53 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196479: Console error when copy/pasting wikitext into VE.

The 400 is specifically "Unknown source".

Jun 13 2018, 4:16 AM · Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Collaboration-Team-Triage, Maps, Verified, User-Ryasmeen, VisualEditor-CopyPaste, MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor (Current work), VisualEditor-ContentEditable

Jun 12 2018

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Trizek-WMF it truncates itself so it fits on one line.

Jun 12 2018, 3:46 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Jun 11 2018

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

I think building it as a separate context item which might not appear directly next to the link context item would be a bit confusing, just because it's explicitly scoped to act on the link annotation, whereas the pile-of-contexts is "all the overlapping annotations at this cursor location".

Jun 11 2018, 4:53 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

Okay, thanks for that! That sequence, and particularly the "xy" still being present, makes me suspect that we're failing to properly tear down the toolbar dialogs, so it's still holding on to a reference to the previous surface, resulting in the failure when we try to perform actions on a discarded surface.

Jun 11 2018, 4:28 PM · MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), User-Ryasmeen, Verified, VisualEditor (Current work)
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

It's less apparent in the screenshot there, but in the full MW-VE experience, having that separate-section styling helps to distinguish it from the preview a bit:

Jun 11 2018, 4:25 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

That patch makes it so that visiting a ?action=edit URL will load the full page's text in the overlay editor. Sort of a preserve-the-status-quo patch.

Jun 11 2018, 4:03 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196150: Regression: Links containing "action" always show the editor on mobile version regardless of value.

I've made T196915 for the edit-a-full-page issue.

Jun 11 2018, 3:49 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Readers-Web-Backlog (Tracking), VisualEditor (Current work), Regression, Mobile, MobileFrontend
DLynch created T196915: Give mobile editor a way to edit more than just a single section at once.
Jun 11 2018, 3:48 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend