Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (185 w, 2 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Fri, Apr 19

Ryasmeen awarded T220513: Non-latin URL fragments don't reliably get scrolled to a Like token.
Fri, Apr 19, 1:41 AM · Patch-For-Review, Readers-Web-Backlog, MobileFrontend

Thu, Apr 18

DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I said it on the other ticket as well, but I suspect that pages which start with a / are probably far less common than subpages, so it'd be a strange case to optimize for...

Thu, Apr 18, 4:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T221028: Parsoid incorrectly parses links to pages starting with a slash '/' in namespaces that can have subpages.

I think the suggested behavior here is far less likely to be what people intended than the subpage behavior. Pages whose names start with a / are unusual, and I suspect people are more likely to be trying to link to a subpage.

Thu, Apr 18, 4:45 PM · Parsoid-Read-Views

Wed, Apr 17

DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

@Ryasmeen When this makes its way to bn.wikipedia we'll know how much it has helped your specific case. :D

Wed, Apr 17, 3:47 PM · Patch-For-Review, Readers-Web-Backlog, MobileFrontend

Fri, Apr 12

DLynch moved T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Fri, Apr 12, 7:28 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch edited projects for T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving, added: VisualEditor (Current work); removed VisualEditor.
Fri, Apr 12, 7:25 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

@janboehme I'd speculatively point to this commit but can't claim to have actually tested that.

Fri, Apr 12, 4:06 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links

Thu, Apr 11

DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I'm using a current checkout of it, so I suppose I have a few months of miscellaneous changes since the 0.10.0 release.

Thu, Apr 11, 8:37 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving.

I can't reproduce the bad link generation, though I agree the not-actually-a-redlink is still happening.

Thu, Apr 11, 4:55 PM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Links
DLynch added a comment to T218942: Random article widget.

In part we speak here of pull request #2990.

Thu, Apr 11, 3:33 PM · iOS-app-v6.3-Lobster-On-A-Motorcycle, Wikipedia-iOS-App-Backlog

Wed, Apr 10

DLynch added a comment to T220513: Non-latin URL fragments don't reliably get scrolled to.

I think this is partially Toggler.prototype.reveal passing the urlencoded selector into jquery, which predictably throws, because $( '#%E0%A6%B6%E0%A6%BF%E0%A6%B0%E0%A7%8B%E0%A6%A8%E0%A6%BEma' ) is quite invalid.

Wed, Apr 10, 5:06 PM · Patch-For-Review, Readers-Web-Backlog, MobileFrontend

Tue, Apr 9

DLynch added a comment to T129546: Support preserving external links in pasted HTML content.

@Esanders: ...actually, as well as pasting from externally, I was copying external links within that instance on test2, and they were getting stripped. So we might have a separate issue?

Tue, Apr 9, 5:20 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor, VisualEditor-CopyPaste
DLynch added a comment to T129546: Support preserving external links in pasted HTML content.

@mingle: It doesn't seem to? I just checked on test2, and cannot paste external links.

Tue, Apr 9, 4:54 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor, VisualEditor-CopyPaste
DLynch created T220513: Non-latin URL fragments don't reliably get scrolled to.
Tue, Apr 9, 2:38 PM · Patch-For-Review, Readers-Web-Backlog, MobileFrontend
DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

Okay, that's a completely separate issue. Seems to be with MobileFrontend not handling non-latin fragments at all well for the initial pageload. I'll make a different ticket.

Tue, Apr 9, 1:34 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mon, Apr 8

DLynch added a comment to T220090: Allow selection of the text in the Visual Editor reference inspector.

Until T208826 is done, this would have some side-effects, as removing the selection from within the text would immediately close the context popup. Once that ticket is done and the patches merged, it'd probably be doable.

Mon, Apr 8, 4:09 PM · VisualEditor-EditingTools, MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), VisualEditor (Current work)

Thu, Apr 4

DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

@Ryasmeen -- honestly, the weird part there is that it worked on en.wiki. We have a train stall at the moment, so en.wiki should still be on 1.33.0-wmf.23 which doesn't have the latest patch.

Thu, Apr 4, 9:57 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Wed, Apr 3

DLynch moved T218163: [betalabs] EditAttemptStep has undeclared properties from Code review to Product owner review on the VisualEditor (Current work) board.
Wed, Apr 3, 3:38 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work)

Tue, Apr 2

DLynch added a comment to T218163: [betalabs] EditAttemptStep has undeclared properties.

@matmarex: see debug.js in the EventLogging extension for more details, but basically, do this in your console:

Tue, Apr 2, 2:44 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work)

Mon, Apr 1

DLynch moved T218163: [betalabs] EditAttemptStep has undeclared properties from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Mon, Apr 1, 5:06 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work)

Thu, Mar 28

DLynch moved T216285: Loss of 'alt' texts when manipulating image presentation form from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Thu, Mar 28, 4:24 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), VisualEditor (Current work), VisualEditor-DataModel
DLynch claimed T216285: Loss of 'alt' texts when manipulating image presentation form.
Thu, Mar 28, 4:18 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), VisualEditor (Current work), VisualEditor-DataModel
DLynch moved T202148: Instrument editing pipeline to be able to figure out which common editing features are used from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Thu, Mar 28, 3:30 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), Patch-For-Review, Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics

Wed, Mar 27

DLynch added a comment to T218939: Deploy mobile section editing to the next set of wikis (listed in the description).

Ugh, reading things before responding to them. Terrible.

Wed, Mar 27, 9:54 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Section Editing
DLynch added a comment to T219420: Update page dynamically after save on mobile.

MobileFrontend.hooks.php has onOutputPageBeforeHTML which does a relatively simple set of things to the content.

Wed, Mar 27, 5:52 PM · MobileFrontend, Performance, VisualEditor, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T218939: Deploy mobile section editing to the next set of wikis (listed in the description).

It's making a patch for the mediawiki-config repo, and scheduling it on Deployments -- at which point one of us will need to be there during the deploy window to verify it worked after the ops team +2 it and push it out.

Wed, Mar 27, 3:46 PM · User-Ryasmeen, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work), Section Editing
DLynch added a comment to T218163: [betalabs] EditAttemptStep has undeclared properties.

Looking at it... I think we've just always been pouring all of these in, and letting the schema accept the ones it knows about. I believe that it just discards the unknown properties, rather than the entire event in those cases, right?

Wed, Mar 27, 3:28 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, VisualEditor (Current work)
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

A provision does seem to mostly work now... or didn't abort early, at least. Eventgate did throw out a bunch of errors when trying to build its node-rdkafka dependency, which can be seen in P8291 if you're curious.

Wed, Mar 27, 2:18 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch created P8291 Vagrant eventgate node-rdkafka dependency error.
Wed, Mar 27, 2:17 PM

Mar 19 2019

DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

Okay, yeah. Patch made it so that we do var fragment = this.getSectionFragmentFromPage(); but that just interrogates the current markup of the page pre-edit. This explains changing the section-name breaking things, since after the page-reload it'll be a different id to look for.

Mar 19 2019, 3:12 AM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mar 18 2019

Deskana awarded T218588: Security Issue Access Request for DLynch a Like token.
Mar 18 2019, 4:37 PM · Security-Team, Security
DLynch added a comment to T218588: Security Issue Access Request for DLynch.

Yup, I have it.

Mar 18 2019, 3:42 PM · Security-Team, Security
DLynch created T218588: Security Issue Access Request for DLynch.
Mar 18 2019, 3:36 PM · Security-Team, Security
DLynch added a comment to T213120: Restore section hash fragment after section editing in mobile VE.

I note that @Ryasmeen changed the title of the section. Perhaps we're generating an outdated section-hash as a result rather than one based on the new hash for the new title? The video didn't show the URL, so I can't be sure.

Mar 18 2019, 3:26 PM · MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), User-Ryasmeen, Section Editing, Verified, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mar 15 2019

DLynch added a comment to T218275: Vagrant restbase can't launch: statsd.childClient is not a function.

I'll confirm that some forced-updating seems to have fixed this. Thanks!

Mar 15 2019, 6:57 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner, RESTBase, MediaWiki-Vagrant
DLynch created T218386: Invalid peer dependencies between eslint and plugins.
Mar 15 2019, 6:57 AM · Core Platform Team Kanban (Done with CPT), Services (done), Core Platform Team (Security, stability, performance and scalability (TEC1)), Citoid

Mar 14 2019

DLynch added a project to T218275: Vagrant restbase can't launch: statsd.childClient is not a function: service-runner.
Mar 14 2019, 2:08 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner, RESTBase, MediaWiki-Vagrant
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

Let's see... doing exactly-what-the-error-message-says and adding the npm::node_version: 10 to hieradata/common.yaml gets through with no errors after only a few runs of provision.

Mar 14 2019, 2:07 AM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch created T218275: Vagrant restbase can't launch: statsd.childClient is not a function.
Mar 14 2019, 2:06 AM · Core Platform Team Kanban (Done with CPT), Services (done), service-runner, RESTBase, MediaWiki-Vagrant
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

The visualeditor role requires the restbase role which requires eventbus.

Mar 14 2019, 12:41 AM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant

Mar 13 2019

DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

Okay, I did a full re-initialization of vagrant, and this error didn't come up until I did role enable visualeditor. So one of the dependencies there is, I guess, not configured correctly?

Mar 13 2019, 9:48 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch merged T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor into T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.
Mar 13 2019, 6:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch merged task T217375: on mobile web source editor, "Next" button stays grayed out after changing source if edit started in visual editor into T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.
Mar 13 2019, 6:00 PM · VisualEditor (Current work), MobileFrontend, VisualEditor-MediaWiki-Mobile
DLynch updated subscribers of T218238: Vagrant initial provision fails on NodeJS version mismatch.
Mar 13 2019, 5:55 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch added a comment to T218238: Vagrant initial provision fails on NodeJS version mismatch.

A side-effect of some sort from rMWVAbb776a65b3e6dcd7a077add48fd3f1870dba333e, I assume.

Mar 13 2019, 5:55 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant
DLynch created T218238: Vagrant initial provision fails on NodeJS version mismatch.
Mar 13 2019, 5:49 PM · Patch-For-Review, Analytics-Kanban, Analytics, MediaWiki-Vagrant

Mar 12 2019

DLynch added a comment to T217825: Editing timing data incorrect for second load.

Isn't the 24ms just it being a really quick load because ResourceLoader has already loaded everything that comes from the mw.loader.using( 'ext.visualEditor.targetLoader' ) call, so it's just legitimately much faster than the 2565ms the first time?

Mar 12 2019, 3:46 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T187102: Vagrant's /var/log/daemon.log filling up with kafka errors.

@elukey No, nothing to fix it. Though it had, looking at it just now, switched into wildly spamming this into the log instead:

Mar 12 2019, 2:26 PM · Core Platform Team Backlog (Watching / External), Services (watching), Analytics, MediaWiki-Vagrant

Mar 7 2019

ppelberg awarded T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE a 100 token.
Mar 7 2019, 11:38 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch moved T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE from Code review to QA on the VisualEditor (Current work) board.
Mar 7 2019, 9:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch added a comment to T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.

That patch handles this ticket's case. We should probably go through all the changes in that patch and make sure that switching them to deep-extend won't cause any issues.

Mar 7 2019, 6:16 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch updated subscribers of T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.

Seems to be the result of a8be7d15e94a8e by @Niedzielski, which changed how constructors initialize events. It passes event handlers into constructors, and does a non-deep merge of existing options with util.extend. This breaks if the existing options have any event handlers already.

Mar 7 2019, 6:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch claimed T217617: [Regression ?] "Next" button stays disabled on MobileFrontend wikitext editor after switching from Mobile VE.
Mar 7 2019, 5:58 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Ryasmeen, VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-Mobile, Section Editing
DLynch added a comment to T217825: Editing timing data incorrect for second load.

Specifically the timing.ve.mobile.performance bits?

Mar 7 2019, 4:40 PM · MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Mar 6 2019

DLynch added a comment to T217783: Lose edits if idle on page.

Specifically: there's no autosave in wikitext mode, because that's not in the VE codebase -- there's no NWE on mobile currently. As far as I know we should have autosave working in visual mode, so it should recover from this case. It's possible that there's some disconnect in the recovery process, though, I haven't tested it.

Mar 6 2019, 5:52 PM · VisualEditor-MediaWiki-Mobile, VisualEditor
DLynch added a comment to T217783: Lose edits if idle on page.

I don't think this is section-editing specific? This is just the page getting kicked out of memory, and us not having autosave working on mobile (I think).

Mar 6 2019, 5:43 PM · VisualEditor-MediaWiki-Mobile, VisualEditor

Mar 4 2019

DLynch updated subscribers of T212340: VisualEditor silently changes <references responsive="1" /> to <references responsive="" />.

This is because we don't actually try to preserve the value of the attribute, just its meaning. More potentially-confusing is that we discard the attribute entirely if it's the same as the wiki's default, so if the default changes lots of edits will suddenly be dirtied... and then toggle away from it if the default switches back again.

Mar 4 2019, 6:04 PM · Verified, MW-1.33-notes (1.33.0-wmf.24; 2019-04-02), Patch-For-Review, VisualEditor (Current work)

Feb 28 2019

DLynch claimed T212253: Start oversampling all mobile visual editor EditAttemptStep events.
Feb 28 2019, 6:00 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, VisualEditor (Current work), Product-Analytics

Feb 27 2019

DLynch added a comment to T212253: Start oversampling all mobile visual editor EditAttemptStep events.

From a call today: Neil would prefer mobile-only oversampling. I'll work up a patch for that.

Feb 27 2019, 6:25 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, VisualEditor (Current work), Product-Analytics
DLynch merged T217257: Impossible to make a link from text containing non-breaking spaces into T217189: VisualEditor cannot set link when link label contains HTML entity.
Feb 27 2019, 5:28 PM · VisualEditor
DLynch merged task T217257: Impossible to make a link from text containing non-breaking spaces into T217189: VisualEditor cannot set link when link label contains HTML entity.
Feb 27 2019, 5:28 PM · VisualEditor

Feb 26 2019

DLynch updated subscribers of T212253: Start oversampling all mobile visual editor EditAttemptStep events.

Only mobile? I've taken a look at this, and @Catrope had hooked up mobile-and-desktop both to mw.config.get( 'wgWMESchemaEditAttemptStepOversample' ). If we want to only oversample mobile events, I think we'll need to tweak that.

Feb 26 2019, 6:02 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Patch-For-Review, VisualEditor (Current work), Product-Analytics

Feb 21 2019

DLynch added a comment to T213528: Adding a category to a page without any categories doesn't show up until saving.

The other side effect of this bug was that removing all non-hidden categories from the page would leave an empty categories box, when it should have been hidden.

Feb 21 2019, 5:42 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch moved T213528: Adding a category to a page without any categories doesn't show up until saving from In progress to Code review on the VisualEditor (Current work) board.
Feb 21 2019, 5:41 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch moved T213528: Adding a category to a page without any categories doesn't show up until saving from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Feb 21 2019, 5:37 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T213528: Adding a category to a page without any categories doesn't show up until saving.
Feb 21 2019, 5:37 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki
DLynch moved T213528: Adding a category to a page without any categories doesn't show up until saving from Q4 to Up next on the VisualEditor board.
Feb 21 2019, 4:33 PM · MW-1.33-notes (1.33.0-wmf.20; 2019-03-05), Verified, VisualEditor (Current work), VisualEditor-MediaWiki

Feb 15 2019

DLynch added a comment to T216248: Citation logging splits events by citation type.

Elsewhere Neil said that this is useful for how the data is actually being analyzed currently, as he was just aggregating the various cite- values together.

Feb 15 2019, 8:28 PM · MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), Patch-For-Review, VisualEditor (Current work)

Feb 5 2019

DLynch claimed T215101: CAPTCHAs are no longer served to mobile users, causing a generic error instead.
Feb 5 2019, 2:30 PM · User-Ryasmeen, Verified, VisualEditor (Current work), Readers-Web-Backlog (Tracking), Editing-team, MobileFrontend

Jan 24 2019

DLynch moved T214533: Mobile visual editor not logging EditAttemptStep abort actions from Ready for Pick Up to In progress on the VisualEditor (Current work) board.
Jan 24 2019, 5:37 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, VisualEditor (Current work), Contributors-Analysis, Product-Analytics
DLynch claimed T214533: Mobile visual editor not logging EditAttemptStep abort actions .
Jan 24 2019, 5:37 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, VisualEditor (Current work), Contributors-Analysis, Product-Analytics
DLynch added a comment to T214533: Mobile visual editor not logging EditAttemptStep abort actions .

Having checked: mobile VE's only source of abort events was (incorrectly) when switching. It has never emitted them for anything else. I'll improve that, so at least canceling out of it will emit them.

Jan 24 2019, 5:36 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, VisualEditor (Current work), Contributors-Analysis, Product-Analytics
DLynch moved T214453: VE: In the Edit dialog for links, when the “Done” button is disabled, the “Enter” key should be disabled as well from In progress to Code review on the VisualEditor (Current work) board.
Jan 24 2019, 5:19 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), VisualEditor (Current work)

Jan 23 2019

DLynch added a comment to T214533: Mobile visual editor not logging EditAttemptStep abort actions .

We expected a drop because the patch for T211156 stopped abort (and ready) from being logged when switching from wikitext to visual, which I suspect was a common source (you could look for ones with the abort_type logged as switchnochange).

Jan 23 2019, 11:43 PM · MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), Patch-For-Review, VisualEditor (Current work), Contributors-Analysis, Product-Analytics
DLynch claimed T214453: VE: In the Edit dialog for links, when the “Done” button is disabled, the “Enter” key should be disabled as well.
Jan 23 2019, 5:36 PM · User-Ryasmeen, Verified, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), VisualEditor (Current work)
DLynch added a comment to T214442: Can't Publish changes in Safari or Microsoft Edge at nlwiki.

I cannot reproduce this with Safari, at least.

Jan 23 2019, 5:12 PM · VisualEditor

Jan 22 2019

DLynch added a comment to T206050: Mobile visual editor does not log saveFailure events.

Is the -1ms timing and the console warning expected/acceptable?

Jan 22 2019, 4:19 AM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch moved T211236: After changing a link target, the link is selected such that typing will delete the link from Code review to QA on the VisualEditor (Current work) board.
Jan 22 2019, 4:16 AM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)

Jan 19 2019

DLynch added a comment to T214132: Switch the 2010 wikitext editor's EditAttemptStep logging to the client side.

I'm not sure if we can without changing the meanings of them, though. At least the timings will change, and no longer really be measuring the same thing as the VE timings for the same events. E.g. init will suddenly become the same thing as ready/loaded. There's also not a great place to do saveSuccess client-side, since it'd be on the redirect to a regular article page...

Jan 19 2019, 12:33 AM · Product-Analytics, VisualEditor

Jan 17 2019

DLynch added a comment to T207796: Add flag to log tracking events to console.

Assuming it passes the QA phase, certainly.

Jan 17 2019, 7:26 PM · VisualEditor (Current work)
DLynch claimed T207796: Add flag to log tracking events to console.

Yes, that wound up being there.

Jan 17 2019, 5:53 PM · VisualEditor (Current work)
DLynch added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

@dchan: In this case it'd need to be model selections -- the annotation inspectors deal entirely with changes to the model. There's a reason I went for the somewhat-hackier route of just tweaking the DOM selection after the normal annotation path had been taken. :D

Jan 17 2019, 3:31 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)
DLynch moved T206014: Mobile editors do not log loaded events from In progress to Code review on the VisualEditor (Current work) board.
Jan 17 2019, 3:28 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Jan 16 2019

DLynch claimed T206014: Mobile editors do not log loaded events.
Jan 16 2019, 6:53 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work), Editing Q1 2018-19 mobile improvements, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis
DLynch claimed T211236: After changing a link target, the link is selected such that typing will delete the link.
Jan 16 2019, 6:46 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)
DLynch removed a project from T202271: Allow restbase url to be set directly in Citoid extension, overwriting the VE url.: Patch-For-Review.
Jan 16 2019, 6:44 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), Citoid

Jan 15 2019

DLynch added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

@dchan: I was thinking that the alternative route was to write greater awareness of nails into selections, such that when setting a selection you could declare whether it should bias inside or outside. That'd avoid this whole post-selection-change fixup routine... but would also complicate the core selection-handling code for the comparatively-unusual case. (That said, I don't have a comprehensive set of cases in my head for model-equivalent-but-practically-different selections. It's possible it'd be applicable to enough cases that it'd make sense to move further into the core...)

Jan 15 2019, 6:57 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)

Jan 8 2019

DLynch moved T211236: After changing a link target, the link is selected such that typing will delete the link from Ready for Pick Up to Code review on the VisualEditor (Current work) board.
Jan 8 2019, 5:47 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)
DLynch edited projects for T211236: After changing a link target, the link is selected such that typing will delete the link, added: VisualEditor (Current work); removed VisualEditor.
Jan 8 2019, 5:47 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)

Dec 18 2018

DLynch added a comment to T205166: Mobile editors do not log timings for any Edit events.

Almost the only QA possible for this one (besides it not actually breaking things) would be Neil saying whether the data being collected is correct, I think?

Dec 18 2018, 5:05 PM · User-Ryasmeen, Editing QA, MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), Patch-For-Review, VisualEditor (Current work), Readers-Web-Backlog (Tracking), MobileFrontend, Editing Q1 2018-19 mobile improvements, Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Dec 13 2018

DLynch added a comment to T211698: 'trackdebug' mode doesn't work unless debug mode is enabled.

Second patch for the MobileFrontend side of the logging code, which had the same use of mw.log.

Dec 13 2018, 4:01 PM · MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), VisualEditor (Current work), Patch-For-Review, Technical-Debt
DLynch added a comment to T211156: Review EditAttemptStep validation failures in production.

There's also some intellectual verification -- turn on trackdebug, and verify that the timing keys in the logged events after a switch don't have any null / NaN values.

Dec 13 2018, 3:56 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis

Dec 12 2018

DLynch reassigned T211788: Identify IME behaviors that will need additional design treatment from DLynch to dchan.

Related is probably: T204387

Dec 12 2018, 5:42 PM · VisualEditor (Current work)
DLynch added a comment to T211156: Review EditAttemptStep validation failures in production.

Quick testing with trackdebug confirms that on mobile switching back and forth between visual and source modes causes a flurry of events which we probably don't want:

Dec 12 2018, 4:03 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
DLynch added a comment to T211156: Review EditAttemptStep validation failures in production.

Kibana suggests upon following the provided link: "Unable to completely restore the URL, be sure to use the share functionality". I'm sufficiently unfamiliar with using it that the rest of this reply is going to be based just on what was said in the ticket description.

Dec 12 2018, 3:46 PM · VisualEditor (Current work), MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), Editing-team, Product-Analytics, Contributors-Analysis
DLynch added a comment to T211236: After changing a link target, the link is selected such that typing will delete the link.

It should be pretty simple to do -- I've had it on my list of tasks to knock out when I have 15 minutes free.

Dec 12 2018, 3:36 PM · Verified, VisualEditor-EditingTools, MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), VisualEditor (Current work)
DLynch added a comment to T211240: Mobile table editing should default to cell contents.

We called it out in the planning document for T211255 as a related change that should be made. David or I could probably fit it in, depending on which of us finishes up our prototyping / research first.

Dec 12 2018, 3:33 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Dec 11 2018

DLynch moved T206050: Mobile visual editor does not log saveFailure events from In progress to Code review on the VisualEditor (Current work) board.
Dec 11 2018, 5:00 PM · MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), Editing Q1 2018-19 mobile improvements, VisualEditor (Current work), Product-Analytics, VisualEditor-MediaWiki, Contributors-Analysis

Dec 5 2018

DLynch updated subscribers of T211240: Mobile table editing should default to cell contents.
Dec 5 2018, 9:50 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch created T211240: Mobile table editing should default to cell contents.
Dec 5 2018, 9:31 PM · VisualEditor (Current work), VisualEditor-MediaWiki-Mobile