Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (426 w, 6 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Yesterday

DLynch moved T352232: [Config] Phase 1 deployment of usability improvements on pages using _NEWSECTIONLINK_ from Doing to QA on the Editing-team (Kanban Board) board.
Wed, Dec 6, 9:19 PM · Editing QA, User-notice, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
DLynch added a comment to T352355: [Config] Enable Edit Check (References) at additional partner wikis.

Update: none of these are getting deployed today, and arwiki won't be enabled universally because it's going to be in the A/B test.

Wed, Dec 6, 4:35 PM · Goal, Editing-team (Kanban Board), EditCheck, VisualEditor

Tue, Dec 5

DLynch moved T346949: Implement edit check configuration setting to restrict sections it'll apply within from Code Review to QA on the Editing-team (Kanban Board) board.

Testing this will involve editing the MediaWiki:Editcheck-config.json message. It adds support for two new keys:

Tue, Dec 5, 5:25 PM · Editing QA, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
DLynch assigned T351946: mobile diff doesn't support switching between Visual and WikiText diffs to Esanders.
Tue, Dec 5, 3:59 PM · Editing QA, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), VisualEditor, VisualEditor-VisualDiffs, MobileFrontend

Mon, Dec 4

DLynch added a comment to T352619: Visual editor should preserve text selection status on editor startup.

That said, this is another on the pile of tasks that'll potentially get simpler as the Parsoid read-views roll out, because then VE and read-mode will be operating off of basically the same HTML.

Mon, Dec 4, 7:01 PM · VisualEditor

Sun, Dec 3

DLynch added a comment to T352619: Visual editor should preserve text selection status on editor startup.

I am not a javascript/DOM expert, but wouldn't it be trivial to make a call to window.getSelection() before invoking the editor, remembering that, re-select that text after the editor starts, and use element.scrollIntoView() to get back to it?

Sun, Dec 3, 10:22 PM · VisualEditor

Sat, Dec 2

DLynch added a comment to T352591: Show page-level discussion statistics.

GBasha-WMF was looking for a way to find this information, and it occurred to me that it was sort of strange we weren't already exposing it...

Sat, Dec 2, 3:43 AM · Editing-team (Design Backlog), Editing Design, DiscussionTools
DLynch created T352591: Show page-level discussion statistics.
Sat, Dec 2, 3:40 AM · Editing-team (Design Backlog), Editing Design, DiscussionTools

Thu, Nov 30

DLynch added a comment to T202719: Backspace across paragraphs is broken on mobile VE (Android Chrome).

Looks like the patch here got moved to T312558 and merged -- we might want to QA this issue specifically.

Thu, Nov 30, 4:37 PM · Patch-For-Review, Editing-team, VisualEditor, VisualEditor-Mobile-UsabilityImprovements, Browser-Support-Android-Google-Chrome, Editing Q1 2018-19 mobile improvements, VisualEditor-MediaWiki-Mobile, VisualEditor-ContentEditable

Wed, Nov 29

DLynch added a comment to T352303: Error while responding to messages from a specific user: "Could not find the comment you're replying to".

I wonder if the language-variants are confusing it somewhere. Садко vs Sadko in what it's looking for when trying to find the comment, etc.

Wed, Nov 29, 4:12 PM · DiscussionTools

Tue, Nov 28

DLynch added a comment to T350912: VE adding empty link param to galleries, images unclickable.

QA note: you should be able to test this by just viewing the "review changes" diff from the save dialog. There's no way to set the link parameter from inside VE, but with this patch it should just leave alone whatever someone has set it to in the source.

Tue, Nov 28, 10:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Parsoid, Regression, VisualEditor, MediaWiki-Gallery
DLynch claimed T350912: VE adding empty link param to galleries, images unclickable.
Tue, Nov 28, 5:45 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Parsoid, Regression, VisualEditor, MediaWiki-Gallery
DLynch moved T350912: VE adding empty link param to galleries, images unclickable from Incoming to Code Review on the Editing-team (Kanban Board) board.
Tue, Nov 28, 5:44 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Parsoid, Regression, VisualEditor, MediaWiki-Gallery
DLynch moved T350749: Create a user script to enable Edit Check from Doing to Code Review on the Editing-team (Kanban Board) board.
Tue, Nov 28, 5:18 AM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Goal, Editing-team (Kanban Board), EditCheck, VisualEditor

Mon, Nov 27

DLynch added a comment to T350912: VE adding empty link param to galleries, images unclickable.

@Arlolra git bisect indicates that this was caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/969191

Mon, Nov 27, 11:47 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Parsoid, Regression, VisualEditor, MediaWiki-Gallery
DLynch added a project to T350912: VE adding empty link param to galleries, images unclickable: Parsoid.
Mon, Nov 27, 11:32 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Parsoid, Regression, VisualEditor, MediaWiki-Gallery
DLynch added a comment to T352012: Error: Object of class Wikimedia\Message\ScalarParam could not be converted to string (in action=visualeditor).

Hm, yeah, my suggestion wouldn't work at all, because ApiMessage::create can't take a MessageValue.

Mon, Nov 27, 4:32 PM · Editing-team, MediaWiki-REST-API, API Platform, VisualEditor, affects-translatewiki.net
DLynch added a comment to T352012: Error: Object of class Wikimedia\Message\ScalarParam could not be converted to string (in action=visualeditor).

The problem seems to be something about how the ApiParsoidTrait dieWithRestHttpException is trying to pass the exception error message from the LocalizedHttpException through to the API.

Mon, Nov 27, 4:12 PM · Editing-team, MediaWiki-REST-API, API Platform, VisualEditor, affects-translatewiki.net

Fri, Nov 17

DLynch reassigned T351549: TypeError: Cannot read properties of undefined (reading 'getAttribute') from DLynch to Esanders.
Fri, Nov 17, 8:10 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Skipped QA, Editing-team (Kanban Board), Wikimedia-production-error, VisualEditor
DLynch claimed T351549: TypeError: Cannot read properties of undefined (reading 'getAttribute') .
Fri, Nov 17, 4:44 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Skipped QA, Editing-team (Kanban Board), Wikimedia-production-error, VisualEditor
DLynch moved T351549: TypeError: Cannot read properties of undefined (reading 'getAttribute') from Incoming to Code Review on the Editing-team (Kanban Board) board.
Fri, Nov 17, 4:43 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Skipped QA, Editing-team (Kanban Board), Wikimedia-production-error, VisualEditor
DLynch added a comment to T351549: TypeError: Cannot read properties of undefined (reading 'getAttribute') .

Related to T350902. I think the two patches for that wound up merging and not producing the expected order.

Fri, Nov 17, 4:40 PM · MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Skipped QA, Editing-team (Kanban Board), Wikimedia-production-error, VisualEditor
DLynch claimed T351542: Reply buttons are visible on archived discussions on mobile.
Fri, Nov 17, 3:53 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), DiscussionTools
DLynch created T351542: Reply buttons are visible on archived discussions on mobile.
Fri, Nov 17, 3:25 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), DiscussionTools

Thu, Nov 16

DLynch added a project to T351470: Should topics / replies consisting entirely of whitespace be allowed?: Editing-team.
Thu, Nov 16, 9:54 PM · Editing-team, DiscussionTools
DLynch added a comment to T326500: The new talk pages should not send posts by pressing enter.

I made T351470 for this question.

Thu, Nov 16, 9:54 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch created T351470: Should topics / replies consisting entirely of whitespace be allowed?.
Thu, Nov 16, 9:53 PM · Editing-team, DiscussionTools
DLynch added a comment to T326500: The new talk pages should not send posts by pressing enter.

Hm, actually... it's different from the classic editor because we auto-sign the comments, so it's impossible to leave an actually completely empty comment/topic. And the classic new-topic editor would certainly allow the equivalent of just entering "~~~~".

Thu, Nov 16, 9:48 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T326500: The new talk pages should not send posts by pressing enter.

@Ryasmeen fair point -- I was thinking it was something we had allowed for backwards-compatibility with the behavior of the non-DT new-topic tool, but I checked and that does suppress entirely-whitespace comments.

Thu, Nov 16, 9:44 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch moved T351448: Extra right padding inside username autocompletion dropdown from Incoming to QA on the Editing-team (Kanban Board) board.
Thu, Nov 16, 7:44 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools
DLynch assigned T351448: Extra right padding inside username autocompletion dropdown to Esanders.

Pretty recent, then -- the patch that added the scrollbar-gutter rule to OOUI was from Oct 25.

Thu, Nov 16, 7:44 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), Regression, DiscussionTools
DLynch moved T341491: [MILESTONE] Deploy config change to "turn off" Usability Improvements A/B test and enable features for A/B test wikis from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:48 PM · Patch-For-Review, Goal, Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
DLynch moved T326500: The new talk pages should not send posts by pressing enter from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:47 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch moved T296905: Content pasted just after a link is always placed inside a link from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:47 PM · Verified, Editing-team (Kanban Board), VisualEditor-CopyPaste, VisualEditor
DLynch moved T326500: The new talk pages should not send posts by pressing enter from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:47 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch moved T346944: Edit icons appear as text in Minerva desktop from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:40 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Web-Team-Backlog, Editing-team (Kanban Board), MinervaNeue, VisualEditor
DLynch moved T349264: Link editcheck-reference-activated tag to Edit Check false positive reporting page from Code Review to QA on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:36 PM · Verified, MW-1.42-notes (1.42.0-wmf.2; 2023-10-24), Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
DLynch moved T337398: DEFAULTSORT not recognized by VisualEditor from Incoming to QA on the Editing-team (Kanban Board) board.
Thu, Nov 16, 5:33 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), User-notice, Parsoid (Tracking), Regression, VisualEditor
DLynch assigned T337398: DEFAULTSORT not recognized by VisualEditor to matmarex.
Thu, Nov 16, 5:32 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), User-notice, Parsoid (Tracking), Regression, VisualEditor

Wed, Nov 15

DLynch added a comment to T351044: DiscussionTools: Expand section arrow is misplaced on mobile.

It's intentional for them to center-aligned on pages without visual enhancements, but they should still be top-aligned on pages with them.

Wed, Nov 15, 7:57 PM · Verified, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Editing-team (Kanban Board), DiscussionTools
DLynch moved T351235: VisualEditorEdit paction=diff gives bad results on MCR pages from Doing to Code Review on the Editing-team (Kanban Board) board.
Wed, Nov 15, 4:29 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor
DLynch moved T351235: VisualEditorEdit paction=diff gives bad results on MCR pages from Incoming to Doing on the Editing-team (Kanban Board) board.
Wed, Nov 15, 4:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor
DLynch added a project to T351235: VisualEditorEdit paction=diff gives bad results on MCR pages: Editing-team (Kanban Board).
Wed, Nov 15, 4:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor
DLynch claimed T351235: VisualEditorEdit paction=diff gives bad results on MCR pages.
Wed, Nov 15, 4:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor

Tue, Nov 14

DLynch added a comment to T350904: [INVESTIGATION] What additional semantic primitives could be introduced to better understood VE edits at scale?.

It's worth considering that "pasted" is more complicated than everything else mentioned so far, both technically and conceptually, because it's content that has meaning because a certain action was performed with it, rather than something that could be worked out by analyzing the text after the fact.

Tue, Nov 14, 10:04 PM · EditCheck, Editing-team, VisualEditor
DLynch added a comment to T351235: VisualEditorEdit paction=diff gives bad results on MCR pages.

toslots being main doesn't stop the other slots being considered for the diff. It seems to just be a mechanism to explicitly tell the API which slot given content is being provided for -- the API is going to return all the slots in its output unless we tell it not to. e.g. https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=compare&format=json&fromtitle=File%3ALord%20Bishnu-Shesh%20Narayan.JPG&toslots=main&totext-main=test&formatversion=2

Tue, Nov 14, 4:47 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor
DLynch added a comment to T351235: VisualEditorEdit paction=diff gives bad results on MCR pages.

To see this go to e.g. https://commons.wikimedia.org/wiki/File:Lord_Bishnu-Shesh_Narayan.JPG and make any minor change in VE or in VE's source mode, and review your changes (in wikitext mode; the visual diff will look fine). You'll see something like this:

Tue, Nov 14, 4:06 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor
DLynch created T351235: VisualEditorEdit paction=diff gives bad results on MCR pages.
Tue, Nov 14, 4:01 PM · Verified, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), Editing-team (Kanban Board), VisualEditor
DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

The last round of patches went out in the train that made it to most wikis on Nov 2nd. We now seem to be hovering at around 0-5 EditAttemptStep schema validation errors on a given day (there haven't been any since the 11th, at the time I write this).

Tue, Nov 14, 3:52 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
DLynch added a project to T351208: Wikimedia\Assert\PostconditionException: Postcondition failed: Parsoid revision did not match requested revision: Parsoid.
Tue, Nov 14, 3:29 PM · Editing-team (Tracking), Parsoid (Tracking), DiscussionTools, Wikimedia-production-error

Mon, Nov 13

DLynch claimed T351044: DiscussionTools: Expand section arrow is misplaced on mobile.
Mon, Nov 13, 3:26 PM · Verified, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Editing-team (Kanban Board), DiscussionTools
DLynch added a comment to T351044: DiscussionTools: Expand section arrow is misplaced on mobile.

Side-effect of the change for T344629, I guess.

Mon, Nov 13, 1:40 AM · Verified, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Editing-team (Kanban Board), DiscussionTools

Thu, Nov 9

DLynch closed T350902: Cannot read properties of undefined (reading 'getRange') as Resolved.
Thu, Nov 9, 8:08 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), VisualEditor, Wikimedia-production-error
DLynch updated subscribers of T350912: VE adding empty link param to galleries, images unclickable.

@Arlolra Is this a plausible side-effect of the recent round-tripping changes for T348703?

Thu, Nov 9, 7:55 PM · Verified, MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Editing-team (Kanban Board), Parsoid, Regression, VisualEditor, MediaWiki-Gallery
DLynch added a comment to T350904: [INVESTIGATION] What additional semantic primitives could be introduced to better understood VE edits at scale?.

(The former is basically why we have tags, incidentally -- we preselect things we think are important and pull them out so we can filter revisions based on that. Sometimes it's data that isn't really part of the revision -- the editor used, actions taken during the edit, etc -- but other times it's thinks like the "a notable amount of content was added" or "a citation was added" which could be worked out at any time, it's just expensive to do so in a query.)

Thu, Nov 9, 6:32 PM · EditCheck, Editing-team, VisualEditor
DLynch added a comment to T350904: [INVESTIGATION] What additional semantic primitives could be introduced to better understood VE edits at scale?.

The challenge of this sort of analysis being applied to something like Special:RecentChanges, or similar server-side tools, is that it's all the outcome of some fairly complicated processing of the data. If we want it to work server-side, we'd probably need to add a whole layer of data storage that could be queried, for which we'd need to define up-front a limited set of data that was worth extracting for use.

Thu, Nov 9, 6:27 PM · EditCheck, Editing-team, VisualEditor
DLynch claimed T350749: Create a user script to enable Edit Check.
Thu, Nov 9, 6:04 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Goal, Editing-team (Kanban Board), EditCheck, VisualEditor
DLynch updated subscribers of T350902: Cannot read properties of undefined (reading 'getRange').

This is on ve.dm.InternalList.prototype.sortGroupIndexes, where it's trying to sort the group and it's finding that there's not a firstNode for one of the indexes. Stack implies that it's in the transaction code, coming off of a content insertion, but is a bit unhelpful for working out what kind of content was inserted.

Thu, Nov 9, 5:38 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), VisualEditor, Wikimedia-production-error
DLynch added a comment to T350899: TypeError: Cannot read properties of null (reading 'getAttribute') in ve.ce.MWGalleryNode.onUpdate.

It's on var mwAttrs = this.model.getAttribute( 'mw' ).attrs;, specifically saying that this.model doesn't exist. Probably means that the debounced event handler is managing to run after the teardown Fortunately, this would mean that there's no functional problem being caused by it.

Thu, Nov 9, 5:22 PM · VisualEditor, Wikimedia-production-error
DLynch added a comment to T347531: Define user experience for prompting people to review and replace unreliable sources.

Re: 1.A, this message is probably going to be very similar to the existing spamprotectiontext message, but we can't just use that one because (a) its default wording expects to be talking about a whole attempted-edit and so is a bit too vague ("probably caused by a link to a forbidden external site"), and (b) some wikis (looking at you, enwiki) have customized it to be huge and so it would cause display issues squeezing it into the citoid dialog.

Thu, Nov 9, 2:29 AM · Editing-team (Kanban Board), Community-Wishlist-Survey-2023, EditCheck, VisualEditor
DLynch added a comment to T350840: TypeError: Cannot read properties of null (reading 'parentNode') at ThreadItem.js.ThreadItem.static.newFromJSON.

The error on the linked one is happening on a diff of a talk page. However, it doesn't happen to me when I visit that page.

Thu, Nov 9, 2:02 AM · Wikimedia-production-error, DiscussionTools

Wed, Nov 8

DLynch renamed T347644: Introduce hidden tag to identify edits when new sentences are added from Introduce hidden to identify edits when new sentences are added to Introduce hidden tag to identify edits when new sentences are added.
Wed, Nov 8, 5:35 PM · Goal, Editing-team (Kanban Board), EditCheck

Tue, Nov 7

DLynch moved T350634: [Config] Enable Edit Check (References) at fon.wiki from Code Review to QA on the Editing-team (Kanban Board) board.
Tue, Nov 7, 9:18 PM · Editing QA, Editing-team (Kanban Board), EditCheck, VisualEditor
DLynch added a comment to T326500: The new talk pages should not send posts by pressing enter.

@Ryasmeen the description field isn't empty -- you're adding a linebreak to it, otherwise it wouldn't have let you post the topic. (We could argue about whether we should count an all-whitespace description is being empty, of course, but as it stands there is content in it.)

Tue, Nov 7, 8:47 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch moved T350634: [Config] Enable Edit Check (References) at fon.wiki from Doing to Code Review on the Editing-team (Kanban Board) board.
Tue, Nov 7, 8:21 PM · Editing QA, Editing-team (Kanban Board), EditCheck, VisualEditor
DLynch moved T350634: [Config] Enable Edit Check (References) at fon.wiki from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
Tue, Nov 7, 8:20 PM · Editing QA, Editing-team (Kanban Board), EditCheck, VisualEditor
DLynch claimed T348805: Create dashboard for viewing edits Edit Check was activated within.
Tue, Nov 7, 5:50 PM · Goal, EditCheck, Editing-team (Kanban Board)
DLynch moved T349265: Investigate feasibility of leveraging the sentencex library within Edit Check from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
Tue, Nov 7, 5:17 PM · Goal, Editing-team (Kanban Board), EditCheck
DLynch added a comment to T350670: [Regression] Wikipedia Portal: Sites Missing in the List.

It was definitely removed in this commit: https://gerrit.wikimedia.org/r/c/wikimedia/portals/deploy/+/971987/1/wikipedia.org/index.html

Tue, Nov 7, 4:41 PM · Unplanned-Sprint-Work, Localization Infrastructure FY2023-24, Language-Team (Language-2023-October-December), Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3), Regression, Chinese-Sites, Wikimedia-Portals

Nov 7 2023

DLynch added a comment to T350627: No longer possible to collapse sections on mobile.

ssastry did a code search and noticed that there's one non-WMF skin that was going to be hit by the same xpath issue, so I made a pull request on it on github.

Nov 7 2023, 1:40 AM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
DLynch closed T350627: No longer possible to collapse sections on mobile as Resolved.
Nov 7 2023, 1:39 AM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
DLynch closed T350627: No longer possible to collapse sections on mobile, a subtask of T350080: 1.42.0-wmf.4 deployment blockers, as Resolved.
Nov 7 2023, 1:38 AM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Release-Engineering-Team (Quid Pro Crow 🦃), Release, Train Deployments

Nov 6 2023

DLynch added a comment to T350627: No longer possible to collapse sections on mobile.

Quick explanation of the issue:

  1. [@class="mw-parser-output"] is checking for an exact-match of the class attribute.
  2. The parser patch added more classes to the mw-parser-output div.
  3. class="mw-content-ltr mw-parser-output" is no-longer an exact match.
Nov 6 2023, 10:24 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
DLynch added a comment to T350627: No longer possible to collapse sections on mobile.

I guess that patch changed the base Parser output as well, so it really could be either.

Nov 6 2023, 10:09 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)
DLynch added a comment to T350627: No longer possible to collapse sections on mobile.

Looks like the MobileFrontend MakeSectionsTransform is no longer working correctly with presumably-changed Parsoid markup -- the linked beta page has the entire article content wrapped in <section class="mf-section-0" id="mf-section-0">.

Nov 6 2023, 9:48 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), Patch-For-Review, MediaWiki-Platform-Team, Content-Transform-Team, Wikimedia-production-error, Web-Team-Backlog (Web Team FY2023-24 Q2 Sprint 3)

Nov 4 2023

DLynch added a comment to T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.

If I was a deployer, I’d assume that any questions have already been cleared during a team meeting.

The deployers don't take any outstanding patches against the repo and merge them, they just merge the ones that've actually been signed up for deployment on https://wikitech.wikimedia.org/wiki/Deployments -- in part because the process includes testing the patch on a staging server, and a random deployer wouldn't know enough about a given patch to properly test that it worked.

Nov 4 2023, 7:37 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
DLynch added a comment to T331635: Enable topic containers and other visual enhancements on pages using __NEWSECTIONLINK__.

Should that be marked work-in-progress until the decision has been made?

I tend to feel that there's no point marking config patches as work-in-progress, as they can only ever be merged by directly being shepherded through a backport window. (Along with the other flaws of the work-in-progress system, of course.)

Nov 4 2023, 2:40 PM · CommRel-Specialists-Support (Oct-Dec-2023), MW-1.41-notes (1.41.0-wmf.1; 2023-03-20), Editing-team (Kanban Board), TPP-Scaling, DiscussionTools
DLynch moved T338171: Revise UI copy for temporary accounts from Code Review to QA on the Editing-team (Kanban Board) board.
Nov 4 2023, 2:10 AM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MediaWiki-Page-editing, Temporary accounts, Goal, Anti-Harassment, Design, Editing-team (Kanban Board)
DLynch updated the task description for T338171: Revise UI copy for temporary accounts.
Nov 4 2023, 2:06 AM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MediaWiki-Page-editing, Temporary accounts, Goal, Anti-Harassment, Design, Editing-team (Kanban Board)
DLynch updated the task description for T338171: Revise UI copy for temporary accounts.
Nov 4 2023, 1:55 AM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MediaWiki-Page-editing, Temporary accounts, Goal, Anti-Harassment, Design, Editing-team (Kanban Board)

Nov 3 2023

DLynch added a comment to T350494: Overlapping page elements when previewing source edits with 2017 wikitext editor mode.

This has already been fixed by T348288, and was thus presumably a symptom of the ongoing reorganization of overlays -- the fix will be going out next week on the normal deployment schedule.

Nov 3 2023, 4:55 PM · VisualEditor, Desktop Improvements (Vector 2022), VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T350494: Overlapping page elements when previewing source edits with 2017 wikitext editor mode.

Confirmed:

image.png (464×2 px, 250 KB)

Nov 3 2023, 4:40 PM · VisualEditor, Desktop Improvements (Vector 2022), VisualEditor-MediaWiki-2017WikitextEditor

Nov 2 2023

DLynch closed T289703: Hotcat after a visual editor save gets old page version as Resolved.

I've gone ahead and fixed HotCat.

Nov 2 2023, 7:51 PM · VisualEditor
DLynch added a comment to T347945: Preformatted text (by entering a space) does not apply on first line in new topic.

Happens because the posting API does $wikitext = CommentModifier::appendSignatureWikitext( $wikitext, $signature );, which calls CommentUtils::htmlTrim on the wikitext (which strips the opening/closing whitespace). I can't remember if we're doing that for a specific reason.

Nov 2 2023, 5:06 PM · DiscussionTools
DLynch moved T237063: EventLogging validation errors for EditAttemptStep from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.

Another wait-for-train pause.

Nov 2 2023, 4:54 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team

Nov 1 2023

DLynch added a comment to T350269: Visual Editor causes edit conflicts with HotCat.

It's a bug in HotCat because VisualEditor does update wgCurRevisionId after it saves an edit. HotCat stores a copy of the values on pageload and never updates them, and so it doesn't notice this.

Nov 1 2023, 3:57 PM · VisualEditor
DLynch claimed T338171: Revise UI copy for temporary accounts.
Nov 1 2023, 1:08 AM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MediaWiki-Page-editing, Temporary accounts, Goal, Anti-Harassment, Design, Editing-team (Kanban Board)

Oct 31 2023

DLynch added a comment to T338171: Revise UI copy for temporary accounts.

From our meeting, "Learn more" in the revised copy will link to https://meta.wikimedia.org/wiki/IP_Editing:_Privacy_Enhancement_and_Abuse_Mitigation for now until something more-direct comes along.

Oct 31 2023, 5:13 PM · Verified, MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MediaWiki-Page-editing, Temporary accounts, Goal, Anti-Harassment, Design, Editing-team (Kanban Board)
DLynch moved T326500: The new talk pages should not send posts by pressing enter from Doing to Code Review on the Editing-team (Kanban Board) board.
Oct 31 2023, 5:10 PM · MW-1.42-notes (1.42.0-wmf.4; 2023-11-07), MW-1.41-notes (1.41.0-wmf.30; 2023-10-10), Editing-team (Kanban Board), DiscussionTools
DLynch moved T348482: Visual Editor template editor dialog should allow more room for Alternative text from Incoming to QA on the Editing-team (Kanban Board) board.
Oct 31 2023, 5:08 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), VisualEditor-MediaWiki-Templates, VisualEditor
DLynch assigned T348482: Visual Editor template editor dialog should allow more room for Alternative text to Esanders.
Oct 31 2023, 5:08 PM · Verified, Editing-team (Kanban Board), MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), VisualEditor-MediaWiki-Templates, VisualEditor
DLynch added a comment to T349851: lua mw.addWarning() messaging not visible when using VisualEditor.

VE edit notices show up in this side-popup when you start editing a page:

image.png (868×846 px, 150 KB)

Oct 31 2023, 5:00 PM · VisualEditor
DLynch added a comment to T97720: Add a tags parameter to API modules creating a logentry.

VisualEditor just got tagged here and so I learned about this task. I think we've already done everything it requests as of T343339.

Oct 31 2023, 3:30 PM · MediaWiki-extensions-FlaggedRevs, Patch-Needs-Improvement, Google-Code-In-2016, MW-1.29-release-notes, MW-1.27-release-notes, MediaWiki-Action-API, MediaWiki-Change-tagging

Oct 30 2023

DLynch added a comment to T350064: On some pages, some references disappear or render differently in Edit mode compared to Read mode.

The issue is indeed that some references are defined in places that VE can't know about. In this case it's the three that're defined inside the infobox parameters.

Oct 30 2023, 7:53 PM · VisualEditor
DLynch added a comment to T350062: When using the newcomer tool: add a link on fr.wiki with a bad connection, I get prompted to "switch to source editor".

I'd need to double-check what "mode" the growth tool is opening in, but assuming it's adding a custom one, it seems possible that just restricting the fallback so it's only offered if we're trying to load "visual" would be the right thing to do.

Oct 30 2023, 7:42 PM · Add-Link, Growth-Team, VisualEditor, Editing-team
DLynch added a comment to T349653: Permalink redirecting: Support plain section links.

Will this run independently of other DiscussionTools features?

The patch-as-written includes it inside the DT initialization, so it'll run if anything at all is causing DT to be loaded on the page. (Which I think might be always happening on talk pages now regardless of how many of the sub-features are disabled. I checked, and turning off everything in the preferences still leaves the mw.dt object existing from the dt.init JS.)

Oct 30 2023, 5:50 PM · Patch-For-Review, DiscussionTools, Editing-team (Kanban Board)
DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

You've added click-new-sticky-header though – is that supposed to be the same thing?

In the cold light of the morning I see you were actually pointing out that this was weirdly named, rather than asking what it means. Yeah, I think that click-new-sticky-header should just be new-sticky-header.

Oct 30 2023, 4:59 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
DLynch moved T349866: Subscribe link is misaligned from Code Review to QA on the Editing-team (Kanban Board) board.
Oct 30 2023, 4:57 PM · Verified, MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), Editing-team (Kanban Board), DiscussionTools

Oct 29 2023

DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

click means it came from a click on an edit link. new means it came from either a redlink or from a section=new action. (url and url-new are those two, but from direct navigation rather than in-page actions.)

Oct 29 2023, 6:39 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team
DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

Huh, so there are. Looks like I didn't add them in https://gerrit.wikimedia.org/r/c/schemas/event/secondary/+/805728 -- I think because at the time it wasn't even possible to create a new section from the sticky header, if I'm remembering the timeline correctly.

Oct 29 2023, 6:10 PM · MW-1.42-notes (1.42.0-wmf.3; 2023-10-31), MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Editing-team (Kanban Board), MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.17; 2021-08-02), Growth-Team-Filtering, MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), VisualEditor, Growth-Team