Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (218 w, 4 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Thu, Dec 5

DLynch created T239933: mw-vagrant eventbus role doesn't install config file.
Thu, Dec 5, 5:03 PM · MediaWiki-Vagrant
DLynch added a comment to T234365: mw-vagrant eventbus role causing 'device full' due to service start failure loop.

I think this is ultimately a duplicate of T158617?

Thu, Dec 5, 4:59 PM · MediaWiki-Vagrant
DLynch added a comment to T158617: npm install fails for changeprop service in MW-Vagrant (cp rdkafka: permission denied).

This is definitely still an issue, and I just had to work around it while setting up a cloud VPS server.

Thu, Dec 5, 5:48 AM · Core Platform Team Legacy (Watching / External), Services (watching), MediaWiki-Vagrant

Mon, Dec 2

DLynch added a comment to T239328: [SPIKE] What talk-related events are being tracked?.

I've raised this question before and not seen an answer: what edit_count data is being used to assign people to the junior/senior buckets? Is it assigned at time-of-posting or time-of-analysis? Are we counting all edits or just article-namespace edits towards this? This could make a notable difference if we, say, made it much easier for people to post a lot of comments quickly...

Mon, Dec 2, 10:28 PM · Editing-team, OWC2020

Fri, Nov 22

DLynch added a comment to T211240: Mobile table editing should default to cell contents.

Jess and I were talking about this and we agreed to try out adding a slight margin to tables on mobile only when they have focus, to see how that affects the experience.

Fri, Nov 22, 4:57 PM · VisualEditor-Mobile-UsabilityImprovements, Verified, MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), Editing Design, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Thu, Nov 14

DLynch added a comment to T232601: Provide a mechanism for in-surface autocomplete.

That last patch is a not-to-be-merged-but-useful-to-exist-for-testing one. The actual username completion will exist over in DiscussionTools, but that's not actually in a state where it's easy to use yet.

Thu, Nov 14, 6:16 PM · Patch-For-Review, OWC2020, VisualEditor (Current work)

Nov 7 2019

DLynch added a comment to T235356: Fatal from ApiGraph->getGraphSpec: "Call to a member function getExtensionData() on boolean".

I don't actually know anything about the Graph extension, but a quick glance at the code suggests that it's trying to load a graph-spec from a page that doesn't exist, and doesn't have a sensible check for that failure case.

Nov 7 2019, 9:13 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Editing-team, MediaWiki-extensions-Graph, Wikimedia-production-error

Nov 6 2019

DLynch added a comment to T234046: Create OWC metric definitions.

I'm interested in the ORES scores over reversion-rates as well, mostly because it lets us avoid all sorts of confusion about what counts/should-count as a revert, and side-effect like the mentioned "what if we overwhelm the people who'd be doing the reversions with a flood of content".

Nov 6 2019, 7:01 PM · Product-Analytics, VisualEditor (Current work), OWC2020
DLynch added a comment to T236548: "visualeditor" Cloud VPS project jessie deprecation.

Will the prototype servers really require too much work to migrate? They're running mediawiki-vagrant, as I recall, so as long as it's in a currently viable state for installs we should be able to spin a new one up from scratch.

Nov 6 2019, 6:16 PM · VisualEditor, Cloud-VPS (Debian Jessie Deprecation)
DLynch added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

On the RESTBase side, the most numerous recorded cases were the ones where VE does not provide an If-Match header during transforms - there were 1122 such occurrences in the last 7 days, so I think we need to prioritise finding out how and why that happens.

Nov 6 2019, 4:33 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase

Nov 5 2019

DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

Thanks for looking into it! I'll just mention that, the schema can be changed to make the fields optional, which will then give you proper metrics showing how often this condition occurs.

Nov 5 2019, 10:20 PM · VisualEditor, Growth-Team, Editing-team
DLynch added a comment to T229074: Preparing VisualEditor for Parsoid-PHP switch.

That patch implements the strategy I described. Adding $wgVisualEditorRestbaseParsoidVariant = 'php'; to the config file triggers the appropriate header-sending.

Nov 5 2019, 4:48 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, Editing QA, Patch-For-Review, VisualEditor (Current work), Core Platform Team, Parsoid-PHP
DLynch added a comment to T229074: Preparing VisualEditor for Parsoid-PHP switch.

I'm thinking that we can't just push it everywhere, because that'd break any non-foundation user of VE who hasn't configured restbase to know about that variant. (E.g. my updated-yesterday vagrant install falls over and breaks as soon as I start sending that header.)

Nov 5 2019, 4:30 PM · MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), User-Ryasmeen, Editing QA, Patch-For-Review, VisualEditor (Current work), Core Platform Team, Parsoid-PHP

Nov 4 2019

DLynch added a comment to T237063: EventLogging validation errors for EditAttemptStep.

It's not just loaded_timing, there's also ready_timing.

Nov 4 2019, 5:47 PM · VisualEditor, Growth-Team, Editing-team

Oct 31 2019

DLynch added a comment to T236975: Vagrant eventbus role can't be installed because of node_version.

For now I went with making a puppet/hieradata/local.yaml file and including npm::node_version: 10 within it.

Oct 31 2019, 4:05 PM · MediaWiki-Vagrant
DLynch added a comment to T236975: Vagrant eventbus role can't be installed because of node_version.

This is probably a regression of T218238, which indicated that it was going to be making eventgate optional for cases which don't strictly require it.

Oct 31 2019, 3:57 AM · MediaWiki-Vagrant
DLynch created T236975: Vagrant eventbus role can't be installed because of node_version.
Oct 31 2019, 3:55 AM · MediaWiki-Vagrant

Oct 29 2019

DLynch added a comment to T234907: RFC: Where to implement Desktop Improvements project.

I want to second @Jdrewniak's point -- if we can refactor skins first so that skins really are a lighter presentation layer on top of a sensible base page structure, then whatever we choose for the rest of this doesn't matter so much. If we're not going to do that, there's a minefield ahead.

Oct 29 2019, 12:28 AM · Readers-Web-Backlog (Kanbanana-2019-20-Q2), Desktop Improvements, TechCom-RFC

Oct 15 2019

DLynch added a comment to T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

Sorry, just to be explicit:

When does the 'dialog-review' and 'dialog-preview' get fired ?

When you click the "review your changes" or "show preview" buttons that are at the bottom of the save dialog.

Oct 15 2019, 5:40 PM · Product-Analytics (Kanban), VisualEditor (Current work)
DLynch updated subscribers of T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

During testing I also found a bunch of other actions being stored under the mwSave feature. We can ignore them if required as the number of times these actions appear is very very small..but it would help to know if its a bug:
review-initial-schnark
checkbox-has
checkbox-intersects
checkbox-unique
checkbox-wpReviewEdit

Those are all probably interactions with other code. The logging we do just does logging based on the ids that are present in the code. If other extensions / gadgets / userscripts insert things, they'll get included in the logging. wpReviewEdit is from the FlaggedRevs extension, for instance.

Oct 15 2019, 5:38 PM · Product-Analytics (Kanban), VisualEditor (Current work)
DLynch added a comment to T233823: Mobile VE edit flow: instrumentation post-deployment data checks.

@DLynch - In QA, @Mayakp.wiki noticed the following mwSave feature actions were being recorded:

These are all from the last patch to that ticket, yes.

Oct 15 2019, 5:30 PM · Product-Analytics (Kanban), VisualEditor (Current work)

Oct 8 2019

DLynch added a comment to T206774: iOS Universal Links banner pushes toasts partially off-screen.

Safari 13 has added Visual Viewport support, which can plausibly help with this.

Oct 8 2019, 4:29 PM · Readers-Web-Backlog (Tracking), MinervaNeue, iOS-app-Bugs, Mobile

Oct 3 2019

DLynch added a comment to T232790: Verify editing flow events are firing properly.

That said, the "Yes, but it's getting fired twice" shouldn't be firing twice. But I can't reproduce that myself, so I might need more information.

Oct 3 2019, 5:38 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)
DLynch added a comment to T232790: Verify editing flow events are firing properly.

Everything Rummana saw looks correct, it's just a confusion about what the event name is. For the VisualEditorFeatureUse events it's two-part, there's a feature and action component, with the name being written here as [feature].[action].

Oct 3 2019, 5:30 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)
DLynch updated the task description for T232790: Verify editing flow events are firing properly.
Oct 3 2019, 5:25 PM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)

Sep 25 2019

DLynch added a comment to T232790: Verify editing flow events are firing properly.

It should all be mwSave as the feature and then the dialog-whatever as the action.

Sep 25 2019, 1:33 AM · MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work)

Sep 24 2019

DLynch added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

There must be some Etag manipulation going on on the client side (either in the PHP side of JS of the VE code) that alters it in some instances or removes it in other, given that we have evidence both cases mentioned in the description happen regularly (albeit with different frequencies).

Sep 24 2019, 3:21 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase

Sep 23 2019

DLynch added a comment to T233320: VisualEditor <-> RESTBase communication and ETags.

For what it's worth, I can't find anything in VE which ever alters an ETag. I.e. the weird suffix case should just be us passing whatever Restbase gave us when we loaded the article back to it.

Sep 23 2019, 4:41 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Patch-For-Review, VisualEditor (Current work), User-mobrovac, Core Platform Team Workboards (Clinic Duty Team), RESTBase

Sep 20 2019

DLynch moved T110413: Relative links to subpages are treated as links to the mainspace that start with / until after saving from Code review to QA on the VisualEditor (Current work) board.
Sep 20 2019, 3:21 PM · Verified, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), VisualEditor (Current work), VisualEditor-MediaWiki-Links

Sep 18 2019

DLynch moved T229079: Instrument each step of mobile VE edit flow from Code review to Product owner review on the VisualEditor (Current work) board.

T232790 is basically the QA process, after all.

Sep 18 2019, 4:02 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch updated subscribers of T233174: [Regression pre-wmf.24] Cannot add a gallery, and cannot make any edit afterwards.

This one was a pain to track, but it's a caught-and-swallowed exception inside TreeModifier. (Swallowed because it occurs in a jQuery promise, where exceptions are discarded.)

Sep 18 2019, 12:55 AM · User-Ryasmeen, VisualEditor-ContentEditable, Verified, VisualEditor (Current work)
DLynch updated subscribers of T233170: [Regression pre-wmf.24] Cannot open citation dialog, error in the console "Uncaught TypeError: Cannot read property 'type' of undefined".

Here's the stack trace:

Sep 18 2019, 12:39 AM · User-Ryasmeen, VisualEditor-MediaWiki-References, Verified, VisualEditor (Current work)

Sep 17 2019

DLynch added a comment to T232237: VE mobile default test buckets are unbalanced.

Buckets are all assigned server-side, yes -- I posted a link to where it's done above.

Sep 17 2019, 9:33 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 11 2019

DLynch added a comment to T232237: VE mobile default test buckets are unbalanced.

@ppelberg They're assigned to the buckets server-side. They then log their bucket as the assigned one, regardless of which editor loads.

Sep 11 2019, 7:51 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 10 2019

DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

Okay, current patches implement firstChange in: desktop VisualEditor, desktop WikiEditor, MobileFrontend wikitext and visual.

Sep 10 2019, 2:52 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

We should also write patches for those editors.

Sep 10 2019, 2:02 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

Okay! That cluster of patches implements the firstTransaction step on desktop and mobile. It logs it with the timing as "time since the document was ready".

Sep 10 2019, 12:39 AM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

I have updated the schema for now, with time-since-ready: https://meta.wikimedia.org/w/index.php?title=Schema:EditAttemptStep&diff=19364181&oldid=19273145

Sep 10 2019, 12:07 AM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

@MNeisler - Sorry, I didn't think to ask -- for the timing, would it be more helpful if I stored time-since-initialization or time-since-ready? That'd sort of be whether this event is conceptually grouped with the editor-loading cluster or the saving cluster.

Sep 10 2019, 12:04 AM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile

Sep 9 2019

DLynch added a comment to T231847: Add ⓧ buttons in the form input fields to make text deletion easier.

From the patch where we started discussing this:

Sep 9 2019, 6:00 PM · VisualEditor (Current work)
DLynch moved T229079: Instrument each step of mobile VE edit flow from Ready for Development to Code review on the VisualEditor (Current work) board.
Sep 9 2019, 3:53 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

When a contributors taps...

“<” in “Save your changes” dialogadded in patch: mwSave.dialog-abort
“<” in “Review your changes” viewadded in patch: mwSave.dialog-review
to "Preview"/"Review" their changesadded in patch: mwSave.dialog-review/preview
"Visual" or "Wikitext" in “Review your changes” viewadded in patch: mwSave.review-switch-source / mwSave.review-switch-visual
the "This is a minor edit" checkbox in the Save dialogadded in patch: mwSave.checkbox-wpMinoredit
the "Watch this page" checkbox in the Save dialogadded in patch: mwSave.checkbox-wpWatchthis
the “>” in v1 of the toolbaralready present in EditAttemptStep as saveIntent
Sep 9 2019, 3:53 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile
DLynch moved T232347: Mobile Visual Editor on iOS has a suppressed error after saving from In progress to Code review on the VisualEditor (Current work) board.
Sep 9 2019, 3:02 PM · Verified, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch added a project to T232347: Mobile Visual Editor on iOS has a suppressed error after saving: VisualEditor-MediaWiki-Mobile.
Sep 9 2019, 2:51 PM · Verified, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch created T232347: Mobile Visual Editor on iOS has a suppressed error after saving.
Sep 9 2019, 2:51 PM · Verified, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch added a comment to T229079: Instrument each step of mobile VE edit flow.

@Neil_P._Quinn_WMF / @MNeisler : Given that the "starts an edit" part requires a change to the EditAttemptStep schema, could you verify that all I'd need to do is add, say, "firstTransaction" to the action enum, and add a first_transaction_timing integer? No other extra data required?

Sep 9 2019, 2:30 PM · VisualEditor (Current work), Skipped QA, MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Product-Analytics, VisualEditor-MediaWiki-Mobile

Sep 7 2019

DLynch added a comment to T232237: VE mobile default test buckets are unbalanced.

For the code-side generation of this distribution, this is where it's defined: https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileFrontendEditorHooks.php#L48

Sep 7 2019, 8:33 PM · Product-Analytics (Kanban), MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Sep 3 2019

DLynch moved T229841: Instrument Edit Cards v3 from Code review to Product owner review on the VisualEditor (Current work) board.
Sep 3 2019, 3:53 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch claimed T229841: Instrument Edit Cards v3.
Sep 3 2019, 2:21 PM · MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Skipped QA, VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Aug 31 2019

DLynch claimed T228230: Add "✔️" into link modal.
Aug 31 2019, 12:02 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design
DLynch edited projects for T228230: Add "✔️" into link modal, added: VisualEditor (Current work); removed VisualEditor.
Aug 31 2019, 12:01 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design

Aug 30 2019

DLynch updated subscribers of T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown.

@Ryasmeen: for testing, the most likely side effect of this patch would be somehow breaking the ability to use the save shortcut again while the save dialog is open to trigger a save.

Aug 30 2019, 4:07 AM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch moved T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown from Code review to QA on the VisualEditor (Current work) board.
Aug 30 2019, 4:06 AM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T228230: Add "✔️" into link modal.

That patch is the most-limited version of this: it's just on mobile, and it's also just the mediawiki link inspector. If greater scope is desired, I can adjust this.

Aug 30 2019, 1:08 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design
DLynch added a comment to T228230: Add "✔️" into link modal.

Actually, more extensive question: should this be just the link modal, or should this be all inspectors? If we're invoking a consistent visual language, after all...

Aug 30 2019, 1:00 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design
DLynch added a comment to T228230: Add "✔️" into link modal.

On mobile:

Aug 30 2019, 12:59 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design
DLynch added a comment to T228230: Add "✔️" into link modal.

Is this a mobile-only change?

Aug 30 2019, 12:37 AM · I18n, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-Edit Cards , Editing Design

Aug 29 2019

DLynch added a project to T203151: Consider adding a button to let users edit the whole page in MobileFrontend: Design.
Aug 29 2019, 4:27 PM · Design, MobileFrontend, VisualEditor

Aug 27 2019

DLynch moved T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown from Incoming to Code review on the VisualEditor (Current work) board.
Aug 27 2019, 8:40 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch edited projects for T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown, added: VisualEditor (Current work); removed VisualEditor.
Aug 27 2019, 8:40 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch claimed T230816: Double tapping 'Publish' (soon to be '>') in the VE toolbar causes the page to publish immediately without the save dialog being shown.

After some research, it's a side-effect of a89c79dc7907fb32707c0fe535230cc04c38cae5 rather than being something tied to the save dialog actions -- intent is that if an accesskey hits the save-button while the save dialog is open, it triggers a save.

Aug 27 2019, 4:01 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Aug 22 2019

DLynch added a comment to T231031: Instrument usage of ISBN barcode scanner.

Educational DVDs can get them too! Though I admit I didn’t bother to look up whether there’s any distinguishing characteristic in the code.

Aug 22 2019, 6:01 PM · VisualEditor (Current work), Citoid
DLynch created T231031: Instrument usage of ISBN barcode scanner.
Aug 22 2019, 5:14 PM · VisualEditor (Current work), Citoid

Aug 21 2019

DLynch claimed T227317: Oversample mobile wikitext EditAttemptStep events on default editor A/B test wikis.
Aug 21 2019, 5:18 PM · User-Ryasmeen, VisualEditor (Current work)

Aug 20 2019

DLynch moved T229744: HTML entities in section headings show on a separate line in mobile visual editor from Code review to QA on the VisualEditor (Current work) board.
Aug 20 2019, 9:42 PM · Verified, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch added a comment to T230807: v1 toolbar shows disabled edit tools on first load, then never again.

That screenshot does also remind me that we should, perhaps, hide the toolbar while that modal is displayed? Having non-disabled tools while the modal is present would be weird as well, after all.

Aug 20 2019, 3:47 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch added a comment to T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE.

@Ryasmeen This one needs to wait for testing until OOJS-UI gets updated, sorry.

Aug 20 2019, 3:02 PM · User-Ryasmeen, Verified, OOUI, VisualEditor (Current work)

Aug 14 2019

DLynch added a comment to T228794: Investigate technical needs for native mobile diffs, including supporting APIs.

“if the visual diffs feature is self contained enough that it could be API-ified or bundled in the App as a JS library to run on a webview (or maybe as an API like page/mobile-html)”

Aug 14 2019, 11:00 PM · iOS-app-v6.5-Squid-On-A-Tandem-Bike, Spike, Wikipedia-iOS-App-Backlog
DLynch moved T230058: Change back action icon in toolbar to "<" from "x" from Incoming to Code review on the VisualEditor (Current work) board.
Aug 14 2019, 4:52 PM · Verified, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch added a comment to T229832: Conduct Edit Cards v3 usertesting.com test.

Following up on my earlier suggestion to document things...

Aug 14 2019, 3:39 PM · VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Aug 13 2019

DLynch added a comment to T211787: Design a Test for prototype.

Notes on the script: testers missed that they should highlight UNLINKED words at first, so that should be specified.

Aug 13 2019, 5:00 PM · VisualEditor
DLynch added a comment to T228753: New mobile context ("edit cards") do not support multiple context items very well.

Some quick experimentation suggests that the edit card can't scroll, if it manages to expand past the screen height. Worse, in that case, the top of the card containing the close button is stuck off the top of the screen, leaving the user in an unrecoverable state.

Aug 13 2019, 4:38 PM · VisualEditor-MediaWiki-Mobile, VisualEditor, VisualEditor-Edit Cards
DLynch moved T229744: HTML entities in section headings show on a separate line in mobile visual editor from Incoming to Code review on the VisualEditor (Current work) board.
Aug 13 2019, 4:33 PM · Verified, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T229744: HTML entities in section headings show on a separate line in mobile visual editor.
Aug 13 2019, 4:33 PM · Verified, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor (Current work), VisualEditor-MediaWiki

Aug 10 2019

DLynch moved T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE from In progress to Code review on the VisualEditor (Current work) board.
Aug 10 2019, 2:31 AM · User-Ryasmeen, Verified, OOUI, VisualEditor (Current work)

Aug 9 2019

DLynch moved T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE from Incoming to In progress on the VisualEditor (Current work) board.

Quirk seems to be with this CSS rule from OOUI

.oo-ui-popupWidget {
    filter: drop-shadow(0 2px 1px rgba(0,0,0,0.3));
}
Aug 9 2019, 6:58 PM · User-Ryasmeen, Verified, OOUI, VisualEditor (Current work)
DLynch added a comment to T226872: [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE.

I can reproduce this, though it's a little inconsistent about when it happens. In my reproduction it's not required that I select another thing that triggers a context item -- many context items will leave their shadows behind to some extent. See:

Aug 9 2019, 6:51 PM · User-Ryasmeen, Verified, OOUI, VisualEditor (Current work)

Aug 8 2019

DLynch added a comment to T230133: Some EditAttemptStep events on existing pages do not have revision IDs.

So, null revision_id means that mw.config.get( 'wgRevisionId' ) didn't return anything. This implies bigger issues with the current session...

Aug 8 2019, 4:37 PM · Product-Analytics, VisualEditor
DLynch added a comment to T229832: Conduct Edit Cards v3 usertesting.com test.

add ⓧ buttons in the form input fields to make text deletion easier

We could switch these to an OOJS-UI SearchInputWidget, probably. Easier for external than internal, because internal uses mw.widgets.TitleSearchWidget and we might need to make sure there wouldn't be any side-effects there.

Aug 8 2019, 4:03 PM · VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch renamed T230058: Change back action icon in toolbar to "<" from "x" from Change back action icon in toolbar to ">" from "x" to Change back action icon in toolbar to "<" from "x".
Aug 8 2019, 1:54 AM · Verified, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)

Aug 6 2019

DLynch added a comment to T221197: VE mobile default: A/B test post-deployment data checks.

This is quite different from what I found in the VisualEditor on mobile report; the ready rate for the mobile visual there was about 95%. The difference may be that the old number was based on a self-selected group of VE users, while this new number is based on a more representative group. Alternatively, it could be the result of a regression during the past year.

Aug 6 2019, 4:38 PM · MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-Ryasmeen, Product-Analytics, VisualEditor (Current work)

Aug 5 2019

DLynch added a comment to T225634: Design "refreshed toolbar" v1.0.

We also said when moving to native affordances for dismissing the keyboard that the Android one is really bad and that we would consider augmenting it with out own button floating above the keyboard.

Aug 5 2019, 4:59 PM · Editing Design, VisualEditor-MediaWiki-Mobile, VisualEditor (Current work)
DLynch moved T229579: Use simplified mobilefrontend copyright messages on mobile VE from Code review to QA on the VisualEditor (Current work) board.
Aug 5 2019, 3:46 PM · MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Aug 2 2019

DLynch edited projects for T211789: Develop a working toolbar prototype v1, added: VisualEditor (Current work); removed VisualEditor.
Aug 2 2019, 8:15 AM · VisualEditor (Current work), Patch-For-Review

Jul 31 2019

DLynch added a comment to T227933: Context items: verify logging events are firing properly.
  1. The window-open events listed in the "Opening of windows" section of this task's description are not blocking Edit Cards v2 release. This is b/c answering the measurement questions we have listed in the description of T221252 depends on us being able to track the opening of context items, not windows.

That is my understanding of Neil's position. (I.e. the missing ones are generally off the toolbar buttons, rather that directly from the contexts of existing nodes.)

Jul 31 2019, 5:30 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Jul 30 2019

DLynch committed rECEXc9209ef36a9e: On manual template selection give the close a descriptive action (authored by DLynch).
On manual template selection give the close a descriptive action
Jul 30 2019, 4:07 PM

Jul 29 2019

DLynch added a comment to T229255: 'window-open-from-command' event is not getting fired while clicking on Add new citation>Manual>Book/Website etc..

This wound up already being fixed in a patch attached to that task.

Jul 29 2019, 7:06 PM · VisualEditor
DLynch merged T229255: 'window-open-from-command' event is not getting fired while clicking on Add new citation>Manual>Book/Website etc. into T221305: Instrument revised *citation* edit workflows.
Jul 29 2019, 7:05 PM · User-Ryasmeen, Skipped QA, MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), VisualEditor-Edit Cards , VisualEditor (Current work)
DLynch merged task T229255: 'window-open-from-command' event is not getting fired while clicking on Add new citation>Manual>Book/Website etc. into T221305: Instrument revised *citation* edit workflows.
Jul 29 2019, 7:05 PM · VisualEditor

Jul 25 2019

DLynch created T229028: Requesting production shell access for DLynch.
Jul 25 2019, 5:17 PM · Operations, SRE-Access-Requests
DLynch added a comment to T227200: Requesting access to analytics-privatedata-users for DLynch.

So, as far as I know, we're currently talking on a ticket which was created through all the "new users" steps stated on the request-shell-access document, and as far as I knew what I was doing here was requesting new production shell access with access to the analytics-privatedata-users group. Did I need to instead make two separate tickets for this? If so, it's not very clear in the documentation.

Jul 25 2019, 4:16 PM · VisualEditor (Current work), Operations, SRE-Access-Requests
DLynch added a comment to T227200: Requesting access to analytics-privatedata-users for DLynch.

I'm interested mainly in analytics data logged in relation to Editing products (the EditAttemptStep and VisualEditorFeatureUse schemas).

Jul 25 2019, 4:03 PM · VisualEditor (Current work), Operations, SRE-Access-Requests

Jul 24 2019

DLynch added a comment to T227933: Context items: verify logging events are firing properly.

I updated the link in the description to include useful URL parameters, and to link to a non-protected page. 👍🏻

Jul 24 2019, 7:36 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch updated the task description for T227933: Context items: verify logging events are firing properly.
Jul 24 2019, 7:36 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch updated the task description for T227933: Context items: verify logging events are firing properly.
Jul 24 2019, 5:33 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch moved T227933: Context items: verify logging events are firing properly from Incoming to QA on the VisualEditor (Current work) board.
Jul 24 2019, 5:16 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile
DLynch edited projects for T227933: Context items: verify logging events are firing properly, added: VisualEditor (Current work); removed VisualEditor.

For event-monitoring, the instructions there are only really helpful in 100% oversampling situations. Otherwise you have to keep reloading the page until you manage to wind up in the sample, which is an incredibly annoying testing requirement. (Or do all your testing on one of the wikis which has oversampling turned on -- which only applies to mobile.)

Jul 24 2019, 5:16 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Jul 22 2019

DLynch committed rECITba9b0c280b80: Tracking for change events in citation-templates (authored by DLynch).
Tracking for change events in citation-templates
Jul 22 2019, 9:34 PM

Jul 18 2019

DLynch added a comment to T227933: Context items: verify logging events are firing properly.

I believe that document is up to date.

Jul 18 2019, 4:13 PM · User-Ryasmeen, Verified, MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), VisualEditor (Current work), VisualEditor-MediaWiki-Mobile

Jul 16 2019

DLynch moved T221249: Instrument revised *link* edit workflows from Engineering QA to Product owner review on the VisualEditor (Current work) board.
Jul 16 2019, 5:12 PM · VisualEditor-Edit Cards , MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), VisualEditor (Current work)