Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (21)

Today

  • No visible events.

Tomorrow

  • No visible events.

Tuesday

  • No visible events.

User Details

User Since
Oct 1 2015, 7:50 PM (558 w, 2 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Fri, Jun 12

DLynch created T429052: Add ability to query a specific URL for reference reliability.
Fri, Jun 12, 8:59 PM · ml-model-requests, Editing-team, EditCheck, VisualEditor Suggestion Mode
DLynch moved T428641: Build PoC for integrating initial set of MoS LLM-generated suggestions into Suggestion Mode as `experimental` from Ready for Dev to Code review on the Editing-team (Editing-current-Q4-8Jun-19Jun-2026) board.
Fri, Jun 12, 8:34 PM · Patch-For-Review, Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Machine-Learning-Team, VisualEditor Suggestion Mode
DLynch moved T428798: Ensure paste check is shown on-screen for larger pastes from Decision to be made to Code review on the Editing-team (Editing-current-Q4-8Jun-19Jun-2026) board.
Fri, Jun 12, 6:52 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), VisualEditor, Patch-For-Review, EditCheck
DLynch added projects to T428798: Ensure paste check is shown on-screen for larger pastes: VisualEditor, Editing-team (Editing-current-Q4-8Jun-19Jun-2026).
Fri, Jun 12, 6:52 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), VisualEditor, Patch-For-Review, EditCheck
DLynch added a comment to T428798: Ensure paste check is shown on-screen for larger pastes.

CleanShot 2026-06-12 at 13.35.23.gif (458×800 px, 3 MB)

Fri, Jun 12, 6:47 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), VisualEditor, Patch-For-Review, EditCheck

Thu, Jun 11

DLynch added a comment to T428843: Suggest people upload photos on articles where images have been requested.

Would we want to scope this to only show on desktop? Commons has some historical issues with cross-wiki uploads, particularly from mobile devices.

Thu, Jun 11, 4:57 PM · VisualEditor Suggestion Mode
DLynch added a comment to T428798: Ensure paste check is shown on-screen for larger pastes.

I think we might have a ticket somewhere (but cannot find it) about making it so that the check icon in the mobile gutter is kept on-screen. That would address this issue, in a non-paste-specific way.

Thu, Jun 11, 4:55 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), VisualEditor, Patch-For-Review, EditCheck
DLynch added a comment to T428776: Consider the reference popup as an entry point to a reference verification check.

This specifically means the read-mode popup, not the context item inside VE, right?

Thu, Jun 11, 4:53 PM · EditCheck
DLynch added a comment to T428760: Edit Suggestions data model.

I could see it having many suggestions

Thu, Jun 11, 3:05 PM · OKR-Work, Editing-team, VisualEditor, EditCheck

Wed, Jun 10

DLynch added a subtask for T428641: Build PoC for integrating initial set of MoS LLM-generated suggestions into Suggestion Mode as `experimental`: T428740: LLM Generated Editing Suggestions - API changes..
Wed, Jun 10, 4:29 PM · Patch-For-Review, Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Machine-Learning-Team, VisualEditor Suggestion Mode
DLynch added a parent task for T428740: LLM Generated Editing Suggestions - API changes.: T428641: Build PoC for integrating initial set of MoS LLM-generated suggestions into Suggestion Mode as `experimental`.
Wed, Jun 10, 4:28 PM · Machine-Learning-Team (Q4 FY2025-26)
DLynch added a comment to T428744: Reply links should be displayed based on whether a page is editable.

Technically, and I know this is a weird edge case, you could have a replyable comment on a page you're not allowed to edit. Because replies work across transclusions, you could have a read-only page that does {{Wikipedia:ProjectFrontPage/Comments}}, and so long as Wikipedia:ProjectFrontPage/Comments is editable it'd pass the replies through.

Wed, Jun 10, 3:24 PM · DiscussionTools
DLynch added a comment to T428559: [Suggestion] Check if image caption ends with ".".

One approach would be to use the likely outcome of T422431, which intends to add the ability to scope a check to only apply within a given node type. In this case it'd be fairly easy to make a textmatch check that checks for \.$ only within mwCaption nodes.

Wed, Jun 10, 3:13 PM · VisualEditor Suggestion Mode, EditCheck, VisualEditor
DLynch added a comment to T428740: LLM Generated Editing Suggestions - API changes..

MOS:GEO is an example of something where we should almost-certainly include a link. You'll be able to write wikitext in the descriptions and have it work, though it's admittedly incredibly enwiki-specific as a result.

Wed, Jun 10, 3:01 PM · Machine-Learning-Team (Q4 FY2025-26)

Tue, Jun 9

DLynch added a comment to T418197: Add "copy link" to DiscussionTools overflow menu.

Context: this is the same toast that's triggered by clicking the timestamp, so this was a long-ago behavioral decision. It could be revisited if we want.

Tue, Jun 9, 5:36 PM · Verified, Editing-team (Editing-current-Q4-8Jun-19Jun-2026), MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), DiscussionTools
DLynch moved T425877: Category edit link lacks href and is inaccessible to keyboard from Code review to QA on the Editing-team (Editing-current-Q4-8Jun-19Jun-2026) board.

It's init-related, so getting a third person to take a look makes sense.

Tue, Jun 9, 3:13 PM · MW-1.47-notes (1.47.0-wmf.7; 2026-06-16), Editing QA, Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Essential-Work, VisualEditor, MediaWiki-User-Interface, Accessibility

Mon, Jun 8

DLynch added a comment to T428492: Define actions that can be taken by model-generated suggestions.

We might need to consider a tiered set of actions -- top-level being the current "here is a description of what the model thinks is wrong", and then becoming more specific like "take action X", then "take action Y automatically". So we'd always be able to offer something, and wouldn't have it be potentially-weird if the model-generated text was suggestion you take an action we don't offer on that wiki.

Mon, Jun 8, 6:18 PM · Machine-Learning-Team, Editing-team, VisualEditor Suggestion Mode
DLynch created T428492: Define actions that can be taken by model-generated suggestions.
Mon, Jun 8, 6:14 PM · Machine-Learning-Team, Editing-team, VisualEditor Suggestion Mode
DLynch added a comment to T424684: [SPIKE] Investigate the remaining causes of the SLO being in the red.

Looks pretty good now. We've had literally no budget consumed in the last 7 days on the dashboard.

Mon, Jun 8, 6:00 PM · MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Editing-team (Editing-Q4-27Apr-8May-2026), OKR-Work, Goal, EditCheck
DLynch created T428490: Set up constructive edits maintenance script.
Mon, Jun 8, 5:52 PM · Patch-For-Review, Editing-team, Product-Analytics, VisualEditor Suggestion Mode, VisualEditor
DLynch added a comment to T422730: Develop an API that enables Edit Checks/Suggestions to be kept in sync with Growth Experiments.

Testing note: https://en.wikipedia.org/w/index.php?search=hasrecommendation%3Alink&title=Special%3ASearch&profile=advanced&fulltext=1&ns0=1 will show you pages with link suggestion data available. That's pre-filtering by the threshold though, so they won't all actually show a suggestion if you edit them.

Mon, Jun 8, 5:31 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), MW-1.46-notes (1.46.0-wmf.24; 2026-04-14), Patch-For-Review, Growth-Team, OKR-Work, VisualEditor Suggestion Mode, Add-Link-Structured-Task

Thu, Jun 4

DLynch moved T416247: Request for investigating performance issues in long talkpages from Decision to be made to Code review on the Editing-team (Editing-current-Q4-8Jun-19Jun-2026) board.
Thu, Jun 4, 2:36 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Patch-For-Review, Content-Transform-Team, Accessibility, DiscussionTools
DLynch claimed T416247: Request for investigating performance issues in long talkpages.
Thu, Jun 4, 2:36 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Patch-For-Review, Content-Transform-Team, Accessibility, DiscussionTools
DLynch added a comment to T427728: VisualEditor should break <editcheck-dialog-scroll-into-view> message in multiple lines when it's too long.

The Tooltip could be shown on hover or focus on the Button on desktop, while being shown by long pressing on touchable screens.

I doubt anyone is going to think to try that, so I'm skeptical that it's worth the implementation-effort of a whole new interaction that we don't currently support. (Plus, it'd be overriding an actual expected system-level browser interaction that people might expect -- it's how you trigger the context menu.)

Thu, Jun 4, 2:34 PM · VisualEditor Suggestion Mode, EditCheck, VisualEditor

Tue, Jun 2

DLynch added a comment to T426133: Create messages needed to translate "Exit the editor" survey and complete translation for Phase 2 languages.

You can also look directly on translatewiki -- go to https://translatewiki.net/wiki/Special:Translate?group=ext-mobilefrontend&language=ru&filter=&action=translate and enter "abandon-survey" in the search box at the top of the list.

Tue, Jun 2, 7:22 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Epic, OKR-Work, Design, Research, Design-Research, VisualEditor Suggestion Mode
DLynch added a comment to T426133: Create messages needed to translate "Exit the editor" survey and complete translation for Phase 2 languages.

@Wellverywell you can see all the strings in the green lines in this file in the patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/1291108/3/i18n/en.json

Tue, Jun 2, 7:17 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Epic, OKR-Work, Design, Research, Design-Research, VisualEditor Suggestion Mode
DLynch added a comment to T427728: VisualEditor should break <editcheck-dialog-scroll-into-view> message in multiple lines when it's too long.

Bear in mind that the ⓘ approach wouldn't be particularly viable on mobile, where this button also appears.

Tue, Jun 2, 1:04 AM · VisualEditor Suggestion Mode, EditCheck, VisualEditor
DLynch moved T426133: Create messages needed to translate "Exit the editor" survey and complete translation for Phase 2 languages from Code review to Blocked on the Editing-team (Editing-Q4-11May-22May-2026) board.
Tue, Jun 2, 12:04 AM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Epic, OKR-Work, Design, Research, Design-Research, VisualEditor Suggestion Mode
DLynch added a comment to T426133: Create messages needed to translate "Exit the editor" survey and complete translation for Phase 2 languages.

Thus far translatewiki has localized it into: az, de, fi, gl, ia, ko, lb, ms, so.

Tue, Jun 2, 12:03 AM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Epic, OKR-Work, Design, Research, Design-Research, VisualEditor Suggestion Mode
DLynch added a comment to T427594: Ctrl+Shift+Space inserts links in VisualEditor.

Depends a little on which wiki you edit on. It'll be on the deployment train, so at latest you should see the fix on Thursday.

Tue, Jun 2, 12:01 AM · VisualEditor, VisualEditor-ContentEditable

Mon, Jun 1

DLynch added a comment to T424684: [SPIKE] Investigate the remaining causes of the SLO being in the red.

I think this has helped. Following those patches going out on the train (finished on the 21st) we haven't yet seen any spikes like there were before.

Mon, Jun 1, 4:30 PM · MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Editing-team (Editing-Q4-27Apr-8May-2026), OKR-Work, Goal, EditCheck
DLynch added a comment to T420865: Fetches from Gerrit aborted due to: GnuTLS recv error (-54): Error in the pull function.

Oh wait, that was the same patch appearing twice as "uploaded" for some reason, not getting merged. So, ignore that "despite the patch" comment.

Mon, Jun 1, 3:19 PM · Patch-For-Review, User-brennen, collaboration-services, Gerrit, ci-test-error (WMF-deployed Build Failure), Release-Engineering-Team, Continuous-Integration-Infrastructure
DLynch added a comment to T420865: Fetches from Gerrit aborted due to: GnuTLS recv error (-54): Error in the pull function.

Definitely still happening despite the above patch, e.g. https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-selenium-php83/36425/console this morning.

Mon, Jun 1, 3:18 PM · Patch-For-Review, User-brennen, collaboration-services, Gerrit, ci-test-error (WMF-deployed Build Failure), Release-Engineering-Team, Continuous-Integration-Infrastructure
DLynch added a comment to T407664: Support regex queries in TextMatchEditCheck.

Also, seems like e.g. regexp \. matches the result of <code>.html</code> even if ignoreQuotedContent is set to true.

Mon, Jun 1, 1:32 PM · Patch-For-Review, MW-1.47-notes (1.47.0-wmf.2; 2026-05-12), Editing-team (Editing-Q4-27Apr-8May-2026), VisualEditor Suggestion Mode, EditCheck, VisualEditor

Sun, May 31

DLynch added a comment to T427743: Selections and gutter marks flicker onDocumentChange.

I'm fairly sure we used to wait to clear out the highlights until the processing phase was completed, so this is likely to be a regression from some of our recent refactors.

Sun, May 31, 4:09 PM · MW-1.47-notes (1.47.0-wmf.7; 2026-06-16), Regression, Editing-team, VisualEditor Suggestion Mode, EditCheck, VisualEditor
DLynch created T427743: Selections and gutter marks flicker onDocumentChange.
Sun, May 31, 4:08 PM · MW-1.47-notes (1.47.0-wmf.7; 2026-06-16), Regression, Editing-team, VisualEditor Suggestion Mode, EditCheck, VisualEditor
DLynch updated subscribers of T427728: VisualEditor should break <editcheck-dialog-scroll-into-view> message in multiple lines when it's too long.

@bmartinezcalvo How do you think this button should adjust to being multi-line? (I can see at least two ways it could scale, depending on whether the sides remain semi-circles or not...)

Sun, May 31, 2:11 PM · VisualEditor Suggestion Mode, EditCheck, VisualEditor

Fri, May 29

DLynch added a comment to T427626: Provide read access to template-generated categories in VE document model.

Here's an example of a template that adds a hidden category:

<link rel="mw:PageProp/Category" href="./Category:All_articles_with_unsourced_statements" about="#mwt5" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"Citation needed","href":"./Template:Citation_needed"},"params":{"date":{"wt":"January 2026"},"reason":{"wt":"There is conflicting information about when this album was released, as sources such as Amazon list the release date as 2001 instead of 2000. If one has a reliable source per WP:RSPS that says 2000, please cite it."}},"i":0}}]}' id="mwDQ"/><link rel="mw:PageProp/Category" href="./Category:Articles_with_unsourced_statements_from_January_2026" about="#mwt5"/><sup class="noprint Inline-Template Template-Fact" style="white-space:nowrap;" about="#mwt5" id="mwDg"><span typeof="mw:Entity">[</span><i><a rel="mw:WikiLink" href="./Wikipedia:Citation_needed" title="Wikipedia:Citation needed"><span title="There is conflicting information about when this album was released, as sources such as Amazon list the release date as 2001 instead of 2000. If one has a reliable source per WP:RSPS that says 2000, please cite it. (January 2026)">citation needed</span></a></i><span typeof="mw:Entity">]</span></sup>
Fri, May 29, 4:28 PM · VisualEditor, EditCheck
DLynch added a comment to T427520: Provide access to add a reference from the Citation Needed template in more languages.

One thing we could do is improve the documentation for this. I'm fairly sure this isn't highlighted anywhere as something a community might want to do.

Fri, May 29, 6:58 AM · VisualEditor
DLynch added a comment to T427594: Ctrl+Shift+Space inserts links in VisualEditor.

I cannot reproduce this on a mac (where it's option-shift-space):

CleanShot 2026-05-29 at 08.37.02@2x.png (866×588 px, 133 KB)

Fri, May 29, 6:38 AM · VisualEditor, VisualEditor-ContentEditable
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

One more reproduction note: I cannot reproduce this when I have JS disabled.

Fri, May 29, 6:04 AM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari

Thu, May 28

DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Might be worth leaving the MinervaNeue tag on, just because it's significantly easier to trigger there, so there may be some relation.

Thu, May 28, 9:30 PM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

@gh87 https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(WMF)?useformat=desktop&useparsoid=1&useskin=vector2022#Survey should get you that. It could be somewhat device-dependent, since the apparent error is RAM-exhaustion -- I'm testing it on an iPhone 17 pro, meaning there's 12GB of RAM.

Thu, May 28, 8:00 PM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.
Thu, May 28, 5:11 PM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari
DLynch added a comment to T322218: Create API to allow retrieving detailed information about Thanks log items for my own user account.

Note that this does expose something currently sort-of private, which is exactly what content was thanked. The user was told this when the notification of the thanks arrived, but if they cleared that notification then it was no longer available to them.

Thu, May 28, 1:17 PM · Connection-Team, Privacy Engineering, Thanks
DLynch closed T427458: ext.testKitchen not loaded by ext.wikimediaEvents module causing errors as Resolved.
Thu, May 28, 12:33 PM · Test Kitchen (Experiment Platform Sprint 24), MediaWiki-extensions-WikimediaEvents
DLynch added a comment to T427102: Moving [[WP:VPWMF#WMF Community Tech team has been disbanded, engineers laid off]] to subpage(s).

Follow-up: I have done some DiscussionTools performance work on the above-mentioned ticket.

Thu, May 28, 12:25 PM · Performance Issue, DiscussionTools
DLynch added a comment to T416247: Request for investigating performance issues in long talkpages.

^ those patches take a local clone I made of the currently very-busy Village_Pump_(WMF), and reduce the time-cost of these areas of DiscussionTools during the initial page load from 176ms to 25ms. (On my high-spec macbook, so we can expect that to be more significant for many users.)

Thu, May 28, 12:25 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Patch-For-Review, Content-Transform-Team, Accessibility, DiscussionTools
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Did you try useformat=mobile&useskin=monobook ? That would help eliminate whether Minerva has anything to do with this.

Thu, May 28, 5:43 AM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari

Wed, May 27

DLynch added a comment to T425983: Allow setting user account limits for checks in suggestion mode.

As a variant of 1/2, we could make the existing showAsCheck and showAsSuggestion keys accept a config-object as well as just a boolean. We've already got precedent of doing nested config checks via textmatch rules, so a similar system could be used here. Check the top-level config, and then check whichever of the sub-configs are provided.

Wed, May 27, 8:58 AM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Patch-For-Review, VisualEditor Suggestion Mode, OKR-Work, EditCheck
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Connecting a cable didn't help as much as I had hoped. The main thing learned was that this isn't the page actually being stuck in a reload loop via navigation, but rather the rendering is crashing and restarting. I was also able to place breakpoints in Toggler.js which weren't reached (or at least, the process crashed regardless and things moved on -- hard to tell the difference).

Wed, May 27, 6:53 AM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari

Tue, May 26

DLynch closed T427253: "Add topic" button mobile overlapping categories again as Resolved.

I tested this on iOS.

Tue, May 26, 9:48 AM · Skipped QA, Editing-team (Editing-Q4-11May-22May-2026), Regression, DiscussionTools
DLynch moved T427253: "Add topic" button mobile overlapping categories again from Decision to be made to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
Tue, May 26, 9:37 AM · Skipped QA, Editing-team (Editing-Q4-11May-22May-2026), Regression, DiscussionTools
DLynch assigned T427253: "Add topic" button mobile overlapping categories again to Esanders.
Tue, May 26, 9:37 AM · Skipped QA, Editing-team (Editing-Q4-11May-22May-2026), Regression, DiscussionTools
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Some debugging:

Tue, May 26, 9:00 AM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

I'd have to assume it's something about the highlighting / auto-expansion code that's clashing, presumably in ways that're more noticeable on larger (and thus slower-to-load) pages.

Tue, May 26, 6:58 AM · Parsoid (Tracking), Editing-team, Reader Experience Team, JavaScript, MinervaNeue, Browser-Support-Apple-Safari

Sat, May 23

DLynch assigned T427066: Media dialog in VisualEditor uses invalid imageinfo API parameter to Jdlrobson.

Is this causing enough of a problem that we should backport the API fix on monday?

Sat, May 23, 2:41 AM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), VisualEditor, Editing-team, VisualEditor-Media
DLynch added a comment to T427102: Moving [[WP:VPWMF#WMF Community Tech team has been disbanded, engineers laid off]] to subpage(s).

First, @matmarex is completely right. DiscussionTools should preserve all the subscriptions when you move signed comments between pages, so long as you avoid altering signature timestamps. If you then transclude the discussion onto the original page, DiscussionTools should also be able to automatically reply on the correct page for people viewing the main village_pump page. (There are ways it can get confused with more complicated arrangements, but an entire thread being transcluded should Just Work.)

Sat, May 23, 1:06 AM · Performance Issue, DiscussionTools

Fri, May 22

DLynch added a comment to T427093: TypeError: can't access property "parentNode", startMarker is null /.

Theoretically, DiscussionTools is supposed to not be activating when the ConvenientDiscussions gadget is enabled, which we'd hope would stop this. (See: DiscussionTools HookUtils.php featureConflictsWithGadget.)

Fri, May 22, 9:39 PM · JavaScript, Revision-Slider, DiscussionTools, Wikimedia-production-error
DLynch added a comment to T427066: Media dialog in VisualEditor uses invalid imageinfo API parameter.

^ that fixes the imageSizes access, which was definitely wrong, and will stop these errors from occurring. Should probably also work out what's going on with thumblimits though.

Fri, May 22, 7:33 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), VisualEditor, Editing-team, VisualEditor-Media
DLynch added a comment to T427066: Media dialog in VisualEditor uses invalid imageinfo API parameter.

I could absolutely patch the widget, but I'm not sure whether or not "siteinfo returned an object for this value" should be considered the new ongoing behavior or just a bug.

Fri, May 22, 7:27 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), VisualEditor, Editing-team, VisualEditor-Media
DLynch added a comment to T426328: [1.48] 3rd parties must update ThumbLimits config.

In a similar vein, this seems to have caused T427066 because the way this value now gets serialized into the siteinfo API has changed (it was formerly an array, and is now an object).

Fri, May 22, 7:26 PM · Patch-For-Review, Content-Transform-Team, MediaWiki-Core-Skin-Architecture, MediaWiki-Core-Preferences
DLynch updated subscribers of T427066: Media dialog in VisualEditor uses invalid imageinfo API parameter.

On quick examination, it's not anything inside the VisualEditor extension, this is a request made by mw.widgets.MediaSearchWidget in core. When the VE media dialog opens, it makes one of those search widgets and requests that it fetch the user-upload queue (via this.search.queryMediaQueue()), and that results in this request with malformed parameters.

Fri, May 22, 7:25 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), VisualEditor, Editing-team, VisualEditor-Media
DLynch added a comment to T426770: EditCheck + Suggestions: Update footer styles.

With that patch:

Fri, May 22, 3:21 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch moved T426133: Create messages needed to translate "Exit the editor" survey and complete translation for Phase 2 languages from Dev Doing to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
Fri, May 22, 3:46 AM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Epic, OKR-Work, Design, Research, Design-Research, VisualEditor Suggestion Mode

Thu, May 21

DLynch added a comment to T427015: 2017 wikitext editor adds an extra newline when using textSelection( 'setContents', ... ).

Issue appears to be that this is what setContents does:

Thu, May 21, 10:09 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
DLynch created T427015: 2017 wikitext editor adds an extra newline when using textSelection( 'setContents', ... ).
Thu, May 21, 9:56 PM · VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor
DLynch created P92813 (An Untitled Masterwork).
Thu, May 21, 9:37 PM
DLynch claimed T426133: Create messages needed to translate "Exit the editor" survey and complete translation for Phase 2 languages.
Thu, May 21, 5:20 PM · MW-1.47-notes (1.47.0-wmf.6; 2026-06-09), Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Epic, OKR-Work, Design, Research, Design-Research, VisualEditor Suggestion Mode
DLynch added a comment to T426770: EditCheck + Suggestions: Update footer styles.

In this context, the font-size on that element is set to use @font-size-small, which correctly evaluates to 0.875rem (per codex), which in this document becomes 14px. I cannot say exactly why that isn't the 12px you specify, but that isn't the token-meaning so it does make sense.

Thu, May 21, 4:02 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch added a comment to T426770: EditCheck + Suggestions: Update footer styles.

Ah, the joys of the token life. Fixing this one might involve either ignoring the token or doing a bunch of digging into the CSS stack.

Thu, May 21, 3:49 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch added a comment to T426770: EditCheck + Suggestions: Update footer styles.

Icon spacing issue was that icon-size-small reacts to the vector appearance menu's content-size setting, and the rest of this widget does not. Spacing was fine when that was set to small (which is where I leave it locally), but at standard/large it looked off. I changed the token used to get an equivalent size across all settings.

Thu, May 21, 1:17 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch added a comment to T426770: EditCheck + Suggestions: Update footer styles.

Footer text size should be font-size-small (12px on Vector22, 14px on Minerva)

Thu, May 21, 1:04 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch added a comment to T382101: Focus shifts from search box to editor box when typing during Visual Editor's loading phase.

ve.init.mw.DesktopArticleTarget.prototype.afterActivate focuses the surface once it's done loading. On a page without editnotices, we could pretty easily check whether document.activeElement exists and is the sort of thing that can contain typing-focus, and not focus the surface if that's the case.

Thu, May 21, 1:50 AM · Vector 2022 (Tracking), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Wed, May 20

DLynch closed T426771: Suggestions: align "More options" button with the rest of buttons as Resolved.

Verified on beta @ https://en.wikipedia.beta.wmcloud.org/wiki/Cats?veaction=edit&ecenable=suggestions,experimental

Wed, May 20, 11:27 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, Design
DLynch added a comment to T380721: Allow wikis to overwrite default output of "References list".

In general, we'd really prefer that {{reflist}}-style templates not be used, because they make it extremely difficult for us to ever support list-defined references. See the venerable T52896, and more recently the bug that meant T356471 had to get reverted.

Wed, May 20, 10:51 PM · Cite, VisualEditor, VisualEditor-MediaWiki-References
DLynch closed T426770: EditCheck + Suggestions: Update footer styles as Resolved.

Checked on https://en.wikipedia.beta.wmcloud.org/wiki/Cats?veaction=edit&ecenable=suggestions,experimental where there's a tone issue that thus had a footer:

CleanShot 2026-05-20 at 17.01.06@2x.png (652×652 px, 55 KB)

Wed, May 20, 10:01 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch added a comment to T399175: [EPIC] Refine Codex icon library.

At this point, we need to get this initial refinement released.

Wed, May 20, 8:06 PM · Editing-team (Editing-Q4-11May-22May-2026), User-notice, Epic, Codex
DLynch added a comment to T399175: [EPIC] Refine Codex icon library.

To be fair on the robot one, the "head only" approach is what was picked for almost-all takes on the robot emoji (🤖). Granted, there's more detail available to them rather than just an outline.

Wed, May 20, 4:03 PM · Editing-team (Editing-Q4-11May-22May-2026), User-notice, Epic, Codex
DLynch added a comment to T399175: [EPIC] Refine Codex icon library.

I noticed these search icons...

Wed, May 20, 2:43 PM · Editing-team (Editing-Q4-11May-22May-2026), User-notice, Epic, Codex
DLynch closed T425145: VisualEditor doesn't show newly added references when using {{reflist}} as Resolved.

Sorry, forgot to close this because of the hackathon.

Wed, May 20, 12:32 AM · Editing-team (Editing-Q4-27Apr-8May-2026), WMDE-TechWish-Sprint-2026-05-12-Fungi, Cite
DLynch added a project to T426432: Mobile VE: Link context not showing when clicking on link while keyboard visible: Editing QA.
Wed, May 20, 12:24 AM · Verified, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Regression, Editing-team (Editing-Q4-11May-22May-2026), VisualEditor

Tue, May 19

DLynch attached a referenced file: F82651402: CleanShot 2026-05-18 at 16.16.25@2x.png.
Tue, May 19, 4:16 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, Design
DLynch moved T426771: Suggestions: align "More options" button with the rest of buttons from Decision to be made to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
Tue, May 19, 4:16 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, Design
DLynch claimed T426771: Suggestions: align "More options" button with the rest of buttons.
Tue, May 19, 4:15 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, Design
DLynch moved T426770: EditCheck + Suggestions: Update footer styles from Decision to be made to Code review on the Editing-team (Editing-Q4-11May-22May-2026) board.
Tue, May 19, 4:14 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch claimed T426770: EditCheck + Suggestions: Update footer styles.
Tue, May 19, 4:14 PM · Skipped QA, MW-1.47-notes (1.47.0-wmf.4; 2026-05-26), Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode, EditCheck, Design
DLynch added a comment to T424203: Add a link suggestion: Update copy.

@bmartinezcalvo if there's a ticket for more general design adjustments to the widget (for the footer and the suggestion-feedback icon), I could retag those patches against it.

Tue, May 19, 3:36 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), RoadToWiki, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), VisualEditor Suggestion Mode, Design
DLynch added a comment to T424203: Add a link suggestion: Update copy.

That patch adjusts the footer display:

CleanShot 2026-05-19 at 10.32.10@2x.png (646×562 px, 56 KB)

Tue, May 19, 3:33 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), RoadToWiki, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), VisualEditor Suggestion Mode, Design
DLynch claimed T424203: Add a link suggestion: Update copy.
Tue, May 19, 2:47 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), RoadToWiki, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), VisualEditor Suggestion Mode, Design
DLynch added a comment to T424203: Add a link suggestion: Update copy.

For the suggestion feedback ... menu, that patch does this:

Tue, May 19, 2:42 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), RoadToWiki, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), VisualEditor Suggestion Mode, Design
DLynch added a comment to T424203: Add a link suggestion: Update copy.

To align with the Revise Tone one, the footer should include the cdxIconRobot in icon-size-small

Tue, May 19, 2:24 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), RoadToWiki, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), VisualEditor Suggestion Mode, Design

Mon, May 18

DLynch moved T426237: SuggestionMode: Exiting out of ReferenceCheck shows the virtual keyboard from Code review to QA on the Editing-team (Editing-Q4-11May-22May-2026) board.
Mon, May 18, 10:31 PM · Verified, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Editing-team (Editing-Q4-11May-22May-2026)
DLynch added a comment to T424203: Add a link suggestion: Update copy.

With those patches, we're now to this state:

CleanShot 2026-05-18 at 16.43.59@2x.png (634×540 px, 61 KB)

Mon, May 18, 9:45 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), RoadToWiki, Patch-For-Review, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), VisualEditor Suggestion Mode, Design
DLynch updated subscribers of T426608: Consider introducing a JSON Schema for EditCheck config.

@medelius did some earlier looking into this because CommunityConfiguration requires a schema. The schemas it required weren't permissive enough to make that system usable for us at the time, but there might be some reusable fragments from when that was done?

Mon, May 18, 3:41 PM · Editing-team (Editing-current-Q4-8Jun-19Jun-2026), Patch-For-Review, EditCheck

Fri, May 15

DLynch added a comment to T425594: Suggest card not shown when tapping "View suggestions".

I can't reproduce this one.

Fri, May 15, 9:23 PM · OKR-Work, Editing-team (Editing-Q4-11May-22May-2026), VisualEditor Suggestion Mode
DLynch claimed T424684: [SPIKE] Investigate the remaining causes of the SLO being in the red.
Fri, May 15, 4:47 PM · MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Editing-team (Editing-Q4-27Apr-8May-2026), OKR-Work, Goal, EditCheck
DLynch moved T424684: [SPIKE] Investigate the remaining causes of the SLO being in the red from Ready for Dev to Code review on the Editing-team (Editing-Q4-27Apr-8May-2026) board.
Fri, May 15, 4:47 PM · MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Editing-team (Editing-Q4-27Apr-8May-2026), OKR-Work, Goal, EditCheck
DLynch added a comment to T424684: [SPIKE] Investigate the remaining causes of the SLO being in the red.

Those patches all came from me investigating uncaught JS errors related to editcheck for this task, though not all of them could actually interfere with the SLO.

Fri, May 15, 4:47 PM · MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Editing-team (Editing-Q4-27Apr-8May-2026), OKR-Work, Goal, EditCheck
DLynch added a comment to T426432: Mobile VE: Link context not showing when clicking on link while keyboard visible.

On iOS: the context doesn't appear, but the keyboard does get dismissed. A second tap on the link open the context.

Fri, May 15, 4:23 PM · Verified, MW-1.47-notes (1.47.0-wmf.3; 2026-05-19), Regression, Editing-team (Editing-Q4-11May-22May-2026), VisualEditor