DLynch (David Lynch)
Senior Software Engineer

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 1 2015, 7:50 PM (142 w, 3 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF)

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Thu, Jun 21

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

We do already refer to the link text as "label" in other places -- e.g. a numbered link gets an "add label" button to swap out the "[3]" for text -- that said, if people think it's unclear and needs explanation in this situation, now would be a good time to quickly change that before people spend effort on translations.

Thu, Jun 21, 4:53 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T197834: Regression: Editing workflow broken for non-JS users and template editors.

I do agree with matmarex's suggested approach. The issue here seems to stem from a lack of clarity (on my part, on reviewer's part, on the code's part, etc) about exactly when things are providing a mobile experience. Wiping that clean and getting a simple rule for it would make sense.

Thu, Jun 21, 4:47 PM · Patch-For-Review, Readers-Web-Kanbanana-Board, Readers-Web-Backlog, MobileFrontend, Mobile, VisualEditor, Regression

Tue, Jun 19

DLynch added a comment to T197659: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked.

I found the simplest way to test reproducing this was to make a template which just contains a single link, include it on an editor page, and then use dev tools to outright remove the highlight node. Leaves the link easily accessible for clicking.

Tue, Jun 19, 6:58 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), VisualEditor-MediaWiki-Templates
DLynch moved T197659: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked from Up next to Code review and QA on the VisualEditor (Current work) board.
Tue, Jun 19, 5:02 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), VisualEditor-MediaWiki-Templates
DLynch claimed T197659: VisualEditor occasionally opens a link within a template instead of the template's settings when clicked.
Tue, Jun 19, 4:53 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), VisualEditor-MediaWiki-Templates

Mon, Jun 18

DLynch moved T197445: Can't reload a page by clicking article tab after editing in VE from Up next to Code review and QA on the VisualEditor (Current work) board.
Mon, Jun 18, 7:04 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T197445: Can't reload a page by clicking article tab after editing in VE.
Mon, Jun 18, 3:48 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor (Current work), VisualEditor-MediaWiki

Fri, Jun 15

DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

The overlay shouldn't be loading on desktop though. Overlays only really make sense on a mobile/tablet device.

Fri, Jun 15, 9:54 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Trizek-WMF If Ed approves and merges the patch, it could all happen today. So the timeline is pretty much "once approvals come in", unfortunately.

Fri, Jun 15, 3:05 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

@Jdlrobson The merged patches should mean that the case you show there will result in the full article appearing in the editor. You can see it on beta: https://simple.wikipedia.beta.wmflabs.org/wiki/Barack_Obama?useskin=minerva&action=edit

Fri, Jun 15, 4:36 AM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend

Thu, Jun 14

DLynch moved T196915: Give mobile editor a way to edit more than just a single section at once from Done to Code review and QA on the VisualEditor (Current work) board.
Thu, Jun 14, 9:09 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch updated subscribers of T197250: Tabbing from "find text" in find and replace dialog takes you to "site search" before "replace text".

I've done some hunting down of this -- the issue is that the windowmanager div the toolbar is in has aria-hidden=true, which makes my tab isolation code assume that nothing in it should be treated as being visible for tabbing purposes.

Thu, Jun 14, 8:25 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), VisualEditor-EditingTools, VisualEditor (Current work)
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

For what it's worth, I'm thinking of this ticket as a two-part thing. Part one is the existing patches which will restore the ?action=edit behavior of getting the full text, and part two would be working out the right place to put the UI to expose it more thoroughly. (I'd argue that the edit button at the top of a mobile page next to all the other page-level actions should trigger /all, but there's probably an argument to be had here...)

Thu, Jun 14, 4:53 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

Yeh the magic password bit doesn't help this problem. mobileeditorsuppress is not exactly easy to remember and is also hard to type on mobile. I personally don't think this gains much unless it's linked to in the interface.

Thu, Jun 14, 4:45 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

@Deskana: That all sounds correct.

Thu, Jun 14, 3:59 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

I've updated the patch for option 1 for now. (Since it's the simple just-make-it-not-bold adjustment.)

Thu, Jun 14, 3:46 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch updated subscribers of T196915: Give mobile editor a way to edit more than just a single section at once.

From @Deskana I guess? (It's mobile, but it's also editing, so...)

Thu, Jun 14, 3:34 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend

Wed, Jun 13

DLynch added a comment to T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

@Volker_E So, I feel like the styling now suggests that the action button is "inside" the input. (Maximally so in the field-with-search-icon case.) That makes it feel wrong to me when the field focus excludes the button. It breaks the "this is one unit" message that the no-spacing-shared-borders design seems to be going for.

Wed, Jun 13, 5:20 PM · VisualEditor
DLynch added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

That said, I just tried to reproduce this with the new steps, and it still doesn't produce the error for me.

Wed, Jun 13, 4:21 PM · VisualEditor
DLynch updated subscribers of T196686: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field .

It maybe looks a little weird with the focus highlight and the disabled action button. If @Volker_E would like to tweak that combination somehow?

Wed, Jun 13, 4:06 PM · VisualEditor
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Esanders I do like how 2 winds up looking, particularly for longer labels. Want to wait for @Pginer-WMF to weigh in with a Design-y opinion?

Wed, Jun 13, 4:04 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch moved T196915: Give mobile editor a way to edit more than just a single section at once from Up next to Code review and QA on the VisualEditor (Current work) board.
Wed, Jun 13, 3:53 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196479: Console error when copy/pasting wikitext into VE.

The 400 is specifically "Unknown source".

Wed, Jun 13, 4:16 AM · Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Collaboration-Team-Triage, Maps, Verified, User-Ryasmeen, VisualEditor-CopyPaste, MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor (Current work), VisualEditor-ContentEditable

Tue, Jun 12

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

@Trizek-WMF it truncates itself so it fits on one line.

Tue, Jun 12, 3:46 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Mon, Jun 11

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

I think building it as a separate context item which might not appear directly next to the link context item would be a bit confusing, just because it's explicitly scoped to act on the link annotation, whereas the pile-of-contexts is "all the overlapping annotations at this cursor location".

Mon, Jun 11, 4:53 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

Okay, thanks for that! That sequence, and particularly the "xy" still being present, makes me suspect that we're failing to properly tear down the toolbar dialogs, so it's still holding on to a reference to the previous surface, resulting in the failure when we try to perform actions on a discarded surface.

Mon, Jun 11, 4:28 PM · VisualEditor
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

It's less apparent in the screenshot there, but in the full MW-VE experience, having that separate-section styling helps to distinguish it from the preview a bit:

Mon, Jun 11, 4:25 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T196915: Give mobile editor a way to edit more than just a single section at once.

That patch makes it so that visiting a ?action=edit URL will load the full page's text in the overlay editor. Sort of a preserve-the-status-quo patch.

Mon, Jun 11, 4:03 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend
DLynch added a comment to T196150: Regression: Links containing "action" always show the editor on mobile version regardless of value.

I've made T196915 for the edit-a-full-page issue.

Mon, Jun 11, 3:49 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Readers-Web-Backlog (Tracking), VisualEditor (Current work), Regression, Mobile, MobileFrontend
DLynch created T196915: Give mobile editor a way to edit more than just a single section at once.
Mon, Jun 11, 3:48 PM · MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), Patch-For-Review, VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-2017WikitextEditor, Readers-Web-Backlog (Tracking), VisualEditor (Current work), MobileFrontend

Sun, Jun 10

DLynch added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

A variant on that, which I think is probably overkill, would be to use the key styling from the help dialog:

Sun, Jun 10, 8:42 PM · Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Sat, Jun 9

DLynch added a comment to T196789: Consider exposing the plain-paste shortcut in the rich-text/plain-text paste dialog somewhere.

Do we have any other shortcuts exposed in dialogs to be consistent with the styling of, or is this treading new ground? (Nothing springs to mind, but...)

Sat, Jun 9, 12:49 AM · Design, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Thu, Jun 7

DLynch added a comment to T194825: Abstract linkAnnotation-active behaviour.

@Esanders is there anything left that you want to do for this after ddef270d90?

Thu, Jun 7, 3:45 PM · VisualEditor, Technical-Debt
DLynch added a comment to T196521: Uncaught TypeError: Cannot read property 'getOffset' of null appears when typing a character in Find field while RegEx option is enabled.

I can't reproduce this, trying locally and on beta.

Thu, Jun 7, 3:40 PM · VisualEditor
DLynch claimed T196254: Copying table creates visible ve-data-attributes and table tags.
Thu, Jun 7, 3:21 PM · MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor-CopyPaste, VisualEditor (Current work), VisualEditor-Tables

Tue, Jun 5

DLynch updated subscribers of T196479: Console error when copy/pasting wikitext into VE.

@Esanders Could be a side effect of 49a8fbae4 or 24e35e428... but it seems to be saying that node is null, which is weird since node = this. Or this.icon is null, in a path which has already verified it exists.

Tue, Jun 5, 5:19 PM · Collaboration-Feature-Rollouts (Collaboration-Maps), Discovery, Collaboration-Team-Triage, Maps, Verified, User-Ryasmeen, VisualEditor-CopyPaste, MW-1.32-release-notes (WMF-deploy-2018-06-12 (1.32.0-wmf.8)), VisualEditor (Current work), VisualEditor-ContentEditable
DLynch created T196481: Give a way to streamline pasting in source mode.
Tue, Jun 5, 5:11 PM · Design, VisualEditor

Mon, Jun 4

DLynch added a comment to T196150: Regression: Links containing "action" always show the editor on mobile version regardless of value.

@Daimona: I'm not opposed here, but the MobileFrontend currently only does section-editing. The mimic'd behavior here is as-if you had visited the page and then clicked the edit button at the very top of the page. (I think this is quite confusing even without this action=edit behavior, naturally.)

Mon, Jun 4, 4:31 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Readers-Web-Backlog (Tracking), VisualEditor (Current work), Regression, Mobile, MobileFrontend
DLynch added a comment to T190079: Prompt user before automatically converting pasted HTML to wikitext.

@Bencemac: On the defaults front, as much as anything that's a UI question. Fitting the setting in, changing the setting later, etc.

Mon, Jun 4, 3:46 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch claimed T196150: Regression: Links containing "action" always show the editor on mobile version regardless of value.
Mon, Jun 4, 3:18 PM · MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), Readers-Web-Backlog (Tracking), VisualEditor (Current work), Regression, Mobile, MobileFrontend

Wed, May 30

DLynch added a comment to T193665: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms.

@Deskana it's not merged yet, so I think what you're saying is that the current state of affairs before-this-patch needs changing.

Wed, May 30, 3:51 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor

Tue, May 29

DLynch moved T194631: Canceling section edit in NWE takes you to start of page from Up next to Code review and QA on the VisualEditor (Current work) board.
Tue, May 29, 2:47 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch claimed T194631: Canceling section edit in NWE takes you to start of page.
Tue, May 29, 2:46 PM · Verified, MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

May 25 2018

DLynch added a comment to T194837: Using back button to go back to Special:CollabPad adds a new toolbar.

I don't think this is happening any more. (Or, it's not to me.)

May 25 2018, 4:04 PM · User-Ryasmeen, VisualEditor
DLynch added a comment to T195544: [Regression pre-wmf.6] UI for dialogs with multiple tabs in VE is broken on Beta.

I don't see this broken on beta / locally. Did it get fixed somewhere else?

May 25 2018, 1:40 PM · User-Ryasmeen, VisualEditor (Current work)
DLynch added a comment to T195528: Issues with the mobile editor on Wikimedia Commons.

May 25 2018, 1:42 AM · MediaWiki-Page-editing, MobileFrontend

May 24 2018

DLynch added a comment to T195528: Issues with the mobile editor on Wikimedia Commons.

When we say "desktop editor" here, are we referring to Visual Editor, the 2017 New Wikitext Editor, or the classic desktop wikitext editor?

May 24 2018, 11:20 PM · MediaWiki-Page-editing, MobileFrontend
TheDJ awarded T190079: Prompt user before automatically converting pasted HTML to wikitext a Love token.
May 24 2018, 7:18 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T193665: Don't show the loading bar on the 2017 Wikitext editor for the first 750ms.

There, a patch in the name of having this be something people can test the experience of.

May 24 2018, 4:55 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor
DLynch moved T195191: Cite menu option is missing on the Mobile VE toolbar from Up next to Code review and QA on the VisualEditor (Current work) board.
May 24 2018, 4:36 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-References, VisualEditor (Current work)
DLynch claimed T195191: Cite menu option is missing on the Mobile VE toolbar.

I'd assume fallout from a08febb0afa2d by @Esanders. Mostly because MobileArticleTarget never got an equivalent to 900b74e9a9 which lets it know where references are supposed to go in the toolbar.

May 24 2018, 3:31 PM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki-References, VisualEditor (Current work)

May 23 2018

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

A 1-2 pixel tweak applied to a few of these elements produces this:

May 23 2018, 4:39 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
DLynch added a comment to T159971: Provide the VE wikitext editing mode as the mobile wikitext editor.

I wound up doing more on this, at the hackathon. (Admittedly, not having seen Ed's patch, otherwise I'd have added to it instead.)

May 23 2018, 4:18 PM · VisualEditor (Current work), Patch-For-Review, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-MediaWiki-Mobile

May 20 2018

DLynch updated subscribers of T178371: Use passive events where appropriate.

@Ryasmeen: Testing for the merged patch should be on scrolling behavior. (The floating toolbar, find/replace search highlights updating, context items / inspectors open while scrolling.)

May 20 2018, 5:10 PM · User-Ryasmeen, VisualEditor (Current work), Performance, VisualEditor-Performance
DLynch added a comment to T187616: "element.setAttribute is not a function" error due to comment nodes, when switching to historic visual diff.

Doesn't seem to happen any more, so I imagine T187070 fixed it as a side-effect.

May 20 2018, 11:50 AM · VisualEditor, VisualEditor-VisualDiffs
DLynch moved T190591: Dialog asking "Do you really want to abandon your edit?" appears while saving an edit with mobile VE from Up next to Code review and QA on the VisualEditor (Current work) board.
May 20 2018, 10:56 AM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki, VisualEditor (Current work), MobileFrontend
DLynch claimed T190591: Dialog asking "Do you really want to abandon your edit?" appears while saving an edit with mobile VE.
May 20 2018, 10:56 AM · Verified-in-Phase0, Verified, User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor-MediaWiki-Media, VisualEditor-MediaWiki, VisualEditor (Current work), MobileFrontend

May 19 2018

DLynch moved T185729: &veaction=edit URL parameter does not work on mobile site from Up next to Code review and QA on the VisualEditor (Current work) board.
May 19 2018, 8:14 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-Initialisation
DLynch claimed T185729: &veaction=edit URL parameter does not work on mobile site.
May 19 2018, 8:13 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor-MediaWiki-Mobile, VisualEditor-MediaWiki, VisualEditor (Current work), VisualEditor-Initialisation
DLynch added a parent task for T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console: T178371: Use passive events where appropriate.
May 19 2018, 5:38 PM · Readers-Web-Backlog (Tracking), VisualEditor
DLynch added a subtask for T178371: Use passive events where appropriate: T190550: [Bug] Mobile VisualEditor prints ~1200 non-passive event listener violations to console.
May 19 2018, 5:38 PM · User-Ryasmeen, VisualEditor (Current work), Performance, VisualEditor-Performance
DLynch claimed T178371: Use passive events where appropriate.
May 19 2018, 5:37 PM · User-Ryasmeen, VisualEditor (Current work), Performance, VisualEditor-Performance
DLynch claimed T190068: Escape should close toolbar panels before trying to close the entire editor.
May 19 2018, 5:36 PM · VisualEditor-EditingTools, MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work)
DLynch changed the visibility for F18359052: ve-limit.mov.
May 19 2018, 5:06 PM
DLynch moved T194458: VisualEditor: Only show edit summary remaining character countdown for last 99 characters from Up next to Code review and QA on the VisualEditor (Current work) board.
May 19 2018, 2:35 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work), VisualEditor-MediaWiki
DLynch claimed T194458: VisualEditor: Only show edit summary remaining character countdown for last 99 characters.
May 19 2018, 2:35 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work), VisualEditor-MediaWiki

May 18 2018

DLynch moved T194463: Hashlinks with question marks shown as missing articles in preview from Up next to Code review and QA on the VisualEditor (Current work) board.
May 18 2018, 6:02 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch claimed T194463: Hashlinks with question marks shown as missing articles in preview.
May 18 2018, 6:01 PM · MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

Relatedly, here we see it blending in with a multiple-annotations stack:

May 18 2018, 3:58 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

May 16 2018

DLynch added a comment to T180151: When you delete a parameter, the template dialogue box scrolls up to the top, and it should stay in the same place.

Issue is subtle fallout from the async-promises change, I think?

May 16 2018, 9:27 AM · Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-Templates

May 10 2018

DLynch moved T194092: Rewrite DesktopArticleTarget#rebuildCategories, it doesn't need an API request from In progress to Code review and QA on the VisualEditor (Current work) board.
May 10 2018, 3:37 PM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), Technical-Debt, VisualEditor-MediaWiki

May 9 2018

DLynch added a comment to T194092: Rewrite DesktopArticleTarget#rebuildCategories, it doesn't need an API request.

I don't think we can make it not need an API request. We can make it use a different API request, though. Or we can decide we don't care about hidden-categories being hidden in the rebuilt markup. (Status quo is already it missing the categories from templates / auto-added stuff like pages-with-syntax-errors.)

May 9 2018, 3:26 PM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), Technical-Debt, VisualEditor-MediaWiki

May 8 2018

DLynch claimed T194092: Rewrite DesktopArticleTarget#rebuildCategories, it doesn't need an API request.
May 8 2018, 5:02 PM · MW-1.32-release-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), VisualEditor (Current work), Technical-Debt, VisualEditor-MediaWiki
DLynch added a comment to T190079: Prompt user before automatically converting pasted HTML to wikitext.

May 8 2018, 3:18 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

May 7 2018

DLynch added a comment to T190079: Prompt user before automatically converting pasted HTML to wikitext.

It'd be:

May 7 2018, 11:29 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

May 2 2018

DLynch moved T193206: Value null is the wrong type for property "action.saveIntent.timing" (integer expected) appears intermittently while adding a new section from In progress to Code review and QA on the VisualEditor (Current work) board.
May 2 2018, 4:36 PM · Verified, User-Ryasmeen, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work)
DLynch claimed T193206: Value null is the wrong type for property "action.saveIntent.timing" (integer expected) appears intermittently while adding a new section .

If it's always action.saveIntent.timing, that implies that when onSaveWorkflowBegin happens timing.ready is undefined.

May 2 2018, 4:30 PM · Verified, User-Ryasmeen, VisualEditor-MediaWiki, MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), VisualEditor (Current work)
DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

Also, let's see...

May 2 2018, 4:15 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links
Elitre awarded T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype a Love token.
May 2 2018, 9:17 AM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

May 1 2018

DLynch added a comment to T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype.

Here's the new state of that patch:

May 1 2018, 4:58 PM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Apr 30 2018

DLynch closed T192320: Visual Editor: Cite > Manual > Basic not stripping unwanted formatting as Resolved.
Apr 30 2018, 3:56 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work)

Apr 25 2018

DLynch moved T192163: Users can't tab into or out of table captions from In progress to Code review and QA on the VisualEditor (Current work) board.
Apr 25 2018, 4:18 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Verified, VisualEditor-Tables, VisualEditor (Current work)
Krinkle awarded T124305: Users sometimes struggle to select the text of the link anchor within the cartouche and so delete it on select-retype a Orange Medal token.
Apr 25 2018, 1:41 AM · VisualEditor (Current work), Tech-Ambassadors, User-notice, Design, VisualEditor-MediaWiki-Links, VisualEditor-Links

Apr 24 2018

DLynch claimed T192163: Users can't tab into or out of table captions.
Apr 24 2018, 4:45 PM · User-Ryasmeen, MW-1.32-release-notes (WMF-deploy-2018-05-01 (1.32.0-wmf.2)), Verified, VisualEditor-Tables, VisualEditor (Current work)

Apr 18 2018

DLynch added a comment to T189556: Pasting long content is many times slower than inserting the same content in a different way.

It's going to get briefly re-broken and then fixed again differently because of T192320.

Apr 18 2018, 10:33 PM · VisualEditor (Current work), Browser-Support-Google-Chrome, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor
DLynch moved T192320: Visual Editor: Cite > Manual > Basic not stripping unwanted formatting from Up next to Code review and QA on the VisualEditor (Current work) board.
Apr 18 2018, 4:55 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work)
DLynch claimed T192320: Visual Editor: Cite > Manual > Basic not stripping unwanted formatting.
Apr 18 2018, 3:49 PM · MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work)

Apr 17 2018

DLynch moved T192378: Comment and transclusions in headings are misaligned from Up next to Code review and QA on the VisualEditor (Current work) board.
Apr 17 2018, 4:36 PM · Verified-in-Phase0, Verified, VisualEditor-EditingTools, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work)
DLynch created T192378: Comment and transclusions in headings are misaligned.
Apr 17 2018, 3:56 PM · Verified-in-Phase0, Verified, VisualEditor-EditingTools, MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), VisualEditor (Current work)

Apr 12 2018

DLynch added a comment to T190079: Prompt user before automatically converting pasted HTML to wikitext.

Snippet of your actual content in both modes does also have the drawback that we'd have to wait for it to run the round trip to the server for the conversion, as well.

Apr 12 2018, 3:08 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Apr 11 2018

DLynch moved T190079: Prompt user before automatically converting pasted HTML to wikitext from In progress to Code review and QA on the VisualEditor (Current work) board.
Apr 11 2018, 5:06 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch added a comment to T190079: Prompt user before automatically converting pasted HTML to wikitext.

I'm sure people might want to give feedback on the wording of this.

Apr 11 2018, 4:28 AM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor

Apr 9 2018

DLynch claimed T190079: Prompt user before automatically converting pasted HTML to wikitext.
Apr 9 2018, 4:06 PM · MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), Patch-For-Review, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch closed T190590: Copy pasting wikitext between two NWE windows causes <nowiki> as Resolved.

This resolves the wikitext / other-plain-text cases. The parent (T153315) is unaffected, since that's not text/plain.

Apr 9 2018, 3:25 PM · Patch-For-Review, Verified, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor (Current work), Browser-Support-Google-Chrome
DLynch closed T190590: Copy pasting wikitext between two NWE windows causes <nowiki>, a subtask of T153315: Pasting annotated wikitext results in double encoding and therefore <nowiki>s, as Resolved.
Apr 9 2018, 3:25 PM · Regression, MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), User-Ryasmeen, VisualEditor-CopyPaste, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor

Apr 5 2018

DLynch added a comment to T191184: Switching to NWE is failing on the Swedish beta cluster wiki.

This does tend to be an error we see if Parsoid / Restbase aren't running properly, for what it's worth.

Apr 5 2018, 4:52 PM · Beta-Cluster-Infrastructure, VisualEditor (Current work), VisualEditor-MediaWiki-2017WikitextEditor
DLynch moved T191234: Tranclusion dialog is shown with horizontal scrollbar because the "Add template" button doesn't fit when Options section is appearing on the left side from In progress to Code review and QA on the VisualEditor (Current work) board.
Apr 5 2018, 3:58 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), VisualEditor-MediaWiki-Templates, Regression, VisualEditor (Current work)
DLynch claimed T191234: Tranclusion dialog is shown with horizontal scrollbar because the "Add template" button doesn't fit when Options section is appearing on the left side .
Apr 5 2018, 3:50 PM · User-Ryasmeen, Verified, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), VisualEditor-MediaWiki-Templates, Regression, VisualEditor (Current work)

Mar 29 2018

DLynch added a comment to T190590: Copy pasting wikitext between two NWE windows causes <nowiki>.

This patch is a shining example of lots of debugging and history-trawling resulting in a tiny change.

Mar 29 2018, 5:02 PM · Patch-For-Review, Verified, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor (Current work), Browser-Support-Google-Chrome
DLynch moved T190590: Copy pasting wikitext between two NWE windows causes <nowiki> from Up next to Code review and QA on the VisualEditor (Current work) board.
Mar 29 2018, 3:40 PM · Patch-For-Review, Verified, User-Ryasmeen, VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor (Current work), Browser-Support-Google-Chrome