User Details
- User Since
- Oct 5 2023, 1:15 PM (131 w, 4 d)
- Availability
- Available
- LDAP User
- Unknown
- MediaWiki User
- DTorsani-WMF [ Global Accounts ]
Thu, Apr 2
Tue, Mar 31
At this time, we are not moving forward with changes to Dialog and Popover footer action behavior.
Mon, Mar 30
Thank you so much for all your detailed feedback @Snaevar! This was truly helpful. There are a few icons in your list that either have to do with a visual balance in application situation, or have previously gone through many rounds of feedback and revisions, and we have landed on those versions. But most of your changes I have applied and updated here. So thank you for that! I think these are already better thanks to your feedback.
Got it, thank you. Yeah, I still don't know about the alignment and positioning. Maybe worth bringing to a design review or getting more opinions. I'll put something together.
@bmartinezcalvo thanks for your thoughts. Does a Dialog actually change its order and alignment of buttons in RTL languages? I am not aware of us changing the layout based on reading direction.
Fri, Mar 27
I've put together a proof of concept patch.
Assigning @DSmit-WMF to this and moving to code review as she has been working on a patch for this.
Thu, Mar 26
Here's the latest direction, which we will be moving forward with. The stylistic direction continues the 2px outline base, with some icons being filled as previously mentioned. It uses a miter/bevel/chamfer join for acute angles, helping to soften, or almost round, certain otherwise sharp corners, throwing off the gestalt of the rather brutalist and squared aesthetic. There are instances where intentional deviation from the defined style occurs, in order to maintain the integrity of the symbol or letterform, such as the various versions of the bold icon.
Wed, Mar 25
Okay, curious what @DSmit-WMF and @AnneT think, and if they agree with this, I'm happy to put some patches together, but might need some help with the Toast one if my above approach is not the right one or if we need to put more dependencies on there to adjust the layout based on props, etc.
Thanks for weighing in Bárbara. A couple thoughts:
- I'm not sure the original design is working, and the right alignment feels odd to me.
- There is also this task reconsidering the position of the buttons in Dialog and Popover, which might be worth doing now.
Tue, Mar 24
@DSmit-WMF @AnneT what if we did something like this?
Wed, Mar 18
Tue, Mar 17
@bmartinezcalvo these actually are applied in Toast, but they are not surfaced in the docs because we don't feel confident yet about how they would be used as Toasts. We are considering doing the same for Messages for now.
Design files have been submitted to the vendor.
Mar 12 2026
@Volker_E that's fair. I am generally more comfortable with opening up a bit more flexibility in component variant availability and allowing for new potential valid use cases we can't think about. That being said, we could do on Message what we did on Toast, which was make these new variants possible, but not document them, and include a comment that does not necessarily encourage their use, hence their exclusion from the docs site. What do you think?
Thanks @Volker_E! I need to add back the background color for the bar, so that the page is not visible through the progress bar.
Mar 11 2026
@Volker_E thanks for your help on this. Forgive me about the second criteria, that wasn't as clear as it should've been. I've updated it, as it is specifically for in Codex, and we could either update @font-family-base to point to @font-family-system-sans or font-family.sans-100 in Codex application.json. Which do you think is best?
Mar 9 2026
@Volker_E thanks for all the additional information.
Mar 6 2026
@Volker_E makes sense, we just have to be a little more intentional about the scope of things these days with the limited resources we have. Thanks for helping out and submitting those two patches. What do you think is the best next step then?
Mar 5 2026
@Volker_E Wouldn't it be simpler to include this as a follow up task? All of the current acceptance criteria is doable with that step, and can be done before that step. This feels like it inflates the scope.
Thanks @Volker_E. Can you share more about what the unintended side effects and community confusion from #1? For #5, what type of community involvement do you feel we need at this point to move this forward? Essentially, how can we most effectively complete this task?
Mar 3 2026
Mar 2 2026
Thanks @AnneT! I'm actually planning to work on this task this week. I'd appreciate code review if you or someone from your team would be able and willing.
Feb 26 2026
I've updated the task description to hopefully provide some more clarity on what's going on and what we want to do.
Feb 23 2026
Feb 19 2026
This will be done as a part of T399175: [EPIC] Refine Codex icon library