Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (244 w, 6 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Pronouns: he/him
Babel: it-N, en-3, fr-1, de-1

Recent Activity

Today

Daimona added a comment to T235589: Fatal exception on Special:MovePage: "Failed to create null revision while moving page ID".

Anyway I just read the discussion about this error on it.wiki and as I understand it the user who moved Amaury Cordeel did not use the gadget at all. The error message showed up after clicking the "Move page" button on Special:MovePage.

Wed, Jan 26, 4:10 PM · Platform Engineering, Beta-Cluster-reproducible, MediaWiki-Page-rename, User-brennen, MediaWiki-Revision-backend, Wikimedia-production-error

Mon, Jan 24

Daimona added a comment to T299978: AbuseFilter 1.36 selenium test failures.

I'm not sure what's going on -- for starters, there haven't been changes to AF in REL1_36 that crossed that code path, nor to core's HTMLForm.php file. However, this code was almost certainly working when 1.36 was cut. Second, the assertion before the first failing one ensures that the current page is Special:AbuseFilter/new, and this is confirmed by the image linked above. The view picker code in 1.36 is essentially the same as today, and if the subpage is "new" it instantiates an AbuseFilterViewEdit object, not AbuseFilterViewImport, which is in the above stacktrace. The code in question is also pretty simple, and I don't see how it could confuse "new" and "import". As such, the only possible explanation is that the special page is being instantiated with the wrong subpage (by SpecialPageFactory). My guess would be something messing up with Titles and leaking some state. I seem to recall a similar issue in the past (for unrelated code, I believe), where the Title wasn't correct after form submission.

Mon, Jan 24, 10:53 PM · ci-test-error, Browser-Tests, MW-1.36-release, AbuseFilter
Daimona added a comment to T299978: AbuseFilter 1.36 selenium test failures.

According to https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php73-selenium-docker/13195/artifact/log/bad-data-results-in-an-error.png, there's an actual problem with the code...

Mon, Jan 24, 10:30 PM · ci-test-error, Browser-Tests, MW-1.36-release, AbuseFilter
Daimona added a comment to T235589: Fatal exception on Special:MovePage: "Failed to create null revision while moving page ID".

What were you doing, on what wiki?

Mon, Jan 24, 12:44 PM · Platform Engineering, Beta-Cluster-reproducible, MediaWiki-Page-rename, User-brennen, MediaWiki-Revision-backend, Wikimedia-production-error

Sun, Jan 23

Daimona added a comment to T235589: Fatal exception on Special:MovePage: "Failed to create null revision while moving page ID".

FTR, this seems to be still happening. Current backtrace:

Sun, Jan 23, 12:37 PM · Platform Engineering, Beta-Cluster-reproducible, MediaWiki-Page-rename, User-brennen, MediaWiki-Revision-backend, Wikimedia-production-error

Thu, Jan 20

Daimona added a parent task for T296280: Introduce "Event" and "Event talk" namespaces: T296279: Create CampaignEvents extension.
Thu, Jan 20, 6:04 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona added a parent task for T298542: Determine names of special pages when organizer creates registration: T296279: Create CampaignEvents extension.
Thu, Jan 20, 6:04 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents
Daimona added subtasks for T296279: Create CampaignEvents extension: T296280: Introduce "Event" and "Event talk" namespaces, T298542: Determine names of special pages when organizer creates registration.
Thu, Jan 20, 6:04 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration

Mon, Jan 17

Daimona added a comment to T266626: Excimer PHP 8.0 support.
Mon, Jan 17, 10:03 PM · Patch-For-Review, PHP 8.0 support, Excimer
Daimona added a comment to T266626: Excimer PHP 8.0 support.

I've regenerated the stubs using make_stub, but the final privates are still there. At this point, I assume it's something within the extension that sets both modifiers.

Mon, Jan 17, 12:53 PM · Patch-For-Review, PHP 8.0 support, Excimer

Tue, Jan 11

Daimona added a comment to T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter.

Based on my local testing, my guess was right. This was caused by r747596 -- notice how $slotRole is not passed to onEditFilterMergedContent. OTOH, it's really not that patch's fault, since the parameter is not officially documented in the hook documentation, nor is it present in the EditFilterMergedContentHook interface (see T288885).

Tue, Jan 11, 3:33 PM · Wikidata, Commons, AbuseFilter, SDC General
Daimona added a subtask for T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter: T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter.
Tue, Jan 11, 3:32 PM · Wikidata, Commons, AbuseFilter, SDC General
Daimona added a parent task for T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter: T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter.
Tue, Jan 11, 3:32 PM · AbuseFilter, MediaWiki-Core-Hooks, Wikidata
Daimona updated the task description for T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter.
Tue, Jan 11, 3:24 PM · AbuseFilter, MediaWiki-Core-Hooks, Wikidata
Daimona added a comment to T296545: PHP8: Error in WikiExporter TypeError: Unsupported operand types: array & int.

Can this be closed now?

Tue, Jan 11, 2:04 PM · MW-1.38-notes (1.38.0-wmf.13; 2021-12-13), PHP 8.0 support, MediaWiki-Core-Snapshots
Daimona added a comment to T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter.

The first thing that comes to mind is that whoever is firing the EditFilterMergedContent hook is passing SLOT_MAIN instead of the actual slot being edited. I'll try to reproduce this locally and see if that's indeed the reason.

Tue, Jan 11, 1:54 PM · Wikidata, Commons, AbuseFilter, SDC General

Wed, Jan 5

Daimona added a comment to T259377: Migrate AbuseFilter to Abstract Schema.

Anything left to do here?

Wed, Jan 5, 10:00 AM · AbuseFilter

Tue, Jan 4

Daimona renamed T298542: Determine names of special pages when organizer creates registration from Agree on a name for the CampaignEvents special page to Find a name for the CampaignEvents special page.
Tue, Jan 4, 3:18 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents
Daimona created T298542: Determine names of special pages when organizer creates registration.
Tue, Jan 4, 3:17 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents

Dec 23 2021

Daimona added a comment to T298263: Abusefilter warnings do not always appear when using reply tool.

AIUI, the actual bug here is the page going gray instead of displaying a warning message. The warning only appearing once is how the warnings are supposed to work.

Dec 23 2021, 6:47 PM · AbuseFilter, DiscussionTools

Dec 21 2021

Daimona added a comment to T298056: AbuseFilter should provide a way to get WebRequest in custom variable hooks.

This is a bit problematic... AF itself does not have access to the global request when it fires the hook, and accessing the WebRequest in general is not easy (unless you have a ContextSource). Also, I'm not sure what the future of WebRequest is, and whether we should treat it as a value object or as a service (currently it's something hybrid). If it's the former, then MW core hooks should pass it; if the second, then it should not be passed by the hook, but injected into the hook handler.

Dec 21 2021, 1:48 PM · AbuseFilter
Daimona added a comment to T298053: Add a phan job to gated extensions/skins and core testing each change with all of them.

I'm not sure if it's doable... The main potential issues I can think of are:

  • It might need A LOT of time and memory
  • We need to make sure that vendor dirs are only parsed once
  • Different repos have different configs
  • More code to analyze means that phan will end up analyzing some methods in a different order, which is going to have a noticeable effect on analysis result
Dec 21 2021, 1:32 PM · Continuous-Integration-Config, phan
Daimona closed T298008: shellbox-pipeline-test jobs fail because they use php-ast 0.1.6 as Resolved.

Seems to be fixed now, thanks!

Dec 21 2021, 1:18 PM · Shellbox, Continuous-Integration-Config

Dec 20 2021

Daimona renamed T296280: Introduce "Event" and "Event talk" namespaces from [PLACEHOLDER] Introduce "Event" and "Event talk" namespaces to Introduce "Event" and "Event talk" namespaces.
Dec 20 2021, 2:33 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona moved T296279: Create CampaignEvents extension from In Development 💻 to Review/Feedback 💬 on the Campaign-Tools (Campaign-Tools-Sprint-3) board.
Dec 20 2021, 2:31 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona renamed T298008: shellbox-pipeline-test jobs fail because they use php-ast 0.1.6 from Upgrade to php-ast 1.0.7 in CI to shellbox-pipeline-test jobs fail because they use php-ast 0.1.6.
Dec 20 2021, 1:09 PM · Shellbox, Continuous-Integration-Config
Daimona edited projects for T298008: shellbox-pipeline-test jobs fail because they use php-ast 0.1.6, added: Shellbox; removed phan.

I don't know precisely how that job works, but it seems to be using the composer-php72 image, on which we do NOT install our version of php-ast, so I guess it's just using some old version.

Dec 20 2021, 1:09 PM · Shellbox, Continuous-Integration-Config

Dec 17 2021

Daimona claimed T297975: "Password" inputbox still appear if "createaccountmail" checkbox is selected.
Dec 17 2021, 10:22 PM · MW-1.38-notes (1.38.0-wmf.16; 2022-01-03), Regression, MediaWiki-User-login-and-signup
Daimona added a comment to T296279: Create CampaignEvents extension.

Before adding the extension to translatewiki, I'd also like to create an alias file with the translations of the special page name (I don't know if things will work with an empty $specialPageAliases).

Dec 17 2021, 1:35 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona updated the task description for T296279: Create CampaignEvents extension.
Dec 17 2021, 1:04 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration

Dec 16 2021

Daimona committed rUCAM9d2561812f0d: Initial commit (authored by Daimona).
Initial commit
Dec 16 2021, 8:25 PM

Dec 14 2021

Daimona created T297748: Make NamespaceInfo work with PageIdentity.
Dec 14 2021, 7:19 PM · Platform Engineering, MediaWiki-General
Daimona awarded T139301: Remove @author lines from code a Like token.
Dec 14 2021, 3:40 PM · MW-1.30-release-notes, Patch-For-Review, MediaWiki-General, WMF-Legal, Proposal, Developer-Advocacy

Dec 10 2021

Daimona updated the task description for T296279: Create CampaignEvents extension.
Dec 10 2021, 5:30 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona updated the task description for T296279: Create CampaignEvents extension.
Dec 10 2021, 5:21 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona updated the task description for T296279: Create CampaignEvents extension.
Dec 10 2021, 4:51 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration

Dec 9 2021

Daimona updated the task description for T296279: Create CampaignEvents extension.
Dec 9 2021, 1:30 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona added a comment to T297352: PhanUndeclaredFunctionInCallable triggers for callable|string types.

Polymorphism doesn't work well with static analysis. Strings can be callable, so phan doesn't know whether the provided string is meant to be used as a callable, or as something else (in your example, a method name). The closest solution would be to disable the validity check for callables if the parameter can be callable|string (and probably other combinations, e.g. callable|array), although that would have false negatives. Here's the upstream issue for that: https://github.com/phan/phan/issues/1648

Dec 9 2021, 1:16 PM · phan

Dec 8 2021

Daimona added a comment to T297293: Create phan stub for php-apcu to pass phan on installs without it.

I think it would be better to generate them ourselves (instructions); PHPStorm stubs may have limited compatibility with phan IIRC.

Dec 8 2021, 11:04 PM · MediaWiki-General, phan
Daimona created T297295: Create project tag for the CampaignEvents extension.
Dec 8 2021, 3:19 PM · Project-Admins, Campaign-Tools (Campaign-Tools-Sprint-2)
Daimona claimed T296279: Create CampaignEvents extension.
Dec 8 2021, 3:09 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona renamed T296279: Create CampaignEvents extension from [PLACEHOLDER] Create Campaigns extension to Create CampaignEvents extension.
Dec 8 2021, 3:09 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration

Dec 6 2021

Daimona updated the task description for T296279: Create CampaignEvents extension.
Dec 6 2021, 7:12 PM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona removed a project from T288758: Introduce a new DeletePage service: Patch-For-Review.
Dec 6 2021, 1:57 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)

Dec 3 2021

Daimona updated subscribers of T294186: Global preferences opt-out checkboxes should inherit the hide-if setting of the preference.

So, we think that changing the code to use $elOrLayout.fieldWidget.wasDisabled should fix this issue. The reason is that this property is set and updated in setDeleted(), which means it keeps track of state changes, whereas the wasDeleted property set in the hide-if logic is never updated. I think this change is correct, since the two properties should in theory always have the same value, but would like to confirm that. @matmarex I see you wrote this code a few years ago. Do you by any chance remember if there was a particular reason not to use the wasDisabled property of the inner widget?

Dec 3 2021, 11:53 AM · Community-Tech (CommTech-Sprint-17), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MediaWiki-extensions-GlobalPreferences

Dec 2 2021

Daimona added a comment to T296957: Grant Access to wmf for eleoni.

I'm currently a full-time employee.

Dec 2 2021, 11:36 PM · SRE, LDAP-Access-Requests
Daimona added a comment to T295993: Grant Access to wmf for Daimona.

@Daimona I'm gonna call it 'Medium' because I _hope_ there isn't actually much difference between what the 'nda' group and the 'wmf' group give you. But if you are currently actually blocked then I would immediately up this to High and be interested what the important differences are.

Dec 2 2021, 12:21 PM · SRE, LDAP-Access-Requests

Dec 1 2021

Daimona added a comment to T295993: Grant Access to wmf for Daimona.

No problem @Daimona ! @herron could you take this and treat it like any other "add me to wmf group" request for the new account above? Thanks!

This is getting confusing. Could we please clarify the updated request info with a fresh task https://phabricator.wikimedia.org/maniphest/task/edit/form/8/

Dec 1 2021, 11:05 PM · SRE, LDAP-Access-Requests
Daimona moved T263209: Add "delete associated talk page" option to ApiDelete from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-14) board.
Dec 1 2021, 4:53 PM · Community-Tech (CommTech-Sprint-17), Patch-For-Review, Undelete-Associated-Talk-Page (2021), MediaWiki-API, Platform Engineering, MediaWiki-Page-deletion
Daimona added a comment to T295993: Grant Access to wmf for Daimona.

@Dzahn Thank you for the info; here is my work wikitech account. And apologies for the back and forth!

Dec 1 2021, 4:30 PM · SRE, LDAP-Access-Requests

Nov 30 2021

Daimona moved T290021: Create a new UndeletePage command object from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.

No new features were added, so we would like to make sure that Special:Undelete and the undelete API module are still working as expected; a few suggestions:

  • Ensure consistency when undeleting files (as opposed to articles)
  • Test behaviour when selectively restoring only some file versions and/or page revisions
  • No need to test this on pages with many deleted revisions; in fact, that will probably timeout and fail
  • Ensure that errors are displayed correctly, for instance if there are no revisions to undelete (e.g. submit the form twice)
Nov 30 2021, 11:17 AM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes, Patch-For-Review, Dependency injection, Undelete-Associated-Talk-Page (2021), MediaWiki-Page-deletion

Nov 29 2021

Daimona added a comment to T295993: Grant Access to wmf for Daimona.

As I said, if my wikimedia email needs to be in the puppet file, that's fine. I do prefer not to use my real name publicly, but I believe this particular instance to be acceptable (as in, not too public).

ITS offers the possibility to use an alias email (e.g. I have moritz@wikimedia.org which aliases to mmuhlenhoff@wikimedia.org). One option would be to simply open a ticket with ITS and let them create a daimona@wikimedia.org address for you, which is used here?

Nov 29 2021, 1:51 PM · SRE, LDAP-Access-Requests
Daimona added a comment to T295993: Grant Access to wmf for Daimona.

@Dzahn On second thought, I'd rather create a separate WMF account, since I didn't realize that my wikimedia.org email would also be used for gerrit and the cloud. I need to create a new WMF account on Wikitech, right?

Nov 29 2021, 12:28 PM · SRE, LDAP-Access-Requests

Nov 25 2021

Daimona added a comment to T295993: Grant Access to wmf for Daimona.

As I said, if my wikimedia email needs to be in the puppet file, that's fine. I do prefer not to use my real name publicly, but I believe this particular instance to be acceptable (as in, not too public).

Nov 25 2021, 1:56 AM · SRE, LDAP-Access-Requests

Nov 24 2021

Daimona added a comment to T295958: Docker: use php image with php-ast in them (73 or 74).

This means that Phan can be used in Docker, which is extremely annoying to not have, as every change has to be round-tripped though Gerrit.

Nov 24 2021, 4:11 PM · Patch-For-Review, MediaWiki-Docker

Nov 23 2021

Daimona added a comment to T275763: Deprecate public access to properties in Title.

Sure.

Nov 23 2021, 2:14 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes (1.37.0-wmf.15; 2021-07-19), User-xSavitar, MediaWiki-General, Technical-Debt
Daimona added a comment to T295993: Grant Access to wmf for Daimona.

Not as much as before. As for the email, it can be changed if necessary; otherwise, I'd rather leave my volunteer one.

Nov 23 2021, 2:14 PM · SRE, LDAP-Access-Requests
Daimona moved T284625: Live preview should respect user's language variant setting from In Development 💻 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.
Nov 23 2021, 10:25 AM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Real-Time-Preview-Wish-2021, Chinese-Sites, MediaWiki-Page-editing
Daimona moved T117549: Do not generate warning on parameter `variant` for API requests from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.
Nov 23 2021, 10:18 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Community-Tech (CommTech-Sprint-14), Platform Engineering, MediaWiki-API
Daimona added a project to T117549: Do not generate warning on parameter `variant` for API requests: Community-Tech (CommTech-Sprint-14).
Nov 23 2021, 10:09 AM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Community-Tech (CommTech-Sprint-14), Platform Engineering, MediaWiki-API
Daimona moved T288758: Introduce a new DeletePage service from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.

Ready for QA now! As a reminder, no new feature was added, so we're still in the "ensure nothing broke" phase. The suggestions at T288758#7404009 are still valid.

Nov 23 2021, 10:08 AM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona moved T288282: Build the page delete UI from DeleteAction, not Article from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.
Nov 23 2021, 10:08 AM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.37-notes, Patch-For-Review, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona moved T288759: Move the "big deletion" logic from Title to DeletePage from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-14) board.
Nov 23 2021, 10:07 AM · Community-Tech (CommTech-Sprint-15), MW-1.37-notes, MW-1.38-notes (1.38.0-wmf.1; 2021-09-21), MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona created T296280: Introduce "Event" and "Event talk" namespaces.
Nov 23 2021, 10:01 AM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration
Daimona created T296279: Create CampaignEvents extension.
Nov 23 2021, 10:00 AM · Campaign-Tools (Campaign-Tools-Sprint-5), CampaignEvents, Campaign-Registration

Nov 22 2021

Daimona added a comment to T278707: phpunit.xml.dist: Remove support for both lowercase unit and uppercase Unit directory, as it's unfriendly for case-insensitive OSes.

I can see some value in standardizing on one capitalization, but why does it have to be the lowercase one? Uppercase is better for PSR-4 (unless we want to start having lowercased namespace names, in deviation from our usual practice); does lowercase have any advantages?

Nov 22 2021, 2:05 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), User-kostajh, MediaWiki-Core-Tests, User-zeljkofilipin

Nov 21 2021

Daimona added a comment to T295993: Grant Access to wmf for Daimona.

@Daimona ACK, understood! We will just move you from nda to wmf then with the existing account. Could you change the email address on your Wikitech account (https://wikitech.wikimedia.org/wiki/Special:Preferences)? thanks!

Nov 21 2021, 6:21 PM · SRE, LDAP-Access-Requests

Nov 20 2021

Daimona added a comment to T295993: Grant Access to wmf for Daimona.

Is there a specific thing that is not currently working?

Nov 20 2021, 12:49 PM · SRE, LDAP-Access-Requests

Nov 18 2021

Daimona moved T295435: Deleting redirects in file: namespace tries to delete the redirect target, not the redirect from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-13) board.
Nov 18 2021, 6:10 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Commons, MediaWiki-Page-deletion
Daimona created T295993: Grant Access to wmf for Daimona.
Nov 18 2021, 3:58 PM · SRE, LDAP-Access-Requests

Nov 15 2021

Daimona added a comment to T288282: Build the page delete UI from DeleteAction, not Article.

This is ready for QA, but my suggestion is to test it together with T288758, once the last two patches (r730775 and r730197) are merged.

Nov 15 2021, 6:02 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.37-notes, Patch-For-Review, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona moved T288758: Introduce a new DeletePage service from QA 🐛 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-13) board.

Actually, I believe it's much better to wait for r730775 as well. The test suggestions above are still valid, I'll move this back to QA when that patch is merged.

Nov 15 2021, 6:00 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona moved T288758: Introduce a new DeletePage service from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-13) board.

@dom_walden @imaigwilo The UI part of this task can now be tested, as per my previous comment (T288758#7404009).

Nov 15 2021, 5:59 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), MW-1.37-notes, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona updated the task description for T288282: Build the page delete UI from DeleteAction, not Article.
Nov 15 2021, 5:56 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.37-notes, Patch-For-Review, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona added a comment to T295708: ConfirmEditHooks phan failure.

Similar to T293818, I guess?

Nov 15 2021, 5:39 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), phan-taint-check-plugin, ci-test-error, ConfirmEdit (CAPTCHA extension)
Daimona added a project to T290624: Use appropriate escaping level in Language::truncateForVisual: phan-taint-check-plugin.
Nov 15 2021, 5:37 PM · phan-taint-check-plugin, MediaWiki-General

Nov 12 2021

Daimona moved T292259: Disambiguation notifications: Add support for CodeMirror from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-13) board.
Nov 12 2021, 12:05 PM · Community-Tech (CommTech-Sprint-15), QTE-TestingOverview, MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MediaWiki-extensions-Disambiguator, Disambiguation-Wish-2021

Nov 10 2021

Daimona awarded T243847: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI a Party Time token.
Nov 10 2021, 7:34 PM · SRE, serviceops, Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona reopened T243847: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI as "Open".

This is actually still relevant. In particular, given T293851, it would be great to have pcov in wm apt, assuming that we're going to switch coverage jobs to PHP 7.4 at some point.

Nov 10 2021, 5:07 PM · SRE, serviceops, Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona reopened T243847: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI, a subtask of T234020: Switch mediawiki code coverage from xdebug to pcov, as Open.
Nov 10 2021, 5:07 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona moved T295435: Deleting redirects in file: namespace tries to delete the redirect target, not the redirect from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-13) board.
Nov 10 2021, 1:39 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Commons, MediaWiki-Page-deletion
Daimona claimed T295435: Deleting redirects in file: namespace tries to delete the redirect target, not the redirect.

Thanks for reporting this. Looking at the changes to DeleteAction, this was actually caused by r711477: FileDeleteAction has a check for redirect files (and also non-local and non-existing files) which triggers a normal article deletion. This is currently happening in FileDeleteAction::tempDelete by calling parent::tempDelete, but that's not enough: everything is still happening inside the FileDeleteAction instance, hence any call to a local method (i.e. $this->foo()`) will use the method in FileDeleteAction (and not DeleteAction) if it exists. r712747 does make it worse by showing the message, and r713299 does fix it by reducing inherited methods, but the underlying problem still exists and is waiting for an innocent code change to trigger similar bugs again. So I'm going to do the switch in WikiFilePage instead.

Nov 10 2021, 1:34 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Commons, MediaWiki-Page-deletion

Nov 9 2021

Daimona claimed T263211: Add "Restore associated talk page" option to special:undelete.
Nov 9 2021, 5:23 PM · Community-Tech (CommTech-Sprint-17), Undelete-Associated-Talk-Page (2021), MediaWiki-Page-deletion
Daimona claimed T290210: Add "restore associated talk page" option to ApiUndelete.
Nov 9 2021, 5:23 PM · Community-Tech (CommTech-Sprint-17), Undelete-Associated-Talk-Page (2021), MediaWiki-API, MediaWiki-Page-deletion
Daimona raised the priority of T184466: Live preview doesn’t use new versions of templates embedded in themselves from Medium to Needs Triage.

Sam and I discussed this today, here is a summary.

Nov 9 2021, 11:09 AM · Community-Tech, Platform Engineering, Real-Time-Preview-Wish-2021, MediaWiki-API, JavaScript, MediaWiki-Page-editing
Daimona added a comment to T286271: Globally set preferences no longer greyed out in local preferences.

And now I set English again and I can reproduce the bug... Nevermind. I've verified that the quick fix above is enough for the immediate problem, so I'm going to merge it. The core change with disable-if is still something that would be nice to have, but for now I want to fix the issue ASAP to try and understand how all these bug reports about GP are related.

Nov 9 2021, 10:46 AM · Community-Tech (CommTech-Sprint-17), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Regression, MediaWiki-extensions-GlobalPreferences
Daimona added a comment to T286271: Globally set preferences no longer greyed out in local preferences.

I changed the content and interface languages to italian, and now it works. The "gender" field is no longer disabled. WTF?!

Nov 9 2021, 10:38 AM · Community-Tech (CommTech-Sprint-17), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Regression, MediaWiki-extensions-GlobalPreferences
Daimona added a comment to T286271: Globally set preferences no longer greyed out in local preferences.

No, that's strange. With current master of core and GP, and no weird caching things going on? I can replicate it locally with Firefox and Chrome, every time.

Nov 9 2021, 10:36 AM · Community-Tech (CommTech-Sprint-17), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Regression, MediaWiki-extensions-GlobalPreferences
Daimona added a comment to T286271: Globally set preferences no longer greyed out in local preferences.

I can reproduce this in production, but not locally. If I set a global preference and go to Special:Preferences to set a local exception, the preference field is greyed out as expected. @Samwilson any idea about that?

Nov 9 2021, 10:17 AM · Community-Tech (CommTech-Sprint-17), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Regression, MediaWiki-extensions-GlobalPreferences

Nov 8 2021

Daimona raised the priority of T117549: Do not generate warning on parameter `variant` for API requests from Low to Needs Triage.
Nov 8 2021, 9:21 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Community-Tech (CommTech-Sprint-14), Platform Engineering, MediaWiki-API
Daimona updated the task description for T288282: Build the page delete UI from DeleteAction, not Article.
Nov 8 2021, 6:42 PM · Community-Tech (CommTech-Sprint-15), MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), MW-1.37-notes, Patch-For-Review, MediaWiki-Page-deletion, Undelete-Associated-Talk-Page (2021)
Daimona removed a project from T293898: Chrome ignores the side-locking CSS in diffs for the HTML clipboard content: Community-Tech (CommTech-Sprint-12).

We agreed that these browser-specific bugs won't be addressed in this phase. The CSS+JS solution provides basic support for copying from diffs, which is what we wanted to implement. Better support will come with T270775.

Nov 8 2021, 6:41 PM · MediaWiki-Page-diffs
Daimona removed a subtask for T287177: [EPIC] Copy and Paste from Diffs: T293898: Chrome ignores the side-locking CSS in diffs for the HTML clipboard content.
Nov 8 2021, 6:41 PM · Community-Tech (CommTech-Sprint-13), Epic
Daimona removed a parent task for T293898: Chrome ignores the side-locking CSS in diffs for the HTML clipboard content: T287177: [EPIC] Copy and Paste from Diffs.
Nov 8 2021, 6:41 PM · MediaWiki-Page-diffs
Daimona added a parent task for T270775: Arrange diffs with CSS grid layout: T293898: Chrome ignores the side-locking CSS in diffs for the HTML clipboard content.
Nov 8 2021, 6:40 PM · Patch-For-Review, MediaWiki-Page-diffs
Daimona added a subtask for T293898: Chrome ignores the side-locking CSS in diffs for the HTML clipboard content: T270775: Arrange diffs with CSS grid layout.
Nov 8 2021, 6:40 PM · MediaWiki-Page-diffs
Daimona removed projects from T294582: Don't autofocus the link target field when the user clicks on the link-inserter toolbar button and some text is selected: Disambiguation-Wish-2021, Community-Tech (CommTech-Sprint-12).

Per above.

Nov 8 2021, 6:39 PM · WikiEditor
Daimona added a subtask for T294582: Don't autofocus the link target field when the user clicks on the link-inserter toolbar button and some text is selected: T209059: Replace WikiEditor widgets with OOUI-based (VisualEditor) components.
Nov 8 2021, 6:38 PM · WikiEditor
Daimona added a parent task for T209059: Replace WikiEditor widgets with OOUI-based (VisualEditor) components: T294582: Don't autofocus the link target field when the user clicks on the link-inserter toolbar button and some text is selected.
Nov 8 2021, 6:38 PM · Design, UI-Standardization, WikiEditor
Daimona closed T295286: Release mediawiki-tools-phan 0.11.1, a subtask of T295285: Upgrade primary branch of all Wikimedia-deployed repos to a version of mediawiki-tools-phan including T270553, as Resolved.
Nov 8 2021, 4:00 PM · Continuous-Integration-Config