Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (179 w, 3 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Babel: it-N, en-3, fr-1

Recent Activity

Yesterday

Daimona added a comment to T266389: Make it easier to run integration/unit tests from IDE.

@Daimona could you provide some screenshots of your config? I have a single configuration for both types of tests although I have two different PHP interpreters since one uses my host PHP and the other (for integration) uses the docker container PHP.

Sat, Oct 24, 9:38 PM · MediaWiki-Core-Testing
Daimona closed T248743: Call BlockUser in AbuseFilterRunner.php as Resolved.
Sat, Oct 24, 9:09 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Technical-Debt, AbuseFilter
Daimona created T266389: Make it easier to run integration/unit tests from IDE.
Sat, Oct 24, 2:34 PM · MediaWiki-Core-Testing
Daimona triaged T266380: Remove ContentTranslation code that emulates AbuseFilter, because it's hard to maintain as High priority.

I can try implementing this, but I'd like to hear some opinion from the maintainers of CX. This is quite important because, as I mentioned in the task description, it forces us to keep BC code around.

Sat, Oct 24, 9:05 AM · ContentTranslation, AbuseFilter
Daimona created T266380: Remove ContentTranslation code that emulates AbuseFilter, because it's hard to maintain.
Sat, Oct 24, 8:59 AM · ContentTranslation, AbuseFilter
Daimona created T266378: Warning: ContentTranslation\PreferenceHelper::getGlobalPreference: Need GlobalPreferences extension. Not getting preference..
Sat, Oct 24, 8:40 AM · ContentTranslation

Thu, Oct 22

Daimona added a comment to T265794: Let other extensions register new actions via hooks, not config.

Since the consequences system is being refactored, it's probably a good idea to write this hook afterwards. This hook might be used as a single place to register both the extension name (currently done via $wgAbuseFilterActions) and the "callback" using the new system (e.g. by returning a value object extending Consequence as per r633380).

Thu, Oct 22, 11:25 PM · AbuseFilter
Daimona created T266297: Integration with AbuseFilter throws a fatal error while registering the extension (broken since 2016).
Thu, Oct 22, 11:22 PM · Patch-For-Review, AbuseFilter, ArticleFeedbackv5
Daimona added a comment to T255506: Identify how abuse log details were purged from the CU logs.

I've created a follow-up at T266272, you're all welcome to chime in or subscribe if you want.

Thu, Oct 22, 7:07 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), MW-1.35-notes (1.35.0-wmf.39; 2020-06-30), AbuseFilter, CheckUser
Daimona created T266272: Add a hook called after inserting AbuseLog entries.
Thu, Oct 22, 7:05 PM · AbuseFilter
Daimona moved T10327: Language::formatNum() should prefix negative values with − (minus sign U+2212) from To Triage to Not ready to announce on the User-notice board.
Thu, Oct 22, 6:57 PM · User-notice, Patch-For-Review, MediaWiki-Interface
Daimona added a project to T10327: Language::formatNum() should prefix negative values with − (minus sign U+2212): User-notice.

I believe this should be mentioned in Tech News once approved.

Thu, Oct 22, 6:57 PM · User-notice, Patch-For-Review, MediaWiki-Interface
Daimona closed T240895: The "afl_change_deleted_patrolled" database patch is not applied by onLoadExtensionSchemaUpdates. as Resolved.
Thu, Oct 22, 4:42 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), AbuseFilter (Overhaul-2020)
Daimona closed T175221: Replace and split $wgAbuseFilterRestrictions responsibility with more verbose variable names. as Resolved.
Thu, Oct 22, 4:20 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), AbuseFilter (Overhaul-2020)

Wed, Oct 21

Daimona added a comment to T27377: Update username in AbuseFilter interface when user is renamed using Renameuser.

Just came to report this, but it seems to have been done already
Can existing entries be fixed via script?

Wed, Oct 21, 6:21 PM · AbuseFilter (Overhaul-2020), MediaWiki-extensions-Renameuser, MediaWiki-extensions-CentralAuth, GlobalRename
Daimona added a comment to T243847: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI.

Memo (for myself or whoever is interested): xdebug 3 should supposedly bring massive performance improvements. Copying from the release notes for 3.0.0beta1:

Wed, Oct 21, 1:00 PM · Operations, serviceops, Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona updated the task description for T22487: useless autopromotion at every request.
Wed, Oct 21, 11:29 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Performance Issue, AbuseFilter

Tue, Oct 20

Daimona added a comment to T265994: PHP Warning: mb_stripos(): Empty delimiter.

This error doesn't cause any impact on the user, because the warning is swallowed silently, and the overall result is also correct (it's as if you didn't specify any search mode), so this is really just logspam.

Tue, Oct 20, 12:04 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter, Wikimedia-production-error
Daimona claimed T265994: PHP Warning: mb_stripos(): Empty delimiter.
Tue, Oct 20, 11:35 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter, Wikimedia-production-error

Mon, Oct 19

Daimona added a comment to T93564: Addition of last hit date to Special:AbuseFilter table.

@Daimona do we have a schema change task for that? I have not been able to find it under Blocked-on-schema-change tag (I believe you are familiar with the schema change process, but leaving this here just in case https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change)
Thanks!

Mon, Oct 19, 4:54 PM · Data-Persistence-Consultation, User-Daimona, Patch-For-Review, Stewards-and-global-tools, WMF-deploy-2015-07-21_(1.26wmf15), AbuseFilter
Daimona changed the status of T93564: Addition of last hit date to Special:AbuseFilter table from Open to Stalled.

Based on some quick experiments, using the afl_filter_id + afl_global combination instead of afl_filter doesn't really solve the problem here. The only difference is that we'd be specifying afl_global = 0 in every ON and WHERE clause, hence reducing the amount of scanned rows; on the remaining rows, the query would still be awful.

Mon, Oct 19, 4:15 PM · Data-Persistence-Consultation, User-Daimona, Patch-For-Review, Stewards-and-global-tools, WMF-deploy-2015-07-21_(1.26wmf15), AbuseFilter
Daimona added a subtask for T93564: Addition of last hit date to Special:AbuseFilter table: T220791: afl_filter should be split in afl_filter_id and afl_global.
Mon, Oct 19, 4:09 PM · Data-Persistence-Consultation, User-Daimona, Patch-For-Review, Stewards-and-global-tools, WMF-deploy-2015-07-21_(1.26wmf15), AbuseFilter
Daimona added a parent task for T220791: afl_filter should be split in afl_filter_id and afl_global: T93564: Addition of last hit date to Special:AbuseFilter table.
Mon, Oct 19, 4:09 PM · AbuseFilter (Overhaul-2020), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review
Daimona reopened T93564: Addition of last hit date to Special:AbuseFilter table as "Open".

@LSobanski I'm sorry, this wasn't meant as a Schema-change task, but rather as a feature request. The DBA part is done, so it's possible to untag if necessary, although the task itself is not resolved.

Mon, Oct 19, 4:01 PM · Data-Persistence-Consultation, User-Daimona, Patch-For-Review, Stewards-and-global-tools, WMF-deploy-2015-07-21_(1.26wmf15), AbuseFilter
Daimona added a comment to T246539: Dry-run, then actually run updateVarDumps.

Mentioned in SAL (#wikimedia-operations) [2020-10-19T11:43:34Z] <Urbanecm> End of [urbanecm@mwmaint2001 ~/updateVarDumps/script]$ while read wiki; do echo "Processing $wiki"; mwscript extensions/AbuseFilter/maintenance/updateVarDumps.php --wiki=$wiki --print-orphaned-records-to=/tmp/urbanecm/$wiki-orphaned.log --progress-markers > $wiki.log; done < ../small-group2.dblist # T246539 # small-group2.dblist is wikis from small.dblist that are also in group2.dblist

Outputs are below (two files per wiki):

Mon, Oct 19, 2:42 PM · User-Urbanecm, Platform Team Workboards (Clinic Duty Team), MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), MW-1.35-notes (1.35.0-wmf.35; 2020-06-02), Wikimedia-maintenance-script-run, AbuseFilter
Daimona closed T264513: updateVarDumps emits PHP notice due to bad serialized data as Resolved.
Mon, Oct 19, 11:46 AM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter

Sun, Oct 18

Daimona edited P13021 (An Untitled Masterwork).
Sun, Oct 18, 1:16 PM
Daimona created P13021 (An Untitled Masterwork).
Sun, Oct 18, 1:01 PM

Sat, Oct 17

Daimona placed T24623: do not set throttle on warn action up for grabs.

I've removed this part from the patch above, because this is not a straightforward change and it needs more discussion. Nonetheless, I'm still going to refactor the logic for handling consequences, so this will turn out to be a technically-easy change.

Sat, Oct 17, 2:04 PM · AbuseFilter
Daimona created T265794: Let other extensions register new actions via hooks, not config.
Sat, Oct 17, 12:23 PM · AbuseFilter
Daimona created T265792: Moves over redirects are not atomic.
Sat, Oct 17, 11:31 AM · MediaWiki-Page-rename
Daimona added a comment to T265779: Fatal MWException when trying to rename a page.

It is not possible to return the Status to the caller

Sat, Oct 17, 11:31 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error
Daimona edited projects for T265779: Fatal MWException when trying to rename a page, added: MediaWiki-Page-rename; removed AbuseFilter.

Seems like an AbuseFilter problem:
Of course, it should be shown as a normal error, not as an exception.

It does not seem to be AbuseFilter fault. AbuseFilter uses ArticleDeleteHook to filter deletion action (in this case). It founds the deletion should be disallowed (as configured) and the hook requires boolean return value to decide on whether to proceed with the deletion or not. So it's obvious, the only option for AbuseFilter is to return false to abort the deletion. It also sets the correct error message by modifying the supplied error variable in the hook. That's all it could do.

So the problem lies in MovePage, with its logic that if target page deletion fails, then exception will follow

MovePage.php
$status = $newpage->doDeleteArticleReal(...)
if ( !$status->isGood() ) {
     throw new MWException( 
     'Failed to delete page-move revision: ' . $status->getWikiText( false, false, 'en' )  );
}
Sat, Oct 17, 10:31 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Platform Team Workboards (External Code Reviews), MediaWiki-Page-rename, Wikimedia-production-error

Thu, Oct 15

Daimona added a comment to T265657: Link text of the Wikipedia sidebar menu bigger than normal.

Another report on itwiki, apparently it did fix itself after purging the page.

Thu, Oct 15, 9:24 PM · Vector
Daimona closed T174000: Log entries for global filter hits are broken if wiki goes beyond their range as Resolved.
Thu, Oct 15, 4:26 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter (Overhaul-2020)
Daimona added a comment to T265563: Special:AbuseLog search by user missing some entries.

Not a regression, this has always worked like this. The accounts are being created by IPs, and we hack around it by assigning the entry to a fake user with the specified account name. This is already problematic, and we should fix the root cause, rather than hacking SpecialAbuseLog.

Thu, Oct 15, 9:18 AM · Stewards-and-global-tools, AbuseFilter
Daimona merged T265563: Special:AbuseLog search by user missing some entries into T235926: The Special:AbuseLog search function does not return or display "createaccount" or "autocreateaccount" edit filter logs when filtering by username.
Thu, Oct 15, 9:18 AM · AbuseFilter
Daimona merged task T265563: Special:AbuseLog search by user missing some entries into T235926: The Special:AbuseLog search function does not return or display "createaccount" or "autocreateaccount" edit filter logs when filtering by username.
Thu, Oct 15, 9:17 AM · Stewards-and-global-tools, AbuseFilter
Daimona added a comment to T201193: Code coverage is low in AbuseFilter.

This is still failing randomly, it seems https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/63833/console It did pass on a recheck. Just letting you know :)

Thu, Oct 15, 9:16 AM · Patch-Needs-Improvement, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), AbuseFilter (Overhaul-2020), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), User-Huji, Test-Coverage

Wed, Oct 14

Daimona closed T231962: Abusefilter modify layout is broken on zhwiki as Resolved.
Wed, Oct 14, 3:50 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter (Overhaul-2020), Chinese-Sites

Tue, Oct 13

Daimona claimed T265370: Investigate improving the tagging code.
Tue, Oct 13, 4:08 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), AbuseFilter
Daimona created T265370: Investigate improving the tagging code.
Tue, Oct 13, 4:00 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), AbuseFilter
Daimona triaged T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage as High priority.

I'm seeing this error more and more, e.g. today on r629233. I'm unsure about the status for other gated extensions, but it's quite annoying. Could someone please take a look?

Tue, Oct 13, 10:40 AM · Wikidata, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-WikibaseClient

Mon, Oct 12

DannyS712 awarded T265298: Provide a public method for logging user rights changes a Like token.
Mon, Oct 12, 6:54 PM · Platform Engineering, Technical-Debt, MediaWiki-User-management
Daimona created T265298: Provide a public method for logging user rights changes.
Mon, Oct 12, 6:10 PM · Platform Engineering, Technical-Debt, MediaWiki-User-management
Daimona added a comment to T263024: Make rmspecials preserve whitespace.

@Daimona we should follow the steps mentioned in T191978. Steps 1 and 2 are done (we know filters must be updated, and we have queries requested and done). Step 3 is to ask the local communities to edit their filters. If a community member acknowledges that they will take this one, we're done. If that person forgets to do so, it's on the community, not us. What should do, however, is step 4 (clearly document what needs to be changed).

Mon, Oct 12, 5:11 PM · User-notice, AbuseFilter (Overhaul-2020)
Daimona added a comment to T264948: Prohibit use of 'object' as type in docblocks.

it highly depends on what a "correct usage" is.

My argument is that object is never wrong.

Hm, I guess this is the same for most, if not all other sniffs. For example, missing documentation doesn't make the code wrong – still we have a sniff that complains about it.

Mon, Oct 12, 4:10 PM · Patch-For-Review, MediaWiki-Codesniffer
Daimona added a comment to T263024: Make rmspecials preserve whitespace.

Belatedly: while option 1 might turn out to be a painful migration (mostly because of T213037), I do agree that it's the best option. Perhaps we might first notice the communities of the upcoming change, and give them some mean to exclude certain filters from the list. This might be done either here on phabricator (e.g. by editing a table in the task description), or on-wiki (e.g. writing something in the notes of the filter).

Mon, Oct 12, 3:59 PM · User-notice, AbuseFilter (Overhaul-2020)
Daimona created T265287: Stop using <big> tags for bigger text in tooltips.
Mon, Oct 12, 2:03 PM · VisualEditor
Daimona claimed T265216: What to do when throttling is enabled but there's no main cache?.
Mon, Oct 12, 11:59 AM · Patch-For-Review, AbuseFilter
Daimona claimed T265224: Avoid using VariableHolder objects to process and undo the 'degroup' action.
Mon, Oct 12, 11:56 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-Daimona, AbuseFilter
Daimona added a comment to T265224: Avoid using VariableHolder objects to process and undo the 'degroup' action.

And avoiding vars is also not trivial. The first solution that comes to mind is to query logging by checking log_timestamp (accounting for a little error), but the query is going to execute horribly. We also couldn't be 100% sure of the results. Instead, I'd propose a different approach (for the long-term; the short-term solution is to keep the dependency on VariableHolder).

Mon, Oct 12, 11:15 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-Daimona, AbuseFilter

Sun, Oct 11

Daimona added a comment to T265224: Avoid using VariableHolder objects to process and undo the 'degroup' action.

The second one can be resolved by simply adding a new method to core's UserGroupManager, that would take an array of groups and add all of them. ::addUserToGroup would just call that method with a single-element array.

Sun, Oct 11, 10:29 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-Daimona, AbuseFilter
Daimona created T265224: Avoid using VariableHolder objects to process and undo the 'degroup' action.
Sun, Oct 11, 10:15 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-Daimona, AbuseFilter
Daimona claimed T248743: Call BlockUser in AbuseFilterRunner.php.
Sun, Oct 11, 9:41 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), Technical-Debt, AbuseFilter
Daimona created T265216: What to do when throttling is enabled but there's no main cache?.
Sun, Oct 11, 6:24 PM · Patch-For-Review, AbuseFilter

Sat, Oct 10

Daimona added a comment to T265189: Fix indices on abuse_filter_history.

I think it might be a good idea to do T188180 first, then see what's left.

Sat, Oct 10, 11:40 AM · Schema-change, AbuseFilter

Fri, Oct 9

Daimona added a comment to T264948: Prohibit use of 'object' as type in docblocks.

I realized I misunderstood this task. This is not about disallowing object as a strict type hint in code, but only about PHPDoc blocks. This makes a lot of what I said before invalid. I'm sorry for the confusion.

Fri, Oct 9, 4:38 PM · Patch-For-Review, MediaWiki-Codesniffer
Daimona added a comment to T264948: Prohibit use of 'object' as type in docblocks.

To be honest I can't fully follow the arguments given in the task description. I have seen examples like the mentioned TypeA|TypeB several times, even wrote them myself.

Fri, Oct 9, 10:55 AM · Patch-For-Review, MediaWiki-Codesniffer

Thu, Oct 8

Daimona added a comment to T264948: Prohibit use of 'object' as type in docblocks.

Sounds good, I would also say that autofix seems bad here, because it is not always clear that object and stdClass are the same here

Thu, Oct 8, 9:16 PM · Patch-For-Review, MediaWiki-Codesniffer

Wed, Oct 7

Daimona claimed T264930: Add phan annotations to ObjectFactory.
Wed, Oct 7, 9:41 PM · Patch-For-Review, phan, ObjectFactory
Daimona added a comment to T264930: Add phan annotations to ObjectFactory.

It should be possible to use the template type from within a @phan-param with explicit array type.

Wed, Oct 7, 9:22 PM · Patch-For-Review, phan, ObjectFactory
Daimona created T264948: Prohibit use of 'object' as type in docblocks.
Wed, Oct 7, 9:11 PM · Patch-For-Review, MediaWiki-Codesniffer
Mainframe98 awarded T264930: Add phan annotations to ObjectFactory a Like token.
Wed, Oct 7, 8:03 PM · Patch-For-Review, phan, ObjectFactory
Daimona created T264930: Add phan annotations to ObjectFactory.
Wed, Oct 7, 7:01 PM · Patch-For-Review, phan, ObjectFactory
Daimona created T264841: Flaky selenium test: WikibaseReferenceOnProtectedPage.
Wed, Oct 7, 8:13 AM · Wikidata, ci-test-error (WMF-deployed Build Failure), MediaWiki-extensions-WikibaseClient

Tue, Oct 6

Daimona closed T262063: Use triple equals in abuse filter parser tests as Resolved.
Tue, Oct 6, 6:06 PM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-Huji, AbuseFilter
DannyS712 awarded T220764: Expose more detailed diff information to the AbuseFilter a Like token.
Tue, Oct 6, 5:59 PM · AbuseFilter (Overhaul-2020), Patch-For-Review
Daimona added a comment to T264562: old_wikitext and new_wikitext are computed differently for MassMessageListContent.

P.S. What you're looking for is something like T220764

Tue, Oct 6, 5:54 PM · MassMessage, AbuseFilter, User-DannyS712
Daimona added a comment to T264562: old_wikitext and new_wikitext are computed differently for MassMessageListContent.

added_lines is not meant to represent "everything that was added", although this is a common misconception (and the dual is true for removed_lines). There's plenty of situations where some text (e.g. a paragraph) can appear in added_lines without being really added. What added_lines represent is just "the RHS of a diff", aka a shorter version of new_wikitext.

What were you trying to use to detect the addition assuming that new_wikitext would have been pretty-printed?

In this case, there were false positives on an antispam filter (https://meta.wikimedia.org/w/index.php?title=Special:AbuseLog&wpSearchUser=1.136.110.229) when someone was trying to remove an entry from a mass message list, because the remaining text included the problematic phrase and the abuse filter thought that all of the text was newly added

Tue, Oct 6, 5:52 PM · MassMessage, AbuseFilter, User-DannyS712
Daimona added a comment to T264562: old_wikitext and new_wikitext are computed differently for MassMessageListContent.

added_lines is not meant to represent "everything that was added", although this is a common misconception (and the dual is true for removed_lines). There's plenty of situations where some text (e.g. a paragraph) can appear in added_lines without being really added. What added_lines represent is just "the RHS of a diff", aka a shorter version of new_wikitext.

Tue, Oct 6, 5:19 PM · MassMessage, AbuseFilter, User-DannyS712
Daimona changed the status of T264768: Avoid dangerous AbuseFilter edits from Open to Stalled.

The property of being a "dangerous" filter is undecidable due to Rice's theorem (I believe), so there's no way we can fully implement this. We might add some common checks (e.g. for regexps matching the empty string), but that wouldn't be complete. And even then, disallowing the edit is out of question. We should only show a warning to the user, but that's blocked on T187686, which seems non-trivial.

Tue, Oct 6, 5:09 PM · AbuseFilter
Daimona added a comment to T264766: Allow mentors to protect their talk page from non-mentees.

@Daimona Please correct me if it's possible to add a variable that doesn't show in the examine outputs.

Tue, Oct 6, 5:06 PM · AbuseFilter, GrowthExperiments-MentorshipModule, Growth-Team
Daimona added a comment to T264562: old_wikitext and new_wikitext are computed differently for MassMessageListContent.

In that case, how can we detect the addition or removal of entries from mass message lists without treating every edit as a complete replacement of the content?

Tue, Oct 6, 5:00 PM · MassMessage, AbuseFilter, User-DannyS712
Daimona added a comment to T264562: old_wikitext and new_wikitext are computed differently for MassMessageListContent.

Thinking about this again, I don't think this is going to be fixed. new_wikitext is meant to represent raw text, i.e. no PST. This is what allows you to create filters like added_lines contains '~~~~' etc. In lack of a better solution, this should probably be closed as invalid.

Tue, Oct 6, 1:12 PM · MassMessage, AbuseFilter, User-DannyS712
Daimona updated subscribers of T264104: Checkup code claiming that we can share a parse operation with the ongoing edit.

@daniel Adding another question: as part of T198651, we'd like to unconditionally apply a PST to every edit before filtering it, so we can tell whether it's a null edit. Is there any precaution we should take in doing so to reduce the performance impact?

Tue, Oct 6, 1:10 PM · Platform Team Workboards (Clinic Duty Team), User-Daimona, AbuseFilter
Daimona closed T252181: Importing abuse filter fails as invalid as Resolved.
Tue, Oct 6, 10:59 AM · MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), User-DannyS712, AbuseFilter

Mon, Oct 5

Daimona added a comment to T264562: old_wikitext and new_wikitext are computed differently for MassMessageListContent.

Is one of those variables not going through PST?

Mon, Oct 5, 9:51 PM · MassMessage, AbuseFilter, User-DannyS712
Huji awarded T264629: Use independent stats for emergency disable a Like token.
Mon, Oct 5, 6:11 PM · AbuseFilter
Daimona closed T264622: $wgAbuseFilterEmergencyDisableThreshold is ignored as Invalid.

There you go, the stats were reset and the filter was throttled. Likely some caching issue. T264629 could help, probably.

Mon, Oct 5, 3:07 PM · AbuseFilter
Daimona created T264629: Use independent stats for emergency disable.
Mon, Oct 5, 3:07 PM · AbuseFilter
Daimona added a comment to T264622: $wgAbuseFilterEmergencyDisableThreshold is ignored.

Thanks, I had already seen this (as as I get notifications for all AbuseFilter tasks). Actions are ininfluent here, the filter should be throttled all the same (even if it has no impact). I think this might just be some caching issue/edge case, but will investigate later.

Mon, Oct 5, 2:52 PM · AbuseFilter

Sun, Oct 4

Daimona added a comment to T264513: updateVarDumps emits PHP notice due to bad serialized data.

I would like to know if this could potentially introduce database corruption down the line, however.

Sun, Oct 4, 4:52 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter
Daimona closed T262903: /test and /examine do not work with page creations as Resolved.
Sun, Oct 4, 1:42 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), AbuseFilter (Overhaul-2020)
Daimona claimed T263627: Found two elemens with id #wpEditToken on Special:AbuseFilter/revert.
Sun, Oct 4, 12:40 PM · Patch-For-Review, AbuseFilter

Sat, Oct 3

Daimona claimed T264513: updateVarDumps emits PHP notice due to bad serialized data.
Sat, Oct 3, 11:25 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter
Daimona updated the task description for T264513: updateVarDumps emits PHP notice due to bad serialized data.
Sat, Oct 3, 11:15 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter
Daimona added a project to T237336: non-commutativity of short-circuiting operations due to truthy/falsy values: User-Daimona.
Sat, Oct 3, 10:25 PM · User-Daimona, AbuseFilter
Daimona added a comment to T237336: non-commutativity of short-circuiting operations due to truthy/falsy values.

Looking at this again, I'm for the "return a boolean" option. This seems more predictable, and possibly more useful (or at least what people might expect) in the context of abuse filters. I guess the change itself wouldn't be super-hard, the problem here is understanding what filters would be affected by this change, and I don't think this is really doable...

Sat, Oct 3, 10:25 PM · User-Daimona, AbuseFilter
Daimona added a comment to T264513: updateVarDumps emits PHP notice due to bad serialized data.

Redacted dump:

Sat, Oct 3, 10:24 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter
Daimona triaged T264513: updateVarDumps emits PHP notice due to bad serialized data as High priority.
Sat, Oct 3, 10:08 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter
Daimona created T264513: updateVarDumps emits PHP notice due to bad serialized data.
Sat, Oct 3, 10:08 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), AbuseFilter
Daimona updated the task description for T237336: non-commutativity of short-circuiting operations due to truthy/falsy values.
Sat, Oct 3, 10:02 PM · User-Daimona, AbuseFilter
Daimona updated the task description for T237336: non-commutativity of short-circuiting operations due to truthy/falsy values.
Sat, Oct 3, 9:57 PM · User-Daimona, AbuseFilter
Daimona created T264495: Cannot add patchset description for others' changes.
Sat, Oct 3, 10:55 AM · Upstream, Gerrit
Daimona created T264493: Use HTMLSelectOrOtherField for warn and disallow messages.
Sat, Oct 3, 9:54 AM · AbuseFilter

Fri, Oct 2

Daimona added a comment to T263024: Make rmspecials preserve whitespace.

@Daimona quick question: does ccnorm remove extra spaces?

Fri, Oct 2, 6:08 PM · User-notice, AbuseFilter (Overhaul-2020)

Thu, Oct 1

Daimona added a comment to T264363: Instances of User are not serializable!.

FTR, we also have different traces on logstash:

Thu, Oct 1, 11:31 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error
Daimona added a comment to T264363: Instances of User are not serializable!.
ProofreadPage\Page\PageContent
/**
	 * @param WikitextContent $header
	 * @param WikitextContent $body
	 * @param WikitextContent $footer
	 * @param PageLevel $level <--------------
	 */
	public function __construct(
		WikitextContent $header, WikitextContent $body, WikitextContent $footer, PageLevel $level
	) {
Thu, Oct 1, 11:02 PM · MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), Platform Engineering, MediaWiki-User-management, Wikimedia-production-error

Wed, Sep 30

Daimona added a comment to T201193: Code coverage is low in AbuseFilter.

Hmm, it's not the first time I see it, but it always passes locally. Given what the test does, my guess is, it tries clicking the "submit" button before it works. This is not 100% convincing because the button is not JS-enriched etc., but perhaps it's worth trying. As anticipated, I cannot tell whether the fix will work because I don't get a failure locally (not even if I delay the page load).

Wed, Sep 30, 10:53 PM · Patch-Needs-Improvement, MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), AbuseFilter (Overhaul-2020), MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), MW-1.34-notes (1.34.0-wmf.7; 2019-05-28), MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), User-Huji, Test-Coverage