Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (149 w, 6 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Babel: it-N, en-3, fr-1

Recent Activity

Today

Daimona reopened T243847: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI, a subtask of T234020: Switch mediawiki code coverage from xdebug to phpdbg or pcov, as Open.
Wed, Apr 1, 6:19 PM · Patch-For-Review, Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona reopened T243847: Add pcov PHP extension to wikimedia apt so it can be used in Wikimedia CI as "Open".

The incentive was to benefit from speed improvement. We got Xdebug main slowness identified and solved T234418.

Wed, Apr 1, 6:19 PM · serviceops, Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona awarded T244031: Broken video on commons for cyclical dependencies talk a Love token.
Wed, Apr 1, 11:06 AM · Code-Health-Group, Code-Health

Yesterday

Daimona added a comment to T245231: Factor username logic out of the User class.

Heh, depending on the main RequestContext isn't ideal... We could perhaps use an anonymous class implementing MessageLocalizer and proxying the call to wfMessage. And maybe do that conditionally, only when the main context isn't available. This, together with the fact that we only need to use the content language for the message, might be enough to fix (haven't tested).

Tue, Mar 31, 11:40 AM · Core Platform Team Workboards (Clinic Duty Team), User-DannyS712, MediaWiki-General

Mon, Mar 30

Daimona committed rEMMAcefb6a9d9a57: Unbreak tests (authored by Daimona).
Unbreak tests
Mon, Mar 30, 3:41 PM

Sat, Mar 28

Daimona added a comment to T216348: Suppress or fix non-double escape phan-taint-check warnings for MW core.

Latest result with taint-check 3.0.1 (excluding roughly 120 DoubleEscaped warnings):

Sat, Mar 28, 5:46 PM · MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), Patch-For-Review, Security-Team, MediaWiki-Core-Testing, phan-taint-check-plugin
Daimona added a comment to T248743: Call SpecialBlock::processForm in AbuseFilterRunner.php.

I don't disagree that it probably should live somewhere else, but that's probably more in scope for something like T221075: Introduce a BlockStore service (or another block refactoring type task), rather than here :)

Sat, Mar 28, 5:38 PM · Patch-For-Review, User-Urbanecm, AbuseFilter
Daimona added a project to T239990: Deprecate and then remove the old AbuseFilterParser: MW-1.35-release.
Sat, Mar 28, 4:17 PM · MW-1.35-release, User-Daimona, Patch-For-Review, AbuseFilter
Daimona added a project to T230256: Some abuse filters stopped matching after empty data introduction: MW-1.35-release.
Sat, Mar 28, 3:21 PM · MW-1.35-release, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, User-notice, AbuseFilter
Daimona added a comment to T248743: Call SpecialBlock::processForm in AbuseFilterRunner.php.

Personally, I just wasn't aware of that method. I can't tell whether it could break anything though.

Sat, Mar 28, 2:41 PM · Patch-For-Review, User-Urbanecm, AbuseFilter
Daimona added a comment to T248742: Weird interaction between phan and taint-check: PhanUndeclaredVariable.

Fortunately this was an easy fix. The code analyzing property access (e.g. $foo->bar) has a special case for when $foo is a stdClass: in this case, accessing a $foo->bar would transfer foo's taintedness to bar. However, the code doing that didn't check whether the LHS of -> is a variable, hence it tried to parse a variable from the LHS even in cases like Foo::myFunc( 'myParam' )->bar. In turn, this would create a bogus variable named $Foo which phan wouldn't recognize.

Sat, Mar 28, 2:31 PM · Patch-For-Review, phan, phan-taint-check-plugin
Daimona created T248742: Weird interaction between phan and taint-check: PhanUndeclaredVariable.
Sat, Mar 28, 2:13 PM · Patch-For-Review, phan, phan-taint-check-plugin
Daimona claimed T240895: The "afl_change_deleted_patrolled" database patch is not applied by onLoadExtensionSchemaUpdates..

I'll make sure to prepare the (painful) backports for 1.33 and 1.34 as well, once the patch is reviewed/approved/merged on master.

Sat, Mar 28, 1:12 PM · Patch-For-Review, AbuseFilter

Fri, Mar 27

Daimona triaged T240895: The "afl_change_deleted_patrolled" database patch is not applied by onLoadExtensionSchemaUpdates. as High priority.

Also reported at https://www.mediawiki.org/wiki/Topic:Vjdi1tkxzyyl9wbj

Fri, Mar 27, 3:06 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T248630: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin.

Meh, it's taint-check messing up with phan. I'll take a look tomorrowish... Also:

Fri, Mar 27, 12:00 AM · Continuous-Integration-Config, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Patch-For-Review, phan-taint-check-plugin, phan, LibUp

Thu, Mar 26

Daimona added a comment to T248630: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin.

Ouch: https://integration.wikimedia.org/ci/job/mwext-php72-phan-docker/43938/console some are weird:

Thu, Mar 26, 11:54 PM · Continuous-Integration-Config, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Patch-For-Review, phan-taint-check-plugin, phan, LibUp
Daimona renamed T248630: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin from Upgrade phan to 0.10.0 and remove phan-taint-check-plugin to Upgrade phan to 0.10.1 and remove phan-taint-check-plugin.
Thu, Mar 26, 11:33 PM · Continuous-Integration-Config, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Patch-For-Review, phan-taint-check-plugin, phan, LibUp
Daimona closed T235390: Merge taint-check-plugin into mediawiki-phan-config as Resolved.

Closing in favour of T248630 for the remaining part.

Thu, Mar 26, 11:01 PM · Patch-For-Review, phan, phan-taint-check-plugin
Krinkle awarded T235390: Merge taint-check-plugin into mediawiki-phan-config a Orange Medal token.
Thu, Mar 26, 10:51 PM · Patch-For-Review, phan, phan-taint-check-plugin
Daimona created T248630: Upgrade phan to 0.10.1 and remove phan-taint-check-plugin.
Thu, Mar 26, 9:43 PM · Continuous-Integration-Config, Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Patch-For-Review, phan-taint-check-plugin, phan, LibUp
Daimona committed rMTPS1b4d4ef52406: Upgrade phan to latest version (authored by Daimona).
Upgrade phan to latest version
Thu, Mar 26, 6:28 PM
Daimona committed rMTPS309490061ba6: Fix phan crash when analyzing MediaWiki core (authored by Daimona).
Fix phan crash when analyzing MediaWiki core
Thu, Mar 26, 6:28 PM
Daimona committed rMTPS4a25f855b661: Remove outdated config settings (authored by Daimona).
Remove outdated config settings
Thu, Mar 26, 6:28 PM
Daimona updated the task description for T235390: Merge taint-check-plugin into mediawiki-phan-config.
Thu, Mar 26, 5:11 PM · Patch-For-Review, phan, phan-taint-check-plugin
Daimona updated the task description for T235390: Merge taint-check-plugin into mediawiki-phan-config.
Thu, Mar 26, 5:10 PM · Patch-For-Review, phan, phan-taint-check-plugin
Daimona closed T240069: Release taint-check 3.0.1, a subtask of T235390: Merge taint-check-plugin into mediawiki-phan-config, as Resolved.
Thu, Mar 26, 4:56 PM · Patch-For-Review, phan, phan-taint-check-plugin
Daimona closed T240069: Release taint-check 3.0.1 as Resolved.

Aaaand {{Done}}.

Thu, Mar 26, 4:56 PM · phan-taint-check-plugin
Daimona closed T235383: Release taint-check 3.0.0, a subtask of T240069: Release taint-check 3.0.1, as Resolved.
Thu, Mar 26, 4:47 PM · phan-taint-check-plugin
Daimona closed T235383: Release taint-check 3.0.0 as Resolved.

{{Done}}!

Thu, Mar 26, 4:47 PM · phan-taint-check-plugin
Daimona added a comment to T235383: Release taint-check 3.0.0.

Good to go?

Thu, Mar 26, 4:35 PM · phan-taint-check-plugin
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Thu, Mar 26, 4:29 PM · phan-taint-check-plugin
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Thu, Mar 26, 4:28 PM · phan-taint-check-plugin
Daimona closed T203344: phan-taint-check should warn about unnecessary @suppress tags as Resolved.
Thu, Mar 26, 4:27 PM · phan-taint-check-plugin
Daimona added a comment to T246733: AbuseFilter needs uses of global $wgUser removed.

To move us one step closer to removing reads from $wgUser

Thu, Mar 26, 3:18 PM · Patch-For-Review, AbuseFilter, User-DannyS712, Technical-Debt
Daimona added a comment to T248438: redundant_condition_detection is still suppressed.

https://github.com/phan/phan/issues/2943 appears to have been resolved with https://github.com/phan/phan/pull/3176 in September 2019;

Thu, Mar 26, 2:08 PM · User-DannyS712, MediaWiki-General, phan
Daimona added a comment to T248360: Phan warning in "includes/specials/SpecialMobileDiff.php" - working around by disabling.

See also T183174. I haven't checked whether that issue is now fixed.

Thu, Mar 26, 2:04 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), Patch-For-Review, Readers-Web-Backlog (Kanbanana-2019-20-Q3), Security-Team, Security, phan-taint-check-plugin
Daimona added a comment to T246991: Apparently incorrect throttler count for a specific user.

Yeah, well, I think this could've been caused either by MW not setting the right expiry, or memcached not evicting the key.

Thu, Mar 26, 2:03 PM · MediaWiki-Cache, Security-Team, MediaWiki-User-management
Daimona added a comment to T248306: CI error on WMF branches: Cannot use the final modifier on an abstract class in vendor/microsoft/tolerant-php-parser/tests/cases/parser/abstractMethodDeclaration7.php on line 3.

So, things to consider here:

  1. The issue comes from taint-check, not phan itself. Hence, the mediawiki-tools-phan repo isn't playing any role here.
    1. Specifically, https://github.com/wikimedia/mediawiki-tools-phan/blob/master/src/config.php is NOT the file used by taint-check
  2. Taint-check runs in its own CI job, separated from the main phan job. It also uses a different version of phan (latest stable uses phan 1.3.2
  3. Phan 1.3.2 does have tests marked as export-ignore, but somehow that isn't working (?)
  4. Taint-check also uses its own config file, which does NOT exclude test files
  5. Additionally, PHP 7.2 is bugged, in that it throws a fatal ("Cannot use the final modifier on an abstract class") when tokenizing invalid code, even if that code isn't going to be executed. See phan issue #3407 and linked PHP bug report.
Thu, Mar 26, 12:46 PM · Release-Engineering-Team, phan-taint-check-plugin, ci-test-error, MediaWiki-Vendor, Continuous-Integration-Config
Daimona changed the status of T246539: Dry-run, then actually run updateVarDumps, a subtask of T213006: Create a script to update afl_var_dump, drop back-compat code, from Stalled to Open.
Thu, Mar 26, 12:33 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Core Platform Team Workboards (Clinic Duty Team), Technical-Debt, Patch-For-Review, User-Daimona, AbuseFilter
Daimona changed the status of T246539: Dry-run, then actually run updateVarDumps from Stalled to Open.
Thu, Mar 26, 12:33 PM · MW-1.35-release, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Wikimedia-maintenance-script-run, AbuseFilter
Daimona added a project to T246539: Dry-run, then actually run updateVarDumps: MW-1.35-release.

Tagging for 1.35, ideally we should get the script working and added to update.php before the release. Running the script on WMF wikis is not included per se, but de facto that's how we're gonna see if the script is bug-free.

Thu, Mar 26, 12:33 PM · MW-1.35-release, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Wikimedia-maintenance-script-run, AbuseFilter
Daimona added a comment to T246733: AbuseFilter needs uses of global $wgUser removed.

Yeah thanks. That's not going to happen before MW 1.36 though.

Would it be possible to use RequestContext::getMain()->getUser() while waiting for the abuse filter blockers to be clear?

Thu, Mar 26, 12:32 PM · Patch-For-Review, AbuseFilter, User-DannyS712, Technical-Debt

Sat, Mar 21

Daimona added a comment to T218074: ip_in_range should accept explicit range notation.

The test contains: ip_in_range( '1.1.1.1', '0.0.0.0/0' ), which fails due to the range not being accepted.

Sat, Mar 21, 11:07 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), IPUtils, Patch-For-Review, User-Daimona, AbuseFilter

Fri, Mar 20

Daimona added a comment to T248078: Fix all functions that have required parameters following optional ones.

FTR, note that phan already checks for this. However, many extensions don't run phan (and it's also never executed on tests), so it's a good idea to have a PHPCS sniff for this.

Fri, Mar 20, 6:06 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), MW-1.35-release, MediaWiki-Codesniffer, Technical-Debt, MediaWiki-General, PHP 8.0 support
DannyS712 awarded T245658: .mp4 build artifacts not viewable due to CSP in Chrome a Burninate token.
Fri, Mar 20, 5:51 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Patch-For-Review, Developer Productivity, ContentSecurityPolicy, Release-Engineering-Team (CI & Testing services), Jenkins, Continuous-Integration-Infrastructure
Daimona added a subtask for T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min: T234020: Switch mediawiki code coverage from xdebug to phpdbg or pcov.
Fri, Mar 20, 2:06 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Patch-For-Review, Developer Productivity, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config
Daimona added a parent task for T234020: Switch mediawiki code coverage from xdebug to phpdbg or pcov: T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.
Fri, Mar 20, 2:06 PM · Patch-For-Review, Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona claimed T248113: MultiMaps extension failing with Call to private Title::__construct() from context 'MultiMaps\BaseMapElement' \ 'MultiMaps\LeafletTest'.
Fri, Mar 20, 2:01 PM · ci-test-error, MediaWiki-extensions-MultiMaps

Thu, Mar 19

Daimona added a comment to T244095: assertArraySubset() will be removed in PHPUnit 9.

Is anyone working on this atm?

Thu, Mar 19, 10:04 AM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), Patch-For-Review, MediaWiki-extensions-DonationInterface, Reading List Service, Product-Infrastructure-Team-Backlog, PageCuration, Growth-Team, MediaWiki-Core-Testing

Wed, Mar 18

Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Wed, Mar 18, 4:44 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Wed, Mar 18, 4:32 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona added a comment to T247864: AbuseFilter overhaul.

@eprodromou Is the CPT willing to participate as advisor, or is this task just for info/tracking?

Wed, Mar 18, 3:08 PM · AbuseFilter, Core Platform Team Workboards (Initiatives)

Tue, Mar 17

Daimona added a comment to T247806: Make WikibaseLexeme compatible with PHP 7.4.

Not because of PHP 7.4 :-[

Tue, Mar 17, 9:05 AM · Lexicographical data, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), PHP 7.4 support, Wikidata
Daimona merged T247806: Make WikibaseLexeme compatible with PHP 7.4 into T247782: WikibaseLexeme CI broken due to Title constructor being private.
Tue, Mar 17, 9:05 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Wikidata, Lexicographical data
Daimona merged task T247806: Make WikibaseLexeme compatible with PHP 7.4 into T247782: WikibaseLexeme CI broken due to Title constructor being private.
Tue, Mar 17, 9:05 AM · Lexicographical data, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), PHP 7.4 support, Wikidata

Mon, Mar 16

Daimona added a comment to T247782: WikibaseLexeme CI broken due to Title constructor being private.

Meh, I thought these test-only errors would have been spotted by the wmf-gate jobs. Sorry for the breakage :(

Mon, Mar 16, 7:38 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Wikidata, Lexicographical data
Daimona added a comment to T247190: Complete TitleFactory to be a real factory service.

Direct calls to Title's constructor were never properly supported and should indeed be replaced throughout the code base. They should be rare anyway.

Mon, Mar 16, 10:19 AM · Dependency injection, Patch-For-Review, MediaWiki-General, Core Platform Team

Sat, Mar 14

Daimona added a comment to T247670: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase).

It doesn't seem a recent regression, see https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+blame/de5e309c258b121bf0626728d8d9a6fd2ab0c717/client/tests/phpunit/includes/ClientParserOutputDataUpdaterTest.php#170

Sat, Mar 14, 6:34 PM · Wikidata, Wikidata-Campsite, MediaWiki-extensions-WikibaseClient, Developer Productivity
Daimona added a comment to T247595: Make Wikibase compatible with PHP 7.4.

Now it should be compatible. Can we enable PHP74 tests as voting?

Sat, Mar 14, 2:13 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Wikidata, PHP 7.4 support
Daimona added a comment to T247190: Complete TitleFactory to be a real factory service.

The question is, will Title be around long enough for this to be worth the effort?

Sat, Mar 14, 12:07 PM · Dependency injection, Patch-For-Review, MediaWiki-General, Core Platform Team
Daimona committed rEPSb08a95aed171: Fix PHPUnit 8 deprecation warnings (authored by Daimona).
Fix PHPUnit 8 deprecation warnings
Sat, Mar 14, 11:37 AM
Daimona added a comment to T247173: Hide "User:" prefix from the "Autopromote block" and "Autopromote restore" logs.

I think this shouldn't be too hard. The DB rows is storing NS and text separately, so it's just a matter of choosing the right method to build the link. Since the AbuseFilterRightsLogFormatter doesn't handle links, it should probably reimplement some parent's method to do that (I haven't checked which one).

Sat, Mar 14, 11:17 AM · AbuseFilter
Daimona added a comment to T245289: Create sniff to help prevent logstash_formatter_key_conflict in mediawiki logs.

I think this is better done in phan which has better inferences on array keys, etc.

Sat, Mar 14, 10:58 AM · phan

Fri, Mar 13

Daimona claimed T247190: Complete TitleFactory to be a real factory service.
Fri, Mar 13, 5:33 PM · Dependency injection, Patch-For-Review, MediaWiki-General, Core Platform Team
Daimona added a comment to T243590: Fix WikibaseDataModel CI for php 7.4.

Is this the same set of issues that emit errors in the CI run?

Fri, Mar 13, 11:28 AM · Wikidata-Campsite, PHP 7.4 support, Wikidata, Wikibase-DataModel
Daimona created T247595: Make Wikibase compatible with PHP 7.4.
Fri, Mar 13, 11:23 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), Wikidata, PHP 7.4 support
Daimona closed T243598: Set tab-width in the base ruleset file as Resolved.
Fri, Mar 13, 10:17 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), MediaWiki-Codesniffer

Thu, Mar 12

Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Thu, Mar 12, 6:10 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona removed a project from T246938: How to update/delete ExternalStore entries?: Patch-For-Review.
Thu, Mar 12, 1:04 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend
Daimona closed T246938: How to update/delete ExternalStore entries?, a subtask of T246539: Dry-run, then actually run updateVarDumps, as Declined.
Thu, Mar 12, 1:04 PM · MW-1.35-release, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), Wikimedia-maintenance-script-run, AbuseFilter
Daimona closed T246938: How to update/delete ExternalStore entries? as Declined.

Writing docs is T247383, fixing the script is T246539. No more actionables here.

Thu, Mar 12, 1:04 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend
Samwilson awarded T243598: Set tab-width in the base ruleset file a Like token.
Thu, Mar 12, 1:57 AM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), MediaWiki-Codesniffer

Wed, Mar 11

Daimona created T247428: Improve caused-by lines as seen for GlobalBlocking.
Wed, Mar 11, 5:43 PM · phan-taint-check-plugin
Daimona added a comment to T246397: Refactor blocking code so much boilerplate isn't needed.

Suggest adding DatabaseBlock::getLogEntry
Returns a ManualLogEntry with known parameters already set

Wed, Mar 11, 9:25 AM · User-DannyS712, MediaWiki-User-management
Daimona awarded T247383: Clearly document ExternalStore as append-only interface (with rationale) a Like token.
Wed, Mar 11, 9:17 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Documentation, MediaWiki-Revision-backend

Tue, Mar 10

Daimona added a comment to T247365: Add comment directive to includes/GlobalBlockingHooks.php to suppress SecurityCheck-XSS warning.

P.S. Memo: those caused-by lines are terrible. I should check why and fix.

Tue, Mar 10, 11:21 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), user-sbassett, phan-taint-check-plugin, Security, GlobalBlocking
Daimona added a comment to T247365: Add comment directive to includes/GlobalBlockingHooks.php to suppress SecurityCheck-XSS warning.

From a very quick look, it may be caused by the 'parentheses' message not being escaped in formatRow. It's probably worth a try. (Note: I didn't check what's the effect of changing text() to escaped() on the params)

Tue, Mar 10, 11:17 PM · MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), user-sbassett, phan-taint-check-plugin, Security, GlobalBlocking
Daimona added a comment to T246938: How to update/delete ExternalStore entries?.

It's basically a no, unless the DBAs un-mark things readonly, delete on each replica...

Tue, Mar 10, 6:45 PM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend
Daimona added a comment to T246938: How to update/delete ExternalStore entries?.

The ES clusters which are not currently being written to have read-only mode enabled in MariaDB, so you can't modify them in any way. They also don't have replication running. So ES is managed by the DBAs as an append-only cluster, a strategy which is enabled by the restricted API presented by MediaWiki. Presenting ES as an append-only store provides some flexibility for implementation options which would not be there if we allowed deletion and update.

Tue, Mar 10, 11:03 AM · Core Platform Team Workboards (Clinic Duty Team), MediaWiki-Revision-backend

Mon, Mar 9

Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Mon, Mar 9, 9:17 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona added a comment to T193950: Hook parameters should not be passed by reference unless the parameter is documented to be replaceable.

Related: T234118

Mon, Mar 9, 6:59 PM · MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), Patch-For-Review, MediaWiki-General, Core Platform Team Legacy (Watching / External), User-Daniel
Daimona added a comment to T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.

Note that, for future tasks, this list may be generated using maintenance/findDeprecated. The current version is incomplete and (at least for me) doesn't seem to be able to find hard deprecation, but there's a new version at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/566537/. It should probably be put in a separated library, but you can git review -d and use it locally. For hard deprecations, it's

php maintenance/findDeprecated/findDeprecated.php | grep "\+"
Mon, Mar 9, 6:03 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona claimed T243425: Refactor DatabaseLogEntry and RCDatabaseLogEntry.
Mon, Mar 9, 5:10 PM · Patch-For-Review, User-Daimona, Technical-Debt, MediaWiki-Logging
Daimona added a comment to T154677: Turn static Hooks class into HookManager service.

Superseded by / subtask of T240307?

Mon, Mar 9, 11:12 AM · CPT Initiatives (Extension Interfaces (CDP2)), User-Daniel, MediaWiki-General, Technical-Debt
Daimona added a comment to T221075: Introduce a BlockStore service.

Currently, we have several classes representing blocks (DatabaseBlock, SystemBlock, ...), all based on the AbstractBlock class, which doesn't involve the Database at all. Hence, I think this task should be updated. We could:

Mon, Mar 9, 10:29 AM · Technical-Debt, MediaWiki-User-management

Sun, Mar 8

Daimona added a comment to T218074: ip_in_range should accept explicit range notation.
Sun, Mar 8, 8:12 PM · MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), IPUtils, Patch-For-Review, User-Daimona, AbuseFilter
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 5:20 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona closed T214317: Phase out deprecated Title::isValidMoveTarget, a subtask of T208786: Untangle MediaHandler, FileRepo, File, Title and Linker, as Resolved.
Sun, Mar 8, 5:09 PM · CPT Initiatives (Decoupling (CDP2)), Epic, MediaWiki-File-management, Multimedia, Commons
Daimona closed T214317: Phase out deprecated Title::isValidMoveTarget as Resolved.

This was done.

Sun, Mar 8, 5:09 PM · CPT Initiatives (Decoupling (CDP2)), Patch-For-Review, Technical-Debt, Multimedia, Commons, MediaWiki-File-management
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 1:35 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 1:23 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 1:09 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 12:56 PM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 11:14 AM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Sun, Mar 8, 11:10 AM · Patch-For-Review, MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release
DannyS712 awarded T247190: Complete TitleFactory to be a real factory service a Like token.
Sun, Mar 8, 10:36 AM · Dependency injection, Patch-For-Review, MediaWiki-General, Core Platform Team
Daimona created T247190: Complete TitleFactory to be a real factory service.
Sun, Mar 8, 10:32 AM · Dependency injection, Patch-For-Review, MediaWiki-General, Core Platform Team

Sat, Mar 7

Daimona updated subscribers of T247163: IPUtils::isValidRange doesn't consider explicit ranges as valid.

I did something similar at https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/522989/, but adding another method instead.

It seems odd to me that some functions in the library accept hyphenated ranges, and others don't...

Sat, Mar 7, 2:33 PM · IPUtils
Daimona added a comment to T247163: IPUtils::isValidRange doesn't consider explicit ranges as valid.

I did something similar at https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/IPUtils/+/522989/, but adding another method instead.

Sat, Mar 7, 2:27 PM · IPUtils
Daimona added a comment to T247093: Add Assert::UnreachableException.

Why not just throw a LogicException? I'm not a fan of assertions used like that, as they're exactly the same as throwing an exception, but more complicated... Also, note that an eventual Assert::unreachable couldn't be annotated as "always-throw" (T240141).

I think you mean "could be annotated"?

Sat, Mar 7, 2:16 PM · Parsoid