Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (140 w, 4 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Babel: it-N, en-3, fr-1

Recent Activity

Today

Daimona added a comment to T227603: Create a CI container for mediawiki/tools/dependency-analysis.

Given the annoying requirements of graph-tool, could we consider adding phpda only (i.e. no wrapper)? It wouldn't work for core, but it probably would for most extensions.

Mon, Jan 27, 7:29 PM · Release-Engineering-Team (Code Health), Code-Health, Continuous-Integration-Config

Yesterday

Daimona committed rSMNBc21a70208cca: build: Updating composer dependencies (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating composer dependencies
Sun, Jan 26, 9:32 PM
Daimona committed rTAWRde7f0bdc23ed: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 1:39 AM
Daimona committed rWLEP5d991f522161: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 1:39 AM
Daimona committed R1981:658503af40d2: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 1:38 AM
Daimona committed rMLIPd8b1836957f0: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 1:38 AM
Daimona committed R1907:92a57409fb1e: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 1:18 AM
Daimona committed R1984:9466ed6bf961: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 12:58 AM
Daimona committed rMLSE35db22c23068: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 12:58 AM
Daimona committed rMLZEcc60a9e0607e: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sun, Jan 26, 12:57 AM

Sat, Jan 25

Daimona added a comment to T243647: Upgrade all MediaWiki libraries to use PHPUnit 8.5+ in their tests, like MediaWiki core.

{{Done}} for all repos with a requirement of PHP 7.2+. There are a couple of libs left.

Sat, Jan 25, 1:16 PM · Technical-Debt, MediaWiki-General
Daimona committed rCSSS081b2d34feb4: Require PHPUnit 8 like MW core (authored by Daimona).
Require PHPUnit 8 like MW core
Sat, Jan 25, 1:11 PM
Daimona triaged T243600: Preparation for the PHPUnit 9 upgrade as Low priority.
Sat, Jan 25, 10:30 AM · User-Daimona, Patch-For-Review, MediaWiki-Core-Testing

Fri, Jan 24

Daimona committed rMTPSd3b5aacd8712: build: Upgrade mediawiki-codesniffer to v29.0.0 (authored by Jdforrester-WMF).
build: Upgrade mediawiki-codesniffer to v29.0.0
Fri, Jan 24, 10:22 PM
Daimona added a comment to T243296: Release a new version of WikibaseCodeSniffer.

I'm going to go around and update this in various places that it is used.

Fri, Jan 24, 5:21 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata
Daimona added a project to T243600: Preparation for the PHPUnit 9 upgrade: User-Daimona.
Fri, Jan 24, 2:42 PM · User-Daimona, Patch-For-Review, MediaWiki-Core-Testing
Daimona created T243600: Preparation for the PHPUnit 9 upgrade.
Fri, Jan 24, 1:27 PM · User-Daimona, Patch-For-Review, MediaWiki-Core-Testing
Daimona closed T243529: PHPCS forbids all attempts to implement interfaces over multiple lines as Invalid.

Working as intended, closing in favour of T243598.

Fri, Jan 24, 1:03 PM · Upstream, MediaWiki-Codesniffer
Daimona created T243598: Set tab-width in the base ruleset file.
Fri, Jan 24, 1:02 PM · MediaWiki-Codesniffer
Daimona added a comment to T243403: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo.

So, aside from findDeprecated, there are two consumers.

  • maintenance/shell.php - This is also the only consumer of Psysh. It looks "weird" to have a single file require two libraries, but I guess it's fine
  • In Flow, scripts/one-class-per-file.php - This looks like a generic util that could be moved elsewhere.
Fri, Jan 24, 11:32 AM · Patch-For-Review, phan, MediaWiki-General

Thu, Jan 23

Daimona added a comment to T219673: Make MediaWikiTestCase::teardownTestDB work reliably.

(actually, PHPUnit 8 does, but we're still on PHPUnit 4 + 6).

Thu, Jan 23, 6:19 PM · Performance-Team, MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), MediaWiki-Core-Testing
Daimona committed rELUA2e1306fa450e: Kill hack for the PHPUnit migration (authored by Daimona).
Kill hack for the PHPUnit migration
Thu, Jan 23, 5:09 PM
Daimona added a project to T243529: PHPCS forbids all attempts to implement interfaces over multiple lines: Upstream.
Thu, Jan 23, 4:58 PM · Upstream, MediaWiki-Codesniffer
Daimona created T243529: PHPCS forbids all attempts to implement interfaces over multiple lines.
Thu, Jan 23, 4:52 PM · Upstream, MediaWiki-Codesniffer
Daimona added a comment to T237164: Wikibase's cache/integration-tests incompatible with PHPUnit 8.

Is this going anywhere, or are we just going to leave it disabled forever?

Thu, Jan 23, 4:25 PM · Wikidata-Campsite, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), MediaWiki-extensions-WikibaseRepository, Wikidata
Daimona awarded T192167: Upgrade PHPUnit from 4/6 to 8 a Barnstar token.
Thu, Jan 23, 4:18 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to phpdbg or pcov.

Now that we're on PHPUnit 8, I've fiddled a bit with pcov and, oh dear, that's just astonishing.

Thu, Jan 23, 2:43 PM · Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona removed a project from T243324: PHPUnit: Drop enforceTimeLimit command and related settings, because we can't use php-invoker: Patch-For-Review.

Resolved, I guess?

Thu, Jan 23, 1:02 PM · MediaWiki-Core-Testing, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (CI & Testing services)
Daimona added a comment to T243469: Regression from 1.35.0-wmf.16: user_age abusefilter variable reports 0 for users with no registration time, rather than 11+ years.

Belatedly, thank you for the quick fix! And I also like the choice of the date :) I got confused while removing the null fallback, and I didn't even think of the missing registrations.

Thu, Jan 23, 11:11 AM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Regression, AbuseFilter
Daimona added a comment to T243296: Release a new version of WikibaseCodeSniffer.

Not if we move the main ruleset file per T243296#5826268. And, of course, unless it turns out to be impossible to have two different rulesets in MW-CS.

Thu, Jan 23, 11:06 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata
Daimona added a comment to T243296: Release a new version of WikibaseCodeSniffer.

(Unless “Move the WB ruleset to MW-CS” includes disabling those rules for all of MW-CS?)

Thu, Jan 23, 11:03 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata
Daimona added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

Ha, I was being cautious, but I certainly don't oppose. As I said above, PHPUnit 8 won't fail hard for non-compliant repos. I can write down a couple of lines for wikitech-l as soon as the upgrade is complete.

Thu, Jan 23, 10:48 AM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
Daimona added a comment to T243296: Release a new version of WikibaseCodeSniffer.

I think we could ship it inside the MediaWiki-Codesniffer repo so it doesn't fall behind at least.

Thu, Jan 23, 10:42 AM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata

Wed, Jan 22

Daimona added a comment to T243403: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo.

Hm, apparently there are other consumers for php-parser. Will need to check up those as well, and see if we can use phan instead (or just leave php-parser in place).

Wed, Jan 22, 5:24 PM · Patch-For-Review, phan, MediaWiki-General
Daimona moved T243425: Refactor DatabaseLogEntry and RCDatabaseLogEntry from Backlog to Nextish on the User-Daimona board.
Wed, Jan 22, 5:06 PM · User-Daimona, Technical-Debt, MediaWiki-Logging
Daimona added a project to T243425: Refactor DatabaseLogEntry and RCDatabaseLogEntry: User-Daimona.
Wed, Jan 22, 5:05 PM · User-Daimona, Technical-Debt, MediaWiki-Logging
Daimona created T243425: Refactor DatabaseLogEntry and RCDatabaseLogEntry.
Wed, Jan 22, 5:05 PM · User-Daimona, Technical-Debt, MediaWiki-Logging
Addshore awarded T226266: Create a phan plugin to handle the Assert library a Mountain of Wealth token.
Wed, Jan 22, 4:51 PM · Patch-For-Review, phan
Daimona added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

Current status:

Wed, Jan 22, 4:34 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
Daimona renamed T243403: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo from Makee maintenance/findDeprecated use phan instead of php-parser to Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo.
Wed, Jan 22, 1:05 PM · Patch-For-Review, phan, MediaWiki-General
Daimona created T243403: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo.
Wed, Jan 22, 1:05 PM · Patch-For-Review, phan, MediaWiki-General
Daimona added a project to T243379: Disable progress bar in the phan docker image: phan.

Half a year later, https://gerrit.wikimedia.org/r/541001 restored it without giving a good reason.

Wed, Jan 22, 11:17 AM · phan, Continuous-Integration-Infrastructure
Daimona added a comment to T219114: phan 1.2.6 is OOMing on MediaWiki core.

The progress bar was restored for no apparent reason via https://gerrit.wikimedia.org/r/541001

Wed, Jan 22, 11:07 AM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Release-Engineering-Team (Kanban), Patch-For-Review, Wikimedia-production-error (Shared Build Failure), MediaWiki-Core-Testing, phan
Daimona added a comment to T243324: PHPUnit: Drop enforceTimeLimit command and related settings, because we can't use php-invoker.

Does the "You should really fix these slow tests" feature depend on this, or is that a different timeout feature in PHPUnit?

Wed, Jan 22, 11:03 AM · MediaWiki-Core-Testing, MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release-Engineering-Team (CI & Testing services)

Tue, Jan 21

Daimona committed rEWCSe195331e4b7a: Fix PHPUnit 8 warnings (authored by Daimona).
Fix PHPUnit 8 warnings
Tue, Jan 21, 6:27 PM
Daimona added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.
Tue, Jan 21, 5:13 PM · MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
Daimona updated subscribers of T243296: Release a new version of WikibaseCodeSniffer.

CC @Ladsgroup as releaser of the last two versions and (AFAICS) most active maintainer.

Tue, Jan 21, 5:05 PM · Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), User-Addshore, MediaWiki-Codesniffer, Wikidata
Daimona added a comment to T243219: session_name(): Cannot change session name when headers already sent in CommonSettings.php on line 510.

Hmmmm interesting. I can think of two main reasons:

  • Some other PHP error/warning/notice is causing this. It should be possible, if the warning in question is hidden for any reason (e.g. error_reporting). In this case, we should first identify the underlying warning.
  • We're indeed sending headers intentionally before the session_name call. This could be a recent regression; we could try to figure it out by calling headers_list / headers_sent($file, $line) before line 510.
Tue, Jan 21, 5:00 PM · Beta-Cluster-Infrastructure, Wikimedia-General-or-Unknown

Mon, Jan 20

Daimona added a comment to T243219: session_name(): Cannot change session name when headers already sent in CommonSettings.php on line 510.

I may be wrong, but errors like this one ("headers already sent") are often seen with some kinds of fatal errors. One specific type that seems to consistently cause this notice is a TypeError due to mismatching types in function calls. Hence, I believe this is actually a side effect of T243218.

Mon, Jan 20, 3:51 PM · Beta-Cluster-Infrastructure, Wikimedia-General-or-Unknown
Daimona added a comment to T237873: Deprecate and remove extension database updating globals.

While that does work, it doesn't tell us which extension is still using the globals; which makes finding the offending extension difficult.

Mon, Jan 20, 12:40 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt
Daimona added a comment to T237873: Deprecate and remove extension database updating globals.

I guess we can start the deprecation phase now? The quickest way seems to add a check to getOldGlobalUpdates and emit a wfDeprecated if any variable isn't empty.

Mon, Jan 20, 12:37 PM · MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), Patch-For-Review, MediaWiki-General, Technical-Debt

Sat, Jan 18

Daimona raised the priority of T243122: Math master is currently broken due to a Wikibase change from Medium to Unbreak Now!.

I think this is not ubn. Why not disable the test?

Sat, Jan 18, 6:44 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata, Math
Daimona reopened T240066: XHGui broken: Invalid argument supplied for foreach as "Open".

It's happening again, for some requests. See for instance this one; most of the recent requests at https://performance.wikimedia.org/xhgui/ seem to be triggering the bug as well.

Sat, Jan 18, 5:29 PM · Performance-Team
Daimona added a project to T243124: Class "Wikibase\Lib\Store\EntityTitleLookup" does not exist.: MediaWiki-extensions-PropertySuggester.
Sat, Jan 18, 2:12 PM · Wikidata-Campsite, MediaWiki-extensions-PropertySuggester, Wikidata
Daimona moved T242696: AbuseFilter not blocking edits that trigger the Filter from Backlog to Nextish on the User-Daimona board.
Sat, Jan 18, 1:59 PM · User-Daimona, AbuseFilter
Daimona added a project to T242696: AbuseFilter not blocking edits that trigger the Filter: User-Daimona.
Sat, Jan 18, 1:59 PM · User-Daimona, AbuseFilter
Daimona added a comment to T242696: AbuseFilter not blocking edits that trigger the Filter.

First of all, the edit was revdel'ed, hence I cannot help with on-wiki debugging in any way. Would it be possible to undelete it, at least temporarily?

Sat, Jan 18, 1:58 PM · User-Daimona, AbuseFilter
Daimona added a subtask for T233864: 1.35.0-wmf.16 deployment blockers: T243122: Math master is currently broken due to a Wikibase change.
Sat, Jan 18, 1:33 PM · User-brennen, Release-Engineering-Team-TODO (2020-01 to 2020-03 (Q3)), Release, Train Deployments
Daimona added a parent task for T243122: Math master is currently broken due to a Wikibase change: T233864: 1.35.0-wmf.16 deployment blockers.
Sat, Jan 18, 1:33 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata, Math
Daimona created T243122: Math master is currently broken due to a Wikibase change.
Sat, Jan 18, 1:32 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata, Math

Fri, Jan 17

Daimona committed rEMAS7d8f6b0834a4: Stop using deprecated assertType (authored by Daimona).
Stop using deprecated assertType
Fri, Jan 17, 5:12 PM
Daimona added a comment to T240884: Standalone service to evaluate user-provided regular expressions.

One complicating factor here is that AbuseFilter and SpamBlacklist both don't have a clear maintainer.

I think @Daimona is understood to be the de facto AF maintainer these days (trusted dev, wmf-NDA, etc.) and is pretty active in its current development.

Fri, Jan 17, 4:42 PM · User-Addshore, TechCom-RFC, Wikidata
Daimona added a comment to T239093: Add Daimona to #mediawiki_security.

Belatedly, I confirm that I can join the channel. Thanks!

Fri, Jan 17, 3:23 PM · Operations

Thu, Jan 16

DannyS712 awarded T241947: Stop using $wgUser in Wikibase a Like token.
Thu, Jan 16, 4:40 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first task, MediaWiki-extensions-WikibaseRepository, Wikidata, Technical-Debt (Deprecation process)

Tue, Jan 14

Daimona committed rEBTR343b5e249552: Stop using deprecated PHPUnit methods (authored by Daimona).
Stop using deprecated PHPUnit methods
Tue, Jan 14, 7:27 PM
Daimona added a comment to T241947: Stop using $wgUser in Wikibase.

Well, RequestContext::getMain is slightly less evil that the global probably.

Tue, Jan 14, 5:27 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first task, MediaWiki-extensions-WikibaseRepository, Wikidata, Technical-Debt (Deprecation process)
Daimona added a comment to T242727: Add .phpunit.result.cache to .gitignore.

There's only a handful of repos that directly install PHPUnit (and most of those probably shouldn't), but sure.

Tue, Jan 14, 5:22 PM · LibUp
Daimona added a comment to T241947: Stop using $wgUser in Wikibase.

Note: there are two usages in the entry point which I'm unsure how to fix.

I guess they could come from "Context".
I don't obviously see anything else in core that could be used at this second.
Which would mean something like:

RequestContext::getMain()->getUser()

In place of the global

Tue, Jan 14, 5:21 PM · MW-1.35-notes (1.35.0-wmf.16; 2020-01-21), Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), good first task, MediaWiki-extensions-WikibaseRepository, Wikidata, Technical-Debt (Deprecation process)
Ricordisamoa awarded T234118: Checkup code passing $this by reference with a temporary variable a Haypence token.
Tue, Jan 14, 12:59 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Code-Health, MediaWiki-Codesniffer
Daimona created T242727: Add .phpunit.result.cache to .gitignore.
Tue, Jan 14, 10:27 AM · LibUp

Mon, Jan 13

Daimona added a comment to T242536: Use phan setting 'scalar_implicit_cast` = false without using strict_types = 1 in mediawiki-phan-config?.

Here is a made-up example:

Mon, Jan 13, 1:54 PM · phan
Daimona added a comment to T242536: Use phan setting 'scalar_implicit_cast` = false without using strict_types = 1 in mediawiki-phan-config?.

Thanks @Umherirrender for opening the task. I'd like to add a couple of words, mostly what I wrote on gerrit.

Mon, Jan 13, 10:54 AM · phan
Daimona changed the status of T234615: Re-create views for abuse_filter_log including two new columns, a subtask of T234052: Add abuse_filter_log.afl_filter_id and afl_global columns, from Stalled to Open.
Mon, Jan 13, 10:37 AM · AbuseFilter, DBA, Blocked-on-schema-change
Daimona changed the status of T234615: Re-create views for abuse_filter_log including two new columns from Stalled to Open.

Unstalling per parent task being resolved (thanks for that!)

Mon, Jan 13, 10:37 AM · cloud-services-team (Kanban), Data-Services
Daimona awarded T234052: Add abuse_filter_log.afl_filter_id and afl_global columns a Like token.
Mon, Jan 13, 10:37 AM · AbuseFilter, DBA, Blocked-on-schema-change

Sun, Jan 12

Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to phpdbg or pcov.

I'd like to note that the latest version of xdebug (2.9.0), released one month ago, claims to be up to 250% faster than 2.7.0 (the version we're using) for generating coverage [1]. I've upgraded locally, and while I didn't get a 250% speedup, it's certainly faster (I didn't measure it, though). I believe this upgrade should be performed as soon as possible, as it seems fairly straightforward.

Sun, Jan 12, 3:15 PM · Release-Engineering-Team-TODO, Continuous-Integration-Config, Release-Engineering-Team (CI & Testing services), Test-Coverage
Daimona removed a project from T174553: Create a mechanism that allows fetching geolocation and subnet data for IP addresses: User-Daimona.
Sun, Jan 12, 11:35 AM · Patch-For-Review, User-Huji, MediaWiki-extension-requests, Stewards-and-global-tools, MediaWiki-extensions-LoginNotify, CheckUser
Daimona removed a project from T203344: phan-taint-check should warn about unnecessary @suppress tags: User-Daimona.
Sun, Jan 12, 11:34 AM · Patch-For-Review, phan-taint-check-plugin
Daimona moved T234155: Create CU-level abuse filters from Backlog to Future on the User-Daimona board.
Sun, Jan 12, 11:34 AM · User-Daimona, Epic, WMF-Legal, CheckUser, AbuseFilter, WorkType-NewFunctionality
Daimona moved T241679: Add an auto-formatter to AbuseFilter from Backlog to Future on the User-Daimona board.
Sun, Jan 12, 11:33 AM · User-Daimona, AbuseFilter
Daimona moved T239990: Deprecate and then remove the old AbuseFilterParser from Backlog to Nextish on the User-Daimona board.
Sun, Jan 12, 11:33 AM · User-Daimona, Patch-For-Review, AbuseFilter
Daimona added a project to T239990: Deprecate and then remove the old AbuseFilterParser: User-Daimona.
Sun, Jan 12, 11:33 AM · User-Daimona, Patch-For-Review, AbuseFilter
Daimona moved T231962: Abusefilter modify layout is broken on zhwiki from Backlog to Nextish on the User-Daimona board.
Sun, Jan 12, 11:33 AM · User-Daimona, Chinese-Sites, Patch-For-Review, AbuseFilter
Daimona added a project to T231962: Abusefilter modify layout is broken on zhwiki: User-Daimona.
Sun, Jan 12, 11:32 AM · User-Daimona, Chinese-Sites, Patch-For-Review, AbuseFilter
Daimona moved T238431: The filter ID in the URL is redundant when viewing an old version of a filter from Backlog to Nextish on the User-Daimona board.
Sun, Jan 12, 11:32 AM · User-Daimona, AbuseFilter
Daimona added a project to T238431: The filter ID in the URL is redundant when viewing an old version of a filter: User-Daimona.
Sun, Jan 12, 11:32 AM · User-Daimona, AbuseFilter
Daimona moved T191694: AbuseFilter list not sorted correctly when ordered by Status from Backlog to Nextish on the User-Daimona board.
Sun, Jan 12, 11:32 AM · User-Daimona, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), AbuseFilter
Daimona added a project to T191694: AbuseFilter list not sorted correctly when ordered by Status: User-Daimona.
Sun, Jan 12, 11:31 AM · User-Daimona, MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), AbuseFilter
Daimona moved T240951: Abusefilter throttle did not work at dewiki from Backlog to Nextish on the User-Daimona board.
Sun, Jan 12, 11:31 AM · User-Daimona, AbuseFilter
Daimona added a project to T240951: Abusefilter throttle did not work at dewiki: User-Daimona.
Sun, Jan 12, 11:31 AM · User-Daimona, AbuseFilter
Daimona moved T228655: Dry-run fixOldLogEntries for AbuseFilter from Backlog to Under review on the User-Daimona board.
Sun, Jan 12, 11:31 AM · User-Daimona, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikimedia-maintenance-script-run, AbuseFilter
Daimona added a project to T228655: Dry-run fixOldLogEntries for AbuseFilter: User-Daimona.
Sun, Jan 12, 11:31 AM · User-Daimona, Patch-For-Review, MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), Wikimedia-maintenance-script-run, AbuseFilter

Sat, Jan 11

Daimona updated the task description for T235390: Merge taint-check-plugin into mediawiki-phan-config.
Sat, Jan 11, 1:08 PM · Patch-For-Review, phan, phan-taint-check-plugin

Thu, Jan 9

Daimona added a comment to T242314: User rights not being evaluated on the beta cluster.

Working as intended. user_rights is lazy-loaded, and no filter is using it.

Should then not still be shown when examining old entries, given that (eg when examining old edits) user rights are loaded for the user currently?

Thu, Jan 9, 6:19 PM · AbuseFilter, Beta-Cluster-Infrastructure, User-DannyS712
Daimona added a comment to T241679: Add an auto-formatter to AbuseFilter.

Before this can be done (and I have some ideas about doing it) we should establish the preferred formatting to be used; I would suggest discussions on enwiki/meta/mediawiki or somewhere else where users who edit abuse filters can chime in - we shouldn't apply formatting that most users would disagree with / formatting applied should follow general practices among users.

Thu, Jan 9, 4:16 PM · User-Daimona, AbuseFilter
Daimona added a comment to T240951: Abusefilter throttle did not work at dewiki.

My final words: caused by the eviction of the key. Note, the backend used for throttle keys is Redis and not memcached. I believe there's nothing we can do here. The best outcome would be to find a way to make throttle work without caching (but how?), or open a follow-up task to investigate whether it's possible to increase the persistence, and hence reduce the chance of eviction.

Thu, Jan 9, 1:15 PM · User-Daimona, AbuseFilter
Daimona closed T242314: User rights not being evaluated on the beta cluster as Invalid.

Working as intended. user_rights is lazy-loaded, and no filter is using it.

Thu, Jan 9, 12:18 PM · AbuseFilter, Beta-Cluster-Infrastructure, User-DannyS712
Daimona added a comment to T242315: Figure out what to do with abuselog entries that include variables that have been removed.

Seems fine. My only suggestion is to use something more like $1 (unknown variable), akin to the proposal for user-set variables. The change itself should be fairly easy to implement.

Thu, Jan 9, 12:16 PM · AbuseFilter, User-DannyS712
Daimona added a comment to T242313: Syntax validation should flag division by variables that can be 0.

This is working as intended. When you're checking syntax, page_namespace is DUNDEFINED, which explicitly allows division by zero. Before that change, you weren't able to write things like

Thu, Jan 9, 11:19 AM · AbuseFilter, User-DannyS712
Daimona updated the task description for T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
Thu, Jan 9, 10:48 AM · MediaWiki-General, Technical-Debt (Deprecation process), MW-1.35-release