Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (96 w, 13 h)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Recent Activity

Yesterday

Daimona added a comment to T212830: Fawiki article cannot be edited: "Service Temporarily Unavailable" timeout upon saving at API execution limit (200 seconds).

@Huji Dang! I checked on logstash (from mobile phone, which is painful) and heck yes! AbuseFilter 101 is constantly taking ~150 seconds to execute on that page!
You are right, profiling is enabled on every wiki (and I already sent patches to remove profiling globals altogether). However, the avg execution time for that filter doesn't show up as very high due to the amount of edits (that's why there are patches to add the maximum recorded execution time). From a quick look I can see a couple of things to be optimized in that filter, please let me know if you need any help with it.

Thu, Mar 21, 10:39 PM · Wikimedia-General-or-Unknown, MediaWiki-Page-editing
Daimona claimed T218074: ip_in_range should accept explicit range notation.
Thu, Mar 21, 6:57 PM · Patch-For-Review, User-Daimona, AbuseFilter
Daimona claimed T218906: Short-circuit evaluation fails with multiple comparisons.
Thu, Mar 21, 3:51 PM · Patch-For-Review, AbuseFilter
Daimona updated the task description for T218906: Short-circuit evaluation fails with multiple comparisons.
Thu, Mar 21, 3:25 PM · Patch-For-Review, AbuseFilter
Daimona updated the task description for T214643: Syntax check should be consistent with actual parsing.
Thu, Mar 21, 3:05 PM · User-Daimona, AbuseFilter
Daimona created T218906: Short-circuit evaluation fails with multiple comparisons.
Thu, Mar 21, 3:04 PM · Patch-For-Review, AbuseFilter
Daimona claimed T218874: PHP Notice: Undefined index: bits for Special:AbuseFilter/test.
Thu, Mar 21, 1:08 PM · Patch-For-Review, Wikimedia-production-error, AbuseFilter
Daimona moved T218874: PHP Notice: Undefined index: bits for Special:AbuseFilter/test from Untriaged to Regressed 1.33-wmf.22 on the Wikimedia-production-error board.
Thu, Mar 21, 12:49 PM · Patch-For-Review, Wikimedia-production-error, AbuseFilter
Daimona updated the task description for T218874: PHP Notice: Undefined index: bits for Special:AbuseFilter/test.
Thu, Mar 21, 12:49 PM · Patch-For-Review, Wikimedia-production-error, AbuseFilter
Daimona created T218874: PHP Notice: Undefined index: bits for Special:AbuseFilter/test.
Thu, Mar 21, 12:47 PM · Patch-For-Review, Wikimedia-production-error, AbuseFilter
Daimona added a comment to T218873: Special:AbuseFilter/test has wrong variable names for upload actions.

Aye, I was right! The prefix 'ARTICLE' wasn't updated to 'page'. The impact is that, in order to test uploads, users have to use article_* vars instead of page_*. Nothing else is affected and no need to backport as these values aren't saved in the DB.

Thu, Mar 21, 12:40 PM · Patch-For-Review, AbuseFilter
Daimona triaged T218873: Special:AbuseFilter/test has wrong variable names for upload actions as High priority.
Thu, Mar 21, 12:28 PM · Patch-For-Review, AbuseFilter
Daimona claimed T218873: Special:AbuseFilter/test has wrong variable names for upload actions.
Thu, Mar 21, 12:27 PM · Patch-For-Review, AbuseFilter
Daimona created T218873: Special:AbuseFilter/test has wrong variable names for upload actions.
Thu, Mar 21, 12:27 PM · Patch-For-Review, AbuseFilter
Daimona closed T218870: Dewiki mostly black, navigation impossible as Invalid.

TerraCodes is right, see for instance T218560.

Thu, Mar 21, 12:20 PM
Daimona added a comment to T218719: Upgrade php-ast to 0.1.4.

@Legoktm I checked all the remaining versions up to 1.2.6 and I can now confirm that we only need 0.1.5 for php-ast. 0.1.2 should be kept for the current version only.

Thu, Mar 21, 8:44 AM · phan-taint-check-plugin, Continuous-Integration-Config

Wed, Mar 20

Daimona added a comment to T218721: Have CI run seccheck tests.

Ah, now I see. Would it still benefit from phpunit?

Wed, Mar 20, 1:47 PM · Patch-For-Review, phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

So I'm looking at the upgrade to PluginV2. The main change is that *Visitor classes are now instantiated by phan itself, which only wants a "get*ClassName" method instead of a constructor. This mostly means that we cannot pass in an instance of the plugin anymore. Moreover, Visitor and PreVisitor must inherit from different classes, which prevents them from having TaintednessBaseVisitor as common parent (should be fixable by turning TaintednessBaseVisitor into a trait). Plus, the MediaWiki checker runs both the generic visitor and the MW visitor, which again isn't possible in V2 because you can only provide a single class name. I'll probably do some gradual changes before the v2 upgrade.

Wed, Mar 20, 11:23 AM · Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T218719: Upgrade php-ast to 0.1.4.

We have T174339 to upgrade to phan 0.8.5, which requires a newer version of php-ast than the one we had.

Wed, Mar 20, 8:44 AM · phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a comment to T218719: Upgrade php-ast to 0.1.4.

@Legoktm Right. But anyway at the end of the migration we'll only have 0.1.4 for the current version, and ?[0] for the final version based on 1.2.x.

Wed, Mar 20, 7:44 AM · phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a comment to T218719: Upgrade php-ast to 0.1.4.

@Legoktm Cool, thanks! I think for now you can use whatever hack comes more handy for seccheck, as at the end of the upgrade we should ideally have a single version installed.
A conditional checking the required phan version seems fine.

Wed, Mar 20, 7:36 AM · phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a comment to T218719: Upgrade php-ast to 0.1.4.

@Legoktm I think the current version should work with 0.1.4. But actually, could you please add 0.1.5 as well? We'll need it for the next upgrade. Thanks!

Wed, Mar 20, 7:23 AM · phan-taint-check-plugin, Continuous-Integration-Config

Tue, Mar 19

Daimona added a comment to T217136: Fatal exception of type "MWException" when trying to move a page on thwiki.

@Krinkle IMHO this should be handled in core. Failures of deletion during page move should show up to the user like the ones for normal deletions do, instead of throwing.

Tue, Mar 19, 11:13 PM · AbuseFilter, User-Daimona, User-revi, Wikimedia-production-error
Daimona updated subscribers of T218719: Upgrade php-ast to 0.1.4.

@Legoktm could you please take a look?

Tue, Mar 19, 10:33 PM · phan-taint-check-plugin, Continuous-Integration-Config
Daimona claimed T218721: Have CI run seccheck tests.
Tue, Mar 19, 10:33 PM · Patch-For-Review, phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a parent task for T216974: Update phan-taint-check-plugin to a newer phan (1.2.x): T207344: Phan-taint-check-plugin not available for PHP > 7.0.
Tue, Mar 19, 7:00 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a subtask for T207344: Phan-taint-check-plugin not available for PHP > 7.0: T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).
Tue, Mar 19, 7:00 PM · phan-taint-check-plugin
Daimona added a parent task for T218721: Have CI run seccheck tests: T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).
Tue, Mar 19, 7:00 PM · Patch-For-Review, phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a subtask for T216974: Update phan-taint-check-plugin to a newer phan (1.2.x): T218721: Have CI run seccheck tests.
Tue, Mar 19, 7:00 PM · Patch-For-Review, phan-taint-check-plugin
Daimona created T218721: Have CI run seccheck tests.
Tue, Mar 19, 6:59 PM · Patch-For-Review, phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a subtask for T216974: Update phan-taint-check-plugin to a newer phan (1.2.x): T218719: Upgrade php-ast to 0.1.4.
Tue, Mar 19, 6:58 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a parent task for T218719: Upgrade php-ast to 0.1.4: T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).
Tue, Mar 19, 6:58 PM · phan-taint-check-plugin, Continuous-Integration-Config
Daimona created T218719: Upgrade php-ast to 0.1.4.
Tue, Mar 19, 6:58 PM · phan-taint-check-plugin, Continuous-Integration-Config
Daimona added a project to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x): Patch-For-Review.
Tue, Mar 19, 6:49 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

$ become gerritbot
https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/SecurityCheckPlugin/+/497583/

Tue, Mar 19, 6:39 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T192217: Remove the "check" pipeline and Zuul's user-filter.

Nitpicky comment: the description "Jobs restricted to trusted users. Will vote +2." for the test pipeline should be changed.

Tue, Mar 19, 2:06 PM · Patch-For-Review, Release-Engineering-Team (Backlog), Continuous-Integration-Infrastructure
zeljkofilipin awarded T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded a Party Time token.
Tue, Mar 19, 11:12 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona added a comment to T203651: Optimize phan-taint-check speed.

The switch to phan's PluginV2 as part of T216974 should boost the speed per PluginV2 documentation.

Tue, Mar 19, 10:48 AM · phan-taint-check-plugin
Daimona added a comment to T216974: Update phan-taint-check-plugin to a newer phan (1.2.x).

This would indeed be awesome. However, see my comment in T207344#5033198. Basically, phan has many breaking changes even in patch versions, so upgrading to 0.8.13 would already break a lot of stuff. Today I tried to get there, but eventually gave up due to this.
For whoever will want to proceed with this, here are the main obstacles I found while upgrading to 0.8.13. Note that I don't really know how phan works so it could be fault of mine (but I'm still happy to help).

  • Clazz::getPropertyByNameInContext now has an extra required parameter, $is_static. However, I couldn't find a way to determine if the property is static where we call it.
  • This commit causes 2 troubles:
    • It adds the new class UnaddressableTypedElement, which is extended by Variable. This breaks all typehints for TypedElementInterface in TaintednessBaseVisitor. Just removing them (and adding UnaddressableTypedElement to the docblock) seems to work fine, but it should be checked more deeply.
    • Parameter::getContext() is replaced by Parameter::getFileRef(), which however doesn't have the getScope() method used in setTaintedness.
Tue, Mar 19, 8:52 AM · Patch-For-Review, phan-taint-check-plugin

Mon, Mar 18

Daimona added a comment to T205254: Investigate usage of "text" in AbuseFilter rules on wikidata.org.

Just a random comment: data actually used by existing abuse filters like the rank can be moved from added_lines to new AF variables defined via hooks.

Mon, Mar 18, 10:40 PM · Wikidata.org, wikidata-tech-focus, Wikidata
Daimona added a comment to T207344: Phan-taint-check-plugin not available for PHP > 7.0.

I'm giving up with the upgrade. Phan doesn't comply with semver at all, and thus as I was saying above you'll face plenty of breaking changes even for x.x.y => x.x.z upgrades. At this point, I think seccheck needs a major rewrite in order to work with 1.2.6. If instead, you want to do it gradually, I suggest bumping to 0.9.6 first (which is roughly the same as 0.8.13), then switch to PluginV2 and slowly move on to 1.2.6.

Mon, Mar 18, 3:36 PM · phan-taint-check-plugin
Daimona added a comment to T207344: Phan-taint-check-plugin not available for PHP > 7.0.

@sbassett Well, actually I'm facing several breaking changes even with 0.8.0 => 0.8.13. The most important is the addition of UnaddressableTypedElement (which also doesn't have a true context but just a FileRef), which breaks several things in TaintednessBaseVisitor. More specifically, I'm talking about this commit.

Mon, Mar 18, 2:39 PM · phan-taint-check-plugin
Daimona added a comment to T207344: Phan-taint-check-plugin not available for PHP > 7.0.

@sbassett Thanks for the reply. I'm trying to understand how phan, AST etc. work to see if I can start bumping the phan version. For now I'm trying to get to phan ^0.8 and ast ^0.1.5, although it won't be fast and I cannot guarantee anything.

Mon, Mar 18, 2:17 PM · phan-taint-check-plugin
Daimona added a comment to T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.

@zeljkofilipin Yes, it does. And I can also confirm that DateTime is the only input type affected by this bug.

Mon, Mar 18, 12:19 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona added a comment to T207344: Phan-taint-check-plugin not available for PHP > 7.0.

@Bawolff Is there a specific reason to require PHP 7.0.0, or it's just because the plugin is untested with other versions?

Mon, Mar 18, 11:15 AM · phan-taint-check-plugin
Daimona renamed T207344: Phan-taint-check-plugin not available for PHP > 7.0 from Phan-taint-check-plugin not available for PHP 7.1.17 to Phan-taint-check-plugin not available for PHP > 7.0.
Mon, Mar 18, 11:05 AM · phan-taint-check-plugin
Daimona added a comment to T218322: Uncaught Error: Circular dependency! mw-input-wpExpiry on beta environment (March 14, 2019).

Different message but same cause as the other task, which already has a patch.

Mon, Mar 18, 10:20 AM · Anti-Harassment, MediaWiki-User-management, OOUI
Daimona merged T218322: Uncaught Error: Circular dependency! mw-input-wpExpiry on beta environment (March 14, 2019) into T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.
Mon, Mar 18, 10:20 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona merged task T218322: Uncaught Error: Circular dependency! mw-input-wpExpiry on beta environment (March 14, 2019) into T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.
Mon, Mar 18, 10:20 AM · Anti-Harassment, MediaWiki-User-management, OOUI
Daimona claimed T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.
Mon, Mar 18, 10:10 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona added a comment to T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.

A quick look points at https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/495296/, since setFlags is a method defined in the FlaggedElement class.

Mon, Mar 18, 10:05 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Mvolz awarded T218472: gerrit.wikimedia.org is down a Cup of Joe token.
Mon, Mar 18, 10:04 AM · User-greg, Operations, Release-Engineering-Team, Gerrit
Daimona added a comment to T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.

Train blockers are Unbreak Now!.

Mon, Mar 18, 9:33 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona added a comment to T218527: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org.

Great! Just a note - this setting is not for logging to Special:AbuseLog, but to recent changes. More specifically, to the places defined in $wgAbuseFilterNotifications, as this setting is only used to decide whether to include private filters there. Needless to say, having all filters logged to RC can greatly help patrollers (with or without abusefilter-modify right), who will know what edits are more likely to be bad.

Mon, Mar 18, 8:25 AM · Patch-For-Review, AbuseFilter, Wikimedia-Site-requests

Sun, Mar 17

Daimona raised the priority of T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null) from Normal to High.

This is hitting us over and over.

Sun, Mar 17, 3:10 PM · User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Daimona merged Restricted Task into T187153: Special:Abuselog throws when viewing details or examining (BadMethodCallException: Call get getId() on null).
Sun, Mar 17, 3:10 PM · User-zeljkofilipin, MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), Patch-For-Review, User-Daimona, Regression, Multi-Content-Revisions, User-Addshore, Wikimedia-production-error, Chinese-Sites, AbuseFilter
Daimona renamed T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded from TypeError: this.setFlags is not a function preventing fields from being loaded to TypeError: this.setFlags is not a function preventing datetime fields from being loaded.
Sun, Mar 17, 3:03 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona triaged T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded as High priority.

Train blocker because this hides form fields, high prio because there's time to fix it before the train starts.

Sun, Mar 17, 3:02 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona added a parent task for T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded: T206676: 1.33.0-wmf.22 deployment blockers.
Sun, Mar 17, 3:02 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona added a subtask for T206676: 1.33.0-wmf.22 deployment blockers: T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.
Sun, Mar 17, 3:02 PM · Release-Engineering-Team (Kanban), User-zeljkofilipin, Release, Train Deployments
Daimona created T218513: TypeError: this.setFlags is not a function preventing datetime fields from being loaded.
Sun, Mar 17, 3:01 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), MediaWiki-HTMLForm, OOUI
Daimona edited P8017 Important and short patches in AbuseFilter currently under review.
Sun, Mar 17, 2:56 PM · AbuseFilter
Daimona added a comment to T218472: gerrit.wikimedia.org is down.

I don't think removing these comments is a good idea, as people subscribed to this task recieve the respective email notifications anyway and are left with even more questions than before. If the intention is to deny the claims of @JruwJN, I would consider it the better approach to just say so, if the intention is to keep this hidden for now, it simply is not working. So I don't think these deletions do any good.

Sun, Mar 17, 12:36 PM · User-greg, Operations, Release-Engineering-Team, Gerrit
Daimona closed T170249: AbuseFilter is near-impossible to test on uploads as Resolved.

Hoping that this won't create more problem than it solves!

Sun, Mar 17, 11:21 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), Multimedia, AbuseFilter
Daimona closed T170249: AbuseFilter is near-impossible to test on uploads, a subtask of T170574: Actions other than `edit` cannot be retrospectively tested in AbuseFilter, as Resolved.
Sun, Mar 17, 11:21 AM · MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)), AbuseFilter
Daimona closed T214642: Short circuit breaks with multiple operations as Resolved.
Sun, Mar 17, 10:05 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), AbuseFilter
Daimona closed T217143: Special:AbuseFilter description and notes have too low of a contrast ratio for unprivileged users as Resolved.
Sun, Mar 17, 9:50 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), AbuseFilter, WCAG-Level-AA, Accessibility
Daimona closed T217520: Make edit filter management sortable as Resolved.
Sun, Mar 17, 9:49 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Daimona, User-DannyS712, AbuseFilter

Sat, Mar 16

Daimona closed T216904: Upgrade AbuseFilter extension to use newer phan as Resolved.
Sat, Mar 16, 8:00 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), phan, AbuseFilter
Mvolz awarded T218472: gerrit.wikimedia.org is down a The World Burns token.
Sat, Mar 16, 3:07 PM · User-greg, Operations, Release-Engineering-Team, Gerrit
MGChecker awarded T218472: gerrit.wikimedia.org is down a The World Burns token.
Sat, Mar 16, 1:06 PM · User-greg, Operations, Release-Engineering-Team, Gerrit
Daimona added a comment to T218472: gerrit.wikimedia.org is down.

@MarcoAurelio Well, "expected" to an extent, as I couldn't find any information about it before the actual shutdown. And BTW, is there a related task/discussion/you-name-it?

Sat, Mar 16, 12:46 PM · User-greg, Operations, Release-Engineering-Team, Gerrit
Base awarded T218472: gerrit.wikimedia.org is down a The World Burns token.
Sat, Mar 16, 11:37 AM · User-greg, Operations, Release-Engineering-Team, Gerrit
Ammarpad awarded T218472: gerrit.wikimedia.org is down a Like token.
Sat, Mar 16, 10:37 AM · User-greg, Operations, Release-Engineering-Team, Gerrit
Daimona closed T218453: [[MediaWiki:Globalrenamerequest-pretext/en]] contains a typo "avalaible" instead of "available" as Resolved.
Sat, Mar 16, 10:25 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-MarcoAurelio, good first bug, MediaWiki-extensions-CentralAuth, GlobalRename, I18n
matej_suchanek awarded T218472: gerrit.wikimedia.org is down a The World Burns token.
Sat, Mar 16, 10:18 AM · User-greg, Operations, Release-Engineering-Team, Gerrit
Daimona triaged T218472: gerrit.wikimedia.org is down as Unbreak Now! priority.
Sat, Mar 16, 10:14 AM · User-greg, Operations, Release-Engineering-Team, Gerrit
Daimona created T218472: gerrit.wikimedia.org is down.
Sat, Mar 16, 10:13 AM · User-greg, Operations, Release-Engineering-Team, Gerrit

Wed, Mar 13

Daimona added a comment to T218074: ip_in_range should accept explicit range notation.

Well, for the specific goals of this task, we'd need a method like isValidRange but for explicit ranges. Maybe something like isValidExplicitRange.

Wed, Mar 13, 8:14 AM · Patch-For-Review, User-Daimona, AbuseFilter

Tue, Mar 12

Daimona added a project to T218074: ip_in_range should accept explicit range notation: User-Daimona.
Tue, Mar 12, 8:58 AM · Patch-For-Review, User-Daimona, AbuseFilter
Daimona created T218074: ip_in_range should accept explicit range notation.
Tue, Mar 12, 8:58 AM · Patch-For-Review, User-Daimona, AbuseFilter
Daimona added a comment to T218070: AbuseFilter logs warning "parser error for filter {num}: {parser error}".

@Krinkle Those filters being broken is indeed a software bug: every filter is syntax-checked upon saving, so ideally no filter should ever fail at runtime. Which is why I raised the logging level in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/482777/. And yes, it's also high priority, although this has no impact for the end user and, I think, it doesn't affect AbuseFilter result.

Tue, Mar 12, 8:15 AM · AbuseFilter, Wikimedia-production-error
Daimona merged T218070: AbuseFilter logs warning "parser error for filter {num}: {parser error}" into T214642: Short circuit breaks with multiple operations.
Tue, Mar 12, 8:12 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), AbuseFilter
Daimona merged task T218070: AbuseFilter logs warning "parser error for filter {num}: {parser error}" into T214642: Short circuit breaks with multiple operations.
Tue, Mar 12, 8:12 AM · AbuseFilter, Wikimedia-production-error

Mon, Mar 11

Daimona closed T217471: OOUI docblocks trip Phan analysis as Resolved.

Awesome, thanks!

Mon, Mar 11, 9:40 PM · OOUI, Documentation, phan
Daimona removed a project from T184342: Cargo Extension : Add missing PHPdoc to the function: Security.
Mon, Mar 11, 4:02 PM · Patch-For-Review, Google-Code-in-2017, MediaWiki-extensions-Cargo
Daimona added a comment to T217471: OOUI docblocks trip Phan analysis.

@matmarex Alright, now the Ruby test parser has to be updated. I guess the regex could be changed to allow [-@] at the beginning of the line, and the following case should have an extra when for it. However I don't know Ruby and I'm leaving it up to someone else to avoid messing up.

Mon, Mar 11, 1:01 PM · OOUI, Documentation, phan
Daimona claimed T217471: OOUI docblocks trip Phan analysis.

The patch above implements prop1 + dashes. I'm currently checking it for errors.

Mon, Mar 11, 11:30 AM · OOUI, Documentation, phan
Daimona closed T191676: Report PREG_REPLACE_EVAL as deprecated in codesniffer as Resolved.

Done with phan.

Mon, Mar 11, 6:49 AM · MediaWiki-Core-Testing, phan, PHP 7.0 support

Sun, Mar 10

Daimona added a project to T217970: Some edits aren't recorded as having been saved in AbuseLog (no diff link): User-Daimona.

Confirming. I also noticed the same thing on itwiki a few days ago, but forgot to investigate further. Of note, it's not easy to detect such edits: one may filter the AbuseLog with impact:not saved AND actions taken:none (or tag), but page creations would show up all the same (see e.g. T62179). I don't know why this happens, but I have to say that the code used to populate afl_rev_id (which signals that the edit succeeded) is pretty brittle (see onPageContentSaveComplete). I sort of tried to clean the code a bit in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/478489/, but that's far from being perfect.

Sun, Mar 10, 6:28 PM · User-Daimona, AbuseFilter

Sat, Mar 9

Daimona closed T216942: Upgrade SpamBlacklist extension to use newer phan as Resolved.
Sat, Mar 9, 1:17 PM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), phan, SpamBlacklist

Fri, Mar 8

Daimona added a comment to T202095: Require that CentralAuth's global groups all use lowercase internal identifiers.

For those who cannot see it, the subtask regarding AbuseFilter is now resolved, so that's not a blocker anymore.

Fri, Mar 8, 6:07 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Code Health (TEC13)), Patch-For-Review, MediaWiki-extensions-CentralAuth
Daimona closed Restricted Task, a subtask of T202095: Require that CentralAuth's global groups all use lowercase internal identifiers, as Resolved.
Fri, Mar 8, 6:06 PM · Core Platform Team Kanban (Blocked Externally), Core Platform Team (Code Health (TEC13)), Patch-For-Review, MediaWiki-extensions-CentralAuth
Daimona added a comment to T217884: AbuseFilter profiler on es.wikibooks missing.

@MarcoAurelio Maybe it's because profiling is reset when a filter is modified. So if you edit a filter it won't have any profiling data until the first action it tries to filter.

Fri, Mar 8, 12:04 PM · Wikimedia-Site-requests, AbuseFilter
Daimona added a comment to T217884: AbuseFilter profiler on es.wikibooks missing.

@MarcoAurelio I don't get it: I can see statistics on the top of single filters (example) and grafana shows the data, too.

Fri, Mar 8, 11:57 AM · Wikimedia-Site-requests, AbuseFilter

Wed, Mar 6

Daimona claimed T217743: Database::selectSQLText should prefix 'table_name.*'.
Wed, Mar 6, 10:29 AM · Patch-For-Review, MediaWiki-Database
Daimona created T217743: Database::selectSQLText should prefix 'table_name.*'.
Wed, Mar 6, 10:28 AM · Patch-For-Review, MediaWiki-Database

Tue, Mar 5

Daimona removed a project from T217487: Various tests failing with Echo/UserMerge issues: Patch-For-Review.

The patch for changing Database::select was still pending, but it's better to move it to a separate task.

Tue, Mar 5, 7:40 PM · MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), Release-Engineering-Team, MediaWiki-extensions-UserMerge, Notifications, Growth-Team
Daimona added a comment to T217471: OOUI docblocks trip Phan analysis.

I've looked for similar cases in MediaWiki and it looks like we settled there on formatting the parameters as a list [...] This format doesn't specify the type in a nice way though.

Tue, Mar 5, 9:09 AM · OOUI, Documentation, phan
Daimona added a comment to T217520: Make edit filter management sortable.

@Headbomb that's what Danny said above, and I replied just above your message in T217520#4996560. Somewhat related to this part T163519.

Tue, Mar 5, 8:37 AM · MW-1.33-notes (1.33.0-wmf.22; 2019-03-19), User-Daimona, User-DannyS712, AbuseFilter