Daimona
Musician

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (61 w, 3 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Recent Activity

Fri, Jul 20

Daimona added a project to T183759: MediaWiki::shell with parameter fails on Windows: SyntaxHighlight.

Affected as well.

Fri, Jul 20, 4:11 PM · SyntaxHighlight, MediaWiki-Shell, MediaWiki-extensions-Score
Daimona added a comment to T199989: Pygmentize times out on Windows.

I think I figured out the reason: stream_set_blocking doesn't work for pipes on windows, see doc and a linked bug report. I also printed the return value for these calls, and indeed they're all false. Apparently this won't be fixed on PHP's end since there actually isn't a good solution available on windows. I'm wondering whether there's a workaround that we can apply locally.

Fri, Jul 20, 2:03 PM · SyntaxHighlight, MediaWiki-Shell
Daimona renamed T199989: Pygmentize times out on Windows from Pygmentize times out on Windows (due to failure of Command::input?) to Pygmentize times out on Windows.
Fri, Jul 20, 1:59 PM · SyntaxHighlight, MediaWiki-Shell
Daimona added a comment to T199989: Pygmentize times out on Windows.

Wellll yes, sounds like this is due to the many bugs of streams on windows reported on the web (just search for something like "php windows proc_open" or similar stuff to read a bunch of them). Trying to read from the stream before entering the while loop results in eternal loading for pipes[1] and pipes[2] while pipes[1] is readable, whatever function is used. Instead, if I change $desc to use files instead of pipes for stdout and stderr, everything works fine, with the output being sent to a file as expected. Sounds like a proper solution isn't easy to implement; maybe some workaround would be possible?

Fri, Jul 20, 12:49 PM · SyntaxHighlight, MediaWiki-Shell
Daimona added a comment to T199989: Pygmentize times out on Windows.

I guess this isn't easy at all. I could experimentally determine what causes the script to hang: it all happens on this line, when reading the first pipe (should be stdin). I also read on the web that stream management is quite bugged on windows from PHP's end, although it's not clear whether those bugs are actually fixed.

Fri, Jul 20, 10:36 AM · SyntaxHighlight, MediaWiki-Shell
Daimona removed a project from T120563: Sorting by hit counts may partly reveal the numbers: Patch-For-Review.
Fri, Jul 20, 8:14 AM · AbuseFilter
Daimona placed T120563: Sorting by hit counts may partly reveal the numbers up for grabs.
Fri, Jul 20, 8:14 AM · AbuseFilter
Daimona placed T198531: Syntax check gets tripped by wild syntax up for grabs.
Fri, Jul 20, 8:13 AM · AbuseFilter

Thu, Jul 19

Daimona created T200036: Throttle filters shown as such on Special:AbuseFilter even without throttled action.
Thu, Jul 19, 6:49 PM · AbuseFilter
Daimona added a comment to T200032: Some wikis have block enabled but don't assign the abusefilter-modify-restricted right to anyone.

I also see that when wmfRealm is 'labs', the action 'block' is enabled but the right is not assigned. However, I actually don't know which sites are affected by this. I'll ask in the appropriate pages of the 2 wikinews above, while waiting for someone who knows what to do with labs.

Thu, Jul 19, 5:52 PM · Wikimedia-Site-requests, AbuseFilter
Daimona created T200032: Some wikis have block enabled but don't assign the abusefilter-modify-restricted right to anyone.
Thu, Jul 19, 5:31 PM · Wikimedia-Site-requests, AbuseFilter
Daimona added a project to T199783: it.wiktionary : request for $wgAbuseFilterAvailableActions[] = 'block': AbuseFilter.

Needs abusefilter-modify-restricted to be assigned. I'll send a patch in a moment.

Thu, Jul 19, 5:16 PM · AbuseFilter, Patch-For-Review, Wikimedia-Site-requests, User-Zoranzoki21
Daimona created T199989: Pygmentize times out on Windows.
Thu, Jul 19, 10:57 AM · SyntaxHighlight, MediaWiki-Shell
Daimona added a comment to T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows).

I determined that it's actually the same problem: using concatenation makes the error disappear. However, this isn't a complete solution, as another problem pops out: the process starts running, but never stops. I guess it's the same as https://www.mediawiki.org/wiki/Topic:Ufijjebcmsvh2lij, for which I'm going to open a separate task.

Thu, Jul 19, 9:39 AM · MediaWiki-Shell, SyntaxHighlight
Daimona merged T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows) into T183759: MediaWiki::shell with parameter fails on Windows.
Thu, Jul 19, 9:37 AM · SyntaxHighlight, MediaWiki-Shell, MediaWiki-extensions-Score
Daimona merged task T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows) into T183759: MediaWiki::shell with parameter fails on Windows.
Thu, Jul 19, 9:37 AM · MediaWiki-Shell, SyntaxHighlight

Wed, Jul 18

Daimona closed T154557: AbuseFilter mobile app edits not flagged as mobile edits as Resolved.
Wed, Jul 18, 6:17 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Mobile, Contributors-Team, AbuseFilter
Daimona awarded T199867: +2 for Huji in mediawiki/* a Like token.
Wed, Jul 18, 2:50 PM · Repository-Ownership-Requests
Daimona awarded T199865: +2 for Matěj Suchánek in mediawiki/* a Like token.
Wed, Jul 18, 2:50 PM · Repository-Ownership-Requests
Volker_E awarded T132284: Convert Special:AbuseFilter to OOUI a Mountain of Wealth token.
Wed, Jul 18, 1:42 PM · MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), User-notice, MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)), MW-1.27-release (WMF-deploy-2016-04-26_(1.27.0-wmf.22)), AbuseFilter, Epic, UI-Standardization
Daimona updated the task description for T42478: AbuseFilter needs regression tests.
Wed, Jul 18, 7:15 AM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Test-Coverage, AbuseFilter
Daimona added a comment to T191699: AbuseLog entries associated with revdel'd revisions are hidden from administrators.

@Huji No, I've been too optimistic while saying that I would have tried to fix both. Per my comment on that task (and the other before), it won't be easy at all.

Wed, Jul 18, 7:12 AM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), AbuseFilter

Tue, Jul 17

Daimona added a comment to T199789: Extension:SyntaxHighlight fail to invoke Pygments.exe on Windows (probably shell exec is broken on Windows).

Same here, a bit more info on MWwiki.

Tue, Jul 17, 11:53 PM · MediaWiki-Shell, SyntaxHighlight
Daimona changed the status of T142176: Abuse filter doesn't record the edit from Open to Stalled.

It's quite hard to help with this. First, edits from 2016 aren't in the recentchanges table anymore, so I can't perform a batch test for that period. Plus, the second link given isn't valid and refers to a not-existent change. Without more info, I probably won't be able to help much. Anyway, I think this might have been some sort of temporary problem, as we have already seen others like this.

Tue, Jul 17, 3:09 PM · TestMe, AbuseFilter
Daimona closed T98119: Abuse filter hit fails the "Examine" interface for the text of the filter as Resolved.

Thanks to T193903 I could finally do the testing directly on enwiki, so I found out some abuselog entries with the described problem, for instance this one. Now, you can easily see that the added text (i.e. added_lines) almost matches a piece of stringy (it's on the second row, it takes few time to find it). I said "almost", because there's a difference, which I'll say explicitly since it's not that big deal: the character "5" from stringy is actually an "S" in the added text, and it would also be trasformed from "5" to "S" by applying normalization to stringy. Probably this is because some old version of equivset changed all S's to 5 and caused the filter to match, while now it doesn't happen anymore and there's no match.

Tue, Jul 17, 1:30 PM · TestMe, AbuseFilter
Daimona merged T199222: Diff page shows diff lines in wrong order into T197157: New diffs show lines in the wrong order.
Tue, Jul 17, 11:52 AM · WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-or-Diffs
Daimona merged task T199222: Diff page shows diff lines in wrong order into T197157: New diffs show lines in the wrong order.
Tue, Jul 17, 11:52 AM · Wikidata, MediaWiki-extensions-Diff
Daimona created T199776: Required doesn't work on multiselect.
Tue, Jul 17, 9:10 AM · MediaWiki-HTMLForm
Daimona added a comment to T197157: New diffs show lines in the wrong order.

I guess T199770 and T195951 are duplicate?

Tue, Jul 17, 9:04 AM · WMDE-QWERTY-Sprint-2018-07-17, wikidiff2, Regression, MediaWiki-History-or-Diffs
Daimona closed T49422: don't update user touched on Special:AbuseLog?wpSearchUser=${ip} reads as Invalid.

Per Legoktm above. I also made some tests and this seems not to happen anymore.

Tue, Jul 17, 8:59 AM · TestMe, Performance, AbuseFilter

Mon, Jul 16

Daimona added a comment to T199506: Investigate possible issues with PostgreSQL.

Yay, thanks. I usually do, but it's quite easy to forget :-)

Mon, Jul 16, 10:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), PostgreSQL, AbuseFilter
Daimona closed T199506: Investigate possible issues with PostgreSQL as Resolved.
Mon, Jul 16, 10:07 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), PostgreSQL, AbuseFilter
Daimona closed T199506: Investigate possible issues with PostgreSQL, a subtask of T199544: Make AbuseFilter work on PostgreSQL and SQLite, as Resolved.
Mon, Jul 16, 10:07 PM · PostgreSQL, SQLite, AbuseFilter
Daimona added a comment to T187865: Don't allow revdel/suppression on Special:Log/abusefilterprivatedetails.

Right, done, thanks.

Mon, Jul 16, 7:31 PM · Patch-For-Review, MediaWiki-Revision-deletion, MediaWiki-Logging, AbuseFilter
Daimona added a comment to T22487: useless autopromotion at every request.

I guess this was mostly fixed in rEABFe008e68b5f30d1ebe3250c3ef4f49d3c8a68530e and also mitigated in rEABF2807b5883a9c4f7bee11ea4e7992c63dd28c0d9e?

Mon, Jul 16, 4:40 PM · Performance, AbuseFilter
Daimona claimed T154557: AbuseFilter mobile app edits not flagged as mobile edits.
Mon, Jul 16, 3:33 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Mobile, Contributors-Team, AbuseFilter
Daimona closed T160239: MediaWiki:Abusefilter-edit-subtitle does not recognize parameter inside a wikilink as Invalid.

I tested it (both on my local wiki and on dewiki) and it works as expected, with the $1 being recognised both inside wikilinks and ifexists. Just a side note on the first version of the message (this one): you can't really expect that a message like that will work forever. It's pretty hacky, and when changing messages or related things in the code it's really hard to mantain compatibility with such stuff.

Mon, Jul 16, 2:54 PM · AbuseFilter
Daimona claimed T187865: Don't allow revdel/suppression on Special:Log/abusefilterprivatedetails.
Mon, Jul 16, 2:00 PM · Patch-For-Review, MediaWiki-Revision-deletion, MediaWiki-Logging, AbuseFilter
Daimona added a comment to T187865: Don't allow revdel/suppression on Special:Log/abusefilterprivatedetails.

I'm looking at this. The main problem is that the core determines whether to add the checkboxes basing on the row log type, here. Since (of course) abusefilterprivatedetails is a stand-alone log not included in suppress log, this means that it's not straightforward to add a non-deletable log without changing the core.

Mon, Jul 16, 1:44 PM · Patch-For-Review, MediaWiki-Revision-deletion, MediaWiki-Logging, AbuseFilter
Daimona added a comment to T191740: Bundle AbuseFilter extension with MW 1.32.

I guess "Extension's default configuration provides optimal experience" is satisfied, but is there a specific requirement list for it? Also, same question for "Tested with web installer".

Mon, Jul 16, 12:45 PM · MW-1.32-release, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona updated the task description for T191740: Bundle AbuseFilter extension with MW 1.32.
Mon, Jul 16, 12:17 PM · MW-1.32-release, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona claimed T49412: Revoking and restoring autopromote groups to users triggering filters ain't logged.
Mon, Jul 16, 12:14 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T49412: Revoking and restoring autopromote groups to users triggering filters ain't logged.

I'm looking at this, and also trying to overhaul blockautopromote. It makes no sense to perform a random block, so I'll just hardcode it to a fixed amount.

Mon, Jul 16, 10:46 AM · Patch-For-Review, AbuseFilter
Daimona closed T106472: Remove "Filter group" column from Special:AbuseFilter main list view as Declined.

Per above, plus the "last hit" column was removed.

Mon, Jul 16, 10:40 AM · AbuseFilter
Daimona assigned T199506: Investigate possible issues with PostgreSQL to matej_suchanek.
Mon, Jul 16, 10:10 AM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), PostgreSQL, AbuseFilter

Sun, Jul 15

Daimona claimed T191694: AbuseFilter list not sorted correctly when ordered by Status.
Sun, Jul 15, 11:58 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T199506: Investigate possible issues with PostgreSQL.

I guess this was fixed in rEABF942a95e80e95466b49f9ac9c14e1e1a249d5a507?

Sun, Jul 15, 10:46 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), PostgreSQL, AbuseFilter
Daimona removed projects from T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit: Patch-For-Review, AbuseFilter.
Sun, Jul 15, 3:52 PM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config
Daimona closed T199621: "Warn" action should be repeated if the action changes as Resolved.
Sun, Jul 15, 3:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, AbuseFilter
Daimona closed T36731: API: Unable to view a log entry specified by its ID as Resolved.
Sun, Jul 15, 3:27 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, AbuseFilter
Daimona lowered the priority of T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit from Unbreak Now! to High.

The urgent part is done.

Sun, Jul 15, 2:36 PM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config
Daimona added a comment to T117737: Convert Special:Log to OOUI.

Indeed. I can do the updates myself, but first I need to understand whether old messages are still meant to be used somewhere, or can be removed.

Sun, Jul 15, 12:49 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, MediaWiki-Logging, UI-Standardization
Daimona added a comment to T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit.

Very likely. Also, the commit above was merged right between the last successful build and the first faulty one.

Sun, Jul 15, 12:27 PM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config
Daimona raised the priority of T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit from High to Unbreak Now!.

Just noticed https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-hhvm-docker/1242/console for Extension:Thanks, and the job is executed (and fails) for the main build as well. I feel this is really UBN!, at least removing the broken test per standard practice.

Sun, Jul 15, 12:01 PM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config
Daimona claimed T199645: No message gets rendered on Special:Log for thanks log.
Sun, Jul 15, 11:41 AM · Growth-Team, Thanks
Daimona added a comment to T199645: No message gets rendered on Special:Log for thanks log.

Same without Vagrant. I'm note sure how those new filters should work, but I guess it's just a missing i18n problem. Will probably need a patch to Thanks extension to add them.

Sun, Jul 15, 11:32 AM · Growth-Team, Thanks
Daimona added a comment to T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit.

I also guess J108 could be related?

Sun, Jul 15, 11:21 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config
Daimona triaged T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit as High priority.

To me this is surely high, given all these unrelated failures. Not setting to UBN! since I'm not completely sure whether this affects other repos as well.

Sun, Jul 15, 10:42 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config
Daimona created T199644: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit.
Sun, Jul 15, 10:41 AM · MediaWiki-Core-Tests, User-zeljkofilipin, Patch-For-Review, MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Continuous-Integration-Config

Sat, Jul 14

Daimona added a comment to T160666: AbuseFilter should use the same account name on all WMF projects.

I think this could be slightly different from other maintenance accounts: AF account can perform lots of action: for instance block, unblock, degroup, re-group, blockautopromote and unblockautopromote (although these last two aren't logged). This means that, on wikis where local config allows such actions, the account can often be found in several logs, and it's nicer for it to have a localised name.

Sat, Jul 14, 2:28 PM · Stewards-and-global-tools, AbuseFilter
Daimona claimed T199621: "Warn" action should be repeated if the action changes.
Sat, Jul 14, 2:19 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, AbuseFilter
Daimona created T199622: Uniform and improve messages shown in case a filter matched the action.
Sat, Jul 14, 2:07 PM · AbuseFilter
Daimona removed a project from T65768: warning message on article deletion / article moving is not parsed: TestMe.

Status of this bug right now: the message is actually parsed, so templates and wikisyntax are correct, though we still have the "You do not have permission to move this page, for the following reason:" message. However, this is actually intended (more or less): to filter "move" actions we use the MovePageCheckPermissions hook, which is indeed intended to check for user permissions. So actually we would need to change the used hook, but is there one which is suitable for our case?

Sat, Jul 14, 1:44 PM · AbuseFilter
Daimona created T199621: "Warn" action should be repeated if the action changes.
Sat, Jul 14, 1:39 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, AbuseFilter
Daimona added a comment to T142656: Automatically disable rarely used Edit Filters.

Agreed that this should be on a per-filter basis. Automatically disabling filters from serverside just because they are staled is a complete WONTFIX, apart from being not that easy to code.

Sat, Jul 14, 12:42 PM · User-Zppix, AbuseFilter
Daimona merged task T20246: Expiry time option, on filters into T142656: Automatically disable rarely used Edit Filters.
Sat, Jul 14, 12:41 PM · AbuseFilter
Daimona merged T20246: Expiry time option, on filters into T142656: Automatically disable rarely used Edit Filters.
Sat, Jul 14, 12:41 PM · User-Zppix, AbuseFilter
Daimona claimed T36731: API: Unable to view a log entry specified by its ID.
Sat, Jul 14, 12:29 PM · MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), Patch-For-Review, AbuseFilter

Fri, Jul 13

Daimona added a comment to T44734: Non-admins can see contents of deleted pages when viewing abusefilter details.

Well, it's true that this problem isn't easy to fix per comments above, otherwise it'd be pretty easy. I also thought of a couple of ways to determine whether the page was deleted, but all of them require having some more info in abuse_filter_log rows. Specifically, having afl_rev_id for page creations: with that, one could check if a revision with such id exists in the 'revision' table so to make a clear distinction. However, I can't see other ideas.

Fri, Jul 13, 11:26 PM · Vuln-Infoleak, Security-Extensions, Security, AbuseFilter
Daimona claimed T191699: AbuseLog entries associated with revdel'd revisions are hidden from administrators.

I'm looking at this, it's quite a simple fix focused on avoiding a string to bool conversion. However, this could make another problem appear, i.e. T44734 for revdel'ed revisions. I'm seizing the opportunity to fix both.

Fri, Jul 13, 10:28 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), AbuseFilter
Daimona added a comment to T115128: AbuseFilter test tools does not work for Flow edits.

The patch above only needs Flow to properly format our entry in /test (and maybe some adjustments for /examine). However, not only I don't know Flow code at all, but I'm also having big problems in making Flow work on my wiki.
I determined that Flow entries aren't shown because the onOldChangesListRecentChangesLine hook returns false. This happens for two reasons: first, here the change is excluded from the view. Second, it doesn't exists in this cache. I'm not really sure about what we should do: maybe change the RC entry on AbuseFilter? Or maybe add specific methods to Flow to handle entries in Special:AbuseFilter/test? I'd appreciate it if someone from Flow would give it a look!

Fri, Jul 13, 9:58 PM · Patch-For-Review, Growth-Team, Collaboration-Team-Triage, StructuredDiscussions, AbuseFilter
Daimona edited subtasks for T191740: Bundle AbuseFilter extension with MW 1.32, added: T199544: Make AbuseFilter work on PostgreSQL and SQLite; removed: T193068: Add support for SQLite and postgre when searching patterns, T42757: Joins on INTEGER and TEXT fail with PostgreSQL, T62639: Database: SQLite and PG are missing columns.
Fri, Jul 13, 2:52 PM · MW-1.32-release, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona removed a parent task for T42757: Joins on INTEGER and TEXT fail with PostgreSQL: T191740: Bundle AbuseFilter extension with MW 1.32.
Fri, Jul 13, 2:52 PM · PostgreSQL, AbuseFilter
Daimona removed a parent task for T62639: Database: SQLite and PG are missing columns: T191740: Bundle AbuseFilter extension with MW 1.32.
Fri, Jul 13, 2:52 PM · SQLite, PostgreSQL, AbuseFilter
Daimona added a parent task for T199544: Make AbuseFilter work on PostgreSQL and SQLite: T191740: Bundle AbuseFilter extension with MW 1.32.
Fri, Jul 13, 2:52 PM · PostgreSQL, SQLite, AbuseFilter
Daimona removed a parent task for T193068: Add support for SQLite and postgre when searching patterns: T191740: Bundle AbuseFilter extension with MW 1.32.
Fri, Jul 13, 2:52 PM · AbuseFilter, PostgreSQL, SQLite
Daimona added subtasks for T199544: Make AbuseFilter work on PostgreSQL and SQLite: T62639: Database: SQLite and PG are missing columns, T42757: Joins on INTEGER and TEXT fail with PostgreSQL, T193068: Add support for SQLite and postgre when searching patterns, T199506: Investigate possible issues with PostgreSQL, T199507: Investigate possible issues with SQLite.
Fri, Jul 13, 2:52 PM · PostgreSQL, SQLite, AbuseFilter
Daimona added a parent task for T42757: Joins on INTEGER and TEXT fail with PostgreSQL: T199544: Make AbuseFilter work on PostgreSQL and SQLite.
Fri, Jul 13, 2:52 PM · PostgreSQL, AbuseFilter
Daimona added a parent task for T62639: Database: SQLite and PG are missing columns: T199544: Make AbuseFilter work on PostgreSQL and SQLite.
Fri, Jul 13, 2:52 PM · SQLite, PostgreSQL, AbuseFilter
Daimona added a parent task for T193068: Add support for SQLite and postgre when searching patterns: T199544: Make AbuseFilter work on PostgreSQL and SQLite.
Fri, Jul 13, 2:52 PM · AbuseFilter, PostgreSQL, SQLite
Daimona added projects to T199544: Make AbuseFilter work on PostgreSQL and SQLite: SQLite, PostgreSQL.
Fri, Jul 13, 2:51 PM · PostgreSQL, SQLite, AbuseFilter
Daimona created T199544: Make AbuseFilter work on PostgreSQL and SQLite.
Fri, Jul 13, 2:51 PM · PostgreSQL, SQLite, AbuseFilter

Wed, Jul 11

Daimona added a comment to T170249: AbuseFilter is near-impossible to test on uploads.

I looked at this. Upload is pretty different from other actions, since it has lot of specific file-related variables to be computed. While filtering the upload we have an UploadBase object from the hook to retrieve such info, however this is not the case for a RC entry. So my question is: do we have a method for retrieving file data from a RC entry? AFAICT, such data is stored in both image and oldimage tables, but they don't seem to be uniquely reachable from RC, if not with timestamp and title. A solution could be, given an RC upload row, to query both image and oldimage tables looking for a match on img_title/oi_name with rc_title and a similar one for timestamp, but it seems poorly efficient to me. Is there a better way?

Wed, Jul 11, 5:23 PM · Patch-For-Review, Multimedia, AbuseFilter
Daimona added a comment to T198974: Rate-limit is too harsh and affects human users.

Agreed that this is truly annoying. Took me a lot of time to file a report due to "concurrent connections".

Wed, Jul 11, 12:06 PM · Patch-For-Review, Phabricator
Daimona created T199317: PHP and SQL errors on screen for xcontribs.
Wed, Jul 11, 11:46 AM · Tool-Erwin's-tools

Tue, Jul 10

Daimona added a comment to T189560: PHP Fatal Error: Class 'Wikimedia\EquivSet\EquivSet' not found.

I guess adding Equivset to vendor will be fine after T191740, or if AntiSpoof will be bundled (since it uses equivset as well). So maybe changing the job would be the best option?

Tue, Jul 10, 8:04 PM · Continuous-Integration-Config, CX-deployments, AbuseFilter
Daimona added a comment to T199252: Search engines continue to link to JS-redirect destination after Wikipedia copyright protest.

I think we already purged common.js several times after the blackout, anyway let's see if it works. As for Google, I don't have a link but I can ask for it if you want. What I can do now is provide an example: try to google "Marea", using a cellphone. The first link to the wikipage actually sends to the landing page, the link being exactly https://it.m.wikipedia.org/wiki/Wikipedia:Comunicato_3_luglio_2018.

Tue, Jul 10, 6:18 PM · Performance-Team, Operations, Traffic, Wikimedia-General-or-Unknown
Daimona added a comment to T199252: Search engines continue to link to JS-redirect destination after Wikipedia copyright protest.

Several users have reported this problem, however they weren't really redirected: instead, while searching stuff on google, google redirected them to the blackout landing page. For many (if not all) of this cases we have determined that google is actually showing the wrong link, which points straight to the blackout page. We also filed a task at google's, and I'm not sure if there's something at MW-side that could be done. Also, this problem (as reported by Nemo), only occurs from mobile, while desktop is totally fine. That being said, I'd like to ask Nemo if he can confirm that google links are wrong in his case as well, or if it's a separate issue.

Tue, Jul 10, 5:58 PM · Performance-Team, Operations, Traffic, Wikimedia-General-or-Unknown
Daimona added a comment to T189560: PHP Fatal Error: Class 'Wikimedia\EquivSet\EquivSet' not found.

And what would be an alternative to having two autoloaders? Anyway, CI is just a case where this problem pops out, but I guess not the only one.

Tue, Jul 10, 1:46 PM · Continuous-Integration-Config, CX-deployments, AbuseFilter
Daimona added a comment to T189560: PHP Fatal Error: Class 'Wikimedia\EquivSet\EquivSet' not found.

@dbarratt Looking at the comments above:

Tue, Jul 10, 1:23 PM · Continuous-Integration-Config, CX-deployments, AbuseFilter
Daimona added a comment to T189560: PHP Fatal Error: Class 'Wikimedia\EquivSet\EquivSet' not found.

@dbarratt I'm not sure how to reproduce this. CI shows this error for REL1_31 branch, see e.g. https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-jessie/46253/console. I also have it on my local wiki, where equivset isn't included in vendor after updates. A composer update solves the problem, although it's not the solution we're looking for.

Tue, Jul 10, 10:06 AM · Continuous-Integration-Config, CX-deployments, AbuseFilter

Mon, Jul 9

Daimona added a comment to T156096: Support empty conditional clauses in the caching parser.

Actually, I think we should get rid of this syntax, with or without the caching parser. This isn't sane at all, and greatly increases the chances of writing a wrong filter. Due to foo& == false, I accidentally made an important itwiki filter stop working for a month, until MusikBot reported it and I could spot a trailing & left by mistake while refactoring. We should probably ask for a query (like in T193894) of use cases in production, fix them and then remove this dangerous syntax.

Mon, Jul 9, 11:32 PM · AbuseFilter
Daimona added a comment to T197002: Make taint-check pass for AbuseFilter.

That's nice! Should we make it voting on CI as soon as it'll pass there?

Mon, Jul 9, 4:13 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), AbuseFilter, Patch-For-Review, phan-taint-check-plugin

Sun, Jul 8

Daimona claimed T42478: AbuseFilter needs regression tests.

I think the above patches will provide a really good test background to start with, and should accomplish the goal of this task. Then, they may be expanded progressively.

Sun, Jul 8, 4:09 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Test-Coverage, AbuseFilter

Sat, Jul 7

Daimona added a comment to T42478: AbuseFilter needs regression tests.

This is what I'm progressively try to add as tests:

  1. Tests for all AFPUserVisibleException exceptions
  2. Tests for filter validation
  3. Tests for generic functions in AbuseFilter class
  4. Complete tests where filters are created, actions are executed and consequences must be taken.

Apart from the latter, everything is under review right now.

Sat, Jul 7, 1:09 PM · MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), Patch-For-Review, Test-Coverage, AbuseFilter
Daimona added a comment to T198890: Provide administrators a tool to enable a serverside blackout on a wiki.

@TerraCodes The ones we've seen for the recent blackout, as I was saying. Itwiki had more ore less three days to decide for a blackout, and there has been some uncertainties until one hour before the effective blackout. Other wikis have had even less time, and in order not to be late they opened short polls (we're talking of a matter of hours, not days), for instance cawiki. Some wikis actually ended up with nothing done because of not enough time left to vote, for instance elwiki. In such a situation, where time is really crucial and should be spent in reaching consensus, communities should have a quick way to enforce their decision. At any rate, this is the classical situation that you can't actually foresee, and for which we need to be ready, no matter how rare such situation could be.

Sat, Jul 7, 8:27 AM · Patch-For-Review, Security-Team, MediaWiki-extension-requests

Fri, Jul 6

Daimona merged T198975: Wikibase causing test failures into T198973: Wikibase tests are failing CI on unrelated changes.
Fri, Jul 6, 3:59 PM · Release-Engineering-Team (Kanban), Wikidata-Campsite, Wikidata, Continuous-Integration-Infrastructure, Wikibase-DataModel-JavaScript
Daimona merged task T198975: Wikibase causing test failures into T198973: Wikibase tests are failing CI on unrelated changes.
Fri, Jul 6, 3:59 PM · MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), Patch-For-Review, Wikibase-DataModel-JavaScript, Wikibase-DataModel, Wikidata-Campsite, Wikidata
Daimona added a comment to T198890: Provide administrators a tool to enable a serverside blackout on a wiki.

Yes, more or less. The period may be relatively short, and may also happen without explicit bilateral communication between communities and WMF (like in this case). In any case, the blackout would be enabled by a sysadmin.

Fri, Jul 6, 1:47 PM · Patch-For-Review, Security-Team, MediaWiki-extension-requests
Daimona added a comment to T198890: Provide administrators a tool to enable a serverside blackout on a wiki.

The idea is to directly transclude the whole page, whatever it is. BTW, the exact timeline I'm thinking of would be this one:

  1. The community, with the approval of WMF, decides to blackout
  2. A patch is created and SWATted as soon as possible. We should adapt the $wgBlackout variable to be used for these cases, so that the patch would only consist of $wgBlackout['Enable'] = true.
  3. The blackout is now enabled, and sysops can change config (landing page, whitelisted groups, almost whatever we want to add)
  4. As the community decides that the blackout should end, the on-wiki config is edited adding "enabled": false, and another patch for serverside deletion is planned for SWAT. This patch is deployed, and the blackout officially ends.
Fri, Jul 6, 1:34 PM · Patch-For-Review, Security-Team, MediaWiki-extension-requests