Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (204 w, 2 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Pronouns: he/him
Babel: it-N, en-3, fr-1, de-1

Recent Activity

Yesterday

Daimona added a comment to T280450: PHP Warning: Cannot modify header information - headers already sent by (output started at /srv/mediawiki/php-1.37.0-wmf.1/includes/MediaWiki.php:817).

This might be a bogus error. Cannot modify header information - headers already sent happens when header() (or a similar function) is called, but some content was already sent. This can happen for lots of different reasons, but usually it is due to a previous PHP warning/notice. Less common is intentional output (e.g. echo), or whitespace before a <?php tag. The error message also says:

Sat, Apr 17, 5:52 PM · Parsoid, Wikimedia-production-error
Daimona updated the task description for T269903: Array shapes not tracked when linking parameters to methods.
Sat, Apr 17, 5:39 PM · Patch-For-Review, phan-taint-check-plugin
Daimona committed rMTPS54e0460ce562: Implement offset-wise backpropagation for assignments and dims (authored by Daimona).
Implement offset-wise backpropagation for assignments and dims
Sat, Apr 17, 3:12 PM
Daimona committed rMTPS7136b598312a: Implement offset-wise backpropagation for the EXECed statement (authored by Daimona).
Implement offset-wise backpropagation for the EXECed statement
Sat, Apr 17, 3:07 PM
Daimona closed T280012: Drop support for old database upgrades from AbuseFilter as Resolved.
Sat, Apr 17, 3:00 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Technical-Debt, AbuseFilter
Daimona committed rMTPS2ca27825c9ba: Store per-offset method links (authored by Daimona).
Store per-offset method links
Sat, Apr 17, 2:41 PM
Daimona committed rMTPS2776cb9d3098: Add more value objects for method links (authored by Daimona).
Add more value objects for method links
Sat, Apr 17, 2:41 PM
Daimona committed rMTPSbb6ef37b77b2: Introduce a value object for method links (authored by Daimona).
Introduce a value object for method links
Sat, Apr 17, 2:41 PM
Daimona committed rMTPS62c5950a43a3: Really upgrade to phan 4.0.4 (authored by Daimona).
Really upgrade to phan 4.0.4
Sat, Apr 17, 2:41 PM
Daimona merged Restricted Task into T272244: AbuseFilter blocks not working for account autocreations.
Sat, Apr 17, 10:36 AM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Vuln-MissingAuthz, AbuseFilter, Security, Security-Team
Daimona created T280439: File:Chessboard480.svg not visible on safari when size is fixed at 208px.
Sat, Apr 17, 10:27 AM · SRE, MediaWiki-General, Browser-Support-Apple-Safari

Fri, Apr 16

Daimona added a project to T257301: Create a web demo for phan taint-check: Continuous-Integration-Config.
Fri, Apr 16, 6:39 PM · Continuous-Integration-Config, Patch-For-Review, phan-taint-check-plugin
Daimona merged T280379: Use newer SonarScanner in WMF CI into T277527: Upgrade sonar-scanner in sonar-scanner docker image in JJB.
Fri, Apr 16, 4:33 PM · Patch-For-Review, Continuous-Integration-Config, Code-Health
Daimona merged task T280379: Use newer SonarScanner in WMF CI into T277527: Upgrade sonar-scanner in sonar-scanner docker image in JJB.
Fri, Apr 16, 4:33 PM · Patch-For-Review, Code-Health, Continuous-Integration-Config
Daimona created T280379: Use newer SonarScanner in WMF CI.
Fri, Apr 16, 4:27 PM · Patch-For-Review, Code-Health, Continuous-Integration-Config

Thu, Apr 15

Daimona added a comment to T257301: Create a web demo for phan taint-check.

Done. There are also a couple of FIXMEs that I'd like to fix shortly, and I should also rebase my fork to upstream (but index.html was removed so it's not straightforward).

Thu, Apr 15, 3:29 PM · Continuous-Integration-Config, Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T257301: Create a web demo for phan taint-check.

but taint-check doesn't because it cannot be found in the virtual FS. I'm currently trying to understand why.

Thu, Apr 15, 3:16 PM · Continuous-Integration-Config, Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T257301: Create a web demo for phan taint-check.

@Legoktm I've just tried packaging php and taint-check separately. It should be doable if we:

Thu, Apr 15, 1:51 PM · Continuous-Integration-Config, Patch-For-Review, phan-taint-check-plugin
Daimona added a comment to T90875: Convert tests/phpunit/phpunit.php entrypoint to plain PHPUnit with bootstrap file.

There could be a FileBackendTestBase with subclasses for each backend. The "proxy" backend classes (FileBackendMultiWrite) could just use MemoryFileBackend instances. The tests for MemoryFileBackend would not need any config. The FSFileBackend subclass could just use the tmp directory. The other FileBackendStore subclass would need site config pointing to a real backend...

If there was a $wgBackendIntegrationTestConfigByClass setting, a map of (full class name => config array), then each test subclass could look for the $wgIntegrationTestBackends entry with the ::class name of the backend subclass. The test would be marked skipped if the config or a driver is missing. The JobQueue could use the same pattern and config variable. Maybe the config variable could go in an IntegrationTestSettings.php file instead of LocalSettings.php, which might avoid some overhead and coupling when running single files in phpunit.

Thu, Apr 15, 11:10 AM · Performance-Team, Patch-For-Review, User-kostajh, Code-Health-Metrics, Technical-Debt, MediaWiki-Core-Testing
Daimona added a comment to T240141: Phan should handle always-throw-function like ApiBase::dieWithError better.

The ultimate fix for this is going to be the never return type implemented in PHP 8.1 (RFC). Upstream issue for supporting that: https://github.com/phan/phan/issues/4380.

Thu, Apr 15, 9:45 AM · Upstream, phan
Daimona added a comment to T234240: Phan should work out of the box on MediaWiki-Vagrant.

Though https://packages.debian.org/buster/php-ast might be a bit too old..

Thu, Apr 15, 9:09 AM · MediaWiki-Vagrant, phan
Daimona added a comment to T280170: Add pcov to composer images.

Thinking about this again, I think it would make more sense to install pcov in the base PHPXY images, since xdebug is installed there, and it'd be easier to reuse. My next question is: is there a specific reason for not using sury-php in the PHP 7.2 image? Being able to install pcov there would possiblycould make it easier to run tests with coverage; for instance, for T279423 I'd have to hack the phpunit command so it doesn't generate coverage on PHP 7.2.

Thu, Apr 15, 8:42 AM · Patch-For-Review, Continuous-Integration-Infrastructure

Wed, Apr 14

Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov as Resolved.

It works.

Wed, Apr 14, 6:16 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona closed T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1" as Resolved.

It works.

Wed, Apr 14, 6:16 PM · Continuous-Integration-Infrastructure
Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min, as Resolved.
Wed, Apr 14, 6:16 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Patch-For-Review, Developer Productivity, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config
Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T232706: mwcore-phpunit-coverage-master times out after 5 hours, as Resolved.
Wed, Apr 14, 6:16 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T269489: composer-package-php72-docker runs with xdebug enabled, as Resolved.
Wed, Apr 14, 6:16 PM · Continuous-Integration-Config
Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T279423: Enable coverage reports for taint-check, as Resolved.
Wed, Apr 14, 6:16 PM · phan-taint-check-plugin
Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1", as Resolved.
Wed, Apr 14, 6:16 PM · Continuous-Integration-Infrastructure
Daimona closed T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T280167: Tweak pcov ini settings, as Resolved.
Wed, Apr 14, 6:16 PM · Continuous-Integration-Config
Daimona added a comment to T280170: Add pcov to composer images.

AFAICS, it can be installed either in the composer-package-phpXX images or the more base phpXX (which is where xdebug is also installed). Regardless of this, it cannot be installed for PHP 7.2 because it doesn't use sury-php, so this change would affect PHP >= 7.3. https://gerrit.wikimedia.org/g/integration/config/+/da9ffb4ef300862a1c4ba164d6f697b50091584f/jjb/misc.yaml#45 should be updated, too.

Wed, Apr 14, 6:09 PM · Patch-For-Review, Continuous-Integration-Infrastructure
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min, as Open.
Wed, Apr 14, 6:02 PM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Patch-For-Review, Developer Productivity, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T232706: mwcore-phpunit-coverage-master times out after 5 hours, as Open.
Wed, Apr 14, 6:02 PM · Release-Engineering-Team-TODO (2020-04 to 2020-06 (Q4)), Release-Engineering-Team (CI & Testing services), Continuous-Integration-Infrastructure, Test-Coverage
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T269489: composer-package-php72-docker runs with xdebug enabled, as Open.
Wed, Apr 14, 6:02 PM · Continuous-Integration-Config
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1", as Open.
Wed, Apr 14, 6:02 PM · Continuous-Integration-Infrastructure
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T279423: Enable coverage reports for taint-check, as Open.
Wed, Apr 14, 6:02 PM · phan-taint-check-plugin
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov, a subtask of T280167: Tweak pcov ini settings, as Open.
Wed, Apr 14, 6:02 PM · Continuous-Integration-Config
Daimona reopened T234020: Switch mediawiki code coverage from xdebug to pcov as "Open".

Apparently we also need to do core (T234020#6987347), as the job is still broken by xdebug (T280064).

Wed, Apr 14, 6:02 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona reopened T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1" as "Open".

Still fails for MW core, see https://integration.wikimedia.org/ci/job/mwcore-phpunit-coverage-patch/28456/console. That job still uses xdebug, see T234020#6987347.

Wed, Apr 14, 6:00 PM · Continuous-Integration-Infrastructure
Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to pcov.

A quick preview of the improvement (for GrowthExperiments):

Wed, Apr 14, 5:57 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona closed T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1" as Resolved.

Should be resolved now.

Wed, Apr 14, 4:55 PM · Continuous-Integration-Infrastructure
Daimona added a parent task for T234020: Switch mediawiki code coverage from xdebug to pcov: T280167: Tweak pcov ini settings.
Wed, Apr 14, 4:45 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a subtask for T280167: Tweak pcov ini settings: T234020: Switch mediawiki code coverage from xdebug to pcov.
Wed, Apr 14, 4:45 PM · Continuous-Integration-Config
Daimona created T280167: Tweak pcov ini settings.
Wed, Apr 14, 4:45 PM · Continuous-Integration-Config
Daimona added a comment to T280161: Make it easier to run phan locally in Wikibase.

Not sure if this is what you meant, but vendor/bin/phan -d . --long-progress-bar will work. It's not very user-friendly, but AFAIK LibUp should add a composer script shortcut (composer phan) the next time it pushes something.

Wed, Apr 14, 4:36 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), phan, Wikibase, wdwb-tech
Daimona awarded T277008: Server fabula outage, www.wikimedia.it offline (provider incident) a Burninate token.
Wed, Apr 14, 4:03 PM · WMIT-Infrastructure
Daimona updated the task description for T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1".
Wed, Apr 14, 2:48 PM · Continuous-Integration-Infrastructure
Daimona added a comment to T277466: Deleted block log entries causes non-relevant block entries to be shown on Special:Contributions .

Above is my stab at it, implementing the solution I outlined above.

Wed, Apr 14, 2:44 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-Blocks
Daimona added a comment to T277466: Deleted block log entries causes non-relevant block entries to be shown on Special:Contributions .

As being discussed on the patch above, there are security concerns to doing this. Capturing what @DannyS712 wrote on the patch: [...]

Wed, Apr 14, 2:08 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-Blocks
Daimona triaged T280101: Add a page protection feature to Abuse Filter as Lowest priority.

Sounds like this can be done with a throttle set to page. See https://www.mediawiki.org/wiki/Extension:AbuseFilter/Actions#Throttling

Wed, Apr 14, 10:13 AM · MediaWiki-Page-protection, AbuseFilter

Tue, Apr 13

Daimona added a parent task for T234020: Switch mediawiki code coverage from xdebug to pcov: T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1".
Tue, Apr 13, 11:17 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a subtask for T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1": T234020: Switch mediawiki code coverage from xdebug to pcov.
Tue, Apr 13, 11:17 PM · Continuous-Integration-Infrastructure
Daimona added a comment to T280064: Post-merge builds failing with "Command 'mwext-phpunit-coverage' returned non-zero exit status 1".

Most probably related to the ongoing work at T234020; specifically, I guess it could be related to T279833.

Tue, Apr 13, 11:16 PM · Continuous-Integration-Infrastructure
Daimona added a comment to T191740: Bundle AbuseFilter extension with MediaWiki.

Sorry, I was insufficiently clear. Support for postgres and sqlite is a requirement for bundling extensions.

That's fine, we can just move this to 1.37. :-)

Tue, Apr 13, 3:43 PM · MW-1.37-release, AbuseFilter (Overhaul-2020), Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona changed the status of T220791: afl_filter should be split in afl_filter_id and afl_global from Open to Stalled.

We cannot proceed until 1.38, when we'll remove the old schema.

Tue, Apr 13, 12:28 PM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), AbuseFilter (Overhaul-2020), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review
Daimona changed the status of T220791: afl_filter should be split in afl_filter_id and afl_global, a subtask of T93564: Addition of last hit date to Special:AbuseFilter table, from Open to Stalled.
Tue, Apr 13, 12:27 PM · Data-Persistence (Consultation), User-Daimona, Patch-For-Review, Stewards-and-global-tools, WMF-deploy-2015-07-21_(1.26wmf15), AbuseFilter
Daimona changed the status of T220791: afl_filter should be split in afl_filter_id and afl_global, a subtask of T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic), from Open to Stalled.
Tue, Apr 13, 12:27 PM · Epic, PostgreSQL, SQLite, AbuseFilter
Daimona changed the status of T220791: afl_filter should be split in afl_filter_id and afl_global, a subtask of T259377: Migrate AbuseFilter to Abstract Schema, from Open to Stalled.
Tue, Apr 13, 12:27 PM · AbuseFilter
Daimona claimed T280012: Drop support for old database upgrades from AbuseFilter.
Tue, Apr 13, 12:12 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Technical-Debt, AbuseFilter
Daimona added a parent task for T259771: RFC: Drop support for older database upgrades: T280012: Drop support for old database upgrades from AbuseFilter.
Tue, Apr 13, 12:02 PM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Stakeholders-Group, Platform Engineering
Daimona added a subtask for T280012: Drop support for old database upgrades from AbuseFilter: T259771: RFC: Drop support for older database upgrades.
Tue, Apr 13, 12:02 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Technical-Debt, AbuseFilter
Daimona created T280012: Drop support for old database upgrades from AbuseFilter.
Tue, Apr 13, 12:01 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Technical-Debt, AbuseFilter
Daimona added a comment to T259771: RFC: Drop support for older database upgrades.

The task description says:

Tue, Apr 13, 11:16 AM · MW-1.36-notes, MW-1.37-notes (1.37.0-wmf.1; 2021-04-13), User-Ladsgroup, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Stakeholders-Group, Platform Engineering
Daimona updated the task description for T220791: afl_filter should be split in afl_filter_id and afl_global.
Tue, Apr 13, 10:03 AM · MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), AbuseFilter (Overhaul-2020), MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review
Daimona added a comment to T274158: Improve revision visibility after recent security patches.

(Reopening since I missed the second bullet. That one is blocked on the subtask)

Tue, Apr 13, 10:03 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), SecTeam-Processed, AbuseFilter, Security, Security-Team
Daimona reopened T274158: Improve revision visibility after recent security patches as "Open".
Tue, Apr 13, 10:02 AM · MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), SecTeam-Processed, AbuseFilter, Security, Security-Team
Daimona reopened T274158: Improve revision visibility after recent security patches, a subtask of T273970: Adjust visibility of AbuseLog entries and related items, as Open.
Tue, Apr 13, 10:02 AM · AbuseFilter (Overhaul-2020)
Daimona added a comment to T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36.

I think it's reasonable to put in the release notes that people should run the migration script. The vast majority of sysadmins won't have AbuseFilter installed, and the few that already installed it manually will have a small single extra task alongside the others they already have. I think expecting it in 1.36 is fine.

Tue, Apr 13, 10:01 AM · MediaWiki-Stakeholders-Group, Epic, MediaWiki-Releasing, MW-1.36-release, MediaWiki-Installer
Daimona removed a subtask for T191740: Bundle AbuseFilter extension with MediaWiki: T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic).
Tue, Apr 13, 10:00 AM · MW-1.37-release, AbuseFilter (Overhaul-2020), Patch-For-Review, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona removed a parent task for T199544: Make AbuseFilter work on PostgreSQL and SQLite (epic): T191740: Bundle AbuseFilter extension with MediaWiki.
Tue, Apr 13, 10:00 AM · Epic, PostgreSQL, SQLite, AbuseFilter
Daimona added a comment to T279976: Phan failed to notice second arg passed to a method that only takes one.

The first line of that file reads

Tue, Apr 13, 9:59 AM · MediaWiki-Core-Testing, phan

Mon, Apr 12

Daimona created T279922: Enforce usage of java-like array union types instead of PSR5-style.
Mon, Apr 12, 1:12 PM · MediaWiki-Codesniffer
Daimona added a comment to T246381: Expand the set of bundled extensions and skins in MediaWiki 1.36.

I'm optimistic that we might achieve AbuseFilter, but none of the others at this point. No pressure, @Daimona. :-)

Mon, Apr 12, 10:03 AM · MediaWiki-Stakeholders-Group, Epic, MediaWiki-Releasing, MW-1.36-release, MediaWiki-Installer

Sun, Apr 11

Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to pcov.

Memo: I missed some usages. I guess these can be migrated later. I also haven't checked whether pcov should be installed in more images for those jobs to be migrated.

Sun, Apr 11, 11:16 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a parent task for T234020: Switch mediawiki code coverage from xdebug to pcov: T269489: composer-package-php72-docker runs with xdebug enabled.
Sun, Apr 11, 11:15 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a subtask for T269489: composer-package-php72-docker runs with xdebug enabled: T234020: Switch mediawiki code coverage from xdebug to pcov.
Sun, Apr 11, 11:15 AM · Continuous-Integration-Config
Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to pcov.

Oh, I just realized why. It's not a zend extension. It should be loaded with just "extension". Local testing confirms, and on my local install, I've always had "extension" too, so I'm not sure how I couldn't get it right.

Sun, Apr 11, 10:19 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to pcov.

I think the actual issue is a few lines above:

Sun, Apr 11, 10:12 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage

Sat, Apr 10

Daimona created T279833: Switch coverage jobs to PHP >= 7.3.
Sat, Apr 10, 6:05 PM · Continuous-Integration-Config, MediaWiki-Core-Testing, Test-Coverage

Fri, Apr 9

Daimona added a comment to T240889: Mobile IP editors not given any indication that they have new messages.

While I agree that this bug is really serious (being able to communicate is possibly the most important thing in a community), I'd also like to point out that the underlying issue is not just "we're not showing notifications to logged out users on the mobile version". The real issue is: "The mobile version doesn't show any notification if Echo is not installed". That is, without Echo, even registered users won't get any notification on the mobile version.

Fri, Apr 9, 2:43 PM · Growth-Team-Filtering, MinervaNeue (Tracking), Notifications, Growth-Team
Daimona added a comment to T234020: Switch mediawiki code coverage from xdebug to pcov.

Memo: I missed some usages. I guess these can be migrated later. I also haven't checked whether pcov should be installed in more images for those jobs to be migrated.

Fri, Apr 9, 12:41 PM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a comment to T279772: Allow loading global filters in /examine and the like.

Hmm I spoke too soon. The filter is loaded client-side using the QueryAbuseFilters API module. This means that we should first allow global filters to be searched via this API module, which is also a broader change (which I think would be fine). The real problem is that this module queries the database directly (as opposed to using FilterLookup), so it's not immediate to make it work with global filters. In fact, I don't even know whether query modules are supposed to query foreign databases. It might be doable with some hacks, but I'd rather not hack something if it's not supposed to be done.

Fri, Apr 9, 11:53 AM · AbuseFilter
Daimona created T279772: Allow loading global filters in /examine and the like.
Fri, Apr 9, 11:02 AM · AbuseFilter

Thu, Apr 8

valerio.bozzolan awarded T272333: Disallow the edit if blocking the user didn't succeed a Doubloon token.
Thu, Apr 8, 7:29 PM · Vuln-MissingAuthz, AbuseFilter, Security, Security-Team
Daimona added a comment to T203651: Optimize phan-taint-check speed.

I managed to fix my issue with kcachegrind so I was able to load bigger cachegrind files. I also managed to profile a complete run on AbuseFilter, after removing vendor and a part of core from the parsing phase (so it only had 1500 files to parse), which gave a 6G cachegrind file. However, I believe that it's not possible to do better, unless and until code filtering is implemented in xdebug (https://bugs.xdebug.org/view.php?id=1670). That would hopefully create much smaller cachegrind files, and also clearer output.

Thu, Apr 8, 12:36 PM · Patch-For-Review, phan-taint-check-plugin
Daimona committed rMTPS8a296b3ff65d: Store variadic parameters in a special property (authored by Daimona).
Store variadic parameters in a special property
Thu, Apr 8, 3:07 AM
Daimona committed rMTPS41e446df38ef: More performance improvements (authored by Daimona).
More performance improvements
Thu, Apr 8, 3:03 AM

Tue, Apr 6

Daimona added a comment to T277466: Deleted block log entries causes non-relevant block entries to be shown on Special:Contributions .

What should the placeholder say?

Tue, Apr 6, 11:22 AM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-Blocks
Daimona added a parent task for T234020: Switch mediawiki code coverage from xdebug to pcov: T279423: Enable coverage reports for taint-check.
Tue, Apr 6, 10:39 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a subtask for T279423: Enable coverage reports for taint-check: T234020: Switch mediawiki code coverage from xdebug to pcov.
Tue, Apr 6, 10:39 AM · phan-taint-check-plugin
Daimona removed a subtask for T234020: Switch mediawiki code coverage from xdebug to pcov: T279423: Enable coverage reports for taint-check.
Tue, Apr 6, 10:39 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona removed a parent task for T279423: Enable coverage reports for taint-check: T234020: Switch mediawiki code coverage from xdebug to pcov.
Tue, Apr 6, 10:39 AM · phan-taint-check-plugin
Daimona added a comment to T279423: Enable coverage reports for taint-check.

Integration tests only might still run reasonabley quick

Tue, Apr 6, 10:39 AM · phan-taint-check-plugin
Daimona updated the task description for T279423: Enable coverage reports for taint-check.
Tue, Apr 6, 10:36 AM · phan-taint-check-plugin
Daimona added a subtask for T234020: Switch mediawiki code coverage from xdebug to pcov: T279423: Enable coverage reports for taint-check.
Tue, Apr 6, 10:24 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO, Patch-For-Review, Continuous-Integration-Config, Test-Coverage
Daimona added a parent task for T279423: Enable coverage reports for taint-check: T234020: Switch mediawiki code coverage from xdebug to pcov.
Tue, Apr 6, 10:24 AM · phan-taint-check-plugin
Daimona created T279423: Enable coverage reports for taint-check.
Tue, Apr 6, 10:24 AM · phan-taint-check-plugin

Mon, Apr 5

Daimona added a project to T279265: A linter could report unneeded/unused pass-by-references in php code: Upstream.

I think this goes well beyond the scope of PHPCS. Phan has similar functionality in VariableTrackerPlugin, but not this specific feature. https://github.com/phan/phan/issues/2092 asks for that, so I guess it's a matter of waiting for it to be implemented upstream.

Mon, Apr 5, 2:31 PM · Upstream, MediaWiki-Codesniffer, phan
Daimona added a comment to T279283: Jenkins failing on all patches, "This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository".

FTR, this is still broken. Not sure if anybody noticed, given that the priority was lowered to normal. See r676890 for an example (5 mins ago).

Mon, Apr 5, 2:24 PM · Patch-For-Review, Release-Engineering-Team, Continuous-Integration-Infrastructure
Daimona added a comment to T279267: $maintClass in maintenance class files should be set with ::class name resolution.

I think this specific instance can be resolved with PHPCS. We'd only be looking for a variable named $maintClass in the global scope in a maintenance script, as long as there's nothing more, codesniffer would suffice.

Mon, Apr 5, 2:21 PM · MediaWiki-extensions-General, MediaWiki-General, Epic, phan, MediaWiki-Codesniffer