Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (122 w, 3 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Babel: it-N, en-3, fr-1

Recent Activity

Today

Daimona added a comment to T233489: CentralAuth and local account creation are not working on beta cluster wikis.

Hah, right, they're report only. Aside from that, the second call to validateSession would be a good candidate.

Sun, Sep 22, 6:46 PM · Beta-Cluster-Infrastructure
Daimona updated subscribers of T233489: CentralAuth and local account creation are not working on beta cluster wikis.

My first thought would be that there's something wrong with the tokens. However, if I try to log in with the browser console open, I see:

Sun, Sep 22, 6:36 PM · Beta-Cluster-Infrastructure
Daimona added a comment to T233523: Integration tests shows errors related to special pages.

17:34:54 Error: Call to private method Editcount::extractParameters() from context 'SpecialGlobalEditcount'

Sun, Sep 22, 6:29 PM · GlobalContribs
Daimona removed a subtask for T191740: Bundle AbuseFilter extension with MediaWiki: Unknown Object (Task).
Sun, Sep 22, 5:25 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona added a comment to T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.

@Krinkle I was able to find the data on graphite. So, is there anything actionable, or should we just keep collecting data for a while?

Sun, Sep 22, 5:00 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona added a comment to T209700: Add support for Pygments ran as CGI application via HTTP.

I tested it locally. The error is only caused by line 337; line 355 appears in the report just because of another assignment. Message::toString is a bit confusing for the plugin, so it's probably just a false positive.

Sun, Sep 22, 4:59 PM · Patch-For-Review, SyntaxHighlight
Daimona added a comment to T209700: Add support for Pygments ran as CGI application via HTTP.

It's complaining because $error is double escaped, hence wfWarn would show double-escaped entities. According to the error message, that's caused by lines 337 and 355. First of all, we'd have to figure out whether double escaping is really taking place.

Sun, Sep 22, 4:38 PM · Patch-For-Review, SyntaxHighlight
Daimona added a comment to T230256: Some abuse filters stopped matching after empty data introduction.

OK, so, there are lots of affected filters. Searching channel:AbuseFilter AND "unset variable" for the last 15 minutes yield 150000 results. Hence, I think we should take a step back, and keep returning NULL in strict mode.

Sun, Sep 22, 2:31 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Patch-For-Review, User-notice, AbuseFilter

Fri, Sep 20

Daimona updated subscribers of T233453: Couldn't fetch revision cu_changes table links to (cuc_this_oldid xxxx).

T207094

Fri, Sep 20, 8:43 PM · User-Urbanecm, Wikimedia-production-error, CheckUser
Daimona changed the status of T231636: Butcher the list of phan suppressions in MW core from Open to Stalled.

The remaining issues are blocked on dropping HHVM support, so that we can use real variargs and nullable types to avoid false positives.

Fri, Sep 20, 10:21 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), phan, MediaWiki-Core-Testing
Elitre awarded T230272: 404 error when using VisualEditor: apierror-visualeditor-docserver-http a 100 token.
Fri, Sep 20, 8:52 AM · User-notice, Core Platform Team Workboards (Clinic Duty Team), RESTBase, VisualEditor (Current work)

Thu, Sep 19

Daimona claimed T233324: Allow privileged users to see deleted edits on Special:AbuseLog.

No guarantees, but I'm trying to see what we can do.

Thu, Sep 19, 4:10 PM · Patch-For-Review, AbuseFilter
Daimona created T233324: Allow privileged users to see deleted edits on Special:AbuseLog.
Thu, Sep 19, 3:58 PM · Patch-For-Review, AbuseFilter
Daimona closed Restricted Task, a subtask of T191740: Bundle AbuseFilter extension with MediaWiki, as Resolved.
Thu, Sep 19, 2:25 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona added a comment to T193068: Add support for SQLite and postgre when searching patterns.

Change 538026 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Use PHP regexps instead of SQL to filter results on Special:AbuseFilter
https://gerrit.wikimedia.org/r/538026

Thu, Sep 19, 1:55 PM · Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, AbuseFilter, PostgreSQL, SQLite
Daimona awarded Blog Post: Wikipedia's JavaScript initialisation on a budget a Yellow Medal token.
Thu, Sep 19, 11:11 AM

Wed, Sep 18

Daimona created T233222: Factor rev_deleted logic out of the API modules.
Wed, Sep 18, 3:31 PM · Technical-Debt, Core Platform Team, MediaWiki-Revision-backend
zeljkofilipin awarded T214478: The first Selenium test for AbuseFilter a Like token.
Wed, Sep 18, 2:13 PM · Release-Engineering-Team-TODO (201909), AbuseFilter, User-zeljkofilipin
Daimona added a subtask for T191740: Bundle AbuseFilter extension with MediaWiki: Unknown Object (Task).
Wed, Sep 18, 12:32 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona removed a project from T214478: The first Selenium test for AbuseFilter: Patch-For-Review.
Wed, Sep 18, 12:17 PM · Release-Engineering-Team-TODO (201909), AbuseFilter, User-zeljkofilipin
Daimona closed T214478: The first Selenium test for AbuseFilter, a subtask of T206621: 5 of the 15 prioritized repositories have at least 1 end-to-end test, as Resolved.
Wed, Sep 18, 12:17 PM · Release-Engineering-Team (Kanban), User-zeljkofilipin
Daimona closed T214478: The first Selenium test for AbuseFilter as Resolved.

Thanks Željko!

Wed, Sep 18, 12:17 PM · Release-Engineering-Team-TODO (201909), AbuseFilter, User-zeljkofilipin
Daimona updated the task description for T214478: The first Selenium test for AbuseFilter.
Wed, Sep 18, 12:17 PM · Release-Engineering-Team-TODO (201909), AbuseFilter, User-zeljkofilipin
Daimona added a comment to T233200: Unable to save change on any page using Translate git master: "Call to undefined method WikitextContent::getText()" on MW1.32/1.33.

Looking at the TranslateHooks file in REL1_32, there's no call to getText. That's because it was introduced with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Translate/+/500243/, which is in master, but not even in 1.33. Since you said you're using MediaWiki 1.32, that would explain the problem here. You should use the 1.32 version of Translate with it.

Wed, Sep 18, 10:16 AM · MediaWiki Language Extension Bundle, MediaWiki-extensions-Translate

Tue, Sep 17

Daimona claimed T231112: Rethink slow filters and profiling after enabling CachingParser.

The implementation above should be good. Ensuring as few cache miss as possible could be the scope of another task, to be opened after looking at prod results.

Tue, Sep 17, 5:45 PM · Patch-For-Review, Performance-Team (Radar), AbuseFilter
Daimona added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.

Yes, of course it matters for that wiki. But if we write both fields, shouldn't it be always fine for that wiki? The other value would just be ignored.

Writing both fields breaks if the "foreign" wiki is in stage 0 or 6.

Tue, Sep 17, 5:21 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Daimona added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.

but we don't have to worry about a case where someone didn't run update.php.

Tue, Sep 17, 5:09 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Daimona added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.

No, you can add them all at the same time. The idea for "0 and 1" is that you need to make sure the new schema is deployed on the DBs of every wiki in your wikifarm before you move on to stage 2.

Tue, Sep 17, 4:22 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Daimona moved T212730: Change the syntax for non-decimal numbers from Backlog to Deprecate/Remove on the MW-1.34-release board.

The deprecation should happen in 1.34.

Tue, Sep 17, 1:34 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-Daimona, AbuseFilter
Daimona added a project to T212730: Change the syntax for non-decimal numbers: MW-1.34-release.
Tue, Sep 17, 1:34 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), User-Daimona, AbuseFilter
Daimona moved T156096: Deprecate and then reject empty operators from Backlog to Deprecate/Remove on the MW-1.34-release board.

The deprecation should happen in 1.34.

Tue, Sep 17, 1:32 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona added a project to T156096: Deprecate and then reject empty operators: MW-1.34-release.
Tue, Sep 17, 1:32 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona moved T230803: The parser should keep a list of variadic functions, and strictly check the amount of parameters for the other functions from Backlog to Deprecate/Remove on the MW-1.34-release board.

The deprecation should happen in 1.34.

Tue, Sep 17, 1:31 PM · MW-1.34-release, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Patch-For-Review, AbuseFilter
Daimona added a project to T230803: The parser should keep a list of variadic functions, and strictly check the amount of parameters for the other functions: MW-1.34-release.
Tue, Sep 17, 1:31 PM · MW-1.34-release, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Patch-For-Review, AbuseFilter
Daimona added a comment to T220791: afl_filter should be split in afl_filter_id and afl_global.

Yes, I did. One of these days I even intend to write up all the details as a blog post or something, but for now I'll give the quick overview.

Tue, Sep 17, 10:29 AM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter

Mon, Sep 16

Daimona added a subtask for T191740: Bundle AbuseFilter extension with MediaWiki: Unknown Object (Task).
Mon, Sep 16, 2:19 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona updated the task description for T230803: The parser should keep a list of variadic functions, and strictly check the amount of parameters for the other functions.
Mon, Sep 16, 1:56 PM · MW-1.34-release, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Patch-For-Review, AbuseFilter
Daimona updated the task description for T156096: Deprecate and then reject empty operators.
Mon, Sep 16, 1:56 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona moved T230803: The parser should keep a list of variadic functions, and strictly check the amount of parameters for the other functions from Requiring manual fix of filters in production to Backlog on the AbuseFilter board.

No affected filters in production.

Mon, Sep 16, 1:55 PM · MW-1.34-release, MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), Patch-For-Review, AbuseFilter
Daimona moved T156096: Deprecate and then reject empty operators from Requiring manual fix of filters in production to Backlog on the AbuseFilter board.
Mon, Sep 16, 1:54 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona moved T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser) from Requiring manual fix of filters in production to Internal bugs on the AbuseFilter board.
Mon, Sep 16, 1:53 PM · AbuseFilter
Daimona updated the task description for T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Mon, Sep 16, 1:50 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona added a comment to T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.

@Krinkle Production is now CachingParser-ready! Hence, we can start the deploy whenever you're available. I'm also on IRC right now, in case you want to schedule a day and time when I'm available to oversee the transition.

Mon, Sep 16, 1:49 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona updated the task description for T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Mon, Sep 16, 1:47 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona closed T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser), a subtask of T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe, as Resolved.
Mon, Sep 16, 1:46 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona closed T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser) as Resolved.
Mon, Sep 16, 1:46 PM · AbuseFilter
Daimona added a comment to T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser).

wmf.22 is now everywhere, so I checked logstash. We don't have any filter using trailing commas for non-variadic functions. Hence, I'm going to close this task per plan in the description.

Mon, Sep 16, 1:46 PM · AbuseFilter
Daimona added a comment to T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser).

Linked version of T153251#5464352:

Mon, Sep 16, 11:24 AM · AbuseFilter
Daimona closed T232962: AbuseFilterViewEdit: Show "Test this filter against recent edits" to all users who can use it as Resolved.
Mon, Sep 16, 10:03 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, AbuseFilter
Daimona added a comment to T34959: Private filters should not be visible in recent changes.

This is actually doable, we only need to set a LogRestriction on abusefilter log (the one in Special:Log for creations/edits). The question is: who should be able to see it? To me abusefilter-view-private sounds like an exaggeration, while abusefilter-view may be reasonable.

Claiming to add the requirement that users have abusefilter-view in order to be able to view abusefilter log entries (log entries in Special:Log, not in Special:AbuseLog)

Mon, Sep 16, 9:47 AM · User-DannyS712, AbuseFilter

Sun, Sep 15

Daimona updated subscribers of T220791: afl_filter should be split in afl_filter_id and afl_global.

So, @matej_suchanek noted that there's a big trouble in the patch. We have a variable with the migration stage for the current DB, but sometimes we'll also have to insert data in a foreign DB (e.g. for edits on some wikis, we could have to update meta). The foreign DB may have a different migration stage. How could this be handled in a non-WMF-specific way?

Sun, Sep 15, 7:43 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Daimona added a comment to T232613: LBFactoryMulti.php: PHP Notice: Undefined index: .

Mentioned in SAL (#wikimedia-operations) [2019-09-15T14:35:00Z] <_joe_> test: setting opcache.interned_strings_buffer to 0 on mw1348 for T232613

Sun, Sep 15, 6:45 PM · Patch-For-Review, MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), Core Platform Team Workboards (Clinic Duty Team), Wikimedia-Rdbms, PHP 7.2 support, Wikimedia-production-error
Daimona updated the task description for T153251: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser).
Sun, Sep 15, 6:12 PM · AbuseFilter
Daimona updated the task description for T156096: Deprecate and then reject empty operators.
Sun, Sep 15, 6:12 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona updated the task description for T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Sun, Sep 15, 6:11 PM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona updated the task description for T156096: Deprecate and then reject empty operators.
Sun, Sep 15, 6:10 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona added a comment to T156096: Deprecate and then reject empty operators.

Little update: production filters now seem to be OK. Next steps here are:

  • Formally deprecate empty operands with logging (either via wfDeprecated, or stating it clearly in the message)
  • Before switching to CachingParser, re-check logstash to ensure no new problems (hence leaving open as subtask)
  • Change logEmptyOperand to be e.g. throwEmptyOperand and throw [in a future MW version]
Sun, Sep 15, 6:09 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona added a comment to T156096: Deprecate and then reject empty operators.

(Uh-oh, edit conflict)

What I am trying to figure out is why in that RFC we never mentioned that there exists a group of sysadmins, yourself included, that already have the rights and permissions to modify filters for technical reasons only.

Sun, Sep 15, 5:36 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona added a comment to T156096: Deprecate and then reject empty operators.

If we already have a user (Krinkle) who is allowed to do this for wikis like fawiki (which has a large, active admin group and is in the opt-out list for Global Sysop), then why the RfC?

Sun, Sep 15, 5:30 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona added a comment to T156096: Deprecate and then reject empty operators.

Linked list:

Sun, Sep 15, 4:19 PM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona merged T232651: Phan should warn if wfDeprecated() is called with non-string parameters into T232949: Strengthen phan's default config.
Sun, Sep 15, 3:29 PM · phan
Daimona merged task T232651: Phan should warn if wfDeprecated() is called with non-string parameters into T232949: Strengthen phan's default config.
Sun, Sep 15, 3:29 PM · phan, MediaWiki-Core-Testing
Daimona created T232949: Strengthen phan's default config.
Sun, Sep 15, 3:28 PM · phan
Daimona closed T232916: Prevent blocked users from using Special:AbuseFilter/revert as Resolved.
Sun, Sep 15, 12:10 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), AbuseFilter
Daimona placed T230066: TagMultiselectWidget: the input field is editable even if the widget is disabled up for grabs.
Sun, Sep 15, 11:57 AM · OOUI, User-DannyS712, AbuseFilter
Daimona added a comment to T156096: Deprecate and then reject empty operators.

So, now this is again the only blocker for the new parser (together with T153251, but they're actually the same thing). The tech news issue asking people to fix filters was published 6 days ago. While it's not that much time, I went to logstash to check how we're doing. And... We're not doing good. Here is the trend over the last 7 days [1]; we can say it has remained constant. If it keeps staying constant, I wonder what we could do to get things done quicker. The outcome of the meta RFC is distant and uncertain, hence it's not something we'll be able to use for this task anyway. I wonder, is the sysadmin group usable for this?

Sun, Sep 15, 11:56 AM · MW-1.34-release, Patch-For-Review, MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-notice, User-Daimona, AbuseFilter
Daimona updated the task description for T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe.
Sun, Sep 15, 11:44 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona closed T230982: Rewrite the code for hoisting variables in skipped branches for CachingParser, a subtask of T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe, as Resolved.
Sun, Sep 15, 11:43 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona closed T230982: Rewrite the code for hoisting variables in skipped branches for CachingParser as Resolved.
Sun, Sep 15, 11:43 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), AbuseFilter
Daimona closed T232498: The CachingParser doesn't report syntax errors in skipped branches, a subtask of T156095: Re-enable AbuseFilterCachingParser once we are sure it's safe, as Resolved.
Sun, Sep 15, 11:43 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Performance-Team, AbuseFilter
Daimona closed T232498: The CachingParser doesn't report syntax errors in skipped branches as Resolved.
Sun, Sep 15, 11:43 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), AbuseFilter
Daimona closed T232881: Hide `Restore autoconfirmed status` on Special:AbuseFilter/tools if user lacks rights as Resolved.
Sun, Sep 15, 11:33 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, AbuseFilter
Daimona added a comment to T232885: Consequences: Don't allow activation of blockAutopromotion or block without activating disallow.

I disagree - when the filter is loaded and viewed, it should show that edits are being disallowed if indeed they are. Perhaps, when saving the filter, if any of the actions that also trigger disallow are activated, the save automatically enableds disallow, so that when the filter is retrieved or viewed, it is clear that it disallows?

Sun, Sep 15, 11:33 AM · User-DannyS712, AbuseFilter
Daimona updated subscribers of T232915: Red-green in PHPUnit code coverage are hard to read.

CC @Legoktm per comments at https://github.com/sebastianbergmann/php-code-coverage/issues/556.

Sun, Sep 15, 8:00 AM · Continuous-Integration-Config, Upstream, Accessibility
Daimona closed T232945: CentralAuth hooks function `onAbuseFilterShouldFilterAction` should be static as Resolved.
Sun, Sep 15, 7:59 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), GlobalRename, User-DannyS712, AbuseFilter, MediaWiki-extensions-CentralAuth
Daimona removed a project from T212082: Do not block page moves with AbuseFilter on LocalRenameJob page moves: Patch-For-Review.
Sun, Sep 15, 7:59 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), User-Daimona, Stewards-and-global-tools, AbuseFilter, MediaWiki-extensions-CentralAuth, GlobalRename

Sat, Sep 14

Daimona closed T232256: Allow @template annotations as Resolved.
Sat, Sep 14, 6:27 PM · MediaWiki-Codesniffer
Daimona added a comment to T187686: Write an Ace worker for AbuseFilter and add clientside validation.

So I tried to do this today... Setting up the worker is not too hard, the only thing we need to pay attention to are paths: ace uses relative paths, and CodeEditor (and also our edit module) set the base path to extension/CodeEditor/modules, because that's where ace lives. But this new mode would live in AF/modules, so we need to change the path. But anyway, it shouldn't be super-hard to fix that.

Sat, Sep 14, 5:32 PM · AbuseFilter
Daimona closed T212082: Do not block page moves with AbuseFilter on LocalRenameJob page moves as Resolved.
Sat, Sep 14, 5:18 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), Core Platform Team Workboards (Clinic Duty Team), User-Daimona, Stewards-and-global-tools, AbuseFilter, MediaWiki-extensions-CentralAuth, GlobalRename
Daimona claimed T232916: Prevent blocked users from using Special:AbuseFilter/revert.
Sat, Sep 14, 1:05 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), AbuseFilter
Daimona awarded T232563: Drop IE6 and IE7 basic compatibility and security support a Like token.
Sat, Sep 14, 1:03 PM · MediaWiki-General, TechCom-RFC
Daimona added a comment to T232885: Consequences: Don't allow activation of blockAutopromotion or block without activating disallow.

It's not only those. The full list is: blockautopromote, block, rangeblock, and degroup. IMHO, forcing 'disallow' to be enabled is not a good UX, so much so that we'll remove it when processing the actions (if other blocking actions are enabled). Given that https://www.mediawiki.org/wiki/Extension:AbuseFilter/Actions already hints that those actions implicitly disallow the edit, I think that we can just silently replace any of those with 'disallow', if the action cannot be performed. Maybe we could also add an OOUI info fields to the actions fieldset pointing to that page on mw.o.

Sat, Sep 14, 11:22 AM · User-DannyS712, AbuseFilter
Daimona created T232916: Prevent blocked users from using Special:AbuseFilter/revert.
Sat, Sep 14, 10:24 AM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), AbuseFilter
Daimona added a project to T232862: Lexeme search on Wikidata result in fatal exceptions: Wikimedia-production-error.
Sat, Sep 14, 10:16 AM · Wikimedia-production-error, Wikidata-Campsite, Wikidata
MarcoAurelio awarded T232915: Red-green in PHPUnit code coverage are hard to read a Like token.
Sat, Sep 14, 9:57 AM · Continuous-Integration-Config, Upstream, Accessibility
Daimona added a comment to T232915: Red-green in PHPUnit code coverage are hard to read.

FTR: https://github.com/sebastianbergmann/php-code-coverage/issues/698. Note that we use an old version of php-code-coverage, and the current one (7.0.7) is slightly different. Red and green are the same, though.

Sat, Sep 14, 9:45 AM · Continuous-Integration-Config, Upstream, Accessibility
Daimona created T232915: Red-green in PHPUnit code coverage are hard to read.
Sat, Sep 14, 8:55 AM · Continuous-Integration-Config, Upstream, Accessibility
Daimona added a comment to T232908: Admins blocked by User:Abuse filter cannot unblockself.

This was shortly discussed in T150826, see T150826#4784526 and following comments. There are two main ways to circumvent this issue:
1 - And most important, check user_groups in abuse filters. That's like a golden rule. There'll always be new problems like this one if a filter isn't checking user groups. (I know that this time it happened during testing, but other than that, this should be the actual solution)
2 - Even then, blocked admins can use Special:AbuseFilter/revert to unblock themselves. That was probably not intended, so we may take it away in the near future.

Sat, Sep 14, 8:40 AM · Core Platform Team, MediaWiki-User-management, User-DannyS712, AbuseFilter
Daimona closed T232914: Edit filter does not work properly on the Russian Wikipedia as Invalid.

There wasn't a specific filter

Sat, Sep 14, 8:32 AM · AbuseFilter
Krinkle awarded T231636: Butcher the list of phan suppressions in MW core a Orange Medal token.
Sat, Sep 14, 1:09 AM · MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), phan, MediaWiki-Core-Testing

Fri, Sep 13

Daimona added a comment to T191740: Bundle AbuseFilter extension with MediaWiki.

@Daimona would you be willing to add me to T152394 and/or T187731?

Fri, Sep 13, 6:47 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona added a comment to T232881: Hide `Restore autoconfirmed status` on Special:AbuseFilter/tools if user lacks rights.

After T232884: Don't allow restoring autopromotion by blocked users is merged, I intend to resolve this by checking AbuseFilter::canEdit to determine if the interface should be shown, since that will cover both those without rights and those with rights but who are blocked from using them

Fri, Sep 13, 6:44 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, AbuseFilter
Daimona added a comment to T232881: Hide `Restore autoconfirmed status` on Special:AbuseFilter/tools if user lacks rights.

Oh didn't see you assigned it to yourself. I already have a patch if you don't.

Fri, Sep 13, 6:29 PM · MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), User-DannyS712, AbuseFilter
Daimona added a comment to T191740: Bundle AbuseFilter extension with MediaWiki.

@CCicalese_WMF Thanks! I'd also appreciate a lot some review for T220791, which is a bit more delicate...

Fri, Sep 13, 6:04 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing
Daimona added a comment to T232862: Lexeme search on Wikidata result in fatal exceptions.
message
[XXvNjwpAMFAAABEsrycAAADE] /w/index.php?search=&search=L%3Ani&title=Special%3ASearch&go=G%C3%A5+til   Error from line 57 of /srv/mediawiki/php-1.34.0-wmf.22/extensions/WikibaseLexemeCirrusSearch/src/LexemeResult.php: Call to a member function setFragment() on null
Fri, Sep 13, 5:41 PM · Wikimedia-production-error, Wikidata-Campsite, Wikidata
Daimona closed T221357: Read timeout reached while viewing AbuseLog, a subtask of T199544: Make AbuseFilter work on PostgreSQL and SQLite (tracking), as Resolved.
Fri, Sep 13, 5:39 PM · PostgreSQL, SQLite, AbuseFilter
Daimona closed T221357: Read timeout reached while viewing AbuseLog as Resolved.

The long-term goal is T220791, this issue was resolved, hence closing.

Fri, Sep 13, 5:39 PM · MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), DBA, AbuseFilter, Wikimedia-production-error
Daimona added a parent task for T220791: afl_filter should be split in afl_filter_id and afl_global: T199544: Make AbuseFilter work on PostgreSQL and SQLite (tracking).
Fri, Sep 13, 5:39 PM · Core Platform Team Workboards (Clinic Duty Team), Schema-change, Patch-For-Review, AbuseFilter
Daimona added a subtask for T199544: Make AbuseFilter work on PostgreSQL and SQLite (tracking): T220791: afl_filter should be split in afl_filter_id and afl_global.
Fri, Sep 13, 5:38 PM · PostgreSQL, SQLite, AbuseFilter
Daimona added a comment to T191740: Bundle AbuseFilter extension with MediaWiki.

@CCicalese_WMF It depends... Right now we only have two known incompatibilities with Postgres.

Fri, Sep 13, 4:49 PM · MW-1.35-release, Patch-For-Review, User-Daimona, AbuseFilter, MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), MediaWiki-Releasing