Page MenuHomePhabricator

Daimona
Musician

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 18 2017, 10:49 AM (126 w, 6 d)
Availability
Available
IRC Nick
Daimona
LDAP User
Daimona Eaytoy
MediaWiki User
Daimona Eaytoy [ Global Accounts ]

Babel: it-N, en-3, fr-1

Recent Activity

Today

Daimona added a comment to T236193: translate_source_text is not set when examining recentchanges.

Just keep in mind that this will likely be executed for 100 RC entries together.

Is there a batching interface to speed it up? It has to fetch the text content to show it. Finding the revisions is not slow, just one extra query, or join (preferably).

Wed, Oct 23, 6:09 PM · MediaWiki-extensions-Translate, User-DannyS712, AbuseFilter
Daimona added a comment to T236286: Uncaught Error: Widget not found when editing filters.

Yeah no need to rollback, for sure. The fix is also pretty small and self-contained.

Wed, Oct 23, 5:02 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

However, when creating a filter, the actions section is just blank (see below).

Wed, Oct 23, 4:47 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
Daimona claimed T236286: Uncaught Error: Widget not found when editing filters.
Wed, Oct 23, 4:46 PM · Patch-For-Review, AbuseFilter
Daimona added a subtask for T233851: 1.35.0-wmf.3 deployment blockers: T236286: Uncaught Error: Widget not found when editing filters.
Wed, Oct 23, 4:46 PM · Release-Engineering-Team (Deployment services), Release-Engineering-Team-TODO (201910), Release, Train Deployments
Daimona added a parent task for T236286: Uncaught Error: Widget not found when editing filters: T233851: 1.35.0-wmf.3 deployment blockers.
Wed, Oct 23, 4:46 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T236286: Uncaught Error: Widget not found when editing filters.

Ouch! I'm going to hotfix that - no need to revert that commit in its entirety. I'll also add a selenium test for actions. I think this should be a train blocker given that the form is unusable no matter what.

Wed, Oct 23, 4:27 PM · Patch-For-Review, AbuseFilter
Daimona added a comment to T236193: translate_source_text is not set when examining recentchanges.

Sounds like easy to fix, but there is a caveat: the source text might change between when the translation happens and when the variable is inspected some time later. Though, with a bit more effort, one can query the exact source text revision and use that, so it's probably not a problem after all.

Wed, Oct 23, 4:25 PM · MediaWiki-extensions-Translate, User-DannyS712, AbuseFilter
Daimona renamed T236193: translate_source_text is not set when examining recentchanges from translate_source_text is not text when examining recentchanges to translate_source_text is not set when examining recentchanges.
Wed, Oct 23, 4:23 PM · MediaWiki-extensions-Translate, User-DannyS712, AbuseFilter
Daimona added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

Note that I was unable to get the block action working for the AbuseFilter extension.

Wed, Oct 23, 1:27 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
Daimona claimed T204339: Convert TranslateSvg to use extension registration.
Wed, Oct 23, 12:56 PM · Patch-For-Review, MediaWiki-extensions-TranslateSvg
Daimona added a comment to T236245: Abuse filter error appears when it shouldn't.

FTR: CX has its own AF checker, which is probably the "culprit" here.

Wed, Oct 23, 12:34 PM · AbuseFilter, ContentTranslation
Daimona added a comment to T203651: Optimize phan-taint-check speed.

I think after releasing 3.0.0 (or even before), we should start thinking about performance, both time- and memory-wise.

I think that could very easily involve a ground-up rewrite, which might not be a bad thing.

Wed, Oct 23, 9:30 AM · phan-taint-check-plugin
Daimona added a comment to T236193: translate_source_text is not set when examining recentchanges.

Added in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Translate/+/003e7f28cd2e587a60d5f8b4114aa7f7c3e5704c%5E%21/TranslateHooks.php
I don't understand fully this bug report, but the source text certainly isn't stored in the recent changes table.

Wed, Oct 23, 9:23 AM · MediaWiki-extensions-Translate, User-DannyS712, AbuseFilter

Yesterday

Daimona claimed T236194: TranslateSVG tests are writing to the actual database.
Tue, Oct 22, 6:04 PM · Patch-For-Review, MediaWiki-extensions-TranslateSvg
Daimona added a project to T236193: translate_source_text is not set when examining recentchanges: MediaWiki-extensions-Translate.

Suspected cause:
Examining via the link from the test interface shows that translate_source_text isn't set, while the original abuse log entry does have that variable: https://www.mediawiki.org/wiki/Special:AbuseFilter/examine/log/180272

Tue, Oct 22, 6:00 PM · MediaWiki-extensions-Translate, User-DannyS712, AbuseFilter
Daimona renamed T236193: translate_source_text is not set when examining recentchanges from Special:AbuseFilter/test isn't recognizing translate_source_text to translate_source_text is not text when examining recentchanges.
Tue, Oct 22, 5:59 PM · MediaWiki-extensions-Translate, User-DannyS712, AbuseFilter
Daimona created T236194: TranslateSVG tests are writing to the actual database.
Tue, Oct 22, 5:55 PM · Patch-For-Review, MediaWiki-extensions-TranslateSvg
Daimona committed rEMMA803c74fbeaaf: build: Updating mediawiki/mediawiki-codesniffer to 28.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 28.0.0
Tue, Oct 22, 4:56 PM
Daimona committed rERGU1e7a027dc922: build: Updating mediawiki/mediawiki-codesniffer to 28.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 28.0.0
Tue, Oct 22, 4:18 PM
Daimona claimed T235990: MediaWikiFarm tests are broken.

I've gone crazy with all those globals, back-compat stuff, and reinvented wheels, but tests are working now!

Tue, Oct 22, 2:29 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-MediaWikiFarm
Daimona committed rESPRb72848a91969: build: Updating mediawiki/mediawiki-codesniffer to 28.0.0 (authored by libraryupgrader <tools.libraryupgrader@tools.wmflabs.org>).
build: Updating mediawiki/mediawiki-codesniffer to 28.0.0
Tue, Oct 22, 1:18 PM
Daimona committed rESPR95c5405c840d: Unbreak CI (authored by Daimona).
Unbreak CI
Tue, Oct 22, 1:18 PM
Daimona added a comment to T235990: MediaWikiFarm tests are broken.

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MediaWikiFarm/+/545263/ seems to mitigate the issue, but, well... The tests are messing up with globals a lot (amongst other things), so something else broke (as expected).

Tue, Oct 22, 1:07 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-MediaWikiFarm
Daimona added a comment to T235990: MediaWikiFarm tests are broken.

I don't think there's one. Apparently, it was introduced because it was faster than MW's PHPUnit config. But now in 2019 we have MediaWikiUnitTestCase etc., so let's just do what extensions normally do.

Tue, Oct 22, 11:48 AM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-MediaWikiFarm
Daimona closed T231636: Butcher the list of phan suppressions in MW core as Resolved.
Tue, Oct 22, 11:13 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), Core Platform Team Workboards (Clinic Duty Team), phan, MediaWiki-Core-Testing
Daimona created T236139: Track wikibase-codesniffer in LibUp.
Tue, Oct 22, 11:12 AM · LibUp
Daimona added a comment to T236127: "&" is not commutative when an operand is undefined.

Oh, from a quick glance: it doesn't return DUNDEFINED because this way dundefined | true is also true (and we want this). So it should return DUNDEFINED only if either operand is undefined, AND the operator is &. I don't know whether that should be handled by boolOp, or by the parser.

Tue, Oct 22, 8:38 AM · AbuseFilter
Daimona added a comment to T236127: "&" is not commutative when an operand is undefined.

AFPData::boolOp discards the DUNDEFINED value in both operands. I think it should do like other methods, and return DUNDEFINED if either of the operands is undefined, instead. However, I should first understand why I didn't do it at first. We should also add a test like

Tue, Oct 22, 8:35 AM · AbuseFilter
Daimona created T236127: "&" is not commutative when an operand is undefined.
Tue, Oct 22, 8:29 AM · AbuseFilter
Daimona added a comment to T235113: Upgrade PHPCS to 28.0.0 in all repos.

And also, please upgrade wikibase/wikibase-codesniffer to 1.0.0, which brings in the 28.0.0 version of mw-codesniffer.

That will need its own labs/libraryupgrader/config entry.

Tue, Oct 22, 8:03 AM · LibUp, MediaWiki-Codesniffer

Mon, Oct 21

Daimona committed rEMMAffc3d0b90d28: Unbreak CI (authored by Daimona).
Unbreak CI
Mon, Oct 21, 6:56 PM
Daimona committed rSMNB6efe05b0aa6a: build: Bump mediawiki-phan-config to 0.8.0 (authored by Daimona).
build: Bump mediawiki-phan-config to 0.8.0
Mon, Oct 21, 5:52 PM
Daimona added a comment to T235990: MediaWikiFarm tests are broken.

I see that the extension has its own phpunit.xml file. I wonder whether we should just get rid of it, given that it's non-standard. Or at least keep it compatible with core's PHPUnit settings, but that sounds challenging...

Mon, Oct 21, 2:10 PM · Patch-For-Review, Technical-Debt, MediaWiki-extensions-MediaWikiFarm
Daimona added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

There's already https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/EventBus/+/544332/, I was waiting for CI to finish before giving a final approve.

Mon, Oct 21, 9:41 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
Daimona created T236030: Selenium tests failing for PluggableAuth plugins.
Mon, Oct 21, 9:29 AM · Release-Engineering-Team (CI & Testing services), Release-Engineering-Team-TODO (201910), User-zeljkofilipin, Continuous-Integration-Config, Wikimedia-production-error (Shared Build Failure), Browser-Tests

Sun, Oct 20

Daimona committed rLLIC0e7c3fb5c9ad: Push mediawiki-phan-config to 0.8.0 (authored by Daimona).
Push mediawiki-phan-config to 0.8.0
Sun, Oct 20, 10:13 AM
Daimona committed rMSBCcf8db7d0aa7d: build: Bump mediawiki-codesniffer to 28.0.0 and make it pass (authored by MaxSem).
build: Bump mediawiki-codesniffer to 28.0.0 and make it pass
Sun, Oct 20, 10:13 AM
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Sun, Oct 20, 9:51 AM · phan-taint-check-plugin
Daimona closed T224756: Add phan to Translate extension, a subtask of T224783: Enable mediawiki/mediawiki-phan-config on all Wikimedia-deployed repositories, as Resolved.
Sun, Oct 20, 9:47 AM · Google-Code-in-2019, Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Epic, Wikimedia-General-or-Unknown, phan
Daimona closed T224756: Add phan to Translate extension as Resolved.
Sun, Oct 20, 9:47 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MediaWiki-extensions-Translate, phan
Daimona committed rERXBa81b1992d865: Use AbstractBlock setters instead of deprecated properties (authored by Tchanders).
Use AbstractBlock setters instead of deprecated properties
Sun, Oct 20, 9:46 AM
Daimona committed rERXB65d61e0b50f9: Stop using deprecated hook GetBlockedStatus (authored by Daimona).
Stop using deprecated hook GetBlockedStatus
Sun, Oct 20, 9:46 AM
Daimona added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

While I concur it shouldn't have been made private without updating callers first, I don't consider ~7 extensions "lots" ;)

Sun, Oct 20, 9:12 AM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
Daimona committed rMTPS8250cb5c34cd: Upgrade to PHPUnit 8.4 (authored by Daimona).
Upgrade to PHPUnit 8.4
Sun, Oct 20, 2:20 AM

Sat, Oct 19

Daimona added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

A reminder for something that puzzled me for a couple of minutes: tests where DatabaseBlock::mReason (note: NOT AbstractBlock::mReason) is accessed directly are likely not failing because a dynamic property is created instead. Nevertheless, this is not a good reason to make the property private, given the breaking change.

Sat, Oct 19, 7:30 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
Daimona added a comment to T227007: Reasons and blockers for SystemBlocks should not be stored as translated messages.

Note that I had to temporarily revert the patch above. It made AbstractBlock::mReason private without hard deprecation, and lots of extensions are accessing it directly. I apologize if this could seem an overkill, but better reverted than sorry. It can be re-applied without making the property private if it works for you.

Sat, Oct 19, 7:00 PM · MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), Core Platform Team Workboards (Clinic Duty Team), Anti-Harassment (The Letter Song), MediaWiki-User-management
Daimona committed rMTPS451bc6b3cbad: build: Upgrade MW phpcs to 28.0.0 (authored by Daimona).
build: Upgrade MW phpcs to 28.0.0
Sat, Oct 19, 6:39 PM
Daimona added a project to T235943: MailGun extension needs php-http/guzzle6-adapter in require not require-dev: good first bug.
Sat, Oct 19, 6:25 PM · good first bug, MediaWiki-extensions-Mailgun
Daimona added a comment to T235926: The Special:AbuseLog search function does not return or display "createaccount" or "autocreateaccount" edit filter logs when filtering by username.

Seems the same as T213982? Long story short, the account creator is an IP address, hence filtering by user (where user = the name of the account being created) won't work. OTOH, the non-existing account has some entries in the AbuseLog because attributing them to the underlying IP would disclose personal info.

Sat, Oct 19, 9:15 AM · AbuseFilter

Fri, Oct 18

Daimona added a comment to T192167: Upgrade PHPUnit from 4/6 to 8.

For setExpectedException, the two patches above will remove the last non-SMW usages. For $this->getMock, there's still a bunch of extensions using it. And also, Wikibase is still using the PHPUnit4And6Compat trait because some tests in https://github.com/DataValues/Common use it; I don't know how to tackle those. All of these is what's left before we can drop the trait.

Fri, Oct 18, 4:43 PM · MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), Patch-For-Review, PHP 7.4 support, MediaWiki-Core-Testing
Daimona placed T234597: Phase out PHPUnit expected exception annotations from tests up for grabs.
Fri, Oct 18, 4:43 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), MediaWiki-Core-Testing
Daimona committed rMTPSf21945d73834: Replace EXEC_TAINT with ALL_EXEC_TAINT where latter was meant (authored by Bawolff).
Replace EXEC_TAINT with ALL_EXEC_TAINT where latter was meant
Fri, Oct 18, 4:15 PM
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Fri, Oct 18, 4:09 PM · phan-taint-check-plugin
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Fri, Oct 18, 2:27 PM · phan-taint-check-plugin
Daimona added a comment to T203651: Optimize phan-taint-check speed.

A little update: after the update to phan 2.2.13, taint-check will start taking way more memory. Scanning AbuseFilter with r542757 checked out took 3056MB of memory on my machine. I think after releasing 3.0.0 (or even before), we should start thinking about performance, both time- and memory-wise.

Fri, Oct 18, 2:16 PM · phan-taint-check-plugin
Daimona added a comment to T235873: Add variables in Abusefilter to detect/block thanks.

Somewhat related to T177780. I've just found an incomplete comment on that task where I was saying that filtering thank actions in AF would be technically difficult, but didn't say why :(

Fri, Oct 18, 1:58 PM · AbuseFilter, Growth-Team, Thanks, Anti-Harassment

Thu, Oct 17

Daimona created T235783: CentralAuth tests failing if GlobalPreferences is loaded.
Thu, Oct 17, 4:10 PM · Wikimedia-production-error (Shared Build Failure), MediaWiki-extensions-GlobalPreferences, MediaWiki-extensions-CentralAuth, Community-Tech
Daimona added a comment to T234051: Patroller right changes to ro.wp.

Unfortunately abusefilter seems to only handle article deletions (not even undeletions, let alone revision visibility)

Thu, Oct 17, 3:07 PM · WMF-Legal, Patch-For-Review, Wikimedia-Site-requests
Daimona added a comment to T235590: AbuseFilter: When viewing an old revision of a filter, don't show abusefilter-edit-oldwarning if the user cannot edit the filter.

Fine by me, thanks!

Thu, Oct 17, 9:23 AM · User-DannyS712, AbuseFilter

Wed, Oct 16

Daimona committed rMTPS9efb68c95b6f: Upgrade phan to 2.0.0, ast to 1.0.1 and require PHP72+ (authored by Daimona).
Upgrade phan to 2.0.0, ast to 1.0.1 and require PHP72+
Wed, Oct 16, 6:31 PM
sbassett awarded T235381: Release taint-check 2.1.0 a Like token.
Wed, Oct 16, 5:31 PM · phan-taint-check-plugin
Jdforrester-WMF awarded T235160: Decide whether extensions should set a PHP version requirement in composer.json a Like token.
Wed, Oct 16, 5:17 PM · MediaWiki-General, PHP 7.0 support, TechCom
Daimona created T235650: Global developer for DannyS712 on beta cluster.
Wed, Oct 16, 1:33 PM · Beta-Cluster-Infrastructure
Daimona closed T235381: Release taint-check 2.1.0 as Resolved.

Done just now: https://gerrit.wikimedia.org/g/mediawiki/tools/phan/SecurityCheckPlugin/+/refs/tags/2.1.0

Wed, Oct 16, 9:41 AM · phan-taint-check-plugin
Daimona closed T235381: Release taint-check 2.1.0, a subtask of T235383: Release taint-check 3.0.0, as Resolved.
Wed, Oct 16, 9:41 AM · phan-taint-check-plugin
Daimona closed T235555: Phan CI error causing jenkins errors on all patches to Echo extension as Resolved.

Fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/543387/.

Wed, Oct 16, 9:38 AM · phan, Growth-Team, Notifications
Daimona committed rMTPS42a3a482c1c2: Merge remote-tracking branch 'origin/2.x' (authored by Daimona).
Merge remote-tracking branch 'origin/2.x'
Wed, Oct 16, 9:38 AM
Daimona added a comment to T235381: Release taint-check 2.1.0.

Time to merge 2.x into master and make a release?

Wed, Oct 16, 9:30 AM · phan-taint-check-plugin

Tue, Oct 15

Daimona committed rMTPS942a7bd4441e: Improve caused-by lines (authored by Daimona).
Improve caused-by lines
Tue, Oct 15, 7:07 PM
Daimona committed rMTPS248902fd12a1: Add debug for reaching max analysis depth (authored by Daimona).
Add debug for reaching max analysis depth
Tue, Oct 15, 7:07 PM
Daimona committed rMTPS92b2d0ec2ce4: Handle closures (authored by Daimona).
Handle closures
Tue, Oct 15, 7:07 PM
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Tue, Oct 15, 5:10 PM · phan-taint-check-plugin
Daimona updated the task description for T235381: Release taint-check 2.1.0.
Tue, Oct 15, 5:09 PM · phan-taint-check-plugin
Daimona added a comment to T225730: Reduce runtime of MW shared gate Jenkins jobs to 5 min.

A possible improvement is T235390. While the seccheck job is pretty fast, it consumes roughly 1.5GB of memory for the average extension (way more for core, where it still has to be enabled), and this usage will increase with future phan versions. Merging the two jobs would mean saving that amount of memory and hence freeing up CI resources. I don't know whether that would have a noticeable impact on the runtime, though.

Tue, Oct 15, 4:50 PM · Release-Engineering-Team (Unit & Int & System Tooling), Release-Engineering-Team-TODO, Code-Health, Performance-Team (Radar), Epic, MediaWiki-Core-Testing, Continuous-Integration-Config
Daimona closed T235326: Wikibase PHPUnit tests are broken as Resolved.
Tue, Oct 15, 11:19 AM · MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), Wikidata
Daimona committed rEWLCe3b1bd93fd7d: Upgrade wikibase codesniffer to 1.0.0 (authored by Daimona).
Upgrade wikibase codesniffer to 1.0.0
Tue, Oct 15, 9:58 AM
Daimona committed rEWCS86f8e5c75ec3: Upgrade wikibase codesniffer to 1.0.0 (authored by Daimona).
Upgrade wikibase codesniffer to 1.0.0
Tue, Oct 15, 7:50 AM

Mon, Oct 14

Daimona updated the task description for T235383: Release taint-check 3.0.0.
Mon, Oct 14, 6:22 PM · phan-taint-check-plugin
Daimona changed the status of T235438: Special:AbuseFilter/test cannot be used on autocreateaccount from Open to Stalled.

That's because automatic account creations are not in the recent changes. Hence, the AF cannot pick them. This lack is intentional (they would clog the logs), so I don't see any solution here.

Mon, Oct 14, 2:53 PM · AbuseFilter
Daimona renamed T235438: Special:AbuseFilter/test cannot be used on autocreateaccount from Abuse filter cannot match autocreateaccount to Special:AbuseFilter/test cannot be used on autocreateaccount.
Mon, Oct 14, 2:45 PM · AbuseFilter
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Mon, Oct 14, 2:31 PM · phan-taint-check-plugin
Daimona committed rEPS56122ac02b3b: Clean up PHPUnit 4 bc (authored by Daimona).
Clean up PHPUnit 4 bc
Mon, Oct 14, 11:18 AM
Daimona committed rECIR23c82adfe5d7: Clean up PHPUnit 4 bc stuff (authored by Daimona).
Clean up PHPUnit 4 bc stuff
Mon, Oct 14, 8:37 AM
Daimona committed rEBQCd3dd3361aa2b: Upgrade wikibase codesniffer to 1.0.0 (authored by Daimona).
Upgrade wikibase codesniffer to 1.0.0
Mon, Oct 14, 6:50 AM
Daimona committed rEOAU268a7f6536bd: Upgrade phpcs, remove PHPUnit 4 b/c (authored by Daimona).
Upgrade phpcs, remove PHPUnit 4 b/c
Mon, Oct 14, 5:54 AM

Sun, Oct 13

Daimona updated the task description for T235383: Release taint-check 3.0.0.
Sun, Oct 13, 5:45 PM · phan-taint-check-plugin
Daimona added a project to T235390: Merge taint-check-plugin into mediawiki-phan-config: phan.
Sun, Oct 13, 5:42 PM · phan, phan-taint-check-plugin
Daimona updated the task description for T235383: Release taint-check 3.0.0.
Sun, Oct 13, 5:36 PM · phan-taint-check-plugin
Daimona added a subtask for T235390: Merge taint-check-plugin into mediawiki-phan-config: T235383: Release taint-check 3.0.0.
Sun, Oct 13, 5:05 PM · phan, phan-taint-check-plugin
Daimona added a parent task for T235383: Release taint-check 3.0.0: T235390: Merge taint-check-plugin into mediawiki-phan-config.
Sun, Oct 13, 5:05 PM · phan-taint-check-plugin
Daimona created T235390: Merge taint-check-plugin into mediawiki-phan-config.
Sun, Oct 13, 5:05 PM · phan, phan-taint-check-plugin
Daimona added a comment to T235053: Move taint-check to require-dev in composer.json.

Uhhhh, I just realized that there's a huge problem in doing this: we'd be requiring two versions of phan at the same time. Right now, it'd be 2.2.13 for mediawiki-phan-config, and 1.3.2 for taint-check.

Sun, Oct 13, 5:00 PM · Patch-For-Review, phan-taint-check-plugin
Daimona added a parent task for T235381: Release taint-check 2.1.0: T235383: Release taint-check 3.0.0.
Sun, Oct 13, 2:43 PM · phan-taint-check-plugin
Daimona added a subtask for T235383: Release taint-check 3.0.0: T235381: Release taint-check 2.1.0.
Sun, Oct 13, 2:43 PM · phan-taint-check-plugin
Daimona created T235383: Release taint-check 3.0.0.
Sun, Oct 13, 2:43 PM · phan-taint-check-plugin
Daimona updated the task description for T235381: Release taint-check 2.1.0.
Sun, Oct 13, 2:37 PM · phan-taint-check-plugin
Daimona closed T227406: Release taint-check 2.0.2 and 2.1.0 as Resolved.

Moved the 2.1.0 part to T235381 for clarity.

Sun, Oct 13, 2:36 PM · phan-taint-check-plugin
Daimona created T235381: Release taint-check 2.1.0.
Sun, Oct 13, 2:35 PM · phan-taint-check-plugin

Sat, Oct 12

Daimona committed rEPSc7bb5102938d: Upgrade phpcs to 28.0.0 (authored by Daimona).
Upgrade phpcs to 28.0.0
Sat, Oct 12, 7:25 PM