Page MenuHomePhabricator

DanielsThomas (Thomas Daniels)
User

Projects

User is not a member of any projects.

Today

  • No visible events.

Tomorrow

  • No visible events.

Saturday

  • No visible events.

User Details

User Since
Nov 22 2020, 5:01 PM (290 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DanielsThomas [ Global Accounts ]

Recent Activity

Jun 27 2022

DanielsThomas added a comment to T270219: VisualEditor does not support wikis without short URLs.

This seems to be resolved for 1.39 for zero config VE installs thanks to T305108, I tried it out and did not come across any issues for the three URL types you list.

Jun 27 2022, 10:19 PM · Editing-team (Third-party), Parsoid (Third-party), VisualEditor
DanielsThomas added a comment to T269508: VisualEditor gives 401 when behind basic auth.

Indeed, I tried it out, it works fine! That's great news. Would this task still be relevant for setups where Parsoid is hosted separately (I have no clue about how such setups are used in practice), or can it be closed?

Jun 27 2022, 10:15 PM · Parsoid (Tracking), VisualEditor

Oct 5 2021

DanielsThomas added a comment to T291750: Docx files created using LibreOffice are incorrectly detected as zip files.

We just tested it on MediaWiki 1.36.2 and can confirm the bug is still present.

Oct 5 2021, 10:25 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Performance-Team, MediaWiki-Uploading, MediaWiki-libs-Mime
DanielsThomas added a comment to T291752: MimeAnalyzer: Document that built-in guesses override PHP/OS detection.

You are right, there are no custom mime maps registered (as far as we know). We also agree that MediaWiki does provide a consistent cross-platform experience by using a built-in mime map. However, it is quite unfortunate that this code might contain bugs such as the one linked. We personally feel the benefits of using a specialized library, such as PHP finfo, could outweigh its disadvantages. Still, it is up to the MediaWiki team to balance these arguments and decide which is best.

Oct 5 2021, 10:14 PM · MediaWiki-Platform-Team (Radar), good first task, MediaWiki-libs-Mime
DanielsThomas added a comment to T291747: Remove "unrecognizedparams" warning from the API.

Thanks, we were unaware of this hook. The documentation on https://www.mediawiki.org/wiki/Manual:Hooks/APIGetAllowedParams is also very unclear about the purpose of this hook. According to https://www.mediawiki.org/wiki/Category:APIGetAllowedParams_extensions it's not too widely used, so many developers might not be aware of it either. As a result, it might still be more intuitive for unrecognizedparams to be removed. Do you know why the unrecognizedparams warning was added?

Oct 5 2021, 10:05 PM · MediaWiki-Action-API

Sep 25 2021

DanielsThomas created T291756: Add a hook before processing of API uploads.
Sep 25 2021, 9:05 PM · Patch-Needs-Improvement, MW-Interfaces-Team, MediaWiki-Action-API, MediaWiki-Uploading
DanielsThomas created T291754: Upload API does not handle very large files correctly.
Sep 25 2021, 8:43 PM · MW-1.43-notes (1.43.0-wmf.28; 2024-10-22), MediaWiki-Action-API, MediaWiki-Uploading
DanielsThomas created T291753: PostgreSQL passwords containing "\%" do not work .
Sep 25 2021, 8:38 PM · MW-1.39-notes, Performance-Team, MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), PostgreSQL, MediaWiki-Installer, MediaWiki-libs-Rdbms
DanielsThomas created T291752: MimeAnalyzer: Document that built-in guesses override PHP/OS detection.
Sep 25 2021, 8:35 PM · MediaWiki-Platform-Team (Radar), good first task, MediaWiki-libs-Mime
DanielsThomas added a project to T291746: Allow upload API users to ignore specific warnings: MediaWiki-Uploading.
Sep 25 2021, 8:30 PM · MediaWiki-Action-API, MediaWiki-Uploading
DanielsThomas created T291750: Docx files created using LibreOffice are incorrectly detected as zip files.
Sep 25 2021, 8:30 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Performance-Team, MediaWiki-Uploading, MediaWiki-libs-Mime
DanielsThomas created T291749: Add functionality to modify the article Table of Contents.
Sep 25 2021, 8:22 PM · MediaWiki-Parser
DanielsThomas created T291747: Remove "unrecognizedparams" warning from the API.
Sep 25 2021, 8:14 PM · MediaWiki-Action-API
DanielsThomas created T291746: Allow upload API users to ignore specific warnings.
Sep 25 2021, 8:10 PM · MediaWiki-Action-API, MediaWiki-Uploading

Sep 22 2021

DanielsThomas added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

Looks right, thank you!

Sep 22 2021, 3:59 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

Can you confirm that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LDAPAuthorization/+/702976/ didn't address you use case properly?

Sep 22 2021, 1:41 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

Sep 18 2021

DanielsThomas added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

Hi, it's been a while since we last talked about this, so I wondered what your thoughts are on the approach of using an LDAP search filter string. Our organisation can look into helping with its implementation, if it sounds good to you.

Sep 18 2021, 3:21 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

Sep 10 2021

DanielsThomas added a comment to T290402: Have a "Getting started" type of guide for creating skins with Mustache.

That's great, thanks a lot!

Sep 10 2021, 8:19 PM · MediaWiki-Core-Skin-Architecture (Menus 2.0), Documentation
DanielsThomas added a comment to T290402: Have a "Getting started" type of guide for creating skins with Mustache.

Thanks for your reply! We appreciate the help. Also thanks for sharing the migration documentation link. For our skin, however, we planned to fully rewrite it from scratch because it currently uses a lot of old functionality and is kind of a mess. Therefore we hoped someone with little PHP experience would be able to build the skin, because it's Mustache so it would only require HTML and CSS knowledge.

Sep 10 2021, 6:25 PM · MediaWiki-Core-Skin-Architecture (Menus 2.0), Documentation

Sep 5 2021

DanielsThomas created T290402: Have a "Getting started" type of guide for creating skins with Mustache.
Sep 5 2021, 10:53 PM · MediaWiki-Core-Skin-Architecture (Menus 2.0), Documentation

Aug 3 2021

DanielsThomas added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

Sure, the following pages outline how to configure that extension:

Aug 3 2021, 10:43 AM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

Jul 5 2021

DanielsThomas added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

Quoting https://ldap.com/ldap-filters/ :

Jul 5 2021, 11:54 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas added a comment to T280875: rules.attributes does not work for multi-valued attribute results.

I have implemented a change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/LDAPAuthorization/+/702976/3..4/tests/phpunit/Requirement/MatchAttributesTest.php
But now other tests hat to be changed. @MarkAHershberger What do you think. Does it match your expectation this way?

Jul 5 2021, 10:43 AM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

May 13 2021

DanielsThomas added a comment to T280873: rules.attributes requires lowercase attribute names.

Could this be related to T226693?

May 13 2021, 10:22 PM · Patch-For-Review, LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas added a project to T280872: Authorization gets cached even when logging out and in again: LDAP-Extensions.
May 13 2021, 10:17 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas added a project to T280873: rules.attributes requires lowercase attribute names: LDAP-Extensions.
May 13 2021, 10:17 PM · Patch-For-Review, LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas added a project to T280875: rules.attributes does not work for multi-valued attribute results: LDAP-Extensions.
May 13 2021, 10:16 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

Apr 21 2021

DanielsThomas created T280875: rules.attributes does not work for multi-valued attribute results.
Apr 21 2021, 10:20 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas created T280873: rules.attributes requires lowercase attribute names.
Apr 21 2021, 10:19 PM · Patch-For-Review, LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization
DanielsThomas created T280872: Authorization gets cached even when logging out and in again.
Apr 21 2021, 10:18 PM · LDAP-Extensions, MediaWiki-extensions-LDAPAuthorization

Dec 5 2020

DanielsThomas created T269508: VisualEditor gives 401 when behind basic auth.
Dec 5 2020, 11:49 PM · Parsoid (Tracking), VisualEditor

Nov 22 2020

DanielsThomas created T268420: GlobalIdGenerator assumes tmp path is unique.
Nov 22 2020, 8:15 PM · MW-1.39-notes (1.39.0-wmf.25; 2022-08-15), Platform Team Workboards (Clinic Duty Team), Editing-team (Tracking), VisualEditor, MediaWiki-General