Page MenuHomePhabricator

DannyS712
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2018, 9:15 PM (105 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DannyS712 [ Global Accounts ]

Recent Activity

Today

DannyS712 updated the task description for T254265: Media Inquiry: Covid pages/API.
Thu, Oct 29, 2:29 AM · Product-Analytics (Kanban), COVID-19 Global Dashboard
DannyS712 placed T266722: Request creation of CATABOT VPS project up for grabs.
Thu, Oct 29, 2:28 AM · Cloud-VPS (Project-requests)
DannyS712 merged T266731: add Greg Varnum to WMF/NDA in Phabricator into T266598: Add Varnent to Wikimedia-NDA group.
Thu, Oct 29, 2:14 AM · User-greg, WMF-NDA-Requests
DannyS712 merged task T266731: add Greg Varnum to WMF/NDA in Phabricator into T266598: Add Varnent to Wikimedia-NDA group.
Thu, Oct 29, 2:13 AM · WMF-NDA-Requests, Release-Engineering-Team, Phabricator, Operations
DannyS712 updated subscribers of T266731: add Greg Varnum to WMF/NDA in Phabricator.

@Varnent Created this per our meeting and when I checked during it and you confirmed you could not see the ticket I also did not see you in https://phabricator.wikimedia.org/project/members/61/ but now after making this ticket... I do. But I changed nothing. Ehm... please try again to open that ticket.

Thu, Oct 29, 2:13 AM · WMF-NDA-Requests, Release-Engineering-Team, Phabricator, Operations
DannyS712 added a comment to T266731: add Greg Varnum to WMF/NDA in Phabricator.

Wasn't this meant to be done yesterday at T266598: Add Varnent to Wikimedia-NDA group?

Thu, Oct 29, 2:12 AM · WMF-NDA-Requests, Release-Engineering-Team, Phabricator, Operations

Yesterday

DannyS712 added a comment to T251023: EditPage::getCurrentContent unexpectedly changes $currentModel and $currentFormat.

Now we have some logging in beta and production around the code @DannyS712 proposes to drop. let's wait and see if it's ever executed.

Wed, Oct 28, 8:39 PM · Patch-For-Review, Platform Team Workboards (External Code Reviews), MediaWiki-ContentHandler, User-DannyS712, MediaWiki-Page-editing
DannyS712 added a comment to T264948: Prohibit use of 'object' as type in docblocks.

Should the same apply to object[]?

Wed, Oct 28, 8:37 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 added a comment to T251023: EditPage::getCurrentContent unexpectedly changes $currentModel and $currentFormat.

The proposed change is VERY scary. No explanation was really provided for why is this code not needed anymore, and I do not believe this code is no-op.

As a start in investigation, I propose to create a bogus change where the logging in that area is replaced with throwing an exception - let's see if any tests in CI fail.

I couldn't find the logs in production, so this makes me think the change is going to the right direction.

Wed, Oct 28, 4:55 PM · Patch-For-Review, Platform Team Workboards (External Code Reviews), MediaWiki-ContentHandler, User-DannyS712, MediaWiki-Page-editing
DannyS712 added a comment to T266660: Request for rights on hiwikipedia of beta cluster.

Also granted importer for a year, per IRC - see https://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special%3ALog&logid=54565

Wed, Oct 28, 3:31 PM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 closed T266660: Request for rights on hiwikipedia of beta cluster as Resolved.

Granted sysop and interface admin for a year, see https://meta.wikimedia.beta.wmflabs.org/w/index.php?title=Special%3ALog&logid=54562

Wed, Oct 28, 3:12 PM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 added a comment to T266660: Request for rights on hiwikipedia of beta cluster.

@CptViraj can you confirm that CptViraj is also your name on the beta cluster?

Wed, Oct 28, 2:27 PM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 claimed T266660: Request for rights on hiwikipedia of beta cluster.
Wed, Oct 28, 1:04 PM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 changed the subtype of T266624: Search on Incubator is broken if you don't have a specific test-wiki set from "Task" to "Bug Report".
Wed, Oct 28, 3:21 AM · MediaWiki-extensions-WikimediaIncubator, incubator.wikimedia.org
DannyS712 updated the task description for T256367: WMF-NDA access for DannyS712.
Wed, Oct 28, 3:18 AM · User-DannyS712, WMF-NDA-Requests
DannyS712 added a comment to T256367: WMF-NDA access for DannyS712.

I guess the last signoff needs to be from @gsingers as the CTO?

Wed, Oct 28, 3:15 AM · User-DannyS712, WMF-NDA-Requests
DannyS712 moved T242762: Expand PHPUnitAssertEqualsSniff to better auto-fix comparisons with count() from Unsorted to Later on the User-DannyS712 board.
Wed, Oct 28, 3:05 AM · User-DannyS712, User-thiemowmde, MediaWiki-Codesniffer
DannyS712 claimed T242762: Expand PHPUnitAssertEqualsSniff to better auto-fix comparisons with count().

Will do, given that this will add yet another PHPUnit sniff should probably go after

Wed, Oct 28, 3:05 AM · User-DannyS712, User-thiemowmde, MediaWiki-Codesniffer
DannyS712 moved T253910: Sniff for wrong order of PHPUnit assert parameters from Next to Awaiting review and deployment on the User-DannyS712 board.
Wed, Oct 28, 2:58 AM · Patch-For-Review, User-DannyS712, MediaWiki-Codesniffer

Tue, Oct 27

DannyS712 closed T266589: Unable to semi-protect properties on Wikidata as Declined.

This is intentional, since the namespace is protected
See rMW8862991ce1b1: Improve UI for page protection with $wgNamespaceProtection by @Anomie

Tue, Oct 27, 8:14 PM · MediaWiki-Page-protection, Wikidata
DannyS712 updated subscribers of P12854 Masterwork From Distant Lands.

@Urbanecm simplewiki 23 was a false positive - the use of rmspecials was in a comment. Should that be accounted for and excluded by the script?

Tue, Oct 27, 7:51 PM
DannyS712 updated the task description for T266584: Ensure current use cases of rmspecials are ready for change in its functionality.
Tue, Oct 27, 7:48 PM · Chinese-Sites, User-Huji, AbuseFilter (Overhaul-2020)
DannyS712 added a comment to T266526: Prevent users from creating categories with U+FFFC OBJECT REPLACEMENT CHARACTER.

Alternatively can be implemented via title blacklist

Tue, Oct 27, 4:53 PM · MediaWiki-General
DannyS712 placed T262721: Proposal: Separate Phabricator project for semi-automated edit requests in XTools up for grabs.
Tue, Oct 27, 3:04 AM · PM, Project-Admins, User-Matthewrbowker, XTools
DannyS712 moved T253760: TimelineRowFormatter uses a custom signature for the msg method from Later to Awaiting review and deployment on the User-DannyS712 board.

Forgot about this entirely, sorry

Tue, Oct 27, 3:03 AM · Patch-For-Review, User-DannyS712, Technical-Debt, Anti-Harassment, CheckUser

Mon, Oct 26

DannyS712 added a comment to T251588: EditPage save hooks pass an entire `EditPage` object.

For now, the constraint system is completely internal, and until the backend is fully factored out of EditPage it should probably stay that way. I agree that the "perfect solution" is to eliminate these hooks if possible. The full migration to a backend cannot proceed until eventually the hooks passing instances of EditPage objects are removed, since the backend won't know about EditPage

Mon, Oct 26, 10:49 PM · Editing-team, Product-Analytics, Analytics, User-DannyS712, Platform Engineering, MediaWiki-Page-editing
DannyS712 closed T266476: Release mediawiki-codesniffer v32.0.0 as Resolved.
Mon, Oct 26, 5:09 PM · Release, MediaWiki-Codesniffer
DannyS712 added a comment to T258108: Turn off auto-watchlist preferences for bots.

It might be nice to prune some of the existing bot entry rows too. There's precedent for this sort of action, see T184485

Mon, Oct 26, 5:00 PM · Platform Engineering, MediaWiki-Watchlist, Growth-Team
DannyS712 moved T208448: Suggestion to add rule for sniffing phpDoc ref tags from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mon, Oct 26, 4:46 PM · MediaWiki-Codesniffer
DannyS712 moved T200028: Add sniff to discourage of use of count() in condition expressions (e.g. if and while) from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mon, Oct 26, 4:46 PM · MediaWiki-Codesniffer
DannyS712 removed a project from T255826: Sort special page alises alphabetically: MediaWiki-Codesniffer.

This is a task for the core change, the sniff to add the functionality to codesniffer was done separately

Mon, Oct 26, 4:22 PM · Patch-For-Review, User-Huji, I18n, MediaWiki-General
DannyS712 moved T258925: Do not warn about missing function doc comment when parameter and return types are fully specified by type hints from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mon, Oct 26, 4:22 PM · MediaWiki-Codesniffer
DannyS712 moved T265231: Sniff for detecting variables named in snake_case style? (lowercase, separation included using underscores) from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mon, Oct 26, 4:22 PM · MediaWiki-Codesniffer
DannyS712 moved T266193: Add a sniff for empty lines between use statements from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mon, Oct 26, 4:21 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 added a comment to T127241: phpcs should error on unclosed @codingStandardsIgnoreStart annotations.

This task was created before the new phpcs tags was there, so would be nice to have it for @phpcs / phpcs as well.

Mon, Oct 26, 4:10 PM · User-DannyS712, Patch-For-Review, MediaWiki-Codesniffer
DannyS712 closed T155627: Add phpcs rule againt a space after unary minus operator as Resolved.
Mon, Oct 26, 3:52 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 closed T251443: Add a sniff for non-global variables named like globals as Resolved.
Mon, Oct 26, 3:38 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 closed T264948: Prohibit use of 'object' as type in docblocks as Resolved.
Mon, Oct 26, 3:29 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 added a project to T266476: Release mediawiki-codesniffer v32.0.0: Release.
Mon, Oct 26, 3:21 PM · Release, MediaWiki-Codesniffer

Sun, Oct 25

DannyS712 added a comment to T265308: Stop extending core's SpecialRandompage.

It should, generally, be okay for core to extend core classes, but I agree that extensions should not be extending this, since it is not stable to extend

Sun, Oct 25, 9:07 PM · MediaWiki-extensions-RandomInCategory, MediaWiki-extensions-WikimediaIncubator, MediaWiki-Special-pages
DannyS712 changed the subtype of T266385: Eligible voter list should be shown in read-only fashion to non-election admins from "Task" to "Feature Request".
Sun, Oct 25, 6:38 PM · Platform Engineering, User-Huji, MediaWiki-extensions-SecurePoll
DannyS712 renamed T266385: Eligible voter list should be shown in read-only fashion to non-election admins from Eligible voter list shoudl be shown in read-only fashion to non-election admins to Eligible voter list should be shown in read-only fashion to non-election admins.
Sun, Oct 25, 6:37 PM · Platform Engineering, User-Huji, MediaWiki-extensions-SecurePoll
DannyS712 merged T266395: $wgNamespaceProtection status is not displayed in the page information into T45283: InfoAction doesn't take namespace protection into account.
Sun, Oct 25, 6:26 AM · Platform Team Workboards (External Code Reviews), Patch-For-Review, MediaWiki-Page-protection
DannyS712 merged task T266395: $wgNamespaceProtection status is not displayed in the page information into T45283: InfoAction doesn't take namespace protection into account.
Sun, Oct 25, 6:26 AM · MediaWiki-Page-protection
DannyS712 added a project to T266397: Endless animation in tab bar an certain window size.: Wikimedia-General-or-Unknown.
Sun, Oct 25, 6:25 AM · Vector
DannyS712 added a comment to T266397: Endless animation in tab bar an certain window size..

Having downloaded the video, steps to reproduce:
Visit, eg, https://de.wikipedia.org/wiki/Wikipedia
Progressively zoom in until the five article tabs (page, talk, view, edit, history) (locally: "Artikel Diskussion Lesen Quelltext anzeigen Versionsgeschichte") no longer fit on one line (for me this was 200% zoom in chrome)
Expected result: display is stable
Actual result:
Display alternatives between shifting the right set of tabs (Lesen Quelltext anzeigen Versionsgeschichte) to a separate line and hiding the right-most tab (Versionsgeschichte) entirely

Sun, Oct 25, 6:24 AM · Vector

Sat, Oct 24

DannyS712 closed T247813: Create a sniff to enforce alphabetical order of literal arrays as Resolved.
Sat, Oct 24, 2:34 AM · MediaWiki-Codesniffer
DannyS712 added a comment to T247813: Create a sniff to enforce alphabetical order of literal arrays.

Given that this new sniff does nothing unless manually applied with @require-sorted-array, unless there are any objections soon I plan to +2 the patch

Sat, Oct 24, 2:27 AM · MediaWiki-Codesniffer
DannyS712 moved T253462: Allow aspects of edits or logs to be revdeled while other aspects are supressed from Unsorted to Later on the User-DannyS712 board.
Sat, Oct 24, 2:15 AM · Platform Engineering, User-DannyS712, User-Huji, MediaWiki-Revision-deletion
DannyS712 added projects to T253462: Allow aspects of edits or logs to be revdeled while other aspects are supressed: User-DannyS712, Platform Engineering.

Fields using the same bit logic (as far as I can tell):
rev_deleted
ar_deleted
oi_deleted
fa_deleted
rc_deleted
log_deleted

Sat, Oct 24, 2:15 AM · Platform Engineering, User-DannyS712, User-Huji, MediaWiki-Revision-deletion

Fri, Oct 23

DannyS712 changed Request URL from https://bn.wikipedia.org/wiki/%E0%A6%AA%E0%A7%87%E0%A6%A8%E0%A7%8D%E0%A6%B8%E0%A6%BF%E0%A6%B2%E0%A7%8D%E2%80%8C%E0%A6%AD%E0%A7%87%E0%A6%A8%E0%A6%BF%E0%A6%AF%E0%A6%BC%E0%A6%BE_%E0%A6%AC%E0%A6%BF%E0%A6%B6%E0%A7%8D%E0%A6%AC%E0%A6%AC%E0%A6%BF%E0%A6%A6%E0%A7%8D%E0%A6%AF%E0%A6%BE%E0%A6%B2%E0%A6%AF%E0%A6%BC to https://bn.wikipedia.org/wiki/পেন্সিল্%E2%80%8Cভেনিয়া_বিশ্ববিদ্যালয় on T265174: Uncaught TypeError: this.items[i].isHighlighted is not a function at OoUiMenuSelectWidget.OO.ui.SelectWidget.highlightItem .
Fri, Oct 23, 9:18 PM · Maps (Kartographer), JavaScript, Wikimedia-production-error, OOUI
DannyS712 added a comment to T263344: DiscussionTools tries to reply to log entries?.

The patch for T252555 is deployed now, and this should be fixed as well. @DannyS712 Can you confirm that the issue no longer occurs?

Fri, Oct 23, 8:44 PM · Editing-team (FY2020-21 Kanban Board), User-DannyS712, DiscussionTools
DannyS712 added a comment to T251588: EditPage save hooks pass an entire `EditPage` object.

OK, we need to review this in tech planning.

Fri, Oct 23, 3:44 AM · Editing-team, Product-Analytics, Analytics, User-DannyS712, Platform Engineering, MediaWiki-Page-editing
DannyS712 added a comment to T258935: Add a limit to the number of sites a user can watch.

@Mooeypoo would you mind taking a look at the patch provided? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/631470

Fri, Oct 23, 2:58 AM · Patch-For-Review, User-DannyS712, MediaWiki-extensions-GlobalWatchlist

Thu, Oct 22

DannyS712 moved T266298: Enable wgAbuseFilterNotificationsPrivate by default for WMF wikis from Unsorted to Others on the User-DannyS712 board.
Thu, Oct 22, 11:43 PM · User-DannyS712, Wikimedia-Site-requests
DannyS712 created T266298: Enable wgAbuseFilterNotificationsPrivate by default for WMF wikis.
Thu, Oct 22, 11:43 PM · User-DannyS712, Wikimedia-Site-requests
DannyS712 updated the task description for T14518: Cross-wiki userrights should use groups from target wiki instead local wiki.
Thu, Oct 22, 11:32 PM · MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), User-DannyS712, User-Rxy, Stewards-and-global-tools, Crosswiki, MediaWiki-User-login-and-signup
DannyS712 moved T266228: Rename namespace_title index on watchlist from Unsorted to Change on the Schema-change board.
Thu, Oct 22, 2:24 PM · Schema-change
DannyS712 added a comment to T253462: Allow aspects of edits or logs to be revdeled while other aspects are supressed.

This will probably also need a maintenance script, and it might be worth tagging DBA to get feedback on the change before proceeding

Thu, Oct 22, 2:22 PM · Platform Engineering, User-DannyS712, User-Huji, MediaWiki-Revision-deletion
DannyS712 added a comment to T265769: Research to create service for BotPassword class.

Nit: there is no point in repeating the class name name in the verbs, IMO. It's a bot password store, of course it's going to insert bot passwords. Just call it insert / update / invalidateAllForUser etc.

Thu, Oct 22, 2:59 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-DannyS712, MediaWiki-Authentication-and-authorization, Dependency injection
DannyS712 added a comment to T265769: Research to create service for BotPassword class.

Plan:
BotPasswordStore service:
Handle DB
BotPassword::save -> BotPasswordStore::insertBotPassword and ::updateBotPassword
BotPassword::delete -> BotPasswordStore::deleteBotPassword

Thu, Oct 22, 2:49 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-DannyS712, MediaWiki-Authentication-and-authorization, Dependency injection
DannyS712 moved T265769: Research to create service for BotPassword class from Unsorted to In progress on the User-DannyS712 board.
Thu, Oct 22, 2:44 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-DannyS712, MediaWiki-Authentication-and-authorization, Dependency injection
DannyS712 claimed T265769: Research to create service for BotPassword class.
Thu, Oct 22, 2:13 AM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-DannyS712, MediaWiki-Authentication-and-authorization, Dependency injection
DannyS712 added a project to T265944: Make class WatchAction a real action class and move helper function to own service: MediaWiki-Watchlist.

If WatchAction::doWatchOrUnwatch moves, so should WatchAction::doWatch and WatchAction::doUnwatch
The following services should be injected to the new service:
WatchedItemStore - currently retrieved from MediaWikiServices
PermissionManager - currently retrieved from MediaWikiServices
HookContainer - currently used via Hooks::runner()

Thu, Oct 22, 2:10 AM · MediaWiki-Watchlist, Growth-Team, MediaWiki-General, Dependency injection

Wed, Oct 21

DannyS712 moved T266193: Add a sniff for empty lines between use statements from Unsorted to Later on the User-DannyS712 board.
Wed, Oct 21, 10:08 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 created T266193: Add a sniff for empty lines between use statements.
Wed, Oct 21, 10:08 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 added a comment to T27377: Update username in AbuseFilter interface when user is renamed using Renameuser.

Just came to report this, but it seems to have been done already
Can existing entries be fixed via script?

Wed, Oct 21, 6:15 PM · AbuseFilter (Overhaul-2020), MediaWiki-extensions-Renameuser, MediaWiki-extensions-CentralAuth, GlobalRename
DannyS712 removed a project from T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null: Patch-For-Review.
Wed, Oct 21, 5:43 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-skins-WikimediaApiPortal, User-DannyS712, API-Portal, Wikimedia-production-error
DannyS712 added a comment to T263592: Use of Language::commafy with a non-numeric string was deprecated in MediaWiki 1.36. [Called from Language::formatNum].

Change 635374 merged by jenkins-bot:
[mediawiki/core@master] Re-enable deprecation warning in Language::commafy() for non-numeric string

https://gerrit.wikimedia.org/r/635374

Wed, Oct 21, 3:54 PM · MW-1.35-notes, MW-1.31-release-notes, MediaWiki-extensions-PdfHandler, Commons, MediaWiki-File-management, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), MediaWiki-extensions-Scribunto, MediaWiki-Parser, MediaWiki-General, Patch-For-Review
DannyS712 updated subscribers of T253078: Create ActionFactory, add dependency injection to actions.

@eprodromou is it okay to move forward with this using ObjectFactory specs for DI?

Wed, Oct 21, 3:03 PM · Platform Engineering, Dependency injection, User-DannyS712, MediaWiki-General
DannyS712 changed the subtype of T266121: Hide the watchlist expiration option using a mediawiki based solution from "Task" to "Feature Request".
Wed, Oct 21, 2:30 PM · Community-Tech, Expiring-Watchlist-Items
DannyS712 added a project to T265312: Reverted edit tag applied to protection entries in page history: User-notice.

Tagging user notice for change going forward
Should a maintenance script be added for removing the tag from old null revisions?

Wed, Oct 21, 2:28 PM · User-notice, MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-DannyS712, MediaWiki-Page-editing
DannyS712 added a comment to T250668: Duplicate notifications for my first edit.

Just got this again on to.wikipedia - https://to.wikipedia.org/w/api.php?action=query&meta=notifications confirms 2 notifications that both appear to be for my first edit

Wed, Oct 21, 4:36 AM · User-DannyS712, Growth-Team, Notifications
DannyS712 added a comment to T253462: Allow aspects of edits or logs to be revdeled while other aspects are supressed.

Might I suggest instead

Wed, Oct 21, 3:07 AM · Platform Engineering, User-DannyS712, User-Huji, MediaWiki-Revision-deletion

Tue, Oct 20

DannyS712 closed T202989: Administrators can no longer view deleted history of js/css pages as Resolved.
Tue, Oct 20, 10:47 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-notice, User-DannyS712, Security, User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, JavaScript
DannyS712 moved T202989: Administrators can no longer view deleted history of js/css pages from Not ready to announce to To Triage on the User-notice board.

Patch merging now, should be ready to announce

Tue, Oct 20, 10:26 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-notice, User-DannyS712, Security, User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, JavaScript
DannyS712 removed a project from T258383: Allow Administrators to delete site-wide script pages: Patch-For-Review.

^ patch rescoped to not include this, will do as a follow-up

Tue, Oct 20, 9:43 PM · MediaWiki-Page-deletion, MediaWiki-User-management, User-DannyS712
DannyS712 moved T265818: Make class SpecialPageLanguage a real special page and move helper function to own service from Next to Awaiting review and deployment on the User-DannyS712 board.
Tue, Oct 20, 8:41 PM · Patch-For-Review, User-DannyS712, MediaWiki-General, Dependency injection
DannyS712 removed a project from T265570: WikiLove icon no longer visible following changes to vector classes: User-DannyS712.
Tue, Oct 20, 8:41 PM · Growth-Team (Current Sprint), MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Regression, Vector (Vector (Tracking)), WikiLove
DannyS712 added a comment to T266042: On https://ticket.wikimedia.org/otrs/index.pl the 2FA string has an incorrect translation in Spanish.

@Ezarate to clarify, this is about viewing https://ticket.wikimedia.org/otrs/index.pl in Spanish, rather than viewing https://otrs-wiki.wikimedia.org/wiki/Main_Page in Spanish, right?

Tue, Oct 20, 4:54 PM · Upstream, I18n, OTRS
DannyS712 moved T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Tue, Oct 20, 2:27 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-skins-WikimediaApiPortal, User-DannyS712, API-Portal, Wikimedia-production-error
DannyS712 claimed T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null.
Tue, Oct 20, 2:27 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-skins-WikimediaApiPortal, User-DannyS712, API-Portal, Wikimedia-production-error
DannyS712 added a comment to T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null.

Caused by

'wgWMAPIPSidebarSpecialPages' => [
	// no default, fallback on extension default if extension is
	// installed, unnecessary otherwise
	'apiportalwiki' => [
		'AppManagement',
		'Notifications',
		'Preferences'
	],
],

since Special:AppManagement doesn't exist yet

Tue, Oct 20, 2:20 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-skins-WikimediaApiPortal, User-DannyS712, API-Portal, Wikimedia-production-error
DannyS712 renamed T266021: PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null from PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null in /srv/mediawiki/php-1.36.0-wmf.14/skins/WikimediaApiPortal/src/Component/SecondaryNavComponent.php:122Stack trace:#0 /srv/mediawiki/php-1.36.0-wmf.14/skins/WikimediaApiPortal/src/Component/SecondaryNavComponent.php(64): MediaWiki\Skin\WikimediaApiPortal\Component\SecondaryNavComponent->getSpecialSidebar(Object(Title), Array, Object(TitleFactory), Object(MediaWiki\SpecialPage\SpecialPageFactory))#1 /srv/mediawiki/php-1.36.0-wmf.14/skins/WikimediaApiPortal/src/ComponentFactory.php(226): MediaWiki\Skin\WikimediaApiPortal\Component\SecondaryNavComponent->__construct(Object(MediaWiki\Config\ServiceOptions), Object(MediaWiki\Message\MessageFormatterFactory), Object(MediaWiki\Skin\WikimediaApiPortal\Skin), Object(Title), Object(NamespaceInfo), Object(TitleFactory), Object(MediaWiki\SpecialPage\SpecialPageFactory), Object(PageProps))#2 /srv/mediawiki/php-1.36.0-wmf.14/skins/WikimediaApiPortal/src/ComponentFactory.php(250): MediaWiki\Skin\Wikimed to PHP Fatal Error: Uncaught Error: Call to a member function getDescription() on null.
Tue, Oct 20, 2:17 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), MediaWiki-skins-WikimediaApiPortal, User-DannyS712, API-Portal, Wikimedia-production-error

Sun, Oct 18

DannyS712 triaged T265818: Make class SpecialPageLanguage a real special page and move helper function to own service as Low priority.
Sun, Oct 18, 6:05 PM · Patch-For-Review, User-DannyS712, MediaWiki-General, Dependency injection
DannyS712 claimed T265818: Make class SpecialPageLanguage a real special page and move helper function to own service.
Sun, Oct 18, 6:04 PM · Patch-For-Review, User-DannyS712, MediaWiki-General, Dependency injection
DannyS712 changed Request ID from a879f870-3b2b-41c2-8cca-5feb8f1e7aeb to 0c5ddc64-14bf-4c8e-aa80-7c85a13568f7 on T265814: Special:MathStatus fails on api.wikimedia.org.
Sun, Oct 18, 8:23 AM · API-Portal, User-DannyS712, Platform Team Initiatives (API Gateway), Math, Wikimedia-production-error
DannyS712 moved T265815: skins/WikimediaApiPortal COPYING doesn't match license from Unsorted to Reports on the User-DannyS712 board.
Sun, Oct 18, 8:09 AM · Patch-For-Review, Software-Licensing, User-DannyS712, MediaWiki-skins-WikimediaApiPortal
DannyS712 created T265815: skins/WikimediaApiPortal COPYING doesn't match license.
Sun, Oct 18, 8:09 AM · Patch-For-Review, Software-Licensing, User-DannyS712, MediaWiki-skins-WikimediaApiPortal
DannyS712 moved T265814: Special:MathStatus fails on api.wikimedia.org from Unsorted to Reports on the User-DannyS712 board.
Sun, Oct 18, 8:04 AM · API-Portal, User-DannyS712, Platform Team Initiatives (API Gateway), Math, Wikimedia-production-error
DannyS712 created T265814: Special:MathStatus fails on api.wikimedia.org.
Sun, Oct 18, 8:04 AM · API-Portal, User-DannyS712, Platform Team Initiatives (API Gateway), Math, Wikimedia-production-error

Sat, Oct 17

DannyS712 moved T265805: Archive Phabricator project #Research-Archive ? from Incoming to Projects to archive on the Project-Admins board.
Sat, Oct 17, 11:16 PM · Project-Admins, Research
DannyS712 added a project to T265805: Archive Phabricator project #Research-Archive ?: Project-Admins.
Sat, Oct 17, 11:15 PM · Project-Admins, Research
DannyS712 added a comment to T202989: Administrators can no longer view deleted history of js/css pages.

There is no justification for preventing administrators viewing or restoring this.

Well, for restoring there is. Undeletion (in particular selective restoration after deletion) is tantamount to editing, which would otherwise be prohibited; depending on the page, that could also mean execution of code by users.

Sat, Oct 17, 8:52 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), User-notice, User-DannyS712, Security, User-Tgr, Trust-and-Safety, Wikimedia-General-or-Unknown, JavaScript

Fri, Oct 16

DannyS712 changed the subtype of T54849: Checkuser option "get users" should point out when user password is changed from "Task" to "Feature Request".
Fri, Oct 16, 9:27 PM · Stewards-and-global-tools, CheckUser
DannyS712 triaged T196955: Add the ability to add a timer to global locks as Lowest priority.
Fri, Oct 16, 9:24 PM · Stewards-and-global-tools, MediaWiki-extensions-CentralAuth, GlobalBlocking
DannyS712 added a project to T265764: Requesting removal from some Gerrit groups: Gerrit-Privilege-Requests.
Fri, Oct 16, 9:09 PM · Gerrit-Privilege-Requests, Gerrit
DannyS712 removed a project from T265693: `oathauth-disable-header` message is missing: Patch-For-Review.
Fri, Oct 16, 8:28 PM · MW-1.36-notes (1.36.0-wmf.14; 2020-10-20), User-Urbanecm, User-DannyS712, MediaWiki-extensions-OATHAuth
DannyS712 closed T265755: Audit and empty non-existent user groups on the beta cluster as Resolved.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=enwiki autoreview
Removing users from autoreview...
  ...done! Removed 17 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=enwiki suppress
Removing users from suppress...
  ...done! Removed 5 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=fawiki uploader
Removing users from uploader...
  ...done! Removed 6 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=fawiki autopatrol
Removing users from autopatrol...
  ...done! Removed 1 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=testwiki autoreview
Removing users from autoreview...
  ...done! Removed 2 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=testwiki editor
Removing users from editor...
  ...done! Removed 1 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=testwiki suppress
Removing users from suppress...
  ...done! Removed 1 users in total.
dannys712@deployment-deploy01:~$ mwscript maintenance/emptyUserGroup.php --wiki=zhwiki autoconfirmed
Removing users from autoconfirmed...
  ...done! Removed 3 users in total.
Fri, Oct 16, 7:07 PM · User-DannyS712, Beta-Cluster-Infrastructure, Wikimedia-maintenance-script-run
DannyS712 updated the task description for T265755: Audit and empty non-existent user groups on the beta cluster.
Fri, Oct 16, 7:02 PM · User-DannyS712, Beta-Cluster-Infrastructure, Wikimedia-maintenance-script-run