Page MenuHomePhabricator

DannyS712
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2018, 9:15 PM (76 w, 2 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DannyS712 [ Global Accounts ]

Recent Activity

Today

DannyS712 added a comment to T249675: index.php should handle section=T-1 etc. when using action=raw.

action=raw handles section=1 fine, but not section=T-1

Wed, Apr 8, 3:29 AM · User-DannyS712, MediaWiki-General
DannyS712 moved T249675: index.php should handle section=T-1 etc. when using action=raw from Unsorted to In progress on the User-DannyS712 board.
Wed, Apr 8, 3:23 AM · User-DannyS712, MediaWiki-General
DannyS712 added projects to T249675: index.php should handle section=T-1 etc. when using action=raw: MediaWiki-General, User-DannyS712.
Wed, Apr 8, 3:22 AM · User-DannyS712, MediaWiki-General
DannyS712 updated the task description for T249021: Hard deprecate Revision::newFromId.
Wed, Apr 8, 2:44 AM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 updated the task description for T249397: Replace LinksUpdate Revision methods with RevisionRecord.
Wed, Apr 8, 2:44 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), PageImages, Event-Platform, PageCuration, Notifications, Technical-Debt (Deprecation process), Analytics, MediaWiki-Revision-backend, User-DannyS712, Growth-Team
DannyS712 updated the task description for T249397: Replace LinksUpdate Revision methods with RevisionRecord.
Wed, Apr 8, 2:24 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), PageImages, Event-Platform, PageCuration, Notifications, Technical-Debt (Deprecation process), Analytics, MediaWiki-Revision-backend, User-DannyS712, Growth-Team
DannyS712 committed rECHB05d0240543dc: Accept empty strings in metadata, fix a typo (authored by DannyS712).
Accept empty strings in metadata, fix a typo
Wed, Apr 8, 12:59 AM

Yesterday

DannyS712 added a comment to T249446: Add a MergeHistoryFactory and convert MergeHistory to DI.

I made a proof of concept at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/587314/ that adds a ComplexStorageOperationFactory implementing a MergeHistoryFactory interface and a MovePageFactory interface. Some issues:

  • If MergeHistory ever needs config values injected, there will be issues with the standard $options->assertRequiredOptions( self::CONSTRUCTOR_OPTIONS );, because the different interfaces will need different options, and there isn't an easy way to check which one is desired
  • The tests using FactoryArgTestTrait only cover half of the combined factory, and it only works because one of the objects being created uses all of the available dependencies. If MergeHistory needs a service that MovePage doesn't, it will no longer be possible to use the FactoryArgTestTrait test
  • Since MergeHistory accepts an option parameter in its constructor, its awkward to require that the services be passed

In short, I don't think a shared factory is going to work

Tue, Apr 7, 9:00 PM · MediaWiki-General, Core Platform Team, User-DannyS712, Dependency injection
DannyS712 placed T247127: Add a MessageLocalizer service up for grabs.
Tue, Apr 7, 7:11 PM · Dependency injection, Patch-For-Review, Core Platform Team Workboards (Clinic Duty Team), CPT Initiatives (Decoupling (CDP2)), MediaWiki-General, User-DannyS712
DannyS712 added a comment to T52329: We need a common repository for Scribunto modules and templates.

This just came up as an issue on enwikinews - wherever the original content is hosted must be compatible / released with CC-BY-2.5 to be able to use it on enwikinews

Do you have a link?

Tue, Apr 7, 7:08 PM · MediaWiki-Templates, Community-Wishlist-Survey-2015, Crosswiki, MediaWiki-extensions-Scribunto
DannyS712 added a comment to T52329: We need a common repository for Scribunto modules and templates.

This just came up as an issue on enwikinews - wherever the original content is hosted must be compatible / released with CC-BY-2.5 to be able to use it on enwikinews

Tue, Apr 7, 6:32 PM · MediaWiki-Templates, Community-Wishlist-Survey-2015, Crosswiki, MediaWiki-extensions-Scribunto
DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.

Oh, I blocked it on enwiki. I didn't realize that was the wrong place. Should I just unblock it there?

Tue, Apr 7, 5:26 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.

Just for the record, as the admin who performed the block, I have no objection to any other admin unblocking, once there's agreement that it's appropriate to do so.

Tue, Apr 7, 5:20 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.

Is it the time to unblock EmausBot?

Tue, Apr 7, 5:00 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 added a parent task for T233965: 9: Add help link: T245336: 111: Newsletter, issue 6.
Tue, Apr 7, 4:34 PM · DannyS712-Global_watchlist.js, User-DannyS712
DannyS712 added a subtask for T245336: 111: Newsletter, issue 6: T233965: 9: Add help link.
Tue, Apr 7, 4:34 PM · User-DannyS712, DannyS712-Global_watchlist.js
DannyS712 closed T233965: 9: Add help link as Resolved.

Done in 8.4.1, though without a help icon :(

Tue, Apr 7, 4:31 PM · DannyS712-Global_watchlist.js, User-DannyS712
DannyS712 changed the status of T233965: 9: Add help link from Stalled to Open.

I closed T227705: Add "help" link to Special:BlankPage as declined; will need to implement manually

Tue, Apr 7, 4:13 PM · DannyS712-Global_watchlist.js, User-DannyS712
DannyS712 removed a project from T227705: Add "help" link to Special:BlankPage: Patch-For-Review.
Tue, Apr 7, 4:12 PM · User-DannyS712, MediaWiki-Special-pages
DannyS712 closed T227705: Add "help" link to Special:BlankPage as Declined.

https://www.mediawiki.org/wiki/Manual:Special_pages#Custom_special_pages does not provide the relevant information (for one thing, it never even mentions Special:BlankPage so for a non-technical user that help page is completely useless).
I am tempted to outright decline this task. It is up to the wikis with those user scripts to also create a pertinent help page and/or a script that would show a help link.

Tue, Apr 7, 4:12 PM · User-DannyS712, MediaWiki-Special-pages
DannyS712 closed T244086: 100: Not working on iOS as Invalid.

Without more info this cannot be addressed

Tue, Apr 7, 4:10 PM · User-DannyS712, DannyS712-Global_watchlist.js
DannyS712 updated the task description for T249623: MWException when logging in on wikitech: "CAS update failed on user_touched. The version of the user to be saved is older than the current version.".
Tue, Apr 7, 3:21 PM · MediaWiki-User-management, wikitech.wikimedia.org, MediaWiki-User-login-and-signup, Wikimedia-production-error, User-DannyS712
DannyS712 moved T249623: MWException when logging in on wikitech: "CAS update failed on user_touched. The version of the user to be saved is older than the current version." from Unsorted to Reports on the User-DannyS712 board.
Tue, Apr 7, 3:21 PM · MediaWiki-User-management, wikitech.wikimedia.org, MediaWiki-User-login-and-signup, Wikimedia-production-error, User-DannyS712
DannyS712 created T249623: MWException when logging in on wikitech: "CAS update failed on user_touched. The version of the user to be saved is older than the current version.".
Tue, Apr 7, 3:20 PM · MediaWiki-User-management, wikitech.wikimedia.org, MediaWiki-User-login-and-signup, Wikimedia-production-error, User-DannyS712
DannyS712 added a comment to T249596: Rebuild wb_items_per_site, after incident where wb_items_per_site was dropped.

@Addshore if you end up with a list of duplicates and can share it with me I can delete the items

Tue, Apr 7, 1:27 PM · MW-1.35-notes (1.35.0-wmf.26; 2020-03-31), User-Addshore, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, Wikidata
QEDK awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a Like token.
Tue, Apr 7, 1:07 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 closed T249592: Request for interface admin permission on zh beta cluster as Resolved.

Granted indefinitely

Tue, Apr 7, 1:04 PM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 claimed T249592: Request for interface admin permission on zh beta cluster.
Tue, Apr 7, 1:02 PM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 moved T249585: am.wikimedia sysops have the '0' right from Unsorted to Next on the User-DannyS712 board.
Tue, Apr 7, 6:35 AM · Wikimedia-Site-requests, User-DannyS712
DannyS712 created T249585: am.wikimedia sysops have the '0' right.
Tue, Apr 7, 6:35 AM · Wikimedia-Site-requests, User-DannyS712
DannyS712 removed a project from T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views: Patch-For-Review.
Tue, Apr 7, 4:46 AM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 moved T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views from Untriaged to Apr 2020 / 1.35-wmf.26+ on the Wikimedia-production-error board.
Tue, Apr 7, 4:34 AM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 closed T249582: Exclude Worddisk.com from Earwig's Copyvio Detector's search as Invalid.
Tue, Apr 7, 4:33 AM
DannyS712 added a comment to T249582: Exclude Worddisk.com from Earwig's Copyvio Detector's search.

@Darylgolden can you give a specific url that was copied?

Tue, Apr 7, 4:31 AM
DannyS712 updated the task description for T249183: Hard deprecate Revision::newFromTitle.
Tue, Apr 7, 2:12 AM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Core Platform Team Workboards (External Code Reviews), Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 added a comment to T249561: Deprecate methods accepting Revision objects as parameters.

Change 586484 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TwoColConflict@master] Don't create a Revision object for Linker::revUserTools
https://gerrit.wikimedia.org/r/586484

Tue, Apr 7, 1:29 AM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 updated the task description for T249183: Hard deprecate Revision::newFromTitle.
Tue, Apr 7, 1:24 AM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Core Platform Team Workboards (External Code Reviews), Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
NickK awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a The World Burns token.
Tue, Apr 7, 12:14 AM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.

Logging here an unfortunate consequence: it is now possible to create a duplicate item linked to the same page.
Behaviour to reproduce:

  1. https://uk.wikipedia.org/wiki/Кнайпа displayed as not linked to any Wikidata item.
  2. https://de.wikipedia.org/wiki/Kneipe displayed as linked to https://www.wikidata.org/wiki/Q19754932 (the ukwiki article is linked to it as well)
  3. A null edit on ukwiki does not help it link to Wikidata (still not linked)
  4. To force linking I used a link on the sidebar in ukwiki and I add link to Kneipe on dewiki. The result is https://www.wikidata.org/wiki/Q89610534

I think it would be a good idea to block editing on Wikidata at the moment to avoid further damage.

Tue, Apr 7, 12:14 AM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error

Mon, Apr 6

DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.

Note in Wikidata EmausBot is creating a lot of duplicated items: https://www.wikidata.org/wiki/Special:NewPages

And due to this, rebuilding wb_items_per_site may results in some errors (see https://www.wikidata.org/wiki/Wikidata:True_duplicates)

Mon, Apr 6, 11:52 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.

Note in Wikidata EmausBot is creating a lot of duplicated items: https://www.wikidata.org/wiki/Special:NewPages

Mon, Apr 6, 11:35 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 merged T249571: DBQueryError in wikitext2017 into T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:27 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 merged task T249571: DBQueryError in wikitext2017 into T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:27 PM · Editing-team
Volker_E awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a Like token.
Mon, Apr 6, 11:23 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
AntonierCH awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a The World Burns token.
Mon, Apr 6, 11:19 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 merged T249570: DBMS error adding a statement into T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:19 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 merged task T249570: DBMS error adding a statement into T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:19 PM · Wikimedia-database-error
DannyS712 updated the task description for T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:18 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
Mvolz awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a The World Burns token.
Mon, Apr 6, 11:18 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
Dreamy_Jazz awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a Like token.
Mon, Apr 6, 11:18 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
Thibaut120094 awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a The World Burns token.
Mon, Apr 6, 11:17 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
Wittylama awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a Like token.
Mon, Apr 6, 11:17 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
ToBeFree awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a Like token.
Mon, Apr 6, 11:15 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
Can_I_Log_In awarded T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views a Like token.
Mon, Apr 6, 11:15 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 added a comment to T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:10 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 renamed T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views from Unable to open some pages on metawiki - DBQueryError to Unable to open some pages on multiple wikis - DBQueryError.
Mon, Apr 6, 11:07 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 renamed T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views from Unable to open some pages on metawiki to Unable to open some pages on metawiki - DBQueryError.
Mon, Apr 6, 11:06 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 changed the subtype of T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views from "Task" to "Production Error".
Mon, Apr 6, 11:05 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 created T249565: Wikidata's wb_items_per_site table has suddenly disappeared, creating DBQueryErrors on page views.
Mon, Apr 6, 11:05 PM · Patch-For-Review, User-Addshore, MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-notice, Wikimedia-Incident, User-Ladsgroup, Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), MediaWiki-extensions-WikibaseRepository, DBA, Wikidata, User-DannyS712, Wikimedia-production-error
DannyS712 edited P10916 Core methods that can accept Revisions.
Mon, Apr 6, 10:55 PM
DannyS712 added a parent task for T249397: Replace LinksUpdate Revision methods with RevisionRecord: T249561: Deprecate methods accepting Revision objects as parameters.
Mon, Apr 6, 10:52 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), PageImages, Event-Platform, PageCuration, Notifications, Technical-Debt (Deprecation process), Analytics, MediaWiki-Revision-backend, User-DannyS712, Growth-Team
DannyS712 added a subtask for T249561: Deprecate methods accepting Revision objects as parameters: T249397: Replace LinksUpdate Revision methods with RevisionRecord.
Mon, Apr 6, 10:52 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 updated the task description for T249561: Deprecate methods accepting Revision objects as parameters.
Mon, Apr 6, 10:52 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 created P10916 Core methods that can accept Revisions.
Mon, Apr 6, 10:51 PM
DannyS712 added a comment to T249561: Deprecate methods accepting Revision objects as parameters.

Change 586459 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Accept RevisionRecord in Linker methods
https://gerrit.wikimedia.org/r/586459

Mon, Apr 6, 10:43 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 triaged T249563: Hard deprecate WikiPage::doEditUpdates as Medium priority.
Mon, Apr 6, 10:23 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 moved T249563: Hard deprecate WikiPage::doEditUpdates from Unsorted to In progress on the User-DannyS712 board.
Mon, Apr 6, 10:23 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 moved T249563: Hard deprecate WikiPage::doEditUpdates from Untriaged to 2020 | MW 1.35 / 1.36 on the Technical-Debt (Deprecation process) board.
Mon, Apr 6, 10:23 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 created T249563: Hard deprecate WikiPage::doEditUpdates.
Mon, Apr 6, 10:23 PM · Wikidata, MediaWiki-extensions-WikibaseRepository, Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 triaged T249561: Deprecate methods accepting Revision objects as parameters as Medium priority.
Mon, Apr 6, 10:21 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 moved T249561: Deprecate methods accepting Revision objects as parameters from Untriaged to 2020 | MW 1.35 / 1.36 on the Technical-Debt (Deprecation process) board.
Mon, Apr 6, 10:21 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 created T249561: Deprecate methods accepting Revision objects as parameters.
Mon, Apr 6, 10:21 PM · Patch-For-Review, MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 updated the task description for T249021: Hard deprecate Revision::newFromId.
Mon, Apr 6, 9:08 PM · MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), Core Platform Team Workboards (External Code Reviews), Patch-For-Review, Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 added a comment to T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.

But, what happens to the redirects I left behind (including when I moved the files to a name other than the bot would have) - are they deleted?

If the uppercased target name doesn't exist, the redirect will be moved to that name.
If the uppercased target name does exist, the script will rename it to the name suffixed with "(former Unicode lowercase)".[1] If https://gerrit.wikimedia.org/r/c/mediawiki/core/+/585900 gets merged in time and the "(former Unicode lowercase)" would wind up pointing to the unsuffixed name or the unsuffixed name is a redirect to the same target as the suffixed name, the script will then delete the suffixed redirect.
[1]: That should be fixed for the file namespace, where extensions matter...

Mon, Apr 6, 9:05 PM · Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, Operations, PHP 7.2 support, MediaWiki-General
DannyS712 added a comment to T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.

I assumed since the title would be unreachable it wouldn't work

Hmm. The file redirect would probably work, except the maintenance script won't actually leave a redirect behind at the soon-to-be-unreachable title because it will soon be unreachable. So yeah, do the moves and cleanup of references manually if you can.
The planned process is like this:

  1. We move all the pages to the new uppercased titles. No redirects are left behind, so links to the lowercased titles will no longer work.
  2. We remove the override that's preventing MediaWiki from uppercasing these letters. Now all the links start working again, just like links to "example" automatically target "Example".
  3. We run the script again, which will hopefully find nothing to do (but might if someone did something in between when we did #1 and #2).
  4. Produce a list of any "former Unicode lowercase" titles actually created, for communities to clean up.

We hope that the time spent in between #1 and #2 will only be a few minutes. We could as well do #2 first and then #1, but links would still be broken in between the two steps.

Mon, Apr 6, 7:54 PM · Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, Operations, PHP 7.2 support, MediaWiki-General
DannyS712 added a comment to T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.

The titles will be by user "Maintenance script" beginning 13 April 2020.

If someone can update global userpage of this account with up to date information, that would be awesome :)

Mon, Apr 6, 7:29 PM · Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, Operations, PHP 7.2 support, MediaWiki-General
DannyS712 added a comment to T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.

Since the old title will not work anymore,

Don't file redirects work?

Mon, Apr 6, 7:28 PM · Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, Operations, PHP 7.2 support, MediaWiki-General
DannyS712 added a comment to T219279: Some pages will become completely unreachable after PHP7 update due to Unicode changes.

Suggestion for User-notice
Mediawiki is upgrading to a newer version of Unicode. Some characters that did not have an uppercase before do now. Titles beginning with one of these characters will be moved. A list of these title can be seen at https://phabricator.wikimedia.org/P10817. The titles will be by user "Maintenance script" beginning 13 April 2020. You may rename them ahead of time if you wish and the new title can be different from the one the script would rename it to.

Mon, Apr 6, 7:10 PM · Patch-For-Review, User-notice, Core Platform Team Workboards (Clinic Duty Team), MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), serviceops, Operations, PHP 7.2 support, MediaWiki-General
DannyS712 added a comment to T249434: Replace hooks using Revision objects with RevisionRecord.

The UndeleteShowRevision hook is entirely unused; it can just be hard deprecated. If a use case emerges, it can be added back as UndeleteShowRevisionRecord with a RevisionRecord instead

Mon, Apr 6, 6:40 PM · Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 added a comment to T244556: add sniffs for using less specific assertions.

How is any of the assertion listed in this tasks description an issue? What do we win by disallowing one form?

Mon, Apr 6, 5:23 PM · Patch-For-Review, User-DannyS712, MediaWiki-Codesniffer
DannyS712 added a comment to T249446: Add a MergeHistoryFactory and convert MergeHistory to DI.

Conceptually MergeHistory looks exactly the same as MovePage - it's a class lying one level up from storage layer, made to do a complex task consisting of a collection of individual storage operations.
We already have a MovePageFactory, so adding a MergeHistoryFactory we're going to be setting up the pattern for classes like this. I donno how many more classes like this we have. If that's a lot, we should probably invent something more complex then adding a factory per class, if so far it's not a lot, I think we can live with interface-per-utility class and share an implementation or merge them all together into a ComplexStorageOperationFactory (name is horrible) interface. At least MovePage and MergeHistory seem to have very similar dependencies.

Mon, Apr 6, 5:03 PM · MediaWiki-General, Core Platform Team, User-DannyS712, Dependency injection
DannyS712 removed a project from T247029: Watchlist API: Filter out expired items from api.php?action=query&list=watchlist: Patch-For-Review.
Mon, Apr 6, 2:48 AM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Community-Tech (Kanban-2019-20-Q4), TCB-Team, Expiring-Watchlist-Items
DannyS712 updated the task description for T249459: Hard deprecate global function wfIsBadImage and remove a release later.
Mon, Apr 6, 2:35 AM · Technical-Debt (Deprecation process), MediaWiki-General

Sun, Apr 5

DannyS712 added a comment to T249307: Unable to login to wikisource.org: "No active login attempt is in progress for your session.".

https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems

  • The issue did not occur in chrome's incognito mode
  • The issue did not occur with the remember flag enabled
  • The issue did not occur on other wikis
Sun, Apr 5, 11:22 PM · MediaWiki-User-login-and-signup, MediaWiki-extensions-CentralAuth, User-DannyS712
DannyS712 reopened T249307: Unable to login to wikisource.org: "No active login attempt is in progress for your session." as "Open".

...and its happening again

Sun, Apr 5, 11:19 PM · MediaWiki-User-login-and-signup, MediaWiki-extensions-CentralAuth, User-DannyS712
DannyS712 moved T249446: Add a MergeHistoryFactory and convert MergeHistory to DI from Unsorted to Next on the User-DannyS712 board.
Sun, Apr 5, 1:30 PM · MediaWiki-General, Core Platform Team, User-DannyS712, Dependency injection
DannyS712 created T249446: Add a MergeHistoryFactory and convert MergeHistory to DI.
Sun, Apr 5, 1:30 PM · MediaWiki-General, Core Platform Team, User-DannyS712, Dependency injection
DannyS712 added a comment to T249380: RfC: Per namespace view restrictions.
Sun, Apr 5, 1:09 PM · MediaWiki-User-management, MediaWiki-Configuration, TechCom-RFC, Developer-Wishlist (2017), User-DannyS712, MediaWiki-Page-protection, Proposal, MediaWiki-General
DannyS712 added a comment to T244556: add sniffs for using less specific assertions.

Change 585973 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/tools/codesniffer@master] Add a sniff for using assertNull instead of assertSame with null
https://gerrit.wikimedia.org/r/585973

Sun, Apr 5, 7:40 AM · Patch-For-Review, User-DannyS712, MediaWiki-Codesniffer
DannyS712 moved T244556: add sniffs for using less specific assertions from Unsorted to In progress on the User-DannyS712 board.
Sun, Apr 5, 7:12 AM · Patch-For-Review, User-DannyS712, MediaWiki-Codesniffer
DannyS712 closed T248183: Sniff for boolean/integer should not be case sensitive as Resolved.
Sun, Apr 5, 6:40 AM · User-DannyS712, MediaWiki-Codesniffer

Sat, Apr 4

DannyS712 added a comment to T245336: 111: Newsletter, issue 6.

Drafting at https://meta.wikimedia.org/wiki/User:DannyS712/Global_watchlist/Updates/Update_6

Sat, Apr 4, 11:47 PM · User-DannyS712, DannyS712-Global_watchlist.js
DannyS712 added a parent task for T241874: 96: Mark as seen should use `timestamp`: T245336: 111: Newsletter, issue 6.
Sat, Apr 4, 11:41 PM · User-DannyS712, DannyS712-Global_watchlist.js
DannyS712 added a subtask for T245336: 111: Newsletter, issue 6: T241874: 96: Mark as seen should use `timestamp`.
Sat, Apr 4, 11:41 PM · User-DannyS712, DannyS712-Global_watchlist.js
DannyS712 closed T241874: 96: Mark as seen should use `timestamp` as Resolved.

Done in 8.4.0

Sat, Apr 4, 11:41 PM · User-DannyS712, DannyS712-Global_watchlist.js
DannyS712 removed a subtask for T246284: Hard deprecate the Revision class: T232877: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet.
Sat, Apr 4, 10:04 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712
DannyS712 added a subtask for T249434: Replace hooks using Revision objects with RevisionRecord: T232877: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet.
Sat, Apr 4, 10:04 PM · Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 edited parent tasks for T232877: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet, added: T249434: Replace hooks using Revision objects with RevisionRecord; removed: T246284: Hard deprecate the Revision class.
Sat, Apr 4, 10:03 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), User-DannyS712, CPT Initiatives (MCR), Documentation, MediaWiki-General, Technical-Debt
DannyS712 updated the task description for T249434: Replace hooks using Revision objects with RevisionRecord.
Sat, Apr 4, 10:03 PM · Core Platform Team Workboards (Clinic Duty Team), Technical-Debt (Deprecation process), MediaWiki-Revision-backend, User-DannyS712
DannyS712 triaged T246284: Hard deprecate the Revision class as Medium priority.
Sat, Apr 4, 9:54 PM · MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), Core Platform Team Workboards (Clinic Duty Team), Patch-For-Review, Technical-Debt (Deprecation process), Epic, MediaWiki-Revision-backend, User-DannyS712