User Details
- User Since
- Oct 21 2018, 9:15 PM (224 w, 3 d)
- Availability
- Available
- LDAP User
- Unknown
- MediaWiki User
- DannyS712 [ Global Accounts ]
Tue, Jan 31
Mon, Jan 30
Sun, Jan 22
Thu, Jan 19
Wed, Jan 18
Tue, Jan 17
Fri, Jan 13
Thu, Jan 12
Jan 1 2023
Dec 21 2022
Dec 18 2022
@Bawolff is this still an issue with the latest version of codesniffer (40.0.1)?
Dec 17 2022
@pwangai do you have any updates? This makes it a bit hard to review patches relating to test coverage
Dec 16 2022
Dec 14 2022
Dec 11 2022
I can do this if we want. I have some experience with there being a vue version of the javascript separate from the non-vue version, and allowing switching between the two, but perhaps it would be easier if for now we don't change Special:NewPagesFeed at all and instead create the new version at, eg, Special:VueNewPagesFeed and then when the time comes simply rename it?
Dec 10 2022
Dec 9 2022
Okay, thanks for explaining
Dec 8 2022
Dec 7 2022
Dec 6 2022
Happy to tackle this myself just wanted to make sure I wasn't missing anything with removing the fallback, if its okay with the performance team I'll send a patch.
Happy to tackle this myself just wanted to make sure I wasn't missing anything with removing the check, if its okay with the performance team I'll send a patch.
Dec 5 2022
If it wasn't clear, from what I recall my Vue version has all of the JavaScript logic for the feed, not just a mockup - it actually works
Dec 3 2022
Dec 2 2022
I'm not around enough to tackle this myself, but a while ago I wrote a Special:NewPagesFeed implementation in vue at https://en.wikipedia.org/wiki/User:DannyS712/VueNPP.js that uses WVUI but should be easy to switch to Codex - as far as I recall it results in as close to the same look and feel as the current jQuery version, feel free to try it out by navigating to Special:BlankPage/VueNPP
Nov 26 2022
Sep 23 2022
Aug 20 2022
Aug 18 2022
I already created the infrastructure for this in my patch for T314236: docs: Add configurable Card demo which adds support for a "thumbnail" property type, once that patch is merged I'll add a configurable Thumbnail demo
Aug 17 2022
T309899: Document how to build documentation within fresh node would also help make it easier to contribute
Aug 4 2022
Aug 3 2022
Jul 31 2022
Jul 30 2022
Just came across this while creating a configurable demo for the Card component. I suggest for changing once the image is loaded that the default be to show a placeholder, but that this can be overridden with a prop to still show the old icon. Also, perhaps the placeholder shown while reloading should be different from the placeholder before the first load, like cdxIconReload?
Can this be made public now?
Jul 27 2022
For a further optimization using string concatenation instead of an array, I ran a modified version of the code above, posting here for reference
var now = performance.now.bind( performance );
Jul 26 2022
Jul 21 2022
Please consider prioritizing T309899: Document how to build documentation within fresh node - we should not encourage new developers to be installing and running NPM scripts directly, https://timotijhof.net/posts/2019/protect-yourself-from-npm/
Jul 20 2022
Fixed with an onwiki edit in my capacity as a global sysop (grants interface admin rights as well), https://ace.wikipedia.org/wiki/Special:Diff/137538
Jul 14 2022
Jul 8 2022
As far as I can tell Database::select() is not used in GlobalWatchlist, see codesearch https://codesearch.wmcloud.org/deployed/?q=select%5C(&i=nope&files=&excludeFiles=&repos=mediawiki/extensions/GlobalWatchlist - is there something I'm missing?