Page MenuHomePhabricator

DannyS712
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2018, 9:15 PM (187 w, 18 h)
Availability
Available
LDAP User
Unknown
MediaWiki User
DannyS712 [ Global Accounts ]

Recent Activity

Today

DannyS712 added a comment to T308995: wikibugs has stopped showing phab/gerrit comments on IRC as of 2022-05-22Z17:00.

Wikibugs just joined #wikimedia-operations

Mon, May 23, 3:48 PM · SRE, Wikibugs
DannyS712 created P28305 PageTriage cleanup notes.
Mon, May 23, 9:09 AM
DannyS712 updated the task description for T309001: PageTriage JavaScript code audit and cleanup.
Mon, May 23, 8:50 AM · Patch-For-Review, User-DannyS712, PageCuration, Growth-Team
DannyS712 created T309001: PageTriage JavaScript code audit and cleanup.
Mon, May 23, 8:50 AM · Patch-For-Review, User-DannyS712, PageCuration, Growth-Team
DannyS712 added a comment to T308933: Drop flaggedpage_config.fpc_select column on wmf wikis.

Both are done.

Mon, May 23, 6:44 AM · Blocked-on-schema-change, DBA
DannyS712 added a comment to T308933: Drop flaggedpage_config.fpc_select column on wmf wikis.

@Ladsgroup has the schema change already been applied to production? Or is it just the views that were updated

Mon, May 23, 6:38 AM · Blocked-on-schema-change, DBA

Yesterday

DannyS712 added a comment to T250421: CodeReview should run phan if it's going to remain in production.

Cross link T116948, seems like there will be work soon to remove from WMF so this won't be needed

Sun, May 22, 5:46 AM · Patch-For-Review, phan, MediaWiki-extensions-CodeReview
DannyS712 committed rETST3c2a967d65ec: build: Updating dependencies (authored by LibUp-bot).
build: Updating dependencies
Sun, May 22, 1:39 AM

Sat, May 21

DannyS712 added a comment to T308903: Autorship data missing from userspace pages?.

It looks like its been that way since it was first added in https://github.com/x-tools/xtools/commit/e7f46030de93babbbdd311b2911f82a2f3fb24dc

Sat, May 21, 11:26 AM · XTools

Fri, May 20

DannyS712 added a comment to T308520: Standardize JEST unit test names and definition.

Simplify tests by moving reusable setup

Fri, May 20, 2:12 AM · Codex, Design-Systems-Team

Thu, May 19

DannyS712 added a project to T308496: Consider using library-upgrader to manage Vue-related dev dependencies: LibUp.
Thu, May 19, 5:28 AM · LibUp, Design-Systems-Team
DannyS712 closed T304042: Add icon toggles to button demos as Declined.

Superseded by rDCOD27ce23c3d864: docs: Allow configuring icons used as slot contents where there is an icon picker for a slot icon (any that the user wants) instead of a toggle

Thu, May 19, 5:11 AM · Design-Systems-Team, Codex
DannyS712 closed T304042: Add icon toggles to button demos, a subtask of T304527: Clean up doc pages with configurable demos, as Declined.
Thu, May 19, 5:11 AM · Design-Systems-team-20200324-20220422, Codex
DannyS712 added a comment to T300659: Design Divider component.

The figma spec linked in the description says that the file is not found (perhaps it needs to be made public?)

Thu, May 19, 5:09 AM · Design-Systems-Team, Design, Codex
DannyS712 added a comment to T306025: Add Button Group component to Codex.

The figma spec linked in the description says that the file is not found (perhaps it needs to be made public?)

Thu, May 19, 5:08 AM · Codex, Design-Systems-Team
DannyS712 placed T295174: Add ProgressBar component to Codex up for grabs.

Unclaiming for the work on a determinate variant

Thu, May 19, 5:07 AM · User-DannyS712, Design-Systems-Team (Design-Systems-Sprint), Codex
DannyS712 added a comment to T295177: Add ProgressBar component with only the indeterminate state.

@AnneT can this be closed?

Thu, May 19, 5:07 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 closed T306581: Handle icons correctly in sample code generation as Resolved.
Thu, May 19, 5:07 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 closed T306581: Handle icons correctly in sample code generation, a subtask of T304042: Add icon toggles to button demos, as Resolved.
Thu, May 19, 5:06 AM · Design-Systems-Team, Codex
DannyS712 moved T305396: Create a configurable demo for MenuItem from Next to Awaiting review and deployment on the User-DannyS712 board.
Thu, May 19, 5:06 AM · Patch-For-Review, User-DannyS712, Design-Systems-Team, Codex
DannyS712 added a project to T308715: Message demo: 'Close' is not the default for dismiss button label: Design-Systems-Team (Design-Systems-Sprint).
Thu, May 19, 3:47 AM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex
DannyS712 changed the status of T308715: Message demo: 'Close' is not the default for dismiss button label from Open to In Progress.
Thu, May 19, 3:47 AM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex
DannyS712 created T308715: Message demo: 'Close' is not the default for dismiss button label.
Thu, May 19, 12:42 AM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex

Wed, May 18

DannyS712 changed the status of T285732: Remove $wgUser fallback in WikiPage::prepareContentForEdit() from Stalled to Open.
Wed, May 18, 9:29 PM · MW-1.39-release, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 changed the status of T285732: Remove $wgUser fallback in WikiPage::prepareContentForEdit(), a subtask of T285731: Remove core fallbacks to global $wgUser [1.39], from Stalled to Open.
Wed, May 18, 9:29 PM · MW-1.39-release, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 changed the status of T286139: Remove WikiPage::doEditContent in 1.39 from Stalled to In Progress.
Wed, May 18, 9:24 PM · Patch-For-Review, MW-1.39-release, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 changed the status of T286139: Remove WikiPage::doEditContent in 1.39, a subtask of T285731: Remove core fallbacks to global $wgUser [1.39], from Stalled to In Progress.
Wed, May 18, 9:24 PM · MW-1.39-release, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 added a project to T308681: [Epic] Ensure Codex components compliance with WCAG level AA: Epic.
Wed, May 18, 9:17 PM · Epic, Design-Systems-Team, Accessibility, Codex

Mon, May 16

DannyS712 updated the task description for T268156: Partial blocks from namespaces are displayed odd.
Mon, May 16, 5:26 AM · Anti-Harassment, User-DannyS712, CheckUser, MediaWiki-Blocks

Wed, May 11

DannyS712 merged T308081: CentralAuth reporting the wrong account creation times into T138145: Clarify the "registered" date in CentralAuth (date is about connecting to SUL, not the actual account registration date).
Wed, May 11, 1:40 AM · MediaWiki-extensions-CentralAuth
DannyS712 merged task T308081: CentralAuth reporting the wrong account creation times into T138145: Clarify the "registered" date in CentralAuth (date is about connecting to SUL, not the actual account registration date).
Wed, May 11, 1:40 AM · MediaWiki-extensions-CentralAuth

Tue, May 10

DannyS712 added a comment to T301389: Application Security Review Request : Wikistories.

Can I be added as a subscriber to P26128 please? Its currently private

Tue, May 10, 6:24 PM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), user-sbassett, Wikistories (MVP), Inuka-Team, secscrum, Security, Application Security Reviews
DannyS712 added a comment to T307968: Tabs: `aria-activedescendant` is of no value on `role="tablist"`.

While I fully admin I have little experience with ARIA attributes, I *think* that tablist does allow this attribute?

Tue, May 10, 12:54 AM · Accessibility, Design-Systems-Team (Design-Systems-Sprint), Codex

Sun, May 8

DannyS712 merged T307854: LowerCamelFunctionsNameSniff handling of MW core hooks into T273482: `Function name "onRecentChange_save" should use lower camel case` for inherited methods.
Sun, May 8, 10:54 PM · Patch-For-Review, MediaWiki-Codesniffer
DannyS712 merged task T307854: LowerCamelFunctionsNameSniff handling of MW core hooks into T273482: `Function name "onRecentChange_save" should use lower camel case` for inherited methods.
Sun, May 8, 10:53 PM · MediaWiki-Codesniffer
DannyS712 added a comment to T307524: Release mediawiki/mediawiki-codesniffer v39.0.0.

Just crosslinking T266890 for reference on that task (release process)

Sun, May 8, 10:52 PM · Release, MediaWiki-Codesniffer
DannyS712 updated the task description for T307864: A composer dependency of OAuth extension contains PHP 8.0 syntax.
Sun, May 8, 10:51 PM · MediaWiki-extensions-OAuth, MW-1.37-release
MGChecker awarded T221922: MassMessage fails to respect a user's partial block a Dislike token.
Sun, May 8, 3:05 PM · MediaWiki-Blocks, MassMessage, Beta-Cluster-reproducible, User-DannyS712

Thu, May 5

DannyS712 added a comment to T204465: Allow users to disable Page Curation's "I have unreviewed a page you curated" message.

+1, just came to try and request this myself, because I run a bot that marks pages as reviewed and when they are unreviewed it doesn't help to report it to the bot

Thu, May 5, 5:41 PM · Growth-Team-Filtering, Growth-Team, PageCuration

Wed, May 4

DannyS712 added projects to T307631: client-side CSS appears to be using LESS syntax, which breaks in web browsers : OOUI, CSS.
Wed, May 4, 9:21 PM · CSS, OOUI
DannyS712 added a comment to T307617: IP Masking.

There is a Legal directive to move away from storing and publishing IP addresses on Wikimedia sites for all users.

This is the first I've heard of a directive not to store IP addresses - is this correct? How will users with advanced rights be able to unveil the IP if it is not stored?

Wed, May 4, 9:20 PM · IP Masking, tech-decision-forum

Tue, May 3

DannyS712 removed a project from T201491: Fix common typos in code: User-DannyS712.
Tue, May 3, 3:37 PM · MW-1.39-notes (1.39.0-wmf.13; 2022-05-23), Wikimedia-Hackathon-2022, MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), MW-1.37-notes (1.37.0-wmf.20; 2021-08-23), Epic, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), MW-1.35-notes, Patch-For-Review, Google-Code-in-2019, Google-Code-in-2018, patch-welcome, good first task

Mon, May 2

DannyS712 committed rLTFR7d03bd8b004d: Allow rebasing mediawiki/core patches (authored by DannyS712).
Allow rebasing mediawiki/core patches
Mon, May 2, 5:50 PM
DannyS712 placed T295177: Add ProgressBar component with only the indeterminate state up for grabs.

Do you mean the border? The inner bar has a height of 16px, and then the outer wrapper has a 1px border on all sides, for the total 18px height. Are you saying to reduce the inner bar to 14px so that the border brings it to 16?

@DannyS712 I mean a 16px inner bar with a 1px stroke outline inside (instead of outside) so the progress bar heigh is not 18px but 16px. Something similar to TextInput outline.

Mon, May 2, 4:49 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 moved T305396: Create a configurable demo for MenuItem from Unsorted to Next on the User-DannyS712 board.

I'll wait until after T306581: Handle icons correctly in sample code generation merges to be able to configure the icon as well

Mon, May 2, 4:37 PM · Patch-For-Review, User-DannyS712, Design-Systems-Team, Codex
DannyS712 claimed T305396: Create a configurable demo for MenuItem.
Mon, May 2, 4:36 PM · Patch-For-Review, User-DannyS712, Design-Systems-Team, Codex

Sat, Apr 30

DannyS712 added a comment to T306856: Add placeholder attribute to configurable TextInput demo.

@DannyS712 @Volker_E if this is in progress, could you please add the "In Progress" tag? If it's being worked on, then it would be appropriate to add to the current Sprint. Otherwise, we should add it to the "Up Next" column on our team board.

Sat, Apr 30, 3:37 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex

Fri, Apr 29

DannyS712 updated the task description for T304062: Codex Demo Documentation Improvements.
Fri, Apr 29, 7:53 PM · Documentation, Design-Systems-Team, Epic, Codex
DannyS712 updated subscribers of T306581: Handle icons correctly in sample code generation.

@bmartinezcalvo though this is currently in the "code review" column, the patch is stalled on some design review before being merged. Would you mind taking a look? You can see the result of the patch at https://785354--wikimedia-codex.netlify.app/components/text-input.html#demos

Fri, Apr 29, 7:53 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 added a comment to T295177: Add ProgressBar component with only the indeterminate state.

@DannyS712 I've done the Design Review of the component and I found one correction to do:

  1. Component height should be 16px. Now it has 18px because it seems that the outline is outside the component instead of inside (we always use outline inside the component to avoid to increase the height of the element)

Captura de pantalla 2022-04-28 a las 18.54.03.png (536×766 px, 51 KB)

I'm going to create the Design Review checklist with this correction.

Fri, Apr 29, 7:30 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 removed a project from T307243: Add the MWStake logo (and link) to the footer of MediaWiki software: LogoFunctions.

LogoFunctions is about an extension unrelated to the request

Fri, Apr 29, 6:09 PM
DannyS712 added a comment to T307243: Add the MWStake logo (and link) to the footer of MediaWiki software.

Given that: MWStake is on track to manage future MediaWiki releases for the WMF

Fri, Apr 29, 6:08 PM
DannyS712 awarded T307243: Add the MWStake logo (and link) to the footer of MediaWiki software a Dislike token.
Fri, Apr 29, 6:08 PM

Thu, Apr 28

DannyS712 added a comment to T307129: Add options to UserDef to avoid potentially dangerous fallbacks.

These were introduced in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/703416 and haven't changed since then.

The use of UserIdentityValue was introduced then, but I made sure to match the existing behavior with User objects that had the same results as close as possible - see 825064fa759c21d22dae3535d60b80f47f04b42b where I added regression tests for the old behavior with user objects:

Thu, Apr 28, 7:45 PM · Platform Engineering, Technical-Debt, MediaWiki-Action-API, MediaWiki-REST-API
DannyS712 closed T306941: MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic false positive as Resolved.
Thu, Apr 28, 4:14 PM · User-DannyS712, MediaWiki-Codesniffer

Wed, Apr 27

DannyS712 added a comment to T304423: Update Contributing code documentation in Codex Demo.

New component, bug or component improvement tickets should be added to the 'Needs Triage (Incoming Requests)' column in the Codex Phabricator Workboard.

Wed, Apr 27, 4:15 PM · Codex, Design-Systems-team-20200324-20220422 (Design Systems Team FY2021-22 Kanban Board)
DannyS712 added a comment to T306952: Request for admin permission on {wikidata, meta} beta cluster.

@DannyS712 Hmm, is wikidata, not meta...

Wed, Apr 27, 3:02 AM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 closed T306952: Request for admin permission on {wikidata, meta} beta cluster as Resolved.

Done

Wed, Apr 27, 2:57 AM · User-DannyS712, Beta-Cluster-Infrastructure
DannyS712 added a comment to T295177: Add ProgressBar component with only the indeterminate state.

@DannyS712 thanks for your feedback from a volunteer's perspective. Our goal is to provide an intake and tracking process that is maintainable for the team and also intuitive for all contributors to participate in. When we revisited this, we knew that the Codex board was super out of date, which was an indicator to us that maintaining statuses in multiple locations is not maintainable manually.

Makes sense, though it hasn't (to me at least) been a big deal elsewhere. But my biggest point is that if you were going to use one location, it should have been the Codex board rather than a DST board

I'll revisit this topic in the team; there are a few paths forward. Ideally I'd like to have a column of "Open" issues that are free for volunteers to grab, and track status within our sprints if feasible.

This makes sense for status within the DST board but it should also be visible in the codex board - right now I've seen some tasks where the title was updated to reflect the status, which is a bit helpful but columns were more useful

We're actively iterating on this, so thanks for your patience. We welcome any and all volunteer contributions but are not actively seeking more until we sort all of this out, for the reasons you've stated, and also to focus on completing our prototype iterations. I've created a task T306857: Workflow for volunteer/cross-team contributions to track progress on improving this workflow. Thank you!

Happy to help

Wed, Apr 27, 2:07 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 merged T306946: Unable to edit any page on beta cluster into T306878: TypeError: Argument 1 passed to MediaWiki\Auth\Throttler::__construct() must be of the type array or null, integer given .
Wed, Apr 27, 2:07 AM · MW-1.39-notes (1.39.0-wmf.10; 2022-05-02), MediaWiki-libs-Services, MediaWiki-Authentication-and-authorization, Beta-Cluster-reproducible
DannyS712 merged task T306946: Unable to edit any page on beta cluster into T306878: TypeError: Argument 1 passed to MediaWiki\Auth\Throttler::__construct() must be of the type array or null, integer given .
Wed, Apr 27, 2:07 AM · Beta-Cluster-Infrastructure, Wikimedia-production-error
DannyS712 added a comment to T306856: Add placeholder attribute to configurable TextInput demo.

The text input demo already includes a note

This component will pass any HTML attributes applied to it, except for CSS class, to the <input> element within the component.

so it might make sense to list the HTML attributes separately, but for now just added as a normal prop

Wed, Apr 27, 2:03 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 claimed T306856: Add placeholder attribute to configurable TextInput demo.
Wed, Apr 27, 2:01 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 added a comment to T303899: Public codex code coverage report.

Hmm, doesn't appear to be visible at https://doc.wikimedia.org/cover/ yet?

Wed, Apr 27, 2:00 AM · Design-Systems-Team, Test-Coverage, Continuous-Integration-Config, Codex, User-DannyS712
DannyS712 added a comment to T306941: MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic false positive.

key() doesn't have parameters, but offsetGet() does, and functions that do not start with "get" and have no parameters do not require documentation, per 42f4c82601e70e7a6ec6697253ab2bbae67e93a2

Wed, Apr 27, 1:30 AM · User-DannyS712, MediaWiki-Codesniffer

Mon, Apr 25

DannyS712 added a comment to T295177: Add ProgressBar component with only the indeterminate state.

Since this is as good a place as any, @ldelench_wmf why were the column from the Codex workboard all hidden, and everything moved into "Open Tasks"? This makes it a lot harder to figure out what is going on and the current state of each ticket

Hi @DannyS712, thanks for your question (and all of your contributions to Codex!) and apologies for any confusion this caused.
We found it was inefficient & confusing for Design Systems to track task statuses on multiple boards, so all our active work is now tracked in one place: Design-Systems-Sprint. We have been pulling your assigned tasks for Code Review & Design Review into that board as we go.
Let me know if there's a need we're not meeting with this current approach & I'll add it as a topic for our retrospective.

Mon, Apr 25, 11:43 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex

Sun, Apr 24

DannyS712 removed a project from T296215: Sub-settings, confusing experience: Codex.

Appears unrelated to codex (which isn't even in use yet)

Sun, Apr 24, 4:17 AM · Talk Pages
DannyS712 updated subscribers of T295177: Add ProgressBar component with only the indeterminate state.

Since this is as good a place as any, @ldelench_wmf why were the column from the Codex workboard all hidden, and everything moved into "Open Tasks"? This makes it a lot harder to figure out what is going on and the current state of each ticket

Sun, Apr 24, 4:15 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 closed T305278: Replace LTR/RTL buttons on docs site with ToggleButtons, a subtask of T304062: Codex Demo Documentation Improvements, as Resolved.
Sun, Apr 24, 4:13 AM · Documentation, Design-Systems-Team, Epic, Codex
DannyS712 closed T305278: Replace LTR/RTL buttons on docs site with ToggleButtons as Resolved.
Sun, Apr 24, 4:13 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 moved T306581: Handle icons correctly in sample code generation from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Sun, Apr 24, 3:59 AM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex

Apr 23 2022

Ahecht awarded T120794: Create redirect when moving modules a Like token.
Apr 23 2022, 5:49 AM · Platform Engineering (Icebox), User-notice, Contributors-Team, User-DannyS712, Patch-For-Review, MediaWiki-extensions-Scribunto

Apr 21 2022

DannyS712 claimed T306581: Handle icons correctly in sample code generation.
Apr 21 2022, 8:01 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 moved T305278: Replace LTR/RTL buttons on docs site with ToggleButtons from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Apr 21 2022, 8:01 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 moved T305278: Replace LTR/RTL buttons on docs site with ToggleButtons from Open Tasks to Review (code & design) on the Codex board.
Apr 21 2022, 8:00 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 claimed T305278: Replace LTR/RTL buttons on docs site with ToggleButtons.
Apr 21 2022, 6:31 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 updated subscribers of T306568: Incorrect fix for MediaWiki.PHPUnit.AssertEquals.

@thiemowmde added these in c7256b0c68708fbd2c950c4e1ce172fe27d87e15

  • assertNotEquals() as well as assertNotSame() with a boolean value is not wrong, but highly confusing. Replace with assertTrue/False().
Apr 21 2022, 6:05 PM · MW-1.39-notes (1.39.0-wmf.9; 2022-04-25), MediaWiki-Codesniffer
DannyS712 added a comment to T306581: Handle icons correctly in sample code generation.

I plan to investigate adding a configurable icon to the wrapper in the next few days

Apr 21 2022, 6:00 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 added a comment to T306573: Copy button in Codex demos copies extra newline in Chrome.

Our use of document.execCommand( 'copy' ) might need to be reconsidered, since it is marked as deprecated, https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand

Apr 21 2022, 5:58 PM · good first task, Design-Systems-Team, Codex

Apr 19 2022

DannyS712 added a comment to T295179: Add ToggleButton component to Codex.

@DannyS712 I've done the Design Review of the component demo and I found some corrections:

  1. We need to add toggled-on-hover and toggled-on-active too for normal button to indicate the user the interaction when the user wants to turn off the button again.

Captura de pantalla 2022-04-19 a las 13.05.51.png (380×1 px, 132 KB)

  1. Disabled toggled-on (normal button) still has wrong styles. It should be exactly the same as disabled toggled-off. Quiet disabled states are ok.

Captura de pantalla 2022-04-19 a las 13.04.18.png (688×1 px, 272 KB)

Apr 19 2022, 6:44 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex
DannyS712 added a comment to T305890: Move the #acl_security_volunteer policy outside of #acl_security.

This fights the model of phabricator a bit. Quoting the phab docs:

...

Phabricator's philosophy here is that it's hard to understand the intent of adding a tag.

I can sympathize with that, sure. But this is a use-case that upstream folks likely didn't envision (I find it bizarre myself) but due to certain legal constraints and risk acceptance by various leadership levels at the WMF, is really the only path forward that the Security-Team has found to provide more volunteer and community contributors access to a set of security-protected tasks in relation to the all-or-nothing status quo. This approach was outlined a bit in T305731 and discussed more thoroughly within T302686 and T298997. I'm also happy to have a more in-depth chat with anybody to further discuss or work through solutions for this issue.

Apr 19 2022, 6:41 PM · SecTeam-Processed, Release-Engineering-Team (Radar), Project-Admins, Phabricator, Security, Security-Team

Apr 18 2022

DannyS712 added a comment to T157658: Factor out a backend from EditPage.

What's the status of this task? I would very much like to see EditPage go away, and I may be able to help with CR. The main patch is a few months old and out-of-date, at the point that it may be easier to start over. I also wonder if it would make more sense to split the changes into multiple patches, e.g. move everything as static methods in another file, then make everything non-static, inject dependencies, clean up etc., so that it's easier to review and it's less likely for things to break (which remains quite likely, given that we're talking about EditPage).

Apr 18 2022, 6:34 PM · MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (External Code Reviews), Patch-For-Review, Platform Engineering Roadmap Decision Making, User-DannyS712, MediaWiki-Page-editing

Apr 17 2022

DannyS712 moved T295177: Add ProgressBar component with only the indeterminate state from Doing to Review (code & design) on the Codex board.
Apr 17 2022, 9:11 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex
DannyS712 moved T295177: Add ProgressBar component with only the indeterminate state from Next to Awaiting review and deployment on the User-DannyS712 board.
Apr 17 2022, 9:10 PM · Design-Systems-Team (Design-Systems-Sprint), User-DannyS712, Codex

Apr 15 2022

DannyS712 awarded T306248: Consider storing a users real name in user properties a Like token.
Apr 15 2022, 5:13 PM · MediaWiki-User-preferences, MediaWiki-User-management, Platform Engineering

Apr 7 2022

DannyS712 changed the status of T120794: Create redirect when moving modules from Stalled to In Progress.

Just to be clear, on why I added this task to the Platform Engineering Icebox. We acknowledge the existence of this task but progress on it is unlikely. If anyone can walk through the urgency/priority that would be helpful.

Others are welcome to work on it or help to get it merged.

Apr 7 2022, 7:19 PM · Platform Engineering (Icebox), User-notice, Contributors-Team, User-DannyS712, Patch-For-Review, MediaWiki-extensions-Scribunto

Apr 6 2022

DannyS712 reassigned T304894: VitePress docs link handlers introduce unwanted behavior into component demos from DannyS712 to Catrope.
Apr 6 2022, 2:48 AM · Upstream, Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint)

Apr 5 2022

DannyS712 committed rLTFRbf6a3b081100: Allow rebasing mediawiki/extensions/Scribunto patches (authored by DannyS712).
Allow rebasing mediawiki/extensions/Scribunto patches
Apr 5 2022, 10:13 PM
DannyS712 added a comment to T295179: Add ToggleButton component to Codex.

Okay, for the quiet version I'll have disabled be the same for toggled-on and toggled-off

Apr 5 2022, 8:53 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex

Apr 4 2022

DannyS712 created T305340: Make user_editcount field unsigned.
Apr 4 2022, 4:22 AM · MW-1.39-notes (1.39.0-wmf.12; 2022-05-16), Patch-For-Review, MediaWiki-General, Schema-change, User-DannyS712
DannyS712 added a comment to T305329: User with negative edit count.

That and UserEditTracker::initializeUserEditCount() only does revision anyway...

Apr 4 2022, 4:20 AM · WMF-General-or-Unknown

Apr 3 2022

DannyS712 added a comment to T305329: User with negative edit count.
MariaDB [itwiki]> select * from actor where actor_user = 110871;
+----------+------------+-----------------------+
| actor_id | actor_user | actor_name            |
+----------+------------+-----------------------+
|   272621 |     110871 | Tetesco sotto il sale |
+----------+------------+-----------------------+
1 row in set (0.001 sec)

MariaDB [itwiki]> select count(*) from revision where rev_actor = 272621;
+----------+
| count(*) |
+----------+
|       88 |
+----------+
1 row in set (0.002 sec)

And the fix:

MariaDB [itwiki]> UPDATE user SET user_editcount=88 where user_id = 110871;
Query OK, 1 row affected (0.003 sec)
Rows matched: 1  Changed: 1  Warnings: 0
Apr 3 2022, 9:23 PM · WMF-General-or-Unknown
DannyS712 awarded T305329: User with negative edit count a The World Burns token.
Apr 3 2022, 9:21 PM · WMF-General-or-Unknown

Apr 1 2022

DannyS712 moved T305265: Update herald rule for Stang from To Triage to Herald rules on the Phabricator board.

The rule appears to be {H188} - you should be able to update it yourself

Apr 1 2022, 11:07 PM · Phabricator
DannyS712 added a comment to T295179: Add ToggleButton component to Codex.

If you go to https://doc.wikimedia.org/codex/main/components/toggle-button.html, hit the button to toggle it on, and then disable the button, you can see that the disabled state still reflects that it was toggled on. I would expect that the quiet version also reflects whether it is toggled on or toggled off when it is disabled

I hadn't realized when I did the Design Review of the demo but this design of the button when you disable it while toggled is not correct and should be fixed:

Captura de pantalla 2022-04-01 a las 11.35.05.png (992×1 px, 417 KB)

We don't want the disabled state for toggled-on is different for not toggled. Disabled buttons for both toggled and not toggled should be the same disabled button (that matches the rest of disabled on all our button):

Captura de pantalla 2022-04-01 a las 11.31.32.png (1×1 px, 1 MB)

Both normal and quiet buttons won't display a different disabled state for toggled and not toggled.

Apr 1 2022, 10:58 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex

Mar 31 2022

DannyS712 added a comment to T295179: Add ToggleButton component to Codex.

I mean I don't see the spec for the button when it is both toggled on *and* disabled

@DannyS712 do you mean the state Toggle-on Disabled? This design doesn't exist since we always use the same Disabled button for all button variants (Primary, Normal or Quiet). I mean, we don't have specific design for disabled outline buttons and disabled solid buttons, so we should use the same solid disabled button for both toggled disabled and toggled-on disabled.

Captura de pantalla 2022-03-31 a las 19.15.53.png (1×2 px, 511 KB)

Captura de pantalla 2022-03-31 a las 19.15.59.png (1×2 px, 507 KB)

Mar 31 2022, 9:45 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex
DannyS712 added a comment to T222042: Add sniff to require trailing commas in multiline arrays.

Reopening, since trailing commas keep coming up in places where they’re uncontroversial (e.g. resources.php file or message lists), but get forgotten because there’s no automatic sniff/fix for them. I did an informal poll among Wikibase developers, and it seems like we have consensus to enable such a rule there. I think the implementation of the sniff should live in the MediaWiki codesniffer; it doesn’t have to be included in the default ruleset, but it should be available for individual repositories if the developers there decide on it. Whether we want to enable it on our largest shared code base (MediaWiki core) is a different question, and if that’s more controversial then I’m happy to leave that alone for now.

@DannyS712 do you still have the code that you wrote at the time? The built-in ArrayDeclarationSniff still seems to be as unsuitable for this purpose as it was three years ago (T222042#5142556), as far as I can tell (the issue to make it more configurable remains open with little progress).

Mar 31 2022, 9:43 PM · MediaWiki-Codesniffer
DannyS712 added a comment to T295179: Add ToggleButton component to Codex.

The figma doesn't appear to include the toggled on and disabled state, can you add it so I know what the quiet version should look like?

Hey @DannyS712 you have in the spec sheet all Normal and Quiet states (view them here):

Captura de pantalla 2022-03-31 a las 11.28.02.png (1×2 px, 674 KB)

Also I've included the guides section for quiet buttons in the beginning of the spec sheet:

Captura de pantalla 2022-03-31 a las 11.33.23.png (842×2 px, 378 KB)

Tell me if you need something more.

Mar 31 2022, 4:00 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex

Mar 30 2022

DannyS712 added a comment to T295179: Add ToggleButton component to Codex.

When i click on the figma link, I'm told "File not found" and

Either this file doesn’t exist or you don’t have permission to view it. Ask the file owner to verify the link and/or update permissions.

@DannyS712 I'm so sorry, I had to give you permission to view the Figma file. I've updated the link permissions so you can view the Figma link.

Mar 30 2022, 10:37 PM · Design-Systems-Team (Design-Systems-Sprint), Patch-For-Review, User-DannyS712, Codex
DannyS712 closed T295184: Add a "copy" button to code samples on the Codex demo site as Resolved.

We will probably need to revisit this when there is an icon prop type for the docs, but for now everything should be copyable :)

Mar 30 2022, 8:35 PM · Design-Systems-team-20200324-20220422 (Design-Systems-Active-Sprint), User-DannyS712, Codex