Page MenuHomePhabricator

DannyS712
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 21 2018, 9:15 PM (133 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DannyS712 [ Global Accounts ]

Recent Activity

Today

FriedrickMILBarbarossa awarded T209749: Allow privileged accounts to determine if an account has enrolled in 2FA a Pterodactyl token.
Fri, May 14, 3:54 AM · Stewards-and-global-tools, MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), Security, User-DannyS712, Security-Team, MediaWiki-extensions-OATHAuth, Trust-and-Safety

Yesterday

DannyS712 closed T267054: GenderCache needs UserNameUtils but that gives a circular dependency / Split MediaWikiTitleCodec into TitleParser and TitleFormatter for proper dependencies? as Resolved.
Thu, May 13, 3:36 AM · User-DannyS712, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Dependency injection

Wed, May 12

DannyS712 added a comment to T282624: Limit IA granting/revoking to stewards only.

@jrbs not sure why you left enwiki off your list, but we'd appreciate being in your announcements list.

Wed, May 12, 9:00 AM · wdwb-tech, Chinese-Sites, Wikidata, Serbian-Sites, Commons, Wiktionary-fr, Stewards-and-global-tools, User-notice, Trust-and-Safety, Wikimedia-Site-requests
DannyS712 added a comment to T267054: GenderCache needs UserNameUtils but that gives a circular dependency / Split MediaWikiTitleCodec into TitleParser and TitleFormatter for proper dependencies?.

I think the User::isValidUserName() call can just be removed. The worst thing that can happen is that the DB will have to search for nonexistent rows. If that's a performance problem, the check can be moved to the caller of GenderCache. But some callers (e.g. ApiPageSet) are getting the inputs from an already validated source.

Wed, May 12, 6:39 AM · User-DannyS712, MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), Platform Team Workboards (Clinic Duty Team), MediaWiki-General, Dependency injection
DannyS712 added a comment to T282624: Limit IA granting/revoking to stewards only.

... Reaching out and getting agreement would be a good idea. There are many wikis with restrictive policies under the understanding that local bureaucrats can indeed add I_Admin.

I assume there are legitimate reasons for this, along the lines of: 1) nothing is making bureaucrats check to make sure 2FA is enabled for interface admins before granting 2) bureaucrats also are not required to have 2FA at present.

This is all true. interface-admin is an extremely powerful right that can cause serious damage. This move is primarily to close any loopholes that have the potential for abuse. Stewards can now check 2FA status for accounts requesting access to this right, per T209749, which as you say, the 'crats cannot.

Wed, May 12, 3:30 AM · wdwb-tech, Chinese-Sites, Wikidata, Serbian-Sites, Commons, Wiktionary-fr, Stewards-and-global-tools, User-notice, Trust-and-Safety, Wikimedia-Site-requests

Mon, May 10

DannyS712 added a comment to T281688: Unblock translatewiki.net deployments (removal of deprecated code which is still in use).

Okay, there is now documentation at https://www.mediawiki.org/wiki/Manual:Revision.php/Migration#Hooks for all of the hook replacements except for ParserFetchTemplate -> BeforeParserFetchTemplateRevisionRecord which I don't understand how to update

Mon, May 10, 6:20 PM · User-DannyS712, Language-Team (Language-2021-April-June), translatewiki.net
Jdlrobson awarded T274616: Use WVUI for Special:GlobalWatchlist a Party Time token.
Mon, May 10, 5:12 PM · Vue.js Migration, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
DannyS712 closed T274616: Use WVUI for Special:GlobalWatchlist, a subtask of T259216: Migrate Special:GlobalWatchlist to Vue, as Resolved.
Mon, May 10, 4:53 PM · User-DannyS712, Goal, Vue.js, MediaWiki-extensions-GlobalWatchlist
DannyS712 closed T274616: Use WVUI for Special:GlobalWatchlist as Resolved.

Forgot to close this earlier - now uses WVUI for everything possible, will continue to update as WVUI gets more features

Mon, May 10, 4:53 PM · Vue.js Migration, MW-1.36-notes (1.36.0-wmf.35; 2021-03-16), User-DannyS712, MediaWiki-extensions-GlobalWatchlist
DannyS712 added a comment to T278857: "build: Updating y18n to 3.2.2" commits didn't all work properly.

What is npm installing on those repos? y18n doesn't show up as vulnerable on https://libraryupgrader2.wmcloud.org/vulns/npm for those repos...?

Mon, May 10, 2:08 PM · User-DannyS712, LibUp
DannyS712 added a comment to T278857: "build: Updating y18n to 3.2.2" commits didn't all work properly.

Seems to have been fine? Please reopen if something is actually wrong.

Mon, May 10, 6:10 AM · User-DannyS712, LibUp
DannyS712 added a comment to T276447: Unhandled exception clicking "Next" button on Notifications page: Rows must have unique IDs. An underlying query may be missing a GROUP BY..

@Aklapper you marked this as having been fixed upstream with a patch merged there - is there a timeline for when that will be deployed to the WMF phabricator instance?

Mon, May 10, 5:33 AM · Phabricator (phabricator-next), Upstream
DannyS712 merged T282400: Exception while accessing second page of notifications in phabricator into T276447: Unhandled exception clicking "Next" button on Notifications page: Rows must have unique IDs. An underlying query may be missing a GROUP BY..
Mon, May 10, 5:32 AM · Phabricator (phabricator-next), Upstream
DannyS712 merged task T282400: Exception while accessing second page of notifications in phabricator into T276447: Unhandled exception clicking "Next" button on Notifications page: Rows must have unique IDs. An underlying query may be missing a GROUP BY..
Mon, May 10, 5:32 AM · Phabricator

Sun, May 9

DannyS712 moved T281688: Unblock translatewiki.net deployments (removal of deprecated code which is still in use) from Unsorted to Others on the User-DannyS712 board.

I'm happy to take a look at patches if you want. A basic migration guide to just fix the Revision uses is dumped below (and I'll probably write this better and post it somewhere easier once the class is fully removed). Doesn't cover all of the hooks, just those that translatewiki uses in extensions as far as I can tell (including those that appear used in semantic mediawiki).

Sun, May 9, 7:09 AM · User-DannyS712, Language-Team (Language-2021-April-June), translatewiki.net
DannyS712 added a project to T281688: Unblock translatewiki.net deployments (removal of deprecated code which is still in use): User-DannyS712.
Sun, May 9, 6:33 AM · User-DannyS712, Language-Team (Language-2021-April-June), translatewiki.net

Thu, May 6

DannyS712 updated the task description for T280808: Decide how to define action block IDs for extension actions.
Thu, May 6, 11:31 PM · MediaWiki-Blocks, Anti-Harassment
DannyS712 added a comment to T280808: Decide how to define action block IDs for extension actions.

Was about to file a ticket for this, but found this task. Added some notes

Thu, May 6, 11:28 PM · MediaWiki-Blocks, Anti-Harassment
DannyS712 added a comment to P15835 (An Untitled Masterwork).

Selecting the user ids for users that have a given mentor, where the user is not a bot, the user is not indefinitely blocked, and the user either registered recently or has an edit. Formatting and order below is kind of ugly

$tables = [ 'growthexperiments_mentor_mentee' ];
$fields = [ 'gemm_mentee_id' ];
$conds = [];
$joins = [];
Thu, May 6, 4:14 PM
DannyS712 added a comment to T282108: Prepare User creation methods for hard deprecation.

Can I suggest not just mass replacing with UserFactory if the uses are eventually going to be replaced with UserIdentityLookup or similar and migrated to UserIdentity/Authority?

Thu, May 6, 2:19 PM · User-Zabe, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)
DannyS712 added a comment to T281991: extensions/OATHAuth - use AbstractAuthenticationProvider ::init, ::postInitSetup instead of the setters of AbstractAuthenticationProvider.

@Vlad.shapik for future reference for these tasks and patches, they are for *replacing uses of the methods* in the different extensions, so the methods can be hard deprecated in core, and should be named accordingly - its confusing to see tasks and patches saying hard deprecate the methods in a bunch of extensions

Thu, May 6, 2:14 PM · MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), MediaWiki-extensions-OATHAuth, Technical-Debt (Deprecation process), Platform Team Workboards (MW Expedition)

Wed, May 5

DannyS712 updated the task description for T272885: Identify existing Vue components in MediaWiki projects.
Wed, May 5, 11:26 PM · Vue.js Migration
DannyS712 committed rEGLW4947241f8762: Fix centering of as-of label (authored by DannyS712).
Fix centering of as-of label
Wed, May 5, 11:06 PM
DannyS712 committed rEGLW8226c1775bca: Fix centering of as-of label (authored by DannyS712).
Fix centering of as-of label
Wed, May 5, 10:12 PM
DannyS712 claimed T281401: PHP Deprecated: Use of User::isIP was deprecated in MediaWiki 1.35. [Called from ApiVisualEditor::execute].
Wed, May 5, 4:42 PM · User-DannyS712, MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (MW Expedition), MediaWiki-User-management, Wikimedia-production-error
DannyS712 committed rEMTD95db972a1b98: build: Updating composer dependencies (authored by LibUp-bot).
build: Updating composer dependencies
Wed, May 5, 4:11 PM
DannyS712 added a comment to T280719: Show specific block options conditionally for Sitewide and Partial blocks.

From gerrit. reformatted a bit, but its a bit messy

I left a bunch of notes, but in general I don't think this is an improvement to the UI either with or without action blocks being enabled. I created 3 patchdemos for testing (the relevant fourth, no action blocks and without this patch, is just production) [1][2][3] and tried them out - based on my own experience with blocks as a sysop, the old interface was more intuitive. But, that might just be me - can I suggest soliciting feedback from other sysops?
Wed, May 5, 3:43 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-Blocks
DannyS712 committed rEJAD40cb3a7fcc93: build: Updating composer dependencies (authored by LibUp-bot).
build: Updating composer dependencies
Wed, May 5, 5:47 AM
DannyS712 added a comment to T281375: Read only time for extension 1 (x1) primary database on 2021-05-05.

The standard "read only" banned is misleading in this case - the window will not be preventing edits, just a couple of other actions (see task description) - is it too late to clarify this?

Wed, May 5, 5:38 AM · CommRel-Specialists-Support (Apr-Jun-2021)

Tue, May 4

DannyS712 moved T281935: It should be safe to create exceptions without using the global state from Unsorted to Reports on the User-DannyS712 board.
Tue, May 4, 11:21 PM · User-DannyS712, Platform Team Workboards (MW Expedition)
DannyS712 created T281935: It should be safe to create exceptions without using the global state.
Tue, May 4, 11:20 PM · User-DannyS712, Platform Team Workboards (MW Expedition)
DannyS712 updated subscribers of T281923: npm audit security report for parsoid: found 1 high severity vulnerability (Prototype Pollution in "merge" package).
Tue, May 4, 9:15 PM · SecTeam-Processed, Parsoid, User-DannyS712, Security, Security-Team
DannyS712 added a project to T281923: npm audit security report for parsoid: found 1 high severity vulnerability (Prototype Pollution in "merge" package): Parsoid.
Tue, May 4, 9:13 PM · SecTeam-Processed, Parsoid, User-DannyS712, Security, Security-Team
DannyS712 created T281923: npm audit security report for parsoid: found 1 high severity vulnerability (Prototype Pollution in "merge" package).
Tue, May 4, 9:12 PM · SecTeam-Processed, Parsoid, User-DannyS712, Security, Security-Team
DannyS712 added a comment to T280719: Show specific block options conditionally for Sitewide and Partial blocks.

Something I noticed testing a different patch on patchdemo (without this redesign, but with action blocks enabled):

Tue, May 4, 9:01 PM · Patch-For-Review, Anti-Harassment (The Letter Song), MediaWiki-Blocks
DannyS712 added a comment to T247143: Remove the Revision class [1.37].

Okay, we're getting close! Current status:
First couple patches, removing the hooks that use Revision objects and starting to remove deprecated support for Revision in other places, has already merged and will go out with the train.
Next batch is ready to go, but I'm waiting until after the train to split them up a bit. Once https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683964 merges, the only remaining use of Revision in core will be in the Revision class itself, and in its tests. At that point

  • update extensions that, like core, supported deprecated Revision object parameters: Wikibase (repo), EntitySchema, and Parsoid
  • Wait for a new version of Parsoid to be tagged and deployed to vendor
  • Wait at least a week since the rest of the changes to remove the uses of the Revision class in core

Then we can merge the actual removal (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684071)

Tue, May 4, 8:36 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Parsoid (Tracking), Wikidata, MediaWiki-extensions-WikibaseRepository, Shape Expressions, Platform Team Workboards (MW Expedition), Patch-For-Review, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 updated subscribers of T281146: 1.37.0-wmf.5 deployment blockers.
  1. Risky Patch! 🚂🔥
Tue, May 4, 8:18 PM · User-brennen, Release-Engineering-Team (Doing), Release, Train Deployments
DannyS712 edited projects for T281916: Request membership in extension-LanguageSelector group for Universal Omega, added: Gerrit-Privilege-Requests; removed MediaWiki-Gerrit-Group-Requests.
Tue, May 4, 7:17 PM · Gerrit-Privilege-Requests
DannyS712 added a project to T281910: Analzye if MediaWiki.PHPUni.tAssertionOrder could handle more complex cases: User-DannyS712.
Tue, May 4, 6:50 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 added a comment to T281910: Analzye if MediaWiki.PHPUni.tAssertionOrder could handle more complex cases.

We can use some of the logic in AssertCountSniff to skip past the first parameter - will try to work on this soon

Tue, May 4, 6:50 PM · User-DannyS712, MediaWiki-Codesniffer
DannyS712 committed rECPW16c0ddf6c193: build: Updating composer dependencies (authored by LibUp-bot).
build: Updating composer dependencies
Tue, May 4, 5:05 PM

Mon, May 3

DannyS712 committed rEWIS26b9eccf015b: SpeechoidConnector: fix typo "resonse" (authored by DannyS712).
SpeechoidConnector: fix typo "resonse"
Mon, May 3, 6:25 AM
DannyS712 closed T281598: Hard deprecate wfCanIPUseHTTPS as Resolved.
Mon, May 3, 3:08 AM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), User-DannyS712, MediaWiki-extensions-CentralAuth, Technical-Debt (Deprecation process)

Sun, May 2

DannyS712 added projects to T247143: Remove the Revision class [1.37]: Parsoid, Shape Expressions, MediaWiki-extensions-WikibaseRepository.
Sun, May 2, 11:10 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Parsoid (Tracking), Wikidata, MediaWiki-extensions-WikibaseRepository, Shape Expressions, Platform Team Workboards (MW Expedition), Patch-For-Review, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 added a comment to T247143: Remove the Revision class [1.37].

Okay, we're getting close! Current status:
First couple patches, removing the hooks that use Revision objects and starting to remove deprecated support for Revision in other places, has already merged and will go out with the train.
Next batch is ready to go, but I'm waiting until after the train to split them up a bit. Once https://gerrit.wikimedia.org/r/c/mediawiki/core/+/683964 merges, the only remaining use of Revision in core will be in the Revision class itself, and in its tests. At that point

  • update extensions that, like core, supported deprecated Revision object parameters: Wikibase (repo), EntitySchema, and Parsoid
  • Wait for a new version of Parsoid to be tagged and deployed to vendor
  • Wait at least a week since the rest of the changes to remove the uses of the Revision class in core

Then we can merge the actual removal (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/684071)

Sun, May 2, 11:10 PM · MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), Parsoid (Tracking), Wikidata, MediaWiki-extensions-WikibaseRepository, Shape Expressions, Platform Team Workboards (MW Expedition), Patch-For-Review, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 committed rEMWC639bddc3bc51: Fix a series of PHPCS and code style issues (authored by thiemowmde).
Fix a series of PHPCS and code style issues
Sun, May 2, 7:33 AM
DannyS712 added a comment to T281145: 1.37.0-wmf.4 deployment blockers.
  1. Risky Patch! 🚂🔥
Sun, May 2, 2:16 AM · User-brennen, Release-Engineering-Team (Doing), Release, Train Deployments

Sat, May 1

DannyS712 renamed T277334: Deprecate the UserLoadFromDatabase hook from Deprecate and remove UserLoadFromDatabase hook to Deprecate the UserLoadFromDatabase hook.
Sat, May 1, 7:07 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (Clinic Duty Team), User-DannyS712, Technical-Debt (Deprecation process)
DannyS712 closed T277334: Deprecate the UserLoadFromDatabase hook as Resolved.
Sat, May 1, 7:06 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), Platform Team Workboards (Clinic Duty Team), User-DannyS712, Technical-Debt (Deprecation process)

Fri, Apr 30

DannyS712 moved T281598: Hard deprecate wfCanIPUseHTTPS from In progress to Awaiting review and deployment on the User-DannyS712 board.
Fri, Apr 30, 7:10 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), User-DannyS712, MediaWiki-extensions-CentralAuth, Technical-Debt (Deprecation process)
DannyS712 moved T281598: Hard deprecate wfCanIPUseHTTPS from Unsorted to In progress on the User-DannyS712 board.
Fri, Apr 30, 6:57 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), User-DannyS712, MediaWiki-extensions-CentralAuth, Technical-Debt (Deprecation process)
DannyS712 moved T281598: Hard deprecate wfCanIPUseHTTPS from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.
Fri, Apr 30, 6:57 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), User-DannyS712, MediaWiki-extensions-CentralAuth, Technical-Debt (Deprecation process)
DannyS712 created T281598: Hard deprecate wfCanIPUseHTTPS.
Fri, Apr 30, 6:57 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), User-DannyS712, MediaWiki-extensions-CentralAuth, Technical-Debt (Deprecation process)
DannyS712 added a comment to T247476: Beta cluster: The content model 'JadeJudgment' is not registered.

Is that error related to jade and its content model? It doesn't look like it TBH

Fri, Apr 30, 5:49 PM · User-Ladsgroup, Patch-For-Review, User-DannyS712, MediaWiki-ContentHandler, Beta-Cluster-Infrastructure, Jade
DannyS712 added a comment to T281072: Mass messages not being delivered.

The original issue for the signpost was resolved after a few hours

Fri, Apr 30, 5:15 PM · Regression, User-DannyS712, MassMessage
DannyS712 added a comment to T247476: Beta cluster: The content model 'JadeJudgment' is not registered.

I can't reproduce the error anymore given that jade is gone. Let's just call it done?

Fri, Apr 30, 5:02 PM · User-Ladsgroup, Patch-For-Review, User-DannyS712, MediaWiki-ContentHandler, Beta-Cluster-Infrastructure, Jade

Thu, Apr 29

DannyS712 updated the task description for T208764: Remove cyclic dependency between Title and User classes.
Thu, Apr 29, 5:49 PM · Platform Team Initiatives (Decoupling (CDP2))
DannyS712 removed a project from T265726: Assign oathauth-verify-user to bureaucrats on WMF wikis: MediaWiki-extensions-OATHAuth.

(this is a configuration change, not a change to the extension itself)

Thu, Apr 29, 5:44 PM · WMF-Legal, Wikimedia-Site-requests, Privacy
DannyS712 committed rEWLCaac782fa4157: Remove unused variable in LexemeHandlerTest (authored by Rosalie_WMDE).
Remove unused variable in LexemeHandlerTest
Thu, Apr 29, 4:26 PM
DannyS712 committed rEBUY77368f0b5df2: Bump required version of MediaWiki to 1.37+ (authored by DannyS712).
Bump required version of MediaWiki to 1.37+
Thu, Apr 29, 11:25 AM

Wed, Apr 28

DannyS712 added a comment to T281400: TypeError: Argument 1 passed to EditPage::displayViewSourcePage() must implement interface Content, null given.

Not sure what the root cause is, but sent a hotfix to replace the php error with a nicer PermissionsError

Wed, Apr 28, 6:48 PM · Patch-For-Review, MediaWiki-Revision-backend, MediaWiki-Page-editing, Platform Team Workboards (Clinic Duty Team), Wikimedia-production-error
DannyS712 added a comment to T281239: Global developer for Zabe on beta.

+1 from me, active developer and trusted on production wikis

Wed, Apr 28, 6:07 PM · User-Zabe, User-Majavah, Beta-Cluster-Infrastructure

Mon, Apr 26

DannyS712 moved T281190: Add a warning when MediaWikiServices is used instead of dependency injection from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Mon, Apr 26, 7:52 PM · Patch-For-Review, MediaWiki-Codesniffer, User-DannyS712
DannyS712 moved T281190: Add a warning when MediaWikiServices is used instead of dependency injection from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Mon, Apr 26, 7:52 PM · Patch-For-Review, MediaWiki-Codesniffer, User-DannyS712
DannyS712 created T281190: Add a warning when MediaWikiServices is used instead of dependency injection.
Mon, Apr 26, 7:51 PM · Patch-For-Review, MediaWiki-Codesniffer, User-DannyS712

Sun, Apr 25

DannyS712 added a comment to T281072: Mass messages not being delivered.
Sun, Apr 25, 8:42 PM · Regression, User-DannyS712, MassMessage
DannyS712 triaged T281072: Mass messages not being delivered as High priority.

Might qualify for UBN, not sure

Sun, Apr 25, 8:31 PM · Regression, User-DannyS712, MassMessage
DannyS712 created T281072: Mass messages not being delivered.
Sun, Apr 25, 8:30 PM · Regression, User-DannyS712, MassMessage
DannyS712 added a comment to T281050: Edit API with appendtext & a contentmodel change gives an internal api error.

So like I say, the failure needs handling better, for sure, maybe some documentation improvements surrounding it...

But using action=edit to handle content model changes might not happen, and I guess it's less likely Fandom would backport it to their version of 1.33

Sun, Apr 25, 7:29 PM · Platform Team Workboards (Clinic Duty Team), MediaWiki-ContentHandler, MediaWiki-API
DannyS712 committed rEWET363d99e68489: ApiQueryWikimediaEditorTasksCounts: remove unneeded factory method (authored by DannyS712).
ApiQueryWikimediaEditorTasksCounts: remove unneeded factory method
Sun, Apr 25, 1:20 PM
DannyS712 updated the task description for T278653: Release mediawiki-codesniffer v36.0.0.
Sun, Apr 25, 1:59 AM · Release, MediaWiki-Codesniffer, User-DannyS712

Sat, Apr 24

DannyS712 added a comment to T280392: Migrate Wikimedia away from OTRS software and branding.

I've marked Rename Phabricator project as done, @Aklapper took care of that https://phabricator.wikimedia.org/project/manage/210/#77240

Sat, Apr 24, 5:38 AM · CommRel-Specialists-Support (Apr-Jun-2021), Znuny, Epic
DannyS712 updated the task description for T280392: Migrate Wikimedia away from OTRS software and branding.
Sat, Apr 24, 5:37 AM · CommRel-Specialists-Support (Apr-Jun-2021), Znuny, Epic

Fri, Apr 23

DannyS712 moved T281008: PHPCS should send a warning when tests don't call parent::setUp(), parent::tearDown(), etc. from Unsorted to Awaiting review and deployment on the User-DannyS712 board.
Fri, Apr 23, 11:01 PM · Patch-For-Review, MediaWiki-Codesniffer, User-DannyS712
DannyS712 moved T281008: PHPCS should send a warning when tests don't call parent::setUp(), parent::tearDown(), etc. from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Fri, Apr 23, 11:01 PM · Patch-For-Review, MediaWiki-Codesniffer, User-DannyS712
DannyS712 created T281008: PHPCS should send a warning when tests don't call parent::setUp(), parent::tearDown(), etc..
Fri, Apr 23, 10:59 PM · Patch-For-Review, MediaWiki-Codesniffer, User-DannyS712
DannyS712 added a comment to T199377: Consider removing page_restrictions.pr_user field from schema.

Given that the PageBlock extension is written by @Legoktm. Let's ping him to see what is the best course of action here.

Fri, Apr 23, 3:34 AM · MediaWiki-General, Patch-For-Review, Schema-change

Thu, Apr 22

DannyS712 committed rECHB6dc8c65215a6: Clean up tests and namespace (authored by DannyS712).
Clean up tests and namespace
Thu, Apr 22, 10:42 PM
DannyS712 renamed T280900: Tag a new release of ObjectFactory from Tag new release to Tag a new release of ObjectFactory.
Thu, Apr 22, 2:01 AM · Release, ObjectFactory
DannyS712 added a comment to T280900: Tag a new release of ObjectFactory.

There is a pending patch (https://gerrit.wikimedia.org/r/c/mediawiki/libs/ObjectFactory/+/676348) to move the code to a new namespace Wikimedia\\ObjectFactory\\ instead of just in Wikimedia\\, suggest including that within the next release (and that would probably warrant making it 3.1.0 instead of 3.0.1)

Thu, Apr 22, 2:01 AM · Release, ObjectFactory
DannyS712 removed a project from T228719: Special:CNReporter renders as a blank page when user is not already on donate.wikimedia.org: User-DannyS712.
Thu, Apr 22, 1:09 AM · Fundraising-Backlog, MediaWiki-extensions-CentralNotice

Wed, Apr 21

DannyS712 added a comment to T280890: PageTriage / Page Curation should allow page creator to mark as unreviewed.

@DannyS712 I think you may have done some related work? I actually though that this was possible in the past? I see that the very similar T22399 has also been ignored for 7 years, preventing any way to unpatrol a page at all - at least the unreview function exists, but seems to be excessively restricted.

Wed, Apr 21, 11:56 PM · Growth-Team, PageCuration
DannyS712 added a comment to T273482: `Function name "onRecentChange_save" should use lower camel case` for inherited methods.

Its impossible for phpcs to know (in the general case) if a method is inherited on not, its just for hooks where the naming is simple that its possible to tell

Then I would argue that phpcs is not the right tool for enforcing style of method names. Perhaps it might be always disabled if the current class is a subclass of anything?

Wed, Apr 21, 2:19 PM · Patch-For-Review, MediaWiki-Codesniffer
DannyS712 added a comment to T273482: `Function name "onRecentChange_save" should use lower camel case` for inherited methods.

@Daimona the patch I sent fixes this for the code that implements these hooks, do we also want to suppress the warning on the interfaces themselves? Or should we leave it to make sure that new hooks being introduced don't have underscores in them?

I recognize that I haven't been sufficiently clear in the task description, but this issue is not just for hooks. The real point is that it's an inherited method. As such, the sniff should:

  • Not warn if the method is inherited from an ancestor class
  • Warn if it isn't
Wed, Apr 21, 12:55 PM · Patch-For-Review, MediaWiki-Codesniffer
DannyS712 closed T245331: Remove core fallbacks to global $wgUser [1.36] as Resolved.

Nothing more to remove before 1.36 is tagged, new work is at T262707: Remove core fallbacks to global $wgUser [1.37]

Wed, Apr 21, 4:18 AM · MW-1.36-release, Technical-Debt (Deprecation process), User-DannyS712, MediaWiki-General
DannyS712 closed T245331: Remove core fallbacks to global $wgUser [1.36], a subtask of T243708: Mediawiki core needs uses of global $wgUser removed, as Resolved.
Wed, Apr 21, 4:18 AM · MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), Epic, Patch-For-Review, User-DannyS712, MediaWiki-General, Technical-Debt

Tue, Apr 20

DannyS712 added a comment to T273482: `Function name "onRecentChange_save" should use lower camel case` for inherited methods.

@Daimona the patch I sent fixes this for the code that implements these hooks, do we also want to suppress the warning on the interfaces themselves? Or should we leave it to make sure that new hooks being introduced don't have underscores in them?

Tue, Apr 20, 10:34 PM · Patch-For-Review, MediaWiki-Codesniffer
DannyS712 moved T273482: `Function name "onRecentChange_save" should use lower camel case` for inherited methods from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.
Tue, Apr 20, 10:31 PM · Patch-For-Review, MediaWiki-Codesniffer
DannyS712 added a comment to T280615: Rename OTRS member global group.

renaming to "permission checker" would be changing the meaning and scope, and should not be bundled with fixing the actual name - instead of "otrs-member" it should be "vrt-member" or whatever the migration group decides

Tue, Apr 20, 5:47 AM · Patch-For-Review, WikimediaMessages, Znuny

Sat, Apr 17

DannyS712 committed rEGTO67946160cdd8: build: Updating eslint-config-wikimedia to 0.20.0 (authored by LibUp-bot).
build: Updating eslint-config-wikimedia to 0.20.0
Sat, Apr 17, 12:41 AM

Fri, Apr 16

DannyS712 reopened T272244: AbuseFilter blocks not working for account autocreations (CVE-2021-31554) as "Open".

It might have been a duplicate, but that other task should probably be merged here since this is where everything is. Plus, there are open patches for this task

Fri, Apr 16, 9:35 PM · MW-1.37-notes (1.37.0-wmf.3; 2021-04-27), Vuln-MissingAuthz, AbuseFilter, Security, Security-Team
DannyS712 added a comment to T54747: Api: Allow creation of new section without header but with summary.

Should be easier to do once T157658: Factor out a backend from EditPage merges

Fri, Apr 16, 7:15 PM · Platform Engineering, MediaWiki-API
DannyS712 added a comment to T278653: Release mediawiki-codesniffer v36.0.0.

Yeah, WFM. Not aware of any open tasks/patches that we should wait for; anyone have a differing opinion?

Might want to wait for https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/673773 from T278010

Fri, Apr 16, 5:58 PM · Release, MediaWiki-Codesniffer, User-DannyS712
DannyS712 updated the task description for T278653: Release mediawiki-codesniffer v36.0.0.
Fri, Apr 16, 5:57 PM · Release, MediaWiki-Codesniffer, User-DannyS712
DannyS712 edited P15397 T170330 (Flow pimple->mediawikiservices) notes.
Fri, Apr 16, 5:55 PM
DannyS712 edited P15397 T170330 (Flow pimple->mediawikiservices) notes.
Fri, Apr 16, 5:24 PM
DannyS712 created P15397 T170330 (Flow pimple->mediawikiservices) notes.
Fri, Apr 16, 5:11 PM
DannyS712 removed a project from T254799: Rename wikimedia/password-blacklist library: Patch-For-Review.
Fri, Apr 16, 3:33 PM · MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), CommonPasswords
DannyS712 committed rTAWR45028431a522: Add tests to cover currently uncovered lines (authored by DannyS712).
Add tests to cover currently uncovered lines
Fri, Apr 16, 12:04 PM
DannyS712 updated subscribers of T280314: discussiontoolssubscribe api should not reuse discussiontoolsedit api documentation for commentname.
Fri, Apr 16, 6:06 AM · DiscussionTools, User-DannyS712