In T163062#3337176, @Liuxinyu970226 wrote:

In T163062#3335220, @Liuxinyu970226 wrote:

@LNDDYL As changing priority is a sensitive action, and in most cases that should reflect reality and not just cause it, would you please explain that why this task is more urgent?

@LNDDYL ^^?

@Acagastya I understand that you have already gained access Tool Labs, and I would recommend you to check out Tool Labs' Help page for further information. You would need to create a Tool account and run your program there, since you cannot run tasks in the login server.

^ after a week of discussion starting 9 Apr: 5 {{support}}, no other opinion.

In T152068#2861484, @gerritbot wrote:

Change 326245 had a related patch set uploaded (by Dargasia):

@jayvdb No, I've got stuff IRL so I abandoned it at the GCI side (which constantly sends me deadline emails), so that I can take my time. Definitely still working on it.

created by your request :) . You can import this into GCI when you get the chance.

T113140 was the previous effort to use requests.

Update:

Maintain a list of problematic sites in the configuration file

This has been worked on, but:

automatic use of fallback logic

I am debating if this should be implemented. Currently I'm thinking of HTTP status codes, but I thought if a server returns something like 403 Forbidden, we should honour it instead. Also in T113596 the website returned 200, but with invalid content.

Thanks!

In T152075#2837739, @jayvdb wrote:

i.e. we would add a use_fake_user_agent parameter to methods in http.comms, which is False by default, True forces a fake user-agent, and None means automatic use of fallback logic (use fake if in the config list, otherwise try with real user-agent, and fallback to fake).

http.comms seems to be used only to get the user_agent, but not for making the requests themselves. Shouldn't this parameter and logic be implemented in the scripts that need fake UAs (i.e. reflinks and weblinkchecker) instead?

This task needs a little analysis to determine why the default is None

None behaves the same way as True (if set a value, UA becomes that value. if False, default UA returned). The default is Introduced since the patch was submitted and unchanged since then.

If T152075 completes, we should remove config.fake_user_agent = None from the test case.

Patch 324633 has been submitted on Geritt, which should resolve this.

PR 179 should solve this. Can you check?

I will be working on this as part of GCI 2016.